12018-03-14T00:00:03 *** weez17 has quit IRC
22018-03-14T00:00:50 *** weez17 has joined #bitcoin-core-dev
32018-03-14T00:06:29 *** dafunkiz_ has joined #bitcoin-core-dev
42018-03-14T00:15:33 *** mangoicedtea has quit IRC
52018-03-14T00:17:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0630974647da...18462960c0f1
62018-03-14T00:17:21 <bitcoin-git> bitcoin/master 33eb907 Russell Yanofsky: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER...
72018-03-14T00:17:21 <bitcoin-git> bitcoin/master 1846296 MarcoFalke: Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER...
82018-03-14T00:18:09 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER (master...pr/locksmart) https://github.com/bitcoin/bitcoin/pull/12681
92018-03-14T00:19:06 <bitcoin-git> [bitcoin] sipa opened pull request #12683: Fix more constness violations in serialization code (master...201803_moreser) https://github.com/bitcoin/bitcoin/pull/12683
102018-03-14T00:22:53 *** CubicEarths has quit IRC
112018-03-14T00:28:21 *** jimbouki has joined #bitcoin-core-dev
122018-03-14T00:28:45 *** CubicEarths has joined #bitcoin-core-dev
132018-03-14T00:29:35 *** arbitrary_guy has quit IRC
142018-03-14T00:31:31 *** Deacyde has joined #bitcoin-core-dev
152018-03-14T00:33:19 *** mangoicedtea has joined #bitcoin-core-dev
162018-03-14T00:35:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
172018-03-14T00:39:05 *** CubicEarths has quit IRC
182018-03-14T00:41:57 *** jimbouki has quit IRC
192018-03-14T00:52:47 *** justanotheruser has quit IRC
202018-03-14T00:54:12 *** meshcollider has joined #bitcoin-core-dev
212018-03-14T00:54:16 *** justanotheruser has joined #bitcoin-core-dev
222018-03-14T00:54:38 *** justanotheruser has quit IRC
232018-03-14T00:54:58 *** justanotheruser has joined #bitcoin-core-dev
242018-03-14T00:54:58 *** jimbouki has joined #bitcoin-core-dev
252018-03-14T00:59:22 *** mangoicedtea has quit IRC
262018-03-14T00:59:59 *** justanotheruser has quit IRC
272018-03-14T01:00:34 *** justanotheruser has joined #bitcoin-core-dev
282018-03-14T01:01:09 *** CapitanRetardo has quit IRC
292018-03-14T01:01:26 *** belcher_ has quit IRC
302018-03-14T01:14:46 *** go1111111 has quit IRC
312018-03-14T01:14:53 *** dafunkiz_ has quit IRC
322018-03-14T01:14:54 *** EpicBaldGuy has quit IRC
332018-03-14T01:20:49 *** schmidty has joined #bitcoin-core-dev
342018-03-14T01:21:13 *** schmidty is now known as Guest75173
352018-03-14T01:22:09 *** Chris_Stewart_5 has quit IRC
362018-03-14T01:22:34 *** dafunkiz_ has joined #bitcoin-core-dev
372018-03-14T01:23:00 *** Giszmo has quit IRC
382018-03-14T01:25:33 *** Guest75173 has quit IRC
392018-03-14T01:28:21 *** jimbouki has quit IRC
402018-03-14T01:28:49 *** Samdney has quit IRC
412018-03-14T01:28:51 *** jimbouki has joined #bitcoin-core-dev
422018-03-14T01:29:33 *** tied2chainz has joined #bitcoin-core-dev
432018-03-14T01:30:09 <tied2chainz> hi
442018-03-14T01:30:41 <tied2chainz> just have a really quick question about version 16.
452018-03-14T01:31:32 *** jimbouki_ has joined #bitcoin-core-dev
462018-03-14T01:31:48 *** BashCo_ has joined #bitcoin-core-dev
472018-03-14T01:32:11 *** jimbouki has quit IRC
482018-03-14T01:32:35 *** BashCo has quit IRC
492018-03-14T01:32:55 <sipa> tied2chainz: shoot
502018-03-14T01:33:12 <sipa> (and generally just ask, don't ask to ask)
512018-03-14T01:34:17 <Randolf> (Slow questions are okay too.)
522018-03-14T01:34:53 *** dafunkiz_ has quit IRC
532018-03-14T01:35:16 <tied2chainz> wanted to know can I also lookup transactions outside of send and receive transactions.
542018-03-14T01:35:23 <sipa> no
552018-03-14T01:35:56 <tied2chainz> only transactions that I've received or sent through my wallet
562018-03-14T01:36:09 <sipa> unless you enable the transaction index (run with -txindex, or put txindex=1 in bitcoin.conf; that will enable the getrawtransaction txid RPC which works for all transactions, not just your own)
572018-03-14T01:36:52 <sipa> it will require a full rebuild of the database though, and slows things down significantly
582018-03-14T01:37:40 <tied2chainz> yeah thanks for the heads
592018-03-14T01:37:45 <eklitzke> interesting, somehow i corrupted my chainstate directory
602018-03-14T01:37:48 <tied2chainz> thanks for the heads up
612018-03-14T01:38:15 <sipa> eklitzke: what did you do?
622018-03-14T01:40:59 <kallewoof> tied2chainz: You can look them up if you know the block hash they're in.
632018-03-14T01:41:10 *** Giszmo has joined #bitcoin-core-dev
642018-03-14T01:41:20 <kallewoof> tied2chainz: Even without -txindex.
652018-03-14T01:41:39 <eklitzke> https://paste.fedoraproject.org/paste/QsExxEOQwQOAGqT1rvPkAw
662018-03-14T01:41:52 <eklitzke> it looks like it shut down normally
672018-03-14T01:41:57 <eklitzke> and then the next time i tried to start it
682018-03-14T01:42:01 <eklitzke> corrupted database
692018-03-14T01:42:19 *** pyericz has joined #bitcoin-core-dev
702018-03-14T01:43:20 <sipa> eklitzke: wow, with a clean shutdown? :S
712018-03-14T01:43:37 <eklitzke> this is actually on v0.16.0, not from my branches
722018-03-14T01:43:40 <eklitzke> hmm
732018-03-14T01:44:06 <eklitzke> interesting, well i had been asking users if they could give me corrupted database files, looks like i got what i was asking for
742018-03-14T01:44:48 *** justanotheruser has quit IRC
752018-03-14T01:45:03 *** pyericz has quit IRC
762018-03-14T01:45:18 *** justanotheruser has joined #bitcoin-core-dev
772018-03-14T01:45:56 *** pyericz has joined #bitcoin-core-dev
782018-03-14T01:48:55 <kallewoof> Am I right that signmessage <addr> leaks the public key of <addr> in the resulting signature?
792018-03-14T01:49:18 <kallewoof> s/leaks/exposes/ I guess.
802018-03-14T01:49:59 *** pyericz has quit IRC
812018-03-14T01:50:24 *** pyericz has joined #bitcoin-core-dev
822018-03-14T01:51:25 *** pyericz has quit IRC
832018-03-14T01:51:35 <eklitzke> actually i remember now what i was doing, the last thing i had been doing with this was running my python utxo scanning script on the data directory
842018-03-14T01:51:45 <eklitzke> s/data directory/chainstate directory/
852018-03-14T01:51:58 <eklitzke> which uses the python leveldb bindings
862018-03-14T01:52:14 <eklitzke> i thought i had the daemon stopped but i guess i could have had it running
872018-03-14T01:52:19 <eklitzke> hopefully i can reproduce
882018-03-14T01:55:31 *** tecneecs has joined #bitcoin-core-dev
892018-03-14T01:55:55 <tecneecs> sup bitcoin?
902018-03-14T01:56:06 *** justanotheruser has quit IRC
912018-03-14T01:56:44 *** justanotheruser has joined #bitcoin-core-dev
922018-03-14T01:59:47 *** pyericz has joined #bitcoin-core-dev
932018-03-14T02:01:40 *** Victorsueca has quit IRC
942018-03-14T02:02:36 *** justanotheruser has quit IRC
952018-03-14T02:03:02 *** LeMiner has quit IRC
962018-03-14T02:03:04 *** justanotheruser has joined #bitcoin-core-dev
972018-03-14T02:03:07 *** Victorsueca has joined #bitcoin-core-dev
982018-03-14T02:03:29 *** pyericz has quit IRC
992018-03-14T02:03:50 *** jimbouki_ has quit IRC
1002018-03-14T02:03:58 *** pyericz has joined #bitcoin-core-dev
1012018-03-14T02:04:04 *** jimbouki has joined #bitcoin-core-dev
1022018-03-14T02:04:57 *** jimbouki has quit IRC
1032018-03-14T02:06:01 <sipa> kallewoof: every ECDSA signature leaks the pubkey (almost)
1042018-03-14T02:09:23 *** pyericz has quit IRC
1052018-03-14T02:10:18 *** pyericz has joined #bitcoin-core-dev
1062018-03-14T02:14:20 *** dabura667 has joined #bitcoin-core-dev
1072018-03-14T02:16:12 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1082018-03-14T02:17:11 <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/18462960c0f1...6acd8700bc0e
1092018-03-14T02:17:12 <bitcoin-git> bitcoin/master a128bdc Russell Yanofsky: [wallet] Construct CWalletTx objects in CommitTransaction...
1102018-03-14T02:17:12 <bitcoin-git> bitcoin/master b4bc32a Russell Yanofsky: [wallet] Get rid of CWalletTx default constructor...
1112018-03-14T02:17:13 <bitcoin-git> bitcoin/master 6acd870 Pieter Wuille: Merge #9680: Unify CWalletTx construction...
1122018-03-14T02:17:43 <kallewoof> sipa: Well, it's sorta like spending an UTXO vs handing out the pubkey for its PKH. One seems worse than the other (though only a little).
1132018-03-14T02:18:03 *** tied2chainz has quit IRC
1142018-03-14T02:18:59 <sipa> kallewoof: but regardless, you can't create a signature without revealing the public key
1152018-03-14T02:20:47 <kallewoof> Yeah, I was initially very confused about how verifymessage could pull it off with only an address, until I realized the signature had a recoverable pubkey in it.
1162018-03-14T02:21:29 <kallewoof> It struck me that people may not realize they are revealing the pubkey when they signmessage a utxo. Clearly as you say, you need the pubkey to verify the sig.
1172018-03-14T02:22:08 <kallewoof> Perhaps it doesn't really matter that you show the pubkey (long) before spending.
1182018-03-14T02:27:06 <luke-jr> kallewoof: hopefully when someone gets around to replacing signmessage, it can be MAST-based with a separate key for messages
1192018-03-14T02:32:18 <kallewoof> luke-jr: Interesting. I'll have to think about how that would work.
1202018-03-14T02:32:57 <sipa> kallewoof: well a decent replacement for signmessage would be something that just uses script
1212018-03-14T02:33:08 <sipa> (but signs something else than a tx)
1222018-03-14T02:33:30 <sipa> that would automatically support any kind of output type
1232018-03-14T02:41:17 *** jimbouki has joined #bitcoin-core-dev
1242018-03-14T02:42:59 <kallewoof> sipa: That makes sense, yeah.
1252018-03-14T02:45:47 *** Aaronvan_ has joined #bitcoin-core-dev
1262018-03-14T02:46:07 <meshcollider> Wasn't someone already working on a BIP draft for an improved signmessage, or am I imagining things
1272018-03-14T02:46:13 *** jimbouki has quit IRC
1282018-03-14T02:46:30 <kallewoof> sipa: Presumably it would sign H(addr||message). Not sure if addr is strictly necessary though.
1292018-03-14T02:48:29 *** Aaronvan_ has quit IRC
1302018-03-14T02:48:34 *** kryptopraxis has quit IRC
1312018-03-14T02:48:57 *** AaronvanW has quit IRC
1322018-03-14T02:49:13 *** Chris_Stewart_5 has quit IRC
1332018-03-14T02:59:12 <luke-jr> meshcollider: at one point, someone was talking about it at least
1342018-03-14T03:00:54 *** kryptopraxis has joined #bitcoin-core-dev
1352018-03-14T03:07:48 <sipa> kallewoof: yup, this is the way to fix it
1362018-03-14T03:13:12 *** mrjenkins has joined #bitcoin-core-dev
1372018-03-14T03:13:23 <mrjenkins> hello!
1382018-03-14T03:14:06 <mrjenkins> why does github repo say that the build is failing?
1392018-03-14T03:14:37 <mrjenkins> does the build is really failing?
1402018-03-14T03:16:41 *** jimbouki has joined #bitcoin-core-dev
1412018-03-14T03:18:50 *** Murch has quit IRC
1422018-03-14T03:21:55 *** schmidty has joined #bitcoin-core-dev
1432018-03-14T03:22:10 *** pyericz has quit IRC
1442018-03-14T03:22:19 *** schmidty is now known as Guest3864
1452018-03-14T03:22:50 *** larafale has joined #bitcoin-core-dev
1462018-03-14T03:24:05 *** pyericz has joined #bitcoin-core-dev
1472018-03-14T03:26:33 *** Guest3864 has quit IRC
1482018-03-14T03:26:57 *** larafale has quit IRC
1492018-03-14T03:31:26 *** arbitrary_guy has joined #bitcoin-core-dev
1502018-03-14T03:32:16 *** jimbouki has quit IRC
1512018-03-14T03:32:21 *** mrjenkins has quit IRC
1522018-03-14T03:35:44 *** Giszmo has quit IRC
1532018-03-14T03:44:01 *** mangoicedtea has joined #bitcoin-core-dev
1542018-03-14T03:49:13 *** jimbouki has joined #bitcoin-core-dev
1552018-03-14T04:12:36 *** User__ has joined #bitcoin-core-dev
1562018-03-14T04:14:49 *** Victorsueca has quit IRC
1572018-03-14T04:15:33 *** ken2812221 has quit IRC
1582018-03-14T04:15:51 *** pyericz has quit IRC
1592018-03-14T04:16:07 *** Victorsueca has joined #bitcoin-core-dev
1602018-03-14T04:16:08 *** jimbouki_ has joined #bitcoin-core-dev
1612018-03-14T04:16:17 *** jimbouki has quit IRC
1622018-03-14T04:21:32 *** pyericz has joined #bitcoin-core-dev
1632018-03-14T04:23:28 *** larafale has joined #bitcoin-core-dev
1642018-03-14T04:23:47 *** jimbouki_ has quit IRC
1652018-03-14T04:24:01 *** rex_4539 has joined #bitcoin-core-dev
1662018-03-14T04:24:30 *** jimbouki has joined #bitcoin-core-dev
1672018-03-14T04:26:09 *** pyericz has quit IRC
1682018-03-14T04:27:57 *** larafale has quit IRC
1692018-03-14T04:42:09 *** rex_4539 has quit IRC
1702018-03-14T04:49:07 *** tecneecs has quit IRC
1712018-03-14T04:55:39 *** jimbouki has quit IRC
1722018-03-14T04:57:41 *** jimbouki has joined #bitcoin-core-dev
1732018-03-14T05:01:57 *** jimbouki has quit IRC
1742018-03-14T05:02:21 *** harryTrout has joined #bitcoin-core-dev
1752018-03-14T05:04:59 *** mangoicedtea has quit IRC
1762018-03-14T05:09:53 *** grafcaps has quit IRC
1772018-03-14T05:10:43 <pierre_rochard> mrjenkins https://github.com/bitcoin/bitcoin shows the build is passing
1782018-03-14T05:10:53 *** dafunkiz_ has joined #bitcoin-core-dev
1792018-03-14T05:23:04 *** schmidty has joined #bitcoin-core-dev
1802018-03-14T05:23:26 *** schmidty is now known as Guest37915
1812018-03-14T05:24:19 *** larafale has joined #bitcoin-core-dev
1822018-03-14T05:27:58 *** Guest37915 has quit IRC
1832018-03-14T05:28:57 *** larafale has quit IRC
1842018-03-14T05:33:16 *** grafcaps has joined #bitcoin-core-dev
1852018-03-14T05:37:50 *** pyericz has joined #bitcoin-core-dev
1862018-03-14T05:38:09 *** grafcaps has quit IRC
1872018-03-14T05:46:12 *** dafunkiz_ has quit IRC
1882018-03-14T06:07:12 *** harryTrout has left #bitcoin-core-dev
1892018-03-14T06:13:31 *** pyericz has quit IRC
1902018-03-14T06:14:07 *** pyericz has joined #bitcoin-core-dev
1912018-03-14T06:23:16 *** Victorsueca has quit IRC
1922018-03-14T06:24:20 *** pyericz has quit IRC
1932018-03-14T06:24:38 *** Victorsueca has joined #bitcoin-core-dev
1942018-03-14T06:24:52 *** pyericz has joined #bitcoin-core-dev
1952018-03-14T06:25:10 *** larafale has joined #bitcoin-core-dev
1962018-03-14T06:29:27 *** larafale has quit IRC
1972018-03-14T06:31:09 *** jimbouki has joined #bitcoin-core-dev
1982018-03-14T06:35:54 *** jimbouki has quit IRC
1992018-03-14T06:42:31 *** jimbouki has joined #bitcoin-core-dev
2002018-03-14T06:43:49 *** sanada` has joined #bitcoin-core-dev
2012018-03-14T06:45:00 *** pyericz_ has joined #bitcoin-core-dev
2022018-03-14T06:45:22 *** sanada has quit IRC
2032018-03-14T06:46:25 *** pyericz has quit IRC
2042018-03-14T06:46:33 *** jimbouki has quit IRC
2052018-03-14T06:56:58 *** fanquake has joined #bitcoin-core-dev
2062018-03-14T07:05:04 <fanquake> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds?
2072018-03-14T07:16:57 *** User__ has quit IRC
2082018-03-14T07:17:42 *** User__ has joined #bitcoin-core-dev
2092018-03-14T07:21:30 <sipa> fanquake: what PR are you referring to?
2102018-03-14T07:22:23 <eklitzke> sipa: for #12683 did you do this manually or have a tool identify the temporary references?
2112018-03-14T07:22:25 <gribble> https://github.com/bitcoin/bitcoin/issues/12683 | Fix more constness violations in serialization code by sipa · Pull Request #12683 · bitcoin/bitcoin · GitHub
2122018-03-14T07:22:28 <eklitzke> this is an interesting change
2132018-03-14T07:24:15 <sipa> eklitzke: there are only 2 dozen calls of REF, some are there as arguments to one of the wrappers (which aren't fixed yet), and some are around the wrappers (which are fixed now)
2142018-03-14T07:24:20 <sipa> it's quite mechanical
2152018-03-14T07:24:21 *** schmidty has joined #bitcoin-core-dev
2162018-03-14T07:24:55 *** schmidty is now known as Guest10494
2172018-03-14T07:25:03 <sipa> eklitzke: #10785 has many more things like this
2182018-03-14T07:25:08 <gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
2192018-03-14T07:25:49 *** larafale has joined #bitcoin-core-dev
2202018-03-14T07:25:55 <eklitzke> neat, i'll take a look at that too
2212018-03-14T07:27:55 *** CubicEarths has joined #bitcoin-core-dev
2222018-03-14T07:28:32 *** fanquake has quit IRC
2232018-03-14T07:28:56 *** Guest10494 has quit IRC
2242018-03-14T07:28:59 *** grafcaps has joined #bitcoin-core-dev
2252018-03-14T07:29:10 *** fanquake has joined #bitcoin-core-dev
2262018-03-14T07:30:27 *** larafale has quit IRC
2272018-03-14T07:34:02 *** grafcaps has quit IRC
2282018-03-14T07:34:16 <kallewoof> fanquake: Don't know if you're referring to me, but I may be guilty of doing that. I'll try to think of whether it's worth it with the amount of ACKs for current state in the future.
2292018-03-14T07:50:24 *** CapitanRetardo has joined #bitcoin-core-dev
2302018-03-14T07:51:56 *** jimbouki has joined #bitcoin-core-dev
2312018-03-14T07:56:45 *** jimbouki has quit IRC
2322018-03-14T08:10:17 *** setpill has joined #bitcoin-core-dev
2332018-03-14T08:15:57 *** pyericz_ has quit IRC
2342018-03-14T08:17:13 *** pyericz has joined #bitcoin-core-dev
2352018-03-14T08:18:21 *** timothy has joined #bitcoin-core-dev
2362018-03-14T08:22:48 *** drizztbsd has joined #bitcoin-core-dev
2372018-03-14T08:23:46 *** timothy has quit IRC
2382018-03-14T08:25:01 *** arbitrary_guy has quit IRC
2392018-03-14T08:26:33 *** larafale has joined #bitcoin-core-dev
2402018-03-14T08:29:44 *** promag_ has quit IRC
2412018-03-14T08:30:26 *** promag has joined #bitcoin-core-dev
2422018-03-14T08:30:35 *** Bethany47Braun has quit IRC
2432018-03-14T08:30:57 *** larafale has quit IRC
2442018-03-14T08:34:41 *** promag has quit IRC
2452018-03-14T08:39:23 *** Kayla75Wunsch has joined #bitcoin-core-dev
2462018-03-14T08:57:36 *** laurentmt has joined #bitcoin-core-dev
2472018-03-14T09:03:54 *** laurentmt has quit IRC
2482018-03-14T09:04:07 *** jimbouki has joined #bitcoin-core-dev
2492018-03-14T09:08:30 *** jimbouki has quit IRC
2502018-03-14T09:14:15 <pierre_rochard> achow101: Iâm taking a look at #12375 - do you have a fix in the works? I just implemented Akioâs solution and it works, though Iâd like to do more research before letting a platform-specific issue add what feels like cruft.
2512018-03-14T09:14:17 <gribble> https://github.com/bitcoin/bitcoin/issues/12375 | wallet_encryption.py fails on macos · Issue #12375 · bitcoin/bitcoin · GitHub
2522018-03-14T09:15:18 *** adiabat has quit IRC
2532018-03-14T09:24:15 <bitcoin-git> [bitcoin] bill-walker closed pull request #12599: [gui] Use base58 script hash address as example (master...master) https://github.com/bitcoin/bitcoin/pull/12599
2542018-03-14T09:24:54 *** fanquake has quit IRC
2552018-03-14T09:25:15 *** schmidty has joined #bitcoin-core-dev
2562018-03-14T09:25:38 *** schmidty is now known as Guest44473
2572018-03-14T09:30:05 *** Guest44473 has quit IRC
2582018-03-14T09:30:11 *** adiabat has joined #bitcoin-core-dev
2592018-03-14T09:31:49 *** grafcaps has joined #bitcoin-core-dev
2602018-03-14T09:34:41 <bitcoin-git> [bitcoin] bill-walker opened pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685
2612018-03-14T09:36:30 *** grafcaps has quit IRC
2622018-03-14T09:37:55 *** fanquake has joined #bitcoin-core-dev
2632018-03-14T09:38:27 *** CapitanRetardo has quit IRC
2642018-03-14T09:47:52 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6acd8700bc0e...c6fc6656299b
2652018-03-14T09:47:52 <bitcoin-git> bitcoin/master 2b3ea39 Vasil Dimov: Polish interfaces around PeerLogicValidation...
2662018-03-14T09:47:53 <bitcoin-git> bitcoin/master c6fc665 Wladimir J. van der Laan: Merge #12680: Add missing virtual destructor in PeerLogicValidation...
2672018-03-14T09:48:37 <bitcoin-git> [bitcoin] laanwj closed pull request #12680: Add missing virtual destructor in PeerLogicValidation (master...master-add-missing-vdtor-in-PeerLogicValidation) https://github.com/bitcoin/bitcoin/pull/12680
2682018-03-14T09:49:11 *** promag has joined #bitcoin-core-dev
2692018-03-14T10:01:06 *** zarez has joined #bitcoin-core-dev
2702018-03-14T10:04:54 *** promag has quit IRC
2712018-03-14T10:05:30 *** CapitanRetardo has joined #bitcoin-core-dev
2722018-03-14T10:07:12 *** CapitanRetardo has quit IRC
2732018-03-14T10:07:47 *** CapitanRetardo has joined #bitcoin-core-dev
2742018-03-14T10:09:09 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c6fc6656299b...9f04c8e23118
2752018-03-14T10:09:09 <bitcoin-git> bitcoin/master fa79016 MarcoFalke: travis: Clone depth 1 unless $CHECK_DOC
2762018-03-14T10:09:10 <bitcoin-git> bitcoin/master 9f04c8e Wladimir J. van der Laan: Merge #12682: travis: Clone depth 1 unless $CHECK_DOC...
2772018-03-14T10:09:20 *** CapitanRetardo has joined #bitcoin-core-dev
2782018-03-14T10:09:59 <bitcoin-git> [bitcoin] laanwj closed pull request #12682: travis: Clone depth 1 unless $CHECK_DOC (master...Mf1803-travisDepth1) https://github.com/bitcoin/bitcoin/pull/12682
2792018-03-14T10:10:25 *** CapitanRetardo has joined #bitcoin-core-dev
2802018-03-14T10:12:25 *** jimbouki has joined #bitcoin-core-dev
2812018-03-14T10:16:05 <wumpus> I'm confused re: 12685
2822018-03-14T10:16:33 *** Megumiin has quit IRC
2832018-03-14T10:16:41 <wumpus> I don't remember the dummy address change getting merged
2842018-03-14T10:17:05 *** jimbouki has quit IRC
2852018-03-14T10:17:20 *** CapitanRetardo has joined #bitcoin-core-dev
2862018-03-14T10:17:50 *** Megumiin has joined #bitcoin-core-dev
2872018-03-14T10:17:59 <wumpus> oh it wasn't (#12599)
2882018-03-14T10:18:01 <gribble> https://github.com/bitcoin/bitcoin/issues/12599 | [gui] Use base58 script hash address as example by bill-walker · Pull Request #12599 · bitcoin/bitcoin · GitHub
2892018-03-14T10:19:26 *** promag has joined #bitcoin-core-dev
2902018-03-14T10:26:31 *** CapitanRetardo has quit IRC
2912018-03-14T10:26:50 *** CapitanRetardo has joined #bitcoin-core-dev
2922018-03-14T10:27:05 *** drizztbsd has quit IRC
2932018-03-14T10:27:17 *** drizztbsd has joined #bitcoin-core-dev
2942018-03-14T10:27:47 *** drizztbsd is now known as timothy
2952018-03-14T10:32:58 *** fanquake has quit IRC
2962018-03-14T10:35:47 *** drizztbsd has joined #bitcoin-core-dev
2972018-03-14T10:36:25 *** timothy has quit IRC
2982018-03-14T10:42:51 <bitcoin-git> [bitcoin] practicalswift opened pull request #12686: travis: Generate a trap for signed arithmetic overflows (enable -ftrapv) (master...trapv) https://github.com/bitcoin/bitcoin/pull/12686
2992018-03-14T10:43:52 *** fanquake has joined #bitcoin-core-dev
3002018-03-14T10:51:56 *** drizztbsd is now known as timothy
3012018-03-14T10:56:35 *** fanquake has quit IRC
3022018-03-14T11:04:03 *** User__ is now known as ken2812221
3032018-03-14T11:04:37 *** ken2812221 has quit IRC
3042018-03-14T11:04:59 *** ken2812221 has joined #bitcoin-core-dev
3052018-03-14T11:08:15 *** fanquake has joined #bitcoin-core-dev
3062018-03-14T11:23:26 *** opdenkamp has quit IRC
3072018-03-14T11:26:42 *** schmidty has joined #bitcoin-core-dev
3082018-03-14T11:27:06 *** schmidty is now known as Guest98035
3092018-03-14T11:28:06 *** harrymm has joined #bitcoin-core-dev
3102018-03-14T11:29:01 *** opdenkamp has joined #bitcoin-core-dev
3112018-03-14T11:30:57 *** Guest98035 has quit IRC
3122018-03-14T11:37:06 *** fanquake has quit IRC
3132018-03-14T11:47:37 *** pyericz has quit IRC
3142018-03-14T11:49:31 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3152018-03-14T11:53:42 *** Kayla75Wunsch has quit IRC
3162018-03-14T11:56:16 *** jimbouki has joined #bitcoin-core-dev
3172018-03-14T11:57:00 *** CubicEarths has quit IRC
3182018-03-14T11:57:19 *** dabura667 has quit IRC
3192018-03-14T11:57:36 *** CubicEarths has joined #bitcoin-core-dev
3202018-03-14T12:00:24 *** Samdney has joined #bitcoin-core-dev
3212018-03-14T12:01:03 *** jimbouki has quit IRC
3222018-03-14T12:02:09 *** CubicEarths has quit IRC
3232018-03-14T12:02:38 *** promag has quit IRC
3242018-03-14T12:05:51 *** mrannanay has joined #bitcoin-core-dev
3252018-03-14T12:06:22 *** CapitanRetardo has quit IRC
3262018-03-14T12:07:11 *** AaronvanW has joined #bitcoin-core-dev
3272018-03-14T12:07:57 *** fanquake has joined #bitcoin-core-dev
3282018-03-14T12:08:13 *** Aaronvan_ has joined #bitcoin-core-dev
3292018-03-14T12:11:45 *** AaronvanW has quit IRC
3302018-03-14T12:14:19 *** promag has joined #bitcoin-core-dev
3312018-03-14T12:14:23 *** grafcaps has joined #bitcoin-core-dev
3322018-03-14T12:14:42 *** fanquake has quit IRC
3332018-03-14T12:15:01 *** fanquake has joined #bitcoin-core-dev
3342018-03-14T12:17:57 *** opdenkamp has quit IRC
3352018-03-14T12:19:27 *** grafcaps has quit IRC
3362018-03-14T12:19:52 *** promag has quit IRC
3372018-03-14T12:21:24 *** promag has joined #bitcoin-core-dev
3382018-03-14T12:21:36 *** CapitanRetardo has joined #bitcoin-core-dev
3392018-03-14T12:21:37 *** fanquake has quit IRC
3402018-03-14T12:24:23 *** promag has quit IRC
3412018-03-14T12:27:01 *** promag has joined #bitcoin-core-dev
3422018-03-14T12:30:46 *** promag has quit IRC
3432018-03-14T12:31:15 *** promag has joined #bitcoin-core-dev
3442018-03-14T12:35:16 *** setpill has quit IRC
3452018-03-14T12:35:33 *** Chris_Stewart_5 has quit IRC
3462018-03-14T12:39:11 <wumpus> <fanquake> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds? <- yeah...
3472018-03-14T12:39:24 <wumpus> feel free to call me out when I do that
3482018-03-14T12:39:58 <wumpus> usually I add "but this doesn't have to be done in this PR" in that case
3492018-03-14T12:40:02 * luke-jr calls jonasschnelli out on doing it with multiwallet? XD
3502018-03-14T12:40:49 <wumpus> at this point I'd be happy to have *any* multiwallet GUI in, just so that work can proceed on it in the repository
3512018-03-14T12:41:06 *** setpill has joined #bitcoin-core-dev
3522018-03-14T12:42:11 <luke-jr> well, #11383 is ready besides a new conflict in wallet_tests I could easily resolve :x
3532018-03-14T12:42:14 <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
3542018-03-14T12:46:47 *** dafunkiz_ has joined #bitcoin-core-dev
3552018-03-14T12:52:43 *** opdenkamp has joined #bitcoin-core-dev
3562018-03-14T12:55:39 *** promag has quit IRC
3572018-03-14T12:56:30 *** CapitanRetardo has quit IRC
3582018-03-14T13:03:34 *** belcher_ has joined #bitcoin-core-dev
3592018-03-14T13:22:16 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f04c8e23118...ce6ffe196e9b
3602018-03-14T13:22:16 <bitcoin-git> bitcoin/master fa23105 MarcoFalke: qa: Cache only chain and wallet for regtest datadir
3612018-03-14T13:22:17 <bitcoin-git> bitcoin/master ce6ffe1 Wladimir J. van der Laan: Merge #12638: qa: Cache only chain and wallet for regtest datadir...
3622018-03-14T13:23:07 <bitcoin-git> [bitcoin] laanwj closed pull request #12638: qa: Cache only chain and wallet for regtest datadir (master...Mf1803-qaMempoolCache) https://github.com/bitcoin/bitcoin/pull/12638
3632018-03-14T13:25:40 *** schmidty has joined #bitcoin-core-dev
3642018-03-14T13:26:03 *** schmidty is now known as Guest72256
3652018-03-14T13:29:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3662018-03-14T13:29:59 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce6ffe196e9b...c4219ff3786e
3672018-03-14T13:29:59 <bitcoin-git> bitcoin/master 4ef82f1 fanquake: depends: biplist 1.0.3
3682018-03-14T13:30:00 <bitcoin-git> bitcoin/master c4219ff Wladimir J. van der Laan: Merge #12625: depends: biplist 1.0.3...
3692018-03-14T13:30:45 <bitcoin-git> [bitcoin] laanwj closed pull request #12625: depends: biplist 1.0.3 (master...biplist-1-0-3) https://github.com/bitcoin/bitcoin/pull/12625
3702018-03-14T13:31:44 *** dafunkiz_ has quit IRC
3712018-03-14T13:32:51 *** CubicEarths has joined #bitcoin-core-dev
3722018-03-14T13:37:44 *** CubicEarths has quit IRC
3732018-03-14T13:38:30 *** CubicEarths has joined #bitcoin-core-dev
3742018-03-14T13:39:03 *** fanquake has joined #bitcoin-core-dev
3752018-03-14T13:40:00 <fanquake> wumpus I think we're meant to be excluding patches already: ":(exclude)depends/patches/" Maybe the script is broken?
3762018-03-14T13:40:10 <wumpus> fanquake: was that ever backported
3772018-03-14T13:40:36 <fanquake> wumpus Good point, probably not
3782018-03-14T13:41:32 <wumpus> :D
3792018-03-14T13:41:42 <wumpus> could include it in that PR I gues
3802018-03-14T13:42:54 *** CubicEarths has quit IRC
3812018-03-14T13:43:48 <wumpus> already had a bit of deja vu feeling about that patch exclusion
3822018-03-14T13:44:41 <fanquake> heh, get enough hassel from whitespace already without it complaining about things we know are "correct"
3832018-03-14T13:44:52 <fanquake> I'll add that commit in a minute
3842018-03-14T13:44:57 <wumpus> yes, agree
3852018-03-14T13:45:19 <fanquake> #12102 should be ready for merge
3862018-03-14T13:45:22 <gribble> https://github.com/bitcoin/bitcoin/issues/12102 | Apply hardening measures in bitcoind systemd service file by Flowdalic · Pull Request #12102 · bitcoin/bitcoin · GitHub
3872018-03-14T13:46:30 <wumpus> I'm still not convinced adding that whitespace check to travis was a good idea. On the other hand at least it avoids PRs to "fix" whitespace!
3882018-03-14T13:48:31 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4219ff3786e...7fb8fb43a630
3892018-03-14T13:48:31 <bitcoin-git> bitcoin/master 79ddfad Florian Schmaus: Apply hardening measurements in bitcoind systemd service file...
3902018-03-14T13:48:32 <bitcoin-git> bitcoin/master 7fb8fb4 Wladimir J. van der Laan: Merge #12102: Apply hardening measures in bitcoind systemd service file...
3912018-03-14T13:49:03 <bitcoin-git> [bitcoin] laanwj closed pull request #12102: Apply hardening measures in bitcoind systemd service file (master...systemd-hardening) https://github.com/bitcoin/bitcoin/pull/12102
3922018-03-14T13:51:46 <bitcoin-git> [bitcoin] fanquake closed pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685
3932018-03-14T13:53:52 *** CubicEarths has joined #bitcoin-core-dev
3942018-03-14T13:54:02 *** ken2812221 has quit IRC
3952018-03-14T13:56:07 *** ken2812221 has joined #bitcoin-core-dev
3962018-03-14T13:57:13 <fanquake> wumpus #12460 has a bunch of utACKs, requested a review from sipa
3972018-03-14T13:57:16 <gribble> https://github.com/bitcoin/bitcoin/issues/12460 | Assert CPubKey::ValidLength to the pubkeys header-relevant size by Empact · Pull Request #12460 · bitcoin/bitcoin · GitHub
3982018-03-14T13:58:13 *** CubicEarths has quit IRC
3992018-03-14T14:01:35 *** CubicEarths has joined #bitcoin-core-dev
4002018-03-14T14:06:05 *** CubicEarths has quit IRC
4012018-03-14T14:06:55 <fanquake> #12316 started a QT bump, but hasn't really been followed up.
4022018-03-14T14:06:57 <gribble> https://github.com/bitcoin/bitcoin/issues/12316 | Upgrade depends/build system to use Qt 5.9.4 by thijstriemstra · Pull Request #12316 · bitcoin/bitcoin · GitHub
4032018-03-14T14:07:25 <fanquake> After discussing with theuni 5.9.x is the way to go for the next QT bump, however the changes should be more involved than what's been done in that PR so far.
4042018-03-14T14:07:45 <fanquake> I think I'll close it for now. I start work on an alternate pr last week.
4052018-03-14T14:08:13 <wumpus> agree, better to close it if it doesn't make progress, probably the author underestimated the work involved
4062018-03-14T14:08:13 *** Victorsueca has quit IRC
4072018-03-14T14:08:54 <wumpus> it's kind of a long haul, for a first-time contributor to try to bump qt in the depends system
4082018-03-14T14:09:16 <wumpus> might learn a thing if he was really involved, but it's going slow
4092018-03-14T14:09:27 *** Victorsueca has joined #bitcoin-core-dev
4102018-03-14T14:09:46 <bitcoin-git> [bitcoin] fanquake closed pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316
4112018-03-14T14:11:52 <wumpus> let's try to credit him in the commit message when we do bump qt
4122018-03-14T14:12:14 *** Guest72256 has quit IRC
4132018-03-14T14:12:27 *** harrymm has quit IRC
4142018-03-14T14:13:46 <bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510
4152018-03-14T14:13:49 <fanquake> wumpus How would like to follow up with issues like #12657 ?
4162018-03-14T14:13:50 <gribble> https://github.com/bitcoin/bitcoin/issues/12657 | Serbian Translation / Cyrillic and Latin - Needs better distinction on Transifex · Issue #12657 · bitcoin/bitcoin · GitHub
4172018-03-14T14:14:08 <fanquake> I'm not quite on top of how we are doing things on Transifex.
4182018-03-14T14:14:18 *** CubicEarths has joined #bitcoin-core-dev
4192018-03-14T14:14:39 *** HFRadical has joined #bitcoin-core-dev
4202018-03-14T14:14:44 <wumpus> I have no idea either
4212018-03-14T14:17:12 <setpill> has anyone tried to test #12656 ? currently running into some problems but not sure if it's an issue in my virtualbox install or in the PR
4222018-03-14T14:17:14 <gribble> https://github.com/bitcoin/bitcoin/issues/12656 | Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer by maaku · Pull Request #12656 · bitcoin/bitcoin · GitHub
4232018-03-14T14:18:58 *** CubicEarths has quit IRC
4242018-03-14T14:19:11 <fanquake> setpill I'm planning on testing shortly. Report any issues your having to the PR.
4252018-03-14T14:19:17 <wumpus> I don't use virtualbox anymore (now use libvirt/virsh on my VM servers) so can't test
4262018-03-14T14:20:06 <fanquake> wumpus I was wondering if the /docs repo might be a better place for that PR ?
4272018-03-14T14:21:39 <wumpus> fanquake: at least the documentation for it should go into the docs repo, so that it's with the other menagerie of gitian building methods. If there are scripts that are more-or-less bound to the bitcoin core release schedule they can be in our repo. Not sure.
4282018-03-14T14:22:33 *** Giszmo has joined #bitcoin-core-dev
4292018-03-14T14:22:53 <wumpus> I think the other gitian building script is also in our repo
4302018-03-14T14:22:53 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7fb8fb43a630...05042d38ba56
4312018-03-14T14:22:54 <bitcoin-git> bitcoin/master 8172d3a Luke Dashjr: configure: UniValue 1.0.4 is required for pushKV(, bool)
4322018-03-14T14:22:55 <bitcoin-git> bitcoin/master 05042d3 Wladimir J. van der Laan: Merge #12666: configure: UniValue 1.0.4 is required for pushKV(, bool)...
4332018-03-14T14:23:43 <bitcoin-git> [bitcoin] laanwj closed pull request #12666: configure: UniValue 1.0.4 is required for pushKV(, bool) (master...univalue-1.0.4-required) https://github.com/bitcoin/bitcoin/pull/12666
4342018-03-14T14:25:05 *** harrymm has joined #bitcoin-core-dev
4352018-03-14T14:25:58 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/05042d38ba56...56cc022112af
4362018-03-14T14:25:58 <bitcoin-git> bitcoin/master c316fdf João Barbosa: [qt] Add support to search the address book
4372018-03-14T14:25:59 <bitcoin-git> bitcoin/master 56cc022 Wladimir J. van der Laan: Merge #12080: Add support to search the address book...
4382018-03-14T14:26:33 <bitcoin-git> [bitcoin] laanwj closed pull request #12080: Add support to search the address book (master...2018-01-searchaddressbook) https://github.com/bitcoin/bitcoin/pull/12080
4392018-03-14T14:29:29 *** CubicEarths has joined #bitcoin-core-dev
4402018-03-14T14:31:14 *** grafcaps has joined #bitcoin-core-dev
4412018-03-14T14:31:35 *** promag has joined #bitcoin-core-dev
4422018-03-14T14:32:13 <fanquake> wumpus I think #12668 can just go in
4432018-03-14T14:32:16 <gribble> https://github.com/bitcoin/bitcoin/issues/12668 | Doc: Ubuntu xenial first dependencies by nvercamm · Pull Request #12668 · bitcoin/bitcoin · GitHub
4442018-03-14T14:32:46 <fanquake> If running apt update/upgrade is going to upset something, WSL is even more broken than we seem to think.
4452018-03-14T14:33:37 <fanquake> You could adjust the commit message though, as nothing Xenial specific.
4462018-03-14T14:34:11 *** CubicEarths has quit IRC
4472018-03-14T14:35:17 <promag> hi, I would like some feedback on #12507, ty
4482018-03-14T14:35:20 <gribble> https://github.com/bitcoin/bitcoin/issues/12507 | Interrupt rescan on shutdown request by promag · Pull Request #12507 · bitcoin/bitcoin · GitHub
4492018-03-14T14:35:39 <promag> in particular, if the rescan should resume or not
4502018-03-14T14:36:37 <instagibbs> wumpus, I must be the only one who gets triggered seeing extra whitespace on my git diff...
4512018-03-14T14:37:23 *** Guyver2 has joined #bitcoin-core-dev
4522018-03-14T14:37:29 *** SopaXorzTaker has joined #bitcoin-core-dev
4532018-03-14T14:40:19 <wumpus> instagibbs: no, I don't think so, it's really easy to notice such things. I consciously have to push myself to ignore all kinds of small grievances while reviewing, to be able to focus at the real changes
4542018-03-14T14:43:05 <wumpus> and yes, sometimes I still fail at that
4552018-03-14T14:43:52 *** meshcollider has quit IRC
4562018-03-14T14:44:23 *** CubicEarths has joined #bitcoin-core-dev
4572018-03-14T14:46:35 *** SopaXorzTaker has joined #bitcoin-core-dev
4582018-03-14T14:48:57 *** CubicEarths has quit IRC
4592018-03-14T14:50:06 *** grafcaps has quit IRC
4602018-03-14T14:53:45 <achow101> pierre_rochard: I haven't really looked at that issue yet. I can't reproduce it either; I don't have a mac
4612018-03-14T14:59:22 *** fanquake has quit IRC
4622018-03-14T15:03:51 *** Deinogalerix21 has joined #bitcoin-core-dev
4632018-03-14T15:06:35 *** CubicEarths has joined #bitcoin-core-dev
4642018-03-14T15:11:09 *** CubicEarths has quit IRC
4652018-03-14T15:11:50 *** Deinogalerix21 has quit IRC
4662018-03-14T15:16:00 *** grafcaps has joined #bitcoin-core-dev
4672018-03-14T15:17:30 <bitcoin-git> [bitcoin] laanwj closed pull request #12636: backport: #11995 Fix Qt build with Xcode 9 (0.16...qt-fix-backport) https://github.com/bitcoin/bitcoin/pull/12636
4682018-03-14T15:20:12 *** owowo has quit IRC
4692018-03-14T15:20:45 *** Victorsueca has quit IRC
4702018-03-14T15:21:54 *** Victorsueca has joined #bitcoin-core-dev
4712018-03-14T15:24:46 *** promag has quit IRC
4722018-03-14T15:25:28 *** owowo has joined #bitcoin-core-dev
4732018-03-14T15:25:33 *** grafcaps has quit IRC
4742018-03-14T15:28:44 *** CubicEarths has joined #bitcoin-core-dev
4752018-03-14T15:30:56 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56cc022112af...de2fcaa89a61
4762018-03-14T15:30:56 <bitcoin-git> bitcoin/master e29c6c8 Nick Vercammen: Ubuntu xenial first dependencies...
4772018-03-14T15:30:57 <bitcoin-git> bitcoin/master de2fcaa Wladimir J. van der Laan: Merge #12668: Doc: do update before fetching packages in WSL build guide...
4782018-03-14T15:31:51 <bitcoin-git> [bitcoin] laanwj closed pull request #12668: Doc: do update before fetching packages in WSL build guide (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12668
4792018-03-14T15:34:14 *** CubicEarths has quit IRC
4802018-03-14T15:35:10 *** zarez has quit IRC
4812018-03-14T15:36:51 *** CubicEarths has joined #bitcoin-core-dev
4822018-03-14T15:40:19 *** SopaXorzTaker has quit IRC
4832018-03-14T15:41:45 *** CubicEarths has quit IRC
4842018-03-14T15:41:45 *** SopaXorzTaker has joined #bitcoin-core-dev
4852018-03-14T15:43:08 *** SopaXorzTaker has quit IRC
4862018-03-14T15:43:44 *** SopaXorzTaker has joined #bitcoin-core-dev
4872018-03-14T15:45:01 *** SopaXorzTaker has quit IRC
4882018-03-14T15:45:39 *** SopaXorzTaker has joined #bitcoin-core-dev
4892018-03-14T15:47:21 *** CubicEarths has joined #bitcoin-core-dev
4902018-03-14T15:48:33 *** zarez has joined #bitcoin-core-dev
4912018-03-14T15:50:09 *** Randolf has quit IRC
4922018-03-14T15:52:03 *** CubicEarths has quit IRC
4932018-03-14T15:55:52 *** CubicEarths has joined #bitcoin-core-dev
4942018-03-14T15:59:57 *** kexkey has joined #bitcoin-core-dev
4952018-03-14T16:00:57 *** CubicEarths has quit IRC
4962018-03-14T16:03:29 *** CubicEarths has joined #bitcoin-core-dev
4972018-03-14T16:04:06 *** dafunkiz_ has joined #bitcoin-core-dev
4982018-03-14T16:07:57 *** CubicEarths has quit IRC
4992018-03-14T16:07:58 *** grafcaps has joined #bitcoin-core-dev
5002018-03-14T16:09:52 *** Aaronvan_ has quit IRC
5012018-03-14T16:11:03 *** zarez has quit IRC
5022018-03-14T16:11:16 *** zarez has joined #bitcoin-core-dev
5032018-03-14T16:12:07 <provoostenator> Does -testsafemode do anything other than display a warning in QT?
5042018-03-14T16:14:11 *** Randolf has joined #bitcoin-core-dev
5052018-03-14T16:15:03 <wumpus> no
5062018-03-14T16:15:40 <wumpus> safe mode never did anything in the GUI (well besides restrict use of RPC, through the debug console)
5072018-03-14T16:16:35 <wumpus> it's interesting that testsafemode is not used in any of the tests, though maybe that was removed already when safe mode was deprecated
5082018-03-14T16:17:34 *** AaronvanW has joined #bitcoin-core-dev
5092018-03-14T16:17:51 *** CubicEarths has joined #bitcoin-core-dev
5102018-03-14T16:22:09 *** CubicEarths has quit IRC
5112018-03-14T16:22:25 *** Murch has joined #bitcoin-core-dev
5122018-03-14T16:27:52 *** schmidty has joined #bitcoin-core-dev
5132018-03-14T16:28:16 *** schmidty is now known as Guest38422
5142018-03-14T16:28:59 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de2fcaa89a61...e7721e667260
5152018-03-14T16:28:59 <bitcoin-git> bitcoin/master 59f4795 fanquake: docs: Update osx brew install instruction
5162018-03-14T16:29:00 <bitcoin-git> bitcoin/master e7721e6 Wladimir J. van der Laan: Merge #12586: docs: Update osx brew install instruction...
5172018-03-14T16:29:44 <bitcoin-git> [bitcoin] laanwj closed pull request #12586: docs: Update osx brew install instruction (master...homebrew-python3-python) https://github.com/bitcoin/bitcoin/pull/12586
5182018-03-14T16:35:40 *** zarez has quit IRC
5192018-03-14T16:39:15 <provoostenator> wumpus: should I make a PR to get rid of it then?
5202018-03-14T16:45:47 *** larafale has joined #bitcoin-core-dev
5212018-03-14T16:46:58 <wumpus> provoostenator: dunno, I don't think there's really a hurry
5222018-03-14T16:52:16 <provoostenator> I didn't specificy when :-)
5232018-03-14T16:53:03 <wumpus> I don't think anyone would be opposed to just removing safe mode and everything assosicated with it, but there's probably more important things, its existence isn't blocking any developments
5242018-03-14T16:56:09 <wumpus> otoh it was deprecated in 0.16 so removing it in 0.17 would be sensible
5252018-03-14T16:58:01 <provoostenator> Afaik the parameter literraly doesn't do anything except show that message. It's not setting any (global) variable.
5262018-03-14T16:59:56 <wumpus> so if you run with -disablesafemode=0 -testsafemode , you should be prevented from executing various RPCs
5272018-03-14T17:01:07 <wumpus> (to be precise, the ones that call ObserveSafeMode)
5282018-03-14T17:01:33 *** SopaXorzTaker has quit IRC
5292018-03-14T17:02:18 <bitcoin-git> [bitcoin] laanwj pushed 14 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7721e667260...e057589dc67f
5302018-03-14T17:02:19 <bitcoin-git> bitcoin/master 12ec29d Andrew Chow: Calculate and store the number of bytes required to spend an input
5312018-03-14T17:02:19 <bitcoin-git> bitcoin/master f84fed8 Andrew Chow: Store effective value, fee, and long term fee in CInputCoin...
5322018-03-14T17:02:20 <bitcoin-git> bitcoin/master 0185939 Andrew Chow: Implement Branch and Bound coin selection in a new file...
5332018-03-14T17:02:33 <bitcoin-git> [bitcoin] laanwj closed pull request #10637: Coin Selection with Murch's algorithm (master...bnb-coin-select) https://github.com/bitcoin/bitcoin/pull/10637
5342018-03-14T17:03:44 <Murch> woohoooooo! :D
5352018-03-14T17:05:42 <wumpus> :D
5362018-03-14T17:06:25 <wumpus> congratulations, thanks for sticking with this
5372018-03-14T17:07:09 <provoostenator> Very nice!
5382018-03-14T17:12:14 *** setpill has quit IRC
5392018-03-14T17:14:35 *** CubicEarths has joined #bitcoin-core-dev
5402018-03-14T17:14:45 <Murch> Thank you achow101, instagibbs, morcos, ryanofsky, eklitzke and everyone else! :D
5412018-03-14T17:14:53 <Murch> This makes me really happy!
5422018-03-14T17:14:58 <achow101> \O/
5432018-03-14T17:15:28 <achow101> Time to start working on replacing the fallback strategy
5442018-03-14T17:16:12 <Murch> Yessir!
5452018-03-14T17:16:26 <Murch> Thanks wumpus
5462018-03-14T17:21:22 <bitcoin-git> [bitcoin] Sjors opened pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687
5472018-03-14T17:21:30 <provoostenator> wumpus: I figured out what I was missing...
5482018-03-14T17:21:40 *** arbitrary_guy has joined #bitcoin-core-dev
5492018-03-14T17:22:03 *** rex_4539 has joined #bitcoin-core-dev
5502018-03-14T17:22:19 *** Chris_Stewart_5 has quit IRC
5512018-03-14T17:22:19 <bitcoin-git> [bitcoin] Sjors closed pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687
5522018-03-14T17:23:55 <instagibbs> gave a whoop at taco place when i saw the email. Thanks for all the heavy lifting achow101 :)
5532018-03-14T17:24:54 <Murch> instagibbs: Everybody was looking at my bewilderedly when I just whooped here at the office. Had to explain what happened. :D
5542018-03-14T17:26:22 <instagibbs> next: rip up knapsack and crazy transaction looping...
5552018-03-14T17:28:08 *** dafunkiz_ has quit IRC
5562018-03-14T17:29:20 <sipa> congrats all, and achow101 and Murch in particular
5572018-03-14T17:29:21 *** Guest38422 has quit IRC
5582018-03-14T17:29:56 *** schmidty has joined #bitcoin-core-dev
5592018-03-14T17:30:20 *** schmidty is now known as Guest74669
5602018-03-14T17:32:29 *** dafunkiz_ has joined #bitcoin-core-dev
5612018-03-14T17:34:36 *** setpill has joined #bitcoin-core-dev
5622018-03-14T17:35:28 *** SopaXorzTaker has joined #bitcoin-core-dev
5632018-03-14T17:35:29 *** Guest74669 has quit IRC
5642018-03-14T17:44:46 *** kexkey_ has joined #bitcoin-core-dev
5652018-03-14T17:47:17 *** timothy has quit IRC
5662018-03-14T17:47:45 *** kexkey has quit IRC
5672018-03-14T17:49:33 *** nullptr| has quit IRC
5682018-03-14T17:50:32 *** nullptr| has joined #bitcoin-core-dev
5692018-03-14T17:52:39 *** Randolf has quit IRC
5702018-03-14T17:56:14 *** iyahjeff has joined #bitcoin-core-dev
5712018-03-14T17:56:52 <iyahjeff> Hi there. Anyone running a full BTC node on Linux that would be kind enough to paste me the output of âdu -shm .bitcoin/blocks/â
5722018-03-14T17:57:24 <arubi> 191199 datadir/blocks/
5732018-03-14T17:57:51 <arubi> oh this is #-core-dev
5742018-03-14T17:57:51 <iyahjeff> @arubi Thanks a lot.
5752018-03-14T17:59:49 *** dafunkiz_ has quit IRC
5762018-03-14T18:01:10 *** iyahjeff has left #bitcoin-core-dev
5772018-03-14T18:03:41 *** Strepsils has joined #bitcoin-core-dev
5782018-03-14T18:20:55 *** LeMiner has joined #bitcoin-core-dev
5792018-03-14T18:24:21 *** laurentmt has joined #bitcoin-core-dev
5802018-03-14T18:27:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5812018-03-14T18:28:15 *** laurentmt has quit IRC
5822018-03-14T18:28:32 *** jojeyh has quit IRC
5832018-03-14T18:32:04 *** SopaXorzTaker has quit IRC
5842018-03-14T18:38:08 <pierre_rochard> ryanofsky Iâm looking at the 0.17 wallet PRs to see what to review next, is #11536 the priority? It seems to precede the two other label PRs
5852018-03-14T18:38:11 <gribble> https://github.com/bitcoin/bitcoin/issues/11536 | Rename account to label where appropriate by ryanofsky · Pull Request #11536 · bitcoin/bitcoin · GitHub
5862018-03-14T18:39:46 <ryanofsky> yes, it is meant to be followed up by #7729, then #11497
5872018-03-14T18:39:49 <gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub
5882018-03-14T18:39:51 <gribble> https://github.com/bitcoin/bitcoin/issues/11497 | Hide accounts system behind deprecation switch by achow101 · Pull Request #11497 · bitcoin/bitcoin · GitHub
5892018-03-14T18:40:09 *** arbitrary_guy has quit IRC
5902018-03-14T18:41:13 *** santiag0 has joined #bitcoin-core-dev
5912018-03-14T18:48:01 *** qu4ku has joined #bitcoin-core-dev
5922018-03-14T18:50:25 *** arbitrary_guy has joined #bitcoin-core-dev
5932018-03-14T18:52:52 *** schmidty has joined #bitcoin-core-dev
5942018-03-14T18:53:08 *** schmidty has quit IRC
5952018-03-14T18:53:09 *** schmidty has joined #bitcoin-core-dev
5962018-03-14T18:54:53 *** d_t has joined #bitcoin-core-dev
5972018-03-14T18:58:23 *** booyah has quit IRC
5982018-03-14T18:59:33 *** booyah has joined #bitcoin-core-dev
5992018-03-14T19:01:12 *** dafunkiz_ has joined #bitcoin-core-dev
6002018-03-14T19:01:35 *** Strepsils has quit IRC
6012018-03-14T19:03:34 *** dafunkiz_ has joined #bitcoin-core-dev
6022018-03-14T19:05:33 *** contrapumpkin has quit IRC
6032018-03-14T19:07:04 *** contrapumpkin has joined #bitcoin-core-dev
6042018-03-14T19:10:01 *** qu4ku has quit IRC
6052018-03-14T19:11:01 *** meshcollider has joined #bitcoin-core-dev
6062018-03-14T19:17:56 *** dafunkiz_ has quit IRC
6072018-03-14T19:18:21 <meshcollider> Yay congrats on the coin selection merge finally achow101, Murch \o/
6082018-03-14T19:27:32 *** Randolf has joined #bitcoin-core-dev
6092018-03-14T19:28:07 *** AaronvanW has quit IRC
6102018-03-14T19:29:00 *** dafunkiz_ has joined #bitcoin-core-dev
6112018-03-14T19:34:25 *** CubicEarths has quit IRC
6122018-03-14T19:36:45 *** owowo has quit IRC
6132018-03-14T19:40:25 *** CubicEarths has joined #bitcoin-core-dev
6142018-03-14T19:40:33 *** Chris_Stewart_5 has quit IRC
6152018-03-14T19:41:53 *** owowo has joined #bitcoin-core-dev
6162018-03-14T19:43:10 *** kexkey_ has quit IRC
6172018-03-14T19:45:44 *** dafunkiz_ has quit IRC
6182018-03-14T19:49:30 *** HFRadical has quit IRC
6192018-03-14T19:50:09 *** HFRadical has joined #bitcoin-core-dev
6202018-03-14T19:53:00 *** HFRadical has quit IRC
6212018-03-14T19:53:55 *** HFRadical has joined #bitcoin-core-dev
6222018-03-14T19:56:26 <bitcoin-git> [bitcoin] dooglus closed pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (master...set_hd_seed) https://github.com/bitcoin/bitcoin/pull/11085
6232018-03-14T19:56:30 *** qu4ku has joined #bitcoin-core-dev
6242018-03-14T19:59:57 *** santiag0_ has joined #bitcoin-core-dev
6252018-03-14T20:00:42 *** santiag0_ has quit IRC
6262018-03-14T20:03:29 *** ossifrage has quit IRC
6272018-03-14T20:09:01 *** jojeyh has joined #bitcoin-core-dev
6282018-03-14T20:10:43 *** santiag0_ has joined #bitcoin-core-dev
6292018-03-14T20:20:16 *** dafunkiz_ has joined #bitcoin-core-dev
6302018-03-14T20:21:59 *** santiag0_ is now known as jajinkaz
6312018-03-14T20:22:32 *** jajinkaz is now known as santiago0
6322018-03-14T20:24:58 *** ossifrage has joined #bitcoin-core-dev
6332018-03-14T20:26:38 <santiago0> hello
6342018-03-14T20:35:50 *** jojeyh has quit IRC
6352018-03-14T20:36:17 <santiago0> I'm IT student. Never participated to bigger projects. How do you manage bitcoin source code? What IDE are you using?
6362018-03-14T20:38:10 <sipa> text editor
6372018-03-14T20:38:29 *** santiag0 has quit IRC
6382018-03-14T20:39:15 <AndyS2> I guess most people just use vim and the command line. After trying a few IDEs, I settled for Eclipse CDT with a VIM plugin for better overview. I'm just fooling around, though.
6392018-03-14T20:39:40 <AndyS2> Mostly because their debugger has a nice overview and seperate interfaces weren't as nice to use.
6402018-03-14T20:40:09 <AndyS2> oops
6412018-03-14T20:42:27 *** promag has joined #bitcoin-core-dev
6422018-03-14T20:42:59 *** jojeyh has joined #bitcoin-core-dev
6432018-03-14T20:43:12 <santiago0> ok thanks. Until now I also used VIM for everything.
6442018-03-14T20:44:55 <AndyS2> It's easier to navigate unknown code with an IDE in my opinion. that said, there's probably some plugin that does just that for vim, too.
6452018-03-14T20:45:30 <AndyS2> I just got a vim plugin for eclipse. serves my purpose well
6462018-03-14T20:45:43 <jojeyh> AndyS2, grep -rnw . -e 'stuff to find'
6472018-03-14T20:46:30 <promag> I believe #12621 is ready to be merged
6482018-03-14T20:46:32 <gribble> https://github.com/bitcoin/bitcoin/issues/12621 | Avoid querying unnecessary model data when filtering transactions by promag · Pull Request #12621 · bitcoin/bitcoin · GitHub
6492018-03-14T20:48:03 *** santiago0 has quit IRC
6502018-03-14T20:51:43 *** goatpig has joined #bitcoin-core-dev
6512018-03-14T21:05:48 *** Emcy has quit IRC
6522018-03-14T21:08:09 *** Randolf has quit IRC
6532018-03-14T21:08:33 *** rex_4539 has quit IRC
6542018-03-14T21:12:28 *** setpill has quit IRC
6552018-03-14T21:16:38 *** dafunkiz_ has quit IRC
6562018-03-14T21:19:33 *** Emcy has joined #bitcoin-core-dev
6572018-03-14T21:20:23 *** Emcy has quit IRC
6582018-03-14T21:20:50 *** Emcy has joined #bitcoin-core-dev
6592018-03-14T21:24:19 *** promag has quit IRC
6602018-03-14T21:26:53 *** jimbouki has joined #bitcoin-core-dev
6612018-03-14T21:26:58 *** Randolf has joined #bitcoin-core-dev
6622018-03-14T21:26:58 *** dafunkiz_ has joined #bitcoin-core-dev
6632018-03-14T21:28:08 *** Dizzle has joined #bitcoin-core-dev
6642018-03-14T21:31:44 *** jimbouki has quit IRC
6652018-03-14T21:38:20 <intcat> jojeyh: or without w
6662018-03-14T21:43:29 *** jojeyh has quit IRC
6672018-03-14T21:49:32 *** byteideas has joined #bitcoin-core-dev
6682018-03-14T21:56:15 *** pgupta has joined #bitcoin-core-dev
6692018-03-14T22:00:38 *** AaronvanW has joined #bitcoin-core-dev
6702018-03-14T22:00:57 *** Randolf has quit IRC
6712018-03-14T22:09:24 *** Guyver2 has quit IRC
6722018-03-14T22:12:00 *** Randolf has joined #bitcoin-core-dev
6732018-03-14T22:14:08 *** dafunkiz_ has quit IRC
6742018-03-14T22:16:20 *** Randolf has quit IRC
6752018-03-14T22:17:27 <bitcoin-git> [bitcoin] eklitzke opened pull request #12689: Smarter default behavior for -printtoconsole (master...console) https://github.com/bitcoin/bitcoin/pull/12689
6762018-03-14T22:25:22 *** tknp has joined #bitcoin-core-dev
6772018-03-14T22:49:33 *** larafale has quit IRC
6782018-03-14T22:58:54 *** pgupta has quit IRC
6792018-03-14T23:01:02 *** promag has joined #bitcoin-core-dev
6802018-03-14T23:01:47 *** dafunkiz_ has joined #bitcoin-core-dev
6812018-03-14T23:03:52 *** Randolf has joined #bitcoin-core-dev
6822018-03-14T23:04:30 *** mikgrt has joined #bitcoin-core-dev
6832018-03-14T23:09:14 *** mikgrt has quit IRC
6842018-03-14T23:10:57 *** jimbouki has joined #bitcoin-core-dev
6852018-03-14T23:11:25 *** jimbouki has quit IRC
6862018-03-14T23:12:23 *** tknp has quit IRC
6872018-03-14T23:14:14 *** Randolf has quit IRC
6882018-03-14T23:14:17 <eklitzke> travis is so annoying, it looks like it doesn't properly handle bash arrays when setting up the build environment
6892018-03-14T23:16:22 *** tecneecs has joined #bitcoin-core-dev
6902018-03-14T23:22:42 *** mikgrt has joined #bitcoin-core-dev
6912018-03-14T23:22:44 *** schmidty has quit IRC
6922018-03-14T23:23:23 *** schmidty has joined #bitcoin-core-dev
6932018-03-14T23:23:26 *** schmidty is now known as Guest48698
6942018-03-14T23:27:26 *** mikgrt has quit IRC
6952018-03-14T23:27:57 *** Guest48698 has quit IRC
6962018-03-14T23:33:05 *** qu4ku has quit IRC
6972018-03-14T23:34:31 *** dafunkiz_ has quit IRC
6982018-03-14T23:38:52 *** Emcy has quit IRC
6992018-03-14T23:39:28 *** Emcy has joined #bitcoin-core-dev
7002018-03-14T23:40:47 *** mikgrt has joined #bitcoin-core-dev
7012018-03-14T23:41:25 *** Randolf has joined #bitcoin-core-dev
7022018-03-14T23:45:21 *** mikgrt has quit IRC
7032018-03-14T23:47:41 <eklitzke> hmm, i got another corrupted chainstate database, this time on a different computer
7042018-03-14T23:47:47 <eklitzke> what's interesting is the crc on the block is correct
7052018-03-14T23:49:27 *** rafalcpp has quit IRC
7062018-03-14T23:49:39 *** booyah has quit IRC
7072018-03-14T23:50:11 <eklitzke> it also thinks that snappy compression is enabled, which is definitely not the case
7082018-03-14T23:50:13 *** rafalcpp has joined #bitcoin-core-dev
7092018-03-14T23:50:15 *** larafale has joined #bitcoin-core-dev
7102018-03-14T23:50:49 *** booyah has joined #bitcoin-core-dev
7112018-03-14T23:51:16 *** qu4ku has joined #bitcoin-core-dev
7122018-03-14T23:52:14 *** promag_ has joined #bitcoin-core-dev
7132018-03-14T23:53:45 *** promag has quit IRC
7142018-03-14T23:54:57 *** larafale has quit IRC
7152018-03-14T23:57:37 *** qu4ku has quit IRC
7162018-03-14T23:58:50 *** mikgrt has joined #bitcoin-core-dev