12018-03-29T00:00:03 *** weez17 has quit IRC
22018-03-29T00:00:40 *** weez17 has joined #bitcoin-core-dev
32018-03-29T00:07:38 <aj> wow travis sure isn't behaving at its best this week
42018-03-29T00:08:05 <Randolf> Is it just slow, or is it exhibiting some problems?
52018-03-29T00:12:51 *** shesek` has quit IRC
62018-03-29T00:13:23 *** shesek` has joined #bitcoin-core-dev
72018-03-29T00:14:11 *** suldev has joined #bitcoin-core-dev
82018-03-29T00:17:15 <aj> jnewbery: +1 on splitting up release-notes and combining in the rc-phase
92018-03-29T00:19:49 <aj> Randolf: https://travis-ci.org/bitcoin/bitcoin/builds/359365323 failed badly, causing a bug to slip through into master that's only picked up in a travis-only (ish) test, causing travis to fail for all PRs after that, needing #12821 to fix
102018-03-29T00:19:51 <gribble> https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
112018-03-29T00:27:57 *** nitramiz has quit IRC
122018-03-29T00:34:42 <Randolf> aj: Have the folks in the #travis channel become aware of this? I found them to be very helpful when I asked them a question a few weeks ago.
132018-03-29T00:39:19 *** unholymachine has quit IRC
142018-03-29T00:39:30 *** Murch has quit IRC
152018-03-29T00:43:02 *** d9b4bef9 has quit IRC
162018-03-29T00:44:08 *** d9b4bef9 has joined #bitcoin-core-dev
172018-03-29T00:50:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
182018-03-29T01:00:46 *** Lauda has quit IRC
192018-03-29T01:01:47 *** Chris_Stewart_5 has quit IRC
202018-03-29T01:02:12 *** qinfengling has quit IRC
212018-03-29T01:03:00 *** Lauda has joined #bitcoin-core-dev
222018-03-29T01:05:12 *** qinfengling has joined #bitcoin-core-dev
232018-03-29T01:15:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
242018-03-29T01:20:21 *** grafcaps has quit IRC
252018-03-29T01:20:50 *** dafunkiz_ has joined #bitcoin-core-dev
262018-03-29T01:28:28 *** rex4539 has joined #bitcoin-core-dev
272018-03-29T01:35:32 *** dafunkiz_ has quit IRC
282018-03-29T01:43:42 *** dafunkiz_ has joined #bitcoin-core-dev
292018-03-29T01:47:37 *** grafcaps has joined #bitcoin-core-dev
302018-03-29T01:58:14 *** AaronvanW has quit IRC
312018-03-29T01:59:31 *** nitramiz has joined #bitcoin-core-dev
322018-03-29T02:04:05 *** Chris_Stewart_5 has quit IRC
332018-03-29T02:13:35 *** dafunkiz_ has quit IRC
342018-03-29T02:16:18 *** dafunkiz_ has joined #bitcoin-core-dev
352018-03-29T02:30:04 *** Evel-Knievel has quit IRC
362018-03-29T02:30:47 *** Evel-Knievel has joined #bitcoin-core-dev
372018-03-29T02:39:08 *** dafunkiz_ has quit IRC
382018-03-29T02:44:35 *** dafunkiz_ has joined #bitcoin-core-dev
392018-03-29T02:52:10 *** dafunkiz_ has quit IRC
402018-03-29T02:52:49 *** arbitrary_guy has quit IRC
412018-03-29T02:53:42 *** arbitrary_guy has joined #bitcoin-core-dev
422018-03-29T02:57:27 *** belcher has quit IRC
432018-03-29T03:03:35 *** rex4539 has quit IRC
442018-03-29T03:07:21 *** da2ce7 has quit IRC
452018-03-29T03:15:33 *** da2ce7 has joined #bitcoin-core-dev
462018-03-29T03:23:32 *** Krellan has quit IRC
472018-03-29T03:24:02 *** Krellan has joined #bitcoin-core-dev
482018-03-29T03:43:34 *** suldev has quit IRC
492018-03-29T03:48:08 *** derrekito_ has joined #bitcoin-core-dev
502018-03-29T03:49:35 *** musalbas has quit IRC
512018-03-29T03:50:25 *** Derrekito has quit IRC
522018-03-29T03:51:34 *** musalbas has joined #bitcoin-core-dev
532018-03-29T03:52:57 *** hirish has quit IRC
542018-03-29T03:54:07 *** BashCo has joined #bitcoin-core-dev
552018-03-29T03:55:06 *** hirish has joined #bitcoin-core-dev
562018-03-29T03:55:34 *** BashCo_ has quit IRC
572018-03-29T04:00:35 *** nitramiz has quit IRC
582018-03-29T04:09:02 *** d9b4bef9 has quit IRC
592018-03-29T04:10:08 *** d9b4bef9 has joined #bitcoin-core-dev
602018-03-29T04:19:01 *** d9b4bef9 has quit IRC
612018-03-29T04:20:09 *** d9b4bef9 has joined #bitcoin-core-dev
622018-03-29T04:21:32 *** Samdney has quit IRC
632018-03-29T04:24:46 *** justanotheruser has joined #bitcoin-core-dev
642018-03-29T04:25:40 *** justanotheruser has joined #bitcoin-core-dev
652018-03-29T04:25:51 *** goatpig has quit IRC
662018-03-29T04:25:58 *** karimofthecrop has joined #bitcoin-core-dev
672018-03-29T04:27:19 *** justan0theruser has quit IRC
682018-03-29T04:27:24 *** Deadhand has quit IRC
692018-03-29T04:41:37 <jtimon> sorry for not following up, but promag will take care of the second part he discovered, please let's move on with https://github.com/bitcoin/bitcoin/pull/12172 's from 58 comments anf +9-4 as it was supposed to be
702018-03-29T04:53:50 <bitcoin-git> [bitcoin] jtimon closed pull request #11426: BIP90: Make buried deployments slightly more easily extensible (master...e16-bip90-extensible) https://github.com/bitcoin/bitcoin/pull/11426
712018-03-29T04:55:48 *** indistylo has joined #bitcoin-core-dev
722018-03-29T05:00:32 *** arubi has quit IRC
732018-03-29T05:00:32 *** ghost43 has quit IRC
742018-03-29T05:00:32 *** dermoth has quit IRC
752018-03-29T05:01:27 *** arubi has joined #bitcoin-core-dev
762018-03-29T05:05:20 *** r251d has quit IRC
772018-03-29T05:05:44 *** r251d has joined #bitcoin-core-dev
782018-03-29T05:06:38 *** Deadhand has joined #bitcoin-core-dev
792018-03-29T05:08:46 *** baldur has quit IRC
802018-03-29T05:10:35 *** suldev has joined #bitcoin-core-dev
812018-03-29T05:15:24 *** arbitrary_guy has quit IRC
822018-03-29T05:21:15 *** baldur has joined #bitcoin-core-dev
832018-03-29T05:35:05 *** jtimon has quit IRC
842018-03-29T05:37:53 *** aruns has joined #bitcoin-core-dev
852018-03-29T05:40:48 *** indistylo has quit IRC
862018-03-29T05:42:05 *** Soligor has quit IRC
872018-03-29T05:46:07 *** Soligor has joined #bitcoin-core-dev
882018-03-29T05:55:02 *** rex4539 has joined #bitcoin-core-dev
892018-03-29T05:55:20 *** suldev has quit IRC
902018-03-29T05:56:46 *** qinfengling has quit IRC
912018-03-29T05:59:45 *** rex4539 has quit IRC
922018-03-29T06:05:19 *** karimofthecrop has quit IRC
932018-03-29T06:10:17 *** rex4539 has joined #bitcoin-core-dev
942018-03-29T06:18:53 <bitcoin-git> [bitcoin] eklitzke opened pull request #12825: Only allocate a LevelDB block cache if LevelDB will actually use it (master...buffer-cache) https://github.com/bitcoin/bitcoin/pull/12825
952018-03-29T06:38:29 *** fanquake has joined #bitcoin-core-dev
962018-03-29T06:42:49 *** r251d has quit IRC
972018-03-29T06:44:51 *** r251d has joined #bitcoin-core-dev
982018-03-29T06:50:38 *** fanquake has quit IRC
992018-03-29T07:00:40 *** lnostdal has joined #bitcoin-core-dev
1002018-03-29T07:01:55 *** jtimon has joined #bitcoin-core-dev
1012018-03-29T07:14:22 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1022018-03-29T07:14:22 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1032018-03-29T07:28:03 *** Cogito_Ergo_Sum has quit IRC
1042018-03-29T07:40:39 *** JackH has quit IRC
1052018-03-29T07:50:13 *** zarez has joined #bitcoin-core-dev
1062018-03-29T07:52:05 *** andytoshi has quit IRC
1072018-03-29T07:53:10 *** andytoshi has joined #bitcoin-core-dev
1082018-03-29T07:53:17 *** JackH has joined #bitcoin-core-dev
1092018-03-29T08:05:10 *** jtimon has quit IRC
1102018-03-29T08:07:10 *** CubicEarths has quit IRC
1112018-03-29T08:11:02 *** d9b4bef9 has quit IRC
1122018-03-29T08:11:34 *** timothy has joined #bitcoin-core-dev
1132018-03-29T08:12:09 *** d9b4bef9 has joined #bitcoin-core-dev
1142018-03-29T08:12:54 *** aruns__ has joined #bitcoin-core-dev
1152018-03-29T08:13:30 *** CubicEarths has joined #bitcoin-core-dev
1162018-03-29T08:16:03 *** drizztbsd has joined #bitcoin-core-dev
1172018-03-29T08:16:25 *** aruns has quit IRC
1182018-03-29T08:17:02 *** timothy has quit IRC
1192018-03-29T08:20:21 *** aruns has joined #bitcoin-core-dev
1202018-03-29T08:22:35 *** aruns__ has quit IRC
1212018-03-29T08:28:00 *** promag has joined #bitcoin-core-dev
1222018-03-29T08:38:25 *** rls has quit IRC
1232018-03-29T08:41:47 *** psyopp has joined #bitcoin-core-dev
1242018-03-29T08:42:27 *** BashCo has quit IRC
1252018-03-29T08:44:20 *** justanotheruser has quit IRC
1262018-03-29T08:49:21 *** aruns has quit IRC
1272018-03-29T08:49:45 *** BashCo has joined #bitcoin-core-dev
1282018-03-29T08:50:13 *** SopaXorzTaker has joined #bitcoin-core-dev
1292018-03-29T08:54:33 *** aruns has joined #bitcoin-core-dev
1302018-03-29T09:00:49 *** JackH has quit IRC
1312018-03-29T09:04:17 *** ohnx has quit IRC
1322018-03-29T09:04:23 *** grafcaps has quit IRC
1332018-03-29T09:07:10 *** ohnx has joined #bitcoin-core-dev
1342018-03-29T09:07:25 *** aruns has quit IRC
1352018-03-29T09:07:33 *** AaronvanW has joined #bitcoin-core-dev
1362018-03-29T09:08:05 *** JackH has joined #bitcoin-core-dev
1372018-03-29T09:08:06 *** aruns has joined #bitcoin-core-dev
1382018-03-29T09:08:16 *** Aaronvan_ has joined #bitcoin-core-dev
1392018-03-29T09:08:45 <murrayn> what's the best way of proceeding with this PR: https://github.com/bitcoin/bitcoin/pull/12809
1402018-03-29T09:08:59 <murrayn> Have I messed it up by merging master into it?
1412018-03-29T09:11:26 *** CubicEarths has quit IRC
1422018-03-29T09:11:57 *** AaronvanW has quit IRC
1432018-03-29T09:12:06 *** CubicEarths has joined #bitcoin-core-dev
1442018-03-29T09:17:15 *** CubicEar_ has joined #bitcoin-core-dev
1452018-03-29T09:17:55 <promag> murrayn: you should remove merge commit
1462018-03-29T09:20:03 <promag> on that branch do git rebase -i HEAD~3
1472018-03-29T09:20:12 *** CubicEarths has quit IRC
1482018-03-29T09:20:20 <promag> then in the editor remove the line with the merge commit
1492018-03-29T09:20:51 *** Victorsueca has quit IRC
1502018-03-29T09:20:58 <promag> save and quit, git log to verify, then force git push
1512018-03-29T09:21:56 <murrayn> there are a lot of lines, the merge is split into separate itms
1522018-03-29T09:21:59 <murrayn> remove them all?
1532018-03-29T09:22:03 *** Victorsueca has joined #bitcoin-core-dev
1542018-03-29T09:22:36 <promag> murrayn: let me see
1552018-03-29T09:22:45 <murrayn> i.e. just leave the original commit
1562018-03-29T09:23:49 *** laurentmt has joined #bitcoin-core-dev
1572018-03-29T09:24:48 <promag> well, you can do git reset --hard master, git cherry-pick 91c8756, git cherry-pick e133491
1582018-03-29T09:25:01 <promag> but don't forget to git rebaes --abort first
1592018-03-29T09:26:36 <murrayn> e133491 was a change to something in the merge commit. so omit it?
1602018-03-29T09:29:21 <promag> yes
1612018-03-29T09:30:04 <murrayn> ok here goes :-)
1622018-03-29T09:31:23 <murrayn> so the i will need to merge the cherry-pick of 91c8756
1632018-03-29T09:33:24 *** meshcollider has quit IRC
1642018-03-29T09:35:09 <promag> what you mean by merge?
1652018-03-29T09:35:41 <promag> you just have to cherry pick 91c8756 after git reset --hard master
1662018-03-29T09:39:22 *** drizztbsd is now known as timothy
1672018-03-29T09:40:47 *** laurentmt has quit IRC
1682018-03-29T09:41:56 <murrayn> promag, i mean i need to resolve the conflicts
1692018-03-29T09:43:51 *** lnostdal has quit IRC
1702018-03-29T09:48:20 <murrayn> ok, resolved the 3 or 4 conflicts in src/init.cpp
1712018-03-29T09:49:39 *** lnostdal has joined #bitcoin-core-dev
1722018-03-29T09:50:28 <murrayn> promag, now what? just commit?
1732018-03-29T09:50:37 *** AaronvanW has joined #bitcoin-core-dev
1742018-03-29T09:50:49 <promag> murrayn: pm please
1752018-03-29T09:50:59 <murrayn> ok thanks for your help
1762018-03-29T09:53:38 *** Aaronvan_ has quit IRC
1772018-03-29T09:55:27 *** lnostdal has quit IRC
1782018-03-29T09:56:19 *** karimofthecrop has joined #bitcoin-core-dev
1792018-03-29T09:59:36 *** lnostdal has joined #bitcoin-core-dev
1802018-03-29T10:00:59 *** karimofthecrop has quit IRC
1812018-03-29T10:12:50 *** Aaronvan_ has joined #bitcoin-core-dev
1822018-03-29T10:16:02 *** AaronvanW has quit IRC
1832018-03-29T10:24:37 *** wxss has joined #bitcoin-core-dev
1842018-03-29T10:36:18 *** promag has quit IRC
1852018-03-29T10:37:42 *** marcinja has joined #bitcoin-core-dev
1862018-03-29T10:38:08 *** Strepsils has joined #bitcoin-core-dev
1872018-03-29T10:40:47 *** marcinja has quit IRC
1882018-03-29T10:41:22 *** Deinogalerix21 has joined #bitcoin-core-dev
1892018-03-29T10:42:41 *** Deinogalerix21 has joined #bitcoin-core-dev
1902018-03-29T10:49:41 *** karimofthecrop has joined #bitcoin-core-dev
1912018-03-29T10:51:29 *** promag has joined #bitcoin-core-dev
1922018-03-29T10:54:22 *** karimofthecrop has quit IRC
1932018-03-29T10:59:03 *** StopAndDecrypt_ has quit IRC
1942018-03-29T11:00:19 *** promag has quit IRC
1952018-03-29T11:04:58 <bitcoin-git> [bitcoin] conscott opened pull request #12826: Fix lint error - making travis builds fail (master...fix_lint_error) https://github.com/bitcoin/bitcoin/pull/12826
1962018-03-29T11:05:59 <bitcoin-git> [bitcoin] fanquake closed pull request #12826: Fix lint error that is making travis builds fail (master...fix_lint_error) https://github.com/bitcoin/bitcoin/pull/12826
1972018-03-29T11:06:22 *** fanquake has joined #bitcoin-core-dev
1982018-03-29T11:14:42 *** grafcaps has joined #bitcoin-core-dev
1992018-03-29T11:17:38 *** anome has joined #bitcoin-core-dev
2002018-03-29T11:19:34 *** grafcaps has quit IRC
2012018-03-29T11:19:45 *** Strepsils has quit IRC
2022018-03-29T11:23:45 *** Giszmo has quit IRC
2032018-03-29T11:28:10 *** Deinogalerix21 has quit IRC
2042018-03-29T11:34:53 *** StopAndDecrypt has joined #bitcoin-core-dev
2052018-03-29T11:35:14 *** StopAndDecrypt has quit IRC
2062018-03-29T11:35:14 *** StopAndDecrypt has joined #bitcoin-core-dev
2072018-03-29T11:37:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2082018-03-29T11:37:34 *** Giszmo has joined #bitcoin-core-dev
2092018-03-29T11:40:47 <bitcoin-git> [bitcoin] murrayn closed pull request #12809: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/12809
2102018-03-29T11:42:04 *** anome has quit IRC
2112018-03-29T12:04:02 *** suldev has joined #bitcoin-core-dev
2122018-03-29T12:05:02 *** belcher has joined #bitcoin-core-dev
2132018-03-29T12:05:27 <fanquake> wumpus/sipa are you around tonight? Be good to get #12821 in and get Travis back.
2142018-03-29T12:05:28 <gribble> https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
2152018-03-29T12:13:22 <bitcoin-git> [bitcoin] matthias-g opened pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
2162018-03-29T12:26:15 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/624bee96597c...082e26c08bb0
2172018-03-29T12:26:15 <bitcoin-git> bitcoin/master 05120ee MarcoFalke: contrib: Remove unused import string
2182018-03-29T12:26:16 <bitcoin-git> bitcoin/master 082e26c Wladimir J. van der Laan: Merge #12821: contrib: Remove unused import string...
2192018-03-29T12:26:59 *** fanquake has quit IRC
2202018-03-29T12:27:05 <bitcoin-git> [bitcoin] laanwj closed pull request #12821: contrib: Remove unused import string (master...Mf1803-contribUnusedImportClangFormatDiff) https://github.com/bitcoin/bitcoin/pull/12821
2212018-03-29T12:27:53 *** Aaronvan_ has quit IRC
2222018-03-29T12:28:28 *** AaronvanW has joined #bitcoin-core-dev
2232018-03-29T12:30:37 *** Chris_Stewart_5 has quit IRC
2242018-03-29T12:32:09 *** promag has joined #bitcoin-core-dev
2252018-03-29T12:32:33 *** AaronvanW has quit IRC
2262018-03-29T12:35:48 *** ghost43 has joined #bitcoin-core-dev
2272018-03-29T12:47:42 *** promag has quit IRC
2282018-03-29T12:52:33 *** AaronvanW has joined #bitcoin-core-dev
2292018-03-29T12:56:38 *** fanquake has joined #bitcoin-core-dev
2302018-03-29T12:59:17 <wumpus> fanquake: thanks
2312018-03-29T12:59:50 <fanquake> wumpus no worries. I'll go restart a few tests
2322018-03-29T13:01:23 <fanquake> Was also going to suggest #12495 for high-priority, but I see you've just approved it
2332018-03-29T13:01:26 <gribble> https://github.com/bitcoin/bitcoin/issues/12495 | Increase LevelDB max_open_files by eklitzke · Pull Request #12495 · bitcoin/bitcoin · GitHub
2342018-03-29T13:02:01 *** suldev has quit IRC
2352018-03-29T13:03:10 <fanquake> Looks like #12787 is ready to go.
2362018-03-29T13:03:12 <gribble> https://github.com/bitcoin/bitcoin/issues/12787 | rpc: Adjust ifdef to avoid unreachable code by practicalswift · Pull Request #12787 · bitcoin/bitcoin · GitHub
2372018-03-29T13:04:03 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/082e26c08bb0...047865e8d188
2382018-03-29T13:04:04 <bitcoin-git> bitcoin/master ccedbaf Evan Klitzke: Increase LevelDB max_open_files unless on 32-bit Unix....
2392018-03-29T13:04:04 <bitcoin-git> bitcoin/master 047865e Wladimir J. van der Laan: Merge #12495: Increase LevelDB max_open_files...
2402018-03-29T13:04:42 <bitcoin-git> [bitcoin] laanwj closed pull request #12495: Increase LevelDB max_open_files (master...ldb_max_open_files) https://github.com/bitcoin/bitcoin/pull/12495
2412018-03-29T13:04:49 <fanquake> #12784 also
2422018-03-29T13:04:51 <gribble> https://github.com/bitcoin/bitcoin/issues/12784 | Fix bug in memory usage calculation (unintended integer division) by practicalswift · Pull Request #12784 · bitcoin/bitcoin · GitHub
2432018-03-29T13:06:32 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/047865e8d188...cd99e5bdc8fc
2442018-03-29T13:06:32 <bitcoin-git> bitcoin/master 61f8298 practicalswift: rpc: Adjust ifdef to avoid unreachable code
2452018-03-29T13:06:33 <bitcoin-git> bitcoin/master cd99e5b Wladimir J. van der Laan: Merge #12787: rpc: Adjust ifdef to avoid unreachable code...
2462018-03-29T13:07:25 <bitcoin-git> [bitcoin] laanwj closed pull request #12787: rpc: Adjust ifdef to avoid unreachable code (master...unreachable-code-ifdef-ENABLE_WALLET) https://github.com/bitcoin/bitcoin/pull/12787
2472018-03-29T13:09:55 <fanquake> wumpus do you want to make a decision on #12767
2482018-03-29T13:09:56 <gribble> https://github.com/bitcoin/bitcoin/issues/12767 | Initialize nVersionDummy to zero in deserialization code by practicalswift · Pull Request #12767 · bitcoin/bitcoin · GitHub
2492018-03-29T13:12:14 *** goatpig has joined #bitcoin-core-dev
2502018-03-29T13:13:00 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd99e5bdc8fc...e80716d3b324
2512018-03-29T13:13:01 <bitcoin-git> bitcoin/master a16c6d2 practicalswift: Fix error in memory usage calculation (unintended integer division)
2522018-03-29T13:13:01 <bitcoin-git> bitcoin/master e80716d Wladimir J. van der Laan: Merge #12784: Fix bug in memory usage calculation (unintended integer division)...
2532018-03-29T13:13:50 <bitcoin-git> [bitcoin] laanwj closed pull request #12784: Fix bug in memory usage calculation (unintended integer division) (master...calc-error) https://github.com/bitcoin/bitcoin/pull/12784
2542018-03-29T13:14:34 <fanquake> #12759 also looks like it's ready. The final nit can be handled another time.
2552018-03-29T13:14:36 <gribble> https://github.com/bitcoin/bitcoin/issues/12759 | [Docs] Improve formatting of developer notes by eklitzke · Pull Request #12759 · bitcoin/bitcoin · GitHub
2562018-03-29T13:16:53 *** tryphe_ has joined #bitcoin-core-dev
2572018-03-29T13:19:01 *** tryphe has quit IRC
2582018-03-29T13:20:55 <wumpus> fanquake: I'm not sure about #12767 - tend to agree with sipa. We shouldn't make unbridled changed to the code everywhere just to make broken static analysis tools happy. I have a similar problem with #12827.
2592018-03-29T13:20:56 <gribble> https://github.com/bitcoin/bitcoin/issues/12767 | Initialize nVersionDummy to zero in deserialization code by practicalswift · Pull Request #12767 · bitcoin/bitcoin · GitHub
2602018-03-29T13:20:57 <gribble> https://github.com/bitcoin/bitcoin/issues/12827 | Trivial: Dont use short version of tinyformat/fmt namespace by matthias-g · Pull Request #12827 · bitcoin/bitcoin · GitHub
2612018-03-29T13:25:02 <bitcoin-git> [bitcoin] matthias-g closed pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
2622018-03-29T13:26:21 *** Evel-Knievel has quit IRC
2632018-03-29T13:26:59 <fanquake> wumpus heh, looks like the second issue was fixing a problem with a specific IDE?
2642018-03-29T13:27:36 <wumpus> fanquake: apparently! I only now see it's an IDE, thought it was another analysis tool
2652018-03-29T13:29:13 <wumpus> there are so many of those, and while they can be useful, they tend to have lots of false positives too. Most of the PRs resulting from them solve false positives, not actual problems found.
2662018-03-29T13:31:00 <fanquake> Looks like #12790 can be merged.
2672018-03-29T13:31:03 <gribble> https://github.com/bitcoin/bitcoin/issues/12790 | [Tests] Use blockmaxweight where tests previously had blockmaxsize by conscott · Pull Request #12790 · bitcoin/bitcoin · GitHub
2682018-03-29T13:31:33 *** Randolf has quit IRC
2692018-03-29T13:33:52 *** lukedashjr has joined #bitcoin-core-dev
2702018-03-29T13:35:57 *** luke-jr has quit IRC
2712018-03-29T13:36:01 <wumpus> fanquake: indeed
2722018-03-29T13:36:46 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e80716d3b324...490644d29e64
2732018-03-29T13:36:46 <bitcoin-git> bitcoin/master b466f6b Conor Scott: [Tests] Use blockmaxweight where tests previously had blockmaxsize
2742018-03-29T13:36:47 <bitcoin-git> bitcoin/master 490644d Wladimir J. van der Laan: Merge #12790: [Tests] Use blockmaxweight where tests previously had blockmaxsize...
2752018-03-29T13:37:36 <bitcoin-git> [bitcoin] laanwj closed pull request #12790: [Tests] Use blockmaxweight where tests previously had blockmaxsize (master...12768_remove_blockmaxsize) https://github.com/bitcoin/bitcoin/pull/12790
2762018-03-29T13:38:20 *** lukedashjr is now known as luke-jr
2772018-03-29T13:39:57 *** aruns has quit IRC
2782018-03-29T13:40:24 <fanquake> wumpus also #12759 if you missed above.
2792018-03-29T13:40:26 <gribble> https://github.com/bitcoin/bitcoin/issues/12759 | [Docs] Improve formatting of developer notes by eklitzke · Pull Request #12759 · bitcoin/bitcoin · GitHub
2802018-03-29T13:42:25 <aj> wumpus: "our (or their or both)" is referring to --ours/--theirs/--union options respectively
2812018-03-29T13:42:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2822018-03-29T13:42:45 *** AaronvanW has quit IRC
2832018-03-29T13:43:20 *** AaronvanW has joined #bitcoin-core-dev
2842018-03-29T13:44:43 <wumpus> fanquake: yep, still looking at that one
2852018-03-29T13:45:20 *** jtimon has joined #bitcoin-core-dev
2862018-03-29T13:46:05 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/490644d29e64...d3908e2cee65
2872018-03-29T13:46:05 <bitcoin-git> bitcoin/master 0bd2ec5 Evan Klitzke: Improve formatting of developer notes...
2882018-03-29T13:46:06 <bitcoin-git> bitcoin/master d3908e2 Wladimir J. van der Laan: Merge #12759: [Docs] Improve formatting of developer notes...
2892018-03-29T13:46:56 <bitcoin-git> [bitcoin] laanwj closed pull request #12759: [Docs] Improve formatting of developer notes (master...developer-notes) https://github.com/bitcoin/bitcoin/pull/12759
2902018-03-29T13:47:54 *** AaronvanW has quit IRC
2912018-03-29T13:50:02 *** indistylo has joined #bitcoin-core-dev
2922018-03-29T13:58:16 *** Guyver2 has joined #bitcoin-core-dev
2932018-03-29T14:00:52 *** unholymachine has joined #bitcoin-core-dev
2942018-03-29T14:04:17 *** moneyball has joined #bitcoin-core-dev
2952018-03-29T14:05:00 *** moneyball has quit IRC
2962018-03-29T14:06:51 <bitcoin-git> [bitcoin] practicalswift closed pull request #12789: Don't return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) (master...CExtKey-junk) https://github.com/bitcoin/bitcoin/pull/12789
2972018-03-29T14:09:36 *** moneyball has joined #bitcoin-core-dev
2982018-03-29T14:15:21 <jnewbery> wumpus: if you're on a merge spree, #10762 and #11773 look ready
2992018-03-29T14:15:24 <gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
3002018-03-29T14:15:26 <gribble> https://github.com/bitcoin/bitcoin/issues/11773 | [tests] Change feature_block.py to use BitcoinTestFramework by jnewbery · Pull Request #11773 · bitcoin/bitcoin · GitHub
3012018-03-29T14:16:06 <wumpus> jnewbery: thanks, I'll have a look
3022018-03-29T14:17:17 <jtimon> https://github.com/bitcoin/bitcoin/pull/12172 got acks, then people asked for more things and I started to work on that but we decided to leave them out at the end
3032018-03-29T14:17:35 <bitcoin-git> [bitcoin] jnewbery opened pull request #12829: Python3 fixup (master...python3_fixup) https://github.com/bitcoin/bitcoin/pull/12829
3042018-03-29T14:17:39 <jtimon> so it should be ready too, I think
3052018-03-29T14:19:21 *** Randolf has joined #bitcoin-core-dev
3062018-03-29T14:21:01 *** arubi has quit IRC
3072018-03-29T14:21:30 *** arubi has joined #bitcoin-core-dev
3082018-03-29T14:30:44 <jtimon> hmm, https://travis-ci.org/bitcoin/bitcoin/builds/359681523 seems stuck or something
3092018-03-29T14:31:42 <wumpus> jtimon: looks like build 1 didn't even start yet?
3102018-03-29T14:32:09 <jtimon> I tried cancelling the job and restarting it, but yeah, it didn't even start
3112018-03-29T14:32:45 *** AaronvanW has joined #bitcoin-core-dev
3122018-03-29T14:34:25 <wumpus> it's possible that it's hanging on a previous PR/build and cannot allocate a builder to that, yet
3132018-03-29T14:34:46 <jnewbery> Perhaps we should just not update release-notes.md at all in individual PRs and just have the wiki page open from the beginning of the release cycle. PRs that require release notes can be tagged as requires_release_notes so we can verify that they all got done at the end of the cycle.
3142018-03-29T14:34:52 <jnewbery> Maybe something to discuss in the meeting
3152018-03-29T14:35:41 <wumpus> I'd never have expected the release notes to become a bottleneck. One positive thing about this is: people are writing release notes for their changes!
3162018-03-29T14:36:22 *** Randolf has quit IRC
3172018-03-29T14:36:23 <jnewbery> it's not a huge bottleneck, but it seems like a completely avoidable annoyance to have reviews invalidated by release-notes.md conflicts
3182018-03-29T14:37:05 <wumpus> yes, a wiki might be better for this, though on the other hand, having the changed synced to merges makes sense
3192018-03-29T14:37:12 <wumpus> changes*
3202018-03-29T14:38:12 *** user989098 has joined #bitcoin-core-dev
3212018-03-29T14:38:13 <jnewbery> yes, good point. Let's discuss in the meeting
3222018-03-29T14:38:37 *** user989098 has quit IRC
3232018-03-29T14:39:00 *** karimofthecrop has joined #bitcoin-core-dev
3242018-03-29T14:39:59 *** shesek` has quit IRC
3252018-03-29T14:42:47 <fanquake> Forgot it was meeting night tonight. Should probably make and effort to join.
3262018-03-29T14:44:28 *** karimofthecrop has quit IRC
3272018-03-29T14:47:26 <wumpus> that'd be cool, though I know it's not easy for that part of the world
3282018-03-29T14:48:23 *** laurentmt has joined #bitcoin-core-dev
3292018-03-29T14:48:42 *** zarez has quit IRC
3302018-03-29T14:48:52 *** zarez has joined #bitcoin-core-dev
3312018-03-29T14:50:43 *** shesek` has joined #bitcoin-core-dev
3322018-03-29T14:50:56 *** Krellan has quit IRC
3332018-03-29T14:51:35 *** Krellan has joined #bitcoin-core-dev
3342018-03-29T14:57:54 *** Lightsword has quit IRC
3352018-03-29T15:03:48 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3908e2cee65...6d53663a4339
3362018-03-29T15:03:49 <bitcoin-git> bitcoin/master 5fb5421 John Newbery: [wallet] Move wallet init functions into WalletInit class.
3372018-03-29T15:03:49 <bitcoin-git> bitcoin/master caaf972 John Newbery: [wallet] Create wallet init interface.
3382018-03-29T15:03:50 <bitcoin-git> bitcoin/master 49baa4a John Newbery: [wallet] Use global g_wallet_init_interface to init/destroy the wallet....
3392018-03-29T15:04:03 <bitcoin-git> [bitcoin] laanwj closed pull request #10762: [wallet] Remove Wallet dependencies from init.cpp (master...walletinit) https://github.com/bitcoin/bitcoin/pull/10762
3402018-03-29T15:05:10 *** Chris_Stewart_5 has quit IRC
3412018-03-29T15:06:09 *** psyopp has quit IRC
3422018-03-29T15:09:01 *** Randolf has joined #bitcoin-core-dev
3432018-03-29T15:16:50 *** zarez has quit IRC
3442018-03-29T15:17:00 *** zarez has joined #bitcoin-core-dev
3452018-03-29T15:17:46 <bitcoin-git> [bitcoin] jamesob opened pull request #12830: [qt] [tests] Clarify address book error messages, add tests (master...2018-03-27-send-recv-addressbook-error) https://github.com/bitcoin/bitcoin/pull/12830
3462018-03-29T15:23:03 *** karimofthecrop has joined #bitcoin-core-dev
3472018-03-29T15:28:00 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3482018-03-29T15:28:00 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3492018-03-29T15:29:12 *** juscamarena has joined #bitcoin-core-dev
3502018-03-29T15:32:44 *** arbitrary_guy has joined #bitcoin-core-dev
3512018-03-29T15:34:27 *** karimofthecrop has quit IRC
3522018-03-29T15:36:11 *** bule has joined #bitcoin-core-dev
3532018-03-29T15:36:20 *** indistylo has quit IRC
3542018-03-29T15:36:21 <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d53663a4339...f0f9732d05d7
3552018-03-29T15:36:21 <bitcoin-git> bitcoin/master 5cd01d2 John Newbery: [tests] Fix flake8 warnings in feature_block.py
3562018-03-29T15:36:22 <bitcoin-git> bitcoin/master 3898c4f John Newbery: [tests] Tidy up feature_block.py...
3572018-03-29T15:36:22 <bitcoin-git> bitcoin/master fc02c12 John Newbery: [tests] Add logging to feature_block.py
3582018-03-29T15:36:44 <bitcoin-git> [bitcoin] laanwj closed pull request #11773: [tests] Change feature_block.py to use BitcoinTestFramework (master...refactor_p2pfullblocktest) https://github.com/bitcoin/bitcoin/pull/11773
3592018-03-29T15:44:15 *** fanquake has quit IRC
3602018-03-29T15:47:51 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12831: [WIP] Run unit tests in parallel (master...Mf1803-qaUnitParallel) https://github.com/bitcoin/bitcoin/pull/12831
3612018-03-29T15:50:56 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3622018-03-29T15:55:13 *** moneyball has quit IRC
3632018-03-29T15:56:46 *** zarez has quit IRC
3642018-03-29T15:57:14 *** Randolf has quit IRC
3652018-03-29T15:58:06 *** ProfMac has quit IRC
3662018-03-29T15:59:38 *** ProfMac has joined #bitcoin-core-dev
3672018-03-29T16:00:36 *** laurentmt has quit IRC
3682018-03-29T16:06:22 *** JackH has quit IRC
3692018-03-29T16:09:41 *** grafcaps has joined #bitcoin-core-dev
3702018-03-29T16:13:50 *** ProfMac has quit IRC
3712018-03-29T16:15:17 *** ProfMac has joined #bitcoin-core-dev
3722018-03-29T16:32:42 *** harrymm has joined #bitcoin-core-dev
3732018-03-29T16:37:27 *** suldev has joined #bitcoin-core-dev
3742018-03-29T16:37:33 *** lnostdal has quit IRC
3752018-03-29T16:39:45 *** tryphe_ has quit IRC
3762018-03-29T16:40:11 *** tryphe_ has joined #bitcoin-core-dev
3772018-03-29T16:52:30 *** AriseChikun has joined #bitcoin-core-dev
3782018-03-29T16:53:22 *** pierre_rochard has joined #bitcoin-core-dev
3792018-03-29T16:53:40 *** pierre_rochard has joined #bitcoin-core-dev
3802018-03-29T16:56:06 *** rex4539 has quit IRC
3812018-03-29T17:01:27 *** Murch has joined #bitcoin-core-dev
3822018-03-29T17:09:06 *** tryphe_ has quit IRC
3832018-03-29T17:09:33 *** tryphe_ has joined #bitcoin-core-dev
3842018-03-29T17:11:55 *** Krellan has quit IRC
3852018-03-29T17:15:39 *** Samdney has joined #bitcoin-core-dev
3862018-03-29T17:22:57 *** moneyball has joined #bitcoin-core-dev
3872018-03-29T17:26:56 *** timothy has quit IRC
3882018-03-29T17:29:46 *** lnostdal has joined #bitcoin-core-dev
3892018-03-29T17:31:45 *** suldev has quit IRC
3902018-03-29T17:32:06 *** ProfMac has quit IRC
3912018-03-29T17:34:28 *** ProfMac has joined #bitcoin-core-dev
3922018-03-29T17:36:29 *** skeees has joined #bitcoin-core-dev
3932018-03-29T17:37:27 *** lnostdal has quit IRC
3942018-03-29T17:40:06 *** warren has quit IRC
3952018-03-29T17:40:06 *** adam3us has quit IRC
3962018-03-29T17:40:18 *** laurentmt has joined #bitcoin-core-dev
3972018-03-29T17:47:43 *** Evel-Knievel has joined #bitcoin-core-dev
3982018-03-29T17:47:53 *** laurentmt has quit IRC
3992018-03-29T17:48:30 *** timothy has joined #bitcoin-core-dev
4002018-03-29T17:49:10 *** timothy has quit IRC
4012018-03-29T17:49:12 *** Chris_Stewart_5 has quit IRC
4022018-03-29T17:49:19 *** lnostdal has joined #bitcoin-core-dev
4032018-03-29T18:00:21 *** ProfMac has quit IRC
4042018-03-29T18:02:14 <wumpus> wtf is up with travis: https://travis-ci.org/bitcoin/bitcoin/jobs/359847093 - looks like it creates a shallow clone, then tries to check out an older commit
4052018-03-29T18:02:33 <wumpus> I think this happens before our own script kicks in
4062018-03-29T18:06:35 *** lnostdal has quit IRC
4072018-03-29T18:07:16 <arubi> wumpus, the config tab shows '"depth": 1'
4082018-03-29T18:07:54 <arubi> so for some reason .travis.yml is set to that..? weird
4092018-03-29T18:09:48 <wumpus> but that's nothing new
4102018-03-29T18:09:53 <ken2812221> Maybe this job must be auto-cancelled
4112018-03-29T18:10:00 *** lnostdal has joined #bitcoin-core-dev
4122018-03-29T18:10:50 <wumpus> depth was changed to 1 in fa79016ab0d23aa3d2c0322ab6be90b37dcd01c1, that's two week ago, not sure why it'd start giving problems now
4132018-03-29T18:11:12 <wumpus> fa44af5cd2152a21da9ef3e48c073a668bf2df27 added depth: false
4142018-03-29T18:11:23 <arubi> hm
4152018-03-29T18:11:25 <wumpus> (feb 10)
4162018-03-29T18:11:32 <wumpus> before that, we had no depth defined in the yml
4172018-03-29T18:17:44 <wumpus> (which effectively means depth=1 IIRC)
4182018-03-29T18:19:54 <arubi> it's 50 I think
4192018-03-29T18:24:28 <wumpus> so maybe it'd be better to remove the depth specification and leave it up to travis again
4202018-03-29T18:25:57 <wumpus> on the other hand, this way it spends less time building old master commits :-)
4212018-03-29T18:34:13 *** skypper has joined #bitcoin-core-dev
4222018-03-29T18:40:16 *** moneyball has quit IRC
4232018-03-29T18:41:45 *** ProfMac has joined #bitcoin-core-dev
4242018-03-29T18:47:03 *** moneyball has joined #bitcoin-core-dev
4252018-03-29T18:49:10 *** nitramiz has joined #bitcoin-core-dev
4262018-03-29T18:58:50 *** CubicEar_ has quit IRC
4272018-03-29T18:59:19 *** CubicEarths has joined #bitcoin-core-dev
4282018-03-29T19:00:09 *** Victorsueca has quit IRC
4292018-03-29T19:00:43 <sipa> meeting time?
4302018-03-29T19:00:48 <jnewbery> hello
4312018-03-29T19:01:06 <eklitzke> hi
4322018-03-29T19:01:14 <provoostenator> hi
4332018-03-29T19:01:27 <bitcoin-git> [bitcoin] Sjors opened pull request #12833: WIP [qt] move QSettings to bitcoin.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
4342018-03-29T19:01:28 *** Victorsueca has joined #bitcoin-core-dev
4352018-03-29T19:01:50 <achow101> meting?
4362018-03-29T19:02:06 <sipa> meeting, me think
4372018-03-29T19:02:14 <jamesob_> yo
4382018-03-29T19:03:30 <sipa> wumpus: ?
4392018-03-29T19:03:37 <jimpo> hi
4402018-03-29T19:03:52 <wumpus> #startmeeting
4412018-03-29T19:03:52 <lightningbot> Meeting started Thu Mar 29 19:03:52 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4422018-03-29T19:03:52 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4432018-03-29T19:03:56 <BlueMatt> my high-priority: #11775 (yay, I have one again)
4442018-03-29T19:03:58 <gribble> https://github.com/bitcoin/bitcoin/issues/11775 | Move fee estimator into validationinterface/cscheduler thread by TheBlueMatt · Pull Request #11775 · bitcoin/bitcoin · GitHub
4452018-03-29T19:04:04 <wumpus> (DST sucks)
4462018-03-29T19:04:24 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
4472018-03-29T19:04:37 <kanzure> hi.
4482018-03-29T19:04:39 <cfields> hi
4492018-03-29T19:05:21 <wumpus> #topic high priority for review
4502018-03-29T19:05:39 *** bule has quit IRC
4512018-03-29T19:05:42 <jnewbery> BlueMatt: needs rebase again. Sorry!
4522018-03-29T19:05:42 <wumpus> BlueMatt: added
4532018-03-29T19:05:59 <instagibbs> hi
4542018-03-29T19:06:15 <BlueMatt> jnewbery: well its a trivial rebase that shouldnt materially effect review
4552018-03-29T19:06:21 <jamesob_> I'd like to nominate ryanofsky's #10244. The burden of rebasing/conflict resolution is high and I think it's in pretty good shape (though needs rebase atm).
4562018-03-29T19:06:25 <gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
4572018-03-29T19:06:37 <provoostenator> agreed
4582018-03-29T19:06:53 <BlueMatt> can we make that a topic? I'd like to discuss it in more depth
4592018-03-29T19:07:12 <BlueMatt> (10244, that is)
4602018-03-29T19:07:24 <jnewbery> +1. Seems to be getting some review traction. It'd be a shame for that to go to waste
4612018-03-29T19:07:44 <wumpus> #topic separate gui from wallet and node (#10244)
4622018-03-29T19:07:48 <gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
4632018-03-29T19:08:34 <ryanofsky> did you have a question BlueMatt?
4642018-03-29T19:08:38 <BlueMatt> yea, sec
4652018-03-29T19:09:02 <wumpus> I've... already said everything I wanted to said about that, won't repeat myself
4662018-03-29T19:09:18 <BlueMatt> so I guess I'm more of a fan of this than the wallet/main split, but I feel like we need to think a bit harder about the api between the gui/wallet+main before we go split it
4672018-03-29T19:09:30 <BlueMatt> I mean some of these things maybe shouldnt be blocking calls
4682018-03-29T19:09:40 <wumpus> TBH we discussed this at the new york meeting
4692018-03-29T19:09:52 <wumpus> and the agreement was that this could be improved after it goes in
4702018-03-29T19:09:57 <BlueMatt> ok, well I will shut up, then, if its been beaten to death
4712018-03-29T19:09:59 <BlueMatt> ok, nvm
4722018-03-29T19:10:12 <wumpus> I'm ok with that. I'd have preferred to make the GUI asynchronous first
4732018-03-29T19:10:20 <wumpus> but Iom' not going to beat that topic to death
4742018-03-29T19:10:21 <wumpus> right
4752018-03-29T19:10:25 <ryanofsky> api is definitely meant to be improved, especially the init stuff which is pretty ugly
4762018-03-29T19:10:32 <kanzure> are there any big blockers to asynchronous gui things?
4772018-03-29T19:10:38 <BlueMatt> yea, I mean that was what I was gonna say, but if there was agreement its not worth re-opening the book on that to discuss
4782018-03-29T19:10:42 <wumpus> no, it's just a different set of work
4792018-03-29T19:11:21 <wumpus> it's somewhat orthogonal to this - my gut just hates blocking RPC calls in GUI threads, it's more of an instinctive revulsion than anything I can explain, so I'll just go along
4802018-03-29T19:11:39 <jamesob_> this PR introduces no RPC calls
4812018-03-29T19:11:47 <provoostenator> I think part of the understanding was that this interface should be considered very much not final.
4822018-03-29T19:11:53 <BlueMatt> jamesob_: it introduces a whole new rpc interface...
4832018-03-29T19:11:57 <wumpus> it does, it introduces an RPC layer between the wallet and the core
4842018-03-29T19:12:03 <provoostenator> Just having _an_ interface was step one.
4852018-03-29T19:12:06 <wumpus> please don't deny that
4862018-03-29T19:12:12 <BlueMatt> anyway, next topic?
4872018-03-29T19:12:22 <wumpus> yes, any other topic suggestions?
4882018-03-29T19:12:33 <sipa> wumpus: i think jamesob_ means RPC as in the existing JSON RPC system
4892018-03-29T19:12:40 <sipa> not RPC as a generic term
4902018-03-29T19:12:50 <jamesob_> correct
4912018-03-29T19:12:56 <wumpus> ok, yes, RPC is a general term for cross-process calls
4922018-03-29T19:13:14 <ryanofsky> jamesob_, an earlier version of this pr did mention ipc, but i took that stuff out
4932018-03-29T19:13:15 <jnewbery> This first step isn't cross-process
4942018-03-29T19:13:40 <BlueMatt> lol, ok, so any topics *aside* from debating rpc/ipc/whatever terminology?
4952018-03-29T19:13:44 <wumpus> yes...
4962018-03-29T19:14:12 <jnewbery> topic suggestion (quick one): release notes conflicts
4972018-03-29T19:14:36 <wumpus> #topic release notes conflicts
4982018-03-29T19:14:41 <jnewbery> I don't think it's a major issue, but it is irritating to have reviews invalidated due to release notes conflicts
4992018-03-29T19:14:57 <jnewbery> options: 1) do nothing because it's not a huge issue
5002018-03-29T19:14:58 <wumpus> could do them in a separate commit, at the end
5012018-03-29T19:15:10 <sipa> do we know if githubdeals correctly with the gitattributes merge=union stuff?
5022018-03-29T19:15:14 <wumpus> oh wait that doesn't help with rebases...
5032018-03-29T19:15:18 <achow101> Maybe we should have the release notes dev wiki thing continuously up and people just add stuff to it as needed
5042018-03-29T19:15:33 <jnewbery> 2) don't use release_notes.md and just use a wiki for the whole release cycle
5052018-03-29T19:15:46 <jnewbery> 3) have separate release_notes files for each PR and merge them at the end
5062018-03-29T19:15:48 <BlueMatt> I mean as long as its a separate commit no reason to invalidate reviews
5072018-03-29T19:15:49 <jnewbery> 4) ?
5082018-03-29T19:16:16 <sipa> 4) is the merge=union thing?
5092018-03-29T19:16:29 <jnewbery> merge=union doesn't help with github I think
5102018-03-29T19:16:33 <achow101> I prefer 2
5112018-03-29T19:16:41 <sipa> i don't like 2
5122018-03-29T19:16:47 <sipa> too much process overhead
5132018-03-29T19:16:55 <wumpus> achow101: I think the only argument against 2 is that it decouples the merge from the release mode update
5142018-03-29T19:17:01 <wumpus> notes*
5152018-03-29T19:17:06 <ryanofsky> an option 4) would be to insert 50-100 blank lines in the file, and add release new notes in the blank space. this would avoid most conflicts
5162018-03-29T19:17:10 <jnewbery> sipa: https://github.com/isaacs/github/issues/487
5172018-03-29T19:17:14 <cfields> outside the box: notes can be added as individual files and aggregated at the end
5182018-03-29T19:17:23 <wumpus> so the author of the PR has to update the wiki after their thing was merged
5192018-03-29T19:17:25 <sipa> jnewbery: right, but we also.don't really use github for merges
5202018-03-29T19:17:30 <wumpus> cfields: unless they somehow interact :)
5212018-03-29T19:17:38 <sipa> i mean more... how does it affect our github merge scriot etc
5222018-03-29T19:17:41 <jnewbery> cfields: I think that's 3
5232018-03-29T19:17:45 <sipa> which compares with the github merge
5242018-03-29T19:17:55 <instagibbs> sipa, would be annoying to see conflict on GUI and just hope it's a merge we can avoid directly handling
5252018-03-29T19:18:06 <sipa> instagibbs: fair
5262018-03-29T19:18:07 <cfields> jnewbery: ah yes, missed 3.
5272018-03-29T19:18:11 <sipa> i think my preference is 3
5282018-03-29T19:18:15 <wumpus> cfields: I mean, sometimes an update to the release notes updates/extends earlier text - though
5292018-03-29T19:18:15 <sdaftuar> i like 3 too
5302018-03-29T19:18:17 <instagibbs> maybe i need to learn that tool better, might give a better view of it
5312018-03-29T19:18:17 <ryanofsky> link describing option 4: https://about.gitlab.com/2015/02/10/gitlab-reduced-merge-conflicts-by-90-percent-with-changelog-placeholders/
5322018-03-29T19:18:17 <jamesob_> I like 3
5332018-03-29T19:18:30 <BlueMatt> option n) leave release notes as a comment on pr and tag the release-notes-needed issue
5342018-03-29T19:18:31 <wumpus> cfields: storing it *per section* would still help!
5352018-03-29T19:18:32 <BlueMatt> easy to merge at the end
5362018-03-29T19:18:37 <BlueMatt> and they exist in the pr itself
5372018-03-29T19:18:44 <ryanofsky> i also like 3 best
5382018-03-29T19:19:04 <wumpus> 'leave it to the maintainer at the end' is not an option :p
5392018-03-29T19:19:23 <sipa> it may be a release notes file per "feature" too, i think, if multiple PRs sequentially update the se thing
5402018-03-29T19:19:41 <jnewbery> sipa: sounds reasonable, if they're serial
5412018-03-29T19:19:46 <sipa> right
5422018-03-29T19:19:55 <jimpo> Yeah, I like the idea of basically having a file for each section in the current release notes
5432018-03-29T19:19:59 <wumpus> I mean what you want to avoid is that *unrelated* PRs collide in the release notes
5442018-03-29T19:20:17 <sipa> wumpus: yyp
5452018-03-29T19:20:23 <wumpus> if PRs that already affect the same thing collide, that's not too bad, because the code likely does too
5462018-03-29T19:21:05 *** phantomcircuit has quit IRC
5472018-03-29T19:21:30 *** Murchone has joined #bitcoin-core-dev
5482018-03-29T19:22:37 <wumpus> so yes, 3 sounds like a good idea to me, though it might be overdesign for something that doesn't cause too much trouble in practice, I wonder if anyone will actually do it
5492018-03-29T19:23:06 <sipa> we can see how it plays out
5502018-03-29T19:23:11 <jnewbery> if it's in the developer notes, then I think people will do it
5512018-03-29T19:23:22 <jnewbery> I'll do it for my PRs to avoid conflicts
5522018-03-29T19:24:04 <jamesob_> could add a lint step to the build that fails if the PR touches the main release notes files as well as src/ files
5532018-03-29T19:24:04 <wumpus> definitely needs to be in the developer notes, like "what directory to use for partial release notes'
5542018-03-29T19:24:11 <wumpus> oh no no more lints
5552018-03-29T19:24:31 <jnewbery> I think that's probably enough discussion. As long as the maintainers don't object to partial release notes then individual contributors can start using them
5562018-03-29T19:24:36 *** Murch has quit IRC
5572018-03-29T19:24:38 <wumpus> I get quite angry if yet another redundant python import breaks travis
5582018-03-29T19:24:53 <jamesob_> suggestion retracted :)
5592018-03-29T19:24:59 <instagibbs> I don't even think there's contribution notes yet
5602018-03-29T19:25:03 <instagibbs> for release notes
5612018-03-29T19:25:07 <wumpus> jamesob_: sorry :)
5622018-03-29T19:25:09 <instagibbs> i had to ask promag
5632018-03-29T19:25:14 <jnewbery> wumpus: is that not caught in the PR's travis run?
5642018-03-29T19:25:16 *** Murch has joined #bitcoin-core-dev
5652018-03-29T19:25:27 <wumpus> jnewbery: I think it is
5662018-03-29T19:26:56 <sipa> topic suggestion: avoid undefined behaviour when it shouldn't matter? (#12789)
5672018-03-29T19:26:58 <gribble> https://github.com/bitcoin/bitcoin/issues/12789 | Dont return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) by practicalswift · Pull Request #12789 · bitcoin/bitcoin · GitHub
5682018-03-29T19:27:11 <wumpus> #topic avoid undefined behaviour when it shouldn't matter?
5692018-03-29T19:27:18 <jtimon> ryanofsky: why not just create a separated pr editing the release notes after the actual pr doing things has been merged?
5702018-03-29T19:27:31 <BlueMatt> "shouldnt"
5712018-03-29T19:27:36 <sipa> i bring it up here because it may be something we should or shouldn't have as a guideline
5722018-03-29T19:28:10 <sipa> for example, should you initialize a variable that isn't read anywhere, because soke compiler warning fails to understand it isn't being read?
5732018-03-29T19:28:22 <sipa> argument in favor: more deterministic failures
5742018-03-29T19:28:24 <BlueMatt> oh, well that isnt "shouldnt"
5752018-03-29T19:28:35 <BlueMatt> that is "doesnt, but compiler warns"
5762018-03-29T19:28:38 <sipa> argument against: reduces the ability for tools to detect things stativally
5772018-03-29T19:29:03 <provoostenator> Other argument in favor: means a linter can catch all uninitialized variables.
5782018-03-29T19:29:04 <sipa> well i say shouldn't, because reviewers may be wrong and the compiler may be right
5792018-03-29T19:29:08 <wumpus> jtimon: that's a possibility too, though like the wiki option it decouples the code change from the release notes change itselff
5802018-03-29T19:29:10 *** Murchone has quit IRC
5812018-03-29T19:29:25 <wumpus> jtimon: also: EVEN MORE PRs :(
5822018-03-29T19:29:36 <jtimon> wumpus: yep, although I guess the bigger drawback is more prs
5832018-03-29T19:29:38 <jtimon> right
5842018-03-29T19:29:43 <BlueMatt> I mean if its at all tricky to show that it *wont* be read, then should def follow the compiler, but the nonstop stream of "this compiler is shit and warned on something that it shouldnt be" prs is....not ideal
5852018-03-29T19:30:02 <wumpus> yeah...
5862018-03-29T19:30:24 <BlueMatt> honestly of all those pros/cons, the pr volume is probably the most important imnsho
5872018-03-29T19:30:26 <wumpus> so many *fix some and some false positive for my crappy static analysis tool/compiler with warnings jacked up*
5882018-03-29T19:30:37 <sipa> i generally dislike the "compiler/analyzer/linter/tool doesn't understand X, let's initialize everything to shut it up"
5892018-03-29T19:30:43 <wumpus> me too
5902018-03-29T19:30:48 <wumpus> just fix your tools FFS
5912018-03-29T19:30:59 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12823: doc: Switch release-notes.md to union merge (master...Mf1803-docGitattributes) https://github.com/bitcoin/bitcoin/pull/12823
5922018-03-29T19:31:18 <wumpus> if it's correct, human-understandable C++ code and we know there's no problems with it, it should not be changes because compiler blabla
5932018-03-29T19:31:31 <wumpus> too risky, too
5942018-03-29T19:31:31 <sipa> or improve the code so it is easier for tools (and humans) to see it is correct
5952018-03-29T19:31:42 <wumpus> if it's not broken don't change it
5962018-03-29T19:31:47 <sipa> true
5972018-03-29T19:31:56 <sipa> ok, just wanted to hear opinions about this
5982018-03-29T19:32:11 <wumpus> unless it's a refactor to prepare for osmething else, of course, but that wasn't the premise :)
5992018-03-29T19:32:51 <wumpus> so I think we agree
6002018-03-29T19:32:56 <sipa> yes
6012018-03-29T19:32:59 <wumpus> any other topics?
6022018-03-29T19:33:49 <jtimon> BlueMatt: I don't know, will more volume of prs specific to release notes be that much more cumbersome?
6032018-03-29T19:34:06 *** Murch has quit IRC
6042018-03-29T19:34:07 <wumpus> jtimon: yes. In that case I prefer the wiki
6052018-03-29T19:34:10 <BlueMatt> less so than code-change pr volume
6062018-03-29T19:34:15 <BlueMatt> but whatever
6072018-03-29T19:34:25 <jnewbery> wumpus: I agree
6082018-03-29T19:34:32 <wumpus> that's why we have the wiki-phase at all before releases, to prevent a jungle of update-release-notes PRs
6092018-03-29T19:34:33 <jtimon> yeah, I mean, I don't have a strong opinion either way
6102018-03-29T19:34:51 <wumpus> (which will also conflict with each other! though easier to rebase..)
6112018-03-29T19:35:05 <ryanofsky> jtimon, imo including release notes along with changes makes changes easier to understand, and also probably more well thought out
6122018-03-29T19:35:07 <wumpus> yes, it's better than code-change PR volume that's for sure
6132018-03-29T19:35:17 <wumpus> ryanofsky: hey that's a good point
6142018-03-29T19:36:19 <jtimon> sipa: sometimes warning are useful, sometimes they are not and it's alright to leave them there. but not sure what the discussion is. nobody is proposing we use -Werror, right?
6152018-03-29T19:36:33 <wumpus> I remember seeing the 'release notes per item' before in some project, not sure which
6162018-03-29T19:36:59 <jtimon> ryanofsky: I agree, but then you have to deal with rebases, I don't see a way around it
6172018-03-29T19:37:24 <wumpus> jtimon: warning being good or evil wasn't what the topic was about
6182018-03-29T19:37:45 <sipa> jtimon: my view is (for example) that if you systemativally initialize every variable (even those for which you know won't be used), you will lose the ability for the compiler to give you warnings about accidentially uninitialized things
6192018-03-29T19:38:05 <jtimon> wumpus: that's what I'm saying, that I'm not sure what the topic is
6202018-03-29T19:38:15 <sipa> this is more general than just compiler warnings, and variable initialization though
6212018-03-29T19:38:29 <wumpus> at ASML we had that as part of the C coding standard - every, single, variable had to be initialized
6222018-03-29T19:38:41 <wumpus> no I don't think we need that here :)
6232018-03-29T19:38:44 *** SopaXorzTaker has quit IRC
6242018-03-29T19:39:44 <cfields> sipa: yes, i really like newer gcc/clang's ability to warn about being unitialized for one or more paths
6252018-03-29T19:40:27 <wumpus> I do think all class variables should be initialized in the constructor, in general
6262018-03-29T19:40:43 *** juscamarena has quit IRC
6272018-03-29T19:41:50 <cfields> wumpus: agreed, but I'd like to start using more c++11 member-initialization for trivial types as it's so much less verbose
6282018-03-29T19:41:51 <wumpus> cfields: they had that in the static analyzer for quite a while, now it moved to a compiler warning, a good thing
6292018-03-29T19:42:16 <cfields> right
6302018-03-29T19:42:53 *** Murch has joined #bitcoin-core-dev
6312018-03-29T19:42:54 <wumpus> cfields: yes, that's a nicer syntax
6322018-03-29T19:43:43 <wumpus> ok, any other topics?
6332018-03-29T19:44:23 <sipa> seems not
6342018-03-29T19:44:25 <wumpus> #endmeeting
6352018-03-29T19:44:25 <lightningbot> Meeting ended Thu Mar 29 19:44:25 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6362018-03-29T19:44:25 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.html
6372018-03-29T19:44:25 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.txt
6382018-03-29T19:44:25 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.log.html
6392018-03-29T19:46:21 *** dafunkiz_ has joined #bitcoin-core-dev
6402018-03-29T19:48:35 *** jamesob_ has quit IRC
6412018-03-29T19:57:39 <cfields> out of curiosity, does the c spec allow for compilers to ignore initializers if a value is always set before it's used?
6422018-03-29T19:58:06 <wumpus> only if there are no side effects
6432018-03-29T19:58:13 <cfields> i'm wondering if compilers are allowed to do the opposite optimization: you always initialize, but it removes them when possible.
6442018-03-29T19:58:54 <BlueMatt> the compiler could run any obvious part of your program and just change the program to have the same effective in/out results, so....yes?
6452018-03-29T19:59:02 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6462018-03-29T19:59:07 <wumpus> ^^
6472018-03-29T19:59:27 <BlueMatt> see-also: crypto-memset
6482018-03-29T19:59:48 <wumpus> the C spec wouldn't say anything on that, because it's not visible to the code in any path
6492018-03-29T19:59:50 <luke-jr> ETA until compilers try to do IBD for you?
6502018-03-29T19:59:54 <luke-jr> âº
6512018-03-29T20:00:14 <BlueMatt> luke-jr: they'll fail on the first net access :(
6522018-03-29T20:00:32 <luke-jr> BlueMatt: yes, I'm joking :P
6532018-03-29T20:01:06 <wumpus> luke-jr: only if you manage to do blockvalidation in c++78 metaprogramming
6542018-03-29T20:01:54 <wumpus> (or maybe it's already possible with current standards, at least compile time hashing is already possible :-)
6552018-03-29T20:02:39 <cfields> heh
6562018-03-29T20:03:28 <BlueMatt> rust has a fucking full ast interpreter in the front-end compiler now, to in the future run anything with no io as a constexpr.......
6572018-03-29T20:05:31 <wumpus> that's an interesting choice
6582018-03-29T20:05:59 <BlueMatt> or, well, thats a possible future use for it, but they have an interpreter in the front-end
6592018-03-29T20:06:07 <wumpus> the drawback with c++ compile-time metaprogramming has always been that it's really slow, as it's circuitous because it (ab)uses features meant for something else. So, why not just include an ast interpreter.
6602018-03-29T20:06:36 <wumpus> (compile-time slow, I mean)
6612018-03-29T20:09:21 <wumpus> so apparently the Tor project is working on porting parts to rust
6622018-03-29T20:12:03 <wumpus> not sure what parts, but it has always been an exclusively C codebase before
6632018-03-29T20:12:09 <booyah> also, what for
6642018-03-29T20:12:19 *** lnostdal has quit IRC
6652018-03-29T20:12:32 <booyah> after decades it's probably rather safe from low-level errors, isn't it
6662018-03-29T20:12:39 <wumpus> hehe :)
6672018-03-29T20:12:49 <wumpus> that's anyone's guess, really
6682018-03-29T20:13:00 <BlueMatt> seems premature tbh to me, mostly cause if you want to, eg, compile it on debian stable you have to use a super-old version of rust and end up getting a billion warnings from recent versions telling you to use new syntax :(
6692018-03-29T20:13:46 <wumpus> debian stable is the problem there
6702018-03-29T20:13:46 <sipa> cfields: not only can they, i believe that SSA transforms will pretty much automatically do that
6712018-03-29T20:14:23 <BlueMatt> wumpus: true, but, what, you're gonna not support debian stable? so...you lose, what, 1/5 your users?
6722018-03-29T20:14:49 <cfields> sipa: so there's no (performance) downside of initialize-by-default as a rule?
6732018-03-29T20:15:00 <wumpus> BlueMatt: but the only way to pressure them into upgrading their rust version is likely for major projects to start using it, it's always a chicken/egg problem
6742018-03-29T20:15:27 <BlueMatt> why would they make an exception to their ship-only-insanely-out-of-date-software rule for a *compiler*?
6752018-03-29T20:15:33 <wumpus> if e.g. bitcoin would start using it, no one would care, but something like tor has quite a lot of influence I think
6762018-03-29T20:15:38 <BlueMatt> that seems like the one thing they'd be least likely to make an exception for
6772018-03-29T20:15:50 <wumpus> oh we'll see
6782018-03-29T20:17:21 <wumpus> I'm glad someone is taking the initative there that's not me
6792018-03-29T20:17:31 *** dafunkiz_ has quit IRC
6802018-03-29T20:18:50 <BlueMatt> lol, well at least we succeeded at getting them to stop shiping bitcoin
6812018-03-29T20:18:51 <wumpus> firefox is likely the main pusher for (decent) rust support in distros
6822018-03-29T20:18:54 <BlueMatt> maybe if the tor folks also succeed
6832018-03-29T20:19:09 <BlueMatt> debian already stopped shipping firefox a long time ago :p
6842018-03-29T20:19:16 <BlueMatt> (because of this exact issue, too....)
6852018-03-29T20:19:37 <wumpus> huh? really?
6862018-03-29T20:19:54 *** dafunkiz_ has joined #bitcoin-core-dev
6872018-03-29T20:19:54 <BlueMatt> iceweasel, yo
6882018-03-29T20:20:15 <wumpus> iceweasel is simply a rebranded firefox
6892018-03-29T20:20:29 <wumpus> because of some license issue...
6902018-03-29T20:20:29 <BlueMatt> yes, but they had to because they wanted to ship super old versions and that wasnt allowed
6912018-03-29T20:20:43 <BlueMatt> afair
6922018-03-29T20:21:15 <BlueMatt> (among other issues)
6932018-03-29T20:21:27 <wumpus> shipping old versions of browsers is really dangerous
6942018-03-29T20:21:52 <BlueMatt> yes, just pointing out that debian was so headstrong in their desire to do stupid insecure shit that they rebranded firefox for it....
6952018-03-29T20:22:54 <wumpus> yes I didn't know that was the reason
6962018-03-29T20:22:57 *** Giszmo has quit IRC
6972018-03-29T20:23:21 <BlueMatt> i mean i may be misrecalling, but I believe that was one of the things that violated the acceptable-use license that firefox required to use their branding
6982018-03-29T20:23:27 <BlueMatt> (among a few other issues)
6992018-03-29T20:25:06 *** lnostdal has joined #bitcoin-core-dev
7002018-03-29T20:26:25 *** suldev has joined #bitcoin-core-dev
7012018-03-29T20:27:13 <cfields> I thought debian was back to firefox now?
7022018-03-29T20:27:23 <cfields> iirc the tm issue was resolved somehow
7032018-03-29T20:28:27 <BlueMatt> seems like it, yes, still, my point stands
7042018-03-29T20:28:52 *** rls has joined #bitcoin-core-dev
7052018-03-29T20:35:02 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0f9732d05d7...252c1b0faef4
7062018-03-29T20:35:03 <bitcoin-git> bitcoin/master 5de2b18 John Newbery: [contrib] fixup security-check.py Python3 support
7072018-03-29T20:35:04 <bitcoin-git> bitcoin/master f50975b John Newbery: [contrib] fixup symbol-check.py Python3 support
7082018-03-29T20:35:04 <bitcoin-git> bitcoin/master 252c1b0 Wladimir J. van der Laan: Merge #12829: Python3 fixup...
7092018-03-29T20:35:47 <bitcoin-git> [bitcoin] laanwj closed pull request #12829: Python3 fixup (master...python3_fixup) https://github.com/bitcoin/bitcoin/pull/12829
7102018-03-29T20:37:23 *** lnostdal has quit IRC
7112018-03-29T20:41:44 *** Giszmo has joined #bitcoin-core-dev
7122018-03-29T20:46:05 *** Giszmo has quit IRC
7132018-03-29T20:47:06 <sipa> cfields: there is when the compiler can't figure out the value is unused
7142018-03-29T20:48:21 <sipa> but in the naive situatiin where there are no branches/loops that conplicate flow analysis, sure
7152018-03-29T20:48:21 *** andytoshi has quit IRC
7162018-03-29T20:48:22 *** andytoshi has joined #bitcoin-core-dev
7172018-03-29T20:48:39 *** lnostdal has joined #bitcoin-core-dev
7182018-03-29T20:58:01 *** d9b4bef9 has quit IRC
7192018-03-29T20:58:46 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/252c1b0faef4...de6bdfd78f22
7202018-03-29T20:58:46 <bitcoin-git> bitcoin/master 6feb46c Evan Klitzke: Add --with-sanitizers option to configure...
7212018-03-29T20:58:47 <bitcoin-git> bitcoin/master de6bdfd Wladimir J. van der Laan: Merge #12692: Add configure options for various -fsanitize flags...
7222018-03-29T20:59:07 *** d9b4bef9 has joined #bitcoin-core-dev
7232018-03-29T20:59:24 <bitcoin-git> [bitcoin] laanwj closed pull request #12692: Add configure options for various -fsanitize flags (master...sanitize) https://github.com/bitcoin/bitcoin/pull/12692
7242018-03-29T21:00:04 *** Guest2527 has joined #bitcoin-core-dev
7252018-03-29T21:02:57 <bitcoin-git> [bitcoin] laanwj closed pull request #12774: Issue #10542 Signmessage doesn't work with segwit addresses (master...master) https://github.com/bitcoin/bitcoin/pull/12774
7262018-03-29T21:05:51 *** Giszmo has joined #bitcoin-core-dev
7272018-03-29T21:06:56 *** Randolf has joined #bitcoin-core-dev
7282018-03-29T21:08:32 <bitcoin-git> [bitcoin] laanwj closed pull request #12124: [wallet] Remove segwit status check (master...master) https://github.com/bitcoin/bitcoin/pull/12124
7292018-03-29T21:09:26 <sipa> m-m-m-multiclose PR
7302018-03-29T21:09:36 <wumpus> hehe
7312018-03-29T21:10:46 *** dafunkiz_ has quit IRC
7322018-03-29T21:13:21 *** dafunkiz_ has joined #bitcoin-core-dev
7332018-03-29T21:14:45 *** dafunkiz_ has quit IRC
7342018-03-29T21:16:08 *** grafcaps has quit IRC
7352018-03-29T21:17:47 *** dafunkiz_ has joined #bitcoin-core-dev
7362018-03-29T21:19:05 *** moneyball has quit IRC
7372018-03-29T21:23:57 *** Chris_Stewart_5 has quit IRC
7382018-03-29T21:24:35 *** Victorsueca has quit IRC
7392018-03-29T21:25:43 *** Victorsueca has joined #bitcoin-core-dev
7402018-03-29T21:28:33 <wumpus> hm we should probably have discussed #12764 at the meeting
7412018-03-29T21:28:34 <gribble> https://github.com/bitcoin/bitcoin/issues/12764 | Remove field in getblocktemplate help that has never been used. by conscott · Pull Request #12764 · bitcoin/bitcoin · GitHub
7422018-03-29T21:29:17 <wumpus> not sure if having the help conform to BIP22 or to our current implementation of it is better
7432018-03-29T21:31:04 <luke-jr> wumpus: I'd be inclined to just point to BIP 22 and leave the docs at that.
7442018-03-29T21:33:10 *** grafcaps has joined #bitcoin-core-dev
7452018-03-29T21:36:39 <wumpus> that'd be another option
7462018-03-29T21:42:51 *** grafcaps has quit IRC
7472018-03-29T21:46:49 *** jb55 has joined #bitcoin-core-dev
7482018-03-29T21:51:35 *** meshcollider has joined #bitcoin-core-dev
7492018-03-29T21:55:58 *** skeees has quit IRC
7502018-03-29T21:56:27 *** Cogito_Ergo_Sum has quit IRC
7512018-03-29T21:58:31 *** wxss_ has joined #bitcoin-core-dev
7522018-03-29T22:01:27 *** wxss has quit IRC
7532018-03-29T22:11:13 *** jb55 has quit IRC
7542018-03-29T22:12:19 *** jb55 has joined #bitcoin-core-dev
7552018-03-29T22:12:41 *** wxss_ has quit IRC
7562018-03-29T22:16:51 *** jb55 has quit IRC
7572018-03-29T22:18:10 *** skypper has quit IRC
7582018-03-29T22:20:34 *** dafunkiz_ has quit IRC
7592018-03-29T22:27:02 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de6bdfd78f22...3b62a9138657
7602018-03-29T22:27:02 <bitcoin-git> bitcoin/master cb1e319 Jorge Timón: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished
7612018-03-29T22:27:03 <bitcoin-git> bitcoin/master 3b62a91 Wladimir J. van der Laan: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished...
7622018-03-29T22:27:37 <bitcoin-git> [bitcoin] laanwj closed pull request #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished (master...b16-bugfix-savemempool) https://github.com/bitcoin/bitcoin/pull/12172
7632018-03-29T22:39:46 *** spinza has quit IRC
7642018-03-29T22:44:34 *** nitramiz has quit IRC
7652018-03-29T22:55:50 *** suldev has quit IRC
7662018-03-29T23:04:01 *** BashCo has quit IRC
7672018-03-29T23:04:58 *** BashCo has joined #bitcoin-core-dev
7682018-03-29T23:05:09 *** suldev has joined #bitcoin-core-dev
7692018-03-29T23:07:09 *** spinza has joined #bitcoin-core-dev
7702018-03-29T23:22:08 *** go1111111 has quit IRC
7712018-03-29T23:31:46 *** Guyver2 has quit IRC
7722018-03-29T23:35:37 *** TrustTrade has joined #bitcoin-core-dev
7732018-03-29T23:49:15 *** Tennis has joined #bitcoin-core-dev
7742018-03-29T23:49:40 *** drexl has joined #bitcoin-core-dev
7752018-03-29T23:50:45 *** lnostdal has quit IRC
7762018-03-29T23:53:07 *** Randolf has quit IRC
7772018-03-29T23:54:30 *** Tennis has quit IRC
7782018-03-29T23:56:12 *** lnostdal has joined #bitcoin-core-dev