12018-04-09T00:00:02 *** weez17 has quit IRC
22018-04-09T00:00:49 *** weez17 has joined #bitcoin-core-dev
32018-04-09T00:02:01 *** d9b4bef9 has quit IRC
42018-04-09T00:03:07 *** d9b4bef9 has joined #bitcoin-core-dev
52018-04-09T00:04:37 *** promag has quit IRC
62018-04-09T00:05:07 *** tester2 has quit IRC
72018-04-09T00:06:21 *** promag has joined #bitcoin-core-dev
82018-04-09T00:06:26 *** promag has quit IRC
92018-04-09T00:06:39 *** promag has joined #bitcoin-core-dev
102018-04-09T00:06:42 *** promag has quit IRC
112018-04-09T00:09:33 *** rls has joined #bitcoin-core-dev
122018-04-09T00:15:17 *** Murch has joined #bitcoin-core-dev
132018-04-09T00:43:23 *** promag has joined #bitcoin-core-dev
142018-04-09T00:47:57 *** promag has quit IRC
152018-04-09T00:54:22 *** pyericz_ has joined #bitcoin-core-dev
162018-04-09T01:00:51 *** dafunkiz_ has joined #bitcoin-core-dev
172018-04-09T01:04:24 *** promag has joined #bitcoin-core-dev
182018-04-09T01:04:57 *** dgenr8 has joined #bitcoin-core-dev
192018-04-09T01:09:24 *** promag has quit IRC
202018-04-09T01:10:29 *** lifeofguenter has quit IRC
212018-04-09T01:11:39 *** lifeofguenter has joined #bitcoin-core-dev
222018-04-09T01:12:52 *** dafunkiz_ has quit IRC
232018-04-09T01:30:38 *** cryptojanitor has quit IRC
242018-04-09T01:34:03 *** Randolf has joined #bitcoin-core-dev
252018-04-09T01:34:22 *** satwo has joined #bitcoin-core-dev
262018-04-09T01:34:41 *** zigen has joined #bitcoin-core-dev
272018-04-09T01:37:29 *** Krellan has quit IRC
282018-04-09T01:38:03 *** Krellan has joined #bitcoin-core-dev
292018-04-09T01:52:01 *** luke-jr has quit IRC
302018-04-09T01:56:51 *** AaronvanW has joined #bitcoin-core-dev
312018-04-09T01:56:57 *** satwo has quit IRC
322018-04-09T02:06:16 *** moneyball has joined #bitcoin-core-dev
332018-04-09T02:22:56 *** rev_strangehope has joined #bitcoin-core-dev
342018-04-09T02:29:14 *** luke-jr has joined #bitcoin-core-dev
352018-04-09T02:29:16 *** moneyball has quit IRC
362018-04-09T02:41:21 *** lifeofguenter has quit IRC
372018-04-09T02:42:55 *** lifeofguenter has joined #bitcoin-core-dev
382018-04-09T02:47:59 *** moneyball has joined #bitcoin-core-dev
392018-04-09T02:53:21 *** moneyball has quit IRC
402018-04-09T02:53:57 *** moneyball has joined #bitcoin-core-dev
412018-04-09T02:54:53 *** grafcaps has quit IRC
422018-04-09T02:55:30 *** moneyball has quit IRC
432018-04-09T02:58:15 <kallewoof> I'm a little confused about coinbase transactions and 'is all from me'. Currently, CWallet::IsAllFromMe will say no to a coinbase transaction, even (it appears) if it's the miner's wallet. The check itself tries to find the prevout in the wallet, but prevout is 0000..., so it obviously won't be there. This causes issues with the IsAllFromMe PR (#12508), which I patched by explicitly saying 'true'
442018-04-09T02:58:17 <kallewoof> for coinbase txs in CWallet::IsAllFromMe, but I wonder if this will cause everyone to think they own all coinbase transactions...
452018-04-09T02:58:17 <gribble> https://github.com/bitcoin/bitcoin/issues/12508 | IsAllFromMe by kallewoof · Pull Request #12508 · bitcoin/bitcoin · GitHub
462018-04-09T02:59:22 *** moneyball has joined #bitcoin-core-dev
472018-04-09T03:00:03 <kallewoof> Then again, if it's a coinbase tx, it will have 100+ confirmations, so in all cases where IsAllFromMe matters (mostly unconfirmed, or low confirm count), it's irrelevant.
482018-04-09T03:00:07 *** AaronvanW has quit IRC
492018-04-09T03:00:41 *** grafcaps has joined #bitcoin-core-dev
502018-04-09T03:00:45 <wumpus> hmm interesting
512018-04-09T03:01:10 <kallewoof> Or is there a case where a 100+ confirm input being mine or not mine makes a difference? I guess in spending it someone could double spend, so ^ is probably not right..
522018-04-09T03:02:32 <wumpus> for 100+ confirms there is no difference. The reason for the 100 depth is to make sure it's deep enough to avoid any realistic reorgs causing trouble.
532018-04-09T03:03:28 <kallewoof> wumpus: Right. But I realized someone could spend a coinbase tx sending 12.5 btc to me, my node would think it was 'from me' and act accordingly, and then they would double spend it and I would risk losing 12.5 btc.
542018-04-09T03:04:27 <luke-jr> huh? I don't understand what you're saying at all
552018-04-09T03:04:36 <luke-jr> generated coins are from noone..
562018-04-09T03:04:43 <kallewoof> luke-jr: Me neither. I think I'm very confused.
572018-04-09T03:05:00 <sipa> from me means that the inputs were coins treated as yours
582018-04-09T03:05:26 <kallewoof> Right. So a coinbase input would not be considered yours even if you created the block?
592018-04-09T03:05:31 <wumpus> it's impossible to double-spend a coinbase, by definition the coinbase can only be in the block where the reward is taken
602018-04-09T03:05:54 <luke-jr> kallewoof: the coinbase isn't really an input at all, just dummy data
612018-04-09T03:06:03 <kallewoof> A coinbase transaction has a coinbase input and an output. I was talking about double spending the output.
622018-04-09T03:06:27 <kallewoof> luke-jr: The question is, should IsAllFromMe(a coinbase tx) say true or false, for the miner mining it?
632018-04-09T03:06:34 <luke-jr> false obviously?
642018-04-09T03:06:38 <luke-jr> it's TO the miner, not FROM him
652018-04-09T03:08:32 <kallewoof> luke-jr: All right. That makes things a bit tricky, I guess, but I'll dig.
662018-04-09T03:09:29 <kallewoof> luke-jr: It doesn't seem like morcos's initial idea in #9167 is compatible with your interpretation, though: "Created a new wallet and walletTx function IsAllFromMe which correctly computes whether all the inputs to a transaction match the requested IsMine filter.
672018-04-09T03:09:31 <gribble> https://github.com/bitcoin/bitcoin/issues/9167 | IsAllFromMe by morcos · Pull Request #9167 · bitcoin/bitcoin · GitHub
682018-04-09T03:09:47 <sipa> kallewoof: i don't understand why you're concerned about coinbase txn at all
692018-04-09T03:10:01 <sipa> coinbases are by definition never from anything
702018-04-09T03:10:09 <kallewoof> sipa: IsMine says true and IsAllFromMe says false for coinbase txs
712018-04-09T03:10:21 <sipa> yes, as it should?
722018-04-09T03:11:26 <kallewoof> Sorry, I meant, IsFromMe and IsAllFromMe say true/false for coinbase
732018-04-09T03:11:35 <sipa> yes, why is that a problem?
742018-04-09T03:11:53 *** pyericz_ has quit IRC
752018-04-09T03:12:02 *** grafcaps has quit IRC
762018-04-09T03:12:47 *** zigen has quit IRC
772018-04-09T03:13:08 <kallewoof> Wait, are coinbase transactions from me or not from me? If IsFromMe says true and there's only a coinbase input why would IsAllFromMe say false? Shouldn't both say the same in this case?
782018-04-09T03:13:20 *** zigen has joined #bitcoin-core-dev
792018-04-09T03:13:34 <kallewoof> luke-jr says false is correct. In which case IsFromMe is wrong, no?
802018-04-09T03:13:39 <sipa> wait
812018-04-09T03:13:47 <sipa> oh, IsFromMe is true?
822018-04-09T03:13:49 <kallewoof> Yes
832018-04-09T03:13:52 <sipa> that i don't understand!
842018-04-09T03:13:53 *** pyericz_ has joined #bitcoin-core-dev
852018-04-09T03:14:01 <sipa> maybe it's a special rule for foinbase tzn
862018-04-09T03:14:04 <sipa> coinbase tzn
872018-04-09T03:14:05 <kallewoof> All it does is check GetDebit(tx, ISMINE_ALL) > 0
882018-04-09T03:14:07 <sipa> txn
892018-04-09T03:14:22 <kallewoof> Right -- I'm saying I need to add that to CWallet::IsAllFromMe as well.
902018-04-09T03:14:29 <kallewoof> that=the special rule for coinbase txs
912018-04-09T03:14:52 <sipa> what is IsAllFromMe even used for?
922018-04-09T03:15:45 <kallewoof> That's a great question. It seems to be used in feebumper, and in wallet.cpp in some places.
932018-04-09T03:16:05 <kallewoof> Actually no it's only used in feebumper on master.
942018-04-09T03:17:16 <sipa> yay
952018-04-09T03:17:18 <kallewoof> So it seems completely fine to allow the special case.
962018-04-09T03:17:24 <sipa> well, you can't feebump a coinbase!
972018-04-09T03:17:33 * kallewoof nods
982018-04-09T03:17:37 *** zigen has quit IRC
992018-04-09T03:19:33 *** jtimon has quit IRC
1002018-04-09T03:21:19 *** ken2812221 has quit IRC
1012018-04-09T03:22:33 *** Randolf has quit IRC
1022018-04-09T03:29:01 *** ken2812221 has joined #bitcoin-core-dev
1032018-04-09T03:29:43 *** ken2812221 has quit IRC
1042018-04-09T03:32:06 *** ken2812221 has joined #bitcoin-core-dev
1052018-04-09T03:37:36 *** Randolf has joined #bitcoin-core-dev
1062018-04-09T03:55:25 *** Krellan has quit IRC
1072018-04-09T03:56:02 *** Krellan has joined #bitcoin-core-dev
1082018-04-09T03:57:46 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/27278dffe877...4781813b5617
1092018-04-09T03:57:47 <bitcoin-git> bitcoin/master 08b17de Karl-Johan Alm: [arith_uint256] Do not destroy *this content if passed-in operator may reference it
1102018-04-09T03:57:48 <bitcoin-git> bitcoin/master b120f7b Karl-Johan Alm: [test] Add tests for self usage in arith_uint256
1112018-04-09T03:57:48 <bitcoin-git> bitcoin/master 4781813 Wladimir J. van der Laan: Merge #12537: [arith_uint256] Make it safe to use "self" in operators...
1122018-04-09T03:58:24 <bitcoin-git> [bitcoin] laanwj closed pull request #12537: [arith_uint256] Make it safe to use "self" in operators (master...uint-safe-self-op) https://github.com/bitcoin/bitcoin/pull/12537
1132018-04-09T04:07:02 *** zigen has joined #bitcoin-core-dev
1142018-04-09T04:10:30 *** zigen has quit IRC
1152018-04-09T04:13:17 *** Michael___ has joined #bitcoin-core-dev
1162018-04-09T04:14:58 *** moneyball has quit IRC
1172018-04-09T04:15:30 *** pyericz_ has quit IRC
1182018-04-09T04:28:27 *** grafcaps has joined #bitcoin-core-dev
1192018-04-09T04:43:53 *** promag has joined #bitcoin-core-dev
1202018-04-09T04:48:21 *** promag has quit IRC
1212018-04-09T04:58:57 *** zigen has joined #bitcoin-core-dev
1222018-04-09T04:59:40 *** Michael___ has quit IRC
1232018-04-09T05:04:20 *** zigen has quit IRC
1242018-04-09T05:04:53 *** zigen has joined #bitcoin-core-dev
1252018-04-09T05:05:35 *** zigen has quit IRC
1262018-04-09T05:05:48 *** zigen has joined #bitcoin-core-dev
1272018-04-09T05:06:57 *** lnostdal has quit IRC
1282018-04-09T05:09:03 *** lnostdal has joined #bitcoin-core-dev
1292018-04-09T05:15:51 *** lnostdal_ has joined #bitcoin-core-dev
1302018-04-09T05:16:01 *** lnostdal has quit IRC
1312018-04-09T05:17:49 *** goatpig has joined #bitcoin-core-dev
1322018-04-09T05:40:04 *** zautomata3 has quit IRC
1332018-04-09T05:45:41 *** zautomata4 has joined #bitcoin-core-dev
1342018-04-09T05:54:57 *** grafcaps has quit IRC
1352018-04-09T05:56:54 <bitcoin-git> [bitcoin] VizXu opened pull request #12919: no message (0.8...master) https://github.com/bitcoin/bitcoin/pull/12919
1362018-04-09T05:57:42 <bitcoin-git> [bitcoin] fanquake closed pull request #12919: no message (0.8...master) https://github.com/bitcoin/bitcoin/pull/12919
1372018-04-09T06:02:13 *** zigen has quit IRC
1382018-04-09T06:02:50 *** zigen has joined #bitcoin-core-dev
1392018-04-09T06:03:05 *** zigen has quit IRC
1402018-04-09T06:03:20 *** zigen has joined #bitcoin-core-dev
1412018-04-09T06:09:48 *** Murch has quit IRC
1422018-04-09T06:10:33 *** Victorsueca has quit IRC
1432018-04-09T06:11:02 *** kanexxz has joined #bitcoin-core-dev
1442018-04-09T06:11:09 *** promag has joined #bitcoin-core-dev
1452018-04-09T06:11:59 *** Victorsueca has joined #bitcoin-core-dev
1462018-04-09T06:15:08 *** grafcaps has joined #bitcoin-core-dev
1472018-04-09T06:15:54 *** promag has quit IRC
1482018-04-09T06:16:41 *** Krellan has quit IRC
1492018-04-09T06:17:26 *** Krellan has joined #bitcoin-core-dev
1502018-04-09T06:19:45 *** zigen has quit IRC
1512018-04-09T06:19:47 *** grafcaps has quit IRC
1522018-04-09T06:20:20 *** zigen has joined #bitcoin-core-dev
1532018-04-09T06:23:10 *** zigen has quit IRC
1542018-04-09T06:23:22 *** zigen has joined #bitcoin-core-dev
1552018-04-09T06:24:38 *** Guest34 has quit IRC
1562018-04-09T06:29:20 *** benma has joined #bitcoin-core-dev
1572018-04-09T06:29:21 *** benma has joined #bitcoin-core-dev
1582018-04-09T06:33:55 *** RoyceX has joined #bitcoin-core-dev
1592018-04-09T06:36:53 *** cheese_ has quit IRC
1602018-04-09T06:39:21 *** harrymm_ has joined #bitcoin-core-dev
1612018-04-09T06:41:19 *** owowo has quit IRC
1622018-04-09T06:42:32 *** harrymm has quit IRC
1632018-04-09T06:51:59 *** cheese_ has joined #bitcoin-core-dev
1642018-04-09T06:52:26 *** zigen has quit IRC
1652018-04-09T06:52:40 *** zigen has joined #bitcoin-core-dev
1662018-04-09T06:53:36 *** grafcaps has joined #bitcoin-core-dev
1672018-04-09T06:54:51 *** RoyceX has quit IRC
1682018-04-09T06:57:09 *** zigen has quit IRC
1692018-04-09T06:57:44 *** zigen has joined #bitcoin-core-dev
1702018-04-09T06:58:47 *** grafcaps has quit IRC
1712018-04-09T07:00:45 *** zigen has quit IRC
1722018-04-09T07:00:51 *** zigen has joined #bitcoin-core-dev
1732018-04-09T07:05:36 *** zigen has quit IRC
1742018-04-09T07:06:03 *** zigen has joined #bitcoin-core-dev
1752018-04-09T07:09:29 *** promag has joined #bitcoin-core-dev
1762018-04-09T07:16:01 *** promag has quit IRC
1772018-04-09T07:20:20 *** ddd has joined #bitcoin-core-dev
1782018-04-09T07:21:48 *** ddd has quit IRC
1792018-04-09T07:41:46 *** zigen has quit IRC
1802018-04-09T07:43:36 *** zarez has joined #bitcoin-core-dev
1812018-04-09T07:45:13 *** zigen has joined #bitcoin-core-dev
1822018-04-09T07:46:51 *** nickler has quit IRC
1832018-04-09T07:47:53 *** nickler has joined #bitcoin-core-dev
1842018-04-09T07:52:35 <bitcoin-git> [bitcoin] kallewoof opened pull request #12920: test: Fix sign for expected values (master...test-signs) https://github.com/bitcoin/bitcoin/pull/12920
1852018-04-09T07:56:37 *** nickler has quit IRC
1862018-04-09T07:58:14 *** Emcy has joined #bitcoin-core-dev
1872018-04-09T07:59:58 *** laurentmt has joined #bitcoin-core-dev
1882018-04-09T08:02:33 *** nickler has joined #bitcoin-core-dev
1892018-04-09T08:03:12 *** laurentmt1 has joined #bitcoin-core-dev
1902018-04-09T08:03:42 *** grafcaps has joined #bitcoin-core-dev
1912018-04-09T08:04:25 *** laurentmt has quit IRC
1922018-04-09T08:04:25 *** laurentmt1 is now known as laurentmt
1932018-04-09T08:05:19 *** andytoshi has quit IRC
1942018-04-09T08:08:59 *** grafcaps has quit IRC
1952018-04-09T08:09:47 *** timothy has joined #bitcoin-core-dev
1962018-04-09T08:10:04 *** setpill has joined #bitcoin-core-dev
1972018-04-09T08:12:06 *** andytoshi has joined #bitcoin-core-dev
1982018-04-09T08:18:43 *** Victorsueca has quit IRC
1992018-04-09T08:19:16 *** drizztbsd has joined #bitcoin-core-dev
2002018-04-09T08:19:59 *** Victorsueca has joined #bitcoin-core-dev
2012018-04-09T08:20:02 *** timothy has quit IRC
2022018-04-09T08:26:24 *** promag has joined #bitcoin-core-dev
2032018-04-09T08:26:30 *** promag has quit IRC
2042018-04-09T08:29:59 *** drizztbsd is now known as timothy
2052018-04-09T08:30:21 *** rafalcpp has quit IRC
2062018-04-09T08:51:54 *** zarez has quit IRC
2072018-04-09T08:52:19 *** zarez has joined #bitcoin-core-dev
2082018-04-09T08:53:27 <bitcoin-git> [bitcoin] Empact opened pull request #12921: Make use of cpuid.h bit definitions (master...cpuid-bits) https://github.com/bitcoin/bitcoin/pull/12921
2092018-04-09T08:57:05 *** zautomata4 has quit IRC
2102018-04-09T08:59:06 *** zautomata4 has joined #bitcoin-core-dev
2112018-04-09T08:59:59 *** vicenteH has joined #bitcoin-core-dev
2122018-04-09T09:03:11 *** zautomata has joined #bitcoin-core-dev
2132018-04-09T09:04:14 *** zautomata4 has quit IRC
2142018-04-09T09:07:03 *** zautomata1 has joined #bitcoin-core-dev
2152018-04-09T09:09:22 *** zautomata has quit IRC
2162018-04-09T09:15:17 *** zautomata1 has quit IRC
2172018-04-09T09:15:52 *** zautomata2 has joined #bitcoin-core-dev
2182018-04-09T09:17:51 *** zigen has quit IRC
2192018-04-09T09:18:07 *** zigen has joined #bitcoin-core-dev
2202018-04-09T09:36:46 *** zautomata has joined #bitcoin-core-dev
2212018-04-09T09:38:28 *** zautomata2 has quit IRC
2222018-04-09T09:48:29 *** zautomata1 has joined #bitcoin-core-dev
2232018-04-09T09:49:23 *** zautomata has quit IRC
2242018-04-09T09:56:09 *** zautomata1 has quit IRC
2252018-04-09T09:58:24 *** jtimon has joined #bitcoin-core-dev
2262018-04-09T09:58:39 *** zautomata1 has joined #bitcoin-core-dev
2272018-04-09T10:04:02 *** zautomata1 has quit IRC
2282018-04-09T10:04:11 *** zautomata2 has joined #bitcoin-core-dev
2292018-04-09T10:04:39 *** laurentmt has quit IRC
2302018-04-09T10:05:53 *** zigen has quit IRC
2312018-04-09T10:06:26 *** zigen has joined #bitcoin-core-dev
2322018-04-09T10:07:28 *** zigen has joined #bitcoin-core-dev
2332018-04-09T10:14:45 *** lnostdal_ has quit IRC
2342018-04-09T10:30:14 *** grafcaps has joined #bitcoin-core-dev
2352018-04-09T10:32:37 *** zigen has quit IRC
2362018-04-09T10:33:12 *** zigen has joined #bitcoin-core-dev
2372018-04-09T10:35:01 *** grafcaps has quit IRC
2382018-04-09T10:37:57 *** zigen has quit IRC
2392018-04-09T10:43:27 *** zigen has joined #bitcoin-core-dev
2402018-04-09T10:47:42 *** zigen has quit IRC
2412018-04-09T10:57:54 *** zautomata2 has quit IRC
2422018-04-09T10:59:29 *** zautomata has joined #bitcoin-core-dev
2432018-04-09T10:59:42 *** zautomata has joined #bitcoin-core-dev
2442018-04-09T10:59:57 <wumpus> does anyone happen to have an arm32 system with crc32 feature in /proc/cpuinfo?
2452018-04-09T11:01:11 *** belcher_ has joined #bitcoin-core-dev
2462018-04-09T11:02:40 <wumpus> I want to port https://github.com/laanwj/crcbench to arm32 (with the goal of integrating that into leveldb) however I currently have no wway to test. Well I could check if it compiles, I guess.
2472018-04-09T11:04:35 <wumpus> oh right, I guess 64-bit ARM can run 32-bit executables
2482018-04-09T11:11:07 *** promag has joined #bitcoin-core-dev
2492018-04-09T11:11:37 *** CubicEarths has joined #bitcoin-core-dev
2502018-04-09T11:16:56 *** wunpunch has joined #bitcoin-core-dev
2512018-04-09T11:21:54 *** Allen_ has joined #bitcoin-core-dev
2522018-04-09T11:23:29 *** Allen_ has left #bitcoin-core-dev
2532018-04-09T11:25:04 *** AaronvanW has joined #bitcoin-core-dev
2542018-04-09T11:26:15 *** rls has quit IRC
2552018-04-09T11:27:09 *** Aaronvan_ has joined #bitcoin-core-dev
2562018-04-09T11:30:37 *** AaronvanW has quit IRC
2572018-04-09T11:36:53 *** zautomata has quit IRC
2582018-04-09T11:37:10 *** zautomata1 has joined #bitcoin-core-dev
2592018-04-09T11:40:20 *** farsider350 has joined #bitcoin-core-dev
2602018-04-09T11:41:58 <MarcoFalke> PSA: We now have 15 parallel jobs on travis for the next year :3
2612018-04-09T11:42:57 <wumpus> awesome, thank you MarcoFalke :)
2622018-04-09T11:43:13 <MarcoFalke> Thanks to ChainCode for sponsoring that!
2632018-04-09T11:44:44 <wumpus> yes!
2642018-04-09T11:49:44 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4781813b5617...6fc5a050f216
2652018-04-09T11:49:44 <bitcoin-git> bitcoin/master bf08fc5 Karl-Johan Alm: test: Assert on correct variable
2662018-04-09T11:49:45 <bitcoin-git> bitcoin/master 6fc5a05 MarcoFalke: Merge #12918: test: Assert on correct variable...
2672018-04-09T11:50:31 *** intcat has quit IRC
2682018-04-09T11:50:36 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12918: test: Assert on correct variable (master...test-typo-rpcrawtx) https://github.com/bitcoin/bitcoin/pull/12918
2692018-04-09T11:55:56 *** Samdney has joined #bitcoin-core-dev
2702018-04-09T11:58:02 *** intcat has joined #bitcoin-core-dev
2712018-04-09T11:59:00 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6fc5a050f216...a04440feb9c9
2722018-04-09T11:59:01 <bitcoin-git> bitcoin/master 280023f practicalswift: Remove duplicate includes
2732018-04-09T11:59:02 <bitcoin-git> bitcoin/master c36b720 practicalswift: Add Travis check for duplicate includes...
2742018-04-09T11:59:02 <bitcoin-git> bitcoin/master a04440f MarcoFalke: Merge #11878: Add Travis check for duplicate includes...
2752018-04-09T11:59:30 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11878: Add Travis check for duplicate includes (master...lint-includes) https://github.com/bitcoin/bitcoin/pull/11878
2762018-04-09T12:05:28 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a04440feb9c9...cd8e45b4e75a
2772018-04-09T12:05:28 <bitcoin-git> bitcoin/master c198dc0 Jan Äapek: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC
2782018-04-09T12:05:29 <bitcoin-git> bitcoin/master cd8e45b MarcoFalke: Merge #12007: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC...
2792018-04-09T12:05:53 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12007: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC (master...master) https://github.com/bitcoin/bitcoin/pull/12007
2802018-04-09T12:07:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd8e45b4e75a...603975b96a15
2812018-04-09T12:07:26 <bitcoin-git> bitcoin/master 9142dfe practicalswift: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion
2822018-04-09T12:07:26 <bitcoin-git> bitcoin/master 603975b MarcoFalke: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion...
2832018-04-09T12:08:10 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion (master...cuckoocache) https://github.com/bitcoin/bitcoin/pull/12770
2842018-04-09T12:10:38 *** Guyver2 has joined #bitcoin-core-dev
2852018-04-09T12:13:37 <aj> MarcoFalke: wow!
2862018-04-09T12:16:26 *** promag has quit IRC
2872018-04-09T12:18:43 *** farsider350 has quit IRC
2882018-04-09T12:35:31 *** lnostdal has joined #bitcoin-core-dev
2892018-04-09T12:42:17 *** lnostdal has quit IRC
2902018-04-09T12:44:41 *** ProfMac has quit IRC
2912018-04-09T12:46:07 <wumpus> so apparently the crc32 extension only exists on armv8, but I didn't know 32-bit-only armv8 existed but apparently it does (Cortex-A32)
2922018-04-09T12:46:24 *** ProfMac has joined #bitcoin-core-dev
2932018-04-09T12:50:20 <wumpus> anyhow getauxv trick to detect cpu features works; if (getauxval(AT_HWCAP) & HWCAP_CRC32) { on aarch64 and if (getauxval(AT_HWCAP2) & HWCAP2_CRC32) { on arm32
2942018-04-09T12:50:54 *** Aaronvan_ has quit IRC
2952018-04-09T12:51:30 *** AaronvanW has joined #bitcoin-core-dev
2962018-04-09T12:55:23 *** lnostdal has joined #bitcoin-core-dev
2972018-04-09T13:02:30 *** promag has joined #bitcoin-core-dev
2982018-04-09T13:15:11 *** Krellan has quit IRC
2992018-04-09T13:16:01 *** Krellan has joined #bitcoin-core-dev
3002018-04-09T13:18:29 *** lnostdal has quit IRC
3012018-04-09T13:22:02 <MarcoFalke> Anyone else seeing this: #12915?
3022018-04-09T13:22:03 <gribble> https://github.com/bitcoin/bitcoin/issues/12915 | Segmentation fault in util: ScheduleBatchPriority · Issue #12915 · bitcoin/bitcoin · GitHub
3032018-04-09T13:27:11 <aj> hmm, i thought designator initialisers (param{.sched_priority=0}) weren't ok for c++11 (http://en.cppreference.com/w/cpp/language/aggregate_initialization says they're c++20 fwiw)
3042018-04-09T13:31:24 <wumpus> MarcoFalke: nope. it crashes inside pthread_setschedparam? that's curious
3052018-04-09T13:32:37 <wumpus> the only way I see that can happen if is a null pointer is passed, but as it is passing a pointer to a static variable you'd say that's not possible
3062018-04-09T13:33:06 <wumpus> does this only happen with the sanitize ron?
3072018-04-09T13:35:39 <aj> err, should it be pthread_self() not 0 as the first argument?
3082018-04-09T13:36:53 <wumpus> uhmm
3092018-04-09T13:37:04 <wumpus> the man page doesn't say anything about 0 being a valid value, at least
3102018-04-09T13:37:33 <wumpus> MarcoFalke: can you try that ^^
3112018-04-09T13:38:30 <MarcoFalke> happens also with sanitizer off
3122018-04-09T13:39:00 <MarcoFalke> I've seen segfaults in the unit test a couple of days ago, but they went away after a reboot. Really sketchy
3132018-04-09T13:41:48 <wumpus> should definitely be pthread_self() - non-determinism in thread ids might explain why it sometimes crashes and sometimes not?
3142018-04-09T13:42:51 <MarcoFalke> For me it always faults
3152018-04-09T13:43:25 <MarcoFalke> The unit test thing was a different topic. Just related because it was also a segfault
3162018-04-09T13:46:19 <MarcoFalke> Making it "const static sched_param param{0};" didn't help
3172018-04-09T13:47:19 <bitcoin-git> [bitcoin] laanwj opened pull request #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0 (master...2018_04_pthread_self) https://github.com/bitcoin/bitcoin/pull/12923
3182018-04-09T13:48:35 <MarcoFalke> will try that ^
3192018-04-09T13:49:42 *** Strepsils has joined #bitcoin-core-dev
3202018-04-09T13:51:15 *** Randolf has quit IRC
3212018-04-09T13:51:42 <MarcoFalke> aj: wumpus: Thx. Work for me now
3222018-04-09T13:51:51 * MarcoFalke subway
3232018-04-09T13:51:52 <wumpus> I can make the initializer change in the same PR, but as it compiles in c++11 mode, I'm not sure .
3242018-04-09T13:53:07 <aj> https://stackoverflow.com/questions/43471743/pthread-self-on-linux -- suggests that without linking pthreads, pthread_self() will sometimes/often/?? return 0
3252018-04-09T13:54:40 <wumpus> that explains why it works for some
3262018-04-09T13:54:57 <MarcoFalke> aj: I added the cout and it is definetly not 0 for me
3272018-04-09T13:54:59 *** Strepsils has quit IRC
3282018-04-09T13:55:07 <wumpus> it depends on the specifics of the pthread implementation, after all posix threads is an interface, not a specific implementation
3292018-04-09T13:55:08 <luke-jr> aj: if you don't link pthreads, pthread_self won't resolve at all, and calling it would be a segfault..
3302018-04-09T13:55:16 <luke-jr> I would expect
3312018-04-09T13:55:37 <wumpus> so one should not make any assumptions about the value that it returns
3322018-04-09T13:58:29 <aj> luke-jr: works fine for me without linking libpthread, value is very non-zero either way though. (i don't get a segfault with marcofalke's test case)
3332018-04-09T13:59:14 <luke-jr> aj: well, glibc no longer has libpthread anymore
3342018-04-09T13:59:43 <luke-jr> (threading is part of the libc now, and linking libpthread explicitly actually can have harmful side effects)
3352018-04-09T14:04:13 *** Strepsils has joined #bitcoin-core-dev
3362018-04-09T14:06:28 *** grafcaps has joined #bitcoin-core-dev
3372018-04-09T14:11:04 *** grafcaps has quit IRC
3382018-04-09T14:14:06 *** cryptojanitor has joined #bitcoin-core-dev
3392018-04-09T14:14:32 <wumpus> about time that threading moved into libc, even little embedded SoCs are mulitcore these days, having threading as something special/optional is just absurd
3402018-04-09T14:14:36 <bitcoin-git> [bitcoin] jamesob closed pull request #12873: [ci] Run functional tests using bitcoin-qt in one Travis job (master...2018-04-03-travis-func-qt) https://github.com/bitcoin/bitcoin/pull/12873
3412018-04-09T14:15:09 <luke-jr> wumpus: would be nice if they didn't have bugs doing it though :p
3422018-04-09T14:15:37 <luke-jr> (with glibc, if you link libpthread, and then call vfork early on, it will just return a pointer to the vfork function rather than actually forking)
3432018-04-09T14:15:56 <aj> jamesob: maybe just open a new PR instead? :(
3442018-04-09T14:16:36 <jamesob> aj: yeah, probably a good idea. Wonder why/how that PR is screwing travis up.
3452018-04-09T14:16:45 <jamesob> sorry for the spam
3462018-04-09T14:20:45 *** qu4ku has joined #bitcoin-core-dev
3472018-04-09T14:23:09 *** jimpo has quit IRC
3482018-04-09T14:26:34 *** owowo has joined #bitcoin-core-dev
3492018-04-09T14:26:34 *** owowo has joined #bitcoin-core-dev
3502018-04-09T14:27:55 *** Strepsil_ has joined #bitcoin-core-dev
3512018-04-09T14:27:58 *** zautomata1 has quit IRC
3522018-04-09T14:28:42 *** jimpo has joined #bitcoin-core-dev
3532018-04-09T14:29:51 *** zautomata1 has joined #bitcoin-core-dev
3542018-04-09T14:30:54 *** Strepsils has quit IRC
3552018-04-09T14:34:48 *** AaronvanW has quit IRC
3562018-04-09T14:35:24 *** AaronvanW has joined #bitcoin-core-dev
3572018-04-09T14:38:37 *** lnostdal has joined #bitcoin-core-dev
3582018-04-09T14:40:07 *** AaronvanW has quit IRC
3592018-04-09T14:42:51 *** lnostdal_ has joined #bitcoin-core-dev
3602018-04-09T14:43:34 *** lnostdal has quit IRC
3612018-04-09T14:48:38 *** SopaXorzTaker has joined #bitcoin-core-dev
3622018-04-09T14:52:23 <jonasschnelli> wumpus: curious: whats the reason for implementing NI crc for arm 32bit?
3632018-04-09T14:53:34 *** AaronvanW has joined #bitcoin-core-dev
3642018-04-09T14:53:42 <wumpus> jonasschnelli: last time I checked, quite a lot of time is spent crcing (for leveldb checksums), while verifying the chain
3652018-04-09T14:54:08 *** grafcaps has joined #bitcoin-core-dev
3662018-04-09T14:55:35 <jonasschnelli> wumpus: Good to know. I just started to play with the ODROID HC2 (Cortex-A15)
3672018-04-09T14:55:37 <wumpus> so using those extensions on hardware that support them probably helps, though I agree the 32-bit case is unlikley to be hit
3682018-04-09T14:55:55 <wumpus> (as 32-bit armv8 are very rare)
3692018-04-09T14:56:10 <wumpus> ah, nice
3702018-04-09T14:56:33 <jonasschnelli> I guess Odroids XU4 and HC2 are 32 bit armv7?
3712018-04-09T14:57:00 <jonasschnelli> Not sure if the have NI crc32
3722018-04-09T14:58:07 <jonasschnelli> Don't have access until Thursday to the machine... so no /proc/cpuinto right now
3732018-04-09T14:58:27 *** grafcaps has quit IRC
3742018-04-09T14:59:15 <wumpus> armv7 never has crc32
3752018-04-09T14:59:29 <jonasschnelli> Just read that up... v8 is min, right.
3762018-04-09T14:59:40 <jonasschnelli> v8.1-A AFAIK
3772018-04-09T15:10:28 *** AaronvanW has quit IRC
3782018-04-09T15:11:07 *** AaronvanW has joined #bitcoin-core-dev
3792018-04-09T15:12:58 *** satwo has joined #bitcoin-core-dev
3802018-04-09T15:14:10 *** kanexxz has quit IRC
3812018-04-09T15:15:27 *** AaronvanW has quit IRC
3822018-04-09T15:16:28 <bitcoin-git> [bitcoin] jnewbery opened pull request #12924: Fix hdmaster-key / seed-key confusion (scripted diff) (master...master_key_to_seed) https://github.com/bitcoin/bitcoin/pull/12924
3832018-04-09T15:16:37 *** grafcaps has joined #bitcoin-core-dev
3842018-04-09T15:18:21 *** Strepsil_ has quit IRC
3852018-04-09T15:20:51 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12094: Fix hdmaster-key / seed-key confusion (master...2018/01/hdseed) https://github.com/bitcoin/bitcoin/pull/12094
3862018-04-09T15:21:09 *** AaronvanW has joined #bitcoin-core-dev
3872018-04-09T15:23:28 *** Murch has joined #bitcoin-core-dev
3882018-04-09T15:25:44 *** AaronvanW has quit IRC
3892018-04-09T15:27:06 *** satwo has quit IRC
3902018-04-09T15:28:23 *** grafcaps has quit IRC
3912018-04-09T15:33:47 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/603975b96a15...a7cbe38ae2dd
3922018-04-09T15:33:48 <bitcoin-git> bitcoin/master cff66e6 Wladimir J. van der Laan: util: Pass pthread_self() to pthread_setschedparam instead of 0...
3932018-04-09T15:33:48 <bitcoin-git> bitcoin/master b86730a Wladimir J. van der Laan: util: Remove designator initializer from ScheduleBatchPriority...
3942018-04-09T15:33:49 <bitcoin-git> bitcoin/master a7cbe38 Wladimir J. van der Laan: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0...
3952018-04-09T15:34:22 *** Giszmo has quit IRC
3962018-04-09T15:34:23 *** Krellan has quit IRC
3972018-04-09T15:34:41 <bitcoin-git> [bitcoin] laanwj closed pull request #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0 (master...2018_04_pthread_self) https://github.com/bitcoin/bitcoin/pull/12923
3982018-04-09T15:35:07 *** Krellan has joined #bitcoin-core-dev
3992018-04-09T15:40:47 *** moneyball has joined #bitcoin-core-dev
4002018-04-09T15:48:34 *** moneyball has quit IRC
4012018-04-09T15:56:57 *** zarez has quit IRC
4022018-04-09T15:59:08 *** jbisch has quit IRC
4032018-04-09T15:59:21 *** nhill has quit IRC
4042018-04-09T16:00:02 *** str4d has joined #bitcoin-core-dev
4052018-04-09T16:00:38 *** AaronvanW has joined #bitcoin-core-dev
4062018-04-09T16:07:09 *** setpill has quit IRC
4072018-04-09T16:15:11 *** Randolf has joined #bitcoin-core-dev
4082018-04-09T16:16:03 <bitcoin-git> [bitcoin] Empact closed pull request #12921: Make use of cpuid.h bit definitions (master...cpuid-bits) https://github.com/bitcoin/bitcoin/pull/12921
4092018-04-09T16:20:27 *** Randolf has quit IRC
4102018-04-09T16:22:30 <promag> it it me or CWalletTx::GetRequestCount() is not used?
4112018-04-09T16:23:28 *** lnostdal_ is now known as lnostdal
4122018-04-09T16:24:44 *** Newton35Dickens has joined #bitcoin-core-dev
4132018-04-09T16:25:38 *** benma has quit IRC
4142018-04-09T16:27:15 *** isis is now known as isis_
4152018-04-09T16:29:12 *** shesek has quit IRC
4162018-04-09T16:29:42 <instagibbs> promag, src/interface/wallet.cpp:95: result.request_count = wtx.GetRequestCount();
4172018-04-09T16:30:00 <promag> rigth, but request_count is not used
4182018-04-09T16:30:16 <promag> oh sorry, it is
4192018-04-09T16:30:33 <promag> my bad :/
4202018-04-09T16:30:36 <instagibbs> np
4212018-04-09T16:32:51 *** shesek has joined #bitcoin-core-dev
4222018-04-09T16:32:51 *** shesek has joined #bitcoin-core-dev
4232018-04-09T16:33:05 *** moneyball has joined #bitcoin-core-dev
4242018-04-09T16:36:34 *** Dizzle has joined #bitcoin-core-dev
4252018-04-09T16:36:42 *** wunpunch has quit IRC
4262018-04-09T16:49:27 *** Giszmo has joined #bitcoin-core-dev
4272018-04-09T16:53:12 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #12925: [Trivial] Logprint the start of a rescan (master...2018/04/rescan) https://github.com/bitcoin/bitcoin/pull/12925
4282018-04-09T17:10:26 *** Krellan has quit IRC
4292018-04-09T17:10:54 *** Krellan has joined #bitcoin-core-dev
4302018-04-09T17:15:12 *** Krellan has quit IRC
4312018-04-09T17:21:10 <jamesob> now that we're not supporting Python2, can we start adding function (type) annotations to functional test code? I think that'll help make the test framework a bit easier to use
4322018-04-09T17:23:02 *** Giszmo has quit IRC
4332018-04-09T17:23:57 *** cryptojanitor has quit IRC
4342018-04-09T17:24:55 *** cryptojanitor has joined #bitcoin-core-dev
4352018-04-09T17:27:47 *** Randolf has joined #bitcoin-core-dev
4362018-04-09T17:28:53 *** Murch has quit IRC
4372018-04-09T17:29:39 *** Murch has joined #bitcoin-core-dev
4382018-04-09T17:30:33 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a7cbe38ae2dd...0700b6f778d9
4392018-04-09T17:30:34 <bitcoin-git> bitcoin/master ea23945 Russell Yanofsky: scripted-diff: Rename wallet database classes...
4402018-04-09T17:30:34 <bitcoin-git> bitcoin/master 398c6f0 Russell Yanofsky: Update walletdb comment after renaming....
4412018-04-09T17:30:35 <bitcoin-git> bitcoin/master 9b0f0c5 Russell Yanofsky: Add m_ prefix to WalletBatch::m_batch
4422018-04-09T17:30:56 <bitcoin-git> [bitcoin] laanwj closed pull request #11851: scripted-diff: Rename wallet database classes (master...pr/wren) https://github.com/bitcoin/bitcoin/pull/11851
4432018-04-09T17:31:54 <wumpus> jamesob: I guess so
4442018-04-09T17:33:41 <jamesob> I'm thinking particularly for arguments in util functions like "pubkey" and "blockhash" which are pretty ambiguous
4452018-04-09T17:37:27 *** vicenteH has quit IRC
4462018-04-09T17:42:14 <wumpus> I've never used type annotations in python so I don't know how useful they are
4472018-04-09T17:46:03 <jamesob> the use is pretty limited out of the box; they're like more succinct docstrings. there are third-party tools that do verification, though I've never used any of them
4482018-04-09T18:04:25 *** SopaXorzTaker has quit IRC
4492018-04-09T18:06:07 *** qu4ku has quit IRC
4502018-04-09T18:07:35 *** Randolf has quit IRC
4512018-04-09T18:16:41 *** Krellan has joined #bitcoin-core-dev
4522018-04-09T18:19:05 <wumpus> I'd say make an example PR where you change a few functions, then see how the review goes
4532018-04-09T18:21:21 *** Krellan has quit IRC
4542018-04-09T18:25:43 *** timothy has quit IRC
4552018-04-09T18:28:34 *** Dizzle has quit IRC
4562018-04-09T18:33:25 *** promag has quit IRC
4572018-04-09T18:38:27 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0700b6f778d9...cf8073f8d1d1
4582018-04-09T18:38:28 <bitcoin-git> bitcoin/master fab9095 MarcoFalke: qa: Windows fixups for functional tests
4592018-04-09T18:38:28 <bitcoin-git> bitcoin/master cf8073f MarcoFalke: Merge #12917: qa: Windows fixups for functional tests...
4602018-04-09T18:39:16 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12917: qa: Windows fixups for functional tests (master...Mf1804-qaWinFixups) https://github.com/bitcoin/bitcoin/pull/12917
4612018-04-09T18:39:43 *** promag has joined #bitcoin-core-dev
4622018-04-09T18:41:33 *** Randolf has joined #bitcoin-core-dev
4632018-04-09T18:43:38 *** Murch has quit IRC
4642018-04-09T18:44:14 *** Victorsueca has quit IRC
4652018-04-09T18:44:46 *** zigen has joined #bitcoin-core-dev
4662018-04-09T18:45:30 *** Victorsueca has joined #bitcoin-core-dev
4672018-04-09T18:46:38 *** promag has quit IRC
4682018-04-09T18:46:53 *** wunpunch has joined #bitcoin-core-dev
4692018-04-09T18:49:19 *** zigen has quit IRC
4702018-04-09T18:50:08 *** drexl has joined #bitcoin-core-dev
4712018-04-09T18:52:05 *** goatpig has quit IRC
4722018-04-09T18:53:55 *** dafunkiz_ has joined #bitcoin-core-dev
4732018-04-09T18:54:35 *** andytoshi has quit IRC
4742018-04-09T18:54:35 *** andytoshi has joined #bitcoin-core-dev
4752018-04-09T18:54:53 *** dafunkiz_ has quit IRC
4762018-04-09T18:56:04 *** Giszmo has joined #bitcoin-core-dev
4772018-04-09T18:56:05 *** dafunkiz_ has joined #bitcoin-core-dev
4782018-04-09T18:59:13 *** Victorsueca has quit IRC
4792018-04-09T19:00:29 *** Victorsueca has joined #bitcoin-core-dev
4802018-04-09T19:01:06 *** Murch has joined #bitcoin-core-dev
4812018-04-09T19:09:05 *** drexl has quit IRC
4822018-04-09T19:12:30 *** dafunkiz_ has quit IRC
4832018-04-09T19:17:19 *** Randolf has quit IRC
4842018-04-09T19:26:12 <jamesob> wumpus: sounds good
4852018-04-09T19:29:37 *** kanexxz has joined #bitcoin-core-dev
4862018-04-09T19:31:10 *** kanexxz has quit IRC
4872018-04-09T19:37:56 *** donaloconnor has joined #bitcoin-core-dev
4882018-04-09T19:39:14 *** moneyball has quit IRC
4892018-04-09T19:40:06 *** moneyball has joined #bitcoin-core-dev
4902018-04-09T19:44:27 *** lightningbot has joined #bitcoin-core-dev
4912018-04-09T19:46:06 *** shtirlic has joined #bitcoin-core-dev
4922018-04-09T19:46:12 *** promag has joined #bitcoin-core-dev
4932018-04-09T19:50:22 *** provoostenator has quit IRC
4942018-04-09T19:53:27 *** provoostenator has joined #bitcoin-core-dev
4952018-04-09T19:53:52 *** promag has quit IRC
4962018-04-09T20:01:10 *** BashCo has joined #bitcoin-core-dev
4972018-04-09T20:02:05 *** BashCo_ has quit IRC
4982018-04-09T20:05:33 *** Victorsueca has quit IRC
4992018-04-09T20:06:59 *** Victorsueca has joined #bitcoin-core-dev
5002018-04-09T20:11:14 *** Randolf has joined #bitcoin-core-dev
5012018-04-09T20:15:08 *** ProfMac has quit IRC
5022018-04-09T20:15:32 *** dafunkiz_ has joined #bitcoin-core-dev
5032018-04-09T20:19:24 *** murchandamus has quit IRC
5042018-04-09T20:23:53 *** dafunkiz_ has quit IRC
5052018-04-09T20:24:18 *** qu4ku has joined #bitcoin-core-dev
5062018-04-09T20:26:58 *** murchandamus has joined #bitcoin-core-dev
5072018-04-09T20:29:29 *** murchandamus has quit IRC
5082018-04-09T20:30:14 *** CubicEarths has quit IRC
5092018-04-09T20:31:59 *** dafunkiz_ has joined #bitcoin-core-dev
5102018-04-09T20:34:55 *** CubicEarths has joined #bitcoin-core-dev
5112018-04-09T20:35:26 <bitcoin-git> [bitcoin] sipa opened pull request #12926: Run unit tests in parallel (master...201804_parunit) https://github.com/bitcoin/bitcoin/pull/12926
5122018-04-09T20:39:48 *** qu4ku has quit IRC
5132018-04-09T20:40:26 *** CubicEarths has quit IRC
5142018-04-09T20:42:15 *** intcat has quit IRC
5152018-04-09T20:42:49 *** murchandamus has joined #bitcoin-core-dev
5162018-04-09T20:44:02 *** dafunkiz_ has quit IRC
5172018-04-09T20:45:27 *** intcat has joined #bitcoin-core-dev
5182018-04-09T20:53:17 *** dafunkiz_ has joined #bitcoin-core-dev
5192018-04-09T20:56:01 <bitcoin-git> [bitcoin] trulex opened pull request #12927: Docs: fixed link, replaced QT with Qt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12927
5202018-04-09T20:58:38 *** zautomata1 has quit IRC
5212018-04-09T20:59:03 *** zautomata has joined #bitcoin-core-dev
5222018-04-09T21:00:07 *** zautomata has quit IRC
5232018-04-09T21:00:08 *** zautomata has joined #bitcoin-core-dev
5242018-04-09T21:00:16 *** Murch has quit IRC
5252018-04-09T21:00:46 *** Randolf has quit IRC
5262018-04-09T21:02:50 *** Murch has joined #bitcoin-core-dev
5272018-04-09T21:03:15 *** Randolf has joined #bitcoin-core-dev
5282018-04-09T21:05:42 *** freedomcode is now known as reardencode
5292018-04-09T21:08:11 *** Randolf has quit IRC
5302018-04-09T21:08:44 *** AaronvanW has quit IRC
5312018-04-09T21:08:49 *** Guyver2 has quit IRC
5322018-04-09T21:09:21 *** AaronvanW has joined #bitcoin-core-dev
5332018-04-09T21:13:27 *** AaronvanW has quit IRC
5342018-04-09T21:14:31 *** Krellan has joined #bitcoin-core-dev
5352018-04-09T21:15:24 *** satwo has joined #bitcoin-core-dev
5362018-04-09T21:17:57 *** dafunkiz_ has quit IRC
5372018-04-09T21:19:14 *** Krellan has quit IRC
5382018-04-09T21:23:21 *** dafunkiz_ has joined #bitcoin-core-dev
5392018-04-09T21:28:10 <jnewbery> wumpus: I'm adding #12892 as high priority for review. Please go ahead and remove it if you don't think it merits that.
5402018-04-09T21:28:12 <gribble> https://github.com/bitcoin/bitcoin/issues/12892 | [wallet] [rpc] introduce label API for wallet by jnewbery · Pull Request #12892 · bitcoin/bitcoin · GitHub
5412018-04-09T21:29:01 <jnewbery> oh, looks like I'm not allowed to. It needs triage into one of the columns
5422018-04-09T21:30:51 *** moneybal_ has joined #bitcoin-core-dev
5432018-04-09T21:31:49 *** moneyball has quit IRC
5442018-04-09T21:45:19 *** Victorsueca has quit IRC
5452018-04-09T21:46:28 *** ProfMac has joined #bitcoin-core-dev
5462018-04-09T21:46:28 *** Victorsueca has joined #bitcoin-core-dev
5472018-04-09T21:48:59 *** Murch has quit IRC
5482018-04-09T21:49:32 *** CubicEarths has joined #bitcoin-core-dev
5492018-04-09T21:57:03 *** Murch has joined #bitcoin-core-dev
5502018-04-09T21:58:04 *** moneybal_ has quit IRC
5512018-04-09T21:59:56 *** moneyball has joined #bitcoin-core-dev
5522018-04-09T22:02:33 *** satwo has quit IRC
5532018-04-09T22:05:29 *** donaloconnor has quit IRC
5542018-04-09T22:06:06 *** Randolf has joined #bitcoin-core-dev
5552018-04-09T22:09:13 *** moneyball has quit IRC
5562018-04-09T22:11:07 *** moneyball has joined #bitcoin-core-dev
5572018-04-09T22:11:45 *** moneyball has quit IRC
5582018-04-09T22:12:16 *** moneyball has joined #bitcoin-core-dev
5592018-04-09T22:12:51 *** moneyball has quit IRC
5602018-04-09T22:13:18 *** moneyball has joined #bitcoin-core-dev
5612018-04-09T22:20:09 *** AaronvanW has joined #bitcoin-core-dev
5622018-04-09T22:24:58 *** AaronvanW has quit IRC
5632018-04-09T22:29:17 *** promag has joined #bitcoin-core-dev
5642018-04-09T22:34:22 *** zigen has joined #bitcoin-core-dev
5652018-04-09T22:39:03 *** zigen has quit IRC
5662018-04-09T22:41:28 *** moneyball has quit IRC
5672018-04-09T22:50:11 *** Emcy has quit IRC
5682018-04-09T22:51:21 *** Emcy has joined #bitcoin-core-dev
5692018-04-09T23:03:57 *** cryptojanitor has quit IRC
5702018-04-09T23:09:24 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf8073f8d1d1...7ee6fc58f87b
5712018-04-09T23:09:24 <bitcoin-git> bitcoin/master 23abfb7 Steve Lee: added logging line back that was accidentally removed with #10762
5722018-04-09T23:09:25 <bitcoin-git> bitcoin/master 7ee6fc5 MarcoFalke: Merge #12845: Trivial: Add logging line in init.cpp that was accidentally removed with #10762...
5732018-04-09T23:10:06 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12845: Trivial: Add logging line in init.cpp that was accidentally removed with #10762 (master...add_logging_line_to_newer_branch) https://github.com/bitcoin/bitcoin/pull/12845
5742018-04-09T23:11:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee6fc58f87b...06ead15050f5
5752018-04-09T23:11:14 <bitcoin-git> bitcoin/master 7039319 Darko JankoviÄ: Docs: fixed link, replaced QT with Qt
5762018-04-09T23:11:15 <bitcoin-git> bitcoin/master 06ead15 MarcoFalke: Merge #12927: Docs: fixed link, replaced QT with Qt...
5772018-04-09T23:12:10 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12927: Docs: fixed link, replaced QT with Qt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12927
5782018-04-09T23:12:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/06ead15050f5...727175a08dff
5792018-04-09T23:12:30 <bitcoin-git> bitcoin/master 75d0e4c Suhas Daftuar: [qa] Delete cookie file before starting node...
5802018-04-09T23:12:31 <bitcoin-git> bitcoin/master 727175a MarcoFalke: Merge #12902: [qa] Handle potential cookie race when starting node...
5812018-04-09T23:13:14 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12902: [qa] Handle potential cookie race when starting node (master...2018-04-improve-dbcrash-restarts) https://github.com/bitcoin/bitcoin/pull/12902
5822018-04-09T23:21:39 *** wunpunch has quit IRC
5832018-04-09T23:26:13 <bitcoin-git> [bitcoin] practicalswift opened pull request #12928: qt: Initialize variables previously neither defined where defined nor in constructor (master...qt-constructors) https://github.com/bitcoin/bitcoin/pull/12928
5842018-04-09T23:29:13 *** belcher_ has quit IRC
5852018-04-09T23:52:34 *** cryptojanitor has joined #bitcoin-core-dev
5862018-04-09T23:53:53 *** satwo has joined #bitcoin-core-dev