12018-04-20T00:00:02 *** weez17 has quit IRC
22018-04-20T00:00:39 *** weez17 has joined #bitcoin-core-dev
32018-04-20T00:11:41 <bitcoin-git> [bitcoin] jimpo opened pull request #13033: Build txindex in parallel with validation (master...txindex-refactor-take2) https://github.com/bitcoin/bitcoin/pull/13033
42018-04-20T00:12:54 <bitcoin-git> [bitcoin] jimpo closed pull request #11857: Build tx index in parallel with validation (master...txindex-refactor) https://github.com/bitcoin/bitcoin/pull/11857
52018-04-20T00:18:05 *** grafcaps has quit IRC
62018-04-20T00:21:39 *** bzb has quit IRC
72018-04-20T00:26:45 *** Murch has quit IRC
82018-04-20T00:33:28 *** grafcaps has joined #bitcoin-core-dev
92018-04-20T00:41:19 *** CubicEarths has joined #bitcoin-core-dev
102018-04-20T00:47:36 *** mistergold has quit IRC
112018-04-20T00:52:21 *** ProfMac has quit IRC
122018-04-20T00:55:25 *** Murch has joined #bitcoin-core-dev
132018-04-20T00:55:33 <achow101> github responded to me about 11857 and they told me that they're looking into it. apparently some other PRs in other projects are seeing similar issues
142018-04-20T00:57:36 *** Murch has quit IRC
152018-04-20T01:13:13 *** harrymm has quit IRC
162018-04-20T01:14:26 *** harrymm has joined #bitcoin-core-dev
172018-04-20T01:18:25 *** grafcaps has quit IRC
182018-04-20T01:18:41 *** zigen has joined #bitcoin-core-dev
192018-04-20T01:27:10 *** grafcaps has joined #bitcoin-core-dev
202018-04-20T01:30:45 *** jtimon has quit IRC
212018-04-20T01:30:53 *** ProfMac has joined #bitcoin-core-dev
222018-04-20T01:35:06 *** fanquake has joined #bitcoin-core-dev
232018-04-20T01:41:55 *** isis_ is now known as isis
242018-04-20T01:53:36 <bitcoin-git> [bitcoin] promag opened pull request #13034: Introduce WalletManager (master...2018-04-walletmanager) https://github.com/bitcoin/bitcoin/pull/13034
252018-04-20T02:12:09 *** Krellan has quit IRC
262018-04-20T02:17:16 *** helo_ is now known as helo
272018-04-20T02:19:56 *** justanotheruser has quit IRC
282018-04-20T02:20:33 *** justan0theruser has joined #bitcoin-core-dev
292018-04-20T02:21:56 *** fanquake has quit IRC
302018-04-20T02:22:25 *** grafcaps has quit IRC
312018-04-20T02:25:37 *** promag has quit IRC
322018-04-20T02:32:17 *** fanquake has joined #bitcoin-core-dev
332018-04-20T02:34:42 *** fanquake has quit IRC
342018-04-20T02:37:28 *** fanquake has joined #bitcoin-core-dev
352018-04-20T02:42:48 *** Murch has joined #bitcoin-core-dev
362018-04-20T02:49:34 *** fanquake has quit IRC
372018-04-20T02:49:41 *** Murch has quit IRC
382018-04-20T02:50:56 *** wxiwsu has joined #bitcoin-core-dev
392018-04-20T02:54:21 *** jojeyh has quit IRC
402018-04-20T02:54:58 *** grafcaps has joined #bitcoin-core-dev
412018-04-20T02:56:04 *** wxiwsu has quit IRC
422018-04-20T02:58:21 *** ProfMac has quit IRC
432018-04-20T03:01:13 *** zigen has quit IRC
442018-04-20T03:01:51 *** zigen has joined #bitcoin-core-dev
452018-04-20T03:04:40 *** Sinclair6 has quit IRC
462018-04-20T03:06:05 *** zigen has quit IRC
472018-04-20T03:10:29 *** Aaronvan_ has quit IRC
482018-04-20T03:13:09 *** jojeyh has joined #bitcoin-core-dev
492018-04-20T03:45:02 *** d9b4bef9 has quit IRC
502018-04-20T03:46:08 *** d9b4bef9 has joined #bitcoin-core-dev
512018-04-20T03:48:38 *** ProfMac has joined #bitcoin-core-dev
522018-04-20T03:50:09 *** zautomata1 has joined #bitcoin-core-dev
532018-04-20T03:50:31 *** cryptojanitor has quit IRC
542018-04-20T03:52:25 *** zautomata has quit IRC
552018-04-20T03:58:57 *** grafcaps has quit IRC
562018-04-20T04:16:27 *** grafcaps has joined #bitcoin-core-dev
572018-04-20T04:23:58 *** zigen has joined #bitcoin-core-dev
582018-04-20T04:31:51 *** ProfMac has quit IRC
592018-04-20T04:32:33 *** Murch has joined #bitcoin-core-dev
602018-04-20T04:36:06 *** ohnx has quit IRC
612018-04-20T04:37:20 *** ohnx has joined #bitcoin-core-dev
622018-04-20T04:41:46 *** anstaendig has quit IRC
632018-04-20T04:53:17 <jimpo> ajtown: Nice tip on --color-moved. TIL.
642018-04-20T04:55:50 <aj> jimpo: pfft, old news. i've known about it for days!
652018-04-20T05:00:11 <sipa> what is --color-moved?!
662018-04-20T05:00:32 *** intcat has quit IRC
672018-04-20T05:00:32 *** ghost43 has quit IRC
682018-04-20T05:00:33 *** dermoth has quit IRC
692018-04-20T05:00:33 *** arubi has quit IRC
702018-04-20T05:00:47 *** ghost43 has joined #bitcoin-core-dev
712018-04-20T05:00:56 *** arubi has joined #bitcoin-core-dev
722018-04-20T05:01:28 <jimpo> aj: hahaha
732018-04-20T05:01:28 *** intcat has joined #bitcoin-core-dev
742018-04-20T05:06:00 <aj> sipa: "git diff HEAD^ --color-moved=zebra"
752018-04-20T05:07:00 *** arbitrary_guy has quit IRC
762018-04-20T05:07:02 <sipa> doesn't work here
772018-04-20T05:07:02 <aj> sipa: i found it while looking for easier ways to review #12885
782018-04-20T05:07:04 <gribble> https://github.com/bitcoin/bitcoin/issues/12885 | Reduce implementation code inside CScript by sipa · Pull Request #12885 · bitcoin/bitcoin · GitHub
792018-04-20T05:07:33 <aj> sipa: needs to be run on a moveonly-type commit, it uses colours so might depend on your terminal
802018-04-20T05:07:34 <kallewoof> Oooh, neat
812018-04-20T05:07:58 <sipa> i use git diff --patience HEAD~:src/file.cpp HEAD:src/newfile.cpp
822018-04-20T05:08:48 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8b7b4b33c9...8b262eb2d80b
832018-04-20T05:08:48 <bitcoin-git> bitcoin/master b77b6e2 Jim Posen: MOVEONLY: Move logging code from util.{h,cpp} to new files.
842018-04-20T05:08:49 <bitcoin-git> bitcoin/master 8b262eb Pieter Wuille: Merge #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files....
852018-04-20T05:09:42 <bitcoin-git> [bitcoin] sipa closed pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (master...logging-files) https://github.com/bitcoin/bitcoin/pull/13021
862018-04-20T05:11:05 <aj> ah, needs git 2.15 which came out octoberish 2017
872018-04-20T05:11:19 <sipa> seems i have 2.14
882018-04-20T05:16:05 *** anstaendig has joined #bitcoin-core-dev
892018-04-20T05:20:39 *** anstaendig has quit IRC
902018-04-20T05:23:31 <bitcoin-git> [bitcoin] macraix opened pull request #13036: PicoStocks 100TH problem (master...master) https://github.com/bitcoin/bitcoin/pull/13036
912018-04-20T05:24:08 <bitcoin-git> [bitcoin] fanquake closed pull request #13036: PicoStocks 100TH problem (master...master) https://github.com/bitcoin/bitcoin/pull/13036
922018-04-20T05:31:15 *** d_t has quit IRC
932018-04-20T05:35:41 *** zigen has quit IRC
942018-04-20T05:36:13 *** zigen has joined #bitcoin-core-dev
952018-04-20T05:38:00 *** zigen_ has joined #bitcoin-core-dev
962018-04-20T05:38:15 *** zigen has quit IRC
972018-04-20T05:42:37 *** zigen_ has quit IRC
982018-04-20T05:43:12 *** zigen has joined #bitcoin-core-dev
992018-04-20T05:50:23 *** Murch has quit IRC
1002018-04-20T05:59:21 *** davec has quit IRC
1012018-04-20T06:09:41 *** davec has joined #bitcoin-core-dev
1022018-04-20T06:09:54 <wumpus> --color-moved=zebra? can we pick other animals too?
1032018-04-20T06:10:29 * wumpus looks at his git version... 2.7.4.. oh alright, maybe in a few years
1042018-04-20T06:12:17 *** RoBz has quit IRC
1052018-04-20T06:15:55 *** Krellan has joined #bitcoin-core-dev
1062018-04-20T06:20:07 *** crt4 has joined #bitcoin-core-dev
1072018-04-20T06:33:54 *** dermoth has joined #bitcoin-core-dev
1082018-04-20T06:37:21 *** Krellan has quit IRC
1092018-04-20T06:45:59 *** promag has joined #bitcoin-core-dev
1102018-04-20T06:46:21 *** Krellan has joined #bitcoin-core-dev
1112018-04-20T06:46:50 <promag> wumpus: hi, do you think you can check #13017?
1122018-04-20T06:46:51 <gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
1132018-04-20T06:48:13 *** promag has quit IRC
1142018-04-20T06:52:32 *** arubi has quit IRC
1152018-04-20T06:54:31 *** bedotech has joined #bitcoin-core-dev
1162018-04-20T06:56:57 *** arubi has joined #bitcoin-core-dev
1172018-04-20T06:57:44 *** tylevine has quit IRC
1182018-04-20T07:00:20 *** tylevine has joined #bitcoin-core-dev
1192018-04-20T07:03:39 *** promag has joined #bitcoin-core-dev
1202018-04-20T07:08:40 *** setpill has joined #bitcoin-core-dev
1212018-04-20T07:18:01 *** votefrac has joined #bitcoin-core-dev
1222018-04-20T07:18:20 *** promag has quit IRC
1232018-04-20T07:21:37 *** lnostdal has quit IRC
1242018-04-20T07:27:53 *** votefrac has quit IRC
1252018-04-20T07:31:34 *** lnostdal has joined #bitcoin-core-dev
1262018-04-20T07:40:38 *** zarez has joined #bitcoin-core-dev
1272018-04-20T07:43:50 *** bedotech has quit IRC
1282018-04-20T07:44:20 *** votefrac has joined #bitcoin-core-dev
1292018-04-20T07:46:49 *** votefrac has quit IRC
1302018-04-20T07:51:34 *** meshcollider has joined #bitcoin-core-dev
1312018-04-20T07:52:04 *** StopAndDecrypt has quit IRC
1322018-04-20T07:53:06 *** StopAndDecrypt has joined #bitcoin-core-dev
1332018-04-20T07:53:16 *** StopAndDecrypt has quit IRC
1342018-04-20T07:53:16 *** StopAndDecrypt has joined #bitcoin-core-dev
1352018-04-20T07:56:47 *** timothy has joined #bitcoin-core-dev
1362018-04-20T08:01:13 *** drizztbsd has joined #bitcoin-core-dev
1372018-04-20T08:01:34 *** timothy has quit IRC
1382018-04-20T08:02:13 *** zigen has quit IRC
1392018-04-20T08:02:42 *** zigen has joined #bitcoin-core-dev
1402018-04-20T08:03:10 *** crt4 has quit IRC
1412018-04-20T08:34:58 *** promag has joined #bitcoin-core-dev
1422018-04-20T08:47:55 <bitcoin-git> [bitcoin] charkala opened pull request #13037: Genesis (master...genesis) https://github.com/bitcoin/bitcoin/pull/13037
1432018-04-20T08:48:20 <bitcoin-git> [bitcoin] charkala closed pull request #13037: Genesis (master...genesis) https://github.com/bitcoin/bitcoin/pull/13037
1442018-04-20T08:50:32 <meshcollider> wumpus do you want to merge https://github.com/bitcoin-core/bitcoincore.org/pull/528 now its had plenty of review and has been sitting there for a while
1452018-04-20T08:50:52 *** zigen has quit IRC
1462018-04-20T08:51:29 *** zigen has joined #bitcoin-core-dev
1472018-04-20T08:52:08 *** zigen has quit IRC
1482018-04-20T08:52:25 *** zigen has joined #bitcoin-core-dev
1492018-04-20T08:59:57 *** crt4 has joined #bitcoin-core-dev
1502018-04-20T09:00:22 *** lnostdal has quit IRC
1512018-04-20T09:02:02 *** d9b4bef9 has quit IRC
1522018-04-20T09:03:08 *** d9b4bef9 has joined #bitcoin-core-dev
1532018-04-20T09:12:00 *** lnostdal has joined #bitcoin-core-dev
1542018-04-20T09:16:01 <wumpus> meshcollider: will have a look, thanks
1552018-04-20T09:35:40 <promag> wumpus: not sure if I understand your argument, currently CWalletRef is narrowly used. Depending on the case it can be acceptable to use either reference, raw pointer or shared pointer. When adding shared pointer I would like to review all places where it makes sense to use it. If we had CWalletRef everywhere then that would obscure that evaluation.
1562018-04-20T09:36:42 <wumpus> promag: it's usually preferable to keep diffs minimal, without a type such as CWalletRef it means every usage has to be changed if the underlying type changes, the whole reason typedefs exist...
1572018-04-20T09:37:00 <wumpus> most users of CWalletRef won't care how it works internally
1582018-04-20T09:37:04 <wumpus> they just want to refer to a wallet
1592018-04-20T09:37:25 <promag> but my point is that not all CWallet* should be std::shared_ptr
1602018-04-20T09:38:10 <wumpus> maybe not, i still think an abstract reference type makes sense
1612018-04-20T09:38:19 <promag> I think that makes sense if CWalletRef was used where it makes sense to switch to shared pointer, but that's not the case
1622018-04-20T09:38:47 <wumpus> yes I agree they don't all need to be replaced
1632018-04-20T09:39:07 <wumpus> what annoyed me is the back and forth, one refactor introduces a certain type then the next one removes it again
1642018-04-20T09:39:10 <promag> even if I keep CWalletRef, switching to std::shared_ptr will cause a (not that) large diff
1652018-04-20T09:39:16 <wumpus> so let's just get on one page first
1662018-04-20T09:39:56 <promag> typedef aside, the code base must be refactored to shared pointers
1672018-04-20T09:40:20 <wumpus> my point was not 'this is a bad idea' but 'this needs discussion with the people involved'
1682018-04-20T09:41:37 <wumpus> if there is general agreement to undo the CWalletRef type again, that's ok with me
1692018-04-20T09:41:50 <promag> wumpus: fair enough, I can revert it too. I should have predicted this :D
1702018-04-20T09:41:51 <wumpus> though it makes me wonder what reasoning introduced it and what changed since
1712018-04-20T09:42:11 <promag> let me blame it
1722018-04-20T09:42:19 <wumpus> now that's a good idea
1732018-04-20T09:43:37 *** jtimon has joined #bitcoin-core-dev
1742018-04-20T09:45:08 <promag> introduced in #8694 by luke-jr
1752018-04-20T09:45:12 <gribble> https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
1762018-04-20T09:45:51 <promag> https://github.com/bitcoin/bitcoin/pull/8694#discussion_r104522825
1772018-04-20T09:47:16 <promag> wumpus: I guess from that PR that there was little discussion
1782018-04-20T09:47:16 <wumpus> let's try to get luke-jr on board there, then
1792018-04-20T09:47:36 <promag> right
1802018-04-20T09:52:47 *** tryphe has quit IRC
1812018-04-20T09:53:14 *** tryphe has joined #bitcoin-core-dev
1822018-04-20T09:54:17 *** tryphe has quit IRC
1832018-04-20T09:55:20 *** crt4 has quit IRC
1842018-04-20T10:00:22 *** justan0theruser has quit IRC
1852018-04-20T10:01:30 *** tryphe has joined #bitcoin-core-dev
1862018-04-20T10:10:02 *** zigen has quit IRC
1872018-04-20T10:11:26 *** zigen has joined #bitcoin-core-dev
1882018-04-20T10:16:22 <bitcoin-git> [bitcoin] laanwj opened pull request #13039: Add logging and error handling for file syncing (master...2018_04_fsync_noignore) https://github.com/bitcoin/bitcoin/pull/13039
1892018-04-20T10:23:10 *** jojeyh has quit IRC
1902018-04-20T10:23:17 *** promag has quit IRC
1912018-04-20T10:27:57 *** RoBz has joined #bitcoin-core-dev
1922018-04-20T10:27:57 *** RoBz has joined #bitcoin-core-dev
1932018-04-20T10:31:17 *** goatpig has joined #bitcoin-core-dev
1942018-04-20T10:35:17 *** Guyver2 has joined #bitcoin-core-dev
1952018-04-20T10:40:21 *** crt4 has joined #bitcoin-core-dev
1962018-04-20T10:44:46 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1972018-04-20T10:44:46 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1982018-04-20T10:45:36 *** zigen has quit IRC
1992018-04-20T10:46:10 *** zigen has joined #bitcoin-core-dev
2002018-04-20T10:50:05 *** zigen has quit IRC
2012018-04-20T11:11:13 *** setpill has quit IRC
2022018-04-20T11:36:52 *** Sentineo has quit IRC
2032018-04-20T11:45:25 *** promag has joined #bitcoin-core-dev
2042018-04-20T11:49:52 *** Giszmo has quit IRC
2052018-04-20T11:57:00 *** cryptojanitor has joined #bitcoin-core-dev
2062018-04-20T11:58:32 *** crt4 has quit IRC
2072018-04-20T12:03:04 <bitcoin-git> [bitcoin] AsKayDevs opened pull request #13040: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/13040
2082018-04-20T12:03:34 *** laurentmt has joined #bitcoin-core-dev
2092018-04-20T12:08:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2102018-04-20T12:13:05 *** BCBot has quit IRC
2112018-04-20T12:20:24 <bitcoin-git> [bitcoin] practicalswift opened pull request #13041: build: Add linter checking for accidental introduction of locale dependence (master...lint-locale-dependence) https://github.com/bitcoin/bitcoin/pull/13041
2122018-04-20T12:24:17 <bitcoin-git> [bitcoin] fanquake closed pull request #13040: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/13040
2132018-04-20T12:30:03 *** BCBot has joined #bitcoin-core-dev
2142018-04-20T12:32:52 *** AaronvanW has joined #bitcoin-core-dev
2152018-04-20T12:39:13 *** tryphe has quit IRC
2162018-04-20T12:39:38 *** tryphe has joined #bitcoin-core-dev
2172018-04-20T12:44:34 *** Chris_Stewart_5 has quit IRC
2182018-04-20T12:46:21 <bitcoin-git> [bitcoin] qshuai opened pull request #13042: Calculated nBits will be replaced by the following GetNextWorkRequire⦠(master...master) https://github.com/bitcoin/bitcoin/pull/13042
2192018-04-20T12:52:02 *** d9b4bef9 has quit IRC
2202018-04-20T12:53:08 *** d9b4bef9 has joined #bitcoin-core-dev
2212018-04-20T12:53:23 *** LeMiner has joined #bitcoin-core-dev
2222018-04-20T13:00:38 *** promag has quit IRC
2232018-04-20T13:19:34 *** zigen has joined #bitcoin-core-dev
2242018-04-20T13:20:53 *** zigen has quit IRC
2252018-04-20T13:21:00 *** zigen has joined #bitcoin-core-dev
2262018-04-20T13:22:02 *** michagogo has quit IRC
2272018-04-20T13:22:41 <bitcoin-git> [bitcoin] Sjors opened pull request #13043: [qt] OptionsDialog: add prune setting (master...2018/04/qt-prune) https://github.com/bitcoin/bitcoin/pull/13043
2282018-04-20T13:22:44 *** michagogo has joined #bitcoin-core-dev
2292018-04-20T13:26:00 *** zigen has quit IRC
2302018-04-20T13:31:12 *** promag has joined #bitcoin-core-dev
2312018-04-20T13:31:33 *** dcousens has quit IRC
2322018-04-20T13:35:10 *** Krellan has quit IRC
2332018-04-20T13:35:47 *** Krellan has joined #bitcoin-core-dev
2342018-04-20T13:35:50 *** promag has quit IRC
2352018-04-20T13:42:09 *** dcousens has joined #bitcoin-core-dev
2362018-04-20T13:44:56 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2372018-04-20T13:48:50 *** promag has joined #bitcoin-core-dev
2382018-04-20T14:05:33 *** jcohen has joined #bitcoin-core-dev
2392018-04-20T14:07:36 *** meshcollider has quit IRC
2402018-04-20T14:08:09 *** AaronvanW has quit IRC
2412018-04-20T14:08:45 *** grafcaps has quit IRC
2422018-04-20T14:15:04 *** sugarpuff has quit IRC
2432018-04-20T14:15:22 *** sugarpuff has joined #bitcoin-core-dev
2442018-04-20T14:15:40 *** bedo has joined #bitcoin-core-dev
2452018-04-20T14:16:48 *** bedo is now known as bedotech
2462018-04-20T14:25:27 *** grafcaps has joined #bitcoin-core-dev
2472018-04-20T14:31:36 *** Giszmo has joined #bitcoin-core-dev
2482018-04-20T14:32:49 *** AaronvanW has joined #bitcoin-core-dev
2492018-04-20T14:33:34 *** Murch has joined #bitcoin-core-dev
2502018-04-20T14:34:41 *** cubancorona has joined #bitcoin-core-dev
2512018-04-20T14:42:49 *** udiWertheimer has quit IRC
2522018-04-20T14:43:05 *** udiWertheimer has joined #bitcoin-core-dev
2532018-04-20T14:43:07 *** Samdney has joined #bitcoin-core-dev
2542018-04-20T14:47:07 *** zigen has joined #bitcoin-core-dev
2552018-04-20T14:51:44 *** zigen has quit IRC
2562018-04-20T15:14:27 *** SopaXorzTaker has joined #bitcoin-core-dev
2572018-04-20T15:23:11 *** AaronvanW has quit IRC
2582018-04-20T15:31:33 *** cryptojanitor has quit IRC
2592018-04-20T15:31:46 *** cryptojanitor has joined #bitcoin-core-dev
2602018-04-20T15:33:39 *** meshcollider has joined #bitcoin-core-dev
2612018-04-20T15:34:13 *** AaronvanW has joined #bitcoin-core-dev
2622018-04-20T15:41:19 *** cubancorona has quit IRC
2632018-04-20T15:45:34 *** laurentmt has quit IRC
2642018-04-20T15:46:10 *** lnostdal has quit IRC
2652018-04-20T15:47:18 *** Randolf has quit IRC
2662018-04-20T15:48:57 *** vicenteH has joined #bitcoin-core-dev
2672018-04-20T15:49:10 *** Krellan has quit IRC
2682018-04-20T15:49:47 *** Krellan has joined #bitcoin-core-dev
2692018-04-20T15:56:23 *** cubancorona has joined #bitcoin-core-dev
2702018-04-20T15:58:13 *** promag has quit IRC
2712018-04-20T15:58:41 <cfields> wumpus: with our powers combined, we've finally arrived at &= :)
2722018-04-20T15:58:56 <cfields> no clue what I was thinking there.
2732018-04-20T16:07:16 *** Randolf has joined #bitcoin-core-dev
2742018-04-20T16:09:43 <BlueMatt> sipa: whats your current feeling on caching witness hashes/the sighash components somewhere on mempool acceptance?
2752018-04-20T16:13:08 <sipa> BlueMatt: caching sure, but not in the same class that is used for everything
2762018-04-20T16:13:12 *** zarez has quit IRC
2772018-04-20T16:13:18 <BlueMatt> yea, ok, fair
2782018-04-20T16:13:25 <BlueMatt> I thought that was rejected on the first go around :/
2792018-04-20T16:17:19 <BlueMatt> wumpus: re: #12998: I'm open to doing whatever to fix it, that was just the simplest thing (fix it for the narrow case when those functions are #define'd by the compiler's headers). cfields suggested moving those functions to _int, but I'm not sure making a downstream project's build scripts easier is worth the refactor for that, but up to y'all
2802018-04-20T16:17:20 <gribble> https://github.com/bitcoin/bitcoin/issues/12998 | Default to defining endian-conversion DECLs in compat w/o config by TheBlueMatt · Pull Request #12998 · bitcoin/bitcoin · GitHub
2812018-04-20T16:17:32 <BlueMatt> I just wanna figure out if I should just apply that patch downstream or what
2822018-04-20T16:19:32 <jcohen> i have a half completed change somewhere that makes proper types out of TxId / WTxId instead of using uint256 somewhere - i can clean up if there's to be more pervasive use of witness ids - doesn't do anything other than readability / compiler safety
2832018-04-20T16:29:44 *** arbitrary_guy has joined #bitcoin-core-dev
2842018-04-20T16:39:06 <luke-jr> wumpus: CWalletRef was intentionally introduced such that it can be replaced with a shared_ptr painlessly
2852018-04-20T16:39:30 <luke-jr> I probably still have a branch with that change
2862018-04-20T16:41:54 *** skeees has joined #bitcoin-core-dev
2872018-04-20T16:42:35 *** SopaXorzTaker has quit IRC
2882018-04-20T16:56:48 *** SopaXorzTaker has joined #bitcoin-core-dev
2892018-04-20T16:59:10 *** Randolf has quit IRC
2902018-04-20T17:00:22 *** AaronvanW has quit IRC
2912018-04-20T17:00:29 *** Krellan has quit IRC
2922018-04-20T17:00:58 *** Krellan has joined #bitcoin-core-dev
2932018-04-20T17:02:09 *** SopaXorzTaker has quit IRC
2942018-04-20T17:10:45 *** AaronvanW has joined #bitcoin-core-dev
2952018-04-20T17:10:56 *** Krellan has quit IRC
2962018-04-20T17:11:14 *** anstaendig has joined #bitcoin-core-dev
2972018-04-20T17:15:35 *** AaronvanW has quit IRC
2982018-04-20T17:23:06 *** SopaXorzTaker has joined #bitcoin-core-dev
2992018-04-20T17:26:22 <bitcoin-git> [bitcoin] instagibbs opened pull request #13045: [p2p] getblock for 1-block reorgs in response to compact block message (master...cmpcttie) https://github.com/bitcoin/bitcoin/pull/13045
3002018-04-20T17:26:35 *** AaronvanW has joined #bitcoin-core-dev
3012018-04-20T17:31:29 *** Murch has quit IRC
3022018-04-20T17:32:42 *** arbitrary_guy has quit IRC
3032018-04-20T17:36:23 <cfields> BlueMatt: I think it's fine as-is. But if you want to take it further, I think it'd be pretty trivial to switch to _int.
3042018-04-20T17:37:23 *** Cogito_Ergo_Sum has quit IRC
3052018-04-20T17:41:11 *** drizztbsd has quit IRC
3062018-04-20T17:41:38 *** cryptojanitor has quit IRC
3072018-04-20T17:44:51 *** isis is now known as isis_
3082018-04-20T17:45:05 *** CubicEarths has quit IRC
3092018-04-20T17:45:35 *** CubicEarths has joined #bitcoin-core-dev
3102018-04-20T17:46:19 *** Aaronvan_ has joined #bitcoin-core-dev
3112018-04-20T17:46:56 *** arbitrary_guy has joined #bitcoin-core-dev
3122018-04-20T17:47:35 *** meshcollider has quit IRC
3132018-04-20T17:49:04 *** AaronvanW has quit IRC
3142018-04-20T17:50:02 *** d9b4bef9 has quit IRC
3152018-04-20T17:50:25 *** CubicEarths has quit IRC
3162018-04-20T17:51:07 *** d9b4bef9 has joined #bitcoin-core-dev
3172018-04-20T17:53:06 *** AaronvanW has joined #bitcoin-core-dev
3182018-04-20T17:55:51 *** CubicEarths has joined #bitcoin-core-dev
3192018-04-20T17:56:27 <bitcoin-git> [bitcoin] skeees opened pull request #13046: [doc][trivial] no retargeting in regtest mode (master...doc-update) https://github.com/bitcoin/bitcoin/pull/13046
3202018-04-20T17:56:35 *** Aaronvan_ has quit IRC
3212018-04-20T17:58:59 *** bedotech has quit IRC
3222018-04-20T17:59:53 *** arbitrary_guy has quit IRC
3232018-04-20T18:06:59 *** Krellan has joined #bitcoin-core-dev
3242018-04-20T18:08:01 *** zautomata1 has quit IRC
3252018-04-20T18:08:57 *** Krellan has quit IRC
3262018-04-20T18:09:02 *** lnostdal has joined #bitcoin-core-dev
3272018-04-20T18:09:28 *** Krellan has joined #bitcoin-core-dev
3282018-04-20T18:10:23 *** CubicEarths has quit IRC
3292018-04-20T18:13:57 *** CubicEarths has joined #bitcoin-core-dev
3302018-04-20T18:15:13 *** Giszmo has quit IRC
3312018-04-20T18:15:58 *** Murch has joined #bitcoin-core-dev
3322018-04-20T18:19:16 <bitcoin-git> [bitcoin] jnewbery opened pull request #13047: [trivial] Tidy blocktools.py (master...tidy_blocktools) https://github.com/bitcoin/bitcoin/pull/13047
3332018-04-20T18:22:26 *** laurentmt has joined #bitcoin-core-dev
3342018-04-20T18:22:49 <jnewbery> 13017 doesn't make replacing the raw pointers with shared_ptrs and easier or more difficult, so I don't think it really needs too much discussion.
3352018-04-20T18:25:27 *** laurentmt has quit IRC
3362018-04-20T18:29:48 *** Giszmo has joined #bitcoin-core-dev
3372018-04-20T18:36:32 *** zautomata1 has joined #bitcoin-core-dev
3382018-04-20T18:47:17 *** bsm1175321 has quit IRC
3392018-04-20T19:10:42 *** SopaXorzTaker has quit IRC
3402018-04-20T19:30:55 *** promag has joined #bitcoin-core-dev
3412018-04-20T19:36:58 *** promag has quit IRC
3422018-04-20T19:41:02 <jimpo> Can I get a look on #12647? It's pretty trivial.
3432018-04-20T19:41:04 <gribble> https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub
3442018-04-20T19:43:41 *** Chris_Stewart_5 has quit IRC
3452018-04-20T19:46:31 *** promag has joined #bitcoin-core-dev
3462018-04-20T19:50:33 *** promag has quit IRC
3472018-04-20T19:51:18 <bitcoin-git> [bitcoin] jnewbery opened pull request #13048: [tests] Fix feature_block flakiness (master...fix_feature_block_flakiness) https://github.com/bitcoin/bitcoin/pull/13048
3482018-04-20T19:57:28 *** ProfMac has joined #bitcoin-core-dev
3492018-04-20T20:04:23 *** timothy has joined #bitcoin-core-dev
3502018-04-20T20:04:32 *** isis_ is now known as isis
3512018-04-20T20:14:26 *** timothy has quit IRC
3522018-04-20T20:25:05 <jtimon> updated https://github.com/bitcoin/bitcoin/pull/10757 again
3532018-04-20T20:25:22 *** jojeyh has joined #bitcoin-core-dev
3542018-04-20T20:25:44 <jtimon> btw aj cool your new test cached a bug
3552018-04-20T20:40:01 *** owowo has quit IRC
3562018-04-20T20:43:29 *** Dizzle has joined #bitcoin-core-dev
3572018-04-20T20:45:05 *** owowo has joined #bitcoin-core-dev
3582018-04-20T20:53:50 *** bsm1175321 has joined #bitcoin-core-dev
3592018-04-20T20:55:40 *** frog has joined #bitcoin-core-dev
3602018-04-20T20:56:06 *** Murch has quit IRC
3612018-04-20T20:58:03 *** frog has quit IRC
3622018-04-20T21:05:54 *** min has joined #bitcoin-core-dev
3632018-04-20T21:11:55 *** Murch has joined #bitcoin-core-dev
3642018-04-20T21:14:24 *** Murch has quit IRC
3652018-04-20T21:22:56 *** Randolf has joined #bitcoin-core-dev
3662018-04-20T21:25:11 *** arbitrary_guy has joined #bitcoin-core-dev
3672018-04-20T21:25:53 *** bsm1175321 has quit IRC
3682018-04-20T21:28:18 *** Murch has joined #bitcoin-core-dev
3692018-04-20T21:33:41 *** tryphe_ has joined #bitcoin-core-dev
3702018-04-20T21:37:11 *** tryphe has quit IRC
3712018-04-20T21:44:35 *** Dizzle has quit IRC
3722018-04-20T21:47:01 *** d9b4bef9 has quit IRC
3732018-04-20T21:49:55 *** Murch has quit IRC
3742018-04-20T21:50:09 *** d9b4bef9 has joined #bitcoin-core-dev
3752018-04-20T21:51:02 *** d9b4bef9 has quit IRC
3762018-04-20T21:52:08 *** d9b4bef9 has joined #bitcoin-core-dev
3772018-04-20T21:53:02 *** d9b4bef9 has quit IRC
3782018-04-20T21:54:15 *** d9b4bef9 has joined #bitcoin-core-dev
3792018-04-20T21:55:38 *** ProfMac has quit IRC
3802018-04-20T21:59:17 *** promag has joined #bitcoin-core-dev
3812018-04-20T22:00:21 *** Guyver2 has quit IRC
3822018-04-20T22:08:15 <promag> luke-jr: mind checking for the shared pointer branch, I would like to see it? There are lot of places where CWallet* must be changed to CWalletRef or std::shared_ptr<CWallet>, and IMO there are some places where CWalletRef should be CWallet* IMO. I've dropped CWalletRef so that the PR introducing shared_ptr would do it in the whole source.
3832018-04-20T22:08:30 *** min has quit IRC
3842018-04-20T22:09:27 *** Murch has joined #bitcoin-core-dev
3852018-04-20T22:10:18 *** ProfMac has joined #bitcoin-core-dev
3862018-04-20T22:13:30 *** Keta has joined #bitcoin-core-dev
3872018-04-20T22:24:09 *** Keta has quit IRC
3882018-04-20T22:35:45 *** ProfMac has quit IRC
3892018-04-20T22:46:03 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3902018-04-20T22:46:34 *** grafcaps has quit IRC
3912018-04-20T22:47:51 *** ProfMac has joined #bitcoin-core-dev
3922018-04-20T22:51:59 *** justanotheruser has joined #bitcoin-core-dev
3932018-04-20T22:52:56 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13049: [0.16] qa: Backports (0.16...Mf1804-qa16Backports) https://github.com/bitcoin/bitcoin/pull/13049
3942018-04-20T23:13:24 *** isis is now known as isis_
3952018-04-20T23:20:08 *** ProfMac has quit IRC
3962018-04-20T23:26:04 *** tryphe_ is now known as tryphe
3972018-04-20T23:30:47 *** AaronvanW has quit IRC
3982018-04-20T23:31:24 *** AaronvanW has joined #bitcoin-core-dev
3992018-04-20T23:33:21 *** propumpkin has joined #bitcoin-core-dev
4002018-04-20T23:35:37 *** AaronvanW has quit IRC
4012018-04-20T23:35:45 *** contrapumpkin has quit IRC
4022018-04-20T23:39:17 *** ProfMac has joined #bitcoin-core-dev
4032018-04-20T23:40:27 *** Chris_Stewart_5 has quit IRC
4042018-04-20T23:44:13 *** CubicEarths has quit IRC
4052018-04-20T23:50:22 *** niftynei has joined #bitcoin-core-dev
4062018-04-20T23:50:55 *** ProfMac has quit IRC
4072018-04-20T23:52:21 *** niftynei has quit IRC
4082018-04-20T23:54:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4092018-04-20T23:57:19 *** luke-jr has quit IRC