12018-05-20T00:04:05 *** Giszmo has quit IRC
22018-05-20T00:18:06 *** Giszmo has joined #bitcoin-core-dev
32018-05-20T00:35:02 *** d9b4bef9 has quit IRC
42018-05-20T00:36:18 *** d9b4bef9 has joined #bitcoin-core-dev
52018-05-20T01:05:20 *** Victorsueca has quit IRC
62018-05-20T01:06:29 *** Victorsueca has joined #bitcoin-core-dev
72018-05-20T01:10:09 *** drexl has quit IRC
82018-05-20T01:17:19 *** keymone has quit IRC
92018-05-20T01:17:54 *** keymone has joined #bitcoin-core-dev
102018-05-20T01:35:05 *** keymone has quit IRC
112018-05-20T01:35:55 *** drexl has joined #bitcoin-core-dev
122018-05-20T01:38:29 *** keymone has joined #bitcoin-core-dev
132018-05-20T02:26:27 <bitcoin-git> [bitcoin] qshuai closed pull request #13042: Calculated nBits will be replaced by the following GetNextWorkRequire⦠(master...master) https://github.com/bitcoin/bitcoin/pull/13042
142018-05-20T02:33:07 *** keymone has quit IRC
152018-05-20T02:44:41 *** keymone has joined #bitcoin-core-dev
162018-05-20T02:55:08 <kallewoof> sipa: gmaxwell: I am on macOS running natively
172018-05-20T02:55:17 <kallewoof> (sorry for late response)
182018-05-20T04:06:03 <kallewoof> wumpus fanquake: You can drop #12634 from high priority list. Jimpo brought up some points that I hadn't considered, so I think I need to rework this before bringing it up for review. :/
192018-05-20T04:06:06 <gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub
202018-05-20T04:14:09 <gmaxwell> kallewoof: it was a longshot... windows has some really obnoxious behavior around exclusive access to files... so much for that guess
212018-05-20T04:19:01 *** d9b4bef9 has quit IRC
222018-05-20T04:19:09 <kallewoof> gmaxwell: I haven't closed the lldb session. Not sure what I can glean from lldb/gdb commands though. Looking at threads it doesn't seem like two threads are doing things with leveldb.
232018-05-20T04:20:08 *** d9b4bef9 has joined #bitcoin-core-dev
242018-05-20T04:21:02 *** d9b4bef9 has quit IRC
252018-05-20T04:31:59 *** drexl has quit IRC
262018-05-20T04:46:47 *** StopAndDecrypt has quit IRC
272018-05-20T05:14:59 *** keymone has quit IRC
282018-05-20T05:16:11 *** keymone has joined #bitcoin-core-dev
292018-05-20T05:23:01 <bitcoin-git> [bitcoin] brandonrninefive opened pull request #13284: Fix for Issue #13231 - [gui] visual "overflow" of amount input. (master...ui_amount_overflow_fix) https://github.com/bitcoin/bitcoin/pull/13284
302018-05-20T05:50:46 *** fanquake has joined #bitcoin-core-dev
312018-05-20T05:54:24 <fanquake> kallewoof done
322018-05-20T06:05:18 *** nuni has joined #bitcoin-core-dev
332018-05-20T06:12:49 *** RoBz has quit IRC
342018-05-20T06:19:18 *** justan0theruser has joined #bitcoin-core-dev
352018-05-20T06:20:39 *** justanotheruser has quit IRC
362018-05-20T06:22:24 *** DougieBot5000 has quit IRC
372018-05-20T06:23:07 *** muheet has joined #bitcoin-core-dev
382018-05-20T06:31:31 *** Sinclair6 has joined #bitcoin-core-dev
392018-05-20T06:35:11 *** nuni has quit IRC
402018-05-20T06:45:05 *** tryphe_ has quit IRC
412018-05-20T06:45:27 *** tryphe has joined #bitcoin-core-dev
422018-05-20T07:04:35 *** keymone has quit IRC
432018-05-20T07:05:10 *** keymone has joined #bitcoin-core-dev
442018-05-20T07:21:56 *** btcdrak has joined #bitcoin-core-dev
452018-05-20T07:28:53 *** SopaXorzTaker has joined #bitcoin-core-dev
462018-05-20T07:36:22 *** goofie has quit IRC
472018-05-20T07:38:09 *** Randolf has joined #bitcoin-core-dev
482018-05-20T07:54:47 *** muheet has quit IRC
492018-05-20T07:57:15 *** muheet has joined #bitcoin-core-dev
502018-05-20T08:15:44 *** luke-jr has quit IRC
512018-05-20T08:17:43 *** luke-jr has joined #bitcoin-core-dev
522018-05-20T08:19:15 <kallewoof> fanquake: Thanks!
532018-05-20T08:22:08 *** d9b4bef9 has joined #bitcoin-core-dev
542018-05-20T08:45:19 *** KK__ has joined #bitcoin-core-dev
552018-05-20T08:46:24 *** KK__ has quit IRC
562018-05-20T08:53:05 *** muheet has quit IRC
572018-05-20T09:25:34 *** keymone has quit IRC
582018-05-20T09:39:16 *** goatpig has joined #bitcoin-core-dev
592018-05-20T09:57:19 *** mistergold has joined #bitcoin-core-dev
602018-05-20T10:21:02 *** Guyver2 has joined #bitcoin-core-dev
612018-05-20T10:22:42 *** lnostdal has quit IRC
622018-05-20T10:23:08 *** DougieBot5000 has joined #bitcoin-core-dev
632018-05-20T10:24:04 *** glaksmono has joined #bitcoin-core-dev
642018-05-20T10:28:03 *** Nielsen has joined #bitcoin-core-dev
652018-05-20T10:29:13 *** Nielsen has quit IRC
662018-05-20T10:37:09 *** drexl has joined #bitcoin-core-dev
672018-05-20T10:40:48 *** glaksmono has quit IRC
682018-05-20T10:41:33 *** glaksmono has joined #bitcoin-core-dev
692018-05-20T10:45:58 *** glaksmono has quit IRC
702018-05-20T10:48:46 *** lnostdal has joined #bitcoin-core-dev
712018-05-20T11:09:34 *** muheet has joined #bitcoin-core-dev
722018-05-20T11:26:17 *** karelb has joined #bitcoin-core-dev
732018-05-20T11:26:47 *** SopaXorzTaker has quit IRC
742018-05-20T11:28:30 *** LeMiner has joined #bitcoin-core-dev
752018-05-20T11:30:43 *** karelb has quit IRC
762018-05-20T11:34:25 *** karelb has joined #bitcoin-core-dev
772018-05-20T11:34:45 *** karelb has quit IRC
782018-05-20T11:40:23 *** glaksmono has joined #bitcoin-core-dev
792018-05-20T11:45:27 *** lnostdal has quit IRC
802018-05-20T11:51:08 *** glaksmono has quit IRC
812018-05-20T11:51:40 *** glaksmono has joined #bitcoin-core-dev
822018-05-20T11:51:50 *** lnostdal has joined #bitcoin-core-dev
832018-05-20T11:54:36 *** glaksmono has quit IRC
842018-05-20T11:54:52 *** glaksmono has joined #bitcoin-core-dev
852018-05-20T11:57:03 *** AaronvanW has joined #bitcoin-core-dev
862018-05-20T12:03:20 *** Victorsueca has quit IRC
872018-05-20T12:04:48 *** Victorsueca has joined #bitcoin-core-dev
882018-05-20T12:17:03 *** glaksmono has quit IRC
892018-05-20T12:18:02 *** d9b4bef9 has quit IRC
902018-05-20T12:19:08 *** d9b4bef9 has joined #bitcoin-core-dev
912018-05-20T12:20:02 *** d9b4bef9 has quit IRC
922018-05-20T12:21:09 *** d9b4bef9 has joined #bitcoin-core-dev
932018-05-20T12:26:32 *** AaronvanW has quit IRC
942018-05-20T12:27:10 *** AaronvanW has joined #bitcoin-core-dev
952018-05-20T12:31:27 *** AaronvanW has quit IRC
962018-05-20T12:47:01 *** RoBz has joined #bitcoin-core-dev
972018-05-20T12:47:01 *** RoBz has joined #bitcoin-core-dev
982018-05-20T12:53:11 *** qu4ku has joined #bitcoin-core-dev
992018-05-20T13:02:10 *** muheet has quit IRC
1002018-05-20T13:04:53 *** Ishtv4n has quit IRC
1012018-05-20T13:09:35 *** lnostdal has quit IRC
1022018-05-20T13:11:26 *** qu4ku has quit IRC
1032018-05-20T13:15:26 *** fanquake has quit IRC
1042018-05-20T13:26:29 *** Giszmo has quit IRC
1052018-05-20T13:30:40 *** promag has joined #bitcoin-core-dev
1062018-05-20T13:35:40 *** promag has quit IRC
1072018-05-20T13:37:04 *** Giszmo has joined #bitcoin-core-dev
1082018-05-20T13:41:00 *** btcdrak has quit IRC
1092018-05-20T13:42:25 *** intcat has quit IRC
1102018-05-20T13:44:00 *** intcat has joined #bitcoin-core-dev
1112018-05-20T13:45:44 *** promag has joined #bitcoin-core-dev
1122018-05-20T13:50:40 *** qu4ku has joined #bitcoin-core-dev
1132018-05-20T13:51:27 *** lnostdal has joined #bitcoin-core-dev
1142018-05-20T13:51:37 *** promag has quit IRC
1152018-05-20T13:57:37 *** qu4ku has quit IRC
1162018-05-20T14:07:13 *** Samdney has joined #bitcoin-core-dev
1172018-05-20T14:08:57 *** ExtraCrispy has quit IRC
1182018-05-20T14:28:02 *** tryphe_ has joined #bitcoin-core-dev
1192018-05-20T14:31:00 *** LeMiner has quit IRC
1202018-05-20T14:31:27 *** tryphe has quit IRC
1212018-05-20T14:39:08 *** dc has joined #bitcoin-core-dev
1222018-05-20T14:51:34 *** ExtraCrispy has joined #bitcoin-core-dev
1232018-05-20T15:03:53 *** drexl has quit IRC
1242018-05-20T15:28:01 *** glaksmono has joined #bitcoin-core-dev
1252018-05-20T15:32:24 *** glaksmono has quit IRC
1262018-05-20T15:43:02 *** Randolf has quit IRC
1272018-05-20T15:45:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1282018-05-20T15:56:35 *** goofie has joined #bitcoin-core-dev
1292018-05-20T16:13:51 *** timothy has joined #bitcoin-core-dev
1302018-05-20T16:38:20 *** StopAndDecrypt has joined #bitcoin-core-dev
1312018-05-20T16:52:19 *** promag has joined #bitcoin-core-dev
1322018-05-20T16:54:14 *** promag has quit IRC
1332018-05-20T17:03:32 *** Victorsueca has quit IRC
1342018-05-20T17:04:45 *** Victorsueca has joined #bitcoin-core-dev
1352018-05-20T17:10:25 *** Chris_Stewart_5 has quit IRC
1362018-05-20T17:24:56 *** promag has joined #bitcoin-core-dev
1372018-05-20T17:36:24 *** promag has quit IRC
1382018-05-20T17:49:42 *** Randolf has joined #bitcoin-core-dev
1392018-05-20T17:54:28 *** SopaXorzTaker has joined #bitcoin-core-dev
1402018-05-20T17:54:38 *** glaksmono has joined #bitcoin-core-dev
1412018-05-20T17:55:45 *** ccdle12 has joined #bitcoin-core-dev
1422018-05-20T17:59:09 *** glaksmono has quit IRC
1432018-05-20T18:00:02 *** d9b4bef9 has quit IRC
1442018-05-20T18:01:07 *** d9b4bef9 has joined #bitcoin-core-dev
1452018-05-20T18:06:41 *** timothy has quit IRC
1462018-05-20T18:12:25 *** drexl has joined #bitcoin-core-dev
1472018-05-20T18:15:17 *** LeMiner has joined #bitcoin-core-dev
1482018-05-20T18:20:10 *** LeMiner has quit IRC
1492018-05-20T18:27:02 *** gwillen has quit IRC
1502018-05-20T18:27:02 *** waxwing has quit IRC
1512018-05-20T18:27:02 *** a5m0 has quit IRC
1522018-05-20T18:27:16 *** waxwing has joined #bitcoin-core-dev
1532018-05-20T18:27:40 *** jimpo has quit IRC
1542018-05-20T18:27:40 *** fnb_theory has quit IRC
1552018-05-20T18:27:41 *** joshb[m] has quit IRC
1562018-05-20T18:27:42 *** cryptapus has quit IRC
1572018-05-20T18:27:42 *** jcorgan has quit IRC
1582018-05-20T18:27:42 *** mryandao has quit IRC
1592018-05-20T18:27:50 *** jcorgan has joined #bitcoin-core-dev
1602018-05-20T18:27:51 *** waxwing has quit IRC
1612018-05-20T18:27:52 *** waxwing has joined #bitcoin-core-dev
1622018-05-20T18:27:58 *** jimpo has joined #bitcoin-core-dev
1632018-05-20T18:28:06 *** cryptapus has joined #bitcoin-core-dev
1642018-05-20T18:28:07 *** cryptapus has quit IRC
1652018-05-20T18:28:07 *** cryptapus has joined #bitcoin-core-dev
1662018-05-20T18:28:18 *** a5m0 has joined #bitcoin-core-dev
1672018-05-20T18:28:31 *** mryandao has joined #bitcoin-core-dev
1682018-05-20T18:29:10 *** gwillen has joined #bitcoin-core-dev
1692018-05-20T18:29:57 *** lifeofguenter has quit IRC
1702018-05-20T18:30:25 *** gaf_ has quit IRC
1712018-05-20T18:31:59 *** lifeofguenter has joined #bitcoin-core-dev
1722018-05-20T18:32:02 *** gaf_ has joined #bitcoin-core-dev
1732018-05-20T18:32:54 *** fnb_theory has joined #bitcoin-core-dev
1742018-05-20T18:46:40 *** lightningbot has joined #bitcoin-core-dev
1752018-05-20T18:48:41 *** joshb[m] has joined #bitcoin-core-dev
1762018-05-20T18:49:07 *** nullptr| has quit IRC
1772018-05-20T18:51:34 *** SopaXorzTaker has quit IRC
1782018-05-20T18:53:45 *** promag has joined #bitcoin-core-dev
1792018-05-20T18:53:59 *** herzmeister[m] has joined #bitcoin-core-dev
1802018-05-20T18:54:45 *** nullptr| has joined #bitcoin-core-dev
1812018-05-20T19:00:46 <belcher> im writing for a bitcoin core PR, this is rpc_net.py https://pastebin.com/SJKwnfKQ my part starts at line 102, i open a p2pconnection to a node and send it some addresses, but then the node doesnt have those addresses in its getaddr as it should, can anyone see anything wrong?
1822018-05-20T19:04:43 *** promag has quit IRC
1832018-05-20T19:16:10 *** muheet has joined #bitcoin-core-dev
1842018-05-20T19:23:38 *** Randolf has quit IRC
1852018-05-20T19:26:18 *** intcat has quit IRC
1862018-05-20T19:26:18 *** arubi has quit IRC
1872018-05-20T19:26:18 *** ghost43 has quit IRC
1882018-05-20T19:28:11 *** arubi has joined #bitcoin-core-dev
1892018-05-20T19:28:20 *** ghost43 has joined #bitcoin-core-dev
1902018-05-20T19:28:35 *** intcat has joined #bitcoin-core-dev
1912018-05-20T19:35:46 *** mistergold has quit IRC
1922018-05-20T19:55:46 *** glaksmono has joined #bitcoin-core-dev
1932018-05-20T20:00:14 *** glaksmono has quit IRC
1942018-05-20T20:00:23 *** LeMiner has joined #bitcoin-core-dev
1952018-05-20T20:00:30 *** lari_ has quit IRC
1962018-05-20T20:00:42 *** lari has joined #bitcoin-core-dev
1972018-05-20T20:34:46 *** Victorsueca has quit IRC
1982018-05-20T20:36:20 *** Victorsueca has joined #bitcoin-core-dev
1992018-05-20T20:37:48 *** ossifrage has quit IRC
2002018-05-20T20:37:48 *** ossifrage_ has joined #bitcoin-core-dev
2012018-05-20T21:09:04 *** JackH has quit IRC
2022018-05-20T21:15:32 *** honeybadgerdgaf_ has joined #bitcoin-core-dev
2032018-05-20T21:18:04 <bitcoin-git> [bitcoin] Empact opened pull request #13288: Remove the need to include "rpc/blockchain.cpp' in order to put `GetDifficulty` under test (master...get-difficulty) https://github.com/bitcoin/bitcoin/pull/13288
2042018-05-20T21:18:10 *** muheet has quit IRC
2052018-05-20T21:19:38 *** jonyvx has joined #bitcoin-core-dev
2062018-05-20T21:20:28 *** Randolf has joined #bitcoin-core-dev
2072018-05-20T21:24:31 *** jonyvx has quit IRC
2082018-05-20T21:35:29 *** intcat has quit IRC
2092018-05-20T21:37:43 *** intcat has joined #bitcoin-core-dev
2102018-05-20T21:45:55 *** honeybadgerdgaf_ has quit IRC
2112018-05-20T21:53:20 *** Sinclair6 has quit IRC
2122018-05-20T21:58:29 *** honeybadgerdgaf has joined #bitcoin-core-dev
2132018-05-20T22:02:52 *** Randolf has quit IRC
2142018-05-20T22:03:42 *** nuke_bloodaxe has quit IRC
2152018-05-20T22:04:13 *** Sinclair6 has joined #bitcoin-core-dev
2162018-05-20T22:05:33 *** honeybadgerdgaf has quit IRC
2172018-05-20T22:06:09 *** honeybadgerdgaf has joined #bitcoin-core-dev
2182018-05-20T22:12:47 *** nuke_bloodaxe has joined #bitcoin-core-dev
2192018-05-20T22:30:25 *** vicenteH has quit IRC
2202018-05-20T22:31:10 *** ccdle12 has quit IRC
2212018-05-20T22:39:33 <achow101> belcher: all of those addresses are probably considered "terrible"
2222018-05-20T22:39:35 <achow101> belcher: see https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L33
2232018-05-20T22:42:05 <belcher> achow101 i tried changing it to addr.time = 1526774400 + i*60 #20th may 2018 but still gives an empty string
2242018-05-20T22:42:07 <gribble> https://github.com/bitcoin/bitcoin/issues/20 | JSON-RPC callback · Issue #20 · bitcoin/bitcoin · GitHub
2252018-05-20T22:42:26 <achow101> belcher: actually you need to set services to match those for a full node
2262018-05-20T22:42:39 <achow101> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L1840
2272018-05-20T22:42:46 <achow101> otherwise they won't get stored
2282018-05-20T22:43:21 <belcher> sec, trying that
2292018-05-20T22:45:47 *** ProfMac has quit IRC
2302018-05-20T22:45:52 *** muheet has joined #bitcoin-core-dev
2312018-05-20T22:47:08 <belcher> so thats node_network | node_witness or node_network_limited | node_witness.. that didnt help either, still returns an empty list
2322018-05-20T22:47:24 <achow101> belcher: check if they are being added to addrman. There should be lines in the debug.log about it
2332018-05-20T22:48:01 <belcher> where does debug.log end up when running tests? like ./test/functional/rpc_net.py
2342018-05-20T22:48:57 <achow101> something should be printed that says the datadir
2352018-05-20T22:49:11 <achow101> the debug.log will be in there in the regtest folder
2362018-05-20T22:49:16 <belcher> ah that must be Initializing test directory /tmp/testqo7f6r9j
2372018-05-20T22:49:24 <achow101> yeah, that's it
2382018-05-20T22:49:42 <achow101> within that is a datadir for each node started for the test
2392018-05-20T22:54:23 <belcher> ok so, the datadir gets cleaned up after the test
2402018-05-20T22:54:27 <belcher> it gets deleted
2412018-05-20T22:54:32 <achow101> run with --nocleanup
2422018-05-20T22:54:47 <achow101> or something like that (check -h)
2432018-05-20T22:55:03 <belcher> also i ran it a few times and once it worked, giving the list of addresses, but i ran it again and it gave an empty list again... so maybe its something to do with the time?
2442018-05-20T22:56:09 <belcher> the debug.log has this line 2018-05-20T22:55:12.580402Z Added 1000 addresses from 127.0.0.1: 0 tried, 64 new
2452018-05-20T22:56:11 <achow101> the time does matter, but I think the first step to debugging this is to figure out whether the addresses make it into addrman in the first place
2462018-05-20T22:56:43 <belcher> a little later: 2018-05-20T22:55:12.921387Z Flushed 64 addresses to peers.dat 141ms
2472018-05-20T22:57:05 <achow101> aren't you adding 1000 addresses though?
2482018-05-20T22:57:16 <belcher> yes.. i dont know where 64 comes from
2492018-05-20T22:58:13 *** ProfMac has joined #bitcoin-core-dev
2502018-05-20T22:58:17 <achow101> hold on, I'll try running it too
2512018-05-20T22:58:34 <belcher> iv run it again, now its "received: addr (30003 bytes) peer=4" and later "Flushed 0 addresses to peers.dat 291ms"
2522018-05-20T22:58:41 <belcher> so zero addresses this time
2532018-05-20T22:59:16 <belcher> here's the exact file im running, sec
2542018-05-20T22:59:30 *** honeybadgerdgaf has quit IRC
2552018-05-20T22:59:55 <belcher> https://pastebin.com/RbXLPGP5
2562018-05-20T23:02:53 <achow101> one thing I'm noticing is that the rpc call is happening before the addr is received, if the ordering in the debug.log is correct
2572018-05-20T23:04:07 <belcher> i just added time.sleep(3) in case that helps, didnt seem to
2582018-05-20T23:04:13 *** LeMiner has quit IRC
2592018-05-20T23:05:21 <achow101> I'm not seeing anything in the debug.log that indicates that addrman is adding anything
2602018-05-20T23:16:24 <achow101> belcher: One problem is that the addresses are 192.168.x.x which addrman won't add. I changed those to something else and addrman is adding the addresses
2612018-05-20T23:17:11 <belcher> oh yes good point
2622018-05-20T23:17:48 <belcher> i just did that and it seems to be working
2632018-05-20T23:18:10 <belcher> weirdly the output says 'services': 1 even though i assigned it as node_network | node_witness
2642018-05-20T23:18:19 <achow101> although it still seems to only be adding 64 addresses
2652018-05-20T23:18:33 <belcher> ah, i still had the time.sleep
2662018-05-20T23:19:01 <belcher> when i remove time.sleep it returns an empty list again
2672018-05-20T23:19:04 <achow101> and you need the time.sleep
2682018-05-20T23:19:44 <belcher> that will slow down the test runtime :\ i wonder if theres a better way, but i dont think the p2p protocol gives a response to 'addr'
2692018-05-20T23:20:38 <achow101> I don't think it does
2702018-05-20T23:20:58 <achow101> you could send a ping and then wait for pong right after sending addr
2712018-05-20T23:21:09 <belcher> good idea
2722018-05-20T23:21:31 <belcher> an interesting thing, i tried to make it send 2000 and 2500 addresses instead of 1000, but it returned an empty list then
2732018-05-20T23:23:12 <achow101> addr can't be greater than 1000
2742018-05-20T23:23:30 <belcher> ah ok
2752018-05-20T23:24:16 *** muheet has quit IRC
2762018-05-20T23:24:23 <belcher> the 64 addresses thing is weird but those 64 can be obtained with getnodeaddresses so its enough to write a test
2772018-05-20T23:28:12 *** Guyver2 has quit IRC
2782018-05-20T23:32:28 <belcher> achow101 mininode.py already has a function sync_with_ping() where it sends a ping and waits for the pong :)
2792018-05-20T23:32:41 <belcher> because that sleep() problem has obviously happened a lot before :p
2802018-05-20T23:36:01 *** Giszmo has quit IRC
2812018-05-20T23:41:59 *** Giszmo has joined #bitcoin-core-dev
2822018-05-20T23:49:08 *** Victorsueca has quit IRC
2832018-05-20T23:50:21 *** Victorsueca has joined #bitcoin-core-dev
2842018-05-20T23:53:52 *** glaksmono has joined #bitcoin-core-dev
2852018-05-20T23:58:14 *** glaksmono has quit IRC