12018-06-06T00:05:12  *** nuke_bloodaxe has joined #bitcoin-core-dev
  22018-06-06T00:06:25  *** BashCo has quit IRC
  32018-06-06T00:06:44  *** BashCo has joined #bitcoin-core-dev
  42018-06-06T00:08:30  *** DougieBot5000 has quit IRC
  52018-06-06T00:08:53  *** BashCo_ has joined #bitcoin-core-dev
  62018-06-06T00:08:58  *** DougieBot5000 has joined #bitcoin-core-dev
  72018-06-06T00:09:57  *** Randolf has quit IRC
  82018-06-06T00:10:08  *** jhfrontz has quit IRC
  92018-06-06T00:10:35  *** BashCo has quit IRC
 102018-06-06T00:10:45  *** Randolf has joined #bitcoin-core-dev
 112018-06-06T00:11:03  *** Randolf has quit IRC
 122018-06-06T00:12:23  *** Randolf has joined #bitcoin-core-dev
 132018-06-06T00:16:41  *** jhfrontz has joined #bitcoin-core-dev
 142018-06-06T00:18:38  *** jhfrontz has quit IRC
 152018-06-06T00:19:44  *** Randolf has quit IRC
 162018-06-06T00:20:33  *** dgenr8 has quit IRC
 172018-06-06T00:21:17  *** Randolf has joined #bitcoin-core-dev
 182018-06-06T00:21:45  *** dgenr8 has joined #bitcoin-core-dev
 192018-06-06T00:22:58  *** jhfrontz has joined #bitcoin-core-dev
 202018-06-06T00:27:05  *** dgenr8 has quit IRC
 212018-06-06T00:28:26  *** jhfrontz has quit IRC
 222018-06-06T00:28:26  *** dgenr8 has joined #bitcoin-core-dev
 232018-06-06T00:28:43  *** dgenr8 has quit IRC
 242018-06-06T00:31:19  *** dgenr8 has joined #bitcoin-core-dev
 252018-06-06T00:31:31  *** dgenr8 has quit IRC
 262018-06-06T00:40:01  *** d9b4bef9 has quit IRC
 272018-06-06T00:43:07  *** d9b4bef9 has joined #bitcoin-core-dev
 282018-06-06T00:47:27  *** jhfrontz has joined #bitcoin-core-dev
 292018-06-06T00:51:13  *** jhfrontz has quit IRC
 302018-06-06T00:57:34  *** jhfrontz has joined #bitcoin-core-dev
 312018-06-06T00:58:15  *** harrymm has quit IRC
 322018-06-06T00:59:40  *** jhfrontz has quit IRC
 332018-06-06T00:59:46  *** BashCo_ has quit IRC
 342018-06-06T01:00:00  *** jhfrontz has joined #bitcoin-core-dev
 352018-06-06T01:00:56  *** manecosta has joined #bitcoin-core-dev
 362018-06-06T01:08:33  *** grafcaps has quit IRC
 372018-06-06T01:10:02  *** manecosta has quit IRC
 382018-06-06T01:12:21  *** jhfrontz has quit IRC
 392018-06-06T01:12:40  *** jhfrontz has joined #bitcoin-core-dev
 402018-06-06T01:21:53  *** grafcaps has joined #bitcoin-core-dev
 412018-06-06T01:23:02  *** AaronvanW has quit IRC
 422018-06-06T01:23:20  *** BashCo has joined #bitcoin-core-dev
 432018-06-06T01:24:16  *** jhfrontz has quit IRC
 442018-06-06T01:27:42  *** Chris_Stewart_5 has quit IRC
 452018-06-06T01:33:44  *** AaronvanW has joined #bitcoin-core-dev
 462018-06-06T01:37:51  *** AaronvanW has quit IRC
 472018-06-06T01:46:27  *** ovovo has quit IRC
 482018-06-06T01:53:03  *** unholymachine has joined #bitcoin-core-dev
 492018-06-06T01:54:27  *** bitconner has quit IRC
 502018-06-06T02:00:45  *** nuke_bloodaxe has quit IRC
 512018-06-06T02:01:42  *** nuke_bloodaxe has joined #bitcoin-core-dev
 522018-06-06T02:01:50  *** unholymachine has quit IRC
 532018-06-06T02:02:28  *** unholymachine has joined #bitcoin-core-dev
 542018-06-06T02:11:00  *** goatpig has quit IRC
 552018-06-06T02:35:40  *** unholymachine has joined #bitcoin-core-dev
 562018-06-06T02:50:39  <MarcoFalke> FYI, I have assigned all non-mergeable open pulls to a new label "Needs rebase"
 572018-06-06T02:50:47  <MarcoFalke> Makes it easier to sort
 582018-06-06T02:50:50  <MarcoFalke> e.g. https://github.com/bitcoin/bitcoin/pulls?q=is%3Apr+is%3Aopen+label%3A%22Needs+rebase%22
 592018-06-06T02:56:09  *** intcat has quit IRC
 602018-06-06T02:57:18  *** intcat has joined #bitcoin-core-dev
 612018-06-06T03:30:44  *** jhfrontz has joined #bitcoin-core-dev
 622018-06-06T03:33:04  *** vicenteH has quit IRC
 632018-06-06T03:33:49  *** satwo has joined #bitcoin-core-dev
 642018-06-06T03:35:50  *** jhfrontz has quit IRC
 652018-06-06T03:36:49  *** vicenteH has joined #bitcoin-core-dev
 662018-06-06T03:45:09  *** satwo has quit IRC
 672018-06-06T03:45:39  *** jhfrontz has joined #bitcoin-core-dev
 682018-06-06T03:48:09  *** jhfrontz has quit IRC
 692018-06-06T03:52:30  *** jhfrontz has joined #bitcoin-core-dev
 702018-06-06T03:54:31  *** jhfrontz has quit IRC
 712018-06-06T03:59:38  *** jhfrontz has joined #bitcoin-core-dev
 722018-06-06T04:01:47  *** jhfrontz has quit IRC
 732018-06-06T04:26:29  *** Krellan has joined #bitcoin-core-dev
 742018-06-06T04:26:55  *** bitconner has joined #bitcoin-core-dev
 752018-06-06T04:32:02  *** d9b4bef9 has quit IRC
 762018-06-06T04:33:08  *** d9b4bef9 has joined #bitcoin-core-dev
 772018-06-06T04:34:53  *** AaronvanW has joined #bitcoin-core-dev
 782018-06-06T04:38:10  *** Emcy has quit IRC
 792018-06-06T04:40:15  *** AaronvanW has quit IRC
 802018-06-06T04:43:55  *** Krellan has quit IRC
 812018-06-06T05:05:21  *** Randolf has quit IRC
 822018-06-06T05:07:28  *** Randolf has joined #bitcoin-core-dev
 832018-06-06T05:09:07  *** bitconne1 has joined #bitcoin-core-dev
 842018-06-06T05:11:57  *** bitconner has quit IRC
 852018-06-06T05:16:07  *** unholymachine has quit IRC
 862018-06-06T05:23:56  *** grubles has quit IRC
 872018-06-06T05:25:52  *** ProfMac has quit IRC
 882018-06-06T05:25:59  *** ghost43 has quit IRC
 892018-06-06T05:30:50  *** ghost43 has joined #bitcoin-core-dev
 902018-06-06T05:32:30  *** ProfMac has joined #bitcoin-core-dev
 912018-06-06T05:37:11  <bitcoin-git> [bitcoin] lucash-dev opened pull request #13404: [tests] speed up of tx_validationcache_tests by reusing of CTransaction. (master...speedup-tx_validationcache_tests) https://github.com/bitcoin/bitcoin/pull/13404
 922018-06-06T05:46:02  *** Cory has quit IRC
 932018-06-06T05:52:30  *** usualrise has joined #bitcoin-core-dev
 942018-06-06T05:56:55  *** vicenteH has quit IRC
 952018-06-06T05:58:43  *** vicenteH has joined #bitcoin-core-dev
 962018-06-06T06:02:10  *** Rebo has joined #bitcoin-core-dev
 972018-06-06T06:18:36  *** Soligor has quit IRC
 982018-06-06T06:19:53  *** Rebo has quit IRC
 992018-06-06T06:20:08  *** Soligor has joined #bitcoin-core-dev
1002018-06-06T06:37:22  *** AaronvanW has joined #bitcoin-core-dev
1012018-06-06T06:41:53  *** AaronvanW has quit IRC
1022018-06-06T07:03:00  *** setpill has joined #bitcoin-core-dev
1032018-06-06T07:55:39  *** timothy has joined #bitcoin-core-dev
1042018-06-06T08:00:10  *** drizztbsd has joined #bitcoin-core-dev
1052018-06-06T08:00:59  *** timothy has quit IRC
1062018-06-06T08:02:58  *** Cory has joined #bitcoin-core-dev
1072018-06-06T08:07:10  *** usualrise has quit IRC
1082018-06-06T08:21:07  *** promag has joined #bitcoin-core-dev
1092018-06-06T08:23:22  *** drizztbsd is now known as timothy
1102018-06-06T08:33:19  <wumpus> MarcoFalke: I hope that happens automatically? otherwise, it sounds like a nightmare to keep it up to date
1112018-06-06T08:33:56  <wumpus> MarcoFalke: also, it's already possible to use bitcoinacks.com to keep track of that
1122018-06-06T08:54:16  *** laurentmt has joined #bitcoin-core-dev
1132018-06-06T08:59:07  *** Guyver2 has joined #bitcoin-core-dev
1142018-06-06T09:05:05  *** AaronvanW has joined #bitcoin-core-dev
1152018-06-06T09:07:46  *** laurentmt has quit IRC
1162018-06-06T09:09:52  *** AaronvanW has quit IRC
1172018-06-06T10:00:15  *** rafalcpp has joined #bitcoin-core-dev
1182018-06-06T10:25:07  *** ghost43 has quit IRC
1192018-06-06T10:25:18  *** ghost43 has joined #bitcoin-core-dev
1202018-06-06T10:26:50  *** AaronvanW has joined #bitcoin-core-dev
1212018-06-06T10:32:14  *** Aaronvan_ has joined #bitcoin-core-dev
1222018-06-06T10:35:43  *** AaronvanW has quit IRC
1232018-06-06T10:42:33  *** Guyver2 has quit IRC
1242018-06-06T11:06:40  *** Madars has quit IRC
1252018-06-06T11:07:46  *** Madars has joined #bitcoin-core-dev
1262018-06-06T11:10:06  *** Guyver2 has joined #bitcoin-core-dev
1272018-06-06T11:19:08  *** Victorsueca has quit IRC
1282018-06-06T11:20:36  *** Victorsueca has joined #bitcoin-core-dev
1292018-06-06T11:30:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1302018-06-06T11:34:20  <wumpus> how are things with 0.16.0rc1? do we have anything that needs to be backported for rc2? I haven't heard any reports of bugs at least.
1312018-06-06T11:35:31  <wumpus> if not, we should do a very fast rc2 for the translations issue and then tag final
1322018-06-06T11:35:34  <wumpus> eh, 0.16.1 obvs
1332018-06-06T11:57:04  *** SopaXorzTaker has joined #bitcoin-core-dev
1342018-06-06T11:57:53  *** bitconne1 has quit IRC
1352018-06-06T12:00:02  *** d9b4bef9 has quit IRC
1362018-06-06T12:00:25  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13406: travis: Add make step so that travis can build all executables for Mac. (master...travis_make_mac) https://github.com/bitcoin/bitcoin/pull/13406
1372018-06-06T12:00:47  *** promag has quit IRC
1382018-06-06T12:01:49  *** Aaronvan_ has quit IRC
1392018-06-06T12:03:15  *** d9b4bef9 has joined #bitcoin-core-dev
1402018-06-06T12:03:52  *** bitconner has joined #bitcoin-core-dev
1412018-06-06T12:08:35  *** bitconner has quit IRC
1422018-06-06T12:10:35  *** m8tion has joined #bitcoin-core-dev
1432018-06-06T12:16:24  *** AaronvanW has joined #bitcoin-core-dev
1442018-06-06T12:17:07  *** Aaronvan_ has joined #bitcoin-core-dev
1452018-06-06T12:18:36  *** bitconner has joined #bitcoin-core-dev
1462018-06-06T12:18:46  *** promag has joined #bitcoin-core-dev
1472018-06-06T12:21:00  *** AaronvanW has quit IRC
1482018-06-06T12:27:38  *** bitconner has quit IRC
1492018-06-06T12:27:46  *** bitconner has joined #bitcoin-core-dev
1502018-06-06T12:32:27  *** bitconner has quit IRC
1512018-06-06T12:35:02  *** Chris_Stewart_5 has quit IRC
1522018-06-06T12:36:03  *** bitconner has joined #bitcoin-core-dev
1532018-06-06T12:39:23  *** owowo has joined #bitcoin-core-dev
1542018-06-06T12:39:23  *** owowo has joined #bitcoin-core-dev
1552018-06-06T12:41:10  *** bitconner has quit IRC
1562018-06-06T12:43:39  *** bitconner has joined #bitcoin-core-dev
1572018-06-06T12:46:21  *** promag has quit IRC
1582018-06-06T12:48:27  *** bitconner has quit IRC
1592018-06-06T13:18:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a589f536b5e1...e4082d59f53d
1602018-06-06T13:18:56  <bitcoin-git> bitcoin/master 9d6c9db Ben Woosley: lint: Add linter to error on #include <*.cpp>...
1612018-06-06T13:18:57  <bitcoin-git> bitcoin/master e4082d5 MarcoFalke: Merge #13301: lint: Add linter to error on #include <*.cpp>...
1622018-06-06T13:19:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13301: lint: Add linter to error on #include <*.cpp> (master...lint-include-cpp) https://github.com/bitcoin/bitcoin/pull/13301
1632018-06-06T13:30:57  *** Emcy has joined #bitcoin-core-dev
1642018-06-06T13:33:03  *** jhfrontz has joined #bitcoin-core-dev
1652018-06-06T13:37:36  *** promag has joined #bitcoin-core-dev
1662018-06-06T13:55:13  *** AaronvanW has joined #bitcoin-core-dev
1672018-06-06T13:59:14  *** Aaronvan_ has quit IRC
1682018-06-06T14:08:18  *** grubles has joined #bitcoin-core-dev
1692018-06-06T14:08:40  *** grafcaps has quit IRC
1702018-06-06T14:15:51  <jamesob_> anyone willing to trade reviews for #13168?
1712018-06-06T14:15:53  <gribble> https://github.com/bitcoin/bitcoin/issues/13168 | Thread names in logs and deadlock debug tools (take 2) by jamesob · Pull Request #13168 · bitcoin/bitcoin · GitHub
1722018-06-06T14:16:07  *** jamesob_ is now known as jamesob
1732018-06-06T14:25:24  *** ryanzim has joined #bitcoin-core-dev
1742018-06-06T14:26:42  <ryanzim> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#p2wpkh says:
1752018-06-06T14:26:44  <ryanzim> > The HASH160 of the pubkey in witness must match the witness program.
1762018-06-06T14:27:34  <ryanzim> This seems to imply that the witness program is HASH160(pubkey), when it's actually HASH160(SHA256(pubkey))
1772018-06-06T14:27:40  <ryanzim> Shouldn't this be clarified?
1782018-06-06T14:31:06  <ryanzim> Ah, sorry; doing a little more research; seems I was confusing HASH160 and ripemd160; nvm
1792018-06-06T14:33:07  *** ryanzim has quit IRC
1802018-06-06T14:33:45  *** luke-jr has quit IRC
1812018-06-06T14:34:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822018-06-06T14:35:36  *** luke-jr has joined #bitcoin-core-dev
1832018-06-06T14:37:31  *** maxkaplan has joined #bitcoin-core-dev
1842018-06-06T14:55:48  *** goatpig has joined #bitcoin-core-dev
1852018-06-06T14:57:02  *** maxkaplan has quit IRC
1862018-06-06T14:58:30  *** qu4ku has joined #bitcoin-core-dev
1872018-06-06T15:09:53  *** Emcy has quit IRC
1882018-06-06T15:12:15  *** Emcy has joined #bitcoin-core-dev
1892018-06-06T15:13:17  *** Sinclair6 has quit IRC
1902018-06-06T15:20:31  *** grafcaps has joined #bitcoin-core-dev
1912018-06-06T15:25:29  *** mistergold has joined #bitcoin-core-dev
1922018-06-06T15:31:03  *** Emcy has quit IRC
1932018-06-06T15:31:34  *** Emcy has joined #bitcoin-core-dev
1942018-06-06T15:42:25  *** grafcaps has quit IRC
1952018-06-06T15:49:07  <promag> Currently there is a DbEnv can reference multiple Db instances right?
1962018-06-06T15:49:21  <promag> s/there is//
1972018-06-06T15:50:46  *** Randolf has quit IRC
1982018-06-06T15:52:31  <promag> Also, BerkeleyDatabase::Flush calls BerkeleyEnvironment::Flush, is there a reason to keep it like that?
1992018-06-06T15:58:02  <promag> so that when unloading a wallet all wallets wouldn't have to be flushed
2002018-06-06T15:59:41  *** grafcaps has joined #bitcoin-core-dev
2012018-06-06T16:00:05  *** owowo has quit IRC
2022018-06-06T16:01:35  <bitcoin-git> [bitcoin] eudisd closed pull request #13373: Qt: Update Wallet Encryption Titles To Better Describe Process (master...feature/bitcoin-#13245) https://github.com/bitcoin/bitcoin/pull/13373
2032018-06-06T16:07:13  <promag> jnewbery: yes there is a couple of things to fix
2042018-06-06T16:07:23  <promag> jnewbery: one is as follow
2052018-06-06T16:07:41  <promag> bitcoind -regtest -debug -wallet=w1 -wallet=w2
2062018-06-06T16:07:59  <promag> bitcoin-cli -regtest unloadwallet w1
2072018-06-06T16:08:17  <promag> bitcoin-cli -regtest -rpcwallet=w2 getwalletinfo
2082018-06-06T16:08:27  <promag> see above questions
2092018-06-06T16:09:19  *** Dizzle has joined #bitcoin-core-dev
2102018-06-06T16:11:56  *** Victorsueca has quit IRC
2112018-06-06T16:13:06  *** Victorsueca has joined #bitcoin-core-dev
2122018-06-06T16:16:07  *** setpill has quit IRC
2132018-06-06T16:17:10  *** nmnkgl has joined #bitcoin-core-dev
2142018-06-06T16:41:15  *** owowo has joined #bitcoin-core-dev
2152018-06-06T16:41:15  *** owowo has joined #bitcoin-core-dev
2162018-06-06T16:47:34  *** Randolf has joined #bitcoin-core-dev
2172018-06-06T16:48:52  *** qu4ku has quit IRC
2182018-06-06T16:55:12  <MarcoFalke> wumpus: I know it is on bitcoinacks.com, but I don't like the idea to switch back and forth between websites when you could have it all in one place
2192018-06-06T16:55:30  <MarcoFalke> And yes, will be automated in the future
2202018-06-06T16:56:14  <MarcoFalke> ACK on the quick rc2
2212018-06-06T16:59:29  *** GoldenBear has joined #bitcoin-core-dev
2222018-06-06T17:06:03  *** Dizzle has quit IRC
2232018-06-06T17:12:38  *** pergaminho has joined #bitcoin-core-dev
2242018-06-06T17:23:49  <bitcoin-git> [bitcoin] skeees opened pull request #13407: [refactor, move-only-ish] Refactor mempool accept/reject logic (master...atmp-p2p-refactor) https://github.com/bitcoin/bitcoin/pull/13407
2252018-06-06T17:26:16  *** timothy has quit IRC
2262018-06-06T17:31:33  <cfields> sipa: did you happen to bench sha2 with sse41 + avx?
2272018-06-06T17:36:01  *** vicenteH has quit IRC
2282018-06-06T17:37:59  <sipa> cfields: ah, forgot about that, good idea
2292018-06-06T17:38:18  <sipa> cfields: feel like fixing the proliferation of various crypto libs in the makefile?
2302018-06-06T17:38:44  <cfields> sipa: sure thing, will PR
2312018-06-06T17:40:06  *** Rebo has joined #bitcoin-core-dev
2322018-06-06T17:41:12  *** JackH has joined #bitcoin-core-dev
2332018-06-06T17:43:42  *** m8tion has quit IRC
2342018-06-06T17:47:07  *** Dizzle has joined #bitcoin-core-dev
2352018-06-06T17:48:57  <sipa> cfields: sse41 2.9ms, sse41 (compiled with -mavx) 2.0ms, avx2 1.1ms
2362018-06-06T17:49:05  <sipa> that's a very significant improvement...
2372018-06-06T17:49:40  <cfields> sipa: yep, same result on the aws instance I just fired up
2382018-06-06T17:51:37  <cfields> sipa: the current avx2 path falls back to sse41 for single transforms, right? So presumably that benefits as well?
2392018-06-06T17:51:52  <sipa> yup
2402018-06-06T17:52:03  <sipa> cfields: ah, no
2412018-06-06T17:52:12  <sipa> it falls back to sse41 for 4 elements
2422018-06-06T17:52:35  *** Dizzle has quit IRC
2432018-06-06T17:52:37  <sipa> there is also an asm sse4 single implementation... but that's not using intrinsics, so won't benefit from -mavx
2442018-06-06T17:53:26  <cfields> ah yes, ok
2452018-06-06T17:54:55  <sipa> we should try to convert that sse4 asm code to intrinsics, though
2462018-06-06T17:55:00  <cfields> so, how do you want to move forward? Seems to me it makes sense to compile different bundles, where all contents are built with the flags
2472018-06-06T17:56:27  <sipa> i guess we can compile the same source file twice, with a different -D specific to that build, which changes the namespace name?
2482018-06-06T17:57:20  <cfields> so for ex, libbitcoin_crypto-avx.a is sha256.cpp, sha256_sse41.cpp, etc. Just built with the avx flags...
2492018-06-06T17:57:26  <cfields> right
2502018-06-06T17:57:58  *** Emcy has quit IRC
2512018-06-06T17:59:03  <cfields> ok. how about: I'll do the simple build changes, we can get shani and power8 in, then we can redo the structure
2522018-06-06T17:59:16  <sipa> sounds good
2532018-06-06T17:59:30  <cfields> ok, thanks for testing
2542018-06-06T18:01:11  *** Emcy has joined #bitcoin-core-dev
2552018-06-06T18:02:40  <sipa> cfields: these numbers are on an 7th gen i7 CPU
2562018-06-06T18:03:25  <sipa> i'll also try on ryzen
2572018-06-06T18:03:39  *** drexl has joined #bitcoin-core-dev
2582018-06-06T18:04:49  <cfields> ok. based on the other tests, I'd be perfectly happy with no-change there :)
2592018-06-06T18:06:55  <gmaxwell> should figure out what AVX instruction's its substituting in...
2602018-06-06T18:08:07  <sipa> gmaxwell: my assumption is that it's just using the higher 128 bits of the 256 registers as extra register space
2612018-06-06T18:08:41  <cfields> gmaxwell: I did asm dumps of Round() split out, but don't speak enough asm to know what I'm looking at
2622018-06-06T18:08:46  <cfields> I can paste those if you'd like
2632018-06-06T18:10:02  <cfields> anything less focused than Round got too messy
2642018-06-06T18:10:15  *** Dizzle has joined #bitcoin-core-dev
2652018-06-06T18:13:16  <sipa> cfields: on Ryzen: sse41 2.8ms, sse41 w/ -mavx 2.2ms, avx2 2.1ms
2662018-06-06T18:13:34  <cfields> woohoo!
2672018-06-06T18:13:45  <sipa> (Ryzen actually only has 4-way parallel arithmetic, so avx2 doesn't have that much of a gain)
2682018-06-06T18:13:52  <cfields> interesting that it's almost the same as avx2
2692018-06-06T18:13:53  <cfields> ah
2702018-06-06T18:13:58  *** jarthur has joined #bitcoin-core-dev
2712018-06-06T18:15:09  <jarthur> Yep, it's practically just "API compatible" with AVX2.
2722018-06-06T18:15:25  <sipa> well it also gives you 256-bit registers
2732018-06-06T18:15:55  <sipa> but i guess those exist at AVX already
2742018-06-06T18:17:40  <jarthur> sipa: gmaxwell mentioned that zen might be able to do parallel sha-ni runs if each step is loaded up side by side. Do you know if anyone has played with that yet? I volunteered at some point but didn't get around to it.
2752018-06-06T18:18:42  <sipa> jarthur: yup, 2-way SHA-NI is faster than 1-way on my system
2762018-06-06T18:18:53  <jarthur> nice! Is that code in your branch atm?
2772018-06-06T18:18:57  <sipa> yup
2782018-06-06T18:19:01  <jarthur> rockin
2792018-06-06T18:19:15  <sipa> (not quite 2x - the implementation needs 10 registers-ish, so 2-way needs 20, while there are only 16 addressable ones, resulting in spills)
2802018-06-06T18:19:42  <sipa> IIRC it took a benchmark from 0.83ms to 0.61ms by doing the 2-way
2812018-06-06T18:20:05  <jarthur> that's significant in bitcoin land
2822018-06-06T18:21:26  <sipa> jarthur: https://github.com/sipa/bitcoin/blob/bb80ab25963f56cad9bb560e59c77d40f351901b/src/crypto/sha256_shani.cpp#L151
2832018-06-06T18:21:39  <sipa> it just calls every round function twice in a row
2842018-06-06T18:22:43  <jarthur> Thanks. Looks nice and clean with those inlines.
2852018-06-06T18:37:26  *** SopaXorzTaker has quit IRC
2862018-06-06T18:54:28  <sipa> who is DrahtBot?
2872018-06-06T18:57:29  *** Sinclair6 has joined #bitcoin-core-dev
2882018-06-06T19:07:34  <wumpus> sipa: MarcoFalke's bot
2892018-06-06T19:07:40  *** arubi has quit IRC
2902018-06-06T19:07:57  <sipa> ah, nice
2912018-06-06T19:08:00  <MarcoFalke> [ ] I'm not a robot
2922018-06-06T19:08:30  *** arubi has joined #bitcoin-core-dev
2932018-06-06T19:08:31  <sipa> oh, i meant "who is running Drahtbot"
2942018-06-06T19:08:36  <sipa> i did realize it was a bot :)
2952018-06-06T19:08:57  <sipa> how does it figure out conflicts?
2962018-06-06T19:09:04  <sipa> does it try every combination of 2 PRs?
2972018-06-06T19:17:57  <MarcoFalke> sipa: Yes, rn. I might implement a smart solution when I have time. Though, the compute overhead is trivial compared to the latency by the github api for now...
2982018-06-06T19:23:07  *** Rebo has quit IRC
2992018-06-06T19:26:33  <MarcoFalke> > i did realize it was a bot :)
3002018-06-06T19:26:40  <MarcoFalke> Thanks for the compliment :)
3012018-06-06T19:28:32  <bitcoin-git> [bitcoin] theuni opened pull request #13408: crypto: cleanup sha256 build (master...sha2-cleanup) https://github.com/bitcoin/bitcoin/pull/13408
3022018-06-06T19:28:42  <cfields> sipa: ^^
3032018-06-06T19:28:52  *** Rebo has joined #bitcoin-core-dev
3042018-06-06T19:33:25  <sipa> cfields: i'd rather keep the explicit -D... in the makefile for the arch specific crypto libs
3052018-06-06T19:33:48  <sipa> rather than rely on config.h
3062018-06-06T19:34:19  <cfields> sipa: for what reason? We're already relying on config.h for endian/swap
3072018-06-06T19:34:59  <sipa> cfields: because different libs may be compiled with different flags
3082018-06-06T19:35:02  *** dongcarl has quit IRC
3092018-06-06T19:35:08  <sipa> (expecting the avx/sse4 split)
3102018-06-06T19:37:03  <cfields> sipa: hmm, I had a different approach in mind. But sure, I'll revert that and we can sha256 it out when we get there.
3112018-06-06T19:37:30  *** Aaronvan_ has joined #bitcoin-core-dev
3122018-06-06T19:39:18  <jamesob> wumpus: how much more review does a bench-only change like #13219 need?
3132018-06-06T19:39:20  <gribble> https://github.com/bitcoin/bitcoin/issues/13219 | bench: Add block assemble benchmark by MarcoFalke · Pull Request #13219 · bitcoin/bitcoin · GitHub
3142018-06-06T19:40:45  <MarcoFalke> jamesob: I guess it is fine, but just covered/hidden by a ton of other open pull requests.
3152018-06-06T19:41:10  *** AaronvanW has quit IRC
3162018-06-06T19:52:44  <sipa> cfields: if you have a different idea, sure
3172018-06-06T19:58:25  *** pergaminho has quit IRC
3182018-06-06T19:58:42  *** pergaminho has joined #bitcoin-core-dev
3192018-06-06T19:59:14  *** pergaminho has joined #bitcoin-core-dev
3202018-06-06T20:19:07  *** drexl has quit IRC
3212018-06-06T20:25:08  *** jnewbery has quit IRC
3222018-06-06T20:28:16  *** jnewbery has joined #bitcoin-core-dev
3232018-06-06T20:53:34  *** pergaminho has quit IRC
3242018-06-06T21:02:15  *** mistergold has quit IRC
3252018-06-06T21:19:57  *** Guyver2 has quit IRC
3262018-06-06T21:27:11  <cfields> sipa: https://github.com/theuni/bitcoin/commits/sha2-libs
3272018-06-06T21:27:37  <cfields> that has the libs split out, rebuilt for each isn set, and adds avx
3282018-06-06T21:28:23  *** nmnkgl has quit IRC
3292018-06-06T21:28:41  <cfields> and yea, i see your point now, we need to pass in a flag for the namespace
3302018-06-06T21:41:32  *** Chris_Stewart_5 has quit IRC
3312018-06-06T21:42:37  *** jhfrontz has quit IRC
3322018-06-06T21:43:35  *** jhfrontz has joined #bitcoin-core-dev
3332018-06-06T21:46:19  <jarthur> sipa cfields, are we going down the direction that optimal instruction set would be picked at runtime, and default b86_64 build would have the lot of them compiled?
3342018-06-06T21:46:52  <cfields> jarthur: yes. that's already the case, we're just diving deeper.
3352018-06-06T21:50:27  *** nmnkgl has joined #bitcoin-core-dev
3362018-06-06T21:50:58  <jarthur> thanks
3372018-06-06T21:54:59  *** jhfrontz has quit IRC
3382018-06-06T21:59:40  *** bitconner has joined #bitcoin-core-dev
3392018-06-06T22:00:15  *** nmnkgl_ has joined #bitcoin-core-dev
3402018-06-06T22:00:41  *** bitconner has quit IRC
3412018-06-06T22:01:37  *** nmnkgl has quit IRC
3422018-06-06T22:03:54  *** booyah has quit IRC
3432018-06-06T22:05:04  *** booyah has joined #bitcoin-core-dev
3442018-06-06T22:09:45  *** goatpig has quit IRC
3452018-06-06T22:11:51  *** jhfrontz has joined #bitcoin-core-dev
3462018-06-06T22:25:15  *** tryphe has quit IRC
3472018-06-06T22:25:15  *** Victorsueca has quit IRC
3482018-06-06T22:25:32  *** BGL has quit IRC
3492018-06-06T22:25:42  *** tryphe has joined #bitcoin-core-dev
3502018-06-06T22:26:23  *** Victorsueca has joined #bitcoin-core-dev
3512018-06-06T22:29:05  *** bitbee_ has quit IRC
3522018-06-06T22:30:31  *** bitbee has joined #bitcoin-core-dev
3532018-06-06T22:39:33  *** snickerfritz has joined #bitcoin-core-dev
3542018-06-06T22:41:18  *** jhfrontz has quit IRC
3552018-06-06T22:45:47  *** jhfrontz has joined #bitcoin-core-dev
3562018-06-06T22:53:51  *** Krellan has joined #bitcoin-core-dev
3572018-06-06T23:06:50  *** contrapumpkin is now known as filthySJW
3582018-06-06T23:06:56  *** filthySJW is now known as contrapumpkin
3592018-06-06T23:09:24  *** jhfrontz has quit IRC
3602018-06-06T23:10:53  *** jhfrontz has joined #bitcoin-core-dev
3612018-06-06T23:13:10  *** nmnkgl_ has quit IRC
3622018-06-06T23:13:55  *** Randolf has quit IRC
3632018-06-06T23:19:03  *** timothy has joined #bitcoin-core-dev
3642018-06-06T23:20:10  *** owowo has quit IRC
3652018-06-06T23:20:22  *** ovovo has joined #bitcoin-core-dev
3662018-06-06T23:26:37  *** jarthur has quit IRC
3672018-06-06T23:26:38  *** Dizzle has quit IRC
3682018-06-06T23:26:53  *** drexl has joined #bitcoin-core-dev
3692018-06-06T23:27:01  *** jhfrontz has quit IRC
3702018-06-06T23:32:34  *** bitconner has joined #bitcoin-core-dev
3712018-06-06T23:36:49  *** jhfrontz has joined #bitcoin-core-dev
3722018-06-06T23:39:21  *** jhfrontz has quit IRC
3732018-06-06T23:41:31  *** Randolf has joined #bitcoin-core-dev
3742018-06-06T23:45:12  *** intcat has quit IRC
3752018-06-06T23:46:31  *** intcat has joined #bitcoin-core-dev
3762018-06-06T23:47:58  *** Krellan has quit IRC
3772018-06-06T23:48:45  *** Krellan has joined #bitcoin-core-dev