12018-06-12T00:00:27 *** nmnkgl has quit IRC
22018-06-12T00:02:53 *** drexl has quit IRC
32018-06-12T00:05:46 *** Chris_Stewart_5 has quit IRC
42018-06-12T00:08:08 *** booyah_ has joined #bitcoin-core-dev
52018-06-12T00:10:51 *** booyah has quit IRC
62018-06-12T00:11:00 *** promag has joined #bitcoin-core-dev
72018-06-12T00:15:59 *** gillian has joined #bitcoin-core-dev
82018-06-12T00:16:22 *** gillian is now known as Guest97188
92018-06-12T00:24:02 <sipa> cfields: clang does not like my code :(
102018-06-12T00:24:20 <cfields> sipa: yea, needs a few little fixups...
112018-06-12T00:24:43 <cfields> just template the param, and move the alignof() to the front of the definition
122018-06-12T00:25:12 <cfields> (I assume you knew that, just verifying that it makes clang happy :)
132018-06-12T00:27:06 <sipa> or just get rid of those helper functions
142018-06-12T00:27:17 <sipa> they don't give much abstraction anyway :)
152018-06-12T00:31:14 <cfields> heh
162018-06-12T00:32:11 <cfields> sipa: this includes the optim from #13400. Was that intended?
172018-06-12T00:32:13 <gribble> https://github.com/bitcoin/bitcoin/issues/13400 | sha256: small speedup for sse4 path. by theuni · Pull Request #13400 · bitcoin/bitcoin · GitHub
182018-06-12T00:33:11 <sipa> oh?
192018-06-12T00:33:14 <sipa> no
202018-06-12T00:33:47 <sipa> i don't see that
212018-06-12T00:34:55 <cfields> looking again, maybe order has me confused.
222018-06-12T00:39:24 *** Guest97188 has left #bitcoin-core-dev
232018-06-12T00:58:07 *** promag has quit IRC
242018-06-12T01:06:08 <phantomcircuit> sipa, the only caller of CCoinsViewDB::BatchWrite seems to be CCoinsViewCache::Flush which calls clear() on cacheCoins after
252018-06-12T01:06:42 <phantomcircuit> but BatchWrite is erasing each entry itself from cacheCoins passed by reference it seems
262018-06-12T01:07:45 <cfields> sipa: https://pastebin.com/raw/H5rV4kM5
272018-06-12T01:13:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
282018-06-12T01:18:57 *** AaronvanW has quit IRC
292018-06-12T01:40:21 *** grafcaps has quit IRC
302018-06-12T01:50:25 <sipa> phantomcircuit: correct
312018-06-12T01:51:07 <sipa> it's also potentially creating new entries in the parent cache
322018-06-12T01:51:25 <sipa> so to compensate for that memory usage, it also erases on the fly from the other one
332018-06-12T01:52:34 *** Chris_Stewart_5 has quit IRC
342018-06-12T01:52:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
352018-06-12T01:53:41 <gmaxwell> sipa: now that you've done intrensics you should be able to specialize the 64byte double sha2
362018-06-12T01:53:48 <gmaxwell> pretty easily?
372018-06-12T01:53:57 <phantomcircuit> sipa, right i see the pr, it's trying to avoid peak memory usage effectively being doubled by caching things twice
382018-06-12T01:54:30 <gmaxwell> (at least the 32-byte specialized version should get heavy use... because of all the places we use double sha2...)
392018-06-12T01:55:10 <sipa> gmaxwell: yup, one thing at a time
402018-06-12T01:55:24 <phantomcircuit> does std::unordered_map::clear() even do anything on an empty map?
412018-06-12T01:55:32 <sipa> no
422018-06-12T01:56:02 <phantomcircuit> ok so that call in Flush() is effectively a noop but makes it clear that it's empty i guess
432018-06-12T02:04:03 *** grafcaps has joined #bitcoin-core-dev
442018-06-12T02:07:01 *** snickerfritz has quit IRC
452018-06-12T02:10:34 *** Chris_Stewart_5 has quit IRC
462018-06-12T02:31:12 *** StopAndDecrypt has quit IRC
472018-06-12T02:39:34 <cfields> sipa: hmm, come to think about it, the slowdown occured on AMD when Round() was done on SIMD instructions. Maybe it doesn't pay the same price on integers?
482018-06-12T02:40:24 *** StopAndDecrypt has joined #bitcoin-core-dev
492018-06-12T02:41:09 <cfields> Sigma0/Sigma1, that is.
502018-06-12T02:42:09 <sipa> what slowdown?
512018-06-12T02:44:35 <cfields> sipa: nm, I'll comment on the PR
522018-06-12T03:09:07 *** bitconner has quit IRC
532018-06-12T03:14:07 <sipa> cfields: fixed, hopefully
542018-06-12T03:15:53 <sipa> cfields: the new Round function in https://github.com/theuni/bitcoin/commit/d69a5164f914c6c2945d8f32134faa0da87795f5 makes the benchmark go from 3.68 ms to 4.16 ms
552018-06-12T03:18:14 <cfields> sipa: Mind giving https://github.com/theuni/bitcoin/commit/4ee6fbb8b7525988783030eb0799bbc7293d50a0 a try? That's a little less dumb, doesn't force a dependency.
562018-06-12T03:18:29 <sipa> (for me, on i7-7)
572018-06-12T03:18:34 <sipa> sure
582018-06-12T03:18:54 <cfields> sipa: I'm mostly curious to see if it's quicker on AMD.
592018-06-12T03:19:53 <sipa> i'll try the different versions on a Ryzen system too if you want
602018-06-12T03:20:04 <sipa> then again, on those systems we'll likely use SHA-NI instead :)
612018-06-12T03:20:15 <cfields> heh, right
622018-06-12T03:20:22 <cfields> you see what I'm getting at though, right?
632018-06-12T03:26:00 *** bitconner has joined #bitcoin-core-dev
642018-06-12T03:30:58 *** bitconner has quit IRC
652018-06-12T03:56:02 *** d9b4bef9 has quit IRC
662018-06-12T03:57:07 *** d9b4bef9 has joined #bitcoin-core-dev
672018-06-12T03:59:24 *** bitconner has joined #bitcoin-core-dev
682018-06-12T04:04:50 *** bitconner has quit IRC
692018-06-12T04:14:37 *** bitconner has joined #bitcoin-core-dev
702018-06-12T04:19:15 *** bitconner has quit IRC
712018-06-12T04:37:10 *** goatpig has quit IRC
722018-06-12T04:39:31 <sipa> cfields: yeah, i'll benchmark on other systems
732018-06-12T04:40:01 *** jojeyh has joined #bitcoin-core-dev
742018-06-12T04:49:01 <bitcoin-git> [bitcoin] lucash-dev opened pull request #13443: Removed unused == operator from CMutableTransaction. (master...remove-CMutableTransaction-equals) https://github.com/bitcoin/bitcoin/pull/13443
752018-06-12T06:01:52 <bitcoin-git> [bitcoin] edsgerlin opened pull request #13444: depends: bump openssl to 1.0.2o (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13444
762018-06-12T06:26:46 *** Victorsueca has quit IRC
772018-06-12T06:28:03 *** Victorsueca has joined #bitcoin-core-dev
782018-06-12T07:09:07 *** promag has joined #bitcoin-core-dev
792018-06-12T07:17:28 *** promag has quit IRC
802018-06-12T07:23:12 *** harrymm has quit IRC
812018-06-12T07:35:58 *** harrymm has joined #bitcoin-core-dev
822018-06-12T07:41:00 <kallewoof> Maybe I missed it.. do we ask someone to remove the needs rebase tags after we rebase stuff or...?
832018-06-12T07:42:52 <sipa> kallewoof: DrahtBot will remove them when it gets around
842018-06-12T07:46:22 <kallewoof> Oh, it is delayed? Gotcha
852018-06-12T07:56:07 <bitcoin-git> [bitcoin] ken2812221 opened pull request #13445: build: Reset default -g -O2 flags when enable debug (master...debug_cflags) https://github.com/bitcoin/bitcoin/pull/13445
862018-06-12T07:59:19 <sipa> kallewoof: it's a bot, it goes through all PRs one by one, it takes a while
872018-06-12T07:59:22 <sipa> MarcoFalke runs it
882018-06-12T08:06:37 *** timothy has joined #bitcoin-core-dev
892018-06-12T08:11:04 *** drizztbsd has joined #bitcoin-core-dev
902018-06-12T08:11:32 *** timothy has quit IRC
912018-06-12T08:14:59 *** rafalcpp has joined #bitcoin-core-dev
922018-06-12T08:20:17 *** promag has joined #bitcoin-core-dev
932018-06-12T08:26:53 <bitcoin-git> [bitcoin] ccdle12 closed pull request #13067: [WIP] Unit test sub-directories - Continued (master...PR-fixes-ccdle12) https://github.com/bitcoin/bitcoin/pull/13067
942018-06-12T08:28:39 <jonasschnelli> wumpus: regarding https://github.com/bitcoin/bitcoin/pull/12196#issuecomment-394356035 ...
952018-06-12T08:28:47 <jonasschnelli> Is that a pay to pubkey unspent?
962018-06-12T08:34:52 *** bitconner has joined #bitcoin-core-dev
972018-06-12T08:35:41 <bitcoin-git> [bitcoin] murrayn opened pull request #13446: Build: remove non-distribution files/directories during make distclean. (master...distclean) https://github.com/bitcoin/bitcoin/pull/13446
982018-06-12T08:40:01 *** bitconner has quit IRC
992018-06-12T09:09:25 *** cdecker has quit IRC
1002018-06-12T09:10:53 *** cdecker has joined #bitcoin-core-dev
1012018-06-12T09:13:32 *** Empact has quit IRC
1022018-06-12T09:17:16 *** Empact has joined #bitcoin-core-dev
1032018-06-12T09:26:22 *** f_ has joined #bitcoin-core-dev
1042018-06-12T09:30:03 *** f_ has quit IRC
1052018-06-12T09:41:28 *** ExtraCrispy has joined #bitcoin-core-dev
1062018-06-12T09:50:25 *** drizztbsd has quit IRC
1072018-06-12T09:51:06 *** drizztbsd has joined #bitcoin-core-dev
1082018-06-12T09:53:09 *** AaronvanW has joined #bitcoin-core-dev
1092018-06-12T09:56:16 *** fanquake has joined #bitcoin-core-dev
1102018-06-12T09:58:38 *** bitconner has joined #bitcoin-core-dev
1112018-06-12T10:03:57 *** bitconner has quit IRC
1122018-06-12T10:11:01 *** d9b4bef9 has quit IRC
1132018-06-12T10:12:07 *** d9b4bef9 has joined #bitcoin-core-dev
1142018-06-12T10:14:10 *** bobques33 has joined #bitcoin-core-dev
1152018-06-12T10:32:27 *** laurentmt has joined #bitcoin-core-dev
1162018-06-12T11:12:40 <rafalcpp> wumpus: hm, why are symlinks prohibited from being in Tree-SHA512? they seem to normally work, they are shown as blobs, their git-sha1 is identical for symlinks with same symlink target, and so is sha512 that we get from them
1172018-06-12T11:14:16 *** nman999_ has joined #bitcoin-core-dev
1182018-06-12T11:15:13 *** nman999_ has quit IRC
1192018-06-12T11:18:38 <rafalcpp> BlueMatt: why we disallow symlinks? (it's your commit be908a69 - Fail merge if there are any symlinks)
1202018-06-12T11:23:09 <rafalcpp> it was decided in #9871 to disable them because bitcoin doesn't need them so no need to wonder if we handle them correctly
1212018-06-12T11:23:11 <gribble> https://github.com/bitcoin/bitcoin/issues/9871 | Add a tree sha512 hash to merge commits by sipa · Pull Request #9871 · bitcoin/bitcoin · GitHub
1222018-06-12T11:23:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1232018-06-12T11:29:00 *** bobques33 has quit IRC
1242018-06-12T11:33:03 <wumpus> rafalcpp: basic security precaution, we could go into detail analysing the consequences of symlinks (relative, absolute, inside tree, outside tree, etc) or just blanket disallow them. As we don't require them, just disallowing is safer.
1252018-06-12T11:33:43 <wumpus> jonasschnelli: could be!
1262018-06-12T11:34:37 <wumpus> we don't really *want* symlinks ending up in the repository
1272018-06-12T11:37:30 <wumpus> `(they're also not compatible with some OSes)
1282018-06-12T11:40:40 <rafalcpp> wumpus: perhaps support for them could exist with --allow-symlinks defaulting to false? Other projects besides bitcoin could benefit from tree sha512
1292018-06-12T11:40:55 *** AaronvanW has quit IRC
1302018-06-12T11:41:29 <wumpus> yes- it could be a git setting that defaults to false. But I don't think it's urgent.
1312018-06-12T11:57:37 *** AaronvanW has joined #bitcoin-core-dev
1322018-06-12T12:03:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c32b414b632...b22115d9a3b0
1332018-06-12T12:03:21 <bitcoin-git> bitcoin/master 419a198 practicalswift: docs: Add a note about the source code filename naming convention
1342018-06-12T12:03:21 <bitcoin-git> bitcoin/master e567713 practicalswift: Do not use uppercase characters in source code filenames
1352018-06-12T12:03:22 <bitcoin-git> bitcoin/master b22115d MarcoFalke: Merge #13312: docs: Add a note about the source code filename naming convention...
1362018-06-12T12:04:04 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13312: docs: Add a note about the source code filename naming convention (master...lowercase-filenames) https://github.com/bitcoin/bitcoin/pull/13312
1372018-06-12T12:06:06 *** laurentmt has quit IRC
1382018-06-12T12:07:25 *** indistylo has joined #bitcoin-core-dev
1392018-06-12T12:09:46 *** promag has quit IRC
1402018-06-12T12:28:27 *** Chris_Stewart_5 has quit IRC
1412018-06-12T12:45:11 <fanquake> I guess one slightly annoying limitation of the linters is that upstream changes can't be tested in /bitcoin
1422018-06-12T12:45:17 *** AaronvanW has quit IRC
1432018-06-12T12:45:57 *** AaronvanW has joined #bitcoin-core-dev
1442018-06-12T12:53:46 <wumpus> yes
1452018-06-12T12:54:30 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b22115d9a3b0...5315660baef0
1462018-06-12T12:54:31 <bitcoin-git> bitcoin/master fa8071a MarcoFalke: qa: Log as utf-8
1472018-06-12T12:54:31 <bitcoin-git> bitcoin/master 5315660 Wladimir J. van der Laan: Merge #13440: qa: Log as utf-8...
1482018-06-12T12:55:19 <bitcoin-git> [bitcoin] laanwj closed pull request #13440: qa: Log as utf-8 (master...Mf1806-qaLogUtf8) https://github.com/bitcoin/bitcoin/pull/13440
1492018-06-12T12:57:34 <fanquake> wumpus See #13444, I don't think that's something we want to do?
1502018-06-12T12:57:36 <gribble> https://github.com/bitcoin/bitcoin/issues/13444 | depends: bump openssl to 1.0.2o by edsgerlin · Pull Request #13444 · bitcoin/bitcoin · GitHub
1512018-06-12T13:00:05 <wumpus> fanquake: will have a look
1522018-06-12T13:00:37 *** bitconner has joined #bitcoin-core-dev
1532018-06-12T13:05:33 *** bitconner has quit IRC
1542018-06-12T13:07:48 <wumpus> fanquake: so the only thing affected by the OpenSSL version in depends is pretty much qt nowadays, right?
1552018-06-12T13:08:12 <wumpus> I tend to agree with you that it is unnecessary
1562018-06-12T13:08:27 <wumpus> (assuming that there has been no security issue that necessitates it)
1572018-06-12T13:09:55 <fanquake> wumpus Looking at the release notes, basically every major change in the 1.0.2 series is a CVE
1582018-06-12T13:12:28 *** Guyver2 has joined #bitcoin-core-dev
1592018-06-12T13:12:51 <wumpus> seems like a nightmare to keep track of
1602018-06-12T13:12:52 *** jouke has quit IRC
1612018-06-12T13:13:23 *** berndj has quit IRC
1622018-06-12T13:13:31 <wumpus> maybe "update to most recent version" isn't that bad an idea, periodically, I don't know...
1632018-06-12T13:13:55 <fanquake> tbh I prefer the "drop the requirement for OpenSSL entirely" idea :p
1642018-06-12T13:14:20 <fanquake> There have been a few shots at that in the past, but never merged for various reasons.
1652018-06-12T13:14:34 *** berndj has joined #bitcoin-core-dev
1662018-06-12T13:16:08 <wumpus> for the core it's doable, but dropping the requirement from the GUI doesn't seem feasible to me, besides replacing it with some alternative SSL library (qt supports some) but I'm not sure that's better...
1672018-06-12T13:17:24 <wumpus> e.g. on windows, qt can use the native SSL support, so wouldn't strictly need OpenSSL - but that doesn't sound too great to me either...
1682018-06-12T13:17:50 <fanquake> Especially given the seeming lack of people we have testing anything on Windows
1692018-06-12T13:19:03 <wumpus> that, too
1702018-06-12T13:19:28 *** m8tion has joined #bitcoin-core-dev
1712018-06-12T13:19:32 *** promag has joined #bitcoin-core-dev
1722018-06-12T13:19:35 <wumpus> also the GUI code does some juggling with certificates that doesn't go through the Qt crypto API, so is OpenSSL specific
1732018-06-12T13:19:48 <wumpus> it doesn't feel really worth working on
1742018-06-12T13:21:23 <wumpus> in a bizarre twist of fate, I was working on a deprecation plan for payment requests, which would have solved this problem once and for all, but then bitpay announced they will *only* support it from then on.
1752018-06-12T13:22:01 <fanquake> heh
1762018-06-12T13:22:05 <fanquake> I remember that
1772018-06-12T13:22:52 <fanquake> #11622
1782018-06-12T13:22:56 <gribble> https://github.com/bitcoin/bitcoin/issues/11622 | build: Add --disable-bip70 configure option by laanwj · Pull Request #11622 · bitcoin/bitcoin · GitHub
1792018-06-12T13:23:12 <wumpus> that took all of the wind out of my sails in that regard
1802018-06-12T13:23:22 <wumpus> yes that one
1812018-06-12T13:24:37 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822018-06-12T13:25:39 <fanquake> I noticed that currently 1/3 of all PRs "need a rebase"
1832018-06-12T13:30:05 *** juX0 has joined #bitcoin-core-dev
1842018-06-12T13:30:52 <wumpus> is:pr is:open -label:"needs rebase"
1852018-06-12T13:31:11 <fanquake> that indeed
1862018-06-12T13:31:36 <wumpus> or let's go nag some people, at least if it's PRs likely to be merged otherwise
1872018-06-12T13:33:31 <wumpus> it looks like most conflicts were caused by build system changes, as well as the txindex refactor
1882018-06-12T13:36:45 *** juX0 has quit IRC
1892018-06-12T13:37:31 <fanquake> wumpus: wouldn't dare nag anyone :p
1902018-06-12T13:38:17 <wumpus> :p
1912018-06-12T13:45:05 <wumpus> any opinions on when we should tag 0.16.1 final?
1922018-06-12T13:46:06 <fanquake> Did anything happen for the assert on Windows?
1932018-06-12T13:47:31 <wumpus> not that I know of - rc2 was just a translation fix
1942018-06-12T13:49:53 <wumpus> you mean #13358? that doesn't seem to be a regression in 0.16.1
1952018-06-12T13:49:54 <gribble> https://github.com/bitcoin/bitcoin/issues/13358 | Assertion failed Error file chain.cpp 102 · Issue #13358 · bitcoin/bitcoin · GitHub
1962018-06-12T13:54:53 <fanquake> wumpus I thought there was another one on shutdown, but have just installed rc2 onto Windows 10 and no longer see it
1972018-06-12T13:56:36 <fanquake> cfields You might be interested, some new output I'm seeing after upgrading to Command Line Tools 10.0 https://0bin.net/paste/2iaLr12c+Q-4rlmS#lexGszZqOKn07pwYKQvTKYGgCBTkDPKGnlCo5PjbGTV
1982018-06-12T13:57:46 <fanquake> wumpus #12337
1992018-06-12T13:57:47 <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
2002018-06-12T13:58:12 <fanquake> However seems like that doesn't need to hold up a 0.16.1
2012018-06-12T14:03:42 *** drizztbsd is now known as timothy
2022018-06-12T14:06:05 *** qrestlove has quit IRC
2032018-06-12T14:15:54 *** laurentmt has joined #bitcoin-core-dev
2042018-06-12T14:16:14 *** qrestlove has joined #bitcoin-core-dev
2052018-06-12T14:17:03 *** laurentmt has quit IRC
2062018-06-12T14:37:07 <jnewbery> Review beg for #13066. We haven't run successfully run the extended tests or verify-commits in Travis for over two months and that would fix it
2072018-06-12T14:37:10 <gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub
2082018-06-12T15:00:44 *** jcohen has joined #bitcoin-core-dev
2092018-06-12T15:17:09 <wumpus> jnewbery: will take a look
2102018-06-12T15:19:25 <wumpus> kind of forgot about that one
2112018-06-12T15:19:49 <jnewbery> great. Thanks!
2122018-06-12T15:21:02 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5315660baef0...ca2a23387be6
2132018-06-12T15:21:02 <bitcoin-git> bitcoin/master fa7a6cf MarcoFalke: policy: Treat segwit as always active
2142018-06-12T15:21:03 <bitcoin-git> bitcoin/master ca2a233 Wladimir J. van der Laan: Merge #13120: policy: Treat segwit as always active...
2152018-06-12T15:21:47 <bitcoin-git> [bitcoin] laanwj closed pull request #13120: policy: Treat segwit as always active (master...Mf1805-segwitGenesisPolicy) https://github.com/bitcoin/bitcoin/pull/13120
2162018-06-12T15:25:48 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca2a23387be6...fa4b9065a829
2172018-06-12T15:25:48 <bitcoin-git> bitcoin/master e5b2cd8 Chun Kuan Lee: Use python instead of slow shell script on verify-commits
2182018-06-12T15:25:49 <bitcoin-git> bitcoin/master fa4b906 Wladimir J. van der Laan: Merge #13066: Migrate verify-commits script to python, run in travis...
2192018-06-12T15:26:07 *** satwo has joined #bitcoin-core-dev
2202018-06-12T15:26:27 <bitcoin-git> [bitcoin] laanwj closed pull request #13066: Migrate verify-commits script to python, run in travis (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13066
2212018-06-12T15:28:38 <BlueMatt> wumpus: errr, did anyone else even review that?
2222018-06-12T15:28:46 <BlueMatt> else besides jnewbery, that is
2232018-06-12T15:28:54 <wumpus> yes, I reviewed it a long time ago
2242018-06-12T15:29:17 <BlueMatt> hmm, can you comment to that effect? I only see a concept ack from you on there
2252018-06-12T15:29:21 <wumpus> checked that it still was more or less the same
2262018-06-12T15:29:46 <wumpus> you didn't lookv ery well, there's an utACK from me in that topic too
2272018-06-12T15:30:01 <wumpus> apr 27
2282018-06-12T15:30:53 <BlueMatt> ah, ok, still wish we'd gotten more than 2 reviews with one pretty old on something thats designed to be usable to verify repo consistency
2292018-06-12T15:31:11 *** satwo has quit IRC
2302018-06-12T15:31:22 <wumpus> well at least it makes checking feasible again
2312018-06-12T15:31:31 <jnewbery> post-merge reviews welcome :)
2322018-06-12T15:31:46 <wumpus> no one was checking because the script was unusably slow
2332018-06-12T15:31:48 <BlueMatt> jnewbery: I dont feel comfortable reviewing security python, sadly
2342018-06-12T15:32:00 <BlueMatt> yes, indeed, better than it not getting run, which is apparently what was happening :(
2352018-06-12T15:32:02 <wumpus> FWIW, I'm 100% more comfortable reviewing python than shell script
2362018-06-12T15:32:20 <BlueMatt> heh, yes, I understand I'm like the only one left who prefers bash to python
2372018-06-12T15:32:21 <wumpus> there's just too much icky edge cases in shell script for me to be comfortable about it
2382018-06-12T15:32:39 <BlueMatt> lets just move everything to C :p
2392018-06-12T15:32:54 <wumpus> (like oh no, you forget to use the right quoting, now everything with spaces will escape.. and similar things)
2402018-06-12T15:33:07 <wumpus> feel free to rewrite it in C :p
2412018-06-12T15:33:13 <wumpus> it'd likely be even faster
2422018-06-12T15:33:23 <BlueMatt> lol, then it'd *actually* be usably fast
2432018-06-12T15:33:27 <BlueMatt> maybe I'll rewrite it in rust :p
2442018-06-12T15:33:36 <wumpus> hehe
2452018-06-12T15:33:42 <wumpus> yes that'd be cool
2462018-06-12T15:33:43 * BlueMatt has way too many rust projects now
2472018-06-12T15:33:58 <BlueMatt> I mean I've got a whole multi-daemon pool server and proxies in rust
2482018-06-12T15:34:47 <jnewbery> well, if anyone else knows python well enough to review #13066, I'm sure BlueMatt will appreciate your postmerge ACKs
2492018-06-12T15:34:49 <gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub
2502018-06-12T15:35:21 <wumpus> yes, it's always good to have more review, also of code already merged
2512018-06-12T15:45:22 *** fanquake has quit IRC
2522018-06-12T15:48:21 <bitcoin-git> [bitcoin] ken2812221 opened pull request #13447: travis: Increase travis_wait time while verifying commits (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13447
2532018-06-12T15:50:27 *** grafcaps has quit IRC
2542018-06-12T15:51:20 <bitcoin-git> [bitcoin] practicalswift opened pull request #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python (master...lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13448
2552018-06-12T15:53:38 <promag> #13111 is ready for review
2562018-06-12T15:53:40 <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
2572018-06-12T15:56:47 *** promag has quit IRC
2582018-06-12T16:07:24 *** grafcaps has joined #bitcoin-core-dev
2592018-06-12T16:08:38 *** joshb[m] has quit IRC
2602018-06-12T16:08:39 *** ajtowns[m] has quit IRC
2612018-06-12T16:08:47 *** squarfed[m] has quit IRC
2622018-06-12T16:08:48 *** herzmeister[m] has quit IRC
2632018-06-12T16:08:49 *** stepa[m] has quit IRC
2642018-06-12T16:08:51 *** kewde[m] has quit IRC
2652018-06-12T16:11:27 *** schnerchi has quit IRC
2662018-06-12T16:13:30 *** schnerchi has joined #bitcoin-core-dev
2672018-06-12T16:32:25 *** kewde[m] has joined #bitcoin-core-dev
2682018-06-12T16:45:57 *** goatpig has joined #bitcoin-core-dev
2692018-06-12T16:46:32 *** herzmeister[m] has joined #bitcoin-core-dev
2702018-06-12T16:46:32 *** ajtowns[m] has joined #bitcoin-core-dev
2712018-06-12T16:46:32 *** joshb[m] has joined #bitcoin-core-dev
2722018-06-12T16:46:34 *** stepa[m] has joined #bitcoin-core-dev
2732018-06-12T16:46:34 *** squarfed[m] has joined #bitcoin-core-dev
2742018-06-12T16:49:20 *** jtimon has joined #bitcoin-core-dev
2752018-06-12T16:51:45 *** rrrrr_ has joined #bitcoin-core-dev
2762018-06-12T16:52:51 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa4b9065a829...a607d23ae82e
2772018-06-12T16:52:51 <bitcoin-git> bitcoin/master 57ba401 Pieter Wuille: Enable double-SHA256-for-64-byte code on 32-bit x86
2782018-06-12T16:52:52 <bitcoin-git> bitcoin/master a607d23 Wladimir J. van der Laan: Merge #13393: Enable double-SHA256-for-64-byte code on 32-bit x86...
2792018-06-12T16:53:34 <bitcoin-git> [bitcoin] laanwj closed pull request #13393: Enable double-SHA256-for-64-byte code on 32-bit x86 (master...201806_dsha256_i386) https://github.com/bitcoin/bitcoin/pull/13393
2802018-06-12T17:01:03 *** bitconner has joined #bitcoin-core-dev
2812018-06-12T17:05:15 *** bitconner has quit IRC
2822018-06-12T17:06:34 *** nmnkgl has joined #bitcoin-core-dev
2832018-06-12T17:17:21 *** rrrrr_ has quit IRC
2842018-06-12T17:18:01 *** d9b4bef9 has quit IRC
2852018-06-12T17:19:08 *** d9b4bef9 has joined #bitcoin-core-dev
2862018-06-12T17:19:16 *** promag has joined #bitcoin-core-dev
2872018-06-12T17:25:38 *** Sinclair6 has quit IRC
2882018-06-12T17:33:19 *** m8tion has quit IRC
2892018-06-12T17:35:26 <promag> MarcoFalke: how about a "dormant" label, automatically added for something not updated for X days (either github or git)?
2902018-06-12T17:45:50 *** nekotribal has quit IRC
2912018-06-12T17:46:06 *** nekotribal has joined #bitcoin-core-dev
2922018-06-12T17:48:22 *** ctrlbreak has quit IRC
2932018-06-12T17:49:05 *** ctrlbreak has joined #bitcoin-core-dev
2942018-06-12T17:53:04 *** drexl has joined #bitcoin-core-dev
2952018-06-12T17:59:25 *** indistylo has quit IRC
2962018-06-12T18:03:21 *** Cory has quit IRC
2972018-06-12T18:07:49 *** promag has quit IRC
2982018-06-12T18:08:20 *** Pasha has joined #bitcoin-core-dev
2992018-06-12T18:11:32 *** Pasha is now known as Cory
3002018-06-12T18:14:05 <bitcoin-git> [bitcoin] instagibbs opened pull request #13449: [WIP] support new multisig template in wallet for Solver, signing, and sign⦠(master...largemultisig) https://github.com/bitcoin/bitcoin/pull/13449
3012018-06-12T18:24:08 *** Cory has quit IRC
3022018-06-12T18:29:12 *** Pasha has joined #bitcoin-core-dev
3032018-06-12T18:30:39 <luke-jr> #12859 seems to not be in 0.16.1 rc2?
3042018-06-12T18:30:41 <gribble> https://github.com/bitcoin/bitcoin/issues/12859 | Bugfix: Include for std::unique_ptr by luke-jr · Pull Request #12859 · bitcoin/bitcoin · GitHub
3052018-06-12T18:32:23 *** Pasha is now known as Cory
3062018-06-12T18:42:25 *** AaronvanW has quit IRC
3072018-06-12T18:42:39 <luke-jr> wumpus: ^
3082018-06-12T18:46:58 *** nmnkgl has quit IRC
3092018-06-12T18:47:35 *** nmnkgl has joined #bitcoin-core-dev
3102018-06-12T18:51:58 *** nmnkgl has quit IRC
3112018-06-12T18:53:16 *** Sinclair6 has joined #bitcoin-core-dev
3122018-06-12T18:56:35 *** indistylo has joined #bitcoin-core-dev
3132018-06-12T18:58:40 *** nmnkgl has joined #bitcoin-core-dev
3142018-06-12T19:06:46 *** AaronvanW has joined #bitcoin-core-dev
3152018-06-12T19:08:15 *** cubancorona has joined #bitcoin-core-dev
3162018-06-12T19:11:06 *** jcohen has quit IRC
3172018-06-12T19:15:18 *** AaronvanW has quit IRC
3182018-06-12T19:15:52 *** AaronvanW has joined #bitcoin-core-dev
3192018-06-12T19:19:27 *** cubancorona has quit IRC
3202018-06-12T19:20:05 *** AaronvanW has quit IRC
3212018-06-12T19:32:49 <wumpus> luke-jr: it was also not tagged as such
3222018-06-12T19:33:54 * luke-jr doesn't do the tagging XD
3232018-06-12T19:34:41 <wumpus> you could have mentioned it, at least
3242018-06-12T19:34:51 <luke-jr> just did
3252018-06-12T19:35:32 * luke-jr wonders how wide this affects
3262018-06-12T19:35:51 *** Victorsueca has quit IRC
3272018-06-12T19:37:04 *** Victorsueca has joined #bitcoin-core-dev
3282018-06-12T19:37:55 <luke-jr> seems like Ubuntu doesn't have Qt 5.10 yet, but Debian testing does
3292018-06-12T19:38:28 <luke-jr> dunno how to check Fedora
3302018-06-12T19:39:12 <luke-jr> Arch has 5.11
3312018-06-12T19:51:52 *** promag has joined #bitcoin-core-dev
3322018-06-12T20:02:35 *** indistylo has quit IRC
3332018-06-12T20:03:20 <bitcoin-git> [bitcoin] practicalswift opened pull request #13450: Add linter: Enforce the source code file naming convention described in the developer notes (master...lint-filenames) https://github.com/bitcoin/bitcoin/pull/13450
3342018-06-12T20:09:01 *** promag has quit IRC
3352018-06-12T20:19:00 *** AaronvanW has joined #bitcoin-core-dev
3362018-06-12T20:32:43 *** promag has joined #bitcoin-core-dev
3372018-06-12T20:34:02 *** nmnkgl has quit IRC
3382018-06-12T20:34:36 *** nmnkgl has joined #bitcoin-core-dev
3392018-06-12T20:35:10 *** bitconner has joined #bitcoin-core-dev
3402018-06-12T20:35:51 *** promag has quit IRC
3412018-06-12T20:38:57 *** nmnkgl has quit IRC
3422018-06-12T20:39:25 *** bitconner has quit IRC
3432018-06-12T20:47:50 <bitcoin-git> [bitcoin] instagibbs opened pull request #13451: expose CBlockIndex::nTx in getblockheader (master...expose_nTx) https://github.com/bitcoin/bitcoin/pull/13451
3442018-06-12T20:49:23 *** joshb[m] has quit IRC
3452018-06-12T20:49:32 *** herzmeister[m] has quit IRC
3462018-06-12T20:49:35 *** kewde[m] has quit IRC
3472018-06-12T20:49:38 *** ajtowns[m] has quit IRC
3482018-06-12T20:49:44 *** squarfed[m] has quit IRC
3492018-06-12T20:49:54 *** stepa[m] has quit IRC
3502018-06-12T20:49:55 *** Krellan has joined #bitcoin-core-dev
3512018-06-12T20:52:39 <luke-jr> #13120 should probably be backported too
3522018-06-12T20:52:41 <gribble> https://github.com/bitcoin/bitcoin/issues/13120 | policy: Treat segwit as always active by MarcoFalke · Pull Request #13120 · bitcoin/bitcoin · GitHub
3532018-06-12T20:53:17 <luke-jr> perhaps simplified
3542018-06-12T21:03:28 *** drexl has quit IRC
3552018-06-12T21:06:22 *** herzmeister[m] has joined #bitcoin-core-dev
3562018-06-12T21:15:29 *** nmnkgl has joined #bitcoin-core-dev
3572018-06-12T21:16:46 <bitcoin-git> [bitcoin] instagibbs opened pull request #13452: have verifytxoutproof check the number of txns in proof structure (master...actuallyverifytxoutproof) https://github.com/bitcoin/bitcoin/pull/13452
3582018-06-12T21:18:43 *** drexl has joined #bitcoin-core-dev
3592018-06-12T21:20:23 *** nmnkgl has quit IRC
3602018-06-12T21:22:09 *** kewde[m] has joined #bitcoin-core-dev
3612018-06-12T21:22:09 *** stepa[m] has joined #bitcoin-core-dev
3622018-06-12T21:22:09 *** joshb[m] has joined #bitcoin-core-dev
3632018-06-12T21:22:09 *** ajtowns[m] has joined #bitcoin-core-dev
3642018-06-12T21:22:09 *** squarfed[m] has joined #bitcoin-core-dev
3652018-06-12T21:23:59 *** Chris_Stewart_5 has quit IRC
3662018-06-12T21:25:35 *** Kevinho669 has joined #bitcoin-core-dev
3672018-06-12T21:32:45 *** Kevinho669 has quit IRC
3682018-06-12T21:37:34 *** bitconner has joined #bitcoin-core-dev
3692018-06-12T21:41:59 *** jcohen has joined #bitcoin-core-dev
3702018-06-12T21:52:06 *** bitconner has quit IRC
3712018-06-12T21:52:34 *** jcohen has quit IRC
3722018-06-12T21:54:21 *** nmnkgl has joined #bitcoin-core-dev
3732018-06-12T22:01:24 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3742018-06-12T22:01:24 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3752018-06-12T22:13:35 *** jojeyh has quit IRC
3762018-06-12T22:16:51 *** Cogito_Ergo_Sum has quit IRC
3772018-06-12T22:23:27 *** owowo has quit IRC
3782018-06-12T22:35:57 *** owowo has joined #bitcoin-core-dev
3792018-06-12T22:38:05 *** bitconner has joined #bitcoin-core-dev
3802018-06-12T22:43:54 *** Anduck has joined #bitcoin-core-dev
3812018-06-12T22:46:16 *** Guyver2 has quit IRC
3822018-06-12T23:14:23 *** promag has joined #bitcoin-core-dev
3832018-06-12T23:15:56 *** herzmeister[m] has quit IRC
3842018-06-12T23:16:01 *** kewde[m] has quit IRC
3852018-06-12T23:16:11 *** stepa[m] has quit IRC
3862018-06-12T23:17:57 *** squarfed[m] has quit IRC
3872018-06-12T23:17:57 *** joshb[m] has quit IRC
3882018-06-12T23:17:57 *** ajtowns[m] has quit IRC
3892018-06-12T23:28:12 *** evenzhou has joined #bitcoin-core-dev
3902018-06-12T23:30:14 *** nekotribal has quit IRC
3912018-06-12T23:32:38 *** herzmeister[m] has joined #bitcoin-core-dev
3922018-06-12T23:35:13 *** promag has quit IRC
3932018-06-12T23:36:08 *** drexl has quit IRC
3942018-06-12T23:40:07 *** promag has joined #bitcoin-core-dev
3952018-06-12T23:47:15 *** kewde[m] has joined #bitcoin-core-dev
3962018-06-12T23:47:15 *** ajtowns[m] has joined #bitcoin-core-dev
3972018-06-12T23:47:15 *** joshb[m] has joined #bitcoin-core-dev
3982018-06-12T23:47:16 *** squarfed[m] has joined #bitcoin-core-dev
3992018-06-12T23:47:16 *** stepa[m] has joined #bitcoin-core-dev
4002018-06-12T23:52:57 *** Chris_Stewart_5 has joined #bitcoin-core-dev