12018-06-13T00:02:55 *** Sinclair6 has quit IRC
22018-06-13T00:07:20 *** AaronvanW has quit IRC
32018-06-13T00:09:11 *** indistylo has joined #bitcoin-core-dev
42018-06-13T00:15:06 *** evenzhou has quit IRC
52018-06-13T00:15:33 *** evenzhou has joined #bitcoin-core-dev
62018-06-13T00:23:02 *** Chris_Stewart_5 has quit IRC
72018-06-13T00:24:39 *** evenzhou_ has joined #bitcoin-core-dev
82018-06-13T00:27:11 *** evenzhou has quit IRC
92018-06-13T00:33:20 *** snickerfritz has joined #bitcoin-core-dev
102018-06-13T00:35:10 *** grafcaps has quit IRC
112018-06-13T00:46:21 *** grafcaps has joined #bitcoin-core-dev
122018-06-13T01:04:19 *** nmnkgl has quit IRC
132018-06-13T01:04:54 *** nmnkgl has joined #bitcoin-core-dev
142018-06-13T01:09:21 *** nmnkgl has quit IRC
152018-06-13T01:11:02 <bitcoin-git> [bitcoin] edsgerlin closed pull request #13444: depends: bump openssl to 1.0.2o (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13444
162018-06-13T01:23:47 <gmaxwell> man I dred reviewing openssl patches.
172018-06-13T01:23:51 <gmaxwell> dread*
182018-06-13T01:24:27 <gmaxwell> lol I see other people complaining on the PR.
192018-06-13T01:32:18 *** snickerfritz has quit IRC
202018-06-13T01:39:14 *** nmnkgl has joined #bitcoin-core-dev
212018-06-13T01:43:27 *** nmnkgl has quit IRC
222018-06-13T01:45:41 *** Krellan has quit IRC
232018-06-13T01:50:39 *** Krellan has joined #bitcoin-core-dev
242018-06-13T01:59:50 *** promag has quit IRC
252018-06-13T02:03:02 *** cubancorona has joined #bitcoin-core-dev
262018-06-13T02:10:04 *** booyah_ has quit IRC
272018-06-13T02:26:38 *** Krellan_ has joined #bitcoin-core-dev
282018-06-13T02:30:57 *** Krellan_ has quit IRC
292018-06-13T02:30:58 *** Krellan has quit IRC
302018-06-13T02:43:27 *** jcohen has joined #bitcoin-core-dev
312018-06-13T02:50:37 *** satwo has joined #bitcoin-core-dev
322018-06-13T02:52:45 *** twistedline has quit IRC
332018-06-13T02:54:58 *** jcohen has quit IRC
342018-06-13T02:59:14 *** twistedline has joined #bitcoin-core-dev
352018-06-13T03:08:51 *** delphi has joined #bitcoin-core-dev
362018-06-13T03:09:14 *** delphi is now known as Guest57855
372018-06-13T03:15:46 *** nmnkgl has joined #bitcoin-core-dev
382018-06-13T03:16:37 *** ToURniQue has joined #bitcoin-core-dev
392018-06-13T03:20:25 *** nmnkgl has quit IRC
402018-06-13T03:21:02 *** Guest57855 has quit IRC
412018-06-13T03:21:06 *** twistedline has quit IRC
422018-06-13T03:22:26 *** indistylo has quit IRC
432018-06-13T03:24:04 *** twistedline has joined #bitcoin-core-dev
442018-06-13T03:46:46 *** bitconner has quit IRC
452018-06-13T04:03:26 *** Victorsueca has quit IRC
462018-06-13T04:04:36 *** Victorsueca has joined #bitcoin-core-dev
472018-06-13T04:06:03 *** bitconner has joined #bitcoin-core-dev
482018-06-13T04:10:34 *** bitconner has quit IRC
492018-06-13T04:14:13 *** grafcaps has quit IRC
502018-06-13T04:20:33 *** jojeyh has joined #bitcoin-core-dev
512018-06-13T04:27:59 *** indistylo has joined #bitcoin-core-dev
522018-06-13T04:31:37 *** bitconner has joined #bitcoin-core-dev
532018-06-13T05:04:02 *** nmnkgl has joined #bitcoin-core-dev
542018-06-13T05:08:37 *** nmnkgl has quit IRC
552018-06-13T05:18:48 *** grafcaps has joined #bitcoin-core-dev
562018-06-13T05:50:46 *** satwo has joined #bitcoin-core-dev
572018-06-13T05:55:40 <bitcoin-git> [bitcoin] practicalswift opened pull request #13454: Add linter: Make sure LC_ALL=C is set when using grep range expressions (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454
582018-06-13T06:02:48 *** meng has joined #bitcoin-core-dev
592018-06-13T06:06:05 *** iwkse has quit IRC
602018-06-13T06:16:41 *** promag has joined #bitcoin-core-dev
612018-06-13T06:16:41 *** satwo has quit IRC
622018-06-13T06:17:34 *** promag has quit IRC
632018-06-13T06:29:40 *** nekotribal has joined #bitcoin-core-dev
642018-06-13T06:31:33 *** Krellan has joined #bitcoin-core-dev
652018-06-13T06:35:08 *** meng has quit IRC
662018-06-13T06:36:08 *** Krellan has quit IRC
672018-06-13T06:52:09 *** nmnkgl has joined #bitcoin-core-dev
682018-06-13T06:56:52 *** nmnkgl has quit IRC
692018-06-13T07:03:17 *** setpill has joined #bitcoin-core-dev
702018-06-13T07:05:28 *** setpill has quit IRC
712018-06-13T07:08:34 *** setpill has joined #bitcoin-core-dev
722018-06-13T07:13:21 *** achow101 has quit IRC
732018-06-13T07:27:21 *** setpill has quit IRC
742018-06-13T07:28:10 *** adiabat has quit IRC
752018-06-13T07:29:00 *** harding has quit IRC
762018-06-13T07:29:13 *** adiabat has joined #bitcoin-core-dev
772018-06-13T07:29:54 *** harding has joined #bitcoin-core-dev
782018-06-13T07:30:05 *** setpill has joined #bitcoin-core-dev
792018-06-13T07:33:56 *** achow101 has joined #bitcoin-core-dev
802018-06-13T07:37:05 *** goatpig has quit IRC
812018-06-13T08:01:33 *** fanquake has joined #bitcoin-core-dev
822018-06-13T08:01:41 <fanquake> wumpus I can create that backport if you aren't already doing it
832018-06-13T08:06:09 <wumpus> sure! thanks, though no real hurry, I've tegged it 0.16.2, don't think it should hold up 0.16.1
842018-06-13T08:07:05 <fanquake> np, I'll do that and the other outstanding backport. Hadn't noticed the Windows one until now..
852018-06-13T08:12:45 <bitcoin-git> [bitcoin] fanquake opened pull request #13455: [0.16.2] Backports (0.16...0-16-2-backports) https://github.com/bitcoin/bitcoin/pull/13455
862018-06-13T08:15:10 <fanquake> Any further thought on #13091? Agree that it's only useful if you branch has already been found. Maybe we need to put a notice in the master readme.md?
872018-06-13T08:15:12 <gribble> https://github.com/bitcoin/bitcoin/issues/13091 | [0.15] doc: Add compilation note to README.md by fanquake · Pull Request #13091 · bitcoin/bitcoin · GitHub
882018-06-13T08:15:22 <fanquake> ^ wumpus
892018-06-13T08:15:39 <fanquake> If we don't want to do that I'll close the PR and the 0.15.2 milestone.
902018-06-13T08:17:51 <wumpus> fanquake: yes, as I commented there, I don't think it's very useful in current form, most people are bound to look at README.md in master, but it probably also needs opinions by other people
912018-06-13T08:18:49 <fanquake> wumpus meh, I think I'll close for now, and might do something against master
922018-06-13T08:19:27 <bitcoin-git> [bitcoin] fanquake closed pull request #13091: [0.15] doc: Add compilation note to README.md (0.15...0-15-0-readme) https://github.com/bitcoin/bitcoin/pull/13091
932018-06-13T08:20:06 *** bitless has joined #bitcoin-core-dev
942018-06-13T08:21:32 *** laurentmt has joined #bitcoin-core-dev
952018-06-13T08:22:49 *** bitless has quit IRC
962018-06-13T08:25:24 *** laurentmt has quit IRC
972018-06-13T08:26:35 <wumpus> fanquake: okay
982018-06-13T08:31:59 *** promag has joined #bitcoin-core-dev
992018-06-13T08:35:43 *** jcohen has joined #bitcoin-core-dev
1002018-06-13T08:40:36 *** anome has joined #bitcoin-core-dev
1012018-06-13T08:43:38 *** nmnkgl has joined #bitcoin-core-dev
1022018-06-13T08:48:22 *** nmnkgl has quit IRC
1032018-06-13T09:07:22 *** laurentmt has joined #bitcoin-core-dev
1042018-06-13T09:11:02 *** d9b4bef9 has quit IRC
1052018-06-13T09:12:08 *** d9b4bef9 has joined #bitcoin-core-dev
1062018-06-13T09:13:17 *** iwkse has joined #bitcoin-core-dev
1072018-06-13T09:16:24 *** Guyver2 has joined #bitcoin-core-dev
1082018-06-13T09:18:18 *** laurentmt has quit IRC
1092018-06-13T09:18:21 *** AaronvanW has joined #bitcoin-core-dev
1102018-06-13T09:18:22 *** jcohen has quit IRC
1112018-06-13T09:23:02 <jonasschnelli> sipa: thanks for the new BCH code...
1122018-06-13T09:23:30 <jonasschnelli> You set "randomly" picked... out of what set?
1132018-06-13T09:24:09 *** Aaronvan_ has joined #bitcoin-core-dev
1142018-06-13T09:25:33 *** promag has quit IRC
1152018-06-13T09:26:29 *** promag has joined #bitcoin-core-dev
1162018-06-13T09:27:35 *** AaronvanW has quit IRC
1172018-06-13T09:55:51 <jonasschnelli> wumpus: for your scantxoutset issue, the problem is, that P2PK and P2PKH leads to the same address, and decoding the script from that address always decodes in a P2PKH script
1182018-06-13T09:56:46 <jonasschnelli> wumpus: scanning for the P2PK script equivalent by "hashing" the script in the txoutset (form a P2PK script) would probably be a large overhead
1192018-06-13T09:57:58 <jonasschnelli> I don't know how to best deal with that... if a warning the P2PK scripts are not covered by providing addresses is enought
1202018-06-13T10:01:43 *** rafalcpp has quit IRC
1212018-06-13T10:02:01 *** rafalcpp has joined #bitcoin-core-dev
1222018-06-13T10:02:07 *** CubicEarths has quit IRC
1232018-06-13T10:03:16 <marcoagner> hi! is the process of documenting changes in behavior (including adding release notes) documented anywhere? thanks
1242018-06-13T10:03:57 *** grafcaps has quit IRC
1252018-06-13T10:06:53 <marcoagner> I'd like to know if I introduce a small behavior change, should I just write a release-notes-prXXX.md or is there anywhere else to document? asking here so I don't clutter the PR with notifications for simple q's :)
1262018-06-13T10:07:04 <fanquake> marcoagner: The main place changes in behaviour are documented is in release notes. With some changes having a deprecation period for a release or two. i.e RPC changes.
1272018-06-13T10:08:37 <fanquake> A release-notes.md PR sounds ok.
1282018-06-13T10:09:11 <wumpus> if it's a significant behavior change, it needs to be mentioned explicitly in the release notes, it's preferable to add a .md for your PR because it has the least chance of conflict (these will be assembled into one text before the release)
1292018-06-13T10:09:24 <wumpus> jonasschnelli: I understand. Maybe it's not a problem at all.
1302018-06-13T10:10:18 <wumpus> jonasschnelli: depending on the use-case
1312018-06-13T10:10:43 <wumpus> agree it would add overhead to scan for those as well
1322018-06-13T10:11:01 <wumpus> on the other hand, if people rely on this to output the spendable outputs to an address, this needs to work
1332018-06-13T10:11:19 <marcoagner> fanquake: wumpus: thank you, I think I got it. it's not a major change but Luke advised to document it and I agree since it changes behavior (the PR in question just in case: https://github.com/bitcoin/bitcoin/pull/13381#issuecomment-396744773)
1342018-06-13T10:14:41 *** setpill has quit IRC
1352018-06-13T10:15:05 *** setpill has joined #bitcoin-core-dev
1362018-06-13T10:18:07 <provoostenator> What's a simple way to generate a reasonably random UInt256 for in src/benchmark?
1372018-06-13T10:22:04 <jonasschnelli> provoostenator: what do you want to benchmark?
1382018-06-13T10:22:46 <provoostenator> CCoinsView(Cache) writes / reads with and without disk access.
1392018-06-13T10:23:06 <provoostenator> So I need unique tx hashes, but they can be garbage.
1402018-06-13T10:32:00 <jonasschnelli> provoostenator: use FastRandomContext() and eventually make sure you pre-generate random hashes before entering the benchmark timecycle?
1412018-06-13T10:33:42 <provoostenator> Thanks. Yes, I'm making sure to keep that sort of stuff away from the benchmark itself.
1422018-06-13T10:35:01 <provoostenator> There's already sa FastRandom_32bit helper function in the becnh dir I just notice, so can just reuse that pattern.
1432018-06-13T10:36:01 <provoostenator> (no actually that's different, but I'll figure it out)
1442018-06-13T10:49:17 *** vicenteH has joined #bitcoin-core-dev
1452018-06-13T10:53:49 *** Aaronvan_ has quit IRC
1462018-06-13T10:54:26 *** AaronvanW has joined #bitcoin-core-dev
1472018-06-13T10:55:29 *** bitconner has quit IRC
1482018-06-13T10:58:35 *** AaronvanW has quit IRC
1492018-06-13T11:11:36 *** grafcaps has joined #bitcoin-core-dev
1502018-06-13T11:12:02 *** AaronvanW has joined #bitcoin-core-dev
1512018-06-13T11:24:05 *** anome has quit IRC
1522018-06-13T11:33:27 *** bitconner has joined #bitcoin-core-dev
1532018-06-13T11:33:50 *** promag has quit IRC
1542018-06-13T11:47:23 *** SpYoGsee has joined #bitcoin-core-dev
1552018-06-13T11:47:50 <SpYoGsee> hallo
1562018-06-13T11:51:28 *** anome has joined #bitcoin-core-dev
1572018-06-13T12:05:01 *** d9b4bef9 has quit IRC
1582018-06-13T12:06:08 *** d9b4bef9 has joined #bitcoin-core-dev
1592018-06-13T12:10:24 *** jcohen has joined #bitcoin-core-dev
1602018-06-13T12:11:21 *** indistylo has quit IRC
1612018-06-13T12:17:00 *** setpill has quit IRC
1622018-06-13T12:32:45 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/dac5d68fc6cf136e0d7b21b9ed4fa053d54e6059
1632018-06-13T12:32:45 <bitcoin-git> bitcoin/0.16 dac5d68 Wladimir J. van der Laan: doc: Last-minute edits to 0.16.1 release notes...
1642018-06-13T12:37:00 <fanquake> Looks like a 0.16.1 tag is imminent :o
1652018-06-13T12:38:49 <wumpus> feeling the tension in the air
1662018-06-13T12:45:25 <wumpus> * [new tag] v0.16.1 -> v0.16.1
1672018-06-13T12:46:59 <fanquake> Wew
1682018-06-13T12:47:32 <fanquake> \o/
1692018-06-13T12:52:59 *** Guyver2 has quit IRC
1702018-06-13T12:53:57 <wumpus> \o//
1712018-06-13T12:54:09 *** SopaXorzTaker has joined #bitcoin-core-dev
1722018-06-13T13:05:19 *** Tralfaz has joined #bitcoin-core-dev
1732018-06-13T13:17:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1742018-06-13T13:23:31 * jonasschnelli started 0.16.1 build: https://bitcoin.jonasschnelli.ch/build/654
1752018-06-13T13:27:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a607d23ae82e...4b1edd318514
1762018-06-13T13:27:42 <bitcoin-git> bitcoin/master 51ed05a Chun Kuan Lee: travis: Increase travis_wait time while verifying commits...
1772018-06-13T13:27:42 <bitcoin-git> bitcoin/master 4b1edd3 MarcoFalke: Merge #13447: travis: Increase travis_wait time while verifying commits...
1782018-06-13T13:28:42 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13447: travis: Increase travis_wait time while verifying commits (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13447
1792018-06-13T13:30:42 *** promag has joined #bitcoin-core-dev
1802018-06-13T13:42:56 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4b1edd318514...caabdea627cf
1812018-06-13T13:42:56 <bitcoin-git> bitcoin/master f6f8026 Karl-Johan Alm: validation: check the specified number of blocks (off-by-one)
1822018-06-13T13:42:57 <bitcoin-git> bitcoin/master caabdea Wladimir J. van der Laan: Merge #13428: validation: check the specified number of blocks (off-by-one)...
1832018-06-13T13:43:47 <bitcoin-git> [bitcoin] laanwj closed pull request #13428: validation: check the specified number of blocks (off-by-one) (master...validation-off-by-one) https://github.com/bitcoin/bitcoin/pull/13428
1842018-06-13T13:45:27 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/caabdea627cf...cf7ca609234d
1852018-06-13T13:45:27 <bitcoin-git> bitcoin/master 51cd508 Ben Woosley: When build fails due to lib missing, indicate which one...
1862018-06-13T13:45:28 <bitcoin-git> bitcoin/master cf7ca60 Wladimir J. van der Laan: Merge #13435: When build fails due to lib missing, indicate which one...
1872018-06-13T13:46:22 <bitcoin-git> [bitcoin] laanwj closed pull request #13435: When build fails due to lib missing, indicate which one (master...lib-missing) https://github.com/bitcoin/bitcoin/pull/13435
1882018-06-13T13:46:52 *** satwo has joined #bitcoin-core-dev
1892018-06-13T13:48:43 *** Sinclair_ has joined #bitcoin-core-dev
1902018-06-13T13:49:33 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf7ca609234d...8eb76f3958e3
1912018-06-13T13:49:33 <bitcoin-git> bitcoin/master 9882d1f Chun Kuan Lee: Reset default -g -O2 flags when enable debug
1922018-06-13T13:49:34 <bitcoin-git> bitcoin/master 8eb76f3 Wladimir J. van der Laan: Merge #13445: build: Reset default -g -O2 flags when enable debug...
1932018-06-13T13:50:26 <bitcoin-git> [bitcoin] laanwj closed pull request #13445: build: Reset default -g -O2 flags when enable debug (master...debug_cflags) https://github.com/bitcoin/bitcoin/pull/13445
1942018-06-13T13:55:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13457: tests: Drop variadic macro (master...Mf1806-qaVariadicMacro) https://github.com/bitcoin/bitcoin/pull/13457
1952018-06-13T14:08:06 *** nmnkgl has joined #bitcoin-core-dev
1962018-06-13T14:09:52 <jonasschnelli> wumpus: added detection of P2PK scripts in scantxoutset: https://github.com/bitcoin/bitcoin/pull/12196#issuecomment-396950856
1972018-06-13T14:12:58 *** nmnkgl has quit IRC
1982018-06-13T14:15:43 *** Sinclair_ has quit IRC
1992018-06-13T14:24:25 *** grafcaps has quit IRC
2002018-06-13T14:30:38 <instagibbs> I'd like a backport tag for #13451 if possible
2012018-06-13T14:30:40 <gribble> https://github.com/bitcoin/bitcoin/issues/13451 | rpc: expose CBlockIndex::nTx in getblock(header) by instagibbs · Pull Request #13451 · bitcoin/bitcoin · GitHub
2022018-06-13T14:40:17 <fanquake> instagibbs I can add it to 13455
2032018-06-13T14:41:04 <fanquake> eh, still needs to be merged
2042018-06-13T14:41:09 *** indistylo has joined #bitcoin-core-dev
2052018-06-13T14:41:40 <instagibbs> yes, working on that. It's a super easy change at least.
2062018-06-13T14:42:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8eb76f3958e3...f532d52d3965
2072018-06-13T14:42:30 <bitcoin-git> bitcoin/master 2ce8186 Lowell Manners: [tests] Add logging to provide anchor points when debugging failures....
2082018-06-13T14:42:31 <bitcoin-git> bitcoin/master f532d52 MarcoFalke: Merge #13350: [tests] Add logging to provide anchor points when debugging p2p_sendheaders...
2092018-06-13T14:43:15 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13350: [tests] Add logging to provide anchor points when debugging p2p_sendheaders (master...testlogging) https://github.com/bitcoin/bitcoin/pull/13350
2102018-06-13T14:51:26 *** grafcaps has joined #bitcoin-core-dev
2112018-06-13T14:51:39 <sipa> jonasschnelli: there are some free parameters for the code
2122018-06-13T14:51:48 <sipa> jonasschnelli: i picked one at random
2132018-06-13T14:52:47 <sipa> jonasschnelli, wumpus: i think it's a very bad idea to continue the pubkey/address confusion, for a number of reasons
2142018-06-13T14:53:41 <sipa> one is that it's not compatible with bip158 based rescanning where you must know the exact scriptPubKeys you're looking for)
2152018-06-13T14:55:12 *** satwo has quit IRC
2162018-06-13T14:55:57 *** grafcaps has quit IRC
2172018-06-13T14:58:00 <jonasschnelli> sipa: P2PK: I think either...
2182018-06-13T14:58:32 <jonasschnelli> But,... what should we do with address bases scanning,... drop it completely?
2192018-06-13T15:00:03 <jonasschnelli> Not looking for P2PK equivalents when providing address is probably dangerous
2202018-06-13T15:00:22 <jonasschnelli> Also, just mentioning in the docs somewhere that P2PK scripts are not covered seems also fragile.
2212018-06-13T15:00:34 <sipa> jonasschnelli: why? it's not that anyone in practice is paid using P2PK
2222018-06-13T15:01:40 <jonasschnelli> Yes. Perhaps...
2232018-06-13T15:01:53 <sipa> yes, i would just document it loudly
2242018-06-13T15:02:21 <jonasschnelli> Okay. Makes sense... let me do that
2252018-06-13T15:02:54 <sipa> so still want to include support for hd chaina etc?
2262018-06-13T15:03:05 <sipa> in scantxoutset?
2272018-06-13T15:06:23 *** satwo has joined #bitcoin-core-dev
2282018-06-13T15:11:12 <bitcoin-git> [bitcoin] laanwj opened pull request #13458: gui: Drop qt5 support (master...2018_06_remove_qt4_support) https://github.com/bitcoin/bitcoin/pull/13458
2292018-06-13T15:11:22 *** satwo has quit IRC
2302018-06-13T15:11:53 *** satwo has joined #bitcoin-core-dev
2312018-06-13T15:13:19 <jonasschnelli> sipa: support for hd chain?
2322018-06-13T15:13:23 <jonasschnelli> You mean flexible keypath?
2332018-06-13T15:13:42 <sipa> jonasschnelli: support for xpub derivation etc
2342018-06-13T15:13:54 <jonasschnelli> It's supported in the current PR
2352018-06-13T15:14:01 <sipa> i know
2362018-06-13T15:14:13 <promag> > gui: Drop qt5 support < uff
2372018-06-13T15:14:17 <jonasschnelli> sipa: Just not with a text base script type descriptor as we once discussed
2382018-06-13T15:14:25 <sipa> jonasschnelli: okay
2392018-06-13T15:14:50 <jonasschnelli> sipa: But I changed the API to have n elements of various types
2402018-06-13T15:15:06 <jonasschnelli> (as you suggested)
2412018-06-13T15:16:18 *** Deinogalerix21 has joined #bitcoin-core-dev
2422018-06-13T15:18:37 <wumpus> promag: lol...
2432018-06-13T15:19:30 <sipa> wumpus: straight to qt6?
2442018-06-13T15:19:39 *** anome has quit IRC
2452018-06-13T15:20:01 *** anome has joined #bitcoin-core-dev
2462018-06-13T15:22:07 <fanquake> sipa bundle that with c++17
2472018-06-13T15:22:49 <sipa> fanquake: that seems weird; c++17 actually exists :)
2482018-06-13T15:22:55 <sipa> go for c++20 at least
2492018-06-13T15:24:03 <wumpus> sipa: we're migrating to electron *runs very fast*
2502018-06-13T15:24:36 <sipa> haha
2512018-06-13T15:24:56 <fanquake> heh
2522018-06-13T15:34:43 *** Guyver2 has joined #bitcoin-core-dev
2532018-06-13T15:35:39 *** grafcaps has joined #bitcoin-core-dev
2542018-06-13T15:38:20 *** m8tion has joined #bitcoin-core-dev
2552018-06-13T15:43:34 *** satwo has quit IRC
2562018-06-13T15:55:56 *** Deinogalerix21 has quit IRC
2572018-06-13T15:56:32 <jonasschnelli> sipa: any preferences for a name for the Base32 based 27 checksum BCH code? BechSeven32? Bech32Priv? Priv32?
2582018-06-13T15:57:16 <jonasschnelli> And I guess I can use the HRP checksum integration 1:1 from Bech32?
2592018-06-13T15:57:48 <sipa> yeah
2602018-06-13T15:58:09 <sipa> Bech32X
2612018-06-13T15:58:11 <sipa> :)
2622018-06-13T16:02:44 *** promag has quit IRC
2632018-06-13T16:04:22 <jonasschnelli> Okay. Bech32X shall it be
2642018-06-13T16:05:10 *** evenzhou_ has quit IRC
2652018-06-13T16:06:07 *** satwo has joined #bitcoin-core-dev
2662018-06-13T16:07:17 <fanquake> jonasschnelli: I'm just retesting, but be good to get your ack/nack on #12783. Not sure if you wanted to test a 10.8 VM, but I think we'll be moving to 10.10+ "soonish".
2672018-06-13T16:07:20 <gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: Disable AppNap by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub
2682018-06-13T16:07:37 <jonasschnelli> fanquake: okay. Will have a look soon.
2692018-06-13T16:08:17 *** satwo has joined #bitcoin-core-dev
2702018-06-13T16:10:41 *** jcohen has quit IRC
2712018-06-13T16:12:44 *** satwo has quit IRC
2722018-06-13T16:14:15 *** satwo has joined #bitcoin-core-dev
2732018-06-13T16:20:54 *** satwo has quit IRC
2742018-06-13T16:23:04 *** CubicEarths has joined #bitcoin-core-dev
2752018-06-13T16:25:35 *** Deinogalerix21 has joined #bitcoin-core-dev
2762018-06-13T16:28:55 *** satwo has joined #bitcoin-core-dev
2772018-06-13T16:30:25 *** Deinogalerix21 has quit IRC
2782018-06-13T16:32:46 *** anome has quit IRC
2792018-06-13T16:36:09 *** nmnkgl has joined #bitcoin-core-dev
2802018-06-13T16:41:42 *** jcohen has joined #bitcoin-core-dev
2812018-06-13T16:41:50 *** satwo has quit IRC
2822018-06-13T16:43:43 *** fanquake has quit IRC
2832018-06-13T16:46:30 *** grafcaps has quit IRC
2842018-06-13T17:00:54 *** razamobin has joined #bitcoin-core-dev
2852018-06-13T17:01:13 *** grafcaps has joined #bitcoin-core-dev
2862018-06-13T17:02:44 *** satwo has joined #bitcoin-core-dev
2872018-06-13T17:12:25 *** jcohen has quit IRC
2882018-06-13T17:17:14 *** razamobin has quit IRC
2892018-06-13T17:18:54 *** Victorsueca has quit IRC
2902018-06-13T17:20:03 *** Victorsueca has joined #bitcoin-core-dev
2912018-06-13T17:22:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f532d52d3965...4382f192e5ce
2922018-06-13T17:22:17 <bitcoin-git> bitcoin/master 3d69853 Chun Kuan Lee: travis: Change Mac goal to all deploy so that travis can build all executables for Mac.
2932018-06-13T17:22:18 <bitcoin-git> bitcoin/master 4382f19 MarcoFalke: Merge #13406: travis: Change Mac goal to all deploy...
2942018-06-13T17:23:07 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13406: travis: Change Mac goal to all deploy (master...travis_make_mac) https://github.com/bitcoin/bitcoin/pull/13406
2952018-06-13T17:26:07 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4382f192e5ce...b2221381e787
2962018-06-13T17:26:08 <bitcoin-git> bitcoin/master faf52f9 MarcoFalke: tests: Drop variadic macro
2972018-06-13T17:26:08 <bitcoin-git> bitcoin/master b222138 Wladimir J. van der Laan: Merge #13457: tests: Drop variadic macro...
2982018-06-13T17:27:02 <bitcoin-git> [bitcoin] laanwj closed pull request #13457: tests: Drop variadic macro (master...Mf1806-qaVariadicMacro) https://github.com/bitcoin/bitcoin/pull/13457
2992018-06-13T17:31:19 *** booyah has joined #bitcoin-core-dev
3002018-06-13T17:41:53 *** justanotheruser has quit IRC
3012018-06-13T17:42:10 *** vicenteH has quit IRC
3022018-06-13T17:42:49 *** justanotheruser has joined #bitcoin-core-dev
3032018-06-13T17:44:03 *** ula has joined #bitcoin-core-dev
3042018-06-13T17:49:35 *** Dyaheon has quit IRC
3052018-06-13T17:50:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2221381e787...4a7e64fc8546
3062018-06-13T17:50:20 <bitcoin-git> bitcoin/master c2dfbb4 Andrew Chow: Add unavailable options to hidden options category...
3072018-06-13T17:50:21 <bitcoin-git> bitcoin/master 4a7e64f MarcoFalke: Merge #13441: Prevent shared conf files from failing with different available options in different binaries...
3082018-06-13T17:50:49 *** Dyaheon has joined #bitcoin-core-dev
3092018-06-13T17:51:14 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13441: Prevent shared conf files from failing with different available options in different binaries (master...gargs-disabled-options) https://github.com/bitcoin/bitcoin/pull/13441
3102018-06-13T17:58:02 *** anome has joined #bitcoin-core-dev
3112018-06-13T18:02:20 *** anome has quit IRC
3122018-06-13T18:02:43 *** Chris_Stewart_5 has quit IRC
3132018-06-13T18:06:13 *** m8tion has quit IRC
3142018-06-13T18:18:41 *** SopaXorzTaker has quit IRC
3152018-06-13T18:21:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3162018-06-13T18:25:32 *** nmnkgl has quit IRC
3172018-06-13T18:26:08 *** nmnkgl has joined #bitcoin-core-dev
3182018-06-13T18:29:50 *** CubicEarths has quit IRC
3192018-06-13T18:30:20 *** nmnkgl has quit IRC
3202018-06-13T18:31:58 *** nmnkgl has joined #bitcoin-core-dev
3212018-06-13T18:32:36 *** drexl has joined #bitcoin-core-dev
3222018-06-13T18:44:02 *** indistylo has quit IRC
3232018-06-13T18:47:49 *** AaronvanW has quit IRC
3242018-06-13T18:48:24 *** AaronvanW has joined #bitcoin-core-dev
3252018-06-13T18:48:37 *** goatpig has joined #bitcoin-core-dev
3262018-06-13T18:53:10 *** AaronvanW has quit IRC
3272018-06-13T18:56:53 <Chris_Stewart_5> I have a question about using `addmultisigaddress` in conjunction with decodescript. I am not getting the same address field output
3282018-06-13T18:57:01 <Chris_Stewart_5> https://pastebin.com/q7yNWAJM
3292018-06-13T18:57:28 <Chris_Stewart_5> if I take the `redeemScript` from addmultisigaddress pass that into `decodescript` I get a different address encoding, why is that?
3302018-06-13T18:58:07 <sipa> i'm confused
3312018-06-13T18:58:16 <sipa> what exactly is not what you expect
3322018-06-13T18:59:21 <Chris_Stewart_5> is the address being returned from `addmultisigaddress` suppose to be an encoding of the redeem script?
3332018-06-13T18:59:36 <sipa> no, it's the P2SH address
3342018-06-13T18:59:53 <Chris_Stewart_5> yes, so p2sh(redeemscript) right?
3352018-06-13T18:59:56 <sipa> yes
3362018-06-13T19:00:18 <Chris_Stewart_5> So why would decodescript give a different address?
3372018-06-13T19:00:45 <sipa> ah!
3382018-06-13T19:00:55 <sipa> sorry, i had no idea what i was supposed to see that was weird
3392018-06-13T19:01:17 <sipa> can you run getaddressinfo or validateaddress on both?
3402018-06-13T19:01:27 <Chris_Stewart_5> np. We checked it against bitcoin-s and it appears to be the second address from decode script that is correct
3412018-06-13T19:02:00 <Chris_Stewart_5> Yes we can do that. Just a sec
3422018-06-13T19:02:08 *** nkohen has joined #bitcoin-core-dev
3432018-06-13T19:02:21 <sipa> oh, it may be that addmultisigaddress returns an P2SH-P2WSH address
3442018-06-13T19:03:29 *** nmnkgl has quit IRC
3452018-06-13T19:03:51 <Chris_Stewart_5> is getaddressinfo only on master?
3462018-06-13T19:04:00 <sipa> possibly
3472018-06-13T19:04:07 *** nmnkgl has joined #bitcoin-core-dev
3482018-06-13T19:04:24 *** nmnkgl has quit IRC
3492018-06-13T19:04:39 *** nmnkgl has joined #bitcoin-core-dev
3502018-06-13T19:05:45 <nkohen> sipa, I think you're right, here's my session https://pastebin.com/YdPgi88U
3512018-06-13T19:06:26 *** tripleslash has quit IRC
3522018-06-13T19:06:27 <sipa> nkohen: yup
3532018-06-13T19:07:04 <satwo> Hello all. Been thinking about a couple of features I'd like to see in Bitcoin Core and am curious what others think and whether these features already been discussed (or even implemented somewhere). a) Exposing SigOps count in getrawtransaction and getblock
3542018-06-13T19:07:05 <satwo> b) a multi-file solution for bitcoind's debug logging to allow for truncating and archiving debug.log
3552018-06-13T19:07:05 <satwo> b) a multi-file solution for bitcoind's debug logging to allow for truncating and archiving debug.log
3562018-06-13T19:07:32 <sipa> nkohen: use addresstype=legacy if you want p2sh-multisig
3572018-06-13T19:07:57 *** tripleslash has joined #bitcoin-core-dev
3582018-06-13T19:09:41 <Chris_Stewart_5> sipa: Is this an issue that there isn't consistentcy in the address being returned by these? I.e. one of thos rpcs isn't reading what your configuration is?
3592018-06-13T19:10:51 <Chris_Stewart_5> if we submitted a PR to do this would that be accepted?
3602018-06-13T19:13:32 *** promag has joined #bitcoin-core-dev
3612018-06-13T19:13:39 <jonasschnelli> Why is "include_watchonly" in getbalance depracated?
3622018-06-13T19:14:57 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13460: doc: Remove note to install all boost dev packages (master...Mf1806-docBuildUbuntu) https://github.com/bitcoin/bitcoin/pull/13460
3632018-06-13T19:15:22 <sipa> Chris_Stewart_5: what would you change?
3642018-06-13T19:15:27 <sipa> all the returned information is correct
3652018-06-13T19:15:39 <sipa> Chris_Stewart_5: decodescript is not a wallet RPC
3662018-06-13T19:15:46 <sipa> it just decodes the script
3672018-06-13T19:15:53 *** nmnkgl has quit IRC
3682018-06-13T19:16:27 *** nmnkgl has joined #bitcoin-core-dev
3692018-06-13T19:16:37 <sipa> validateaddress/getaddressinfo will return the wallet related information
3702018-06-13T19:21:01 <sipa> i guess decodescript could get an extra "p2sh-p2wsh" field
3712018-06-13T19:21:16 <sipa> which gives the p2sh-p2wsh address for that script
3722018-06-13T19:21:22 *** nmnkgl has quit IRC
3732018-06-13T19:21:51 <sipa> actually, no
3742018-06-13T19:22:26 <sipa> if it's already a witness program it can't do that, etc
3752018-06-13T19:27:46 <gmaxwell> satwo: you can handle the logs like standard unix daemon logs. Mv the file, then HUP the process and it'll make a new file and stop writing to the old one.
3762018-06-13T19:29:22 *** laurentmt has joined #bitcoin-core-dev
3772018-06-13T19:31:34 *** vicenteH has joined #bitcoin-core-dev
3782018-06-13T19:31:53 *** laurentmt has quit IRC
3792018-06-13T19:33:40 <satwo> gmaxwell: Wouldn't there be data loss (albeit small) with that approach?
3802018-06-13T19:34:19 <satwo> Or does bitcoind immediately make a new debug.log if it doesn't see one where it's expecting to?
3812018-06-13T19:37:19 *** promag has quit IRC
3822018-06-13T19:44:05 *** intcat has quit IRC
3832018-06-13T19:44:06 *** arubi has quit IRC
3842018-06-13T19:44:06 *** ghost43 has quit IRC
3852018-06-13T19:46:09 *** promag has joined #bitcoin-core-dev
3862018-06-13T19:50:20 *** intcat has joined #bitcoin-core-dev
3872018-06-13T19:50:48 <Chris_Stewart_5> sipa: If you provide a 'raw' (non witness) redeem script it would make sense to have multiple address encodings no?
3882018-06-13T19:51:42 <sipa> Chris_Stewart_5: iguess
3892018-06-13T19:52:01 <sipa> but generally decodescript doesn't know
3902018-06-13T19:52:47 <sipa> though things that look like witness programs aren't useful as scripts directly
3912018-06-13T19:52:53 <Chris_Stewart_5> Yeah I understand, I didn't realize it was an rpc that doesn't have any context into your wallet. Not even configuration settings
3922018-06-13T19:53:03 *** ghost43 has joined #bitcoin-core-dev
3932018-06-13T19:53:18 *** arubi has joined #bitcoin-core-dev
3942018-06-13T19:53:22 <sipa> oh it does have configuration info
3952018-06-13T19:53:50 <sipa> but the field is called "p2sh", not "address", so i guess it's expected to produce a p2sh address
3962018-06-13T19:54:21 <sipa> still, i think it wouldn't make sense to make its output depend on what type of addresses you have configured
3972018-06-13T19:54:33 <sipa> it's an rpc designed to examine things, not to construct addresses
3982018-06-13T19:55:28 <Chris_Stewart_5> really? I would disagree. But to each and his own. Thanks you for the help
3992018-06-13T19:56:32 <sipa> but adding other fields for p2wsh addresses there sounds oretty useful to me
4002018-06-13T19:57:15 <sipa> Chris_Stewart_5: generally nobody but the receiver wallet should be constructing addresses (as only he and his software can determine exactly which outputs tjey will consider valid payments)
4012018-06-13T19:57:43 <sipa> so i think it doesn't make sense to have an RPC that is designed to analyse other's addresses be dependent on your own settings for what addresses to genrrate
4022018-06-13T19:59:03 <sipa> i've seen some confusion from people who want to "convert" an existing p2pkh address into segwit versions, which you should never do, as you don't know the receiver wallet will support it
4032018-06-13T20:05:01 *** Squidicuz has quit IRC
4042018-06-13T20:07:59 *** bitconner has quit IRC
4052018-06-13T20:18:06 *** snickerfritz has joined #bitcoin-core-dev
4062018-06-13T20:18:07 *** snickerfritz has quit IRC
4072018-06-13T20:18:07 *** snickerfritz has joined #bitcoin-core-dev
4082018-06-13T20:22:41 <cfields> sipa: it occurs to me that for for SHA256D64, duplicated leaves have some redundant sigma0 calculations during message expansion.
4092018-06-13T20:22:52 <cfields> not enough redundancy to be useful, just thought it was interesting
4102018-06-13T20:23:38 *** bitconner has joined #bitcoin-core-dev
4112018-06-13T20:24:10 *** promag has quit IRC
4122018-06-13T20:26:38 *** nmnkgl has joined #bitcoin-core-dev
4132018-06-13T20:29:58 <luke-jr> IIRC, the new code is doing 8-way if there's >=8 things left, and 4-way if 4-7 things left.. is there a reason not to do 8-way for >4 things? wouldn't that be faster than doing 4-way + 2-way + 1-way ?
4142018-06-13T20:30:01 *** bitconner has quit IRC
4152018-06-13T20:30:38 <luke-jr> sipa: ^
4162018-06-13T20:30:57 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #13461: Wallet: correctly deprecate accounts in getbalance, re-add minconf / include-watch-only (master...2018/06/watch_only_balance) https://github.com/bitcoin/bitcoin/pull/13461
4172018-06-13T20:33:58 <sipa> luke-jr: yes, i've thought about that- but it also doesn't matter all that much
4182018-06-13T20:34:07 <sipa> it affects at most 3 entries per level
4192018-06-13T20:42:25 *** bitconner has joined #bitcoin-core-dev
4202018-06-13T20:42:56 <bitcoin-git> [bitcoin] Empact opened pull request #13462: scripted-diff: Simplify common case of CHashWriter and drop SER_GETHASH (master...serialize-hash-type) https://github.com/bitcoin/bitcoin/pull/13462
4212018-06-13T20:51:28 *** Squidicuz has joined #bitcoin-core-dev
4222018-06-13T20:53:09 *** meshcollider has joined #bitcoin-core-dev
4232018-06-13T21:05:34 *** Chris_Stewart_5 has quit IRC
4242018-06-13T21:10:47 *** christos88 has joined #bitcoin-core-dev
4252018-06-13T21:15:58 <christos88> hi, my bit core client says since a few hours ago as i started it that its "checking again the blocks..." "Blöcke werden nochmal neu verarbeitet...", its says 0%, the client is working but i dont know what its doing, i want to complete the download of the blockchain, its possible that the program wasnt shut down properly but how long can the work process take?
4262018-06-13T21:18:59 <sipa> christos88: yes, unclean shutdown
4272018-06-13T21:19:53 <sipa> it can take a long time; it needs to go through all blocks since the last succesful flush
4282018-06-13T21:20:00 <sipa> with large dbcache that can be a lot
4292018-06-13T21:21:10 *** nkohen has quit IRC
4302018-06-13T21:22:29 <bitcoin-git> [bitcoin] spyder46n2 opened pull request #13463: Merge change from BitCoin #11013 - Fix automake warnings when running autogen.sh (Ubuntu and others) (master...develop) https://github.com/bitcoin/bitcoin/pull/13463
4312018-06-13T21:24:58 <christos88> @sipa thank you, i had already over 80%, it took me a few weeks, do i have to wait again that long?
4322018-06-13T21:30:06 *** TheRec_ has quit IRC
4332018-06-13T21:31:25 *** AaronvanW has joined #bitcoin-core-dev
4342018-06-13T21:35:40 <sipa> christos88: weeks?!
4352018-06-13T21:35:42 <sipa> what hardware?
4362018-06-13T21:37:06 *** AaronvanW has quit IRC
4372018-06-13T21:37:36 *** Guyver2 has quit IRC
4382018-06-13T21:47:13 *** TheRec has joined #bitcoin-core-dev
4392018-06-13T21:47:13 *** TheRec has joined #bitcoin-core-dev
4402018-06-13T21:54:03 <midnightmagic> gah, what's up with ken's signature
4412018-06-13T21:56:55 <achow101> what's wrong with it?
4422018-06-13T22:00:06 <christos88> sipa: its old hardware, intel dual core, 4gb ram, geforce 9400
4432018-06-13T22:00:47 *** luke-jr has quit IRC
4442018-06-13T22:03:10 <achow101> midnightmagic: he uses ECDSA instead of RSA, perhaps that's the problem?
4452018-06-13T22:09:02 *** jojeyh has quit IRC
4462018-06-13T22:11:30 *** jtimon has quit IRC
4472018-06-13T22:12:44 <midnightmagic> hrm
4482018-06-13T22:13:27 *** promag has joined #bitcoin-core-dev
4492018-06-13T22:16:42 <midnightmagic> he must be using gpg2 as gpg
4502018-06-13T22:16:47 <booyah> christos88: it shouldn't take so long. is computer running almost 24/2?
4512018-06-13T22:16:49 <booyah> christos88: it shouldn't take so long. is computer running almost 24/24?
4522018-06-13T22:17:15 <achow101> midnightmagic: probably. in some systems, gpg2 is the default gpg
4532018-06-13T22:18:06 <midnightmagic> rad
4542018-06-13T22:22:25 <christos88> booyah: yes, right now 24 hours, percentage per hour was o,XX, depended on how much i was using browsers to surf, right now bitcore is checking at 0% since 4 hours
4552018-06-13T22:33:15 *** bitconner has quit IRC
4562018-06-13T22:33:50 *** AaronvanW has joined #bitcoin-core-dev
4572018-06-13T22:34:32 *** nmnkgl has quit IRC
4582018-06-13T22:36:03 <bitcoin-git> [bitcoin] spyder46n2 closed pull request #13463: Merge change from BitCoin #11013 - Fix automake warnings when running autogen.sh (Ubuntu and others) (master...develop) https://github.com/bitcoin/bitcoin/pull/13463
4592018-06-13T22:37:43 *** bitconner has joined #bitcoin-core-dev
4602018-06-13T22:38:41 *** AaronvanW has quit IRC
4612018-06-13T22:41:12 *** Krellan has joined #bitcoin-core-dev
4622018-06-13T22:45:09 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4632018-06-13T22:45:09 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4642018-06-13T22:45:40 *** nmnkgl has joined #bitcoin-core-dev
4652018-06-13T22:45:58 *** Krellan has quit IRC
4662018-06-13T22:55:25 *** vicenteH has quit IRC
4672018-06-13T22:58:28 *** CubicEarths has joined #bitcoin-core-dev
4682018-06-13T23:02:03 *** luke-jr has joined #bitcoin-core-dev
4692018-06-13T23:05:19 *** Tralfaz has quit IRC
4702018-06-13T23:06:21 *** grafcaps has quit IRC
4712018-06-13T23:20:41 *** lukedashjr has joined #bitcoin-core-dev
4722018-06-13T23:21:53 *** belcher has quit IRC
4732018-06-13T23:22:08 *** luke-jr has quit IRC
4742018-06-13T23:22:21 *** timothy has quit IRC
4752018-06-13T23:25:04 *** lukedashjr is now known as luke-jr
4762018-06-13T23:26:58 *** delphi has joined #bitcoin-core-dev
4772018-06-13T23:27:14 <bitcoin-git> [bitcoin] kristapsk opened pull request #13464: RPC: Allow to specify rescan start timestamp for importaddress, importprivkey and importpubkey (master...rescan-from) https://github.com/bitcoin/bitcoin/pull/13464
4782018-06-13T23:27:22 *** delphi is now known as Guest4980
4792018-06-13T23:27:39 *** CubicEarths has quit IRC
4802018-06-13T23:30:54 *** Guest4980 is now known as jojeyh
4812018-06-13T23:33:47 *** luke-jr has quit IRC
4822018-06-13T23:36:37 *** luke-jr has joined #bitcoin-core-dev
4832018-06-13T23:41:37 *** Cogito_Ergo_Sum has quit IRC
4842018-06-13T23:55:09 *** jojeyh has quit IRC
4852018-06-13T23:56:25 *** jojeyh has joined #bitcoin-core-dev