12018-06-19T00:04:34 *** DrFeelGood has joined #bitcoin-core-dev
22018-06-19T00:07:02 *** AaronvanW has quit IRC
32018-06-19T00:12:52 <sipa> gmaxwell: z85 also excludes _
42018-06-19T00:12:54 <sipa> that's the 9th one
52018-06-19T00:13:15 <sipa> seems indeed a bit of a strange choice: "',;\_`|~
62018-06-19T00:16:36 *** jtimon has quit IRC
72018-06-19T00:26:18 *** dgenr8 has quit IRC
82018-06-19T00:29:15 *** dgenr8 has joined #bitcoin-core-dev
92018-06-19T00:29:19 *** dgenr8 has quit IRC
102018-06-19T00:30:35 *** GoldenBear has quit IRC
112018-06-19T00:31:07 *** GoldenBear has joined #bitcoin-core-dev
122018-06-19T00:32:06 *** dgenr8 has joined #bitcoin-core-dev
132018-06-19T00:38:33 *** Chris_Stewart_5 has joined #bitcoin-core-dev
142018-06-19T00:39:10 *** dgenr8 has quit IRC
152018-06-19T00:41:09 <gmaxwell> sipa: I wonder why _ ?
162018-06-19T00:47:10 <sipa> no clue
172018-06-19T00:53:15 *** dgenr8 has joined #bitcoin-core-dev
182018-06-19T00:53:41 *** dgenr8 has quit IRC
192018-06-19T00:53:52 *** promag has quit IRC
202018-06-19T00:54:17 *** tsl1125 has joined #bitcoin-core-dev
212018-06-19T00:55:45 *** dgenr8 has joined #bitcoin-core-dev
222018-06-19T00:56:35 *** dgenr8 has quit IRC
232018-06-19T00:57:07 *** nmnkgl has quit IRC
242018-06-19T00:57:19 *** dgenr8 has joined #bitcoin-core-dev
252018-06-19T00:57:41 *** dgenr8 has quit IRC
262018-06-19T00:59:11 *** tsl1125 has quit IRC
272018-06-19T00:59:15 *** dgenr8 has joined #bitcoin-core-dev
282018-06-19T01:09:01 *** meshcollider has quit IRC
292018-06-19T01:32:48 *** nmnkgl has joined #bitcoin-core-dev
302018-06-19T01:37:27 *** nmnkgl has quit IRC
312018-06-19T02:09:02 *** d9b4bef9 has quit IRC
322018-06-19T02:10:07 *** d9b4bef9 has joined #bitcoin-core-dev
332018-06-19T02:10:41 *** Chris_Stewart_5 has quit IRC
342018-06-19T02:26:50 *** tsl1125 has joined #bitcoin-core-dev
352018-06-19T02:27:23 *** eenoch_ is now known as eenoch
362018-06-19T02:29:17 *** tsl1125 has quit IRC
372018-06-19T02:43:43 *** Victorsueca has quit IRC
382018-06-19T02:45:05 *** Victorsueca has joined #bitcoin-core-dev
392018-06-19T03:45:07 *** harrymm has quit IRC
402018-06-19T03:54:29 *** CubicEarths has joined #bitcoin-core-dev
412018-06-19T04:00:49 *** BGL has quit IRC
422018-06-19T04:00:57 *** jimmysong__ has joined #bitcoin-core-dev
432018-06-19T04:02:27 *** harrymm has joined #bitcoin-core-dev
442018-06-19T04:03:57 *** jimmysong_ has quit IRC
452018-06-19T04:10:53 *** harrymm has quit IRC
462018-06-19T04:27:13 *** harrymm has joined #bitcoin-core-dev
472018-06-19T04:43:30 *** Pinank has joined #bitcoin-core-dev
482018-06-19T04:44:30 *** Pinank has quit IRC
492018-06-19T05:01:13 *** goatpig has joined #bitcoin-core-dev
502018-06-19T05:16:43 *** nekotribal has joined #bitcoin-core-dev
512018-06-19T05:41:45 *** BGL has joined #bitcoin-core-dev
522018-06-19T05:51:22 *** Krellan has joined #bitcoin-core-dev
532018-06-19T06:08:01 *** d9b4bef9 has quit IRC
542018-06-19T06:09:18 *** d9b4bef9 has joined #bitcoin-core-dev
552018-06-19T06:21:35 *** ExtraCrispy has quit IRC
562018-06-19T06:21:49 *** thaumavorio has quit IRC
572018-06-19T06:23:04 *** thaumavorio has joined #bitcoin-core-dev
582018-06-19T07:01:20 *** BashCo has quit IRC
592018-06-19T07:02:04 *** fanquake has quit IRC
602018-06-19T07:11:12 *** BashCo has joined #bitcoin-core-dev
612018-06-19T07:24:27 *** Randolf has quit IRC
622018-06-19T07:25:45 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/088240685456...3f398d7a17f1
632018-06-19T07:25:46 <bitcoin-git> bitcoin/master fa6e497 MarcoFalke: rpc: Avoid "duplicate" return value for invalid submitblock
642018-06-19T07:25:46 <bitcoin-git> bitcoin/master f748944 Matt Corallo: Only set fNewBlock to true in AcceptBlock when we write to disk...
652018-06-19T07:25:47 <bitcoin-git> bitcoin/master 3f398d7 Jonas Schnelli: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock...
662018-06-19T07:26:46 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13439: rpc: Avoid "duplicate" return value for invalid submitblock (master...2018-06-marcos-submitblock-fix) https://github.com/bitcoin/bitcoin/pull/13439
672018-06-19T07:28:18 *** Krellan has quit IRC
682018-06-19T07:30:10 *** ExtraCrispy has joined #bitcoin-core-dev
692018-06-19T07:30:55 *** Randolf has joined #bitcoin-core-dev
702018-06-19T07:37:38 *** helo has quit IRC
712018-06-19T07:39:08 *** helo has joined #bitcoin-core-dev
722018-06-19T07:42:14 *** BashCo has quit IRC
732018-06-19T07:45:16 *** BashCo has joined #bitcoin-core-dev
742018-06-19T07:59:21 *** ExtraCrispy has quit IRC
752018-06-19T07:59:43 *** BashCo has quit IRC
762018-06-19T08:02:15 *** Victorsueca has quit IRC
772018-06-19T08:03:00 *** ExtraCrispy has joined #bitcoin-core-dev
782018-06-19T08:03:35 *** Victorsueca has joined #bitcoin-core-dev
792018-06-19T08:06:53 <jonasschnelli> Regarding BIP174 (PSBT), the BIP32 derivation path is global, does that mean that each Co-Signer must use the same master key? Or is that global value per PSBT file which is per co-signer different?
802018-06-19T08:07:07 <jonasschnelli> ^ achow101
812018-06-19T08:08:03 <achow101> jonasschnelli: not all signers need to be able to produce the private key for a public key in the derivation paths
822018-06-19T08:08:21 <achow101> that's just there as a "here is some information that may be useful, use it as you wish"
832018-06-19T08:08:41 <achow101> co signers can use different master keys
842018-06-19T08:08:57 *** StopAndDecrypt has quit IRC
852018-06-19T08:09:03 <jonasschnelli> achow101: so in multisig accoding to Bip45 or similar, this information (BIP32 derivation path) would be of no value to the signers, right?
862018-06-19T08:09:19 *** vicenteH has joined #bitcoin-core-dev
872018-06-19T08:10:16 <achow101> I think the derivation paths would still be useful
882018-06-19T08:10:41 <jonasschnelli> How would a cosigner figure out what key he needs to derive for signing a multisig UTXO?
892018-06-19T08:11:14 *** StopAndDecrypt has joined #bitcoin-core-dev
902018-06-19T08:11:23 *** StopAndDecrypt has quit IRC
912018-06-19T08:11:24 *** StopAndDecrypt has joined #bitcoin-core-dev
922018-06-19T08:11:26 <jonasschnelli> By taking the global BIP32 keypath but not looking at the fingerprint/masterkey?
932018-06-19T08:11:56 <achow101> jonasschnelli: the idea is that suppose you have a signer who just has a master private key. Using the derivation paths, he can find which pubkeys that he can sign for because they have his master key fingerprint so then he can derive their private keys and sign
942018-06-19T08:13:43 <jonasschnelli> a) why would the signer need the fingerprint? Wouldn't the path be sufficient?
952018-06-19T08:14:32 <jonasschnelli> b) What if creator and signer are in a non trusted relationship... the only thing i'd like to tell the creator â if I would be a signer â is my pubkey for creating the MS address.
962018-06-19T08:14:44 <achow101> a) in the bip45 case, the path would be sufficient. but bip45 is not guaranteed
972018-06-19T08:15:15 <achow101> b) then there is no need for a derivation path entry for that pubkey
982018-06-19T08:15:50 <achow101> derivation paths is only there to tell a wallet how to get the private key if it doesn't already know it
992018-06-19T08:16:03 <jonasschnelli> Okay. I see. I think it was not obvious to me by reading the BIP that one could fill in the path but present 0 bytes for the fingerprint
1002018-06-19T08:16:25 <achow101> ... that is not allowed
1012018-06-19T08:16:33 <jonasschnelli> hmm...
1022018-06-19T08:17:01 <jonasschnelli> achow101: Can we go through the BIP 2-of-3 usecase: https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki#2-of-3-multisig-workflow?
1032018-06-19T08:17:06 <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
1042018-06-19T08:17:19 <achow101> ok..
1052018-06-19T08:17:33 <jonasschnelli> Alice (creator) would she need to know the fingerpritn of Bob's /Caroles master?
1062018-06-19T08:18:03 <achow101> no
1072018-06-19T08:18:14 <achow101> however Bob and Carol can provide it if they want to
1082018-06-19T08:18:29 <jonasschnelli> achow101: would she just not provide the BIP32 derivation key/value?
1092018-06-19T08:18:53 <achow101> yes, there would simply be no BIP 32 derivations if neither Bob or Carol provided their master fingerprint
1102018-06-19T08:19:16 <achow101> If one provided, then there would only be one BIP 32 derivation entry
1112018-06-19T08:19:22 <jonasschnelli> But that means, Carol (HWW) would need a map of utxo-addresses-to-keypath in order to derive the key required for signing, right?
1122018-06-19T08:19:33 *** StopAndDecrypt has quit IRC
1132018-06-19T08:19:39 *** timothy has joined #bitcoin-core-dev
1142018-06-19T08:19:46 <achow101> yes
1152018-06-19T08:19:54 *** StopAndDecrypt has joined #bitcoin-core-dev
1162018-06-19T08:19:58 <achow101> so in this case, Carol would probably want to provide the master fingerprint
1172018-06-19T08:20:04 *** StopAndDecrypt has quit IRC
1182018-06-19T08:20:04 *** StopAndDecrypt has joined #bitcoin-core-dev
1192018-06-19T08:20:15 <jonasschnelli> Though, we assume now, they are using BIP45 or another deterministic MS address generation scheme...
1202018-06-19T08:20:38 <jonasschnelli> Is there a K/V where Alice could tell Carol which keypath they should use without telling or knowing its fingerprint?
1212018-06-19T08:21:02 *** BashCo has joined #bitcoin-core-dev
1222018-06-19T08:21:07 <achow101> no
1232018-06-19T08:21:30 <jonasschnelli> Would that make sense to have a such field? or allow BIP32 keypath without fingerprint/master key reference?
1242018-06-19T08:22:09 <achow101> presumably with BIP 45 the master key fingerprint would already be known, no?
1252018-06-19T08:22:40 <jonasschnelli> Yes. I think so...
1262018-06-19T08:22:51 *** BashCo_ has joined #bitcoin-core-dev
1272018-06-19T08:23:03 <jonasschnelli> But not if we would go with sipa change request (see ML)
1282018-06-19T08:23:25 <jonasschnelli> though... eventually..
1292018-06-19T08:24:13 <jonasschnelli> achow101: I was just playing an example in my head where cosigner would not share xpubs (not BIP45) since sharing the xpub is a security and privacy risk...
1302018-06-19T08:24:31 <jonasschnelli> I think MS creation should be possible by just sharing a range of pubkeys
1312018-06-19T08:24:36 <achow101> jonasschnelli: which change? the "generic key offset" one?
1322018-06-19T08:24:49 <jonasschnelli> "For that reason I would suggest that the derivation paths include the
1332018-06-19T08:24:50 <jonasschnelli> full public key and chaincode of the parent or master things are
1342018-06-19T08:24:50 <jonasschnelli> derived from. This does mean that the Creator needs to know the full
1352018-06-19T08:24:50 <jonasschnelli> xpub which things are derived from, rather than just its fingerprin"
1362018-06-19T08:24:57 <achow101> oh that.
1372018-06-19T08:25:05 *** BashCo has quit IRC
1382018-06-19T08:26:40 <achow101> jonasschnelli: not having a bip32 derivation path entry is completely fine. The signers just need to parse the redeemscript for that input to figure out what keys are required and check whether they have them
1392018-06-19T08:27:04 <jonasschnelli> I see... thanks
1402018-06-19T08:28:35 <jonasschnelli> achow101: from the BIP "The master key fingerprint concatenated with the derivation path of the public key"
1412018-06-19T08:28:45 <jonasschnelli> Is "public" in "public key" relevant here?
1422018-06-19T08:28:57 <jonasschnelli> Since a derivation path refers to pub & priv, right?
1432018-06-19T08:29:10 <achow101> the "public" isn't relevant
1442018-06-19T08:29:34 <jonasschnelli> Same here: "Public keys can be those that will be needed to sign any type of key hash input or is spent to by an output"
1452018-06-19T08:30:04 <achow101> the pubkey is the key of the KV pair for bip32 derivation paths. so I just worded it to refer to that pubkey
1462018-06-19T08:30:31 <jonasschnelli> Okay. I see
1472018-06-19T08:32:58 <jonasschnelli> achow101: again for my clarification (sorry if I'm bothering you): using the 0x03 type (BIP32 derivation path) would mean, that each Co-Signer (in case of a multisig) would require to use the same masterkey (if we assume they have no capabilities to derive keys based on just the pubkey)?
1482018-06-19T08:33:45 <achow101> no. there can be multiple bip32 derivation paths, each corresponding to a different key
1492018-06-19T08:34:26 <achow101> so pubkey 1 can have master key 1 and derivation path 1, and pubkey 2 can have a different master key 2 and derivation path 2. both get their own 0x03 type records
1502018-06-19T08:36:05 <jonasschnelli> Ah.. I see. The uniqueness is not on the k/v number (0x03) its for the whole key (ex. 0x03&pubkey)
1512018-06-19T08:36:32 <achow101> yes
1522018-06-19T08:38:03 <jonasschnelli> Thanks achow101
1532018-06-19T08:40:11 <jonasschnelli> achow101: the current K/V value type (k/v size depending on type) seems to disallow backward compatibility, is that sipa point on the mailing list?
1542018-06-19T08:40:25 <achow101> how so?
1552018-06-19T08:40:31 <jonasschnelli> (old clients may fail to skip k/v's they don't know)
1562018-06-19T08:40:47 <achow101> the size includes the type
1572018-06-19T08:40:59 <jonasschnelli> Oh.. right. I see
1582018-06-19T08:41:05 <achow101> it's <size><type><key><size><value>
1592018-06-19T08:41:13 <achow101> so sizes will always be known
1602018-06-19T08:41:31 <jonasschnelli> Indeed. So clients can skip unknown k/v types
1612018-06-19T08:41:41 <achow101> yep
1622018-06-19T08:42:39 <jonasschnelli> Okay. I see the point on the ML was more that, instead of K/V, we could use a set of record... since somce K/V have acctually no K
1632018-06-19T08:42:43 <jonasschnelli> *some
1642018-06-19T08:42:55 <achow101> yeah..
1652018-06-19T08:55:42 *** timothy has quit IRC
1662018-06-19T09:01:09 *** timothy has joined #bitcoin-core-dev
1672018-06-19T09:02:32 *** promag has joined #bitcoin-core-dev
1682018-06-19T09:02:58 *** vicenteH has quit IRC
1692018-06-19T09:03:40 *** vicenteH has joined #bitcoin-core-dev
1702018-06-19T09:04:22 <promag> jonasschnelli: does unloadwallet lgty?
1712018-06-19T09:04:49 <jonasschnelli> yes.. I just had a crash on regtest while executing generate 1 ... but not sure if it is related to that change
1722018-06-19T09:05:19 <jonasschnelli> promag: can you try to load / unload and play a bit with generate 1
1732018-06-19T09:05:32 <jonasschnelli> Could also be related to my disableprivatekey work
1742018-06-19T09:05:48 <jonasschnelli> But in general it looks good... I think it needs other acks before merge
1752018-06-19T09:05:52 <promag> you are rebased on unloadwallet?
1762018-06-19T09:06:16 <promag> I hope jnewbery can look at it again
1772018-06-19T09:25:58 *** kabaum has joined #bitcoin-core-dev
1782018-06-19T09:39:17 <jonasschnelli> promag: I did some local changes on top of unloadwallet (just because I forgot to reset back to master)
1792018-06-19T09:40:24 <promag> jonasschnelli: I'm on #13501 but then I'll try the above
1802018-06-19T09:40:26 <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Remove race on shutdown between event loop exit and http reply by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
1812018-06-19T09:50:36 *** jtimon has joined #bitcoin-core-dev
1822018-06-19T10:06:21 *** ExtraCrispy has quit IRC
1832018-06-19T10:06:36 *** ExtraCrispy has joined #bitcoin-core-dev
1842018-06-19T10:07:57 *** CubicEarths has quit IRC
1852018-06-19T10:09:23 *** AaronvanW has joined #bitcoin-core-dev
1862018-06-19T10:22:55 *** ExtraCrispy has quit IRC
1872018-06-19T10:31:43 *** hri has joined #bitcoin-core-dev
1882018-06-19T10:31:52 <hri> hi
1892018-06-19T10:32:44 *** hri has quit IRC
1902018-06-19T10:40:02 *** d9b4bef9 has quit IRC
1912018-06-19T10:40:24 *** Gnappuraz has joined #bitcoin-core-dev
1922018-06-19T10:41:09 *** d9b4bef9 has joined #bitcoin-core-dev
1932018-06-19T10:43:26 *** Gnappuraz has left #bitcoin-core-dev
1942018-06-19T10:44:12 *** Gnappuraz has joined #bitcoin-core-dev
1952018-06-19T10:44:17 *** Gnappuraz has left #bitcoin-core-dev
1962018-06-19T10:48:08 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1972018-06-19T10:50:51 *** promag_ has joined #bitcoin-core-dev
1982018-06-19T10:54:15 *** promag has quit IRC
1992018-06-19T11:00:27 *** jpe has quit IRC
2002018-06-19T11:00:36 *** kabaum has quit IRC
2012018-06-19T11:18:29 *** laurentmt has joined #bitcoin-core-dev
2022018-06-19T11:19:29 *** laurentmt has quit IRC
2032018-06-19T11:28:01 *** Ruby69Trantow has joined #bitcoin-core-dev
2042018-06-19T11:34:09 *** bitconner has joined #bitcoin-core-dev
2052018-06-19T11:54:54 *** Gnappuraz has joined #bitcoin-core-dev
2062018-06-19T12:08:30 *** ula has joined #bitcoin-core-dev
2072018-06-19T12:09:56 *** Chris_Stewart_5 has quit IRC
2082018-06-19T12:11:46 *** SopaXorzTaker has joined #bitcoin-core-dev
2092018-06-19T12:16:52 *** vicenteH has quit IRC
2102018-06-19T12:30:46 *** kabaum has joined #bitcoin-core-dev
2112018-06-19T12:51:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2122018-06-19T12:58:14 *** ccook has quit IRC
2132018-06-19T13:01:12 *** kabaum has quit IRC
2142018-06-19T13:10:11 *** quer has joined #bitcoin-core-dev
2152018-06-19T13:49:05 <bitcoin-git> [bitcoin] practicalswift opened pull request #13503: Document FreeBSD quirk. Fix FreeBSD build: Cast to int to allow std::min to work under FreeBSD. (master...document-freebsd-quirk) https://github.com/bitcoin/bitcoin/pull/13503
2162018-06-19T13:50:45 *** goatpig has quit IRC
2172018-06-19T14:10:18 *** dendisuhubdy has joined #bitcoin-core-dev
2182018-06-19T14:13:01 *** vicenteH has joined #bitcoin-core-dev
2192018-06-19T14:28:18 <bitcoin-git> [bitcoin] practicalswift closed pull request #13503: Document FreeBSD quirk. Fix FreeBSD build: Cast to int to allow std::min to work under FreeBSD. (master...document-freebsd-quirk) https://github.com/bitcoin/bitcoin/pull/13503
2202018-06-19T14:29:27 *** bitconner has quit IRC
2212018-06-19T14:34:05 *** bitconner has joined #bitcoin-core-dev
2222018-06-19T14:34:30 *** Gnappuraz has quit IRC
2232018-06-19T14:38:56 *** Krellan has joined #bitcoin-core-dev
2242018-06-19T14:39:40 *** bitconner has quit IRC
2252018-06-19T14:41:13 *** bitconner has joined #bitcoin-core-dev
2262018-06-19T14:49:32 *** brianhoffman has quit IRC
2272018-06-19T14:49:50 *** brianhoffman has joined #bitcoin-core-dev
2282018-06-19T15:09:58 *** bitconner has quit IRC
2292018-06-19T15:21:12 *** ExtraCrispy has joined #bitcoin-core-dev
2302018-06-19T15:34:44 *** Guyver2 has joined #bitcoin-core-dev
2312018-06-19T15:44:32 *** Randolf has quit IRC
2322018-06-19T15:45:51 *** jhfrontz has quit IRC
2332018-06-19T15:47:27 *** bitconner has joined #bitcoin-core-dev
2342018-06-19T15:50:32 *** zfrohardt has joined #bitcoin-core-dev
2352018-06-19T15:52:12 *** bitconner has quit IRC
2362018-06-19T15:52:17 *** tsle1850 has joined #bitcoin-core-dev
2372018-06-19T15:59:49 *** Dizzle has joined #bitcoin-core-dev
2382018-06-19T16:03:37 *** Randolf has joined #bitcoin-core-dev
2392018-06-19T16:04:38 *** Krellan has quit IRC
2402018-06-19T16:41:33 *** bitconner has joined #bitcoin-core-dev
2412018-06-19T16:46:09 *** bitconner has quit IRC
2422018-06-19T16:47:28 *** CubicEarths has joined #bitcoin-core-dev
2432018-06-19T16:56:34 *** Dizzle has quit IRC
2442018-06-19T16:57:25 *** CubicEarths has quit IRC
2452018-06-19T17:01:50 *** bitconner has joined #bitcoin-core-dev
2462018-06-19T17:04:01 *** ExtraCrispy has quit IRC
2472018-06-19T17:04:47 *** Krellan has joined #bitcoin-core-dev
2482018-06-19T17:05:45 <bitcoin-git> [bitcoin] promag closed pull request #13492: Fix reply not sent when event loop terminates prematurely (master...2018-06-http-shutdown) https://github.com/bitcoin/bitcoin/pull/13492
2492018-06-19T17:06:36 *** bitconner has quit IRC
2502018-06-19T17:06:56 *** Krellan has quit IRC
2512018-06-19T17:09:57 *** timothy has quit IRC
2522018-06-19T17:13:41 *** bitconner has joined #bitcoin-core-dev
2532018-06-19T17:25:27 *** CubicEarths has joined #bitcoin-core-dev
2542018-06-19T17:27:22 *** CubicEarths has quit IRC
2552018-06-19T17:27:58 *** CubicEarths has joined #bitcoin-core-dev
2562018-06-19T17:34:16 <promag_> wumpus: MarcoFalke: cfields: fyi #13501
2572018-06-19T17:34:18 <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Remove race on shutdown between event loop exit and http reply by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
2582018-06-19T17:34:25 *** bitconner has quit IRC
2592018-06-19T17:41:21 *** bitconner has joined #bitcoin-core-dev
2602018-06-19T17:49:42 *** grafcaps has joined #bitcoin-core-dev
2612018-06-19T17:53:20 *** nmnkgl has joined #bitcoin-core-dev
2622018-06-19T18:01:14 <michagogo> Hm, the Debian bug that keeps us in unstable just got closed
2632018-06-19T18:03:39 *** promag_ has quit IRC
2642018-06-19T18:04:57 *** Teflon has joined #bitcoin-core-dev
2652018-06-19T18:11:06 *** Teflon has quit IRC
2662018-06-19T18:14:04 <michagogo> Do you think thatâs okay, or should we argue against that?
2672018-06-19T18:15:21 *** promag has joined #bitcoin-core-dev
2682018-06-19T18:28:23 *** kurito has joined #bitcoin-core-dev
2692018-06-19T18:29:33 *** dendisuhubdy has quit IRC
2702018-06-19T18:38:47 *** SopaXorzTaker has quit IRC
2712018-06-19T18:44:49 *** bitconner has quit IRC
2722018-06-19T18:46:07 <bitcoin-git> [bitcoin] skeees closed pull request #12801: Add option to only notify after wallet transactions are confirmed (master...notifycount) https://github.com/bitcoin/bitcoin/pull/12801
2732018-06-19T18:49:27 *** brianhoffman has quit IRC
2742018-06-19T18:50:17 *** brianhoffman has joined #bitcoin-core-dev
2752018-06-19T18:52:45 <jonasschnelli> promag why is uiInterface.LoadWallet(walletInstance); called before the CreateWalletFromFile() method can't return an error?
2762018-06-19T18:53:00 <jonasschnelli> s/can't/can
2772018-06-19T18:53:48 <jonasschnelli> I think uiInterface.LoadWallet(walletInstance); displays the wallet in the GUI but there are various cases where CreateWalletFromFile will refuse loading the wallet after that uiInterface call
2782018-06-19T18:56:27 *** ula has quit IRC
2792018-06-19T18:57:07 *** drexl has joined #bitcoin-core-dev
2802018-06-19T18:59:40 *** kurito_ has joined #bitcoin-core-dev
2812018-06-19T19:02:57 *** kurito has quit IRC
2822018-06-19T19:09:56 *** kurito_ has quit IRC
2832018-06-19T19:10:28 *** ula has joined #bitcoin-core-dev
2842018-06-19T19:12:54 *** sam_c has joined #bitcoin-core-dev
2852018-06-19T19:13:03 *** sam_c has left #bitcoin-core-dev
2862018-06-19T19:17:45 *** nmnkgl has quit IRC
2872018-06-19T19:21:20 *** nmnkgl has joined #bitcoin-core-dev
2882018-06-19T19:27:23 *** tex has joined #bitcoin-core-dev
2892018-06-19T19:27:59 *** tex has left #bitcoin-core-dev
2902018-06-19T19:32:04 *** tsle1850 has quit IRC
2912018-06-19T19:33:16 *** tex has joined #bitcoin-core-dev
2922018-06-19T19:34:20 *** tex has left #bitcoin-core-dev
2932018-06-19T19:38:09 *** tsle1850 has joined #bitcoin-core-dev
2942018-06-19T19:41:02 *** Randolf has quit IRC
2952018-06-19T19:41:03 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #13506: Qt: load wallet in UI after possible init aborts (master...2018/06/wallet_ui) https://github.com/bitcoin/bitcoin/pull/13506
2962018-06-19T19:42:57 *** booyah has quit IRC
2972018-06-19T19:43:55 *** AaronvanW has quit IRC
2982018-06-19T19:46:32 *** booyah has joined #bitcoin-core-dev
2992018-06-19T19:47:34 <promag> jonasschnelli: yes, that needs a fix
3002018-06-19T19:47:48 <jonasschnelli> promag: See #13506
3012018-06-19T19:47:50 <gribble> https://github.com/bitcoin/bitcoin/issues/13506 | Qt: load wallet in UI after possible init aborts by jonasschnelli · Pull Request #13506 · bitcoin/bitcoin · GitHub
3022018-06-19T19:48:16 <promag> i think its the same problem in https://github.com/bitcoin/bitcoin/pull/13097#issuecomment-398445833
3032018-06-19T19:49:26 <promag> oh that's a new issue
3042018-06-19T19:53:41 *** booyah has quit IRC
3052018-06-19T19:53:57 *** booyah has joined #bitcoin-core-dev
3062018-06-19T19:54:45 *** Victorsueca has quit IRC
3072018-06-19T19:55:22 *** str4d has joined #bitcoin-core-dev
3082018-06-19T19:56:03 *** Victorsueca has joined #bitcoin-core-dev
3092018-06-19T19:57:11 <promag> jonasschnelli: your fix is obviously correct
3102018-06-19T19:57:23 *** treyzania_ has joined #bitcoin-core-dev
3112018-06-19T19:57:32 <jonasschnelli> promag: I wasn't sure but could not find a reason why it can't be called later
3122018-06-19T19:58:09 <promag> like I said in your PR, the bug was already there before #13063
3132018-06-19T19:58:12 <gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
3142018-06-19T19:59:14 <promag> there are a couple of places with "CWallet::CreateWalletFromFile(...); if (!wallet) error; AddWallet(...)"
3152018-06-19T20:00:27 <promag> I have a branch with CWallet::LoadWalletFromFile that does that (also WalletManager::LoadWalletFromFile)
3162018-06-19T20:04:57 <jonasschnelli> Indeed
3172018-06-19T20:20:13 *** treyzania_ has quit IRC
3182018-06-19T20:33:31 *** nmnkgl has quit IRC
3192018-06-19T20:37:46 *** AaronvanW has joined #bitcoin-core-dev
3202018-06-19T20:43:34 *** Chris_Stewart_5 has quit IRC
3212018-06-19T20:45:12 *** jtimon has quit IRC
3222018-06-19T20:46:45 *** kabaum has joined #bitcoin-core-dev
3232018-06-19T20:46:55 *** zfrohardt has quit IRC
3242018-06-19T20:59:46 *** Ruby69Trantow has quit IRC
3252018-06-19T21:00:55 *** brianhoffman has quit IRC
3262018-06-19T21:07:25 *** Aaronvan_ has joined #bitcoin-core-dev
3272018-06-19T21:08:07 *** str4d has quit IRC
3282018-06-19T21:10:57 *** AaronvanW has quit IRC
3292018-06-19T21:13:16 *** nmnkgl has joined #bitcoin-core-dev
3302018-06-19T21:17:35 *** nmnkgl has quit IRC
3312018-06-19T21:27:59 *** Helene24Fadel has joined #bitcoin-core-dev
3322018-06-19T21:37:08 <bitcoin-git> [bitcoin] kristapsk opened pull request #13507: RPC: Fix parameter count check for importpubkey. (master...importpubkey) https://github.com/bitcoin/bitcoin/pull/13507
3332018-06-19T21:38:26 *** kabaum has quit IRC
3342018-06-19T21:39:37 *** Aaronvan_ is now known as AaronvanW
3352018-06-19T21:43:27 *** DrFeelGood has quit IRC
3362018-06-19T21:44:46 *** tsle1850 has quit IRC
3372018-06-19T21:44:53 *** Randolf has joined #bitcoin-core-dev
3382018-06-19T21:45:56 *** DrFeelGood has joined #bitcoin-core-dev
3392018-06-19T21:50:42 *** tsle1850 has joined #bitcoin-core-dev
3402018-06-19T21:52:04 *** jojeyh has joined #bitcoin-core-dev
3412018-06-19T21:55:57 *** belcher has quit IRC
3422018-06-19T21:57:03 *** miya has joined #bitcoin-core-dev
3432018-06-19T22:02:22 *** jojeyh has quit IRC
3442018-06-19T22:05:43 *** jojeyh has joined #bitcoin-core-dev
3452018-06-19T22:07:38 *** Randolf has quit IRC
3462018-06-19T22:09:05 *** grafcaps has quit IRC
3472018-06-19T22:13:48 *** vicenteH has quit IRC
3482018-06-19T22:18:05 *** jtimon has joined #bitcoin-core-dev
3492018-06-19T22:21:20 *** CubicEarths has quit IRC
3502018-06-19T22:26:00 *** grafcaps has joined #bitcoin-core-dev
3512018-06-19T22:30:41 *** grafcaps has quit IRC
3522018-06-19T22:33:22 *** grafcaps has joined #bitcoin-core-dev
3532018-06-19T22:38:27 *** tsle1850 has quit IRC
3542018-06-19T22:38:35 *** grafcaps has quit IRC
3552018-06-19T22:38:37 *** jimpo has quit IRC
3562018-06-19T22:40:58 *** tsle1850 has joined #bitcoin-core-dev
3572018-06-19T22:41:23 *** Randolf has joined #bitcoin-core-dev
3582018-06-19T22:42:32 *** grafcaps has joined #bitcoin-core-dev
3592018-06-19T22:46:27 *** grafcaps has quit IRC
3602018-06-19T22:48:00 *** miya has quit IRC
3612018-06-19T22:48:45 *** nmnkgl has joined #bitcoin-core-dev
3622018-06-19T22:51:36 *** grafcaps has joined #bitcoin-core-dev
3632018-06-19T22:51:55 *** Aaronvan_ has joined #bitcoin-core-dev
3642018-06-19T22:52:29 *** Aaronva__ has joined #bitcoin-core-dev
3652018-06-19T22:54:48 *** AaronvanW has quit IRC
3662018-06-19T22:55:35 *** grafcaps has quit IRC
3672018-06-19T22:56:05 *** Aaronvan_ has quit IRC
3682018-06-19T22:57:27 *** DrFeelGood has quit IRC
3692018-06-19T23:02:06 *** DrFeelGood has joined #bitcoin-core-dev
3702018-06-19T23:03:23 *** Guyver2 has quit IRC
3712018-06-19T23:08:18 *** lqz has joined #bitcoin-core-dev
3722018-06-19T23:08:41 <lqz> whoami
3732018-06-19T23:08:44 <lqz> ls
3742018-06-19T23:09:18 <lqz> whois
3752018-06-19T23:09:47 *** lqz has left #bitcoin-core-dev
3762018-06-19T23:18:42 *** grafcaps has joined #bitcoin-core-dev
3772018-06-19T23:22:45 *** grafcaps has quit IRC
3782018-06-19T23:27:20 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3792018-06-19T23:27:44 *** grafcaps has joined #bitcoin-core-dev
3802018-06-19T23:28:20 *** drexl has quit IRC
3812018-06-19T23:30:46 *** Randolf has quit IRC
3822018-06-19T23:31:19 *** promag has quit IRC
3832018-06-19T23:32:27 *** grafcaps has quit IRC
3842018-06-19T23:33:27 *** tsle1850 has quit IRC
3852018-06-19T23:36:55 *** tsle1850 has joined #bitcoin-core-dev
3862018-06-19T23:54:48 *** grafcaps has joined #bitcoin-core-dev
3872018-06-19T23:59:21 *** grafcaps has quit IRC