12018-07-13T00:11:07  <achow101> cfields: for kvm, I think it would be easier to keep vmbuilder and just use the updated fork
  22018-07-13T00:11:44  <achow101> also probably more cross-platform too
  32018-07-13T00:16:10  *** grafcaps has quit IRC
  42018-07-13T00:35:57  *** grafcaps has joined #bitcoin-core-dev
  52018-07-13T00:40:12  <cfields> achow101: you're probably right. I haven't looked into uvtool much yet
  62018-07-13T00:41:09  <cfields> finally managed to get builds going. testing #13171 now.
  72018-07-13T00:41:11  <gribble> https://github.com/bitcoin/bitcoin/issues/13171 | Change gitian-descriptors to use bionic instead by ken2812221 · Pull Request #13171 · bitcoin/bitcoin · GitHub
  82018-07-13T00:43:41  <luke-jr> hopefully bionic is ready sooner rather than later so we can slip POWER9 into 0.17 bins :p
  92018-07-13T00:44:04  <luke-jr> (or POWER8 for more compatibility)
 102018-07-13T01:01:42  *** Murch has quit IRC
 112018-07-13T01:02:10  *** Murch has joined #bitcoin-core-dev
 122018-07-13T01:04:51  *** ddt_is_dead has quit IRC
 132018-07-13T01:12:43  *** vicenteH has quit IRC
 142018-07-13T01:13:13  *** vicenteH has joined #bitcoin-core-dev
 152018-07-13T01:21:38  *** jpe_ has joined #bitcoin-core-dev
 162018-07-13T01:22:40  *** Krellan has quit IRC
 172018-07-13T01:24:16  *** jpe has quit IRC
 182018-07-13T01:24:43  *** Murch has quit IRC
 192018-07-13T01:26:35  *** Murch has joined #bitcoin-core-dev
 202018-07-13T01:28:35  *** bitconner has quit IRC
 212018-07-13T01:43:17  *** Michael___ has joined #bitcoin-core-dev
 222018-07-13T01:52:21  *** Michael___ has quit IRC
 232018-07-13T02:15:02  *** d9b4bef9 has quit IRC
 242018-07-13T02:16:14  *** d9b4bef9 has joined #bitcoin-core-dev
 252018-07-13T02:33:23  *** ken2812221 has joined #bitcoin-core-dev
 262018-07-13T02:33:43  *** bitconner has joined #bitcoin-core-dev
 272018-07-13T02:41:57  *** Murch has quit IRC
 282018-07-13T02:47:32  *** |EHG| has quit IRC
 292018-07-13T02:48:25  *** |EHG| has joined #bitcoin-core-dev
 302018-07-13T03:11:44  *** jk has joined #bitcoin-core-dev
 312018-07-13T03:17:10  *** grafcaps has quit IRC
 322018-07-13T03:28:21  *** jk has quit IRC
 332018-07-13T04:09:22  *** jb55 has quit IRC
 342018-07-13T04:14:09  *** bitconner has quit IRC
 352018-07-13T04:20:27  *** shesek has quit IRC
 362018-07-13T04:22:03  <kallewoof> FWIW I was going to ask to have #12257 added to high priority list at the meeting now that the transaction limit one is merged but I fell asleep. Any objections on that?
 372018-07-13T04:22:08  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
 382018-07-13T04:35:33  <gmaxwell> I would have asked for that myself but wumpus made sounds that it could go in after the freeze too.
 392018-07-13T04:36:30  <gmaxwell> (also, I hadn't reviewed it yet so I felt kinda bad for nagging. :) )
 402018-07-13T04:37:18  *** Randolf has joined #bitcoin-core-dev
 412018-07-13T04:50:48  <kallewoof> Ohh, OK!
 422018-07-13T04:51:07  <kallewoof> Thanks for nagging though.
 432018-07-13T05:05:57  *** davec has quit IRC
 442018-07-13T05:11:10  *** vicenteH has quit IRC
 452018-07-13T05:15:33  *** vicenteH has joined #bitcoin-core-dev
 462018-07-13T05:22:10  *** davec has joined #bitcoin-core-dev
 472018-07-13T05:22:41  *** Murch has joined #bitcoin-core-dev
 482018-07-13T05:27:19  *** DougieBot5000_ has joined #bitcoin-core-dev
 492018-07-13T05:27:56  *** DougieBot5000 is now known as Guest757
 502018-07-13T05:27:57  *** DougieBot5000_ is now known as DougieBot5000
 512018-07-13T05:28:42  *** ctrlbreak_MAD has joined #bitcoin-core-dev
 522018-07-13T05:32:38  *** ctrlbreak has quit IRC
 532018-07-13T06:05:02  *** d9b4bef9 has quit IRC
 542018-07-13T06:06:07  *** d9b4bef9 has joined #bitcoin-core-dev
 552018-07-13T06:13:11  *** grafcaps has joined #bitcoin-core-dev
 562018-07-13T06:17:27  *** grafcaps has quit IRC
 572018-07-13T06:26:15  *** promag has quit IRC
 582018-07-13T06:26:20  *** booyah has quit IRC
 592018-07-13T06:26:48  *** promag has joined #bitcoin-core-dev
 602018-07-13T06:27:16  *** booyah has joined #bitcoin-core-dev
 612018-07-13T06:30:57  *** promag has quit IRC
 622018-07-13T06:48:35  *** bitconner has joined #bitcoin-core-dev
 632018-07-13T06:49:00  *** grafcaps has joined #bitcoin-core-dev
 642018-07-13T06:49:15  *** arubi has quit IRC
 652018-07-13T06:52:11  *** arubi has joined #bitcoin-core-dev
 662018-07-13T06:53:44  *** grafcaps has quit IRC
 672018-07-13T06:55:00  *** bitconne1 has joined #bitcoin-core-dev
 682018-07-13T06:58:26  *** bitconner has quit IRC
 692018-07-13T06:59:57  *** vicenteH has quit IRC
 702018-07-13T07:00:30  *** vicenteH has joined #bitcoin-core-dev
 712018-07-13T07:03:40  *** ken2812221 is now known as ken2812221_
 722018-07-13T07:03:58  *** promag has joined #bitcoin-core-dev
 732018-07-13T07:06:29  *** promag has quit IRC
 742018-07-13T07:15:34  <bitcoin-git> [bitcoin] kallewoof opened pull request #13654: build: make 'depends' output less spammy (master...depends-despammed) https://github.com/bitcoin/bitcoin/pull/13654
 752018-07-13T07:20:31  *** Guyver2 has joined #bitcoin-core-dev
 762018-07-13T07:20:40  *** jpe__ has joined #bitcoin-core-dev
 772018-07-13T07:23:01  *** jpe_ has quit IRC
 782018-07-13T07:23:18  *** Murch has quit IRC
 792018-07-13T07:24:25  *** jnewbery has quit IRC
 802018-07-13T07:25:13  *** jamesob has quit IRC
 812018-07-13T07:25:22  *** zxzzt has quit IRC
 822018-07-13T07:26:26  *** jnewbery has joined #bitcoin-core-dev
 832018-07-13T07:27:02  *** jamesob has joined #bitcoin-core-dev
 842018-07-13T07:27:10  *** zxzzt has joined #bitcoin-core-dev
 852018-07-13T07:49:44  *** bitconne1 has quit IRC
 862018-07-13T08:05:06  *** SopaXorzTaker has joined #bitcoin-core-dev
 872018-07-13T08:11:12  *** setpill has joined #bitcoin-core-dev
 882018-07-13T08:24:19  *** timothy has joined #bitcoin-core-dev
 892018-07-13T08:30:53  *** promag has joined #bitcoin-core-dev
 902018-07-13T08:48:54  *** Randolf has quit IRC
 912018-07-13T08:49:35  *** vicenteH has quit IRC
 922018-07-13T08:50:06  *** vicenteH has joined #bitcoin-core-dev
 932018-07-13T08:57:15  <kallewoof> So, the make depends part of the macos travis job is taking 35 minutes. leaving ~5-10 minutes for the rest of the build process before travis bops it over the head.
 942018-07-13T08:58:38  <kallewoof> Do we really need to ... make everything from scratch every time? It feels quite overkill.
 952018-07-13T08:59:53  <kallewoof> https://travis-ci.org/bitcoin/bitcoin/jobs/403447612 has a patch with better overview of each depends build. qt alone takes 17 minutes.
 962018-07-13T09:00:00  *** Randolf has joined #bitcoin-core-dev
 972018-07-13T09:00:17  <kallewoof> https://travis-ci.org/bitcoin/bitcoin/jobs/403447612#L1745-L1756 specifically
 982018-07-13T09:00:22  <sipa> kallewoof: should be cached, no?
 992018-07-13T09:00:30  <sipa> cfields: ^ ?
1002018-07-13T09:00:40  <kallewoof> sipa: it doesn't seem to be
1012018-07-13T09:00:49  <aj> downloads might be cached, but the rebuilds sure don't seem to be?
1022018-07-13T09:01:01  <aj> (assuming you mean via ccache)
1032018-07-13T09:01:33  <ken2812221_> I hava a PR #13515 to fail the travis job if depends build take more than 20 mins, so it can store cache safely.
1042018-07-13T09:01:35  <gribble> https://github.com/bitcoin/bitcoin/issues/13515 | travis: Enable Qt build for Windows and 32-bit Linux by ken2812221 · Pull Request #13515 · bitcoin/bitcoin · GitHubAsset 1Asset 1
1052018-07-13T09:03:06  <kallewoof> I was wading through logs because make depends made so much output that travis truncated the log. Hence #13654
1062018-07-13T09:03:09  <gribble> https://github.com/bitcoin/bitcoin/issues/13654 | build: make depends output less spammy by kallewoof · Pull Request #13654 · bitcoin/bitcoin · GitHubAsset 1Asset 1
1072018-07-13T09:03:54  <kallewoof> All other make depends output is super fast, like a few minutes at most. Only qt that is taking 17 mins.
1082018-07-13T09:07:18  <ken2812221_> If travis fail because it runs more than 50 mins, it won't store the cache. That's why I do #13515.
1092018-07-13T09:07:19  <gribble> https://github.com/bitcoin/bitcoin/issues/13515 | travis: Enable Qt build for Windows and 32-bit Linux by ken2812221 · Pull Request #13515 · bitcoin/bitcoin · GitHub
1102018-07-13T09:07:55  <kallewoof> ken2812221_: Ahh, I was wondering what you meant.
1112018-07-13T09:10:01  <ken2812221_> Didn't you complain about timeout in travis ci?
1122018-07-13T09:10:28  <kallewoof> I did, yep. I just didn't understand what you meant when you said "fail the travis job so it can store cache safely".
1132018-07-13T09:11:29  <sipa> kallewoof: if it fails before timing out, the resulting builds are still cached for future runs
1142018-07-13T09:12:07  <kallewoof> Yeah I understand that now after ken2812221_ explained
1152018-07-13T09:12:09  <ken2812221_> Thanks sipa. That is what I mean.
1162018-07-13T09:17:00  *** murrayn has quit IRC
1172018-07-13T09:19:05  *** Randolf has quit IRC
1182018-07-13T09:19:30  *** Randolf has joined #bitcoin-core-dev
1192018-07-13T09:21:15  *** murrayn has joined #bitcoin-core-dev
1202018-07-13T09:21:16  *** murrayn has joined #bitcoin-core-dev
1212018-07-13T09:24:14  *** vicenteH has quit IRC
1222018-07-13T09:24:42  *** vicenteH has joined #bitcoin-core-dev
1232018-07-13T09:48:31  *** AaronvanW has joined #bitcoin-core-dev
1242018-07-13T09:58:20  <provoostenator> Double unicorn on #13557 (Github said a while ago that there should only be single unicorns and refresh makes them go away)
1252018-07-13T09:58:28  <gribble> https://github.com/bitcoin/bitcoin/issues/13557 | BIP 174 PSBT Serializations and RPCs by achow101 · Pull Request #13557 · bitcoin/bitcoin · GitHub
1262018-07-13T10:00:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dcb154e5aad8...2ea7eb62b21a
1272018-07-13T10:00:24  <bitcoin-git> bitcoin/master a0b604c James O'Beirne: [tests] skip rpc_zmq functional test when python3 zmq lib is not present...
1282018-07-13T10:00:24  <bitcoin-git> bitcoin/master 2ea7eb6 MarcoFalke: Merge #13645: [tests] skip rpc_zmq functional test as necessary...
1292018-07-13T10:01:18  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13646: tests: Skip rpc_zmq.py when ZMQ is disabled (master...skip-zmq-test) https://github.com/bitcoin/bitcoin/pull/13646
1302018-07-13T10:01:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13645: [tests] skip rpc_zmq functional test as necessary (master...2018-07-skip-zmq-tests) https://github.com/bitcoin/bitcoin/pull/13645
1312018-07-13T10:01:41  *** belcher has joined #bitcoin-core-dev
1322018-07-13T10:03:58  *** vicenteH has quit IRC
1332018-07-13T10:13:09  *** jaggfabulous has joined #bitcoin-core-dev
1342018-07-13T10:15:19  *** jaggfabulous has quit IRC
1352018-07-13T10:15:39  *** jaggfabulous has joined #bitcoin-core-dev
1362018-07-13T10:22:18  *** vicenteH has joined #bitcoin-core-dev
1372018-07-13T10:25:16  *** grafcaps has joined #bitcoin-core-dev
1382018-07-13T10:28:00  *** pavan has joined #bitcoin-core-dev
1392018-07-13T10:28:34  <pavan> JOIN
1402018-07-13T10:29:40  *** grafcaps has quit IRC
1412018-07-13T10:29:58  *** pavan has left #bitcoin-core-dev
1422018-07-13T10:30:57  *** spinza has quit IRC
1432018-07-13T10:32:51  *** arubi has quit IRC
1442018-07-13T10:38:20  *** arubi has joined #bitcoin-core-dev
1452018-07-13T10:38:58  *** shesek has joined #bitcoin-core-dev
1462018-07-13T10:48:29  *** spinza has joined #bitcoin-core-dev
1472018-07-13T10:55:23  *** Aaronvan_ has joined #bitcoin-core-dev
1482018-07-13T10:56:21  *** da2ce7 has quit IRC
1492018-07-13T10:57:01  *** da2ce7 has joined #bitcoin-core-dev
1502018-07-13T10:58:05  *** shesek has quit IRC
1512018-07-13T10:58:17  *** AaronvanW has quit IRC
1522018-07-13T11:01:16  *** grafcaps has joined #bitcoin-core-dev
1532018-07-13T11:03:01  *** d9b4bef9 has quit IRC
1542018-07-13T11:03:13  *** Victorsueca has quit IRC
1552018-07-13T11:04:16  *** d9b4bef9 has joined #bitcoin-core-dev
1562018-07-13T11:04:25  *** Victorsueca has joined #bitcoin-core-dev
1572018-07-13T11:05:59  *** grafcaps has quit IRC
1582018-07-13T11:09:20  *** Deinogalerix21 has joined #bitcoin-core-dev
1592018-07-13T11:21:43  *** Aaronvan_ is now known as AaronvanW
1602018-07-13T11:23:32  *** Aaronvan_ has joined #bitcoin-core-dev
1612018-07-13T11:26:27  *** AaronvanW has quit IRC
1622018-07-13T11:37:22  *** AaronvanW has joined #bitcoin-core-dev
1632018-07-13T11:40:32  *** Aaronvan_ has quit IRC
1642018-07-13T11:51:53  *** ddt_is_dead has joined #bitcoin-core-dev
1652018-07-13T11:55:13  *** promag has quit IRC
1662018-07-13T11:56:46  *** ddt_is_dead has quit IRC
1672018-07-13T12:02:29  *** setpill has quit IRC
1682018-07-13T12:33:09  *** ken2812221_ has quit IRC
1692018-07-13T12:38:35  <bitcoin-git> [bitcoin] afk11 opened pull request #13655: bitcoinconsensus: invalid flags should be set to bitcoinconsensus_err (master...bitcoinconsensus-invalid-flags-squashed) https://github.com/bitcoin/bitcoin/pull/13655
1702018-07-13T12:54:27  *** SopaXorzTaker has quit IRC
1712018-07-13T12:58:30  *** Victorsueca has quit IRC
1722018-07-13T12:59:39  *** Victorsueca has joined #bitcoin-core-dev
1732018-07-13T13:06:06  *** Randolf has quit IRC
1742018-07-13T13:06:33  *** Randolf has joined #bitcoin-core-dev
1752018-07-13T13:13:12  *** StayCool has joined #bitcoin-core-dev
1762018-07-13T13:18:28  <StayCool> I just read through some of satoshi's old posts on bitcointalk, and some of the latest ones mention the accounting feature of the JSON-RPC. I find it interesting that Satoshi wanted an implementation of accounts to be available, to easily enable developers to handle customer balances. However currently, it seems like there is consensus from the current developers for completely removing accounts. https://bitcointalk.org/i
1772018-07-13T13:19:04  <StayCool> from what i can read, it seems that the primary reason behind removing the accounts feature is that it has had some issues with balances below 0 while not scaling to millions of accounts? I wonder how Satoshi would look at the account feature today.
1782018-07-13T13:20:12  *** Arokh has quit IRC
1792018-07-13T13:21:32  *** Arokh has joined #bitcoin-core-dev
1802018-07-13T13:31:13  *** jaggfabulous has quit IRC
1812018-07-13T13:31:34  *** jaggfabulous has joined #bitcoin-core-dev
1822018-07-13T13:36:16  *** veleiro has joined #bitcoin-core-dev
1832018-07-13T13:36:40  <luke-jr> jonasschnelli: why do you insist on keeping a broken mis-feature in scantxoutset? ("address" support confuses users by mixing up addresses and keys, and on top of that, it doesn't even work since p2pk won't get picked up)
1842018-07-13T13:41:10  *** HoMM has joined #bitcoin-core-dev
1852018-07-13T13:41:42  <provoostenator> StayCool: it's mostly just renamed to labels. Keeping funds properly seperate is better achieved by using multiple wallets, a feature that was recently added.
1862018-07-13T13:43:27  <StayCool> provoostenator: but this "multiple" wallet feature only scales to about 100-200 wallets, and that is with a rather big amount of RAM. Hopefully the scalability can be increased.
1872018-07-13T13:45:11  <StayCool> Also it's not simply a renaming to labels. Some RPC commands will be removed regarding account, for example the move command.
1882018-07-13T13:47:18  <jnewbery> StayCool: `move` is utterly broken
1892018-07-13T13:50:52  *** hashist has joined #bitcoin-core-dev
1902018-07-13T13:51:56  *** Deinogalerix21 has quit IRC
1912018-07-13T13:55:14  *** HoMM has quit IRC
1922018-07-13T13:55:54  *** promag has joined #bitcoin-core-dev
1932018-07-13T13:59:29  *** jaggfabulous has quit IRC
1942018-07-13T13:59:49  *** jaggfabulous has joined #bitcoin-core-dev
1952018-07-13T14:00:21  *** Yep has joined #bitcoin-core-dev
1962018-07-13T14:00:27  *** SopaXorzTaker has joined #bitcoin-core-dev
1972018-07-13T14:05:45  *** reallll has joined #bitcoin-core-dev
1982018-07-13T14:08:44  *** belcher has quit IRC
1992018-07-13T14:08:54  *** reallll has quit IRC
2002018-07-13T14:10:43  <luke-jr> provoostenator: accounts are in many ways better than multiwallet
2012018-07-13T14:10:51  <luke-jr> jnewbery: broken how?
2022018-07-13T14:11:03  <luke-jr> it did/does what it is intended to do AFAIK
2032018-07-13T14:11:37  *** Yep has quit IRC
2042018-07-13T14:11:43  <provoostenator> Labels no longer keep funds seperated when they're spent, right?
2052018-07-13T14:12:44  <luke-jr> provoostenator: they never did, and never were intended to
2062018-07-13T14:13:01  <provoostenator> Right, so that gives a false sense of privacy.
2072018-07-13T14:13:14  <luke-jr> only if people don't RTFM
2082018-07-13T14:13:25  <luke-jr> (and in some ways, accounts actually improved privacy because of this)
2092018-07-13T14:15:17  <provoostenator> If funds aren't seperated in any way, how did "move" make any sense?
2102018-07-13T14:15:36  <luke-jr> provoostenator: each account had a balance. move increased the balance of one, and decreased the balance of another.
2112018-07-13T14:16:50  <luke-jr> it basically worked fine AFAIK, except 1) didn't scale and 2) didn't backup very well
2122018-07-13T14:16:59  <provoostenator> And because of the funds mixing, you could end up with negative balances (though the sum would be 0)?
2132018-07-13T14:17:29  <luke-jr> provoostenator: you get negative balances by move-ing more funds than your source account had
2142018-07-13T14:17:45  <luke-jr> and possibly with fees; I forget how those worked
2152018-07-13T14:18:24  <luke-jr> eg, if accountA has 1 BTC, move 2 BTC and now it has -1 BTC
2162018-07-13T14:18:39  <provoostenator> Proof that Satoshi wanted fractional reserves ultimately :-P
2172018-07-13T14:19:35  <StayCool> i think the issue with fees was fixed when sendtoaddress included a subtractfee parameter, before that sendfrom was used which could result in a negative fee if the fee was higher than the amount
2182018-07-13T14:20:28  <StayCool> how come the accounts feature doesn't scale very well?
2192018-07-13T14:20:49  <StayCool> negative amount not fee*
2202018-07-13T14:22:15  <luke-jr> StayCool: all move-s were basically kept in RAM
2212018-07-13T14:23:30  <StayCool> you mean move-s using the "move" command, or all transactions?
2222018-07-13T14:32:33  *** DictateThePace has quit IRC
2232018-07-13T14:33:21  *** Murch has joined #bitcoin-core-dev
2242018-07-13T14:37:38  *** grafcaps has joined #bitcoin-core-dev
2252018-07-13T14:42:09  *** grafcaps has quit IRC
2262018-07-13T14:44:34  *** veleiro` has joined #bitcoin-core-dev
2272018-07-13T14:45:31  <bitcoin-git> [bitcoin] 251Labs opened pull request #13656: Remove the boost/algorithm/string/predicate.hpp dependency from netbase.cpp (master...patch/remove_boost_predicate_from_netbase) https://github.com/bitcoin/bitcoin/pull/13656
2282018-07-13T14:46:05  *** veleiro has quit IRC
2292018-07-13T14:52:16  *** shesek has joined #bitcoin-core-dev
2302018-07-13T14:52:16  *** shesek has quit IRC
2312018-07-13T14:52:16  *** shesek has joined #bitcoin-core-dev
2322018-07-13T14:53:20  *** veleiro` is now known as veleiro
2332018-07-13T15:00:57  *** veleiro has quit IRC
2342018-07-13T15:16:52  *** Victorsueca has quit IRC
2352018-07-13T15:18:09  *** Victorsueca has joined #bitcoin-core-dev
2362018-07-13T15:20:29  *** jamesob_ has joined #bitcoin-core-dev
2372018-07-13T15:30:01  *** Randolf has quit IRC
2382018-07-13T15:30:18  *** Randolf has joined #bitcoin-core-dev
2392018-07-13T15:37:27  *** promag has quit IRC
2402018-07-13T15:45:54  *** ExtraCrispy has joined #bitcoin-core-dev
2412018-07-13T15:50:23  *** harrymm has joined #bitcoin-core-dev
2422018-07-13T16:12:49  *** jamesob_ has quit IRC
2432018-07-13T16:32:23  *** grafcaps has joined #bitcoin-core-dev
2442018-07-13T16:35:19  *** jamesob_ has joined #bitcoin-core-dev
2452018-07-13T16:45:20  <bitcoin-git> [bitcoin] Empact opened pull request #13657: wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity (master...accurate-get-blocks-to-maturity) https://github.com/bitcoin/bitcoin/pull/13657
2462018-07-13T16:46:52  *** veleiro has joined #bitcoin-core-dev
2472018-07-13T16:47:24  <bitcoin-git> [bitcoin] Empact opened pull request #13658: [wallet] [moveonly] Move rescanning from time logic into wallet/rpcdump.cpp (master...rescan-from-time) https://github.com/bitcoin/bitcoin/pull/13658
2482018-07-13T16:51:01  *** Sinclair6 has joined #bitcoin-core-dev
2492018-07-13T17:03:49  *** drexl has joined #bitcoin-core-dev
2502018-07-13T17:06:18  <gmaxwell> StayCool: beyond being somewhat flaky, the accounts feature is just inherently unsafe to use because there is no way to make it durable.  Say you withdraw under a seperate account, but then crash right at the same time.  Its possible for the transfer to have gone through but the account binding information to be lost.
2512018-07-13T17:07:04  <gmaxwell> provoostenator: like luke said, multiwallet is in absoltely no way a replacement for accounts, and for the application of accounts multiwallet is tremendously worse.
2522018-07-13T17:07:28  <gmaxwell> Nor is multiwallet intended to be a replacement for accounts.
2532018-07-13T17:07:55  <gmaxwell> The replacement for accounts is managing them in your own front end accounting database... which can be made durable and scalable.
2542018-07-13T17:09:25  <gmaxwell> StayCool: as far as what satoshi thinks, I think it's quite likely that he'd agree now that we can't manage the complexity of the software by craming in every additional piece of functionality that could be done just as well (or better) outside of the software.  But if he didn't? Who cares? Lots of people disagree about this or that here and there.
2552018-07-13T17:11:18  <gmaxwell> luke-jr: I don't agree with your addresses comment above. Addresses are highly useful ways to identify txouts. It doesn't 'mix up addresses and keys' -- it lets you query by "give me the txouts that were sent to this particular address" which is highly useful, since the address is likely the only identifying mark that the user has previously seen for whatever set of txouts they're aware of.
2562018-07-13T17:12:18  <gmaxwell> provoostenator: to be clear, accounts never kept funds seperate, nor were they intended to.  They accounted for different attribution for funds while not keeping them seperate.
2572018-07-13T17:15:18  <luke-jr> gmaxwell: txouts aren't sent to addresses; bitcoins are. the txouts created don't get associated with the address
2582018-07-13T17:16:15  <luke-jr> it's an important distinction, because otherwise you get people thinking the validity of a UTXO means the person who received at that address owns those funds
2592018-07-13T17:17:27  <gmaxwell> touts are spendable by a specific scriptpubkey, which an address encodes. It's written write into them.
2602018-07-13T17:18:08  <luke-jr> an address is an opaque abstraction; that it is implemented by encoding a scriptpubkey is a technical detail unrelated to the address itself
2612018-07-13T17:18:47  <gmaxwell> You're just wasting people's time arguing that scanning shouldn't match by address. Thats 99.9% of the utility of it for me and many others.  People are not going to go "gee luke, you're right. I guess we'll handicap this feature to make it useless to us even personally then merge it anyways"
2622018-07-13T17:19:06  <gmaxwell> Moreover, consistency with listunspent demands it.
2632018-07-13T17:19:34  <luke-jr> if listunspent has such a bug, that should get fixed. UTXOs and addresses do not mix, or you end up with "send from", "address balance" and similar nonsense
2642018-07-13T17:20:35  <gmaxwell> "send from" is a bit of confusion about the properties of the spending transaction, not properties of the txouts.
2652018-07-13T17:20:52  <luke-jr> the spending transaction is spending txouts
2662018-07-13T17:21:26  <gmaxwell> touts identified by txid:vout, not by address.
2672018-07-13T17:21:53  <luke-jr> UTXOs are identified by txid:vout, not by address.
2682018-07-13T17:22:09  *** Randolf has quit IRC
2692018-07-13T17:22:11  <gmaxwell> I'm all for avoiding confusing functionality that isn't important. But without the ability to match by address this scanning stuff (as well as listunspent) would be almost useless.
2702018-07-13T17:22:33  <gmaxwell> luke-jr: indeed, they are not, if they were identified by address you wouldn't need a scan function to go from address to identifier!
2712018-07-13T17:23:33  <gmaxwell> The purpose of a scan function is to go from a non-identifying property about something to the identifier(s).
2722018-07-13T17:25:58  <instagibbs> Empact_, I'm seeing a number of "move only" PRs, now I'm unsure of the definition of move only.
2732018-07-13T17:26:09  <luke-jr> if address was a property of UTXOs, then addresses would have balances, and addresses would send coins
2742018-07-13T17:26:24  <instagibbs> Your PRs are encapsulating and de-duplicating behavior, to me that's not move only, but maybe I have my personal biases on the meaning
2752018-07-13T17:26:45  <bitcoin-git> [bitcoin] laanwj closed pull request #13618: Typos in the install script (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13618
2762018-07-13T17:26:50  * instagibbs throwing this question into the open. see #13651 for example
2772018-07-13T17:26:52  <gribble> https://github.com/bitcoin/bitcoin/issues/13651 | [moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe by Empact · Pull Request #13651 · bitcoin/bitcoin · GitHub
2782018-07-13T17:28:18  <gmaxwell> That isn't moveonly as I understood it.
2792018-07-13T17:28:57  <luke-jr> MarcoFalke: re https://github.com/bitcoin/bitcoin/pull/13644#issuecomment-404896710 , I don't see them?
2802018-07-13T17:29:26  <luke-jr> oh, maybe prior to that PR
2812018-07-13T17:29:53  <Lauda> Is it possible that txindex building is doing too many operations? According to linux mint system monitor it did: read total 3.0 TiB, write total 276.6 GiB
2822018-07-13T17:30:10  <Lauda> Seems excessive, and I compared to the network traffic (insignificant in comparison) so it isnt block serving
2832018-07-13T17:32:52  *** Murch has quit IRC
2842018-07-13T17:34:09  *** jagg_fab has joined #bitcoin-core-dev
2852018-07-13T17:34:50  *** Murch has joined #bitcoin-core-dev
2862018-07-13T17:36:05  *** jaggfabulous has quit IRC
2872018-07-13T17:42:52  *** frog_ has joined #bitcoin-core-dev
2882018-07-13T17:43:54  <sipa> Lauda: no, validation is very heavy in i/o; it should go down with large dbcache
2892018-07-13T17:44:22  <Lauda> this was with ~5-6GB being used by qt
2902018-07-13T17:44:54  <Lauda> did anyone ever benchmark something like this? If so, I'd like to take a look :)
2912018-07-13T17:45:38  *** frog_ has quit IRC
2922018-07-13T17:50:11  <sipa> StayCool: the biggest issue with accounts is that it effectively requires you to make a backup after every address you generate
2932018-07-13T17:50:50  <sipa> StayCool: plus 99% of people assume they work like multiple wallets, and that acxounts represent sets of UTXO (instead of being bean counters internal to a wallet)
2942018-07-13T17:52:15  <gmaxwell> Not just after every address you generate, but also backup concurrently with sending funds-- e.g. any time you spend in an account you'd need to backup before broadcasting the transaction.
2952018-07-13T17:53:46  <sipa> luke-jr: of course "balance of an address" is a technically meaningful and consistent thing to define
2962018-07-13T17:53:58  <sipa> luke-jr: every output has an associated locking script
2972018-07-13T17:54:17  <sipa> an address is a shorthand way to write some (most) locking scripts
2982018-07-13T17:55:00  <sipa> that doesn't mean balance of an address is a useful abstraction to show users; you're very correct that it is confusing to people
2992018-07-13T17:55:13  *** eavesdropper has joined #bitcoin-core-dev
3002018-07-13T17:55:55  <sipa> however, scantxoutset is an RPC that inherently breaks that abstraction - it exposes the user to a lower level view than a wallet
3012018-07-13T17:56:09  *** drexl has quit IRC
3022018-07-13T17:56:14  <sipa> just like listunspent, createrawtransacrion, gettxoutsetinfo, ...
3032018-07-13T17:56:59  <sipa> i don't think there is a risk for confusion there; you can't use the RPC unless you already understand that internally wallets are backed by sets of unspent outputs
3042018-07-13T17:57:09  *** drexl has joined #bitcoin-core-dev
3052018-07-13T17:59:10  <sipa> i would be opposed to a getaddressbalance RPC that reported the sum of the values in all unspent utxos with a locking script that corresponds to a given UTXO
3062018-07-13T17:59:46  <sipa> but scantxoutset doesn't do that; it gives the actual UTXOs
3072018-07-13T18:01:10  <sipa> luke-jr: another principle perhaps is that you shouldn't try to guess what address a txout was sent to by looking at its script; but given address you can always convert it to a script and see what matches
3082018-07-13T18:01:24  <sipa> (the "stealth address test")
3092018-07-13T18:03:02  *** timothy has quit IRC
3102018-07-13T18:06:51  *** zautomata has joined #bitcoin-core-dev
3112018-07-13T18:06:56  *** zautomata has joined #bitcoin-core-dev
3122018-07-13T18:06:57  *** StayCool has quit IRC
3132018-07-13T18:07:29  *** veleiro has quit IRC
3142018-07-13T18:07:59  *** veleiro has joined #bitcoin-core-dev
3152018-07-13T18:08:18  <gmaxwell> reminder #13298 needs acks
3162018-07-13T18:08:21  <gribble> https://github.com/bitcoin/bitcoin/issues/13298 | Net: Random delays *per network group* to obfuscate transaction time by naumenkogs · Pull Request #13298 · bitcoin/bitcoin · GitHub
3172018-07-13T18:15:16  <bitcoin-git> [bitcoin] Empact closed pull request #13619: Include cstring alongside select in compat/glib_sanity.cpp (master...glib-sanity) https://github.com/bitcoin/bitcoin/pull/13619
3182018-07-13T18:24:15  *** rafalcpp has quit IRC
3192018-07-13T19:00:58  *** veleiro has quit IRC
3202018-07-13T19:05:42  *** veleiro has joined #bitcoin-core-dev
3212018-07-13T19:06:20  *** jamesob_ has quit IRC
3222018-07-13T19:17:35  <jonasschnelli> Windows Gitian Build seems to be broken: https://bitcoin.jonasschnelli.ch/build/687
3232018-07-13T19:17:42  <jonasschnelli> qwin10helpers.cpp:60:37: fatal error: uiviewsettingsinterop.h: No such file or directory
3242018-07-13T19:17:42  <jonasschnelli>  #  include <uiviewsettingsinterop.h>
3252018-07-13T19:18:18  <cfields> jonasschnelli: see #13171
3262018-07-13T19:18:21  <gribble> https://github.com/bitcoin/bitcoin/issues/13171 | Change gitian-descriptors to use bionic instead by ken2812221 · Pull Request #13171 · bitcoin/bitcoin · GitHubAsset 1Asset 1
3272018-07-13T19:18:34  <jonasschnelli> cfields: thanks!
3282018-07-13T19:18:56  <jonasschnelli> I'll try to test this
3292018-07-13T19:19:00  <cfields> jonasschnelli: might want to hold off on trying to build though, things are still a bit bumpy
3302018-07-13T19:19:19  <jonasschnelli> okay... thanks.. I'll wait then
3312018-07-13T19:19:37  <cfields> at the very lest, there are some changes needed to gitian
3322018-07-13T19:20:14  <cfields> oh, the main one was merged already.
3332018-07-13T19:20:28  <cfields> at the very least, need to update your gitian :)
3342018-07-13T19:33:39  *** hirish has quit IRC
3352018-07-13T19:33:53  *** hirish has joined #bitcoin-core-dev
3362018-07-13T19:34:05  *** farmerwampum has joined #bitcoin-core-dev
3372018-07-13T19:35:16  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ea7eb62b21a...619cd29393b6
3382018-07-13T19:35:17  <bitcoin-git> bitcoin/master 3c292cc Gregory Sanders: ScanforWalletTransactions should mark input txns as dirty
3392018-07-13T19:35:17  <bitcoin-git> bitcoin/master 619cd29 Jonas Schnelli: Merge #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty...
3402018-07-13T19:35:46  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty (master...scandirty) https://github.com/bitcoin/bitcoin/pull/12944
3412018-07-13T19:37:13  *** farmerwampum_ has joined #bitcoin-core-dev
3422018-07-13T19:38:44  *** farmerwampum has quit IRC
3432018-07-13T19:38:45  *** farmerwampum_ is now known as farmerwampum
3442018-07-13T19:43:26  *** SopaXorzTaker has quit IRC
3452018-07-13T19:47:25  *** zautomata has quit IRC
3462018-07-13T19:57:18  *** Krellan has joined #bitcoin-core-dev
3472018-07-13T19:57:53  *** TechnikPTO has joined #bitcoin-core-dev
3482018-07-13T19:58:50  <TechnikPTO> hi all
3492018-07-13T19:59:29  <TechnikPTO> im looking for documentation for source code of bitcoin core
3502018-07-13T20:00:25  *** veleiro` has joined #bitcoin-core-dev
3512018-07-13T20:00:52  *** hashist has left #bitcoin-core-dev
3522018-07-13T20:01:57  *** veleiro has quit IRC
3532018-07-13T20:05:11  *** Tralfaz has joined #bitcoin-core-dev
3542018-07-13T20:06:46  *** Murch has quit IRC
3552018-07-13T20:10:02  *** TechnikPTO has quit IRC
3562018-07-13T20:10:34  *** keymone has joined #bitcoin-core-dev
3572018-07-13T20:14:48  *** Murch has joined #bitcoin-core-dev
3582018-07-13T20:21:44  *** zautomata has joined #bitcoin-core-dev
3592018-07-13T20:21:51  *** zautomata has joined #bitcoin-core-dev
3602018-07-13T20:23:22  *** Murch has quit IRC
3612018-07-13T20:34:23  *** Murch has joined #bitcoin-core-dev
3622018-07-13T20:34:29  *** Murch has quit IRC
3632018-07-13T20:35:29  *** Murch has joined #bitcoin-core-dev
3642018-07-13T20:35:46  *** promag has joined #bitcoin-core-dev
3652018-07-13T20:48:33  <bitcoin-git> [bitcoin] theuni opened pull request #13659: build: add missing leveldb defines (master...solaris-build) https://github.com/bitcoin/bitcoin/pull/13659
3662018-07-13T20:56:27  *** promag has quit IRC
3672018-07-13T21:04:05  *** veleiro` has quit IRC
3682018-07-13T21:04:41  *** veleiro` has joined #bitcoin-core-dev
3692018-07-13T21:08:34  *** jamesob_ has joined #bitcoin-core-dev
3702018-07-13T21:10:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/619cd29393b6...8f1106da5849
3712018-07-13T21:10:29  <bitcoin-git> bitcoin/master eeeef80 MarcoFalke: qa: Fix some TODOs in p2p_segwit
3722018-07-13T21:10:29  <bitcoin-git> bitcoin/master 8f1106d MarcoFalke: Merge #13626: qa: Fix some TODOs in p2p_segwit...
3732018-07-13T21:11:20  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13626: qa: Fix some TODOs in p2p_segwit (master...Mf1807-qaSegwitTodos) https://github.com/bitcoin/bitcoin/pull/13626
3742018-07-13T21:18:42  *** Guyver2 has quit IRC
3752018-07-13T21:26:39  *** drexl_ has joined #bitcoin-core-dev
3762018-07-13T21:26:52  *** tryphe_000 has joined #bitcoin-core-dev
3772018-07-13T21:27:16  *** drexl has quit IRC
3782018-07-13T21:27:21  *** drexl_ is now known as drexl
3792018-07-13T21:29:27  *** grafcaps has quit IRC
3802018-07-13T21:29:58  *** tryphe_ has quit IRC
3812018-07-13T21:29:59  *** BGL has quit IRC
3822018-07-13T21:34:41  *** mistergold has joined #bitcoin-core-dev
3832018-07-13T21:37:14  *** JackH has joined #bitcoin-core-dev
3842018-07-13T21:37:14  *** Victorsueca has quit IRC
3852018-07-13T21:38:26  *** Victorsueca has joined #bitcoin-core-dev
3862018-07-13T21:39:58  *** jagg_fab has quit IRC
3872018-07-13T21:43:01  *** ken2812221 has joined #bitcoin-core-dev
3882018-07-13T21:55:05  *** Dizzle has joined #bitcoin-core-dev
3892018-07-13T21:55:52  *** tryphe_000 is now known as tryphe
3902018-07-13T21:59:49  *** Giszmo has joined #bitcoin-core-dev
3912018-07-13T22:38:56  *** jamesob_ has quit IRC
3922018-07-13T22:46:28  *** nmnkgl has joined #bitcoin-core-dev
3932018-07-13T22:51:39  *** zautomata has quit IRC
3942018-07-13T22:52:41  *** zautomata has joined #bitcoin-core-dev
3952018-07-13T22:58:21  *** veleiro` has quit IRC
3962018-07-13T23:00:23  *** Giszmo has quit IRC
3972018-07-13T23:09:34  *** BGL has joined #bitcoin-core-dev
3982018-07-13T23:15:05  *** Giszmo has joined #bitcoin-core-dev
3992018-07-13T23:26:58  *** ken2812221 has quit IRC
4002018-07-13T23:27:06  *** ken2812221_ has joined #bitcoin-core-dev
4012018-07-13T23:33:45  *** mistergold has quit IRC
4022018-07-13T23:33:49  *** Dizzle has quit IRC
4032018-07-13T23:46:12  *** ToURniQue has joined #bitcoin-core-dev
4042018-07-13T23:50:57  *** ken2812221_ has quit IRC
4052018-07-13T23:57:47  *** Tralfaz has quit IRC