12018-07-20T00:00:27 *** adam3us has quit IRC
22018-07-20T00:02:56 *** revstrangehope has quit IRC
32018-07-20T00:02:56 *** chjj has quit IRC
42018-07-20T00:03:19 *** Chris_Stewart_5 has quit IRC
52018-07-20T00:06:33 *** Magma has quit IRC
62018-07-20T00:06:35 *** joshb[m] has quit IRC
72018-07-20T00:06:58 *** justanotheruser has quit IRC
82018-07-20T00:06:58 *** brianhoffman has quit IRC
92018-07-20T00:06:58 *** wumpus has quit IRC
102018-07-20T00:06:58 *** Urgo has quit IRC
112018-07-20T00:06:58 *** |EHG| has quit IRC
122018-07-20T00:06:58 *** tylevine has quit IRC
132018-07-20T00:06:58 *** keymone has quit IRC
142018-07-20T00:06:58 *** DougieBot5000 has quit IRC
152018-07-20T00:06:58 *** davec has quit IRC
162018-07-20T00:06:58 *** treyzania has quit IRC
172018-07-20T00:06:58 *** Cory has quit IRC
182018-07-20T00:06:59 *** michagogo has quit IRC
192018-07-20T00:06:59 *** dongcarl has quit IRC
202018-07-20T00:06:59 *** cornfeedhobo has quit IRC
212018-07-20T00:07:12 *** rev_strangehope has joined #bitcoin-core-dev
222018-07-20T00:07:21 *** chjj has joined #bitcoin-core-dev
232018-07-20T00:08:04 *** adam3us has joined #bitcoin-core-dev
242018-07-20T00:10:28 *** stepa[m] has quit IRC
252018-07-20T00:10:30 *** squarfed[m] has quit IRC
262018-07-20T00:10:37 *** herzmeister[m] has quit IRC
272018-07-20T00:10:56 *** warren has quit IRC
282018-07-20T00:11:11 *** ajtowns[m] has quit IRC
292018-07-20T00:11:11 *** kewde[m] has quit IRC
302018-07-20T00:12:47 *** adam3us has quit IRC
312018-07-20T00:15:03 *** Magma has joined #bitcoin-core-dev
322018-07-20T00:15:42 *** justanotheruser has joined #bitcoin-core-dev
332018-07-20T00:15:42 *** brianhoffman has joined #bitcoin-core-dev
342018-07-20T00:15:42 *** wumpus has joined #bitcoin-core-dev
352018-07-20T00:15:42 *** Urgo has joined #bitcoin-core-dev
362018-07-20T00:15:42 *** |EHG| has joined #bitcoin-core-dev
372018-07-20T00:15:42 *** tylevine has joined #bitcoin-core-dev
382018-07-20T00:15:42 *** keymone has joined #bitcoin-core-dev
392018-07-20T00:15:42 *** DougieBot5000 has joined #bitcoin-core-dev
402018-07-20T00:15:42 *** davec has joined #bitcoin-core-dev
412018-07-20T00:15:42 *** treyzania has joined #bitcoin-core-dev
422018-07-20T00:15:42 *** Cory has joined #bitcoin-core-dev
432018-07-20T00:15:42 *** cornfeedhobo has joined #bitcoin-core-dev
442018-07-20T00:15:42 *** michagogo has joined #bitcoin-core-dev
452018-07-20T00:15:42 *** dongcarl has joined #bitcoin-core-dev
462018-07-20T00:15:55 *** justanotheruser has quit IRC
472018-07-20T00:16:21 *** warren has joined #bitcoin-core-dev
482018-07-20T00:17:02 *** adam3us has joined #bitcoin-core-dev
492018-07-20T00:18:59 *** justanotheruser has joined #bitcoin-core-dev
502018-07-20T00:46:25 *** Chris_Stewart_5 has joined #bitcoin-core-dev
512018-07-20T00:47:35 *** joshb[m] has joined #bitcoin-core-dev
522018-07-20T01:08:52 *** Victorsueca has quit IRC
532018-07-20T01:09:35 *** grafcaps has quit IRC
542018-07-20T01:10:07 *** Victorsueca has joined #bitcoin-core-dev
552018-07-20T01:12:57 *** jamesob__ has quit IRC
562018-07-20T01:13:57 *** jamesob_ has quit IRC
572018-07-20T01:14:00 *** Guest26115 has quit IRC
582018-07-20T01:14:26 *** promag has quit IRC
592018-07-20T01:26:05 *** grafcaps has joined #bitcoin-core-dev
602018-07-20T01:34:22 *** grafcaps has quit IRC
612018-07-20T01:39:50 *** unixb0y has quit IRC
622018-07-20T01:44:02 *** unixb0y has joined #bitcoin-core-dev
632018-07-20T01:49:40 *** stepa[m] has joined #bitcoin-core-dev
642018-07-20T01:49:41 *** squarfed[m] has joined #bitcoin-core-dev
652018-07-20T01:49:41 *** ajtowns[m] has joined #bitcoin-core-dev
662018-07-20T01:49:42 *** herzmeister[m] has joined #bitcoin-core-dev
672018-07-20T01:49:45 *** kewde[m] has joined #bitcoin-core-dev
682018-07-20T01:56:38 *** jpe_ has joined #bitcoin-core-dev
692018-07-20T01:58:07 *** grafcaps has joined #bitcoin-core-dev
702018-07-20T02:00:42 *** jpe__ has quit IRC
712018-07-20T02:06:48 <bitcoin-git> [bitcoin] achow101 opened pull request #13721: Bugfixes for BIP 174 combining and deserialization (master...psbt-fixes) https://github.com/bitcoin/bitcoin/pull/13721
722018-07-20T02:12:55 *** Squidicuz has joined #bitcoin-core-dev
732018-07-20T02:20:46 *** ken2812221__ has joined #bitcoin-core-dev
742018-07-20T02:23:51 *** ken2812221_ has quit IRC
752018-07-20T02:34:05 *** Krellan has quit IRC
762018-07-20T02:39:47 *** Chris_Stewart_5 has quit IRC
772018-07-20T02:46:29 *** ken2812221__ is now known as ken2812221
782018-07-20T02:51:30 *** ken2812221 has quit IRC
792018-07-20T02:57:10 *** hendrik__ has joined #bitcoin-core-dev
802018-07-20T03:00:40 *** hendrik_ has quit IRC
812018-07-20T03:06:52 *** ken2812221 has joined #bitcoin-core-dev
822018-07-20T03:12:04 *** polydin has joined #bitcoin-core-dev
832018-07-20T03:25:26 *** grafcaps has quit IRC
842018-07-20T03:52:33 <kallewoof> I'm torn on https://github.com/bitcoin/bitcoin/pull/12257#discussion_r203741762 -- on the one hand, we want to give correct values for ancestor count; on the other hand, the reason ancestor count is taken into account is because we want to avoid too-long chains of unconfirmed transactions, which is separate. on the third (?) hand, the accurate ancestor count will give a hint at the number of ancestors the resulting transaction
852018-07-20T03:52:33 <kallewoof> will end up having, but on the fifth (!) hand, we want to give a rebate to eliminating multi-utxo-same-dest, and being too strict/accurate here might mean a lot of address reuse remains unspent indefinitely because it creates too many ancestors. in fact, the worse it gets (3,4,5 txs in same output group), the lower the chances the wallet will "fix" the issue.
862018-07-20T03:53:08 <kallewoof> I missed the forth hand. Alas.
872018-07-20T04:19:23 *** ken2812221 has quit IRC
882018-07-20T04:20:37 *** dqx_ has joined #bitcoin-core-dev
892018-07-20T04:24:07 *** booyah has joined #bitcoin-core-dev
902018-07-20T04:34:21 *** ken2812221 has joined #bitcoin-core-dev
912018-07-20T04:41:27 *** jtimon has quit IRC
922018-07-20T04:58:45 *** farmerwampum has quit IRC
932018-07-20T05:00:17 *** jtimon has joined #bitcoin-core-dev
942018-07-20T05:03:18 <jcorgan> kallewoof: "on the third (?) hand" <== "on the gripping hand" :-)
952018-07-20T05:04:36 <kallewoof> jcorgan: ohh..
962018-07-20T05:08:24 *** jtimon has quit IRC
972018-07-20T05:11:59 *** bitconner has quit IRC
982018-07-20T05:12:58 *** ken2812221 has quit IRC
992018-07-20T05:36:36 *** bitconner has joined #bitcoin-core-dev
1002018-07-20T05:40:57 *** bitconner has quit IRC
1012018-07-20T05:51:44 *** bitconner has joined #bitcoin-core-dev
1022018-07-20T06:09:37 *** RoBz has quit IRC
1032018-07-20T06:20:40 *** grafcaps has joined #bitcoin-core-dev
1042018-07-20T06:21:04 *** riemann_ has joined #bitcoin-core-dev
1052018-07-20T06:25:29 *** grafcaps has quit IRC
1062018-07-20T06:26:31 *** AHemlocksLie has quit IRC
1072018-07-20T06:28:34 *** riemann_ has quit IRC
1082018-07-20T06:37:34 *** ken2812221 has joined #bitcoin-core-dev
1092018-07-20T06:44:01 *** d9b4bef9 has quit IRC
1102018-07-20T06:52:44 <bitcoin-git> [bitcoin] hmel opened pull request #13722: [Trivial] Use variable name instead of relying on class layout (master...use_varname_not_this) https://github.com/bitcoin/bitcoin/pull/13722
1112018-07-20T06:56:52 <gmaxwell> kallewoof: keep in mind, usually most inputs in a wallet are confirmed and have an ancestor count of zero.
1122018-07-20T06:57:26 <gmaxwell> in general the count handling in selection is really just there to get slightly less bad behavior in pathalogical cases.
1132018-07-20T06:57:52 <gmaxwell> Probably if your wallet is running out of confirmed outputs, you'd prefer to no longer group them.
1142018-07-20T06:58:14 <gmaxwell> (or at least unless you've decided you'd rather not transact at all than reduce your privacy.)
1152018-07-20T06:58:32 <gmaxwell> but in that case you should probably be completely avoiding spending unconfirmed coins.
1162018-07-20T06:58:41 <kallewoof> gmaxwell: Yeah, that's a good point.
1172018-07-20T06:58:42 <gmaxwell> Since any spend of an unconfirmed output is bad for your privacy.
1182018-07-20T06:58:53 <gmaxwell> (since it means that coin was change)
1192018-07-20T07:14:32 *** ken2812221 has quit IRC
1202018-07-20T07:15:00 *** Amol has joined #bitcoin-core-dev
1212018-07-20T07:15:29 <bitcoin-git> [bitcoin] sipa opened pull request #13723: PSBT key path cleanups (master...201807_key_origin_provider) https://github.com/bitcoin/bitcoin/pull/13723
1222018-07-20T07:18:08 *** ken2812221 has joined #bitcoin-core-dev
1232018-07-20T07:19:27 *** Amol has quit IRC
1242018-07-20T07:27:22 *** timothy has joined #bitcoin-core-dev
1252018-07-20T07:28:09 *** hex17or has joined #bitcoin-core-dev
1262018-07-20T07:29:13 *** jpe__ has joined #bitcoin-core-dev
1272018-07-20T07:29:47 *** hex17or has quit IRC
1282018-07-20T07:32:26 *** polydin has quit IRC
1292018-07-20T07:32:27 *** jpe_ has quit IRC
1302018-07-20T07:38:57 <dcousens> is P2WSH(P2WPKH) possible?
1312018-07-20T07:47:34 *** polydin has joined #bitcoin-core-dev
1322018-07-20T07:51:29 *** ken2812221 has quit IRC
1332018-07-20T07:54:31 <sipa> dcousens: no
1342018-07-20T07:54:41 <sipa> dcousens: consensus invalid
1352018-07-20T07:55:20 <sipa> or rather, it would be treated as just OP_0 <keyhash>
1362018-07-20T07:56:15 *** SopaXorzTaker has joined #bitcoin-core-dev
1372018-07-20T07:57:12 <dcousens> ok! cool, that would explain it
1382018-07-20T07:57:31 <dcousens> (was receiving Error: 64: non-mandatory-script-verify-flag (Script evaluated without error but finished with a false/empty top stack element))
1392018-07-20T08:01:01 *** SopaXorzTaker has quit IRC
1402018-07-20T08:01:42 *** hendrik_ has joined #bitcoin-core-dev
1412018-07-20T08:05:35 *** hendrik__ has quit IRC
1422018-07-20T08:08:50 *** grafcaps has joined #bitcoin-core-dev
1432018-07-20T08:09:21 *** setpill has joined #bitcoin-core-dev
1442018-07-20T08:09:31 <sipa> dcousens: ah yes, consensus invalid due to the cleanstack rule
1452018-07-20T08:09:44 *** ken2812221 has joined #bitcoin-core-dev
1462018-07-20T08:13:34 *** grafcaps has quit IRC
1472018-07-20T08:16:05 *** setpill has quit IRC
1482018-07-20T08:17:44 *** setpill has joined #bitcoin-core-dev
1492018-07-20T08:34:05 *** jcorgan has quit IRC
1502018-07-20T08:42:24 *** indistylo has joined #bitcoin-core-dev
1512018-07-20T08:46:27 *** ken2812221 has quit IRC
1522018-07-20T08:48:52 *** promag has joined #bitcoin-core-dev
1532018-07-20T08:50:30 *** ken2812221 has joined #bitcoin-core-dev
1542018-07-20T08:51:34 *** meshcollider_ has joined #bitcoin-core-dev
1552018-07-20T08:52:30 *** ken2812221 has quit IRC
1562018-07-20T08:52:51 *** ken2812221 has joined #bitcoin-core-dev
1572018-07-20T09:15:13 *** ken2812221 has quit IRC
1582018-07-20T09:22:10 *** ken2812221 has joined #bitcoin-core-dev
1592018-07-20T09:28:08 *** d9b4bef9 has joined #bitcoin-core-dev
1602018-07-20T09:31:08 *** Guyver2 has joined #bitcoin-core-dev
1612018-07-20T09:34:00 *** Deni_ has joined #bitcoin-core-dev
1622018-07-20T09:42:52 *** ajtowns[m] has quit IRC
1632018-07-20T09:42:52 *** herzmeister[m] has quit IRC
1642018-07-20T09:42:54 *** kewde[m] has quit IRC
1652018-07-20T09:42:59 *** stepa[m] has quit IRC
1662018-07-20T09:43:03 *** joshb[m] has quit IRC
1672018-07-20T09:43:03 *** squarfed[m] has quit IRC
1682018-07-20T09:43:04 *** Deni_ has quit IRC
1692018-07-20T09:45:29 *** rev_strangehope has quit IRC
1702018-07-20T09:48:18 *** joshb[m] has joined #bitcoin-core-dev
1712018-07-20T09:48:26 *** rev_strangehope has joined #bitcoin-core-dev
1722018-07-20T09:57:02 *** grafcaps has joined #bitcoin-core-dev
1732018-07-20T10:01:18 *** grafcaps has quit IRC
1742018-07-20T10:09:10 *** ajtowns[m] has joined #bitcoin-core-dev
1752018-07-20T10:09:11 *** herzmeister[m] has joined #bitcoin-core-dev
1762018-07-20T10:09:11 *** kewde[m] has joined #bitcoin-core-dev
1772018-07-20T10:09:14 *** squarfed[m] has joined #bitcoin-core-dev
1782018-07-20T10:09:14 *** stepa[m] has joined #bitcoin-core-dev
1792018-07-20T10:11:02 *** setpill has quit IRC
1802018-07-20T10:12:32 *** setpill has joined #bitcoin-core-dev
1812018-07-20T10:14:02 *** jamesob_ has joined #bitcoin-core-dev
1822018-07-20T10:14:06 *** jamesob__ has joined #bitcoin-core-dev
1832018-07-20T10:21:57 *** SopaXorzTaker has joined #bitcoin-core-dev
1842018-07-20T10:24:14 *** farmerwampum has joined #bitcoin-core-dev
1852018-07-20T10:28:13 *** farmerwampum has quit IRC
1862018-07-20T10:28:31 *** farmerwampum has joined #bitcoin-core-dev
1872018-07-20T10:42:13 *** ken2812221_ has joined #bitcoin-core-dev
1882018-07-20T10:44:24 *** ken2812221 has quit IRC
1892018-07-20T10:46:35 *** ken2812221__ has joined #bitcoin-core-dev
1902018-07-20T10:50:20 *** ken2812221_ has quit IRC
1912018-07-20T10:53:35 *** ken2812221__ has quit IRC
1922018-07-20T10:54:05 *** ken2812221 has joined #bitcoin-core-dev
1932018-07-20T10:56:48 *** promag_ has joined #bitcoin-core-dev
1942018-07-20T10:56:48 *** promag has quit IRC
1952018-07-20T11:10:25 *** meshcollider_ has quit IRC
1962018-07-20T11:13:24 *** aruns__ has joined #bitcoin-core-dev
1972018-07-20T11:16:54 *** indistylo has quit IRC
1982018-07-20T11:17:37 *** indistylo has joined #bitcoin-core-dev
1992018-07-20T11:18:22 *** aruns__ has quit IRC
2002018-07-20T11:19:40 *** SopaXorzTaker has quit IRC
2012018-07-20T11:20:06 *** SopaXorzTaker has joined #bitcoin-core-dev
2022018-07-20T11:28:49 *** aruns__ has joined #bitcoin-core-dev
2032018-07-20T11:31:34 *** indistylo has quit IRC
2042018-07-20T11:32:30 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2052018-07-20T11:36:42 *** setpill has quit IRC
2062018-07-20T11:38:38 *** jamesob__ has quit IRC
2072018-07-20T11:38:39 *** jamesob_ has quit IRC
2082018-07-20T11:40:31 *** setpill has joined #bitcoin-core-dev
2092018-07-20T11:50:14 *** ExtraCrispy has joined #bitcoin-core-dev
2102018-07-20T11:52:05 *** aruns__ has quit IRC
2112018-07-20T11:52:40 *** promag_ has quit IRC
2122018-07-20T11:54:51 *** indistylo has joined #bitcoin-core-dev
2132018-07-20T11:55:10 *** dqx_ has quit IRC
2142018-07-20T12:19:57 *** niska has quit IRC
2152018-07-20T12:25:16 *** niska has joined #bitcoin-core-dev
2162018-07-20T12:27:07 *** Chris_Stewart_5 has quit IRC
2172018-07-20T12:27:32 *** bitconner has quit IRC
2182018-07-20T12:29:23 <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/aba2e666d7fd...6b6e854362bc
2192018-07-20T12:29:24 <bitcoin-git> bitcoin/master 9995a60 Jonas Schnelli: Add facility to store wallet flags (64 bits)
2202018-07-20T12:29:25 <bitcoin-git> bitcoin/master cebefba Jonas Schnelli: Add option to disable private keys during internal wallet creation
2212018-07-20T12:29:25 <bitcoin-git> bitcoin/master 2f15c2b Jonas Schnelli: Add disable privatekeys option to createwallet
2222018-07-20T12:41:19 *** bitconner has joined #bitcoin-core-dev
2232018-07-20T12:44:51 *** dqx_ has joined #bitcoin-core-dev
2242018-07-20T12:46:11 *** bitconner has quit IRC
2252018-07-20T12:54:54 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/08ca3144104a...2848aa808fde
2262018-07-20T12:54:54 <bitcoin-git> bitcoin/0.16 0296b9c MarcoFalke: 0.16.2: Bump manpages
2272018-07-20T12:54:55 <bitcoin-git> bitcoin/0.16 2848aa8 Wladimir J. van der Laan: Merge #13703: 0.16.2: [doc] Bump manpages...
2282018-07-20T13:00:22 *** dqx_ has quit IRC
2292018-07-20T13:04:28 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6b6e854362bc...f7f574d453bf
2302018-07-20T13:04:29 <bitcoin-git> bitcoin/master b1b8863 Mason Simon: docs: Specify preferred Python string formatting technique
2312018-07-20T13:04:29 <bitcoin-git> bitcoin/master f7f574d MarcoFalke: Merge #13718: docs: Specify preferred Python string formatting technique...
2322018-07-20T13:05:19 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13718: docs: Specify preferred Python string formatting technique (master...python-string-format-guideline) https://github.com/bitcoin/bitcoin/pull/13718
2332018-07-20T13:07:58 *** dqx_ has joined #bitcoin-core-dev
2342018-07-20T13:08:26 *** jtimon has joined #bitcoin-core-dev
2352018-07-20T13:14:21 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f7f574d453bf...c575260f80e9
2362018-07-20T13:14:22 <bitcoin-git> bitcoin/master fa4bf92 MarcoFalke: Remove dead service bits code
2372018-07-20T13:14:22 <bitcoin-git> bitcoin/master c575260 Wladimir J. van der Laan: Merge #11637: p2p: Remove dead service bits code...
2382018-07-20T13:14:37 <bitcoin-git> [bitcoin] laanwj closed pull request #11637: p2p: Remove dead service bits code (master...Mf1711-p2pDead) https://github.com/bitcoin/bitcoin/pull/11637
2392018-07-20T13:17:20 *** bitconner has joined #bitcoin-core-dev
2402018-07-20T13:18:56 *** Victorsueca has quit IRC
2412018-07-20T13:20:08 *** Victorsueca has joined #bitcoin-core-dev
2422018-07-20T13:22:08 *** bitconner has quit IRC
2432018-07-20T13:22:47 *** dqx_ has quit IRC
2442018-07-20T13:23:03 *** setpill has quit IRC
2452018-07-20T13:25:10 *** dqx_ has joined #bitcoin-core-dev
2462018-07-20T13:25:51 *** frog_ has joined #bitcoin-core-dev
2472018-07-20T13:31:42 *** frog_ has quit IRC
2482018-07-20T13:33:17 *** grafcaps has joined #bitcoin-core-dev
2492018-07-20T13:36:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2502018-07-20T13:37:39 *** grafcaps has quit IRC
2512018-07-20T13:37:41 <bitcoin-git> [bitcoin] ken2812221 opened pull request #13724: [contrib] Support ARM and RISC-V symbol check (master...symbol-check-all) https://github.com/bitcoin/bitcoin/pull/13724
2522018-07-20T13:40:02 *** promag has joined #bitcoin-core-dev
2532018-07-20T13:41:44 *** dqx_ has quit IRC
2542018-07-20T13:43:33 *** bitconner has joined #bitcoin-core-dev
2552018-07-20T13:43:53 *** dqx_ has joined #bitcoin-core-dev
2562018-07-20T13:48:53 *** bitconner has quit IRC
2572018-07-20T13:49:02 *** d9b4bef9 has quit IRC
2582018-07-20T13:50:07 *** d9b4bef9 has joined #bitcoin-core-dev
2592018-07-20T13:55:56 *** dqx_ has quit IRC
2602018-07-20T13:58:31 *** dqx_ has joined #bitcoin-core-dev
2612018-07-20T13:58:45 *** str4d has joined #bitcoin-core-dev
2622018-07-20T14:04:01 *** SopaXT has joined #bitcoin-core-dev
2632018-07-20T14:05:17 *** dqx_ has quit IRC
2642018-07-20T14:05:38 *** frog_ has joined #bitcoin-core-dev
2652018-07-20T14:06:31 *** SopaXorzTaker has quit IRC
2662018-07-20T14:12:41 *** frog_ has quit IRC
2672018-07-20T14:18:02 *** dqx_ has joined #bitcoin-core-dev
2682018-07-20T14:18:24 *** frog_ has joined #bitcoin-core-dev
2692018-07-20T14:19:45 *** jpe has joined #bitcoin-core-dev
2702018-07-20T14:21:23 *** jpe__ has quit IRC
2712018-07-20T14:22:45 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c575260f80e9...dcc0cffbcf51
2722018-07-20T14:22:45 <bitcoin-git> bitcoin/master 5c613aa Ben Woosley: lint: Add linter for circular dependencies...
2732018-07-20T14:22:46 <bitcoin-git> bitcoin/master dcc0cff Wladimir J. van der Laan: Merge #13695: lint: Add linter for circular dependencies...
2742018-07-20T14:23:49 <bitcoin-git> [bitcoin] laanwj closed pull request #13695: lint: Add linter for circular dependencies (master...circ-lint) https://github.com/bitcoin/bitcoin/pull/13695
2752018-07-20T14:25:27 *** AaronvanW has joined #bitcoin-core-dev
2762018-07-20T14:27:53 *** Aaronvan_ has joined #bitcoin-core-dev
2772018-07-20T14:31:11 *** AaronvanW has quit IRC
2782018-07-20T14:45:10 *** rockhouse has quit IRC
2792018-07-20T14:45:11 *** victorSN has quit IRC
2802018-07-20T14:45:54 *** str4d has quit IRC
2812018-07-20T14:46:18 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/dcc0cffbcf51...2dc5ab637803
2822018-07-20T14:46:19 <bitcoin-git> bitcoin/master 11588c6 Chun Kuan Lee: Replace boost program_options
2832018-07-20T14:46:19 <bitcoin-git> bitcoin/master f447a0a Chun Kuan Lee: Remove program options from build system
2842018-07-20T14:46:20 <bitcoin-git> bitcoin/master 2dc5ab6 Wladimir J. van der Laan: Merge #13482: Remove boost::program_options dependency...
2852018-07-20T14:47:06 <bitcoin-git> [bitcoin] laanwj closed pull request #13482: Remove boost::program_options dependency (master...program_options) https://github.com/bitcoin/bitcoin/pull/13482
2862018-07-20T14:47:48 *** rockhouse has joined #bitcoin-core-dev
2872018-07-20T14:47:51 *** victorSN has joined #bitcoin-core-dev
2882018-07-20T14:48:05 *** bitconner has joined #bitcoin-core-dev
2892018-07-20T14:49:33 *** rockhouse has quit IRC
2902018-07-20T14:49:33 *** rockhouse has joined #bitcoin-core-dev
2912018-07-20T14:52:05 *** dqx_ has quit IRC
2922018-07-20T14:55:38 *** victorSN has quit IRC
2932018-07-20T14:55:38 *** rockhouse has quit IRC
2942018-07-20T14:58:41 *** str4d has joined #bitcoin-core-dev
2952018-07-20T15:00:44 *** dqx_ has joined #bitcoin-core-dev
2962018-07-20T15:05:36 *** grafcaps has joined #bitcoin-core-dev
2972018-07-20T15:05:38 *** Aaronvan_ has quit IRC
2982018-07-20T15:06:13 *** AaronvanW has joined #bitcoin-core-dev
2992018-07-20T15:06:27 *** str4d has quit IRC
3002018-07-20T15:10:05 <Randolf> It's always good to see Boost disappearing.
3012018-07-20T15:10:39 *** AaronvanW has quit IRC
3022018-07-20T15:18:25 *** indistylo has quit IRC
3032018-07-20T15:18:57 *** dqx_ has quit IRC
3042018-07-20T15:20:12 *** grafcaps has quit IRC
3052018-07-20T15:22:14 *** dqx_ has joined #bitcoin-core-dev
3062018-07-20T15:25:41 <face> Why is getting rid of boost considered beneficial? Where can I read up on the discussion?
3072018-07-20T15:40:34 *** dongcarl has quit IRC
3082018-07-20T15:40:34 *** SopaXT has quit IRC
3092018-07-20T15:40:42 *** grafcaps has joined #bitcoin-core-dev
3102018-07-20T15:41:08 *** SopaXT has joined #bitcoin-core-dev
3112018-07-20T15:44:06 *** dongcarl has joined #bitcoin-core-dev
3122018-07-20T15:45:35 *** SopaXT has quit IRC
3132018-07-20T15:46:03 *** SopaXT has joined #bitcoin-core-dev
3142018-07-20T16:00:11 *** Victorsueca has quit IRC
3152018-07-20T16:01:37 *** Victorsueca has joined #bitcoin-core-dev
3162018-07-20T16:03:21 * rafalcpp finds it sad
3172018-07-20T16:03:34 <rafalcpp> other then that pure c++ is super portable
3182018-07-20T16:04:42 *** str4d has joined #bitcoin-core-dev
3192018-07-20T16:16:08 <promag> connect(verifyMessageAction, &QAction::triggered, this, &BitcoinGUI::gotoVerifyMessageTab);
3202018-07-20T16:16:10 <promag> vs
3212018-07-20T16:16:15 <promag> connect(verifyMessageAction, &QAction::triggered, [this]{ gotoVerifyMessageTab() });
3222018-07-20T16:16:51 <promag> any opinion?
3232018-07-20T16:19:38 <sipa> needs a semicolon before ;
3242018-07-20T16:19:43 <sipa> eh, before }
3252018-07-20T16:20:02 <promag> yap, other than that? :P
3262018-07-20T16:20:30 <promag> the 2nd has the advantage of supporting default arguments
3272018-07-20T16:20:57 <promag> if the slot declaration is gotoVerifyMessageTab(bool foo = false) for instance
3282018-07-20T16:21:21 <sipa> i believe the first one is more lightweight
3292018-07-20T16:21:31 <sipa> but i have no opinion either way
3302018-07-20T16:21:41 <promag> why more lightweight?
3312018-07-20T16:22:18 <promag> lightweight in compile time or runtime?
3322018-07-20T16:24:00 <promag> sipa: btw regarding output descriptor, do you think "old behaviour" should be in the grammar? or a call option?
3332018-07-20T16:24:35 *** SopaXT is now known as SopaXorzTaker
3342018-07-20T16:26:52 *** dqx_ has quit IRC
3352018-07-20T16:27:33 <sipa> promag: what is a call option?
3362018-07-20T16:29:08 <promag> sipa: a option to scantxoutset, like --compability=true or --behavior=old ..
3372018-07-20T16:30:16 <sipa> promag: oh this is not about scantxoutset
3382018-07-20T16:30:28 <sipa> promag: i want descriptors to be used for everything
3392018-07-20T16:30:35 <sipa> in particular, the wallet itself
3402018-07-20T16:31:47 <sipa> and in order.to convert existing wallets into a descriptor form, there should be a way of encoding "all the things we used to accept for one key", otherwise you need multiple descriptors even for simple things in the wallet
3412018-07-20T16:32:46 *** booyah has quit IRC
3422018-07-20T16:33:41 <promag> so in 100 years that old() descriptor must represent the same things
3432018-07-20T16:33:46 <sipa> but i also want to prevent having several dialects of the language; if it's supported in one place, it should be supported elsewhere (and for scantxoutset it seems useful too, actually)
3442018-07-20T16:33:50 <sipa> yes
3452018-07-20T16:34:34 *** RoBz has joined #bitcoin-core-dev
3462018-07-20T16:34:35 *** RoBz has joined #bitcoin-core-dev
3472018-07-20T16:35:02 <promag> still "old()" meaning is very unclear, specially in the future
3482018-07-20T16:35:35 <sipa> yes, "legacy" would be nice, but already has a different meanjng
3492018-07-20T16:35:53 <promag> even legacy is not explicit
3502018-07-20T16:36:17 <promag> pk_pkh_wpkh_shwpkh(...) :P
3512018-07-20T16:36:25 <sipa> yeah...
3522018-07-20T16:36:56 <promag> who cares? at least is clear
3532018-07-20T16:38:14 <sipa> old on an uncompressed key will just expand to pk and pkh
3542018-07-20T16:39:25 *** booyah has joined #bitcoin-core-dev
3552018-07-20T16:39:30 <promag> pk_pkh(uncompressed key)
3562018-07-20T16:39:58 <promag> I mean, the wallet knows how to export output descriptors
3572018-07-20T16:41:04 *** nullptr| has joined #bitcoin-core-dev
3582018-07-20T16:41:52 *** dqx_ has joined #bitcoin-core-dev
3592018-07-20T16:45:00 *** owowo has quit IRC
3602018-07-20T16:46:39 *** dqx_ has quit IRC
3612018-07-20T16:46:44 <sipa> promag: sounds a bit confusing, and make people wonder if why wpkh_wshpk or so wouldn't work
3622018-07-20T16:47:01 *** Dizzle has joined #bitcoin-core-dev
3632018-07-20T16:47:57 *** Emcy has quit IRC
3642018-07-20T16:48:01 *** grafcaps has quit IRC
3652018-07-20T16:48:49 *** veleiro has joined #bitcoin-core-dev
3662018-07-20T16:49:58 *** owowo has joined #bitcoin-core-dev
3672018-07-20T16:50:24 *** grafcaps has joined #bitcoin-core-dev
3682018-07-20T16:51:01 *** Emcy has joined #bitcoin-core-dev
3692018-07-20T16:51:05 <promag> sipa: right, on the other hand can't old() can be abused?
3702018-07-20T16:52:36 <sipa> promag: i don't like "old" :)
3712018-07-20T16:53:11 <promag> ditch it then
3722018-07-20T16:53:44 <promag> for scantxoutset, make the caller specify each one
3732018-07-20T16:54:25 <promag> "pk(uncompressed key)", "pkh(uncompressed key)"
3742018-07-20T16:55:15 *** dqx_ has joined #bitcoin-core-dev
3752018-07-20T16:55:57 <sipa> promag: as i said i don't want multiple dialects
3762018-07-20T16:57:17 *** str4d has quit IRC
3772018-07-20T16:59:01 <sipa> i think it's good to have support for "all the things old versions did with keys"
3782018-07-20T17:06:21 *** AaronvanW has joined #bitcoin-core-dev
3792018-07-20T17:12:53 *** dqx_ has quit IRC
3802018-07-20T17:13:53 *** ryanofsky_ has joined #bitcoin-core-dev
3812018-07-20T17:14:07 *** AaronvanW has quit IRC
3822018-07-20T17:14:25 *** harding has quit IRC
3832018-07-20T17:14:25 *** ryanofsky has quit IRC
3842018-07-20T17:14:43 *** AaronvanW has joined #bitcoin-core-dev
3852018-07-20T17:15:23 *** harding has joined #bitcoin-core-dev
3862018-07-20T17:19:23 *** AaronvanW has quit IRC
3872018-07-20T17:23:34 *** jb55 has joined #bitcoin-core-dev
3882018-07-20T17:29:14 *** Randolf has quit IRC
3892018-07-20T17:31:08 *** dqx_ has joined #bitcoin-core-dev
3902018-07-20T17:36:06 *** vicenteH has joined #bitcoin-core-dev
3912018-07-20T17:36:22 *** AaronvanW has joined #bitcoin-core-dev
3922018-07-20T17:38:29 *** MrPaz has joined #bitcoin-core-dev
3932018-07-20T17:40:59 <gmaxwell> sdaftuar: Do you (or someone else) have a realistic block creation workload benchmark to tell if this is a performance improvement? https://0bin.net/paste/zkrurel5frKrxmLW#xs8hKiKd4oVR0V2fC1vEEsmuScVCjh762UrB8kZL4G3
3942018-07-20T17:41:24 <gmaxwell> (I suppose it would be better to actually track the real minimum weight of any tx in the mempool, but this was simpler. :P )
3952018-07-20T17:45:56 *** luke-jr has quit IRC
3962018-07-20T17:46:18 *** luke-jr has joined #bitcoin-core-dev
3972018-07-20T17:47:35 *** veleiro has quit IRC
3982018-07-20T17:59:02 *** Emcy has quit IRC
3992018-07-20T18:00:52 *** tripleslash has joined #bitcoin-core-dev
4002018-07-20T18:02:14 *** e4xit has quit IRC
4012018-07-20T18:03:22 *** Emcy has joined #bitcoin-core-dev
4022018-07-20T18:06:57 *** dqx_ has quit IRC
4032018-07-20T18:12:37 *** grubles has quit IRC
4042018-07-20T18:13:18 *** AaronvanW has quit IRC
4052018-07-20T18:13:53 *** AaronvanW has joined #bitcoin-core-dev
4062018-07-20T18:15:44 *** dqx_ has joined #bitcoin-core-dev
4072018-07-20T18:17:06 *** grubles has joined #bitcoin-core-dev
4082018-07-20T18:18:15 *** AaronvanW has quit IRC
4092018-07-20T18:22:57 *** e4xit has joined #bitcoin-core-dev
4102018-07-20T18:27:16 <bitcoin-git> [bitcoin] Empact opened pull request #13725: Fix bitcoin-cli --version (master...fix-bitcoin-cli-version) https://github.com/bitcoin/bitcoin/pull/13725
4112018-07-20T18:28:41 *** SopaXT has joined #bitcoin-core-dev
4122018-07-20T18:31:32 *** SopaXorzTaker has quit IRC
4132018-07-20T18:34:20 *** frog_ has joined #bitcoin-core-dev
4142018-07-20T18:39:55 *** Victorsueca has quit IRC
4152018-07-20T18:41:08 *** Victorsueca has joined #bitcoin-core-dev
4162018-07-20T18:49:43 *** timothy has quit IRC
4172018-07-20T18:53:45 <bitcoin-git> [bitcoin] DrahtBot closed pull request #9719: Allow abort of ConnectBlock() when shutdown requested. (master...AbortConnectBlockAtShutdown) https://github.com/bitcoin/bitcoin/pull/9719
4182018-07-20T18:55:11 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #9719: Allow abort of ConnectBlock() when shutdown requested. (master...AbortConnectBlockAtShutdown) https://github.com/bitcoin/bitcoin/pull/9719
4192018-07-20T18:55:55 <sipa> MarcoFalke: what happened?
4202018-07-20T18:56:57 <bitcoin-git> [bitcoin] 251Labs opened pull request #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency (master...patch/remove_boost_join_dependency) https://github.com/bitcoin/bitcoin/pull/13726
4212018-07-20T19:05:21 *** delpa^ has quit IRC
4222018-07-20T19:18:26 *** csknk has joined #bitcoin-core-dev
4232018-07-20T19:20:39 *** SopaXT has quit IRC
4242018-07-20T19:21:52 <bitcoin-git> [bitcoin] DrahtBot reopened pull request #11194: fees: optimize decay (master...speedup-movingaverage) https://github.com/bitcoin/bitcoin/pull/11194
4252018-07-20T19:22:33 *** kerfle has joined #bitcoin-core-dev
4262018-07-20T19:37:59 <bitcoin-git> [bitcoin] spyder46n2 opened pull request #13727: MENY - Fix OS-X debug build (master...mney-fix-OSX-debug-build) https://github.com/bitcoin/bitcoin/pull/13727
4272018-07-20T19:40:14 <bitcoin-git> [bitcoin] spyder46n2 closed pull request #13727: MENY - Fix OS-X debug build (master...mney-fix-OSX-debug-build) https://github.com/bitcoin/bitcoin/pull/13727
4282018-07-20T19:44:28 *** drexl has joined #bitcoin-core-dev
4292018-07-20T19:54:05 <sdaftuar> gmaxwell: i think i have a way to benchmark, but my guess would be that it would have minimal impact, after the optimization we did in #9959
4302018-07-20T19:54:07 <gribble> https://github.com/bitcoin/bitcoin/issues/9959 | Mining: Prevent slowdown in CreateNewBlock on large mempools by sdaftuar · Pull Request #9959 · bitcoin/bitcoin · GitHub
4312018-07-20T19:55:37 <sdaftuar> i should probably benchmark again though, i haven't done any kind of performance runs on the mining code in a while
4322018-07-20T19:55:48 *** AaronvanW has joined #bitcoin-core-dev
4332018-07-20T19:56:14 *** csknk has quit IRC
4342018-07-20T19:56:45 *** laurentmt has joined #bitcoin-core-dev
4352018-07-20T19:59:09 *** dqx_ has quit IRC
4362018-07-20T20:01:25 *** dqx_ has joined #bitcoin-core-dev
4372018-07-20T20:04:06 *** drexl_ has joined #bitcoin-core-dev
4382018-07-20T20:06:57 *** drexl has quit IRC
4392018-07-20T20:07:00 *** drexl_ is now known as drexl
4402018-07-20T20:13:22 *** rockhouse has joined #bitcoin-core-dev
4412018-07-20T20:16:39 *** laurentmt has quit IRC
4422018-07-20T20:17:18 *** rockhouse has quit IRC
4432018-07-20T20:23:04 *** rockhouse has joined #bitcoin-core-dev
4442018-07-20T20:25:45 *** dqx_ has quit IRC
4452018-07-20T20:28:05 *** AaronvanW has quit IRC
4462018-07-20T20:29:01 *** dqx_ has joined #bitcoin-core-dev
4472018-07-20T20:29:52 <bitcoin-git> [bitcoin] DrahtBot closed pull request #12435: RPC: Strict JSON-RPC 2.0 compliance (gated behind flag) (master...2018-02-jsonrpc-2.0) https://github.com/bitcoin/bitcoin/pull/12435
4482018-07-20T20:29:58 <bitcoin-git> [bitcoin] DrahtBot closed pull request #12419: Force distinct destinations in CWallet::CreateTransaction (master...2018-02-distinct-destinations) https://github.com/bitcoin/bitcoin/pull/12419
4492018-07-20T20:30:06 <bitcoin-git> [bitcoin] DrahtBot closed pull request #12297: Improve CWallet::IsAllFromMe for false results (master...2018-01-isallfromme) https://github.com/bitcoin/bitcoin/pull/12297
4502018-07-20T20:30:14 <bitcoin-git> [bitcoin] DrahtBot closed pull request #12274: http: avoid fd exhaustion (master...http-fd-limit) https://github.com/bitcoin/bitcoin/pull/12274
4512018-07-20T20:30:24 <bitcoin-git> [bitcoin] DrahtBot closed pull request #12051: add missing debian contrib files to tarball (master...master) https://github.com/bitcoin/bitcoin/pull/12051
4522018-07-20T20:30:32 <bitcoin-git> [bitcoin] DrahtBot closed pull request #11785: Raise the open fd limit to the maximum allowed (master...master) https://github.com/bitcoin/bitcoin/pull/11785
4532018-07-20T20:30:42 <bitcoin-git> [bitcoin] DrahtBot closed pull request #11551: Fix unsigned integer wrap-around in GetBlockProofEquivalentTime (master...proof-equivalent-time) https://github.com/bitcoin/bitcoin/pull/11551
4542018-07-20T20:30:49 <bitcoin-git> [bitcoin] DrahtBot closed pull request #11494: Clarify BIP9 behaviour when nTimeout <= 0 (master...vb_0_timeout) https://github.com/bitcoin/bitcoin/pull/11494
4552018-07-20T20:31:02 <bitcoin-git> [bitcoin] DrahtBot closed pull request #9384: CCoinsViewCache code cleanup & deduplication (master...pr/ccoins-cleanup) https://github.com/bitcoin/bitcoin/pull/9384
4562018-07-20T20:44:19 <sipa> MarcoFalke: what is the time limit for DrahtBot to trigger a close/reopen?
4572018-07-20T20:45:11 *** rex4539 has joined #bitcoin-core-dev
4582018-07-20T20:45:32 *** bitconne1 has joined #bitcoin-core-dev
4592018-07-20T20:48:44 *** bitconner has quit IRC
4602018-07-20T20:52:21 *** Dizzle has quit IRC
4612018-07-20T21:03:15 *** frog_ has quit IRC
4622018-07-20T21:13:01 <achow101> #13212 looks like it can be merged. 3 utACKs and 1 tested ack
4632018-07-20T21:13:03 <gribble> https://github.com/bitcoin/bitcoin/issues/13212 | Net: Fixed a race condition when disabling the network. by lmanners · Pull Request #13212 · bitcoin/bitcoin · GitHub
4642018-07-20T21:16:34 *** ajtowns[m] has quit IRC
4652018-07-20T21:16:53 *** squarfed[m] has quit IRC
4662018-07-20T21:16:58 *** stepa[m] has quit IRC
4672018-07-20T21:16:59 *** herzmeister[m] has quit IRC
4682018-07-20T21:17:06 *** joshb[m] has quit IRC
4692018-07-20T21:17:12 *** kewde[m] has quit IRC
4702018-07-20T21:18:37 *** Emcy_ has joined #bitcoin-core-dev
4712018-07-20T21:18:43 *** Guyver2 has quit IRC
4722018-07-20T21:20:57 *** Emcy has quit IRC
4732018-07-20T21:21:47 <gmaxwell> sdaftuar: yes, it seemed kind of redundant with that other optimization, but it also seemed to me that it might tend to fire first.
4742018-07-20T21:24:26 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2dc5ab637803...07ce27845575
4752018-07-20T21:24:26 <bitcoin-git> bitcoin/master 5b82aa7 Ben Woosley: Fix bitcoin-cli --version...
4762018-07-20T21:24:27 <bitcoin-git> bitcoin/master 07ce278 MarcoFalke: Merge #13725: Fix bitcoin-cli --version...
4772018-07-20T21:25:01 *** Emcy_ has quit IRC
4782018-07-20T21:25:26 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13725: Fix bitcoin-cli --version (master...fix-bitcoin-cli-version) https://github.com/bitcoin/bitcoin/pull/13725
4792018-07-20T21:25:28 *** Emcy has joined #bitcoin-core-dev
4802018-07-20T21:27:02 *** dqx_ has quit IRC
4812018-07-20T21:28:05 *** drexl_ has joined #bitcoin-core-dev
4822018-07-20T21:30:46 *** dqx_ has joined #bitcoin-core-dev
4832018-07-20T21:31:05 *** Empact_ has quit IRC
4842018-07-20T21:31:18 *** Empact has joined #bitcoin-core-dev
4852018-07-20T21:31:45 *** drexl has quit IRC
4862018-07-20T21:31:47 *** drexl_ is now known as drexl
4872018-07-20T21:32:05 *** shesek has quit IRC
4882018-07-20T21:41:10 *** AaronvanW has joined #bitcoin-core-dev
4892018-07-20T21:42:39 *** Krellan has joined #bitcoin-core-dev
4902018-07-20T21:44:10 *** Chris_Stewart_5 has quit IRC
4912018-07-20T21:48:12 *** shesek has joined #bitcoin-core-dev
4922018-07-20T21:57:58 *** keymone has quit IRC
4932018-07-20T22:03:31 *** rex4539 has quit IRC
4942018-07-20T22:04:32 *** kewde[m] has joined #bitcoin-core-dev
4952018-07-20T22:06:50 *** vicenteH has quit IRC
4962018-07-20T22:08:28 *** AaronvanW has quit IRC
4972018-07-20T22:14:34 *** booyah has quit IRC
4982018-07-20T22:18:27 *** vicenteH has joined #bitcoin-core-dev
4992018-07-20T22:23:48 *** joshb[m] has joined #bitcoin-core-dev
5002018-07-20T22:23:49 *** herzmeister[m] has joined #bitcoin-core-dev
5012018-07-20T22:23:49 *** ajtowns[m] has joined #bitcoin-core-dev
5022018-07-20T22:23:51 *** squarfed[m] has joined #bitcoin-core-dev
5032018-07-20T22:23:51 *** stepa[m] has joined #bitcoin-core-dev
5042018-07-20T22:27:41 *** Victorsueca has quit IRC
5052018-07-20T22:28:54 *** Victorsueca has joined #bitcoin-core-dev
5062018-07-20T22:35:59 <bitcoin-git> [bitcoin] Empact opened pull request #13728: Run the CI lint stage on mac and linux both (master...bsd-bash-compatibility) https://github.com/bitcoin/bitcoin/pull/13728
5072018-07-20T22:46:01 <bitcoin-git> [bitcoin] Empact opened pull request #13729: Scripts and tools: Avoid unnecessarily setting env variables on the lint build (master...ci-lint-env) https://github.com/bitcoin/bitcoin/pull/13729
5082018-07-20T23:31:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5092018-07-20T23:34:32 *** ken2812221 has quit IRC
5102018-07-20T23:35:55 *** promag has quit IRC
5112018-07-20T23:41:24 *** grafcaps has quit IRC
5122018-07-20T23:42:28 *** grafcaps has joined #bitcoin-core-dev
5132018-07-20T23:44:22 *** dqx_ has quit IRC
5142018-07-20T23:47:10 *** grafcaps has quit IRC
5152018-07-20T23:48:19 *** dqx_ has joined #bitcoin-core-dev
5162018-07-20T23:56:00 *** StopAndDecrypt has joined #bitcoin-core-dev
5172018-07-20T23:59:27 *** dqx_ has quit IRC