12018-07-27T00:06:21  *** StopAndDecrypt has quit IRC
  22018-07-27T00:07:14  *** StopAndDecrypt has joined #bitcoin-core-dev
  32018-07-27T00:10:00  *** grafcaps has quit IRC
  42018-07-27T00:13:30  *** dqx__ has quit IRC
  52018-07-27T00:15:35  *** dqx_ has joined #bitcoin-core-dev
  62018-07-27T00:16:04  *** dqx_ has quit IRC
  72018-07-27T00:56:35  *** AaronvanW has quit IRC
  82018-07-27T00:57:12  *** AaronvanW has joined #bitcoin-core-dev
  92018-07-27T01:02:09  *** AaronvanW has quit IRC
 102018-07-27T01:05:38  *** jpe_ has joined #bitcoin-core-dev
 112018-07-27T01:08:38  *** jpe__ has quit IRC
 122018-07-27T01:17:48  *** savil has joined #bitcoin-core-dev
 132018-07-27T01:26:52  *** Victorsueca has quit IRC
 142018-07-27T01:28:08  *** Victorsueca has joined #bitcoin-core-dev
 152018-07-27T01:49:43  *** leishman__ has quit IRC
 162018-07-27T02:02:06  *** jarthur has joined #bitcoin-core-dev
 172018-07-27T02:08:06  *** AaronvanW has joined #bitcoin-core-dev
 182018-07-27T02:12:35  *** AaronvanW has quit IRC
 192018-07-27T02:34:54  *** savil has quit IRC
 202018-07-27T03:32:10  *** justan0theruser has quit IRC
 212018-07-27T03:32:27  *** justanotheruser has joined #bitcoin-core-dev
 222018-07-27T04:00:55  *** grubles has quit IRC
 232018-07-27T04:08:44  *** AaronvanW has joined #bitcoin-core-dev
 242018-07-27T04:13:21  *** AaronvanW has quit IRC
 252018-07-27T04:29:18  *** jarthur has quit IRC
 262018-07-27T04:35:16  *** grubles has joined #bitcoin-core-dev
 272018-07-27T04:46:35  *** grubles has quit IRC
 282018-07-27T04:56:18  *** schmidty_ has quit IRC
 292018-07-27T04:56:50  *** grubles has joined #bitcoin-core-dev
 302018-07-27T05:09:43  *** BillSmith4lyfe has joined #bitcoin-core-dev
 312018-07-27T05:42:27  *** jtimon has quit IRC
 322018-07-27T05:53:19  *** leishman has joined #bitcoin-core-dev
 332018-07-27T05:55:23  *** leishman has quit IRC
 342018-07-27T06:09:28  *** AaronvanW has joined #bitcoin-core-dev
 352018-07-27T06:14:27  *** AaronvanW has quit IRC
 362018-07-27T06:32:53  *** no_input_found has quit IRC
 372018-07-27T06:33:14  *** no_input_found has joined #bitcoin-core-dev
 382018-07-27T07:21:47  *** SopaXorzTaker has joined #bitcoin-core-dev
 392018-07-27T07:40:53  *** Victorsueca has quit IRC
 402018-07-27T07:42:08  *** Victorsueca has joined #bitcoin-core-dev
 412018-07-27T07:52:21  *** murrayn has quit IRC
 422018-07-27T07:54:28  *** ken2812221 has quit IRC
 432018-07-27T07:54:34  *** timothy has joined #bitcoin-core-dev
 442018-07-27T08:01:03  *** csknk has joined #bitcoin-core-dev
 452018-07-27T08:02:47  *** csknk has quit IRC
 462018-07-27T08:08:59  *** setpill has joined #bitcoin-core-dev
 472018-07-27T08:13:48  *** polydin has quit IRC
 482018-07-27T08:15:05  <jonasschnelli> sipa: would adding 'h' as equivalent to ' in the descriptor xpub/xpriv range definition makes sense? >'< in conjunction with JSON and the GUI/bitcoin-cli/shell seems to be a hassle
 492018-07-27T08:18:30  *** csknk has joined #bitcoin-core-dev
 502018-07-27T08:21:10  *** csknk has joined #bitcoin-core-dev
 512018-07-27T08:22:48  *** csknk has quit IRC
 522018-07-27T08:22:58  *** csknk has joined #bitcoin-core-dev
 532018-07-27T08:30:57  *** promag has joined #bitcoin-core-dev
 542018-07-27T08:37:01  *** vicenteH has joined #bitcoin-core-dev
 552018-07-27T09:37:27  *** go1111111 has quit IRC
 562018-07-27T09:54:58  *** AaronvanW has joined #bitcoin-core-dev
 572018-07-27T10:08:13  *** SopaXorzTaker has quit IRC
 582018-07-27T10:14:22  *** csknk has quit IRC
 592018-07-27T11:45:37  *** exit70 has quit IRC
 602018-07-27T11:45:49  <sipa> jonasschnelli: yes perhaps; but for compatibility with existing RPCs i stayed with '
 612018-07-27T11:46:53  *** exit70 has joined #bitcoin-core-dev
 622018-07-27T11:53:38  *** promag has quit IRC
 632018-07-27T11:54:36  <jonasschnelli> sipa: is think it should not be OR, it should be AND
 642018-07-27T11:54:51  <jonasschnelli> support ' AND h
 652018-07-27T11:56:42  *** vicenteH has quit IRC
 662018-07-27T11:57:10  *** vicenteH has joined #bitcoin-core-dev
 672018-07-27T12:00:50  *** jtimon has joined #bitcoin-core-dev
 682018-07-27T12:37:00  *** csknk has joined #bitcoin-core-dev
 692018-07-27T13:03:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 702018-07-27T13:06:03  *** rafalcpp has quit IRC
 712018-07-27T13:17:13  *** rafalcpp has joined #bitcoin-core-dev
 722018-07-27T13:20:10  *** promag has joined #bitcoin-core-dev
 732018-07-27T13:23:16  *** jpe_ has quit IRC
 742018-07-27T13:23:34  *** jpe has joined #bitcoin-core-dev
 752018-07-27T13:27:34  *** setpill has quit IRC
 762018-07-27T13:29:33  *** setpill has joined #bitcoin-core-dev
 772018-07-27T13:30:05  *** Chris_Stewart_5 has quit IRC
 782018-07-27T13:52:20  *** profmac has quit IRC
 792018-07-27T14:20:46  *** AaronvanW has quit IRC
 802018-07-27T14:26:17  <brighton36> so, I'm looking to find out a few things about the bitcoincore.org site. Chiefly, content changes are delegated. Who can I speak to about that?
 812018-07-27T14:26:23  <brighton36> *how
 822018-07-27T14:26:38  *** SopaXorzTaker has joined #bitcoin-core-dev
 832018-07-27T14:27:19  <brighton36> Is there a policy somewhere perhaps?
 842018-07-27T14:29:55  *** csknk has quit IRC
 852018-07-27T14:31:25  *** AaronvanW has joined #bitcoin-core-dev
 862018-07-27T14:35:57  *** AaronvanW has quit IRC
 872018-07-27T14:40:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 882018-07-27T14:48:26  <harding> brighton36: I help maintain the site.  I don't relaly understand your question.  There's a basic contributing policy at https://github.com/bitcoin-core/bitcoincore.org/blob/master/CONTRIBUTING.md but the basic process is the same for any open source project: people open PRs proposing changes, other people provide feedback, once the feedback is generally positive, the PR is merged.  If the PR never gets to that stage, it's
 892018-07-27T14:48:27  <harding> eventually closed.  If there's something wonky going on (like lots of comments from unknown accounts), that's factored into the merge/no-merge decision.
 902018-07-27T15:08:36  <brighton36> thank-you harding :)
 912018-07-27T15:08:48  <brighton36> I get that this is a heavily politicized issue. But, I'd like to know what the process is
 922018-07-27T15:08:56  <brighton36> I think a mission statement would help greatly
 932018-07-27T15:09:12  <brighton36> less would obviously be more, but, just being able to point at a mission would help us out greatly
 942018-07-27T15:09:52  <brighton36> Borrowing one from any other prominent open source project, and redacting specifics would seem productive. Less is more.
 952018-07-27T15:10:25  *** harrymm has quit IRC
 962018-07-27T15:10:26  <brighton36> Is there a process by which the stakeholders could decide that, or is a PR the process?
 972018-07-27T15:10:38  <harding> brighton36: I'm not sure what you're talking about, but it feels a bit off topic for this channel.  Would you mind joining #bitcoin-core-website to discuss further?  (Or you can PM me if you're a registered user.)
 982018-07-27T15:10:46  <brighton36> yep
 992018-07-27T15:10:51  <brighton36> thank-you sir
1002018-07-27T15:12:13  *** cryptapus has quit IRC
1012018-07-27T15:20:26  *** marcinja_ has quit IRC
1022018-07-27T15:20:47  *** AaronvanW has joined #bitcoin-core-dev
1032018-07-27T15:25:15  *** savil has joined #bitcoin-core-dev
1042018-07-27T15:34:48  *** vicenteH has quit IRC
1052018-07-27T15:44:08  *** Chris_Stewart_5 has quit IRC
1062018-07-27T15:45:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1072018-07-27T15:48:27  *** Emcy has quit IRC
1082018-07-27T15:49:20  *** |EHG| has quit IRC
1092018-07-27T15:50:39  *** Emcy has joined #bitcoin-core-dev
1102018-07-27T15:55:09  *** |EHG| has joined #bitcoin-core-dev
1112018-07-27T15:55:49  *** |EHG| has left #bitcoin-core-dev
1122018-07-27T16:00:53  *** promag has quit IRC
1132018-07-27T16:01:27  *** promag has joined #bitcoin-core-dev
1142018-07-27T16:02:19  *** masonicboom has joined #bitcoin-core-dev
1152018-07-27T16:06:11  *** promag has quit IRC
1162018-07-27T16:06:15  *** dqx_ has joined #bitcoin-core-dev
1172018-07-27T16:12:29  *** dqx__ has joined #bitcoin-core-dev
1182018-07-27T16:12:52  *** dqx__ has quit IRC
1192018-07-27T16:15:51  *** dqx_ has quit IRC
1202018-07-27T16:31:52  *** setpill has quit IRC
1212018-07-27T16:34:06  *** jarthur has joined #bitcoin-core-dev
1222018-07-27T16:40:57  *** leishman has joined #bitcoin-core-dev
1232018-07-27T16:52:59  *** leishman___ has joined #bitcoin-core-dev
1242018-07-27T16:53:06  *** leishman___ has left #bitcoin-core-dev
1252018-07-27T17:26:27  *** rex4539 has quit IRC
1262018-07-27T17:26:39  *** jarthur has quit IRC
1272018-07-27T17:32:34  *** vicenteH has joined #bitcoin-core-dev
1282018-07-27T17:36:14  *** timothy has quit IRC
1292018-07-27T17:40:02  *** masonicboom has quit IRC
1302018-07-27T17:45:48  *** masonicboom has joined #bitcoin-core-dev
1312018-07-27T17:56:00  *** rex4539 has joined #bitcoin-core-dev
1322018-07-27T18:23:35  <sipa> MarcoFalke: AssertionError: not(0.00700000 == 0.007)
1332018-07-27T18:23:42  <sipa> any idea how to deal with that in tests?
1342018-07-27T18:24:48  <luke-jr> sipa: maybe assert_approx?
1352018-07-27T18:25:09  <sipa> i don't see that anywhere in our source code
1362018-07-27T18:25:18  <sipa> this can't be the only place where this is an issue
1372018-07-27T18:25:23  <sipa> so i must be doing something wrong
1382018-07-27T18:25:36  <sipa> (it's ValueFromAmount output in RPC
1392018-07-27T18:26:12  <sipa> i'll just try to stick to integer amounts
1402018-07-27T18:26:15  <luke-jr> sipa: test/functional/wallet_groups.py
1412018-07-27T18:30:09  <sdaftuar> sipa: are both values coming from rpc calls, or is one hardcoded in?  i think we use Decimal() in the test framework a bunch, presumably to solve that problem
1422018-07-27T18:31:03  <sipa> sdaftuar: ah!
1432018-07-27T18:31:08  <sipa> one is hardcoded
1442018-07-27T18:33:43  <jonasschnelli> sipa: re xpub range in descriptors...
1452018-07-27T18:33:46  <gmaxwell> :( even we can't get it right.
1462018-07-27T18:34:14  <jonasschnelli> sipa: if you disagree with the index <= vs <, then I guess you need to +1 when populating the range from the JSON or change the doc
1472018-07-27T18:34:31  <jonasschnelli> Because the doc states: "\"range\": n,             (numeric, optional) Up to what child index HD chains should be explored (default: 1000)\n""
1482018-07-27T18:34:44  <jonasschnelli> if you pass in 1000, it will only derive up to 999
1492018-07-27T18:35:17  <jonasschnelli> I think the doc is correct and would recommend to +1 somewhere else
1502018-07-27T18:37:22  <sipa> jonasschnelli: good point
1512018-07-27T18:38:16  <jonasschnelli> IMO if one puts a range of 1500, then one probably expect that key at index 1500 will be included...
1522018-07-27T18:39:23  <jonasschnelli> sipa: why not a real range X-Y? instead of pure Y?
1532018-07-27T18:39:23  <sipa> ok, will fix
1542018-07-27T18:39:39  <sipa> jonasschnelli: sounds like something for a later extension?
1552018-07-27T18:39:40  <jonasschnelli> (although could be changed later)
1562018-07-27T18:39:44  <jonasschnelli> agree
1572018-07-27T18:42:20  <sipa> GAH
1582018-07-27T18:42:21  <sipa> AssertionError: not(0.00200000 == 0.00200000000000000004163336342344337026588618755340576171875)
1592018-07-27T18:44:53  <sdaftuar> sipa: i think you need to do `Decimal("0.002")`?
1602018-07-27T18:45:20  <sdaftuar> at least, that's what i see all over our python test code
1612018-07-27T18:46:35  <sipa> sdaftuar: thanks! that works
1622018-07-27T18:47:39  *** grubles has quit IRC
1632018-07-27T18:50:27  *** jtimon has quit IRC
1642018-07-27T18:54:07  *** rex4539 has quit IRC
1652018-07-27T18:56:03  <sipa> jonasschnelli: regarding support for "h" instead of "'", should it roundtrip?
1662018-07-27T18:56:21  <jonasschnelli> no... I think only input
1672018-07-27T18:56:37  <sipa> ok, that's easy enough then
1682018-07-27T18:56:51  <jonasschnelli> Yes.
1692018-07-27T18:57:08  <jonasschnelli> I guess no-one will complain about the missing roundtripness...
1702018-07-27T18:57:22  <jonasschnelli> IMO it's mainly useful to bypass shellish input sources
1712018-07-27T18:57:39  <jonasschnelli> *shellish input source restrictions
1722018-07-27T18:58:55  *** satwo has joined #bitcoin-core-dev
1732018-07-27T19:04:44  <satwo> Has the bitcoind config param -rpcclienttimeout been removed? I'm getting errors trying to set it in both the command line and in bitcoin.conf.
1742018-07-27T19:04:46  *** rex4539 has joined #bitcoin-core-dev
1752018-07-27T19:05:37  <sipa> satwo: no, but it's a bitcoin-cli command line option; not a bitcoind one
1762018-07-27T19:06:39  <satwo> Thanks sipa. This doc may need updating then: https://github.com/bitcoin/bitcoin/blob/master/contrib/debian/examples/bitcoin.conf
1772018-07-27T19:09:18  <satwo> Would it be appropriate to remove the section for rpcclienttimeout there? Or am I missing something?
1782018-07-27T19:09:57  *** Chris_Stewart_5 has quit IRC
1792018-07-27T19:10:00  <sipa> in bitcoin.conf it should work fine; that file should be read by both bitcoind and bitcoin-cli
1802018-07-27T19:10:51  *** go1111111 has joined #bitcoin-core-dev
1812018-07-27T19:11:43  <satwo> That's what I thought, but I got the following error when starting bitcoind: Error reading configuration file: Invalid configuration value rpcclienttimeout
1822018-07-27T19:12:46  <sipa> oh, of course
1832018-07-27T19:13:04  <sipa> right; you can't put it in bitcoin.conf anymore, because it's not a bitcoind option
1842018-07-27T19:13:16  <sipa> and since 0.17 bitcoind will give an error if an invalid option is passed
1852018-07-27T19:13:34  <sipa> we could add an exception to ignore it
1862018-07-27T19:16:22  <satwo> For just that one param?
1872018-07-27T19:16:36  <sipa> no, this is true for every parameter
1882018-07-27T19:16:52  <sipa> in earlier versions bitcoind would just ignore unknown options; now it will give an error
1892018-07-27T19:20:02  <satwo> Got it. What do you mean exactly by adding an exception to ignore it? Show the error/warning but allow bitcoind to start anyway?
1902018-07-27T19:20:08  <sipa> but we should probably make it ignore bitcoin-cli only options like this one, when present in bitcoin.conf
1912018-07-27T19:20:11  <wumpus> it's good that it now gives errors on unkonwn options, this was a long-running issue
1922018-07-27T19:20:33  <wumpus> but yes, that's firly annoying too...
1932018-07-27T19:21:09  <wumpus> sipa: though that means that all executables need to have knowledge of all other executables' flags
1942018-07-27T19:21:28  <wumpus> which is exactly what we were trying to avoid by modularizing the options system
1952018-07-27T19:21:38  <sipa> wumpus: or we need a way to specify bitcoin.conf options that only apply to a particular binary
1962018-07-27T19:21:39  <wumpus> it's kind of annoying, maybe cli-specific options could have their own sections?
1972018-07-27T19:21:44  <sipa> like the network sections
1982018-07-27T19:21:45  <wumpus> right
1992018-07-27T19:22:00  <wumpus> for 0.17 I agree we could just make it a warning
2002018-07-27T19:22:04  <wumpus> if an unknown option is specified
2012018-07-27T19:22:11  <wumpus> then for 0.18 think about for to sensibly enforce this
2022018-07-27T19:23:07  <sipa> that's one possibility
2032018-07-27T19:23:14  <sipa> or we could use the deprecation mechanism
2042018-07-27T19:23:57  <sipa> (by default it's enforced, unless you pass -ignoreunknownconfigoptions or so; and then it still only applies to bitcoin.conf and not to command line options)
2052018-07-27T19:24:55  <wumpus> yes
2062018-07-27T19:27:58  <luke-jr> wumpus: actually, it might be annoying if users get errors for Knots configs in bitcoin.conf
2072018-07-27T19:28:09  <luke-jr> perhaps there should be a way to explicitly say "don't error if you don't understand this"
2082018-07-27T19:28:20  <wumpus> sipa has a good point
2092018-07-27T19:28:32  <luke-jr> per-option seems safer IMO
2102018-07-27T19:28:33  <wumpus> make it an error if an unknown option on the command line
2112018-07-27T19:28:36  <luke-jr> though we could do both
2122018-07-27T19:28:42  <wumpus> but a warning if in bitcoin.conf
2132018-07-27T19:28:46  <luke-jr> sure
2142018-07-27T19:39:32  <satwo> Happy to attempt an implementation of this, if no one else wants to knock it out.
2152018-07-27T19:42:06  <sipa> i vaguely remember we already have an exception for some option, but i can't check right now
2162018-07-27T19:43:49  *** grubles has joined #bitcoin-core-dev
2172018-07-27T19:49:34  *** polydin has joined #bitcoin-core-dev
2182018-07-27T19:53:38  *** owowo has quit IRC
2192018-07-27T19:59:08  *** owowo has joined #bitcoin-core-dev
2202018-07-27T20:00:18  *** Victorsueca has quit IRC
2212018-07-27T20:01:31  *** Victorsueca has joined #bitcoin-core-dev
2222018-07-27T20:04:36  *** savil has quit IRC
2232018-07-27T20:16:42  <wumpus> satwo: would be awesome
2242018-07-27T20:17:21  *** SopaXorzTaker has quit IRC
2252018-07-27T20:27:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2262018-07-27T20:46:57  *** Chris_Stewart_5 has quit IRC
2272018-07-27T20:47:51  <satwo> wumpus: Will work on it this weekend. Still learning C++ but I'll do the best I can
2282018-07-27T20:57:38  *** booyah is now known as booyah_
2292018-07-27T21:00:18  <cfields> jonasschnelli: 0.16.2 macOS signature ping :)
2302018-07-27T21:05:25  *** michaelsdunn1 has joined #bitcoin-core-dev
2312018-07-27T21:15:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2322018-07-27T21:18:23  <jonasschnelli> cfields: Oh. Yes. Just started the build,... will PR the detatched sig tomorrow (in 10-12h).
2332018-07-27T21:23:19  <cfields> jonasschnelli: np, thanks
2342018-07-27T21:27:20  *** masonicboom has quit IRC
2352018-07-27T21:38:51  *** masonicboom has joined #bitcoin-core-dev
2362018-07-27T21:39:14  *** savil has joined #bitcoin-core-dev
2372018-07-27T21:42:41  *** Victorsueca has quit IRC
2382018-07-27T21:44:11  *** Victorsueca has joined #bitcoin-core-dev
2392018-07-27T21:45:05  *** Chris_Stewart_5 has quit IRC
2402018-07-27T22:07:18  *** LKbTkXFn has joined #bitcoin-core-dev
2412018-07-27T22:14:55  *** lnostdal has quit IRC
2422018-07-27T22:37:34  *** jhfrontz has joined #bitcoin-core-dev
2432018-07-27T22:39:36  *** spinza has quit IRC
2442018-07-27T22:55:54  <jhfrontz> Is there anything that needs to be done to enable use of the  0.16.2 version of contrib/gitian-descriptors/gitian-linux.yml (when using a docker-based gitian build)?
2452018-07-27T22:56:53  <jhfrontz> I'm getting errors about missing symbols (like described here: https://github.com/bitcoin/bitcoin/issues/12511#issuecomment-386740137 ).
2462018-07-27T23:01:06  *** michaelsdunn1 has quit IRC
2472018-07-27T23:03:06  <jhfrontz> It looks like all the signers of 0.16.2  for linux so far have used "trusty" (instead of the 0.16.2-gitian-linux.yml-spec'd "bionic").  So maybe I shouldn't be using the new version?
2482018-07-27T23:03:30  <wumpus> yes 0.16.2 is built with trusty
2492018-07-27T23:03:59  <wumpus> no releases yet have been built with bionic, though this is the plan for 0.17
2502018-07-27T23:05:48  <sipa> jhfrontz: if you build on bionic (even if it works), you won't get the same binaries as others
2512018-07-27T23:06:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2522018-07-27T23:06:24  *** CubicEarth has quit IRC
2532018-07-27T23:06:48  <jhfrontz> OK, tnx.  I must've pulled down the wrong version?
2542018-07-27T23:07:04  <wumpus> I guess so? I'm not sure how you end up in that situation at all, the descriptors on the 0.16 branch shouldn't point to bionic
2552018-07-27T23:07:04  <jhfrontz> of gitian-linux.yml, I mean
2562018-07-27T23:07:42  <jhfrontz> doh, wrong branch…
2572018-07-27T23:07:47  <sipa> https://github.com/bitcoin/bitcoin/blob/v0.16.2/contrib/gitian-descriptors/gitian-linux.yml <- specifies trusty
2582018-07-27T23:08:18  *** CubicEarth has joined #bitcoin-core-dev
2592018-07-27T23:29:59  *** leishman has quit IRC
2602018-07-27T23:44:46  *** owowo has quit IRC
2612018-07-27T23:49:32  *** owowo has joined #bitcoin-core-dev