12018-08-07T00:03:01 *** d9b4bef9 has quit IRC
22018-08-07T00:04:15 *** d9b4bef9 has joined #bitcoin-core-dev
32018-08-07T00:11:41 *** drexl has quit IRC
42018-08-07T00:12:42 *** Dizzle has quit IRC
52018-08-07T00:24:03 *** goatpig has quit IRC
62018-08-07T00:35:21 *** rls has quit IRC
72018-08-07T00:52:17 *** Emcy_ has joined #bitcoin-core-dev
82018-08-07T00:56:14 *** Emcy has quit IRC
92018-08-07T01:00:44 *** var-g_ has quit IRC
102018-08-07T01:01:28 *** var-g_ has joined #bitcoin-core-dev
112018-08-07T01:14:22 *** promag has quit IRC
122018-08-07T01:28:19 *** promag has joined #bitcoin-core-dev
132018-08-07T01:58:06 *** jarthur has joined #bitcoin-core-dev
142018-08-07T02:07:01 *** d9b4bef9 has quit IRC
152018-08-07T02:08:09 *** d9b4bef9 has joined #bitcoin-core-dev
162018-08-07T02:09:02 *** d9b4bef9 has quit IRC
172018-08-07T02:10:08 *** d9b4bef9 has joined #bitcoin-core-dev
182018-08-07T02:13:51 *** StopAndDecrypt has quit IRC
192018-08-07T02:17:16 *** StopAndDecrypt has joined #bitcoin-core-dev
202018-08-07T02:30:26 *** no_input_found has quit IRC
212018-08-07T02:30:46 *** no_input_found has joined #bitcoin-core-dev
222018-08-07T02:51:59 *** promag has quit IRC
232018-08-07T02:54:42 *** promag has joined #bitcoin-core-dev
242018-08-07T02:59:20 *** promag has quit IRC
252018-08-07T03:06:19 *** jhfrontz has quit IRC
262018-08-07T03:16:36 *** promag has joined #bitcoin-core-dev
272018-08-07T03:20:28 *** jeremyrubin has joined #bitcoin-core-dev
282018-08-07T03:21:05 *** promag has quit IRC
292018-08-07T03:23:01 *** promag has joined #bitcoin-core-dev
302018-08-07T03:27:35 *** promag has quit IRC
312018-08-07T03:36:35 *** promag has joined #bitcoin-core-dev
322018-08-07T03:47:27 *** promag has quit IRC
332018-08-07T03:50:20 *** vicenteH has quit IRC
342018-08-07T03:50:50 *** vicenteH has joined #bitcoin-core-dev
352018-08-07T04:06:39 *** jarthur has quit IRC
362018-08-07T04:07:33 *** jarthur has joined #bitcoin-core-dev
372018-08-07T04:46:21 *** promag has joined #bitcoin-core-dev
382018-08-07T04:50:57 *** promag has quit IRC
392018-08-07T05:01:11 *** promag has joined #bitcoin-core-dev
402018-08-07T05:05:57 *** promag has quit IRC
412018-08-07T05:35:40 *** Krellan has quit IRC
422018-08-07T05:40:08 *** jarthur has quit IRC
432018-08-07T05:48:54 *** justanotheruser has quit IRC
442018-08-07T05:49:00 *** Randolf has joined #bitcoin-core-dev
452018-08-07T05:54:42 *** justanotheruser has joined #bitcoin-core-dev
462018-08-07T06:24:06 *** promag has joined #bitcoin-core-dev
472018-08-07T06:28:27 *** promag has quit IRC
482018-08-07T06:38:01 *** d9b4bef9 has quit IRC
492018-08-07T06:39:08 *** d9b4bef9 has joined #bitcoin-core-dev
502018-08-07T06:41:56 *** polydin has quit IRC
512018-08-07T07:04:01 *** Krellan has joined #bitcoin-core-dev
522018-08-07T07:10:44 *** no_input_found has quit IRC
532018-08-07T07:29:07 *** pigeons has quit IRC
542018-08-07T07:56:47 *** atroxes has quit IRC
552018-08-07T07:57:16 *** atroxes has joined #bitcoin-core-dev
562018-08-07T08:39:23 *** SopaXorzTaker has joined #bitcoin-core-dev
572018-08-07T09:16:43 *** rls has joined #bitcoin-core-dev
582018-08-07T09:23:17 *** no_input_found has joined #bitcoin-core-dev
592018-08-07T09:50:16 *** Emcy has joined #bitcoin-core-dev
602018-08-07T09:53:00 *** Emcy_ has quit IRC
612018-08-07T10:23:01 *** d9b4bef9 has quit IRC
622018-08-07T10:24:08 *** d9b4bef9 has joined #bitcoin-core-dev
632018-08-07T10:50:27 *** Victorsueca has quit IRC
642018-08-07T10:51:44 *** Victorsueca has joined #bitcoin-core-dev
652018-08-07T10:53:48 *** face has joined #bitcoin-core-dev
662018-08-07T10:54:02 *** intcat has quit IRC
672018-08-07T10:56:08 *** intcat has joined #bitcoin-core-dev
682018-08-07T10:56:09 *** gwillen has quit IRC
692018-08-07T10:57:38 *** gwillen has joined #bitcoin-core-dev
702018-08-07T11:00:09 *** goatpig has joined #bitcoin-core-dev
712018-08-07T11:15:19 <wumpus> I miss the github bot
722018-08-07T11:26:30 <wumpus> need more review on some still-open 0.17 PRs, looks like #13788 and #13808 (and possibly #13667)
732018-08-07T11:26:31 <gribble> https://github.com/bitcoin/bitcoin/issues/13788 | Fix --disable-asm for newer assembly checks/code by luke-jr · Pull Request #13788 · bitcoin/bitcoin · GitHub
742018-08-07T11:26:32 <gribble> https://github.com/bitcoin/bitcoin/issues/13808 | wallet: shuffle coins before grouping, where warranted by kallewoof · Pull Request #13808 · bitcoin/bitcoin · GitHubAsset 1Asset 1
752018-08-07T11:26:33 <gribble> https://github.com/bitcoin/bitcoin/issues/13667 | wallet: Fix backupwallet for multiwallets by domob1812 · Pull Request #13667 · bitcoin/bitcoin · GitHub
762018-08-07T11:34:50 *** Krellan has quit IRC
772018-08-07T11:36:34 *** Krellan has joined #bitcoin-core-dev
782018-08-07T11:40:48 *** AaronvanW has joined #bitcoin-core-dev
792018-08-07T11:46:55 *** Krellan has quit IRC
802018-08-07T11:48:04 *** Krellan has joined #bitcoin-core-dev
812018-08-07T12:24:05 *** AaronvanW has quit IRC
822018-08-07T12:26:46 *** Randolf has quit IRC
832018-08-07T12:45:17 <wumpus> so many windows PRs lately, that's great, but we could really use a windows reviewer
842018-08-07T12:49:42 *** davex__ has quit IRC
852018-08-07T12:50:46 *** rockhouse has quit IRC
862018-08-07T12:50:46 *** lari has quit IRC
872018-08-07T12:50:47 *** earlz has quit IRC
882018-08-07T12:50:47 *** TheCharlatan has quit IRC
892018-08-07T12:54:26 *** rockhouse has joined #bitcoin-core-dev
902018-08-07T12:56:29 *** earlz has joined #bitcoin-core-dev
912018-08-07T12:58:29 <MarcoFalke> ryanofsky: It is noise. Also, you can check the edit history to see that nothing changed.
922018-08-07T13:06:51 *** Krellan has quit IRC
932018-08-07T13:08:18 *** Krellan has joined #bitcoin-core-dev
942018-08-07T13:24:58 *** Emcy has quit IRC
952018-08-07T14:10:01 *** lnostdal has joined #bitcoin-core-dev
962018-08-07T14:25:02 *** d9b4bef9 has quit IRC
972018-08-07T14:26:08 *** d9b4bef9 has joined #bitcoin-core-dev
982018-08-07T14:57:43 *** prod_ has joined #bitcoin-core-dev
992018-08-07T15:03:37 *** michaelsdunn1 has joined #bitcoin-core-dev
1002018-08-07T15:12:39 *** Victorsueca has quit IRC
1012018-08-07T15:13:59 *** Victorsueca has joined #bitcoin-core-dev
1022018-08-07T15:20:50 *** SopaXorzTaker has quit IRC
1032018-08-07T15:51:10 <ryanofsky> can draftbot be prevented from showing up in edit history when it is not actually changing anything? (it seems impossible to tell in 11640 whether or not it made changes due to incomplete history)
1042018-08-07T15:52:07 <ryanofsky> also imo it would be nice if draftbot refrained from adding "needs rebase" comments, and just stuck to applying labels and maybe pinging pr authors privately
1052018-08-07T15:53:42 <ryanofsky> i'd like to be able to keep my rebase history in a comment that get updated instead of having this "needs rebase" "rebased" "needs rebase" "rebased" ping pong
1062018-08-07T16:02:51 *** wumpus has quit IRC
1072018-08-07T16:18:24 *** wumpus has joined #bitcoin-core-dev
1082018-08-07T16:47:18 *** csknk has joined #bitcoin-core-dev
1092018-08-07T16:51:08 *** Emcy has joined #bitcoin-core-dev
1102018-08-07T16:54:48 *** Emcy_ has joined #bitcoin-core-dev
1112018-08-07T16:57:57 *** Emcy has quit IRC
1122018-08-07T17:05:23 *** csknk has quit IRC
1132018-08-07T17:06:07 <MarcoFalke> ryanofsky: The "needs rebase" comments get deleted after you did the rebase
1142018-08-07T17:06:15 <MarcoFalke> Also no need to reply to the bot
1152018-08-07T17:06:36 <MarcoFalke> Though, I can change it to ping privately if you have an idea on how to do that
1162018-08-07T17:15:06 *** bitbee has quit IRC
1172018-08-07T17:21:04 <harding> MarcoFalke: to ping privately, the bot could just pull the email address of the committer from the most recent commit message and email them. Alternatively, the bot could open an issue on the repository they're making their PR from, e.g. github.com/harding/bitcoin/issues/new
1182018-08-07T17:24:20 <MarcoFalke> The email wouldn't go through the GitHub filter, so likely couldn't be sorted into different inboxes. And issues are usually disabled for forked repos
1192018-08-07T17:26:30 <harding> What's the GitHub filter? You're correct on the second point; I think that didn't used to be the case.
1202018-08-07T17:27:40 <harding> Oh, I see, you're saying that people who have rules setup already wouldn't be able to reuse those rules for the rebase notifications.
1212018-08-07T17:28:16 <MarcoFalke> jup
1222018-08-07T17:29:00 <MarcoFalke> githubs send from:"notifications@github.com" to:"bitcoin@noreply.github.com" with cc:"comment@noreply.github.com" and cc you
1232018-08-07T17:29:45 <harding> MarcoFalke: maybe just batch all rebase notifications for a particular email address into one daily notification. That's not too spamy, I think? A single list of todos is kind of nice anyway.
1242018-08-07T17:32:09 <MarcoFalke> Hmm, I could just disable it for pull requests that are highly likely to conflict
1252018-08-07T17:32:50 <MarcoFalke> Which I believe are only #10973 and #10102
1262018-08-07T17:32:53 <gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHubAsset 1Asset 1
1272018-08-07T17:32:56 <gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHubAsset 1Asset 1
1282018-08-07T17:35:43 *** bitbee has joined #bitcoin-core-dev
1292018-08-07T17:40:29 *** Dizzle has joined #bitcoin-core-dev
1302018-08-07T17:48:40 <ryanofsky> oh, i didn't realize the "needs rebase" comments get deleted. that seems fine and basically equivalent to emailing
1312018-08-07T17:51:52 *** rafalcpp_ is now known as rafalcpp
1322018-08-07T18:22:00 *** Krellan has quit IRC
1332018-08-07T18:27:01 *** d9b4bef9 has quit IRC
1342018-08-07T18:28:08 *** d9b4bef9 has joined #bitcoin-core-dev
1352018-08-07T18:46:48 *** goatpig has quit IRC
1362018-08-07T19:26:28 *** owowo has quit IRC
1372018-08-07T19:27:21 *** owowo has joined #bitcoin-core-dev
1382018-08-07T19:40:16 *** ken2812221 has quit IRC
1392018-08-07T19:50:37 *** ken2812221 has joined #bitcoin-core-dev
1402018-08-07T19:52:26 *** games_ has joined #bitcoin-core-dev
1412018-08-07T19:58:27 *** vicenteH has quit IRC
1422018-08-07T20:02:29 *** vicenteH has joined #bitcoin-core-dev
1432018-08-07T20:16:38 *** Victorsueca has quit IRC
1442018-08-07T20:17:59 *** Victorsueca has joined #bitcoin-core-dev
1452018-08-07T20:28:29 *** drexl has joined #bitcoin-core-dev
1462018-08-07T20:57:21 *** jhfrontz has joined #bitcoin-core-dev
1472018-08-07T21:12:35 *** jhfrontz has quit IRC
1482018-08-07T21:18:44 *** jhfrontz has joined #bitcoin-core-dev
1492018-08-07T21:19:39 *** Krellan has joined #bitcoin-core-dev
1502018-08-07T21:31:03 *** jhfrontz has quit IRC
1512018-08-07T21:31:21 *** jhfrontz has joined #bitcoin-core-dev
1522018-08-07T21:35:03 *** jhfrontz has quit IRC
1532018-08-07T21:43:02 *** drexl has quit IRC
1542018-08-07T22:05:15 *** michaelsdunn1 has quit IRC
1552018-08-07T22:12:22 *** timothy has quit IRC
1562018-08-07T22:12:37 *** jhfrontz has joined #bitcoin-core-dev
1572018-08-07T22:20:51 *** vicenteH has quit IRC
1582018-08-07T22:26:01 *** vicenteH has joined #bitcoin-core-dev
1592018-08-07T22:29:02 *** d9b4bef9 has quit IRC
1602018-08-07T22:30:07 *** d9b4bef9 has joined #bitcoin-core-dev
1612018-08-07T22:34:41 *** jhfrontz has quit IRC
1622018-08-07T22:56:15 *** tryphe has quit IRC
1632018-08-07T22:56:42 *** tryphe has joined #bitcoin-core-dev
1642018-08-07T22:56:58 *** Victorsueca has quit IRC
1652018-08-07T22:58:28 *** Victorsueca has joined #bitcoin-core-dev
1662018-08-07T23:07:48 *** jhfrontz has joined #bitcoin-core-dev
1672018-08-07T23:12:15 *** jhfrontz has quit IRC
1682018-08-07T23:18:39 *** jhfrontz has joined #bitcoin-core-dev
1692018-08-07T23:27:05 *** MrPaz has quit IRC
1702018-08-07T23:35:03 *** Dizzle has quit IRC
1712018-08-07T23:38:05 *** justanotheruser has quit IRC
1722018-08-07T23:39:28 *** justan0theruser has joined #bitcoin-core-dev