12018-08-17T00:01:46 *** Dizzle has quit IRC
22018-08-17T00:05:59 *** masonicboom has quit IRC
32018-08-17T00:11:45 *** justanotheruser has joined #bitcoin-core-dev
42018-08-17T00:14:53 *** kevink has quit IRC
52018-08-17T00:35:01 *** d9b4bef9 has quit IRC
62018-08-17T00:35:50 *** masonicboom has joined #bitcoin-core-dev
72018-08-17T00:36:16 *** d9b4bef9 has joined #bitcoin-core-dev
82018-08-17T00:36:49 *** Emcy has joined #bitcoin-core-dev
92018-08-17T00:39:27 <michagogo> Hrm
102018-08-17T00:39:34 <michagogo> I got a new computer
112018-08-17T00:40:06 <michagogo> But all my VMs, including the Ubuntu I use for gitian, are in virtualbox
122018-08-17T00:40:57 <michagogo> And it seems that Windows 10 actually runs in a Hyper-V VM, which hogs the vtxâ¦
132018-08-17T00:41:52 <michagogo> Not to mention that if I want Docker thatâs Hyper-V too
142018-08-17T00:42:13 <michagogo> So I guess I need to figure out how to migrate, but I feel like thatâll be a pain
152018-08-17T00:42:30 *** Emcy_ has joined #bitcoin-core-dev
162018-08-17T00:42:31 <michagogo> Especially because the Hyper-V console sucks
172018-08-17T00:43:05 <michagogo> To the point that for Windows VMs, they tell you youâre better off RDPing in
182018-08-17T00:45:53 *** Emcy has quit IRC
192018-08-17T00:46:31 *** Krellan has quit IRC
202018-08-17T00:46:42 *** Krellan has joined #bitcoin-core-dev
212018-08-17T00:48:17 *** Krellan has quit IRC
222018-08-17T00:48:33 *** Krellan has joined #bitcoin-core-dev
232018-08-17T00:48:35 *** Emcy_ has quit IRC
242018-08-17T00:49:29 *** Emcy_ has joined #bitcoin-core-dev
252018-08-17T00:53:21 *** jhfrontz has joined #bitcoin-core-dev
262018-08-17T01:05:12 *** plankers has quit IRC
272018-08-17T01:05:49 *** plankers has joined #bitcoin-core-dev
282018-08-17T01:26:55 *** Aaronvan_ has quit IRC
292018-08-17T01:29:16 *** justanotheruser has quit IRC
302018-08-17T01:29:46 *** justanotheruser has joined #bitcoin-core-dev
312018-08-17T01:35:23 <achow101> luke-jr: really? It worked for me
322018-08-17T01:37:34 *** AaronvanW has joined #bitcoin-core-dev
332018-08-17T01:39:00 <luke-jr> achow101: it's trying to install grub, and there's no package or something
342018-08-17T01:39:04 <luke-jr> 2018-08-16 23:26:15,629 INFO : E: Package 'grub' has no installation candidate
352018-08-17T01:41:21 <achow101> luke-jr: are you sure you are using the correct vmbuilder?
362018-08-17T01:41:57 *** AaronvanW has quit IRC
372018-08-17T01:46:44 <luke-jr> achow101: no, but I tried both master and bionic branches..
382018-08-17T01:55:46 *** ken2812221 has joined #bitcoin-core-dev
392018-08-17T02:10:33 *** jb55 has joined #bitcoin-core-dev
402018-08-17T02:13:16 *** rls has quit IRC
412018-08-17T02:14:38 *** masonicboom has quit IRC
422018-08-17T02:23:20 *** Krellan has quit IRC
432018-08-17T02:28:08 *** thib has joined #bitcoin-core-dev
442018-08-17T02:36:09 *** goatpig has quit IRC
452018-08-17T02:38:17 *** AaronvanW has joined #bitcoin-core-dev
462018-08-17T02:42:27 *** AaronvanW has quit IRC
472018-08-17T02:47:06 *** reallll has joined #bitcoin-core-dev
482018-08-17T02:47:49 *** masonicboom has joined #bitcoin-core-dev
492018-08-17T02:50:41 *** belcher_ has quit IRC
502018-08-17T02:56:00 *** Emcy_ has quit IRC
512018-08-17T03:07:10 *** Emcy_ has joined #bitcoin-core-dev
522018-08-17T03:16:27 *** Chris_Stewart_5 has quit IRC
532018-08-17T03:38:05 *** masonicboom has quit IRC
542018-08-17T04:34:02 *** d9b4bef9 has quit IRC
552018-08-17T04:35:09 *** d9b4bef9 has joined #bitcoin-core-dev
562018-08-17T04:37:28 *** unholymachine has quit IRC
572018-08-17T04:39:02 *** AaronvanW has joined #bitcoin-core-dev
582018-08-17T04:44:27 *** AaronvanW has quit IRC
592018-08-17T05:28:17 *** fanquake has joined #bitcoin-core-dev
602018-08-17T05:28:56 <fanquake> MarcoFalke Any idea why your sigs don't match the others that have been submitted?
612018-08-17T05:35:27 <luke-jr> achow101: I don't see how the code in that branch can possibly work. It hard-codes "grub"
622018-08-17T05:52:31 <achow101> luke-jr: I'm not sure
632018-08-17T05:52:55 <achow101> fanquake: I'm getting the same sigs as MarcoFalke
642018-08-17T05:53:21 <achow101> fanquake: I used docker to build, maybe that's causing the difference?
652018-08-17T05:54:04 <fanquake> achow101 hmm ok. So wumpus, ken, jonass and myself match, yourself and marco match differently.
662018-08-17T05:54:29 <fanquake> achow101: that could be it. I'll do a docker build and see if there's a difference.
672018-08-17T06:02:48 *** rex4539 has quit IRC
682018-08-17T06:12:05 *** rex4539 has joined #bitcoin-core-dev
692018-08-17T06:27:04 *** Krellan has joined #bitcoin-core-dev
702018-08-17T06:33:29 *** plankers has quit IRC
712018-08-17T06:46:38 <ken2812221> The difference is linux only.
722018-08-17T06:49:35 *** jtimon has quit IRC
732018-08-17T07:29:56 <jonasschnelli> ken2812221, fanquake: you are using LXC, right? Docker uses LXC as well, right?
742018-08-17T07:54:47 *** SopaXorzTaker has joined #bitcoin-core-dev
752018-08-17T08:05:51 *** csknk has joined #bitcoin-core-dev
762018-08-17T08:36:02 *** d9b4bef9 has quit IRC
772018-08-17T08:37:09 *** d9b4bef9 has joined #bitcoin-core-dev
782018-08-17T08:41:55 *** AaronvanW has joined #bitcoin-core-dev
792018-08-17T08:46:27 *** AaronvanW has quit IRC
802018-08-17T09:05:21 <ken2812221> jonasschnelli: yes, I'm using LXC
812018-08-17T09:06:05 *** promag has joined #bitcoin-core-dev
822018-08-17T09:08:08 <promag> should #13501 be tagged bugfix?
832018-08-17T09:08:10 <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
842018-08-17T09:18:01 *** reallll has quit IRC
852018-08-17T09:18:31 *** belcher_ has joined #bitcoin-core-dev
862018-08-17T09:39:01 *** AaronvanW has joined #bitcoin-core-dev
872018-08-17T09:43:08 <fanquake> yes, also LXC
882018-08-17T10:44:05 *** Krellan has quit IRC
892018-08-17T10:44:54 *** Krellan has joined #bitcoin-core-dev
902018-08-17T10:59:32 *** arubi has quit IRC
912018-08-17T10:59:56 *** arubi has joined #bitcoin-core-dev
922018-08-17T11:01:27 *** Aaronvan_ has joined #bitcoin-core-dev
932018-08-17T11:02:03 *** Aaronva__ has joined #bitcoin-core-dev
942018-08-17T11:04:48 *** AaronvanW has quit IRC
952018-08-17T11:05:58 *** Aaronvan_ has quit IRC
962018-08-17T11:12:14 *** Krellan has quit IRC
972018-08-17T11:14:18 *** HoMM has joined #bitcoin-core-dev
982018-08-17T11:17:34 *** Krellan has joined #bitcoin-core-dev
992018-08-17T11:21:58 *** Victorsueca has quit IRC
1002018-08-17T11:23:18 *** Victorsueca has joined #bitcoin-core-dev
1012018-08-17T11:38:40 *** prod_ has quit IRC
1022018-08-17T11:50:39 *** itaseski has joined #bitcoin-core-dev
1032018-08-17T12:00:48 *** promag has quit IRC
1042018-08-17T12:02:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1052018-08-17T12:07:01 *** d9b4bef9 has quit IRC
1062018-08-17T12:08:09 *** d9b4bef9 has joined #bitcoin-core-dev
1072018-08-17T12:09:02 *** d9b4bef9 has quit IRC
1082018-08-17T12:10:09 *** d9b4bef9 has joined #bitcoin-core-dev
1092018-08-17T12:11:02 *** d9b4bef9 has quit IRC
1102018-08-17T12:12:08 *** d9b4bef9 has joined #bitcoin-core-dev
1112018-08-17T12:18:40 *** Victorsueca has quit IRC
1122018-08-17T12:18:44 *** Victor_sueca has joined #bitcoin-core-dev
1132018-08-17T12:58:55 *** brianhoffman has joined #bitcoin-core-dev
1142018-08-17T13:01:42 *** brianhoffman_ has joined #bitcoin-core-dev
1152018-08-17T13:03:26 *** brianhoffman has quit IRC
1162018-08-17T13:03:27 *** brianhoffman_ is now known as brianhoffman
1172018-08-17T13:18:05 *** rex4539 has quit IRC
1182018-08-17T13:54:38 *** belcher_ has quit IRC
1192018-08-17T13:56:36 *** belcher_ has joined #bitcoin-core-dev
1202018-08-17T14:13:05 *** Chris_Stewart_5 has quit IRC
1212018-08-17T14:26:24 <wumpus> I'm also using LXC
1222018-08-17T14:30:20 *** promag has joined #bitcoin-core-dev
1232018-08-17T14:30:26 *** michaelsdunn1 has joined #bitcoin-core-dev
1242018-08-17T14:31:45 *** csknk has quit IRC
1252018-08-17T14:38:49 <promag> wumpus: is there a way to compare case insensitive in the code?
1262018-08-17T14:40:38 *** belcher_ has quit IRC
1272018-08-17T14:45:03 *** belcher_ has joined #bitcoin-core-dev
1282018-08-17T14:47:32 <promag> ken2812221: would you mind testing #13501 in windows?
1292018-08-17T14:47:33 <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHubAsset 1Asset 1
1302018-08-17T14:48:31 <ken2812221> promag: Sure
1312018-08-17T14:48:53 <promag> thanks! I don't have access to one atm
1322018-08-17T14:50:47 <promag> wumpus: ^ no need to backport right?
1332018-08-17T14:51:31 <sipa> promag: convert both sides to lowercase and then compare? :)
1342018-08-17T14:52:06 <promag> sipa: yap, that's what I'm doing
1352018-08-17T14:52:39 <promag> sipa: I'll add an utility function
1362018-08-17T14:53:01 <promag> not sure if in util.h or utilstrencodings.h
1372018-08-17T14:53:07 <promag> suggestion?
1382018-08-17T14:53:41 <wumpus> promag: no, no need to backport, it's a very rare problem and not a regression -- would be great to solve it for 0.18
1392018-08-17T14:53:56 <promag> wumpus: agree
1402018-08-17T14:54:56 <ken2812221> promag: How about using regex?
1412018-08-17T14:54:57 <wumpus> promag: we'll need a locale-independent case conversion function, I guess
1422018-08-17T14:55:47 <wumpus> otherwise, this is going to do something different based on the user's language, which you don't want in http header handling
1432018-08-17T14:56:12 <promag> wumpus: like evutil_ascii_strcasecmp?
1442018-08-17T14:56:48 <wumpus> I guess you can use the libevent code, but only in code that already uses libevent directly
1452018-08-17T14:57:02 <wumpus> not in, say, utilstrencodings or util
1462018-08-17T14:58:00 <promag> maybe static bool HTTPRequest::CompareHeaders(a, b)?
1472018-08-17T14:59:22 <wumpus> promag: or make the headers function return the headers already lowercased
1482018-08-17T15:00:03 <promag> libevent doesn't expose that, and I'd like to dump what the client sends
1492018-08-17T15:00:57 <wumpus> ok, yes in that case a static function on HTTPRequest makes sense I suppose... I think it's somewhat hacky, implementing our own case-insensitive comparision function sounds super easy
1502018-08-17T15:02:00 <wumpus> now you convert from libevent string to std::string, then back to C string to pass it back for comparison...
1512018-08-17T15:02:24 <promag> wumpus: right, prefer that than own implementation
1522018-08-17T15:02:24 <wumpus> starting to think all of this isn't worth it just for some diagnostic logging
1532018-08-17T15:02:57 <wumpus> how many times do you really need to know the headers?
1542018-08-17T15:03:19 <wumpus> and you can't, say, start up wireshark or tcpdump
1552018-08-17T15:03:29 <wumpus> that has always worked great for me FWIW
1562018-08-17T15:05:01 <promag> sure, the idea is to have a out of the box way of seeing the requests
1572018-08-17T15:05:17 <promag> *headers
1582018-08-17T15:05:21 <wumpus> but why?
1592018-08-17T15:05:25 *** owowo has joined #bitcoin-core-dev
1602018-08-17T15:05:28 <wumpus> what was your motivation for this?
1612018-08-17T15:05:52 <wumpus> from my own experience at least I'm usually interested inthe request contents, not the headers
1622018-08-17T15:06:38 <promag> in 13501, I was puzzled to know why bitcoin-cli worked differently than AuthProxy
1632018-08-17T15:07:13 *** nullptr| has quit IRC
1642018-08-17T15:07:16 <promag> anyway, I'll finish the implementation and then close it
1652018-08-17T15:07:38 <wumpus> well other people might reasonably disagree
1662018-08-17T15:08:15 <promag> what if we dump it only if `-debug` is on?
1672018-08-17T15:08:18 <wumpus> it's just that personally, I think this is a rabbit hole not venturing into
1682018-08-17T15:08:23 <wumpus> worth*
1692018-08-17T15:09:14 <wumpus> I add debug code like this all the time to diagnose specific issues, but never even consider upstreaming it, because it served its purpose
1702018-08-17T15:10:39 <wumpus> and making it production-friendly implies "censoring" sensitive headers and all that
1712018-08-17T15:10:56 <wumpus> which in turn brings in utiltiy functions we don't need right now for other things
1722018-08-17T15:13:36 <wumpus> and then the new string sanitization issues that this brings
1732018-08-17T15:13:47 <wumpus> I'm sorry
1742018-08-17T15:14:03 *** nullptr| has joined #bitcoin-core-dev
1752018-08-17T15:14:20 <promag> lol
1762018-08-17T15:15:03 <promag> don't be, I'll just finish and close it because I agree with you
1772018-08-17T15:17:58 <wumpus> thanks
1782018-08-17T15:21:55 *** HoMM has quit IRC
1792018-08-17T15:34:46 *** Krellan has quit IRC
1802018-08-17T15:35:34 *** Krellan has joined #bitcoin-core-dev
1812018-08-17T15:43:29 *** rex4539 has joined #bitcoin-core-dev
1822018-08-17T15:56:47 <cfields_> catching up. I understand there is/was an issue with determinism with the gitian build. Resolved, or is that still the case?
1832018-08-17T16:07:29 <cfields_> I see, it's the Linux build. have
1842018-08-17T16:07:32 <cfields_> er
1852018-08-17T16:08:27 <cfields_> achow101 / jonasschnelli / ken2812221 / MarcoFalke / wumpus: can any of you share the gitian Linux output for comparison?
1862018-08-17T16:16:29 <cfields_> http://changelogs.ubuntu.com/changelogs/pool/main/g/glibc/glibc_2.27-3ubuntu1/changelog
1872018-08-17T16:18:32 <ken2812221> cfields: https://0bin.net/paste/Tae5ifPLYebHiKTi#uyXDywq91FOahuh+lc2E76cS9Qu-uINxkpxAHiL33BL
1882018-08-17T16:19:01 <ken2812221> This is lxc
1892018-08-17T16:19:06 <cfields_> ken2812221: thanks!
1902018-08-17T16:20:21 <cfields_> comparing now
1912018-08-17T16:21:43 <ken2812221> The difference is on bitcoin-qt, I've compared it before but I deleted the docker one.
1922018-08-17T16:21:50 *** promag has quit IRC
1932018-08-17T16:23:07 <cfields_> ah, ok
1942018-08-17T16:27:09 *** csknk has joined #bitcoin-core-dev
1952018-08-17T16:38:47 *** fanquake has quit IRC
1962018-08-17T16:51:30 <MarcoFalke> Thanks for the lxc gitian results. Will also take a look here...
1972018-08-17T17:05:41 *** jhfrontz has quit IRC
1982018-08-17T17:18:37 *** jhfrontz has joined #bitcoin-core-dev
1992018-08-17T17:41:39 *** Victor_sueca has quit IRC
2002018-08-17T17:42:13 *** Victorsueca has joined #bitcoin-core-dev
2012018-08-17T17:47:08 <achow101> jonasschnelli: docker doesn't use lxc as the backend anymore
2022018-08-17T17:47:53 <wumpus> achow101: but it uses the same kind of kernel namespacing that lxc uses, doesn't it?
2032018-08-17T17:48:10 <wumpus> (maybe in a slightly different way)
2042018-08-17T17:49:12 <achow101> wumpus: I think so?
2052018-08-17T17:51:34 <wumpus> it's somewhat surprising for that to cause a difference in build result!
2062018-08-17T17:52:10 *** Krellan has quit IRC
2072018-08-17T17:52:18 <wumpus> bitcoin-qt only suggests to me it's another non-determinism thing with the qt tooling, maybe file ordering or date/time in metadata in the qrc archives
2082018-08-17T17:55:40 <MarcoFalke> I made it use --jobs 16, if that helps
2092018-08-17T17:56:15 <achow101> I thought the non-determinism was with all of them
2102018-08-17T17:56:23 <achow101> MarcoFalke: did you use docker?
2112018-08-17T17:56:26 <MarcoFalke> jup
2122018-08-17T17:56:30 <MarcoFalke> diffoscope spits out a trillion lines ...
2132018-08-17T17:57:17 *** Krellan has joined #bitcoin-core-dev
2142018-08-17T17:57:57 <achow101> oh, nvm, i see what you meant by bitcoin-qt being the non-deterministic one
2152018-08-17T17:59:11 <achow101> cfields_: here are my binaries https://github.com/achow101/bitcoin/releases/tag/v0.17.0rc1
2162018-08-17T18:00:09 *** jtimon has joined #bitcoin-core-dev
2172018-08-17T18:01:04 <MarcoFalke> diffoscope: https://transfer.sh/8q9rT/diffoscope_51eb52972b_2_c7c606df_bitcoin-0.17.0-x86_64-linux-gnu.tar.gz.1
2182018-08-17T18:02:23 <MarcoFalke> only difference in qt
2192018-08-17T18:04:06 <gmaxwell> cmp the binaries and see if the difference is just a timestamp or something?
2202018-08-17T18:05:12 *** jhfrontz has quit IRC
2212018-08-17T18:06:56 <MarcoFalke> They have different sizes: 28286668 vs 28287142
2222018-08-17T18:08:23 <gmaxwell> pretty big difference in fact.
2232018-08-17T18:09:01 <wumpus> could still be a timestamp difference in compressed resource data
2242018-08-17T18:11:04 *** vexbuy has joined #bitcoin-core-dev
2252018-08-17T18:11:36 *** jeremyrubin has quit IRC
2262018-08-17T18:14:25 *** jhfrontz has joined #bitcoin-core-dev
2272018-08-17T18:16:21 <wumpus> gah for some reason I deleted the gitian output, need to rebuild before I can take a look
2282018-08-17T18:16:56 <gmaxwell> or a difference in file order
2292018-08-17T18:17:15 <jonasschnelli> gmaxwell: what do you think about the rekey not being a real rekey, I mean 'e' lives basically forever (until the connection dies). Would redoing the handshake (generate a new 'e') not make more sense?
2302018-08-17T18:17:42 <gmaxwell> No, it would just waste cpu time.
2312018-08-17T18:18:12 <gmaxwell> I'm not sure what 'e' refers to here, specifically.
2322018-08-17T18:18:23 <jonasschnelli> ephemeral key
2332018-08-17T18:19:16 <gmaxwell> The ephemeral key shouldn't even be remembered after the handshake is complete.
2342018-08-17T18:19:46 <gmaxwell> The hand shake computes an ephemeral key and outputs a session id, and encrypt and auth keys in each direction and forgets the ephemeral key.
2352018-08-17T18:20:10 <jonasschnelli> Yes. Right. Makes sense.
2362018-08-17T18:20:12 <gmaxwell> Rekey replaces the encrypt and auth keys with new ones derrived one way, so a host compromise can't go back and get old ones.
2372018-08-17T18:25:30 <gmaxwell> Rekey serves the purpose of limiting the amount of data that goes through the AEAD with a static key, since it's limited to 2^32 blocks by design, and as an additional benefit gets is some protection against being able to compromise a host in order to decrypt its past communications-- a kind of perfect forward secrecy which is relevant to us because we tend to have super long lived connections.
2382018-08-17T18:26:08 <jonasschnelli> ack
2392018-08-17T18:26:43 <jonasschnelli> Though 2^31 now with the rekey bit. :)
2402018-08-17T18:27:02 *** d9b4bef9 has quit IRC
2412018-08-17T18:27:04 <jonasschnelli> ah. you meant the ChaChaPoly1305, nm then
2422018-08-17T18:27:08 <gmaxwell> right.
2432018-08-17T18:27:56 <gmaxwell> running the DH again wouldn't actually accompish anything but be slow, so we'd have to worry about DOS attacks from rekeying too often-- which basically cannot happen when rekey is just a cheap one way function.
2442018-08-17T18:28:03 <jonasschnelli> Sorry for brining other wild ideas in: what about using UDP (long term)?
2452018-08-17T18:28:09 *** d9b4bef9 has joined #bitcoin-core-dev
2462018-08-17T18:29:23 <sipa> that's a lot more complicated
2472018-08-17T18:29:32 <sipa> as our protocol is inherently ordered
2482018-08-17T18:30:05 *** Emcy_ has quit IRC
2492018-08-17T18:30:07 <gmaxwell> It's very difficult to use UDP as a general thing because you have to have _working_ nat traversal. it's easy to traverse 50% of nats, but to get to 99.999% is very hard. webrtc in firefox has hundreds of thousands of lines of code related to nat traversal.
2502018-08-17T18:30:08 <sipa> you'd need to invent your own message based protocol with retransmissions and ordering
2512018-08-17T18:30:41 <gmaxwell> And as sipa notes, you also have to implement your own TCP analog, complete with flow control and ordering.
2522018-08-17T18:30:48 <jonasschnelli> i see
2532018-08-17T18:31:44 <gmaxwell> it think it would be really neat for someone to implement a UDP protocol for bitcoin that just runs as a proxy in another process.
2542018-08-17T18:32:23 *** Krellan has quit IRC
2552018-08-17T18:32:47 <gmaxwell> it's also possible to do UDP for a narrow subset of use pretty easily. E.g. block relay between hosts that do not require nat traversal (either no nat, or manually portmapped udp)-- fibre does that and it's relatively straight forward.
2562018-08-17T18:34:02 *** Krellan has joined #bitcoin-core-dev
2572018-08-17T18:36:21 <gmaxwell> Basically the things we know we can gain from using UDP: (1) better low priority congestion control for low priority traffic, e.g. support peers IBDing without impacting the local network, (2) avoiding head of line blocking e.g. a peer requesting a 100k transaction from us stops us from sending them a 10kb compact block until the 100k transaction is done. (3) avoiding retransmission head of l
2582018-08-17T18:36:21 <gmaxwell> ine blocking, where a single dropped packet delays communicating a block by at least one whole round trip. (4) better access to inbound peers due to nat hole punching.
2592018-08-17T18:36:31 *** Krellan has quit IRC
2602018-08-17T18:36:43 <gmaxwell> 2/3 are basically block transmission specific and don't apply to the rest of our protocol.
2612018-08-17T18:37:26 <gmaxwell> Which means they can be solved with a thing that only does blocks.
2622018-08-17T18:37:44 <gmaxwell> 4 is super hard because getting nat traversal working for the billion and one psycho devices out there is really complicated.
2632018-08-17T18:39:51 <gmaxwell> 1. is hard because it requires effectively a userspace TCP stack optimized for low priority.. all of it having a big network attack surface.
2642018-08-17T18:40:42 <gmaxwell> stuff like 1/4 don't need to be addressed from scratch, e.g. https://github.com/bittorrent/libutp
2652018-08-17T18:43:38 <gmaxwell> in terms of effort&risk vs reward, it's kind of crazy that we haven't done a NAT-PMP/NAT-PCP implementation.
2662018-08-17T18:44:29 *** grafcaps has joined #bitcoin-core-dev
2672018-08-17T19:03:46 <jonasschnelli> The current signal-rekey-in-length bit has one problem, time based rekeys would need an artificial message,... or maybe it's okay to wait for the next ping
2682018-08-17T19:04:11 <jonasschnelli> Because the signal is for : "next message will use the new key"
2692018-08-17T19:05:00 <jonasschnelli> No message == no way to signal the bit
2702018-08-17T19:07:06 <gmaxwell> I think it's fine to just wait for the next message for bitcoin core, since we ping with a perfectly fine interval.
2712018-08-17T19:07:24 <gmaxwell> For some other kind of client that didn't ping as often, they could trigger a ping at the relevant time.
2722018-08-17T19:14:26 <jonasschnelli> petertodd: did you post to the ML or did someone impersonates you?
2732018-08-17T19:17:49 <MarcoFalke> jonasschnelli: The mail is missing the typical sig he puts on, so clearly fake unless proven otherwise
2742018-08-17T19:18:10 <jonasschnelli> yes. He posts sometimes without GPG, but never without his text sig
2752018-08-17T19:18:16 <gmaxwell> Who cares?
2762018-08-17T19:18:40 <jonasschnelli> Indeed,.. maybe kanzure (the mod)
2772018-08-17T19:18:50 <gmaxwell> yet another dumb offtopic post, out of many. :)
2782018-08-17T19:19:36 <jonasschnelli> I thought it's a moderated list?!
2792018-08-17T19:20:06 <gmaxwell> I believe regular posters are whitelisted to bypass the moderation.
2802018-08-17T19:20:34 <jonasschnelli> by smtp from:? hell please no. :)
2812018-08-17T19:22:13 <gmaxwell> seems like it!
2822018-08-17T19:25:19 *** DougieBot5000 has quit IRC
2832018-08-17T19:25:23 *** aLK-[i] has quit IRC
2842018-08-17T19:25:47 *** DougieBot5000 has joined #bitcoin-core-dev
2852018-08-17T19:30:55 *** Aaronva__ has quit IRC
2862018-08-17T19:31:38 *** AaronvanW has joined #bitcoin-core-dev
2872018-08-17T19:33:42 *** tripleslash has quit IRC
2882018-08-17T19:33:51 *** CubicEarth has quit IRC
2892018-08-17T19:34:01 *** StopAndDecrypt has quit IRC
2902018-08-17T19:34:15 <MarcoFalke> The gitian issue is likely something with depends
2912018-08-17T19:34:25 <MarcoFalke> Anyone happen to have a gitian-builder/cache/* for lxc?
2922018-08-17T19:34:43 *** StopAndDecrypt has joined #bitcoin-core-dev
2932018-08-17T19:34:51 * gmaxwell wonders if someday we're going to find a compromised dependency this way.
2942018-08-17T19:34:59 *** tripleslash has joined #bitcoin-core-dev
2952018-08-17T19:35:03 *** CubicEarth has joined #bitcoin-core-dev
2962018-08-17T19:35:27 <MarcoFalke> gitian-builder/cache/bitcoin-linux-0.17/x86_64-linux-gnu/* I meant
2972018-08-17T19:35:36 *** cfields has joined #bitcoin-core-dev
2982018-08-17T19:37:55 *** tripleslash has quit IRC
2992018-08-17T19:39:16 *** tripleslash has joined #bitcoin-core-dev
3002018-08-17T19:40:11 *** SopaXorzTaker has quit IRC
3012018-08-17T19:45:41 *** ken2812221_ has joined #bitcoin-core-dev
3022018-08-17T19:47:33 *** Emcy has joined #bitcoin-core-dev
3032018-08-17T19:53:26 *** ken2812221_ has quit IRC
3042018-08-17T19:53:57 *** Emcy has quit IRC
3052018-08-17T19:56:51 *** cfields has quit IRC
3062018-08-17T19:57:12 *** cfields has joined #bitcoin-core-dev
3072018-08-17T19:59:10 *** cfields has quit IRC
3082018-08-17T19:59:33 *** csknk has quit IRC
3092018-08-17T20:01:25 *** cfields has joined #bitcoin-core-dev
3102018-08-17T20:02:27 <jonasschnelli> MarcoFalke: creating a tar.bz....
3112018-08-17T20:02:45 *** cfields has joined #bitcoin-core-dev
3122018-08-17T20:10:57 <MarcoFalke> jonasschnelli: thx
3132018-08-17T20:12:11 <jonasschnelli> MarcoFalke: https://bitcoin.jonasschnelli.ch/x86_64-linux-gnu.tar.bz
3142018-08-17T20:29:40 *** vexbuy has quit IRC
3152018-08-17T20:32:17 <MarcoFalke> docker deps: https://transfer.sh/f6AG9/x86_64-linux-gnu.tar.xz
3162018-08-17T20:32:23 <MarcoFalke> diffoscope says it is qt
3172018-08-17T20:33:21 *** belcher_ has quit IRC
3182018-08-17T20:33:24 <jonasschnelli> as always. :)
3192018-08-17T20:36:12 <MarcoFalke> https://transfer.sh/JN68e/qt_diffoscope
3202018-08-17T20:42:46 <MarcoFalke> .rodata.str1.1 has the size difference
3212018-08-17T20:43:51 <MarcoFalke> caused by "/usr/share/X11/xkb", it seems
3222018-08-17T20:44:02 *** jhfrontz has quit IRC
3232018-08-17T20:48:31 <cfields> MarcoFalke: thanks! is that the only difference?
3242018-08-17T20:48:37 <MarcoFalke> I think so
3252018-08-17T20:49:17 <MarcoFalke> The other changes seem due to the two rodata offsets
3262018-08-17T20:51:01 <cfields> hmm, I wonder if qt picked up a system xcb
3272018-08-17T20:52:18 *** xHire has quit IRC
3282018-08-17T20:54:10 <MarcoFalke> Are these are sting literals in translation units?
3292018-08-17T20:54:42 *** BGL has joined #bitcoin-core-dev
3302018-08-17T20:58:14 <cfields> MarcoFalke: I think I've got it, sec
3312018-08-17T20:59:31 <MarcoFalke> Ah it is in src/gui/configure.pri
3322018-08-17T21:01:27 <cfields> yea, it's a hard-coded thing that comes from configure
3332018-08-17T21:02:46 <cfields> MarcoFalke: are all arches non-deterministic?
3342018-08-17T21:02:52 <MarcoFalke> jup
3352018-08-17T21:03:43 *** Victorsueca has quit IRC
3362018-08-17T21:03:45 <cfields> ok
3372018-08-17T21:04:27 *** xHire has joined #bitcoin-core-dev
3382018-08-17T21:04:58 *** Victorsueca has joined #bitcoin-core-dev
3392018-08-17T21:12:16 <cfields> MarcoFalke: you happen to have a build.log for one of your linux builds?
3402018-08-17T21:13:09 *** treyzania has joined #bitcoin-core-dev
3412018-08-17T21:13:16 <kanzure> hmmmm wtf smtp from: is whitelisted?
3422018-08-17T21:13:22 <MarcoFalke> overwritten by my 0.16.2 build
3432018-08-17T21:13:30 <MarcoFalke> Maybe drahtbot has one
3442018-08-17T21:13:30 <kanzure> *what*?
3452018-08-17T21:15:51 <achow101> cfields: I have one
3462018-08-17T21:16:17 <MarcoFalke> cfields: Maybe https://drahtbot.space/gitian/bitcoin/bitcoin/885a45e323e900535ede2036b91a9118f12eb52b/bitcoin-linux-build.log
3472018-08-17T21:16:33 <MarcoFalke> for commit https://github.com/bitcoin/bitcoin/commit/885a45e323e900535ede2036b91a9118f12eb52b
3482018-08-17T21:16:38 <achow101> nvm, I don't
3492018-08-17T21:17:17 <cfields> MarcoFalke: yep! there's the problem! thanks.
3502018-08-17T21:17:48 <cfields> test config.gui.tests.xkbconfigroot gave result /usr/share/X11/xkb
3512018-08-17T21:17:49 <cfields> vs
3522018-08-17T21:17:58 <cfields> test config.gui.tests.xkbconfigroot gave result
3532018-08-17T21:18:21 <cfields> qt's stupid check assumes a native build.
3542018-08-17T21:18:21 *** xHire has quit IRC
3552018-08-17T21:18:37 <MarcoFalke> Can we force the thing to an empty string?
3562018-08-17T21:20:23 <MarcoFalke> My suggested fix would be to remove the for loop in src/gui/configure.pri:47
3572018-08-17T21:20:51 <cfields> I think we want to hard-code it to the most likely strong. Otherwise I would assume it may affect keyboard layout/bindings
3582018-08-17T21:22:29 <MarcoFalke> Thoug, both of the dirs are missing on the docker?
3592018-08-17T21:22:35 <cfields> MarcoFalke: we should just be able to set "-xkb-config-root=/usr/share/X11/xkb"
3602018-08-17T21:23:10 <cfields> MarcoFalke: I assume some people have that dir due to other installed packages
3612018-08-17T21:23:55 <MarcoFalke> Ah, I didn't understand. Yeah, set it to the most likely one
3622018-08-17T21:25:59 <cfields> sec, let's see what this path is actually used for
3632018-08-17T21:30:15 <cfields> yea, keymap stuff. And it looks like the path is hit.
3642018-08-17T21:30:33 <cfields> We should just use whatever value the previous binaries have used.
3652018-08-17T21:31:38 <cfields> rebuilding 0.16 to see what it did.
3662018-08-17T21:32:53 <MarcoFalke> cfields: 0.16.2 linux-build.log on docker trusty: https://transfer.sh/b8srP/build.log
3672018-08-17T21:33:52 <cfields> MarcoFalke: thanks!
3682018-08-17T21:33:55 <cfields> QMAKE_XKB_CONFIG_ROOT = /usr/share/X11/xkb
3692018-08-17T21:36:47 *** jhfrontz has joined #bitcoin-core-dev
3702018-08-17T21:37:23 <cfields> MarcoFalke: PR incoming. I'm just doing a quick local build with a phony value to make sure that it gets inserted even if the path doesn't exist.
3712018-08-17T21:37:46 <MarcoFalke> ok
3722018-08-17T21:37:58 <MarcoFalke> will be offline for about 40 mins
3732018-08-17T21:47:42 *** luke-jr has quit IRC
3742018-08-17T21:47:58 *** luke-jr has joined #bitcoin-core-dev
3752018-08-17T21:58:05 *** Emcy has joined #bitcoin-core-dev
3762018-08-17T22:00:15 *** itaseski has quit IRC
3772018-08-17T22:01:40 *** spinza has quit IRC
3782018-08-17T22:01:45 *** rls has joined #bitcoin-core-dev
3792018-08-17T22:03:22 <achow101> cfields: do you know why this wasn't a problem for earlier releases?
3802018-08-17T22:03:40 <achow101> I used the docker method for 0.16.2 and 0.16.1
3812018-08-17T22:03:57 <cfields> achow101: qt reworked their entire build-system for 5.8 iirc.
3822018-08-17T22:04:10 <cfields> I assume this is a regression
3832018-08-17T22:05:46 <cfields> https://bugreports.qt.io/browse/QTBUG-60005
3842018-08-17T22:06:16 *** jb55 has quit IRC
3852018-08-17T22:06:34 *** spinza has joined #bitcoin-core-dev
3862018-08-17T22:07:22 <cfields> yea, the -xkb-config-root switch is broken as well, we'll have to patch :(
3872018-08-17T22:12:30 *** michaelsdunn1 has quit IRC
3882018-08-17T22:41:42 *** masonicboom has joined #bitcoin-core-dev
3892018-08-17T22:45:53 *** masonicboom has quit IRC
3902018-08-17T22:45:54 *** Krellan has joined #bitcoin-core-dev
3912018-08-17T22:52:17 *** grafcaps has quit IRC
3922018-08-17T22:55:19 *** murrayn has quit IRC
3932018-08-17T23:03:45 *** masonicboom has joined #bitcoin-core-dev
3942018-08-17T23:04:27 <cfields> MarcoFalke: See #14000
3952018-08-17T23:04:29 <gribble> https://github.com/bitcoin/bitcoin/issues/14000 | depends: fix qt determinism by theuni · Pull Request #14000 · bitcoin/bitcoin · GitHub
3962018-08-17T23:26:10 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3972018-08-17T23:29:32 *** jb55 has joined #bitcoin-core-dev
3982018-08-17T23:36:57 *** rls has quit IRC
3992018-08-17T23:47:31 *** harding has quit IRC