12018-09-06T00:12:45  *** Victorsueca has quit IRC
  22018-09-06T00:13:44  *** Victorsueca has joined #bitcoin-core-dev
  32018-09-06T00:38:12  *** justan0theruser is now known as justanotheruser
  42018-09-06T00:39:23  *** justanotheruser is now known as cata-foxes
  52018-09-06T00:39:25  *** Murch has quit IRC
  62018-09-06T00:39:35  *** cata-foxes is now known as justanotheruser
  72018-09-06T00:42:00  *** masonicboom has quit IRC
  82018-09-06T00:49:01  *** Victorsueca has quit IRC
  92018-09-06T00:50:21  *** Victorsueca has joined #bitcoin-core-dev
 102018-09-06T01:07:36  *** spinza has quit IRC
 112018-09-06T01:08:50  *** fanquake has joined #bitcoin-core-dev
 122018-09-06T01:10:02  <fanquake> Probably easiest of the release-notes.md in master links to the wiki (as that is quicker and easier to make changes too).
 132018-09-06T01:10:18  <fanquake> Then the release notes can just be merged back into branches pre a tag/release. Or something like that.
 142018-09-06T01:11:51  <sipa> i'd actually prefer merging them now
 152018-09-06T01:12:01  <sipa> there isn't all that much activity on the wiki
 162018-09-06T01:13:05  *** AaronvanW has quit IRC
 172018-09-06T01:13:08  <fanquake> Fair enough. I can PR that later today if you'd like.
 182018-09-06T01:16:16  *** justanotheruser has quit IRC
 192018-09-06T01:28:06  *** plankers has quit IRC
 202018-09-06T01:28:09  *** spinza has joined #bitcoin-core-dev
 212018-09-06T01:39:05  <fanquake> sipa #14157
 222018-09-06T01:39:06  <gribble> https://github.com/bitcoin/bitcoin/issues/14157 | [0.17] doc: merge upstream release-notes from bitcoin-core/bitcoin-devwiki by fanquake · Pull Request #14157 · bitcoin/bitcoin · GitHub
 232018-09-06T01:40:02  <sipa> thanks!
 242018-09-06T01:46:11  *** justanotheruser has joined #bitcoin-core-dev
 252018-09-06T02:04:27  <fanquake> Is download.qt.io down for anyone else?
 262018-09-06T02:17:36  *** ken2812221_ has joined #bitcoin-core-dev
 272018-09-06T02:24:24  <fanquake> nvm, must have been an intermittent issue.
 282018-09-06T02:26:18  *** justanotheruser has quit IRC
 292018-09-06T02:30:21  *** miknotauro has quit IRC
 302018-09-06T02:43:25  *** justanotheruser has joined #bitcoin-core-dev
 312018-09-06T03:34:54  *** takinbo has joined #bitcoin-core-dev
 322018-09-06T03:48:27  *** sipa has quit IRC
 332018-09-06T03:50:27  *** miknotauro has joined #bitcoin-core-dev
 342018-09-06T03:55:19  *** ken2812221_ has quit IRC
 352018-09-06T03:57:14  *** sipa has joined #bitcoin-core-dev
 362018-09-06T03:58:34  *** fanquake has quit IRC
 372018-09-06T03:58:53  *** fanquake has joined #bitcoin-core-dev
 382018-09-06T03:59:37  *** fanquake has joined #bitcoin-core-dev
 392018-09-06T04:00:07  *** fanquake has quit IRC
 402018-09-06T04:00:26  *** fanquake has joined #bitcoin-core-dev
 412018-09-06T04:01:06  *** profmac has quit IRC
 422018-09-06T04:05:47  *** sipa_ has joined #bitcoin-core-dev
 432018-09-06T04:08:04  *** sipa has quit IRC
 442018-09-06T04:16:29  *** instagibbs has quit IRC
 452018-09-06T04:17:18  *** profmac has joined #bitcoin-core-dev
 462018-09-06T04:17:40  *** contrapumpkin has quit IRC
 472018-09-06T04:18:23  *** a5m0 has quit IRC
 482018-09-06T04:19:38  *** instagibbs has joined #bitcoin-core-dev
 492018-09-06T04:25:13  *** a5m0 has joined #bitcoin-core-dev
 502018-09-06T04:34:24  *** fanquake has joined #bitcoin-core-dev
 512018-09-06T04:37:46  *** fanquake has quit IRC
 522018-09-06T04:38:01  *** fanquake has joined #bitcoin-core-dev
 532018-09-06T06:15:28  *** a5m0 has quit IRC
 542018-09-06T06:17:54  *** fanquake has quit IRC
 552018-09-06T06:27:07  *** AaronvanW has joined #bitcoin-core-dev
 562018-09-06T06:31:43  *** AaronvanW has quit IRC
 572018-09-06T07:07:51  *** a5m0 has joined #bitcoin-core-dev
 582018-09-06T07:17:30  *** ryanofsky has joined #bitcoin-core-dev
 592018-09-06T07:25:35  <ken2812221> Both #10102 and #13937 are down
 602018-09-06T07:25:37  <gribble> https://github.com/bitcoin/bitcoin/issues/10102 | HTTP Error 500: Internal Server Error
 612018-09-06T07:25:38  <gribble> https://github.com/bitcoin/bitcoin/issues/13937 | HTTP Error 500: Internal Server Error
 622018-09-06T07:55:01  *** profmac has quit IRC
 632018-09-06T08:11:48  *** profmac has joined #bitcoin-core-dev
 642018-09-06T08:28:01  *** AaronvanW has joined #bitcoin-core-dev
 652018-09-06T08:32:36  *** AaronvanW has quit IRC
 662018-09-06T08:44:53  *** trotski2000 has joined #bitcoin-core-dev
 672018-09-06T08:46:39  *** Zenton has joined #bitcoin-core-dev
 682018-09-06T09:15:23  <wumpus> sipa_: before final
 692018-09-06T09:15:50  <wumpus> sipa: editing release notes should *not* happen in the branch right now, who is doing this?
 702018-09-06T09:16:32  <wumpus> editing the release notes should happen on the wiki
 712018-09-06T09:16:37  <wumpus> if anyone is doing something else, point them there
 722018-09-06T09:16:56  <wumpus> FWIW the wiki is also the 'preliminary release notes' link sent in the rc announcements
 732018-09-06T09:39:27  *** AaronvanW has joined #bitcoin-core-dev
 742018-09-06T10:03:38  <sipa_> wumpus: ok
 752018-09-06T10:12:03  *** Guyver2 has joined #bitcoin-core-dev
 762018-09-06T11:10:15  *** drexl has joined #bitcoin-core-dev
 772018-09-06T11:23:40  *** giaki3003 has joined #bitcoin-core-dev
 782018-09-06T11:23:49  *** giaki3003 has left #bitcoin-core-dev
 792018-09-06T11:24:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 802018-09-06T11:53:49  *** promag has joined #bitcoin-core-dev
 812018-09-06T11:57:58  *** promag has quit IRC
 822018-09-06T12:21:04  *** Chris_Stewart_5 has quit IRC
 832018-09-06T12:30:57  *** miknotauro has quit IRC
 842018-09-06T12:55:22  <wumpus> ok, https://github.com/bitcoin/bitcoin/milestone/33 has only release notes TODOs left, let's tag 0.17.0rc3 ?
 852018-09-06T13:00:51  *** belcher_ has joined #bitcoin-core-dev
 862018-09-06T13:08:16  *** copumpkin has joined #bitcoin-core-dev
 872018-09-06T13:12:56  *** RubenSomsen has joined #bitcoin-core-dev
 882018-09-06T13:13:15  <ken2812221> ACK
 892018-09-06T13:25:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 902018-09-06T13:27:10  *** rafalcpp has joined #bitcoin-core-dev
 912018-09-06T13:43:02  *** SopaXorzTaker has joined #bitcoin-core-dev
 922018-09-06T13:50:44  *** elichai2 has joined #bitcoin-core-dev
 932018-09-06T13:52:03  <wumpus>  * [new tag]                                                                           v0.17.0rc3 -> v0.17.0rc3
 942018-09-06T13:56:09  *** itaseski has joined #bitcoin-core-dev
 952018-09-06T14:01:14  <achow101> yay
 962018-09-06T14:18:42  *** owowo has quit IRC
 972018-09-06T14:23:12  *** owowo has joined #bitcoin-core-dev
 982018-09-06T14:29:23  *** AaronvanW has quit IRC
 992018-09-06T14:30:27  *** profmac has quit IRC
1002018-09-06T14:40:01  *** AaronvanW has joined #bitcoin-core-dev
1012018-09-06T14:44:25  *** AaronvanW has quit IRC
1022018-09-06T15:05:21  <provoostenator> ken2812221 they're down for me too. I sent an email to Github yesterday about another one; they're looking into it.
1032018-09-06T15:11:04  *** polydin has quit IRC
1042018-09-06T15:23:27  *** Emcy has quit IRC
1052018-09-06T15:24:39  *** Emcy has joined #bitcoin-core-dev
1062018-09-06T15:28:20  *** harrymm_ has joined #bitcoin-core-dev
1072018-09-06T15:28:42  *** harrymm has quit IRC
1082018-09-06T15:32:48  *** harrymm_ has quit IRC
1092018-09-06T15:38:24  *** harrymm has joined #bitcoin-core-dev
1102018-09-06T15:40:45  *** AaronvanW has joined #bitcoin-core-dev
1112018-09-06T15:43:15  *** harrymm has quit IRC
1122018-09-06T15:46:36  *** AaronvanW has quit IRC
1132018-09-06T15:55:33  *** harrymm has joined #bitcoin-core-dev
1142018-09-06T16:11:24  *** Rootsudo has joined #bitcoin-core-dev
1152018-09-06T16:19:21  *** Victorsueca has quit IRC
1162018-09-06T16:20:42  *** Victorsueca has joined #bitcoin-core-dev
1172018-09-06T16:32:45  *** rafalcpp has quit IRC
1182018-09-06T16:32:45  *** queip has quit IRC
1192018-09-06T16:49:29  *** Randolf has joined #bitcoin-core-dev
1202018-09-06T17:10:15  *** Randolf has quit IRC
1212018-09-06T17:13:55  *** polydin has joined #bitcoin-core-dev
1222018-09-06T17:14:10  <wumpus> same problem here
1232018-09-06T17:18:11  *** Guyver2 has quit IRC
1242018-09-06T17:37:24  *** Krellan has quit IRC
1252018-09-06T17:39:39  <jamesob> anyone know if we have an easy way of testing zeromq PUBs?
1262018-09-06T17:40:11  <jamesob> i.e. triggering publications for the purpose of testing a client
1272018-09-06T17:41:30  <wumpus> regtest + zmq block notifications?
1282018-09-06T17:41:32  *** Zenton has quit IRC
1292018-09-06T17:41:48  <wumpus> (e.g. the same way as the functional test does it)
1302018-09-06T17:42:48  *** AaronvanW has joined #bitcoin-core-dev
1312018-09-06T17:44:02  <jamesob> yeah, that's probably easiest. thanks wumpus
1322018-09-06T17:46:43  <Chris_Stewart_5> Was there a bug in master recently related to -datadir?
1332018-09-06T17:47:33  *** AaronvanW has quit IRC
1342018-09-06T17:47:51  <wumpus> Chris_Stewart_5: not that I know o, what kind of bug?
1352018-09-06T17:49:52  <Chris_Stewart_5> Ooh, nvm. Seems it might have been related to a systemd config
1362018-09-06T17:56:02  *** profmac has joined #bitcoin-core-dev
1372018-09-06T18:02:32  *** SopaXorzTaker has quit IRC
1382018-09-06T18:02:40  *** hebasto has joined #bitcoin-core-dev
1392018-09-06T18:03:20  *** Rootsudo has quit IRC
1402018-09-06T18:13:06  *** itaseski has quit IRC
1412018-09-06T18:26:24  <wumpus> right
1422018-09-06T18:29:41  *** jtimon has joined #bitcoin-core-dev
1432018-09-06T18:34:25  <jonasschnelli> sipa_: a) is the master key fingerprint optional?
1442018-09-06T18:34:55  <sipa_> jonasschnelli: where?
1452018-09-06T18:34:59  *** sipa_ is now known as sipa
1462018-09-06T18:35:17  <jonasschnelli> sipa: in the descriptor. :)
1472018-09-06T18:35:26  <jonasschnelli> would ... pkh(d34db33f/44'/0'/0':xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL/1/*)
1482018-09-06T18:35:39  <sipa> that's valid
1492018-09-06T18:35:43  <jonasschnelli> also work as pkh(xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL/1/*)
1502018-09-06T18:35:48  <sipa> yes of course
1512018-09-06T18:35:53  <jonasschnelli> Oh... NM, that is already implemented..
1522018-09-06T18:36:04  <sipa> it just doesn't have key origin info if you don't specify it
1532018-09-06T18:36:37  <jonasschnelli> Is a key origin always fingerprint & path or can it just be the fingerprint?
1542018-09-06T18:36:50  <sipa> it can just be fingerprint
1552018-09-06T18:36:53  <sipa> in case the path is empty
1562018-09-06T18:37:35  <jonasschnelli> okay... but that wouldn't not imply that the fingerprint must be the related xpubs fingerprint?
1572018-09-06T18:37:54  <sipa> uh, i guess it would be
1582018-09-06T18:38:13  <sipa> yeah, there isn't much sense in that case,  i guess
1592018-09-06T18:38:16  <jonasschnelli> I'm asking because the fingerprint could also be a hint to the signing device without revealing the path
1602018-09-06T18:38:19  <sipa> or at least it should be enforced
1612018-09-06T18:39:00  *** promag has joined #bitcoin-core-dev
1622018-09-06T18:39:01  *** promag has quit IRC
1632018-09-06T18:39:17  *** promag has joined #bitcoin-core-dev
1642018-09-06T18:39:32  *** promag has quit IRC
1652018-09-06T18:53:40  <jonasschnelli> sipa: would it make sense to always support 'h' as hardened key indicator...
1662018-09-06T18:53:47  <jonasschnelli> The parsing does not https://github.com/bitcoin/bitcoin/pull/13723/files#diff-0480c57f121cd5daa1bc3a495a51ebaeR562
1672018-09-06T18:54:04  <achow101> jonasschnelli: IMO yes. that's part of one my import things PRs
1682018-09-06T18:54:08  <jonasschnelli> And I just looked up, ... there is no "clear" standard for derivation path (BIP32 doesn't mention it specific)
1692018-09-06T18:54:12  <achow101> the BIP uses h/H too
1702018-09-06T18:54:41  <jonasschnelli> achow101: is there a spec how to specify a derivation path? I think this is something that is vaguely defined.
1712018-09-06T18:55:02  <sipa> jonasschnelli: the parser should always support h wherever ' is supported
1722018-09-06T18:55:09  <jonasschnelli> agree
1732018-09-06T18:55:11  <sipa> there are even tests for that
1742018-09-06T18:55:24  <achow101> jonasschnelli: doesn't bip 32 say>?
1752018-09-06T18:55:48  *** clarkmoody has joined #bitcoin-core-dev
1762018-09-06T18:56:29  <sipa> jonasschnelli: https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp#L439
1772018-09-06T18:57:22  *** Krellan has joined #bitcoin-core-dev
1782018-09-06T18:59:54  <jonasschnelli> sipa: but https://github.com/bitcoin/bitcoin/pull/13723/files#diff-0480c57f121cd5daa1bc3a495a51ebaeR562 ?
1792018-09-06T19:00:26  <sipa> jonasschnelli: that's not used by the descriptor code
1802018-09-06T19:00:29  *** elichai2 has quit IRC
1812018-09-06T19:00:30  <wumpus> #startmeeting
1822018-09-06T19:00:30  <lightningbot> Meeting started Thu Sep  6 19:00:30 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
1832018-09-06T19:00:30  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
1842018-09-06T19:00:39  <gmaxwell> Hi
1852018-09-06T19:00:57  <achow101> hi
1862018-09-06T19:01:00  <jonasschnelli> hi
1872018-09-06T19:01:08  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircu
1882018-09-06T19:01:11  <wumpus> it codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
1892018-09-06T19:01:42  <wumpus> PSA: v0.17.0rc3 has been tagged
1902018-09-06T19:01:56  <wumpus> topics?
1912018-09-06T19:02:00  <sipa> \o/
1922018-09-06T19:02:28  *** meshcollider_ has joined #bitcoin-core-dev
1932018-09-06T19:02:44  <meshcollider> hi
1942018-09-06T19:03:03  <gmaxwell> Seems things have been kind of quiet.
1952018-09-06T19:03:21  <wumpus> yes, quiet week
1962018-09-06T19:03:55  <provoostenator> hi
1972018-09-06T19:04:00  <jnewbery> hi
1982018-09-06T19:04:08  <gmaxwell> phantomcircuit (your ping got cut, perhaps you'd like to talk about your poll() work, if you're around)
1992018-09-06T19:04:08  <Chris_Stewart_5> Thoughts on merging #12775 ? Do we want it enabled in .travis.yml by default?
2002018-09-06T19:04:11  <gribble> https://github.com/bitcoin/bitcoin/issues/12775 | Integration of property based testing into Bitcoin Core by Christewart · Pull Request #12775 · bitcoin/bitcoin · GitHub
2012018-09-06T19:04:15  *** promag has joined #bitcoin-core-dev
2022018-09-06T19:04:29  <wumpus> Chris_Stewart_5: yeah that one should be merged...
2032018-09-06T19:04:40  <phantomcircuit> Hello
2042018-09-06T19:04:44  <Chris_Stewart_5> sorry, RAPIDCHECK=1 in DEP_OPTS
2052018-09-06T19:05:19  <wumpus> Chris_Stewart_5: and it makes sense to have it enabled for at least one travis build if it's merged, after all, otherwise it'll probably get under-tested
2062018-09-06T19:05:19  *** promag has quit IRC
2072018-09-06T19:05:31  <phantomcircuit> i'm working on implementing poll on *nix systems, the first step is to cleanup ThreadSocketHandler to separate the select() logic from the rest of the logic
2082018-09-06T19:05:41  <wumpus> oh topic
2092018-09-06T19:05:50  <wumpus> #topic poll() (phantoncircuit)
2102018-09-06T19:06:02  <Chris_Stewart_5> wumpus: I'll try to take care of that in the next 2 days
2112018-09-06T19:06:18  <phantomcircuit> i've started that in #14147 (which is as far as im going to go in that particular pr)
2122018-09-06T19:06:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14147 | net: Refactor ThreadSocketHandler by pstratem · Pull Request #14147 · bitcoin/bitcoin · GitHub
2132018-09-06T19:06:19  <wumpus> Chris_Stewart_5: I mean it'd be perfectly valid to say you don't want to hold up this PR for that, and do it later
2142018-09-06T19:06:25  <wumpus> Chris_Stewart_5: just be clear :)
2152018-09-06T19:07:00  <phantomcircuit> next step after that is going to be to separate the socket handling logic from the select() logic
2162018-09-06T19:07:03  <wumpus> phantomcircuit: good
2172018-09-06T19:07:11  <gmaxwell> phantomcircuit: my understanding is that your refactors are driven by a more complete set of commits that go all the way to actually enabling poll, you just haven't PRed the ret, right?
2182018-09-06T19:07:28  <phantomcircuit> gmaxwell, right
2192018-09-06T19:08:21  <wumpus> so enabling poll turns out to be more work than was expected, I was told at some point it'd basically be a five-line patch, or is this because you want to do it properly? :)
2202018-09-06T19:09:08  <sipa> it seems we're pretty close on track for the 0.17 release schedule
2212018-09-06T19:09:11  <gmaxwell> he's doing it more properly.
2222018-09-06T19:10:17  <gmaxwell> ISTM at least the current PR is a perfectly fine change even considered independantly of poll().
2232018-09-06T19:10:29  <phantomcircuit> doing it more property, there's a smaller patchset possible but that does things like iterate over every fd for every cnode looking for it's own fd
2242018-09-06T19:10:46  <phantomcircuit> which is O(n^2) worst case for n = vNodes.size()
2252018-09-06T19:10:53  <phantomcircuit> so probably dont want to do that
2262018-09-06T19:10:58  <wumpus> ok, yes, that would be good to avoid, we don't want to worsen performance
2272018-09-06T19:11:21  <wumpus> right, thanks for the explanation, it's common for people to underestimate how much work something is anyhow :)
2282018-09-06T19:11:52  <gmaxwell> I think I made the 5 line comment before, but it was based on an actual ~5 line patch that matt was previously using. :P
2292018-09-06T19:12:07  <phantomcircuit> and indeed the current patchset is specifically selected to make sense even without poll() (but that's certainly why im doing it)
2302018-09-06T19:13:37  <wumpus> should we add 14147 to high priority for review? I suppose it's blocking further work for you
2312018-09-06T19:13:42  <phantomcircuit> poll() works more like epoll than select, specifically there's no equivalent for FD_ISSET, so either you need to keep some sort of mapping or iterate over them
2322018-09-06T19:14:11  <phantomcircuit> i believe matts patchset just iterated which is trivial but certainly not what we want to do
2332018-09-06T19:14:25  <wumpus> indeed
2342018-09-06T19:14:35  <wumpus> it was just aproof of concept then
2352018-09-06T19:14:36  <sipa> makes sense
2362018-09-06T19:14:44  <phantomcircuit> wumpus, im building off that pr for the rest of the poll() logic assuming it'll eventually be fine
2372018-09-06T19:15:14  <phantomcircuit> there's 7 commits to that pr and 100 loc changed but mostly that's just moving things
2382018-09-06T19:15:18  <BlueMatt> I mean iterating is essentially fine, really
2392018-09-06T19:15:18  <gmaxwell> It's a nearly trivial review in any case. It's just moving things around.
2402018-09-06T19:15:27  <BlueMatt> its not like we're handling 10k connections
2412018-09-06T19:15:36  <gmaxwell> ?w=1 eliminates 90% of the diff. :)
2422018-09-06T19:15:40  <BlueMatt> (and less error-prone than tracking things with CNodes)
2432018-09-06T19:15:48  <BlueMatt> cause we've had errors in the past with CNode deletion ordering....
2442018-09-06T19:15:57  <BlueMatt> or, if not errors, shitloads of complication that made review hard
2452018-09-06T19:16:32  <gmaxwell> I agree that iterating is fine for a few hundred connections, but I think we'd prefer to avoid it unless we really do get mired in review.
2462018-09-06T19:16:38  <wumpus> anyhow, let's review phantomcircuit 's work
2472018-09-06T19:16:44  <BlueMatt> wumpus: yea, fair
2482018-09-06T19:16:47  <wumpus> I don't see the point of discussing this now
2492018-09-06T19:16:52  <BlueMatt> yep
2502018-09-06T19:17:39  <wumpus> if it's really so hard to review (there's nothing what people have said that would suggest that) then of course we can look for another solution
2512018-09-06T19:17:46  <wumpus> any other topics?
2522018-09-06T19:17:48  <gmaxwell> +1
2532018-09-06T19:18:23  <gmaxwell> sipa: wumpus: Where did we ever land in replacing the openssl RNG?
2542018-09-06T19:18:35  <wumpus> #topic replacing the openssl RNG
2552018-09-06T19:18:44  <wumpus> good question, I think that kind of stranded at some point
2562018-09-06T19:18:47  <sipa> gmaxwell: i don't feel like spending much work on it
2572018-09-06T19:18:54  <gmaxwell> It would be nice if we could finally be rid of the dependency in 0.18.
2582018-09-06T19:19:08  <sipa> but we should probably write some requirements for what it needs to be replaced with
2592018-09-06T19:19:10  <wumpus> ok so someone would need to pick up sipa 's old work probably
2602018-09-06T19:19:43  <gmaxwell> I think in part because we reasonably wanted to break some of it off into a library, and then that sounded like too much work. :)
2612018-09-06T19:19:56  <sipa> yes
2622018-09-06T19:20:00  <meshcollider> Is there an old PR or something
2632018-09-06T19:20:03  <wumpus> I don't care about that part anymore
2642018-09-06T19:20:21  <meshcollider> Or a gist
2652018-09-06T19:20:27  <moneyball> suggested topic: Tokyo CoreDev topic ideas
2662018-09-06T19:20:32  <gmaxwell> I'd be happy to do something, but I also really don't feel like making a library right now. (or rather, I'd prefer to spend that time working on something else)
2672018-09-06T19:20:36  <wumpus> just put it in its own subdirectory under src, someone that wants it as library can do the work for that
2682018-09-06T19:21:07  <wumpus> if not, there's no need to do build system work etc
2692018-09-06T19:21:09  <provoostenator> meshcollider: #10299
2702018-09-06T19:21:11  <gribble> https://github.com/bitcoin/bitcoin/issues/10299 | Remove OpenSSL by sipa · Pull Request #10299 · bitcoin/bitcoin · GitHub
2712018-09-06T19:21:18  *** owowo has quit IRC
2722018-09-06T19:21:21  <meshcollider> provoostenator: thanks
2732018-09-06T19:21:30  <gmaxwell> (in particular, librarizing it is hard because a library ought to be reentrant and probably C callable ... which are things that don't matter much for our own use)
2742018-09-06T19:21:38  <wumpus> I know all too well how frustrating making libraries for c++ is
2752018-09-06T19:21:57  <luke-jr> why would it be C++?
2762018-09-06T19:22:02  <wumpus> lol...
2772018-09-06T19:22:06  <provoostenator>  CoreDev topic ideas: hardware wallet support, faster wallet bootstrap (i.e. sync in background)
2782018-09-06T19:22:17  <wumpus> yesl et's start piling up other requirements as well
2792018-09-06T19:22:20  <wumpus> ok, another topic?
2802018-09-06T19:22:28  <gmaxwell> luke-jr: So one of the things we could do for it would be rewrite in C, but thats something that people don't feel like doing.
2812018-09-06T19:22:29  <provoostenator> Probably continue the coin selection fun?
2822018-09-06T19:22:42  <wumpus> let's rewrite it in rust !
2832018-09-06T19:23:01  <moneyball> wumpus suggested topic: Tokyo CoreDev topic ideas
2842018-09-06T19:23:14  <kanzure> hi.
2852018-09-06T19:23:20  <wumpus> #topic Tokyo CoreDev topic ideas (provoostenator)
2862018-09-06T19:23:23  <sipa> CoreDev topics: descriptors and extensions to them
2872018-09-06T19:23:36  <kanzure> already on there
2882018-09-06T19:23:39  <jtimon> rust all your problems
2892018-09-06T19:23:47  <kanzure> what would you guys like to hjear from other people, and/or from yourselves
2902018-09-06T19:23:53  <moneyball> kanzure has reached out to some folks, and i plan to as well to solicit topic ideas. also feel free to share them here as you are already doing :)
2912018-09-06T19:23:55  <wumpus> jtimon: I have C/C++ burnout
2922018-09-06T19:24:22  <kanzure> oh no that's terminal
2932018-09-06T19:24:38  <jtimon> wumpus: well, you write python too :p
2942018-09-06T19:24:47  <wumpus> jtimon: python is still somewhat cute
2952018-09-06T19:25:01  * jonasschnelli can't be in Tokyo :/
2962018-09-06T19:25:11  <achow101> kanzure: moneyball: what are the current topics, if any?
2972018-09-06T19:25:21  <gmaxwell> I'd like to see kallewoof's progress on input grouping get done.
2982018-09-06T19:25:23  <sipa> wumpus: thankfully carbon doesn't rust
2992018-09-06T19:25:32  *** promag has joined #bitcoin-core-dev
3002018-09-06T19:25:37  <wumpus> sipa: heh!
3012018-09-06T19:26:25  <kanzure> achow101: PSBT, hardware wallet stuff, output descriptors, input grouping, schnorr signatures BIP stuff, forward blocks, client-side filtering, lattice-based digital signatures, coin selection, #13869
3022018-09-06T19:26:26  <gribble> https://github.com/bitcoin/bitcoin/issues/13869 | Filename and command line encoding issue on Windows · Issue #13869 · bitcoin/bitcoin · GitHub
3032018-09-06T19:26:36  <gmaxwell> Maybe people could think about rhavar's bustapay... I think it might be reasonable to support it in the bitcoin core wallet.
3042018-09-06T19:26:52  <gmaxwell> lattice-based digital signatures?!?!
3052018-09-06T19:26:53  <kanzure> who would be a good candidate to fly the flag of bustapay
3062018-09-06T19:27:04  <kanzure> gmaxwell: it's a meshcollider thing
3072018-09-06T19:27:17  <moneyball> here is what kanzure has collected so far, from about 10 people:
3082018-09-06T19:27:17  <moneyball> * partially signed bitcoin transactions
3092018-09-06T19:27:17  <moneyball> * hardware wallet support
3102018-09-06T19:27:17  <moneyball> * script validation
3112018-09-06T19:27:17  <moneyball> * input grouping
3122018-09-06T19:27:17  <moneyball> * output descriptors
3132018-09-06T19:27:17  <moneyball> * Schnorr signatures BIP
3142018-09-06T19:27:18  <moneyball> * k-of-n threshold signatures using Schnorr
3152018-09-06T19:27:18  <moneyball> * forward blocks
3162018-09-06T19:27:19  <moneyball> * hardware wallet support in Bitcoin Core
3172018-09-06T19:27:19  <moneyball> * status of client-side filtering and neutrino
3182018-09-06T19:27:20  <moneyball> * client side filtering
3192018-09-06T19:27:40  <sipa> please don't paste long lists in IRC
3202018-09-06T19:27:50  <meshcollider> Heh I don't think it's worth discussing lattice sigs at CoreDev
3212018-09-06T19:27:50  <moneyball> oh, sorry
3222018-09-06T19:27:57  <meshcollider> That's just what I'm working on
3232018-09-06T19:28:00  <achow101> kanzure: re bustapay, me? I was part of the meeting that came up with the basis for that
3242018-09-06T19:28:04  <kanzure> okay it is you
3252018-09-06T19:28:21  <kanzure> done
3262018-09-06T19:28:43  *** owowo has joined #bitcoin-core-dev
3272018-09-06T19:29:00  <jnewbery> maybe offtopic for now, but how is bustapay different from p2ep?
3282018-09-06T19:29:02  <wumpus> nah pasting 12 lines which are relevant topics isn't that bad, but yes, never do that with error messages / logs pelase :)
3292018-09-06T19:29:13  <BlueMatt> "forward blocks"
3302018-09-06T19:29:15  <BlueMatt> ?
3312018-09-06T19:29:20  <instagibbs> BlueMatt, maaku's thing
3322018-09-06T19:29:22  <instagibbs> IIRC
3332018-09-06T19:29:30  <kanzure> BlueMatt: time travel exploit
3342018-09-06T19:29:46  <achow101> jnewbery: it's basically the same thing, but actually implemented
3352018-09-06T19:30:02  <gmaxwell> jnewbery: actually implementable and not woo.
3362018-09-06T19:30:26  <kanzure> moneyball and i will be heckling each of you for more topic suggestions soon, thanks for the input
3372018-09-06T19:30:28  <achow101> it cuts out some of the complexity as a tradeoff for a possible and very small (IMO) privacy risk
3382018-09-06T19:30:48  <BlueMatt> ah, right, the exploit-timeward-to-change-blocktime-and-fork-to-lock-it-in thing....I feel like thats something that needs more broad bitcoin-dev or whatever discussion, its not something to be discussed a technical planning meeting
3392018-09-06T19:30:50  <wumpus> do you need even more topics? seems a decent list
3402018-09-06T19:31:07  <kanzure> this list is tiny compared to last few times; it'll grow.
3412018-09-06T19:31:07  <BlueMatt> dandelion, depending on who's there, should be discussed
3422018-09-06T19:31:08  <wumpus> none trivial
3432018-09-06T19:31:13  <jtimon> kallewoof: has been working on a "signet" branch I'm currently reviewing and testing that allows the creation of signed blocks testchains ala elements, not sure if that could be a topic, but I would be very happy to see something like that get into master at some point
3442018-09-06T19:31:14  <instagibbs> BlueMatt, ACK
3452018-09-06T19:31:29  <sipa> agree with BlueMatt as well
3462018-09-06T19:31:50  <kanzure> jtimon: added
3472018-09-06T19:31:52  <kanzure> BlueMatt: added
3482018-09-06T19:31:55  <gmaxwell> agree with BlueMatt as well
3492018-09-06T19:32:03  <BlueMatt> agree with BlueMatt as well
3502018-09-06T19:32:06  <BlueMatt> wait, hmmm
3512018-09-06T19:32:15  <kanzure> don't do that you'll break the universe
3522018-09-06T19:32:42  <sipa> try typing 'google' into google
3532018-09-06T19:33:18  <michagogo> Or ‘recursion’
3542018-09-06T19:33:20  <BlueMatt> Did you mean recursion?
3552018-09-06T19:33:32  <sipa> BlueMatt: it was an it crowd joke
3562018-09-06T19:33:56  <provoostenator> Something that might be worth putting in the meeting minutes: multiple PR's are suffering from 500 server error for multiple days. Apparantly Github is aware of the problem.
3572018-09-06T19:34:07  *** farmerwampum has joined #bitcoin-core-dev
3582018-09-06T19:34:15  * BlueMatt emailed support and got back a "we're looking into it, its visible on a few projects"
3592018-09-06T19:34:31  <achow101> do we have so many PRs and issues that we broke github?
3602018-09-06T19:34:39  <wumpus> github is falling apart, so soon after ms took it over
3612018-09-06T19:34:54  <sipa> nah, it was falling apart before
3622018-09-06T19:34:57  <wumpus> I think they switched the server hosting to windows 95
3632018-09-06T19:35:05  <sipa> haha
3642018-09-06T19:35:38  <wumpus> if it helps I'll send a mail too
3652018-09-06T19:35:38  <luke-jr> at least not ME
3662018-09-06T19:35:50  <wumpus> haah then it would alrady be gone
3672018-09-06T19:35:57  <kanzure> other topics?
3682018-09-06T19:36:10  <gmaxwell> WinCE.
3692018-09-06T19:36:20  <michagogo> How did everyone get a bionic gitian environment working?
3702018-09-06T19:36:28  <meshcollider> MS haven't actually taken over yet have they
3712018-09-06T19:36:32  <luke-jr> michagogo: I ended up installing from the iso by hand
3722018-09-06T19:36:36  <sipa> https://i.imgur.com/zh4F55R.png
3732018-09-06T19:36:40  <wumpus> deep magic voodoo rituals
3742018-09-06T19:36:44  <luke-jr> michagogo: and patching gitian to work with it
3752018-09-06T19:36:52  <wumpus> #topic gitian build on bionic
3762018-09-06T19:36:58  <meshcollider> sipa: lol
3772018-09-06T19:37:07  <provoostenator> Works
3782018-09-06T19:37:10  <wumpus> with LXC it's easy, just the standard steps
3792018-09-06T19:37:32  <achow101> both lxc and docker work
3802018-09-06T19:37:50  <achow101> but according to luke-jr kvm is broken again as apparently the new vmbuilder doesn't work?
3812018-09-06T19:37:58  <achow101> (I haven't tried yet)
3822018-09-06T19:38:02  <michagogo> wumpus: make-base-vm —lxc —suite bionic seemed to work for me (finished without error), but the result seems broken
3832018-09-06T19:38:17  <jonasschnelli> define "broken"?
3842018-09-06T19:38:30  <luke-jr> michagogo: latest gitian?
3852018-09-06T19:38:36  <michagogo> Yep
3862018-09-06T19:38:42  <michagogo> (On a xenial host)
3872018-09-06T19:39:21  <wumpus> these additional steps are what I had to do for gitian building on debian 9.5 with LXC: https://gist.github.com/laanwj/c62e101bfd68718f0686926dfd10666b
3882018-09-06T19:40:22  <wumpus> (e.g. I needed a new lxc version, as well as a new version of debootstrap as it was lacking the bionic script)
3892018-09-06T19:41:07  <wumpus> if it built the image then I think that part went right, but you might have an too-old version of LXC that cannot handle bionic
3902018-09-06T19:41:31  <wumpus> I don't remember what the minimum version is that works, jonasschnelli might
3912018-09-06T19:41:40  * jonasschnelli looking
3922018-09-06T19:42:04  <jonasschnelli> stable-2.1
3932018-09-06T19:42:19  <wumpus> yea 2.1.5 or something?
3942018-09-06T19:42:32  * luke-jr wonders why bionic needs special LXC support
3952018-09-06T19:43:02  <jonasschnelli> I think its 2.1.1
3962018-09-06T19:43:15  <jonasschnelli> jup. 2.1.1. is min
3972018-09-06T19:43:24  <wumpus> thanks!
3982018-09-06T19:43:38  *** AaronvanW has joined #bitcoin-core-dev
3992018-09-06T19:44:21  <achow101> you need at least 2.1.x
4002018-09-06T19:44:43  *** Rootsudo has joined #bitcoin-core-dev
4012018-09-06T19:44:47  <wumpus> michagogo: which lxc version did you try with?
4022018-09-06T19:46:22  <michagogo> wumpus: whatever’s in xenial-updates
4032018-09-06T19:46:42  <achow101> michagogo: do `lxc-start --version`
4042018-09-06T19:47:47  *** AaronvanW has quit IRC
4052018-09-06T19:49:29  <promag> hi :|
4062018-09-06T19:50:44  <wumpus> Package: lxc1 (2.0.8-0ubuntu1~16.04.2)
4072018-09-06T19:50:48  <wumpus> so, too old.
4082018-09-06T19:50:56  <wumpus> promag: hi
4092018-09-06T19:51:28  <wumpus> other topics?
4102018-09-06T19:52:31  <wumpus> #endmeeting
4112018-09-06T19:52:31  <lightningbot> Meeting ended Thu Sep  6 19:52:31 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4122018-09-06T19:52:31  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.html
4132018-09-06T19:52:31  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.txt
4142018-09-06T19:52:31  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.log.html
4152018-09-06T19:52:33  <sipa> seems not
4162018-09-06T19:53:03  <meshcollider> 7:25 am <gmaxwell> I'd like to see kallewoof's progress on input grouping get done.
4172018-09-06T19:53:04  <meshcollider> What's this referring to?
4182018-09-06T19:53:52  <luke-jr> #12257 probably?
4192018-09-06T19:53:59  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4202018-09-06T19:54:10  *** jtimon has quit IRC
4212018-09-06T19:54:26  <gmaxwell> especially the "group for everyone, if it doesn't make your fees higher" part that got dropped at the last minute.
4222018-09-06T19:54:26  <luke-jr> but it's already merged, so.. dunno
4232018-09-06T19:54:33  <luke-jr> ah
4242018-09-06T19:54:36  <gmaxwell> it got gimped before being merged. :P
4252018-09-06T19:58:31  <meshcollider> oh
4262018-09-06T20:02:52  *** clarkmoody has quit IRC
4272018-09-06T20:03:09  <michagogo> Yep, 2.0.8
4282018-09-06T20:03:27  <michagogo> “lxc-init: missing container name, use —name option”
4292018-09-06T20:04:08  <michagogo> Maybe I’ll upgrade my VM to 18.04
4302018-09-06T20:04:12  <MarcoFalke> We should put the minimum version into https://github.com/bitcoin-core/docs
4312018-09-06T20:04:43  *** AaronvanW has joined #bitcoin-core-dev
4322018-09-06T20:08:54  <michagogo> sudo do-release-upgrade
4332018-09-06T20:08:56  <michagogo> er
4342018-09-06T20:12:10  <wumpus> MarcoFalke: yes, would make sense
4352018-09-06T20:20:27  *** Urgo has quit IRC
4362018-09-06T20:27:54  <sipa> jonasschnelli: to be clear, if you have an xpub without key origin in a descriptor, it'll still report a fpr/path in its expansion; just one with fpr = xpub's short id, and empty path
4372018-09-06T20:28:33  <jonasschnelli> ok
4382018-09-06T20:29:48  <sipa> i think i'll add a test that if you supply a key origin with empty path, its hash matches the xpub's short id
4392018-09-06T20:37:22  *** Zenton has joined #bitcoin-core-dev
4402018-09-06T21:07:33  <michagogo> Okay, I'm now running bionic
4412018-09-06T21:11:11  <michagogo> And yep, looks like now the build's working
4422018-09-06T21:17:58  *** Chris_Stewart_5 has quit IRC
4432018-09-06T21:32:45  *** RubenSomsen has quit IRC
4442018-09-06T21:44:39  *** belcher_ has quit IRC
4452018-09-06T22:00:37  *** jtimon has joined #bitcoin-core-dev
4462018-09-06T22:06:07  *** jtimon has quit IRC
4472018-09-06T22:06:18  <michagogo> So, hey, looks like my new i7-8750H is quite a bit faster than my i7-3610QM :D
4482018-09-06T22:22:17  *** hebasto has quit IRC
4492018-09-06T22:31:25  *** meshcollider_ has quit IRC
4502018-09-06T22:50:40  *** promag has quit IRC
4512018-09-06T22:51:14  *** promag has joined #bitcoin-core-dev
4522018-09-06T22:51:54  *** esotericnonsense has quit IRC
4532018-09-06T22:55:28  *** promag has quit IRC
4542018-09-06T22:57:26  *** esotericnonsense has joined #bitcoin-core-dev
4552018-09-06T23:03:04  *** Victorsueca has quit IRC
4562018-09-06T23:04:22  *** Victorsueca has joined #bitcoin-core-dev
4572018-09-06T23:06:18  *** spinza has quit IRC
4582018-09-06T23:09:30  *** esotericnonsense has quit IRC
4592018-09-06T23:13:56  *** profmac has quit IRC
4602018-09-06T23:15:29  *** leishman has joined #bitcoin-core-dev
4612018-09-06T23:16:26  *** spinza has joined #bitcoin-core-dev
4622018-09-06T23:22:17  *** leishman has quit IRC
4632018-09-06T23:34:13  *** esotericnonsense has joined #bitcoin-core-dev
4642018-09-06T23:34:39  *** esotericnonsense has quit IRC
4652018-09-06T23:36:16  *** esotericnonsense has joined #bitcoin-core-dev
4662018-09-06T23:38:59  *** esotericnonsense has quit IRC
4672018-09-06T23:39:28  *** esotericnonsense has joined #bitcoin-core-dev
4682018-09-06T23:49:06  *** jcorgan has quit IRC
4692018-09-06T23:57:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev