12018-09-14T00:00:24 *** belcher has quit IRC
22018-09-14T00:23:29 *** masonicboom has quit IRC
32018-09-14T00:23:57 *** Giszmo has quit IRC
42018-09-14T00:58:59 *** phwalkr has joined #bitcoin-core-dev
52018-09-14T01:00:08 *** warren has quit IRC
62018-09-14T01:00:08 *** prod_ has quit IRC
72018-09-14T01:00:08 *** Nebraskka has quit IRC
82018-09-14T01:00:09 *** victorSN has quit IRC
92018-09-14T01:00:09 *** hkjn0 has quit IRC
102018-09-14T01:02:17 *** warren has joined #bitcoin-core-dev
112018-09-14T01:03:35 *** Nebraskka has joined #bitcoin-core-dev
122018-09-14T01:03:51 *** victorSN has joined #bitcoin-core-dev
132018-09-14T01:10:44 *** drexl has quit IRC
142018-09-14T01:28:00 *** Victorsueca has quit IRC
152018-09-14T01:29:18 *** Victorsueca has joined #bitcoin-core-dev
162018-09-14T01:41:28 *** captjakk has joined #bitcoin-core-dev
172018-09-14T01:42:18 *** Krellan has quit IRC
182018-09-14T01:45:01 *** da2ce7 has joined #bitcoin-core-dev
192018-09-14T01:49:43 *** captjakk has quit IRC
202018-09-14T01:51:04 *** lnostdal has quit IRC
212018-09-14T01:56:49 *** sipa has quit IRC
222018-09-14T02:00:41 *** sipa has joined #bitcoin-core-dev
232018-09-14T02:02:32 *** lnostdal has joined #bitcoin-core-dev
242018-09-14T02:09:07 *** lnostdal has quit IRC
252018-09-14T02:21:02 *** lnostdal has joined #bitcoin-core-dev
262018-09-14T02:26:07 *** lnostdal has quit IRC
272018-09-14T02:39:36 *** lnostdal has joined #bitcoin-core-dev
282018-09-14T02:45:53 *** lnostdal has quit IRC
292018-09-14T02:47:59 *** masonicboom has joined #bitcoin-core-dev
302018-09-14T03:00:43 *** lnostdal has joined #bitcoin-core-dev
312018-09-14T03:02:09 *** chjj has quit IRC
322018-09-14T03:02:09 *** sdaftuar has quit IRC
332018-09-14T03:02:09 *** BCBot has quit IRC
342018-09-14T03:02:09 *** cfields has quit IRC
352018-09-14T03:02:09 *** qinfengling has quit IRC
362018-09-14T03:02:10 *** vxe has quit IRC
372018-09-14T03:02:10 *** kanzure has quit IRC
382018-09-14T03:02:10 *** so has quit IRC
392018-09-14T03:04:19 *** BCBot has joined #bitcoin-core-dev
402018-09-14T03:05:55 *** cfields has joined #bitcoin-core-dev
412018-09-14T03:06:00 *** BCBot has quit IRC
422018-09-14T03:06:15 *** chjj has joined #bitcoin-core-dev
432018-09-14T03:06:18 *** BCBot has joined #bitcoin-core-dev
442018-09-14T03:06:25 *** masonicboom has quit IRC
452018-09-14T03:07:17 *** kanzure has joined #bitcoin-core-dev
462018-09-14T03:17:12 *** lnostdal has quit IRC
472018-09-14T03:32:28 *** lnostdal has joined #bitcoin-core-dev
482018-09-14T03:55:20 *** meshcollider_ has joined #bitcoin-core-dev
492018-09-14T03:59:41 *** gribble has quit IRC
502018-09-14T04:00:43 *** miknotauro has joined #bitcoin-core-dev
512018-09-14T04:07:51 *** gribble has joined #bitcoin-core-dev
522018-09-14T04:26:25 *** arubi has quit IRC
532018-09-14T04:26:57 *** arubi has joined #bitcoin-core-dev
542018-09-14T04:43:26 *** sipa has quit IRC
552018-09-14T04:43:42 *** sipa has joined #bitcoin-core-dev
562018-09-14T05:05:22 *** grubles has joined #bitcoin-core-dev
572018-09-14T05:50:02 <kallewoof> Sigh. Why would the wallet_avoidreuse.py get a 'method not found' in travis when it works locally? I don't even know where to begin debugging that.
582018-09-14T05:51:52 <kallewoof> Could be an OS thing I guess. *tries on linux*
592018-09-14T05:56:25 *** RubenSomsen has joined #bitcoin-core-dev
602018-09-14T06:07:52 *** ken2812221_ has joined #bitcoin-core-dev
612018-09-14T06:09:29 <ken2812221_> kallewoof: You should skip it if wallet disabled.
622018-09-14T06:11:21 <kallewoof> I think you're right on. It says $ export DEP_OPTS="NO_WALLET=1"
632018-09-14T06:11:43 *** miknotauro has quit IRC
642018-09-14T06:12:13 <kallewoof> I'm confused why other tests are working though
652018-09-14T06:13:34 <ken2812221_> See #14180
662018-09-14T06:13:34 <kallewoof> OK I see it now. It's the skip_test_if_missing_module thingie that is in other tests but not in mine. Adding it. Thanks for the hint!
672018-09-14T06:13:36 <gribble> https://github.com/bitcoin/bitcoin/issues/14180 | qa: Run all tests even if wallet is not compiled by MarcoFalke · Pull Request #14180 · bitcoin/bitcoin · GitHubAsset 1Asset 1
682018-09-14T06:16:44 *** Jmabsd has joined #bitcoin-core-dev
692018-09-14T06:17:21 <Jmabsd> where again is the code that validates the signature for a segwit input? (as in, generates the signtext for a segwit input, either to validate an input or to generate a transaction)
702018-09-14T06:38:50 *** booyah has joined #bitcoin-core-dev
712018-09-14T06:43:31 <sipa> Jmabsd: script/interpreter.cpp, SignatureHash
722018-09-14T06:46:32 *** ppaqmj has joined #bitcoin-core-dev
732018-09-14T06:47:21 *** hebasto has joined #bitcoin-core-dev
742018-09-14T06:51:03 <hebasto> wumpus: MarcoFalke: may I ask you to add missed #13844 to the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes
752018-09-14T06:51:06 <gribble> https://github.com/bitcoin/bitcoin/issues/13844 | doc: correct the help output for -prune by hebasto · Pull Request #13844 · bitcoin/bitcoin · GitHub
762018-09-14T06:53:59 *** promag has joined #bitcoin-core-dev
772018-09-14T06:56:20 *** promag has quit IRC
782018-09-14T07:02:05 *** setpill has joined #bitcoin-core-dev
792018-09-14T07:31:36 *** hebasto has quit IRC
802018-09-14T07:31:56 *** hebasto has joined #bitcoin-core-dev
812018-09-14T07:35:28 *** miknotauro has joined #bitcoin-core-dev
822018-09-14T07:36:23 *** gribble has quit IRC
832018-09-14T07:49:29 *** ppaqmj has quit IRC
842018-09-14T07:52:44 *** tryphe_000 has joined #bitcoin-core-dev
852018-09-14T07:56:03 *** tryphe_ has quit IRC
862018-09-14T08:18:52 *** gribble has joined #bitcoin-core-dev
872018-09-14T08:20:04 <wumpus> hebasto: sure! I see what went wrong there, it was backported to the 0.16 branch, and thus ended up on the exclude list for 0.17 (to make sure PRs only end up in the earliest release's release notes, in this case 0.16.3), however there hasn't been release on the 0.16 branch since. Anyhow, I'll add it in manually.
882018-09-14T08:31:49 <wumpus> hebasto: added
892018-09-14T08:45:06 *** meshcollider_ has quit IRC
902018-09-14T08:48:58 *** timothy has joined #bitcoin-core-dev
912018-09-14T09:32:18 *** Sentineo has quit IRC
922018-09-14T09:42:03 *** phwalkr has joined #bitcoin-core-dev
932018-09-14T09:46:48 *** phwalkr has quit IRC
942018-09-14T10:33:53 *** Victorsueca has quit IRC
952018-09-14T10:35:04 *** Victorsueca has joined #bitcoin-core-dev
962018-09-14T10:41:36 *** Guyver2 has joined #bitcoin-core-dev
972018-09-14T11:14:15 *** miknotauro has quit IRC
982018-09-14T11:15:44 *** queip has joined #bitcoin-core-dev
992018-09-14T11:16:27 *** rafalcpp has joined #bitcoin-core-dev
1002018-09-14T11:17:16 *** miknotauro has joined #bitcoin-core-dev
1012018-09-14T11:25:27 *** owowo has quit IRC
1022018-09-14T11:26:12 *** owowo has joined #bitcoin-core-dev
1032018-09-14T11:58:01 *** phwalkr has joined #bitcoin-core-dev
1042018-09-14T11:59:23 *** phwalkr has quit IRC
1052018-09-14T11:59:47 *** phwalkr has joined #bitcoin-core-dev
1062018-09-14T12:04:22 *** phwalkr has quit IRC
1072018-09-14T12:13:40 *** Victorsueca has quit IRC
1082018-09-14T12:14:18 *** setpill has quit IRC
1092018-09-14T12:14:49 *** Victorsueca has joined #bitcoin-core-dev
1102018-09-14T12:37:42 *** miknotauro has quit IRC
1112018-09-14T13:03:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1122018-09-14T13:03:54 *** drexl has joined #bitcoin-core-dev
1132018-09-14T13:12:18 *** rafalcpp has quit IRC
1142018-09-14T13:16:16 *** rafalcpp has joined #bitcoin-core-dev
1152018-09-14T13:16:17 *** sdaftuar has joined #bitcoin-core-dev
1162018-09-14T13:16:52 *** queip has quit IRC
1172018-09-14T13:18:18 *** queip has joined #bitcoin-core-dev
1182018-09-14T13:52:08 *** tryphe_ has joined #bitcoin-core-dev
1192018-09-14T13:54:20 *** cornfeedhobo has quit IRC
1202018-09-14T13:54:59 *** stevenroose has quit IRC
1212018-09-14T13:55:36 *** tryphe_000 has quit IRC
1222018-09-14T13:55:37 *** nanotube has quit IRC
1232018-09-14T13:59:26 *** stevenroose has joined #bitcoin-core-dev
1242018-09-14T14:02:09 *** nanotube has joined #bitcoin-core-dev
1252018-09-14T14:04:39 *** queip has quit IRC
1262018-09-14T14:17:02 *** cornfeedhobo has joined #bitcoin-core-dev
1272018-09-14T14:17:23 <hebasto> wumpus: thank you
1282018-09-14T14:30:33 *** rafalcpp has quit IRC
1292018-09-14T14:45:37 *** queip has joined #bitcoin-core-dev
1302018-09-14T15:00:01 *** rafalcpp has joined #bitcoin-core-dev
1312018-09-14T15:02:20 *** michaelsdunn1 has joined #bitcoin-core-dev
1322018-09-14T15:16:13 *** murr4y has joined #bitcoin-core-dev
1332018-09-14T15:47:27 *** miknotauro has joined #bitcoin-core-dev
1342018-09-14T16:01:00 *** queip has quit IRC
1352018-09-14T16:04:06 *** Jmabsd has quit IRC
1362018-09-14T16:05:43 *** queip has joined #bitcoin-core-dev
1372018-09-14T16:06:47 *** captjakk has joined #bitcoin-core-dev
1382018-09-14T16:20:11 *** grubles has quit IRC
1392018-09-14T16:24:50 *** Victorsueca has quit IRC
1402018-09-14T16:26:00 *** Victorsueca has joined #bitcoin-core-dev
1412018-09-14T16:33:32 <hebasto> What is a proper way to start working on someone's PR labeled "Up for grabs"? Open a new one?
1422018-09-14T16:51:24 <gmaxwell> Does "Downgrade warning" need a warning about the txindex change? can you not go back from 0.17 if you use txindex?
1432018-09-14T16:56:27 *** csknk has joined #bitcoin-core-dev
1442018-09-14T16:56:38 *** AaronvanW has quit IRC
1452018-09-14T16:57:15 *** AaronvanW has joined #bitcoin-core-dev
1462018-09-14T17:01:33 *** AaronvanW has quit IRC
1472018-09-14T17:04:14 *** jhfrontz has joined #bitcoin-core-dev
1482018-09-14T17:10:59 *** jhfrontz has quit IRC
1492018-09-14T17:11:40 <jimpo> gmaxwell: Hmm, I think you could go back but the txindex would be missing. So you'd have to reindex to get it back.
1502018-09-14T17:19:17 *** dqx has joined #bitcoin-core-dev
1512018-09-14T17:19:58 <gmaxwell> so if you go back and set txindex=0 you'll be okay? that should probably get mentioned.
1522018-09-14T17:20:55 *** jhfrontz has joined #bitcoin-core-dev
1532018-09-14T17:22:53 *** jhfrontz has quit IRC
1542018-09-14T17:25:12 *** julian___ has joined #bitcoin-core-dev
1552018-09-14T17:31:04 *** jhfrontz has joined #bitcoin-core-dev
1562018-09-14T17:31:33 *** AaronvanW has joined #bitcoin-core-dev
1572018-09-14T17:34:59 *** kostiantyn has joined #bitcoin-core-dev
1582018-09-14T17:39:05 <kostiantyn> Hi! According to this link https://en.bitcoinwiki.org/wiki/Bitcoin_Core_0.11_(ch_5):_Initial_Block_Download during IBD the node downloads headers first before starting to download blocks.
1592018-09-14T17:39:06 <kostiantyn> Is it still true? It seems like the node starts downloading blocks once it sees the header which passes nMinimumChainWork.
1602018-09-14T17:42:14 *** dqx has quit IRC
1612018-09-14T17:43:52 <sipa> kostiantyn: for any given block, we download the header first
1622018-09-14T17:43:57 <sipa> and then the block data itself
1632018-09-14T17:44:19 <sipa> but the header downloding and block downloading in general run in parallel; it's just easier to describe them as two sequential processes
1642018-09-14T17:44:30 <sipa> (they've always run in parallel, since headers-first was implemented in 0.10)
1652018-09-14T17:45:43 <kostiantyn> thanks a lot for the explanation!
1662018-09-14T17:47:40 <kostiantyn> maybe it makes sense to update this line in the wiki " Once the node has all of the headers, from the genesis block up to the current tip of the blockchain (380,000 as of October 2015), only then does it begins downloading the full blocks."
1672018-09-14T17:47:41 *** jhfrontz has quit IRC
1682018-09-14T17:48:15 *** julian___ has quit IRC
1692018-09-14T17:54:44 *** grubles has joined #bitcoin-core-dev
1702018-09-14T17:54:59 *** kostiantyn has quit IRC
1712018-09-14T17:59:12 *** jhfrontz has joined #bitcoin-core-dev
1722018-09-14T18:07:12 *** jarthur has joined #bitcoin-core-dev
1732018-09-14T18:09:14 *** Mrrt has joined #bitcoin-core-dev
1742018-09-14T18:22:13 *** Sentineo has joined #bitcoin-core-dev
1752018-09-14T18:41:59 *** miknotauro has quit IRC
1762018-09-14T18:42:46 <Lightsword> in regards to #14221 isnât poll() broken on some unix like platforms like OSX? https://daniel.haxx.se/blog/2016/10/11/poll-on-mac-10-12-is-broken/
1772018-09-14T18:42:47 <gribble> https://github.com/bitcoin/bitcoin/issues/14221 | wip: net: Implement poll by pstratem · Pull Request #14221 · bitcoin/bitcoin · GitHub
1782018-09-14T18:45:46 <gmaxwell> There is no need to poll on an empty watching set.
1792018-09-14T18:47:43 <Lightsword> gmaxwell, so that poll() bug shouldnât affect us?
1802018-09-14T18:48:41 <sipa> i don't understand the issue if it's just in case of an empty set... you can easily workaround that by detecting an empty set being passed in, and if so, just sleepign
1812018-09-14T18:56:08 <sipa> either it's more than just that, or it's a pretty boring bug :)
1822018-09-14T18:58:03 <Lightsword> ok, just wanted to make sure that wouldnât cause problems, by the way, what was happening in regards to switching to libevent for node p2p sockets, did that effort stall for some reason? I see #11227 but it hasnât been updated in a while
1832018-09-14T18:58:05 <gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
1842018-09-14T18:58:08 *** sipa has quit IRC
1852018-09-14T18:58:08 *** intcat has quit IRC
1862018-09-14T18:58:08 *** arubi has quit IRC
1872018-09-14T18:58:08 *** grubles has quit IRC
1882018-09-14T18:58:08 *** morcos has quit IRC
1892018-09-14T18:58:08 *** ghost43 has quit IRC
1902018-09-14T18:58:24 *** sipa has joined #bitcoin-core-dev
1912018-09-14T18:58:33 *** arubi has joined #bitcoin-core-dev
1922018-09-14T18:58:52 *** ghost43 has joined #bitcoin-core-dev
1932018-09-14T18:59:22 *** morcos has joined #bitcoin-core-dev
1942018-09-14T18:59:46 *** intcat has joined #bitcoin-core-dev
1952018-09-14T19:04:19 *** rafalcpp has quit IRC
1962018-09-14T19:04:22 *** queip has quit IRC
1972018-09-14T19:10:45 *** itaseski has joined #bitcoin-core-dev
1982018-09-14T19:17:58 *** BashCo has joined #bitcoin-core-dev
1992018-09-14T19:19:18 *** queip has joined #bitcoin-core-dev
2002018-09-14T19:23:10 *** queip has quit IRC
2012018-09-14T19:26:29 <gmaxwell> sipa: I wonder if on ryzen where you have 2x parallelism in shani, if it would makes sense to use multiple cores to compute hashtrees... or if it couldn't overcome overheads.
2022018-09-14T19:28:43 *** grubles has joined #bitcoin-core-dev
2032018-09-14T19:31:50 *** Krellan has joined #bitcoin-core-dev
2042018-09-14T19:37:48 *** queip has joined #bitcoin-core-dev
2052018-09-14T19:39:27 *** rafalcpp has joined #bitcoin-core-dev
2062018-09-14T19:42:14 *** romanz has quit IRC
2072018-09-14T19:42:34 *** csknk has quit IRC
2082018-09-14T19:46:39 *** captjakk has quit IRC
2092018-09-14T19:49:12 *** BashCo has quit IRC
2102018-09-14T19:50:50 *** BashCo has joined #bitcoin-core-dev
2112018-09-14T19:55:08 *** rafalcpp has quit IRC
2122018-09-14T19:55:10 *** queip has quit IRC
2132018-09-14T20:01:31 *** grubles has quit IRC
2142018-09-14T20:04:58 *** BashCo has quit IRC
2152018-09-14T20:06:23 *** BashCo has joined #bitcoin-core-dev
2162018-09-14T20:17:41 *** miknotauro has joined #bitcoin-core-dev
2172018-09-14T20:23:33 *** rex4539 has joined #bitcoin-core-dev
2182018-09-14T20:36:34 *** BashCo has quit IRC
2192018-09-14T20:37:41 *** drexl has quit IRC
2202018-09-14T20:37:44 *** quer has joined #bitcoin-core-dev
2212018-09-14T20:38:16 *** BashCo has joined #bitcoin-core-dev
2222018-09-14T20:43:08 *** BashCo has quit IRC
2232018-09-14T21:14:13 *** AaronvanW has quit IRC
2242018-09-14T21:19:05 *** jhfrontz has quit IRC
2252018-09-14T21:39:08 *** Guyver2 has quit IRC
2262018-09-14T21:41:21 *** jhfrontz has joined #bitcoin-core-dev
2272018-09-14T21:48:18 <phantomcircuit> so why is SOCKET unsigned int when all the fd parameters to things are int?
2282018-09-14T21:52:04 * phantomcircuit goes to ask 2011 wumpus
2292018-09-14T21:52:06 <phantomcircuit> any idea?
2302018-09-14T21:53:59 <phantomcircuit> oh i see
2312018-09-14T21:54:14 <phantomcircuit> unsigned on windows
2322018-09-14T22:01:29 *** masonicboom has joined #bitcoin-core-dev
2332018-09-14T22:12:02 *** jhfrontz has quit IRC
2342018-09-14T22:17:53 *** jhfrontz has joined #bitcoin-core-dev
2352018-09-14T22:22:52 *** michaelsdunn1 has quit IRC
2362018-09-14T22:23:44 *** jhfrontz has quit IRC
2372018-09-14T22:23:57 *** jhfrontz has joined #bitcoin-core-dev
2382018-09-14T22:25:36 *** jhfrontz has quit IRC
2392018-09-14T22:26:01 *** Chris_Stewart_5 has quit IRC
2402018-09-14T22:26:53 *** jarthur has quit IRC
2412018-09-14T22:43:21 *** Tennis has joined #bitcoin-core-dev
2422018-09-14T22:54:37 *** grubles has joined #bitcoin-core-dev
2432018-09-14T22:58:48 *** masonicboom has quit IRC
2442018-09-14T22:58:51 *** grubles has quit IRC
2452018-09-14T23:22:34 *** conman has joined #bitcoin-core-dev
2462018-09-14T23:23:05 <conman> is 0.17.0 not tagged no git for a reason?
2472018-09-14T23:23:30 <conman> I can only find v0.17.0rc3
2482018-09-14T23:23:35 <conman> tag, that is
2492018-09-14T23:24:47 <sipa> yes, because 0.17.0 is not released yet :)
2502018-09-14T23:25:05 *** drexl has joined #bitcoin-core-dev
2512018-09-14T23:28:29 <conman> ah very good
2522018-09-14T23:28:47 <conman> I misunderstood, thanks
2532018-09-14T23:30:12 <sipa> don't worry, it's very close
2542018-09-14T23:33:35 <conman> thank you, the posts I'd read referencing 0.17.0 didn't say "will have"; it sounded like it was out
2552018-09-14T23:34:32 <conman> hence the confusion :)
2562018-09-14T23:39:18 *** ken2812221 has quit IRC
2572018-09-14T23:46:06 *** owowo has quit IRC
2582018-09-14T23:50:57 *** owowo has joined #bitcoin-core-dev