12018-10-04T00:04:50 *** timothy has quit IRC
22018-10-04T00:18:51 *** Krellan has quit IRC
32018-10-04T00:22:00 *** Krellan has joined #bitcoin-core-dev
42018-10-04T00:22:26 *** esotericnonsense has quit IRC
52018-10-04T00:24:13 *** esotericnonsense has joined #bitcoin-core-dev
62018-10-04T00:25:33 *** ken2812221 has quit IRC
72018-10-04T00:26:38 *** ken2812221 has joined #bitcoin-core-dev
82018-10-04T00:31:32 *** sipa has quit IRC
92018-10-04T00:31:49 *** sipa has joined #bitcoin-core-dev
102018-10-04T00:32:17 *** marcinja_ has joined #bitcoin-core-dev
112018-10-04T00:33:47 *** marcinja_ is now known as marcinja
122018-10-04T00:45:37 *** marcinja has joined #bitcoin-core-dev
132018-10-04T01:05:51 *** Krellan has quit IRC
142018-10-04T01:11:23 *** Krellan has joined #bitcoin-core-dev
152018-10-04T01:38:09 *** tradermyx has joined #bitcoin-core-dev
162018-10-04T01:38:39 <tradermyx> What is rpcbind=?
172018-10-04T01:38:55 <sipa> the IP address to bind to when listening for incoming RPC connections
182018-10-04T01:39:16 <tradermyx> Then what is rpcconnect?
192018-10-04T01:39:20 <tradermyx> Which I thought was exactly that.
202018-10-04T01:39:41 <sipa> rpcconnect is an RPC client setting, it sets the IP address to connect to
212018-10-04T01:39:50 <sipa> rpcbind is an RPC server setting, it sets the IP address to listen on
222018-10-04T01:40:04 <sipa> rpcconnect only affects bitcoin-cli
232018-10-04T01:40:18 <sipa> rpcbind only affects bitcoind and bitcoin-qt (when running with -daemon)
242018-10-04T01:42:15 <tradermyx> I have rpcconnect, rpcport, rpcuser, rpcpassword set in my bitcoin.conf. Don't really understand why Bitcoin Core needs to be told where to connect... itself?
252018-10-04T01:42:44 <sipa> what are you trying to do?
262018-10-04T01:42:54 <tradermyx> Come to think of it, I don't really understand what bitcoin-cli is either. I use standard cURL requests to talk to http://127.0.0.01/ with the port specified (it works).
272018-10-04T01:42:57 <sipa> rpcconnect is something you'd use when your bitcoind is running on another system
282018-10-04T01:43:14 <sipa> if you use cURL, rpcconnect has no effect
292018-10-04T01:43:16 <tradermyx> Hmm. I see. So it's already implied to be 127.0.0.1 by default.
302018-10-04T01:43:20 <sipa> right
312018-10-04T01:43:42 <tradermyx> I didn't think Bitcoin Core itself had the ability to connect/do anything with the RPC API on a different machine.
322018-10-04T01:44:12 <sipa> bitcoin-cli is really just a slightly-specialized version of curl
332018-10-04T01:44:26 <sipa> it connects to a server, sends it a command, and shows the result
342018-10-04T01:44:37 <sipa> and you can tell it where to connect
352018-10-04T01:44:44 <sipa> but the default is 127.0.0.1
362018-10-04T01:45:29 <tradermyx> How come it's not recommended to simply use that binary to talk to the API?
372018-10-04T01:45:57 <sipa> what do you mean?
382018-10-04T01:46:06 <tradermyx> (I just upgraded to 0.17 and https://bitcoincore.org/en/releases/0.17.0/ seems like a lot of work was put into it... Although I won't be using these new "labels" seeing as "accounts" was deprecated. Better handle that myself if at all.)
392018-10-04T01:46:21 <tradermyx> sipa: I mean, why use cURL requests if I can just shell_exec() the bitcoin-cli binary?
402018-10-04T01:46:50 <tradermyx> (I already have the cURL stuff working, so I'm purely asking out of curiosity.)
412018-10-04T01:46:53 <gmaxwell> ... is you web service shell_execing right now?
422018-10-04T01:47:01 <tradermyx> Nope.
432018-10-04T01:47:23 <tradermyx> Just wondering what the point of that feature is. Or why it's not recommended to use.
442018-10-04T01:47:58 <gmaxwell> It's the recommended way to use bitcoin from the commandline.
452018-10-04T01:48:09 <gmaxwell> Which is what it's for.
462018-10-04T01:48:23 <tradermyx> So for testing stuff manually?
472018-10-04T01:48:38 *** esotericnonsense has quit IRC
482018-10-04T01:48:42 <gmaxwell> Usually one would not use it for programmatic access as it would be slower then making a connection via more conventional means.
492018-10-04T01:49:01 <gmaxwell> tradermyx: no, not just for testing-- for working with and using the node and wallet.
502018-10-04T01:49:05 <tradermyx> https://bitcoincore.org/en/doc/0.16.3/ <-- Is there not yet a 0.17 documentation uploaded? (Not in the menu and not when trying to modify the URL)
512018-10-04T01:49:10 <tradermyx> Ah.
522018-10-04T01:49:29 <sipa> but bitcoin-cli is a way for humans to talk to bitcoind
532018-10-04T01:49:43 <sipa> you wouldn't want to use it for another program; there are far more efficient and convenient ways
542018-10-04T01:54:02 *** jb55 has joined #bitcoin-core-dev
552018-10-04T02:01:09 <tradermyx> It's extremely hard to even find rpcconnect mentioned anywhere, BTW. That goes in general for documentation on this stuff; it's sprinked onto countless webpages on different domains.
562018-10-04T02:01:34 <tradermyx> Is the 0.17 documentation still being worked on and will become available soon?
572018-10-04T02:02:28 <sipa> butcoin-cli --hrlp
582018-10-04T02:02:48 <sipa> sorry
592018-10-04T02:02:53 <sipa> butcoin-cli --help
602018-10-04T02:03:11 <sipa> the website is just generated from the built-in help text
612018-10-04T02:04:26 <tradermyx> Then it's especially odd that it's not updated on the site, if it's automated. Note: Not "complaining" -- just pointing things out as I find them.
622018-10-04T02:04:42 <tradermyx> This is a fascinating piece of software for sure.
632018-10-04T02:05:09 <tradermyx> I like the idea of theoretically being able to control money in this way. My bank actively prevents even automating logging in to view saldo.
642018-10-04T02:05:18 <sipa> you're very welcome to help out with efforts to automate it :)
652018-10-04T02:05:30 *** Murch has quit IRC
662018-10-04T02:12:12 *** esotericnonsense has joined #bitcoin-core-dev
672018-10-04T02:12:28 *** jb55 has quit IRC
682018-10-04T02:18:45 *** Krellan has quit IRC
692018-10-04T02:23:57 *** Krellan has joined #bitcoin-core-dev
702018-10-04T02:28:13 *** promag has quit IRC
712018-10-04T02:28:41 *** Krellan has quit IRC
722018-10-04T02:28:42 *** booyah has quit IRC
732018-10-04T02:28:55 *** booyah has joined #bitcoin-core-dev
742018-10-04T02:31:48 *** ken2812221 has quit IRC
752018-10-04T02:34:21 *** Krellan has joined #bitcoin-core-dev
762018-10-04T02:38:34 *** Krellan has quit IRC
772018-10-04T02:40:05 *** Krellan has joined #bitcoin-core-dev
782018-10-04T02:46:56 *** jb55 has joined #bitcoin-core-dev
792018-10-04T02:51:12 *** Krellan has quit IRC
802018-10-04T03:07:15 *** Krellan has joined #bitcoin-core-dev
812018-10-04T03:09:04 *** booyah has quit IRC
822018-10-04T03:09:19 *** booyah has joined #bitcoin-core-dev
832018-10-04T03:26:24 *** Krellan has quit IRC
842018-10-04T03:28:20 <tradermyx> sipa: I thought it was already automated?
852018-10-04T03:36:43 *** Krellan has joined #bitcoin-core-dev
862018-10-04T03:38:12 *** booyah has quit IRC
872018-10-04T03:38:56 *** booyah has joined #bitcoin-core-dev
882018-10-04T03:41:15 *** Krellan has quit IRC
892018-10-04T03:46:48 *** Krellan has joined #bitcoin-core-dev
902018-10-04T03:48:21 *** echeveria has joined #bitcoin-core-dev
912018-10-04T04:05:10 <sipa> tradermyx: apparently not enough :)
922018-10-04T04:06:33 *** Krellan has quit IRC
932018-10-04T04:07:58 *** windsok has joined #bitcoin-core-dev
942018-10-04T04:12:00 *** Krellan has joined #bitcoin-core-dev
952018-10-04T04:12:42 *** nullptr| has quit IRC
962018-10-04T04:15:23 *** esotericnonsense has quit IRC
972018-10-04T04:15:26 *** tradermyx has quit IRC
982018-10-04T04:15:27 *** spinza has quit IRC
992018-10-04T04:15:31 *** nullptr| has joined #bitcoin-core-dev
1002018-10-04T04:15:59 *** murrayn has quit IRC
1012018-10-04T04:16:00 *** Cory has quit IRC
1022018-10-04T04:17:36 *** rex4539 has joined #bitcoin-core-dev
1032018-10-04T04:21:20 *** Pasha has joined #bitcoin-core-dev
1042018-10-04T04:24:31 *** Pasha is now known as Cory
1052018-10-04T04:27:26 *** esotericnonsense has joined #bitcoin-core-dev
1062018-10-04T04:54:07 *** spinza has joined #bitcoin-core-dev
1072018-10-04T04:56:45 *** esotericnonsense has quit IRC
1082018-10-04T05:02:26 *** esotericnonsense has joined #bitcoin-core-dev
1092018-10-04T05:05:14 *** meshcollider_ has joined #bitcoin-core-dev
1102018-10-04T05:48:18 *** Zenton has quit IRC
1112018-10-04T06:05:18 <karelb> tradermyx: I made a PR :D
1122018-10-04T06:05:38 <karelb> https://github.com/bitcoin-core/bitcoincore.org/pull/618
1132018-10-04T06:05:59 <karelb> it's automated as in "someone has to run the script and git-commit and make a PR"
1142018-10-04T06:07:32 <karelb> I have no idea how would to automate this on every release...
1152018-10-04T06:08:19 <karelb> (the RPC diff is linked in the PR if you are interested)
1162018-10-04T06:11:37 *** hebasto has joined #bitcoin-core-dev
1172018-10-04T06:13:43 <karelb> (oh he quit already)
1182018-10-04T06:16:56 <karelb> anyway how would one go automate this.... even putting binaries etc online is not automated and I see @harding putting them online manually each release?
1192018-10-04T06:16:59 *** harrymm has quit IRC
1202018-10-04T06:17:17 *** promag has joined #bitcoin-core-dev
1212018-10-04T06:17:48 *** copumpkin has quit IRC
1222018-10-04T06:19:45 *** IGHOR has quit IRC
1232018-10-04T06:20:05 *** promag has quit IRC
1242018-10-04T06:22:19 <sipa> karelb: perhaps one step would be adding it to the bitcoin core release process notes
1252018-10-04T06:23:06 <karelb> sipa: ð good idea
1262018-10-04T06:26:09 *** murrayn has joined #bitcoin-core-dev
1272018-10-04T06:50:48 *** copumpkin has joined #bitcoin-core-dev
1282018-10-04T06:54:43 <hebasto> MarcoFalke: what is minimal codespell version to run test/lint/lint-spelling.sh successfully?
1292018-10-04T06:57:24 *** face has quit IRC
1302018-10-04T07:09:59 *** promag has joined #bitcoin-core-dev
1312018-10-04T07:13:48 *** lnostdal has quit IRC
1322018-10-04T07:20:28 *** qinfengling has joined #bitcoin-core-dev
1332018-10-04T07:25:00 *** meshcollider_ has quit IRC
1342018-10-04T07:27:55 *** promag has quit IRC
1352018-10-04T07:27:58 *** jeremyrubin has joined #bitcoin-core-dev
1362018-10-04T07:36:34 *** hebasto has quit IRC
1372018-10-04T07:43:14 *** IGHOR has joined #bitcoin-core-dev
1382018-10-04T07:49:04 *** booyah has quit IRC
1392018-10-04T07:50:10 *** booyah has joined #bitcoin-core-dev
1402018-10-04T07:54:51 *** rex4539 has quit IRC
1412018-10-04T07:58:07 *** harrymm has joined #bitcoin-core-dev
1422018-10-04T07:58:21 *** timothy has joined #bitcoin-core-dev
1432018-10-04T08:01:09 *** setpill has joined #bitcoin-core-dev
1442018-10-04T08:01:52 *** elichai2 has joined #bitcoin-core-dev
1452018-10-04T08:22:15 *** setpill has quit IRC
1462018-10-04T08:23:47 *** setpill has joined #bitcoin-core-dev
1472018-10-04T08:39:54 *** Zenton has joined #bitcoin-core-dev
1482018-10-04T08:49:21 *** jeremyrubin has quit IRC
1492018-10-04T08:55:01 *** rh0nj has quit IRC
1502018-10-04T08:56:08 *** rh0nj has joined #bitcoin-core-dev
1512018-10-04T09:12:45 *** fanquake has joined #bitcoin-core-dev
1522018-10-04T09:13:33 <fanquake> Will there still be a meeting tomorrow morning? I'm hoping I might actually be able to join between flights
1532018-10-04T09:17:36 *** Krellan has quit IRC
1542018-10-04T09:22:50 *** Krellan has joined #bitcoin-core-dev
1552018-10-04T09:32:55 *** hebasto has joined #bitcoin-core-dev
1562018-10-04T09:58:05 *** setpill has quit IRC
1572018-10-04T09:58:37 *** setpill has joined #bitcoin-core-dev
1582018-10-04T10:17:41 *** Krellan has quit IRC
1592018-10-04T10:18:28 *** Krellan has joined #bitcoin-core-dev
1602018-10-04T10:24:41 *** ExtraCrispy has joined #bitcoin-core-dev
1612018-10-04T10:27:34 *** Krellan has quit IRC
1622018-10-04T10:28:49 *** Krellan has joined #bitcoin-core-dev
1632018-10-04T10:32:08 *** JackH has quit IRC
1642018-10-04T10:37:36 *** Krellan has quit IRC
1652018-10-04T10:44:33 *** Krellan has joined #bitcoin-core-dev
1662018-10-04T10:50:34 *** phwalkr has joined #bitcoin-core-dev
1672018-10-04T10:58:01 *** arubi has quit IRC
1682018-10-04T11:00:18 *** arubi has joined #bitcoin-core-dev
1692018-10-04T11:04:33 *** rex4539 has joined #bitcoin-core-dev
1702018-10-04T11:22:09 *** AaronvanW has quit IRC
1712018-10-04T11:27:12 *** ExtraCrispy has quit IRC
1722018-10-04T11:27:13 *** irc_viewer_test has joined #bitcoin-core-dev
1732018-10-04T11:28:26 *** ExtraCrispy has joined #bitcoin-core-dev
1742018-10-04T11:30:36 *** irc_viewer_test has quit IRC
1752018-10-04T11:31:36 *** ExtraCrispy has quit IRC
1762018-10-04T11:40:48 *** ExtraCrispy has joined #bitcoin-core-dev
1772018-10-04T12:06:18 *** unifiedh has joined #bitcoin-core-dev
1782018-10-04T12:13:10 *** drexl has joined #bitcoin-core-dev
1792018-10-04T12:14:30 *** ken2812221 has joined #bitcoin-core-dev
1802018-10-04T12:23:35 *** arubi has quit IRC
1812018-10-04T12:28:21 *** Krellan has quit IRC
1822018-10-04T12:28:52 *** arubi has joined #bitcoin-core-dev
1832018-10-04T12:32:54 *** promag has joined #bitcoin-core-dev
1842018-10-04T12:33:37 *** Krellan has joined #bitcoin-core-dev
1852018-10-04T12:37:18 *** promag has quit IRC
1862018-10-04T12:43:21 *** fanquake has quit IRC
1872018-10-04T12:51:15 *** arubi has quit IRC
1882018-10-04T12:51:43 *** arubi has joined #bitcoin-core-dev
1892018-10-04T12:53:26 *** Krellan has quit IRC
1902018-10-04T12:54:01 *** Krellan has joined #bitcoin-core-dev
1912018-10-04T12:58:24 *** Krellan has quit IRC
1922018-10-04T12:59:30 *** Krellan has joined #bitcoin-core-dev
1932018-10-04T12:59:45 <harding> Each week, I look through the previous week's commits for interesting ones to document for the Optech newsletter. As part of that weekly routine, I'd be willing to write up any undocumented notable changes for the release notes---hopefully significantly cutting down on the work during the RC cycle---but I'd like suggestions on the best way to do that. Should I submit a PR each week to update the release notes? Or save up my
1942018-10-04T12:59:45 <harding> work for a monthly PR? Or maybe maintain the release notes on the devwiki full time? Or something else?
1952018-10-04T13:08:28 *** Krellan has quit IRC
1962018-10-04T13:08:58 <sipa> harding: that sounds awesome
1972018-10-04T13:09:09 <sipa> though i think weekly is probably too ofte
1982018-10-04T13:09:10 *** arubi has quit IRC
1992018-10-04T13:09:32 *** Krellan has joined #bitcoin-core-dev
2002018-10-04T13:09:33 *** arubi has joined #bitcoin-core-dev
2012018-10-04T13:12:13 <harding> sipa: yeah, that's what I was thinking. I guess I'll start with monthly and we can tweak it from there.
2022018-10-04T13:14:00 *** Guyver2 has joined #bitcoin-core-dev
2032018-10-04T13:16:00 *** ExtraCrispy has quit IRC
2042018-10-04T13:45:03 *** promag has joined #bitcoin-core-dev
2052018-10-04T13:54:45 *** unifiedh has quit IRC
2062018-10-04T13:57:09 *** lnostdal has joined #bitcoin-core-dev
2072018-10-04T14:05:06 *** promag has quit IRC
2082018-10-04T14:06:32 *** promag has joined #bitcoin-core-dev
2092018-10-04T14:08:10 *** setpill has quit IRC
2102018-10-04T14:29:47 *** promag has quit IRC
2112018-10-04T14:33:21 *** Apocalyptic has quit IRC
2122018-10-04T14:34:31 *** justanotheruser has quit IRC
2132018-10-04T14:34:48 *** Apocalyptic has joined #bitcoin-core-dev
2142018-10-04T14:36:04 *** michaelsdunn1 has joined #bitcoin-core-dev
2152018-10-04T14:38:36 *** Krellan has quit IRC
2162018-10-04T14:39:31 *** Krellan has joined #bitcoin-core-dev
2172018-10-04T14:47:16 *** ExtraCrispy has joined #bitcoin-core-dev
2182018-10-04T15:14:43 *** ExtraCrispy_ has joined #bitcoin-core-dev
2192018-10-04T15:31:34 *** Krellan has quit IRC
2202018-10-04T15:32:33 *** Krellan has joined #bitcoin-core-dev
2212018-10-04T15:41:26 *** Krellan has quit IRC
2222018-10-04T15:42:23 *** promag has joined #bitcoin-core-dev
2232018-10-04T15:45:00 *** promag has quit IRC
2242018-10-04T15:47:06 *** Krellan has joined #bitcoin-core-dev
2252018-10-04T15:51:39 *** Krellan has quit IRC
2262018-10-04T15:52:16 *** Krellan has joined #bitcoin-core-dev
2272018-10-04T16:06:05 *** rex4539 has quit IRC
2282018-10-04T16:10:09 *** rex4539 has joined #bitcoin-core-dev
2292018-10-04T16:11:24 *** Victorsueca has quit IRC
2302018-10-04T16:12:38 *** Victorsueca has joined #bitcoin-core-dev
2312018-10-04T16:23:34 *** Krellan has quit IRC
2322018-10-04T16:29:30 *** Krellan has joined #bitcoin-core-dev
2332018-10-04T16:34:06 *** jarthur has joined #bitcoin-core-dev
2342018-10-04T16:44:24 *** promag has joined #bitcoin-core-dev
2352018-10-04T16:50:11 *** timothy has quit IRC
2362018-10-04T16:58:39 *** Murch has joined #bitcoin-core-dev
2372018-10-04T17:02:05 *** Krellan has quit IRC
2382018-10-04T17:07:02 *** tryphe_ has joined #bitcoin-core-dev
2392018-10-04T17:09:38 *** tryphe has quit IRC
2402018-10-04T17:14:30 *** promag has quit IRC
2412018-10-04T17:17:42 <gmaxwell> [OT] https://www.bloomberg.com/news/features/2018-10-04/the-big-hack-how-china-used-a-tiny-chip-to-infiltrate-america-s-top-companies?srnd=businessweek-v2 pervasive chinese backdoor chips found in supermicro hardware, chinese AWS.
2422018-10-04T17:20:28 *** ExtraCrispy has quit IRC
2432018-10-04T17:31:11 <wumpus> yes, ouch.
2442018-10-04T17:41:54 *** Zenton has quit IRC
2452018-10-04T17:45:11 *** Murch has quit IRC
2462018-10-04T17:45:47 *** Murch has joined #bitcoin-core-dev
2472018-10-04T17:55:30 *** marcoagner has joined #bitcoin-core-dev
2482018-10-04T18:08:28 *** sfhi has joined #bitcoin-core-dev
2492018-10-04T18:13:55 *** sfhi has quit IRC
2502018-10-04T18:16:37 *** no_input_found has quit IRC
2512018-10-04T18:16:58 *** no_input_found has joined #bitcoin-core-dev
2522018-10-04T18:22:11 *** promag has joined #bitcoin-core-dev
2532018-10-04T18:24:27 *** jarthur has quit IRC
2542018-10-04T18:27:53 *** promag has quit IRC
2552018-10-04T18:43:30 *** promag has joined #bitcoin-core-dev
2562018-10-04T18:46:14 *** jcorgan has joined #bitcoin-core-dev
2572018-10-04T18:55:32 *** Murch has quit IRC
2582018-10-04T18:55:44 *** clarkmoody has joined #bitcoin-core-dev
2592018-10-04T18:57:14 *** ken2812221_ has joined #bitcoin-core-dev
2602018-10-04T19:00:07 <promag> wumpus: having a family dinner, can you add #14291 to HP?
2612018-10-04T19:00:09 <gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
2622018-10-04T19:00:57 <promag> it's a dependency for #14350 and #13100
2632018-10-04T19:00:59 <gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletInfo class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
2642018-10-04T19:01:01 <gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
2652018-10-04T19:02:49 <wumpus> #startmeeting
2662018-10-04T19:02:49 <lightningbot> Meeting started Thu Oct 4 19:02:49 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2672018-10-04T19:02:49 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2682018-10-04T19:02:55 <wumpus> promag: sure
2692018-10-04T19:02:58 <promag> hi
2702018-10-04T19:03:00 <promag> thanks!
2712018-10-04T19:03:09 *** ken2812221_ has quit IRC
2722018-10-04T19:04:12 <phantomcircuit> hi
2732018-10-04T19:05:05 <jcorgan> i bet many are sleeping or about to
2742018-10-04T19:05:07 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
2752018-10-04T19:05:18 <wumpus> yesâI expect so too
2762018-10-04T19:05:25 <jonasschnelli> hi
2772018-10-04T19:05:27 *** ken2812221_ has joined #bitcoin-core-dev
2782018-10-04T19:05:43 <wumpus> don't know if we really have things to discuss without the people in Tokyo
2792018-10-04T19:05:51 *** ken2812221_ has joined #bitcoin-core-dev
2802018-10-04T19:05:56 * jonasschnelli is sad to miss SB tokyo
2812018-10-04T19:06:01 * wumpus too
2822018-10-04T19:06:17 <jcorgan> #MeToo
2832018-10-04T19:06:22 <jcorgan> sri
2842018-10-04T19:06:25 <jonasschnelli> heh
2852018-10-04T19:06:38 <wumpus> lol
2862018-10-04T19:07:26 <gmaxwell> hi
2872018-10-04T19:07:27 <wumpus> anything for high-priority for review? or what can be merged? I haven't been able to focus much this week
2882018-10-04T19:07:44 <phantomcircuit> #14335 and maybe #14336
2892018-10-04T19:07:46 <gribble> https://github.com/bitcoin/bitcoin/issues/14335 | net: refactor: cleanup ThreadSocketHandler by pstratem · Pull Request #14335 · bitcoin/bitcoin · GitHub
2902018-10-04T19:07:47 <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
2912018-10-04T19:08:19 <phantomcircuit> i still cant exactly ping down why some of the commits in 14336 fail tests but the final one doesn't
2922018-10-04T19:08:28 <phantomcircuit> and they seem like races more than actual failures
2932018-10-04T19:08:41 <wumpus> do they fail locally for you too?
2942018-10-04T19:08:43 <wumpus> or only on travis?
2952018-10-04T19:09:01 <phantomcircuit> wumpus, only on travis
2962018-10-04T19:09:12 <wumpus> aww
2972018-10-04T19:09:25 <wumpus> I can try running them in some weird environments
2982018-10-04T19:10:29 <phantomcircuit> 14335 however passes everywhere
2992018-10-04T19:10:34 <gmaxwell> you might try inserting sleeps to see if you can trigger something locally.
3002018-10-04T19:10:38 <wumpus> so if they are races they only happen part of the time, not always
3012018-10-04T19:10:45 <phantomcircuit> it's just refactoring no logic changes at all now
3022018-10-04T19:10:59 *** promag has quit IRC
3032018-10-04T19:11:02 <wumpus> well if it causes test failures there might be logic changes you don't know about
3042018-10-04T19:11:07 <phantomcircuit> gmaxwell, i can randomly trigger the rpc_zmq.py test to fail
3052018-10-04T19:11:12 *** Krellan has joined #bitcoin-core-dev
3062018-10-04T19:11:14 <wumpus> I don't think a pure refactoring can result in more races
3072018-10-04T19:11:17 <phantomcircuit> but it's zmq so i would expect it to be very racey
3082018-10-04T19:11:23 *** Krellan has quit IRC
3092018-10-04T19:11:27 <phantomcircuit> wumpus, yeah that pr doesn't have any issues
3102018-10-04T19:11:34 <wumpus> no, zmq is not inherently racy
3112018-10-04T19:11:35 <phantomcircuit> it's just the one implementing poll()
3122018-10-04T19:11:43 <phantomcircuit> (this is why it's two separate pulls)
3132018-10-04T19:11:58 *** Krellan has joined #bitcoin-core-dev
3142018-10-04T19:12:10 <phantomcircuit> wumpus, the test is though, it starts the node and then instantly makes an rpc call for zmq notifications
3152018-10-04T19:12:14 <wumpus> (maybe our use of it is, I don't now)
3162018-10-04T19:12:25 <wumpus> ohh
3172018-10-04T19:12:27 <jcorgan> the test is written in a racy way as described
3182018-10-04T19:12:27 <phantomcircuit> cant probably make that more robust but im not super familiar with the testing framework
3192018-10-04T19:13:39 <wumpus> someone needs to take a look at it; we can't merge something that makes any test randomly fail, as it wil keep coming back in later PRs
3202018-10-04T19:13:51 <wumpus> #action reviews #14336
3212018-10-04T19:13:53 <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
3222018-10-04T19:14:34 <gmaxwell> We should just fix that test, but is the zmq test the only one that fails?
3232018-10-04T19:14:46 <gmaxwell> There is something other tests do to wait until the node is ready.
3242018-10-04T19:15:00 <phantomcircuit> gmaxwell, feature notifications fails on windows
3252018-10-04T19:15:01 <wumpus> yes, fixing the test is acceptable too if it is broken
3262018-10-04T19:15:17 <phantomcircuit> but im having trouble replicating that for a whole bunch of reasons
3272018-10-04T19:16:15 <phantomcircuit> gmaxwell, they wait on nodes to be synchronized i think, but that doesn't apply to the zmq test
3282018-10-04T19:16:31 <phantomcircuit> (again im not exactly sure though)
3292018-10-04T19:16:46 *** ken2812221_ has quit IRC
3302018-10-04T19:16:58 <jcorgan> which file is the zmq test
3312018-10-04T19:17:03 <wumpus> if there's multiple nodes connected to each other they need to wait to be synchronized
3322018-10-04T19:17:21 <phantomcircuit> jcorgan, test/functional/rpc_zmq.py
3332018-10-04T19:17:26 <wumpus> test/functional/rpc_zmq.py
3342018-10-04T19:17:28 <wumpus> yes
3352018-10-04T19:17:34 <phantomcircuit> jynx
3362018-10-04T19:19:02 <wumpus> okay, any other topics?
3372018-10-04T19:19:08 <jcorgan> it's the assert on L31 that non-deterministically fails?
3382018-10-04T19:19:37 <gmaxwell> I could give a little update on our work on set recon relay which has been ongoing.
3392018-10-04T19:19:56 <wumpus> lol that test doesn't even *test* zmq
3402018-10-04T19:20:03 <wumpus> I don't understand how it can fail
3412018-10-04T19:20:32 *** fanquake has joined #bitcoin-core-dev
3422018-10-04T19:20:38 <wumpus> it jst tests some administrative rpc functions related to zmq
3432018-10-04T19:21:02 <wumpus> gmaxwell: might be better to do that when there's more people
3442018-10-04T19:21:21 <gmaxwell> OK
3452018-10-04T19:21:24 <wumpus> but, is up to you
3462018-10-04T19:21:48 <jcorgan> maybe it's interface_zmq.py
3472018-10-04T19:21:59 *** nehan_ has joined #bitcoin-core-dev
3482018-10-04T19:22:05 *** nehan_ has quit IRC
3492018-10-04T19:22:19 <wumpus> jcorgan: that's the one that really tests the zmq interface, yes
3502018-10-04T19:22:45 <gmaxwell> wumpus: well, I'd like to-- the people who aren't here will probably hear about it at the events there at. :)
3512018-10-04T19:22:48 <jcorgan> right, but is that the one randomly failing?
3522018-10-04T19:23:19 <wumpus> phantomcircuit: I don't understand it, you make P2P changes, and a test completely unrelated to P2P starts failing
3532018-10-04T19:23:20 <gmaxwell> wumpus: I guess it can fail if the node isn't up by the time it attempts the rpc?
3542018-10-04T19:23:52 <wumpus> unless your poll somehow interferes with libevent, but I wouldn't understand why
3552018-10-04T19:23:55 <gmaxwell> like, e.g. poll having a sleep timeout during startup where the select didn't could slow down bringup slightly.
3562018-10-04T19:24:15 <wumpus> the test framework is smart enough to wait for the RPC interface to actually work, AFAIK
3572018-10-04T19:24:31 <wumpus> (there's this 'warmup' period that it needs to ignore, for example)
3582018-10-04T19:24:32 <gmaxwell> if so, then I've got no suggstions. :)
3592018-10-04T19:24:56 <wumpus> well it mightb be that this test does something ... special
3602018-10-04T19:25:15 <wumpus> #topic recon relay (gmaxwell)
3612018-10-04T19:25:42 <gmaxwell> Sipa, gleb, and I have been continuing to work on set recon relay. Gleb has made a lot of progress with simulations.
3622018-10-04T19:26:28 <gmaxwell> In his simulated network topology he shows that the best possible (no 'overhead') relay using 8 byte tx identifiers would use about 44x less bandwidth for relay than what the code currently does.
3632018-10-04T19:27:40 <gmaxwell> (optimal would basically be exach node gets exactly 1 inv per tx and no more) Simulations of our recon work don't quite achieve optimality (since we also want relay to be reasonably fast) but end up only using 2-3x the bandwidth of the theoretically optimal usage, which sounds pretty good compared to 44x. :)
3642018-10-04T19:28:25 <gmaxwell> Sipa and I (mostly sipa) have been working on optimizing the recon code itself, which is in part important because its performance helps tell us what parameters make sense to propose.
3652018-10-04T19:28:36 <gmaxwell> E.g. some benchmark results from last night: https://people.xiph.org/~greg/temp/srr2.png
3662018-10-04T19:28:42 <wumpus> nice !
3672018-10-04T19:29:33 <gmaxwell> This shows how long it takes to do the computation for reconciling 150 differences (which is a good high watermark from glebs simulations), as a function of how long the short-txids we're using (in bits).
3682018-10-04T19:30:22 <gmaxwell> The graph shows that some sizes are much faster in the implementation currently, for optimization (and the number theory that enables those optimizations) reasons.
3692018-10-04T19:30:26 <wumpus> 44x less bandwidth is more than impressive, I didn't know that the invs were such a large part of the traffic
3702018-10-04T19:31:25 <gmaxwell> Ah! that figure is perfectly efficient invs (one inv per host) vs invs in what we do today. Invs are a majority of traffic on nodes right now, but those figure ignore all the non-inv traffic.
3712018-10-04T19:31:25 <wumpus> but that's similar to my surprise how much (at least of outgoing traffic) is 'reject' messages
3722018-10-04T19:31:50 <gmaxwell> So in terms of actual total traffic impact, maybe halve those numbers for your expectations.
3732018-10-04T19:32:09 <sipa> ohai
3742018-10-04T19:32:38 <gmaxwell> Basically gleb's simulator simulates a plausable bitcoin network topology, and then measures how transactions relay around in it with different relaying schemes, so we can try different ideas and measure their impacts.
3752018-10-04T19:32:55 <gmaxwell> So in any case, lots of progress going on there.
3762018-10-04T19:32:59 <wumpus> is this simulator available anywhere?
3772018-10-04T19:33:36 <gmaxwell> Not yet. Sipa and I need to convince gleb that his code is not too awful, I think.
3782018-10-04T19:34:10 <wumpus> no hurry, though it would be nice to have, if it was available we'd want to link it
3792018-10-04T19:34:16 <gmaxwell> Absolutely.
3802018-10-04T19:34:53 <gmaxwell> In any case, right now we're still in a fairly researchy mode, looping over detailed ideas and feeding the results back in to tell us what to try next.
3812018-10-04T19:35:48 <gmaxwell> Thats all I've got for now, unless sleepwalking sipa has more.
3822018-10-04T19:36:16 <sipa> not really
3832018-10-04T19:36:52 <wumpus> you could say so, it's .. 04:36 there?
3842018-10-04T19:37:26 <wumpus> thanks for the update!
3852018-10-04T19:38:44 <wumpus> I guess it's time to close the meeting
3862018-10-04T19:39:04 <wumpus> #endmeeting
3872018-10-04T19:39:04 <lightningbot> Meeting ended Thu Oct 4 19:39:04 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3882018-10-04T19:39:04 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-04-19.02.html
3892018-10-04T19:39:04 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-04-19.02.txt
3902018-10-04T19:39:04 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-04-19.02.log.html
3912018-10-04T19:39:05 <gmaxwell> Sounds good.
3922018-10-04T19:39:18 <sipa> i wasn't trying to make the meeting even (i completely.forgot about it), but jetlag made me randomly wake up
3932018-10-04T19:42:49 *** fanquake has quit IRC
3942018-10-04T19:43:36 <gmaxwell> That ZMQ rpc test looks like it has a pretty poor ratio of speed to utility. It doesn't really even seem to actually test anything other than calling the RPCs doesn't catch fire.
3952018-10-04T19:44:04 <gmaxwell> Which is not totally useless, but not terribly useful either.
3962018-10-04T19:45:22 *** clarkmoody has quit IRC
3972018-10-04T19:45:46 <jcorgan> are there other tests like that one for other RPC calls?
3982018-10-04T19:47:37 <jcorgan> i don't see any others that just test that one thing
3992018-10-04T19:49:20 <gmaxwell> I was going to write that it would probably make sense to merge all 'just run the thing and don't test anything much' tests into a single test, but ZMQ might already just be seperate because the software might not be compiled with ZMQ support.
4002018-10-04T19:49:59 <jcorgan> well it uses the skip check, those could be rolled in
4012018-10-04T19:51:59 *** Zenton has joined #bitcoin-core-dev
4022018-10-04T19:53:30 <jcorgan> i guess that would apply to the whole module, though, so no
4032018-10-04T20:14:54 *** phwalkr has quit IRC
4042018-10-04T20:19:29 *** Zenton has quit IRC
4052018-10-04T20:24:10 *** Krellan has quit IRC
4062018-10-04T20:26:09 *** Krellan has joined #bitcoin-core-dev
4072018-10-04T20:31:39 *** Zenton has joined #bitcoin-core-dev
4082018-10-04T20:32:28 *** Zenton has joined #bitcoin-core-dev
4092018-10-04T20:44:55 <phantomcircuit> gmaxwell, it's separate so it doesn't run when zmq isn't available
4102018-10-04T20:45:01 <phantomcircuit> and that seems to be a module level thing
4112018-10-04T20:47:04 *** promag has joined #bitcoin-core-dev
4122018-10-04T20:57:19 *** IGHOR has quit IRC
4132018-10-04T20:59:10 *** IGHOR has joined #bitcoin-core-dev
4142018-10-04T21:04:57 *** Victorsueca has quit IRC
4152018-10-04T21:06:08 *** Victorsueca has joined #bitcoin-core-dev
4162018-10-04T21:20:56 *** promag has quit IRC
4172018-10-04T21:27:29 *** elichai2 has quit IRC
4182018-10-04T21:39:21 *** Guyver2 has quit IRC
4192018-10-04T21:43:17 *** michaelsdunn1 has quit IRC
4202018-10-04T21:50:34 *** promag has joined #bitcoin-core-dev
4212018-10-04T21:55:11 *** rex4539 has quit IRC
4222018-10-04T21:55:49 *** rex4539 has joined #bitcoin-core-dev
4232018-10-04T22:08:45 *** nullptr| has quit IRC
4242018-10-04T22:21:25 *** justanotheruser has joined #bitcoin-core-dev
4252018-10-04T22:22:11 *** nullptr| has joined #bitcoin-core-dev
4262018-10-04T22:40:57 *** Murch has joined #bitcoin-core-dev
4272018-10-04T22:41:41 *** nullptr| has quit IRC
4282018-10-04T22:45:01 *** nullptr| has joined #bitcoin-core-dev
4292018-10-04T22:45:55 *** promag has quit IRC
4302018-10-04T22:54:44 <kanzure> yes we were busy in tokyo
4312018-10-04T22:57:09 *** promag has joined #bitcoin-core-dev
4322018-10-04T23:02:52 *** reallll has joined #bitcoin-core-dev
4332018-10-04T23:06:30 *** belcher_ has quit IRC
4342018-10-04T23:24:08 *** reallll is now known as belcher_
4352018-10-04T23:25:14 *** rex4539 has quit IRC
4362018-10-04T23:43:08 *** promag has quit IRC