12018-10-16T00:14:13 *** Zenton has quit IRC
22018-10-16T00:16:52 *** Zenton has joined #bitcoin-core-dev
32018-10-16T00:17:37 *** dongcarl_ has joined #bitcoin-core-dev
42018-10-16T00:18:54 *** promag has quit IRC
52018-10-16T00:20:55 *** dongcarl_ has quit IRC
62018-10-16T00:25:53 *** owowo has quit IRC
72018-10-16T00:31:13 *** morcos has quit IRC
82018-10-16T00:33:48 *** morcos has joined #bitcoin-core-dev
92018-10-16T00:36:27 *** proletesseract has quit IRC
102018-10-16T00:40:52 *** dongcarl_ has joined #bitcoin-core-dev
112018-10-16T00:49:56 *** Victorsueca has quit IRC
122018-10-16T00:51:04 *** Victorsueca has joined #bitcoin-core-dev
132018-10-16T00:56:03 *** proletesseract has joined #bitcoin-core-dev
142018-10-16T01:00:40 *** MrPaz has joined #bitcoin-core-dev
152018-10-16T01:01:18 *** dongcarl_ has quit IRC
162018-10-16T01:05:36 *** fanquake has joined #bitcoin-core-dev
172018-10-16T01:12:12 *** fanquake has quit IRC
182018-10-16T01:13:13 *** AaronvanW has quit IRC
192018-10-16T01:13:34 *** AaronvanW has joined #bitcoin-core-dev
202018-10-16T01:17:53 *** AaronvanW has quit IRC
212018-10-16T01:22:40 *** drexl has quit IRC
222018-10-16T01:23:44 *** str4d has quit IRC
232018-10-16T01:31:47 *** Murch has quit IRC
242018-10-16T01:39:01 *** rh0nj has quit IRC
252018-10-16T01:40:07 *** rh0nj has joined #bitcoin-core-dev
262018-10-16T01:47:59 *** dongcarl_ has joined #bitcoin-core-dev
272018-10-16T01:49:32 *** dongcarl_ has quit IRC
282018-10-16T02:24:01 *** Murch has joined #bitcoin-core-dev
292018-10-16T02:31:42 *** tryphe has quit IRC
302018-10-16T02:31:48 *** Murch has quit IRC
312018-10-16T02:32:33 *** Krellan has quit IRC
322018-10-16T02:34:11 *** intcat has quit IRC
332018-10-16T02:35:21 *** intcat has joined #bitcoin-core-dev
342018-10-16T02:39:16 *** bitconner has quit IRC
352018-10-16T02:42:10 *** tryphe has joined #bitcoin-core-dev
362018-10-16T02:46:25 *** leishman has joined #bitcoin-core-dev
372018-10-16T02:47:55 *** hebasto has joined #bitcoin-core-dev
382018-10-16T02:50:38 *** leishman has quit IRC
392018-10-16T02:55:22 *** Murch has joined #bitcoin-core-dev
402018-10-16T02:57:08 <kallewoof> How does bitcoin core track bip9 activation states? I have odd cases where a copied chain state will result in all bip9 soft forks turning up as "failed" rather than "activated". If I disable the timeout, they show up as 'started', but with 'possible: false'.
412018-10-16T02:59:39 *** bitconner has joined #bitcoin-core-dev
422018-10-16T03:00:15 *** arubi has quit IRC
432018-10-16T03:01:41 <sipa> kallewoof: versionbits.cpp
442018-10-16T03:02:07 *** schnerchi has joined #bitcoin-core-dev
452018-10-16T03:02:14 *** luke-jr has quit IRC
462018-10-16T03:02:26 *** luke-jr has joined #bitcoin-core-dev
472018-10-16T03:02:57 <kallewoof> sipa: Yeah, I've been staring at that file for awhile now. Will stare some more.
482018-10-16T03:03:35 <sipa> kallewoof: it should be implementing bip9 exactly
492018-10-16T03:04:39 *** bitconner has quit IRC
502018-10-16T03:04:54 *** arubi has joined #bitcoin-core-dev
512018-10-16T03:05:01 <kallewoof> Yeah, I think I'm confused over what I'm confused over tbh. Will do some debugging.
522018-10-16T03:05:14 *** schnerch_ has quit IRC
532018-10-16T03:07:01 <achow101> kallewoof: those errors you mention sound like mtp isn't being computed correctly
542018-10-16T03:07:45 <kallewoof> achow101: Huh.. I haven't really touched that part of the code.
552018-10-16T03:09:38 <sipa> but everything should be recomputed at runtime
562018-10-16T03:10:13 <achow101> kallewoof: sipa: is it possible that pruned chainstates cannot compute bip9 status?
572018-10-16T03:10:30 <kallewoof> They only rely on block headers so I think they should be able to
582018-10-16T03:11:45 <sipa> indeed
592018-10-16T03:16:32 *** bitcoin-git has joined #bitcoin-core-dev
602018-10-16T03:16:33 <bitcoin-git> [bitcoin] MeshCollider opened pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
612018-10-16T03:16:33 *** bitcoin-git has left #bitcoin-core-dev
622018-10-16T03:19:41 *** jack has joined #bitcoin-core-dev
632018-10-16T03:20:57 *** jack has quit IRC
642018-10-16T03:21:16 *** Murch has quit IRC
652018-10-16T03:52:00 *** bitcoin-git has joined #bitcoin-core-dev
662018-10-16T03:52:00 <bitcoin-git> [bitcoin] kallewoof opened pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
672018-10-16T03:52:00 *** bitcoin-git has left #bitcoin-core-dev
682018-10-16T04:00:40 *** schnerch_ has joined #bitcoin-core-dev
692018-10-16T04:02:14 *** MrPaz has quit IRC
702018-10-16T04:03:30 *** schnerchi has quit IRC
712018-10-16T04:24:31 *** rex4539 has quit IRC
722018-10-16T04:42:20 *** geezas has joined #bitcoin-core-dev
732018-10-16T04:55:08 *** bitcoin-git has joined #bitcoin-core-dev
742018-10-16T04:55:09 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a2cac787360...9bd3ff430b4e
752018-10-16T04:55:09 <bitcoin-git> bitcoin/master 36323e2 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode...
762018-10-16T04:55:10 <bitcoin-git> bitcoin/master 9bd3ff4 Wladimir J. van der Laan: Merge #14383: qt: Clean system tray icon menu for '-disablewallet' mode...
772018-10-16T04:55:10 *** bitcoin-git has left #bitcoin-core-dev
782018-10-16T04:56:14 *** bitcoin-git has joined #bitcoin-core-dev
792018-10-16T04:56:14 <bitcoin-git> [bitcoin] laanwj closed pull request #14383: qt: Clean system tray icon menu for '-disablewallet' mode (master...20181003-disablewallet-systray) https://github.com/bitcoin/bitcoin/pull/14383
802018-10-16T04:56:14 *** bitcoin-git has left #bitcoin-core-dev
812018-10-16T04:59:58 *** bitconner has joined #bitcoin-core-dev
822018-10-16T05:04:49 *** bitcoin-git has joined #bitcoin-core-dev
832018-10-16T05:04:50 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bd3ff430b4e...2468471e1398
842018-10-16T05:04:50 <bitcoin-git> bitcoin/master 7d173c4 Tim Ruffing: qt: Revert "Force TLS1.0+ for SSL connections"...
852018-10-16T05:04:51 <bitcoin-git> bitcoin/master 2468471 Wladimir J. van der Laan: Merge #14403: qt: Revert "Force TLS1.0+ for SSL connections"...
862018-10-16T05:04:51 *** bitcoin-git has left #bitcoin-core-dev
872018-10-16T05:04:57 *** bitconner has quit IRC
882018-10-16T05:05:50 *** bitcoin-git has joined #bitcoin-core-dev
892018-10-16T05:05:50 <bitcoin-git> [bitcoin] laanwj closed pull request #14403: qt: Revert "Force TLS1.0+ for SSL connections" (master...sslv3) https://github.com/bitcoin/bitcoin/pull/14403
902018-10-16T05:05:50 *** bitcoin-git has left #bitcoin-core-dev
912018-10-16T05:10:56 <hebasto> wumpus: regarding #14370, should I add a modified unit test to the same PR or it should be another PR?
922018-10-16T05:10:57 <gribble> https://github.com/bitcoin/bitcoin/issues/14370 | utils and libraries: Allow values quoting in config files by hebasto · Pull Request #14370 · bitcoin/bitcoin · GitHub
932018-10-16T05:13:33 *** unholymachine has quit IRC
942018-10-16T05:18:31 *** murrayn has joined #bitcoin-core-dev
952018-10-16T05:18:32 *** murrayn has joined #bitcoin-core-dev
962018-10-16T05:27:09 <meshcollider> wumpus: #14291 is also RTM I think
972018-10-16T05:27:14 <gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
982018-10-16T05:27:32 <meshcollider> and can we please add #14454 to high priority
992018-10-16T05:27:34 <gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
1002018-10-16T05:27:38 *** kallewoof has quit IRC
1012018-10-16T05:28:16 <sipa> meshcollider: that's growing into a painful amount of code :)
1022018-10-16T05:28:42 <wumpus> meshcollider: thanks, will have a look
1032018-10-16T05:28:55 <sipa> will review in detail soon
1042018-10-16T05:28:58 *** kallewoof has joined #bitcoin-core-dev
1052018-10-16T05:29:07 <meshcollider> sipa: the segwit one?
1062018-10-16T05:29:11 <sipa> and thanks for quickly addressing my comments so far
1072018-10-16T05:29:13 <meshcollider> sipa: it still removes more than it adds ;)
1082018-10-16T05:29:53 <meshcollider> thanks for giving comments so quickly
1092018-10-16T05:31:48 <meshcollider> and 14303 removes all the duplicated pwallet->MarkDirty() calls which will tidy it up a bit more too
1102018-10-16T05:33:46 <wumpus> habasto: would rather close 14370, don't think it is a necessary change
1112018-10-16T05:34:37 <hebasto> wumpus: thanks for your quick review; I'll think about it.
1122018-10-16T05:35:03 <wumpus> if something can be solved by better documentation, please work on documentation!
1132018-10-16T05:35:12 <wumpus> don't change the code instead
1142018-10-16T05:36:48 *** bitcoin-git has joined #bitcoin-core-dev
1152018-10-16T05:36:48 <bitcoin-git> [bitcoin] MeshCollider opened pull request #14494: Error if # is used in rpcpassword in conf (master...201810_hash_in_rpcpassword_error) https://github.com/bitcoin/bitcoin/pull/14494
1162018-10-16T05:36:48 *** bitcoin-git has left #bitcoin-core-dev
1172018-10-16T05:39:01 *** rh0nj has quit IRC
1182018-10-16T05:41:43 <wumpus> habasto: huh so does #13143 provide an actual use-case for quoting functionality?
1192018-10-16T05:41:44 <gribble> https://github.com/bitcoin/bitcoin/issues/13143 | `#` cannot be used rpcpassword (or bitcoin.conf in general) · Issue #13143 · bitcoin/bitcoin · GitHub
1202018-10-16T05:42:08 *** rh0nj has joined #bitcoin-core-dev
1212018-10-16T05:42:39 <meshcollider> wumpus: I would say it makes it even more confusing lol
1222018-10-16T05:43:00 <wumpus> hehe
1232018-10-16T05:43:25 <wumpus> well I remember because windows .ini format has no way to insert #'s, that's also why I know they have no quoting...
1242018-10-16T05:44:07 <wumpus> all this is kind of terrible edge-case stuff
1252018-10-16T05:45:18 <meshcollider> I agree
1262018-10-16T05:46:17 <meshcollider> we should just disallow same-line comments and only exclude lines from the conf if they *start* with a #
1272018-10-16T05:47:27 <wumpus> yes, I think that's a fair option, I remember seeing that in other software (but don't remember which one, right now); though,also a breaking change
1282018-10-16T05:47:54 <wumpus> people might already be using # to comment their .ini files lines... so would create the *opposite* issue :(
1292018-10-16T05:48:28 <meshcollider> yeah I think its too hard to change now
1302018-10-16T05:48:29 <wumpus> anyhow I think 14494 is good, just don't have "illegal hash character" in the error message that's terrible :-)
1312018-10-16T05:48:45 <meshcollider> haha ok what should I change it to
1322018-10-16T05:49:22 <wumpus> well what I said in the PR, it's at most ambigious, it's rejected because it's probably a mistake
1332018-10-16T05:49:35 <meshcollider> " do not use hash characters in rpcpassword" ?
1342018-10-16T05:50:14 <wumpus> if it's an actual comment it is actually okay, in principle
1352018-10-16T05:50:35 <wumpus> well a friendlier message, not something about 'do not use' but just explain to the user why this is a problem
1362018-10-16T05:50:38 <meshcollider> ok
1372018-10-16T05:50:54 <wumpus> illegal hash characer sounds like the cops will show up any time :)
1382018-10-16T05:51:16 <kallewoof> wumpus: I think iptables will happily try to parse # chars unless they are the first on the line
1392018-10-16T05:51:17 *** proletesseract has quit IRC
1402018-10-16T05:51:24 <meshcollider> "using hash in rpcpassword can be ambiguous and should be avoided"
1412018-10-16T05:52:01 <wumpus> yes, that would be better
1422018-10-16T05:52:16 <wumpus> or maybe don't call it hash but simply mention '#'
1432018-10-16T05:53:10 <wumpus> that's more direct for non-english speaking people
1442018-10-16T05:53:52 *** proletesseract has joined #bitcoin-core-dev
1452018-10-16T05:54:21 <hebasto> ^
1462018-10-16T05:54:30 <meshcollider> true, and even english speakers sometimes call it pound or octothorpe
1472018-10-16T05:54:47 *** proletesseract has quit IRC
1482018-10-16T05:58:02 <sipa> meshcollider: probably only antipodians
1492018-10-16T05:59:06 <meshcollider> sipa: lol
1502018-10-16T05:59:24 <meshcollider> sipa: achow used "pound", so it must be you all who are upside down
1512018-10-16T06:01:26 *** proletesseract has joined #bitcoin-core-dev
1522018-10-16T06:06:00 *** proletesseract has quit IRC
1532018-10-16T06:18:22 <luke-jr> meshcollider: but if we can't hash over RPC, how will people mine? /s
1542018-10-16T06:19:16 <sipa> clearly we need to rename it 'pounders'
1552018-10-16T06:21:10 <luke-jr> sipa: also, what are these 'podes' that people are protesting? :p
1562018-10-16T06:29:32 <karelb> I am trying to run my fork of bitcoind on travis.... and travis stops with this
1572018-10-16T06:29:42 <karelb> src/threadinterrupt.cpp:25: mut ==> must, mutt, moot
1582018-10-16T06:29:43 <karelb> Warning: codespell identified likely spelling errors
1592018-10-16T06:29:50 <karelb> failure generated from test/lint/lint-spelling.sh
1602018-10-16T06:29:55 *** ExtraCrispy_ has quit IRC
1612018-10-16T06:29:56 <karelb> .....ummmmm, ok?
1622018-10-16T06:30:32 <karelb> I did no change in threadinterrupt, and that "mut" is just some mutex
1632018-10-16T06:32:17 *** ExtraCrispy_ has joined #bitcoin-core-dev
1642018-10-16T06:39:15 <karelb> well whatever, one commit that renamed "mut" to "mutex" fixed that, I just wonder why I needed to do that...
1652018-10-16T06:40:18 <gwillen> karelb: your travis instance is stupid
1662018-10-16T06:40:24 <gwillen> if you make it less stupid you will have fewer problems
1672018-10-16T06:40:38 <gwillen> it is trying to spell-correct your code, and doing it moronically
1682018-10-16T06:40:43 <karelb> :D
1692018-10-16T06:40:43 <gwillen> and seems to be set to warnings-as-errors.
1702018-10-16T06:40:56 <karelb> I use travis-ci.org
1712018-10-16T06:41:02 <gwillen> well, apparently they are stupid
1722018-10-16T06:41:11 <gwillen> but I imagine there is an option not to make codespell warnings errors
1732018-10-16T06:41:14 <karelb> the same config as bitcoin core
1742018-10-16T06:41:15 <gwillen> which they absolutely should not be
1752018-10-16T06:41:18 <gwillen> oh, hm
1762018-10-16T06:41:21 <gwillen> I mean, seemingly not
1772018-10-16T06:42:36 <karelb> well let's see what happens when I make a PR, if that `mut` stuff is still there
1782018-10-16T06:52:06 *** geezas has quit IRC
1792018-10-16T06:54:29 *** proletesseract has joined #bitcoin-core-dev
1802018-10-16T07:00:50 <meshcollider> sipa: re private keys, if youve imported the private key then the danger isnt as prominent is it
1812018-10-16T07:06:42 *** Krellan has joined #bitcoin-core-dev
1822018-10-16T07:07:35 *** Krellan has quit IRC
1832018-10-16T07:07:52 *** setpill has joined #bitcoin-core-dev
1842018-10-16T07:08:31 <meshcollider> because even if they send to the key directly, you have the privkey
1852018-10-16T07:11:04 *** Krellan has joined #bitcoin-core-dev
1862018-10-16T07:23:33 *** JackH has quit IRC
1872018-10-16T07:24:13 *** DougieBot5000_ is now known as DougieBot5000
1882018-10-16T07:25:04 *** romanz has quit IRC
1892018-10-16T07:25:39 *** romanz has joined #bitcoin-core-dev
1902018-10-16T07:31:30 *** e4xit has joined #bitcoin-core-dev
1912018-10-16T07:32:19 *** hebasto has quit IRC
1922018-10-16T07:33:40 *** hebasto has joined #bitcoin-core-dev
1932018-10-16T07:36:57 *** jungly has joined #bitcoin-core-dev
1942018-10-16T07:44:59 *** bitconner has joined #bitcoin-core-dev
1952018-10-16T07:49:33 *** bitconner has quit IRC
1962018-10-16T08:18:15 *** promag has joined #bitcoin-core-dev
1972018-10-16T08:26:36 *** Empact_ has quit IRC
1982018-10-16T08:30:00 *** murrayn_ has joined #bitcoin-core-dev
1992018-10-16T08:33:18 *** murrayn has quit IRC
2002018-10-16T08:35:15 *** luke-jr has quit IRC
2012018-10-16T08:35:24 *** luke-jr has joined #bitcoin-core-dev
2022018-10-16T08:35:45 *** murrayn_ has quit IRC
2032018-10-16T08:36:06 *** proletesseract has quit IRC
2042018-10-16T08:41:04 *** luke-jr has quit IRC
2052018-10-16T08:41:12 *** luke-jr has joined #bitcoin-core-dev
2062018-10-16T08:49:11 <wumpus> karelb: lol that's stupid
2072018-10-16T08:50:44 <wumpus> please don't tell me that stupid spelling check is mandatory in travis now
2082018-10-16T08:50:56 <karelb> wumpus: maybe it's some misconfiguration... I don't really want to deal with it so I made a commit that I will remove before doing PR
2092018-10-16T08:51:11 <karelb> that commit just renamed mut to mutex
2102018-10-16T08:51:12 <wumpus> AHH apparently it was changed to fail in e413c2ddd1240d7bacd1837fa49d25781fe6e5fa
2112018-10-16T08:51:38 *** Zenton has quit IRC
2122018-10-16T08:52:13 <wumpus> yes I can imagine...
2132018-10-16T08:53:06 <wumpus> i've tried, in vain, to prevent all kinds of silly lints from being merged
2142018-10-16T08:54:22 <karelb> :D
2152018-10-16T08:54:39 <karelb> I wonder why is my fork failing but not bitcoin master
2162018-10-16T08:54:52 <karelb> but I don't wonder *that much*
2172018-10-16T08:55:18 *** Zenton has joined #bitcoin-core-dev
2182018-10-16T08:58:12 *** rex4539 has joined #bitcoin-core-dev
2192018-10-16T08:59:38 <wumpus> maybe... it only runs on PRs?
2202018-10-16T09:01:48 *** bralyclo_ has joined #bitcoin-core-dev
2212018-10-16T09:02:13 <wumpus> well you could always rename it 'mutt' or 'moot', i'm sure that's an improvement...
2222018-10-16T09:02:42 <karelb> 'mutex' seems to work, although 'mutt' has a ring to it
2232018-10-16T09:03:15 *** nickler has joined #bitcoin-core-dev
2242018-10-16T09:03:50 <wumpus> i'm not sure whether this constitutes a 'variable names need to be valid english words' policy
2252018-10-16T09:05:14 *** bralyclow has quit IRC
2262018-10-16T09:07:20 *** murrayn has joined #bitcoin-core-dev
2272018-10-16T09:07:20 *** murrayn has joined #bitcoin-core-dev
2282018-10-16T09:08:43 <promag> wumpus: from the PR discussion looks like that change slipped?
2292018-10-16T09:09:23 *** timothy has joined #bitcoin-core-dev
2302018-10-16T09:10:33 <promag> maybe the reason is because nobody checks the warnings
2312018-10-16T09:11:56 *** ken2812221_ has joined #bitcoin-core-dev
2322018-10-16T09:13:59 <luke-jr> 'variable names need to be valid english words' sounds like a stupid policy..
2332018-10-16T09:22:45 <wumpus> luke-jr: no disagreement from me, i'm sure i've protested in the PR that added this linter, but meh i don't have the energy to fight this
2342018-10-16T09:23:48 *** Victorsueca has quit IRC
2352018-10-16T09:23:54 * wumpus wants to add a linter that deletes all linters
2362018-10-16T09:24:06 <luke-jr> :P
2372018-10-16T09:26:03 <wumpus> soo enough about that shit, are there any serious PRs I should pay attention to?
2382018-10-16T09:26:57 <luke-jr> dunno, barely have time to rebase my own stuff :/
2392018-10-16T09:26:57 *** Krellan has quit IRC
2402018-10-16T09:27:02 *** Victorsueca has joined #bitcoin-core-dev
2412018-10-16T09:28:36 *** Krellan has joined #bitcoin-core-dev
2422018-10-16T09:28:44 <luke-jr> the downgrading warning in 0.17 relnotes is confusing; why is it talking about 0.15?
2432018-10-16T09:29:15 <meshcollider> luke-jr: because that's the version at which it changed isn't it
2442018-10-16T09:29:57 <meshcollider> but yeah its not worded well
2452018-10-16T09:30:04 <luke-jr> dunno, 0.16 didn't mention it
2462018-10-16T09:30:13 <luke-jr> I thought we had a change in 0.17 too?
2472018-10-16T09:30:14 <wumpus> I *guess* it's when you want to downgrade from 0.17 to 0.15?
2482018-10-16T09:30:30 <meshcollider> "Wallets created in 0.16 and later are not compatible with versions prior to 0.16 and will not work if you try to use newly created wallets in older versions. Existing wallets that were created with older versions are not affected by this."
2492018-10-16T09:30:53 <wumpus> it's a bit late to discuss 0.17 release notes, now
2502018-10-16T09:31:10 <meshcollider> it looks like its just been copy+pasted from 0.15, oh well
2512018-10-16T09:31:45 <luke-jr> wumpus: that's not what it says though :/
2522018-10-16T09:31:46 <luke-jr> yes, just noticed
2532018-10-16T09:31:51 <wumpus> it probably has
2542018-10-16T09:32:13 <wumpus> the upgrading/downgrading part tends to be copy-pasted between releases because it tends to stay relevant
2552018-10-16T09:32:46 <wumpus> at some point it can be removed because no one is going to downgrade to 3 major versions back, but still
2562018-10-16T09:33:18 <wumpus> would be good to have close scrutiny of the release notes before a release
2572018-10-16T09:33:33 <promag> wumpus: I'm depending on #14291 for the multiwallet support in the UI
2582018-10-16T09:33:37 <gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
2592018-10-16T09:33:55 <wumpus> promag: yeah have that one merged locally for testing
2602018-10-16T09:34:02 <promag> wumpus: nice
2612018-10-16T09:41:22 <meshcollider> sipa: for the descriptors PR, what if we don't even import the public keys? Why not just import the private keys, otherwise just import the scriptPubKey only as watch only
2622018-10-16T09:41:59 *** ken2812221 has quit IRC
2632018-10-16T09:45:31 *** ken2812221 has joined #bitcoin-core-dev
2642018-10-16T10:06:41 *** AaronvanW has joined #bitcoin-core-dev
2652018-10-16T10:21:16 *** Deacyde has quit IRC
2662018-10-16T10:34:54 *** rex4539 has quit IRC
2672018-10-16T10:35:40 <promag> sipa: meshcollider: please also see #14303
2682018-10-16T10:35:42 <gribble> https://github.com/bitcoin/bitcoin/issues/14303 | rpc: Early call once CWallet::MarkDirty in import calls by promag · Pull Request #14303 · bitcoin/bitcoin · GitHub
2692018-10-16T10:36:35 <meshcollider> promag: Already concept ACK'ed it ;) mentioned it above, its a nice cleanup
2702018-10-16T10:36:56 *** kau has joined #bitcoin-core-dev
2712018-10-16T10:37:40 *** esotericnonsense has quit IRC
2722018-10-16T10:37:58 <promag> ken2812221: how do you build and run tests on windows? do you use wsl and depends?
2732018-10-16T10:41:11 *** esotericnonsense has joined #bitcoin-core-dev
2742018-10-16T10:45:04 *** ken2812221__ has joined #bitcoin-core-dev
2752018-10-16T10:45:20 *** ken2812221_ has quit IRC
2762018-10-16T10:46:59 <ken2812221__> promag: I use both MSVC and virtual machine to build it. The IO on WSL is extremely slow.
2772018-10-16T10:47:27 <promag> ken2812221__: right, it is
2782018-10-16T10:48:09 <promag> ken2812221__: is there a guide or something so I can easily setup the same here?
2792018-10-16T10:51:37 <ken2812221__> Copy bitcoin-cli.exe and bitcoind.exe into src folder. Modify and copy test\config.ini.in to test\config.ini. Then you can run python test\functional\test_runner.py --force.
2802018-10-16T10:57:01 *** hebasto has quit IRC
2812018-10-16T10:57:23 *** hebasto has joined #bitcoin-core-dev
2822018-10-16T10:57:40 <promag> I suspect #14299 will create more noise
2832018-10-16T10:57:41 <gribble> https://github.com/bitcoin/bitcoin/issues/14299 | Deprecate wallet `generate` RPC method · Issue #14299 · bitcoin/bitcoin · GitHub
2842018-10-16T11:06:25 *** belcher_ has joined #bitcoin-core-dev
2852018-10-16T11:09:41 *** belcher has quit IRC
2862018-10-16T11:10:18 <wumpus> I don't know, I think telling people to use generatetoaddress is fine
2872018-10-16T11:10:39 <wumpus> the mining functionality in bitcoin core is not exactly used a lot
2882018-10-16T11:12:24 <wumpus> seperating the mining from the wallet always made sense, not sure why it hasn't been done before
2892018-10-16T11:14:56 *** ken2812221__ has quit IRC
2902018-10-16T11:16:38 <promag> yeap, I also think the ones using it can easily change
2912018-10-16T11:22:23 *** kau has quit IRC
2922018-10-16T11:24:26 <promag> wumpus: does my response clarifies your concern https://github.com/bitcoin/bitcoin/pull/14291/files#r225491304 ?
2932018-10-16T11:26:00 <wumpus> promag: i'm personally scared of that behavior, but if others think it's ok, i'll just go along...
2942018-10-16T11:26:44 <wumpus> promag: you're right it only scans the files at recursion depth=0 for the btree signature, though it still *nests* into all the directories nevertheless
2952018-10-16T11:26:51 <promag> wumpus: do you think it should do that only if walletdir != datadir?
2962018-10-16T11:28:00 <wumpus> that would, to me, seem like the most straightforward way to prevent this; then give the user a clear explanation *why* it won't work and what they can do to make it work
2972018-10-16T11:29:15 <wumpus> one specific concern: opening and closing the .lock file will nix the datadir lock, at least on some OSes
2982018-10-16T11:30:17 <promag> hmm, skip that filename then?
2992018-10-16T11:30:21 <promag> ryanofsky: ^
3002018-10-16T11:30:31 <wumpus> that seems *extremely* fragile
3012018-10-16T11:31:54 <wumpus> maybe this brings a valid problem to light: there's just too many ways to organize the data directory with regard to wallets, all need to be handled, and tested
3022018-10-16T11:32:06 <wumpus> in any case, I'd prefer if the RPC simply failed in that case
3032018-10-16T11:33:07 <promag> but do you agree on the concept?
3042018-10-16T11:37:59 <wumpus> in the case where there is a separate wallet directory, certainly!
3052018-10-16T11:38:48 *** bitcoin-git has joined #bitcoin-core-dev
3062018-10-16T11:38:48 <bitcoin-git> [bitcoin] practicalswift opened pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
3072018-10-16T11:38:48 *** bitcoin-git has left #bitcoin-core-dev
3082018-10-16T11:42:45 <promag> wumpus: I'll push a commit with that change to see what others say
3092018-10-16T11:51:55 *** bitcoin-git has joined #bitcoin-core-dev
3102018-10-16T11:51:56 <bitcoin-git> [bitcoin] practicalswift opened pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
3112018-10-16T11:51:56 *** bitcoin-git has left #bitcoin-core-dev
3122018-10-16T12:05:07 <promag> ken2812221: just say build_msvc/README.md
3132018-10-16T12:05:19 <promag> s/say/saw :P
3142018-10-16T12:07:38 <promag> assign #14495 to MarcoFalke?
3152018-10-16T12:07:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14495 | build: Warn (dont fail!) on spelling errors by practicalswift · Pull Request #14495 · bitcoin/bitcoin · GitHub
3162018-10-16T12:11:13 *** promag has quit IRC
3172018-10-16T12:30:35 *** bitconner has joined #bitcoin-core-dev
3182018-10-16T12:34:59 *** bitconner has quit IRC
3192018-10-16T12:37:00 *** shesek has joined #bitcoin-core-dev
3202018-10-16T12:37:00 *** shesek has quit IRC
3212018-10-16T12:37:00 *** shesek has joined #bitcoin-core-dev
3222018-10-16T12:40:20 *** drexl has joined #bitcoin-core-dev
3232018-10-16T12:42:01 *** rh0nj has quit IRC
3242018-10-16T12:43:07 *** rh0nj has joined #bitcoin-core-dev
3252018-10-16T13:01:11 *** dcousens has joined #bitcoin-core-dev
3262018-10-16T13:02:03 *** dcousens has quit IRC
3272018-10-16T13:03:04 *** AaronvanW has quit IRC
3282018-10-16T13:04:31 *** timothy has quit IRC
3292018-10-16T13:05:50 *** Jmabsd has joined #bitcoin-core-dev
3302018-10-16T13:05:57 *** timothy has joined #bitcoin-core-dev
3312018-10-16T13:06:27 <Jmabsd> sorry for disturbing - can you give me some reference where the hash in a P2WSH pubkey script is validated or/and generated? i like to understand if it's single or dual iteration SHA256 and how the code looks.
3322018-10-16T13:09:54 *** echonaut has joined #bitcoin-core-dev
3332018-10-16T13:10:30 *** echonaut13 has quit IRC
3342018-10-16T13:15:44 *** promag has joined #bitcoin-core-dev
3352018-10-16T13:16:41 *** Guyver2 has joined #bitcoin-core-dev
3362018-10-16T13:23:52 *** AaronvanW has joined #bitcoin-core-dev
3372018-10-16T13:42:20 *** Deinogalerix21 has joined #bitcoin-core-dev
3382018-10-16T13:51:54 *** Deinogalerix21 has quit IRC
3392018-10-16T13:59:15 <karelb> ad the codespell issue - it seems I have branched master *before* the codespell version was fixed, so that's why it got updated now and shouted at me
3402018-10-16T13:59:36 <karelb> which explains that
3412018-10-16T14:04:07 *** zivl has quit IRC
3422018-10-16T14:07:13 *** Krellan has quit IRC
3432018-10-16T14:07:54 <promag> wumpus: pushed https://github.com/bitcoin/bitcoin/pull/14291/commits/4702191778eaa23152fccd4d219a649ce712e79c
3442018-10-16T14:08:24 *** Krellan has joined #bitcoin-core-dev
3452018-10-16T14:11:26 *** promag has quit IRC
3462018-10-16T14:35:03 *** leishman has joined #bitcoin-core-dev
3472018-10-16T14:35:46 *** leishman has quit IRC
3482018-10-16T14:36:34 *** bitconner has joined #bitcoin-core-dev
3492018-10-16T14:36:40 *** leishman has joined #bitcoin-core-dev
3502018-10-16T14:38:10 *** promag has joined #bitcoin-core-dev
3512018-10-16T14:39:53 *** grubles has quit IRC
3522018-10-16T14:41:16 *** bitconner has quit IRC
3532018-10-16T14:41:39 <phantomcircuit> wumpus, can you look at #14335
3542018-10-16T14:41:40 <gribble> https://github.com/bitcoin/bitcoin/issues/14335 | net: refactor: cleanup ThreadSocketHandler by pstratem · Pull Request #14335 · bitcoin/bitcoin · GitHub
3552018-10-16T14:52:18 *** michaelsdunn1 has joined #bitcoin-core-dev
3562018-10-16T14:55:54 *** nullptr| has quit IRC
3572018-10-16T14:56:56 *** nullptr| has joined #bitcoin-core-dev
3582018-10-16T15:09:41 *** esotericnonsense has quit IRC
3592018-10-16T15:11:14 *** esotericnonsense has joined #bitcoin-core-dev
3602018-10-16T15:13:24 <wumpus> phantomcircuit: sure
3612018-10-16T15:13:38 *** bergz has joined #bitcoin-core-dev
3622018-10-16T15:14:46 *** bitcoin-git has joined #bitcoin-core-dev
3632018-10-16T15:14:46 <bitcoin-git> [bitcoin] DesWurstes closed pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
3642018-10-16T15:14:46 *** bitcoin-git has left #bitcoin-core-dev
3652018-10-16T15:21:10 *** bitcoin-git has joined #bitcoin-core-dev
3662018-10-16T15:21:10 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2468471e1398...23419e4c4939
3672018-10-16T15:21:11 <bitcoin-git> bitcoin/master edb5350 Patrick Strateman: Move NotifyNumConnectionsChanged logic to private method.
3682018-10-16T15:21:11 <bitcoin-git> bitcoin/master 7479b63 Patrick Strateman: Move DisconnectNodes logic to private method.
3692018-10-16T15:21:12 <bitcoin-git> bitcoin/master 2af9cff Patrick Strateman: Move InactivityCheck logic to private method.
3702018-10-16T15:21:12 *** bitcoin-git has left #bitcoin-core-dev
3712018-10-16T15:21:43 *** shesek has quit IRC
3722018-10-16T15:22:28 *** bitcoin-git has joined #bitcoin-core-dev
3732018-10-16T15:22:28 <bitcoin-git> [bitcoin] laanwj closed pull request #14335: net: refactor: cleanup ThreadSocketHandler (master...2018-09-24-thread-handler-cleanup) https://github.com/bitcoin/bitcoin/pull/14335
3742018-10-16T15:22:28 *** bitcoin-git has left #bitcoin-core-dev
3752018-10-16T15:24:28 <phantomcircuit> wumpus, ty
3762018-10-16T15:40:43 *** arubi has quit IRC
3772018-10-16T15:44:30 *** JackH has joined #bitcoin-core-dev
3782018-10-16T15:44:51 *** esotericnonsense has quit IRC
3792018-10-16T15:45:23 *** arubi has joined #bitcoin-core-dev
3802018-10-16T15:46:45 *** promag has quit IRC
3812018-10-16T15:46:57 *** intcat has quit IRC
3822018-10-16T15:47:06 *** esotericnonsense has joined #bitcoin-core-dev
3832018-10-16T15:48:32 *** iphelix_ has quit IRC
3842018-10-16T15:49:29 *** grubles has joined #bitcoin-core-dev
3852018-10-16T15:50:39 *** intcat has joined #bitcoin-core-dev
3862018-10-16T15:53:38 *** iphelix has joined #bitcoin-core-dev
3872018-10-16T15:54:01 *** iphelix is now known as Guest3720
3882018-10-16T15:55:36 *** Guest3720 has quit IRC
3892018-10-16T15:59:10 *** justanotheruser has quit IRC
3902018-10-16T16:00:35 *** Murch has joined #bitcoin-core-dev
3912018-10-16T16:01:30 *** esotericnonsense has quit IRC
3922018-10-16T16:03:15 *** iphelix_ has joined #bitcoin-core-dev
3932018-10-16T16:04:42 *** esotericnonsense has joined #bitcoin-core-dev
3942018-10-16T16:04:51 *** Krellan has quit IRC
3952018-10-16T16:04:56 *** leishman has quit IRC
3962018-10-16T16:05:29 *** leishman has joined #bitcoin-core-dev
3972018-10-16T16:06:04 *** setpill has quit IRC
3982018-10-16T16:06:43 *** esotericnonsense has quit IRC
3992018-10-16T16:10:01 *** leishman has quit IRC
4002018-10-16T16:10:16 *** leishman has joined #bitcoin-core-dev
4012018-10-16T16:19:45 *** singleSole_ has joined #bitcoin-core-dev
4022018-10-16T16:20:06 <singleSole_> hi
4032018-10-16T16:29:14 *** esotericnonsense has joined #bitcoin-core-dev
4042018-10-16T16:31:13 *** singleSole_ has quit IRC
4052018-10-16T16:33:59 *** promag has joined #bitcoin-core-dev
4062018-10-16T16:35:18 *** owowo has joined #bitcoin-core-dev
4072018-10-16T16:35:28 *** esotericnonsens_ has joined #bitcoin-core-dev
4082018-10-16T16:35:33 *** esotericnonsense has quit IRC
4092018-10-16T16:35:42 *** esotericnonsens_ is now known as esotericnonsense
4102018-10-16T16:38:32 *** Krellan has joined #bitcoin-core-dev
4112018-10-16T16:40:16 *** jungly has quit IRC
4122018-10-16T16:41:04 *** sfhi has joined #bitcoin-core-dev
4132018-10-16T16:49:30 *** jarthur has joined #bitcoin-core-dev
4142018-10-16T16:52:19 *** bergz has quit IRC
4152018-10-16T17:05:16 *** sfhi has quit IRC
4162018-10-16T17:16:30 *** promag has quit IRC
4172018-10-16T17:18:52 *** timothy has quit IRC
4182018-10-16T17:48:44 *** bralyclow has joined #bitcoin-core-dev
4192018-10-16T17:49:50 *** bralyclow has joined #bitcoin-core-dev
4202018-10-16T17:51:57 *** bralyclo_ has quit IRC
4212018-10-16T18:00:35 *** promag has joined #bitcoin-core-dev
4222018-10-16T18:01:47 *** Zenton has quit IRC
4232018-10-16T18:04:20 *** Zenton has joined #bitcoin-core-dev
4242018-10-16T18:07:06 *** bralyclo_ has joined #bitcoin-core-dev
4252018-10-16T18:07:32 *** bralyclo_ has joined #bitcoin-core-dev
4262018-10-16T18:08:37 *** bralyclo_ has quit IRC
4272018-10-16T18:09:01 *** bralyclo_ has joined #bitcoin-core-dev
4282018-10-16T18:09:32 *** luke-jr has quit IRC
4292018-10-16T18:09:50 *** luke-jr has joined #bitcoin-core-dev
4302018-10-16T18:10:03 *** bralyclow has quit IRC
4312018-10-16T18:30:49 *** bergz has joined #bitcoin-core-dev
4322018-10-16T18:31:26 *** wumpus has quit IRC
4332018-10-16T18:31:39 *** MrPaz has joined #bitcoin-core-dev
4342018-10-16T18:38:29 *** Krellan has quit IRC
4352018-10-16T19:01:54 *** bitconner has joined #bitcoin-core-dev
4362018-10-16T19:18:04 *** bralyclo_ has quit IRC
4372018-10-16T19:18:26 *** bralyclow has joined #bitcoin-core-dev
4382018-10-16T19:21:18 *** promag has quit IRC
4392018-10-16T19:40:00 *** bralyclow2 has joined #bitcoin-core-dev
4402018-10-16T19:47:00 *** michaelsdunn1 has quit IRC
4412018-10-16T19:48:23 *** bralyclow2 has quit IRC
4422018-10-16T19:48:45 *** bralyclow2 has joined #bitcoin-core-dev
4432018-10-16T19:49:03 *** bralyclow2 has quit IRC
4442018-10-16T19:49:38 *** bralyclow2 has joined #bitcoin-core-dev
4452018-10-16T19:50:08 *** promag has joined #bitcoin-core-dev
4462018-10-16T19:51:16 *** bralyclow2 has quit IRC
4472018-10-16T19:51:30 *** michaelsdunn1 has joined #bitcoin-core-dev
4482018-10-16T19:51:30 *** michaelsdunn1 has quit IRC
4492018-10-16T19:51:30 *** michaelsdunn1 has joined #bitcoin-core-dev
4502018-10-16T19:53:50 *** Krellan has joined #bitcoin-core-dev
4512018-10-16T19:59:48 *** jarthur has quit IRC
4522018-10-16T20:08:17 *** michaelsdunn1 has quit IRC
4532018-10-16T20:11:20 *** michaelsdunn1 has joined #bitcoin-core-dev
4542018-10-16T20:23:07 *** Aaronvan_ has joined #bitcoin-core-dev
4552018-10-16T20:26:11 *** AaronvanW has quit IRC
4562018-10-16T20:27:41 *** Squidicuz has joined #bitcoin-core-dev
4572018-10-16T20:31:54 *** proletesseract has joined #bitcoin-core-dev
4582018-10-16T20:36:16 *** Murch has quit IRC
4592018-10-16T20:41:08 *** lukedashjr has joined #bitcoin-core-dev
4602018-10-16T20:45:26 *** luke-jr has quit IRC
4612018-10-16T20:45:51 *** lukedashjr is now known as luke-jr
4622018-10-16T20:48:09 <hebasto> promag: regarding "breaking change" in #14494. why?
4632018-10-16T20:48:10 <gribble> https://github.com/bitcoin/bitcoin/issues/14494 | Error if # is used in rpcpassword in conf by MeshCollider · Pull Request #14494 · bitcoin/bitcoin · GitHub
4642018-10-16T20:49:45 *** dviola has joined #bitcoin-core-dev
4652018-10-16T20:58:23 *** promag has quit IRC
4662018-10-16T21:03:00 *** dviola has quit IRC
4672018-10-16T21:10:20 *** cryptapus has joined #bitcoin-core-dev
4682018-10-16T21:10:20 *** cryptapus has quit IRC
4692018-10-16T21:10:20 *** cryptapus has joined #bitcoin-core-dev
4702018-10-16T21:11:18 *** jamesob has joined #bitcoin-core-dev
4712018-10-16T21:15:52 *** Aaronvan_ has quit IRC
4722018-10-16T21:16:59 *** jarthur has joined #bitcoin-core-dev
4732018-10-16T21:18:03 *** bitconner has quit IRC
4742018-10-16T21:18:19 *** bitcoin-git has joined #bitcoin-core-dev
4752018-10-16T21:18:19 <bitcoin-git> [bitcoin] hebasto opened pull request #14497: docs: Add `doc/bitcoin-conf.md` (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497
4762018-10-16T21:18:19 *** bitcoin-git has left #bitcoin-core-dev
4772018-10-16T21:32:56 *** proletesseract has quit IRC
4782018-10-16T21:37:15 <meshcollider> hebasto: I mentioned that idea above briefly, we can't just stop ignoring comments in-line, because many people's conf files may already use inline comments
4792018-10-16T21:37:25 <meshcollider> So suddenly they would all stop being ignored
4802018-10-16T21:37:37 *** Murch has joined #bitcoin-core-dev
4812018-10-16T21:41:07 *** intcat has quit IRC
4822018-10-16T21:41:11 <meshcollider> Jmabsd: https://github.com/bitcoin/bitcoin/tree/master/src/script/standard.cpp#L24
4832018-10-16T21:45:58 *** intcat has joined #bitcoin-core-dev
4842018-10-16T21:47:59 *** promag has joined #bitcoin-core-dev
4852018-10-16T21:49:44 <achow101> what if we instead just removed rpcuser and rpcpassword? they'be been deprecated for ages
4862018-10-16T21:52:39 <sipa> ha.
4872018-10-16T21:52:39 <hebasto> meshcollider: to change config file is not the same as to change code :)
4882018-10-16T21:53:47 <sipa> hebasto: well we can't just break compatibility with existing config files (within reason)
4892018-10-16T21:54:06 <esotericnonsense> surely # in rpcpassword is broken regardless. wtf.
4902018-10-16T21:54:37 * esotericnonsense has now made himself aware that you can have a hash in file names. great
4912018-10-16T21:54:44 <sipa> ha
4922018-10-16T21:55:29 <esotericnonsense> stat #: missing operand (of course)
4932018-10-16T21:55:32 <esotericnonsense> stat "#": it works
4942018-10-16T21:55:46 <sipa> stat \#
4952018-10-16T21:56:03 <promag> hebasto: what sipa said
4962018-10-16T21:56:14 <hebasto> agree
4972018-10-16T22:05:02 *** bergz has quit IRC
4982018-10-16T22:09:24 *** profmac has quit IRC
4992018-10-16T22:10:06 *** hebasto has quit IRC
5002018-10-16T22:12:52 *** Krellan has quit IRC
5012018-10-16T22:13:24 *** Krellan_ has joined #bitcoin-core-dev
5022018-10-16T22:14:21 *** shesek has joined #bitcoin-core-dev
5032018-10-16T22:14:21 *** shesek has joined #bitcoin-core-dev
5042018-10-16T22:16:27 *** spinza has quit IRC
5052018-10-16T22:17:29 *** bitcoin-git has joined #bitcoin-core-dev
5062018-10-16T22:17:29 <bitcoin-git> [bitcoin] mrwhythat opened pull request #14498: rpcwallet: listsentbyaddress RPC (master...listsentbyaddress-rpc) https://github.com/bitcoin/bitcoin/pull/14498
5072018-10-16T22:17:29 *** bitcoin-git has left #bitcoin-core-dev
5082018-10-16T22:19:04 *** jarthur has quit IRC
5092018-10-16T22:21:45 *** profmac has joined #bitcoin-core-dev
5102018-10-16T22:23:02 *** bitconner has joined #bitcoin-core-dev
5112018-10-16T22:26:25 *** spinza has joined #bitcoin-core-dev
5122018-10-16T22:26:33 *** justanotheruser has joined #bitcoin-core-dev
5132018-10-16T22:27:33 *** Guyver2 has quit IRC
5142018-10-16T22:32:26 *** ExtraCrispy_ has quit IRC
5152018-10-16T22:37:21 *** michaelsdunn1 has quit IRC
5162018-10-16T22:40:17 *** bergz has joined #bitcoin-core-dev
5172018-10-16T22:45:03 *** promag has quit IRC
5182018-10-16T22:47:50 *** OzPac has joined #bitcoin-core-dev
5192018-10-16T23:13:54 <gmaxwell> oh come on, getblockstats run with no special aguments either works or doesn't work without txindex enabled, based on what block you call it on.
5202018-10-16T23:14:02 *** leishman has quit IRC
5212018-10-16T23:14:34 *** leishman has joined #bitcoin-core-dev
5222018-10-16T23:20:31 *** jarthur has joined #bitcoin-core-dev
5232018-10-16T23:21:47 *** bralyclow2 has joined #bitcoin-core-dev
5242018-10-16T23:23:17 *** bralyclow2 has quit IRC
5252018-10-16T23:23:32 <echeveria> achow101: they kind of need to go away
5262018-10-16T23:23:45 <echeveria> achow101: there's fucking like, 3000+ open RPC ports on IPv4.
5272018-10-16T23:23:49 *** bralyclow2 has joined #bitcoin-core-dev
5282018-10-16T23:24:08 <echeveria> achow101: assclowns like Samurai Wallet are telling people to bind RPC to 0.0.0.0.
5292018-10-16T23:24:36 *** bralyclow3 has joined #bitcoin-core-dev
5302018-10-16T23:26:46 <gmaxwell> echeveria: what?!
5312018-10-16T23:27:08 <gmaxwell> why?
5322018-10-16T23:27:38 <echeveria> gmaxwell: connect your wallet to your own node, using RPC! or something. I don't know much about it other than reading some people trying to do it in #bitcoin.
5332018-10-16T23:28:13 * luke-jr facepalms
5342018-10-16T23:28:39 *** bralyclow2 has quit IRC
5352018-10-16T23:29:08 <echeveria> https://support.samourai.io/article/39-enable-trusted-node-in-your-wallet
5362018-10-16T23:29:40 <echeveria> clowns.
5372018-10-16T23:29:59 <gmaxwell> actually they tell you to VPN, no rpc bind it seems?
5382018-10-16T23:30:28 <gmaxwell> what does this feature do?
5392018-10-16T23:30:41 *** bralyclow3 has quit IRC
5402018-10-16T23:30:48 <luke-jr> they also tell you to rpcallowip your LAN (or VPN) only
5412018-10-16T23:30:58 <luke-jr> but I guess that may bind 0.0.0.0 :/
5422018-10-16T23:31:14 <gmaxwell> why are they not just using p2p?
5432018-10-16T23:31:24 *** OzPac has quit IRC
5442018-10-16T23:31:56 <gmaxwell> "Use your personal node to broadcast transactions to the bitcoin network"
5452018-10-16T23:32:07 <gmaxwell> thats what it claims it does
5462018-10-16T23:32:35 <luke-jr> wtf, that's not even particularly useful
5472018-10-16T23:32:36 <echeveria> from the description I doubt it uses it as a data source.
5482018-10-16T23:33:03 <echeveria> this is the company that lied in their original software release and claimed to be decentralized, while using blockchain.info in their closed source release.
5492018-10-16T23:33:12 <gmaxwell> I know previously it used bc.i as its data source. I don't see how it would use your local node as a data source.
5502018-10-16T23:33:25 *** bergz has quit IRC
5512018-10-16T23:33:59 <gmaxwell> "We build the software that Bitcoin deserves" ... just so.
5522018-10-16T23:38:45 <echeveria> all of their "privacy" tools are snake oil, to boot. it's unfortunate that they're impacting bitcoin node users as well as people fooled into using their incompetent software.
5532018-10-16T23:39:04 <achow101> echeveria: removing rpcuser and rpcpassword wouldn't change that though
5542018-10-16T23:39:12 <achow101> you can still set rpcauth
5552018-10-16T23:39:27 <achow101> (albeit harder to do)
5562018-10-16T23:39:50 <echeveria> achow101: it ends up being an automatically generated token, doesn't it?
5572018-10-16T23:40:09 <gmaxwell> echeveria: no thats cookie auth.
5582018-10-16T23:40:11 <achow101> echeveria: no, that's only the cookie auth stuff. that token goes into the .cookie file
5592018-10-16T23:40:26 <achow101> rpcauth is like rpcuser and rpcpassword except as one config option and the password is hashed
5602018-10-16T23:40:38 <echeveria> oh, I thought they were the same thing.
5612018-10-16T23:41:04 <echeveria> guess that doesn't implicitly solve any issue like I thought.
5622018-10-16T23:41:36 <achow101> i mean it's harder for people to figure out how to hash their password to use rpcauth
5632018-10-16T23:41:50 <gmaxwell> cookie auth is a replacement for things that read passwords out of the conf file, rpcauth is the replacement for things that have a persistant key left in another app.
5642018-10-16T23:42:46 <echeveria> yep, understood, I just bundled them together in my head. it sort of surprised my awfully to realise that so many RPC ports were open in public IPv4 scans. I'm not sure there's a resolution to that, it's already something that's non-trivial to do.
5652018-10-16T23:43:15 <gmaxwell> I hope that many of them are honeypots, etc.
5662018-10-16T23:43:15 <echeveria> unless the RPC bind option is changed to IM_AN_IDIOT=0.0.0. or something, which I can understand why nobody would want to do that.
5672018-10-16T23:43:43 <echeveria> hopefully.
5682018-10-16T23:44:14 <meshcollider> sipa: how about checking the flatsigningprovider only added a single pubkey for each descriptor, and import it if it did
5692018-10-16T23:44:14 <gmaxwell> just change the string to a new random 256 bit hex value in each release. :P
5702018-10-16T23:44:18 <meshcollider> Would that work?
5712018-10-16T23:45:21 <echeveria> gmaxwell: see I'd say remove the ability to bind anything but localhost, but I know that would mean people would refuse to upgrade for compatibility reasons.
5722018-10-16T23:45:36 <sipa> meshcollider: i have a bit of another strategy in mind
5732018-10-16T23:45:36 <achow101> or remove rpcbind and make people figure out iptables/firewall crap to get it accessible from the outside world
5742018-10-16T23:45:56 <sipa> meshcollider: let's focus on making importmulti work first for all supported things, and ignore descriptors
5752018-10-16T23:46:09 <sipa> meshcollider: i think the code can be massively simplified (but let's do that after merging your PR)
5762018-10-16T23:46:13 <gmaxwell> echeveria: it's not unreasonable to bind to a private lan, for example. just security wise fragile.
5772018-10-16T23:46:16 <meshcollider> sipa: Alright, sounds good
5782018-10-16T23:46:25 <sipa> and after simplification, it can share a lot of logic with the descriptor approach
5792018-10-16T23:46:45 <gmaxwell> echeveria: maybe {stop} should work without authentication. :P
5802018-10-16T23:47:02 <meshcollider> sipa: does this include change to the wallet or just the RPC code
5812018-10-16T23:47:14 <sipa> meshcollider: just the scope of your current PRs
5822018-10-16T23:47:16 <gmaxwell> echeveria: oh there you go, auto stop after 1000 invalid auth attempts. :P
5832018-10-16T23:47:29 <echeveria> yuck.
5842018-10-16T23:47:39 <sipa> echeveria: wumpus had some unix socket binding RPC stuff earlier, not sure what the state is
5852018-10-16T23:48:03 <sipa> perhaps that can be made default the only open thing, and you need a separate tool to proxy it to TCP/IP
5862018-10-16T23:48:08 <sipa> ... at some point
5872018-10-16T23:48:12 <gmaxwell> sipa: it was held up because the client side support needed upstream improvements in libevent. :(
5882018-10-16T23:48:17 <sipa> gmaxwell: right
5892018-10-16T23:48:29 <echeveria> sipa: I think that results in people using obsolete versions sadly.
5902018-10-16T23:48:43 <sipa> echeveria: quite possibly
5912018-10-16T23:48:58 <echeveria> that's what happened with BitPay's Insight. they stopped maintaining it so everybody who built around it is still running 0.12, as far as I can tell not behind guard nodes.
5922018-10-16T23:48:59 <gmaxwell> I do think that making it harder to make rpc remotely accessible might be a reasonable move, esp post domain socket support. (not that they're really related)
5932018-10-16T23:49:03 <jarthur> sipa gmaxwell do you remember why we needed to re-use a socket object in libevent? Is it because we wanted the unix socket file managed by Core instead of libevent?
5942018-10-16T23:49:12 *** bitcoin-git has joined #bitcoin-core-dev
5952018-10-16T23:49:13 <bitcoin-git> [bitcoin] MeshCollider closed pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
5962018-10-16T23:49:13 *** bitcoin-git has left #bitcoin-core-dev
5972018-10-16T23:49:16 <sipa> jarthur: no clue about the details
5982018-10-16T23:49:35 <gmaxwell> echeveria: disabling it would do that, but requiring an insecure_nonlocal_binding=1
5992018-10-16T23:49:46 <echeveria> yep.
6002018-10-16T23:50:08 <gmaxwell> jarthur: should be in wumpus' issue in the libevent repo.
6012018-10-16T23:50:27 <jarthur> sipa: alright. I think that's what wumpus' upstream PR was all about. I think we can do it in libevent today if we have libevent opening the socket in the first place.
6022018-10-16T23:51:37 <jarthur> Why is this remote RPC stuff coming up? IMO, it's already hard to expose an RPC port on anything but the loopback.
6032018-10-16T23:51:59 <echeveria> jarthur: I noticed that there's a large number of RPC sockets open.
6042018-10-16T23:52:38 *** Murch has quit IRC
6052018-10-16T23:52:48 <jarthur> echeveria: ah, when using Samurai? Or just listening sockets on a clean Core run?
6062018-10-16T23:52:52 <gmaxwell> jarthur: wumpus' major motiviation behind working on domain sockets was getting bitcoind to run in a very restrictive sandbox.
6072018-10-16T23:53:30 <gmaxwell> samurai is just one of many potential causes for the large number of rpc exposes hosts.
6082018-10-16T23:54:02 <echeveria> jarthur: just in general, many IPv4 that have 8333 open also have 8332 open. there's various tools like shodan that present this information in an easy to consume way. samourai was just one theory of mine as to why people might be doing it, as they do suggest exposing your RPC port in some way, for a very stupid reason.
6092018-10-16T23:54:04 <gmaxwell> (and a kind of absurd one, since it looks like they have the user open up the RPC to remote hosts just to sendrawtransaction)
6102018-10-16T23:54:55 <achow101> even with rpcbind=0.0.0.0, you still need to be whitelisted in rpcallowip to connect though
6112018-10-16T23:55:12 <achow101> unless people also did rpcallowip=0.0.0.0
6122018-10-16T23:56:08 <jarthur> echeveria: alright. There's also electrumx, electrum-server, electrum-personal-server, electrs, getwork proxy, stratum mining proxies, stratum mining pools. A whole lot of RPC uses out there.
6132018-10-16T23:56:29 <gmaxwell> none of those things should be exposing the bitcoind rpc to the wide internet.
6142018-10-16T23:56:31 <echeveria> jarthur: none of what you've described need a world listening RPC port.
6152018-10-16T23:56:54 <jarthur> Yea, not justifying the open port, just why people end up opening those ports in the first place.
6162018-10-16T23:57:39 <gmaxwell> achow101: perhaps we should require "massively_increased_security_vulnerablity_exposure=1" for any rpcallowip statement wider than /8. :P
6172018-10-16T23:57:41 *** Murch has joined #bitcoin-core-dev
6182018-10-16T23:57:56 <jarthur> I sometimes load up an EC2 Core server, open up RPC to the net and use Amazon Security group to only let myself have access. I got no shame in it :)
6192018-10-16T23:58:02 <echeveria> jarthur: huh? it needs extra effort to make it bind to 0.0.0.0, which you don't need for nay of the services you talk about.
6202018-10-16T23:58:23 <echeveria> jarthur: you're a bad sysadmin. you have SSH, forward the port locally.
6212018-10-16T23:59:19 <gmaxwell> jarthur: the fact that its possible to 0/0 safely (although fragile) is why its possible at all.
6222018-10-16T23:59:41 <jarthur> echeveria: yea, that's certainly better. Have done that too when less lazy.