12018-10-19T00:02:17 <gmaxwell> gwillen: there are a lot of reasons things can be slow.
22018-10-19T00:02:55 <gwillen> yeah, but I know I have a decent CPU, and I know how to check if my own connection is working
32018-10-19T00:03:31 <gmaxwell> including, for example, that when blocks arrive out of order, they'll all processed at once while not emptying the buffers on connections, which are only 5MB in size.
42018-10-19T00:03:36 *** str4d has quit IRC
52018-10-19T00:04:23 <gmaxwell> so when a peer or two is slow and pauses validation, once the missing blocks show up, you'll connect up to 1000 blocks at once, and all your transfers stall out.
62018-10-19T00:04:31 <gwillen> oof, *nod*
72018-10-19T00:05:14 <gmaxwell> and even on a fast computer, 1 second per block to validate during sync isn't too unrealistic.
82018-10-19T00:11:00 *** bralyclow has joined #bitcoin-core-dev
92018-10-19T00:12:41 *** bralycl__ has joined #bitcoin-core-dev
102018-10-19T00:13:18 *** bralyclo_ has quit IRC
112018-10-19T00:16:02 <phantomcircuit> gmaxwell, hmm that seems kind of broken
122018-10-19T00:16:19 *** bralyclow has quit IRC
132018-10-19T00:16:56 <phantomcircuit> how difficult would it be to process one block at a time instead? what kind of negative performance could that cause
142018-10-19T00:17:32 <gmaxwell> the reason it processes all at once is more about not ending up in a weird place during a reorg, rather than anything performance related.
152018-10-19T00:20:22 <sipa> phantomcircuit: we should just reduce the size of the download window later in the chain
162018-10-19T00:20:46 <sipa> it actually releases cs_main briefly in between each block
172018-10-19T00:22:30 <luke-jr> or finally get on with a block weight limit decrease <.<
182018-10-19T00:23:53 *** Bullit has joined #bitcoin-core-dev
192018-10-19T00:25:27 <gmaxwell> sipa: it releases cs_main, but doesn't exit the message handling loop and go empty the queues for the other peers.
202018-10-19T00:25:58 *** jimmysong has quit IRC
212018-10-19T00:26:18 <gmaxwell> it's really easy to see the effect... bandwidth usage continually drops to zero while syncing.
222018-10-19T00:27:19 <sipa> gmaxwell: yup
232018-10-19T00:27:34 <sipa> the solution to that is doing blocm validation in the background...
242018-10-19T00:28:06 <gmaxwell> or just exit the message handling loop after processing a couple blocks... so that it can go drain the queues for the other peers.
252018-10-19T00:28:56 <sipa> fair; but we'd need to make sure to not process any further messages from the peer until all blocks are processed
262018-10-19T00:29:52 <sipa> but that doesn't sound too hard actually
272018-10-19T00:30:02 *** rh0nj has quit IRC
282018-10-19T00:31:13 *** rh0nj has joined #bitcoin-core-dev
292018-10-19T00:37:03 <gmaxwell> Some people, when confronted with a problem, think "I know, I'll use concurrency." Now they have tproblemsow.
302018-10-19T00:39:01 *** Aaronvan_ has joined #bitcoin-core-dev
312018-10-19T00:41:46 *** AaronvanW has quit IRC
322018-10-19T00:41:47 <sipa> Some people, when confronted with a problem, think "I know, I'll use floating point." Now they have 1.9999997 problems.
332018-10-19T00:45:50 *** michaelsdunn1 has joined #bitcoin-core-dev
342018-10-19T00:46:37 <andytoshi> in fairness, i can read "tproblemsow" twice as fast as i could read two words
352018-10-19T00:46:40 * andytoshi ducks
362018-10-19T00:52:19 <phantomcircuit> gmaxwell, hmm i guess with a reorg we rewind and then walk all the way to the new tip
372018-10-19T00:52:35 <phantomcircuit> could rewind to the split and then do normal sync again with the new headers
382018-10-19T00:54:01 <phantomcircuit> i assume rewinding is reasonably fast?
392018-10-19T00:54:03 <phantomcircuit> or no
402018-10-19T00:54:34 <gmaxwell> rewinding is slow
412018-10-19T00:54:39 <sipa> phantomcircuit: we release cs_main whenever we're in a state that's better than the previous state
422018-10-19T00:55:01 <sipa> or when we're back in a previous state and there is no valid better chain available
432018-10-19T01:01:59 <gmaxwell> it should just do enough work to get to a better position then it last was and stop.
442018-10-19T01:02:15 <gmaxwell> so a reorg would still block things for a while but otherwise it won't slow down progress generally.
452018-10-19T01:06:43 *** ken2812221 has quit IRC
462018-10-19T01:09:42 *** jb55 has quit IRC
472018-10-19T01:15:21 *** jpe__ has joined #bitcoin-core-dev
482018-10-19T01:16:17 <phantomcircuit> sipa, it would be nice if there was something like "step and tell me if you did something"
492018-10-19T01:16:23 <phantomcircuit> then run that in the background
502018-10-19T01:17:06 <sipa> gmaxwell: seems reasonable... but how do you make sure to continue processing blocks when no peer is giving you anything?
512018-10-19T01:17:14 <sipa> whenever the processing timeout fires?
522018-10-19T01:18:21 *** jpe_ has quit IRC
532018-10-19T01:20:11 *** michaelsdunn1 has quit IRC
542018-10-19T01:22:59 <phantomcircuit> sipa, background thread
552018-10-19T01:24:00 <sipa> phantomcircuit: i'm trying to get gmaxwell to see that may be useful :p
562018-10-19T01:37:25 *** sipa has quit IRC
572018-10-19T01:38:30 *** sipa has joined #bitcoin-core-dev
582018-10-19T01:59:25 *** Aaronvan_ has quit IRC
592018-10-19T02:05:21 *** lukedashjr has joined #bitcoin-core-dev
602018-10-19T02:05:51 *** clarkmoody has joined #bitcoin-core-dev
612018-10-19T02:06:59 *** lukedashjr has quit IRC
622018-10-19T02:07:10 *** lukedashjr has joined #bitcoin-core-dev
632018-10-19T02:07:16 *** clarkmoody has quit IRC
642018-10-19T02:09:21 *** luke-jr has quit IRC
652018-10-19T02:09:59 *** AaronvanW has joined #bitcoin-core-dev
662018-10-19T02:11:52 *** lukedashjr is now known as luke-jr
672018-10-19T02:14:56 *** AaronvanW has quit IRC
682018-10-19T02:15:45 *** Krellan has quit IRC
692018-10-19T02:26:01 *** Murch has quit IRC
702018-10-19T02:29:39 *** morcos has quit IRC
712018-10-19T02:33:05 *** morcos has joined #bitcoin-core-dev
722018-10-19T02:56:43 *** lnostdal has joined #bitcoin-core-dev
732018-10-19T02:57:28 *** justanotheruser has joined #bitcoin-core-dev
742018-10-19T03:03:00 *** bralyclow2 has joined #bitcoin-core-dev
752018-10-19T03:04:54 *** lnostdal has quit IRC
762018-10-19T03:05:04 *** bralyclow2 has quit IRC
772018-10-19T03:05:52 *** justanotheruser has quit IRC
782018-10-19T03:14:56 *** satashi has joined #bitcoin-core-dev
792018-10-19T03:20:31 *** lnostdal has joined #bitcoin-core-dev
802018-10-19T03:20:59 *** satashi has quit IRC
812018-10-19T03:22:48 *** justanotheruser has joined #bitcoin-core-dev
822018-10-19T03:39:40 *** bitconner has quit IRC
832018-10-19T03:40:53 *** lnostdal has quit IRC
842018-10-19T03:46:04 *** tknp has quit IRC
852018-10-19T03:56:34 *** lnostdal has joined #bitcoin-core-dev
862018-10-19T03:57:01 *** schnerchi has joined #bitcoin-core-dev
872018-10-19T03:59:37 *** schnerch_ has quit IRC
882018-10-19T04:24:38 *** harrymm has quit IRC
892018-10-19T04:27:25 *** bitcoin-git has joined #bitcoin-core-dev
902018-10-19T04:27:25 <bitcoin-git> [bitcoin] fanquake opened pull request #14515: doc: Update OpenBSD build guide for 6.4 (master...openbsd-6-4) https://github.com/bitcoin/bitcoin/pull/14515
912018-10-19T04:27:25 *** bitcoin-git has left #bitcoin-core-dev
922018-10-19T04:27:57 *** bitcoin-git has joined #bitcoin-core-dev
932018-10-19T04:27:57 <bitcoin-git> [bitcoin] fanquake closed pull request #14314: Trivial: gitignore contents of db4 folder (master...master) https://github.com/bitcoin/bitcoin/pull/14314
942018-10-19T04:27:57 *** bitcoin-git has left #bitcoin-core-dev
952018-10-19T04:28:21 *** dviola has joined #bitcoin-core-dev
962018-10-19T04:41:54 *** harrymm has joined #bitcoin-core-dev
972018-10-19T04:52:40 *** AaronvanW has joined #bitcoin-core-dev
982018-10-19T04:55:16 *** jarthur has joined #bitcoin-core-dev
992018-10-19T04:58:21 *** AaronvanW has quit IRC
1002018-10-19T05:06:43 *** dviola has quit IRC
1012018-10-19T05:07:50 *** diego2 has joined #bitcoin-core-dev
1022018-10-19T05:10:52 *** gwillen has quit IRC
1032018-10-19T05:11:48 *** gwillen has joined #bitcoin-core-dev
1042018-10-19T05:12:03 *** tryphe has quit IRC
1052018-10-19T05:12:28 *** tryphe has joined #bitcoin-core-dev
1062018-10-19T05:14:45 *** diego2 has quit IRC
1072018-10-19T05:21:32 *** hebasto has joined #bitcoin-core-dev
1082018-10-19T05:49:13 *** Emcy_ has joined #bitcoin-core-dev
1092018-10-19T05:49:26 *** Emcy_ has quit IRC
1102018-10-19T05:53:17 *** bitcoin-git has joined #bitcoin-core-dev
1112018-10-19T05:53:18 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8eb2cd1ddaab...d387507aeca6
1122018-10-19T05:53:18 <bitcoin-git> bitcoin/master ca6d86c Chun Kuan Lee: tests: Stop node before removing the notification file
1132018-10-19T05:53:19 <bitcoin-git> bitcoin/master d387507 Pieter Wuille: Merge #14465: tests: Stop node before removing the notification file...
1142018-10-19T05:53:19 *** bitcoin-git has left #bitcoin-core-dev
1152018-10-19T05:54:27 *** bitcoin-git has joined #bitcoin-core-dev
1162018-10-19T05:54:27 <bitcoin-git> [bitcoin] sipa closed pull request #14465: tests: Stop node before removing the notification file (master...test-notification-fix) https://github.com/bitcoin/bitcoin/pull/14465
1172018-10-19T05:54:27 *** bitcoin-git has left #bitcoin-core-dev
1182018-10-19T06:08:01 *** rh0nj has quit IRC
1192018-10-19T06:09:08 *** rh0nj has joined #bitcoin-core-dev
1202018-10-19T06:18:11 *** justanotheruser has quit IRC
1212018-10-19T06:32:17 *** jarthur has quit IRC
1222018-10-19T06:41:08 *** AaronvanW has joined #bitcoin-core-dev
1232018-10-19T06:49:55 *** promag has joined #bitcoin-core-dev
1242018-10-19T06:51:14 *** AaronvanW has quit IRC
1252018-10-19T06:51:17 *** promag has quit IRC
1262018-10-19T06:58:47 *** drexl has quit IRC
1272018-10-19T07:02:51 *** setpill has joined #bitcoin-core-dev
1282018-10-19T07:06:49 *** jungly has joined #bitcoin-core-dev
1292018-10-19T07:19:16 <jonasschnelli> sipa, gmaxwell: ping for final review #14046 (to close/finailize your earlier review)
1302018-10-19T07:19:19 <gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub
1312018-10-19T07:24:01 *** intcat has quit IRC
1322018-10-19T07:26:04 *** intcat has joined #bitcoin-core-dev
1332018-10-19T07:53:14 *** bitcoin-git has joined #bitcoin-core-dev
1342018-10-19T07:53:15 <bitcoin-git> [bitcoin] hebasto opened pull request #14517: qt: Fix start with the `-min` option (master...20181019-start-minimized-to-tray) https://github.com/bitcoin/bitcoin/pull/14517
1352018-10-19T07:53:15 *** bitcoin-git has left #bitcoin-core-dev
1362018-10-19T08:07:20 *** lnostdal_ has joined #bitcoin-core-dev
1372018-10-19T08:07:25 *** lnostdal has quit IRC
1382018-10-19T08:12:19 *** lnostdal_ has quit IRC
1392018-10-19T08:12:43 *** lnostdal_ has joined #bitcoin-core-dev
1402018-10-19T08:17:09 <hebasto> meshcollider: gmaxwell: wumpus: MarcoFalke: ryanofsky: #14514 is it worth?
1412018-10-19T08:17:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14514 | Version number for `bitcoin.conf` · Issue #14514 · bitcoin/bitcoin · GitHub
1422018-10-19T08:20:03 *** lnostdal_ has quit IRC
1432018-10-19T08:29:42 *** promag has joined #bitcoin-core-dev
1442018-10-19T08:29:43 *** promag has quit IRC
1452018-10-19T08:29:56 *** promag has joined #bitcoin-core-dev
1462018-10-19T08:36:19 *** harrymm has quit IRC
1472018-10-19T08:47:06 *** AaronvanW has joined #bitcoin-core-dev
1482018-10-19T08:47:22 *** Zenton has joined #bitcoin-core-dev
1492018-10-19T08:49:36 *** harrymm has joined #bitcoin-core-dev
1502018-10-19T08:51:36 *** AaronvanW has quit IRC
1512018-10-19T09:01:50 *** Guyver2 has joined #bitcoin-core-dev
1522018-10-19T09:38:02 *** rh0nj has quit IRC
1532018-10-19T09:39:09 *** rh0nj has joined #bitcoin-core-dev
1542018-10-19T09:40:01 *** rh0nj has quit IRC
1552018-10-19T09:41:08 *** rh0nj has joined #bitcoin-core-dev
1562018-10-19T09:42:02 *** rh0nj has quit IRC
1572018-10-19T09:43:09 *** rh0nj has joined #bitcoin-core-dev
1582018-10-19T09:46:33 *** bitconner has joined #bitcoin-core-dev
1592018-10-19T09:51:27 *** bitconner has quit IRC
1602018-10-19T10:08:57 *** AaronvanW has joined #bitcoin-core-dev
1612018-10-19T10:25:34 <meshcollider> hebasto: in my opinion not really :)
1622018-10-19T10:26:51 *** schmidty has joined #bitcoin-core-dev
1632018-10-19T10:27:15 *** schmidty is now known as Guest20006
1642018-10-19T10:38:58 *** Victorsueca has quit IRC
1652018-10-19T10:38:58 *** grubles has quit IRC
1662018-10-19T10:39:26 *** grubles has joined #bitcoin-core-dev
1672018-10-19T10:40:12 *** Victorsueca has joined #bitcoin-core-dev
1682018-10-19T10:44:10 *** morcos has quit IRC
1692018-10-19T10:44:23 *** morcos has joined #bitcoin-core-dev
1702018-10-19T10:54:51 <wumpus> ooh time to upgrade OpenBSD
1712018-10-19T11:06:41 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1722018-10-19T11:07:00 *** timothy has quit IRC
1732018-10-19T11:15:25 *** infernix has quit IRC
1742018-10-19T11:20:48 *** promag has quit IRC
1752018-10-19T11:27:36 *** infernix has joined #bitcoin-core-dev
1762018-10-19T11:46:47 *** bitconner has joined #bitcoin-core-dev
1772018-10-19T11:49:56 *** AaronvanW has quit IRC
1782018-10-19T11:51:15 *** bitconner has quit IRC
1792018-10-19T11:52:05 *** Cheeseo has joined #bitcoin-core-dev
1802018-10-19T12:14:03 <meshcollider> sipa: still trying to figure out why the P2WSH address is not IsMine, I've confirmed both private keys and the witness script were imported into the wallet successfully, and it works for P2SH-P2WSH, so I'm very confused
1812018-10-19T12:15:59 *** timothy has joined #bitcoin-core-dev
1822018-10-19T12:16:01 *** AaronvanW has joined #bitcoin-core-dev
1832018-10-19T12:17:05 <meshcollider> Its solvable, and both private keys are there, so what more does it need :(
1842018-10-19T12:17:38 <meshcollider> I'm either missing something really dumb, or there's a bug in the IsMine logic
1852018-10-19T12:21:49 *** drexl has joined #bitcoin-core-dev
1862018-10-19T12:22:49 <meshcollider> actually I think I know the issue, let me test something
1872018-10-19T12:24:08 *** RoyceX has joined #bitcoin-core-dev
1882018-10-19T12:27:56 *** Cheeseo has quit IRC
1892018-10-19T12:34:24 <meshcollider> sipa: yes, the scriptPubKey also needs to be added to the wallet scripts as well for it to be IsMine, not just the witnessScript so it works now
1902018-10-19T12:39:14 *** Aaronvan_ has joined #bitcoin-core-dev
1912018-10-19T12:40:28 *** SopaXorzTaker has joined #bitcoin-core-dev
1922018-10-19T12:42:36 *** AaronvanW has quit IRC
1932018-10-19T12:51:14 *** Emcy has quit IRC
1942018-10-19T13:06:53 *** intcat has quit IRC
1952018-10-19T13:08:16 *** setpill has quit IRC
1962018-10-19T13:08:53 *** intcat has joined #bitcoin-core-dev
1972018-10-19T13:13:45 *** Chris_Stewart_5 has quit IRC
1982018-10-19T13:17:35 *** RoyceX has quit IRC
1992018-10-19T13:24:40 <harding> Re: possibly removing the GUI addressbook, I just wanted to note that I use that with my cold wallet setup so that I can import a handful of watch-only pubkeys at a time using the RPC (labeling them as, e.g., "cold-2019-10-19") and then use the GUI addressbook to hand them out as necessary over the next few weeks (relabeling them as I use them to both track payments and prevent address reuse). I could probably do the same thing
2002018-10-19T13:24:41 <harding> just as easily using a text file, so I wouldn't mourn the loss of the addressbook, but it is something that's currently a part of what I think is a reasonable workflow. The Receive tab doesn't currently show imported stuff until you receive payment to it.
2012018-10-19T13:25:14 *** promag has joined #bitcoin-core-dev
2022018-10-19T13:25:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2032018-10-19T13:27:45 <wumpus> harding: I think that's a reasonable workflow, too
2042018-10-19T13:29:30 <wumpus> gah openbsd 6.4 upgrade failed here, some error at startup of the kernel, might have to do with the specific qemu config
2052018-10-19T13:35:16 *** Emcy has joined #bitcoin-core-dev
2062018-10-19T13:40:27 *** Aaronvan_ has quit IRC
2072018-10-19T14:02:23 *** SigmaOC has joined #bitcoin-core-dev
2082018-10-19T14:02:28 <SigmaOC> REPLY isn't just a zsh thing. Works in any shell; it's just the convention (dunno where it started).
2092018-10-19T14:02:38 <SigmaOC> PuppyNews_, I'm afraid no one from wikipedia can hear you right now, this channel is moderated (+m)
2102018-10-19T14:02:46 <SigmaOC> unyu: what are dynamicsl systems?
2112018-10-19T14:02:52 <SigmaOC> better ask ur question.
2122018-10-19T14:06:21 *** SigmaOC has quit IRC
2132018-10-19T14:06:23 *** soahccc has joined #bitcoin-core-dev
2142018-10-19T14:06:31 <soahccc> actually lets call it a_i
2152018-10-19T14:06:37 <soahccc> han-solo: etc... ( http://ix.io/1mtz )
2162018-10-19T14:06:43 <soahccc> malloc/realloc/free is just a mistake while dealing with C++ code
2172018-10-19T14:09:18 *** AaronvanW has joined #bitcoin-core-dev
2182018-10-19T14:12:59 *** soahccc has quit IRC
2192018-10-19T14:15:02 *** kexkey has joined #bitcoin-core-dev
2202018-10-19T14:21:28 *** madeng has joined #bitcoin-core-dev
2212018-10-19T14:24:00 *** madeng has quit IRC
2222018-10-19T14:27:02 *** rh0nj has quit IRC
2232018-10-19T14:28:07 *** rh0nj has joined #bitcoin-core-dev
2242018-10-19T14:30:56 *** AaronvanW has quit IRC
2252018-10-19T14:31:56 *** bitcoin-git has joined #bitcoin-core-dev
2262018-10-19T14:31:56 <bitcoin-git> [bitcoin] promag opened pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518
2272018-10-19T14:31:56 *** bitcoin-git has left #bitcoin-core-dev
2282018-10-19T14:32:08 <promag> gmaxwell: ^
2292018-10-19T14:34:53 *** bitcoin-git has joined #bitcoin-core-dev
2302018-10-19T14:34:54 <bitcoin-git> [bitcoin] practicalswift closed pull request #14254: build: Add address sanitizer (ASan) Travis job (master...asan) https://github.com/bitcoin/bitcoin/pull/14254
2312018-10-19T14:34:54 *** bitcoin-git has left #bitcoin-core-dev
2322018-10-19T14:35:23 *** bitcoin-git has joined #bitcoin-core-dev
2332018-10-19T14:35:23 <bitcoin-git> [bitcoin] practicalswift closed pull request #14010: tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization (master...SelectParams-when-fuzzing) https://github.com/bitcoin/bitcoin/pull/14010
2342018-10-19T14:35:23 *** bitcoin-git has left #bitcoin-core-dev
2352018-10-19T14:35:56 *** bitcoin-git has joined #bitcoin-core-dev
2362018-10-19T14:35:56 <bitcoin-git> [bitcoin] practicalswift closed pull request #13971: Add tests and error handling to DecodeExtPubKey/DecodeExtKey. Add [[nodiscard]]. (master...DecodeExtKey) https://github.com/bitcoin/bitcoin/pull/13971
2372018-10-19T14:35:56 *** bitcoin-git has left #bitcoin-core-dev
2382018-10-19T14:36:36 *** bitcoin-git has joined #bitcoin-core-dev
2392018-10-19T14:36:36 <bitcoin-git> [bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969
2402018-10-19T14:36:36 *** bitcoin-git has left #bitcoin-core-dev
2412018-10-19T14:37:21 *** bitcoin-git has joined #bitcoin-core-dev
2422018-10-19T14:37:21 <bitcoin-git> [bitcoin] practicalswift closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909
2432018-10-19T14:37:21 *** bitcoin-git has left #bitcoin-core-dev
2442018-10-19T14:38:48 *** rafalcpp has quit IRC
2452018-10-19T14:39:41 *** queip has quit IRC
2462018-10-19T14:45:33 *** michaelsdunn1 has joined #bitcoin-core-dev
2472018-10-19T14:45:35 *** michaelsdunn1 has quit IRC
2482018-10-19T14:45:35 *** michaelsdunn1 has joined #bitcoin-core-dev
2492018-10-19T14:52:13 *** copumpkin has joined #bitcoin-core-dev
2502018-10-19T14:53:13 *** bitcoin-git has joined #bitcoin-core-dev
2512018-10-19T14:53:14 <bitcoin-git> [bitcoin] practicalswift closed pull request #14475: serialize: Document integer width assumptions we are making when calculating compact sizes (master...integer-width-assumptions) https://github.com/bitcoin/bitcoin/pull/14475
2522018-10-19T14:53:14 *** bitcoin-git has left #bitcoin-core-dev
2532018-10-19T14:57:20 *** SopaXorzTaker has quit IRC
2542018-10-19T15:17:27 *** ExtraCrispy has joined #bitcoin-core-dev
2552018-10-19T15:36:52 *** bitconner has joined #bitcoin-core-dev
2562018-10-19T15:39:13 *** Zenton has quit IRC
2572018-10-19T15:41:09 *** bitconner has quit IRC
2582018-10-19T15:48:12 *** queip has joined #bitcoin-core-dev
2592018-10-19T16:01:20 *** Murch has joined #bitcoin-core-dev
2602018-10-19T16:01:31 <promag> imo is ready to merge #14453
2612018-10-19T16:01:32 <gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
2622018-10-19T16:03:56 *** rafalcpp has joined #bitcoin-core-dev
2632018-10-19T16:08:06 <jonasschnelli> promag: is it possible to add a test for 14453?
2642018-10-19T16:45:40 *** cryptocat is now known as bitbee
2652018-10-19T16:49:50 *** bitcoin-git has joined #bitcoin-core-dev
2662018-10-19T16:49:50 <bitcoin-git> [bitcoin] jamesob opened pull request #14519: test: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
2672018-10-19T16:49:50 *** bitcoin-git has left #bitcoin-core-dev
2682018-10-19T16:52:18 *** jungly has quit IRC
2692018-10-19T17:07:08 <midnightmagic> wumpus: I didn't know you were into OpenBSD. Bitcoin builds work okay on it still? There was a guy who was persistently building on OpenBSD for quite some time.
2702018-10-19T17:09:42 *** kexkey has quit IRC
2712018-10-19T17:13:01 *** jarthur has joined #bitcoin-core-dev
2722018-10-19T17:22:34 <sipa> meshcollider: argh, indeed, i should have known
2732018-10-19T17:23:33 *** Zenton has joined #bitcoin-core-dev
2742018-10-19T17:24:10 *** bitcoin-git has joined #bitcoin-core-dev
2752018-10-19T17:24:10 <bitcoin-git> [bitcoin] hebasto opened pull request #14521: qt, docs: Fix `bitcoin-qt -version` output formatting (master...20181019-qt-cli-license) https://github.com/bitcoin/bitcoin/pull/14521
2762018-10-19T17:24:10 *** bitcoin-git has left #bitcoin-core-dev
2772018-10-19T17:27:38 *** jarthur has quit IRC
2782018-10-19T17:28:11 *** jarthur has joined #bitcoin-core-dev
2792018-10-19T17:31:40 *** bralyclow2 has joined #bitcoin-core-dev
2802018-10-19T17:33:01 *** bralyclow2 has quit IRC
2812018-10-19T17:39:16 *** jarthur has quit IRC
2822018-10-19T17:41:58 *** jarthur has joined #bitcoin-core-dev
2832018-10-19T17:46:23 *** bitcoin-git has joined #bitcoin-core-dev
2842018-10-19T17:46:24 <bitcoin-git> [bitcoin] jamesob opened pull request #14522: tests: add invalid P2P message tests (master...2018-10-invalid-msgs-test) https://github.com/bitcoin/bitcoin/pull/14522
2852018-10-19T17:46:24 *** bitcoin-git has left #bitcoin-core-dev
2862018-10-19T17:49:14 *** jarthur has quit IRC
2872018-10-19T17:52:19 *** jarthur has joined #bitcoin-core-dev
2882018-10-19T18:04:04 *** jarthur has quit IRC
2892018-10-19T18:14:31 *** dqx_ has joined #bitcoin-core-dev
2902018-10-19T18:18:36 *** jarthur has joined #bitcoin-core-dev
2912018-10-19T18:29:01 *** rh0nj has quit IRC
2922018-10-19T18:30:07 *** rh0nj has joined #bitcoin-core-dev
2932018-10-19T18:34:25 *** lnostdal has joined #bitcoin-core-dev
2942018-10-19T18:48:24 *** lnostdal has quit IRC
2952018-10-19T18:48:43 *** satwo has joined #bitcoin-core-dev
2962018-10-19T18:48:45 *** lnostdal has joined #bitcoin-core-dev
2972018-10-19T18:50:16 *** bralyclow has joined #bitcoin-core-dev
2982018-10-19T18:51:00 *** bralyclo_ has joined #bitcoin-core-dev
2992018-10-19T18:53:02 *** bralyc___ has joined #bitcoin-core-dev
3002018-10-19T18:53:06 *** bralycl__ has quit IRC
3012018-10-19T18:54:22 *** bralycl__ has joined #bitcoin-core-dev
3022018-10-19T18:55:12 *** bralyclow has quit IRC
3032018-10-19T18:56:24 *** bralyclo_ has quit IRC
3042018-10-19T18:57:42 *** bralyc___ has quit IRC
3052018-10-19T19:00:28 *** jarthur has quit IRC
3062018-10-19T19:01:12 <meshcollider> Wallet meeting?
3072018-10-19T19:02:21 <sipa> oops, indeed!
3082018-10-19T19:03:13 <gmaxwell> Hi.
3092018-10-19T19:04:03 <gmaxwell> sipa: start meeting?
3102018-10-19T19:04:24 *** cold_wallet has joined #bitcoin-core-dev
3112018-10-19T19:04:56 <sipa> #startmeeting
3122018-10-19T19:04:56 <lightningbot> Meeting started Fri Oct 19 19:04:56 2018 UTC. The chair is sipa. Information about MeetBot at http://wiki.debian.org/MeetBot.
3132018-10-19T19:04:56 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3142018-10-19T19:05:00 *** paper_wallet has joined #bitcoin-core-dev
3152018-10-19T19:05:14 <sipa> welcome to the first bitcoin core wallet meeting!
3162018-10-19T19:05:30 <meshcollider> \o/
3172018-10-19T19:05:53 *** nestorOfWallets has joined #bitcoin-core-dev
3182018-10-19T19:05:57 <sipa> i think it would be good to start with listing what people are working on
3192018-10-19T19:06:44 *** hardware_wallet has joined #bitcoin-core-dev
3202018-10-19T19:07:39 <gmaxwell> I am working on nothing wallet related. (there, now everyone doesn't have to worry, since you can't be doing worse than nothing)
3212018-10-19T19:08:16 <meshcollider> I've been working on getting importmulti working with all the segwit address types and everything recently, and trying to get through most of sipa's descriptor PRs for review :)
3222018-10-19T19:08:29 <gwillen> oh hm, I am glad I happened to see this but I am interested in how one finds out about these meetings and their topics :-)
3232018-10-19T19:08:46 <sipa> gwillen: discussed yesterday in the bitcoin core meeting :)
3242018-10-19T19:08:58 <sipa> i'm working on a number of smaller descriptor related improvements, before digging into fully importing descriptors into the wallet
3252018-10-19T19:09:52 <meshcollider> Should we ping the list of Devs from the main meeting in case anyone who wanted to be here forgot
3262018-10-19T19:09:59 *** wallet_dat has joined #bitcoin-core-dev
3272018-10-19T19:10:04 <sipa> meshcollider: sgtm
3282018-10-19T19:11:00 <meshcollider> #bitcoin-core-dev Wallet meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
3292018-10-19T19:11:47 <jonasschnelli> hi
3302018-10-19T19:12:21 <kanzure> hi.
3312018-10-19T19:12:49 <gwillen> Wallet-wise: I am still working on the offline signing usecase, modeled after the flow armory uses with gui interfaces for create-sign-broadcast.
3322018-10-19T19:12:54 <kanzure> gwillen: also it was discussed in tokyo. you were there.
3332018-10-19T19:13:03 <gwillen> kanzure: like I remember things people say.
3342018-10-19T19:13:14 <luke-jr> lol
3352018-10-19T19:13:14 <jamesob> anyone know of an easy way to clear the sig/script caches of a running bitcoind process?
3362018-10-19T19:13:22 <achow101> hi
3372018-10-19T19:13:30 <sipa> jamesob: i'm not sure it's possible
3382018-10-19T19:13:36 <jamesob> oops! sorry to interrupt the meeting :)
3392018-10-19T19:13:36 <sipa> jamesob: but meeting now :)
3402018-10-19T19:13:43 <luke-jr> btw, not wallet related, but: my node stats are b0rked for a bit :x
3412018-10-19T19:13:44 <sipa> yay, we have some people
3422018-10-19T19:13:59 *** copumpkin has quit IRC
3432018-10-19T19:14:19 <kanzure> are descriptors going to be renamed (or descript?)
3442018-10-19T19:14:23 <luke-jr> sorry, gtg
3452018-10-19T19:14:39 <meshcollider> kanzure: why would they be renamed?
3462018-10-19T19:14:45 <sipa> kanzure: we've sort of settled on the name miniscript instead of descript; descriptors are descriptors :)
3472018-10-19T19:15:01 <achow101> meshcollider: because it's confusing
3482018-10-19T19:15:02 <sipa> (they're much less related to eachother than the name seemed to imply anyway)
3492018-10-19T19:15:04 <kanzure> miniscript because it's yer subset of script. alright.
3502018-10-19T19:15:09 *** reallll has joined #bitcoin-core-dev
3512018-10-19T19:15:20 <kanzure> i would have also accepted sipascript
3522018-10-19T19:15:32 <meshcollider> achow101: descriptors is a good name? Only "descript" might have been a little ;)
3532018-10-19T19:16:18 <kanzure> http://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2018-10-08-script-descriptors/
3542018-10-19T19:16:30 <sipa> so i think my most important blocker is #14150
3552018-10-19T19:16:33 <gribble> https://github.com/bitcoin/bitcoin/issues/14150 | Add key origin support to descriptors by sipa · Pull Request #14150 · bitcoin/bitcoin · GitHub
3562018-10-19T19:16:49 <achow101> so what steps do we need to do to get the wallet to be descriptor based?
3572018-10-19T19:17:25 <gwillen> kanzure: I have also been pushing for "output descriptors" rather than "script descriptors" given the choice of both, the latter being a bit of a tongue twister :-)
3582018-10-19T19:17:46 <sipa> after that a number of things become possible, including #14477, the ability to add origin info to scantxoutset (which would solve #14503), and it would also allow writing a descriptor/utxoset based PSBT updater
3592018-10-19T19:17:49 <gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
3602018-10-19T19:17:50 <gribble> https://github.com/bitcoin/bitcoin/issues/14503 | scantxoutset does not identify UTXO origins · Issue #14503 · bitcoin/bitcoin · GitHub
3612018-10-19T19:17:55 <achow101> gwillen: output script descriptors ;p
3622018-10-19T19:17:58 <sipa> achow101: yeah, that's the big question :)
3632018-10-19T19:18:24 <sipa> i think the first step is abstracting out IsMine
3642018-10-19T19:18:38 *** belcher_ has quit IRC
3652018-10-19T19:18:43 <gmaxwell> scanutxoset based psbt updater would be a major win.
3662018-10-19T19:18:44 <kanzure> need to keep old ismine things?
3672018-10-19T19:19:15 <sipa> kanzure: i would prefer that, and i also don't think it's that much extra work
3682018-10-19T19:19:30 <sipa> IsMine is really simple to add things too - just OR the result
3692018-10-19T19:19:30 <meshcollider> Long term, is making the wallet descriptor-based enough to solve all the existing concerns with same keys being used for different address types and which keys we treat as IsMine, etc?
3702018-10-19T19:19:38 <sipa> meshcollider: yup
3712018-10-19T19:21:26 <achow101> sipa: isn't IsMine already separated from the wallet?
3722018-10-19T19:21:37 <sipa> so one way of seeing it i think is that a wallet will consist of a number of records, each of which has one descriptor plus some metadata (birthdate, change or not, explored how far, gap limit, ...), and one record is designated "here is where you draw payment addresses from" and "here is where you draw change from"
3732018-10-19T19:22:27 <sipa> and then there can be - for now - a 'legacy' record that corresponds to the behaviour of the existing keypool/mapkeys/mapwatchonly/mapscripts
3742018-10-19T19:23:08 <sipa> achow101: so the goal would be that there can be multiple implementations of the ismine logic, and one (the legacy one) needs to encapsulate the keypool logic... which is a nontrivial change
3752018-10-19T19:23:45 <sipa> right now IsMine is just something that operates based on a KeyStore, and that's not enough
3762018-10-19T19:23:57 <meshcollider> For the payment and change addresses sources, they would just be ranged descriptors too right?
3772018-10-19T19:24:10 <sipa> yup
3782018-10-19T19:24:45 <sipa> another missing piece is an "evaluation cache" for descriptors, which would e.g. store pubkeys for hd keys which have hardened steps in them
3792018-10-19T19:25:36 <meshcollider> Store pubkeys for solvabilty while the wallet is locked, or?
3802018-10-19T19:25:57 <sipa> meshcollider: well, and to compute the scriptPubKeys to watch for
3812018-10-19T19:26:18 *** WalletIncmpatBdb has joined #bitcoin-core-dev
3822018-10-19T19:26:25 <sipa> for efficiency maybe it shoud store all pubkeys involved in descriptors, even the ones from unhardened paths
3832018-10-19T19:26:33 <sipa> or we'd need to rederive them at startup
3842018-10-19T19:27:50 <sipa> probably the first step is creating an interface for IsMine; just like SigningProvider is an interface for solving/signing
3852018-10-19T19:28:13 <sipa> initially the wallet itself can implement that, by calling the old IsMine code, but that code can then be moved into one instance of that logic
3862018-10-19T19:28:37 <sipa> after that, it should be easy to create another descriptor based implementation
3872018-10-19T19:29:18 <sipa> </monologue>
3882018-10-19T19:29:29 <sipa> other topics?
3892018-10-19T19:31:07 <meshcollider> Upgrade wise, descriptor based wallets aren't backwards compatible with old versions, or we are going to allow some more magic not-touching-the-wallet derivation of descriptors at startup every time?
3902018-10-19T19:31:18 *** bitconner has joined #bitcoin-core-dev
3912018-10-19T19:31:29 <sipa> yeah, that's a different question; i think there are a number of ways
3922018-10-19T19:31:51 <sipa> one is to keep them completely separate, and old wallet remains compatible with old versions as long as you don't import anything descriptor based
3932018-10-19T19:32:49 <sipa> another is to convert the existing stuff to descriptors at startup every time - which would allow removing the existing IsMine logic from the runtime, but not gain us much otherwise (and the conversion is pretty complicated)
3942018-10-19T19:33:19 <achow101> it also wouldn't work for encrypted wallets
3952018-10-19T19:33:22 <sipa> and i guess another is to just have 2 types of wallets, and you need an explicit conversion between them
3962018-10-19T19:33:42 <sipa> achow101: i think it would
3972018-10-19T19:33:53 <sipa> we know the xpub we derived keys from, no?
3982018-10-19T19:33:58 <achow101> no
3992018-10-19T19:34:24 <achow101> xpub and xprv are derived from the seed on the for whenever they are needed
4002018-10-19T19:34:24 <sipa> no?
4012018-10-19T19:34:30 <sipa> ah
4022018-10-19T19:34:59 <achow101> alao hardened derivation, so no xpub
4032018-10-19T19:35:17 <sipa> that's ok
4042018-10-19T19:35:24 <sipa> but yeah
4052018-10-19T19:35:41 <sipa> i think it's actually best to at least initially have the two live side by side
4062018-10-19T19:36:13 <meshcollider> Can we deprecate the old version and in a future release only accept wallets if they've been upgraded?
4072018-10-19T19:36:35 *** adiabat has quit IRC
4082018-10-19T19:36:52 <sipa> perhaps
4092018-10-19T19:37:09 <achow101> I'm afraid that if we have to keep the old one around that it will never go away because people don't upgrade
4102018-10-19T19:37:29 <meshcollider> That's what I mean
4112018-10-19T19:37:47 <sipa> i think a bigger question is what to do with things like addmultisigaddress etc
4122018-10-19T19:38:20 <achow101> can't it construct a descriptor based on what was given?
4132018-10-19T19:38:47 <meshcollider> Isn't that ok to just make a new multisig descriptor record with the public keys of whatever was specified?
4142018-10-19T19:38:49 <gmaxwell> that was my thought
4152018-10-19T19:39:05 <sipa> achow101: yeah, with slightly different (but far more reasonable, actuallly) semantics
4162018-10-19T19:39:13 *** adiabat has joined #bitcoin-core-dev
4172018-10-19T19:39:43 <sipa> meshcollider: same with importmulti, actually
4182018-10-19T19:39:54 <sipa> anything specified there can be converted to a descriptor
4192018-10-19T19:40:07 <andytoshi> meshcollider: people today show up with 2012 wallets on #bitcoin, and it's a pretty impressive show of backward-compatibility that i can always say "just import it into the latest core"
4202018-10-19T19:40:20 <andytoshi> even if it's got e.g. p2pk outputs
4212018-10-19T19:40:36 *** jarthur has joined #bitcoin-core-dev
4222018-10-19T19:41:50 <booyah> andytoshi: yeap, I think it's safe to assume people will expect that basically forever. Wallets in some deep storate boxes, inherited, burried in backyard
4232018-10-19T19:41:59 <meshcollider> andytoshi: you could still import it, but it would upgrade it for you I think
4242018-10-19T19:42:19 <meshcollider> So you just can't import it and then go back and use it on the 2012 software
4252018-10-19T19:43:21 <sipa> i think that the burden of maintaining compatibility with the old wallet format actually won't be too hard, as due to the necessary refactoring for descriptors in the first place, it will become pretty standalone and not entangled with everything else
4262018-10-19T19:43:46 <sipa> and i shouldn't say "old format", it's just adding some new fields
4272018-10-19T19:44:31 <jonasschnelli> I still sometimes have the feeling we should clone the wallet code (make it run with the existing wallet code) and remove everything that is legacy,.. don't promise backward comp. for 1-2 yrs.
4282018-10-19T19:44:50 <jonasschnelli> All the fancy stuff could go there...
4292018-10-19T19:44:59 <jonasschnelli> API can break during that 1-2yr period
4302018-10-19T19:45:04 <sipa> jonasschnelli: maybe, but i think that's not the right granularity
4312018-10-19T19:45:17 <sipa> you'd be duplicating a lot of things that are perfectly compatible
4322018-10-19T19:45:21 <sipa> like coin selection
4332018-10-19T19:45:23 <jonasschnelli> We still can "backport" to the stable wallet
4342018-10-19T19:45:33 <jonasschnelli> You can factor out the coin selection
4352018-10-19T19:45:38 <sipa> exactly.
4362018-10-19T19:45:40 <jonasschnelli> But I agree, some parts would. be duplicated
4372018-10-19T19:45:44 <sipa> just like you can factor out the ismine logic.
4382018-10-19T19:45:50 <sipa> :)
4392018-10-19T19:46:00 <gmaxwell> I don't think we get enough testing/review for one wallet, having two doesn't sound better. :) if it were narrowed down to a pretty small thing, then sure.
4402018-10-19T19:46:38 <gmaxwell> Being able to _import_ old wallets should always be relatively straight forward though, so it may make sense to not support old wallets except being able to import them at some point.
4412018-10-19T19:46:47 <sipa> yeah, agree
4422018-10-19T19:46:56 <jonasschnelli> I think we test less if we go with the two-wallets approach since backward compatibility and the edge-cases that come up with it consumes a major part of the review and fix time
4432018-10-19T19:47:32 <sipa> i feel that "meh just create a new wallet" is a knee jerk response when facing the complexity of the existing system
4442018-10-19T19:47:34 <jonasschnelli> At some point in time, you have to abandon old wallets (maybe thats not within the next 10 yrs)
4452018-10-19T19:47:43 <sipa> it's always appealing to rewrite things you don't understand
4462018-10-19T19:47:50 <sipa> but that doesn't make it the right choice
4472018-10-19T19:48:03 <jonasschnelli> Yes. Maybe.
4482018-10-19T19:48:06 <gmaxwell> And usually a bad idea, since the complexity was almost always there for a reason. :)
4492018-10-19T19:48:29 <sipa> it is certainly true that _some_ of the complexity can be dropped if we don't need backward compatibility
4502018-10-19T19:48:42 <sipa> but identifying that is perhaps less work than making a new implementation actually production ready
4512018-10-19T19:48:46 <jonasschnelli> I don't think its about complexity... more about progress we can't make otherwise. And dragging around legacy stuff like the account system.
4522018-10-19T19:49:18 <sipa> i think we can make progress fine
4532018-10-19T19:49:38 <jonasschnelli> Yes. That indeed true.
4542018-10-19T19:50:04 <sipa> especially with a number of people pulling in the same direction - which is something that hopefully these meetings contribute to
4552018-10-19T19:50:13 <jonasschnelli> As said, somethimes I think it would be worth do the 2nd wallet... but you guys always convince me the single-wallet approach is more future proof
4562018-10-19T19:50:54 <meshcollider> Is #8369 in any way helpful to this discussion
4572018-10-19T19:50:56 <gribble> https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
4582018-10-19T19:51:14 <jonasschnelli> meshcollider: oh. I think we implemented that in a way,.. not?
4592018-10-19T19:51:27 <jonasschnelli> With the disableprivatekey function
4602018-10-19T19:51:55 <jonasschnelli> The disableprivatekey function introduced a 64bit bitmap
4612018-10-19T19:52:18 <sipa> jonasschnelli: very old but relevant blog post: https://www.joelonsoftware.com/2000/04/06/things-you-should-never-do-part-i/
4622018-10-19T19:52:50 <jonasschnelli> Oh. I smell that this is a good read. Thanks sipa
4632018-10-19T19:53:45 <jonasschnelli> meshcollider: with that 64bit features flag bitmap, the upper 32 are mandatory (wallet needs those features) where the lower32 bits are optional.
4642018-10-19T19:53:53 *** MtgoxColdWallet has joined #bitcoin-core-dev
4652018-10-19T19:54:26 <sipa> jonasschnelli: i'm in favor of something like that, though we shouldn't overuse it as it may lead to an explosion of combinations to test
4662018-10-19T19:54:26 <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/9662/commits/9995a602a639b64a749545b7c3bafbf67f97324f
4672018-10-19T19:54:56 <sipa> (which is less of a concern when when the features don't interact, and another argument for abstracting out things, so that it becomes clear they can't interact)
4682018-10-19T19:56:44 <sipa> oh, i didn't realize the disableprivatekey introduced that already
4692018-10-19T19:56:50 <meshcollider> A descriptor wallet could just be a mandatory flag then right
4702018-10-19T19:56:56 <jonasschnelli> Yes. I smuggled it in
4712018-10-19T19:56:57 *** timothy has quit IRC
4722018-10-19T19:57:12 <sipa> meshcollider: right
4732018-10-19T19:57:12 <jonasschnelli> Things like disableprivatekeys is optional and needs a such facility
4742018-10-19T19:57:24 *** timothy has joined #bitcoin-core-dev
4752018-10-19T19:59:00 <sipa> i guess that's it?
4762018-10-19T19:59:05 <meshcollider> Alright this has been a good meeting IMO, last couple minutes anything else?
4772018-10-19T19:59:23 <meshcollider> Maybe it's just been good because I've been asking lots of questions lol
4782018-10-19T19:59:25 <jonasschnelli> We should use the meetingbot I guess?
4792018-10-19T19:59:25 <jonasschnelli> (next time)
4802018-10-19T19:59:38 *** satwo has quit IRC
4812018-10-19T19:59:40 <meshcollider> Well, it's running
4822018-10-19T19:59:50 <jonasschnelli> Oh. We did.
4832018-10-19T19:59:50 <meshcollider> Just no explicit actions or topics
4842018-10-19T19:59:58 <jonasschnelli> I see. Sure.
4852018-10-19T20:00:03 <sipa> #endmeeting
4862018-10-19T20:00:03 <lightningbot> Meeting ended Fri Oct 19 20:00:03 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4872018-10-19T20:00:03 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-19-19.04.html
4882018-10-19T20:00:03 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-19-19.04.txt
4892018-10-19T20:00:03 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-19-19.04.log.html
4902018-10-19T20:00:04 <nestorOfWallets> thanks o/
4912018-10-19T20:00:09 <sipa> thanks all!
4922018-10-19T20:00:17 <MtgoxColdWallet> see you in future
4932018-10-19T20:00:20 <meshcollider> Thank you :)
4942018-10-19T20:00:23 <paper_wallet> bb
4952018-10-19T20:00:34 *** cold_wallet has left #bitcoin-core-dev
4962018-10-19T20:00:44 *** paper_wallet has quit IRC
4972018-10-19T20:00:44 *** WalletIncmpatBdb has quit IRC
4982018-10-19T20:00:44 *** MtgoxColdWallet has quit IRC
4992018-10-19T20:00:44 *** nestorOfWallets has quit IRC
5002018-10-19T20:00:44 *** hardware_wallet has quit IRC
5012018-10-19T20:00:44 *** wallet_dat has quit IRC
5022018-10-19T20:01:17 *** hebasto has quit IRC
5032018-10-19T20:02:11 <sipa> booyah: lol
5042018-10-19T20:06:37 *** timothy has quit IRC
5052018-10-19T20:06:39 *** Krellan_ has joined #bitcoin-core-dev
5062018-10-19T20:09:58 *** Murch has quit IRC
5072018-10-19T20:14:11 *** Murch has joined #bitcoin-core-dev
5082018-10-19T20:17:33 *** Chris_Stewart_5 has quit IRC
5092018-10-19T20:25:21 *** lnostdal has quit IRC
5102018-10-19T20:31:43 *** satwo has joined #bitcoin-core-dev
5112018-10-19T20:41:48 *** satwo has quit IRC
5122018-10-19T20:43:40 *** lnostdal has joined #bitcoin-core-dev
5132018-10-19T20:45:57 *** satwo has joined #bitcoin-core-dev
5142018-10-19T20:54:22 *** ula has joined #bitcoin-core-dev
5152018-10-19T21:00:19 *** AaronvanW has joined #bitcoin-core-dev
5162018-10-19T21:07:51 *** michaelsdunn1 has quit IRC
5172018-10-19T21:08:27 *** michaelsdunn1 has joined #bitcoin-core-dev
5182018-10-19T21:09:27 *** michaels_ has joined #bitcoin-core-dev
5192018-10-19T21:21:01 *** michaels_ has quit IRC
5202018-10-19T21:27:01 *** dqx__ has joined #bitcoin-core-dev
5212018-10-19T21:29:41 *** dqx__ has quit IRC
5222018-10-19T21:30:03 *** dqx_ has quit IRC
5232018-10-19T21:31:21 *** dqx_ has joined #bitcoin-core-dev
5242018-10-19T21:31:30 *** Victorsueca has quit IRC
5252018-10-19T21:41:18 *** Victorsueca has joined #bitcoin-core-dev
5262018-10-19T21:41:33 <jarthur> jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them.
5272018-10-19T21:48:38 <sipa> details?
5282018-10-19T21:48:52 <sipa> i'll join
5292018-10-19T21:50:46 *** dqx_ has quit IRC
5302018-10-19T21:51:27 <jarthur> Thanks, sipa
5312018-10-19T21:58:49 *** Guyver2 has quit IRC
5322018-10-19T22:02:00 *** Aaronvan_ has joined #bitcoin-core-dev
5332018-10-19T22:02:41 *** dqx_ has joined #bitcoin-core-dev
5342018-10-19T22:03:57 *** AaronvanW has quit IRC
5352018-10-19T22:16:48 *** laurentmt has joined #bitcoin-core-dev
5362018-10-19T22:18:23 *** spinza has quit IRC
5372018-10-19T22:31:02 *** rh0nj has quit IRC
5382018-10-19T22:32:07 *** rh0nj has joined #bitcoin-core-dev
5392018-10-19T22:36:48 *** spinza has joined #bitcoin-core-dev
5402018-10-19T22:41:33 *** justanotheruser has joined #bitcoin-core-dev
5412018-10-19T22:47:36 *** ossifrage has quit IRC
5422018-10-19T22:57:34 *** laurentmt has quit IRC
5432018-10-19T22:59:57 *** michaels_ has joined #bitcoin-core-dev
5442018-10-19T23:02:13 *** ossifrage has joined #bitcoin-core-dev
5452018-10-19T23:10:23 *** michaels_ has quit IRC
5462018-10-19T23:27:19 *** copumpkin has joined #bitcoin-core-dev
5472018-10-19T23:30:28 *** Murch has quit IRC
5482018-10-19T23:33:47 *** copumpkin has quit IRC
5492018-10-19T23:37:34 *** jarthur has quit IRC
5502018-10-19T23:49:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5512018-10-19T23:57:21 *** bitcoin-git has joined #bitcoin-core-dev
5522018-10-19T23:57:21 <bitcoin-git> [bitcoin] kristapsk opened pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524
5532018-10-19T23:57:21 *** bitcoin-git has left #bitcoin-core-dev