12018-10-24T00:04:52  *** bitconner has joined #bitcoin-core-dev
  22018-10-24T00:05:03  *** ken2812221 has joined #bitcoin-core-dev
  32018-10-24T00:22:16  *** bitconner has quit IRC
  42018-10-24T00:27:54  *** bitconner has joined #bitcoin-core-dev
  52018-10-24T00:28:07  *** jarthur has quit IRC
  62018-10-24T00:29:12  *** Mutter has joined #bitcoin-core-dev
  72018-10-24T00:34:33  *** bitcoin-git has joined #bitcoin-core-dev
  82018-10-24T00:34:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/94cf1ec94821...5473e255f687
  92018-10-24T00:34:34  <bitcoin-git> bitcoin/master 0089905 practicalswift: Add compile time checking for cs_main locks which we assert at run time
 102018-10-24T00:34:35  <bitcoin-git> bitcoin/master 5473e25 MarcoFalke: Merge #14444: Add compile time checking for cs_main locks which we assert at run time...
 112018-10-24T00:34:35  *** bitcoin-git has left #bitcoin-core-dev
 122018-10-24T00:35:37  *** bitcoin-git has joined #bitcoin-core-dev
 132018-10-24T00:35:37  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14444: Add compile time checking for cs_main locks which we assert at run time (master...move-runtime-checking-to-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/14444
 142018-10-24T00:35:37  *** bitcoin-git has left #bitcoin-core-dev
 152018-10-24T00:40:53  *** dqx_ has quit IRC
 162018-10-24T00:42:43  *** jarthur has joined #bitcoin-core-dev
 172018-10-24T00:46:29  *** jarthur has quit IRC
 182018-10-24T00:49:11  *** Mutter has quit IRC
 192018-10-24T00:49:38  *** grubles has quit IRC
 202018-10-24T00:52:56  *** Mutter has joined #bitcoin-core-dev
 212018-10-24T00:58:07  *** Victorsueca has quit IRC
 222018-10-24T00:59:19  *** Victorsueca has joined #bitcoin-core-dev
 232018-10-24T01:02:36  *** Mutter has quit IRC
 242018-10-24T01:02:55  *** jarthur has joined #bitcoin-core-dev
 252018-10-24T01:33:52  *** Mutter has joined #bitcoin-core-dev
 262018-10-24T01:41:02  *** Mutter has quit IRC
 272018-10-24T01:42:25  *** michaelsdunn1 has joined #bitcoin-core-dev
 282018-10-24T01:55:54  *** bitconner has quit IRC
 292018-10-24T01:58:12  *** AaronvanW has quit IRC
 302018-10-24T02:07:23  *** StopAndDecrypt has quit IRC
 312018-10-24T02:08:58  *** bitconner has joined #bitcoin-core-dev
 322018-10-24T02:09:38  *** StopAndDecrypt has joined #bitcoin-core-dev
 332018-10-24T02:15:47  *** bitconner has quit IRC
 342018-10-24T02:22:07  *** luke-jr has quit IRC
 352018-10-24T02:22:17  *** luke-jr has joined #bitcoin-core-dev
 362018-10-24T02:23:22  *** ken2812221 has quit IRC
 372018-10-24T02:32:38  *** Emcy has joined #bitcoin-core-dev
 382018-10-24T02:32:38  *** Emcy_ has quit IRC
 392018-10-24T02:57:07  *** Emcy has quit IRC
 402018-10-24T02:57:36  *** Emcy has joined #bitcoin-core-dev
 412018-10-24T03:05:58  *** michaelsdunn1 has quit IRC
 422018-10-24T03:07:23  *** michaelsdunn1 has joined #bitcoin-core-dev
 432018-10-24T03:08:20  *** michaelsdunn1 has joined #bitcoin-core-dev
 442018-10-24T03:10:34  *** promag has quit IRC
 452018-10-24T03:52:18  *** schnerch_ has joined #bitcoin-core-dev
 462018-10-24T03:54:18  *** schnerchi has quit IRC
 472018-10-24T04:02:55  *** TheRec has quit IRC
 482018-10-24T04:12:22  *** bitconner has joined #bitcoin-core-dev
 492018-10-24T04:15:08  *** hebasto has joined #bitcoin-core-dev
 502018-10-24T04:16:52  *** bitconner has quit IRC
 512018-10-24T04:43:33  *** Randolf has joined #bitcoin-core-dev
 522018-10-24T04:45:36  *** bitcoin-git has joined #bitcoin-core-dev
 532018-10-24T04:45:36  <bitcoin-git> [bitcoin] achow101 opened pull request #14558: rpc: Require solvability in importmulti if importing more than the scriptPubKey (master...importmulti-solvability) https://github.com/bitcoin/bitcoin/pull/14558
 542018-10-24T04:45:36  *** bitcoin-git has left #bitcoin-core-dev
 552018-10-24T05:15:00  *** sanket1729_ has joined #bitcoin-core-dev
 562018-10-24T05:28:51  *** mr_paz has quit IRC
 572018-10-24T05:29:08  *** mr_paz has joined #bitcoin-core-dev
 582018-10-24T05:35:34  *** lnostdal has quit IRC
 592018-10-24T05:40:11  *** mr_paz has quit IRC
 602018-10-24T05:40:14  *** mr_paz_ has joined #bitcoin-core-dev
 612018-10-24T06:17:57  *** promag has joined #bitcoin-core-dev
 622018-10-24T06:23:01  *** rh0nj has quit IRC
 632018-10-24T06:24:07  *** rh0nj has joined #bitcoin-core-dev
 642018-10-24T06:29:30  *** promag has quit IRC
 652018-10-24T06:32:19  *** thaumavorio has quit IRC
 662018-10-24T06:34:05  *** Soligor has joined #bitcoin-core-dev
 672018-10-24T06:39:13  *** thaumavorio has joined #bitcoin-core-dev
 682018-10-24T06:43:23  *** sanket1729_ has quit IRC
 692018-10-24T06:50:20  *** Krellan has joined #bitcoin-core-dev
 702018-10-24T06:52:41  *** thaumavorio has quit IRC
 712018-10-24T06:54:06  *** thaumavorio has joined #bitcoin-core-dev
 722018-10-24T06:59:47  *** ken2812221 has joined #bitcoin-core-dev
 732018-10-24T07:03:07  *** setpill has joined #bitcoin-core-dev
 742018-10-24T07:06:22  *** setpill has quit IRC
 752018-10-24T07:06:59  *** TheRec has joined #bitcoin-core-dev
 762018-10-24T07:06:59  *** TheRec has joined #bitcoin-core-dev
 772018-10-24T07:07:44  *** setpill has joined #bitcoin-core-dev
 782018-10-24T07:09:16  *** timothy has joined #bitcoin-core-dev
 792018-10-24T07:09:33  *** bitconner has joined #bitcoin-core-dev
 802018-10-24T07:13:26  *** bitcoin-git has joined #bitcoin-core-dev
 812018-10-24T07:13:26  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
 822018-10-24T07:13:26  *** bitcoin-git has left #bitcoin-core-dev
 832018-10-24T07:13:47  *** bitconner has quit IRC
 842018-10-24T08:09:15  *** panako has joined #bitcoin-core-dev
 852018-10-24T08:13:34  *** martinus_ has joined #bitcoin-core-dev
 862018-10-24T08:28:47  *** jungly has joined #bitcoin-core-dev
 872018-10-24T08:38:39  *** promag has joined #bitcoin-core-dev
 882018-10-24T08:41:16  <promag> ken2812221: I don't understand what you mean here https://github.com/bitcoin/bitcoin/pull/14552#issuecomment-432409103
 892018-10-24T08:58:08  <ken2812221> Sorry, my English is not good. I'll try to explain.
 902018-10-24T08:59:59  <promag> I have the same problem :P but I don't understand the lazy part
 912018-10-24T09:00:24  *** bitconner has joined #bitcoin-core-dev
 922018-10-24T09:03:02  <ken2812221> @promag Can you take a look again?
 932018-10-24T09:03:21  *** bitcoin-git has joined #bitcoin-core-dev
 942018-10-24T09:03:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5473e255f687...e895fdc9fc83
 952018-10-24T09:03:22  <bitcoin-git> bitcoin/master 1c7e25d practicalswift: wallet: Add missing locks
 962018-10-24T09:03:22  <bitcoin-git> bitcoin/master dee4292 practicalswift: wallet: Add Clang thread safety analysis annotations
 972018-10-24T09:03:23  <bitcoin-git> bitcoin/master 37b2538 practicalswift: Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext...
 982018-10-24T09:03:23  *** bitcoin-git has left #bitcoin-core-dev
 992018-10-24T09:03:37  *** bitcoin-git has joined #bitcoin-core-dev
1002018-10-24T09:03:38  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet (master...missing-wallet-locks) https://github.com/bitcoin/bitcoin/pull/11634
1012018-10-24T09:03:38  *** bitcoin-git has left #bitcoin-core-dev
1022018-10-24T09:04:45  *** bitconner has quit IRC
1032018-10-24T09:11:20  <promag> ken2812221: ah now I understand :) ty
1042018-10-24T09:13:15  <promag> ken2812221: I wonder if it's still possible to abstract "wallet.dat" in db.{cpp,h}
1052018-10-24T09:23:59  <ken2812221> Maybe we should add add m_file in CWallet?
1062018-10-24T09:25:47  <ken2812221> To store the exact wallet filename. Then we can get rid of all "wallet.dat" in db.{cpp,h} hopefully.
1072018-10-24T09:34:02  <promag> FWIW in #14350, I was planning to add WalletLocation::GetEnvironmentPath and WalletLocation::GetDatabasePath
1082018-10-24T09:34:05  <gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
1092018-10-24T09:41:35  *** Mutter has joined #bitcoin-core-dev
1102018-10-24T09:43:28  *** Mutter has quit IRC
1112018-10-24T09:43:56  <promag> ken2812221: should we support -wallet=sub/w5 in windows?
1122018-10-24T09:44:49  <ken2812221> It's a valid path on Windows, but it is equal to sub\w5
1132018-10-24T09:45:42  <promag> so in listwallets we honor the supplied value
1142018-10-24T09:47:02  <wumpus> sounds like a no-brainer to have the wallet object know its own filename
1152018-10-24T09:47:27  <promag> wumpus: you mean the database file path?
1162018-10-24T09:47:29  <wumpus> even if it is only or display/UI purposes
1172018-10-24T09:48:01  <wumpus> yes, whatever the particular database has as a concept of database idenitifier I guess
1182018-10-24T09:48:34  <wumpus> I mean the user needs to be able to tell databases apart from it, that's the point
1192018-10-24T09:53:29  <promag> ken2812221: wumpus: BTW you could review #14531
1202018-10-24T09:53:31  <gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
1212018-10-24T09:53:45  <wumpus> yess I will thanks
1222018-10-24T09:55:07  <wumpus> ohh you added a unit test great
1232018-10-24T09:56:18  *** iphelix has quit IRC
1242018-10-24T09:57:47  *** iphelix has joined #bitcoin-core-dev
1252018-10-24T09:58:09  *** iphelix is now known as Guest11672
1262018-10-24T10:02:00  *** spinza has quit IRC
1272018-10-24T10:05:13  <promag> wumpus: yes let me know if it can be improved
1282018-10-24T10:05:39  *** martinus_ has quit IRC
1292018-10-24T10:07:37  *** spinza has joined #bitcoin-core-dev
1302018-10-24T10:13:16  *** bitcoin-git has joined #bitcoin-core-dev
1312018-10-24T10:13:16  <bitcoin-git> [bitcoin] practicalswift opened pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
1322018-10-24T10:13:16  *** bitcoin-git has left #bitcoin-core-dev
1332018-10-24T10:13:52  *** Victorsueca has quit IRC
1342018-10-24T10:15:19  *** Mutter has joined #bitcoin-core-dev
1352018-10-24T10:16:06  *** OzPac has joined #bitcoin-core-dev
1362018-10-24T10:19:00  *** panako has quit IRC
1372018-10-24T10:22:41  <promag> ken2812221: I'll rebase mine on #14559 instead
1382018-10-24T10:22:43  <gribble> https://github.com/bitcoin/bitcoin/issues/14559 | appveyor: Enable multiwallet tests by ken2812221 · Pull Request #14559 · bitcoin/bitcoin · GitHub
1392018-10-24T10:22:59  *** Mutter has quit IRC
1402018-10-24T10:23:08  *** michaelfolkson has joined #bitcoin-core-dev
1412018-10-24T10:24:04  *** Mutter has joined #bitcoin-core-dev
1422018-10-24T10:24:46  *** Mutter has quit IRC
1432018-10-24T10:24:52  *** AaronvanW has joined #bitcoin-core-dev
1442018-10-24T10:26:17  *** michaelfolkson has quit IRC
1452018-10-24T10:39:47  <ken2812221> promag: Thank you
1462018-10-24T10:39:54  <promag> wumpus: sorry going to force push 14531 because of rebase
1472018-10-24T10:42:35  <ken2812221> promag: Better to make sure that all folders used in 14531 are exist.
1482018-10-24T10:42:51  <ken2812221> I mean in unit test
1492018-10-24T10:42:55  <promag> ken2812221: why?
1502018-10-24T10:43:36  <promag> shouldn't hit the filesystem?
1512018-10-24T10:49:53  <ken2812221> It would actually open files and compare file descriptor.
1522018-10-24T10:50:19  <ken2812221> It's using temp folder, so it would not hurt.
1532018-10-24T10:50:33  *** AaronvanW has quit IRC
1542018-10-24T10:50:39  <ken2812221> https://github.com/boostorg/filesystem/blob/develop/src/operations.cpp#L1186
1552018-10-24T10:52:34  *** AaronvanW has joined #bitcoin-core-dev
1562018-10-24T10:52:43  <promag> hmm
1572018-10-24T10:53:21  <promag> ken2812221: is it too bad to just remove the substr(0, base.size()) from the absolute path?
1582018-10-24T10:54:27  *** dqx_ has joined #bitcoin-core-dev
1592018-10-24T10:54:52  *** dqx_ has quit IRC
1602018-10-24T10:55:41  <promag> ken2812221: what is the best way to convert fs::path to string?
1612018-10-24T11:00:37  *** bitconner has joined #bitcoin-core-dev
1622018-10-24T11:00:47  <ken2812221> promag: Does substr(0, base.size()) work on case insensitive filesystem?
1632018-10-24T11:01:12  <ken2812221> .string()?
1642018-10-24T11:06:40  *** bitconner has quit IRC
1652018-10-24T11:17:08  *** michaelfolkson has joined #bitcoin-core-dev
1662018-10-24T11:23:43  *** hebasto_ has joined #bitcoin-core-dev
1672018-10-24T11:23:48  *** hebasto has quit IRC
1682018-10-24T11:30:27  *** laurentmt has joined #bitcoin-core-dev
1692018-10-24T11:30:59  *** bitcoin-git has joined #bitcoin-core-dev
1702018-10-24T11:30:59  <bitcoin-git> [bitcoin] promag opened pull request #14561: Remove fs::relative call and fix listwalletdir tests (master...2018-10-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/14561
1712018-10-24T11:30:59  *** bitcoin-git has left #bitcoin-core-dev
1722018-10-24T11:31:13  <promag> ken2812221: please take a look at https://github.com/bitcoin/bitcoin/pull/14561/commits/be120e35d15220c65a08583ff774bb324ffe7fb4
1732018-10-24T11:33:31  <promag> ken2812221: instead of adding a generic GetRelativePath (just because we have to support boost 1.47), and since we need the relative path in the recursive_directory_iterator loop, I've removed the walletdir there
1742018-10-24T11:39:51  *** michaelfolkson has quit IRC
1752018-10-24T11:41:52  *** michaelfolkson has joined #bitcoin-core-dev
1762018-10-24T11:47:18  *** michaelfolkson has quit IRC
1772018-10-24T11:50:00  *** laurentmt has quit IRC
1782018-10-24T11:53:16  *** michaelfolkson has joined #bitcoin-core-dev
1792018-10-24T11:56:56  *** Victorsueca has joined #bitcoin-core-dev
1802018-10-24T12:03:18  *** bitcoin-git has joined #bitcoin-core-dev
1812018-10-24T12:03:18  <bitcoin-git> [bitcoin] practicalswift closed pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
1822018-10-24T12:03:18  *** bitcoin-git has left #bitcoin-core-dev
1832018-10-24T12:11:09  *** bitcoin-git has joined #bitcoin-core-dev
1842018-10-24T12:11:09  <bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/e895fdc9fc83...9dda5fdf64ca
1852018-10-24T12:11:10  <bitcoin-git> bitcoin/master 67d7d67 John Newbery: [test] Fix flake8 warnings in tests...
1862018-10-24T12:11:10  <bitcoin-git> bitcoin/master bdefc97 John Newbery: [tests] Remove deprecated addwitnessaddress call from feature_nulldummy...
1872018-10-24T12:11:11  <bitcoin-git> bitcoin/master 3cf77f0 John Newbery: [tests] Remove deprecated addwitnessaddress call from wallet_dump.py...
1882018-10-24T12:11:11  *** bitcoin-git has left #bitcoin-core-dev
1892018-10-24T12:12:03  *** bitcoin-git has joined #bitcoin-core-dev
1902018-10-24T12:12:03  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14296: [wallet] Remove addwitnessaddress (master...remove_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/14296
1912018-10-24T12:12:03  *** bitcoin-git has left #bitcoin-core-dev
1922018-10-24T12:24:27  *** IGHOR has quit IRC
1932018-10-24T12:32:55  *** bitcoin-git has joined #bitcoin-core-dev
1942018-10-24T12:32:55  <bitcoin-git> [bitcoin] karel-3d closed pull request #14502: Rpc help helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
1952018-10-24T12:32:55  *** bitcoin-git has left #bitcoin-core-dev
1962018-10-24T12:45:29  *** dqx has quit IRC
1972018-10-24T12:47:52  *** michaelfolkson has quit IRC
1982018-10-24T12:51:36  *** ap4lmtree has quit IRC
1992018-10-24T12:55:29  *** ap4lmtree has joined #bitcoin-core-dev
2002018-10-24T13:02:47  *** bitconner has joined #bitcoin-core-dev
2012018-10-24T13:07:08  *** bitconner has quit IRC
2022018-10-24T13:16:08  *** Krellan has quit IRC
2032018-10-24T13:17:29  *** Krellan has joined #bitcoin-core-dev
2042018-10-24T13:20:17  *** IGHOR has joined #bitcoin-core-dev
2052018-10-24T13:21:06  *** bitcoin-git has joined #bitcoin-core-dev
2062018-10-24T13:21:07  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dda5fdf64ca...2e15fa16cd3b
2072018-10-24T13:21:07  <bitcoin-git> bitcoin/master 585b47c João Barbosa: rpc: Prevent concurrent savemempool
2082018-10-24T13:21:08  <bitcoin-git> bitcoin/master 2e15fa1 Wladimir J. van der Laan: Merge #12842: Prevent concurrent savemempool...
2092018-10-24T13:21:08  *** bitcoin-git has left #bitcoin-core-dev
2102018-10-24T13:21:36  *** bitcoin-git has joined #bitcoin-core-dev
2112018-10-24T13:21:36  <bitcoin-git> [bitcoin] laanwj closed pull request #12842: Prevent concurrent savemempool (master...2018-03-concurrent-savemempool) https://github.com/bitcoin/bitcoin/pull/12842
2122018-10-24T13:21:36  *** bitcoin-git has left #bitcoin-core-dev
2132018-10-24T13:29:19  <wumpus> loool https://github.com/bitcoin/bitcoin/pull/14504#issuecomment-431169025 apparently a spinner makes for a "boring user experience" of the tests, happy that running the tests is so exciting now
2142018-10-24T13:30:26  *** Randolf has quit IRC
2152018-10-24T13:36:39  *** setpill has quit IRC
2162018-10-24T13:41:18  <sipa> wumpus: development goals :)
2172018-10-24T13:42:20  <promag> so much excitement
2182018-10-24T13:42:25  <sipa> wow
2192018-10-24T13:42:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2202018-10-24T13:50:41  <wumpus> :D
2212018-10-24T13:50:46  <promag> merge_queue.push(#14453)
2222018-10-24T13:50:48  <gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
2232018-10-24T14:08:02  *** nodweber has quit IRC
2242018-10-24T14:08:03  *** thib has quit IRC
2252018-10-24T14:09:31  *** thib has joined #bitcoin-core-dev
2262018-10-24T14:09:51  *** nodweber has joined #bitcoin-core-dev
2272018-10-24T14:15:54  *** dgenr8 has quit IRC
2282018-10-24T14:16:55  *** Mutter has joined #bitcoin-core-dev
2292018-10-24T14:18:51  *** bitcoin-git has joined #bitcoin-core-dev
2302018-10-24T14:18:51  <bitcoin-git> [bitcoin] promag closed pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
2312018-10-24T14:18:51  *** bitcoin-git has left #bitcoin-core-dev
2322018-10-24T14:23:58  *** dgenr8 has joined #bitcoin-core-dev
2332018-10-24T14:30:19  *** bitcoin-git has joined #bitcoin-core-dev
2342018-10-24T14:30:19  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e15fa16cd3b...9886590116b1
2352018-10-24T14:30:19  <bitcoin-git> bitcoin/master 9dcf6c0 Wladimir J. van der Laan: build: Add --disable-bip70 configure option...
2362018-10-24T14:30:20  <bitcoin-git> bitcoin/master 38b9850 Wladimir J. van der Laan: qt: cleanup: Move BIP70 functions together in paymentserver...
2372018-10-24T14:30:20  <bitcoin-git> bitcoin/master fbb643d James Hilliard: Add BIP70 deprecation warning
2382018-10-24T14:30:21  *** bitcoin-git has left #bitcoin-core-dev
2392018-10-24T14:31:45  *** fanquake has joined #bitcoin-core-dev
2402018-10-24T14:31:47  *** bitcoin-git has joined #bitcoin-core-dev
2412018-10-24T14:31:47  <bitcoin-git> [bitcoin] laanwj closed pull request #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support (master...deprecate-bip70) https://github.com/bitcoin/bitcoin/pull/14451
2422018-10-24T14:31:47  *** bitcoin-git has left #bitcoin-core-dev
2432018-10-24T14:34:45  <fanquake> wumpus are we meant to be able to build bitcoin-qt without protobuf after #14451?
2442018-10-24T14:34:48  <gribble> https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub
2452018-10-24T14:35:17  <fanquake> I'm unable to, and commented about 30s to late.. Although might be misunderstanding.
2462018-10-24T14:37:18  *** michaelsdunn1 has joined #bitcoin-core-dev
2472018-10-24T14:40:07  <fanquake> np, cleared up by Marco
2482018-10-24T14:40:52  *** fanquake has quit IRC
2492018-10-24T14:41:01  *** Aaronvan_ has joined #bitcoin-core-dev
2502018-10-24T14:43:27  <luke-jr> not building bitcoin-qt seems a bit extreme though; might make sense to refactor configure to just change the bip70 option
2512018-10-24T14:44:00  *** AaronvanW has quit IRC
2522018-10-24T14:45:07  *** bitcoin-git has joined #bitcoin-core-dev
2532018-10-24T14:45:07  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9886590116b1...a74ed3a05b27
2542018-10-24T14:45:08  <bitcoin-git> bitcoin/master 321decf João Barbosa: rpc: Fix wallet unload during walletpassphrase timeout
2552018-10-24T14:45:08  <bitcoin-git> bitcoin/master 8907df9 João Barbosa: qa: Ensure wallet unload during walletpassphrase timeout
2562018-10-24T14:45:09  <bitcoin-git> bitcoin/master a74ed3a Wladimir J. van der Laan: Merge #14453: rpc: Fix wallet unload during walletpassphrase timeout...
2572018-10-24T14:45:09  *** bitcoin-git has left #bitcoin-core-dev
2582018-10-24T14:45:19  <promag> ken2812221: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19758459
2592018-10-24T14:45:33  <promag> ken2812221: there's a bunch of `Error: Specified -walletdir "wallets" is a relative path`
2602018-10-24T14:46:38  *** bitcoin-git has joined #bitcoin-core-dev
2612018-10-24T14:46:38  <bitcoin-git> [bitcoin] laanwj closed pull request #14453: rpc: Fix wallet unload during walletpassphrase timeout (master...2018-10-unload-unlocked-wallet) https://github.com/bitcoin/bitcoin/pull/14453
2622018-10-24T14:46:38  *** bitcoin-git has left #bitcoin-core-dev
2632018-10-24T14:51:54  <ken2812221> promag: See https://github.com/bitcoin/bitcoin/pull/14146#issuecomment-421099412
2642018-10-24T14:54:20  <promag> thanks
2652018-10-24T14:55:40  *** Chris_Stewart_5 has quit IRC
2662018-10-24T14:56:25  <promag> wumpus: sorry, could you replace 14531 with 14561 in HP? also 14350 should not be there.
2672018-10-24T15:02:43  *** esotericnonsense has quit IRC
2682018-10-24T15:04:10  *** esotericnonsense has joined #bitcoin-core-dev
2692018-10-24T15:14:01  *** spinza has quit IRC
2702018-10-24T15:17:38  *** bitcoin-git has joined #bitcoin-core-dev
2712018-10-24T15:17:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a74ed3a05b27...6241eb3224d9
2722018-10-24T15:17:39  <bitcoin-git> bitcoin/master 96c509e Isidoro Ghezzi: show the progress of functional test...
2732018-10-24T15:17:40  <bitcoin-git> bitcoin/master 6241eb3 MarcoFalke: Merge #14504: tests: show the progress of functional tests...
2742018-10-24T15:17:40  *** bitcoin-git has left #bitcoin-core-dev
2752018-10-24T15:18:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2762018-10-24T15:19:20  *** bitcoin-git has joined #bitcoin-core-dev
2772018-10-24T15:19:20  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14504: tests: show the progress of functional tests (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
2782018-10-24T15:19:20  *** bitcoin-git has left #bitcoin-core-dev
2792018-10-24T15:26:24  *** Krellan has quit IRC
2802018-10-24T15:27:14  *** Krellan has joined #bitcoin-core-dev
2812018-10-24T15:31:55  *** spinza has joined #bitcoin-core-dev
2822018-10-24T15:33:37  *** jarthur has joined #bitcoin-core-dev
2832018-10-24T15:38:02  *** bitcoin-git has joined #bitcoin-core-dev
2842018-10-24T15:38:02  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6241eb3224d9...2b88f67e0bcc
2852018-10-24T15:38:03  <bitcoin-git> bitcoin/master 2d796fa Chun Kuan Lee: wallet: Fix duplicate fileid
2862018-10-24T15:38:03  <bitcoin-git> bitcoin/master 4ea7732 Chun Kuan Lee: tests: add test case for loading copied wallet twice
2872018-10-24T15:38:04  <bitcoin-git> bitcoin/master 2b88f67 Wladimir J. van der Laan: Merge #14320: [bugfix] wallet: Fix duplicate fileid detection...
2882018-10-24T15:38:04  *** bitcoin-git has left #bitcoin-core-dev
2892018-10-24T15:39:05  *** irc_viewer_test has joined #bitcoin-core-dev
2902018-10-24T15:39:08  *** bitcoin-git has joined #bitcoin-core-dev
2912018-10-24T15:39:08  <bitcoin-git> [bitcoin] laanwj closed pull request #14320: [bugfix] wallet: Fix duplicate fileid detection (master...2018-09-25-wallet-duplicate-fileid-fix) https://github.com/bitcoin/bitcoin/pull/14320
2922018-10-24T15:39:08  *** bitcoin-git has left #bitcoin-core-dev
2932018-10-24T15:41:14  *** irc_viewer_test has quit IRC
2942018-10-24T15:53:56  *** Guest11672 is now known as iphelix
2952018-10-24T15:53:56  *** iphelix has joined #bitcoin-core-dev
2962018-10-24T15:57:08  *** bitcoin-git has joined #bitcoin-core-dev
2972018-10-24T15:57:08  <bitcoin-git> [bitcoin] promag closed pull request #12929: Remove CWallet dependency from CWalletTx (master...2018-04-wallettx) https://github.com/bitcoin/bitcoin/pull/12929
2982018-10-24T15:57:08  *** bitcoin-git has left #bitcoin-core-dev
2992018-10-24T15:59:56  <promag> wumpus: I'd like to have #13501 as soon as possible so it gets really tested by other pulls and travis/appveyor before 0.18
3002018-10-24T15:59:59  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
3012018-10-24T16:03:02  *** bitconner has joined #bitcoin-core-dev
3022018-10-24T16:03:10  *** bitcoin-git has joined #bitcoin-core-dev
3032018-10-24T16:03:10  <bitcoin-git> [bitcoin] promag closed pull request #13637: wallet: Add GetBalances to calculate all balances (master...2018-06-wallet-getbalance) https://github.com/bitcoin/bitcoin/pull/13637
3042018-10-24T16:03:10  *** bitcoin-git has left #bitcoin-core-dev
3052018-10-24T16:03:40  <wumpus> promag: I'm a bit scared of that one, let me see again
3062018-10-24T16:06:55  <promag> wumpus: thanks
3072018-10-24T16:09:04  *** bitconner has quit IRC
3082018-10-24T16:09:50  *** Murch has joined #bitcoin-core-dev
3092018-10-24T16:14:06  <wumpus> it's one of those things that have been 'fixed' too many times
3102018-10-24T16:15:37  <luke-jr> is there a reason we distribute tar.gz instead of tar.xz?
3112018-10-24T16:16:56  *** jarthur has quit IRC
3122018-10-24T16:17:24  *** jarthur has joined #bitcoin-core-dev
3132018-10-24T16:28:41  *** michaelfolkson has joined #bitcoin-core-dev
3142018-10-24T16:47:00  *** Victorsueca has quit IRC
3152018-10-24T16:47:58  <luke-jr> is a 10 GB blockchain benchmark significant?
3162018-10-24T16:48:09  <luke-jr> or do I need to get real storage involved?
3172018-10-24T16:48:12  *** Victorsueca has joined #bitcoin-core-dev
3182018-10-24T16:49:07  *** Chris_Stewart_5 has quit IRC
3192018-10-24T16:51:49  <gmaxwell> luke-jr: tar.xz is probably a PITA to open on windows/mac/openbsd. and who cares if the download is a couple MB bigger when the sync going to be 250GB...
3202018-10-24T16:55:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3212018-10-24T17:06:05  *** bitcoin-git has joined #bitcoin-core-dev
3222018-10-24T17:06:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b88f67e0bcc...613fc95ee4ea
3232018-10-24T17:06:06  <bitcoin-git> bitcoin/master 4dca7d0 Chun Kuan Lee: appveyor: Enable multiwallet test
3242018-10-24T17:06:07  <bitcoin-git> bitcoin/master 613fc95 MarcoFalke: Merge #14559: appveyor: Enable multiwallet tests...
3252018-10-24T17:06:07  *** bitcoin-git has left #bitcoin-core-dev
3262018-10-24T17:07:30  *** bitcoin-git has joined #bitcoin-core-dev
3272018-10-24T17:07:30  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
3282018-10-24T17:07:30  *** bitcoin-git has left #bitcoin-core-dev
3292018-10-24T17:11:20  <luke-jr> gmaxwell: well, they're Linux binaries inside
3302018-10-24T17:11:56  <gmaxwell> there is also source inside.
3312018-10-24T17:12:22  *** jungly has quit IRC
3322018-10-24T17:14:00  *** michaelfolkson has quit IRC
3332018-10-24T17:19:13  <luke-jr> a different tarball
3342018-10-24T17:20:07  <luke-jr> anyway, I see 2.2% performance gain over the first 10 GB of blocks using BlueMatt's POWER8 optimisation stuff (on binaries built for POWER7)
3352018-10-24T17:20:15  <luke-jr> is that significant?
3362018-10-24T17:20:58  * luke-jr has no idea why -mcpu=power7 performs better than -mcpu=power9 on POWER9..
3372018-10-24T17:21:02  <sipa> there may be a larger benefit to larger blocks
3382018-10-24T17:22:39  <gmaxwell> luke-jr: the interesting question is did something break the speedup of sse4/avx over plain C.
3392018-10-24T17:23:00  <gmaxwell> The microbenchmark on that power8 optimized sha2 is a comparable speedup to sse4 on x86.
3402018-10-24T17:23:08  *** bitcoin-git has joined #bitcoin-core-dev
3412018-10-24T17:23:08  <bitcoin-git> [bitcoin] Neeshmacpaul opened pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
3422018-10-24T17:23:08  *** bitcoin-git has left #bitcoin-core-dev
3432018-10-24T17:23:28  <BlueMatt> luke-jr: yea, I closed it cause 2.2% is wayyyy lower than it should be based on the microbenchmar
3442018-10-24T17:23:28  <BlueMatt> k
3452018-10-24T17:23:38  <BlueMatt> it may be that it doesnt actually help cause the limit is cache or something like that
3462018-10-24T17:24:41  <gmaxwell> s/cache/malloc/ :P
3472018-10-24T17:24:52  <BlueMatt> yea.....
3482018-10-24T17:24:57  <BlueMatt> ffs
3492018-10-24T17:25:26  *** bitcoin-git has joined #bitcoin-core-dev
3502018-10-24T17:25:27  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
3512018-10-24T17:25:27  *** bitcoin-git has left #bitcoin-core-dev
3522018-10-24T17:25:36  <luke-jr> well, even if there's another bottleneck, it probably helps free up CPU resources for other processes?
3532018-10-24T17:26:37  <BlueMatt> heh could try running ibd with some other cpu-but-not-memory-intensive process running on the same core on another thread and see if you see a difference lol
3542018-10-24T17:35:34  <luke-jr> hmm, interesting idea.
3552018-10-24T17:36:10  <gmaxwell> or just profile an figure out why its not speeding things up. :P
3562018-10-24T17:37:40  *** Chris_Stewart_5 has quit IRC
3572018-10-24T17:38:57  *** Krellan has quit IRC
3582018-10-24T17:40:24  *** Krellan has joined #bitcoin-core-dev
3592018-10-24T17:59:46  *** michaelfolkson has joined #bitcoin-core-dev
3602018-10-24T18:13:29  *** michaelfolkson has quit IRC
3612018-10-24T18:18:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3622018-10-24T18:19:20  *** cubancorona has joined #bitcoin-core-dev
3632018-10-24T18:24:39  *** satwo has joined #bitcoin-core-dev
3642018-10-24T18:30:57  *** cubancorona has quit IRC
3652018-10-24T18:37:23  *** timothy has quit IRC
3662018-10-24T18:38:50  *** echonaut has joined #bitcoin-core-dev
3672018-10-24T18:39:31  *** ap4lmtree- has joined #bitcoin-core-dev
3682018-10-24T18:39:50  *** brianhoffman_ has joined #bitcoin-core-dev
3692018-10-24T18:40:18  *** Victor_sueca has joined #bitcoin-core-dev
3702018-10-24T18:40:27  *** laurentmt has joined #bitcoin-core-dev
3712018-10-24T18:41:55  *** niska has joined #bitcoin-core-dev
3722018-10-24T18:42:52  *** TheHoliestRoger_ has joined #bitcoin-core-dev
3732018-10-24T18:43:11  *** berndj-blackout has joined #bitcoin-core-dev
3742018-10-24T18:43:33  *** sdaftuar_ has joined #bitcoin-core-dev
3752018-10-24T18:43:48  *** commavir_ has joined #bitcoin-core-dev
3762018-10-24T18:44:05  *** jcorgan_ has joined #bitcoin-core-dev
3772018-10-24T18:44:13  *** andytosh1 has joined #bitcoin-core-dev
3782018-10-24T18:44:29  *** gnusha_ has joined #bitcoin-core-dev
3792018-10-24T18:44:38  *** gwollon has joined #bitcoin-core-dev
3802018-10-24T18:45:02  *** e4xit_ has joined #bitcoin-core-dev
3812018-10-24T18:46:42  *** shinohai_ has joined #bitcoin-core-dev
3822018-10-24T18:46:48  *** bitconner has joined #bitcoin-core-dev
3832018-10-24T18:47:21  *** odk has joined #bitcoin-core-dev
3842018-10-24T18:47:31  *** ccook has joined #bitcoin-core-dev
3852018-10-24T18:47:50  *** CubicEarth_ has joined #bitcoin-core-dev
3862018-10-24T18:48:51  *** Victorsueca has quit IRC
3872018-10-24T18:48:51  *** ap4lmtree has quit IRC
3882018-10-24T18:48:52  *** Soligor has quit IRC
3892018-10-24T18:48:53  *** berndj has quit IRC
3902018-10-24T18:48:53  *** opdenkamp has quit IRC
3912018-10-24T18:48:53  *** newbie-- has quit IRC
3922018-10-24T18:48:53  *** TheHoliestRoger has quit IRC
3932018-10-24T18:48:53  *** brianhoffman has quit IRC
3942018-10-24T18:48:53  *** keymone has quit IRC
3952018-10-24T18:48:53  *** jcorgan has quit IRC
3962018-10-24T18:48:53  *** gwillen has quit IRC
3972018-10-24T18:48:53  *** echonaut14 has quit IRC
3982018-10-24T18:48:53  *** CubicEarth has quit IRC
3992018-10-24T18:48:53  *** e4xit has quit IRC
4002018-10-24T18:48:54  *** andytoshi has quit IRC
4012018-10-24T18:48:54  *** so has quit IRC
4022018-10-24T18:48:54  *** niska` has quit IRC
4032018-10-24T18:48:54  *** commavir has quit IRC
4042018-10-24T18:48:54  *** shinohai has quit IRC
4052018-10-24T18:48:54  *** gnusha has quit IRC
4062018-10-24T18:48:54  *** sdaftuar has quit IRC
4072018-10-24T18:48:54  *** ccook_ has quit IRC
4082018-10-24T18:48:59  *** brianhoffman_ is now known as brianhoffman
4092018-10-24T18:49:10  *** murchandamus1 has joined #bitcoin-core-dev
4102018-10-24T18:49:18  *** Soligor has joined #bitcoin-core-dev
4112018-10-24T18:49:25  *** odk is now known as opdenkamp
4122018-10-24T18:49:32  *** so has joined #bitcoin-core-dev
4132018-10-24T18:49:56  *** keymone has joined #bitcoin-core-dev
4142018-10-24T18:50:53  *** opdenkamp has quit IRC
4152018-10-24T18:51:07  *** bitconner has quit IRC
4162018-10-24T18:51:11  *** opdenkamp has joined #bitcoin-core-dev
4172018-10-24T18:52:23  *** berndj-blackout is now known as berndj
4182018-10-24T19:05:03  *** Chris_Stewart_5 has quit IRC
4192018-10-24T19:07:17  <jnewbery> Just running test_runner and the new progress output is thrilling. Glad we didn't go for the boring spinner option.
4202018-10-24T19:11:42  *** Aaronvan_ has quit IRC
4212018-10-24T19:12:53  *** laurentmt has quit IRC
4222018-10-24T19:13:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4232018-10-24T19:15:44  *** reallll has joined #bitcoin-core-dev
4242018-10-24T19:19:23  *** belcher_ has quit IRC
4252018-10-24T19:19:27  *** reallll is now known as belcher_
4262018-10-24T19:22:31  *** AaronvanW has joined #bitcoin-core-dev
4272018-10-24T19:23:23  <instagibbs> it should make some sort of progressive ascii art
4282018-10-24T19:25:36  *** sdaftuar_ is now known as sdaftuar
4292018-10-24T19:27:14  *** AaronvanW has quit IRC
4302018-10-24T19:30:47  *** sdaftuar has quit IRC
4312018-10-24T19:30:48  *** sdaftuar has joined #bitcoin-core-dev
4322018-10-24T19:58:00  *** michaelfolkson has joined #bitcoin-core-dev
4332018-10-24T20:08:12  *** gwollon is now known as gwillen
4342018-10-24T20:08:43  <instagibbs> https://travis-ci.org/bitcoin/bitcoin/builds/445823485?utm_source=github_status&utm_medium=notification looks like linter is broke on master/0.17
4352018-10-24T20:09:51  <instagibbs> ubuntu flake update apparently
4362018-10-24T20:14:22  <instagibbs> hmm that one is giving some other error, but here's tip of 0.17 https://travis-ci.org/bitcoin/bitcoin/jobs/443960300
4372018-10-24T20:17:21  <instagibbs> looks like pyflakes update causing it https://gitlab.com/pycqa/flake8/commit/527af5c214ef0eccfde3dd58d7ea15e09c483bd3
4382018-10-24T20:23:19  *** Aaronvan_ has joined #bitcoin-core-dev
4392018-10-24T20:23:50  <michagogo> Hm. I just tried fixing https://github.com/bitcoin-core/gitian.sigs/issues/658
4402018-10-24T20:23:56  <michagogo> And it broke even more
4412018-10-24T20:24:25  <michagogo> Anyone have any idea wy?
4422018-10-24T20:24:27  <michagogo> why*
4432018-10-24T20:36:48  *** bitconner has joined #bitcoin-core-dev
4442018-10-24T20:53:01  *** e4xit_ is now known as e4xit
4452018-10-24T20:55:25  *** bitcoin-git has joined #bitcoin-core-dev
4462018-10-24T20:55:25  <bitcoin-git> [bitcoin] instagibbs opened pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
4472018-10-24T20:55:25  *** bitcoin-git has left #bitcoin-core-dev
4482018-10-24T21:00:57  *** Chris_Stewart_5 has quit IRC
4492018-10-24T21:05:45  *** jarthur has quit IRC
4502018-10-24T21:12:45  *** Krellan has quit IRC
4512018-10-24T21:12:47  *** schmidty has quit IRC
4522018-10-24T21:15:21  *** jarthur has joined #bitcoin-core-dev
4532018-10-24T21:15:56  *** jarthur has quit IRC
4542018-10-24T21:18:49  *** ctrlbreak has joined #bitcoin-core-dev
4552018-10-24T21:22:35  *** irc_viewer_test has joined #bitcoin-core-dev
4562018-10-24T21:23:05  *** schmidty has joined #bitcoin-core-dev
4572018-10-24T21:23:29  *** schmidty is now known as Guest12812
4582018-10-24T21:29:08  *** michaelfolkson has quit IRC
4592018-10-24T21:30:26  *** irc_viewer_test has quit IRC
4602018-10-24T21:34:01  *** bitcoin-git has joined #bitcoin-core-dev
4612018-10-24T21:34:01  <bitcoin-git> [bitcoin] instagibbs closed pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
4622018-10-24T21:34:01  *** bitcoin-git has left #bitcoin-core-dev
4632018-10-24T21:36:20  *** michaelfolkson has joined #bitcoin-core-dev
4642018-10-24T21:39:07  *** dqx has joined #bitcoin-core-dev
4652018-10-24T21:39:47  *** Krellan has joined #bitcoin-core-dev
4662018-10-24T21:47:45  *** OzPac has quit IRC
4672018-10-24T21:51:30  *** Victor_sueca has quit IRC
4682018-10-24T21:52:50  *** Victor_sueca has joined #bitcoin-core-dev
4692018-10-24T21:52:58  *** treyzania has quit IRC
4702018-10-24T21:54:41  *** treyzania has joined #bitcoin-core-dev
4712018-10-24T22:05:35  *** satwo has quit IRC
4722018-10-24T22:31:23  *** promag has quit IRC
4732018-10-24T22:33:20  *** promag has joined #bitcoin-core-dev
4742018-10-24T22:33:36  *** profmac has quit IRC
4752018-10-24T22:40:02  *** jcorgan_ has quit IRC
4762018-10-24T22:40:02  *** jcorgan_ has joined #bitcoin-core-dev
4772018-10-24T22:40:13  *** jcorgan_ is now known as jcorgan
4782018-10-24T22:43:17  *** spinza has quit IRC
4792018-10-24T22:43:37  *** michaelfolkson has quit IRC
4802018-10-24T22:44:42  *** michaelsdunn1 has quit IRC
4812018-10-24T22:46:44  *** profmac has joined #bitcoin-core-dev
4822018-10-24T23:02:35  *** spinza has joined #bitcoin-core-dev
4832018-10-24T23:03:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4842018-10-24T23:47:56  *** Krellan has quit IRC
4852018-10-24T23:49:28  *** Krellan has joined #bitcoin-core-dev
4862018-10-24T23:54:47  *** proletesseract has joined #bitcoin-core-dev
4872018-10-24T23:57:25  *** promag has quit IRC