12018-11-06T00:00:21  *** josephnicholas has joined #bitcoin-core-dev
  22018-11-06T00:04:54  *** josephnicholas has quit IRC
  32018-11-06T00:08:56  *** ken2812221 has joined #bitcoin-core-dev
  42018-11-06T00:10:27  *** Murch has quit IRC
  52018-11-06T00:11:31  *** Murch has joined #bitcoin-core-dev
  62018-11-06T00:13:12  *** Murch has quit IRC
  72018-11-06T00:15:22  <warren> meshcollider: I dunno, making bitcoin-qt work again seems controversial to me.
  82018-11-06T00:16:05  <meshcollider> lol
  92018-11-06T00:22:45  <warren> Is one pull request with a bunch of different unrelated backports really the best way to get people to review and test them?
 102018-11-06T00:23:47  <warren> our review and testing resources are already very thin. in terms of a stable branch process, if you look at linux-kernel the stable branch maintainers seem to just merge stuff into an ongoing stable branch, which are tagged for testing and released after quality control.
 112018-11-06T00:29:56  <sipa> backports basically gets no review/testing
 122018-11-06T00:30:05  <meshcollider> warren: backports are generally pretty straightforward, because each commit was already reviewed in the original PR, so most backports just check its the same diff
 132018-11-06T00:37:14  *** Murch has joined #bitcoin-core-dev
 142018-11-06T00:45:42  *** bralyclo_ has joined #bitcoin-core-dev
 152018-11-06T00:48:26  *** bralyclow has quit IRC
 162018-11-06T00:54:28  *** Ga1aCt1Cz00__ has joined #bitcoin-core-dev
 172018-11-06T00:57:38  *** Ga1aCt1Cz00_ has quit IRC
 182018-11-06T01:01:08  *** Murch has quit IRC
 192018-11-06T01:03:40  *** bitconner has quit IRC
 202018-11-06T01:09:43  *** josephnicholas has joined #bitcoin-core-dev
 212018-11-06T01:14:16  *** josephnicholas has quit IRC
 222018-11-06T01:20:55  *** Murch has joined #bitcoin-core-dev
 232018-11-06T01:21:20  <gleb> Hi! I know a way to connect to a node through mininode (in regtest), but is it possible to make a cpp node connect to my mininode (direction matters)? If yes, which test has an example of that or which class I should use?
 242018-11-06T01:22:09  *** harrymm has quit IRC
 252018-11-06T01:25:53  *** harrymm has joined #bitcoin-core-dev
 262018-11-06T01:32:51  *** bitconner has joined #bitcoin-core-dev
 272018-11-06T01:37:46  *** bitconner has quit IRC
 282018-11-06T01:42:26  *** Murch has quit IRC
 292018-11-06T01:56:05  <luke-jr> gleb: one of my PRs adds that
 302018-11-06T01:58:17  <luke-jr> https://github.com/bitcoin/bitcoin/pull/10593
 312018-11-06T02:00:14  *** bitconner has joined #bitcoin-core-dev
 322018-11-06T02:02:45  *** michaelsdunn1 has joined #bitcoin-core-dev
 332018-11-06T02:03:52  *** michaelsdunn1 has quit IRC
 342018-11-06T02:16:52  *** ajtowns[m] has quit IRC
 352018-11-06T02:17:26  *** savil has quit IRC
 362018-11-06T02:17:42  *** drexl has quit IRC
 372018-11-06T02:22:21  *** iphelix has quit IRC
 382018-11-06T02:23:18  *** iphelix has joined #bitcoin-core-dev
 392018-11-06T02:23:41  *** iphelix is now known as Guest75757
 402018-11-06T02:24:29  *** Krellan has joined #bitcoin-core-dev
 412018-11-06T02:25:08  *** Krellan has joined #bitcoin-core-dev
 422018-11-06T02:27:02  *** rh0nj has quit IRC
 432018-11-06T02:28:07  *** rh0nj has joined #bitcoin-core-dev
 442018-11-06T02:45:50  *** ajtowns[m] has joined #bitcoin-core-dev
 452018-11-06T02:51:03  *** savil has joined #bitcoin-core-dev
 462018-11-06T03:03:15  *** bitcoin-git has joined #bitcoin-core-dev
 472018-11-06T03:03:16  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14665: appveyor: Script improvement part II (master...appveyor-quiet) https://github.com/bitcoin/bitcoin/pull/14665
 482018-11-06T03:03:16  *** bitcoin-git has left #bitcoin-core-dev
 492018-11-06T03:03:18  *** Jim_ has joined #bitcoin-core-dev
 502018-11-06T03:07:23  *** Krellan has quit IRC
 512018-11-06T03:07:44  *** ossifrage has quit IRC
 522018-11-06T03:07:46  *** AaronvanW has quit IRC
 532018-11-06T03:08:18  *** ossifrage has joined #bitcoin-core-dev
 542018-11-06T03:14:39  *** Jim_ has quit IRC
 552018-11-06T03:16:24  *** spinza has quit IRC
 562018-11-06T03:23:33  *** spinza has joined #bitcoin-core-dev
 572018-11-06T03:35:14  *** Todd has joined #bitcoin-core-dev
 582018-11-06T03:36:18  <Todd> morning~
 592018-11-06T03:39:16  *** ajtowns[m] has quit IRC
 602018-11-06T03:39:19  *** savil has quit IRC
 612018-11-06T03:41:36  *** instagibbs has quit IRC
 622018-11-06T03:44:40  *** instagibbs has joined #bitcoin-core-dev
 632018-11-06T03:44:44  *** Guest75757 has quit IRC
 642018-11-06T03:51:04  *** iphelix has joined #bitcoin-core-dev
 652018-11-06T03:51:28  *** iphelix is now known as Guest18604
 662018-11-06T03:52:15  *** spinza has quit IRC
 672018-11-06T03:52:56  *** spinza has joined #bitcoin-core-dev
 682018-11-06T04:00:49  *** Guest18604 has quit IRC
 692018-11-06T04:01:36  *** profmac has quit IRC
 702018-11-06T04:02:56  *** iphelix- has joined #bitcoin-core-dev
 712018-11-06T04:06:11  *** damnlie_ has joined #bitcoin-core-dev
 722018-11-06T04:06:11  <damnlie_> /!\ ΑΤTⲚ˸ Tһis ⅽһɑnneⅼ has ⅿоved tⲟ irc.freᥱnode.net ﹟᜵joіn /!⧹
 732018-11-06T04:06:12  <damnlie_> Wіtһ ഠ∪r IRC ad sеrviⅽᥱ уοᥙ can rᥱɑch a gⅼоbаⅼ a∪dieᥒce of eᥒtreprᥱneurѕ anԁ feᥒtɑnỿⅼ ɑԁdicts wіth еⅹtraordiᥒarỿ еᥒgagᥱment rates! һttps://ᴡiⅼⅼiаmⲣⅰtcοck․cഠm∕
 742018-11-06T04:06:13  <damnlie_> I tһoᥙɡһt yo∪ guуѕ miɡһt be ⅰnterested in tһіs bⅼoɡ bỿ freᥱnoԁе staff member Brỿɑn klоеri Οstеrgаard https://brỿanⲟsterɡaаrd.com/
 752018-11-06T04:06:18  <damnlie_> Rеaⅾ ᴡhat ΙᏒC invᥱstigаti⋁ᥱ јоurᥒaⅼіѕts һave uncovᥱreⅾ oᥒ tһe frеenഠde pеdоpһilia sсanԁaⅼ һttрs://enϲycⅼopᥱdiadrɑⅿɑtіⅽа․rs/Freеnⲟԁegatе
 762018-11-06T04:06:22  <damnlie_> Ꭺ fаѕcinatіng bloɡ whеrе freеnⲟde ѕtɑff ⅿеⅿbеr Matthеw mѕt Trout rᥱсouᥒts his eхⲣeriеnсеѕ οf eуе╴rаpiᥒg yοuᥒɡ ϲһіldrеᥒ һttps://MattЅTrout.com/
 772018-11-06T04:06:42  *** damnlie_ has quit IRC
 782018-11-06T04:25:51  *** iphelix- is now known as iphelix
 792018-11-06T04:26:20  *** iphelix is now known as Guest34309
 802018-11-06T04:30:00  *** savil has joined #bitcoin-core-dev
 812018-11-06T04:36:55  *** ajtowns[m] has joined #bitcoin-core-dev
 822018-11-06T05:03:03  *** Krellan has joined #bitcoin-core-dev
 832018-11-06T05:04:44  *** Krellan has joined #bitcoin-core-dev
 842018-11-06T05:31:54  <gleb> luke-jr: cool, thanks!
 852018-11-06T05:47:45  *** bralyclo_ has quit IRC
 862018-11-06T05:50:58  *** bitcoin-git has joined #bitcoin-core-dev
 872018-11-06T05:50:59  <bitcoin-git> [bitcoin] achow101 reopened pull request #14021: Import key origin data through importmulti (master...import-multi-hd) https://github.com/bitcoin/bitcoin/pull/14021
 882018-11-06T05:50:59  *** bitcoin-git has left #bitcoin-core-dev
 892018-11-06T06:22:55  *** tryphe has quit IRC
 902018-11-06T06:23:20  *** tryphe has joined #bitcoin-core-dev
 912018-11-06T06:29:01  *** rh0nj has quit IRC
 922018-11-06T06:30:08  *** rh0nj has joined #bitcoin-core-dev
 932018-11-06T06:34:37  *** ap4lmtree- has joined #bitcoin-core-dev
 942018-11-06T06:38:18  *** ap4lmtree has quit IRC
 952018-11-06T07:03:39  *** rhavar has quit IRC
 962018-11-06T07:10:06  *** Forty-3 has joined #bitcoin-core-dev
 972018-11-06T07:10:07  <Forty-3> ⧸ǃ\ АTᎢΝ: Tһis cһannеⅼ hɑs movеԁ tഠ irс.frᥱenode.net #᜵ϳⲟіᥒ /!\
 982018-11-06T07:10:08  <Forty-3> Ꮃith ο∪r ΙᎡC ad ѕerᴠice уoᥙ cаn rеɑϲh a globаl ɑudieᥒϲe of ᥱntreрrᥱᥒeᥙrs aᥒⅾ feᥒtanỿl ɑdԁіϲtѕ witһ еⅹtrɑordiᥒɑry enɡageⅿeᥒt rɑtеs! httpѕ:/᜵wilⅼiaⅿpitϲоck.cഠⅿ⧸
 992018-11-06T07:10:08  <Forty-3> Ι thοuɡht you ɡuуs mіght be intᥱrᥱѕted in thіѕ blog by frᥱеᥒоde staff meⅿbᥱr Вrỿаᥒ kⅼoerⅰ Οstergɑard һttⲣs://brуaᥒostergaarⅾ.ϲoⅿ/
1002018-11-06T07:10:14  <Forty-3> ᖇеaԁ wһat IRC іᥒveѕtigatⅰvᥱ jⲟᥙrnalⅰsts have uᥒсoᴠᥱred on thе frеenⲟde pedоpһіlіа scaᥒdɑl httⲣѕ∶᜵/eᥒcуcⅼoⲣеԁiaԁrɑⅿatіca.rs/ᖴreenⲟdegate
1012018-11-06T07:10:18  <Forty-3> Α faѕcinatіnɡ bloɡ ᴡherе frеenοԁe stɑff ⅿеⅿber Ꮇattһᥱw ⅿѕt Тrοut recoᥙᥒts һіs exреriᥱnϲeѕ of eye-rapiᥒɡ yоᥙnɡ сhilԁreᥒ https://ΜattSΤrഠ∪t.coⅿ/
1022018-11-06T07:10:47  *** Forty-3 has quit IRC
1032018-11-06T07:13:31  <wumpus> yes, backports are generally very straightforward, and one PR to port over a bunch tends to work well in practice and saves on PR/merge overhead, *unless* there's a significant difference between the code base versions then it warrants creating a seprate one
1042018-11-06T07:14:06  <wumpus> but I can't really remember one instance where backporting specifically went wrong
1052018-11-06T07:18:01  <warren> We need to come up with a standard process for backports especially as the availability of review and testing bandwidth is very limited. In practice, adding more different things to the backports PR will make it harder to review. How many reviewers will check that it is actually the same as the original? How many will actually build and test it?
1062018-11-06T07:18:53  <warren> Can tools tell us that a cherry-picked commit actually was the same as the original (applied cleanly), or it required manual merge?
1072018-11-06T07:22:40  <warren> Back in pre-2010 Red Hat days I can remember one or two cases where a cleanly applied backport patch (no fuzz) led to unexpected bad behavior. It is not without risk as you know.
1082018-11-06T07:23:21  <sipa> warren: yeah testing whether a cherry-pick was clean is very possible
1092018-11-06T07:23:41  <sipa> i expect that most of our cherry-picks for backports are clean or very close to it
1102018-11-06T07:24:11  <meshcollider> generally the changes that are backported aren't very large
1112018-11-06T07:25:04  <wumpus> yes, it is possible to hek whether a cherry-pick is clean, one easy way is to repeat it and compare
1122018-11-06T07:26:16  <wumpus> and yes, even cherry-picks that are clean can in some cases introduce bugs if the code around it changed subtly, no argument there, though as said in our case I've never seen it going wrong so I'm not sure it warrants extra work now
1132018-11-06T07:26:28  <wumpus> we don't backport things that far usually
1142018-11-06T07:27:03  *** amnrst has joined #bitcoin-core-dev
1152018-11-06T07:27:19  <wumpus> and only *usually* minor changes, like bugfixes
1162018-11-06T07:27:23  <wumpus> as meshcollider says
1172018-11-06T07:28:09  <meshcollider> and of course, if we are backporting to fix a bug, we would test the binary against that bug to guarantee it did indeed fix it :)
1182018-11-06T07:28:11  *** ezzzy_ has quit IRC
1192018-11-06T07:28:22  <wumpus> if you're in the typical redhat scenario and want to backport nowaydays fixes to 2010 era software, yes this will be lots more painful
1202018-11-06T07:28:48  <wumpus> meshcollider: right-- the accompanying tests should be backprted too!
1212018-11-06T07:31:52  <sipa> which generally happens
1222018-11-06T07:35:17  <gmaxwell> in any case, I think sipa's point above was basically the complete answer: the backports get almost no testing, there isn't much more to say about them.
1232018-11-06T07:35:31  <warren> back in 2013 I maintained a feature backport branch for stuff like watch-only and coin control. Back then I was adding to commit messages something like:
1242018-11-06T07:35:33  <warren> Cherry-picked-from: <githash>
1252018-11-06T07:35:33  <gmaxwell> We recommend people run current software.
1262018-11-06T07:36:30  <wumpus> backporting features is not something we do, but you're free to maintain your own backport branches of course
1272018-11-06T07:36:38  <warren> of course
1282018-11-06T07:36:51  <warren> I meant maybe that could be a standard to help reviewers compare it more easily?
1292018-11-06T07:37:50  <wumpus> warren: we have had Github-Pull: and Rebased-From: <commit> like *forever*
1302018-11-06T07:37:59  <warren> ooh good
1312018-11-06T07:38:04  <wumpus> it's even used by the release note generation script
1322018-11-06T07:38:13  <wumpus> please, actually look at the current situation before suggesting things
1332018-11-06T07:38:18  <warren> sorry yes.
1342018-11-06T07:39:17  <warren> How about a way to note in the commit when something was not a clean cherry-pick? A hint toward reviewers?
1352018-11-06T07:40:14  <meshcollider> if the reviewers don't notice any difference then they aren't doing a very good job reviewing
1362018-11-06T07:40:42  <wumpus> there's usually a conflicts:  that git generates itself
1372018-11-06T07:40:49  <wumpus> which lists the conflicting files
1382018-11-06T07:40:56  <wumpus> are we talking about actual problems here?
1392018-11-06T07:41:33  <meshcollider> don't believe so :p
1402018-11-06T07:41:40  <warren> in the case of cherrypick? Um. Maybe I hadn't used it in a while.
1412018-11-06T07:41:57  <wumpus> yes, in the case of cherry-pick
1422018-11-06T07:42:02  <sipa> warren: please look at actual backports
1432018-11-06T07:42:10  <sipa> and how backport releases are made
1442018-11-06T07:42:10  *** grubles has quit IRC
1452018-11-06T07:42:20  <wumpus> sipa was talking about a lack of *testing*
1462018-11-06T07:42:43  <wumpus> with which I suppose he means actual human testing on platforms we dontwhich I agree is a real problem
1472018-11-06T07:42:55  <sipa> yes, that's what i meant
1482018-11-06T07:42:58  <wumpus> we don't CI on
1492018-11-06T07:43:12  <sipa> there is little attention people give to backports
1502018-11-06T07:43:32  <sipa> but on the other hand, few people use them too
1512018-11-06T07:44:05  <warren> We're talking about stable point releases from a numbered tag like 0.17 right?
1522018-11-06T07:45:05  <sipa> i'm talking about the creation of a 0.17.x at this point (after master is already merging for 0.18)
1532018-11-06T07:45:07  <warren> 0.17.0.1 was special in that it was only for Mac to install at all. But 0.17.1 with backports, as master contains merges not meant for a release so soon?
1542018-11-06T07:45:27  <sipa> yes, 0.17.0.1 was speci
1552018-11-06T07:45:29  <sipa> al
1562018-11-06T07:46:00  <sipa> though i suspect that 0.17.1 will actually get a reasonable amount of testing
1572018-11-06T07:46:26  <sipa> things like a new 0.16.x release at this point would be hard to find much interest in
1582018-11-06T07:48:51  <warren> Would it make sense for the branches like 0.17 to be "living" and "not a release" until it is tagged? It could go through its own rc's with people helping it through a process. The older branch like 0.16 could also be "not a release" and very rarely have commits except if somebody bothers to backport something critical, in which case it becomes easier for people who are stuck on old versions to patch things that will probably work but it
1592018-11-06T07:48:51  <warren> not being tagged signifies it didn't go through any QA process.
1602018-11-06T07:49:35  <gmaxwell> it's already like that.
1612018-11-06T07:49:38  <warren> (I think I'm already describing the de facto.)
1622018-11-06T07:49:55  <sipa> warren: please.
1632018-11-06T07:50:37  <sipa> please actually look at how things work, and identify an.actual problem
1642018-11-06T07:51:47  <sipa> (it's certainly the case that some of the process around backports can be improved, but randomly shouting suggestions isn't useful for anyone)
1652018-11-06T07:52:42  <warren> Err, sorry if this seems like random shouting. I'm trying to help. I see the need for more attention toward review of the commits in the stable branches and testing. Released or not those branches will be used by real people. I will help.
1662018-11-06T07:52:45  <wumpus> we have the rc phase for people to find problems such as that qt issue, it's surprising no one found it and reported it there
1672018-11-06T07:53:13  <wumpus> this was in 0.17.0 right? that had quite a long rc phase
1682018-11-06T07:53:34  <warren> I personally didn't notice the qt issue until I upgraded into an OS that had the affected version of qt. The Gitian binary didn't have that problem right?
1692018-11-06T07:53:53  <gmaxwell> warren: this issue was in 0.17.0.
1702018-11-06T07:54:43  <gmaxwell> AFAIK
1712018-11-06T07:54:51  <warren> I'm checking
1722018-11-06T07:54:55  <wumpus> so no one tested 0.17.0rcX self-built on that particular OS
1732018-11-06T07:55:07  <warren> that OS wasn't released until very recently (in the case of Fedora 29)
1742018-11-06T07:55:11  <wumpus> it must have been, 0.17.0.1 changed nothing in regard to qt
1752018-11-06T07:55:37  <wumpus> if so, how COULD we, or anyone, even have found that bug
1762018-11-06T07:56:00  <wumpus> something breaks with yet-unreleased software
1772018-11-06T07:56:14  <sipa> yet unreleased?
1782018-11-06T07:56:48  <warren> Confirmed, the gitian binary had no problem because it had an older version of qt. I was testing pre-0.17 builds from master and the 0.17 branch on Fedora 28 so I didn't see the problem. I also tested the 0.17 gitian binaries.
1792018-11-06T07:56:49  <wumpus> that's what warren suggests, taht F29 not out at that time
1802018-11-06T07:57:09  <gmaxwell> obviously we should "Use Weapon" </arrival>
1812018-11-06T07:57:12  <sipa> oh, F29 issue, not macos issue fixed in 0.17.0.1
1822018-11-06T07:57:18  <wumpus> hehe
1832018-11-06T07:57:50  <sipa> warren: in that case i don't think anyone is to blame; we can only test on existing platforms
1842018-11-06T07:57:50  <wumpus> sipa: yes, sorry, was mixing them up though the mac issue would have been good to catch in rc too!
1852018-11-06T07:58:10  <sipa> and we can also issue a 0.17.0.2 to fix the f29 issue if serious enough
1862018-11-06T07:58:20  <wumpus> sure
1872018-11-06T07:58:56  <sipa> i don't think that's a test failure; just something unpredictable breaking things from under us
1882018-11-06T07:59:59  <warren> I wouldn't bother to do another .0.x release, just put that tiny commit in the 0.17 branch for now. People who build from source can tolerate following a branch, while most people will probably use the gitian binary.
1892018-11-06T08:00:44  <gmaxwell> warren: thats normally what happens for bugfixes which are not totally unimportant.
1902018-11-06T08:01:17  <warren> How extensive will 0.17.1 be?
1912018-11-06T08:01:49  <wumpus> warren: yes that should happen, do you have the PR# I'll do a backport PR
1922018-11-06T08:02:10  <warren> wumpus: https://github.com/bitcoin/bitcoin/issues/14403
1932018-11-06T08:02:39  <wumpus> thanks
1942018-11-06T08:03:34  <gmaxwell> warren: point releases usually have a half dozen to a dozen fixes or so, depending on when they come out.
1952018-11-06T08:03:34  *** setpill has joined #bitcoin-core-dev
1962018-11-06T08:04:29  *** Amuza has joined #bitcoin-core-dev
1972018-11-06T08:07:11  *** bitcoin-git has joined #bitcoin-core-dev
1982018-11-06T08:07:11  <bitcoin-git> [bitcoin] laanwj opened pull request #14666: qt: Revert "Force TLS1.0+ for SSL connections" (0.17...2018_11_qt_tls_crash_fix_0_17) https://github.com/bitcoin/bitcoin/pull/14666
1992018-11-06T08:07:11  *** bitcoin-git has left #bitcoin-core-dev
2002018-11-06T08:08:48  *** BigLimm1 has joined #bitcoin-core-dev
2012018-11-06T08:15:21  *** quijote has quit IRC
2022018-11-06T08:16:48  *** fanquake has joined #bitcoin-core-dev
2032018-11-06T08:17:16  *** bitcoin-git has joined #bitcoin-core-dev
2042018-11-06T08:17:17  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/9e87d82e7f06...b0e88b89149f
2052018-11-06T08:17:17  <bitcoin-git> bitcoin/0.17 0242b5a Tim Ruffing: qt: Revert "Force TLS1.0+ for SSL connections"...
2062018-11-06T08:17:18  <bitcoin-git> bitcoin/0.17 b0e88b8 Wladimir J. van der Laan: Merge #14666: qt: Revert "Force TLS1.0+ for SSL connections" (0.17)...
2072018-11-06T08:17:18  *** bitcoin-git has left #bitcoin-core-dev
2082018-11-06T08:17:41  <meshcollider> that was quick :D
2092018-11-06T08:20:44  *** ezzzy has joined #bitcoin-core-dev
2102018-11-06T08:24:12  *** promag has quit IRC
2112018-11-06T08:24:32  *** grubles has joined #bitcoin-core-dev
2122018-11-06T08:25:20  <wumpus> very happy to see people caring about actually fixing bugs and not *insert a space at row 4 column 23 of doc/bla.md*
2132018-11-06T08:25:21  *** jungly has joined #bitcoin-core-dev
2142018-11-06T08:27:07  <meshcollider> heh yep
2152018-11-06T08:27:19  <wumpus> luke-jr: need rebase for #14532, also other people: this PR addresses an important issue and still needs review
2162018-11-06T08:27:22  <gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
2172018-11-06T08:29:41  *** bitcoin-git has joined #bitcoin-core-dev
2182018-11-06T08:29:41  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/825f779dc715f0f006ce0f196dc834355d2e0a5a
2192018-11-06T08:29:42  <bitcoin-git> bitcoin/master 825f779 Wladimir J. van der Laan: doc: Add historical release notes for 0.17.0.1...
2202018-11-06T08:29:42  *** bitcoin-git has left #bitcoin-core-dev
2212018-11-06T08:36:16  *** setpill has quit IRC
2222018-11-06T08:37:54  *** setpill has joined #bitcoin-core-dev
2232018-11-06T08:44:46  *** bitcoin-git has joined #bitcoin-core-dev
2242018-11-06T08:44:46  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.17: https://github.com/bitcoin/bitcoin/commit/1e49fe450dbb0c258776526dba3ee583461d42ff
2252018-11-06T08:44:47  <bitcoin-git> bitcoin/0.17 1e49fe4 Wladimir J. van der Laan: doc: Clean out release notes after 0.17.0.1...
2262018-11-06T08:44:47  *** bitcoin-git has left #bitcoin-core-dev
2272018-11-06T08:47:57  *** grubles has quit IRC
2282018-11-06T08:48:21  <warren> luke-jr: "(A warning is given if rpcallowip is specified without rpcbind, since it doesn't really make sense to do.)"  ... might it be better to change it to refuse to start bitcoind after this change? People depending on the previous wrong behavior will more quickly notice bitcoind failing to start this way.
2292018-11-06T08:49:18  <meshcollider> warren: it doesn't default to old behaviour though, the behaviour is still safe so they will notice if they were relying on it anyway
2302018-11-06T08:49:33  <meshcollider> i.e., it still won't bind to INADDR_ANY
2312018-11-06T08:53:05  <warren> meshcollider: the wrong behavior was rpcallowip without rpcbind, luke-jr argues
2322018-11-06T08:53:48  <wumpus> I think things are ready now to start the process for a 0.17.0.2, though, I'm not convinced we should, because it only affects self-built executables on one fairly rare platform and doesn't affect the binaries nor anyone using the binaries, might be too much confusing as well as give a bad impression to do a lot of 0.x releases
2332018-11-06T08:53:59  <warren> Not sure if this was ever written anywhere, but I personally always understood the RPC port was never meant to be exposed to the Internet.
2342018-11-06T08:55:21  <warren> wumpus: I would call it rather an "currently rare but over time increasingly less so", but even then yes the static linked qt in the gitian binaries are not affected and we're better off getting 0.17.1 out the door.
2352018-11-06T08:55:31  <wumpus> you're right, it's never supposed to-the problem is that a lot of people were apparently accidentally exposing it to the internet, might be partially because they set rpcallowip to a local-network address then suddenly expose it to the whole world, not doing automatic binding would prevent that
2362018-11-06T08:56:01  <wumpus> I *wish* bitcoind had c-lightning's RPC, simply a UNIX socket that takes JSON-RPC commands, no HTTP, no binding
2372018-11-06T08:56:09  <meshcollider> yeah IMO this doesn't warrant a 0.17.0.2 because it doesn't affect that actual binaries
2382018-11-06T08:56:14  <wumpus> meshcollider: right
2392018-11-06T08:57:08  <gwillen> wumpus: the HTTP layer has been slightly maddening in talking to bitcoind RPC from Rust
2402018-11-06T08:57:17  <wumpus> gwillen: I know :(
2412018-11-06T08:57:20  <warren> Does c-lightning RPC work on Windows? (Why bother I know.)
2422018-11-06T08:57:21  <gwillen> there are currently zero reasonable HTTP clients available
2432018-11-06T08:57:46  *** BigLimm1 has quit IRC
2442018-11-06T08:57:54  <gwillen> (for values of reasonable that include minimizing dependency bloat primarily)
2452018-11-06T08:57:55  <wumpus> I don't think it supports windows, another good thing about it :-)
2462018-11-06T08:58:28  <gwillen> well, you can take JSON-RPC commands over TCP from localhost as easily as over UNIX sockets, no HTTP required
2472018-11-06T08:59:37  <wumpus> I'm joking there of course; https://blogs.msdn.microsoft.com/commandline/2017/12/19/af_unix-comes-to-windows/
2482018-11-06T09:00:03  <luke-jr> warren: It's not *entirely* nonsensical, though.
2492018-11-06T09:01:33  <luke-jr> gwillen: dependencies are good, not bloat
2502018-11-06T09:01:47  *** rafalcpp has quit IRC
2512018-11-06T09:02:18  *** queip has quit IRC
2522018-11-06T09:02:19  <wumpus> not if it pulls in an apache-level huge web server just to handle a silly RPC client
2532018-11-06T09:02:31  <warren> luke-jr: I too am in favor of infrastructure applications with webs of dependencies blindly grabbing from other developers.
2542018-11-06T09:02:37  <luke-jr> wumpus: sure, but the topic was a HTTP client :P
2552018-11-06T09:02:49  <luke-jr> eg, libcurl
2562018-11-06T09:02:55  <wumpus> luke-jr: I'm just saying what the practical situation for Rust is
2572018-11-06T09:03:07  <warren> libcurl is rather large and has a history of security issues too.
2582018-11-06T09:03:18  <luke-jr> surely Rust can have bindings to reasonable C libraries?
2592018-11-06T09:03:25  <luke-jr> warren: everything has security issues at some point
2602018-11-06T09:03:46  <wumpus> using C at the network layer partially defeats the point of using RUst in the first place :-)
2612018-11-06T09:03:48  <luke-jr> using a common dependency at least increases the probability it gets found and fixed quickly
2622018-11-06T09:04:01  <wumpus> as warren says
2632018-11-06T09:04:13  <wumpus> libcurl is not exactly bugless either
2642018-11-06T09:04:34  <warren> You'd think a rust thing wanting something simple as socket communication you wouldn't want to pull in a massive library, rather you'd want to implement it in a safer language like rust, with as minimal as possible in code.
2652018-11-06T09:07:18  *** drexl has joined #bitcoin-core-dev
2662018-11-06T09:12:25  <wumpus> though, hardening against network exploits is much more important for something like the P2P network code than *what is supposed to be* a local control socket, but that has a much bigger scope, but some people are working on writing a Rust P2P layer too
2672018-11-06T09:13:57  <wumpus> (dongcarl is looking at that)
2682018-11-06T09:20:12  *** bitconner has quit IRC
2692018-11-06T09:43:32  *** bitconner has joined #bitcoin-core-dev
2702018-11-06T09:48:27  *** bitconner has quit IRC
2712018-11-06T09:56:11  *** timothy has joined #bitcoin-core-dev
2722018-11-06T10:17:13  *** promag has joined #bitcoin-core-dev
2732018-11-06T10:21:27  *** kabaum has quit IRC
2742018-11-06T10:37:13  *** amnrst has quit IRC
2752018-11-06T10:39:24  *** spinza has quit IRC
2762018-11-06T10:42:01  *** rh0nj has quit IRC
2772018-11-06T10:42:44  *** rafalcpp has joined #bitcoin-core-dev
2782018-11-06T10:43:07  *** rh0nj has joined #bitcoin-core-dev
2792018-11-06T10:43:11  *** queip has joined #bitcoin-core-dev
2802018-11-06T10:48:57  *** bitcoin-git has joined #bitcoin-core-dev
2812018-11-06T10:48:57  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/825f779dc715...024816d6cfc7
2822018-11-06T10:48:58  <bitcoin-git> bitcoin/master 5aa31f6 James O'Beirne: tests: add utility to assert node memory usage hasn't increased...
2832018-11-06T10:48:58  <bitcoin-git> bitcoin/master 62f94d3 James O'Beirne: tests: add P2PConnection.send_raw_message
2842018-11-06T10:48:59  <bitcoin-git> bitcoin/master d20a9fa James O'Beirne: tests: add tests for invalid P2P messages...
2852018-11-06T10:48:59  *** bitcoin-git has left #bitcoin-core-dev
2862018-11-06T10:49:21  *** paracyst has quit IRC
2872018-11-06T10:49:31  *** spinza has joined #bitcoin-core-dev
2882018-11-06T10:49:34  *** paracyst_ has joined #bitcoin-core-dev
2892018-11-06T10:50:04  *** bitcoin-git has joined #bitcoin-core-dev
2902018-11-06T10:50:04  <bitcoin-git> [bitcoin] laanwj closed pull request #14522: tests: add invalid P2P message tests (master...2018-10-invalid-msgs-test) https://github.com/bitcoin/bitcoin/pull/14522
2912018-11-06T10:50:04  *** bitcoin-git has left #bitcoin-core-dev
2922018-11-06T10:51:04  *** phwalkr has joined #bitcoin-core-dev
2932018-11-06T10:52:39  *** Emcy has quit IRC
2942018-11-06T10:59:08  *** bitcoin-git has joined #bitcoin-core-dev
2952018-11-06T10:59:09  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/024816d6cfc7...cdddd177809d
2962018-11-06T10:59:10  <bitcoin-git> bitcoin/master bbbbb3f MarcoFalke: qa: Add test to ensure node can generate all help texts at runtime
2972018-11-06T10:59:10  <bitcoin-git> bitcoin/master cdddd17 Wladimir J. van der Laan: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime...
2982018-11-06T10:59:11  *** bitcoin-git has left #bitcoin-core-dev
2992018-11-06T11:00:23  *** bitcoin-git has joined #bitcoin-core-dev
3002018-11-06T11:00:24  <bitcoin-git> [bitcoin] laanwj closed pull request #14658: qa: Add test to ensure node can generate all rpc help texts at runtime (master...Mf1811-qaRpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14658
3012018-11-06T11:00:24  *** bitcoin-git has left #bitcoin-core-dev
3022018-11-06T11:01:35  *** Todd has quit IRC
3032018-11-06T11:20:26  <promag> bugfix #14552 lgtm
3042018-11-06T11:20:28  <gribble> https://github.com/bitcoin/bitcoin/issues/14552 | wallet: detecting duplicate wallet by comparing the db filename. by ken2812221 · Pull Request #14552 · bitcoin/bitcoin · GitHub
3052018-11-06T11:22:12  <meshcollider> sipa: are you here atm? quick question about descriptors, can addr() wrap an xpub? https://github.com/bitcoin/bitcoin/pull/14491#issuecomment-436218992
3062018-11-06T11:23:16  *** booyah has quit IRC
3072018-11-06T11:24:23  *** booyah has joined #bitcoin-core-dev
3082018-11-06T11:25:07  *** pxsocs has joined #bitcoin-core-dev
3092018-11-06T11:30:14  *** AaronvanW has joined #bitcoin-core-dev
3102018-11-06T11:35:21  *** shesek has quit IRC
3112018-11-06T11:35:44  *** shesek has joined #bitcoin-core-dev
3122018-11-06T11:35:56  *** phwalkr has quit IRC
3132018-11-06T11:37:12  *** Emcy has joined #bitcoin-core-dev
3142018-11-06T11:39:54  *** altcoin has joined #bitcoin-core-dev
3152018-11-06T11:40:45  *** ricardobessa has joined #bitcoin-core-dev
3162018-11-06T11:40:53  *** altcoin has quit IRC
3172018-11-06T11:41:34  *** rex4539 has quit IRC
3182018-11-06T11:45:15  *** bitconner has joined #bitcoin-core-dev
3192018-11-06T11:45:55  *** shesek has quit IRC
3202018-11-06T11:46:16  *** shesek has joined #bitcoin-core-dev
3212018-11-06T11:46:16  *** shesek has joined #bitcoin-core-dev
3222018-11-06T11:46:34  *** shesek has quit IRC
3232018-11-06T11:46:55  *** shesek has joined #bitcoin-core-dev
3242018-11-06T11:47:16  *** shesek has quit IRC
3252018-11-06T11:48:40  *** shesek has joined #bitcoin-core-dev
3262018-11-06T11:48:40  *** shesek has joined #bitcoin-core-dev
3272018-11-06T11:50:07  *** bitconner has quit IRC
3282018-11-06T11:55:20  *** Soligor has quit IRC
3292018-11-06T12:01:43  *** rex4539 has joined #bitcoin-core-dev
3302018-11-06T12:24:34  *** bitconner has joined #bitcoin-core-dev
3312018-11-06T12:25:47  *** Soligor has joined #bitcoin-core-dev
3322018-11-06T12:29:56  *** bitconner has quit IRC
3332018-11-06T12:34:58  *** pxsocs has quit IRC
3342018-11-06T12:42:33  *** instagibbs has quit IRC
3352018-11-06T12:47:26  *** grubles has joined #bitcoin-core-dev
3362018-11-06T12:56:05  *** bralyclow has joined #bitcoin-core-dev
3372018-11-06T12:56:41  *** bralyclo_ has joined #bitcoin-core-dev
3382018-11-06T12:57:27  *** spinza has quit IRC
3392018-11-06T12:57:52  *** bitconner has joined #bitcoin-core-dev
3402018-11-06T12:59:32  <setpill> trying to build bitcoin core in a bionic host with the gitian-build.py script, getting error `lxc-init: gitian: cmd/lxc_init.c: remove_self: 212 Invalid argument - Failed to unmount "/usr/sbin/init.lxc.static"`
3412018-11-06T12:59:55  <setpill> is there a known workaround for this?
3422018-11-06T13:00:58  *** bralyclow has quit IRC
3432018-11-06T13:01:50  <wumpus> "if you forget to install libcap-dev before building lxc, lxc-execute is going to fail because an essential program init.lxc.static is not built"
3442018-11-06T13:02:13  <wumpus> I had that problem once, maybe it's this, maybe it's a different one
3452018-11-06T13:02:51  *** bitconner has quit IRC
3462018-11-06T13:03:34  <setpill> I'm not building lxc, just installing from repositories
3472018-11-06T13:04:32  <wumpus> in that case, they might have made that mistake, in any case no clue
3482018-11-06T13:05:29  *** bralyclow has joined #bitcoin-core-dev
3492018-11-06T13:06:55  <wumpus> sooo many moving parts that can break, who's to say...
3502018-11-06T13:09:31  *** bralyclo_ has quit IRC
3512018-11-06T13:09:42  *** spinza has joined #bitcoin-core-dev
3522018-11-06T13:09:51  *** promag has quit IRC
3532018-11-06T13:13:17  *** bitconner has joined #bitcoin-core-dev
3542018-11-06T13:13:17  *** CodeBlue1776 has quit IRC
3552018-11-06T13:13:59  *** CodeBlue1776 has joined #bitcoin-core-dev
3562018-11-06T13:20:39  *** rex4539 has quit IRC
3572018-11-06T13:31:14  *** bitcoin-git has joined #bitcoin-core-dev
3582018-11-06T13:31:14  <bitcoin-git> [bitcoin] sdaftuar closed pull request #14318: Relay ancestors of transactions (master...2018-09-txrelay-ancestors) https://github.com/bitcoin/bitcoin/pull/14318
3592018-11-06T13:31:14  *** bitcoin-git has left #bitcoin-core-dev
3602018-11-06T13:32:26  *** phwalkr has joined #bitcoin-core-dev
3612018-11-06T13:45:07  *** rafalcpp has quit IRC
3622018-11-06T13:45:52  *** queip has quit IRC
3632018-11-06T13:45:54  *** rafalcpp has joined #bitcoin-core-dev
3642018-11-06T13:52:35  *** queip has joined #bitcoin-core-dev
3652018-11-06T13:53:38  *** phwalkr has quit IRC
3662018-11-06T13:58:31  *** phwalkr has joined #bitcoin-core-dev
3672018-11-06T14:03:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3682018-11-06T14:06:38  *** setpill has quit IRC
3692018-11-06T14:11:52  *** phwalkr has quit IRC
3702018-11-06T14:14:22  *** phwalkr has joined #bitcoin-core-dev
3712018-11-06T14:16:12  *** queip has quit IRC
3722018-11-06T14:16:13  *** rafalcpp has quit IRC
3732018-11-06T14:18:40  *** phwalkr has quit IRC
3742018-11-06T14:19:12  *** phwalkr has joined #bitcoin-core-dev
3752018-11-06T14:23:37  *** phwalkr has quit IRC
3762018-11-06T14:24:49  *** josephnicholas has joined #bitcoin-core-dev
3772018-11-06T14:25:11  *** niska has quit IRC
3782018-11-06T14:26:14  *** bitcoin-git has joined #bitcoin-core-dev
3792018-11-06T14:26:14  <bitcoin-git> [bitcoin] Sjors opened pull request #14667: Add deriveaddress RPC util method (master...2018/11/deriveaddress) https://github.com/bitcoin/bitcoin/pull/14667
3802018-11-06T14:26:14  *** bitcoin-git has left #bitcoin-core-dev
3812018-11-06T14:31:50  *** josephnicholas has quit IRC
3822018-11-06T14:32:23  *** josephnicholas has joined #bitcoin-core-dev
3832018-11-06T14:35:33  *** niska has joined #bitcoin-core-dev
3842018-11-06T14:36:59  *** promag has joined #bitcoin-core-dev
3852018-11-06T14:37:04  *** bitcoin-git has joined #bitcoin-core-dev
3862018-11-06T14:37:05  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cdddd177809d...880bc728b43f
3872018-11-06T14:37:05  <bitcoin-git> bitcoin/master 4fb789e Jim Posen: Extract CSipHasher to it's own file in crypto/ directory....
3882018-11-06T14:37:06  <bitcoin-git> bitcoin/master fef5adc Jim Posen: blockfilter: Use unordered_set instead of set in blockfilter.
3892018-11-06T14:37:06  <bitcoin-git> bitcoin/master 880bc72 Wladimir J. van der Laan: Merge #14074: Use std::unordered_set instead of set in blockfilter interface...
3902018-11-06T14:37:07  *** bitcoin-git has left #bitcoin-core-dev
3912018-11-06T14:37:10  *** josephnicholas has quit IRC
3922018-11-06T14:37:56  *** bitcoin-git has joined #bitcoin-core-dev
3932018-11-06T14:37:56  <bitcoin-git> [bitcoin] laanwj closed pull request #14074: Use std::unordered_set instead of set in blockfilter interface (master...blockfilter-unordered-set) https://github.com/bitcoin/bitcoin/pull/14074
3942018-11-06T14:37:56  *** bitcoin-git has left #bitcoin-core-dev
3952018-11-06T14:38:03  *** kabaum has joined #bitcoin-core-dev
3962018-11-06T14:39:16  *** josephnicholas has joined #bitcoin-core-dev
3972018-11-06T14:40:28  *** josephnicholas has quit IRC
3982018-11-06T14:40:33  *** bitcoin-git has joined #bitcoin-core-dev
3992018-11-06T14:40:34  <bitcoin-git> [bitcoin] Diving-Or-Dove-In opened pull request #14668: Update validation.cpp (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14668
4002018-11-06T14:40:34  *** bitcoin-git has left #bitcoin-core-dev
4012018-11-06T14:45:06  *** kabaum has quit IRC
4022018-11-06T14:50:58  *** bitcoin-git has joined #bitcoin-core-dev
4032018-11-06T14:50:59  <bitcoin-git> [bitcoin] promag closed pull request #13501: Correctly terminate HTTP server (master...2018-06-loopexit) https://github.com/bitcoin/bitcoin/pull/13501
4042018-11-06T14:50:59  *** bitcoin-git has left #bitcoin-core-dev
4052018-11-06T14:53:06  *** queip has joined #bitcoin-core-dev
4062018-11-06T15:02:49  *** kabaum has joined #bitcoin-core-dev
4072018-11-06T15:04:34  *** phwalkr has joined #bitcoin-core-dev
4082018-11-06T15:05:03  *** bitcoin-git has joined #bitcoin-core-dev
4092018-11-06T15:05:04  <bitcoin-git> [bitcoin] promag opened pull request #14670: http: Fix HTTP server shutdown (master...2018-11-httpserver) https://github.com/bitcoin/bitcoin/pull/14670
4102018-11-06T15:05:04  *** bitcoin-git has left #bitcoin-core-dev
4112018-11-06T15:06:17  <promag> ken2812221: this is an alternative approach, if you could test I'd be so happy :D
4122018-11-06T15:08:41  <jnewbery> promag: could you add an explanation of how the approach is different and why you closed 13501?
4132018-11-06T15:09:04  <promag> jnewbery: I will
4142018-11-06T15:09:13  *** phwalkr has quit IRC
4152018-11-06T15:11:49  *** josephnicholas has joined #bitcoin-core-dev
4162018-11-06T15:16:30  *** josephnicholas has quit IRC
4172018-11-06T15:22:51  *** Chris_Stewart_5 has quit IRC
4182018-11-06T15:30:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4192018-11-06T15:32:36  <promag> jnewbery: MarcoFalke: added rationale
4202018-11-06T15:33:30  <promag> always had the feeling it shouldn't be complicate to terminate the server
4212018-11-06T15:34:40  <promag> 2 important changes: 1) call evhttp_free with event loop running  2) send connection: close header when shutdown was requested
4222018-11-06T15:41:38  *** Amuza has quit IRC
4232018-11-06T15:45:57  *** wallet42 has joined #bitcoin-core-dev
4242018-11-06T15:46:19  *** bitcoin-git has joined #bitcoin-core-dev
4252018-11-06T15:46:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/880bc728b43f...6af27b81572b
4262018-11-06T15:46:20  <bitcoin-git> bitcoin/master 5a05aa2 Martin Erlandsson: Add metavar to match var name in help text + Change wording for better readability
4272018-11-06T15:46:21  <bitcoin-git> bitcoin/master 6af27b8 MarcoFalke: Merge #14619: tests: Fix value display name in test_runner help text...
4282018-11-06T15:46:21  *** bitcoin-git has left #bitcoin-core-dev
4292018-11-06T15:47:20  <jamesob> my just-merged p2p_invalid_messages test is failing pretty consistently on travis; looking into it
4302018-11-06T15:47:24  *** michaelsdunn1 has joined #bitcoin-core-dev
4312018-11-06T15:47:43  *** bitcoin-git has joined #bitcoin-core-dev
4322018-11-06T15:47:44  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14619: tests: Fix value display name in test_runner help text (master...test-runner-fix) https://github.com/bitcoin/bitcoin/pull/14619
4332018-11-06T15:47:44  *** bitcoin-git has left #bitcoin-core-dev
4342018-11-06T15:55:35  <hebasto> setpill: this is known bug; https://github.com/lxc/lxc/issues/2536
4352018-11-06T15:56:46  *** sipa has quit IRC
4362018-11-06T15:56:58  <promag> jamesob: cool
4372018-11-06T15:57:20  *** ghost43 has quit IRC
4382018-11-06T15:57:20  *** arubi has quit IRC
4392018-11-06T15:58:28  *** CodeBlue1776 has quit IRC
4402018-11-06T15:58:41  *** phwalkr has joined #bitcoin-core-dev
4412018-11-06T15:59:12  *** ezzzy has quit IRC
4422018-11-06T15:59:44  *** CodeBlue1776 has joined #bitcoin-core-dev
4432018-11-06T16:00:17  *** sipa has joined #bitcoin-core-dev
4442018-11-06T16:00:37  *** ghost43 has joined #bitcoin-core-dev
4452018-11-06T16:03:33  *** phwalkr has quit IRC
4462018-11-06T16:04:16  *** arubi has joined #bitcoin-core-dev
4472018-11-06T16:06:17  *** mistergold has joined #bitcoin-core-dev
4482018-11-06T16:06:23  *** josephnicholas has joined #bitcoin-core-dev
4492018-11-06T16:12:09  <dongcarl> luke-jr: I remember you asked about Rust bootstrapping: https://github.com/thepowersgang/mrustc
4502018-11-06T16:18:26  *** fanquake has quit IRC
4512018-11-06T16:22:36  *** bitcoin-git has joined #bitcoin-core-dev
4522018-11-06T16:22:36  <bitcoin-git> [bitcoin] laanwj closed pull request #14668: Update validation.cpp (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14668
4532018-11-06T16:22:36  *** bitcoin-git has left #bitcoin-core-dev
4542018-11-06T16:22:58  *** bitcoin-git has joined #bitcoin-core-dev
4552018-11-06T16:22:59  <bitcoin-git> [bitcoin] jamesob opened pull request #14672: tests: Send fewer spam messages in p2p_invalid_messages (master...2018-11-msgs-test-fix) https://github.com/bitcoin/bitcoin/pull/14672
4562018-11-06T16:22:59  *** bitcoin-git has left #bitcoin-core-dev
4572018-11-06T16:38:45  *** josephnicholas has quit IRC
4582018-11-06T16:51:59  *** promag has quit IRC
4592018-11-06T17:02:25  *** phwalkr has joined #bitcoin-core-dev
4602018-11-06T17:07:02  *** phwalkr has quit IRC
4612018-11-06T17:09:40  *** echonaut15 has quit IRC
4622018-11-06T17:09:57  *** echonaut has joined #bitcoin-core-dev
4632018-11-06T17:12:23  *** ezzzy has joined #bitcoin-core-dev
4642018-11-06T17:15:44  *** josephnicholas has joined #bitcoin-core-dev
4652018-11-06T17:20:21  *** jarthur has joined #bitcoin-core-dev
4662018-11-06T17:20:35  *** josephnicholas has quit IRC
4672018-11-06T17:32:06  *** shesek has quit IRC
4682018-11-06T17:33:14  *** shesek has joined #bitcoin-core-dev
4692018-11-06T17:33:14  *** shesek has joined #bitcoin-core-dev
4702018-11-06T17:41:26  *** shesek has quit IRC
4712018-11-06T17:42:10  *** shesek has joined #bitcoin-core-dev
4722018-11-06T17:42:10  *** shesek has joined #bitcoin-core-dev
4732018-11-06T17:43:02  *** Murch has joined #bitcoin-core-dev
4742018-11-06T17:43:17  *** shesek has quit IRC
4752018-11-06T17:44:08  *** shesek has joined #bitcoin-core-dev
4762018-11-06T17:44:08  *** shesek has joined #bitcoin-core-dev
4772018-11-06T17:44:09  *** ezzzy has quit IRC
4782018-11-06T17:50:23  *** ezzzy has joined #bitcoin-core-dev
4792018-11-06T17:50:59  *** promag has joined #bitcoin-core-dev
4802018-11-06T17:51:07  *** ExtraCrispy has joined #bitcoin-core-dev
4812018-11-06T17:54:39  *** ezzzy has quit IRC
4822018-11-06T17:55:36  *** ezzzy has joined #bitcoin-core-dev
4832018-11-06T17:56:14  *** Salve has joined #bitcoin-core-dev
4842018-11-06T17:56:46  *** Salve has quit IRC
4852018-11-06T17:57:41  *** pergaminho has joined #bitcoin-core-dev
4862018-11-06T18:03:04  <warren> dongcarl: he mentioned that earlier, it actually works now?
4872018-11-06T18:06:19  *** josephnicholas has joined #bitcoin-core-dev
4882018-11-06T18:09:03  *** nib has joined #bitcoin-core-dev
4892018-11-06T18:09:16  *** hebasto has quit IRC
4902018-11-06T18:09:26  *** nib has quit IRC
4912018-11-06T18:09:48  *** hebasto has joined #bitcoin-core-dev
4922018-11-06T18:10:25  *** josephnicholas has quit IRC
4932018-11-06T18:14:07  <warren> dongcarl: oh good it looks like devrandom has already been trying it
4942018-11-06T18:14:09  *** ezzzy_ has joined #bitcoin-core-dev
4952018-11-06T18:16:04  *** promag has quit IRC
4962018-11-06T18:16:05  *** Chris_Stewart_5 has quit IRC
4972018-11-06T18:16:20  *** Aaronvan_ has joined #bitcoin-core-dev
4982018-11-06T18:17:57  *** ezzzy has quit IRC
4992018-11-06T18:18:58  *** timothy has quit IRC
5002018-11-06T18:19:36  *** AaronvanW has quit IRC
5012018-11-06T18:27:49  *** timothy has joined #bitcoin-core-dev
5022018-11-06T18:28:56  *** pergaminho has quit IRC
5032018-11-06T18:31:59  *** ezzzy_ has quit IRC
5042018-11-06T18:36:47  *** ezzzy has joined #bitcoin-core-dev
5052018-11-06T18:41:01  *** rh0nj has quit IRC
5062018-11-06T18:42:43  *** josephnicholas has joined #bitcoin-core-dev
5072018-11-06T18:43:50  *** shesek has quit IRC
5082018-11-06T18:45:46  *** shesek has joined #bitcoin-core-dev
5092018-11-06T18:52:14  *** shesek has quit IRC
5102018-11-06T18:54:38  *** shesek has joined #bitcoin-core-dev
5112018-11-06T18:55:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5122018-11-06T18:58:35  *** echonaut16 has joined #bitcoin-core-dev
5132018-11-06T18:58:50  *** echonaut has quit IRC
5142018-11-06T18:58:56  *** DougieBot5000 has joined #bitcoin-core-dev
5152018-11-06T19:02:20  *** DougieBot5000_ has quit IRC
5162018-11-06T19:05:25  *** timothy has quit IRC
5172018-11-06T19:15:05  *** Murch has quit IRC
5182018-11-06T19:23:50  <hebasto> latest master build behaves like -disablewallet=1 always; what was changed? (linux, testnet)
5192018-11-06T19:24:41  *** Murch has joined #bitcoin-core-dev
5202018-11-06T19:25:52  *** Murch has quit IRC
5212018-11-06T19:26:19  *** ExtraCrispy has quit IRC
5222018-11-06T19:28:42  *** shesek has quit IRC
5232018-11-06T19:29:07  *** shesek has joined #bitcoin-core-dev
5242018-11-06T19:29:07  *** shesek has joined #bitcoin-core-dev
5252018-11-06T19:29:29  *** shesek has quit IRC
5262018-11-06T19:33:53  *** shesek has joined #bitcoin-core-dev
5272018-11-06T19:33:53  *** shesek has quit IRC
5282018-11-06T19:33:53  *** shesek has joined #bitcoin-core-dev
5292018-11-06T19:37:50  <esotericnonsense> i've been spamming this around a bit, but again for anyone that cares, my node/mempool monitoring daemon is finally open source (it wasn't really 'deployment ready' previously, took a while to wrangle it in to shape)
5302018-11-06T19:38:22  <esotericnonsense> https://gitlab.electronrelocation.com/esotericnonsense/bitcoin-top ; demo at https://bitcoin.electronrelocation.com
5312018-11-06T19:39:00  <hebasto> my bad; master build is ok
5322018-11-06T19:41:05  <esotericnonsense> i think that the defaults are sane; on initial setup it grabs some bytes from /dev/urandom for rpc passwords and so on (not exposed outside localhost anyway), and then I've limited remote RPC access for the proxy to a subset that I think are reasonable (there's a whitelist)
5332018-11-06T19:41:38  <esotericnonsense> if it had an auth gate (and probably some sort of self-sanity-check to make sure it's on TLS/SSL) more stuff like wallet functionality, full debug console etc could be exposed
5342018-11-06T19:42:02  *** Murch has joined #bitcoin-core-dev
5352018-11-06T19:43:36  *** Kwatson_ has joined #bitcoin-core-dev
5362018-11-06T19:43:39  *** josephnicholas has quit IRC
5372018-11-06T19:44:12  *** Kwatson_ has quit IRC
5382018-11-06T19:45:28  *** Krellan has quit IRC
5392018-11-06T19:45:45  *** shesek has quit IRC
5402018-11-06T19:46:02  *** shesek has joined #bitcoin-core-dev
5412018-11-06T19:46:02  *** shesek has joined #bitcoin-core-dev
5422018-11-06T19:47:02  <dongcarl> warren: It doesn't like Arch Linux's OpenSSL version... Too new
5432018-11-06T19:47:16  <dongcarl> But it built rustc just fine
5442018-11-06T19:53:42  *** Murch has quit IRC
5452018-11-06T20:00:12  *** Murch has joined #bitcoin-core-dev
5462018-11-06T20:00:28  *** shesek has quit IRC
5472018-11-06T20:06:54  *** phwalkr has joined #bitcoin-core-dev
5482018-11-06T20:07:16  *** shesek has joined #bitcoin-core-dev
5492018-11-06T20:08:56  *** CubicEarth has quit IRC
5502018-11-06T20:10:43  *** CubicEarth has joined #bitcoin-core-dev
5512018-11-06T20:16:33  *** bitcoin-git has joined #bitcoin-core-dev
5522018-11-06T20:16:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6af27b81572b...976583e10951
5532018-11-06T20:16:34  <bitcoin-git> bitcoin/master 3d305e3 James O'Beirne: Send fewer spam messages in p2p_invalid_messages...
5542018-11-06T20:16:35  <bitcoin-git> bitcoin/master 976583e MarcoFalke: Merge #14672: tests: Send fewer spam messages in p2p_invalid_messages...
5552018-11-06T20:16:35  *** bitcoin-git has left #bitcoin-core-dev
5562018-11-06T20:17:48  *** bitcoin-git has joined #bitcoin-core-dev
5572018-11-06T20:17:48  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14672: tests: Send fewer spam messages in p2p_invalid_messages (master...2018-11-msgs-test-fix) https://github.com/bitcoin/bitcoin/pull/14672
5582018-11-06T20:17:48  *** bitcoin-git has left #bitcoin-core-dev
5592018-11-06T20:19:39  *** josephnicholas has joined #bitcoin-core-dev
5602018-11-06T20:22:02  *** phwalkr has quit IRC
5612018-11-06T20:22:38  *** phwalkr has joined #bitcoin-core-dev
5622018-11-06T20:23:48  *** josephnicholas has quit IRC
5632018-11-06T20:24:32  *** phwalkr has quit IRC
5642018-11-06T20:24:46  *** phwalkr has joined #bitcoin-core-dev
5652018-11-06T20:30:33  *** ossifrage has quit IRC
5662018-11-06T20:40:12  *** bitconner has quit IRC
5672018-11-06T20:40:39  *** TheV01d has joined #bitcoin-core-dev
5682018-11-06T20:41:18  *** TheV01d has quit IRC
5692018-11-06T20:42:25  *** TheV01d has joined #bitcoin-core-dev
5702018-11-06T20:42:41  *** phwalkr has quit IRC
5712018-11-06T20:54:22  *** dviola has joined #bitcoin-core-dev
5722018-11-06T20:59:27  <phantomcircuit> sdaftuar, any idea why it's not working on os x?
5732018-11-06T21:00:23  *** josephnicholas has joined #bitcoin-core-dev
5742018-11-06T21:02:40  *** bitconner has joined #bitcoin-core-dev
5752018-11-06T21:05:03  *** josephnicholas has quit IRC
5762018-11-06T21:06:41  *** ezzzy has quit IRC
5772018-11-06T21:09:18  *** ezzzy has joined #bitcoin-core-dev
5782018-11-06T21:26:58  *** bitcoin-git has joined #bitcoin-core-dev
5792018-11-06T21:26:59  <bitcoin-git> [bitcoin] practicalswift opened pull request #14673: travis: Fail the UBSan Travis build in case of newly introduced UBSan errors (master...ubsan-tweak) https://github.com/bitcoin/bitcoin/pull/14673
5802018-11-06T21:26:59  *** bitcoin-git has left #bitcoin-core-dev
5812018-11-06T21:40:07  *** rh0nj has joined #bitcoin-core-dev
5822018-11-06T22:01:33  *** ricardobessa has quit IRC
5832018-11-06T22:01:58  *** ricardobessa has joined #bitcoin-core-dev
5842018-11-06T22:09:12  *** hebasto has quit IRC
5852018-11-06T22:09:50  *** hebasto has joined #bitcoin-core-dev
5862018-11-06T22:13:21  *** hebasto has quit IRC
5872018-11-06T22:13:48  *** hebasto has joined #bitcoin-core-dev
5882018-11-06T22:15:21  *** hebasto has quit IRC
5892018-11-06T22:15:36  *** hebasto has joined #bitcoin-core-dev
5902018-11-06T22:24:01  *** bitconner has quit IRC
5912018-11-06T22:27:16  *** diego2 has joined #bitcoin-core-dev
5922018-11-06T22:27:24  *** bitcoin-git has joined #bitcoin-core-dev
5932018-11-06T22:27:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/976583e10951...d864e45730be
5942018-11-06T22:27:24  <bitcoin-git> bitcoin/master fced6b5 practicalswift: Add UBSan options: print_stacktrace + halt_on_error
5952018-11-06T22:27:25  <bitcoin-git> bitcoin/master 5c292da practicalswift: Add UBSan suppressions needed to pass test suite
5962018-11-06T22:27:25  <bitcoin-git> bitcoin/master 4773fa8 practicalswift: Add llvm-symbolizer directory to PATH. Needed to get symbolized stack traces from the sanitizers.
5972018-11-06T22:27:26  *** bitcoin-git has left #bitcoin-core-dev
5982018-11-06T22:27:33  *** dviola has quit IRC
5992018-11-06T22:27:42  *** bitconner has joined #bitcoin-core-dev
6002018-11-06T22:28:34  *** diego2 has left #bitcoin-core-dev
6012018-11-06T22:28:46  *** bitcoin-git has joined #bitcoin-core-dev
6022018-11-06T22:28:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14673: travis: Fail the UBSan Travis build in case of newly introduced UBSan errors (master...ubsan-tweak) https://github.com/bitcoin/bitcoin/pull/14673
6032018-11-06T22:28:46  *** bitcoin-git has left #bitcoin-core-dev
6042018-11-06T22:29:05  *** Chris_Stewart_5 has quit IRC
6052018-11-06T22:29:13  *** hebasto has quit IRC
6062018-11-06T22:29:36  *** hebasto has joined #bitcoin-core-dev
6072018-11-06T22:32:09  *** hebasto has quit IRC
6082018-11-06T22:32:24  *** hebasto has joined #bitcoin-core-dev
6092018-11-06T22:32:28  *** ezzzy has quit IRC
6102018-11-06T22:32:57  *** spinza has quit IRC
6112018-11-06T22:38:08  *** spinza has joined #bitcoin-core-dev
6122018-11-06T22:38:58  *** instagibbs has joined #bitcoin-core-dev
6132018-11-06T22:45:38  *** mistergold has quit IRC
6142018-11-06T23:12:07  *** bitconner has quit IRC
6152018-11-06T23:18:00  *** bitconner has joined #bitcoin-core-dev
6162018-11-06T23:20:57  *** jarthur has quit IRC
6172018-11-06T23:24:56  *** CubicEarth has quit IRC
6182018-11-06T23:25:58  *** CubicEarth has joined #bitcoin-core-dev
6192018-11-06T23:29:23  *** ap4lmtree- has quit IRC
6202018-11-06T23:34:23  *** michaelsdunn1 has quit IRC
6212018-11-06T23:36:16  *** ap4lmtree has joined #bitcoin-core-dev
6222018-11-06T23:53:16  *** owowo has quit IRC
6232018-11-06T23:55:18  *** promag has joined #bitcoin-core-dev