12018-11-07T00:09:21  *** bitcoin-git has joined #bitcoin-core-dev
  22018-11-07T00:09:22  <bitcoin-git> [bitcoin] rodasmith opened pull request #14674: Let systemd bitcoind write to /etc/bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14674
  32018-11-07T00:09:22  *** bitcoin-git has left #bitcoin-core-dev
  42018-11-07T00:32:29  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
  52018-11-07T00:35:30  *** Ga1aCt1Cz00__ has quit IRC
  62018-11-07T00:50:36  *** spinza has quit IRC
  72018-11-07T00:55:46  *** spinza has joined #bitcoin-core-dev
  82018-11-07T00:57:27  *** ossifrage has joined #bitcoin-core-dev
  92018-11-07T01:09:13  *** ossifrage has quit IRC
 102018-11-07T01:09:44  *** ossifrage has joined #bitcoin-core-dev
 112018-11-07T01:21:53  *** murrayn_ has joined #bitcoin-core-dev
 122018-11-07T01:25:28  *** murrayn has quit IRC
 132018-11-07T01:29:14  *** Krellan has joined #bitcoin-core-dev
 142018-11-07T01:32:05  *** Krellan has joined #bitcoin-core-dev
 152018-11-07T01:36:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 162018-11-07T01:38:04  *** kabaum has quit IRC
 172018-11-07T01:38:37  *** rex4539 has joined #bitcoin-core-dev
 182018-11-07T01:40:42  *** kabaum has joined #bitcoin-core-dev
 192018-11-07T01:47:19  *** kabaum has quit IRC
 202018-11-07T01:52:46  *** kabaum has joined #bitcoin-core-dev
 212018-11-07T01:55:59  *** ghost43 has quit IRC
 222018-11-07T01:56:11  *** ghost43 has joined #bitcoin-core-dev
 232018-11-07T02:03:31  *** Chris_Stewart_5 has quit IRC
 242018-11-07T02:12:04  *** Murch has quit IRC
 252018-11-07T02:51:49  *** Krellan_ has joined #bitcoin-core-dev
 262018-11-07T02:52:32  *** instagibbs has quit IRC
 272018-11-07T02:54:52  *** Krellan_ has quit IRC
 282018-11-07T02:55:56  *** Krellan has quit IRC
 292018-11-07T03:00:07  *** ricardobessa has quit IRC
 302018-11-07T03:00:59  *** bitcoin-git has joined #bitcoin-core-dev
 312018-11-07T03:00:59  <bitcoin-git> [bitcoin] ken2812221 closed pull request #14655: qt: remove unused SECURE style (master...qt-unused-secure) https://github.com/bitcoin/bitcoin/pull/14655
 322018-11-07T03:00:59  *** bitcoin-git has left #bitcoin-core-dev
 332018-11-07T03:01:35  *** grubles has quit IRC
 342018-11-07T03:02:03  *** grubles has joined #bitcoin-core-dev
 352018-11-07T03:11:54  <promag> jamesob: https://travis-ci.org/bitcoin/bitcoin/jobs/451688699
 362018-11-07T03:33:21  *** owowo has joined #bitcoin-core-dev
 372018-11-07T03:33:43  *** promag has quit IRC
 382018-11-07T03:38:17  *** instagibbs has joined #bitcoin-core-dev
 392018-11-07T03:45:21  *** Aaronvan_ has quit IRC
 402018-11-07T03:45:59  *** AaronvanW has joined #bitcoin-core-dev
 412018-11-07T03:50:01  *** AaronvanW has quit IRC
 422018-11-07T03:51:39  *** murrayn_ has quit IRC
 432018-11-07T03:51:58  *** murrayn has joined #bitcoin-core-dev
 442018-11-07T03:55:59  *** AaronvanW has joined #bitcoin-core-dev
 452018-11-07T04:00:28  *** AaronvanW has quit IRC
 462018-11-07T04:16:18  *** bitconner has quit IRC
 472018-11-07T04:16:59  *** bitconner has joined #bitcoin-core-dev
 482018-11-07T04:21:39  *** bitconner has quit IRC
 492018-11-07T04:27:46  *** bitcoin-git has joined #bitcoin-core-dev
 502018-11-07T04:27:46  <bitcoin-git> [bitcoin] rodasmith closed pull request #14674: Let systemd bitcoind write to /etc/bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14674
 512018-11-07T04:27:46  *** bitcoin-git has left #bitcoin-core-dev
 522018-11-07T05:21:27  *** bralyclow has quit IRC
 532018-11-07T05:28:33  *** bitconner has joined #bitcoin-core-dev
 542018-11-07T05:30:08  *** bralyclow has joined #bitcoin-core-dev
 552018-11-07T05:31:12  *** bralyclow has quit IRC
 562018-11-07T05:32:21  *** altcoin has joined #bitcoin-core-dev
 572018-11-07T05:34:51  *** altcoin has quit IRC
 582018-11-07T06:06:09  *** bitconner has quit IRC
 592018-11-07T06:10:01  *** rh0nj has quit IRC
 602018-11-07T06:11:07  *** rh0nj has joined #bitcoin-core-dev
 612018-11-07T06:50:58  *** Bullitje has joined #bitcoin-core-dev
 622018-11-07T06:54:28  *** Bullit has quit IRC
 632018-11-07T06:58:11  *** AaronvanW has joined #bitcoin-core-dev
 642018-11-07T07:03:13  *** AaronvanW has quit IRC
 652018-11-07T07:05:12  <warren> dongcarl: huzzah
 662018-11-07T07:12:01  *** martinus has joined #bitcoin-core-dev
 672018-11-07T07:19:15  <hebasto> wumpus: MarcoFalke: ethic/testing/QA question. If one's PR (e.g., #14123) contains cherry-picked commits from my PR should I avoid ACKing such PR?
 682018-11-07T07:19:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14123 | gui: Add GUIUtil::bringToFront by promag · Pull Request #14123 · bitcoin/bitcoin · GitHub
 692018-11-07T07:30:07  *** martinus has quit IRC
 702018-11-07T08:05:23  *** ezzzy has joined #bitcoin-core-dev
 712018-11-07T08:08:12  *** setpill has joined #bitcoin-core-dev
 722018-11-07T08:12:17  <sipa> hebasto: feel free to ack
 732018-11-07T08:13:10  *** Krellan_ has joined #bitcoin-core-dev
 742018-11-07T08:14:17  <hebasto> sipa: ty
 752018-11-07T08:24:05  <wumpus> esotericnonsense: nice!
 762018-11-07T08:24:45  <wumpus> hebasto: no, you can still review the rest, you could say you haven't reviewed commit XXX because it's your own
 772018-11-07T08:44:28  *** phwalkr has joined #bitcoin-core-dev
 782018-11-07T08:47:01  <hebasto> wumpus: ok
 792018-11-07T08:53:53  <luke-jr> someone looking for help with -rpcallowip in #bitcoin right now FYI
 802018-11-07T08:59:11  *** todd has joined #bitcoin-core-dev
 812018-11-07T09:05:33  *** promag has joined #bitcoin-core-dev
 822018-11-07T09:34:57  <promag> wumpus: could you look at #14670, esp the PR description. I think this is it XD
 832018-11-07T09:34:59  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
 842018-11-07T09:35:45  *** promag has quit IRC
 852018-11-07T09:36:59  *** timothy has joined #bitcoin-core-dev
 862018-11-07T09:42:07  *** DougieBot5000 has quit IRC
 872018-11-07T09:42:37  *** DougieBot5000 has joined #bitcoin-core-dev
 882018-11-07T09:44:47  *** jungly has quit IRC
 892018-11-07T09:45:05  *** dqx has joined #bitcoin-core-dev
 902018-11-07T09:45:58  *** jungly has joined #bitcoin-core-dev
 912018-11-07T09:53:56  *** vishwas has joined #bitcoin-core-dev
 922018-11-07T09:55:01  <vishwas> hi
 932018-11-07T10:00:12  *** Krellan_ has quit IRC
 942018-11-07T10:02:53  *** spinza has quit IRC
 952018-11-07T10:06:31  *** promag has joined #bitcoin-core-dev
 962018-11-07T10:08:01  *** spinza has joined #bitcoin-core-dev
 972018-11-07T10:08:13  *** shesek has quit IRC
 982018-11-07T10:08:45  *** shesek has joined #bitcoin-core-dev
 992018-11-07T10:11:34  <vishwas> hey can some help me with this https://bitcoin.stackexchange.com/questions/80782/converting-raw-scriptpubkey-to-readable-format ?  thanks!
1002018-11-07T10:16:36  *** shesek has quit IRC
1012018-11-07T10:17:02  *** shesek has joined #bitcoin-core-dev
1022018-11-07T10:17:30  <gwillen> vishwas: you should try to get your debugger to print it as a hex string
1032018-11-07T10:17:38  <gwillen> if you get that you can pass it to the "decodescript" RPC
1042018-11-07T10:18:58  <gwillen> note that scriptPubKey in the structure there is a C++ vector object, you really can't do much by poking around inside it
1052018-11-07T10:18:59  *** todd has quit IRC
1062018-11-07T10:19:20  <gwillen> all that "direct" and "indirect" stuff is internal implementation details of C++ vectors
1072018-11-07T10:22:17  <vishwas> thanks gwillen let me try that.
1082018-11-07T10:30:57  *** shesek has quit IRC
1092018-11-07T10:31:30  *** shesek has joined #bitcoin-core-dev
1102018-11-07T10:31:30  *** shesek has joined #bitcoin-core-dev
1112018-11-07T10:35:48  <vishwas> @gwillen ; one question, so when the UTXO finally gets stored in to the block, this vector object should get transformed into string ?
1122018-11-07T10:36:34  <vishwas> or its gets stored in this form only.?
1132018-11-07T10:37:21  *** shesek has quit IRC
1142018-11-07T10:37:53  *** shesek has joined #bitcoin-core-dev
1152018-11-07T10:37:53  *** shesek has joined #bitcoin-core-dev
1162018-11-07T10:46:13  *** shesek has quit IRC
1172018-11-07T10:47:23  *** shesek has joined #bitcoin-core-dev
1182018-11-07T11:00:55  *** AaronvanW has joined #bitcoin-core-dev
1192018-11-07T11:03:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1202018-11-07T11:05:02  *** rh0nj has quit IRC
1212018-11-07T11:05:32  *** AaronvanW has quit IRC
1222018-11-07T11:06:08  *** rh0nj has joined #bitcoin-core-dev
1232018-11-07T11:16:02  *** Guyver2 has joined #bitcoin-core-dev
1242018-11-07T11:29:27  *** Chris_Stewart_5 has quit IRC
1252018-11-07T11:42:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1262018-11-07T11:42:59  *** phwalkr has quit IRC
1272018-11-07T12:27:01  *** josephnicholas has joined #bitcoin-core-dev
1282018-11-07T12:30:08  *** josephnicholas has quit IRC
1292018-11-07T12:30:46  *** josephnicholas has joined #bitcoin-core-dev
1302018-11-07T12:30:46  <setpill> hrm. does the gitian build process check the integrity of the osslsigncode tarfile downloaded from sourceforge in any way?
1312018-11-07T12:31:10  <setpill> or the patch downloaded from bitcoincore.org for that matter...
1322018-11-07T12:33:11  *** bralyclow has joined #bitcoin-core-dev
1332018-11-07T12:39:55  <gmaxwell> setpill: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-win-signer.yml#L23
1342018-11-07T12:43:57  <setpill> ah, expected them in the script that downloads them, thanks
1352018-11-07T12:44:09  *** spinza has quit IRC
1362018-11-07T12:51:17  *** goosie has joined #bitcoin-core-dev
1372018-11-07T12:56:31  *** vishwas has quit IRC
1382018-11-07T12:58:19  *** rafalcpp has joined #bitcoin-core-dev
1392018-11-07T13:01:40  *** AaronvanW has joined #bitcoin-core-dev
1402018-11-07T13:01:42  *** shesek has quit IRC
1412018-11-07T13:02:45  *** shesek has joined #bitcoin-core-dev
1422018-11-07T13:04:15  *** shesek has quit IRC
1432018-11-07T13:04:35  *** Chris_Stewart_5 has quit IRC
1442018-11-07T13:05:55  *** AaronvanW has quit IRC
1452018-11-07T13:07:08  *** shesek has joined #bitcoin-core-dev
1462018-11-07T13:10:15  *** spinza has joined #bitcoin-core-dev
1472018-11-07T13:10:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1482018-11-07T13:24:31  *** Chris_Stewart_5 has quit IRC
1492018-11-07T13:25:30  *** AaronvanW has joined #bitcoin-core-dev
1502018-11-07T13:31:26  *** AaronvanW has quit IRC
1512018-11-07T13:32:16  *** AaronvanW has joined #bitcoin-core-dev
1522018-11-07T13:39:13  *** promag has quit IRC
1532018-11-07T13:43:56  *** watchtower has joined #bitcoin-core-dev
1542018-11-07T13:48:12  *** belcher has joined #bitcoin-core-dev
1552018-11-07T13:48:39  *** watchtower has quit IRC
1562018-11-07T13:50:59  *** ott0disk has joined #bitcoin-core-dev
1572018-11-07T13:51:48  *** JackH has joined #bitcoin-core-dev
1582018-11-07T14:00:22  *** setpill has quit IRC
1592018-11-07T14:04:14  *** Tralfaz has joined #bitcoin-core-dev
1602018-11-07T14:04:23  *** watchtower has joined #bitcoin-core-dev
1612018-11-07T14:10:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1622018-11-07T14:22:48  *** ott0disk has quit IRC
1632018-11-07T14:23:16  *** bralyclow has quit IRC
1642018-11-07T14:26:50  *** promag has joined #bitcoin-core-dev
1652018-11-07T14:27:26  *** bralyclow has joined #bitcoin-core-dev
1662018-11-07T14:27:28  *** YSqTU2XbB has joined #bitcoin-core-dev
1672018-11-07T14:36:11  *** YSqTU2XbB has quit IRC
1682018-11-07T14:45:56  *** watchtower has quit IRC
1692018-11-07T14:47:11  *** CodeBlue1776 has quit IRC
1702018-11-07T14:49:09  *** CodeBlue1776 has joined #bitcoin-core-dev
1712018-11-07T15:01:03  *** phwalkr has joined #bitcoin-core-dev
1722018-11-07T15:21:03  *** watchtower has joined #bitcoin-core-dev
1732018-11-07T15:27:25  *** Scipio has joined #bitcoin-core-dev
1742018-11-07T15:27:31  <instagibbs> in functional tests is there a nice way to send coinbase outputs to p2pk as per `generate`?
1752018-11-07T15:27:37  <instagibbs> now that generate is gone
1762018-11-07T15:28:38  <instagibbs> I guess s/functional tests/rpc/
1772018-11-07T15:34:56  <provoostenator> Can someone elaborate on the difference between a FlatSigningProvider and a HidingSigningProvider and why only the latter has a working GetKeyOrigin?
1782018-11-07T15:36:13  <sipa> provoostenator: FlatSigningProvider provides the data stored in fields in the object itself
1792018-11-07T15:36:52  <sipa> it's what you use if you just have a bunch of keys, pubkeys, scripts, and origins, and want to make it available to the signing code
1802018-11-07T15:37:39  <sipa> HidingSigningProvider takes as input *another* signingprovider, but hides certain information from it (in particular, private keys)
1812018-11-07T15:38:23  *** phwalkr has quit IRC
1822018-11-07T15:38:49  <sipa> and what do you mean with "no working GetKeyOrigin" ?
1832018-11-07T15:39:09  *** michaelsdunn1 has joined #bitcoin-core-dev
1842018-11-07T15:40:25  <provoostenator> sipa: in the WIP hardware wallet support branch I find that walletcreatefundedpbst no longer adds origin info. Trying to triangulate why: https://github.com/achow101/bitcoin/tree/hww
1852018-11-07T15:41:23  <sipa> provoostenator: you're setting the flag for hd paths to true, right?
1862018-11-07T15:41:47  <provoostenator> This in the case of a wallet with no private keys. Yes, the bip32 bool at the end is true
1872018-11-07T15:43:28  <provoostenator> I find that only HidingSigningProvider::GetKeyOrigin is called, which afaik can only return false and doesn't actual set the info field.
1882018-11-07T15:43:45  <sipa> huh
1892018-11-07T15:44:19  <sipa> why do you think so?
1902018-11-07T15:45:18  <jamesob> merge beg: https://github.com/bitcoin/bitcoin/pull/14457
1912018-11-07T15:56:18  *** bitcoin-git has joined #bitcoin-core-dev
1922018-11-07T15:56:18  <bitcoin-git> [bitcoin] instagibbs opened pull request #14678: remove redundant KeyOriginInfo access, already done in CreateSig (master...redundant_keypath) https://github.com/bitcoin/bitcoin/pull/14678
1932018-11-07T15:56:18  *** bitcoin-git has left #bitcoin-core-dev
1942018-11-07T15:56:32  *** ezzzy has quit IRC
1952018-11-07T15:59:43  <provoostenator> sipa: I set log statements on both HidingSigningProvider::GetKeyOrigin and FlatSigningProvider::GetKeyOrigin and only the former is called.
1962018-11-07T16:01:09  <instagibbs> provoostenator, the underlying m_provider is CWallet though?
1972018-11-07T16:01:31  <provoostenator> Oh, I assemed it referred to the base class, n00b...
1982018-11-07T16:02:08  <instagibbs> It "wraps" CWallet to "hide" stuff. Honestly they should have documentation :)
1992018-11-07T16:04:04  *** bitcoin-git has joined #bitcoin-core-dev
2002018-11-07T16:04:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d864e45730be...4e6dc7a0ef22
2012018-11-07T16:04:05  <bitcoin-git> bitcoin/master 99d33a6 Chun Kuan Lee: appveyor: Script improvement part II
2022018-11-07T16:04:06  <bitcoin-git> bitcoin/master 4e6dc7a MarcoFalke: Merge #14665: appveyor: Script improvement part II...
2032018-11-07T16:04:06  *** bitcoin-git has left #bitcoin-core-dev
2042018-11-07T16:04:17  *** watchtower has quit IRC
2052018-11-07T16:05:31  *** bitcoin-git has joined #bitcoin-core-dev
2062018-11-07T16:05:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14665: appveyor: Script improvement part II (master...appveyor-quiet) https://github.com/bitcoin/bitcoin/pull/14665
2072018-11-07T16:05:31  *** bitcoin-git has left #bitcoin-core-dev
2082018-11-07T16:07:31  *** bitcoin-git has joined #bitcoin-core-dev
2092018-11-07T16:07:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e6dc7a0ef22...66c70249f9e6
2102018-11-07T16:07:32  <bitcoin-git> bitcoin/master 053b6f4 Harry Moreno: align items in contrib init
2112018-11-07T16:07:33  <bitcoin-git> bitcoin/master 66c7024 MarcoFalke: Merge #14611: docs: align items in contrib init...
2122018-11-07T16:07:33  *** bitcoin-git has left #bitcoin-core-dev
2132018-11-07T16:08:16  *** watchtower has joined #bitcoin-core-dev
2142018-11-07T16:08:46  *** bitcoin-git has joined #bitcoin-core-dev
2152018-11-07T16:08:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14611: docs: align items in contrib init (master...morenoh149-patch-1) https://github.com/bitcoin/bitcoin/pull/14611
2162018-11-07T16:08:46  *** bitcoin-git has left #bitcoin-core-dev
2172018-11-07T16:12:43  *** watchtower has quit IRC
2182018-11-07T16:14:16  *** watchtower has joined #bitcoin-core-dev
2192018-11-07T16:16:37  *** watchtower has quit IRC
2202018-11-07T16:17:10  *** bitcoin-git has joined #bitcoin-core-dev
2212018-11-07T16:17:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/66c70249f9e6...e8d490f27e69
2222018-11-07T16:17:11  <bitcoin-git> bitcoin/master e4dc39b Hennadii Stepanov: Replace platform dependent type with proper const
2232018-11-07T16:17:11  <bitcoin-git> bitcoin/master bafb921 Hennadii Stepanov: Remove duplicated code...
2242018-11-07T16:17:12  <bitcoin-git> bitcoin/master 5352030 Russell Yanofsky: Avoid using numeric_limits for sequence numbers and lock times...
2252018-11-07T16:17:12  *** bitcoin-git has left #bitcoin-core-dev
2262018-11-07T16:18:19  *** bitcoin-git has joined #bitcoin-core-dev
2272018-11-07T16:18:19  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636
2282018-11-07T16:18:19  *** bitcoin-git has left #bitcoin-core-dev
2292018-11-07T16:18:30  *** jarthur has joined #bitcoin-core-dev
2302018-11-07T16:20:31  *** bitcoin-git has joined #bitcoin-core-dev
2312018-11-07T16:20:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13677: Remind developers that disablewallet=1 should always work (master...2018/07/disable-wallet) https://github.com/bitcoin/bitcoin/pull/13677
2322018-11-07T16:20:31  *** bitcoin-git has left #bitcoin-core-dev
2332018-11-07T16:27:29  *** bitcoin-git has joined #bitcoin-core-dev
2342018-11-07T16:27:29  <bitcoin-git> [bitcoin] instagibbs opened pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
2352018-11-07T16:27:29  *** bitcoin-git has left #bitcoin-core-dev
2362018-11-07T16:29:31  *** jarthur has quit IRC
2372018-11-07T16:34:01  *** rh0nj has quit IRC
2382018-11-07T16:35:08  *** rh0nj has joined #bitcoin-core-dev
2392018-11-07T16:52:02  *** ezzzy has joined #bitcoin-core-dev
2402018-11-07T16:58:32  *** promag has quit IRC
2412018-11-07T17:01:02  *** Krellan has joined #bitcoin-core-dev
2422018-11-07T17:02:38  <provoostenator> Any one-liner to serialize a KeyOriginInfo object to std::string (for debugging)?
2432018-11-07T17:03:11  <provoostenator> (or to char *)
2442018-11-07T17:03:48  <sipa> provoostenator: decodepsbt has code for that
2452018-11-07T17:04:02  <sipa> oh, it does it in 2 separate json fields
2462018-11-07T17:04:51  <provoostenator> sipa: got it, that should be easy to reuse
2472018-11-07T17:07:29  *** Aaronvan_ has joined #bitcoin-core-dev
2482018-11-07T17:08:51  <MarcoFalke> https://github.com/bitcoin/bitcoin/issues/14675#issuecomment-436689585
2492018-11-07T17:08:57  <MarcoFalke> 0.17.0.2 ?
2502018-11-07T17:10:24  *** Murch has joined #bitcoin-core-dev
2512018-11-07T17:10:27  *** AaronvanW has quit IRC
2522018-11-07T17:11:27  *** XtuDe has quit IRC
2532018-11-07T17:11:59  *** bitcoin-git has joined #bitcoin-core-dev
2542018-11-07T17:11:59  <bitcoin-git> [bitcoin] jamesob opened pull request #14683: tests: better combine_logs.py behavior (master...2018-11-better-cons-log) https://github.com/bitcoin/bitcoin/pull/14683
2552018-11-07T17:11:59  *** bitcoin-git has left #bitcoin-core-dev
2562018-11-07T17:23:08  *** bitcoin-git has joined #bitcoin-core-dev
2572018-11-07T17:23:08  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8d490f27e69...d26d15c6c89a
2582018-11-07T17:23:09  <bitcoin-git> bitcoin/master 590a57f practicalswift: tests: Remove unused testing code
2592018-11-07T17:23:09  <bitcoin-git> bitcoin/master c82190c practicalswift: tests: Add Python dead code linter (vulture)
2602018-11-07T17:23:10  <bitcoin-git> bitcoin/master d26d15c MarcoFalke: Merge #14365: tests: Add Python dead code linter (vulture) to Travis...
2612018-11-07T17:23:10  *** bitcoin-git has left #bitcoin-core-dev
2622018-11-07T17:24:03  *** bitcoin-git has joined #bitcoin-core-dev
2632018-11-07T17:24:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14365:  tests: Add Python dead code linter (vulture) to Travis (master...lint-python-dead-code) https://github.com/bitcoin/bitcoin/pull/14365
2642018-11-07T17:24:04  *** bitcoin-git has left #bitcoin-core-dev
2652018-11-07T17:24:24  <esotericnonsense> wumpus: :) when I get bored of bashing JS libraries into submission I'll add some more stuff. need to get away from this chart distraction and add some actually useful API bits. :p\
2662018-11-07T17:33:07  *** JackH has quit IRC
2672018-11-07T17:35:34  *** XtXe has joined #bitcoin-core-dev
2682018-11-07T17:37:27  *** XtXe has quit IRC
2692018-11-07T17:42:57  *** bitcoin-git has joined #bitcoin-core-dev
2702018-11-07T17:42:57  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14684: [doc] conf: Remove deprecated options from docs, Other cleanup (master...Mf1609-trivialPre14) https://github.com/bitcoin/bitcoin/pull/14684
2712018-11-07T17:42:57  *** bitcoin-git has left #bitcoin-core-dev
2722018-11-07T17:44:22  <provoostenator> (mystery solved, the older version of achow101's hww PR would write "h" into meta.hdKeypath, which trips up ParseHDKeypath. The new version always uses '.
2732018-11-07T17:47:47  *** XtXe has joined #bitcoin-core-dev
2742018-11-07T17:50:44  *** dstadulis has joined #bitcoin-core-dev
2752018-11-07T17:53:07  *** dstadulis has quit IRC
2762018-11-07T17:57:01  *** ExtraCrispy has joined #bitcoin-core-dev
2772018-11-07T18:02:08  <sipa> provoostenator: ha, nice find
2782018-11-07T18:02:18  <provoostenator> Hardware wallet fun in ##hww
2792018-11-07T18:02:24  <instagibbs> achow101, ^
2802018-11-07T18:02:25  <provoostenator> ##hwi
2812018-11-07T18:03:43  *** XtXe has quit IRC
2822018-11-07T18:04:13  *** XtXe has joined #bitcoin-core-dev
2832018-11-07T18:04:56  *** XtXe has joined #bitcoin-core-dev
2842018-11-07T18:09:16  *** XtXe has quit IRC
2852018-11-07T18:19:57  *** ricardobessa has joined #bitcoin-core-dev
2862018-11-07T18:36:54  *** Chris_Stewart_5 has quit IRC
2872018-11-07T18:49:13  *** rex4539 has quit IRC
2882018-11-07T18:51:54  *** timothy has quit IRC
2892018-11-07T19:07:04  *** ExtraCrispy has quit IRC
2902018-11-07T19:14:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2912018-11-07T19:16:49  *** belcher has quit IRC
2922018-11-07T19:17:34  *** belcher has joined #bitcoin-core-dev
2932018-11-07T19:33:55  *** esotericnonsense has quit IRC
2942018-11-07T19:36:02  *** esotericnonsense has joined #bitcoin-core-dev
2952018-11-07T19:36:55  *** mistergold has joined #bitcoin-core-dev
2962018-11-07T19:37:48  *** AaronvanW has joined #bitcoin-core-dev
2972018-11-07T19:38:01  *** Aaronvan_ has quit IRC
2982018-11-07T19:38:15  *** jarthur has joined #bitcoin-core-dev
2992018-11-07T19:40:10  *** rex4539 has joined #bitcoin-core-dev
3002018-11-07T19:45:06  *** schmidty has joined #bitcoin-core-dev
3012018-11-07T19:45:07  *** schmidty has joined #bitcoin-core-dev
3022018-11-07T19:58:23  *** promag has joined #bitcoin-core-dev
3032018-11-07T20:01:24  *** bitcoin-git has joined #bitcoin-core-dev
3042018-11-07T20:01:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d26d15c6c89a...11e1ac3ae085
3052018-11-07T20:01:25  <bitcoin-git> bitcoin/master b191c7d James O'Beirne: doc: add comment explaining recentRejects-DoS behavior...
3062018-11-07T20:01:26  <bitcoin-git> bitcoin/master 11e1ac3 MarcoFalke: Merge #14436: doc: add comment explaining recentRejects-DoS behavior...
3072018-11-07T20:01:26  *** bitcoin-git has left #bitcoin-core-dev
3082018-11-07T20:12:53  *** ricardobessa has quit IRC
3092018-11-07T20:29:36  <jnewbery> instagibbs: re generate to P2PK, I don't think so - is there a reason you can't use P2PKH or P2WPKH?
3102018-11-07T20:31:25  <instagibbs> I used multisig to test my hypothesis instead, thanks anyways
3112018-11-07T20:32:13  <instagibbs> https://github.com/bitcoin/bitcoin/pull/14678 turns out it was just redundancy, not a bug
3122018-11-07T20:32:14  *** promag has quit IRC
3132018-11-07T20:36:21  <ezzzy> are there any up-to-date resources documenting the bitcoin protocol, except of en.bitcoin.it/wiki/Protocol_documentation?
3142018-11-07T20:47:26  *** jamesob has quit IRC
3152018-11-07T20:47:43  *** rodarmor has quit IRC
3162018-11-07T20:47:43  *** Jackielove4u has quit IRC
3172018-11-07T20:47:51  *** jamesob has joined #bitcoin-core-dev
3182018-11-07T20:48:03  *** Jackielove4u has joined #bitcoin-core-dev
3192018-11-07T20:48:14  *** rodarmor has joined #bitcoin-core-dev
3202018-11-07T21:02:49  *** Guest34309 has quit IRC
3212018-11-07T21:03:14  *** iphelix has joined #bitcoin-core-dev
3222018-11-07T21:03:36  *** iphelix is now known as Guest83806
3232018-11-07T21:06:04  *** BashCo_ has quit IRC
3242018-11-07T21:09:31  *** Scipio has quit IRC
3252018-11-07T21:10:54  *** dondreyt has joined #bitcoin-core-dev
3262018-11-07T21:13:41  <dondreyt> I'm currently in the process of doing some debugging of Bitcoin Core. Is there a way to output a CScript to console, in particular a public key signature as a string representation of hexadecimal?
3272018-11-07T21:26:40  *** ken2812221 has quit IRC
3282018-11-07T21:27:32  <phantomcircuit> dondreyt, iirc there's a descodescript rpc call
3292018-11-07T21:27:36  <phantomcircuit> if that's what you mean
3302018-11-07T21:27:55  <meshcollider> dondreyt: HexStr(script.begin(), script.end())
3312018-11-07T21:28:48  <dondreyt> Ah yeah, HexStr is what I'm looking for for. Do you pass in the CScript as a third parameter into that?
3322018-11-07T21:29:11  <meshcollider> No I'm assuming the CScript is called script
3332018-11-07T21:29:17  <meshcollider> It returns the string
3342018-11-07T21:29:36  <dondreyt> meshcollider: I see
3352018-11-07T21:31:06  <dondreyt> meshcollider: To view the output of this when you call "submitblock" from the console, is there a function I should use?  I see LogPrintf scattered throughout, but I wasn't sure where the outputted to.
3362018-11-07T21:32:20  <dondreyt> phanetomcircuit: Thanks, I'll check out descodescript as well. Didn't know there was an RPC for that.
3372018-11-07T21:35:19  <meshcollider> dondreyt: logprintf prints to the debug.log file
3382018-11-07T21:35:48  <dondreyt> meshcollider: Ahhh okay, makes perfect sense. Thanks
3392018-11-07T21:36:27  <meshcollider> np
3402018-11-07T21:37:19  <phantomcircuit> dondreyt, wait what are you trying to do exactly?
3412018-11-07T21:38:19  <dondreyt> phantomcircuit: Just in the learning phase of seeing how data is represented and passed around. I submitted a block via RPC and have been following it through the validation path.
3422018-11-07T21:40:04  <phantomcircuit> dondreyt, oh ok, might want to add a bunch of LogPrint statements then using HexStr like meshcollider suggested
3432018-11-07T21:40:10  <phantomcircuit> then you can decodescript the hexstrings
3442018-11-07T21:41:06  <dondreyt> phantomcircuit: Okay, I'm going to go ahead and do that.
3452018-11-07T21:45:11  *** mistergold has quit IRC
3462018-11-07T21:47:06  *** promag has joined #bitcoin-core-dev
3472018-11-07T21:52:36  <jamesob> anyone know if jimpo_'s still working on #14121? if not, I'd like to rebase it
3482018-11-07T21:52:39  <gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
3492018-11-07T21:56:06  *** bsm117532 has joined #bitcoin-core-dev
3502018-11-07T22:04:11  *** Murch has quit IRC
3512018-11-07T22:05:30  *** BashCo1 has joined #bitcoin-core-dev
3522018-11-07T22:07:34  *** BashCo has joined #bitcoin-core-dev
3532018-11-07T22:07:49  *** spinza has quit IRC
3542018-11-07T22:08:50  *** Murch has joined #bitcoin-core-dev
3552018-11-07T22:09:46  *** BashCo1 has quit IRC
3562018-11-07T22:11:57  *** BashCo has quit IRC
3572018-11-07T22:13:16  *** bsm117532 has quit IRC
3582018-11-07T22:17:51  *** BashCo has joined #bitcoin-core-dev
3592018-11-07T22:19:06  *** belcher has quit IRC
3602018-11-07T22:19:47  *** dondreyt has quit IRC
3612018-11-07T22:20:21  *** Guyver2 has quit IRC
3622018-11-07T22:22:19  *** BashCo has quit IRC
3632018-11-07T22:23:06  *** BashCo has joined #bitcoin-core-dev
3642018-11-07T22:25:05  *** BashCo1 has joined #bitcoin-core-dev
3652018-11-07T22:27:49  *** BashCo has quit IRC
3662018-11-07T22:27:58  *** spinza has joined #bitcoin-core-dev
3672018-11-07T22:29:32  *** penthief12 has joined #bitcoin-core-dev
3682018-11-07T22:33:25  *** josephnicholas has quit IRC
3692018-11-07T22:34:01  *** josephnicholas has joined #bitcoin-core-dev
3702018-11-07T22:34:30  *** penthief12 has quit IRC
3712018-11-07T22:37:16  *** mika_ has joined #bitcoin-core-dev
3722018-11-07T22:38:16  *** josephnicholas has quit IRC
3732018-11-07T22:38:32  *** bralyclow has quit IRC
3742018-11-07T22:39:19  *** Aaronvan_ has joined #bitcoin-core-dev
3752018-11-07T22:39:48  *** Murch has quit IRC
3762018-11-07T22:40:54  *** michaelsdunn1 has quit IRC
3772018-11-07T22:42:24  *** AaronvanW has quit IRC
3782018-11-07T22:42:46  *** ezzzy has quit IRC
3792018-11-07T22:43:24  *** ezzzy has joined #bitcoin-core-dev
3802018-11-07T22:43:48  *** bralyclow has joined #bitcoin-core-dev
3812018-11-07T22:44:42  *** BashCo1 has quit IRC
3822018-11-07T22:46:06  *** Chris_Stewart_5 has quit IRC
3832018-11-07T22:47:57  *** ezzzy has quit IRC
3842018-11-07T22:55:33  *** bitconner has joined #bitcoin-core-dev
3852018-11-07T23:03:05  *** recover has joined #bitcoin-core-dev
3862018-11-07T23:04:05  *** Murch has joined #bitcoin-core-dev
3872018-11-07T23:13:03  *** mika_ has quit IRC
3882018-11-07T23:13:03  *** ezzzy has joined #bitcoin-core-dev
3892018-11-07T23:17:16  *** ezzzy has quit IRC
3902018-11-07T23:22:19  *** arubi has quit IRC
3912018-11-07T23:22:55  *** arubi has joined #bitcoin-core-dev
3922018-11-07T23:29:02  *** recover_ has joined #bitcoin-core-dev
3932018-11-07T23:33:17  *** recover__ has joined #bitcoin-core-dev
3942018-11-07T23:33:18  *** josephnicholas has joined #bitcoin-core-dev
3952018-11-07T23:34:44  *** spinza has quit IRC
3962018-11-07T23:38:18  *** josephnicholas has quit IRC
3972018-11-07T23:38:26  *** spinza has joined #bitcoin-core-dev
3982018-11-07T23:39:35  *** deaunapaul has joined #bitcoin-core-dev
3992018-11-07T23:46:09  *** AaronvanW has joined #bitcoin-core-dev
4002018-11-07T23:49:46  *** Aaronvan_ has quit IRC
4012018-11-07T23:56:19  *** spinza has quit IRC