12018-11-13T00:11:17 *** Krellan has joined #bitcoin-core-dev
22018-11-13T00:12:04 *** michaelsdunn1 has quit IRC
32018-11-13T00:14:28 *** Murch has quit IRC
42018-11-13T00:23:11 *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
52018-11-13T00:26:15 *** Ga1aCt1Cz00__ has quit IRC
62018-11-13T00:30:28 *** booyah has quit IRC
72018-11-13T00:30:30 *** booyah_ has joined #bitcoin-core-dev
82018-11-13T00:31:33 *** promag has quit IRC
92018-11-13T00:32:21 <phantomcircuit> sipa, hmm actually just a bad measurement from perf it seems
102018-11-13T00:34:07 *** shesek has joined #bitcoin-core-dev
112018-11-13T00:34:07 *** shesek has joined #bitcoin-core-dev
122018-11-13T00:57:30 *** khush has joined #bitcoin-core-dev
132018-11-13T01:02:11 *** Mutter has joined #bitcoin-core-dev
142018-11-13T01:03:02 *** khush has quit IRC
152018-11-13T01:07:58 *** millerti has quit IRC
162018-11-13T01:10:12 *** Mutter has quit IRC
172018-11-13T01:14:23 <esotericnonsense> sipa: yes!
182018-11-13T01:14:35 <esotericnonsense> 2**90. :o.
192018-11-13T01:50:30 *** dviola has quit IRC
202018-11-13T01:53:16 *** _cryptosignal_me has joined #bitcoin-core-dev
212018-11-13T02:23:23 *** Krellan has quit IRC
222018-11-13T02:36:01 *** rh0nj has quit IRC
232018-11-13T02:37:08 *** rh0nj has joined #bitcoin-core-dev
242018-11-13T03:08:47 *** AaronvanW has quit IRC
252018-11-13T03:11:05 *** timopaulin has joined #bitcoin-core-dev
262018-11-13T03:15:15 *** timopaulin has quit IRC
272018-11-13T03:21:37 *** Giszmo has quit IRC
282018-11-13T03:35:53 *** ken2812221 has quit IRC
292018-11-13T03:46:59 *** grubles_ has joined #bitcoin-core-dev
302018-11-13T03:49:29 *** grubles has quit IRC
312018-11-13T03:58:45 *** promag has joined #bitcoin-core-dev
322018-11-13T04:05:12 *** promag has quit IRC
332018-11-13T04:06:31 *** Roybent has joined #bitcoin-core-dev
342018-11-13T04:09:52 *** Roybent has quit IRC
352018-11-13T04:14:37 *** teardown has quit IRC
362018-11-13T04:17:25 *** grubles__ has joined #bitcoin-core-dev
372018-11-13T04:19:55 *** grubles_ has quit IRC
382018-11-13T05:13:03 *** Roybent has joined #bitcoin-core-dev
392018-11-13T05:14:52 <Roybent> (silicone, saline, string) implants
402018-11-13T05:16:39 *** Roybent has left #bitcoin-core-dev
412018-11-13T06:38:02 *** rh0nj has quit IRC
422018-11-13T06:39:07 *** rh0nj has joined #bitcoin-core-dev
432018-11-13T07:02:47 *** murrayn has joined #bitcoin-core-dev
442018-11-13T07:02:48 *** murrayn has joined #bitcoin-core-dev
452018-11-13T07:06:45 *** state_bits has joined #bitcoin-core-dev
462018-11-13T07:15:56 *** rafalcpp has quit IRC
472018-11-13T07:17:14 *** rafalcpp has joined #bitcoin-core-dev
482018-11-13T07:39:51 *** tryphe_ is now known as tryphe
492018-11-13T07:41:13 *** bitcoin-git has joined #bitcoin-core-dev
502018-11-13T07:41:14 <bitcoin-git> [bitcoin] 1Il1 opened pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
512018-11-13T07:41:14 *** bitcoin-git has left #bitcoin-core-dev
522018-11-13T07:50:53 *** bitcoin-git has joined #bitcoin-core-dev
532018-11-13T07:50:54 <bitcoin-git> [bitcoin] 1Il1 opened pull request #14714: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
542018-11-13T07:50:54 *** bitcoin-git has left #bitcoin-core-dev
552018-11-13T07:52:03 *** Murch has joined #bitcoin-core-dev
562018-11-13T07:52:33 *** bitcoin-git has joined #bitcoin-core-dev
572018-11-13T07:52:34 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47ed24cf8aa7...b60f4e3f0951
582018-11-13T07:52:35 <bitcoin-git> bitcoin/master a6b5ec1 marcoagner: rpc: creates possibility to preserve labels on importprivkey...
592018-11-13T07:52:35 <bitcoin-git> bitcoin/master b60f4e3 Jonas Schnelli: Merge #13381: RPC: creates possibility to preserve labels on importprivkey...
602018-11-13T07:52:36 *** bitcoin-git has left #bitcoin-core-dev
612018-11-13T07:53:04 *** bitcoin-git has joined #bitcoin-core-dev
622018-11-13T07:53:04 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13381: RPC: creates possibility to preserve labels on importprivkey (master...feature_preserve_labels_on_import) https://github.com/bitcoin/bitcoin/pull/13381
632018-11-13T07:53:04 *** bitcoin-git has left #bitcoin-core-dev
642018-11-13T07:56:56 *** Murch has quit IRC
652018-11-13T08:06:13 *** setpill has joined #bitcoin-core-dev
662018-11-13T08:10:25 *** GoatzMilk has quit IRC
672018-11-13T08:10:44 *** GoatzMilk has joined #bitcoin-core-dev
682018-11-13T08:19:48 *** queip has quit IRC
692018-11-13T08:21:12 *** GoatzMilk has quit IRC
702018-11-13T08:21:18 *** rafalcpp has quit IRC
712018-11-13T08:22:27 *** JackH has quit IRC
722018-11-13T08:23:26 *** GoatzMilk has joined #bitcoin-core-dev
732018-11-13T08:27:20 *** rafalcpp has joined #bitcoin-core-dev
742018-11-13T08:30:20 *** really_cool_dj_n has joined #bitcoin-core-dev
752018-11-13T08:30:26 *** GoatzMilk has quit IRC
762018-11-13T08:31:08 *** queip has joined #bitcoin-core-dev
772018-11-13T08:33:27 *** jungly has joined #bitcoin-core-dev
782018-11-13T08:35:45 *** really_cool_dj_n has quit IRC
792018-11-13T08:36:40 *** GoatzMilk has joined #bitcoin-core-dev
802018-11-13T08:38:14 *** bitcoin-git has joined #bitcoin-core-dev
812018-11-13T08:38:14 <bitcoin-git> [bitcoin] 1Il1 closed pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
822018-11-13T08:38:14 *** bitcoin-git has left #bitcoin-core-dev
832018-11-13T08:41:24 *** timothy has joined #bitcoin-core-dev
842018-11-13T08:41:30 *** GoatzMilk has quit IRC
852018-11-13T08:42:11 *** GoatzMilk has joined #bitcoin-core-dev
862018-11-13T08:44:46 *** bitcoin-git has joined #bitcoin-core-dev
872018-11-13T08:44:47 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b60f4e3f0951...083f53547092
882018-11-13T08:44:47 <bitcoin-git> bitcoin/master 8711cc0 Hennadii Stepanov: qt: Improve BitcoinAmountField class...
892018-11-13T08:44:48 <bitcoin-git> bitcoin/master a16f44c Hennadii Stepanov: qt: Remove "Pay only required fee" checkbox...
902018-11-13T08:44:48 <bitcoin-git> bitcoin/master 083f535 Jonas Schnelli: Merge #14608: qt: Remove the "Pay only required fee..." checkbox...
912018-11-13T08:44:49 *** bitcoin-git has left #bitcoin-core-dev
922018-11-13T08:45:45 *** bitcoin-git has joined #bitcoin-core-dev
932018-11-13T08:45:46 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14608: qt: Remove the "Pay only required fee..." checkbox (master...20181030-remove-payonlyrequiredfee) https://github.com/bitcoin/bitcoin/pull/14608
942018-11-13T08:45:46 *** bitcoin-git has left #bitcoin-core-dev
952018-11-13T08:52:16 *** GoatzMilk has quit IRC
962018-11-13T08:54:25 *** GoatzMilk has joined #bitcoin-core-dev
972018-11-13T09:06:28 *** Victorsueca has quit IRC
982018-11-13T09:06:54 *** phwalkr has joined #bitcoin-core-dev
992018-11-13T09:07:43 *** Victorsueca has joined #bitcoin-core-dev
1002018-11-13T09:12:21 *** JackH has joined #bitcoin-core-dev
1012018-11-13T09:28:03 *** wxss has joined #bitcoin-core-dev
1022018-11-13T09:30:53 *** bitcoin-git has joined #bitcoin-core-dev
1032018-11-13T09:30:53 <bitcoin-git> [bitcoin] Empact opened pull request #14715: Drop defunct prevector compat handling (master...trivial-prevector) https://github.com/bitcoin/bitcoin/pull/14715
1042018-11-13T09:30:53 *** bitcoin-git has left #bitcoin-core-dev
1052018-11-13T09:39:52 *** bitcoin-git has joined #bitcoin-core-dev
1062018-11-13T09:39:53 <bitcoin-git> [bitcoin] Empact opened pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
1072018-11-13T09:39:53 *** bitcoin-git has left #bitcoin-core-dev
1082018-11-13T09:43:42 *** promag has joined #bitcoin-core-dev
1092018-11-13T09:52:48 *** tryphe_ has joined #bitcoin-core-dev
1102018-11-13T09:53:47 *** tryphe has quit IRC
1112018-11-13T10:07:21 <promag> saw this travis error https://pasteboard.co/HMXvxSX.png
1122018-11-13T10:14:56 <meshcollider> #14690 looks RTM
1132018-11-13T10:14:57 <gribble> https://github.com/bitcoin/bitcoin/issues/14690 | Throw error if CPubKey is invalid during PSBT keypath serialization by instagibbs · Pull Request #14690 · bitcoin/bitcoin · GitHub
1142018-11-13T10:21:28 *** spinza has quit IRC
1152018-11-13T10:30:02 *** cubancorona has quit IRC
1162018-11-13T10:30:22 *** cubancorona has joined #bitcoin-core-dev
1172018-11-13T10:31:20 *** booyah has joined #bitcoin-core-dev
1182018-11-13T10:32:00 *** booyah_ has quit IRC
1192018-11-13T10:35:07 *** spinza has joined #bitcoin-core-dev
1202018-11-13T10:40:02 *** rh0nj has quit IRC
1212018-11-13T10:41:08 *** rh0nj has joined #bitcoin-core-dev
1222018-11-13T10:41:09 *** _flow_ has quit IRC
1232018-11-13T10:51:39 *** CodeBlue1776 has quit IRC
1242018-11-13T10:52:29 *** CodeBlue1776 has joined #bitcoin-core-dev
1252018-11-13T10:52:49 *** mistergold has joined #bitcoin-core-dev
1262018-11-13T10:54:37 *** _flow_ has joined #bitcoin-core-dev
1272018-11-13T11:01:41 *** JackH has quit IRC
1282018-11-13T11:07:41 *** ExtraCrispy has quit IRC
1292018-11-13T11:08:10 *** ExtraCrispy has joined #bitcoin-core-dev
1302018-11-13T11:19:29 *** booyah_ has joined #bitcoin-core-dev
1312018-11-13T11:21:09 *** booyah has quit IRC
1322018-11-13T11:30:59 *** AaronvanW has joined #bitcoin-core-dev
1332018-11-13T11:37:17 *** Aaronvan_ has joined #bitcoin-core-dev
1342018-11-13T11:40:22 *** AaronvanW has quit IRC
1352018-11-13T11:40:30 *** josephnicholas has joined #bitcoin-core-dev
1362018-11-13T11:47:21 *** karoofish27 has joined #bitcoin-core-dev
1372018-11-13T11:50:39 *** phwalkr has quit IRC
1382018-11-13T11:51:14 *** phwalkr has joined #bitcoin-core-dev
1392018-11-13T11:53:17 *** belcher has joined #bitcoin-core-dev
1402018-11-13T11:55:28 *** phwalkr has quit IRC
1412018-11-13T12:05:15 *** timothy has quit IRC
1422018-11-13T12:09:10 *** timothy has joined #bitcoin-core-dev
1432018-11-13T12:20:32 *** ken2812221 has joined #bitcoin-core-dev
1442018-11-13T12:21:46 *** shesek has quit IRC
1452018-11-13T12:22:48 *** shesek has joined #bitcoin-core-dev
1462018-11-13T12:28:09 *** Deinogalerix21 has joined #bitcoin-core-dev
1472018-11-13T12:44:39 *** bitcoin-git has joined #bitcoin-core-dev
1482018-11-13T12:44:40 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/083f53547092...ce7fcc356909
1492018-11-13T12:44:41 <bitcoin-git> bitcoin/master 4e4de10 Gregory Sanders: Throw error if CPubKey is invalid during PSBT keypath serialization
1502018-11-13T12:44:41 <bitcoin-git> bitcoin/master ce7fcc3 Wladimir J. van der Laan: Merge #14690: Throw error if CPubKey is invalid during PSBT keypath serialization...
1512018-11-13T12:44:42 *** bitcoin-git has left #bitcoin-core-dev
1522018-11-13T12:45:46 *** bitcoin-git has joined #bitcoin-core-dev
1532018-11-13T12:45:46 <bitcoin-git> [bitcoin] laanwj closed pull request #14690: Throw error if CPubKey is invalid during PSBT keypath serialization (master...check_psbt_pubkey) https://github.com/bitcoin/bitcoin/pull/14690
1542018-11-13T12:45:46 *** bitcoin-git has left #bitcoin-core-dev
1552018-11-13T12:46:27 <wumpus> achow101: I've also heard that; only "webhooks" remain :(
1562018-11-13T12:46:37 *** phwalkr has joined #bitcoin-core-dev
1572018-11-13T12:49:27 <wumpus> why does microsoft hate IRC :-(((( (no, kidding, this was already planned before the takeover)
1582018-11-13T12:49:39 *** Deinogalerix21 has quit IRC
1592018-11-13T12:51:08 *** phwalkr has quit IRC
1602018-11-13T12:52:57 <wumpus> would be fairly straightforward to make an IRC bot that listens to github events, very similar to the twitter/mastodon bot, but it's yet another moving part it was nice that github handled this
1612018-11-13T12:55:37 *** bitcoin-git has joined #bitcoin-core-dev
1622018-11-13T12:55:38 <bitcoin-git> [bitcoin] murrayn opened pull request #14718: Remove unreferenced boost headers and quieten remaining clang warnings (master...clang_warnings) https://github.com/bitcoin/bitcoin/pull/14718
1632018-11-13T12:55:38 *** bitcoin-git has left #bitcoin-core-dev
1642018-11-13T13:01:21 *** promag has quit IRC
1652018-11-13T13:14:13 *** phwalkr has joined #bitcoin-core-dev
1662018-11-13T13:16:01 *** phwalkr has quit IRC
1672018-11-13T13:16:13 *** phwalkr has joined #bitcoin-core-dev
1682018-11-13T13:20:48 *** promag has joined #bitcoin-core-dev
1692018-11-13T13:35:25 *** Murch has joined #bitcoin-core-dev
1702018-11-13T13:35:50 *** Murch has quit IRC
1712018-11-13T13:38:30 *** promag has quit IRC
1722018-11-13T13:47:22 *** Murch has joined #bitcoin-core-dev
1732018-11-13T13:52:50 *** bitcoin-git has joined #bitcoin-core-dev
1742018-11-13T13:52:50 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce7fcc356909...c51e1516a930
1752018-11-13T13:52:51 <bitcoin-git> bitcoin/master 27154ce 1Il1: util.h: explicitly include required QString header
1762018-11-13T13:52:51 <bitcoin-git> bitcoin/master c51e151 Wladimir J. van der Laan: Merge #14714: util.h: explicitly include required QString header...
1772018-11-13T13:52:52 *** bitcoin-git has left #bitcoin-core-dev
1782018-11-13T13:53:59 *** bitcoin-git has joined #bitcoin-core-dev
1792018-11-13T13:53:59 <bitcoin-git> [bitcoin] laanwj closed pull request #14714: tests: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
1802018-11-13T13:53:59 *** bitcoin-git has left #bitcoin-core-dev
1812018-11-13T13:57:12 *** promag has joined #bitcoin-core-dev
1822018-11-13T14:00:09 *** phwalkr has quit IRC
1832018-11-13T14:15:56 *** Murch has quit IRC
1842018-11-13T14:20:16 *** Murch has joined #bitcoin-core-dev
1852018-11-13T14:22:03 *** Guyver2 has joined #bitcoin-core-dev
1862018-11-13T14:24:08 *** Murch has quit IRC
1872018-11-13T14:27:02 *** Murch has joined #bitcoin-core-dev
1882018-11-13T14:33:46 *** Murch has quit IRC
1892018-11-13T14:36:47 *** CodeBlue1776 has quit IRC
1902018-11-13T14:37:11 *** CodeBlue1776 has joined #bitcoin-core-dev
1912018-11-13T14:39:39 *** timothy has quit IRC
1922018-11-13T14:41:18 *** reardencode has joined #bitcoin-core-dev
1932018-11-13T14:42:03 *** timothy has joined #bitcoin-core-dev
1942018-11-13T14:44:13 *** ccook has quit IRC
1952018-11-13T15:06:11 *** setpill has quit IRC
1962018-11-13T15:10:22 *** lnostdal_ has joined #bitcoin-core-dev
1972018-11-13T15:10:46 *** lnostdal has quit IRC
1982018-11-13T15:11:04 *** lnostdal has joined #bitcoin-core-dev
1992018-11-13T15:19:22 *** ossifrage has quit IRC
2002018-11-13T15:26:55 *** bitcoin-git has joined #bitcoin-core-dev
2012018-11-13T15:26:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c51e1516a930...5d605b27457d
2022018-11-13T15:26:56 <bitcoin-git> bitcoin/master 6c787d3 MarcoFalke: tests: Make feature_block pass on centos
2032018-11-13T15:26:56 <bitcoin-git> bitcoin/master fa21568 MarcoFalke: qa: Avoid race in p2p_invalid_block by waiting for the block request
2042018-11-13T15:26:57 <bitcoin-git> bitcoin/master 5d605b2 MarcoFalke: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request...
2052018-11-13T15:26:57 *** bitcoin-git has left #bitcoin-core-dev
2062018-11-13T15:28:09 *** bitcoin-git has joined #bitcoin-core-dev
2072018-11-13T15:28:09 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request (master...Mf1811-qaPassOnCentOs) https://github.com/bitcoin/bitcoin/pull/14700
2082018-11-13T15:28:09 *** bitcoin-git has left #bitcoin-core-dev
2092018-11-13T15:36:13 *** ossifrage has joined #bitcoin-core-dev
2102018-11-13T15:37:44 *** michaelsdunn1 has joined #bitcoin-core-dev
2112018-11-13T15:40:42 <instagibbs> wumpus, would you mind if i made the sigdata const before you consider merging in #14678 ? Or would that "reset" the review? I think it would make intent of function more clear
2122018-11-13T15:40:44 <gribble> https://github.com/bitcoin/bitcoin/issues/14678 | [wallet] remove redundant KeyOriginInfo access, already done in CreateSig by instagibbs · Pull Request #14678 · bitcoin/bitcoin · GitHub
2132018-11-13T15:40:58 <wumpus> instagibbs: I don't mind
2142018-11-13T15:42:04 <wumpus> better to just do it the best way possible than put in a fixup PR just after it's merged, that's frustrating! I think "resetting review" is more of a concern for complex changes
2152018-11-13T15:43:57 <instagibbs> yep, just making sure
2162018-11-13T15:53:26 <wumpus> right
2172018-11-13T15:57:37 *** josephnicholas has quit IRC
2182018-11-13T15:58:04 *** josephnicholas has joined #bitcoin-core-dev
2192018-11-13T16:02:55 *** josephnicholas has quit IRC
2202018-11-13T16:05:07 *** queip has quit IRC
2212018-11-13T16:07:51 <phantomcircuit> hmm sipa is definitely right that a sorted vector would be fast
2222018-11-13T16:07:57 *** rafalcpp has quit IRC
2232018-11-13T16:09:37 *** rafalcpp has joined #bitcoin-core-dev
2242018-11-13T16:16:36 *** bitcoin-git has joined #bitcoin-core-dev
2252018-11-13T16:16:37 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14719: qa: Check specific reject reasons in feature_block (master...Mf1811-qaRejectBlock) https://github.com/bitcoin/bitcoin/pull/14719
2262018-11-13T16:16:37 *** bitcoin-git has left #bitcoin-core-dev
2272018-11-13T16:19:48 *** queip has joined #bitcoin-core-dev
2282018-11-13T16:20:26 *** queip has quit IRC
2292018-11-13T16:21:36 *** josephnicholas has joined #bitcoin-core-dev
2302018-11-13T16:22:16 *** gloata has joined #bitcoin-core-dev
2312018-11-13T16:26:44 *** jarthur has joined #bitcoin-core-dev
2322018-11-13T16:27:28 *** queip has joined #bitcoin-core-dev
2332018-11-13T16:28:28 *** promag has quit IRC
2342018-11-13T16:31:15 *** gloata has quit IRC
2352018-11-13T16:35:39 *** cubancorona has quit IRC
2362018-11-13T16:41:39 *** agnjunio has joined #bitcoin-core-dev
2372018-11-13T16:42:14 *** grubles__ is now known as grubles
2382018-11-13T16:47:45 *** josephnicholas has quit IRC
2392018-11-13T16:54:34 *** emilr has joined #bitcoin-core-dev
2402018-11-13T16:55:43 *** josephnicholas has joined #bitcoin-core-dev
2412018-11-13T16:55:59 <luke-jr> wumpus: unfortunately, it looks like the existing plugin for github stuff doesn't work with my ljrbot :<
2422018-11-13T16:56:47 <luke-jr> (and last time I tried to update it to the Limnoria fork, it was a mess)
2432018-11-13T16:58:09 *** josephnicholas has quit IRC
2442018-11-13T17:07:57 *** josephnicholas has joined #bitcoin-core-dev
2452018-11-13T17:08:32 <wumpus> luke-jr: oh too bad
2462018-11-13T17:12:45 *** josephni_ has joined #bitcoin-core-dev
2472018-11-13T17:13:35 <luke-jr> although, now that #anime has their own bot, maybe I can delete all the problematic aliases they added and try again, but ... time... :x
2482018-11-13T17:16:55 *** josephnicholas has quit IRC
2492018-11-13T17:17:13 *** josephni_ has quit IRC
2502018-11-13T17:23:37 *** grafcaps has quit IRC
2512018-11-13T17:26:45 *** grafcaps has joined #bitcoin-core-dev
2522018-11-13T17:27:25 *** bitcoin-git has joined #bitcoin-core-dev
2532018-11-13T17:27:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5d605b27457d...e0c6bb782308
2542018-11-13T17:27:26 <bitcoin-git> bitcoin/master fa3df02 MarcoFalke: travis: Avoid timeout on verify-commits check
2552018-11-13T17:27:26 <bitcoin-git> bitcoin/master fa5a6ce MarcoFalke: qa: Raise ci test_runner timeout to 40 mins
2562018-11-13T17:27:27 <bitcoin-git> bitcoin/master e0c6bb7 MarcoFalke: Merge #14705: travis: Avoid timeout on verify-commits check...
2572018-11-13T17:27:27 *** bitcoin-git has left #bitcoin-core-dev
2582018-11-13T17:28:34 *** bitcoin-git has joined #bitcoin-core-dev
2592018-11-13T17:28:35 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14705: travis: Avoid timeout on verify-commits check (master...Mf1811-travisVerifyCommits) https://github.com/bitcoin/bitcoin/pull/14705
2602018-11-13T17:28:35 *** bitcoin-git has left #bitcoin-core-dev
2612018-11-13T17:36:56 *** bitcoin-git has joined #bitcoin-core-dev
2622018-11-13T17:36:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0c6bb782308...c651265c934c
2632018-11-13T17:36:57 <bitcoin-git> bitcoin/master fa0d36f MarcoFalke: rpc: Include rpc/util.h where needed for RPCHelpMan...
2642018-11-13T17:36:57 <bitcoin-git> bitcoin/master fa483e1 MarcoFalke: rpc: Add RPCHelpMan for machine-generated help
2652018-11-13T17:36:58 <bitcoin-git> bitcoin/master c651265 MarcoFalke: Merge #14530: Use RPCHelpMan to generate RPC doc strings...
2662018-11-13T17:36:58 *** bitcoin-git has left #bitcoin-core-dev
2672018-11-13T17:37:54 *** bitcoin-git has joined #bitcoin-core-dev
2682018-11-13T17:37:54 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14530: Use RPCHelpMan to generate RPC doc strings (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
2692018-11-13T17:37:54 *** bitcoin-git has left #bitcoin-core-dev
2702018-11-13T17:38:24 *** cubancorona has joined #bitcoin-core-dev
2712018-11-13T17:38:30 *** promag has joined #bitcoin-core-dev
2722018-11-13T17:39:01 *** rh0nj has quit IRC
2732018-11-13T17:41:19 *** hebasto has joined #bitcoin-core-dev
2742018-11-13T17:41:59 *** queip has quit IRC
2752018-11-13T17:42:18 *** go1111111 has quit IRC
2762018-11-13T17:44:21 *** go1111111 has joined #bitcoin-core-dev
2772018-11-13T17:46:06 *** ken2812221 has quit IRC
2782018-11-13T17:49:05 *** queip has joined #bitcoin-core-dev
2792018-11-13T17:56:27 *** bitcoin-git has joined #bitcoin-core-dev
2802018-11-13T17:56:27 <bitcoin-git> [bitcoin] Empact closed pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
2812018-11-13T17:56:27 *** bitcoin-git has left #bitcoin-core-dev
2822018-11-13T18:04:36 *** owowo has quit IRC
2832018-11-13T18:10:10 *** promag has quit IRC
2842018-11-13T18:10:43 *** owowo has joined #bitcoin-core-dev
2852018-11-13T18:11:40 *** promag_ has joined #bitcoin-core-dev
2862018-11-13T18:16:35 *** promag_ has quit IRC
2872018-11-13T18:17:28 *** grafcaps has quit IRC
2882018-11-13T18:30:05 *** josephnicholas has joined #bitcoin-core-dev
2892018-11-13T18:36:40 *** grafcaps has joined #bitcoin-core-dev
2902018-11-13T18:42:02 *** queip has quit IRC
2912018-11-13T18:45:52 *** bitconner has joined #bitcoin-core-dev
2922018-11-13T18:48:38 *** tryphe_ is now known as tryphe
2932018-11-13T18:53:13 *** queip has joined #bitcoin-core-dev
2942018-11-13T19:04:55 *** Krellan has joined #bitcoin-core-dev
2952018-11-13T19:05:28 *** grafcaps has quit IRC
2962018-11-13T19:07:22 *** timothy has quit IRC
2972018-11-13T19:09:49 <stevenroose> SendMoney (in rpcwallet) takes a CTxDestination
2982018-11-13T19:10:04 <stevenroose> Is that somehow compatible with OP_RETURN?
2992018-11-13T19:10:17 <stevenroose> Doesn't seem to support it.. Is there a workaround?
3002018-11-13T19:10:24 <stevenroose> sipa: ^?
3012018-11-13T19:10:44 *** ExtraCrispy has quit IRC
3022018-11-13T19:10:49 <stevenroose> Or would I need an extra variant for that?
3032018-11-13T19:11:13 *** ExtraCrispy has joined #bitcoin-core-dev
3042018-11-13T19:13:20 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3052018-11-13T19:14:54 *** josephnicholas has quit IRC
3062018-11-13T19:15:41 <stevenroose> hmm, nvm
3072018-11-13T19:19:24 *** bitcoin-git has joined #bitcoin-core-dev
3082018-11-13T19:19:24 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
3092018-11-13T19:19:24 *** bitcoin-git has left #bitcoin-core-dev
3102018-11-13T19:24:42 *** josephnicholas has joined #bitcoin-core-dev
3112018-11-13T19:28:45 <wumpus> no, CTxDestination doesn't support send-money-into-the-void destination
3122018-11-13T19:29:28 *** josephnicholas has quit IRC
3132018-11-13T19:32:15 <wumpus> could add an extra variant for that, but as there's no address type nor standard representation for that, it's not clear how to fit it in
3142018-11-13T19:34:46 <wumpus> there's CNoDestination but it's used to signal errors
3152018-11-13T19:37:33 *** spinza has quit IRC
3162018-11-13T19:38:11 *** grafcaps has joined #bitcoin-core-dev
3172018-11-13T19:41:12 *** josephnicholas has joined #bitcoin-core-dev
3182018-11-13T19:43:17 *** spinza has joined #bitcoin-core-dev
3192018-11-13T19:46:26 *** josephnicholas has quit IRC
3202018-11-13T19:49:31 *** booyah_ is now known as booyah
3212018-11-13T19:54:58 <wumpus> would probably make sense to move reverse_iterator.h and reverselock.h under util/
3222018-11-13T19:55:44 <sipa> agree
3232018-11-13T19:55:53 <wumpus> and sync.h maybe
3242018-11-13T19:59:03 <sipa> what about prevector and limitedmap?
3252018-11-13T20:01:46 *** josephnicholas has joined #bitcoin-core-dev
3262018-11-13T20:03:15 <wumpus> those qualify as util too imo
3272018-11-13T20:05:25 <sipa> oh and indirectmap
3282018-11-13T20:05:36 <sipa> cuckoocache too
3292018-11-13T20:05:50 <sipa> they're all completely standalone things
3302018-11-13T20:07:46 *** Aaronvan_ has quit IRC
3312018-11-13T20:08:05 <wumpus> yes!
3322018-11-13T20:08:55 *** AaronvanW has joined #bitcoin-core-dev
3332018-11-13T20:09:28 <sipa> in a way, things like logging and cmdline parsing are far more application specific than all those things
3342018-11-13T20:09:58 *** AaronvanW has quit IRC
3352018-11-13T20:11:12 <wumpus> it would almost warrant a separate 'types' directory for data types which are otherwise independent of the OS and application
3362018-11-13T20:11:42 <wumpus> though as we already have 'compat', 'support' and 'util' for util-ish things it'd be kinda overkill
3372018-11-13T20:12:06 <sipa> oh, and span
3382018-11-13T20:12:07 <wumpus> would make sense to have a clear guideline there first
3392018-11-13T20:12:24 <sipa> and memusage :)
3402018-11-13T20:12:39 <sipa> the last one isn't a type definition, but it is completely independent
3412018-11-13T20:13:21 <sipa> perhaps a directory for all "things that totally could be part of the c++ standard library"
3422018-11-13T20:13:56 *** josephnicholas has quit IRC
3432018-11-13T20:14:12 <wumpus> that would include fs.h too
3442018-11-13T20:14:25 *** josephnicholas has joined #bitcoin-core-dev
3452018-11-13T20:14:28 <sipa> ah yes
3462018-11-13T20:14:38 <sipa> utilstrencodings too
3472018-11-13T20:14:53 <wumpus> it's very much different from the data structure ones though as it pulls in a large part of the OS
3482018-11-13T20:15:14 <sipa> and utiltime maybe, if we see it as a simpler std::chrono kind of thing
3492018-11-13T20:15:19 <wumpus> it's more similar to the stuff in compat/ in that regard
3502018-11-13T20:16:20 <wumpus> but all util* just moved to util/, let's not move them so soon again :)
3512018-11-13T20:16:32 <sipa> sure
3522018-11-13T20:16:48 <sipa> but it may make sense for someone to write a proposal for "what things should be in what directory"
3532018-11-13T20:16:54 <sipa> and then do it all at once
3542018-11-13T20:17:06 <wumpus> I don't think that ever works in practice for us
3552018-11-13T20:17:10 <sipa> haha
3562018-11-13T20:17:13 <sipa> perhaps not
3572018-11-13T20:17:39 <sipa> but i very much agree we shouldn't "i think these things belong more here, here is a PR to just move that"
3582018-11-13T20:17:47 <sipa> that ends up going back and forth
3592018-11-13T20:17:54 <wumpus> I was suprised how quickly people agreed on the util/ move, let's not pushit too far
3602018-11-13T20:19:27 *** josephnicholas has quit IRC
3612018-11-13T20:19:54 <wumpus> also true
3622018-11-13T20:20:25 <wumpus> was just surprised how many utilities there are inthe bare /src/ directory, it really doesnt matter that much
3632018-11-13T20:20:38 *** AaronvanW has joined #bitcoin-core-dev
3642018-11-13T20:20:54 <wumpus> certainly not going to open a PR for it :)
3652018-11-13T20:25:03 *** AaronvanW has quit IRC
3662018-11-13T20:25:36 <instagibbs> #14679 probably also ready for merge
3672018-11-13T20:25:38 <gribble> https://github.com/bitcoin/bitcoin/issues/14679 | importmulti: Dont add internal addresses to address book by instagibbs · Pull Request #14679 · bitcoin/bitcoin · GitHub
3682018-11-13T20:35:20 *** bitcoin-git has joined #bitcoin-core-dev
3692018-11-13T20:35:20 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c651265c934c...f617e05c38c9
3702018-11-13T20:35:21 <bitcoin-git> bitcoin/master 7afddfa Gregory Sanders: importmulti: Don't add internal addresses to address book
3712018-11-13T20:35:21 <bitcoin-git> bitcoin/master f617e05 Wladimir J. van der Laan: Merge #14679: importmulti: Don't add internal addresses to address book...
3722018-11-13T20:35:22 *** bitcoin-git has left #bitcoin-core-dev
3732018-11-13T20:36:24 *** bitcoin-git has joined #bitcoin-core-dev
3742018-11-13T20:36:24 <bitcoin-git> [bitcoin] laanwj closed pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
3752018-11-13T20:36:24 *** bitcoin-git has left #bitcoin-core-dev
3762018-11-13T20:38:25 *** Tralfaz has joined #bitcoin-core-dev
3772018-11-13T20:41:48 *** keer4n has quit IRC
3782018-11-13T20:41:58 *** queip has quit IRC
3792018-11-13T20:42:04 *** keer4n has joined #bitcoin-core-dev
3802018-11-13T20:42:04 *** Bullitje_enable has joined #bitcoin-core-dev
3812018-11-13T20:45:59 *** Bullitje has quit IRC
3822018-11-13T20:51:54 *** queip has joined #bitcoin-core-dev
3832018-11-13T21:06:23 *** josephnicholas has joined #bitcoin-core-dev
3842018-11-13T21:08:27 <MarcoFalke> Moved the discussion into an issue, so we don't loose track of that: #14721
3852018-11-13T21:08:29 <gribble> https://github.com/bitcoin/bitcoin/issues/14721 | developer doc: Source code organization for standalone (util) functions · Issue #14721 · bitcoin/bitcoin · GitHub
3862018-11-13T21:11:36 *** Guyver2 has quit IRC
3872018-11-13T21:21:27 *** AaronvanW has joined #bitcoin-core-dev
3882018-11-13T21:26:19 *** Aaronvan_ has joined #bitcoin-core-dev
3892018-11-13T21:30:59 *** AaronvanW has quit IRC
3902018-11-13T21:40:07 *** rh0nj has joined #bitcoin-core-dev
3912018-11-13T21:41:42 *** bitcoin-git has joined #bitcoin-core-dev
3922018-11-13T21:41:42 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14712: wallet: Require a start block in ScanForWalletTransactions (master...Mf1811-walletCrashScan) https://github.com/bitcoin/bitcoin/pull/14712
3932018-11-13T21:41:42 *** bitcoin-git has left #bitcoin-core-dev
3942018-11-13T21:41:55 *** queip has quit IRC
3952018-11-13T21:44:15 *** promag has joined #bitcoin-core-dev
3962018-11-13T21:47:34 *** Murch has joined #bitcoin-core-dev
3972018-11-13T21:49:01 *** queip has joined #bitcoin-core-dev
3982018-11-13T21:51:31 *** bitcoin-git has joined #bitcoin-core-dev
3992018-11-13T21:51:32 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f617e05c38c9...8c59bb85f979
4002018-11-13T21:51:32 <bitcoin-git> bitcoin/master fa0815c Jon Layton: rpc: Correctly name arguments
4012018-11-13T21:51:33 <bitcoin-git> bitcoin/master 8c59bb8 MarcoFalke: Merge #14720: rpc: Correctly name arguments...
4022018-11-13T21:51:33 *** bitcoin-git has left #bitcoin-core-dev
4032018-11-13T21:51:50 *** bitconner has quit IRC
4042018-11-13T21:52:52 *** bitcoin-git has joined #bitcoin-core-dev
4052018-11-13T21:52:52 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
4062018-11-13T21:52:52 *** bitcoin-git has left #bitcoin-core-dev
4072018-11-13T21:53:43 *** bitconner has joined #bitcoin-core-dev
4082018-11-13T21:58:17 *** mistergold has quit IRC
4092018-11-13T22:05:54 *** keer4n has quit IRC
4102018-11-13T22:06:10 *** keer4n has joined #bitcoin-core-dev
4112018-11-13T22:08:59 *** spinza has quit IRC
4122018-11-13T22:12:25 *** spinza has joined #bitcoin-core-dev
4132018-11-13T22:19:42 *** spinza has quit IRC
4142018-11-13T22:19:43 *** Soligor has quit IRC
4152018-11-13T22:20:59 *** rhyslindmark has joined #bitcoin-core-dev
4162018-11-13T22:22:33 *** rhyslindmark has quit IRC
4172018-11-13T22:28:32 *** spinza has joined #bitcoin-core-dev
4182018-11-13T22:28:56 *** promag has quit IRC
4192018-11-13T22:31:08 *** Soligor has joined #bitcoin-core-dev
4202018-11-13T22:33:35 *** josephnicholas has quit IRC
4212018-11-13T22:34:03 *** josephnicholas has joined #bitcoin-core-dev
4222018-11-13T22:35:30 *** Chris_Stewart_5 has quit IRC
4232018-11-13T22:36:54 *** drexl_ has joined #bitcoin-core-dev
4242018-11-13T22:37:18 *** murrayn_ has joined #bitcoin-core-dev
4252018-11-13T22:37:32 *** drexl has quit IRC
4262018-11-13T22:39:04 *** josephnicholas has quit IRC
4272018-11-13T22:40:40 *** murrayn has quit IRC
4282018-11-13T22:41:58 *** queip has quit IRC
4292018-11-13T22:43:35 *** Mutter has joined #bitcoin-core-dev
4302018-11-13T22:46:18 *** Murch has quit IRC
4312018-11-13T22:46:23 *** Mutter has quit IRC
4322018-11-13T22:48:40 *** queip has joined #bitcoin-core-dev
4332018-11-13T22:51:43 *** go1111111 has quit IRC
4342018-11-13T23:04:07 *** bralyclow has joined #bitcoin-core-dev
4352018-11-13T23:04:13 *** go1111111 has joined #bitcoin-core-dev
4362018-11-13T23:09:35 <bralyclow> anyone around, posting a question I need your help with...question everyone, I have a bitcoin core full node and wallet, I tried sending a transaction today from a wallet on the node that spent all the BTC in all associated addresses at 1 satoshi per byte and the transaction has been unconfirmed now for over 8 hours which it should have been picked up by this 8 hour timeframe, my question is how can I increase the fee when ther
4372018-11-13T23:09:36 <bralyclow> e is no BTC left in the wallet and associated addresses and when I try I get this error, "Increasing transaction fee failed (Transaction does not have a change output)" Can I simply deposit 10000 satoshi to an address in that wallet and then try to increase the fee to get it sent, or what can be done and how?
4382018-11-13T23:10:41 *** ExtraCrispy has quit IRC
4392018-11-13T23:10:45 <jarthur> Was it all truly spent, or did you get some back in change? And did you opt for a replaceable/RBF transaction?
4402018-11-13T23:11:04 <jarthur> Also, this is the development channel. #bitcoin is the place to ask general network usage questions.
4412018-11-13T23:11:11 *** ExtraCrispy has joined #bitcoin-core-dev
4422018-11-13T23:15:31 <bralyclow> sorry about asking in here, but yes, all spent, no change or change address created as the fee was to be taken from the total left in that wallet, I did mark the transaction as enable RBF
4432018-11-13T23:21:45 *** promag has joined #bitcoin-core-dev
4442018-11-13T23:33:27 *** TheRec has quit IRC
4452018-11-13T23:34:10 *** TheRec has joined #bitcoin-core-dev
4462018-11-13T23:34:11 *** TheRec has joined #bitcoin-core-dev
4472018-11-13T23:37:39 *** bitcoin-git has joined #bitcoin-core-dev
4482018-11-13T23:37:39 <bitcoin-git> [bitcoin] hebasto opened pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
4492018-11-13T23:37:39 *** bitcoin-git has left #bitcoin-core-dev
4502018-11-13T23:42:01 *** queip has quit IRC
4512018-11-13T23:44:03 *** murrayn has joined #bitcoin-core-dev
4522018-11-13T23:44:09 *** murrayn_ has quit IRC
4532018-11-13T23:51:15 *** queip has joined #bitcoin-core-dev
4542018-11-13T23:54:00 *** josephnicholas has joined #bitcoin-core-dev
4552018-11-13T23:58:31 *** josephnicholas has quit IRC