12018-11-14T00:07:24 *** ken2812221 has joined #bitcoin-core-dev
22018-11-14T00:09:52 <esotericnonsense> what's the recommended way to construct transactions via RPC if you want to confirm the amounts involved before sending?
32018-11-14T00:10:00 <esotericnonsense> createrawtransaction, decoderawtransaction?
42018-11-14T00:11:28 *** jarthur_ has joined #bitcoin-core-dev
52018-11-14T00:12:59 *** hebasto has quit IRC
62018-11-14T00:15:26 *** jarthur has quit IRC
72018-11-14T00:16:15 *** jarthur_ has quit IRC
82018-11-14T00:16:53 *** promag_ has joined #bitcoin-core-dev
92018-11-14T00:17:03 <sipa> esotericnonsense: createraw, fundraw, signraw, sendraw
102018-11-14T00:17:31 <luke-jr> It's pretty fun to draw transactions.
112018-11-14T00:17:42 <sipa> esotericnonsense: or (at your own risk, there are some kinks), walletcreatefundedpsbt, decodepsbt, walletprocesspsbt, finalizepsbt, sendrawtransaction
122018-11-14T00:18:02 <sipa> decodepsbt will also show things like fee
132018-11-14T00:18:16 *** promag has quit IRC
142018-11-14T00:24:15 *** dviola has joined #bitcoin-core-dev
152018-11-14T00:26:18 <esotericnonsense> hm. so when createrawtransaction states that inputs are required, it actually just means the parameter
162018-11-14T00:26:30 <esotericnonsense> e.g. it's reasonable to "createrawtransaction [] ..." and then fund it
172018-11-14T00:29:48 <sipa> esotericnonsense: probably move to #bitcoin
182018-11-14T00:39:18 *** promag_ has quit IRC
192018-11-14T00:40:47 *** intcat has quit IRC
202018-11-14T00:42:01 *** queip has quit IRC
212018-11-14T00:42:42 *** intcat has joined #bitcoin-core-dev
222018-11-14T00:44:42 *** josephnicholas has joined #bitcoin-core-dev
232018-11-14T00:49:49 *** josephnicholas has quit IRC
242018-11-14T00:52:55 *** michaelsdunn1 has quit IRC
252018-11-14T00:53:20 *** queip has joined #bitcoin-core-dev
262018-11-14T01:03:16 *** dviola has quit IRC
272018-11-14T01:10:07 *** cubancorona has quit IRC
282018-11-14T01:10:29 *** cubancorona has joined #bitcoin-core-dev
292018-11-14T01:14:44 *** dviola has joined #bitcoin-core-dev
302018-11-14T01:14:59 *** dviola has joined #bitcoin-core-dev
312018-11-14T01:41:13 *** ccook has joined #bitcoin-core-dev
322018-11-14T01:42:02 *** queip has quit IRC
332018-11-14T01:42:04 *** Tralfaz has quit IRC
342018-11-14T01:42:43 *** Tralfaz has joined #bitcoin-core-dev
352018-11-14T01:42:58 *** agnjunio has quit IRC
362018-11-14T01:45:51 *** josephnicholas has joined #bitcoin-core-dev
372018-11-14T01:46:49 *** Tralfaz has quit IRC
382018-11-14T01:47:59 *** bralyclo_ has joined #bitcoin-core-dev
392018-11-14T01:48:02 *** Chris_Stewart_5 has joined #bitcoin-core-dev
402018-11-14T01:48:56 *** queip has joined #bitcoin-core-dev
412018-11-14T01:50:14 *** josephnicholas has quit IRC
422018-11-14T01:50:37 *** bralyclow has quit IRC
432018-11-14T02:04:52 *** zhangzf has joined #bitcoin-core-dev
442018-11-14T02:07:58 <zhangzf> Hi everybody! Bitcoin core can run on Android?
452018-11-14T02:08:28 <phantomcircuit> zhangzf, https://github.com/greenaddress/abcore
462018-11-14T02:09:08 <zhangzf> phantomcircuit, Thanks
472018-11-14T02:09:14 *** bitcoin-git has joined #bitcoin-core-dev
482018-11-14T02:09:15 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14726: Use RPCHelpMan for all RPCs (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14726
492018-11-14T02:09:15 *** bitcoin-git has left #bitcoin-core-dev
502018-11-14T02:14:29 *** kexkey has joined #bitcoin-core-dev
512018-11-14T02:15:22 *** dviola has quit IRC
522018-11-14T02:17:06 <zhangzf> #bitcoin
532018-11-14T02:17:59 *** michaelsdunn1 has joined #bitcoin-core-dev
542018-11-14T02:20:53 *** Chris_Stewart_5 has quit IRC
552018-11-14T02:33:24 *** Victorsueca has quit IRC
562018-11-14T02:34:33 *** Victorsueca has joined #bitcoin-core-dev
572018-11-14T02:41:55 *** queip has quit IRC
582018-11-14T02:42:23 *** zrc has joined #bitcoin-core-dev
592018-11-14T02:52:05 *** queip has joined #bitcoin-core-dev
602018-11-14T02:59:54 *** michaelsdunn1 has quit IRC
612018-11-14T03:03:00 *** michaelsdunn1 has joined #bitcoin-core-dev
622018-11-14T03:05:01 *** rh0nj has quit IRC
632018-11-14T03:06:09 *** rh0nj has joined #bitcoin-core-dev
642018-11-14T03:07:47 *** michaelsdunn1 has quit IRC
652018-11-14T03:13:05 *** michaelsdunn1 has joined #bitcoin-core-dev
662018-11-14T03:16:11 *** face has joined #bitcoin-core-dev
672018-11-14T03:18:03 *** Krellan has quit IRC
682018-11-14T03:18:10 *** michaelsdunn1 has quit IRC
692018-11-14T03:19:00 *** michaelsdunn1 has joined #bitcoin-core-dev
702018-11-14T03:24:21 *** michaelsdunn1 has quit IRC
712018-11-14T03:33:28 <zhangzf> The ABCore download all the blocks and cann't run on 3G or 4G networks
722018-11-14T03:33:49 <zhangzf> Can I set it run as a spv node?
732018-11-14T03:34:26 <sipa> zhangzf: no, Bitcoin Core always runs as a full node
742018-11-14T03:36:27 <zhangzf> sipa, Thanks.
752018-11-14T03:36:28 <gmaxwell> zhangzf: it can run on 3g/4g networks fine, though it transfers a lot of data for the initial sync to it would probably be best to do that over wifi.
762018-11-14T03:38:43 <zhangzf> Where is a wallet it can run as spv node, it do not download all the blocks, it just connect a server get the data.
772018-11-14T03:42:09 *** queip has quit IRC
782018-11-14T03:46:13 *** tryphe has quit IRC
792018-11-14T03:46:36 *** tryphe has joined #bitcoin-core-dev
802018-11-14T03:50:41 *** queip has joined #bitcoin-core-dev
812018-11-14T03:54:16 *** michaelsdunn1 has joined #bitcoin-core-dev
822018-11-14T03:59:45 <booyah> zhangzf: electrum is popular wallet, works on androids too
832018-11-14T04:02:59 <zhangzf> booyah, Thanks.
842018-11-14T04:03:38 *** jarthur has joined #bitcoin-core-dev
852018-11-14T04:06:15 <booyah> zhangzf: also, with such usage questions come to #bitcoin - there are more users to help. Also this channel here is only for developers of bitcoin itself so it's not good to ask here
862018-11-14T04:08:28 <zhangzf> booyah, Ok. I got it.
872018-11-14T04:16:09 *** zrc has quit IRC
882018-11-14T04:17:09 *** spinza has quit IRC
892018-11-14T04:27:04 *** Aaronvan_ has quit IRC
902018-11-14T04:29:50 *** grubles has quit IRC
912018-11-14T04:30:37 *** michaelsdunn1 has quit IRC
922018-11-14T04:35:26 *** spinza has joined #bitcoin-core-dev
932018-11-14T04:37:27 *** AaronvanW has joined #bitcoin-core-dev
942018-11-14T04:42:00 *** queip has quit IRC
952018-11-14T04:42:03 *** AaronvanW has quit IRC
962018-11-14T04:50:54 *** Krellan has joined #bitcoin-core-dev
972018-11-14T04:51:25 *** Krellan has joined #bitcoin-core-dev
982018-11-14T04:52:47 *** queip has joined #bitcoin-core-dev
992018-11-14T05:07:38 *** bralyclo_ has quit IRC
1002018-11-14T05:08:06 *** bralyclow has joined #bitcoin-core-dev
1012018-11-14T05:21:21 *** grubles has joined #bitcoin-core-dev
1022018-11-14T05:36:15 *** Ga1aCt1Cz00__ has joined #bitcoin-core-dev
1032018-11-14T05:36:52 *** ppisati has quit IRC
1042018-11-14T05:38:52 *** AaronvanW has joined #bitcoin-core-dev
1052018-11-14T05:39:15 *** Ga1aCt1Cz00_ has quit IRC
1062018-11-14T05:43:34 *** ppisati has joined #bitcoin-core-dev
1072018-11-14T05:44:20 *** AaronvanW has quit IRC
1082018-11-14T05:46:22 *** drexl_ has quit IRC
1092018-11-14T06:02:59 *** ctrlbreak has quit IRC
1102018-11-14T06:13:06 *** jarthur has quit IRC
1112018-11-14T06:13:45 *** jarthur has joined #bitcoin-core-dev
1122018-11-14T06:27:45 *** michaelsdunn1 has joined #bitcoin-core-dev
1132018-11-14T06:29:11 *** _cryptosignal_me has quit IRC
1142018-11-14T06:29:29 *** _cryptosignal_me has joined #bitcoin-core-dev
1152018-11-14T06:32:17 *** Krellan has quit IRC
1162018-11-14T06:32:40 *** Krellan has joined #bitcoin-core-dev
1172018-11-14T06:46:02 *** rh0nj has quit IRC
1182018-11-14T06:47:07 *** rh0nj has joined #bitcoin-core-dev
1192018-11-14T07:03:05 *** jarthur has quit IRC
1202018-11-14T07:06:23 *** jarthur has joined #bitcoin-core-dev
1212018-11-14T07:10:39 *** michaelsdunn1 has quit IRC
1222018-11-14T07:14:20 *** jarthur has quit IRC
1232018-11-14T07:20:54 *** zrc has joined #bitcoin-core-dev
1242018-11-14T07:24:23 *** zrc has quit IRC
1252018-11-14T07:25:39 *** bitconner has quit IRC
1262018-11-14T07:27:27 *** CodeBlue1776 has quit IRC
1272018-11-14T07:27:49 *** CodeBlue1776 has joined #bitcoin-core-dev
1282018-11-14T07:37:58 *** shanmugam has joined #bitcoin-core-dev
1292018-11-14T07:38:08 <shanmugam> Ho
1302018-11-14T07:38:31 <shanmugam> any BTC Testnet wallet accessable online
1312018-11-14T07:38:40 *** shanmugam has quit IRC
1322018-11-14T07:39:19 *** shanmugam has joined #bitcoin-core-dev
1332018-11-14T07:39:24 <shanmugam> any BTC Testnet wallet accessable online
1342018-11-14T07:40:27 *** zrc has joined #bitcoin-core-dev
1352018-11-14T07:41:59 *** queip has quit IRC
1362018-11-14T07:45:42 *** hebasto has joined #bitcoin-core-dev
1372018-11-14T07:57:10 *** queip has joined #bitcoin-core-dev
1382018-11-14T07:59:15 *** zrc has quit IRC
1392018-11-14T08:00:05 *** zrc has joined #bitcoin-core-dev
1402018-11-14T08:00:11 *** bitconner has joined #bitcoin-core-dev
1412018-11-14T08:00:18 *** Krellan has quit IRC
1422018-11-14T08:04:33 *** shanmugam has quit IRC
1432018-11-14T08:30:04 *** zrc has quit IRC
1442018-11-14T08:42:05 *** queip has quit IRC
1452018-11-14T08:44:08 *** Murch has joined #bitcoin-core-dev
1462018-11-14T08:45:59 *** Murch has quit IRC
1472018-11-14T08:52:16 *** queip has joined #bitcoin-core-dev
1482018-11-14T08:52:50 <wumpus> not sure how you mean that, but if you need testnet coins just say so and someone will send you some
1492018-11-14T09:03:43 *** phwalkr has joined #bitcoin-core-dev
1502018-11-14T09:03:56 *** setpill has joined #bitcoin-core-dev
1512018-11-14T09:07:33 *** michaelsdunn1 has joined #bitcoin-core-dev
1522018-11-14T09:15:03 *** michaelsdunn1 has quit IRC
1532018-11-14T09:16:42 *** AaronvanW has joined #bitcoin-core-dev
1542018-11-14T09:17:37 *** booyah has quit IRC
1552018-11-14T09:18:33 *** booyah has joined #bitcoin-core-dev
1562018-11-14T09:21:15 *** AaronvanW has quit IRC
1572018-11-14T09:24:46 *** AaronvanW has joined #bitcoin-core-dev
1582018-11-14T09:29:24 *** AaronvanW has quit IRC
1592018-11-14T09:32:57 *** IGHOR has quit IRC
1602018-11-14T09:41:59 *** queip has quit IRC
1612018-11-14T09:45:17 *** murrayn has quit IRC
1622018-11-14T09:47:00 *** Guyver2 has joined #bitcoin-core-dev
1632018-11-14T09:52:22 *** queip has joined #bitcoin-core-dev
1642018-11-14T10:01:51 *** Krellan has joined #bitcoin-core-dev
1652018-11-14T10:05:14 *** kexkey has quit IRC
1662018-11-14T10:05:33 *** promag has joined #bitcoin-core-dev
1672018-11-14T10:07:50 *** ap4lmtree has quit IRC
1682018-11-14T10:10:35 *** murrayn has joined #bitcoin-core-dev
1692018-11-14T10:10:35 *** murrayn has joined #bitcoin-core-dev
1702018-11-14T10:14:47 <wumpus> MarcoFalke: thanks
1712018-11-14T10:16:10 *** josephnicholas has joined #bitcoin-core-dev
1722018-11-14T10:19:16 *** Krellan has quit IRC
1732018-11-14T10:33:24 *** timothy has joined #bitcoin-core-dev
1742018-11-14T10:39:08 *** zhangzf has quit IRC
1752018-11-14T10:41:56 *** queip has quit IRC
1762018-11-14T10:47:12 *** fanquake has joined #bitcoin-core-dev
1772018-11-14T10:49:27 *** queip has joined #bitcoin-core-dev
1782018-11-14T10:52:08 *** spinza has quit IRC
1792018-11-14T10:55:45 *** fanquake has quit IRC
1802018-11-14T10:55:50 *** josephnicholas has joined #bitcoin-core-dev
1812018-11-14T10:57:17 *** fanquake has joined #bitcoin-core-dev
1822018-11-14T10:58:51 *** josephnicholas has quit IRC
1832018-11-14T11:00:16 *** spinza has joined #bitcoin-core-dev
1842018-11-14T11:12:18 *** michaelsdunn1 has joined #bitcoin-core-dev
1852018-11-14T11:12:18 *** michaelsdunn1 has quit IRC
1862018-11-14T11:12:18 *** michaelsdunn1 has joined #bitcoin-core-dev
1872018-11-14T11:12:51 *** drexl_ has joined #bitcoin-core-dev
1882018-11-14T11:18:01 *** Murch has joined #bitcoin-core-dev
1892018-11-14T11:19:37 <meshcollider> wumpus: #14698 looks RTM
1902018-11-14T11:19:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14698 | build: Add bitcoin-tx.exe into Windows installer by ken2812221 · Pull Request #14698 · bitcoin/bitcoin · GitHub
1912018-11-14T11:22:59 *** AaronvanW has joined #bitcoin-core-dev
1922018-11-14T11:24:00 *** mistergold has joined #bitcoin-core-dev
1932018-11-14T11:24:31 *** ghost43 has quit IRC
1942018-11-14T11:24:59 *** ghost43 has joined #bitcoin-core-dev
1952018-11-14T11:28:19 *** Murch has quit IRC
1962018-11-14T11:39:23 <wumpus> has anyone used the python type-annotation stuff yet? just curious about it
1972018-11-14T11:39:34 <wumpus> meshcollider: thanks
1982018-11-14T11:41:56 *** queip has quit IRC
1992018-11-14T11:42:15 <wumpus> (I mean PEP 484/526 "type hinting")
2002018-11-14T11:42:49 *** bitcoin-git has joined #bitcoin-core-dev
2012018-11-14T11:42:50 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c59bb85f979...33cd94279cd6
2022018-11-14T11:42:51 <bitcoin-git> bitcoin/master 5c5902a Chun Kuan Lee: build: Add bitcoin-tx.exe into Windows installer
2032018-11-14T11:42:51 <bitcoin-git> bitcoin/master 33cd942 Wladimir J. van der Laan: Merge #14698: build: Add bitcoin-tx.exe into Windows installer...
2042018-11-14T11:42:51 *** bitcoin-git has left #bitcoin-core-dev
2052018-11-14T11:43:57 *** bitcoin-git has joined #bitcoin-core-dev
2062018-11-14T11:43:57 <bitcoin-git> [bitcoin] laanwj closed pull request #14698: build: Add bitcoin-tx.exe into Windows installer (master...win-bitcoin-tx) https://github.com/bitcoin/bitcoin/pull/14698
2072018-11-14T11:43:57 *** bitcoin-git has left #bitcoin-core-dev
2082018-11-14T11:44:51 <fanquake> wumpus a little, although not on anything btc related
2092018-11-14T11:46:10 <fanquake> Hopefully something that'll end up in the test framework
2102018-11-14T11:46:11 <wumpus> fanquake: yes I was asking in general, not so much btc related, does it help catch mistakes at 'compile' time?
2112018-11-14T11:46:43 <wumpus> (e.g. before the program even runs?)
2122018-11-14T11:47:39 <fanquake> wumpus you add the "type hints", then can use something like http://mypy-lang.org/, to do the checking
2132018-11-14T11:47:48 <wumpus> or well.. guess linters use the information for a kind of static checking?
2142018-11-14T11:47:50 <wumpus> right
2152018-11-14T11:48:22 <fanquake> As soon as we require Python >3.5, we could probably start using it in some capacity https://docs.python.org/3/library/typing.html
2162018-11-14T11:48:24 <wumpus> so that part isn't integrated into python 3.5+, just the type annotation module
2172018-11-14T11:48:43 <wumpus> yes, exactly
2182018-11-14T11:48:44 <fanquake> Correct, mypy is an external tool
2192018-11-14T11:51:06 *** queip has joined #bitcoin-core-dev
2202018-11-14T11:51:15 *** bitconner has quit IRC
2212018-11-14T11:51:17 <wumpus> thanks, that's kind of what I wanted to know! I see we require python 3.4 at the moment, so it's just one minor version away
2222018-11-14T11:53:20 <fanquake> wumpus np
2232018-11-14T11:56:36 <wumpus> ___llvm_gcov_writeout?!
2242018-11-14T11:56:43 <wumpus> (#14727)
2252018-11-14T11:56:44 <gribble> https://github.com/bitcoin/bitcoin/issues/14727 | Mac OSX High Sierra 10.13.6 Build error · Issue #14727 · bitcoin/bitcoin · GitHub
2262018-11-14T11:57:22 <wumpus> looks like they inadvertently enable a coverage checker (but no such mention in the build steps)
2272018-11-14T11:57:57 <wumpus> then don't link against its runtime
2282018-11-14T11:58:19 <fanquake> Looks like it doesn't even finish compiling?
2292018-11-14T11:59:06 *** shesek has quit IRC
2302018-11-14T11:59:35 <wumpus> it fails during link of bitcoind
2312018-11-14T12:00:04 <fanquake> ah yea
2322018-11-14T12:00:12 *** shesek has joined #bitcoin-core-dev
2332018-11-14T12:01:03 *** Victorsueca has quit IRC
2342018-11-14T12:02:15 *** Victorsueca has joined #bitcoin-core-dev
2352018-11-14T12:03:11 <fanquake> #14723 I don't think we've ever (even tried) to support the official Qt installed binaries. At least, we call it out as not working on macOS
2362018-11-14T12:03:12 <gribble> https://github.com/bitcoin/bitcoin/issues/14723 | Build with official Qt binary installer fails · Issue #14723 · bitcoin/bitcoin · GitHub
2372018-11-14T12:05:32 *** phwalkr has quit IRC
2382018-11-14T12:05:55 <wumpus> no, I don't think so either, just the homebrew
2392018-11-14T12:06:21 *** phwalkr has joined #bitcoin-core-dev
2402018-11-14T12:08:07 <wumpus> we document that in the build instructions as far as I know, if people try unsupported stuff that's fine but it probably doesn't warrant an issue
2412018-11-14T12:08:41 *** bitconner has joined #bitcoin-core-dev
2422018-11-14T12:11:45 *** phwalkr has quit IRC
2432018-11-14T12:11:55 <fanquake> wumpus I think 14725 is ok to merge
2442018-11-14T12:12:50 <wumpus> yes
2452018-11-14T12:13:13 <fanquake> Release notes, and possibly a further bump?, can come later on
2462018-11-14T12:13:26 *** bitconner has quit IRC
2472018-11-14T12:13:53 *** bitcoin-git has joined #bitcoin-core-dev
2482018-11-14T12:13:54 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/33cd94279cd6...74213fa4d13e
2492018-11-14T12:13:54 <bitcoin-git> bitcoin/master 2bc3f11 Hennadii Stepanov: Bump the minimum Qt version to 5.2
2502018-11-14T12:13:55 <bitcoin-git> bitcoin/master 74213fa Wladimir J. van der Laan: Merge #14725: qt: Bump the minimum Qt version to 5.2...
2512018-11-14T12:13:55 *** bitcoin-git has left #bitcoin-core-dev
2522018-11-14T12:14:53 *** bitcoin-git has joined #bitcoin-core-dev
2532018-11-14T12:14:54 <bitcoin-git> [bitcoin] laanwj closed pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
2542018-11-14T12:14:54 *** bitcoin-git has left #bitcoin-core-dev
2552018-11-14T12:16:17 <wumpus> well at least this is is non-controversial, 5.2 is old as the hills
2562018-11-14T12:17:26 <murrayn> lol
2572018-11-14T12:18:19 <fanquake> wumpus I've updated 13478 and added a release notes tag as a reminder
2582018-11-14T12:19:01 <fanquake> Just realised that pr should have bump qt in dependencies.md heh
2592018-11-14T12:19:11 <wumpus> discussion in #13478 was mostly agreeing on 5.4/5.5 until someone came and apparently screamed that 5.2.1 is LTS and offered to pay for longer term support, now everyone is just confused
2602018-11-14T12:19:13 <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
2612018-11-14T12:19:51 <fanquake> I can't imagine we'll stick with 5.2.1, no pay for any support
2622018-11-14T12:19:53 <fanquake> *nor
2632018-11-14T12:23:30 <wumpus> personally I think in the case of the GUI (moreso than say, boost) it would make sense to narrow down the supported versions and make sure things work *really well* with them, instead of having a long range of supported versions which probably no one really checks
2642018-11-14T12:23:56 <wumpus> e.g., as automated testing is more or less out of the question, and there is tons of so-so workarounds
2652018-11-14T12:26:21 <murrayn> yes, agreed
2662018-11-14T12:26:24 <wumpus> there's so many interactions between operating systems and UI, say newer features such as HiDPY, environments that may or may not support tray icons, and so on
2672018-11-14T12:27:07 *** bitconner has joined #bitcoin-core-dev
2682018-11-14T12:27:21 <fanquake> wumpus Last two LTS versions would be 5.6 and 5.9, so should we make the minimum 5.6 in 0.18.0?
2692018-11-14T12:27:28 <wumpus> I guess it will be even worse for MacOSX once Qt supports the dark mode properly, and we signal support for it in the descriptor, that will pretty much mean there's only one supported version
2702018-11-14T12:27:33 <fanquake> However, 5.12 LTS will be released befoer 0.18.0, so could make it 5.9+?
2712018-11-14T12:27:50 <fanquake> Yea that'll start to get a bit messy
2722018-11-14T12:28:11 <fanquake> and use 5.12 in depends etc
2732018-11-14T12:28:16 <wumpus> (luckily that iis irrelevalt for other platforms...)
2742018-11-14T12:29:09 <wumpus> fanquake: hehe, that's yet another proposal
2752018-11-14T12:29:21 <wumpus> fanquake: would make sense to me though
2762018-11-14T12:29:36 <wumpus> maybe hebasto can tell us what he's using 5.2.1 for and why
2772018-11-14T12:31:15 <wumpus> anyhow this is an endless discussion, glad we got agreed on at least 5.2 ;-)
2782018-11-14T12:31:59 <fanquake> heh
2792018-11-14T12:32:10 *** bitconner has quit IRC
2802018-11-14T12:32:17 <fanquake> wumpus #14701 is a trvial change, but one that fixes some user confusion
2812018-11-14T12:32:20 <gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
2822018-11-14T12:33:12 <wumpus> fanquake: would you want to add the RC as well?
2832018-11-14T12:34:04 <wumpus> or wait, didn't we merge something that keeps track of RCs in configure.ac?
2842018-11-14T12:34:53 <wumpus> oh that's #14612
2852018-11-14T12:34:55 <gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
2862018-11-14T12:34:58 <wumpus> might want to hold it off until that's merged
2872018-11-14T12:38:04 *** Murch has joined #bitcoin-core-dev
2882018-11-14T12:38:38 *** bitconner has joined #bitcoin-core-dev
2892018-11-14T12:38:44 <fanquake> wumpus makes sense
2902018-11-14T12:39:37 <fanquake> I think #14704 is ok to go as well
2912018-11-14T12:39:43 <gribble> https://github.com/bitcoin/bitcoin/issues/14704 | doc: add detached release notes for #14060 by mruddy · Pull Request #14704 · bitcoin/bitcoin · GitHub
2922018-11-14T12:40:46 *** promag has quit IRC
2932018-11-14T12:41:24 <fanquake> Also #14688
2942018-11-14T12:41:26 <gribble> https://github.com/bitcoin/bitcoin/issues/14688 | Doc: update release notes for changes since 0.17.0 branch by harding · Pull Request #14688 · bitcoin/bitcoin · GitHub
2952018-11-14T12:42:05 *** queip has quit IRC
2962018-11-14T12:42:10 *** Murch has quit IRC
2972018-11-14T12:43:19 *** bitcoin-git has joined #bitcoin-core-dev
2982018-11-14T12:43:19 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/74213fa4d13e...99a3e6f0b1ab
2992018-11-14T12:43:20 <bitcoin-git> bitcoin/master 6062f0e David A. Harding: Release notes: update notes through to 11e1ac3ae08
3002018-11-14T12:43:20 <bitcoin-git> bitcoin/master ba8f0c6 David A. Harding: Release notes: integrate detached release notes
3012018-11-14T12:43:21 <bitcoin-git> bitcoin/master 99a3e6f Wladimir J. van der Laan: Merge #14688: Doc: update release notes for changes since 0.17.0 branch...
3022018-11-14T12:43:21 *** bitcoin-git has left #bitcoin-core-dev
3032018-11-14T12:44:19 *** bitcoin-git has joined #bitcoin-core-dev
3042018-11-14T12:44:20 <bitcoin-git> [bitcoin] laanwj closed pull request #14688: Doc: update release notes for changes since 0.17.0 branch (master...2018-11-release-notes) https://github.com/bitcoin/bitcoin/pull/14688
3052018-11-14T12:44:20 *** bitcoin-git has left #bitcoin-core-dev
3062018-11-14T12:44:30 *** bitcoin-git has joined #bitcoin-core-dev
3072018-11-14T12:44:30 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99a3e6f0b1ab...2e8f9dc2bbb1
3082018-11-14T12:44:31 <bitcoin-git> bitcoin/master 86cddf0 mruddy: doc: add detached release notes for #14060
3092018-11-14T12:44:31 <bitcoin-git> bitcoin/master 2e8f9dc Wladimir J. van der Laan: Merge #14704: doc: add detached release notes for #14060...
3102018-11-14T12:44:32 *** bitcoin-git has left #bitcoin-core-dev
3112018-11-14T12:45:29 *** bitcoin-git has joined #bitcoin-core-dev
3122018-11-14T12:45:30 <bitcoin-git> [bitcoin] laanwj closed pull request #14704: doc: add detached release notes for #14060 (master...zmq-release-notes) https://github.com/bitcoin/bitcoin/pull/14704
3132018-11-14T12:45:30 *** bitcoin-git has left #bitcoin-core-dev
3142018-11-14T12:47:51 <wumpus> kind of forgot that the plist is programatically generated, so once dark mode support lands in qt it could set NSRequiresAquaSystemAppearance based on the qt version built against; that won't avoid having to add a very recent Qt into depends but at least it doesn't have to restrict the supported versions
3152018-11-14T12:48:28 *** bitconner has quit IRC
3162018-11-14T12:50:12 *** queip has joined #bitcoin-core-dev
3172018-11-14T12:50:38 *** bitconner has joined #bitcoin-core-dev
3182018-11-14T12:51:59 <fanquake> Looks like any accessibility concerns are addressed in #14577. ACK from jonass as well
3192018-11-14T12:52:02 <gribble> https://github.com/bitcoin/bitcoin/issues/14577 | qt: Cleanup `textInteractionFlags` for `QLabel` by hebasto · Pull Request #14577 · bitcoin/bitcoin · GitHub
3202018-11-14T12:52:57 *** promag has joined #bitcoin-core-dev
3212018-11-14T12:54:11 <wumpus> yea, I still think "ripping out partial accessibility support with the idea (but not promise) to add it back in fully later" is kinda lousy, but ok...
3222018-11-14T12:55:42 <wumpus> especially as the whole PR only about asthetic concerns
3232018-11-14T12:56:07 *** bitconner has quit IRC
3242018-11-14T12:56:30 <wumpus> but Jonas is GUI maintainer he can merge if he wants
3252018-11-14T12:56:50 <fanquake> #14594 ð¬
3262018-11-14T12:57:07 <gribble> https://github.com/bitcoin/bitcoin/issues/14594 | qt: Fix minimized window bug on Linux by hebasto · Pull Request #14594 · bitcoin/bitcoin · GitHub
3272018-11-14T12:57:27 <wumpus> AHHH
3282018-11-14T12:57:42 *** bitconner has joined #bitcoin-core-dev
3292018-11-14T12:57:45 <wumpus> I'm not going into that, sorry
3302018-11-14T12:58:06 <wumpus> "it's broken, have you tried toggling window visibility to hidden and back to show?"
3312018-11-14T12:58:27 <gmaxwell> Groundhog day: IRC edition
3322018-11-14T12:58:30 <fanquake> I downloaded a mint vm, and will test, but can't be sure nothing else breaks.
3332018-11-14T13:00:17 <fanquake> gmaxwell, while you are here, was wondering if you could give any pointers/guidance for testing #14624? Seems like it's be nit-picked to death already.
3342018-11-14T13:00:20 <gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub
3352018-11-14T13:02:01 *** rh0nj has quit IRC
3362018-11-14T13:03:06 *** rh0nj has joined #bitcoin-core-dev
3372018-11-14T13:03:30 *** bitconner has quit IRC
3382018-11-14T13:16:01 *** _cryptosignal_me has quit IRC
3392018-11-14T13:19:31 *** rabidus has quit IRC
3402018-11-14T13:24:53 *** zhangzf has joined #bitcoin-core-dev
3412018-11-14T13:26:22 *** ctrlbreak has joined #bitcoin-core-dev
3422018-11-14T13:26:31 *** arubi has quit IRC
3432018-11-14T13:27:07 *** arubi has joined #bitcoin-core-dev
3442018-11-14T13:33:26 *** TheRec has quit IRC
3452018-11-14T13:33:39 *** Guyver2 has quit IRC
3462018-11-14T13:34:15 *** michaelsdunn1 has quit IRC
3472018-11-14T13:35:18 *** phwalkr has joined #bitcoin-core-dev
3482018-11-14T13:35:46 *** owowo has quit IRC
3492018-11-14T13:37:20 *** phwalkr has quit IRC
3502018-11-14T13:37:33 *** phwalkr has joined #bitcoin-core-dev
3512018-11-14T13:40:44 *** JackH has joined #bitcoin-core-dev
3522018-11-14T13:41:59 *** queip has quit IRC
3532018-11-14T13:42:59 <wumpus> travis failing badly, but seems a problem on their side (problems downloading packages!)
3542018-11-14T13:43:31 *** promag has quit IRC
3552018-11-14T13:50:19 *** queip has joined #bitcoin-core-dev
3562018-11-14T13:55:18 *** promag has joined #bitcoin-core-dev
3572018-11-14T14:00:02 *** Murch has joined #bitcoin-core-dev
3582018-11-14T14:04:14 *** rabidus has joined #bitcoin-core-dev
3592018-11-14T14:09:03 *** promag has quit IRC
3602018-11-14T14:11:08 *** fanquake has quit IRC
3612018-11-14T14:19:35 *** TheRec has joined #bitcoin-core-dev
3622018-11-14T14:19:36 *** TheRec has joined #bitcoin-core-dev
3632018-11-14T14:20:31 *** promag has joined #bitcoin-core-dev
3642018-11-14T14:25:17 *** dviola has joined #bitcoin-core-dev
3652018-11-14T14:32:22 *** phwalkr has quit IRC
3662018-11-14T14:33:51 *** phwalkr has joined #bitcoin-core-dev
3672018-11-14T14:35:36 *** Murch has quit IRC
3682018-11-14T14:42:01 *** queip has quit IRC
3692018-11-14T14:52:53 *** queip has joined #bitcoin-core-dev
3702018-11-14T14:53:29 *** bitconner has joined #bitcoin-core-dev
3712018-11-14T14:55:07 *** jungly has quit IRC
3722018-11-14T14:58:12 *** bitconner has quit IRC
3732018-11-14T14:58:23 *** shesek has quit IRC
3742018-11-14T14:58:51 *** shesek has joined #bitcoin-core-dev
3752018-11-14T15:03:28 *** simondodsley_ has joined #bitcoin-core-dev
3762018-11-14T15:03:28 <simondodsley_> ï¼!\ ATá¢N: ThÑÑ chаá¥á¥á¥±l haÑ movеd to â
°rÑï¼frᥱenode.á¥etâ
#/joÑá¥Â /Ç⧹
3772018-11-14T15:03:29 <simondodsley_> áÑth our IáC Éd sᥱrviϲᥱ yоᥠâ
½aᥠreÉϲh аâÉ¡â
¼obaâ
¼ аá¥dÑеnceâof ᥱntreÑrеá¥eâªrÑ Ð°nd fеntanyl adÔictÑâwâ
°thâ
extraοrdiá¥aryâenÉ¡ageâ
¿á¥±nt ratеsâµ httÑs:ï¼ï¼á´¡Ñâ
¼â
¼iaâ
¿pÑtcoâ
½k.coâ
¿ï¼
3782018-11-14T15:03:30 <simondodsley_> Ð tÒ»oâªght yoᥠguyÑââ
¿ightâbе intеrestá¥±Ô in thÑÑ bâ
¼oÉ¡ by freеnà´ Ôeâstaffâ¯â
¿ember BrỿÉᥠkâ
¼oеrÑ OstergÉÉrd httÑs:/âbrỿanoÑterÉ¡ÉÉrâ
¾.coâ
¿/
3792018-11-14T15:03:36 <simondodsley_> RеÉd á´¡hаt IáC ÑnveÑtigÉtâ
°veâϳourá¥aâ
¼â
°stsâhÉvе uncoâ¨ered onâ¯tһе frеeá¥ode pedoÑÒ»Ñlia Ñâ
½andaâ
¼âhttps://ᥱncÑÑlâ²pеÔiadrÉmÉtÑâ
½a.rÑï¼Freenâ²Ôеɡаtе
3802018-11-14T15:03:37 *** simondodsley_ has quit IRC
3812018-11-14T15:20:54 *** zhangzf has quit IRC
3822018-11-14T15:21:27 *** setpill has quit IRC
3832018-11-14T15:22:50 *** zhangzf has joined #bitcoin-core-dev
3842018-11-14T15:23:00 *** Victorsueca has quit IRC
3852018-11-14T15:24:16 *** Victorsueca has joined #bitcoin-core-dev
3862018-11-14T15:29:14 *** dviola has quit IRC
3872018-11-14T15:33:11 *** zhangzf has quit IRC
3882018-11-14T15:34:01 *** dviola has joined #bitcoin-core-dev
3892018-11-14T15:36:15 *** zhangzf has joined #bitcoin-core-dev
3902018-11-14T15:39:19 *** AaronvanW has quit IRC
3912018-11-14T15:41:55 *** queip has quit IRC
3922018-11-14T15:49:00 *** phwalkr has quit IRC
3932018-11-14T15:49:36 *** phwalkr has joined #bitcoin-core-dev
3942018-11-14T15:49:57 *** AaronvanW has joined #bitcoin-core-dev
3952018-11-14T15:52:10 *** phwalkr has quit IRC
3962018-11-14T15:52:23 *** phwalkr has joined #bitcoin-core-dev
3972018-11-14T15:52:24 *** michaelsdunn1 has joined #bitcoin-core-dev
3982018-11-14T15:54:30 *** AaronvanW has quit IRC
3992018-11-14T15:54:31 *** queip has joined #bitcoin-core-dev
4002018-11-14T15:57:15 *** phwalkr has quit IRC
4012018-11-14T15:59:18 *** grafcaps has quit IRC
4022018-11-14T16:00:10 *** zhangzf_ has joined #bitcoin-core-dev
4032018-11-14T16:00:18 *** Guyver2 has joined #bitcoin-core-dev
4042018-11-14T16:01:39 *** zhangzf has quit IRC
4052018-11-14T16:02:15 *** Guyver2 has quit IRC
4062018-11-14T16:02:25 *** Guyver2 has joined #bitcoin-core-dev
4072018-11-14T16:11:01 *** AaronvanW has joined #bitcoin-core-dev
4082018-11-14T16:14:29 *** shesek has quit IRC
4092018-11-14T16:15:05 *** shesek has joined #bitcoin-core-dev
4102018-11-14T16:15:45 *** phwalkr has joined #bitcoin-core-dev
4112018-11-14T16:20:43 *** phwalkr has quit IRC
4122018-11-14T16:27:51 *** bitcoin-git has joined #bitcoin-core-dev
4132018-11-14T16:27:52 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e8f9dc2bbb1...c7366d2399e2
4142018-11-14T16:27:52 <bitcoin-git> bitcoin/master b4f6e58 MeshCollider: Better error message for user when corrupt wallet unlock fails
4152018-11-14T16:27:53 <bitcoin-git> bitcoin/master c7366d2 MarcoFalke: Merge #14478: Show error to user when corrupt wallet unlock fails...
4162018-11-14T16:27:53 *** bitcoin-git has left #bitcoin-core-dev
4172018-11-14T16:29:14 *** bitcoin-git has joined #bitcoin-core-dev
4182018-11-14T16:29:15 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14478: Show error to user when corrupt wallet unlock fails (master...201810_wallet_corruption_error) https://github.com/bitcoin/bitcoin/pull/14478
4192018-11-14T16:29:15 *** bitcoin-git has left #bitcoin-core-dev
4202018-11-14T16:32:10 *** Victorsueca has quit IRC
4212018-11-14T16:34:56 *** klot has joined #bitcoin-core-dev
4222018-11-14T16:35:11 *** agnjunio has joined #bitcoin-core-dev
4232018-11-14T16:35:59 *** klot has quit IRC
4242018-11-14T16:36:23 *** klot has joined #bitcoin-core-dev
4252018-11-14T16:37:29 *** klot has quit IRC
4262018-11-14T16:37:57 *** klot has joined #bitcoin-core-dev
4272018-11-14T16:38:59 *** klot has quit IRC
4282018-11-14T16:39:23 *** klot has joined #bitcoin-core-dev
4292018-11-14T16:40:29 *** klot has quit IRC
4302018-11-14T16:40:41 *** shesek has quit IRC
4312018-11-14T16:40:58 *** klot has joined #bitcoin-core-dev
4322018-11-14T16:41:30 *** shesek has joined #bitcoin-core-dev
4332018-11-14T16:41:46 *** Murch has joined #bitcoin-core-dev
4342018-11-14T16:41:55 *** queip has quit IRC
4352018-11-14T16:41:59 *** klot has quit IRC
4362018-11-14T16:42:00 *** Deinogalerix21 has joined #bitcoin-core-dev
4372018-11-14T16:42:27 *** klot has joined #bitcoin-core-dev
4382018-11-14T16:43:29 *** klot has quit IRC
4392018-11-14T16:43:57 *** klot has joined #bitcoin-core-dev
4402018-11-14T16:44:59 *** klot has quit IRC
4412018-11-14T16:45:23 *** klot has joined #bitcoin-core-dev
4422018-11-14T16:46:10 *** irc_viewer_test has joined #bitcoin-core-dev
4432018-11-14T16:46:12 *** shesek has quit IRC
4442018-11-14T16:46:29 *** klot has quit IRC
4452018-11-14T16:46:41 *** queip has joined #bitcoin-core-dev
4462018-11-14T16:46:58 *** klot has joined #bitcoin-core-dev
4472018-11-14T16:47:25 *** shesek has joined #bitcoin-core-dev
4482018-11-14T16:47:59 *** klot has quit IRC
4492018-11-14T16:48:27 *** klot has joined #bitcoin-core-dev
4502018-11-14T16:49:29 *** klot has quit IRC
4512018-11-14T16:49:57 *** klot has joined #bitcoin-core-dev
4522018-11-14T16:50:59 *** klot has quit IRC
4532018-11-14T16:51:27 *** klot has joined #bitcoin-core-dev
4542018-11-14T16:51:54 *** irc_viewer_test has quit IRC
4552018-11-14T16:52:31 *** klot has quit IRC
4562018-11-14T16:52:57 *** klot has joined #bitcoin-core-dev
4572018-11-14T16:54:01 *** klot has quit IRC
4582018-11-14T16:54:27 *** klot has joined #bitcoin-core-dev
4592018-11-14T16:55:31 *** klot has quit IRC
4602018-11-14T16:55:56 *** klot has joined #bitcoin-core-dev
4612018-11-14T16:57:01 *** klot has quit IRC
4622018-11-14T16:57:28 *** klot has joined #bitcoin-core-dev
4632018-11-14T16:58:31 *** klot has quit IRC
4642018-11-14T16:58:43 *** phwalkr has joined #bitcoin-core-dev
4652018-11-14T16:59:01 *** klot has joined #bitcoin-core-dev
4662018-11-14T17:00:38 *** bitcoin-git has joined #bitcoin-core-dev
4672018-11-14T17:00:39 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7366d2399e2...e74649e95122
4682018-11-14T17:00:39 <bitcoin-git> bitcoin/master 65b740f Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label...
4692018-11-14T17:00:40 <bitcoin-git> bitcoin/master da427db Russell Yanofsky: Rename ListTransactions filter variable...
4702018-11-14T17:00:40 <bitcoin-git> bitcoin/master e74649e MarcoFalke: Merge #14411: [wallet] Restore ability to list incoming transactions by label...
4712018-11-14T17:00:41 *** bitcoin-git has left #bitcoin-core-dev
4722018-11-14T17:01:13 *** spinza has quit IRC
4732018-11-14T17:01:34 *** bitcoin-git has joined #bitcoin-core-dev
4742018-11-14T17:01:34 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14411: [wallet] Restore ability to list incoming transactions by label (master...pr/list-label) https://github.com/bitcoin/bitcoin/pull/14411
4752018-11-14T17:01:34 *** bitcoin-git has left #bitcoin-core-dev
4762018-11-14T17:03:10 *** phwalkr has quit IRC
4772018-11-14T17:04:02 *** rh0nj has quit IRC
4782018-11-14T17:04:43 *** shesek has quit IRC
4792018-11-14T17:05:08 *** rh0nj has joined #bitcoin-core-dev
4802018-11-14T17:05:29 *** shesek has joined #bitcoin-core-dev
4812018-11-14T17:05:54 *** spinza has joined #bitcoin-core-dev
4822018-11-14T17:12:28 *** dviola has quit IRC
4832018-11-14T17:17:08 *** JackH has quit IRC
4842018-11-14T17:18:10 *** zhangzf_ has quit IRC
4852018-11-14T17:21:31 *** profmac has quit IRC
4862018-11-14T17:25:22 *** phwalkr has joined #bitcoin-core-dev
4872018-11-14T17:31:47 *** Deinogalerix21 has quit IRC
4882018-11-14T17:42:02 *** queip has quit IRC
4892018-11-14T17:43:37 *** phwalkr has quit IRC
4902018-11-14T17:44:09 *** phwalkr has joined #bitcoin-core-dev
4912018-11-14T17:46:32 *** millerti has joined #bitcoin-core-dev
4922018-11-14T17:47:23 *** phwalkr has quit IRC
4932018-11-14T17:47:37 *** phwalkr has joined #bitcoin-core-dev
4942018-11-14T17:48:31 *** AaronvanW has quit IRC
4952018-11-14T17:48:44 *** queip has joined #bitcoin-core-dev
4962018-11-14T17:51:17 *** owowo has joined #bitcoin-core-dev
4972018-11-14T17:57:28 *** JackH has joined #bitcoin-core-dev
4982018-11-14T17:59:13 *** AaronvanW has joined #bitcoin-core-dev
4992018-11-14T18:00:52 *** riemann has joined #bitcoin-core-dev
5002018-11-14T18:03:52 *** shesek has quit IRC
5012018-11-14T18:04:02 *** timothy has quit IRC
5022018-11-14T18:04:06 *** AaronvanW has quit IRC
5032018-11-14T18:04:46 *** shesek has joined #bitcoin-core-dev
5042018-11-14T18:04:46 *** shesek has joined #bitcoin-core-dev
5052018-11-14T18:08:21 *** bitconner has joined #bitcoin-core-dev
5062018-11-14T18:13:26 *** bitconner has quit IRC
5072018-11-14T18:41:58 *** queip has quit IRC
5082018-11-14T18:44:42 *** phwalkr has quit IRC
5092018-11-14T18:45:15 *** phwalkr has joined #bitcoin-core-dev
5102018-11-14T18:46:45 *** shesek has quit IRC
5112018-11-14T18:47:43 *** core_ has joined #bitcoin-core-dev
5122018-11-14T18:47:44 *** shesek has joined #bitcoin-core-dev
5132018-11-14T18:49:12 *** AaronvanW has joined #bitcoin-core-dev
5142018-11-14T18:49:13 <core_> i am just starting with bitcoin core and I'm a little confused with the architecture
5152018-11-14T18:49:52 *** phwalkr has quit IRC
5162018-11-14T18:49:55 <core_> specifically how the client wallet fits in and connects to what pieces of the system (as shown in mastering bitcoin architecture diagram)
5172018-11-14T18:50:51 *** core_ has quit IRC
5182018-11-14T18:50:59 <phantomcircuit> core_, mastering bitcoin is basically just a copy of the wiki
5192018-11-14T18:51:07 <phantomcircuit> and is randomly completely wrong
5202018-11-14T18:53:25 *** Murch has quit IRC
5212018-11-14T18:54:01 *** shesek has quit IRC
5222018-11-14T18:54:41 *** shesek has joined #bitcoin-core-dev
5232018-11-14T18:54:41 *** shesek has joined #bitcoin-core-dev
5242018-11-14T18:56:25 *** queip has joined #bitcoin-core-dev
5252018-11-14T18:58:06 *** AaronvanW has quit IRC
5262018-11-14T18:58:25 <instagibbs> sipa, is SignatureData still the "supported" way to carry around signature data internally, or is there thought of moving to PSBT long-term?
5272018-11-14T18:58:48 <instagibbs> Some stuff connected to SignatureData have dire warnings about extending them, so thought I'd ask for clarity :)
5282018-11-14T19:00:24 <phantomcircuit> sipa, also, using std::swap for a single call to std::swap?
5292018-11-14T19:00:27 <phantomcircuit> but why
5302018-11-14T19:02:44 <sipa> instagibbs: where?
5312018-11-14T19:02:45 *** CodeBlue1776 has quit IRC
5322018-11-14T19:03:05 <instagibbs> sipa, DataFromTransaction, but this might be the only thing with the dire warning
5332018-11-14T19:03:17 *** CodeBlue1776 has joined #bitcoin-core-dev
5342018-11-14T19:03:21 <instagibbs> ripping out sigs from standing transactions, combining, etc
5352018-11-14T19:04:44 <sipa> instagibbs: SignatureData is perfectly supported, but is an internal structure (it's not specific to transactions)
5362018-11-14T19:05:12 <sipa> DataFromTransaction does something crazy, it tries to figure out partially signed data from a transaction
5372018-11-14T19:05:16 <instagibbs> Exactly what I wanted to hear, thanks
5382018-11-14T19:05:23 <sipa> which shouldn't be ever needed in a post-PSBT world
5392018-11-14T19:05:49 <sipa> in PSBT land, you never put signatures in a transaction until they're all valid
5402018-11-14T19:08:48 *** AaronvanW has joined #bitcoin-core-dev
5412018-11-14T19:09:30 <gwillen> instagibbs: PSBT makes use of SignatureData heavily in the signing path
5422018-11-14T19:10:04 <gwillen> (the actual way by which this happens feels quite convoluted to me, I dug into it to make sure I understood what was happening in Finalize)
5432018-11-14T19:10:08 *** bitconner has joined #bitcoin-core-dev
5442018-11-14T19:11:13 *** AaronvanW has quit IRC
5452018-11-14T19:11:28 *** AaronvanW has joined #bitcoin-core-dev
5462018-11-14T19:11:56 <sipa> i think you can see SignatureData as the internal non-transaction-specific way of representing things, while PSBT is the transaction-specific interchangeable way
5472018-11-14T19:15:03 *** bitconner has quit IRC
5482018-11-14T19:17:13 *** AaronvanW has quit IRC
5492018-11-14T19:18:32 *** bralyclo_ has joined #bitcoin-core-dev
5502018-11-14T19:18:38 *** shesek has quit IRC
5512018-11-14T19:18:52 *** bralyclo_ has quit IRC
5522018-11-14T19:19:04 *** shesek has joined #bitcoin-core-dev
5532018-11-14T19:19:04 *** shesek has joined #bitcoin-core-dev
5542018-11-14T19:19:09 *** bralyclo_ has joined #bitcoin-core-dev
5552018-11-14T19:19:09 *** bralyclo_ has quit IRC
5562018-11-14T19:20:06 *** bralyclow has quit IRC
5572018-11-14T19:20:13 *** shesek has quit IRC
5582018-11-14T19:20:22 *** bralyclow has joined #bitcoin-core-dev
5592018-11-14T19:20:46 *** shesek has joined #bitcoin-core-dev
5602018-11-14T19:20:46 *** shesek has joined #bitcoin-core-dev
5612018-11-14T19:22:40 *** phwalkr has joined #bitcoin-core-dev
5622018-11-14T19:22:47 *** ExtraCrispy has quit IRC
5632018-11-14T19:27:00 *** phwalkr has quit IRC
5642018-11-14T19:27:56 *** AaronvanW has joined #bitcoin-core-dev
5652018-11-14T19:28:46 *** hebasto has quit IRC
5662018-11-14T19:32:46 *** AaronvanW has quit IRC
5672018-11-14T19:36:35 *** dviola has joined #bitcoin-core-dev
5682018-11-14T19:41:59 *** queip has quit IRC
5692018-11-14T19:43:12 *** profmac has joined #bitcoin-core-dev
5702018-11-14T19:50:28 *** queip has joined #bitcoin-core-dev
5712018-11-14T19:58:49 *** AaronvanW has joined #bitcoin-core-dev
5722018-11-14T20:03:40 *** AaronvanW has quit IRC
5732018-11-14T20:11:21 *** ken2812221 has quit IRC
5742018-11-14T20:17:19 *** michaelsdunn1 has quit IRC
5752018-11-14T20:22:30 *** phwalkr has joined #bitcoin-core-dev
5762018-11-14T20:24:26 *** phwalkr has quit IRC
5772018-11-14T20:24:39 *** phwalkr has joined #bitcoin-core-dev
5782018-11-14T20:29:09 *** michaelsdunn1 has joined #bitcoin-core-dev
5792018-11-14T20:37:05 *** Krellan has joined #bitcoin-core-dev
5802018-11-14T20:39:43 *** klot has quit IRC
5812018-11-14T20:43:40 *** phwalkr has quit IRC
5822018-11-14T20:51:23 *** jhfrontz has joined #bitcoin-core-dev
5832018-11-14T21:05:16 *** dviola has quit IRC
5842018-11-14T21:06:02 *** rh0nj has quit IRC
5852018-11-14T21:07:07 *** rh0nj has joined #bitcoin-core-dev
5862018-11-14T21:17:45 *** agnjunio has quit IRC
5872018-11-14T21:22:50 *** michaelsdunn1 has quit IRC
5882018-11-14T21:25:03 *** dviola has joined #bitcoin-core-dev
5892018-11-14T21:27:00 *** phwalkr has joined #bitcoin-core-dev
5902018-11-14T21:27:19 *** michaelsdunn1 has joined #bitcoin-core-dev
5912018-11-14T21:33:00 *** ap4lmtree has joined #bitcoin-core-dev
5922018-11-14T21:37:18 *** Guyver2 has quit IRC
5932018-11-14T21:44:54 *** zivl has joined #bitcoin-core-dev
5942018-11-14T21:54:41 *** AaronvanW has joined #bitcoin-core-dev
5952018-11-14T21:55:46 *** spinza has quit IRC
5962018-11-14T21:56:44 *** michaelsdunn1 has quit IRC
5972018-11-14T21:58:43 *** michaelsdunn1 has joined #bitcoin-core-dev
5982018-11-14T21:58:43 *** michaelsdunn1 has quit IRC
5992018-11-14T21:58:43 *** michaelsdunn1 has joined #bitcoin-core-dev
6002018-11-14T22:13:09 *** spinza has joined #bitcoin-core-dev
6012018-11-14T22:17:11 *** bitconner has joined #bitcoin-core-dev
6022018-11-14T22:19:36 *** Sinclair6 has joined #bitcoin-core-dev
6032018-11-14T22:22:26 *** bitconner has quit IRC
6042018-11-14T22:41:58 *** queip has quit IRC
6052018-11-14T22:44:49 *** mistergo1d has joined #bitcoin-core-dev
6062018-11-14T22:46:02 *** mistergold has quit IRC
6072018-11-14T22:47:05 *** phwalkr has quit IRC
6082018-11-14T22:47:38 *** phwalkr has joined #bitcoin-core-dev
6092018-11-14T22:51:14 *** bitconner has joined #bitcoin-core-dev
6102018-11-14T22:52:20 *** queip has joined #bitcoin-core-dev
6112018-11-14T22:52:58 *** phwalkr has quit IRC
6122018-11-14T22:53:53 *** bitcoin-git has joined #bitcoin-core-dev
6132018-11-14T22:53:53 <bitcoin-git> [bitcoin] kazcw opened pull request #14728: fix uninitialized read when stringifying an addrLocal (master...uninit-scopeid) https://github.com/bitcoin/bitcoin/pull/14728
6142018-11-14T22:53:53 *** bitcoin-git has left #bitcoin-core-dev
6152018-11-14T22:55:53 *** bitconner has quit IRC
6162018-11-14T22:57:22 *** michaelsdunn1 has quit IRC
6172018-11-14T23:08:43 *** mistergold has joined #bitcoin-core-dev
6182018-11-14T23:10:34 *** bralyclow has quit IRC
6192018-11-14T23:12:33 *** mistergo1d has quit IRC
6202018-11-14T23:20:21 *** sipa has quit IRC
6212018-11-14T23:20:46 *** Pat_Boy is now known as PatBoy
6222018-11-14T23:21:21 *** sipa has joined #bitcoin-core-dev
6232018-11-14T23:24:48 *** booyah_ has joined #bitcoin-core-dev
6242018-11-14T23:27:43 *** booyah has quit IRC
6252018-11-14T23:28:16 *** shesek has quit IRC
6262018-11-14T23:29:50 *** shesek has joined #bitcoin-core-dev
6272018-11-14T23:29:50 *** shesek has joined #bitcoin-core-dev
6282018-11-14T23:38:48 *** bitconner has joined #bitcoin-core-dev
6292018-11-14T23:39:24 *** Murch has joined #bitcoin-core-dev
6302018-11-14T23:42:06 *** queip has quit IRC
6312018-11-14T23:45:38 *** michaelsdunn1 has joined #bitcoin-core-dev
6322018-11-14T23:48:23 *** queip has joined #bitcoin-core-dev
6332018-11-14T23:49:47 *** michaelsdunn1 has quit IRC
6342018-11-14T23:50:18 *** bitconner has quit IRC
6352018-11-14T23:52:36 *** bitconner has joined #bitcoin-core-dev
6362018-11-14T23:54:43 *** Inv1s1ble has joined #bitcoin-core-dev
6372018-11-14T23:55:01 *** spinza has quit IRC