12018-11-15T00:05:04 *** cubancorona has quit IRC
22018-11-15T00:06:24 *** bralyclow has joined #bitcoin-core-dev
32018-11-15T00:13:53 *** spinza has joined #bitcoin-core-dev
42018-11-15T00:16:39 *** TheRec has quit IRC
52018-11-15T00:16:43 *** shesek has quit IRC
62018-11-15T00:17:19 *** shesek has joined #bitcoin-core-dev
72018-11-15T00:17:19 *** shesek has joined #bitcoin-core-dev
82018-11-15T00:17:33 *** owowo has quit IRC
92018-11-15T00:21:56 *** TheRec has joined #bitcoin-core-dev
102018-11-15T00:21:56 *** TheRec has joined #bitcoin-core-dev
112018-11-15T00:23:03 *** owowo has joined #bitcoin-core-dev
122018-11-15T00:26:11 *** shesek has quit IRC
132018-11-15T00:26:40 *** shesek has joined #bitcoin-core-dev
142018-11-15T00:26:40 *** shesek has joined #bitcoin-core-dev
152018-11-15T00:41:55 *** queip has quit IRC
162018-11-15T00:46:49 *** mistergold has quit IRC
172018-11-15T00:51:34 *** queip has joined #bitcoin-core-dev
182018-11-15T00:56:04 *** zhangzf has joined #bitcoin-core-dev
192018-11-15T01:03:12 *** shesek has quit IRC
202018-11-15T01:04:08 *** shesek has joined #bitcoin-core-dev
212018-11-15T01:04:57 *** lnostdal has quit IRC
222018-11-15T01:08:11 *** lnostdal has joined #bitcoin-core-dev
232018-11-15T01:11:16 *** shesek has quit IRC
242018-11-15T01:11:29 *** Murch has quit IRC
252018-11-15T01:12:00 *** shesek has joined #bitcoin-core-dev
262018-11-15T01:12:00 *** shesek has joined #bitcoin-core-dev
272018-11-15T01:14:55 *** shesek has quit IRC
282018-11-15T01:15:21 *** shesek has joined #bitcoin-core-dev
292018-11-15T01:15:29 *** shesek has quit IRC
302018-11-15T01:15:29 *** shesek has joined #bitcoin-core-dev
312018-11-15T01:20:52 *** shesek has quit IRC
322018-11-15T01:21:48 *** shesek has joined #bitcoin-core-dev
332018-11-15T01:38:15 *** shesek has quit IRC
342018-11-15T01:38:40 *** shesek has joined #bitcoin-core-dev
352018-11-15T01:41:57 *** queip has quit IRC
362018-11-15T01:45:35 *** instagibbs has quit IRC
372018-11-15T01:46:41 *** queip has joined #bitcoin-core-dev
382018-11-15T01:54:06 *** Sinclai__ has joined #bitcoin-core-dev
392018-11-15T01:57:11 *** Sinclair6 has quit IRC
402018-11-15T02:08:37 *** promag has quit IRC
412018-11-15T02:18:43 *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
422018-11-15T02:21:50 *** Ga1aCt1Cz00__ has quit IRC
432018-11-15T02:22:51 *** instagibbs has joined #bitcoin-core-dev
442018-11-15T02:23:09 <esotericnonsense> is it expected behaviour that repeated calls to fundrawtransaction will result in new change addresses being used even if the set of inputs is identical?
452018-11-15T02:25:06 <sipa> define "set of inputs is identical" ?
462018-11-15T02:25:42 <sipa> ah, you're calling fundrawtransaction with the same input multiple times?
472018-11-15T02:26:06 <esotericnonsense> yes, basically it'll use the exact same coins as inputs each time (unless the algo was non-deterministic, why wouldn't it)
482018-11-15T02:26:09 <sipa> yes, those change addresses are marked in use by the fundrawtransaction RPC, regardless of whether the resulting transaction is broadcast or not
492018-11-15T02:26:12 <esotericnonsense> and then just burn through change addresses
502018-11-15T02:26:34 <esotericnonsense> hm. okay. I guess I need to getnewaddress and handle that manually.
512018-11-15T02:27:05 <sipa> use getrawchangeaddress instead
522018-11-15T02:27:29 <esotericnonsense> aha.
532018-11-15T02:31:06 <esotericnonsense> so you end up with a workflow a bit like this then; getrawchangeaddress (store this in a DB or whatever); do a bunch of fundrawtransactions with that change address; once you're happy, do "ismine" checks (e.g. look at getaddressinfo, listreceivedbyaddress) immediately prior to signing
542018-11-15T02:31:52 <sipa> or you can use PSBT
552018-11-15T02:32:32 <sipa> https://github.com/bitcoin/bitcoin/blob/master/doc/psbt.md
562018-11-15T02:33:19 <esotericnonsense> it seems that PSBT doesn't really add anything for the single-signature case
572018-11-15T02:33:46 <sipa> decodepsbt will tell you the fee explicitly, for example
582018-11-15T02:33:54 <sipa> something that decoderawtransaction can't do
592018-11-15T02:34:38 <sipa> but fair, its advantages are more relevant in multiparty or at least multi-device settings
602018-11-15T02:35:23 <esotericnonsense> yeah, though maybe it makes sense to just use it, walletcreatefundedpsbt seems to do basically what I'm after in one step
612018-11-15T02:36:02 *** dqx_ has joined #bitcoin-core-dev
622018-11-15T02:37:03 <esotericnonsense> i'm just trying to avoid reinventing the wheel since it feels like holding this change address around is a bit silly; I almost want a transaction that has a dummy change address in it that's invalid but otherwise would have the same fee, so that bitcoind could just swap out the dummy for a real change address immediately prior to signing, then there's no external state
632018-11-15T02:41:58 *** queip has quit IRC
642018-11-15T02:42:19 *** lnostdal has quit IRC
652018-11-15T02:46:08 *** crrod has joined #bitcoin-core-dev
662018-11-15T02:46:31 *** crrod has quit IRC
672018-11-15T02:47:27 *** millerti has quit IRC
682018-11-15T02:48:29 *** crrod has joined #bitcoin-core-dev
692018-11-15T02:50:16 *** queip has joined #bitcoin-core-dev
702018-11-15T02:50:55 *** crrod has quit IRC
712018-11-15T02:51:20 *** crrod has joined #bitcoin-core-dev
722018-11-15T02:52:13 *** crrod has quit IRC
732018-11-15T02:53:10 *** crrod has joined #bitcoin-core-dev
742018-11-15T02:53:44 *** crrod has quit IRC
752018-11-15T02:55:51 *** crrod has joined #bitcoin-core-dev
762018-11-15T02:55:57 *** AaronvanW has quit IRC
772018-11-15T02:58:54 *** dviola has quit IRC
782018-11-15T03:11:48 *** rhavar has joined #bitcoin-core-dev
792018-11-15T03:24:53 *** crrod has quit IRC
802018-11-15T03:26:16 *** crrod has joined #bitcoin-core-dev
812018-11-15T03:28:27 *** unusuario has joined #bitcoin-core-dev
822018-11-15T03:30:46 *** crrod has quit IRC
832018-11-15T03:35:00 *** drexl_ has quit IRC
842018-11-15T03:41:56 *** queip has quit IRC
852018-11-15T03:53:23 *** queip has joined #bitcoin-core-dev
862018-11-15T04:06:28 *** bitcoin-git has joined #bitcoin-core-dev
872018-11-15T04:06:28 <bitcoin-git> [bitcoin] qubenix opened pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
882018-11-15T04:06:28 *** bitcoin-git has left #bitcoin-core-dev
892018-11-15T04:07:51 *** unusuario has left #bitcoin-core-dev
902018-11-15T04:09:12 *** klot has joined #bitcoin-core-dev
912018-11-15T04:09:59 *** klot has quit IRC
922018-11-15T04:10:29 *** klot has joined #bitcoin-core-dev
932018-11-15T04:11:30 *** klot has quit IRC
942018-11-15T04:11:55 *** klot has joined #bitcoin-core-dev
952018-11-15T04:13:00 *** klot has quit IRC
962018-11-15T04:14:06 *** shesek has quit IRC
972018-11-15T04:14:45 *** shesek has joined #bitcoin-core-dev
982018-11-15T04:14:45 *** shesek has joined #bitcoin-core-dev
992018-11-15T04:22:58 *** instagibbs has quit IRC
1002018-11-15T04:31:13 *** instagibbs has joined #bitcoin-core-dev
1012018-11-15T04:59:21 *** phwalkr has joined #bitcoin-core-dev
1022018-11-15T05:03:45 *** phwalkr has quit IRC
1032018-11-15T05:42:03 *** queip has quit IRC
1042018-11-15T05:44:09 *** shesek has quit IRC
1052018-11-15T05:44:56 *** shesek has joined #bitcoin-core-dev
1062018-11-15T05:44:56 *** shesek has joined #bitcoin-core-dev
1072018-11-15T05:55:02 *** rh0nj has quit IRC
1082018-11-15T05:55:04 *** queip has joined #bitcoin-core-dev
1092018-11-15T05:56:08 *** rh0nj has joined #bitcoin-core-dev
1102018-11-15T05:59:16 *** warren has quit IRC
1112018-11-15T05:59:16 *** BlueMatt has quit IRC
1122018-11-15T05:59:26 *** takinbo has quit IRC
1132018-11-15T05:59:45 *** vaishali_ has joined #bitcoin-core-dev
1142018-11-15T05:59:51 *** dqx has quit IRC
1152018-11-15T05:59:59 *** vaishali_ has quit IRC
1162018-11-15T06:00:14 *** ryanofsky_ has joined #bitcoin-core-dev
1172018-11-15T06:00:18 *** mariorz has quit IRC
1182018-11-15T06:00:25 *** warren has joined #bitcoin-core-dev
1192018-11-15T06:00:26 *** jrayhawk has quit IRC
1202018-11-15T06:00:29 *** warren has quit IRC
1212018-11-15T06:00:29 *** warren has joined #bitcoin-core-dev
1222018-11-15T06:00:38 *** takinbo has joined #bitcoin-core-dev
1232018-11-15T06:00:42 *** jrayhawk has joined #bitcoin-core-dev
1242018-11-15T06:00:50 *** dqx has joined #bitcoin-core-dev
1252018-11-15T06:00:52 *** mariorz has joined #bitcoin-core-dev
1262018-11-15T06:00:57 *** ryanofsky has quit IRC
1272018-11-15T06:01:34 *** BlueMatt has joined #bitcoin-core-dev
1282018-11-15T06:01:35 *** bralyclow has quit IRC
1292018-11-15T06:02:29 *** bralyclow has joined #bitcoin-core-dev
1302018-11-15T06:36:41 *** jhfrontz has quit IRC
1312018-11-15T06:41:56 *** queip has quit IRC
1322018-11-15T06:53:13 *** queip has joined #bitcoin-core-dev
1332018-11-15T07:02:08 *** wpaulino has quit IRC
1342018-11-15T07:02:18 *** bitconner has quit IRC
1352018-11-15T07:02:25 *** wpaulino has joined #bitcoin-core-dev
1362018-11-15T07:08:00 *** JustTesting has joined #bitcoin-core-dev
1372018-11-15T07:12:19 *** JustTesting has quit IRC
1382018-11-15T07:18:00 *** promag has joined #bitcoin-core-dev
1392018-11-15T07:18:10 *** promag has quit IRC
1402018-11-15T07:19:27 *** jhfrontz has joined #bitcoin-core-dev
1412018-11-15T07:26:23 *** Guest64655 is now known as iphelix
1422018-11-15T07:26:23 *** iphelix has joined #bitcoin-core-dev
1432018-11-15T07:30:38 *** promag has joined #bitcoin-core-dev
1442018-11-15T07:38:01 *** Guyver2 has joined #bitcoin-core-dev
1452018-11-15T07:41:16 *** jkjk has joined #bitcoin-core-dev
1462018-11-15T07:41:26 <jkjk> hi
1472018-11-15T07:41:58 *** queip has quit IRC
1482018-11-15T07:42:57 *** jkjk has quit IRC
1492018-11-15T07:47:18 <sipa> hi
1502018-11-15T07:48:06 <gmaxwell> hi
1512018-11-15T07:48:16 <gmaxwell> is it time for the new midnight meeting?
1522018-11-15T07:51:27 *** promag has quit IRC
1532018-11-15T07:54:20 *** queip has joined #bitcoin-core-dev
1542018-11-15T07:55:24 *** fanquake has joined #bitcoin-core-dev
1552018-11-15T07:55:47 <gwillen> gmaxwell: it seems like midnightmagic would need to moderate, for reasons of nominative determinism
1562018-11-15T07:56:36 *** bitconner has joined #bitcoin-core-dev
1572018-11-15T07:58:39 *** Skizzerz5 has joined #bitcoin-core-dev
1582018-11-15T08:01:38 *** setpill has joined #bitcoin-core-dev
1592018-11-15T08:01:45 *** bitconner has quit IRC
1602018-11-15T08:04:25 *** setpill has quit IRC
1612018-11-15T08:04:28 *** Skizzerz5 has quit IRC
1622018-11-15T08:05:31 *** shesek has quit IRC
1632018-11-15T08:06:09 *** setpill has joined #bitcoin-core-dev
1642018-11-15T08:06:12 *** shesek has joined #bitcoin-core-dev
1652018-11-15T08:06:12 *** shesek has joined #bitcoin-core-dev
1662018-11-15T08:18:15 *** wpaulino has quit IRC
1672018-11-15T08:18:15 *** wpaulino has joined #bitcoin-core-dev
1682018-11-15T08:25:44 *** shesek has quit IRC
1692018-11-15T08:26:10 *** shesek has joined #bitcoin-core-dev
1702018-11-15T08:27:11 *** shesek has joined #bitcoin-core-dev
1712018-11-15T08:27:36 *** phwalkr has joined #bitcoin-core-dev
1722018-11-15T08:32:08 *** jungly has joined #bitcoin-core-dev
1732018-11-15T08:37:45 *** Murch has joined #bitcoin-core-dev
1742018-11-15T08:41:55 *** queip has quit IRC
1752018-11-15T08:52:56 *** queip has joined #bitcoin-core-dev
1762018-11-15T08:57:47 *** spinza has quit IRC
1772018-11-15T09:04:16 *** nameeee has joined #bitcoin-core-dev
1782018-11-15T09:08:00 *** spinza has joined #bitcoin-core-dev
1792018-11-15T09:14:27 *** booyah_ is now known as booyah
1802018-11-15T09:17:09 <esotericnonsense> sipa: thanks for the help earlier. i have it working now (ignoring the change address issues). think i'll deal with that later on since i don't care about bloating a testnet wallet
1812018-11-15T09:23:47 *** phwalkr has quit IRC
1822018-11-15T09:27:51 *** Murch has quit IRC
1832018-11-15T09:28:03 *** phwalkr has joined #bitcoin-core-dev
1842018-11-15T09:28:48 *** cjd has joined #bitcoin-core-dev
1852018-11-15T09:39:51 *** timothy has joined #bitcoin-core-dev
1862018-11-15T09:42:01 *** queip has quit IRC
1872018-11-15T09:47:04 *** phwalkr has quit IRC
1882018-11-15T09:47:54 *** phwalkr has joined #bitcoin-core-dev
1892018-11-15T09:52:08 *** phwalkr has quit IRC
1902018-11-15T09:55:01 *** queip has joined #bitcoin-core-dev
1912018-11-15T10:03:37 *** hebasto has joined #bitcoin-core-dev
1922018-11-15T10:05:01 *** rh0nj has quit IRC
1932018-11-15T10:05:09 *** phwalkr has joined #bitcoin-core-dev
1942018-11-15T10:05:13 *** Victorsueca has joined #bitcoin-core-dev
1952018-11-15T10:06:07 *** rh0nj has joined #bitcoin-core-dev
1962018-11-15T10:09:50 *** JackH has quit IRC
1972018-11-15T10:09:53 *** phwalkr has quit IRC
1982018-11-15T10:10:31 *** promag has joined #bitcoin-core-dev
1992018-11-15T10:10:35 *** Guyver2 has quit IRC
2002018-11-15T10:11:40 *** state_bits has quit IRC
2012018-11-15T10:13:22 *** state_bits has joined #bitcoin-core-dev
2022018-11-15T10:21:25 *** rhavar has quit IRC
2032018-11-15T10:24:29 *** spinza has quit IRC
2042018-11-15T10:27:41 *** spinza has joined #bitcoin-core-dev
2052018-11-15T10:42:05 *** queip has quit IRC
2062018-11-15T10:47:41 *** JackH has joined #bitcoin-core-dev
2072018-11-15T10:48:07 *** zhangzf has quit IRC
2082018-11-15T10:48:08 *** queip has joined #bitcoin-core-dev
2092018-11-15T10:51:40 <promag> does appveyor merges with master before build and test?
2102018-11-15T10:59:09 *** bitconner has joined #bitcoin-core-dev
2112018-11-15T11:03:17 *** dqx_ has quit IRC
2122018-11-15T11:04:35 *** bitconner has quit IRC
2132018-11-15T11:10:32 *** AaronvanW has joined #bitcoin-core-dev
2142018-11-15T11:13:22 *** shesek has quit IRC
2152018-11-15T11:14:10 *** shesek has joined #bitcoin-core-dev
2162018-11-15T11:27:50 *** shesek has quit IRC
2172018-11-15T11:28:45 *** shesek has joined #bitcoin-core-dev
2182018-11-15T11:28:45 *** shesek has joined #bitcoin-core-dev
2192018-11-15T11:29:14 *** Victorsueca has quit IRC
2202018-11-15T11:30:35 *** Victorsueca has joined #bitcoin-core-dev
2212018-11-15T11:37:17 *** shesek has quit IRC
2222018-11-15T11:37:57 *** shesek has joined #bitcoin-core-dev
2232018-11-15T11:39:27 *** shesek has joined #bitcoin-core-dev
2242018-11-15T11:39:27 *** shesek has joined #bitcoin-core-dev
2252018-11-15T11:41:59 *** queip has quit IRC
2262018-11-15T11:44:29 *** Victorsueca has quit IRC
2272018-11-15T11:45:48 *** Victorsueca has joined #bitcoin-core-dev
2282018-11-15T11:54:26 *** spinza has quit IRC
2292018-11-15T11:54:44 *** queip has joined #bitcoin-core-dev
2302018-11-15T11:55:33 *** shesek has quit IRC
2312018-11-15T11:56:06 *** shesek has joined #bitcoin-core-dev
2322018-11-15T11:56:06 *** shesek has joined #bitcoin-core-dev
2332018-11-15T11:59:09 *** spinza has joined #bitcoin-core-dev
2342018-11-15T12:17:15 *** fabianfabian has joined #bitcoin-core-dev
2352018-11-15T12:21:20 *** drexl has joined #bitcoin-core-dev
2362018-11-15T12:42:01 *** queip has quit IRC
2372018-11-15T12:43:33 *** murr4y has joined #bitcoin-core-dev
2382018-11-15T12:52:19 *** queip has joined #bitcoin-core-dev
2392018-11-15T12:59:23 *** bitconner has joined #bitcoin-core-dev
2402018-11-15T13:03:27 *** bitconner has quit IRC
2412018-11-15T13:12:01 *** riemann_ has joined #bitcoin-core-dev
2422018-11-15T13:14:38 *** riemann has quit IRC
2432018-11-15T13:16:54 *** cubancorona has joined #bitcoin-core-dev
2442018-11-15T13:19:02 *** emilr has quit IRC
2452018-11-15T13:21:19 *** TX1683 has joined #bitcoin-core-dev
2462018-11-15T13:35:08 *** IGHOR has joined #bitcoin-core-dev
2472018-11-15T13:39:43 *** Murch has joined #bitcoin-core-dev
2482018-11-15T13:41:59 *** queip has quit IRC
2492018-11-15T13:43:13 *** shesek has quit IRC
2502018-11-15T13:43:43 *** shesek has joined #bitcoin-core-dev
2512018-11-15T13:43:43 *** shesek has joined #bitcoin-core-dev
2522018-11-15T13:46:21 *** Murch has quit IRC
2532018-11-15T13:47:57 *** Murch has joined #bitcoin-core-dev
2542018-11-15T13:48:58 *** queip has joined #bitcoin-core-dev
2552018-11-15T13:50:25 *** shesek has quit IRC
2562018-11-15T13:51:02 *** shesek has joined #bitcoin-core-dev
2572018-11-15T13:51:02 *** shesek has joined #bitcoin-core-dev
2582018-11-15T13:52:14 *** Murch has quit IRC
2592018-11-15T13:53:48 *** shesek has quit IRC
2602018-11-15T13:54:03 *** Murch has joined #bitcoin-core-dev
2612018-11-15T13:54:06 *** fanquake has quit IRC
2622018-11-15T13:54:46 *** shesek has joined #bitcoin-core-dev
2632018-11-15T13:54:46 *** shesek has joined #bitcoin-core-dev
2642018-11-15T14:02:08 *** owowo has quit IRC
2652018-11-15T14:04:07 *** Murch has quit IRC
2662018-11-15T14:05:18 *** promag has quit IRC
2672018-11-15T14:07:20 *** owowo has joined #bitcoin-core-dev
2682018-11-15T14:20:45 <cjd> Does anybody happen to know what was the largest (in number of bytes) transaction ever created ?
2692018-11-15T14:28:42 <timothy> cjd: iirc https://blockstream.info/tx/bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08
2702018-11-15T14:29:51 <cjd> oh wow, thank you
2712018-11-15T14:35:13 *** zhangzf has joined #bitcoin-core-dev
2722018-11-15T14:41:19 <hebasto> promag: it seems so; https://github.com/bitcoin/bitcoin/commit/affc245f0199a9f7a2dadaa555024820a17ffc2a
2732018-11-15T14:49:03 *** dady_ has joined #bitcoin-core-dev
2742018-11-15T14:51:37 *** dady_ has quit IRC
2752018-11-15T14:59:39 *** bitconner has joined #bitcoin-core-dev
2762018-11-15T14:59:51 *** shesek has quit IRC
2772018-11-15T15:00:24 *** shesek has joined #bitcoin-core-dev
2782018-11-15T15:00:29 *** shesek has quit IRC
2792018-11-15T15:00:30 *** shesek has joined #bitcoin-core-dev
2802018-11-15T15:04:20 *** bitconner has quit IRC
2812018-11-15T15:23:26 *** jarthur has joined #bitcoin-core-dev
2822018-11-15T15:27:52 *** Murch has joined #bitcoin-core-dev
2832018-11-15T15:36:51 *** zhangzf_ has joined #bitcoin-core-dev
2842018-11-15T15:37:27 *** zhangzf has quit IRC
2852018-11-15T15:41:56 *** queip has quit IRC
2862018-11-15T15:48:58 *** michaelsdunn1 has joined #bitcoin-core-dev
2872018-11-15T15:50:08 *** queip has joined #bitcoin-core-dev
2882018-11-15T15:53:18 *** michaelsdunn1 has quit IRC
2892018-11-15T15:57:17 *** michaelsdunn1 has joined #bitcoin-core-dev
2902018-11-15T16:02:42 *** zhangzf_ has quit IRC
2912018-11-15T16:19:00 *** shesek has quit IRC
2922018-11-15T16:19:28 *** shesek has joined #bitcoin-core-dev
2932018-11-15T16:19:28 *** shesek has joined #bitcoin-core-dev
2942018-11-15T16:24:48 *** millerti has joined #bitcoin-core-dev
2952018-11-15T16:28:30 *** setpill has quit IRC
2962018-11-15T16:31:17 *** dviola has joined #bitcoin-core-dev
2972018-11-15T16:35:31 *** Murch has quit IRC
2982018-11-15T16:37:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2992018-11-15T16:40:45 *** oneark has joined #bitcoin-core-dev
3002018-11-15T16:41:55 *** queip has quit IRC
3012018-11-15T16:49:07 *** shesek has quit IRC
3022018-11-15T16:49:36 *** shesek has joined #bitcoin-core-dev
3032018-11-15T16:52:15 *** queip has joined #bitcoin-core-dev
3042018-11-15T16:52:34 *** bitcoin-git has joined #bitcoin-core-dev
3052018-11-15T16:52:34 <bitcoin-git> [bitcoin] dongcarl opened pull request #14731: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
3062018-11-15T16:52:34 *** bitcoin-git has left #bitcoin-core-dev
3072018-11-15T16:59:54 *** ghost43_ has joined #bitcoin-core-dev
3082018-11-15T17:00:42 *** rhavar has joined #bitcoin-core-dev
3092018-11-15T17:01:01 *** ghost43 has quit IRC
3102018-11-15T17:13:47 *** JackH has quit IRC
3112018-11-15T17:15:10 *** ghost43_ is now known as ghost43
3122018-11-15T17:15:26 *** shesek has quit IRC
3132018-11-15T17:16:21 *** shesek has joined #bitcoin-core-dev
3142018-11-15T17:32:06 *** promag has joined #bitcoin-core-dev
3152018-11-15T17:41:56 *** queip has quit IRC
3162018-11-15T17:43:22 *** riemann has joined #bitcoin-core-dev
3172018-11-15T17:45:02 *** hbdgr__ has joined #bitcoin-core-dev
3182018-11-15T17:45:40 *** riemann_ has quit IRC
3192018-11-15T17:46:18 <promag> hebasto: thanks, I wonder if it's possible to rebase with a different branch
3202018-11-15T17:47:52 *** queip has joined #bitcoin-core-dev
3212018-11-15T17:48:21 <esotericnonsense> sipa: in case you were interested, the results of the psbt stuff from yesterday...
3222018-11-15T17:48:24 <esotericnonsense> https://files.esotericnonsense.com/public/bitcoin-top-wallet-send.jpg
3232018-11-15T17:48:24 *** riemann has quit IRC
3242018-11-15T17:48:34 <esotericnonsense> (the gray box is a javascript QR scanner)\
3252018-11-15T17:48:52 <esotericnonsense> so this is all self hosted using bitcoind rpc, very much testnet stuff atm though
3262018-11-15T17:49:16 *** shesek has quit IRC
3272018-11-15T17:49:17 <promag> "omg send"? :D
3282018-11-15T17:49:19 <esotericnonsense> the gray box is using decodepsbt
3292018-11-15T17:49:34 <esotericnonsense> promag: i have a really bad habit of using stupid names for everything all over my code
3302018-11-15T17:49:40 *** shesek has joined #bitcoin-core-dev
3312018-11-15T17:49:40 *** shesek has joined #bitcoin-core-dev
3322018-11-15T17:49:51 <promag> lgtm :D
3332018-11-15T17:49:57 <esotericnonsense> not "unsensible variable names", but rather stuff like panic!("omg it's all gone terribly wrong NOOOOOOOOOO")
3342018-11-15T17:55:01 *** shesek has quit IRC
3352018-11-15T17:56:29 *** shesek has joined #bitcoin-core-dev
3362018-11-15T17:56:29 *** shesek has joined #bitcoin-core-dev
3372018-11-15T18:07:01 *** JackH has joined #bitcoin-core-dev
3382018-11-15T18:13:16 *** promag has quit IRC
3392018-11-15T18:17:25 <instagibbs> in functional tests how do i set up nodes with no connections to peers?
3402018-11-15T18:18:10 *** mistergold has joined #bitcoin-core-dev
3412018-11-15T18:18:28 *** ezzzy has joined #bitcoin-core-dev
3422018-11-15T18:19:54 *** Victorsueca has quit IRC
3432018-11-15T18:21:03 *** Victorsueca has joined #bitcoin-core-dev
3442018-11-15T18:25:30 *** lnostdal has joined #bitcoin-core-dev
3452018-11-15T18:25:31 <instagibbs> got it, override setup_network
3462018-11-15T18:30:57 *** hbdgr__ has quit IRC
3472018-11-15T18:31:15 *** riemann has joined #bitcoin-core-dev
3482018-11-15T18:38:28 *** Chris_Stewart_5 has quit IRC
3492018-11-15T18:45:22 *** niiil has joined #bitcoin-core-dev
3502018-11-15T18:52:53 *** promag has joined #bitcoin-core-dev
3512018-11-15T18:52:53 *** dviola has quit IRC
3522018-11-15T18:56:20 *** shesek has quit IRC
3532018-11-15T18:57:09 *** shesek has joined #bitcoin-core-dev
3542018-11-15T18:57:09 *** shesek has joined #bitcoin-core-dev
3552018-11-15T18:58:31 *** Krellan has quit IRC
3562018-11-15T18:59:42 *** bitconner has joined #bitcoin-core-dev
3572018-11-15T18:59:50 <MarcoFalke> 6:59 PM
3582018-11-15T19:00:04 <wumpus> #startmeeting
3592018-11-15T19:00:04 <lightningbot> Meeting started Thu Nov 15 19:00:04 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3602018-11-15T19:00:04 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3612018-11-15T19:00:07 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
3622018-11-15T19:00:18 <provoostenator> hi
3632018-11-15T19:00:20 <meshcollider> hi
3642018-11-15T19:00:36 <promag> hi
3652018-11-15T19:00:37 <kanzure> hi.
3662018-11-15T19:00:57 <wumpus> proposed topics?
3672018-11-15T19:01:33 *** ezzzy has quit IRC
3682018-11-15T19:02:38 <wumpus> #topic high priority for review
3692018-11-15T19:02:40 <sipa> hi.
3702018-11-15T19:03:07 <phantomcircuit> hi
3712018-11-15T19:03:14 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 current high priority PRs are by luke-jr promag achow101 phantomcircuit sipa
3722018-11-15T19:03:32 <meshcollider> Maybe #14552
3732018-11-15T19:03:34 <wumpus> anything to add or remove for this week?
3742018-11-15T19:03:35 <gribble> https://github.com/bitcoin/bitcoin/issues/14552 | wallet: detecting duplicate wallet by comparing the db filename. by ken2812221 · Pull Request #14552 · bitcoin/bitcoin · GitHub
3752018-11-15T19:03:48 <instagibbs> hi
3762018-11-15T19:04:07 *** bitconner has quit IRC
3772018-11-15T19:04:09 <wumpus> meshcollider: added
3782018-11-15T19:04:15 <meshcollider> Thanks
3792018-11-15T19:04:39 <promag> regarding #14670, it is possible to have appveyor rebase on that instead of master?
3802018-11-15T19:04:41 <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
3812018-11-15T19:04:41 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3822018-11-15T19:04:48 *** ezzzy has joined #bitcoin-core-dev
3832018-11-15T19:04:49 *** clarkmoody has joined #bitcoin-core-dev
3842018-11-15T19:05:00 <wumpus> luke-jr: please rebase #14532
3852018-11-15T19:05:02 <gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
3862018-11-15T19:05:18 <wumpus> (should be a small change)
3872018-11-15T19:05:40 <provoostenator> I like to nominate #11082
3882018-11-15T19:05:43 <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
3892018-11-15T19:05:51 <promag> I saw several connection problems in some PR's in appveyor and I think 14670 fixes that
3902018-11-15T19:05:52 <provoostenator> Since I have PR that depends on that.
3912018-11-15T19:05:58 <wumpus> provoostenator: I don't know anything about appveyor
3922018-11-15T19:06:06 <MarcoFalke> promag: You'd have to fixup the appveyor yaml, I'd presume
3932018-11-15T19:06:07 <wumpus> provoostenator: luke-jr already has a PR
3942018-11-15T19:06:42 <wumpus> really, let's try to get the INADDR_ANY in, it's silly that it takes so long
3952018-11-15T19:06:46 *** shesek has quit IRC
3962018-11-15T19:06:57 <wumpus> it's an important security issue in a way
3972018-11-15T19:07:37 <wumpus> buut I'm fine with adding the _rw one as well if others agree...
3982018-11-15T19:07:44 <promag> MarcoFalke: you mean manually rebase? because from https://www.appveyor.com/docs/appveyor-yml/ I don't see that's possible out of the box
3992018-11-15T19:08:10 *** shesek has joined #bitcoin-core-dev
4002018-11-15T19:08:10 *** shesek has joined #bitcoin-core-dev
4012018-11-15T19:09:07 <MarcoFalke> Git should be installed on the machine, so you could do "git fetch https://github.com/promag/bitcoin branch && git merge FETCH_HEAD" before compiling?
4022018-11-15T19:10:11 <promag> MarcoFalke: do you think that could go to master temporally?
4032018-11-15T19:11:34 <provoostenator> wumpus: I'm fine with waiting until this more urgent PR is done, I'll try to help with review
4042018-11-15T19:11:42 <sipa> i think merging it is preferable
4052018-11-15T19:11:48 <sipa> (after review, of course)
4062018-11-15T19:12:01 <wumpus> merging it is certainly preferable, if we can be confident of it
4072018-11-15T19:12:47 <promag> ok then
4082018-11-15T19:13:08 <phantomcircuit> wumpus, im reviewing that one now
4092018-11-15T19:13:15 <MarcoFalke> phantomcircuit: Thx
4102018-11-15T19:13:18 <wumpus> it's the so-manieth time that particular part of the code was fixed, so I certainly understand people are a bit skeptical, you'll need very good tests
4112018-11-15T19:13:21 <phantomcircuit> the IsBindAny looks wrong actually...
4122018-11-15T19:15:03 <phantomcircuit> unless GetByte does some magic
4132018-11-15T19:15:13 <wumpus> let's review in the PR :)
4142018-11-15T19:15:22 <wumpus> any other topics?
4152018-11-15T19:15:26 <phantomcircuit> true sorry
4162018-11-15T19:16:00 <sipa> short reminder: wallet meeting tomorrow, same time
4172018-11-15T19:16:34 <wumpus> #action wallet meeting tomorrow, same time (friday 19:00 UTC)
4182018-11-15T19:18:44 <wumpus> this is a short meeting I suppose!
4192018-11-15T19:19:11 <sipa> seems so
4202018-11-15T19:19:58 <wumpus> #endmeeting
4212018-11-15T19:19:58 <lightningbot> Meeting ended Thu Nov 15 19:19:58 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4222018-11-15T19:19:58 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.html
4232018-11-15T19:19:58 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.txt
4242018-11-15T19:19:58 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.log.html
4252018-11-15T19:20:41 <meshcollider> Very short :)
4262018-11-15T19:21:09 <provoostenator> Sorry, a bit distracted by a certain fork.
4272018-11-15T19:22:57 *** laptop__ has joined #bitcoin-core-dev
4282018-11-15T19:23:36 *** laptop__ has quit IRC
4292018-11-15T19:23:57 *** laptop__ has joined #bitcoin-core-dev
4302018-11-15T19:25:09 *** clarkmoody has quit IRC
4312018-11-15T19:26:27 *** JackH has quit IRC
4322018-11-15T19:26:30 *** shesek has quit IRC
4332018-11-15T19:27:30 *** shesek has joined #bitcoin-core-dev
4342018-11-15T19:27:30 *** shesek has joined #bitcoin-core-dev
4352018-11-15T19:27:35 *** fabianfabian has quit IRC
4362018-11-15T19:27:42 *** atroxes has quit IRC
4372018-11-15T19:28:34 *** atroxes has joined #bitcoin-core-dev
4382018-11-15T19:29:48 *** atroxes has quit IRC
4392018-11-15T19:32:39 *** GoatzMilk has quit IRC
4402018-11-15T19:34:49 *** promag has quit IRC
4412018-11-15T19:36:09 *** conekins13 has joined #bitcoin-core-dev
4422018-11-15T19:36:24 *** shesek has quit IRC
4432018-11-15T19:36:42 *** conekins13 has quit IRC
4442018-11-15T19:37:29 *** shesek has joined #bitcoin-core-dev
4452018-11-15T19:39:10 *** jarthur has quit IRC
4462018-11-15T19:40:04 *** oneark has quit IRC
4472018-11-15T19:40:30 *** bitcoin-git has joined #bitcoin-core-dev
4482018-11-15T19:40:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/e74649e95122...384967f311b4
4492018-11-15T19:40:31 <bitcoin-git> bitcoin/master 7c5bc2a practicalswift: miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee
4502018-11-15T19:40:31 <bitcoin-git> bitcoin/master 145fe95 practicalswift: tests: Check return value of ParseParameters(...)
4512018-11-15T19:40:32 <bitcoin-git> bitcoin/master 579497e practicalswift: tests: Explicitly ignore the return value of DecodeBase58(...)
4522018-11-15T19:40:32 *** bitcoin-git has left #bitcoin-core-dev
4532018-11-15T19:41:04 *** bitcoin-git has joined #bitcoin-core-dev
4542018-11-15T19:41:04 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
4552018-11-15T19:41:04 *** bitcoin-git has left #bitcoin-core-dev
4562018-11-15T19:41:58 *** queip has quit IRC
4572018-11-15T19:48:41 *** shesek has quit IRC
4582018-11-15T19:49:14 *** shesek has joined #bitcoin-core-dev
4592018-11-15T19:49:14 *** shesek has joined #bitcoin-core-dev
4602018-11-15T19:50:48 *** Guyver2 has joined #bitcoin-core-dev
4612018-11-15T19:51:25 *** ezzzy has quit IRC
4622018-11-15T19:52:07 *** queip has joined #bitcoin-core-dev
4632018-11-15T19:54:03 *** ezzzy has joined #bitcoin-core-dev
4642018-11-15T19:57:44 <phantomcircuit> sipa, had any issues with the poll server?
4652018-11-15T19:58:27 <sipa> phantomcircuit: no
4662018-11-15T19:58:52 <sipa> currently running with 160 connections
4672018-11-15T20:00:26 <phantomcircuit> sipa, do we have anything that will exercise the performance?
4682018-11-15T20:00:36 <phantomcircuit> like try to do ibd or something
4692018-11-15T20:00:40 *** Murch has joined #bitcoin-core-dev
4702018-11-15T20:00:47 <phantomcircuit> but x100 nodes
4712018-11-15T20:00:52 *** shesek has quit IRC
4722018-11-15T20:01:30 <sipa> jamesob: ^
4732018-11-15T20:05:13 *** ezzzy has quit IRC
4742018-11-15T20:05:43 *** grubles has quit IRC
4752018-11-15T20:07:38 *** ezzzy has joined #bitcoin-core-dev
4762018-11-15T20:09:46 *** shesek has joined #bitcoin-core-dev
4772018-11-15T20:09:46 *** shesek has joined #bitcoin-core-dev
4782018-11-15T20:11:04 *** Murchone has joined #bitcoin-core-dev
4792018-11-15T20:12:19 *** shesek has quit IRC
4802018-11-15T20:13:44 *** Murch has quit IRC
4812018-11-15T20:14:44 *** bitconner has joined #bitcoin-core-dev
4822018-11-15T20:24:30 *** Murchone has quit IRC
4832018-11-15T20:26:00 *** ezzzy has quit IRC
4842018-11-15T20:27:21 *** timothy has quit IRC
4852018-11-15T20:29:12 *** rex4539 has quit IRC
4862018-11-15T20:33:28 *** Murch has joined #bitcoin-core-dev
4872018-11-15T20:34:51 *** fabianfabian has joined #bitcoin-core-dev
4882018-11-15T20:36:20 *** grubles has joined #bitcoin-core-dev
4892018-11-15T20:41:57 *** queip has quit IRC
4902018-11-15T20:42:51 *** Murch has quit IRC
4912018-11-15T20:53:10 *** queip has joined #bitcoin-core-dev
4922018-11-15T20:57:28 *** Murch has joined #bitcoin-core-dev
4932018-11-15T21:01:42 *** hebasto has quit IRC
4942018-11-15T21:08:05 *** bitconner has quit IRC
4952018-11-15T21:08:53 *** Murch has quit IRC
4962018-11-15T21:12:22 <stevenroose> who is maintaining the gnusha.org logs? Are they open to adding more channels? We were thinging we'd love one for #rust-bitcoin
4972018-11-15T21:12:28 <stevenroose> dongcarl: ^ there, I asked ;)
4982018-11-15T21:12:29 *** mistergold has quit IRC
4992018-11-15T21:12:50 <luke-jr> wumpus: unable to do so at the moment, and too tied up with other work to fix :/
5002018-11-15T21:12:56 <dongcarl> stevenroose: ah, I got the answer, it's kanzure
5012018-11-15T21:13:20 <luke-jr> re bitcoin_rw, reminder that things *don't* have to be high-prio for review, to be reviewed
5022018-11-15T21:15:52 <stevenroose> dongcarl: ah oops
5032018-11-15T21:18:05 *** jimmy has joined #bitcoin-core-dev
5042018-11-15T21:24:43 *** rex4539 has joined #bitcoin-core-dev
5052018-11-15T21:27:30 *** n1bor has joined #bitcoin-core-dev
5062018-11-15T21:37:49 *** Vita has joined #bitcoin-core-dev
5072018-11-15T21:38:40 <Vita> Zk proof of identity + POS or PoW with a hashing/staking hardcap.
5082018-11-15T21:38:47 <Vita> 1 - Prevents recentralization
5092018-11-15T21:40:27 <Vita> 2 - Allows and motivates scalability (implement a variable cap with formula Cap(throughput))
5102018-11-15T21:40:29 <sipa> Vita: #bitcoin-wizards or so, off topic here
5112018-11-15T21:40:57 <Vita> 3 - Conserves security
5122018-11-15T21:41:26 *** bralyclow has quit IRC
5132018-11-15T21:41:56 *** queip has quit IRC
5142018-11-15T21:42:02 *** Vita has quit IRC
5152018-11-15T21:45:17 *** bralyclow has joined #bitcoin-core-dev
5162018-11-15T21:46:51 *** queip has joined #bitcoin-core-dev
5172018-11-15T21:54:07 *** dqx_ has joined #bitcoin-core-dev
5182018-11-15T21:57:23 *** bitconner has joined #bitcoin-core-dev
5192018-11-15T22:01:48 *** michaelfolkson has joined #bitcoin-core-dev
5202018-11-15T22:07:13 *** niiil has quit IRC
5212018-11-15T22:11:01 *** promag has joined #bitcoin-core-dev
5222018-11-15T22:12:02 *** Guyver2 has quit IRC
5232018-11-15T22:16:39 *** shesek has joined #bitcoin-core-dev
5242018-11-15T22:19:52 *** justanotheruser has quit IRC
5252018-11-15T22:22:24 *** Murch has joined #bitcoin-core-dev
5262018-11-15T22:24:52 *** jarthur has joined #bitcoin-core-dev
5272018-11-15T22:25:57 *** michaelsdunn1 has quit IRC
5282018-11-15T22:27:07 *** dqx_ has quit IRC
5292018-11-15T22:27:07 *** face has quit IRC
5302018-11-15T22:27:21 *** dqx_ has joined #bitcoin-core-dev
5312018-11-15T22:38:15 *** shesek has quit IRC
5322018-11-15T22:38:56 *** shesek has joined #bitcoin-core-dev
5332018-11-15T22:41:56 *** spinza has quit IRC
5342018-11-15T22:42:00 *** queip has quit IRC
5352018-11-15T22:43:23 *** instagibbs has quit IRC
5362018-11-15T22:44:25 *** morcos has quit IRC
5372018-11-15T22:45:19 *** spinza has joined #bitcoin-core-dev
5382018-11-15T22:46:03 *** millerti has quit IRC
5392018-11-15T22:47:31 *** instagibbs has joined #bitcoin-core-dev
5402018-11-15T22:48:53 <phantomcircuit> sipa, is there a sorted_vector class i can just use?
5412018-11-15T22:49:18 <phantomcircuit> i dont think the performance gain is worth making the code more complex
5422018-11-15T22:49:34 *** morcos has joined #bitcoin-core-dev
5432018-11-15T22:49:36 <phantomcircuit> the only real solution to it is ultimately to register for and release events
5442018-11-15T22:49:46 <sipa> just add stuff to a vector, and call std::sort(v.begin(), v.end()); before returning it
5452018-11-15T22:49:48 <phantomcircuit> (which would make a switch to libevent easier)
5462018-11-15T22:50:03 <phantomcircuit> but that's way harder to get right
5472018-11-15T22:50:11 <sipa> but a wrapper would be neat, which exposes an efficient find
5482018-11-15T22:50:30 <sipa> like frozenset in python
5492018-11-15T22:50:45 *** Emcy has left #bitcoin-core-dev
5502018-11-15T22:51:04 <phantomcircuit> hmm i guess that cant have duplicated entries either so it doesn't need to check for inclusion first
5512018-11-15T22:51:15 <sipa> indeed
5522018-11-15T22:51:53 *** queip has joined #bitcoin-core-dev
5532018-11-15T22:52:25 <sipa> phantomcircuit: i think it's not worth the code complexity in your PR though
5542018-11-15T22:52:47 <phantomcircuit> with ~100 connections SocketEvents is using 15x the cpu time though
5552018-11-15T22:53:05 <phantomcircuit> so im not sure any change to the select set logic is worth it
5562018-11-15T22:53:25 <sipa> 15x compared to what?
5572018-11-15T22:53:35 *** hex17or has joined #bitcoin-core-dev
5582018-11-15T22:54:10 <phantomcircuit> sipa, compared to GenerateSelectSets
5592018-11-15T23:04:04 *** booyah has quit IRC
5602018-11-15T23:05:16 *** booyah has joined #bitcoin-core-dev
5612018-11-15T23:09:24 *** fabianfabian has quit IRC
5622018-11-15T23:19:23 *** hex17or has quit IRC
5632018-11-15T23:29:54 <phantomcircuit> sipa, im not sure how to make the socketevents method faster without having duplicate pollfd entries
5642018-11-15T23:30:03 <phantomcircuit> which seem to cause problems (at least on os x)
5652018-11-15T23:30:55 <sipa> phantomcircuit: how does allowing duplicates make it faster?
5662018-11-15T23:31:29 *** cubancorona has quit IRC
5672018-11-15T23:32:47 *** promag has quit IRC
5682018-11-15T23:40:37 *** Victorsueca has quit IRC
5692018-11-15T23:41:48 *** Victorsueca has joined #bitcoin-core-dev
5702018-11-15T23:41:57 <phantomcircuit> sipa, currently i have a map and that needs to be converted to a vector for the actual poll() call
5712018-11-15T23:41:57 *** queip has quit IRC
5722018-11-15T23:42:24 *** Zenton has quit IRC
5732018-11-15T23:42:24 *** michaelfolkson has quit IRC
5742018-11-15T23:42:41 <phantomcircuit> the map lookup/change is slower than the vector push_back
5752018-11-15T23:42:59 *** bitcoin-git has joined #bitcoin-core-dev
5762018-11-15T23:42:59 <bitcoin-git> [bitcoin] zallarak opened pull request #14733: p2p: allow p2ptimeout to be configurable, speed up slow test (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
5772018-11-15T23:42:59 *** bitcoin-git has left #bitcoin-core-dev
5782018-11-15T23:43:06 <phantomcircuit> there's some optimization i can do but i doubt it'll have a huge impact
5792018-11-15T23:43:23 <sipa> phantomcircuit: can you show me the code you have with the map?
5802018-11-15T23:43:55 <phantomcircuit> sipa, https://github.com/bitcoin/bitcoin/pull/14336/commits/47526062bae7af5309156ef4ab9c2b25310f5c35#diff-9a82240fe7dfe86564178691cc57f2f1R1324
5812018-11-15T23:45:29 <sipa> phantomcircuit: start by using an unordered_map ?
5822018-11-15T23:47:11 <phantomcircuit> sipa, will do
5832018-11-15T23:47:17 <phantomcircuit> i guess i'll do the rest to one sec
5842018-11-15T23:47:20 *** shesek has quit IRC
5852018-11-15T23:47:57 *** Chris_Stewart_5 has quit IRC
5862018-11-15T23:48:35 *** queip has joined #bitcoin-core-dev
5872018-11-15T23:48:49 *** shesek has joined #bitcoin-core-dev
5882018-11-15T23:49:01 *** rh0nj has quit IRC
5892018-11-15T23:50:08 *** rh0nj has joined #bitcoin-core-dev
5902018-11-15T23:50:57 *** hex17or has joined #bitcoin-core-dev
5912018-11-15T23:51:03 <phantomcircuit> sipa, actually the other one is super annoying
5922018-11-15T23:51:27 <phantomcircuit> setting the fd and the events bitfield that way does two lookups when i only have to do one
5932018-11-15T23:54:28 *** murrayn has quit IRC
5942018-11-15T23:55:29 <sipa> phantomcircuit: do you hate template magic?
5952018-11-15T23:56:25 <sipa> we could make GenerateSelectSets a templated function that takes as input a callback for each thing to listen to, which will be different for the select and the poll based implementation
5962018-11-15T23:56:35 *** michaelsdunn1 has joined #bitcoin-core-dev
5972018-11-15T23:56:44 <sipa> and by using a template that won't be a runtime function pointer, but an inlinable piece of code
5982018-11-15T23:57:31 *** hex17or has quit IRC
5992018-11-15T23:57:49 *** Krellan has joined #bitcoin-core-dev