12018-11-20T00:05:07  *** rex4539 has quit IRC
  22018-11-20T00:09:36  *** dviola has joined #bitcoin-core-dev
  32018-11-20T00:14:18  *** kanzure_ is now known as kanzure
  42018-11-20T00:34:25  *** _cryptodesktop_i has joined #bitcoin-core-dev
  52018-11-20T00:42:09  *** queip has quit IRC
  62018-11-20T00:51:40  *** drexl_ has quit IRC
  72018-11-20T00:52:18  *** drexl has joined #bitcoin-core-dev
  82018-11-20T00:53:33  *** queip has joined #bitcoin-core-dev
  92018-11-20T01:08:54  *** _cryptodesktop_i has quit IRC
 102018-11-20T01:26:47  *** intcat has quit IRC
 112018-11-20T01:28:48  *** intcat has joined #bitcoin-core-dev
 122018-11-20T01:30:49  *** dviola has quit IRC
 132018-11-20T01:37:04  *** arubi_ has quit IRC
 142018-11-20T01:37:42  *** arubi has joined #bitcoin-core-dev
 152018-11-20T01:42:01  *** queip has quit IRC
 162018-11-20T01:44:28  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
 172018-11-20T01:47:39  *** Ga1aCt1Cz00__ has quit IRC
 182018-11-20T01:49:09  *** queip has joined #bitcoin-core-dev
 192018-11-20T01:59:19  *** michaelsdunn1 has joined #bitcoin-core-dev
 202018-11-20T02:13:42  *** michaelsdunn1 has quit IRC
 212018-11-20T02:19:33  *** michaelsdunn1 has joined #bitcoin-core-dev
 222018-11-20T02:23:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 232018-11-20T02:42:09  *** queip has quit IRC
 242018-11-20T02:45:58  *** michaelsdunn1 has quit IRC
 252018-11-20T02:55:49  *** queip has joined #bitcoin-core-dev
 262018-11-20T02:57:52  *** bitcoin-git has joined #bitcoin-core-dev
 272018-11-20T02:57:52  <bitcoin-git> [bitcoin] qqz898 opened pull request #14766: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14766
 282018-11-20T02:57:52  *** bitcoin-git has left #bitcoin-core-dev
 292018-11-20T02:59:02  *** bitcoin-git has joined #bitcoin-core-dev
 302018-11-20T02:59:03  <bitcoin-git> [bitcoin] qqz898 closed pull request #14766: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14766
 312018-11-20T02:59:03  *** bitcoin-git has left #bitcoin-core-dev
 322018-11-20T02:59:43  *** bitcoin-git has joined #bitcoin-core-dev
 332018-11-20T02:59:43  <bitcoin-git> [bitcoin] qqz898 closed pull request #14766: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14766
 342018-11-20T02:59:43  *** bitcoin-git has left #bitcoin-core-dev
 352018-11-20T03:07:26  *** AaronvanW has quit IRC
 362018-11-20T03:20:06  *** Chris_Stewart_5 has quit IRC
 372018-11-20T03:21:44  *** cjd has quit IRC
 382018-11-20T03:22:29  *** cjd has joined #bitcoin-core-dev
 392018-11-20T03:31:01  *** rh0nj has quit IRC
 402018-11-20T03:32:07  *** rh0nj has joined #bitcoin-core-dev
 412018-11-20T03:38:00  *** go1111111 has quit IRC
 422018-11-20T03:42:02  *** queip has quit IRC
 432018-11-20T03:51:16  *** go1111111 has joined #bitcoin-core-dev
 442018-11-20T03:52:53  *** queip has joined #bitcoin-core-dev
 452018-11-20T03:58:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 462018-11-20T04:06:07  *** Chris_Stewart_5 has quit IRC
 472018-11-20T04:22:03  *** schnerch_ has joined #bitcoin-core-dev
 482018-11-20T04:24:51  *** schnerchi has quit IRC
 492018-11-20T04:28:50  *** cjd has quit IRC
 502018-11-20T04:28:58  *** cjd has joined #bitcoin-core-dev
 512018-11-20T04:32:38  *** gelmutshmidt has joined #bitcoin-core-dev
 522018-11-20T04:41:58  *** queip has quit IRC
 532018-11-20T04:49:57  *** queip has joined #bitcoin-core-dev
 542018-11-20T04:59:23  *** Eagle[TM] has joined #bitcoin-core-dev
 552018-11-20T05:01:53  *** EagleTM has quit IRC
 562018-11-20T05:12:12  <kallewoof> *headscratch* why would I get errors about "ifstream in fs not having a type" in fs.h (which I haven't touched) included from bitcoind.cpp (which I haven't touched)...?
 572018-11-20T05:12:30  <kallewoof> bottom of https://travis-ci.org/bitcoin/bitcoin/jobs/457291806
 582018-11-20T05:12:31  <sipa> kallewoof: master is broken
 592018-11-20T05:12:57  <kallewoof> sipa: oh
 602018-11-20T05:15:56  *** Ga1aCt1Cz00__ has joined #bitcoin-core-dev
 612018-11-20T05:19:23  *** Ga1aCt1Cz00_ has quit IRC
 622018-11-20T05:23:30  *** spinza has quit IRC
 632018-11-20T05:36:43  *** spinza has joined #bitcoin-core-dev
 642018-11-20T05:39:19  *** tryphe_ is now known as tryphe
 652018-11-20T05:42:53  *** bitcoin-git has joined #bitcoin-core-dev
 662018-11-20T05:42:53  <bitcoin-git> [bitcoin] kallewoof opened pull request #14768: revert removal of fstream.hpp header in fs.h (master...restore-fs-h-include-boost-fs-fstream) https://github.com/bitcoin/bitcoin/pull/14768
 672018-11-20T05:42:53  *** bitcoin-git has left #bitcoin-core-dev
 682018-11-20T05:50:30  *** bitcoin-git has joined #bitcoin-core-dev
 692018-11-20T05:50:30  <bitcoin-git> [bitcoin] MeshCollider closed pull request #14763: Remove filesystem/fstream from EXPECTED_BOOST_INCLUDES (master...2018/11/expected_boost_includes) https://github.com/bitcoin/bitcoin/pull/14763
 702018-11-20T05:50:30  *** bitcoin-git has left #bitcoin-core-dev
 712018-11-20T06:00:59  *** bitconner has quit IRC
 722018-11-20T06:17:21  *** bitconner has joined #bitcoin-core-dev
 732018-11-20T06:21:39  *** bitconner has quit IRC
 742018-11-20T06:42:03  *** queip has quit IRC
 752018-11-20T06:54:10  *** queip has joined #bitcoin-core-dev
 762018-11-20T07:20:08  *** Eagle[TM] has quit IRC
 772018-11-20T07:31:47  *** go1111111 has quit IRC
 782018-11-20T07:41:57  *** queip has quit IRC
 792018-11-20T07:47:25  *** go1111111 has joined #bitcoin-core-dev
 802018-11-20T07:52:36  *** face has joined #bitcoin-core-dev
 812018-11-20T07:55:48  *** queip has joined #bitcoin-core-dev
 822018-11-20T07:56:52  <gwillen> gmaxwell: can you explain to me what your comment on 14588 means? (I assume it's not for me, but for committers)
 832018-11-20T07:57:52  *** booyah has quit IRC
 842018-11-20T07:58:37  *** rex4539 has joined #bitcoin-core-dev
 852018-11-20T08:00:29  *** ghost43 has quit IRC
 862018-11-20T08:02:14  *** ghost43 has joined #bitcoin-core-dev
 872018-11-20T08:08:17  <sipa> gwillen: gmaxwell suggests we may want to include it in 0.17.1
 882018-11-20T08:08:47  <sipa> and no, not aimed at you (but feel to comment whether you think that's a good idea)
 892018-11-20T08:09:21  <gmaxwell> yeah, feel free to say if you think it should/shouldn't be.
 902018-11-20T08:19:11  *** ghost43 has quit IRC
 912018-11-20T08:20:40  *** booyah has joined #bitcoin-core-dev
 922018-11-20T08:24:40  *** ghost43 has joined #bitcoin-core-dev
 932018-11-20T08:28:49  *** EagleTM has joined #bitcoin-core-dev
 942018-11-20T08:41:34  *** EagleTM has quit IRC
 952018-11-20T08:42:01  *** queip has quit IRC
 962018-11-20T08:48:24  *** queip has joined #bitcoin-core-dev
 972018-11-20T08:55:54  <wumpus> meshcollider: I'm now
 982018-11-20T08:58:31  <wumpus> provoostenator: that really shouldn't have been merged before being sure about it, linters cause enough issues without feeding them false input
 992018-11-20T08:59:52  <wumpus> oh it doesn't change the linter config, just removes a header too much causing compile issues
1002018-11-20T09:00:42  <wumpus> why is fstream only needed on some platforms?
1012018-11-20T09:01:16  <wumpus> oh I see, it sometimes gets included through other headers
1022018-11-20T09:07:12  *** bitcoin-git has joined #bitcoin-core-dev
1032018-11-20T09:07:13  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/09f1d7fe7243...1b99d153d071
1042018-11-20T09:07:13  <bitcoin-git> bitcoin/master e816b34 Karl-Johan Alm: revert removal of fstream.hpp header in fs.h...
1052018-11-20T09:07:14  <bitcoin-git> bitcoin/master 1b99d15 Wladimir J. van der Laan: Merge #14768: revert removal of fstream.hpp header in fs.h...
1062018-11-20T09:07:14  *** bitcoin-git has left #bitcoin-core-dev
1072018-11-20T09:08:25  *** bitcoin-git has joined #bitcoin-core-dev
1082018-11-20T09:08:25  <bitcoin-git> [bitcoin] laanwj closed pull request #14768: revert removal of fstream.hpp header in fs.h (master...restore-fs-h-include-boost-fs-fstream) https://github.com/bitcoin/bitcoin/pull/14768
1092018-11-20T09:08:25  *** bitcoin-git has left #bitcoin-core-dev
1102018-11-20T09:14:38  <wumpus> ouch, travis being down and it not being noticed is quite dangerous
1112018-11-20T09:20:04  *** timothy has joined #bitcoin-core-dev
1122018-11-20T09:20:31  <wumpus> luckily it was only a header issue then
1132018-11-20T09:24:56  *** phwalkr has joined #bitcoin-core-dev
1142018-11-20T09:28:15  *** belcher has quit IRC
1152018-11-20T09:28:45  *** phwalkr has quit IRC
1162018-11-20T09:33:56  *** phwalkr has joined #bitcoin-core-dev
1172018-11-20T09:41:19  *** belcher has joined #bitcoin-core-dev
1182018-11-20T09:42:05  *** queip has quit IRC
1192018-11-20T09:43:19  *** intcat has quit IRC
1202018-11-20T09:45:32  *** intcat has joined #bitcoin-core-dev
1212018-11-20T09:48:34  *** queip has joined #bitcoin-core-dev
1222018-11-20T10:03:36  *** setpill has joined #bitcoin-core-dev
1232018-11-20T10:12:04  *** phwalkr has quit IRC
1242018-11-20T10:16:47  <luke-jr> if Travis being down is dangerous, the real danger is the conclusion that things are being merged without real review :x
1252018-11-20T10:18:49  <luke-jr> ie, it's being used as more than just a mere convenience
1262018-11-20T10:22:51  *** michaelfolkson has joined #bitcoin-core-dev
1272018-11-20T10:28:25  <wumpus> nah not fatally dangerous, the PR didn't go without review
1282018-11-20T10:28:28  <promag> is there a way to make a long RPC call? like server side sleep?
1292018-11-20T10:28:55  <wumpus> promag: yes, RPC calls can sleep as long as they want, although the client has to make sure they don't time out
1302018-11-20T10:29:03  <promag> I thought we were doing blind merges :D
1312018-11-20T10:29:29  <wumpus> it does hold up a RPC thread but there's other calls that can take a long time for example the utxo stats one
1322018-11-20T10:29:52  <promag> wumpus: for testing I don't think we have?
1332018-11-20T10:29:54  <wumpus> I think the mining RPC does long-polling
1342018-11-20T10:30:00  <wumpus> and there's RPCs to wait for next block and such?
1352018-11-20T10:30:12  <promag> ah!
1362018-11-20T10:30:27  <promag> thank you sir
1372018-11-20T10:30:33  <wumpus> np
1382018-11-20T10:40:16  <promag> do we have tests to concurrently call RPC to the same node?
1392018-11-20T10:41:58  *** queip has quit IRC
1402018-11-20T10:53:38  *** queip has joined #bitcoin-core-dev
1412018-11-20T10:54:33  *** spinza has quit IRC
1422018-11-20T11:01:07  *** cryptoboy has joined #bitcoin-core-dev
1432018-11-20T11:09:26  *** spinza has joined #bitcoin-core-dev
1442018-11-20T11:15:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1452018-11-20T11:26:41  *** cryptoboy has quit IRC
1462018-11-20T11:27:09  *** cryptoboy has joined #bitcoin-core-dev
1472018-11-20T11:41:56  *** queip has quit IRC
1482018-11-20T11:46:28  *** speedChicken_ has joined #bitcoin-core-dev
1492018-11-20T11:48:01  *** rh0nj has quit IRC
1502018-11-20T11:49:07  *** rh0nj has joined #bitcoin-core-dev
1512018-11-20T11:49:48  *** AaronvanW has joined #bitcoin-core-dev
1522018-11-20T11:53:13  *** michaelfolkson has quit IRC
1532018-11-20T11:53:43  *** queip has joined #bitcoin-core-dev
1542018-11-20T11:53:48  *** spinza has quit IRC
1552018-11-20T11:57:00  *** spinza has joined #bitcoin-core-dev
1562018-11-20T12:05:09  *** phwalkr has joined #bitcoin-core-dev
1572018-11-20T12:14:16  <wumpus> promag: I don't think so
1582018-11-20T12:26:29  *** phwalkr has quit IRC
1592018-11-20T12:42:43  *** zhangzf has joined #bitcoin-core-dev
1602018-11-20T12:51:32  *** rex4539 has quit IRC
1612018-11-20T13:04:09  *** Chris_Stewart_5 has quit IRC
1622018-11-20T13:10:26  *** rhavar has quit IRC
1632018-11-20T13:14:03  <provoostenator> One reason we didn't notice Travis missing is that there's still a green checkbox from the other tools. That's strange, shouldn't Github show an error if any integration is missing / fails?
1642018-11-20T13:17:49  *** intcat has quit IRC
1652018-11-20T13:21:16  *** intcat has joined #bitcoin-core-dev
1662018-11-20T13:33:26  <wumpus> normally yes
1672018-11-20T13:39:05  <Varunram> only if it misses / fails though, not if it doesn't boot up the tests in the first place
1682018-11-20T13:55:04  <wumpus> yes, that sound plausible
1692018-11-20T14:16:31  *** bitcoin-git has joined #bitcoin-core-dev
1702018-11-20T14:16:31  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b99d153d071...afa506f6ebeb
1712018-11-20T14:16:32  <bitcoin-git> bitcoin/master c456fbd Russell Yanofsky: Refactor: Move m_db pointers into BerkeleyDatabase...
1722018-11-20T14:16:32  <bitcoin-git> bitcoin/master 15c93f0 Chun Kuan Lee: wallet: Add trailing wallet.dat when detecting duplicate wallet if it's a directory.
1732018-11-20T14:16:33  <bitcoin-git> bitcoin/master 5912031 Chun Kuan Lee: wallet: Create IsDatabaseLoaded function
1742018-11-20T14:16:33  *** bitcoin-git has left #bitcoin-core-dev
1752018-11-20T14:17:40  *** bitcoin-git has joined #bitcoin-core-dev
1762018-11-20T14:17:40  <bitcoin-git> [bitcoin] laanwj closed pull request #14552: wallet: detecting duplicate wallet by comparing the db filename. (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
1772018-11-20T14:17:40  *** bitcoin-git has left #bitcoin-core-dev
1782018-11-20T14:17:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1792018-11-20T14:29:12  *** booyah has quit IRC
1802018-11-20T14:41:56  *** queip has quit IRC
1812018-11-20T14:47:29  *** Guyver2 has joined #bitcoin-core-dev
1822018-11-20T14:48:32  *** queip has joined #bitcoin-core-dev
1832018-11-20T14:50:54  *** cryptoboy has quit IRC
1842018-11-20T14:51:07  *** bitcoin-git has joined #bitcoin-core-dev
1852018-11-20T14:51:08  <bitcoin-git> [bitcoin] scravy opened pull request #14770: Do not specify sudo in .travis (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14770
1862018-11-20T14:51:08  *** bitcoin-git has left #bitcoin-core-dev
1872018-11-20T14:52:16  *** booyah has joined #bitcoin-core-dev
1882018-11-20T14:53:22  *** cryptoboy has joined #bitcoin-core-dev
1892018-11-20T15:07:10  *** setpill has quit IRC
1902018-11-20T15:12:39  <promag> wumpus: I was waiting for https://github.com/bitcoin/bitcoin/pull/14552#pullrequestreview-176535062
1912018-11-20T15:14:06  <wumpus> promag: huh didn't see that, you had already utACKed it
1922018-11-20T15:14:57  <promag> yeah, that was a previous commit
1932018-11-20T15:15:10  <wumpus> *sigh* ok
1942018-11-20T15:15:16  <promag> how can I cancel an utACK?
1952018-11-20T15:15:23  <wumpus> edit->delete it
1962018-11-20T15:15:42  <promag> anyway, ken2812221_ ^
1972018-11-20T15:15:47  *** LGzr has joined #bitcoin-core-dev
1982018-11-20T15:16:02  <wumpus> I can revert it if that's really necessary
1992018-11-20T15:16:09  <promag> I don't think so
2002018-11-20T15:16:55  <promag> the mutex is for g_dbenvs, but there is no mutex for WalletEnvironment
2012018-11-20T15:17:16  <promag> so I wonder if it should use the same
2022018-11-20T15:23:01  <LGzr> Hola, all. I've a question about the p2sh example at https://bitcoin.org/en/developer-examples#p2sh-multisig; is there a more appropriate forum than here? (Question is: what purpose it serves that createmultisig uses public key for one, and addresses for the others)
2032018-11-20T15:26:12  *** Victor_sueca has joined #bitcoin-core-dev
2042018-11-20T15:27:21  *** Victorsueca has quit IRC
2052018-11-20T15:33:32  *** michaelsdunn1 has joined #bitcoin-core-dev
2062018-11-20T15:40:13  *** mr_paz has joined #bitcoin-core-dev
2072018-11-20T15:42:05  *** queip has quit IRC
2082018-11-20T15:47:42  <wumpus> LGzr: I think https://bitcoin.stackexchange.com/ is the best place to ask such things
2092018-11-20T15:50:01  *** rh0nj has quit IRC
2102018-11-20T15:50:24  <LGzr> Wumpus - thanks!
2112018-11-20T15:51:07  *** rh0nj has joined #bitcoin-core-dev
2122018-11-20T15:52:37  *** queip has joined #bitcoin-core-dev
2132018-11-20T15:54:19  *** Victor_sueca has quit IRC
2142018-11-20T15:56:35  *** Victorsueca has joined #bitcoin-core-dev
2152018-11-20T16:09:42  *** dqx_ has joined #bitcoin-core-dev
2162018-11-20T16:19:40  *** dqx has quit IRC
2172018-11-20T16:20:23  <achow101> meshcollider: can you rebase #14491
2182018-11-20T16:20:26  <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
2192018-11-20T16:28:45  *** Victorsueca has quit IRC
2202018-11-20T16:29:53  *** Victorsueca has joined #bitcoin-core-dev
2212018-11-20T16:32:49  *** michaelfolkson has joined #bitcoin-core-dev
2222018-11-20T16:40:50  *** Victorsueca has quit IRC
2232018-11-20T16:41:57  *** queip has quit IRC
2242018-11-20T16:43:00  *** promag has quit IRC
2252018-11-20T16:46:42  *** rex4539 has joined #bitcoin-core-dev
2262018-11-20T16:55:20  *** queip has joined #bitcoin-core-dev
2272018-11-20T17:06:42  *** bitcoin-git has joined #bitcoin-core-dev
2282018-11-20T17:06:42  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14755: Remove redundant readme info in /doc (master...issue-14639) https://github.com/bitcoin/bitcoin/pull/14755
2292018-11-20T17:06:42  *** bitcoin-git has left #bitcoin-core-dev
2302018-11-20T17:08:24  *** Victorsueca has joined #bitcoin-core-dev
2312018-11-20T17:10:52  *** gelmutshmidt has quit IRC
2322018-11-20T17:11:20  *** gelmutshmidt has joined #bitcoin-core-dev
2332018-11-20T17:16:19  *** IRC-Source_71688 has joined #bitcoin-core-dev
2342018-11-20T17:18:28  *** IRC-Source_71688 has quit IRC
2352018-11-20T17:19:18  *** kexkey has joined #bitcoin-core-dev
2362018-11-20T17:20:15  *** kelt has quit IRC
2372018-11-20T17:21:14  *** michaelfolkson has quit IRC
2382018-11-20T17:22:46  *** michaelfolkson has joined #bitcoin-core-dev
2392018-11-20T17:23:06  *** jarthur has joined #bitcoin-core-dev
2402018-11-20T17:31:02  *** cryptoboy has quit IRC
2412018-11-20T17:31:09  *** kelt has joined #bitcoin-core-dev
2422018-11-20T17:31:12  *** cryptoboy has joined #bitcoin-core-dev
2432018-11-20T17:32:24  *** promag has joined #bitcoin-core-dev
2442018-11-20T17:37:21  <provoostenator> I notice that dumpwallet (on a fresh wallet) contains two sections, I'm confused why:
2452018-11-20T17:37:25  <provoostenator> cV6... 2018-11-20T17:23:30Z reserve=1 # addr=tb1q... hdkeypath=m/0'/0'/11'
2462018-11-20T17:37:30  <provoostenator> 001433... 0 script=1 # addr=2Ms...
2472018-11-20T17:39:52  <sipa> the script is the p2sh wrapper of that address, i suppose
2482018-11-20T17:41:57  *** queip has quit IRC
2492018-11-20T17:42:19  <provoostenator> Ah hence they start with 0014? So the first section is for legacy & native segwit, the second for p2sh wrapped segwit? But why don't the p2sh entries show an hdkeypath?
2502018-11-20T17:44:25  <sipa> they're not keys
2512018-11-20T17:45:00  <sipa> in the current wallet design, you don't import addresses
2522018-11-20T17:45:15  <sipa> you import keys and scripts, and it figures out on its own what that implies for what is yours
2532018-11-20T17:45:19  *** bitconner has joined #bitcoin-core-dev
2542018-11-20T17:45:51  <sipa> in practice for the P2SH-P2WPKH address derived from a wallet key, IsMine works as follows:
2552018-11-20T17:45:59  <sipa> * it sees a P2SH address, so it looks up the script for that scripthash
2562018-11-20T17:46:36  <sipa> * it notices the script is a P2WPKH script, so it recurses by replacing it with the corresponding P2PKH script
2572018-11-20T17:46:49  <sipa> * it notices it's a P2PKH script, so it looks up the pubkeyhash
2582018-11-20T17:46:58  <sipa> * it finds the private key for it, so it's considered spendable
2592018-11-20T17:47:15  <sipa> but the only thing in that whole sequence that has a keypath is the key at the end
2602018-11-20T17:48:16  *** ddd has joined #bitcoin-core-dev
2612018-11-20T17:49:38  *** zallarak has joined #bitcoin-core-dev
2622018-11-20T17:49:42  *** bitconner has quit IRC
2632018-11-20T17:50:03  *** rabidus has quit IRC
2642018-11-20T17:50:09  *** ddd has quit IRC
2652018-11-20T17:51:45  *** bitcoin-git has joined #bitcoin-core-dev
2662018-11-20T17:51:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afa506f6ebeb...6b90a2a0e065
2672018-11-20T17:51:47  <bitcoin-git> bitcoin/master feeef7d Julian Fleischer: Do not specify sudo in .travis...
2682018-11-20T17:51:47  <bitcoin-git> bitcoin/master 6b90a2a Wladimir J. van der Laan: Merge #14770: travis: Do not specify sudo in .travis...
2692018-11-20T17:51:48  *** bitcoin-git has left #bitcoin-core-dev
2702018-11-20T17:52:54  *** bitcoin-git has joined #bitcoin-core-dev
2712018-11-20T17:52:54  <bitcoin-git> [bitcoin] laanwj closed pull request #14770: travis: Do not specify sudo in .travis (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14770
2722018-11-20T17:52:54  *** bitcoin-git has left #bitcoin-core-dev
2732018-11-20T17:54:22  *** queip has joined #bitcoin-core-dev
2742018-11-20T17:54:51  *** oneark has quit IRC
2752018-11-20T17:57:12  *** rabidus has joined #bitcoin-core-dev
2762018-11-20T17:58:07  *** Chris_Stewart_5 has quit IRC
2772018-11-20T17:58:16  *** bitconner has joined #bitcoin-core-dev
2782018-11-20T17:59:05  *** fabianfabian has joined #bitcoin-core-dev
2792018-11-20T18:03:20  *** bitconner has quit IRC
2802018-11-20T18:14:33  *** bitconner has joined #bitcoin-core-dev
2812018-11-20T18:15:25  <provoostenator> sipa: thanks. Perhaps no point in cleaning up the current wallet, but dumpwallet could add comments to the script entries like "p2sh-segwit script for hdkeypath=m/0..."?
2822018-11-20T18:16:41  <sipa> provoostenator: or we could dump the inferred descriptor for each entry :)
2832018-11-20T18:16:42  *** promag has quit IRC
2842018-11-20T18:19:00  <provoostenator> That makes sense on top of #11803, but more for the key entries than for the script entries.
2852018-11-20T18:19:02  <gribble> https://github.com/bitcoin/bitcoin/issues/11803 | Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet by luke-jr · Pull Request #11803 · bitcoin/bitcoin · GitHub
2862018-11-20T18:19:16  <sipa> provoostenator: no, that makes no sense
2872018-11-20T18:19:23  <sipa> keys are keys, not addresses
2882018-11-20T18:19:35  <provoostenator> But they're supposed to be interpreted as combo() descriptors
2892018-11-20T18:19:46  <sipa> they participate in all scripts that use them
2902018-11-20T18:19:47  <provoostenator> Depending on wallet age
2912018-11-20T18:19:55  <sipa> and we can't even efficiently iterate those
2922018-11-20T18:20:21  <sipa> yes, they also (for now) imply a combo descriptor on their own
2932018-11-20T18:20:29  <sipa> but that's not very informative
2942018-11-20T18:20:56  <sipa> "this key acts in all the way it itself can be an address!"
2952018-11-20T18:21:02  <provoostenator> It's perhaps more informative than the current address= comment which is misleading.
2962018-11-20T18:21:15  <sipa> ah, i see
2972018-11-20T18:21:29  <sipa> it could list all addresses, or a combo descriptor - that's fair
2982018-11-20T18:21:52  <sipa> but for scripts it's actually interesting, as it will tell which which keys it is related to
2992018-11-20T18:23:14  <provoostenator> Yes, but the script is only relevant for p2sh wrapped segwit, right? (in a default new wallet)
3002018-11-20T18:23:50  <sipa> sure
3012018-11-20T18:23:55  <sipa> or anything you manually imported
3022018-11-20T18:24:02  <sipa> (multisig etc)
3032018-11-20T18:24:49  <provoostenator> In that case I think it's more clear for the comment to indicate that it's only there for p2sh wrapped segwit support, i.e. those entries are redundant once descriptors take over.
3042018-11-20T18:25:15  <sipa> dumpwallet as a whole will need to be revamped post-descriptors
3052018-11-20T18:25:39  <sipa> i don't understand what you're trying to argue for
3062018-11-20T18:25:56  <sipa> scripts are not just there for p2sh wrapped segwit
3072018-11-20T18:25:58  <sipa> they are there for p2sh and p2wsh everything
3082018-11-20T18:26:00  <provoostenator> Indeed, but it might be useful to get it good enough so it's easier to test things (like upgrade paths) once we have descriptor functionality complete.
3092018-11-20T18:26:20  <provoostenator> Right now it's really to inspect what is actually in a wallet.
3102018-11-20T18:26:24  <provoostenator> *really hard
3112018-11-20T18:28:04  <provoostenator> The comment would only be there for scripts that relate to the standard wallet, not any imported / generated p2(w)sh stuff.
3122018-11-20T18:28:23  <sipa> we don't know that
3132018-11-20T18:28:27  <sipa> there is just a bunch of scripts
3142018-11-20T18:28:47  <sipa> they're not in any way linked to other wallet information
3152018-11-20T18:29:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3162018-11-20T18:30:22  <provoostenator> You could re-match them using the private keys from all keys with an hdmasterkeyid?
3172018-11-20T18:31:47  <sipa> or you could just print their inferred descriptor
3182018-11-20T18:31:52  <sipa> which works for everything
3192018-11-20T18:31:57  <sipa> and is efficient
3202018-11-20T18:32:25  <sipa> even that may be confusing, though
3212018-11-20T18:32:50  <sipa> as a p2sh-p2wsh script will have two entries
3222018-11-20T18:32:50  <sipa> and we don't dump watched scripts
3232018-11-20T18:33:07  * sipa would like to see dumpwallet die
3242018-11-20T18:34:06  <provoostenator> I think dumpwallet can be useful for testing transition to descriptor based wallets, but I'm fine with making it die after that :-)
3252018-11-20T18:34:54  <sipa> yeah, of course
3262018-11-20T18:37:48  <provoostenator> sipa: about REST https://github.com/bitcoin/bitcoin/pull/12040#discussion_r235092254
3272018-11-20T18:38:02  <provoostenator> Look for my example "do some wallet operation on wallet"
3282018-11-20T18:38:40  <provoostenator> It passes an Authorization: Basic param with the request, which contains the RPC username and password in  some base64 converted form. Afaik it has full RPC access.
3292018-11-20T18:38:47  <provoostenator> That's not because of this PR.
3302018-11-20T18:39:20  <provoostenator> (or if it is, that's very underhanded code)
3312018-11-20T18:40:20  <sipa> provoostenator: yes, i see that, but that is just  the RPC interface
3322018-11-20T18:40:34  <provoostenator> Oh wait, but then what is the -rest parameter doing?
3332018-11-20T18:40:37  <sipa> not the REST interface, which uses .../rest/... URLs
3342018-11-20T18:40:48  <provoostenator> -rpcport=8080 is just cancelling my -rest=1?
3352018-11-20T18:41:01  <sipa> no
3362018-11-20T18:41:07  <sipa> -rest enables the REST interface
3372018-11-20T18:41:29  <sipa> that doesn't mean you can't use RPC anymore
3382018-11-20T18:42:00  *** queip has quit IRC
3392018-11-20T18:42:10  <sipa> ah, -rpcport is somewhat confusingly named i guess, as that option indeed does affect both rpc and rest
3402018-11-20T18:42:24  *** LGzr has quit IRC
3412018-11-20T18:42:46  <provoostenator> Ah, it seems very unhealthy that RPC and REST are so intertwined.
3422018-11-20T18:42:59  <provoostenator> Shouldn't REST just launch it's own server?
3432018-11-20T18:43:08  <sipa> why?
3442018-11-20T18:43:24  <sipa> they're entirely separate, apart from both being HTTP
3452018-11-20T18:43:54  <sipa> rpcport should be named httpport i guess, but it's a bit late for that
3462018-11-20T18:43:58  <provoostenator> I might not want to expose my RPC port to the internet
3472018-11-20T18:44:17  <provoostenator> Oh wait, it doesn't move the RPC port? Ok, that is _really_ confusing :-)
3482018-11-20T18:44:25  <sipa> sigh
3492018-11-20T18:44:44  <sipa> rpcport sets the HTTP listen port
3502018-11-20T18:44:45  <sipa> both RPC and REST use HTTP
3512018-11-20T18:44:53  <sipa> and you shouldn't expose either to the internet
3522018-11-20T18:45:06  <sipa> only the P2P interface is designed to be DoS resilient
3532018-11-20T18:45:53  <provoostenator> Ok, but DoS is a different threat than someone gaining RPC control.
3542018-11-20T18:46:02  <sipa> sure
3552018-11-20T18:46:12  <sipa> but neither are designed to be exposed to the internet
3562018-11-20T18:47:30  *** queip has joined #bitcoin-core-dev
3572018-11-20T18:48:43  *** dviola has joined #bitcoin-core-dev
3582018-11-20T18:53:09  *** bitconner has quit IRC
3592018-11-20T18:54:34  <wumpus> it would be fully possible to start multiple http servers, and have rpc run on one and rest on the other, though I doubt it's going to be a feature that sees much use
3602018-11-20T18:55:53  <provoostenator> I think it would be less confusing if it was a seperate server with its own port, but for this ticket that doesn't matter. The trick is just to only add CORS stuff to /rest/* so we don't have to worry about the phishing scenario I described.
3612018-11-20T18:55:55  <wumpus> *if* you want to expose anything to the internet you're going to want to put an nginx server or such in front, which would filter what URLs are allowed
3622018-11-20T18:56:55  <wumpus> I don't see how it's confusing, it has been like this since the beginning and AFAIK it's all documented *shrugs*
3632018-11-20T18:57:08  <sipa> provoostenator: why do you need CORS on REST?
3642018-11-20T18:57:24  <wumpus> that sounds really scary
3652018-11-20T18:58:01  <provoostenator> Well that's the point of that PR, which we could debate in general.
3662018-11-20T18:58:30  <sipa> i thought it was about something something browser security (i don't understand browsers, this may be my misunderstanding)
3672018-11-20T18:58:45  <sipa> but for REST there is no security needed
3682018-11-20T18:59:09  <provoostenator> At the moment browsers refuse to connect to the REST RPC via JSON.
3692018-11-20T18:59:10  <wumpus> it'd be about letting websites make requests to the local bitcoind instance, hence 'cross-origin'
3702018-11-20T18:59:21  <wumpus> I think that's completely ill-advices
3712018-11-20T18:59:46  <sipa> ah, it's permitting something, not denying something
3722018-11-20T18:59:49  <wumpus> right
3732018-11-20T18:59:51  <provoostenator> Yes
3742018-11-20T18:59:55  <sipa> i see
3752018-11-20T19:00:06  <provoostenator> I don't see any downside with read-only access.
3762018-11-20T19:00:14  <sipa> permitting sites to access REST sounds much less scary than letting them access RPC though
3772018-11-20T19:00:22  <wumpus> it increases the attack surface to any random website
3782018-11-20T19:00:38  <provoostenator> That's true.
3792018-11-20T19:00:48  <wumpus> what if it's not really read-only but there is some bug in the REST code or a heartbleed-kind of bug that exposes memory and private keys or whoknowswhat
3802018-11-20T19:01:00  <wumpus> I really prefer not having that kind of stuff in bitcoind, sorry
3812018-11-20T19:01:23  <provoostenator> I guess that begs the question why this REST service exists in the first place.
3822018-11-20T19:01:36  <wumpus> it's a fast way of accessing bitcoind's state
3832018-11-20T19:02:01  <wumpus> no need for JSON parsing and formatting, it can give various binary objects directly
3842018-11-20T19:02:22  <wumpus> also it can work without autentication for *local* programs, which is useful
3852018-11-20T19:02:52  <jarthur> Yea, and that's a big plus. In sidecar services that need to parse the blockchain from a node, so much CPU time is spent on JSON parsing when using the RPC api.
3862018-11-20T19:03:04  <wumpus> that doesn't mean you'd want to either expose it to the whole internet, or to every website in a browser
3872018-11-20T19:04:43  <wumpus> that'd instantly lift any vulnerability from local-only and limited scope to, pretty much, rce
3882018-11-20T19:04:51  <wumpus> same for DoS
3892018-11-20T19:04:59  <provoostenator> So it's for fast queries by semi-trusted software.
3902018-11-20T19:05:04  <wumpus> yes
3912018-11-20T19:05:52  <provoostenator> That makes sense. It might be good to document that intention to set expectations: https://github.com/bitcoin/bitcoin/blob/master/doc/REST-interface.md
3922018-11-20T19:05:56  <wumpus> or say, at most internal to your company if you bind on a local network interface and know what you're doing
3932018-11-20T19:07:17  <wumpus> bitcoind's P2P interface is the only interface that is hardened for public internet access, and even there improvements are certainly possible
3942018-11-20T19:07:17  <sipa> provoostenator: that sounds like a good idea
3952018-11-20T19:07:38  <wumpus> yes
3962018-11-20T19:07:58  <wumpus> would be good to document that better
3972018-11-20T19:08:55  <sipa> wumpus: so, in fairness, the issue of exposing REST to browsers (or any local program running untrusted code) already exists, and it's only through browsers' self-restraint that this is somewhat curbed
3982018-11-20T19:09:52  <sipa> i don't think CORS makes things any worse, it's just a question of whether we should treat browsers accessing REST as a supported/recommended practice
3992018-11-20T19:10:10  <sipa> and in general i think the answer is no, but perhaps for a company's internal site it makes sense
4002018-11-20T19:11:10  <gmaxwell> at least so long as REST is merely a DOS/RCE vector and not intentionally given access to anything too interesting it's not as big a deal.
4012018-11-20T19:11:22  <gmaxwell> don't want to repeat ethereum's mistakes.
4022018-11-20T19:13:10  <wumpus> sipa: *everything* is due to browser's self restraint, any security at all, if javascript would run unrestricted it would be really bad
4032018-11-20T19:14:20  <wumpus> and sure, there could be an option to add CORS headers for specific sites
4042018-11-20T19:14:35  <sipa> the PR lets you configure domains
4052018-11-20T19:14:37  <wumpus> if anyone is going to use that and test that
4062018-11-20T19:14:48  <wumpus> I'm just afraid of scope creep, as you know
4072018-11-20T19:15:24  <sipa> wumpus: i understand, but my point is that this isn't really restricted to browsers; the issue exists equally for say someone running an untrusted VM image that makes a connection to the host network
4082018-11-20T19:15:28  <wumpus> look, there's this concern we haven't even ever *thought* about and suddenly it needs to be considered in bitcoin core
4092018-11-20T19:15:58  <sipa> so our job should be to make sure that by default, these things aren't a concern, and document them well
4102018-11-20T19:16:30  <wumpus> yes, okay, the general case where peopel run untrusted software that can access local network, it's not possible to protect against that
4112018-11-20T19:16:39  <provoostenator> Someone who really wants this could add an nginx server that just adds the header etc.
4122018-11-20T19:16:43  <sipa> (i'm not arguing in favor of the CORS PR; I don't understand the use cases well enough, it just sounds to me that if remote access from local software is a problem, the solution is elsewhere)
4132018-11-20T19:17:10  <wumpus> remote access from random websites that the user opens in their browser is a problem
4142018-11-20T19:17:32  <wumpus> 'remote' I mean, it's effectively local, the browser protects that using CORS
4152018-11-20T19:18:07  <sipa> i mean things like by default not exposing REST, not exposing RPC port publicly, not having a trivial RPC username/password are all protections against this
4162018-11-20T19:18:10  <provoostenator> Scope creep is a nice thing to prevent. Even having to explain in documentation what the pitfalls of CORS are, and keep track of that, is overhead.
4172018-11-20T19:18:19  <gmaxwell> sipa: to be fair 'VM sandbox that has network access as localhost' is kind of a special case that applies to FAR fewer users than "I run a browser"
4182018-11-20T19:19:04  <sipa> wumpus: also, unix domain sockets instead of TCP/IP for RPC would be an improvement
4192018-11-20T19:19:27  <sipa> so it's at least restricted to the same user on the same machine
4202018-11-20T19:19:48  <jarthur> Yea, someone just needs to find time to finish that out.
4212018-11-20T19:20:46  <jarthur> Maybe I'll get some time this weekend if no one else is working on it
4222018-11-20T19:21:02  <wumpus> yes unix domain sockets would be great, I should rebase that some time
4232018-11-20T19:21:08  *** timothy has quit IRC
4242018-11-20T19:21:37  <wumpus> or someone else :)
4252018-11-20T19:21:57  *** dqx has joined #bitcoin-core-dev
4262018-11-20T19:25:33  *** dqx_ has quit IRC
4272018-11-20T19:30:01  *** rh0nj has quit IRC
4282018-11-20T19:31:08  *** rh0nj has joined #bitcoin-core-dev
4292018-11-20T19:35:49  <provoostenator> Unix domain sockets also to get data in other formats than JSON (so you don't need the REST API at all)?
4302018-11-20T19:37:20  *** Tennis has joined #bitcoin-core-dev
4312018-11-20T19:39:39  *** dqx_ has joined #bitcoin-core-dev
4322018-11-20T19:40:50  <wumpus> it'd be the same http server just over a different socket
4332018-11-20T19:41:01  <wumpus> not a completely different API
4342018-11-20T19:41:24  *** dqx_ has quit IRC
4352018-11-20T19:41:56  *** dqx_ has joined #bitcoin-core-dev
4362018-11-20T19:41:56  *** queip has quit IRC
4372018-11-20T19:42:09  *** dqx has quit IRC
4382018-11-20T19:43:43  *** bitconner has joined #bitcoin-core-dev
4392018-11-20T19:44:43  *** michaelsdunn1 has quit IRC
4402018-11-20T19:44:57  *** Chris_Stewart_5 has quit IRC
4412018-11-20T19:46:12  *** michaelsdunn1 has joined #bitcoin-core-dev
4422018-11-20T19:46:12  *** michaelsdunn1 has quit IRC
4432018-11-20T19:46:12  *** michaelsdunn1 has joined #bitcoin-core-dev
4442018-11-20T19:48:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4452018-11-20T19:48:39  *** bitconner has quit IRC
4462018-11-20T19:48:53  *** zallarak has quit IRC
4472018-11-20T19:49:33  *** queip has joined #bitcoin-core-dev
4482018-11-20T19:50:22  *** dqx_ has quit IRC
4492018-11-20T19:54:49  *** mr_paz has quit IRC
4502018-11-20T19:58:36  *** kelt has quit IRC
4512018-11-20T20:06:05  *** bitconner has joined #bitcoin-core-dev
4522018-11-20T20:06:08  *** bitcoin-git has joined #bitcoin-core-dev
4532018-11-20T20:06:09  <bitcoin-git> [bitcoin] vim88 closed pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
4542018-11-20T20:06:09  *** bitcoin-git has left #bitcoin-core-dev
4552018-11-20T20:06:44  *** promag has joined #bitcoin-core-dev
4562018-11-20T20:07:21  *** asoltys has quit IRC
4572018-11-20T20:16:17  <jnewbery> promag: > do we have tests to concurrently call RPC to the same node?
4582018-11-20T20:16:40  <jnewbery> yes: check mining_getblocktemplate_longpoll.py
4592018-11-20T20:16:51  <promag> jnewbery: hi, yap saw that
4602018-11-20T20:17:11  <promag> see #14670
4612018-11-20T20:17:18  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
4622018-11-20T20:17:18  <jnewbery> If you want to do similar in a new test, I recommend you take the LongPoll thread class and lift it into TestNode
4632018-11-20T20:17:47  <promag> https://github.com/bitcoin/bitcoin/pull/14670/files#diff-9ee18e00fd5f5f1444ba12e8e1378e6a
4642018-11-20T20:18:07  <promag> leave a comment there please, bbl
4652018-11-20T20:33:27  *** arubi has quit IRC
4662018-11-20T20:34:24  *** arubi has joined #bitcoin-core-dev
4672018-11-20T20:34:31  *** andrew79 has joined #bitcoin-core-dev
4682018-11-20T20:34:57  *** ezzzy has joined #bitcoin-core-dev
4692018-11-20T20:41:58  *** queip has quit IRC
4702018-11-20T20:46:45  *** queip has joined #bitcoin-core-dev
4712018-11-20T20:47:44  *** ezzzy has quit IRC
4722018-11-20T20:49:43  *** michaelsdunn1 has quit IRC
4732018-11-20T20:52:05  *** ezzzy has joined #bitcoin-core-dev
4742018-11-20T20:58:44  *** wpaulino has quit IRC
4752018-11-20T20:58:44  *** wpaulino has joined #bitcoin-core-dev
4762018-11-20T20:59:12  *** michaelsdunn1 has joined #bitcoin-core-dev
4772018-11-20T20:59:12  *** michaelsdunn1 has quit IRC
4782018-11-20T20:59:12  *** michaelsdunn1 has joined #bitcoin-core-dev
4792018-11-20T21:01:24  *** ezzzy has quit IRC
4802018-11-20T21:02:21  *** michaelsdunn1 has quit IRC
4812018-11-20T21:03:51  *** michaelsdunn1 has joined #bitcoin-core-dev
4822018-11-20T21:04:43  *** dviola has quit IRC
4832018-11-20T21:08:27  *** michaelsdunn1 has quit IRC
4842018-11-20T21:16:17  *** michaelsdunn1 has joined #bitcoin-core-dev
4852018-11-20T21:19:48  *** gelmutshmidt has quit IRC
4862018-11-20T21:24:43  *** Jbaczuk_ has quit IRC
4872018-11-20T21:34:15  *** owowo has quit IRC
4882018-11-20T21:34:22  *** andrew79 has quit IRC
4892018-11-20T21:39:07  *** owowo has joined #bitcoin-core-dev
4902018-11-20T21:40:38  *** cryptoboy has quit IRC
4912018-11-20T21:40:43  *** jrayhawk_ is now known as jrayhawk
4922018-11-20T21:41:56  *** queip has quit IRC
4932018-11-20T21:45:47  *** elichai2 has quit IRC
4942018-11-20T21:52:32  *** shesek has joined #bitcoin-core-dev
4952018-11-20T21:52:32  *** shesek has joined #bitcoin-core-dev
4962018-11-20T21:54:13  *** bitconner has quit IRC
4972018-11-20T21:54:37  *** tmz24 has joined #bitcoin-core-dev
4982018-11-20T21:55:03  *** tmz24 has quit IRC
4992018-11-20T21:57:49  *** queip has joined #bitcoin-core-dev
5002018-11-20T22:00:47  *** justanotheruser has quit IRC
5012018-11-20T22:15:51  *** hex17or has joined #bitcoin-core-dev
5022018-11-20T22:18:52  *** hex17or has quit IRC
5032018-11-20T22:20:08  *** promag has quit IRC
5042018-11-20T22:21:38  *** hex17or has joined #bitcoin-core-dev
5052018-11-20T22:21:45  *** rex4539 has quit IRC
5062018-11-20T22:33:05  *** spinza has quit IRC
5072018-11-20T22:36:19  *** spinza has joined #bitcoin-core-dev
5082018-11-20T22:37:44  *** Chris_Stewart_5 has quit IRC
5092018-11-20T22:40:05  *** hex17or has quit IRC
5102018-11-20T22:41:56  *** queip has quit IRC
5112018-11-20T22:42:22  *** hex17or has joined #bitcoin-core-dev
5122018-11-20T22:46:55  *** hex17or has quit IRC
5132018-11-20T22:50:58  *** hex17or has joined #bitcoin-core-dev
5142018-11-20T22:53:04  *** hex17or has quit IRC
5152018-11-20T22:54:52  *** queip has joined #bitcoin-core-dev
5162018-11-20T22:58:56  *** justanotheruser has joined #bitcoin-core-dev
5172018-11-20T23:04:16  *** iphelix has quit IRC
5182018-11-20T23:04:24  *** iphelix- has joined #bitcoin-core-dev
5192018-11-20T23:04:48  *** iphelix- is now known as iphelix
5202018-11-20T23:05:52  *** iphelix is now known as Guest19336
5212018-11-20T23:07:42  *** jamesob has quit IRC
5222018-11-20T23:07:54  *** jamesob has joined #bitcoin-core-dev
5232018-11-20T23:11:34  *** bitconner has joined #bitcoin-core-dev
5242018-11-20T23:28:07  *** dqx has joined #bitcoin-core-dev
5252018-11-20T23:40:58  *** fabianfabian has quit IRC
5262018-11-20T23:41:59  *** bitcoin-git has joined #bitcoin-core-dev
5272018-11-20T23:41:59  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
5282018-11-20T23:41:59  *** bitcoin-git has left #bitcoin-core-dev
5292018-11-20T23:42:05  *** queip has quit IRC
5302018-11-20T23:53:39  *** michaelfolkson has joined #bitcoin-core-dev
5312018-11-20T23:54:00  *** queip has joined #bitcoin-core-dev