12018-11-21T00:02:10 *** michaelfolkson has quit IRC
22018-11-21T00:08:47 *** Guyver2 has quit IRC
32018-11-21T00:12:01 *** michaelsdunn1 has quit IRC
42018-11-21T00:12:54 *** shesek has quit IRC
52018-11-21T00:13:32 *** shesek has joined #bitcoin-core-dev
62018-11-21T00:17:14 *** owner has joined #bitcoin-core-dev
72018-11-21T00:17:34 *** owner is now known as Guest70039
82018-11-21T00:17:44 *** Guest70039 is now known as TGeek
92018-11-21T00:20:57 *** jarthur has quit IRC
102018-11-21T00:22:24 <TGeek> Hi all, I am having an issue in bitcoin core 0.17.0.1 with the bumpfee rpc call.. It keeps throwing an error "(-4) Transaction does not have a change output". Which is strange because the output for the tx has two outputs, one for the to address and one for change. I have been troubleshooting this issue for 2 days now and cannot seem to find anything related in searches.. Any help would be greatly appreciated.
112018-11-21T00:23:46 <sipa> how was the transaction created?
122018-11-21T00:24:41 <TGeek> via createrawtransaction and set as replaceable
132018-11-21T00:25:24 <sipa> how did you create the change?
142018-11-21T00:25:28 <sipa> *the change address
152018-11-21T00:26:14 <TGeek> tried both getnewaddress and getrawchangeaddress.. both do not work
162018-11-21T00:26:34 <sipa> i think you should open an issue
172018-11-21T00:26:57 <gmaxwell> does the fee bumper give correct errors on all the other cases it can't handle?
182018-11-21T00:27:00 <TGeek> also tried using a specific static address with a UTXO's
192018-11-21T00:27:46 <sipa> i would expect getrawchangeaddress to work
202018-11-21T00:28:19 <sipa> but maybe the change information is held as metadata in the wallet, which means it won't work with anything but sendtoaddress/sendmany
212018-11-21T00:29:39 <TGeek> hmm.. but getrawchangeaddress says in the docs that it is only for using with RAW transactions "NOT normal use"
222018-11-21T00:30:12 *** Chris_Stewart_5 has joined #bitcoin-core-dev
232018-11-21T00:30:38 <sipa> TGeek: yes, i mean that it's possible that bumpfee only works on transaction created through sendtoaddress/sendmany, and not through any of the rawtransaction RPCs
242018-11-21T00:31:20 <sipa> in any case, if so, that should be improved upon
252018-11-21T00:31:29 <sipa> so perhaps best to open an issue so more people can chime in
262018-11-21T00:32:07 <TGeek> ok, will do.. thanks for your time, have a good one
272018-11-21T00:41:06 *** bitcoin-git has joined #bitcoin-core-dev
282018-11-21T00:41:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
292018-11-21T00:41:06 *** bitcoin-git has left #bitcoin-core-dev
302018-11-21T00:42:00 *** queip has quit IRC
312018-11-21T00:47:33 *** queip has joined #bitcoin-core-dev
322018-11-21T00:51:01 *** rh0nj has quit IRC
332018-11-21T00:52:07 *** rh0nj has joined #bitcoin-core-dev
342018-11-21T01:00:59 *** Tennis has quit IRC
352018-11-21T01:02:48 *** TGeek has quit IRC
362018-11-21T01:17:41 *** _cryptodesktop_i has joined #bitcoin-core-dev
372018-11-21T01:22:24 *** spinza has quit IRC
382018-11-21T01:25:33 *** spinza has joined #bitcoin-core-dev
392018-11-21T01:25:53 *** michaelfolkson has joined #bitcoin-core-dev
402018-11-21T01:36:31 *** Victorsueca has quit IRC
412018-11-21T01:37:42 *** Victorsueca has joined #bitcoin-core-dev
422018-11-21T01:42:03 *** queip has quit IRC
432018-11-21T01:48:14 *** bitconner has quit IRC
442018-11-21T01:51:39 *** _cryptodesktop_i has quit IRC
452018-11-21T01:52:10 *** queip has joined #bitcoin-core-dev
462018-11-21T02:04:15 *** Chris_Stewart_5 has quit IRC
472018-11-21T02:21:19 *** michaelfolkson has quit IRC
482018-11-21T02:31:31 *** rex4539 has joined #bitcoin-core-dev
492018-11-21T02:37:16 *** shesek has quit IRC
502018-11-21T02:37:42 *** justanotheruser has quit IRC
512018-11-21T02:37:43 *** shesek has joined #bitcoin-core-dev
522018-11-21T02:37:43 *** shesek has joined #bitcoin-core-dev
532018-11-21T02:37:55 *** arubi has quit IRC
542018-11-21T02:38:52 *** arubi has joined #bitcoin-core-dev
552018-11-21T02:39:08 *** rex4539 has quit IRC
562018-11-21T02:45:05 *** profmac has quit IRC
572018-11-21T02:57:39 *** profmac has joined #bitcoin-core-dev
582018-11-21T03:02:00 *** Bullit has quit IRC
592018-11-21T03:04:48 *** justanotheruser has joined #bitcoin-core-dev
602018-11-21T03:08:29 *** justanotheruser has quit IRC
612018-11-21T03:08:58 *** justanotheruser has joined #bitcoin-core-dev
622018-11-21T03:14:29 *** michaelsdunn1 has joined #bitcoin-core-dev
632018-11-21T03:36:21 *** mineralnov has joined #bitcoin-core-dev
642018-11-21T03:37:41 *** AaronvanW has quit IRC
652018-11-21T03:38:03 *** michaelsdunn1 has quit IRC
662018-11-21T03:41:57 *** queip has quit IRC
672018-11-21T03:54:26 *** queip has joined #bitcoin-core-dev
682018-11-21T04:16:37 *** bitcoin-git has joined #bitcoin-core-dev
692018-11-21T04:16:38 <bitcoin-git> [bitcoin] kallewoof opened pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774
702018-11-21T04:16:38 *** bitcoin-git has left #bitcoin-core-dev
712018-11-21T04:21:30 *** schnerchi has joined #bitcoin-core-dev
722018-11-21T04:24:39 *** schnerch_ has quit IRC
732018-11-21T04:42:01 *** queip has quit IRC
742018-11-21T04:52:29 *** queip has joined #bitcoin-core-dev
752018-11-21T04:53:02 *** rh0nj has quit IRC
762018-11-21T04:54:08 *** rh0nj has joined #bitcoin-core-dev
772018-11-21T05:03:47 *** CodeBlue1776 has quit IRC
782018-11-21T05:05:51 *** CodeBlue1776 has joined #bitcoin-core-dev
792018-11-21T05:10:27 *** bitcoin-git has joined #bitcoin-core-dev
802018-11-21T05:10:27 <bitcoin-git> [bitcoin] dooglus opened pull request #14775: 'break' should be 'continue' here? (master...patch-6) https://github.com/bitcoin/bitcoin/pull/14775
812018-11-21T05:10:27 *** bitcoin-git has left #bitcoin-core-dev
822018-11-21T05:27:42 *** ap4lmtree has quit IRC
832018-11-21T05:29:51 *** ap4lmtree has joined #bitcoin-core-dev
842018-11-21T05:40:44 *** ap4lmtree- has joined #bitcoin-core-dev
852018-11-21T05:42:03 *** queip has quit IRC
862018-11-21T05:42:33 *** ap4lmtree has quit IRC
872018-11-21T05:45:16 *** ap4lmtree has joined #bitcoin-core-dev
882018-11-21T05:46:49 *** ap4lmtree- has quit IRC
892018-11-21T05:52:36 *** queip has joined #bitcoin-core-dev
902018-11-21T06:20:42 *** oneark has joined #bitcoin-core-dev
912018-11-21T06:40:27 *** IGHOR has quit IRC
922018-11-21T06:41:52 *** IGHOR has joined #bitcoin-core-dev
932018-11-21T06:50:12 *** rex4539 has joined #bitcoin-core-dev
942018-11-21T06:52:33 *** Zenton has quit IRC
952018-11-21T06:55:53 *** schnerchi has quit IRC
962018-11-21T06:57:58 *** bitcoin-git has joined #bitcoin-core-dev
972018-11-21T06:57:58 <bitcoin-git> [bitcoin] jameshilliard opened pull request #14776: Add process based prctl spectre mitigation controls. (master...spectre-prctl) https://github.com/bitcoin/bitcoin/pull/14776
982018-11-21T06:57:58 *** bitcoin-git has left #bitcoin-core-dev
992018-11-21T07:10:11 *** schnerchi has joined #bitcoin-core-dev
1002018-11-21T07:11:48 *** jrayhawk has quit IRC
1012018-11-21T07:12:05 *** jrayhawk has joined #bitcoin-core-dev
1022018-11-21T07:16:22 *** dqx_ has joined #bitcoin-core-dev
1032018-11-21T07:16:54 *** rex4539 has quit IRC
1042018-11-21T07:29:37 *** rex4539 has joined #bitcoin-core-dev
1052018-11-21T07:35:49 *** jrayhawk has quit IRC
1062018-11-21T07:36:02 *** jrayhawk has joined #bitcoin-core-dev
1072018-11-21T07:38:18 *** jrayhawk has quit IRC
1082018-11-21T07:38:29 *** jrayhawk has joined #bitcoin-core-dev
1092018-11-21T08:33:23 *** mineralnov has quit IRC
1102018-11-21T08:40:00 <wumpus> what's up with appveyor? looks like it's failing on every PR
1112018-11-21T08:42:00 *** queip has quit IRC
1122018-11-21T08:44:31 *** rex4539 has quit IRC
1132018-11-21T08:46:37 *** tryphe has quit IRC
1142018-11-21T08:54:57 *** queip has joined #bitcoin-core-dev
1152018-11-21T08:55:01 *** rh0nj has quit IRC
1162018-11-21T08:56:10 *** rh0nj has joined #bitcoin-core-dev
1172018-11-21T09:03:34 *** setpill has joined #bitcoin-core-dev
1182018-11-21T09:34:07 *** bitcoin-git has joined #bitcoin-core-dev
1192018-11-21T09:34:15 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6b90a2a0e065...267793af8b03
1202018-11-21T09:34:15 <bitcoin-git> bitcoin/master 6be7d14 Carl Dong: Properly generate salt in rpcauth.py, update tests...
1212018-11-21T09:34:15 <bitcoin-git> bitcoin/master 267793a Wladimir J. van der Laan: Merge #14742: Properly generate salt in rpcauth.py...
1222018-11-21T09:34:15 *** bitcoin-git has left #bitcoin-core-dev
1232018-11-21T09:35:12 *** bitcoin-git has joined #bitcoin-core-dev
1242018-11-21T09:35:13 <bitcoin-git> [bitcoin] laanwj closed pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
1252018-11-21T09:35:13 *** bitcoin-git has left #bitcoin-core-dev
1262018-11-21T09:40:33 *** Zenton has joined #bitcoin-core-dev
1272018-11-21T09:42:58 *** promag has joined #bitcoin-core-dev
1282018-11-21T09:43:14 <promag> wumpus: test added to #14670
1292018-11-21T09:43:29 <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
1302018-11-21T09:46:31 *** Guyver2 has joined #bitcoin-core-dev
1312018-11-21T09:58:11 *** promag has quit IRC
1322018-11-21T10:00:10 *** tryphe has joined #bitcoin-core-dev
1332018-11-21T10:01:26 *** tryphe has quit IRC
1342018-11-21T10:01:26 *** timothy has joined #bitcoin-core-dev
1352018-11-21T10:01:50 *** tryphe has joined #bitcoin-core-dev
1362018-11-21T10:03:42 *** kexkey has quit IRC
1372018-11-21T10:06:33 *** promag has joined #bitcoin-core-dev
1382018-11-21T10:11:18 *** promag has quit IRC
1392018-11-21T10:12:58 *** harrymm has joined #bitcoin-core-dev
1402018-11-21T10:36:37 *** schmidty_ has quit IRC
1412018-11-21T10:40:59 *** timothy has quit IRC
1422018-11-21T10:41:22 *** timothy has joined #bitcoin-core-dev
1432018-11-21T10:42:16 *** queip has quit IRC
1442018-11-21T10:43:11 *** spinza has quit IRC
1452018-11-21T10:43:21 *** CodeBlue1776 has quit IRC
1462018-11-21T10:44:24 *** CodeBlue1776 has joined #bitcoin-core-dev
1472018-11-21T10:54:08 *** queip has joined #bitcoin-core-dev
1482018-11-21T10:59:52 *** bitcoin-git has joined #bitcoin-core-dev
1492018-11-21T10:59:53 <bitcoin-git> [bitcoin] domob1812 opened pull request #14777: tests: Add regtest for JSON-RPC batch calls (master...batch-rpc) https://github.com/bitcoin/bitcoin/pull/14777
1502018-11-21T10:59:53 *** bitcoin-git has left #bitcoin-core-dev
1512018-11-21T11:00:23 *** spinza has joined #bitcoin-core-dev
1522018-11-21T11:10:27 *** promag has joined #bitcoin-core-dev
1532018-11-21T11:10:41 <promag> no travis job for #14777? :/
1542018-11-21T11:10:43 <gribble> https://github.com/bitcoin/bitcoin/issues/14777 | tests: Add regtest for JSON-RPC batch calls by domob1812 · Pull Request #14777 · bitcoin/bitcoin · GitHub
1552018-11-21T11:12:25 *** spinza has quit IRC
1562018-11-21T11:32:40 *** promag has quit IRC
1572018-11-21T11:35:02 *** spinza has joined #bitcoin-core-dev
1582018-11-21T11:40:49 *** shesek` has joined #bitcoin-core-dev
1592018-11-21T11:42:01 *** queip has quit IRC
1602018-11-21T11:44:07 *** shesek has quit IRC
1612018-11-21T11:45:25 *** shesek` has quit IRC
1622018-11-21T11:46:01 *** shesek` has joined #bitcoin-core-dev
1632018-11-21T11:47:47 *** queip has joined #bitcoin-core-dev
1642018-11-21T11:51:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1652018-11-21T11:55:53 *** shesek` has quit IRC
1662018-11-21T11:56:29 *** shesek` has joined #bitcoin-core-dev
1672018-11-21T11:59:33 *** intcat has quit IRC
1682018-11-21T12:01:35 *** intcat has joined #bitcoin-core-dev
1692018-11-21T12:16:29 *** ap4lmtree has quit IRC
1702018-11-21T12:16:54 *** ap4lmtree has joined #bitcoin-core-dev
1712018-11-21T12:22:02 *** shesek` has quit IRC
1722018-11-21T12:23:13 *** shesek` has joined #bitcoin-core-dev
1732018-11-21T12:25:33 *** shesek` has joined #bitcoin-core-dev
1742018-11-21T12:26:18 *** davec_ has quit IRC
1752018-11-21T12:27:28 *** davec has joined #bitcoin-core-dev
1762018-11-21T12:31:58 *** Chris_Stewart_5 has quit IRC
1772018-11-21T12:38:27 *** AaronvanW has joined #bitcoin-core-dev
1782018-11-21T12:42:03 *** queip has quit IRC
1792018-11-21T12:42:27 *** Victorsueca has quit IRC
1802018-11-21T12:43:43 *** Victorsueca has joined #bitcoin-core-dev
1812018-11-21T12:44:03 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822018-11-21T12:50:20 *** queip has joined #bitcoin-core-dev
1832018-11-21T12:52:31 *** promag has joined #bitcoin-core-dev
1842018-11-21T12:58:56 *** gelmutshmidt has joined #bitcoin-core-dev
1852018-11-21T13:04:42 *** gelmutshmidt has quit IRC
1862018-11-21T13:04:43 *** promag has quit IRC
1872018-11-21T13:07:07 *** dawud has joined #bitcoin-core-dev
1882018-11-21T13:07:09 <dawud> Hello anybody around?
1892018-11-21T13:08:31 <dawud> I have a question about generating keys. I've used bitaddress.org to generate a key pair. It works pretty simply, so I'm pretty confused what could have gone wrong.
1902018-11-21T13:08:57 <wumpus> ask general question in #bitcoin please
1912018-11-21T13:09:20 <dawud> This is about R values and the algorithm used to generate private keys.
1922018-11-21T13:09:42 <dawud> When I generated the key, I took photos and wrote down the 'brain wallet passphrase'. So, I know the phrase is "correct". However, now, when I type the same passphrase, it generates a DIFFERENT private key.
1932018-11-21T13:10:11 <dawud> So, I'm wondering, in core, when generating keys, is there a way that somehow a different R value or something like that could happen, if it was done, say, in an old version of core?
1942018-11-21T13:10:16 <phantomcircuit> dawud, still this channel is about bitcoin core development
1952018-11-21T13:10:20 <phantomcircuit> which this is definitely not
1962018-11-21T13:11:13 <dawud> I asked there.
1972018-11-21T13:14:28 *** agnjunio has joined #bitcoin-core-dev
1982018-11-21T13:14:31 *** shesek` has quit IRC
1992018-11-21T13:14:37 <wumpus> please, don't insist. you could also try the bitcoin stack exchange (https://bitcoin.stackexchange.com/) if #bitcoin yields nothing
2002018-11-21T13:15:12 *** shesek` has joined #bitcoin-core-dev
2012018-11-21T13:30:58 *** promag has joined #bitcoin-core-dev
2022018-11-21T13:34:35 *** rex4539 has joined #bitcoin-core-dev
2032018-11-21T13:35:48 *** Guyver2 has quit IRC
2042018-11-21T13:40:34 *** face has quit IRC
2052018-11-21T13:41:47 *** bitcoin-git has joined #bitcoin-core-dev
2062018-11-21T13:41:48 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/267793af8b03...16498860546e
2072018-11-21T13:41:48 <bitcoin-git> bitcoin/master fa7da06 MarcoFalke: qa: Check specific reject reasons in feature_block
2082018-11-21T13:41:49 <bitcoin-git> bitcoin/master 1649886 Wladimir J. van der Laan: Merge #14719: qa: Check specific reject reasons in feature_block...
2092018-11-21T13:41:50 *** bitcoin-git has left #bitcoin-core-dev
2102018-11-21T13:41:58 *** queip has quit IRC
2112018-11-21T13:42:58 *** bitcoin-git has joined #bitcoin-core-dev
2122018-11-21T13:42:58 <bitcoin-git> [bitcoin] laanwj closed pull request #14719: qa: Check specific reject reasons in feature_block (master...Mf1811-qaRejectBlock) https://github.com/bitcoin/bitcoin/pull/14719
2132018-11-21T13:42:58 *** bitcoin-git has left #bitcoin-core-dev
2142018-11-21T13:43:58 *** gelmutshmidt has joined #bitcoin-core-dev
2152018-11-21T13:47:01 *** rh0nj has quit IRC
2162018-11-21T13:50:27 *** queip has joined #bitcoin-core-dev
2172018-11-21T13:50:54 *** promag has quit IRC
2182018-11-21T13:55:50 *** justanotheruser has quit IRC
2192018-11-21T14:13:52 *** spinza has quit IRC
2202018-11-21T14:34:02 *** spinza has joined #bitcoin-core-dev
2212018-11-21T14:37:17 *** dqx__ has joined #bitcoin-core-dev
2222018-11-21T14:38:44 *** dqx_ has quit IRC
2232018-11-21T14:41:57 *** queip has quit IRC
2242018-11-21T14:42:41 *** dqx__ has quit IRC
2252018-11-21T14:47:40 *** dawud has quit IRC
2262018-11-21T14:51:06 *** queip has joined #bitcoin-core-dev
2272018-11-21T14:54:54 *** dqx_ has joined #bitcoin-core-dev
2282018-11-21T14:56:23 *** promag has joined #bitcoin-core-dev
2292018-11-21T15:05:56 *** setpill has quit IRC
2302018-11-21T15:24:07 *** Guyver2 has joined #bitcoin-core-dev
2312018-11-21T15:28:39 *** dqx_ has quit IRC
2322018-11-21T15:29:19 *** dqx_ has joined #bitcoin-core-dev
2332018-11-21T15:30:26 *** promag has quit IRC
2342018-11-21T15:33:06 *** promag has joined #bitcoin-core-dev
2352018-11-21T15:33:43 *** gelmuth_ has joined #bitcoin-core-dev
2362018-11-21T15:36:40 *** gelmutshmidt has quit IRC
2372018-11-21T15:42:03 *** queip has quit IRC
2382018-11-21T15:48:10 *** queip has joined #bitcoin-core-dev
2392018-11-21T15:49:47 *** dviola has joined #bitcoin-core-dev
2402018-11-21T15:57:12 *** kexkey has joined #bitcoin-core-dev
2412018-11-21T16:16:21 *** shesek` has quit IRC
2422018-11-21T16:17:38 *** shesek has joined #bitcoin-core-dev
2432018-11-21T16:20:06 *** gelmuth_ has quit IRC
2442018-11-21T16:21:56 *** shesek has quit IRC
2452018-11-21T16:23:08 *** shesek has joined #bitcoin-core-dev
2462018-11-21T16:27:27 *** dqx_ has quit IRC
2472018-11-21T16:34:04 *** shesek has quit IRC
2482018-11-21T16:38:10 *** shesek has joined #bitcoin-core-dev
2492018-11-21T16:42:06 *** queip has quit IRC
2502018-11-21T16:50:49 *** queip has joined #bitcoin-core-dev
2512018-11-21T16:54:08 *** shesek has quit IRC
2522018-11-21T16:55:03 *** shesek has joined #bitcoin-core-dev
2532018-11-21T16:55:47 <stevenroose> Does bitcoind remove the cookie file when closing?
2542018-11-21T16:56:33 <stevenroose> Hmm seems so, didn't know.
2552018-11-21T17:00:59 *** meshcollider_ has joined #bitcoin-core-dev
2562018-11-21T17:07:38 *** Chris_Stewart_5 has quit IRC
2572018-11-21T17:10:18 *** rex4539 has quit IRC
2582018-11-21T17:11:47 <stevenroose> Is core supposed to make the .cookie file in datadir/.cookie or datadit/chain/.cookie?
2592018-11-21T17:11:54 <stevenroose> With chain = chainname
2602018-11-21T17:12:08 <stevenroose> I'm reading this: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L329
2612018-11-21T17:12:10 <stevenroose> But I seem to find the cookie file in the main datadir.
2622018-11-21T17:12:25 <sipa> stevenroose: inside the chain specific datadir
2632018-11-21T17:12:45 <sipa> if you configure the datadir yourself, that's the one that will be used
2642018-11-21T17:13:08 <sipa> otherwise a default is used that depends on the chain
2652018-11-21T17:16:48 <stevenroose> sipa: oh wait, so if you set -datadir yourself, it should be top-level?
2662018-11-21T17:17:10 <stevenroose> but then that like in test_framework doesn't make sense, right? test_framework always sets the -datadir and still it points at datadir/regtest/.cookie?
2672018-11-21T17:17:18 <stevenroose> s/that like/that line/
2682018-11-21T17:21:04 <stevenroose> sipa: it seems to always add the network-specific part, no?
2692018-11-21T17:21:18 <stevenroose> https://github.com/bitcoin/bitcoin/blob/master/src/util/system.cpp#L786
2702018-11-21T17:25:38 <stevenroose> ah, networkspecific part for mainnet is "" :|
2712018-11-21T17:25:40 <stevenroose> k thanks
2722018-11-21T17:32:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2732018-11-21T17:33:07 *** rh0nj has joined #bitcoin-core-dev
2742018-11-21T17:33:46 *** owowo has quit IRC
2752018-11-21T17:34:17 <wumpus> even if you configure datadir yourself, it should use the network-specific subdir
2762018-11-21T17:34:36 <wumpus> for mainnet that's top-level
2772018-11-21T17:35:57 <wumpus> test chains (testnet3, regtest) have subdirectories
2782018-11-21T17:37:30 *** spinza has quit IRC
2792018-11-21T17:38:51 *** rex4539 has joined #bitcoin-core-dev
2802018-11-21T17:39:25 *** jarthur has joined #bitcoin-core-dev
2812018-11-21T17:41:43 *** owowo has joined #bitcoin-core-dev
2822018-11-21T17:42:00 *** queip has quit IRC
2832018-11-21T17:44:49 *** provoostenator has quit IRC
2842018-11-21T17:45:20 *** provoost- has joined #bitcoin-core-dev
2852018-11-21T17:45:28 *** provoost- is now known as provoostenator
2862018-11-21T17:48:53 *** spinza has joined #bitcoin-core-dev
2872018-11-21T17:50:25 *** queip has joined #bitcoin-core-dev
2882018-11-21T18:16:33 *** Victorsueca has quit IRC
2892018-11-21T18:17:43 *** Victorsueca has joined #bitcoin-core-dev
2902018-11-21T18:17:50 *** shesek has quit IRC
2912018-11-21T18:18:18 *** shesek has joined #bitcoin-core-dev
2922018-11-21T18:18:18 *** shesek has joined #bitcoin-core-dev
2932018-11-21T18:26:17 *** AaronvanW has quit IRC
2942018-11-21T18:30:09 *** dgpv has joined #bitcoin-core-dev
2952018-11-21T18:32:27 <dgpv> script output descriptors multi() expression supports only fixed order of keys, in the order they listed
2962018-11-21T18:32:55 <dgpv> but some wallets (copay, for example) uses an approach where pubkeys are sorted by their hex values for each address
2972018-11-21T18:33:26 <dgpv> to create an address at index 123, you get all pubkeys for index 123, sort the pubkeys, and then make a multisig address with them
2982018-11-21T18:33:49 <gmaxwell> ugh, that prevents you from putting the most likely to sign first, so they take longer to validate.
2992018-11-21T18:33:57 <dgpv> this way there's no need to know the order of the keys in a keyring
3002018-11-21T18:34:48 <gmaxwell> dgpv: they could have as well defined it by sorting the master keys.
3012018-11-21T18:35:00 <dgpv> you only need to know the xpubs of participants, but not the order of how they joined the multisig scheme
3022018-11-21T18:35:17 <dgpv> they could not, because they do not know the order beforehand
3032018-11-21T18:35:29 <dgpv> some user creates multisig wallets and sends invitations to others
3042018-11-21T18:35:35 <dgpv> they may join in arbitrary order
3052018-11-21T18:35:46 <dgpv> *creates multisig wallet*, not wallets
3062018-11-21T18:36:40 *** AaronvanW has joined #bitcoin-core-dev
3072018-11-21T18:36:58 <dgpv> they also do not know who will likely to sign more often
3082018-11-21T18:37:24 <gmaxwell> dgpv: I am not following your statement. If the keys on an output come from xpubs a, b, c then they could be put in xpub sorted order.
3092018-11-21T18:37:50 <gmaxwell> dgpv: the user almost certantly does, even if the application doesn't provide a way for the user to tell them. :)
3102018-11-21T18:38:03 <sipa> dgpv: i don't think it's unreasonable to extend descriptors with a sorted-multi construction
3112018-11-21T18:38:30 <dgpv> my point is that this scheme exists, and is used for a long time by at least one wallet
3122018-11-21T18:38:34 *** bitcoin-git has joined #bitcoin-core-dev
3132018-11-21T18:38:35 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/16498860546e...d7b0258ff037
3142018-11-21T18:38:36 <bitcoin-git> bitcoin/master 3fb09b9 Akio Nakamura: Warn unrecognized sections in the config file...
3152018-11-21T18:38:36 <bitcoin-git> bitcoin/master d7b0258 Wladimir J. van der Laan: Merge #14708: Warn unrecognised sections in the config file...
3162018-11-21T18:38:37 *** bitcoin-git has left #bitcoin-core-dev
3172018-11-21T18:38:53 *** Zenton has quit IRC
3182018-11-21T18:39:08 <dgpv> we also do not use this scheme as a default, but support it as an artifact of previous integration with copay/bws
3192018-11-21T18:39:39 *** bitcoin-git has joined #bitcoin-core-dev
3202018-11-21T18:39:40 <bitcoin-git> [bitcoin] laanwj closed pull request #14708: Warn unrecognised sections in the config file (master...warn_unrecognized_section) https://github.com/bitcoin/bitcoin/pull/14708
3212018-11-21T18:39:40 *** bitcoin-git has left #bitcoin-core-dev
3222018-11-21T18:39:46 <sipa> dgpv: so far, the bitcoin core wallet also hasn't really supported HD chains created by other software as import
3232018-11-21T18:40:01 <sipa> and it still doesn't, but with descriptors that'll hopefully become easier
3242018-11-21T18:40:38 <dgpv> one of the use for descriptors is interoperability, as I understand
3252018-11-21T18:40:48 <sipa> not really
3262018-11-21T18:40:56 <sipa> it's more about flexibility
3272018-11-21T18:41:13 <sipa> interoperability may be a nice side effect
3282018-11-21T18:41:18 *** timothy has quit IRC
3292018-11-21T18:41:34 *** AaronvanW has quit IRC
3302018-11-21T18:41:34 <sipa> but i don't expect other wallets to support descriptors too, or at least not in a guaranteed to be compatible way
3312018-11-21T18:41:48 <sipa> they're just a generic way for representing something more flexible and readable than what we had before in core
3322018-11-21T18:42:03 *** queip has quit IRC
3332018-11-21T18:42:22 <dgpv> it would be useful way to create interoperable backups
3342018-11-21T18:42:40 <sipa> meh :)
3352018-11-21T18:42:53 <sipa> different software hardly agrees on what a wallet is
3362018-11-21T18:43:02 <gmaxwell> Generally interoperablity between wallets in a broad sense is misguided... the interoperability depends critically on the functionality, and we can't expect all wallets to have the same functionality.
3372018-11-21T18:43:24 <dgpv> we support a lot address configurations, and could create script descriptors that can be imported into core, or import descriptors from core
3382018-11-21T18:43:35 <sipa> sure, but will you keep up?
3392018-11-21T18:43:51 <sipa> i don't intend to make descriptors a "standard" - more something that we can easily extend
3402018-11-21T18:44:25 *** oneark has quit IRC
3412018-11-21T18:44:43 <sipa> i think it's important to provide flexibility, so that power users can build interesting constructions on top - which may include interoperability between wallets
3422018-11-21T18:44:57 <luke-jr> dgpv: last year, quite a few wallet software teams met to discuss issues like interoperability, but concluded it wasn't practical
3432018-11-21T18:45:15 <sipa> but interoperability as a supported feature is very hard, as it essentially requires the developer teams to coordinate rollouts of new features etc
3442018-11-21T18:46:11 <gmaxwell> luke-jr: They're interoperable in the sense that you can send funds from one wallet to another. :P
3452018-11-21T18:46:20 <luke-jr> gmaxwell: well, yeah, but .. context :P
3462018-11-21T18:46:23 <sipa> in any case, i have no objection to extending descriptors with a sorted-pubkey-multisig construction if that's useful, but it's not personally a priority to me
3472018-11-21T18:47:30 *** queip has joined #bitcoin-core-dev
3482018-11-21T18:47:50 <luke-jr> I guess note that for literal export/import, one could treat any wallet as JBOK
3492018-11-21T18:48:59 <promag> should we allow reindex=1 in conf file?
3502018-11-21T18:49:30 <gmaxwell> it's almost always a mistake, but I thought we discussed doing something about that before...
3512018-11-21T18:49:38 <promag> or maybe warn?
3522018-11-21T18:49:38 <luke-jr> promag: I don't think it would be reasonable to forbid it
3532018-11-21T18:49:57 <gmaxwell> I guess one downside of refusing it, is that if someone has a startup script where the only way to pass options to the process is the config file...
3542018-11-21T18:50:00 <promag> is there a use case for that? I can't see one
3552018-11-21T18:50:03 <dgpv> only popular wallet with exotic scripts that I know is greenaddress, others use standard scripts and maybe different derivation paths..
3562018-11-21T18:50:08 <sipa> promag: there are people for whom editing the config file is easier than passing a cmdline argument, i think
3572018-11-21T18:50:30 <luke-jr> conf file shouldn't deviate from command line parsing too much
3582018-11-21T18:50:51 <luke-jr> being stricter with unknown command line options makes sense, but anything more seems like a bad idea
3592018-11-21T18:51:04 <sipa> agree
3602018-11-21T18:51:06 <gmaxwell> dgpv: use of the particular script is only 1% of what it takes to make things compatible.
3612018-11-21T18:51:19 <dgpv> what else? derivation paths ?
3622018-11-21T18:51:22 <promag> so not even warn?
3632018-11-21T18:51:47 <rafalcpp> maybe warn, or someone will be stuck always reindexing?
3642018-11-21T18:51:56 <luke-jr> rafalcpp: I think anyone would notice fairly quickly
3652018-11-21T18:51:57 <dgpv> if you allow to specify arbitrary derivation paths with templates, you can support any scheme
3662018-11-21T18:52:12 <gmaxwell> dgpv: Seriously, the bitcoin project has been held back for years by misguided efforts towards interoperability with a largely indifferent industry. It's a bit irritating that you're advocating us burning more time here on this particular point of it, because it would be useful in your product.
3672018-11-21T18:52:35 *** shesek has quit IRC
3682018-11-21T18:52:38 <rafalcpp> luke-jr: if some RPC for getting general "state" of node could include misc warninings, it could remind there
3692018-11-21T18:53:14 <sipa> gmaxwell: no need for that
3702018-11-21T18:53:22 <sipa> i'm sure dgpv is just earnestly trying to understand the issue
3712018-11-21T18:53:44 *** gmaxwell has left #bitcoin-core-dev
3722018-11-21T18:53:55 <luke-jr> rafalcpp: "hmm, every time i restart my node it takes days to work again" is a stronger warning than anything we can do
3732018-11-21T18:54:49 <dgpv> actually this is new info for me, about the fact that interoperability is not important
3742018-11-21T18:55:20 <sipa> dgpv: of course interoperability is important, but it comes at a high cost
3752018-11-21T18:55:36 <sipa> and i think the space, and the concept of what wallets are and try to be is just evolving too fast to focus on it
3762018-11-21T18:55:56 <promag> luke-jr: +1
3772018-11-21T18:56:04 <promag> thanks for the feedback
3782018-11-21T18:56:28 <sipa> dgpv: for example, how to deal with change, or backups, or multiple wallets, or hardware devices, ...
3792018-11-21T18:56:41 <sipa> are all ways in which wallets can differ in ways that make them hard to interoperate
3802018-11-21T18:57:04 <luke-jr> coming soon: or Lightning channels
3812018-11-21T18:57:19 <sipa> some software insists that 'the blockchain is your wallet' and everything except a seed can be recovered from the chain
3822018-11-21T18:57:34 <luke-jr> x.x
3832018-11-21T18:57:42 <sipa> luke-jr: exactly
3842018-11-21T18:57:52 <rafalcpp> luke-jr: what about a server, it will just have 80% of uptime for bitcoind unstead of 99% for unclear reason. Wouldnt't RPC getblockchaininfo -> "warnings" field make sense? Maybe not, but we could make it a place admins know to look at first when troubleshooting. "doing-reindex". Maybe later also "no-peers", and some other. Just idea
3852018-11-21T18:58:52 <sipa> dgpv: when you include multiparty or multidevice things, you complicate things further, even beyond just the script involved (for example, how do the different parties interact to construct a transaction)
3862018-11-21T19:00:28 <dgpv> sipa: but IMO the most important part is how to specify where to find your UTXO - how to generate the addresses
3872018-11-21T19:00:53 <sipa> dgpv: even that differs between wallets
3882018-11-21T19:00:59 <dgpv> sipa: the most important for interoperability - you can have your money even if you have a backup from now-unsupported wallet
3892018-11-21T19:01:24 <sipa> dgpv: emergency recovery is a whole lot easier to support than full interoperability though
3902018-11-21T19:01:38 <dgpv> sipa: but what differs is scripts, derivation paths, and maybe pubkey order
3912018-11-21T19:02:24 <sipa> i'm not sure what you're arguing for now
3922018-11-21T19:02:49 <sipa> all i'm saying is that i don't think it makes sense to commit to "bitcoin core aims to be interoperable with software X"
3932018-11-21T19:03:36 <sipa> if descriptors are flexible enough to support emergency recovery from wallets created by software X, great, use it
3942018-11-21T19:04:14 <dgpv> sipa: actually my initial question was should I submit a PR with change for sortedmulti() or just create an issue on bitcoin core github
3952018-11-21T19:04:30 <dgpv> sipa: got a suggestion to ask here first
3962018-11-21T19:04:30 <sipa> up to you
3972018-11-21T19:05:04 <dgpv> sipa: I got my answer, so thank you for the time you expended answering me
3982018-11-21T19:05:35 <luke-jr> dgpv: I think the existing sorted multi PR should get merged first
3992018-11-21T19:05:51 <dgpv> it is there ?
4002018-11-21T19:05:59 <luke-jr> not for HD, just in general
4012018-11-21T19:06:28 <sipa> there's also a bip for it i think
4022018-11-21T19:06:33 <luke-jr> #8751
4032018-11-21T19:06:35 <gribble> https://github.com/bitcoin/bitcoin/issues/8751 | RPC: Add parameter to addmultisigaddress / createmultisig to sort public keys by afk11 · Pull Request #8751 · bitcoin/bitcoin · GitHub
4042018-11-21T19:07:02 <luke-jr> looks like it needs someone to rebase it
4052018-11-21T19:07:18 <luke-jr> actually, I probably already did
4062018-11-21T19:08:02 <luke-jr> dgpv: here, you can submit this if you want: https://github.com/luke-jr/bitcoin/pull/new/sort-multisigs-0.17
4072018-11-21T19:08:19 <luke-jr> although I don't know if it needs *more* rebasing..
4082018-11-21T19:08:39 <luke-jr> probably
4092018-11-21T19:12:38 *** fabianfabian has joined #bitcoin-core-dev
4102018-11-21T19:16:09 <dgpv> luke-jr: that PR is about adding a single multisig address, and that can be sorted on client, so I don't think it would be useful
4112018-11-21T19:16:30 <dgpv> luke-jr: sorting is useful if you are creating many addresses from xpubs
4122018-11-21T19:18:26 <dgpv> luke-jr: ah, sorry, i'm mistaken
4132018-11-21T19:18:55 <sipa> dgpv: well is all of this useful at all before we even support importing descriptors?
4142018-11-21T19:19:13 <sipa> right now, for multisig, the only thing we can do is import individual things
4152018-11-21T19:19:34 <luke-jr> dgpv: what you're talking about is just a repeated form of that
4162018-11-21T19:21:12 <dgpv> actually, I'm not mistaken - createmultisig takes only pubkeys, not xpubs
4172018-11-21T19:24:18 <dgpv> sipa: I see. so maybe sometime in the future, if core supports importing xpubs to create a sequence of multisig addresses from it
4182018-11-21T19:24:31 <dgpv> sipa: then sortetmulti may become relevant
4192018-11-21T19:24:51 <dgpv> sipa: until then, no need.
4202018-11-21T19:30:02 *** tryphe_ has joined #bitcoin-core-dev
4212018-11-21T19:32:43 *** tryphe has quit IRC
4222018-11-21T19:38:06 *** AaronvanW has joined #bitcoin-core-dev
4232018-11-21T19:41:58 *** queip has quit IRC
4242018-11-21T19:43:25 *** AaronvanW has quit IRC
4252018-11-21T19:44:47 *** dgpv has quit IRC
4262018-11-21T19:49:06 *** dviola has quit IRC
4272018-11-21T19:51:40 *** queip has joined #bitcoin-core-dev
4282018-11-21T19:59:03 *** dgpv has joined #bitcoin-core-dev
4292018-11-21T20:20:14 *** jarthur has quit IRC
4302018-11-21T20:36:40 *** afk11 has joined #bitcoin-core-dev
4312018-11-21T20:37:17 *** spinza has quit IRC
4322018-11-21T20:42:01 *** queip has quit IRC
4332018-11-21T20:46:25 *** spinza has joined #bitcoin-core-dev
4342018-11-21T20:49:42 *** queip has joined #bitcoin-core-dev
4352018-11-21T20:52:34 *** Zenton has joined #bitcoin-core-dev
4362018-11-21T21:20:11 *** Zenton has quit IRC
4372018-11-21T21:24:02 *** Zenton has joined #bitcoin-core-dev
4382018-11-21T21:34:01 *** rh0nj has quit IRC
4392018-11-21T21:35:08 *** rh0nj has joined #bitcoin-core-dev
4402018-11-21T21:36:32 *** dviola has joined #bitcoin-core-dev
4412018-11-21T21:39:53 *** AaronvanW has joined #bitcoin-core-dev
4422018-11-21T21:41:57 *** queip has quit IRC
4432018-11-21T21:43:45 *** dviola has quit IRC
4442018-11-21T21:44:03 *** AaronvanW has quit IRC
4452018-11-21T21:44:35 *** diego2 has joined #bitcoin-core-dev
4462018-11-21T21:45:06 *** diego2 has quit IRC
4472018-11-21T21:53:05 *** jarthur has joined #bitcoin-core-dev
4482018-11-21T21:55:26 *** queip has joined #bitcoin-core-dev
4492018-11-21T22:08:40 *** jarthur has quit IRC
4502018-11-21T22:09:13 *** jarthur has joined #bitcoin-core-dev
4512018-11-21T22:14:04 *** AaronvanW has joined #bitcoin-core-dev
4522018-11-21T22:19:13 *** dqx_ has joined #bitcoin-core-dev
4532018-11-21T22:23:58 *** justanotheruser has joined #bitcoin-core-dev
4542018-11-21T22:31:25 *** spinza has quit IRC
4552018-11-21T22:32:01 *** jarthur has quit IRC
4562018-11-21T22:32:37 *** jarthur has joined #bitcoin-core-dev
4572018-11-21T22:36:24 *** afk11 has quit IRC
4582018-11-21T22:41:06 *** rex4539 has quit IRC
4592018-11-21T22:42:04 *** queip has quit IRC
4602018-11-21T22:44:54 *** spinza has joined #bitcoin-core-dev
4612018-11-21T22:51:30 *** Victorsueca has quit IRC
4622018-11-21T22:52:44 *** Victorsueca has joined #bitcoin-core-dev
4632018-11-21T22:52:58 *** queip has joined #bitcoin-core-dev
4642018-11-21T23:01:43 *** Chris_Stewart_5 has quit IRC
4652018-11-21T23:04:15 *** kexkey has quit IRC
4662018-11-21T23:04:50 *** kexkey has joined #bitcoin-core-dev
4672018-11-21T23:07:43 *** Guyver2 has quit IRC
4682018-11-21T23:09:36 *** kexkey has quit IRC
4692018-11-21T23:10:10 *** Victorsueca has quit IRC
4702018-11-21T23:11:18 *** Victorsueca has joined #bitcoin-core-dev
4712018-11-21T23:16:46 *** jarthur has quit IRC
4722018-11-21T23:17:51 *** dqx_ has quit IRC
4732018-11-21T23:24:04 *** justanotheruser has quit IRC
4742018-11-21T23:42:03 *** queip has quit IRC
4752018-11-21T23:44:49 *** fabianfabian has quit IRC
4762018-11-21T23:45:59 *** jarthur has joined #bitcoin-core-dev
4772018-11-21T23:47:38 *** queip has joined #bitcoin-core-dev
4782018-11-21T23:50:18 *** jarthur has quit IRC
4792018-11-21T23:56:18 *** bitcoin-git has joined #bitcoin-core-dev
4802018-11-21T23:56:18 <bitcoin-git> [bitcoin] jnewbery opened pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
4812018-11-21T23:56:18 *** bitcoin-git has left #bitcoin-core-dev