12018-11-22T00:03:18  *** jarthur has joined #bitcoin-core-dev
  22018-11-22T00:04:07  *** jarthur has quit IRC
  32018-11-22T00:13:41  *** ctrlbreak has joined #bitcoin-core-dev
  42018-11-22T00:22:33  *** gmaxwell has joined #bitcoin-core-dev
  52018-11-22T00:23:16  <gmaxwell> Stackexchange deleted the question, but this person: https://github.com/rollmeister/bitcoin-armv8/blob/master/src/crypto/sha256.cpp  showed up asking some questions about optimizing sha256d64 for arm, he says the code he has there speeds up his sync 2x.
  62018-11-22T00:23:49  <gmaxwell> "I have made progress and while the current implementation is 20% slower than it could be it is still five times faster than before and think I will settle for that. Details are in my bitcoin-armv8 repo. It is reindexing my copy of the bitcoin blockchain at over double the pace."
  72018-11-22T00:23:57  <gmaxwell> so we might want to steal that code. :P
  82018-11-22T00:25:33  <luke-jr> theft is bad
  92018-11-22T00:25:48  <gmaxwell> obviously I mean friendly stealing.
 102018-11-22T00:25:50  <luke-jr> :P
 112018-11-22T00:26:07  <gmaxwell> (I mean considering he's just transliterating our existing optimization to arm, I doubt he'd mind. :P )
 122018-11-22T00:26:29  <luke-jr> eh? if we already have it, what is there to copy?
 132018-11-22T00:26:41  <sipa> gmaxwell: i assume it's this person: https://github.com/bitcoin/bitcoin/issues/13401#issuecomment-439891165
 142018-11-22T00:26:54  <sipa> luke-jr: we don't have optimized code for ARM
 152018-11-22T00:26:56  <gmaxwell> luke-jr: we have it for x86.
 162018-11-22T00:27:01  <luke-jr> ah
 172018-11-22T00:27:11  <gmaxwell> he's converting the x86 optimized functions to the arm analogs.
 182018-11-22T00:27:44  <gmaxwell> sounds like he could use a bit of help in part of it too.
 192018-11-22T00:27:53  <gmaxwell> (and also help with the build system parts)
 202018-11-22T00:27:59  <zib> 2.5 weeks to sync on the RPi instead of 5 :D
 212018-11-22T00:28:25  <gmaxwell> zib: hey, that would be a pretty big improvement. :P
 222018-11-22T00:30:20  <zib> Agreed. A bit more polished turd :D But I assume it's for all block validation not just reindexing?
 232018-11-22T00:30:52  <gmaxwell> zib: yes, these speedups are for all block validation, reindexing is just a nice benchmark.
 242018-11-22T00:31:15  <zib> Got it. Then it's pretty nice.
 252018-11-22T00:31:38  <gmaxwell> For compact block relay the speedup should be pretty close to the function speedup in most cases, since its bottlenecked on hashing. (e.g. 5x)
 262018-11-22T00:32:21  <zib> I need to figure out why the RPi can't handle encrypted swap (regardless of how heavy the encryption is)
 272018-11-22T00:32:50  <zib> Want to have the swap encrypted on the full node + ln but it dies as soon as it start swapping.
 282018-11-22T00:33:21  <zib> And you really need a swap on those little things :P
 292018-11-22T00:34:05  <gmaxwell> zib: stick a fan on it.
 302018-11-22T00:35:19  <gmaxwell> back in the day, some people would talk about 'windows quality hardware' -- basically windows crashed so much that you could release a pretty faulty system and people wouldn't notice since even if it crashed a couple times a week that was still 10x fewer than windows itself and not noticible...
 312018-11-22T00:36:32  <gmaxwell> it seems the arm board vendors saw that and said "hold my beer".  mobile devices end up heavily throttled due to being battery powered... I've never owned one that wouldn't crash or corrupt data under real load.
 322018-11-22T00:37:04  <gmaxwell> (Novena comes closest to okay, but even that, if I put the libsecp256k1 tests on it in a loop, it eventually shuts off with a thermal overload, unless I add a fan)
 332018-11-22T00:37:43  <zib> Didn't check if it's crashing from overheating but I guess it's possible.
 342018-11-22T00:38:00  <zib> Better just run it inside the fridge.
 352018-11-22T00:38:15  <phantomcircuit> zib, ensure you're power supply isn't browning out
 362018-11-22T00:39:03  <zib> phantomcircuit: I thought that at first but tried 2 different official adapters
 372018-11-22T00:39:10  <phantomcircuit> zib, ok but like monitor the 5v rail and see what happens at full load
 382018-11-22T00:39:26  <zib> But like there's no problem if its a normal swap. I doubt the encryption brings it over the edge power wise.
 392018-11-22T00:39:30  <phantomcircuit> also if you're swapping to an encrypted sdcard you're going to be sad
 402018-11-22T00:39:34  <sipa> zib: raspberry pi in a fridge == device that consumes as much as a desktop PC with a few % of the computation power :p
 412018-11-22T00:39:44  *** kexkey has joined #bitcoin-core-dev
 422018-11-22T00:40:00  <zib> sipa: :D not a dedicated fridge
 432018-11-22T00:40:08  <phantomcircuit> zib, doesn't matter a refrigerator is super inefficient
 442018-11-22T00:40:17  <phantomcircuit> they're relying on the insulation
 452018-11-22T00:40:26  <zib> I was just joking man :D
 462018-11-22T00:40:37  <gmaxwell> hard to tell, poe's law for small computers.
 472018-11-22T00:40:47  <zib> I like these tiny devices. Esp the RPi Zero. Got one for monitoring the wind+rain, one to turn off my sprinkler if there's been rain. One to open/close the front gate.
 482018-11-22T00:41:29  <zib> And resin coated one to put on a bouey in the ocean. USB-connector rusted but the board was fine :D
 492018-11-22T00:41:55  <zib> *buoy
 502018-11-22T00:41:58  *** queip has quit IRC
 512018-11-22T00:54:09  *** queip has joined #bitcoin-core-dev
 522018-11-22T01:06:29  *** kexkey has quit IRC
 532018-11-22T01:06:56  *** agnjunio has quit IRC
 542018-11-22T01:17:33  *** nullptr| has quit IRC
 552018-11-22T01:19:09  *** tryphe_ is now known as tryphe
 562018-11-22T01:36:01  *** rh0nj has quit IRC
 572018-11-22T01:37:07  *** rh0nj has joined #bitcoin-core-dev
 582018-11-22T01:39:51  *** betapop has joined #bitcoin-core-dev
 592018-11-22T01:40:45  *** betapop_ has joined #bitcoin-core-dev
 602018-11-22T01:41:58  *** queip has quit IRC
 612018-11-22T01:44:05  *** betapop has quit IRC
 622018-11-22T01:45:54  *** nullptr| has joined #bitcoin-core-dev
 632018-11-22T01:47:29  *** betapop_ has quit IRC
 642018-11-22T01:48:15  *** queip has joined #bitcoin-core-dev
 652018-11-22T02:21:28  *** bitcoin-git has joined #bitcoin-core-dev
 662018-11-22T02:21:28  <bitcoin-git> [bitcoin] sipa opened pull request #14780: PSBT backports to 0.17 (0.17...201811_psbt_backports_0.17) https://github.com/bitcoin/bitcoin/pull/14780
 672018-11-22T02:21:28  *** bitcoin-git has left #bitcoin-core-dev
 682018-11-22T02:30:21  *** justanotheruser has joined #bitcoin-core-dev
 692018-11-22T02:36:04  *** betapop has joined #bitcoin-core-dev
 702018-11-22T02:42:03  *** queip has quit IRC
 712018-11-22T02:50:53  *** queip has joined #bitcoin-core-dev
 722018-11-22T03:09:19  *** CodeBlue1776 has quit IRC
 732018-11-22T03:09:32  *** CodeBlue1776 has joined #bitcoin-core-dev
 742018-11-22T03:10:52  *** _cryptosignal_me has joined #bitcoin-core-dev
 752018-11-22T03:15:32  *** meshcollider_ has quit IRC
 762018-11-22T03:27:47  *** jhfrontz has quit IRC
 772018-11-22T03:31:52  *** anxing has joined #bitcoin-core-dev
 782018-11-22T03:32:17  <anxing> get info
 792018-11-22T03:32:25  *** anxing has quit IRC
 802018-11-22T03:33:06  * luke-jr stabs buggy linters
 812018-11-22T03:39:01  *** AaronvanW has quit IRC
 822018-11-22T03:42:01  *** queip has quit IRC
 832018-11-22T03:42:06  *** contrapumpkin has quit IRC
 842018-11-22T03:44:35  *** _cryptosignal_me has quit IRC
 852018-11-22T03:48:58  *** queip has joined #bitcoin-core-dev
 862018-11-22T04:00:42  *** achow101 has quit IRC
 872018-11-22T04:07:23  *** achow101 has joined #bitcoin-core-dev
 882018-11-22T04:09:42  *** schnerch_ has joined #bitcoin-core-dev
 892018-11-22T04:12:48  *** schnerchi has quit IRC
 902018-11-22T04:30:50  *** rhavar has joined #bitcoin-core-dev
 912018-11-22T04:33:59  *** e4xit has quit IRC
 922018-11-22T04:35:28  *** justanotheruser has quit IRC
 932018-11-22T04:38:41  *** justanotheruser has joined #bitcoin-core-dev
 942018-11-22T04:41:56  *** queip has quit IRC
 952018-11-22T04:44:21  *** promag_ has joined #bitcoin-core-dev
 962018-11-22T04:46:37  *** betapop has quit IRC
 972018-11-22T04:47:00  *** promag has quit IRC
 982018-11-22T04:49:38  *** queip has joined #bitcoin-core-dev
 992018-11-22T04:51:09  *** promag_ has quit IRC
1002018-11-22T04:51:54  *** promag has joined #bitcoin-core-dev
1012018-11-22T04:57:12  *** justanotheruser has quit IRC
1022018-11-22T05:04:38  <meshcollider> luke-jr: its not the linter...
1032018-11-22T05:04:48  <meshcollider> i think you can make it happy just by changing the code
1042018-11-22T05:05:01  <luke-jr> meshcollider: ?
1052018-11-22T05:05:11  <meshcollider> remove the account alias
1062018-11-22T05:05:18  <luke-jr> that'd reintroduce a bug
1072018-11-22T05:05:30  <meshcollider> the account alias was removed for a reason
1082018-11-22T05:05:53  <meshcollider> it should accept "*" but it should not accept account="*"
1092018-11-22T05:06:15  <luke-jr> why not? that's exactly how you'd specify it..
1102018-11-22T05:07:29  <meshcollider> as of 0.18 it would be specified with the dummy name or not at all
1112018-11-22T05:08:58  <luke-jr> as of 0.18, it will hopefully be trusted_only
1122018-11-22T05:09:12  <meshcollider> yes so just use trusted_only and not account
1132018-11-22T05:09:45  <meshcollider> account -> dummy was already a breaking change so dummy -> trusted_only is fine
1142018-11-22T05:10:00  <luke-jr> meshcollider: it's not supposed to be breaking existing code
1152018-11-22T05:10:49  <sipa> accounts are gone, that already is a breaking change
1162018-11-22T05:10:57  <sipa> one that was properly deprecated first
1172018-11-22T05:11:14  <luke-jr> sipa: despite the name, it's not used for an account in this case
1182018-11-22T05:12:00  <sipa> then there is no reason to use that name, right
1192018-11-22T05:12:07  <luke-jr> sipa: the parameter was either null or "*" for "total wallet balance" calculated differently, or an account name
1202018-11-22T05:12:14  <luke-jr> sipa: the reason to use the name is that existing callers use it
1212018-11-22T05:12:58  <sipa> luke-jr: all callers that were using the account features had to change their code already
1222018-11-22T05:13:03  <meshcollider> ^
1232018-11-22T05:13:09  <sipa> presumably that includes even this argument
1242018-11-22T05:13:11  <luke-jr> but this doesn't use the account features, only the "account" parameter name
1252018-11-22T05:13:24  <luke-jr> to indicate something that is not account-related
1262018-11-22T05:13:27  <meshcollider> all uses of "account" parameter name have already been broken
1272018-11-22T05:13:32  <sipa> because before we discovered it actually had an impact on confirmations, it was an account related thing
1282018-11-22T05:13:34  <meshcollider> so dont add it back
1292018-11-22T05:13:39  <luke-jr> sipa: it wasn't in this use case
1302018-11-22T05:13:40  <sipa> this is purely incidental
1312018-11-22T05:14:14  <luke-jr> hardly "discovered" when it was known/documented behaviour that people rely on
1322018-11-22T05:14:33  <luke-jr> eg, I use it for my tax calculations
1332018-11-22T05:15:20  <meshcollider> do you use account="*" ?
1342018-11-22T05:15:23  <luke-jr> yes
1352018-11-22T05:15:36  <luke-jr> oh, as opposed to positional parameters? not sure
1362018-11-22T05:15:57  <luke-jr> looks like I am using positional, but that's not really the point
1372018-11-22T05:16:02  <meshcollider> im not suggesting we break positional parameters
1382018-11-22T05:16:10  <meshcollider> noone should be using any account named parameter now
1392018-11-22T05:16:10  <luke-jr> if you were using named params, you HAD to use the name "account" for this
1402018-11-22T05:16:21  <meshcollider> HAD to but not now
1412018-11-22T05:16:36  <meshcollider> because accounts have been deprecated and removed the proper way, so people should migrate to the new name
1422018-11-22T05:17:01  <luke-jr> there was no new name yet
1432018-11-22T05:17:07  <meshcollider> it was called dummy
1442018-11-22T05:17:21  <meshcollider> and you are changing to trusted_only
1452018-11-22T05:17:25  <luke-jr> dummy never worked
1462018-11-22T05:17:27  <meshcollider> either way, its not called accounts
1472018-11-22T05:18:01  <meshcollider> yes so fix the behaviour of dummy, dont revert back to deprecated accounts :(
1482018-11-22T05:18:20  <meshcollider> the name change dummy -> trusted_only is good though
1492018-11-22T05:19:10  <luke-jr> so that there's literally no way for someone to write code that works with 0.16 and 0.17.1?
1502018-11-22T05:19:16  <luke-jr> (using named args)
1512018-11-22T05:19:32  <meshcollider> thats generally how breaking changes work, yes
1522018-11-22T05:19:42  <luke-jr> there's a deprecation step to avoid that
1532018-11-22T05:19:55  <luke-jr> and there's no reason to break in this case
1542018-11-22T05:21:28  <meshcollider> keep the "dummy" alias as well as "trusted_only" then
1552018-11-22T05:22:34  <luke-jr> why? "dummy" was never used for this
1562018-11-22T05:23:53  <meshcollider> Oh I think I see what you mean. The account alias can be kept in the backport to 0.17.1 but not in master
1572018-11-22T05:24:05  <meshcollider> dont add it to master
1582018-11-22T05:26:18  *** luke-jr has quit IRC
1592018-11-22T05:26:34  *** luke-jr has joined #bitcoin-core-dev
1602018-11-22T05:31:47  <luke-jr> not sure if my ok got through before freenode d/c me, but no compat in master, just in 0.17 sounds reasonable
1612018-11-22T05:34:09  <meshcollider> thanks :)
1622018-11-22T05:36:14  *** bitcoin-git has joined #bitcoin-core-dev
1632018-11-22T05:36:14  <bitcoin-git> [bitcoin] luke-jr opened pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
1642018-11-22T05:36:14  *** bitcoin-git has left #bitcoin-core-dev
1652018-11-22T05:36:32  *** bitcoin-git has joined #bitcoin-core-dev
1662018-11-22T05:36:33  <bitcoin-git> [bitcoin] luke-jr closed pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
1672018-11-22T05:36:33  *** bitcoin-git has left #bitcoin-core-dev
1682018-11-22T05:36:58  *** bitcoin-git has joined #bitcoin-core-dev
1692018-11-22T05:36:58  <bitcoin-git> [bitcoin] luke-jr opened pull request #14782: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (0.17...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14782
1702018-11-22T05:36:58  *** bitcoin-git has left #bitcoin-core-dev
1712018-11-22T05:47:44  *** intcat has quit IRC
1722018-11-22T05:47:44  *** ghost43 has quit IRC
1732018-11-22T05:48:02  *** ghost43 has joined #bitcoin-core-dev
1742018-11-22T05:49:41  *** intcat has joined #bitcoin-core-dev
1752018-11-22T06:20:29  *** justanotheruser has joined #bitcoin-core-dev
1762018-11-22T06:40:11  *** justanotheruser has quit IRC
1772018-11-22T06:42:02  *** queip has quit IRC
1782018-11-22T06:50:17  *** queip has joined #bitcoin-core-dev
1792018-11-22T06:51:11  *** esotericnonsense has quit IRC
1802018-11-22T06:52:43  *** esotericnonsense has joined #bitcoin-core-dev
1812018-11-22T07:20:25  *** justanotheruser has joined #bitcoin-core-dev
1822018-11-22T07:40:20  *** tryphe_ has joined #bitcoin-core-dev
1832018-11-22T07:43:48  *** tryphe has quit IRC
1842018-11-22T08:13:08  *** rex4539 has joined #bitcoin-core-dev
1852018-11-22T08:42:08  *** queip has quit IRC
1862018-11-22T08:52:25  *** tryphe_ is now known as tryphe
1872018-11-22T08:52:30  *** queip has joined #bitcoin-core-dev
1882018-11-22T08:53:42  *** justanotheruser has quit IRC
1892018-11-22T08:54:20  *** schnerch_ has quit IRC
1902018-11-22T08:55:34  *** luke-jr has quit IRC
1912018-11-22T08:55:43  *** luke-jr has joined #bitcoin-core-dev
1922018-11-22T09:05:28  *** setpill has joined #bitcoin-core-dev
1932018-11-22T09:16:09  *** phwalkr has joined #bitcoin-core-dev
1942018-11-22T09:17:37  *** timothy has joined #bitcoin-core-dev
1952018-11-22T09:30:01  *** intcat has quit IRC
1962018-11-22T09:37:37  *** intcat has joined #bitcoin-core-dev
1972018-11-22T09:42:29  *** phwalkr has quit IRC
1982018-11-22T09:46:10  *** phwalkr has joined #bitcoin-core-dev
1992018-11-22T09:47:41  *** oneark has joined #bitcoin-core-dev
2002018-11-22T09:50:40  *** phwalkr_ has joined #bitcoin-core-dev
2012018-11-22T09:51:34  *** bitcoin-git has joined #bitcoin-core-dev
2022018-11-22T09:51:34  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d7b0258ff037...e736b67467ef
2032018-11-22T09:51:35  <bitcoin-git> bitcoin/master 7bad78c Ben Woosley: Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h...
2042018-11-22T09:51:35  <bitcoin-git> bitcoin/master 69ca487 Ben Woosley: Implement prevector::fill once...
2052018-11-22T09:51:36  <bitcoin-git> bitcoin/master e736b67 Wladimir J. van der Laan: Merge #14715: Drop defunct prevector compat handling...
2062018-11-22T09:51:36  *** bitcoin-git has left #bitcoin-core-dev
2072018-11-22T09:52:37  *** bitcoin-git has joined #bitcoin-core-dev
2082018-11-22T09:52:38  <bitcoin-git> [bitcoin] laanwj closed pull request #14715: Drop defunct prevector compat handling (master...trivial-prevector) https://github.com/bitcoin/bitcoin/pull/14715
2092018-11-22T09:52:38  *** bitcoin-git has left #bitcoin-core-dev
2102018-11-22T09:53:47  *** bitcoin-git has joined #bitcoin-core-dev
2112018-11-22T09:53:48  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/e736b67467ef...e77a2258e4da
2122018-11-22T09:53:48  <bitcoin-git> bitcoin/master 3615003 Luke Dashjr: net: Always default rpcbind to localhost, never "all interfaces"...
2132018-11-22T09:53:49  <bitcoin-git> bitcoin/master d6a1287 Luke Dashjr: CNetAddr: Add IsBindAny method to check for INADDR_ANY
2142018-11-22T09:53:49  <bitcoin-git> bitcoin/master 27c44ef Luke Dashjr: rpcbind: Warn about exposing RPC to untrusted networks
2152018-11-22T09:53:50  *** bitcoin-git has left #bitcoin-core-dev
2162018-11-22T09:54:43  *** bitcoin-git has joined #bitcoin-core-dev
2172018-11-22T09:54:43  <bitcoin-git> [bitcoin] laanwj closed pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
2182018-11-22T09:54:43  *** bitcoin-git has left #bitcoin-core-dev
2192018-11-22T09:55:13  *** shesek has joined #bitcoin-core-dev
2202018-11-22T09:59:12  <promag> wumpus: #14756 is ready to merge, after jnewbery review the script interface remains the same
2212018-11-22T09:59:14  <gribble> https://github.com/bitcoin/bitcoin/issues/14756 | Improve rpcauth.py by using argparse and getpass modules by promag · Pull Request #14756 · bitcoin/bitcoin · GitHub
2222018-11-22T09:59:45  *** phwalkr has joined #bitcoin-core-dev
2232018-11-22T10:00:30  *** rhavar has quit IRC
2242018-11-22T10:10:13  *** Victorsueca has quit IRC
2252018-11-22T10:11:41  *** Victorsueca has joined #bitcoin-core-dev
2262018-11-22T10:15:42  *** spinza has quit IRC
2272018-11-22T10:21:49  *** phwalkr has quit IRC
2282018-11-22T10:27:35  *** murrayn has quit IRC
2292018-11-22T10:29:10  *** murrayn has joined #bitcoin-core-dev
2302018-11-22T10:29:21  *** spinza has joined #bitcoin-core-dev
2312018-11-22T10:42:01  *** queip has quit IRC
2322018-11-22T10:45:38  *** phwalkr has joined #bitcoin-core-dev
2332018-11-22T10:49:55  *** phwalkr has quit IRC
2342018-11-22T10:52:13  *** queip has joined #bitcoin-core-dev
2352018-11-22T11:03:27  *** IGHOR has quit IRC
2362018-11-22T11:12:33  *** luke-jr has quit IRC
2372018-11-22T11:12:42  *** luke-jr has joined #bitcoin-core-dev
2382018-11-22T11:17:15  *** phwalkr has joined #bitcoin-core-dev
2392018-11-22T11:21:43  *** phwalkr has quit IRC
2402018-11-22T11:31:35  *** JackH has joined #bitcoin-core-dev
2412018-11-22T11:36:38  *** shesek has quit IRC
2422018-11-22T11:36:39  <wumpus> promag: ok!
2432018-11-22T11:38:32  *** bitcoin-git has joined #bitcoin-core-dev
2442018-11-22T11:38:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e77a2258e4da...708cbb172dbf
2452018-11-22T11:38:33  <bitcoin-git> bitcoin/master d6cde00 João Barbosa: rpcauth: Improve by using argparse and getpass modules
2462018-11-22T11:38:34  <bitcoin-git> bitcoin/master 708cbb1 Wladimir J. van der Laan: Merge #14756: Improve rpcauth.py by using argparse and getpass modules...
2472018-11-22T11:38:34  *** bitcoin-git has left #bitcoin-core-dev
2482018-11-22T11:39:31  *** bitcoin-git has joined #bitcoin-core-dev
2492018-11-22T11:39:32  <bitcoin-git> [bitcoin] laanwj closed pull request #14756: Improve rpcauth.py by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
2502018-11-22T11:39:32  *** bitcoin-git has left #bitcoin-core-dev
2512018-11-22T11:40:41  <promag> ops, bug in master
2522018-11-22T11:40:42  *** shesek has joined #bitcoin-core-dev
2532018-11-22T11:40:42  *** shesek has joined #bitcoin-core-dev
2542018-11-22T11:42:05  *** queip has quit IRC
2552018-11-22T11:49:21  *** shesek has quit IRC
2562018-11-22T11:52:43  *** IGHOR has joined #bitcoin-core-dev
2572018-11-22T11:53:50  *** queip has joined #bitcoin-core-dev
2582018-11-22T11:57:06  *** AaronvanW has joined #bitcoin-core-dev
2592018-11-22T12:00:50  *** michaelfolkson has joined #bitcoin-core-dev
2602018-11-22T12:03:26  *** michaelfolkson has quit IRC
2612018-11-22T12:05:18  *** michaelfolkson has joined #bitcoin-core-dev
2622018-11-22T12:24:25  <wumpus> promag: ?
2632018-11-22T12:24:25  *** bitcoin-git has joined #bitcoin-core-dev
2642018-11-22T12:24:25  <bitcoin-git> [bitcoin] promag opened pull request #14783: qt: Fix boost::signals2::no_slots_error in early calls to InitWarning (master...2018-11-fix-noslotserror) https://github.com/bitcoin/bitcoin/pull/14783
2652018-11-22T12:24:25  *** bitcoin-git has left #bitcoin-core-dev
2662018-11-22T12:24:32  <promag> wumpus: ^
2672018-11-22T12:25:00  <promag> nothing serious
2682018-11-22T12:26:50  <promag> maybe we should just call `noui_connect()` in bitcoin-qt?
2692018-11-22T12:26:52  *** michaelfolkson has quit IRC
2702018-11-22T12:27:13  <wumpus> maybe? does it register any other things that might interfere
2712018-11-22T12:27:24  <wumpus> I'm sure there was a reason, at some point, not to do that
2722018-11-22T12:28:14  *** michaelfolkson has joined #bitcoin-core-dev
2732018-11-22T12:30:47  <promag> I'll leave as it is (as a minimal fix) but also leave that suggestion
2742018-11-22T12:32:36  <promag> wumpus: I don't understand your last question
2752018-11-22T12:32:44  <promag> what return value?
2762018-11-22T12:32:45  <wumpus> so to be clear: the actual problem here is that the MessageBox slot gets called before the UI is set up far enough that any handlers are added?
2772018-11-22T12:32:55  <promag> yes
2782018-11-22T12:32:55  <wumpus> ThreadSafeMessageBox's return value
2792018-11-22T12:33:05  <wumpus> it returns a bool
2802018-11-22T12:34:17  <wumpus> depending on what the user chooses
2812018-11-22T12:38:07  <jonasschnelli> I will miss the meeting again today (and probably next week).
2822018-11-22T12:38:48  <wumpus> jonasschnelli: thanks for letting us know
2832018-11-22T12:39:18  <jonasschnelli> getting up 3am is not very comfortable (currently in GMT+7)
2842018-11-22T12:39:27  *** agnjunio has joined #bitcoin-core-dev
2852018-11-22T12:39:30  <wumpus> true!
2862018-11-22T12:40:15  <promag> there are a 6 calls to InitWarning in init.cpp
2872018-11-22T12:40:33  <wumpus> but non in that early stage
2882018-11-22T12:40:41  <promag> at least 2
2892018-11-22T12:40:51  <promag> in InitParameterInteraction()
2902018-11-22T12:41:03  <promag> InitWarning(strprintf(_("Config setting for %s only applied on %s network when in [%s] section."), arg, network, network));
2912018-11-22T12:41:08  <promag> InitWarning(strprintf(_("Section [%s] is not recognized."), section));
2922018-11-22T12:41:15  <promag> these were added recently right?
2932018-11-22T12:41:16  <wumpus> so, then, this was not a regression in #14708?
2942018-11-22T12:41:22  <gribble> https://github.com/bitcoin/bitcoin/issues/14708 | Warn unrecognised sections in the config file by AkioNak · Pull Request #14708 · bitcoin/bitcoin · GitHub
2952018-11-22T12:41:40  <wumpus> probably... and never tested with the ui
2962018-11-22T12:41:57  *** queip has quit IRC
2972018-11-22T12:42:08  <promag> also guilty :(
2982018-11-22T12:43:09  <wumpus> in any case, it's probably safest to convert those to LogPrintf and dn't mess with the slot handlers
2992018-11-22T12:44:01  <wumpus> we're simply not able to show a message box or do anything else UI-wise at that point in the initialization process
3002018-11-22T12:44:10  <promag> wumpus: yap
3012018-11-22T12:44:23  <promag> wumpus: I'm checking older commits of that PR
3022018-11-22T12:44:24  <kallewoof> jonasschnelli: welcome to my world lol
3032018-11-22T12:44:38  <wumpus> maybe later on the UI code can be refactored so that that *is* possible, but that's a too large and risky change now
3042018-11-22T12:44:39  <promag> looks like InitWarning was added in the end
3052018-11-22T12:45:49  <wumpus> (e.g. there are some things concerning locale and language setup that only can run *after* configuration parsing, and I think using Qt things before that will currently cause bad things to happen)
3062018-11-22T12:46:50  <promag> problem introduced here https://github.com/bitcoin/bitcoin/pull/14708#event-1970984970
3072018-11-22T12:47:11  <wumpus> yes, so it is introduced in 14708
3082018-11-22T12:47:16  <wumpus> good to know
3092018-11-22T12:47:28  <promag> I'll revert those 2 to LogPrintf
3102018-11-22T12:47:33  <wumpus> at least it hasn't existed for ages without anyone noticing :)
3112018-11-22T12:47:42  <wumpus> thanks!
3122018-11-22T12:48:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3132018-11-22T12:51:13  <promag> no
3142018-11-22T12:51:16  <promag> np
3152018-11-22T12:52:28  *** queip has joined #bitcoin-core-dev
3162018-11-22T12:53:00  *** michaelfolkson has quit IRC
3172018-11-22T12:53:31  *** AaronvanW has quit IRC
3182018-11-22T12:54:02  *** wxss_ has joined #bitcoin-core-dev
3192018-11-22T12:54:50  *** wxss has quit IRC
3202018-11-22T12:57:18  *** michaelfolkson has joined #bitcoin-core-dev
3212018-11-22T13:00:10  <wumpus> "all checks have failed" uhh
3222018-11-22T13:00:37  <wumpus> promag: it's not compiling
3232018-11-22T13:00:49  <promag> fixing it... :/
3242018-11-22T13:01:26  <wumpus> whoops, should have checked that too, changing my utACK to a concept ACK for now
3252018-11-22T13:03:48  *** AaronvanW has joined #bitcoin-core-dev
3262018-11-22T13:08:54  *** AaronvanW has quit IRC
3272018-11-22T13:08:56  <promag> wumpus: sorry about that, should be ok now
3282018-11-22T13:09:30  <promag> wumpus: is it today #14670?
3292018-11-22T13:09:33  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
3302018-11-22T13:09:34  <promag> :P
3312018-11-22T13:12:52  <promag> wumpus: feature_config_args.py failed.. will fix later, out for lunch
3322018-11-22T13:13:07  *** phwalkr has joined #bitcoin-core-dev
3332018-11-22T13:13:22  *** michaelfolkson has quit IRC
3342018-11-22T13:17:58  *** Chris_Stewart_5 has quit IRC
3352018-11-22T13:17:59  *** bitcoin-git has joined #bitcoin-core-dev
3362018-11-22T13:17:59  <bitcoin-git> [bitcoin] promag opened pull request #14784: qt: Don't use the wallet name as map key (master...2018-11-qtwalletmodel) https://github.com/bitcoin/bitcoin/pull/14784
3372018-11-22T13:17:59  *** bitcoin-git has left #bitcoin-core-dev
3382018-11-22T13:18:08  *** phwalkr has quit IRC
3392018-11-22T13:21:06  *** michaelfolkson has joined #bitcoin-core-dev
3402018-11-22T13:31:51  *** michaelfolkson has quit IRC
3412018-11-22T13:42:10  *** queip has quit IRC
3422018-11-22T13:44:20  *** phwalkr has joined #bitcoin-core-dev
3432018-11-22T13:48:34  *** phwalkr has quit IRC
3442018-11-22T13:50:03  *** queip has joined #bitcoin-core-dev
3452018-11-22T13:51:37  *** phwalkr has joined #bitcoin-core-dev
3462018-11-22T14:02:11  *** bitcoin-git has joined #bitcoin-core-dev
3472018-11-22T14:02:12  <bitcoin-git> [bitcoin] cornelius opened pull request #14785: Scripts: Fix detection of copyright holders (master...copyright-header) https://github.com/bitcoin/bitcoin/pull/14785
3482018-11-22T14:02:12  *** bitcoin-git has left #bitcoin-core-dev
3492018-11-22T14:04:08  *** _cryptodesktop_i has joined #bitcoin-core-dev
3502018-11-22T14:19:54  <wumpus> should we cancel today's meeting because of US thanksgiving? just realized that's today and I think we did that in some years before
3512018-11-22T14:29:36  <promag> ken2812221_: please see https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20488539
3522018-11-22T14:30:04  <promag> ken2812221_: multiwallet test failed, but passed in travis
3532018-11-22T14:30:38  <promag> ken2812221_: what bothers me is that the changes are unrelated to that test :/
3542018-11-22T14:31:28  *** Guyver2 has joined #bitcoin-core-dev
3552018-11-22T14:31:42  <promag> wumpus: no thanksgiving here.. but I have my daughter violin recital
3562018-11-22T14:38:27  *** _cryptodesktop_i has quit IRC
3572018-11-22T14:40:03  *** promag has quit IRC
3582018-11-22T14:42:57  <wumpus> I guess all the people that aren't going to be at the meeting also aren't going to respond now :)
3592018-11-22T14:44:59  <cjd> Quick, call a vote to change bitcoin over to proof of stake ;)
3602018-11-22T14:50:29  <wumpus> heh
3612018-11-22T15:04:48  *** setpill has quit IRC
3622018-11-22T15:06:24  *** shesek has joined #bitcoin-core-dev
3632018-11-22T15:14:06  *** Bullit has joined #bitcoin-core-dev
3642018-11-22T15:23:48  *** AaronvanW has joined #bitcoin-core-dev
3652018-11-22T15:24:30  *** Zenton has quit IRC
3662018-11-22T15:24:56  *** JimmyB has joined #bitcoin-core-dev
3672018-11-22T15:27:12  *** JimmyB has quit IRC
3682018-11-22T15:38:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3692018-11-22T15:41:57  *** queip has quit IRC
3702018-11-22T15:42:21  *** kexkey has joined #bitcoin-core-dev
3712018-11-22T15:44:49  *** kexkey_ has joined #bitcoin-core-dev
3722018-11-22T15:47:22  *** kexkey has quit IRC
3732018-11-22T15:52:50  *** queip has joined #bitcoin-core-dev
3742018-11-22T15:53:48  *** rhavar has joined #bitcoin-core-dev
3752018-11-22T15:56:52  *** Zenton has joined #bitcoin-core-dev
3762018-11-22T16:03:42  *** stadivm has joined #bitcoin-core-dev
3772018-11-22T16:09:13  *** kexkey_ has quit IRC
3782018-11-22T16:11:23  *** stadivm has quit IRC
3792018-11-22T16:13:48  *** Chris_Stewart_5 has quit IRC
3802018-11-22T16:23:05  <achow101> wumpus: +1
3812018-11-22T16:36:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3822018-11-22T16:38:21  *** bitcoin-git has joined #bitcoin-core-dev
3832018-11-22T16:38:22  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/708cbb172dbf...2a97f192ea92
3842018-11-22T16:38:22  <bitcoin-git> bitcoin/master fa21ca0 MarcoFalke: test: Add BOOST_REQUIRE to getters returning optional
3852018-11-22T16:38:23  <bitcoin-git> bitcoin/master 2a97f19 MarcoFalke: Merge #14771: test: Add BOOST_REQUIRE to getters returning optional...
3862018-11-22T16:38:23  *** bitcoin-git has left #bitcoin-core-dev
3872018-11-22T16:39:26  *** bitcoin-git has joined #bitcoin-core-dev
3882018-11-22T16:39:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
3892018-11-22T16:39:26  *** bitcoin-git has left #bitcoin-core-dev
3902018-11-22T16:41:58  *** queip has quit IRC
3912018-11-22T16:54:57  *** queip has joined #bitcoin-core-dev
3922018-11-22T17:04:04  *** JackH has quit IRC
3932018-11-22T17:15:52  *** bitcoin-git has joined #bitcoin-core-dev
3942018-11-22T17:15:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a97f192ea92...3dda4c5f037b
3952018-11-22T17:15:54  <bitcoin-git> bitcoin/master 3d2c7d6 Daniel Kraft: Add regtest for JSON-RPC batch calls....
3962018-11-22T17:15:54  <bitcoin-git> bitcoin/master 3dda4c5 MarcoFalke: Merge #14777: tests: Add regtest for JSON-RPC batch calls...
3972018-11-22T17:15:54  *** bitcoin-git has left #bitcoin-core-dev
3982018-11-22T17:16:51  *** bitcoin-git has joined #bitcoin-core-dev
3992018-11-22T17:16:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14777: tests: Add regtest for JSON-RPC batch calls (master...batch-rpc) https://github.com/bitcoin/bitcoin/pull/14777
4002018-11-22T17:16:51  *** bitcoin-git has left #bitcoin-core-dev
4012018-11-22T17:21:26  <wumpus> ok, hereby PSA: there will be no meeting today because of thanksgiving in the US
4022018-11-22T17:21:56  <wumpus> the small number of people that responded says enough
4032018-11-22T17:23:45  <gmaxwell> well the non-response is also because you asked at 6am pacific... but yes, good call.
4042018-11-22T17:26:54  <wumpus> yes, good point
4052018-11-22T17:36:54  *** promag has joined #bitcoin-core-dev
4062018-11-22T17:37:33  *** spinza has quit IRC
4072018-11-22T17:41:47  *** JackH has joined #bitcoin-core-dev
4082018-11-22T17:42:02  *** queip has quit IRC
4092018-11-22T17:44:39  *** spinza has joined #bitcoin-core-dev
4102018-11-22T17:47:39  <luke-jr> cjd: developers don't decide consensus rule changes in the first place ;)
4112018-11-22T17:48:12  <cjd> I know, I just couldn't resist making a Federal Reserve Act joke
4122018-11-22T17:49:25  *** gelmutshmidt has joined #bitcoin-core-dev
4132018-11-22T17:49:52  <sipa> cjd: long time no see here, i think we met in 2011 or 2012 at a bitcoin conference
4142018-11-22T17:50:35  <cjd> Yes, it should be 2012, you remember my presentation...  I've been waiting these past 6 years for Lightning Network :)
4152018-11-22T17:50:52  <sipa> london?
4162018-11-22T17:50:55  <cjd> Yes sir
4172018-11-22T17:51:19  <sipa> i remember you gave a talk, i can't remember the contents after 6 years :)
4182018-11-22T17:51:30  *** queip has joined #bitcoin-core-dev
4192018-11-22T17:51:55  <cjd> Well, it doesn't matter too much because the idea has developed quite a bit in the mean time...
4202018-11-22T17:52:06  <cjd> More recent version: https://www.youtube.com/watch?v=3uQRg_giihI
4212018-11-22T17:53:54  *** Chris_Stewart_5 has quit IRC
4222018-11-22T18:06:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4232018-11-22T18:09:15  *** promag has quit IRC
4242018-11-22T18:09:38  *** fabianfabian has joined #bitcoin-core-dev
4252018-11-22T18:14:26  *** phwalkr has quit IRC
4262018-11-22T18:15:00  *** phwalkr has joined #bitcoin-core-dev
4272018-11-22T18:19:01  *** rh0nj has quit IRC
4282018-11-22T18:20:07  *** rh0nj has joined #bitcoin-core-dev
4292018-11-22T18:32:58  *** shesek has quit IRC
4302018-11-22T18:33:48  *** Chris_Stewart_5 has quit IRC
4312018-11-22T18:39:55  *** dviola has joined #bitcoin-core-dev
4322018-11-22T18:40:08  *** dviola has quit IRC
4332018-11-22T18:41:02  *** bitcoin-git has joined #bitcoin-core-dev
4342018-11-22T18:41:03  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14747: build: Drop AC_CHECK_DECLS for unused __builtin_clz (master...builtin-clz) https://github.com/bitcoin/bitcoin/pull/14747
4352018-11-22T18:41:03  *** bitcoin-git has left #bitcoin-core-dev
4362018-11-22T18:42:01  *** queip has quit IRC
4372018-11-22T18:42:09  *** dviola has joined #bitcoin-core-dev
4382018-11-22T18:50:10  *** queip has joined #bitcoin-core-dev
4392018-11-22T19:00:24  <meshcollider> Oh, no meeting, ok
4402018-11-22T19:03:04  *** oneark has quit IRC
4412018-11-22T19:06:57  <sipa> meshcollider: the turkey gods must be satisfied
4422018-11-22T19:09:07  <arubi> what about turpubkeys?
4432018-11-22T19:22:54  *** shesek has joined #bitcoin-core-dev
4442018-11-22T19:22:57  <wumpus> heh
4452018-11-22T19:27:11  *** timothy has quit IRC
4462018-11-22T19:33:13  *** rhavar has quit IRC
4472018-11-22T19:34:25  *** stasbar has joined #bitcoin-core-dev
4482018-11-22T19:40:49  *** bitcoin-git has joined #bitcoin-core-dev
4492018-11-22T19:40:49  <bitcoin-git> [bitcoin] jl2012 opened pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
4502018-11-22T19:40:49  *** bitcoin-git has left #bitcoin-core-dev
4512018-11-22T19:41:59  *** queip has quit IRC
4522018-11-22T19:46:46  *** stasbar has quit IRC
4532018-11-22T19:47:42  *** queip has joined #bitcoin-core-dev
4542018-11-22T20:03:36  *** bitcoin-git has joined #bitcoin-core-dev
4552018-11-22T20:03:36  <bitcoin-git> [bitcoin] merland opened pull request #14787: Replace old instructions with links to official docs (master...issue14639) https://github.com/bitcoin/bitcoin/pull/14787
4562018-11-22T20:03:36  *** bitcoin-git has left #bitcoin-core-dev
4572018-11-22T20:08:54  *** bitcoin-git has joined #bitcoin-core-dev
4582018-11-22T20:08:55  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14788: tests: Possible fix the permission error when the tests open the cookie file (master...fix-win-test-perm-deny) https://github.com/bitcoin/bitcoin/pull/14788
4592018-11-22T20:08:55  *** bitcoin-git has left #bitcoin-core-dev
4602018-11-22T20:14:23  *** Emcy has joined #bitcoin-core-dev
4612018-11-22T20:28:32  *** Emcy has quit IRC
4622018-11-22T20:29:51  *** Emcy has joined #bitcoin-core-dev
4632018-11-22T20:33:09  *** kmels has joined #bitcoin-core-dev
4642018-11-22T20:43:34  *** Emcy_ has joined #bitcoin-core-dev
4652018-11-22T20:45:53  *** fabianfabian has quit IRC
4662018-11-22T20:47:04  *** Emcy has quit IRC
4672018-11-22T20:47:22  *** phwalkr has quit IRC
4682018-11-22T20:48:46  *** Emcy_ has quit IRC
4692018-11-22T21:06:31  *** rhavar has joined #bitcoin-core-dev
4702018-11-22T21:13:48  *** bitcoin-git has joined #bitcoin-core-dev
4712018-11-22T21:13:48  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
4722018-11-22T21:13:48  *** bitcoin-git has left #bitcoin-core-dev
4732018-11-22T21:15:47  *** ken2812221_ has quit IRC
4742018-11-22T21:33:05  *** phwalkr has joined #bitcoin-core-dev
4752018-11-22T21:33:25  *** fabianfabian has joined #bitcoin-core-dev
4762018-11-22T21:46:16  *** fabianfabian has quit IRC
4772018-11-22T21:48:16  *** phwalkr has quit IRC
4782018-11-22T21:59:43  *** bitcoin-git has joined #bitcoin-core-dev
4792018-11-22T21:59:43  <bitcoin-git> [bitcoin] kristapsk opened pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
4802018-11-22T21:59:43  *** bitcoin-git has left #bitcoin-core-dev
4812018-11-22T22:13:30  *** spinza has quit IRC
4822018-11-22T22:15:55  *** owowo has quit IRC
4832018-11-22T22:21:01  *** rh0nj has quit IRC
4842018-11-22T22:21:08  *** owowo has joined #bitcoin-core-dev
4852018-11-22T22:22:07  *** rh0nj has joined #bitcoin-core-dev
4862018-11-22T22:31:35  *** Guyver2 has quit IRC
4872018-11-22T22:34:10  *** spinza has joined #bitcoin-core-dev
4882018-11-22T22:36:02  *** harrymm has quit IRC
4892018-11-22T22:41:59  *** queip has quit IRC
4902018-11-22T22:49:33  *** queip has joined #bitcoin-core-dev
4912018-11-22T22:53:02  *** dviola has quit IRC
4922018-11-22T23:09:47  *** nullptr| has quit IRC
4932018-11-22T23:10:05  *** promag has joined #bitcoin-core-dev
4942018-11-22T23:11:46  *** nullptr| has joined #bitcoin-core-dev
4952018-11-22T23:17:23  *** gelmutshmidt has quit IRC
4962018-11-22T23:20:30  *** CodeBlue1776 has quit IRC
4972018-11-22T23:21:23  *** CodeBlue1776 has joined #bitcoin-core-dev
4982018-11-22T23:31:26  *** promag has quit IRC
4992018-11-22T23:42:02  *** queip has quit IRC
5002018-11-22T23:49:15  *** shesek has quit IRC
5012018-11-22T23:49:42  *** shesek has joined #bitcoin-core-dev
5022018-11-22T23:50:18  *** Emcy has joined #bitcoin-core-dev
5032018-11-22T23:50:59  *** shesek has quit IRC
5042018-11-22T23:51:11  *** queip has joined #bitcoin-core-dev