12018-12-11T00:00:38 *** rafalcpp has quit IRC
22018-12-11T00:01:22 *** rafalcpp has joined #bitcoin-core-dev
32018-12-11T00:22:52 *** dgenr8 has joined #bitcoin-core-dev
42018-12-11T00:24:42 *** miknotauro has joined #bitcoin-core-dev
52018-12-11T00:27:34 *** dgenr8 has quit IRC
62018-12-11T00:30:47 *** dgenr8 has joined #bitcoin-core-dev
72018-12-11T00:38:16 *** hex17or has quit IRC
82018-12-11T00:45:18 *** hex17or has joined #bitcoin-core-dev
92018-12-11T00:56:43 *** shesek has quit IRC
102018-12-11T00:57:39 *** shesek has joined #bitcoin-core-dev
112018-12-11T01:03:35 *** Murch has quit IRC
122018-12-11T01:16:01 *** rh0nj has quit IRC
132018-12-11T01:19:09 *** rh0nj has joined #bitcoin-core-dev
142018-12-11T01:24:25 *** dviola has quit IRC
152018-12-11T01:26:01 *** rh0nj has quit IRC
162018-12-11T01:27:08 *** rh0nj has joined #bitcoin-core-dev
172018-12-11T01:27:22 *** _cryptosignal_me has joined #bitcoin-core-dev
182018-12-11T01:38:51 *** promag has quit IRC
192018-12-11T02:01:07 *** _cryptosignal_me has quit IRC
202018-12-11T02:21:58 *** bsm117532 has quit IRC
212018-12-11T02:36:55 *** bitcoin-git has joined #bitcoin-core-dev
222018-12-11T02:36:56 <bitcoin-git> [bitcoin] AkioNak opened pull request #14919: test: Prevent "Duplicate-wallet filename specified" (master...confirm_unloadwallet_done) https://github.com/bitcoin/bitcoin/pull/14919
232018-12-11T02:36:56 *** bitcoin-git has left #bitcoin-core-dev
242018-12-11T02:57:47 *** keymone has quit IRC
252018-12-11T03:03:26 *** AaronvanW has quit IRC
262018-12-11T03:11:39 *** ghost43 has quit IRC
272018-12-11T03:18:52 *** ghost43 has joined #bitcoin-core-dev
282018-12-11T03:23:17 *** phwalkr has joined #bitcoin-core-dev
292018-12-11T03:35:54 *** keymone has joined #bitcoin-core-dev
302018-12-11T03:56:18 *** keymone has quit IRC
312018-12-11T04:01:22 *** keymone has joined #bitcoin-core-dev
322018-12-11T04:22:27 *** phwalkr has quit IRC
332018-12-11T04:47:53 *** phwalkr has joined #bitcoin-core-dev
342018-12-11T04:50:15 <jimpo> thanks for the reviews, jamesob!
352018-12-11T04:50:49 <jamesob> jimpo: more to come. I want me some block filters!
362018-12-11T04:54:35 *** Krellan has quit IRC
372018-12-11T05:20:28 *** spinza has quit IRC
382018-12-11T05:28:01 *** rh0nj has quit IRC
392018-12-11T05:29:07 *** rh0nj has joined #bitcoin-core-dev
402018-12-11T05:35:24 *** spinza has joined #bitcoin-core-dev
412018-12-11T06:00:15 *** earthling has joined #bitcoin-core-dev
422018-12-11T06:01:11 *** bitcoin-git has joined #bitcoin-core-dev
432018-12-11T06:01:11 <bitcoin-git> [bitcoin] Empact opened pull request #14920: Build: enable -Wdocumentation via isystem (master...isystem) https://github.com/bitcoin/bitcoin/pull/14920
442018-12-11T06:01:11 *** bitcoin-git has left #bitcoin-core-dev
452018-12-11T06:01:16 *** earthling has quit IRC
462018-12-11T06:02:24 *** miknotauro has quit IRC
472018-12-11T06:12:44 *** hebasto has joined #bitcoin-core-dev
482018-12-11T06:33:06 *** miknotauro has joined #bitcoin-core-dev
492018-12-11T06:38:06 *** state_bits has quit IRC
502018-12-11T06:40:51 *** state_bits has joined #bitcoin-core-dev
512018-12-11T06:54:02 *** Krellan has joined #bitcoin-core-dev
522018-12-11T07:00:18 *** Krellan has quit IRC
532018-12-11T07:42:06 *** Randolf has joined #bitcoin-core-dev
542018-12-11T07:42:51 *** Urgo has joined #bitcoin-core-dev
552018-12-11T08:00:13 *** Krellan has joined #bitcoin-core-dev
562018-12-11T08:03:54 *** Cory has quit IRC
572018-12-11T08:09:11 *** Pasha has joined #bitcoin-core-dev
582018-12-11T08:12:22 *** Pasha is now known as Cory
592018-12-11T08:19:27 *** bgibson has quit IRC
602018-12-11T08:21:27 *** ChA1NsAw has joined #bitcoin-core-dev
612018-12-11T08:28:42 *** AcTiVaTe9 has joined #bitcoin-core-dev
622018-12-11T08:33:12 *** AcTiVaTe9 has quit IRC
632018-12-11T08:37:14 *** opdenkamp has joined #bitcoin-core-dev
642018-12-11T08:49:28 *** bgibson has joined #bitcoin-core-dev
652018-12-11T08:55:41 *** murrayn has quit IRC
662018-12-11T09:03:08 *** Victorsueca has quit IRC
672018-12-11T09:04:20 *** Victorsueca has joined #bitcoin-core-dev
682018-12-11T09:27:30 *** Persopolis has joined #bitcoin-core-dev
692018-12-11T09:30:42 *** Persopolis has quit IRC
702018-12-11T09:49:54 *** hebasto has quit IRC
712018-12-11T10:04:38 *** kexkey has quit IRC
722018-12-11T10:10:42 *** spinza has quit IRC
732018-12-11T10:12:44 *** hebasto has joined #bitcoin-core-dev
742018-12-11T10:21:01 *** spinza has joined #bitcoin-core-dev
752018-12-11T10:32:45 *** timothy has joined #bitcoin-core-dev
762018-12-11T10:33:40 *** Zenton has quit IRC
772018-12-11T10:39:28 <meshcollider> provoostenator: would you mind re-reviewing #14646 if you have some time
782018-12-11T10:39:31 <gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
792018-12-11T10:43:55 *** Zenton has joined #bitcoin-core-dev
802018-12-11T10:52:31 *** Zenton has quit IRC
812018-12-11T10:56:21 <wumpus> rc1 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.17.1/test.rc1/
822018-12-11T10:58:42 *** belcher has quit IRC
832018-12-11T11:03:25 *** belcher has joined #bitcoin-core-dev
842018-12-11T11:06:26 *** Zenton has joined #bitcoin-core-dev
852018-12-11T11:09:40 *** fanquake has joined #bitcoin-core-dev
862018-12-11T11:10:48 <fanquake> wumpus only 2 signed sigs? Or haven't you pushed yours up
872018-12-11T11:11:29 <wumpus> yes, I still have to upload mine
882018-12-11T11:11:36 <wumpus> thanks for remindingm e
892018-12-11T11:13:16 <fanquake> np
902018-12-11T11:21:07 *** miknotauro has quit IRC
912018-12-11T11:23:24 <provoostenator> I'm rebuilding my unsigned ones first because it was complaining about "cp: cannot stat 'inputs/bitcoin-0.17.1rc1-win-unsigned.tar.gz"
922018-12-11T11:23:37 <provoostenator> (just copied a neweer version of gitian-build.py
932018-12-11T11:30:24 *** shesek has quit IRC
942018-12-11T11:31:12 *** shesek has joined #bitcoin-core-dev
952018-12-11T11:31:12 *** shesek has joined #bitcoin-core-dev
962018-12-11T11:31:27 *** shesek has quit IRC
972018-12-11T11:32:50 *** shesek has joined #bitcoin-core-dev
982018-12-11T11:33:41 <provoostenator> Happy to review 13646 again. Can someone remind me of the git incantation to see what changed relative to my 94677cc utACK? (assuming I still have it locally)
992018-12-11T11:35:45 *** promag has joined #bitcoin-core-dev
1002018-12-11T11:36:02 <wumpus> if you just want to see the difference since then: git diff 94677cc
1012018-12-11T11:38:28 <wumpus> this will work okay if either commits were added since then, or commits were squashed/reorganized in place. As it is the total diff that includes the difference in base commits it's not useful to review a rebase.
1022018-12-11T11:38:43 <wumpus> for reviewing a rebase*
1032018-12-11T11:48:16 *** AaronvanW has joined #bitcoin-core-dev
1042018-12-11T11:57:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1052018-12-11T12:02:30 <fanquake> Chris_Stewart_5 is rapidcheck work essentially blocked on upstream?
1062018-12-11T12:03:48 *** spinza has quit IRC
1072018-12-11T12:09:07 <Chris_Stewart_5> fanquake: I haven't had time to track down the root cause. Does it appear that memory access violation is happening in rapidcheck?
1082018-12-11T12:12:22 <fanquake> Chris_Stewart_5 Yes I think so. The bitcoin related test which is failing seems too simple? to be the cause.
1092018-12-11T12:13:13 *** ppisati has quit IRC
1102018-12-11T12:19:07 *** CodeBlue1776 has quit IRC
1112018-12-11T12:20:01 *** CodeBlue1776 has joined #bitcoin-core-dev
1122018-12-11T12:20:18 *** ppisati has joined #bitcoin-core-dev
1132018-12-11T12:20:43 *** bitcoin-git has joined #bitcoin-core-dev
1142018-12-11T12:20:44 <bitcoin-git> [bitcoin] ken2812221 opened pull request #14922: windows: Set_WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
1152018-12-11T12:20:44 *** bitcoin-git has left #bitcoin-core-dev
1162018-12-11T12:21:13 *** fanquake has quit IRC
1172018-12-11T12:23:08 <Chris_Stewart_5> Yes I think it must be. I guess i could remove the test since all of the other ones seems to pass and we can merge that PR.
1182018-12-11T12:23:29 *** spinza has joined #bitcoin-core-dev
1192018-12-11T12:28:47 *** spinza has quit IRC
1202018-12-11T12:33:31 *** fanquake has joined #bitcoin-core-dev
1212018-12-11T12:38:36 <promag> Does it make sense dynamic maxtxfee?
1222018-12-11T12:39:08 <promag> currently it requires a restart?
1232018-12-11T12:45:03 <wumpus> do we still support windows vista or not? I'm confused (re: #14922)
1242018-12-11T12:45:05 <gribble> https://github.com/bitcoin/bitcoin/issues/14922 | windows: Set _WIN32_WINNT to 0x0600 (Windows Vista) by ken2812221 · Pull Request #14922 · bitcoin/bitcoin · GitHub
1252018-12-11T12:45:29 <wumpus> apparently Randolf removed mention of it from the compatibility notes in the release notes
1262018-12-11T12:45:33 <wumpus> in #12546
1272018-12-11T12:45:35 <gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility Notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub
1282018-12-11T12:46:30 <wumpus> for lack of testing on that version I think it makes sense, but, well, I don't think we've ever discussed it
1292018-12-11T12:47:00 <promag> vista is not supported by microsoft since april 2017
1302018-12-11T12:47:08 *** Chris_Stewart_5 has quit IRC
1312018-12-11T12:47:11 <wumpus> ok
1322018-12-11T12:47:59 <wumpus> which suggests that we shouldn't either
1332018-12-11T12:48:02 <fanquake> I'd be surprised if anyone is testing on vista at all.
1342018-12-11T12:48:19 <promag> even win7?
1352018-12-11T12:49:29 <fanquake> qt 5.12 will still support win7, so I think we should try and keep compat for now
1362018-12-11T12:49:57 <promag> https://support.microsoft.com/en-us/help/13853/windows-lifecycle-fact-sheet
1372018-12-11T12:50:16 <promag> yap
1382018-12-11T12:50:34 <fanquake> So we should only support Windows 10?
1392018-12-11T12:51:03 <fanquake> and essentially > 1709
1402018-12-11T12:51:18 <wumpus> no, I'd say we should support win7
1412018-12-11T12:51:23 <wumpus> many people are still using that
1422018-12-11T12:52:01 <fanquake> Potentially larger issue is qts removal of support for "old" macOS versions. 5.12 is 10.12+
1432018-12-11T12:52:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1442018-12-11T12:52:59 <promag> we are far from min qt 5.12
1452018-12-11T12:53:21 <fanquake> It doesn't have to be min, just being able to use in depends
1462018-12-11T12:53:34 *** shesek has quit IRC
1472018-12-11T12:53:59 <fanquake> I'd like to try and use 5.12 (LTS) for 0.18.0
1482018-12-11T12:54:23 <promag> it fixes some macos issues AFAIK
1492018-12-11T12:54:36 <fanquake> and backport the last 5.9.x (LTS) point release to 0.17.x
1502018-12-11T12:55:16 *** shesek has joined #bitcoin-core-dev
1512018-12-11T12:56:12 <Chris_Stewart_5> fanquake: Sorry lost connection, thoughts on just removing that test for now? Like you said it is a very simple test
1522018-12-11T12:56:52 <promag> provoostenator: added new screenshot to #14573
1532018-12-11T12:56:54 <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
1542018-12-11T12:57:24 <promag> provoostenator: I'll push in a bit
1552018-12-11T12:57:41 *** shesek has quit IRC
1562018-12-11T12:58:12 *** shesek has joined #bitcoin-core-dev
1572018-12-11T12:58:15 <fanquake> Chris_Stewart_5 possibly, if you just want to be able to merge #14853 (assuming no other tests fail) in a similar way. I can test later tonight.
1582018-12-11T12:58:17 <gribble> https://github.com/bitcoin/bitcoin/issues/14853 | [wip] depends: latest rapidcheck, enable property based tests on Travis by fanquake · Pull Request #14853 · bitcoin/bitcoin · GitHub
1592018-12-11T12:59:02 <fanquake> When I tried compiling #14430 I ran into some other, potentially related, issues.
1602018-12-11T12:59:05 <gribble> https://github.com/bitcoin/bitcoin/issues/14430 | Add more property based tests for basic bitcoin data structures by Christewart · Pull Request #14430 · bitcoin/bitcoin · GitHub
1612018-12-11T13:10:02 *** rh0nj has quit IRC
1622018-12-11T13:10:28 <Chris_Stewart_5> fanquake: I believe the issues with #14430 where from not having the EXTRAS module installed from rapidcheck? At least I believe that was MarcoFalke's problem with #14171
1632018-12-11T13:10:31 <gribble> https://github.com/bitcoin/bitcoin/issues/14430 | Add more property based tests for basic bitcoin data structures by Christewart · Pull Request #14430 · bitcoin/bitcoin · GitHub
1642018-12-11T13:10:32 <gribble> https://github.com/bitcoin/bitcoin/issues/14171 | travis: Run property based testing by MarcoFalke · Pull Request #14171 · bitcoin/bitcoin · GitHub
1652018-12-11T13:11:38 <fanquake> Chris_Stewart_5 I've tried compiling ontop of the new PR, and was seeing compilation problems, some output here: https://github.com/bitcoin/bitcoin/pull/14430#issuecomment-443400827
1662018-12-11T13:13:12 *** Randolf has quit IRC
1672018-12-11T13:13:24 <Chris_Stewart_5> fanquake: Actually looking closer it appears there are two different properties failing between 14171 and 14430 'key_sign_symmetry' and 'key_set_symmetry'
1682018-12-11T13:14:22 <Chris_Stewart_5> Interesting, i missed that comment
1692018-12-11T13:15:17 <Chris_Stewart_5> did we bump to c++14?
1702018-12-11T13:17:40 *** promag has quit IRC
1712018-12-11T13:18:01 <wumpus> Chris_Stewart_5: no
1722018-12-11T13:18:08 <fanquake> Chris_Stewart_5 No, maybe for 0.19.0 #13356
1732018-12-11T13:18:09 <gribble> https://github.com/bitcoin/bitcoin/issues/13356 | RFC: C++14 Requirement · Issue #13356 · bitcoin/bitcoin · GitHub
1742018-12-11T13:21:38 <fanquake> If anyones interested, while doing rc1 testing, I'll be adding bitcoin-core vm setups to a Vagrantfile here: https://github.com/fanquake/core-review/tree/master/vagrant
1752018-12-11T13:22:06 <fanquake> A lot of my vm setup/testing had been pretty manual using virtualbox, so I've decided to try and automate it further.
1762018-12-11T13:23:18 <fanquake> For ex, make it's fairly easy to github-merge a PR, then "spin up" an openBSD vm, with core dependencies/debugging tools already available, and have the code sitting inside.
1772018-12-11T13:25:00 <Chris_Stewart_5> That can be used for more generalized testing, i.e. rapid check stuff right? Is there much of a difference between this and using docker?
1782018-12-11T13:26:05 <provoostenator> wumpus: thanks. Indeed I want to review the rebase, which involves slightly more magic
1792018-12-11T13:27:17 <fanquake> Chris_Stewart_5 Yea. I did use Docker directly to recreate Travis for the rapidcheck debugging, but decided to use vagrant here, as it sits "above" virtualbox, docker etc
1802018-12-11T13:28:15 <Chris_Stewart_5> Interesting. I probably won't get around to testing until this weekend but I'll give it a try.
1812018-12-11T13:30:47 <provoostenator> Stack Overflow to the rescue: git commit-tree HEAD^{tree} -p 94677cc -p HEAD~5 -m "Rebase changes since 94677cc" && git show
1822018-12-11T13:30:57 <provoostenator> Where 5 is the number of commits in the PR
1832018-12-11T13:34:17 *** shesek has quit IRC
1842018-12-11T13:35:37 *** shesek has joined #bitcoin-core-dev
1852018-12-11T13:36:50 *** jaibitcoin has joined #bitcoin-core-dev
1862018-12-11T13:38:22 *** ap4lmtree has quit IRC
1872018-12-11T13:38:55 <provoostenator> (neh, I don't think that worked, I'll leave a comment on the PR once I find it)
1882018-12-11T13:39:50 *** shesek has quit IRC
1892018-12-11T13:40:25 *** ap4lmtree has joined #bitcoin-core-dev
1902018-12-11T13:41:38 *** shesek has joined #bitcoin-core-dev
1912018-12-11T13:42:46 *** shesek has quit IRC
1922018-12-11T13:43:22 <provoostenator> Ah, it's: git show ` git commit-tree ...`
1932018-12-11T13:46:22 *** jaibitcoin has quit IRC
1942018-12-11T13:49:30 *** shesek has joined #bitcoin-core-dev
1952018-12-11T13:49:30 *** shesek has joined #bitcoin-core-dev
1962018-12-11T13:54:12 *** Chris_Stewart_5 has quit IRC
1972018-12-11T14:00:37 *** elichai2 has joined #bitcoin-core-dev
1982018-12-11T14:07:34 *** Guyver2 has joined #bitcoin-core-dev
1992018-12-11T14:30:22 <fanquake> Chris_Stewart_5 I've just pushed up a travis vm definition: https://github.com/fanquake/core-review/commit/26032d6bdcdf7e928f8ce22c97e29c9846b39d59
2002018-12-11T14:31:29 <fanquake> If you do a github-merge 14853, then vagrant up travis-linux-no-depends-qt
2012018-12-11T14:32:01 *** shesek has quit IRC
2022018-12-11T14:32:04 <fanquake> At the end you can ssh into the box, and run gdb --args src/test/test_bitcoin --log_level=all --run_test=key_properties
2032018-12-11T14:32:33 <fanquake> then "run", "thread apply bt all" and it'll give you the backtrace you're after
2042018-12-11T14:32:43 *** shesek has joined #bitcoin-core-dev
2052018-12-11T14:42:58 *** promag has joined #bitcoin-core-dev
2062018-12-11T14:42:59 *** shesek has quit IRC
2072018-12-11T14:43:53 *** shesek has joined #bitcoin-core-dev
2082018-12-11T14:53:09 *** xdash has joined #bitcoin-core-dev
2092018-12-11T14:55:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2102018-12-11T14:57:24 *** drexl has quit IRC
2112018-12-11T14:59:22 *** promag has quit IRC
2122018-12-11T15:13:25 *** promag has joined #bitcoin-core-dev
2132018-12-11T15:17:36 *** shesek has quit IRC
2142018-12-11T15:18:26 *** shesek has joined #bitcoin-core-dev
2152018-12-11T15:18:26 *** shesek has joined #bitcoin-core-dev
2162018-12-11T15:27:11 *** promag has quit IRC
2172018-12-11T15:32:07 *** jarthur has joined #bitcoin-core-dev
2182018-12-11T15:34:09 *** promag has joined #bitcoin-core-dev
2192018-12-11T15:36:17 *** michaelsdunn1 has joined #bitcoin-core-dev
2202018-12-11T15:36:34 *** promag has quit IRC
2212018-12-11T15:50:40 *** Chris_Stewart_5 has quit IRC
2222018-12-11T16:11:00 *** shesek has quit IRC
2232018-12-11T16:13:32 *** dqx has quit IRC
2242018-12-11T16:13:44 *** shesek has joined #bitcoin-core-dev
2252018-12-11T16:15:07 *** miknotauro has joined #bitcoin-core-dev
2262018-12-11T16:19:40 *** shesek has quit IRC
2272018-12-11T16:20:24 *** shesek has joined #bitcoin-core-dev
2282018-12-11T16:20:24 *** shesek has joined #bitcoin-core-dev
2292018-12-11T16:24:15 <wumpus> fanquake: that seems very useful, I'm still mostly using manual testing in VMs too, can be a hassle sometimes especially when the VMs need to be upgraded, would be good to automate
2302018-12-11T16:25:13 <wumpus> provoostenator: good to know
2312018-12-11T16:26:19 <provoostenator> wumpus: actually that didn't work either. I left a git range-diff incantation on the PR, though the diff is too big to be useful.
2322018-12-11T16:28:32 *** shesek has quit IRC
2332018-12-11T16:28:52 <wumpus> provoostenator: what I usually do is manually repeat the rebase (on a temporary branch), then compare against the author's, it's a lot of hassle though especially the rebase doesn't go cleanup
2342018-12-11T16:28:59 <wumpus> cleanly*
2352018-12-11T16:29:08 *** shesek has joined #bitcoin-core-dev
2362018-12-11T16:31:19 <wumpus> I'd hoped there was a cleaner/faster way but seems not
2372018-12-11T16:33:19 *** shesek has quit IRC
2382018-12-11T16:33:49 *** shesek has joined #bitcoin-core-dev
2392018-12-11T16:36:58 <provoostenator> git range-diff `git merge-base --all HEAD 94677cc `... 94677cc HEAD~5...HEAD
2402018-12-11T16:37:51 <provoostenator> Though it takes Matrix level reading skills to understand the result often.
2412018-12-11T16:39:24 *** miknotauro has quit IRC
2422018-12-11T16:40:07 *** rh0nj has joined #bitcoin-core-dev
2432018-12-11T16:48:26 <fanquake> wumpus I added some example usage docs, https://github.com/fanquake/core-review/tree/master/vagrant#testing-pull-requests , will add more vms this week.
2442018-12-11T16:55:38 *** fanquake has quit IRC
2452018-12-11T17:02:09 <provoostenator> I annotated a range-diff for a simpler commit #14573, though I suspect there's a better way...
2462018-12-11T17:02:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
2472018-12-11T17:04:35 *** Krellan has quit IRC
2482018-12-11T17:15:49 *** shesek has quit IRC
2492018-12-11T17:16:28 *** shesek has joined #bitcoin-core-dev
2502018-12-11T17:17:24 *** shesek has quit IRC
2512018-12-11T17:18:09 *** shesek has joined #bitcoin-core-dev
2522018-12-11T17:20:09 *** Murch has joined #bitcoin-core-dev
2532018-12-11T17:25:14 <meshcollider> If anyone has some time, #14886 review would be very appreciated so we can get it merged, a lot depends on it
2542018-12-11T17:25:16 <gribble> https://github.com/bitcoin/bitcoin/issues/14886 | [tests] Refactor importmulti tests by jnewbery · Pull Request #14886 · bitcoin/bitcoin · GitHub
2552018-12-11T17:30:05 *** promag has joined #bitcoin-core-dev
2562018-12-11T17:39:55 *** shesek has quit IRC
2572018-12-11T17:40:38 *** shesek has joined #bitcoin-core-dev
2582018-12-11T17:46:53 <promag> can I have #14573 in HP?
2592018-12-11T17:46:55 <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
2602018-12-11T17:51:51 *** shesek has quit IRC
2612018-12-11T17:54:01 *** shesek has joined #bitcoin-core-dev
2622018-12-11T18:01:36 *** spinza has joined #bitcoin-core-dev
2632018-12-11T18:04:25 *** shesek has quit IRC
2642018-12-11T18:06:00 *** shesek has joined #bitcoin-core-dev
2652018-12-11T18:06:00 *** shesek has joined #bitcoin-core-dev
2662018-12-11T18:06:36 *** shesek has quit IRC
2672018-12-11T18:07:07 *** shesek has joined #bitcoin-core-dev
2682018-12-11T18:07:14 *** promag has quit IRC
2692018-12-11T18:16:17 *** Aaronvan_ has joined #bitcoin-core-dev
2702018-12-11T18:16:28 *** Urgo has quit IRC
2712018-12-11T18:19:57 *** AaronvanW has quit IRC
2722018-12-11T18:24:10 *** shesek has quit IRC
2732018-12-11T18:24:50 *** shesek has joined #bitcoin-core-dev
2742018-12-11T18:24:50 *** shesek has joined #bitcoin-core-dev
2752018-12-11T18:24:58 *** bitcoin-git has joined #bitcoin-core-dev
2762018-12-11T18:24:59 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14925: test: Correctly deserialize without witness (master...Mf1812-testWitnessDeser) https://github.com/bitcoin/bitcoin/pull/14925
2772018-12-11T18:24:59 *** bitcoin-git has left #bitcoin-core-dev
2782018-12-11T18:26:32 *** shesek has quit IRC
2792018-12-11T18:27:19 *** shesek has joined #bitcoin-core-dev
2802018-12-11T18:29:12 *** shesek has quit IRC
2812018-12-11T18:29:20 *** spinza has quit IRC
2822018-12-11T18:31:28 *** shesek has joined #bitcoin-core-dev
2832018-12-11T18:31:28 *** shesek has joined #bitcoin-core-dev
2842018-12-11T18:35:24 *** Krellan has joined #bitcoin-core-dev
2852018-12-11T18:35:38 *** shesek has quit IRC
2862018-12-11T18:36:39 *** rex4539 has quit IRC
2872018-12-11T18:37:48 *** shesek has joined #bitcoin-core-dev
2882018-12-11T18:37:57 *** bitcoin-git has joined #bitcoin-core-dev
2892018-12-11T18:37:58 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14926: test: consensus: Check that final transactions are valid (master...Mf1812-testConsensusFinal) https://github.com/bitcoin/bitcoin/pull/14926
2902018-12-11T18:37:58 *** bitcoin-git has left #bitcoin-core-dev
2912018-12-11T18:41:22 *** spinza has joined #bitcoin-core-dev
2922018-12-11T18:42:04 *** shesek has quit IRC
2932018-12-11T18:43:14 *** shesek has joined #bitcoin-core-dev
2942018-12-11T18:43:14 *** shesek has joined #bitcoin-core-dev
2952018-12-11T18:44:06 *** Krellan has quit IRC
2962018-12-11T18:44:10 *** bitcoin-git has joined #bitcoin-core-dev
2972018-12-11T18:44:11 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5f23460c7e31...d680ef9381b4
2982018-12-11T18:44:11 <bitcoin-git> bitcoin/master 522b80b qubenix: add `--retry 5` to curl opts in install_db4.sh
2992018-12-11T18:44:12 <bitcoin-git> bitcoin/master d680ef9 MarcoFalke: Merge #14883: add `--retry 5` to curl opts in install_db4.sh...
3002018-12-11T18:44:12 *** bitcoin-git has left #bitcoin-core-dev
3012018-12-11T18:45:05 *** timothy has quit IRC
3022018-12-11T18:45:09 *** bitcoin-git has joined #bitcoin-core-dev
3032018-12-11T18:45:09 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14883: add `--retry 5` to curl opts in install_db4.sh (master...qubenix-curl-retry) https://github.com/bitcoin/bitcoin/pull/14883
3042018-12-11T18:45:09 *** bitcoin-git has left #bitcoin-core-dev
3052018-12-11T18:46:04 *** bitcoin-git has joined #bitcoin-core-dev
3062018-12-11T18:46:05 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d680ef9381b4...7701b62561c4
3072018-12-11T18:46:05 <bitcoin-git> bitcoin/master 0dcac51 Gregory Sanders: wallet_keypool_topup.py: Test for all keypool address types
3082018-12-11T18:46:06 <bitcoin-git> bitcoin/master 7701b62 MarcoFalke: Merge #14857: wallet_keypool_topup.py: Test for all keypool address types...
3092018-12-11T18:46:06 *** bitcoin-git has left #bitcoin-core-dev
3102018-12-11T18:46:50 *** bitcoin-git has joined #bitcoin-core-dev
3112018-12-11T18:46:50 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14857: wallet_keypool_topup.py: Test for all keypool address types (master...keypool_topup_addresstype) https://github.com/bitcoin/bitcoin/pull/14857
3122018-12-11T18:46:50 *** bitcoin-git has left #bitcoin-core-dev
3132018-12-11T18:49:12 *** miknotauro has joined #bitcoin-core-dev
3142018-12-11T18:54:15 *** CodeBlue1776 has quit IRC
3152018-12-11T18:54:32 *** CodeBlue1776 has joined #bitcoin-core-dev
3162018-12-11T18:57:40 *** bitcoin-git has joined #bitcoin-core-dev
3172018-12-11T18:57:40 <bitcoin-git> [bitcoin] MarcoFalke pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/7701b62561c4...f65bce858f26
3182018-12-11T18:57:41 <bitcoin-git> bitcoin/master cb41ade John Newbery: [tests] fix flake8 warnings in wallet_importmulti.py
3192018-12-11T18:57:42 <bitcoin-git> bitcoin/master e5a8ea8 John Newbery: [tests] tidy up imports in wallet_importmulti.py
3202018-12-11T18:57:42 <bitcoin-git> bitcoin/master 7c99614 John Newbery: [tests] add get_key function to wallet_importmulti.py...
3212018-12-11T18:57:43 *** bitcoin-git has left #bitcoin-core-dev
3222018-12-11T18:58:14 *** bitcoin-git has joined #bitcoin-core-dev
3232018-12-11T18:58:15 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14886: [tests] Refactor importmulti tests (master...importmulti_tests) https://github.com/bitcoin/bitcoin/pull/14886
3242018-12-11T18:58:15 *** bitcoin-git has left #bitcoin-core-dev
3252018-12-11T19:00:46 *** shesek has quit IRC
3262018-12-11T19:01:40 *** shesek has joined #bitcoin-core-dev
3272018-12-11T19:06:19 *** Victorsueca has quit IRC
3282018-12-11T19:07:36 *** Victorsueca has joined #bitcoin-core-dev
3292018-12-11T19:10:01 *** rex4539 has joined #bitcoin-core-dev
3302018-12-11T19:24:09 *** xdash has quit IRC
3312018-12-11T19:26:06 *** shesek has quit IRC
3322018-12-11T19:27:03 *** shesek has joined #bitcoin-core-dev
3332018-12-11T19:27:03 *** shesek has joined #bitcoin-core-dev
3342018-12-11T19:28:50 *** miknotauro has quit IRC
3352018-12-11T19:31:46 *** shesek has quit IRC
3362018-12-11T19:32:51 *** shesek has joined #bitcoin-core-dev
3372018-12-11T19:32:51 *** shesek has joined #bitcoin-core-dev
3382018-12-11T19:38:33 *** michaelsdunn1 has quit IRC
3392018-12-11T19:41:55 *** miknotauro has joined #bitcoin-core-dev
3402018-12-11T19:42:17 *** michaelsdunn1 has joined #bitcoin-core-dev
3412018-12-11T19:47:14 *** michaelsdunn1 has quit IRC
3422018-12-11T19:49:20 *** michaelsdunn1 has joined #bitcoin-core-dev
3432018-12-11T19:51:13 *** miknotauro has quit IRC
3442018-12-11T19:52:09 *** elichai2 has quit IRC
3452018-12-11T19:54:04 *** michaelsdunn1 has quit IRC
3462018-12-11T19:54:36 *** shesek has quit IRC
3472018-12-11T19:55:24 *** Krellan has joined #bitcoin-core-dev
3482018-12-11T19:55:45 *** shesek has joined #bitcoin-core-dev
3492018-12-11T19:55:54 *** michaelsdunn1 has joined #bitcoin-core-dev
3502018-12-11T20:04:07 *** miknotauro has joined #bitcoin-core-dev
3512018-12-11T20:08:16 *** michaels_ has joined #bitcoin-core-dev
3522018-12-11T20:09:27 *** promag has joined #bitcoin-core-dev
3532018-12-11T20:11:40 *** michaelsdunn1 has quit IRC
3542018-12-11T20:16:11 *** Nazo has joined #bitcoin-core-dev
3552018-12-11T20:16:39 *** miknotauro has quit IRC
3562018-12-11T20:19:41 *** Nazo has quit IRC
3572018-12-11T20:21:42 *** Aaronvan_ has quit IRC
3582018-12-11T20:22:10 *** AaronvanW has joined #bitcoin-core-dev
3592018-12-11T20:22:47 *** hebasto has quit IRC
3602018-12-11T20:27:02 *** shesek has quit IRC
3612018-12-11T20:28:23 *** shesek has joined #bitcoin-core-dev
3622018-12-11T20:30:42 *** miknotauro has joined #bitcoin-core-dev
3632018-12-11T20:32:32 *** michaels_ has quit IRC
3642018-12-11T20:33:59 *** michaelsdunn1 has joined #bitcoin-core-dev
3652018-12-11T20:35:45 *** Krellan has quit IRC
3662018-12-11T20:36:20 *** Krellan has joined #bitcoin-core-dev
3672018-12-11T20:37:33 *** Krellan has quit IRC
3682018-12-11T20:38:10 *** Krellan has joined #bitcoin-core-dev
3692018-12-11T20:38:31 *** shesek has quit IRC
3702018-12-11T20:39:34 *** shesek has joined #bitcoin-core-dev
3712018-12-11T20:39:34 *** shesek has joined #bitcoin-core-dev
3722018-12-11T20:44:44 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3732018-12-11T20:56:36 *** michaelsdunn1 has quit IRC
3742018-12-11T20:58:42 *** michaelsdunn1 has joined #bitcoin-core-dev
3752018-12-11T20:58:42 *** michaelsdunn1 has quit IRC
3762018-12-11T20:58:42 *** michaelsdunn1 has joined #bitcoin-core-dev
3772018-12-11T21:05:48 *** shesek has quit IRC
3782018-12-11T21:06:34 *** shesek has joined #bitcoin-core-dev
3792018-12-11T21:08:07 *** promag has quit IRC
3802018-12-11T21:11:32 *** luke-jr has quit IRC
3812018-12-11T21:12:00 *** miknotauro has quit IRC
3822018-12-11T21:13:01 *** shesek has quit IRC
3832018-12-11T21:13:34 *** csknk has joined #bitcoin-core-dev
3842018-12-11T21:14:41 *** bitcoin-git has joined #bitcoin-core-dev
3852018-12-11T21:14:42 <bitcoin-git> [bitcoin] gmaxwell opened pull request #14929: Allow connections from misbehavior banned peers. (master...201812-softbanmisbehaving) https://github.com/bitcoin/bitcoin/pull/14929
3862018-12-11T21:14:42 *** bitcoin-git has left #bitcoin-core-dev
3872018-12-11T21:15:21 *** chubas has joined #bitcoin-core-dev
3882018-12-11T21:15:34 *** shesek has joined #bitcoin-core-dev
3892018-12-11T21:15:34 *** shesek has joined #bitcoin-core-dev
3902018-12-11T21:16:52 *** csknk has quit IRC
3912018-12-11T21:18:07 *** shesek has quit IRC
3922018-12-11T21:19:49 *** shesek has joined #bitcoin-core-dev
3932018-12-11T21:20:39 *** promag has joined #bitcoin-core-dev
3942018-12-11T21:23:19 *** luke-jr has joined #bitcoin-core-dev
3952018-12-11T21:31:44 *** Krellan has quit IRC
3962018-12-11T21:39:49 *** Krellan has joined #bitcoin-core-dev
3972018-12-11T21:41:01 *** Guyver2 has quit IRC
3982018-12-11T21:41:10 *** chubas has quit IRC
3992018-12-11T21:47:45 *** promag has quit IRC
4002018-12-11T21:49:37 *** fabianfabian has joined #bitcoin-core-dev
4012018-12-11T22:05:46 *** spinza has quit IRC
4022018-12-11T22:08:44 *** spinza has joined #bitcoin-core-dev
4032018-12-11T22:09:52 *** drexl has joined #bitcoin-core-dev
4042018-12-11T22:15:43 *** shesek has quit IRC
4052018-12-11T22:16:50 *** shesek has joined #bitcoin-core-dev
4062018-12-11T22:16:50 *** shesek has joined #bitcoin-core-dev
4072018-12-11T22:22:44 *** shesek has quit IRC
4082018-12-11T22:23:58 *** shesek has joined #bitcoin-core-dev
4092018-12-11T22:23:58 *** shesek has joined #bitcoin-core-dev
4102018-12-11T22:24:54 <meshcollider> promag: done
4112018-12-11T22:27:45 *** jarthur has quit IRC
4122018-12-11T22:33:02 *** shesek has quit IRC
4132018-12-11T22:34:31 *** shesek has joined #bitcoin-core-dev
4142018-12-11T22:36:04 *** Krellan has quit IRC
4152018-12-11T22:38:50 *** shesek has quit IRC
4162018-12-11T22:39:51 *** shesek has joined #bitcoin-core-dev
4172018-12-11T22:40:40 *** shesek has quit IRC
4182018-12-11T22:41:48 *** shesek has joined #bitcoin-core-dev
4192018-12-11T22:41:48 *** shesek has joined #bitcoin-core-dev
4202018-12-11T22:42:17 *** qu4ku has joined #bitcoin-core-dev
4212018-12-11T22:42:34 *** shesek has quit IRC
4222018-12-11T22:43:53 *** shesek has joined #bitcoin-core-dev
4232018-12-11T22:55:06 *** CubicEarth has quit IRC
4242018-12-11T22:59:50 *** michaelsdunn1 has quit IRC
4252018-12-11T23:02:36 *** state_bits has quit IRC
4262018-12-11T23:02:44 *** state_bits has joined #bitcoin-core-dev
4272018-12-11T23:04:50 *** promag has joined #bitcoin-core-dev
4282018-12-11T23:17:48 *** owowo has quit IRC
4292018-12-11T23:34:11 *** Emcy has quit IRC
4302018-12-11T23:34:49 *** Emcy has joined #bitcoin-core-dev
4312018-12-11T23:39:02 *** shesek has quit IRC
4322018-12-11T23:42:38 *** shesek has joined #bitcoin-core-dev
4332018-12-11T23:47:22 *** shesek has quit IRC
4342018-12-11T23:50:45 *** kinlo has quit IRC
4352018-12-11T23:50:47 *** Chris_Stewart_5 has quit IRC
4362018-12-11T23:55:44 *** fabianfabian has quit IRC
4372018-12-11T23:55:52 *** Krellan has joined #bitcoin-core-dev
4382018-12-11T23:57:35 *** shesek has joined #bitcoin-core-dev
4392018-12-11T23:58:03 <promag> thanks meshcollider