12018-12-12T00:00:21 *** miknotauro has joined #bitcoin-core-dev
22018-12-12T00:05:44 *** ChA1NsAw has quit IRC
32018-12-12T00:08:28 *** miknotauro has quit IRC
42018-12-12T00:09:14 *** shesek has quit IRC
52018-12-12T00:09:53 *** kinlo has joined #bitcoin-core-dev
62018-12-12T00:11:00 *** bitcoin-git has joined #bitcoin-core-dev
72018-12-12T00:11:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14930: test: pruning: Check that verifychain can be called when pruned (master...Mf1812-testPruneVerify) https://github.com/bitcoin/bitcoin/pull/14930
82018-12-12T00:11:00 *** bitcoin-git has left #bitcoin-core-dev
92018-12-12T00:12:40 *** shesek has joined #bitcoin-core-dev
102018-12-12T00:12:40 *** shesek has quit IRC
112018-12-12T00:12:40 *** shesek has joined #bitcoin-core-dev
122018-12-12T00:18:06 <promag> MarcoFalke: I'd like that wallet :P
132018-12-12T00:29:52 *** shesek has quit IRC
142018-12-12T00:41:29 *** promag has quit IRC
152018-12-12T00:41:39 *** dviola has joined #bitcoin-core-dev
162018-12-12T00:59:36 *** Murch has quit IRC
172018-12-12T01:11:15 *** Aaronvan_ has joined #bitcoin-core-dev
182018-12-12T01:11:27 *** AaronvanW has quit IRC
192018-12-12T01:24:13 *** qu4ku has quit IRC
202018-12-12T01:35:27 *** Aaronvan_ has quit IRC
212018-12-12T01:42:11 *** AaronvanW has joined #bitcoin-core-dev
222018-12-12T01:43:35 *** AaronvanW has quit IRC
232018-12-12T01:43:52 *** AaronvanW has joined #bitcoin-core-dev
242018-12-12T01:46:01 *** rh0nj has quit IRC
252018-12-12T01:48:38 *** bitcoin-git has joined #bitcoin-core-dev
262018-12-12T01:48:38 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14931: test: mempool_persist: Verify prioritization is dumped correctly (master...Mf1812-testMempoolPrio) https://github.com/bitcoin/bitcoin/pull/14931
272018-12-12T01:48:38 *** bitcoin-git has left #bitcoin-core-dev
282018-12-12T01:49:07 *** rh0nj has joined #bitcoin-core-dev
292018-12-12T02:04:55 *** ap4lmtree has quit IRC
302018-12-12T02:09:01 *** ap4lmtree has joined #bitcoin-core-dev
312018-12-12T02:34:58 *** shesek has joined #bitcoin-core-dev
322018-12-12T02:38:18 *** shesek has quit IRC
332018-12-12T02:39:14 *** shesek has joined #bitcoin-core-dev
342018-12-12T02:41:53 *** shesek has joined #bitcoin-core-dev
352018-12-12T02:53:03 *** bitcoin-git has joined #bitcoin-core-dev
362018-12-12T02:53:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14932: ui: Warn the user on file corruption in mempool.dat (master...Mf1812-testFileCorruption) https://github.com/bitcoin/bitcoin/pull/14932
372018-12-12T02:53:03 *** bitcoin-git has left #bitcoin-core-dev
382018-12-12T02:54:29 *** shesek has quit IRC
392018-12-12T02:55:48 *** shesek has joined #bitcoin-core-dev
402018-12-12T02:55:48 *** shesek has joined #bitcoin-core-dev
412018-12-12T02:57:05 *** shesek has quit IRC
422018-12-12T02:57:58 *** shesek has joined #bitcoin-core-dev
432018-12-12T02:57:58 *** shesek has joined #bitcoin-core-dev
442018-12-12T02:58:55 *** shesek has quit IRC
452018-12-12T03:01:22 *** shesek has joined #bitcoin-core-dev
462018-12-12T03:02:54 *** shesek has joined #bitcoin-core-dev
472018-12-12T03:04:13 *** shesek has quit IRC
482018-12-12T03:04:43 *** shesek has joined #bitcoin-core-dev
492018-12-12T03:20:15 *** AaronvanW has quit IRC
502018-12-12T03:21:54 *** Krellan has quit IRC
512018-12-12T03:27:27 *** nelsonhb has joined #bitcoin-core-dev
522018-12-12T03:30:51 *** murrayn has joined #bitcoin-core-dev
532018-12-12T03:30:52 *** murrayn has joined #bitcoin-core-dev
542018-12-12T03:35:40 *** comboy has joined #bitcoin-core-dev
552018-12-12T03:36:59 *** _cryptodesktop_i has joined #bitcoin-core-dev
562018-12-12T03:45:09 *** shesek has quit IRC
572018-12-12T03:46:33 *** shesek has joined #bitcoin-core-dev
582018-12-12T03:54:34 *** shesek has quit IRC
592018-12-12T03:56:06 *** shesek has joined #bitcoin-core-dev
602018-12-12T03:57:44 *** shesek has quit IRC
612018-12-12T04:06:19 *** shesek has joined #bitcoin-core-dev
622018-12-12T04:11:07 *** _cryptodesktop_i has quit IRC
632018-12-12T04:11:15 *** shesek has quit IRC
642018-12-12T04:15:48 *** Cory has quit IRC
652018-12-12T04:17:16 *** shesek has joined #bitcoin-core-dev
662018-12-12T04:19:34 *** shesek has quit IRC
672018-12-12T04:20:59 *** shesek has joined #bitcoin-core-dev
682018-12-12T04:21:30 *** shesek has quit IRC
692018-12-12T04:22:31 *** Cory has joined #bitcoin-core-dev
702018-12-12T04:23:43 *** shesek has joined #bitcoin-core-dev
712018-12-12T04:24:59 *** shesek has joined #bitcoin-core-dev
722018-12-12T04:26:09 *** bitcoin-git has joined #bitcoin-core-dev
732018-12-12T04:26:10 <bitcoin-git> [bitcoin] MeshCollider pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/f65bce858f26...3fff1ab817e7
742018-12-12T04:26:10 <bitcoin-git> bitcoin/master 6be0fb4 Pieter Wuille: [refactor] Add a base DescriptorImpl with most common logic
752018-12-12T04:26:11 <bitcoin-git> bitcoin/master 24d3a7b Pieter Wuille: [refactor] Use DescriptorImpl internally, permitting access to new methods
762018-12-12T04:26:11 <bitcoin-git> bitcoin/master 1eda33a Pieter Wuille: [refactor] Combine the ToString and ToPrivateString implementations
772018-12-12T04:26:12 *** bitcoin-git has left #bitcoin-core-dev
782018-12-12T04:26:54 *** bitcoin-git has joined #bitcoin-core-dev
792018-12-12T04:26:54 <bitcoin-git> [bitcoin] MeshCollider closed pull request #14646: Add expansion cache functions to descriptors (unused for now) (master...201811_descriptcache) https://github.com/bitcoin/bitcoin/pull/14646
802018-12-12T04:26:54 *** bitcoin-git has left #bitcoin-core-dev
812018-12-12T04:29:53 *** spinza has quit IRC
822018-12-12T04:32:50 *** spinza has joined #bitcoin-core-dev
832018-12-12T04:33:09 *** shesek has quit IRC
842018-12-12T04:33:44 *** shesek has joined #bitcoin-core-dev
852018-12-12T04:33:44 *** shesek has joined #bitcoin-core-dev
862018-12-12T04:34:07 *** shesek has quit IRC
872018-12-12T04:34:48 *** shesek has joined #bitcoin-core-dev
882018-12-12T04:37:05 *** shesek has quit IRC
892018-12-12T04:39:22 *** shesek has joined #bitcoin-core-dev
902018-12-12T05:01:40 *** bitcoin-git has joined #bitcoin-core-dev
912018-12-12T05:01:41 <bitcoin-git> [bitcoin] MeshCollider pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fff1ab817e7...ed2a2cebd362
922018-12-12T05:01:41 <bitcoin-git> bitcoin/master bb24d68 Ben Woosley: Make CWallet::ScanForWalletTransactions args and return value const
932018-12-12T05:01:42 <bitcoin-git> bitcoin/master 3002d6c Ben Woosley: Return a status enum from ScanForWalletTransactions...
942018-12-12T05:01:42 <bitcoin-git> bitcoin/master bd3b036 Ben Woosley: Add stop_block out arg to ScanForWalletTransactions...
952018-12-12T05:01:43 *** shesek has quit IRC
962018-12-12T05:01:43 *** bitcoin-git has left #bitcoin-core-dev
972018-12-12T05:01:54 *** bitcoin-git has joined #bitcoin-core-dev
982018-12-12T05:01:54 <bitcoin-git> [bitcoin] MeshCollider closed pull request #13076: Fix ScanForWalletTransactions to return an enum indicating scan result: success / failure / user_abort (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
992018-12-12T05:01:54 *** bitcoin-git has left #bitcoin-core-dev
1002018-12-12T05:02:15 *** shesek has joined #bitcoin-core-dev
1012018-12-12T05:04:53 *** shesek has joined #bitcoin-core-dev
1022018-12-12T05:04:53 *** shesek has joined #bitcoin-core-dev
1032018-12-12T05:07:44 *** shesek has quit IRC
1042018-12-12T05:08:44 *** shesek has joined #bitcoin-core-dev
1052018-12-12T05:08:44 *** shesek has joined #bitcoin-core-dev
1062018-12-12T05:09:00 <nelsonhb> The succession of these flame emperors, from Shennong, the first Yan Emperor, until the time of the last Yan Emperor's defeat by the Yellow
1072018-12-12T05:09:00 <nelsonhb> Emperor, may have been some 500 years.
1082018-12-12T05:14:45 *** shesek has quit IRC
1092018-12-12T05:16:27 *** shesek has joined #bitcoin-core-dev
1102018-12-12T05:17:26 *** murrayn has quit IRC
1112018-12-12T05:17:40 *** tryphe has quit IRC
1122018-12-12T05:17:49 *** murrayn has joined #bitcoin-core-dev
1132018-12-12T05:17:49 *** murrayn has joined #bitcoin-core-dev
1142018-12-12T05:18:28 *** tryphe has joined #bitcoin-core-dev
1152018-12-12T05:18:49 *** TheRec has quit IRC
1162018-12-12T05:19:05 *** shesek has joined #bitcoin-core-dev
1172018-12-12T05:19:06 *** nelsonhb has quit IRC
1182018-12-12T05:19:28 *** TheRec has joined #bitcoin-core-dev
1192018-12-12T05:19:28 *** TheRec has joined #bitcoin-core-dev
1202018-12-12T05:23:55 *** shesek has quit IRC
1212018-12-12T05:25:11 *** shesek has joined #bitcoin-core-dev
1222018-12-12T05:32:01 *** shesek has quit IRC
1232018-12-12T05:33:26 *** shesek has joined #bitcoin-core-dev
1242018-12-12T05:38:58 *** shesek has quit IRC
1252018-12-12T05:40:42 *** shesek has joined #bitcoin-core-dev
1262018-12-12T05:40:42 *** shesek has joined #bitcoin-core-dev
1272018-12-12T05:41:06 *** helo has joined #bitcoin-core-dev
1282018-12-12T05:41:37 *** shesek has quit IRC
1292018-12-12T05:45:47 *** shesek has joined #bitcoin-core-dev
1302018-12-12T05:47:58 *** shesek has quit IRC
1312018-12-12T05:48:41 *** shesek has joined #bitcoin-core-dev
1322018-12-12T05:49:46 *** shesek has quit IRC
1332018-12-12T05:50:13 *** shesek has joined #bitcoin-core-dev
1342018-12-12T05:53:11 *** shesek has joined #bitcoin-core-dev
1352018-12-12T05:53:39 <ap4lmtree> qt is a popular interface gui huh
1362018-12-12T05:53:50 <ap4lmtree> how did you guys learn that qt related programming
1372018-12-12T06:20:41 *** miknotauro has joined #bitcoin-core-dev
1382018-12-12T06:29:46 *** shesek has quit IRC
1392018-12-12T06:30:40 *** shesek has joined #bitcoin-core-dev
1402018-12-12T06:30:40 *** shesek has joined #bitcoin-core-dev
1412018-12-12T06:33:06 *** shesek has quit IRC
1422018-12-12T06:33:41 *** shesek has joined #bitcoin-core-dev
1432018-12-12T06:36:52 *** schmidty_ has joined #bitcoin-core-dev
1442018-12-12T06:37:54 *** schmidty has quit IRC
1452018-12-12T06:38:02 *** shesek has quit IRC
1462018-12-12T06:38:46 *** shesek has joined #bitcoin-core-dev
1472018-12-12T06:42:24 *** shesek has quit IRC
1482018-12-12T06:42:51 *** shesek has joined #bitcoin-core-dev
1492018-12-12T06:52:11 *** shesek has quit IRC
1502018-12-12T06:52:47 *** shesek has joined #bitcoin-core-dev
1512018-12-12T06:52:47 *** shesek has joined #bitcoin-core-dev
1522018-12-12T06:53:10 *** shesek has quit IRC
1532018-12-12T06:54:51 *** shesek has joined #bitcoin-core-dev
1542018-12-12T07:04:19 *** shesek has quit IRC
1552018-12-12T07:08:00 *** shesek has joined #bitcoin-core-dev
1562018-12-12T07:08:00 *** shesek has joined #bitcoin-core-dev
1572018-12-12T07:09:44 *** shesek has quit IRC
1582018-12-12T07:13:38 *** shesek has joined #bitcoin-core-dev
1592018-12-12T07:13:38 *** shesek has joined #bitcoin-core-dev
1602018-12-12T07:14:57 *** shesek has quit IRC
1612018-12-12T07:16:10 *** shesek has joined #bitcoin-core-dev
1622018-12-12T07:16:10 *** shesek has joined #bitcoin-core-dev
1632018-12-12T07:29:28 *** promag has joined #bitcoin-core-dev
1642018-12-12T07:30:40 *** shesek has quit IRC
1652018-12-12T07:31:44 *** shesek has joined #bitcoin-core-dev
1662018-12-12T07:32:36 *** shesek has quit IRC
1672018-12-12T07:34:04 *** shesek has joined #bitcoin-core-dev
1682018-12-12T07:35:39 *** promag has quit IRC
1692018-12-12T07:39:57 *** dviola has quit IRC
1702018-12-12T07:46:00 *** shesek has quit IRC
1712018-12-12T07:46:28 *** shesek has joined #bitcoin-core-dev
1722018-12-12T07:49:18 *** grubles has quit IRC
1732018-12-12T07:51:02 *** shesek has quit IRC
1742018-12-12T07:51:45 *** Murch has joined #bitcoin-core-dev
1752018-12-12T07:51:47 *** shesek has joined #bitcoin-core-dev
1762018-12-12T07:51:47 *** shesek has joined #bitcoin-core-dev
1772018-12-12T07:53:45 *** sipa has quit IRC
1782018-12-12T07:54:05 *** sipa has joined #bitcoin-core-dev
1792018-12-12T07:59:52 <provoostenator> I found that for Gitian building 0.17.1 of the Windows signer binary it's necessary to use gitian-builder.py from the 0.17 branch, not from master. Or it starts complaining about file names.
1802018-12-12T08:00:04 *** grubles has joined #bitcoin-core-dev
1812018-12-12T08:02:35 <provoostenator> For signing stuff on your local machine (instead of inside the VM) and pushing to Github, this maybe useful: https://github.com/bitcoin-core/docs/issues/18#issue-292936112
1822018-12-12T08:10:18 *** Murch has quit IRC
1832018-12-12T08:15:08 *** Krellan has joined #bitcoin-core-dev
1842018-12-12T08:18:16 *** shesek has quit IRC
1852018-12-12T08:20:01 *** rh0nj has quit IRC
1862018-12-12T08:20:15 *** shesek has joined #bitcoin-core-dev
1872018-12-12T08:20:19 <wumpus> provoostenator: I think the idea to use the gitian-builder from the branch you're building
1882018-12-12T08:21:10 *** shesek has quit IRC
1892018-12-12T08:22:28 <provoostenator> The currently instructions tell you to copy gitian-builder during the setup phase, but are unclear on what to do after. Always using the one from the release branch makes sense.
1902018-12-12T08:23:37 <provoostenator> Maybe it should do a diff against bitcoin/contrib/gitian-builder.py after it checks out the branch and then prompt the user.
1912018-12-12T08:24:09 *** bitcoin-git has joined #bitcoin-core-dev
1922018-12-12T08:24:09 <bitcoin-git> [bitcoin] hebasto closed pull request #14905: scripted-diff: Replace deprecated C headers (master...20181209-replace-c-headers) https://github.com/bitcoin/bitcoin/pull/14905
1932018-12-12T08:24:09 *** bitcoin-git has left #bitcoin-core-dev
1942018-12-12T08:32:25 *** Zenton has quit IRC
1952018-12-12T08:57:02 *** fanquake has joined #bitcoin-core-dev
1962018-12-12T09:06:46 *** nelsonhb has joined #bitcoin-core-dev
1972018-12-12T09:09:59 *** drexl has quit IRC
1982018-12-12T09:09:59 *** bitcoin-git has joined #bitcoin-core-dev
1992018-12-12T09:09:59 <bitcoin-git> [bitcoin] Sjors opened pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
2002018-12-12T09:09:59 *** bitcoin-git has left #bitcoin-core-dev
2012018-12-12T09:25:13 *** timothy has joined #bitcoin-core-dev
2022018-12-12T09:45:55 *** promag has joined #bitcoin-core-dev
2032018-12-12T09:47:56 *** hebasto has joined #bitcoin-core-dev
2042018-12-12T09:49:31 <promag> hebasto: are you able to test #14573 in windows?
2052018-12-12T09:49:33 <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
2062018-12-12T09:51:03 <hebasto> promag: unfortunately, no
2072018-12-12T09:51:18 <promag> ok ty
2082018-12-12T10:04:40 *** Zenton has joined #bitcoin-core-dev
2092018-12-12T10:14:04 <meshcollider> promag: I can test it on windows tomorrow
2102018-12-12T10:14:17 <promag> ok cool :)
2112018-12-12T10:14:38 <fanquake> meshcollider which version/s?
2122018-12-12T10:23:20 *** shesek has joined #bitcoin-core-dev
2132018-12-12T10:23:20 *** shesek has joined #bitcoin-core-dev
2142018-12-12T10:31:02 *** shesek` has joined #bitcoin-core-dev
2152018-12-12T10:32:58 *** shesek has quit IRC
2162018-12-12T10:33:01 *** shesek` has joined #bitcoin-core-dev
2172018-12-12T10:36:41 *** shesek` has quit IRC
2182018-12-12T10:37:38 *** shesek` has joined #bitcoin-core-dev
2192018-12-12T10:39:02 <promag> well, regargding 14573, details on windows can be improved in a separate PR to avoid invalidating existing acks
2202018-12-12T10:40:35 <meshcollider> fanquake: windows 10
2212018-12-12T10:44:08 *** spinza has quit IRC
2222018-12-12T10:50:36 *** spinza has joined #bitcoin-core-dev
2232018-12-12T10:52:34 *** shesek` has quit IRC
2242018-12-12T10:53:57 *** shesek` has joined #bitcoin-core-dev
2252018-12-12T10:55:08 *** shesek` has quit IRC
2262018-12-12T10:57:17 *** shesek has joined #bitcoin-core-dev
2272018-12-12T10:57:17 *** shesek has joined #bitcoin-core-dev
2282018-12-12T10:57:27 *** miknotauro has quit IRC
2292018-12-12T11:21:45 *** shesek has quit IRC
2302018-12-12T11:22:35 *** shesek has joined #bitcoin-core-dev
2312018-12-12T11:28:59 <wumpus> what's with the appveyor failures?
2322018-12-12T11:29:21 <wumpus> oh nm, it's only on some PRs
2332018-12-12T11:29:30 <fanquake> more than usual?
2342018-12-12T11:29:37 <wumpus> no, I don't think so :<
2352018-12-12T11:29:52 <fanquake> Probably just need rebasing after a test fix?
2362018-12-12T11:34:44 *** shesek has quit IRC
2372018-12-12T11:35:47 *** shesek has joined #bitcoin-core-dev
2382018-12-12T11:35:47 *** shesek has joined #bitcoin-core-dev
2392018-12-12T11:53:11 *** shesek has quit IRC
2402018-12-12T11:54:27 *** shesek has joined #bitcoin-core-dev
2412018-12-12T12:02:09 *** rh0nj has joined #bitcoin-core-dev
2422018-12-12T12:10:01 <promag> wumpus: nothing related with #14670 right?
2432018-12-12T12:10:04 <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
2442018-12-12T12:10:20 *** shesek has quit IRC
2452018-12-12T12:10:37 <wumpus> promag: nope
2462018-12-12T12:10:39 *** shesek has joined #bitcoin-core-dev
2472018-12-12T12:10:39 *** shesek has joined #bitcoin-core-dev
2482018-12-12T12:15:17 *** shesek has quit IRC
2492018-12-12T12:16:39 *** shesek has joined #bitcoin-core-dev
2502018-12-12T12:21:35 *** shesek has quit IRC
2512018-12-12T12:22:33 *** shesek has joined #bitcoin-core-dev
2522018-12-12T12:25:24 *** shesek has quit IRC
2532018-12-12T12:29:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2542018-12-12T12:30:11 *** shesek has joined #bitcoin-core-dev
2552018-12-12T12:33:37 *** shesek has quit IRC
2562018-12-12T12:34:33 *** shesek has joined #bitcoin-core-dev
2572018-12-12T12:34:33 *** shesek has joined #bitcoin-core-dev
2582018-12-12T12:35:42 *** AaronvanW has joined #bitcoin-core-dev
2592018-12-12T12:38:33 *** shesek has quit IRC
2602018-12-12T12:39:59 *** shesek has joined #bitcoin-core-dev
2612018-12-12T12:39:59 *** shesek has joined #bitcoin-core-dev
2622018-12-12T12:42:31 *** shesek has quit IRC
2632018-12-12T12:43:25 *** shesek has joined #bitcoin-core-dev
2642018-12-12T12:46:54 <fanquake> wumpus I'm happy for 14909 to just go in without the other additions
2652018-12-12T12:47:55 *** shesek has quit IRC
2662018-12-12T12:49:35 *** shesek has joined #bitcoin-core-dev
2672018-12-12T12:49:35 *** shesek has joined #bitcoin-core-dev
2682018-12-12T12:50:28 *** bitcoin-git has joined #bitcoin-core-dev
2692018-12-12T12:50:29 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed2a2cebd362...96bde4f01f41
2702018-12-12T12:50:29 <bitcoin-git> bitcoin/master b7bee6a fanquake: doc: Update minimum required qt
2712018-12-12T12:50:30 <bitcoin-git> bitcoin/master 96bde4f Wladimir J. van der Laan: Merge #14909: doc: Update minimum required Qt...
2722018-12-12T12:50:30 *** bitcoin-git has left #bitcoin-core-dev
2732018-12-12T12:51:24 *** bitcoin-git has joined #bitcoin-core-dev
2742018-12-12T12:51:25 <bitcoin-git> [bitcoin] laanwj closed pull request #14909: doc: Update minimum required Qt (master...doc-qt-minimum-52) https://github.com/bitcoin/bitcoin/pull/14909
2752018-12-12T12:51:25 *** bitcoin-git has left #bitcoin-core-dev
2762018-12-12T12:56:36 <fanquake> wumpus also happy for #14701 to go in as is
2772018-12-12T12:56:38 <gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
2782018-12-12T12:57:27 *** Chris_Stewart_5 has quit IRC
2792018-12-12T13:01:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2802018-12-12T13:02:50 *** promag has quit IRC
2812018-12-12T13:07:55 *** shesek has quit IRC
2822018-12-12T13:09:52 *** shesek has joined #bitcoin-core-dev
2832018-12-12T13:22:26 <fanquake> Would be interested to know if there are many/any? users running Bitcoin-Core on Windows Vista. Could use some more input in #14922.
2842018-12-12T13:22:27 <gribble> https://github.com/bitcoin/bitcoin/issues/14922 | windows: Set _WIN32_WINNT to 0x0600 (Windows Vista) by ken2812221 · Pull Request #14922 · bitcoin/bitcoin · GitHub
2852018-12-12T13:23:08 <fanquake> The 0.17.0.1 release binaries "seem" to work on Vista, but Qt dropped official support in 5.6, so I'd assume it's only a matter of time before they stop working.
2862018-12-12T13:44:12 *** bitcoin-git has joined #bitcoin-core-dev
2872018-12-12T13:44:12 <bitcoin-git> [bitcoin] practicalswift opened pull request #14935: tests: Test for expected return values when calling functions returning a success code (master...test-return-values) https://github.com/bitcoin/bitcoin/pull/14935
2882018-12-12T13:44:12 *** bitcoin-git has left #bitcoin-core-dev
2892018-12-12T13:47:41 *** promag has joined #bitcoin-core-dev
2902018-12-12T13:48:48 *** spinza has quit IRC
2912018-12-12T13:51:51 *** spinza has joined #bitcoin-core-dev
2922018-12-12T13:55:10 *** shesek has quit IRC
2932018-12-12T13:55:15 <timothy> fanquake: Microsoft deprecated support for Vista more than 1 years ago
2942018-12-12T13:55:27 <timothy> do you REALLY want to run something like bitcoin on an unsupported OS?
2952018-12-12T13:55:43 *** shesek has joined #bitcoin-core-dev
2962018-12-12T13:56:11 *** tryphe has quit IRC
2972018-12-12T13:56:35 *** tryphe has joined #bitcoin-core-dev
2982018-12-12T13:58:33 <fanquake> timothy nope, which is why I've suggested we increase our minimum supported version of Windows to Windows 7 in 0.18.0
2992018-12-12T14:00:29 *** nelsonhb has quit IRC
3002018-12-12T14:02:55 *** shesek has quit IRC
3012018-12-12T14:03:28 *** shesek has joined #bitcoin-core-dev
3022018-12-12T14:09:02 *** shesek has quit IRC
3032018-12-12T14:09:28 *** shesek has joined #bitcoin-core-dev
3042018-12-12T14:17:57 *** ghost43 has quit IRC
3052018-12-12T14:18:46 *** ghost43 has joined #bitcoin-core-dev
3062018-12-12T14:22:01 *** shesek has quit IRC
3072018-12-12T14:22:22 *** shesek has joined #bitcoin-core-dev
3082018-12-12T14:30:14 *** Guyver2 has joined #bitcoin-core-dev
3092018-12-12T14:30:46 *** Guyver2 has quit IRC
3102018-12-12T14:30:58 *** Guyver2 has joined #bitcoin-core-dev
3112018-12-12T14:36:47 *** wxss has joined #bitcoin-core-dev
3122018-12-12T14:58:04 <promag> sipa: about #14565
3132018-12-12T14:58:08 <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
3142018-12-12T14:59:04 <promag> after this should it have support for "all or nothing" import?
3152018-12-12T15:02:22 *** tripleslash has quit IRC
3162018-12-12T15:04:07 *** tripleslash has joined #bitcoin-core-dev
3172018-12-12T15:04:58 *** shesek has quit IRC
3182018-12-12T15:10:49 <provoostenator> I suggested in the comments to have a warning==error option, which would have that effect, at least for stuff we can detect in advance.
3192018-12-12T15:12:18 <provoostenator> No actually it would still be a per entry thing.
3202018-12-12T15:14:09 <promag> right
3212018-12-12T15:17:11 <promag> let me rephrase my question, after 14565, should we _add_ support for "all or nothing"?
3222018-12-12T15:19:52 <wumpus> fanquake: probably better to ask on twitter or reddit, but no, I don't think anyone is still using vista, it was extremely unpopular even at the time
3232018-12-12T15:20:15 <wumpus> +indeed, as timothy says, using an unsupported OS for bitcoin is kind of stupid
3242018-12-12T15:21:03 <wumpus> windows 7 is still used intentionally by some people (that dislike windows 10) so setting that as the baseline supported version would make sense, imo
3252018-12-12T15:22:21 <fanquake> wumpus fair enough. If you agree with my comments here, https://github.com/bitcoin/bitcoin/pull/14922#issuecomment-446585696, I'll add that to 0.18.0 and ask ken to update (including docs).
3262018-12-12T15:25:39 *** bitcoin-git has joined #bitcoin-core-dev
3272018-12-12T15:25:40 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96bde4f01f41...edc2822b9dc9
3282018-12-12T15:25:40 <bitcoin-git> bitcoin/master 8e20934 fanquake: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString
3292018-12-12T15:25:41 <bitcoin-git> bitcoin/master edc2822 Wladimir J. van der Laan: Merge #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString...
3302018-12-12T15:25:41 *** bitcoin-git has left #bitcoin-core-dev
3312018-12-12T15:26:10 <promag> looks like XP > vista
3322018-12-12T15:26:37 *** bitcoin-git has joined #bitcoin-core-dev
3332018-12-12T15:26:37 <bitcoin-git> [bitcoin] laanwj closed pull request #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (master...add-build-version-to-info-plist) https://github.com/bitcoin/bitcoin/pull/14701
3342018-12-12T15:26:37 *** bitcoin-git has left #bitcoin-core-dev
3352018-12-12T15:27:51 <wumpus> fanquake: I agree
3362018-12-12T15:37:28 *** drexl has joined #bitcoin-core-dev
3372018-12-12T15:40:25 *** drexl has quit IRC
3382018-12-12T15:53:17 *** michaelsdunn1 has joined #bitcoin-core-dev
3392018-12-12T16:03:01 *** rh0nj has quit IRC
3402018-12-12T16:04:07 *** rh0nj has joined #bitcoin-core-dev
3412018-12-12T16:17:18 <promag> IMO #14914 is ready
3422018-12-12T16:17:21 <gribble> https://github.com/bitcoin/bitcoin/issues/14914 | Docs: Add nice table to files.md by emilengler · Pull Request #14914 · bitcoin/bitcoin · GitHub
3432018-12-12T16:20:23 *** wxss_ has joined #bitcoin-core-dev
3442018-12-12T16:23:20 *** wxss has quit IRC
3452018-12-12T16:29:53 *** lopp has joined #bitcoin-core-dev
3462018-12-12T16:30:31 *** Tralfaz has joined #bitcoin-core-dev
3472018-12-12T16:31:10 *** Victorsueca has quit IRC
3482018-12-12T16:31:34 *** Tralfaz has quit IRC
3492018-12-12T16:33:15 *** Tralfaz has joined #bitcoin-core-dev
3502018-12-12T16:36:27 *** shesek has joined #bitcoin-core-dev
3512018-12-12T16:36:27 *** shesek has joined #bitcoin-core-dev
3522018-12-12T16:36:35 *** Tralfaz has joined #bitcoin-core-dev
3532018-12-12T16:45:47 *** Murch has joined #bitcoin-core-dev
3542018-12-12T17:00:49 *** bitcoin-git has joined #bitcoin-core-dev
3552018-12-12T17:00:49 <bitcoin-git> [bitcoin] ken2812221 opened pull request #14937: travis: fix travis would always be green even if it fail (master...travis-fix-save-cache-2) https://github.com/bitcoin/bitcoin/pull/14937
3562018-12-12T17:00:49 *** bitcoin-git has left #bitcoin-core-dev
3572018-12-12T17:02:48 *** bitcoin-git has joined #bitcoin-core-dev
3582018-12-12T17:02:48 <bitcoin-git> [bitcoin] Sjors opened pull request #14938: Support creating an empty wallet (master...2018/12/create-empty-wallet) https://github.com/bitcoin/bitcoin/pull/14938
3592018-12-12T17:02:48 *** bitcoin-git has left #bitcoin-core-dev
3602018-12-12T17:03:13 *** drexl has joined #bitcoin-core-dev
3612018-12-12T17:07:08 *** Tralfaz has quit IRC
3622018-12-12T17:07:49 *** bitcoin-git has joined #bitcoin-core-dev
3632018-12-12T17:07:50 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc2822b9dc9...38fb1b40dfb3
3642018-12-12T17:07:50 <bitcoin-git> bitcoin/master 9b51b15 Emil Engler: Add nice table to files.md...
3652018-12-12T17:07:51 <bitcoin-git> bitcoin/master 38fb1b4 Wladimir J. van der Laan: Merge #14914: Docs: Add nice table to files.md...
3662018-12-12T17:07:51 *** bitcoin-git has left #bitcoin-core-dev
3672018-12-12T17:07:57 *** Tralfaz has joined #bitcoin-core-dev
3682018-12-12T17:08:54 *** bitcoin-git has joined #bitcoin-core-dev
3692018-12-12T17:08:54 <bitcoin-git> [bitcoin] laanwj closed pull request #14914: Docs: Add nice table to files.md (master...add-nice-table) https://github.com/bitcoin/bitcoin/pull/14914
3702018-12-12T17:08:54 *** bitcoin-git has left #bitcoin-core-dev
3712018-12-12T17:19:52 *** Tralfaz has quit IRC
3722018-12-12T17:20:40 *** Tralfaz has joined #bitcoin-core-dev
3732018-12-12T17:27:27 *** Victorsueca has joined #bitcoin-core-dev
3742018-12-12T17:35:24 *** bitcoin-git has joined #bitcoin-core-dev
3752018-12-12T17:35:25 <bitcoin-git> [bitcoin] lontivero opened pull request #14939: rpc: Add test_accept_unsigned flag to testmempoolaccept (master...TestAcceptanceForUnsignedTransactions) https://github.com/bitcoin/bitcoin/pull/14939
3762018-12-12T17:35:25 *** bitcoin-git has left #bitcoin-core-dev
3772018-12-12T17:36:57 *** q-ask has joined #bitcoin-core-dev
3782018-12-12T17:37:17 *** q-ask has left #bitcoin-core-dev
3792018-12-12T17:48:18 *** Guest73299 has joined #bitcoin-core-dev
3802018-12-12T17:48:48 *** Guest73299 has quit IRC
3812018-12-12T17:49:14 *** Geekingfrog25 has joined #bitcoin-core-dev
3822018-12-12T17:50:42 *** millerti has joined #bitcoin-core-dev
3832018-12-12T17:53:38 *** bitcoin-git has joined #bitcoin-core-dev
3842018-12-12T17:53:39 <bitcoin-git> [bitcoin] mrwhythat closed pull request #14476: RPC method 'encodescript' (master...encodescript-rpc) https://github.com/bitcoin/bitcoin/pull/14476
3852018-12-12T17:53:39 *** bitcoin-git has left #bitcoin-core-dev
3862018-12-12T18:03:51 *** fanquake has quit IRC
3872018-12-12T18:22:30 *** Chris_Stewart_5 has quit IRC
3882018-12-12T18:26:55 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3892018-12-12T18:46:53 *** wernie has joined #bitcoin-core-dev
3902018-12-12T18:49:58 *** timothy has quit IRC
3912018-12-12T18:50:42 *** shesek has quit IRC
3922018-12-12T18:51:10 *** shesek has joined #bitcoin-core-dev
3932018-12-12T18:53:07 *** shesek has joined #bitcoin-core-dev
3942018-12-12T18:56:25 *** shesek has quit IRC
3952018-12-12T18:58:23 *** miknotauro has joined #bitcoin-core-dev
3962018-12-12T19:00:13 *** wernie has quit IRC
3972018-12-12T19:01:45 *** shesek has joined #bitcoin-core-dev
3982018-12-12T19:01:45 *** shesek has joined #bitcoin-core-dev
3992018-12-12T19:03:20 *** shesek has quit IRC
4002018-12-12T19:11:47 *** shesek has joined #bitcoin-core-dev
4012018-12-12T19:11:48 *** shesek has quit IRC
4022018-12-12T19:11:48 *** shesek has joined #bitcoin-core-dev
4032018-12-12T19:15:36 *** shesek has quit IRC
4042018-12-12T19:16:53 *** shesek has joined #bitcoin-core-dev
4052018-12-12T19:54:29 *** hebasto has quit IRC
4062018-12-12T20:03:02 *** rh0nj has quit IRC
4072018-12-12T20:03:50 *** sturles has quit IRC
4082018-12-12T20:04:57 *** sturles has joined #bitcoin-core-dev
4092018-12-12T20:08:14 *** miknotauro has quit IRC
4102018-12-12T20:10:08 *** rh0nj has joined #bitcoin-core-dev
4112018-12-12T20:12:07 *** rh0nj has joined #bitcoin-core-dev
4122018-12-12T20:25:12 *** AaronvanW has quit IRC
4132018-12-12T20:25:43 *** AaronvanW has joined #bitcoin-core-dev
4142018-12-12T20:30:27 *** jarthur has joined #bitcoin-core-dev
4152018-12-12T20:49:56 *** shesek has quit IRC
4162018-12-12T20:52:13 *** shesek has joined #bitcoin-core-dev
4172018-12-12T20:54:25 *** miknotauro has joined #bitcoin-core-dev
4182018-12-12T20:55:02 *** spinza has quit IRC
4192018-12-12T21:08:27 *** spinza has joined #bitcoin-core-dev
4202018-12-12T21:09:01 *** jarthur has quit IRC
4212018-12-12T21:09:48 *** drexl has quit IRC
4222018-12-12T21:29:20 *** bitcoinjunior has joined #bitcoin-core-dev
4232018-12-12T21:30:24 *** miknotauro has quit IRC
4242018-12-12T21:39:52 *** jarthur has joined #bitcoin-core-dev
4252018-12-12T21:45:35 *** promag has quit IRC
4262018-12-12T21:46:11 *** exekias6 has joined #bitcoin-core-dev
4272018-12-12T21:49:33 *** wxss has joined #bitcoin-core-dev
4282018-12-12T21:49:45 *** promag has joined #bitcoin-core-dev
4292018-12-12T21:50:26 *** wxss_ has quit IRC
4302018-12-12T22:00:39 *** wxss_ has joined #bitcoin-core-dev
4312018-12-12T22:03:07 *** shesek has quit IRC
4322018-12-12T22:03:30 *** wxss has quit IRC
4332018-12-12T22:03:45 *** shesek has joined #bitcoin-core-dev
4342018-12-12T22:07:00 *** shesek has joined #bitcoin-core-dev
4352018-12-12T22:12:33 *** miknotauro has joined #bitcoin-core-dev
4362018-12-12T22:15:31 *** wxss_ has quit IRC
4372018-12-12T22:16:15 *** wxss has joined #bitcoin-core-dev
4382018-12-12T22:19:52 *** spinza has quit IRC
4392018-12-12T22:23:02 *** spinza has joined #bitcoin-core-dev
4402018-12-12T22:23:06 *** karelb_ has joined #bitcoin-core-dev
4412018-12-12T22:23:15 *** moneyball_ has joined #bitcoin-core-dev
4422018-12-12T22:23:16 *** michaelsdunn1 has quit IRC
4432018-12-12T22:23:26 *** Varunram_ has joined #bitcoin-core-dev
4442018-12-12T22:23:42 *** michaelsdunn1 has joined #bitcoin-core-dev
4452018-12-12T22:25:50 *** dlb76_ has joined #bitcoin-core-dev
4462018-12-12T22:27:55 <andytoshi> sipa: i'm confused by https://github.com/bitcoin/bitcoin/pull/13191 ... it seems the new SHA256D64 does not append the sha256 length/padding anywhere, so how can `ComputeMerkleRoot` be consensus-compatible with the old code?
4472018-12-12T22:28:09 <andytoshi> i assume i'm just being dumb/blind
4482018-12-12T22:28:59 <gmaxwell> andytoshi: the length/padding is hardcoded into it.
4492018-12-12T22:29:12 <gmaxwell> (because the length is fixed)
4502018-12-12T22:29:26 *** Varunram has quit IRC
4512018-12-12T22:29:26 *** karelb has quit IRC
4522018-12-12T22:29:26 *** dlb76 has quit IRC
4532018-12-12T22:29:29 *** belcher has quit IRC
4542018-12-12T22:29:34 *** nsh has quit IRC
4552018-12-12T22:29:34 *** moneyball has quit IRC
4562018-12-12T22:29:34 *** rex4539 has quit IRC
4572018-12-12T22:29:35 *** Varunram_ is now known as Varunram
4582018-12-12T22:29:35 *** moneyball_ is now known as moneyball
4592018-12-12T22:29:35 *** karelb_ is now known as karelb
4602018-12-12T22:29:35 <andytoshi> isn't it 512 * `blocks` ?
4612018-12-12T22:29:44 *** Randolf has joined #bitcoin-core-dev
4622018-12-12T22:29:56 <sipa> andytoshi: it can only hash 64-byte inputs
4632018-12-12T22:30:14 <gmaxwell> thats what the D64 means.
4642018-12-12T22:30:24 <andytoshi> what does the `blocks` argument mean then?
4652018-12-12T22:30:28 <sipa> andytoshi: the 'blocks' is how many double-SHA256-on-64-byte-inputs are being computed *in parallel*
4662018-12-12T22:30:32 <andytoshi> ah!
4672018-12-12T22:30:33 <andytoshi> thank yuo
4682018-12-12T22:30:46 <andytoshi> ah yeah, suddenly the code makes sense :P
4692018-12-12T22:31:41 *** belcher has joined #bitcoin-core-dev
4702018-12-12T22:33:01 <gmaxwell> the speedup in this code over boring code comes mostly from hardcoding the lengths and padding, and in doing so elimiating the related expander rounds.
4712018-12-12T22:33:28 <gmaxwell> (both from the 64 byte input and the 32byte inter-stage input)
4722018-12-12T22:33:33 <sipa> and from using SSE4/AVX2 to compute 4 or 8 of them in parallel
4732018-12-12T22:33:54 <gmaxwell> whered that patch using avx512 to do 16 in parallel go? :P
4742018-12-12T22:34:09 <andytoshi> ok. the reason i ask is that in Elements we are directly using sha2 midstates to get the same speedup (which ofc changes the hash function so is completely incompatible with bitcoin)
4752018-12-12T22:34:19 <andytoshi> and we're trying to rebase on #13191 and deciding the best course of action
4762018-12-12T22:34:22 <gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub
4772018-12-12T22:34:29 <sipa> https://github.com/bitcoin/bitcoin/pull/13989/files
4782018-12-12T22:34:44 <gmaxwell> andytoshi: really? midstates, yuck. :P
4792018-12-12T22:35:21 <andytoshi> gmaxwell: yes, yuck :P
4802018-12-12T22:36:47 <gmaxwell> welp if you're not using SHA256D64 you can't use that code... it could be adapted to not include the length by changing some constants.
4812018-12-12T22:37:16 <andytoshi> yep, that's what i'm concluding. thanks. probably we'll just keep our hacky midstate code and switch to SHA256D64 at the next hf opportunity
4822018-12-12T22:37:17 *** dlb76_ is now known as dlb76
4832018-12-12T22:37:20 *** dlb76 has joined #bitcoin-core-dev
4842018-12-12T22:37:23 <gmaxwell> is what elements does SHA256D64 that just doesn't run the second compression function run?
4852018-12-12T22:37:30 <andytoshi> gmaxwell: correct
4862018-12-12T22:37:49 <gmaxwell> yes, then it could be adapted with some work. it would be somewhat faster than this code.
4872018-12-12T22:38:21 *** Guyver2 has quit IRC
4882018-12-12T22:38:52 <andytoshi> hmm, ok, maybe it's worth doing that work. though i'm uncomfortable enough with our effectively-homebrew hash function already without trying to optimize it :)
4892018-12-12T22:39:53 <promag> should running with -wallet=xxx be an error if it's configured with --disable-wallet?
4902018-12-12T22:40:13 <gmaxwell> andytoshi: well fortunately if you get it wrong it probably just won't work. :P
4912018-12-12T22:40:32 <andytoshi> hehe, this is true
4922018-12-12T22:40:34 *** nsh has joined #bitcoin-core-dev
4932018-12-12T22:40:57 <gmaxwell> promag: hm in one sense, sure, but "I compiled differently and now I get an error on my config files" is not great.
4942018-12-12T22:41:10 <promag> right, because config file
4952018-12-12T22:41:23 <gmaxwell> promag: logging -wallet ignored due to ... is probably a reasonable middle ground, I dunno if we do that now.
4962018-12-12T22:59:15 <promag> is there a long call like waitforblock but that holds a wallet?
4972018-12-12T23:00:19 <sipa> i don't think so
4982018-12-12T23:03:09 <tryphe> gmaxwell, it would be similar to setting some mempool options along with a "blocksonly=1" line in the config. one could uncomment the single "blocksonly=1" line to have the mempool options take effect. similar to commenting/uncommenting a "disable-wallet=1" line while having wallet= set.
4992018-12-12T23:04:20 <tryphe> gmaxwell, uncomment=comment*, but you get the idea :)
5002018-12-12T23:04:41 <sipa> tryphe: the difference is that with --disable-wallet, the wallet related code isn't even compiled in, so there would naively not be anything that can recognize those wallet lines as something meaningful in other configurations
5012018-12-12T23:05:11 <tryphe> sipa, this is a good point
5022018-12-12T23:07:18 <gmaxwell> the reason in favor of erroring on non-sensible configs is because silently giving the user something different than what they asked for isn't nice, and they might bash their head against a wall trying to figure out why it doesn't work because they didn't notice the other parameter.
5032018-12-12T23:07:37 <gmaxwell> I generally prefer to log -- unless the interaction is one that if uncaught could cause funds loss.
5042018-12-12T23:08:00 <gmaxwell> they'll find the log sometime between the third and fourth hour of troubleshooting. :P
5052018-12-12T23:08:21 *** wxss has quit IRC
5062018-12-12T23:16:18 *** Tralfaz has quit IRC
5072018-12-12T23:19:03 *** drexl has joined #bitcoin-core-dev
5082018-12-12T23:27:45 <promag> review beg #14641
5092018-12-12T23:27:47 <gribble> https://github.com/bitcoin/bitcoin/issues/14641 | rpc: Add min_conf option to fund transaction calls by promag · Pull Request #14641 · bitcoin/bitcoin · GitHub
5102018-12-12T23:28:07 *** Randolf has quit IRC
5112018-12-12T23:34:06 *** jarthur has quit IRC
5122018-12-12T23:36:45 *** bitcoinjunior has quit IRC
5132018-12-12T23:39:31 <promag> gmaxwell: are you suggesting to not apply min_conf to ismine utxo?
5142018-12-12T23:41:03 *** shesek has quit IRC
5152018-12-12T23:41:22 *** shesek has joined #bitcoin-core-dev
5162018-12-12T23:42:04 *** kmels has quit IRC
5172018-12-12T23:42:32 *** brianhoffman_ has joined #bitcoin-core-dev
5182018-12-12T23:42:39 *** tryphe_ has joined #bitcoin-core-dev
5192018-12-12T23:45:28 *** brianhoffman has quit IRC
5202018-12-12T23:45:29 *** brianhoffman_ is now known as brianhoffman
5212018-12-12T23:46:05 *** tryphe has quit IRC
5222018-12-12T23:48:26 *** tryphe_ is now known as tryphe