12019-01-02T00:03:43 *** user420 has quit IRC
22019-01-02T00:05:02 *** user420 has joined #bitcoin-core-dev
32019-01-02T00:06:50 *** promag has joined #bitcoin-core-dev
42019-01-02T00:13:00 *** jcorgan_ has joined #bitcoin-core-dev
52019-01-02T00:15:52 *** jcorgan has quit IRC
62019-01-02T00:16:58 *** promag has quit IRC
72019-01-02T00:19:37 *** Krellan has joined #bitcoin-core-dev
82019-01-02T00:30:07 *** Zenton has quit IRC
92019-01-02T00:47:32 *** cluelessperson has quit IRC
102019-01-02T01:12:26 *** cryptapus has quit IRC
112019-01-02T01:12:53 *** cryptapus has joined #bitcoin-core-dev
122019-01-02T01:38:22 *** CodeBlue1776 has quit IRC
132019-01-02T01:38:43 *** CodeBlue1776 has joined #bitcoin-core-dev
142019-01-02T01:46:46 *** roidster has joined #bitcoin-core-dev
152019-01-02T01:50:47 *** bitcoin-git has joined #bitcoin-core-dev
162019-01-02T01:50:48 <bitcoin-git> [bitcoin] ken2812221 closed pull request #14922: [WIP] windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
172019-01-02T01:50:48 *** bitcoin-git has left #bitcoin-core-dev
182019-01-02T02:05:15 *** roidster has quit IRC
192019-01-02T02:26:49 *** user420 has quit IRC
202019-01-02T02:32:58 *** EagleTM has quit IRC
212019-01-02T02:51:22 *** AaronvanW has quit IRC
222019-01-02T02:52:40 *** th3_wizard has joined #bitcoin-core-dev
232019-01-02T02:55:56 *** grubles has quit IRC
242019-01-02T03:05:32 *** grubles has joined #bitcoin-core-dev
252019-01-02T03:08:27 *** CodeBlue1776 has quit IRC
262019-01-02T03:09:17 *** CodeBlue1776 has joined #bitcoin-core-dev
272019-01-02T03:45:23 *** bitcoin-git has joined #bitcoin-core-dev
282019-01-02T03:45:24 <bitcoin-git> [bitcoin] MeshCollider pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f5a70d146259...4f041ba14f68
292019-01-02T03:45:24 <bitcoin-git> bitcoin/master b60ac00 Antti Majakivi: Botbot.me (IRC logs) not available anymore...
302019-01-02T03:45:25 <bitcoin-git> bitcoin/master 4f041ba MeshCollider: Merge #15073: docs: Botbot.me (IRC logs) not available anymore...
312019-01-02T03:45:25 *** bitcoin-git has left #bitcoin-core-dev
322019-01-02T03:46:07 *** bitcoin-git has joined #bitcoin-core-dev
332019-01-02T03:46:07 <bitcoin-git> [bitcoin] MeshCollider closed pull request #15073: docs: Botbot.me (IRC logs) not available anymore (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15073
342019-01-02T03:46:07 *** bitcoin-git has left #bitcoin-core-dev
352019-01-02T04:03:01 *** rh0nj has quit IRC
362019-01-02T04:04:07 *** rh0nj has joined #bitcoin-core-dev
372019-01-02T04:31:18 *** spinza has quit IRC
382019-01-02T04:42:38 *** spinza has joined #bitcoin-core-dev
392019-01-02T04:43:48 *** Emcy has quit IRC
402019-01-02T05:25:14 *** mistergold has joined #bitcoin-core-dev
412019-01-02T05:55:35 *** Emcy has joined #bitcoin-core-dev
422019-01-02T06:28:05 *** rex4539 has joined #bitcoin-core-dev
432019-01-02T06:36:19 *** cluelessperson has joined #bitcoin-core-dev
442019-01-02T06:40:44 *** cluelessperson has quit IRC
452019-01-02T06:46:18 *** davec has quit IRC
462019-01-02T06:48:23 *** davec has joined #bitcoin-core-dev
472019-01-02T06:58:15 *** cluelessperson has joined #bitcoin-core-dev
482019-01-02T07:00:36 *** cluelessperson has quit IRC
492019-01-02T07:01:21 *** cluelessperson has joined #bitcoin-core-dev
502019-01-02T07:17:50 *** hebasto has joined #bitcoin-core-dev
512019-01-02T07:24:07 *** rex4539 has quit IRC
522019-01-02T07:27:32 *** TX1683 has quit IRC
532019-01-02T07:29:56 *** TX1683 has joined #bitcoin-core-dev
542019-01-02T08:05:02 *** rh0nj has quit IRC
552019-01-02T08:06:08 *** rh0nj has joined #bitcoin-core-dev
562019-01-02T08:14:45 *** Guyver2 has joined #bitcoin-core-dev
572019-01-02T08:20:40 *** rex4539 has joined #bitcoin-core-dev
582019-01-02T08:35:20 *** aqquadro has joined #bitcoin-core-dev
592019-01-02T08:47:48 *** Murch has joined #bitcoin-core-dev
602019-01-02T08:50:11 *** hebasto has quit IRC
612019-01-02T08:50:33 *** hebasto has joined #bitcoin-core-dev
622019-01-02T09:00:58 *** Guyver2 has quit IRC
632019-01-02T09:11:38 *** rex4539 has quit IRC
642019-01-02T09:24:42 *** Zenton has joined #bitcoin-core-dev
652019-01-02T09:40:20 *** belcher has quit IRC
662019-01-02T09:45:06 *** jungly has joined #bitcoin-core-dev
672019-01-02T09:50:19 *** bitcoin-git has joined #bitcoin-core-dev
682019-01-02T09:50:19 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15077: rpc: List all message types in getpeerinfo recv/send stats (master...Mf1812-netStats0) https://github.com/bitcoin/bitcoin/pull/15077
692019-01-02T09:50:19 *** bitcoin-git has left #bitcoin-core-dev
702019-01-02T09:52:54 *** bitcoin-git has joined #bitcoin-core-dev
712019-01-02T09:52:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4f041ba14f68...3ec4cc0a9e7c
722019-01-02T09:52:55 <bitcoin-git> bitcoin/master de23739 Ben Woosley: test: Fix rpc_net.py "pong" race condition...
732019-01-02T09:52:56 <bitcoin-git> bitcoin/master 3ec4cc0 MarcoFalke: Merge #15069: test: Fix rpc_net.py "pong" race condition...
742019-01-02T09:52:56 *** bitcoin-git has left #bitcoin-core-dev
752019-01-02T09:53:38 *** bitcoin-git has joined #bitcoin-core-dev
762019-01-02T09:53:38 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15069: test: Fix rpc_net.py "pong" race condition (master...rpc_net-race) https://github.com/bitcoin/bitcoin/pull/15069
772019-01-02T09:53:38 *** bitcoin-git has left #bitcoin-core-dev
782019-01-02T10:04:27 *** spinza has quit IRC
792019-01-02T10:06:08 *** timothy has joined #bitcoin-core-dev
802019-01-02T10:11:46 *** Murch has quit IRC
812019-01-02T10:11:51 *** spinza has joined #bitcoin-core-dev
822019-01-02T10:16:18 *** mistergold has quit IRC
832019-01-02T10:22:33 *** Murch has joined #bitcoin-core-dev
842019-01-02T10:31:47 *** EagleTM has joined #bitcoin-core-dev
852019-01-02T10:53:34 *** owowo has joined #bitcoin-core-dev
862019-01-02T11:02:18 *** promag has joined #bitcoin-core-dev
872019-01-02T11:03:25 <promag> happy 2019 everyone!
882019-01-02T11:04:00 <wumpus> thank you promag, same to you!
892019-01-02T11:04:11 <promag> ty
902019-01-02T11:04:31 <promag> I'm going to clean up 14982
912019-01-02T11:05:07 <promag> but then I'd like some review effort on #13100 after I update it
922019-01-02T11:05:10 <gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
932019-01-02T11:05:37 <promag> I think 0.18 _must_ have it
942019-01-02T11:07:07 <luke-jr> there are no "_must_ have" features <.<
952019-01-02T11:08:13 <wumpus> if it's ready by then then it should be merged...
962019-01-02T11:08:22 <luke-jr> sure, same as anything else
972019-01-02T11:09:40 <promag> true, but the "plan" as to have dynamic wallet via rpc on 0.17, then gui on 0.18
982019-01-02T11:09:46 <promag> *was
992019-01-02T11:10:05 <promag> but sure, if it's not ready..
1002019-01-02T11:10:41 *** EagleTM has quit IRC
1012019-01-02T11:14:12 *** rex4539 has joined #bitcoin-core-dev
1022019-01-02T11:26:18 *** mistergold has joined #bitcoin-core-dev
1032019-01-02T11:27:35 *** AaronvanW has joined #bitcoin-core-dev
1042019-01-02T11:37:02 *** setpill has joined #bitcoin-core-dev
1052019-01-02T11:40:40 *** bitcoin-git has joined #bitcoin-core-dev
1062019-01-02T11:40:41 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg (master...Mf1901-docRpcGetPeerInfo) https://github.com/bitcoin/bitcoin/pull/15078
1072019-01-02T11:40:41 *** bitcoin-git has left #bitcoin-core-dev
1082019-01-02T11:40:46 *** john__ has joined #bitcoin-core-dev
1092019-01-02T11:41:49 *** bitcoin-git has joined #bitcoin-core-dev
1102019-01-02T11:41:49 <bitcoin-git> [bitcoin] laanwj closed pull request #15031: Removing unnecessary comparison of size_t maxConfirms (master...maxConfirms) https://github.com/bitcoin/bitcoin/pull/15031
1112019-01-02T11:41:49 *** bitcoin-git has left #bitcoin-core-dev
1122019-01-02T11:44:34 <fanquake> wumpus in 15028, it's not your file that has gone missing
1132019-01-02T11:44:37 <fanquake> it's the one at http://strateman.ninja/fuzzing.tar.xz
1142019-01-02T11:45:27 <wumpus> fanquake: I see, sorry, misread
1152019-01-02T11:45:33 <wumpus> tagged phantomcircuit now
1162019-01-02T11:45:49 <MarcoFalke> I'd prefer to move to target-based seeds instead
1172019-01-02T11:46:12 <MarcoFalke> It is just a hassle to have only one type of seed for all targets
1182019-01-02T11:46:41 <MarcoFalke> It is hard to fuzz just one subtarget without modifying the code
1192019-01-02T11:47:47 <MarcoFalke> And if the modification is done in the wrong way and the fuzzer is instructed to discard seeds that don't increase the coverage, they are incorrectly lost
1202019-01-02T11:48:27 <MarcoFalke> See #15043
1212019-01-02T11:48:29 <gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
1222019-01-02T11:48:30 <wumpus> yes
1232019-01-02T11:48:51 <fanquake> marco are you testing 15047 on fedora/some linux?
1242019-01-02T11:49:05 <MarcoFalke> #15047
1252019-01-02T11:49:07 <gribble> https://github.com/bitcoin/bitcoin/issues/15047 | build: Allow to configure --with-sanitizers=fuzzer by MarcoFalke · Pull Request #15047 · bitcoin/bitcoin · GitHub
1262019-01-02T11:49:55 <MarcoFalke> It should work on any linux that has clang installed
1272019-01-02T11:50:48 <MarcoFalke> Though, the binaries such as `bitcoind` obviously don't link with the fuzzer
1282019-01-02T11:52:25 <MarcoFalke> I plan to improve the documentation later on
1292019-01-02T11:52:43 <MarcoFalke> After #15043
1302019-01-02T11:52:45 <gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
1312019-01-02T11:53:56 <MarcoFalke> With separate targets people could also easily contribute coverage for a specific target (without having to run meaningless serialization fuzzers or modify the code)
1322019-01-02T11:55:04 <MarcoFalke> I will maintain a repo for our fuzz seed corpus for that
1332019-01-02T12:00:22 <wumpus> putting the corpuses into a (separate) repo sounds like a good idea
1342019-01-02T12:00:25 *** Murch has quit IRC
1352019-01-02T12:01:52 <cjd> For cjdns, I used the first 4 bytes of the seed as the test id
1362019-01-02T12:02:35 <cjd> then I just made a bunch of files which were plausible data for each of the tests and started up AFL with all of them
1372019-01-02T12:02:54 *** th3_wizard has quit IRC
1382019-01-02T12:06:29 <cjd> I'm partial to the idea that every test which can plausibly make use of random data should use a fuzz api and then be reachable from AFL
1392019-01-02T12:12:46 <wumpus> we have the test id as part of the data now, the idea in 15043 is to move away from that as it's easier to manage
1402019-01-02T12:13:45 <wumpus> I don't have enough experience with fuzzing to have a strong opinion on that
1412019-01-02T12:15:14 *** bitcoin-git has joined #bitcoin-core-dev
1422019-01-02T12:15:14 <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ec4cc0a9e7c...62cf608e93f9
1432019-01-02T12:15:15 <bitcoin-git> bitcoin/master 1e6afd0 Patrick Strateman: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
1442019-01-02T12:15:15 <bitcoin-git> bitcoin/master 7e403c0 Patrick Strateman: Move GenerateSelectSet logic to private method....
1452019-01-02T12:15:16 <bitcoin-git> bitcoin/master 28211a4 Patrick Strateman: Move SocketEvents logic to private method....
1462019-01-02T12:15:16 *** bitcoin-git has left #bitcoin-core-dev
1472019-01-02T12:15:41 *** bitcoin-git has joined #bitcoin-core-dev
1482019-01-02T12:15:41 <bitcoin-git> [bitcoin] laanwj closed pull request #14336: net: implement poll (master...2018-09-24-socket-handler-poll) https://github.com/bitcoin/bitcoin/pull/14336
1492019-01-02T12:15:41 *** bitcoin-git has left #bitcoin-core-dev
1502019-01-02T12:16:12 <cjd> #15043
1512019-01-02T12:16:14 <gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
1522019-01-02T12:16:21 *** rex4539 has quit IRC
1532019-01-02T12:20:27 <cjd> "the fuzzer needs to "learn" how the fuzz targets are organized" I don't really understand this
1542019-01-02T12:22:33 <cjd> It seems that unless there is a significant cost to doing it this way (fuzzer has more difficulty finding new paths), the benefit of having one fuzz entry point for someone to point AFL at outweighs the cost of cross-test type pollution
1552019-01-02T12:22:46 *** Murch has joined #bitcoin-core-dev
1562019-01-02T12:23:34 <wumpus> that was something I've thought of mentioning too, it does seem easier to 'just fuzz' when there's one target
1572019-01-02T12:25:19 <wumpus> with separate executables it seems you need to have a specific target in mind
1582019-01-02T12:26:30 <cjd> I'll write my thoughts on github, as I am not in a position where I have to work with the bitcoin codebase every day so I don't want to impose, but I would like to raise a few questions as someone who does use this method
1592019-01-02T12:26:54 <wumpus> well it's good to have outside opionions on this imo
1602019-01-02T12:29:08 *** Murch has quit IRC
1612019-01-02T12:35:25 *** Murch has joined #bitcoin-core-dev
1622019-01-02T12:37:57 <cjd> BTW: one type of fuzzing which could potentially be very valuable for bitcoin is difference fuzzing.. create a test function which takes input and produces output and then use some linker trickery to allow linking 2 versions of bitcoin and invoking the function from each, if the output is different between the two then you got trouble
1632019-01-02T12:40:33 <wumpus> yes, that sounds useful
1642019-01-02T12:40:50 <wumpus> for the consensus code
1652019-01-02T12:43:46 <cjd> This is the function prototype which I created: https://github.com/cjdelisle/cjdns/blob/crashey/test/FuzzTest.h
1662019-01-02T12:44:09 <cjd> and one example of it being used: https://github.com/cjdelisle/cjdns/blob/crashey/benc/serialization/json/test/JsonBencMessageReader_fuzz_test.c
1672019-01-02T12:44:34 <cjd> my strategy is more to try to fit a fuzz case wherever I can imagine to, looking at any code which makes me even the slightest bit nervous
1682019-01-02T12:49:01 *** rh0nj has quit IRC
1692019-01-02T12:52:08 *** rh0nj has joined #bitcoin-core-dev
1702019-01-02T12:52:56 <promag> hebasto: hi, do you have the time to review #15065?
1712019-01-02T12:52:57 <gribble> https://github.com/bitcoin/bitcoin/issues/15065 | 0.17: GUI Backports #14123 #14133 #14383 #14597 by promag · Pull Request #15065 · bitcoin/bitcoin · GitHub
1722019-01-02T12:57:42 <fanquake> promag are those all clean backports?
1732019-01-02T12:58:17 <promag> there was only one change because of the SIGNAL/SLOT macros
1742019-01-02T12:59:09 <promag> here https://github.com/bitcoin/bitcoin/pull/15065/commits/27beb83
1752019-01-02T13:00:52 *** dviola has joined #bitcoin-core-dev
1762019-01-02T13:10:40 <fanquake> merged those changes ^ and qt wouldn't build
1772019-01-02T13:10:57 <fanquake> keep forgetting I'm unlinking protobuf now
1782019-01-02T13:16:45 *** bitcoin-git has joined #bitcoin-core-dev
1792019-01-02T13:16:46 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/62cf608e93f9...c3bb936a0f97
1802019-01-02T13:16:46 <bitcoin-git> bitcoin/master c9066f0 Kristaps Kaupe: Allow running rpc_bind.py --nonloopback test without IPv6
1812019-01-02T13:16:47 <bitcoin-git> bitcoin/master c3bb936 Wladimir J. van der Laan: Merge #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6...
1822019-01-02T13:16:47 *** bitcoin-git has left #bitcoin-core-dev
1832019-01-02T13:17:20 *** bitcoin-git has joined #bitcoin-core-dev
1842019-01-02T13:17:20 <bitcoin-git> [bitcoin] laanwj closed pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
1852019-01-02T13:17:20 *** bitcoin-git has left #bitcoin-core-dev
1862019-01-02T13:19:16 <hebasto> promag: sure
1872019-01-02T13:24:01 *** bitbee has quit IRC
1882019-01-02T13:26:07 <fanquake> promag is there anything I'm forgetting to test? https://github.com/bitcoin/bitcoin/pull/15065#issuecomment-450862480
1892019-01-02T13:26:13 <fanquake> macOS only at the moment.
1902019-01-02T13:28:46 *** bitbee has joined #bitcoin-core-dev
1912019-01-02T13:43:04 *** AaronvanW has quit IRC
1922019-01-02T13:44:40 *** sfhi has joined #bitcoin-core-dev
1932019-01-02T13:44:40 *** bitcoin-git has joined #bitcoin-core-dev
1942019-01-02T13:44:41 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3bb936a0f97...df894fa69a09
1952019-01-02T13:44:42 <bitcoin-git> bitcoin/master 59e3877 James O'Beirne: test: add invalid tx templates for use in functional tests...
1962019-01-02T13:44:42 <bitcoin-git> bitcoin/master df894fa Wladimir J. van der Laan: Merge #14457: test: add invalid tx templates for use in functional tests...
1972019-01-02T13:44:43 *** bitcoin-git has left #bitcoin-core-dev
1982019-01-02T13:45:09 *** bitcoin-git has joined #bitcoin-core-dev
1992019-01-02T13:45:10 <bitcoin-git> [bitcoin] laanwj closed pull request #14457: test: add invalid tx templates for use in functional tests (master...2018-10-invalid-tx-tests) https://github.com/bitcoin/bitcoin/pull/14457
2002019-01-02T13:45:10 *** bitcoin-git has left #bitcoin-core-dev
2012019-01-02T13:51:14 *** spaced0ut has joined #bitcoin-core-dev
2022019-01-02T14:03:51 *** Robin has joined #bitcoin-core-dev
2032019-01-02T14:06:38 *** promag has quit IRC
2042019-01-02T14:11:18 *** dviola has quit IRC
2052019-01-02T14:13:09 *** dviola has joined #bitcoin-core-dev
2062019-01-02T14:13:25 *** dviola has joined #bitcoin-core-dev
2072019-01-02T14:40:54 *** mistergold has quit IRC
2082019-01-02T14:43:07 *** Tralfaz has joined #bitcoin-core-dev
2092019-01-02T14:53:08 <fanquake> Has anyone seen #15079 before? Bit of a weird bug
2102019-01-02T14:53:09 <gribble> https://github.com/bitcoin/bitcoin/issues/15079 | gui: Incorrect application name when passing -regtest on Fedora · Issue #15079 · bitcoin/bitcoin · GitHub
2112019-01-02T14:59:48 <wumpus> fanquake: see post; I don't think it's really a bug, we've never used a different app name for regtest
2122019-01-02T15:00:07 <wumpus> (this means it shares QSettings with testnet)
2132019-01-02T15:01:23 <fanquake> wumpus ah fair enough, surprised I never noticed earlier
2142019-01-02T15:05:06 <wumpus> there would be a point in changing it I guess especially if you're using bitcoin-qt regtest with the functional tests, wouldn't want to run it with the testnet settings
2152019-01-02T15:06:24 *** promag has joined #bitcoin-core-dev
2162019-01-02T15:06:43 <promag> ty hebasto
2172019-01-02T15:08:49 <fanquake> promag Could you have a look at #15000? It fixes the notification segfault on Fedora, but seems to break macOS notifications.
2182019-01-02T15:08:50 <gribble> https://github.com/bitcoin/bitcoin/issues/15000 | qt: Fix broken notificator on GNOME by hebasto · Pull Request #15000 · bitcoin/bitcoin · GitHub
2192019-01-02T15:09:06 <promag> fanquake: sure
2202019-01-02T15:09:18 <fanquake> Just want to confirm it's not a local issue of mine.
2212019-01-02T15:15:28 *** aqquadro has quit IRC
2222019-01-02T15:20:33 *** michaelsdunn1 has joined #bitcoin-core-dev
2232019-01-02T15:22:52 *** Guyver2 has joined #bitcoin-core-dev
2242019-01-02T15:23:09 <promag> MarcoFalke: do you update the license year range on each touched file?
2252019-01-02T15:25:04 *** sfhi has quit IRC
2262019-01-02T15:31:51 *** john__ has quit IRC
2272019-01-02T15:54:42 <wumpus> promag: that is the original idea behind the license years, touching the file updates the copyright to current year
2282019-01-02T15:55:23 <wumpus> usually people don't bother, which isn't bad, there's a script to update all of them at the end up the year
2292019-01-02T15:56:53 *** aqquadro has joined #bitcoin-core-dev
2302019-01-02T15:56:56 <promag> contrib/devtools/copyright_header.py?
2312019-01-02T15:57:24 <wumpus> yes
2322019-01-02T15:58:29 <cjd> It seems to me that since normally all content it considered to belong to it's creator until the copyright expires (after whatever number of years), the year written in the notice is sort of a nod to older times when people used printing presses and there was no way to get dates from git blame
2332019-01-02T16:01:15 <wumpus> it's essentially redundant as the info is in git anyway, but yeah
2342019-01-02T16:03:02 <wumpus> there's been many discussions about this in the past, even about removing the years from the header, but there's no strong reason to, it's convention and it doesn't harm either
2352019-01-02T16:03:20 <promag> wumpus: 0.17.2 date is before 0.18?
2362019-01-02T16:03:24 <cjd> there are much worse conventions than that :)
2372019-01-02T16:05:27 *** aqquadro has quit IRC
2382019-01-02T16:05:31 <wumpus> cjd: it's true :)
2392019-01-02T16:05:41 <wumpus> promag: I guess?
2402019-01-02T16:07:04 <wumpus> promag: it's not sure of course but I would be surprised if there isn't a reason to do 0.17.2 before march/april
2412019-01-02T16:08:41 <promag> kk
2422019-01-02T16:19:19 *** bitcoin-git has joined #bitcoin-core-dev
2432019-01-02T16:19:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df894fa69a09...fb52d0684e0f
2442019-01-02T16:19:20 <bitcoin-git> bitcoin/master c8d9d90 Hennadii Stepanov: Fix broken notificator on GNOME...
2452019-01-02T16:19:21 <bitcoin-git> bitcoin/master fb52d06 MarcoFalke: Merge #15000: qt: Fix broken notificator on GNOME...
2462019-01-02T16:19:21 *** bitcoin-git has left #bitcoin-core-dev
2472019-01-02T16:20:00 *** bitcoin-git has joined #bitcoin-core-dev
2482019-01-02T16:20:01 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15000: qt: Fix broken notificator on GNOME (master...20181218-fix-notificator) https://github.com/bitcoin/bitcoin/pull/15000
2492019-01-02T16:20:01 *** bitcoin-git has left #bitcoin-core-dev
2502019-01-02T16:20:54 *** Skirmant has quit IRC
2512019-01-02T16:27:09 <promag> fanquake: re #15000, have you double checked?
2522019-01-02T16:27:11 <gribble> https://github.com/bitcoin/bitcoin/issues/15000 | qt: Fix broken notificator on GNOME by hebasto · Pull Request #15000 · bitcoin/bitcoin · GitHub
2532019-01-02T16:48:45 *** Murch has quit IRC
2542019-01-02T16:53:01 *** rh0nj has quit IRC
2552019-01-02T16:54:00 *** promag has quit IRC
2562019-01-02T16:54:07 *** rh0nj has joined #bitcoin-core-dev
2572019-01-02T16:56:04 *** Murch has joined #bitcoin-core-dev
2582019-01-02T16:58:45 *** CodeBlue1776 has quit IRC
2592019-01-02T16:59:45 *** dviola has quit IRC
2602019-01-02T16:59:56 *** CodeBlue1776 has joined #bitcoin-core-dev
2612019-01-02T17:03:04 *** Guest36764 has quit IRC
2622019-01-02T17:08:45 *** dviola has joined #bitcoin-core-dev
2632019-01-02T17:09:03 *** dviola has joined #bitcoin-core-dev
2642019-01-02T17:13:45 *** MrPaz has joined #bitcoin-core-dev
2652019-01-02T17:20:57 *** setpill has quit IRC
2662019-01-02T17:28:10 *** aqquadro has joined #bitcoin-core-dev
2672019-01-02T17:28:10 *** aqquadro has joined #bitcoin-core-dev
2682019-01-02T17:33:58 <achow101> github dead :(
2692019-01-02T17:34:32 <spinza> yeah for me too
2702019-01-02T17:34:40 <aqquadro> achow101, spinza thank you i was thinking is dead only for me
2712019-01-02T17:35:05 <achow101> check https://www.githubstatus.com/. the website part has a major outage
2722019-01-02T17:35:15 *** brianhoffman has quit IRC
2732019-01-02T17:37:40 <instagibbs> unicorns on various repos
2742019-01-02T17:38:46 *** brianhoffman has joined #bitcoin-core-dev
2752019-01-02T17:47:39 *** Skirmant has joined #bitcoin-core-dev
2762019-01-02T17:48:39 *** Murch has quit IRC
2772019-01-02T17:50:34 *** Murch has joined #bitcoin-core-dev
2782019-01-02T17:53:35 *** jungly has quit IRC
2792019-01-02T17:53:36 *** jarthur has joined #bitcoin-core-dev
2802019-01-02T17:58:40 <spinza> unicorns gone for me
2812019-01-02T18:04:00 *** ddustin has joined #bitcoin-core-dev
2822019-01-02T18:04:12 *** jarthur has quit IRC
2832019-01-02T18:04:38 *** jarthur has joined #bitcoin-core-dev
2842019-01-02T18:13:05 *** elichai2 has joined #bitcoin-core-dev
2852019-01-02T18:18:31 *** tripleslash has joined #bitcoin-core-dev
2862019-01-02T18:18:32 *** tripleslash has quit IRC
2872019-01-02T18:19:24 *** tripleslash has joined #bitcoin-core-dev
2882019-01-02T18:26:10 *** promag has joined #bitcoin-core-dev
2892019-01-02T18:42:36 *** Murch has quit IRC
2902019-01-02T18:43:40 *** promag has quit IRC
2912019-01-02T18:46:14 *** davec has quit IRC
2922019-01-02T18:48:07 *** davec has joined #bitcoin-core-dev
2932019-01-02T18:55:46 *** Murch has joined #bitcoin-core-dev
2942019-01-02T19:22:28 *** Skirmant has quit IRC
2952019-01-02T19:25:33 *** Skirmant has joined #bitcoin-core-dev
2962019-01-02T19:26:59 *** Skirmant has quit IRC
2972019-01-02T19:27:21 *** Skirmant has joined #bitcoin-core-dev
2982019-01-02T19:39:13 *** Skirmant has quit IRC
2992019-01-02T19:41:02 *** belcher has joined #bitcoin-core-dev
3002019-01-02T19:42:19 *** Murch has quit IRC
3012019-01-02T19:42:34 *** rex4539 has joined #bitcoin-core-dev
3022019-01-02T19:47:14 *** Murch has joined #bitcoin-core-dev
3032019-01-02T19:54:09 *** evenom has joined #bitcoin-core-dev
3042019-01-02T19:54:15 *** michaelsdunn1 has quit IRC
3052019-01-02T19:56:26 *** Murch has quit IRC
3062019-01-02T19:58:33 *** michaelsdunn1 has joined #bitcoin-core-dev
3072019-01-02T19:58:33 *** michaelsdunn1 has quit IRC
3082019-01-02T19:58:33 *** michaelsdunn1 has joined #bitcoin-core-dev
3092019-01-02T19:59:35 *** spinza has quit IRC
3102019-01-02T20:01:37 *** spaced0ut has quit IRC
3112019-01-02T20:08:05 *** spinza has joined #bitcoin-core-dev
3122019-01-02T20:14:31 *** aqquadro has quit IRC
3132019-01-02T20:14:32 *** evenom has quit IRC
3142019-01-02T20:14:55 *** spaced0ut has joined #bitcoin-core-dev
3152019-01-02T20:22:39 *** Skirmant has joined #bitcoin-core-dev
3162019-01-02T20:39:33 *** promag has joined #bitcoin-core-dev
3172019-01-02T20:45:43 *** cryptapus has quit IRC
3182019-01-02T20:50:22 *** michaelsdunn1 has quit IRC
3192019-01-02T20:51:47 *** bitcoin-git has joined #bitcoin-core-dev
3202019-01-02T20:51:48 <bitcoin-git> [bitcoin] harding opened pull request #15081: Doc: Update release notes for master through to 2019-01-01 (master...2019-01-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15081
3212019-01-02T20:51:48 *** bitcoin-git has left #bitcoin-core-dev
3222019-01-02T20:51:58 *** michaelsdunn1 has joined #bitcoin-core-dev
3232019-01-02T20:57:07 *** dermoth has quit IRC
3242019-01-02T21:01:42 *** dviola has quit IRC
3252019-01-02T21:03:21 *** cryptapus has joined #bitcoin-core-dev
3262019-01-02T21:07:14 *** Guyver2 has quit IRC
3272019-01-02T21:09:03 *** cluelessperson has quit IRC
3282019-01-02T21:11:06 *** ossifrage has quit IRC
3292019-01-02T21:11:33 *** ossifrage has joined #bitcoin-core-dev
3302019-01-02T21:12:08 *** dviola has joined #bitcoin-core-dev
3312019-01-02T21:12:26 *** dviola has joined #bitcoin-core-dev
3322019-01-02T21:16:47 *** ossifrage has quit IRC
3332019-01-02T21:31:17 *** rex4539 has quit IRC
3342019-01-02T21:35:49 *** dviola has quit IRC
3352019-01-02T21:38:14 *** elichai2 has quit IRC
3362019-01-02T21:39:45 *** hebasto has quit IRC
3372019-01-02T21:40:10 *** ossifrage has joined #bitcoin-core-dev
3382019-01-02T21:40:17 *** hebasto has joined #bitcoin-core-dev
3392019-01-02T21:42:27 *** hebasto has joined #bitcoin-core-dev
3402019-01-02T21:50:27 *** cryptapus has quit IRC
3412019-01-02T21:50:49 *** cryptapus has joined #bitcoin-core-dev
3422019-01-02T21:50:49 *** cryptapus has quit IRC
3432019-01-02T21:50:49 *** cryptapus has joined #bitcoin-core-dev
3442019-01-02T21:55:24 *** EagleTM has joined #bitcoin-core-dev
3452019-01-02T22:12:48 *** promag has quit IRC
3462019-01-02T22:17:57 *** spinza has quit IRC
3472019-01-02T22:19:34 *** ossifrage has quit IRC
3482019-01-02T22:20:02 *** ossifrage has joined #bitcoin-core-dev
3492019-01-02T22:30:19 *** spinza has joined #bitcoin-core-dev
3502019-01-02T22:34:03 *** jarthur_ has joined #bitcoin-core-dev
3512019-01-02T22:35:31 *** AaronvanW has joined #bitcoin-core-dev
3522019-01-02T22:37:16 *** jarthur_ has quit IRC
3532019-01-02T22:37:42 *** jarthur_ has joined #bitcoin-core-dev
3542019-01-02T22:38:34 *** jarthur has quit IRC
3552019-01-02T22:39:38 *** AaronvanW has quit IRC
3562019-01-02T22:40:01 *** jarthur has joined #bitcoin-core-dev
3572019-01-02T22:40:51 *** AaronvanW has joined #bitcoin-core-dev
3582019-01-02T22:41:47 *** jarthur_ has quit IRC
3592019-01-02T22:41:51 *** Skirmant has quit IRC
3602019-01-02T22:43:16 *** sfhi has joined #bitcoin-core-dev
3612019-01-02T22:44:15 *** jarthur has quit IRC
3622019-01-02T22:48:57 *** dermoth has joined #bitcoin-core-dev
3632019-01-02T22:49:36 *** dermoth has quit IRC
3642019-01-02T22:49:57 *** dermoth has joined #bitcoin-core-dev
3652019-01-02T22:57:00 *** Skirmant has joined #bitcoin-core-dev
3662019-01-02T22:58:46 *** sfhi has quit IRC
3672019-01-02T23:04:02 *** rh0nj has quit IRC
3682019-01-02T23:05:08 *** rh0nj has joined #bitcoin-core-dev
3692019-01-02T23:11:39 *** hirish has joined #bitcoin-core-dev
3702019-01-02T23:12:03 *** hirish is now known as Guest14638
3712019-01-02T23:18:22 *** AaronvanW has quit IRC
3722019-01-02T23:19:03 *** AaronvanW has joined #bitcoin-core-dev
3732019-01-02T23:30:02 *** michaelsdunn1 has quit IRC
3742019-01-02T23:35:47 *** Zenton has quit IRC
3752019-01-02T23:40:29 *** hebasto has quit IRC
3762019-01-02T23:54:16 <fanquake> promag, when you are testing for notifications on macOS. Are you using src/qt/bitcoin-qt, or calling make-deploy and using the App in the .dmg?
3772019-01-02T23:55:55 <fanquake> Seems to make a difference for me. re hebasto's comment, I didn't get anything in the Notification center at all, not just missing popups. I'll check again.
3782019-01-02T23:58:18 *** fabianfabian has joined #bitcoin-core-dev