12019-01-03T00:01:44 *** ghost43 has quit IRC
22019-01-03T00:03:59 *** ghost43 has joined #bitcoin-core-dev
32019-01-03T00:05:34 *** EagleTM has quit IRC
42019-01-03T00:26:04 <fanquake> Anyone have a PR for high-priority? Looking at bit empty at the moment -> https://github.com/bitcoin/bitcoin/projects/8
52019-01-03T00:28:51 *** AaronvanW has quit IRC
62019-01-03T00:30:00 *** yusuf has joined #bitcoin-core-dev
72019-01-03T00:30:11 *** AaronvanW has joined #bitcoin-core-dev
82019-01-03T00:30:30 <yusuf> hello
92019-01-03T00:34:30 *** AaronvanW has quit IRC
102019-01-03T00:41:28 *** yusuf has quit IRC
112019-01-03T00:57:11 *** ossifrage has quit IRC
122019-01-03T01:02:41 *** AaronvanW has joined #bitcoin-core-dev
132019-01-03T01:03:00 *** ossifrage has joined #bitcoin-core-dev
142019-01-03T01:15:38 *** AaronvanW has quit IRC
152019-01-03T01:16:57 *** spinza has quit IRC
162019-01-03T01:34:48 *** spinza has joined #bitcoin-core-dev
172019-01-03T01:55:33 *** RATHARARE has joined #bitcoin-core-dev
182019-01-03T01:57:20 *** mistergold has joined #bitcoin-core-dev
192019-01-03T01:59:49 *** cluelessperson_ has joined #bitcoin-core-dev
202019-01-03T02:02:28 *** mistergold has quit IRC
212019-01-03T02:09:04 *** mistergold has joined #bitcoin-core-dev
222019-01-03T02:12:11 *** RATHARARE has quit IRC
232019-01-03T02:12:30 *** irc_viewer_test has joined #bitcoin-core-dev
242019-01-03T02:15:11 *** irc_viewer_test has quit IRC
252019-01-03T02:22:10 *** AaronvanW has joined #bitcoin-core-dev
262019-01-03T02:41:28 *** EagleTM has joined #bitcoin-core-dev
272019-01-03T03:04:46 *** ossifrage has quit IRC
282019-01-03T03:08:44 *** EagleTM has quit IRC
292019-01-03T03:41:03 *** cluelessperson_ has quit IRC
302019-01-03T03:41:22 *** cluelessperson_ has joined #bitcoin-core-dev
312019-01-03T03:43:17 *** cluelessperson_ has quit IRC
322019-01-03T03:44:42 *** cluelessperson has joined #bitcoin-core-dev
332019-01-03T03:56:15 *** bytting has joined #bitcoin-core-dev
342019-01-03T04:04:02 *** rh0nj has quit IRC
352019-01-03T04:05:07 *** rh0nj has joined #bitcoin-core-dev
362019-01-03T04:09:24 *** tmc has joined #bitcoin-core-dev
372019-01-03T04:22:27 *** AaronvanW has quit IRC
382019-01-03T04:25:15 <achow101> fanquake: #14491
392019-01-03T04:25:19 <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
402019-01-03T04:25:55 <fanquake> achow101 done
412019-01-03T04:26:38 *** bitcoin-git has joined #bitcoin-core-dev
422019-01-03T04:26:38 <bitcoin-git> [bitcoin] bytting opened pull request #15083: wallet: Fix a bug where memcmp takes a pointer address as second argument (master...20190103-fix-memcmp) https://github.com/bitcoin/bitcoin/pull/15083
432019-01-03T04:26:38 *** bitcoin-git has left #bitcoin-core-dev
442019-01-03T04:34:11 *** AaronvanW has joined #bitcoin-core-dev
452019-01-03T04:38:52 *** AaronvanW has quit IRC
462019-01-03T05:00:07 *** ossifrage has joined #bitcoin-core-dev
472019-01-03T05:09:39 *** bytting has quit IRC
482019-01-03T05:42:09 *** ossifrage has quit IRC
492019-01-03T05:42:36 *** ossifrage has joined #bitcoin-core-dev
502019-01-03T06:32:23 *** rex4539 has joined #bitcoin-core-dev
512019-01-03T06:34:58 *** AaronvanW has joined #bitcoin-core-dev
522019-01-03T06:39:13 *** AaronvanW has quit IRC
532019-01-03T06:43:49 *** bitcoin-git has joined #bitcoin-core-dev
542019-01-03T06:43:50 <bitcoin-git> [bitcoin] benthecarman opened pull request #15084: gui: don't disable the sync overlay when wallet is disabled (master...sync_overlay_without_wallet) https://github.com/bitcoin/bitcoin/pull/15084
552019-01-03T06:43:50 *** bitcoin-git has left #bitcoin-core-dev
562019-01-03T06:50:36 *** rex4539 has quit IRC
572019-01-03T07:06:52 *** bitcoin-git has joined #bitcoin-core-dev
582019-01-03T07:06:53 <bitcoin-git> [bitcoin] benthecarman opened pull request #15085: gui: Fix for Incorrect application name when passing -regtest (master...regest_window_name) https://github.com/bitcoin/bitcoin/pull/15085
592019-01-03T07:06:53 *** bitcoin-git has left #bitcoin-core-dev
602019-01-03T07:08:10 *** Initech has joined #bitcoin-core-dev
612019-01-03T07:10:14 *** chenpo has joined #bitcoin-core-dev
622019-01-03T07:16:05 *** Initech has quit IRC
632019-01-03T07:19:11 *** chenpo has quit IRC
642019-01-03T07:21:29 *** promag has joined #bitcoin-core-dev
652019-01-03T07:24:00 *** chenpo has joined #bitcoin-core-dev
662019-01-03T07:27:45 *** hebasto has joined #bitcoin-core-dev
672019-01-03T07:40:40 *** chenpo has quit IRC
682019-01-03T07:43:55 *** fabianfabian has quit IRC
692019-01-03T07:45:23 *** bitcoin-git has joined #bitcoin-core-dev
702019-01-03T07:45:23 <bitcoin-git> [bitcoin] benthecarman opened pull request #15086: rpc: Fixing logical error in ListTransactions (master...fix_logical_error_in_ListTransactions) https://github.com/bitcoin/bitcoin/pull/15086
712019-01-03T07:45:23 *** bitcoin-git has left #bitcoin-core-dev
722019-01-03T07:59:35 *** bitcoin-git has joined #bitcoin-core-dev
732019-01-03T07:59:35 <bitcoin-git> [bitcoin] benthecarman closed pull request #15086: rpc: Fixing logical error in ListTransactions (master...fix_logical_error_in_ListTransactions) https://github.com/bitcoin/bitcoin/pull/15086
742019-01-03T07:59:35 *** bitcoin-git has left #bitcoin-core-dev
752019-01-03T08:04:18 *** rex4539 has joined #bitcoin-core-dev
762019-01-03T08:08:01 *** rh0nj has quit IRC
772019-01-03T08:09:07 *** rh0nj has joined #bitcoin-core-dev
782019-01-03T08:17:23 *** ChA1NsAw has joined #bitcoin-core-dev
792019-01-03T08:35:47 *** AaronvanW has joined #bitcoin-core-dev
802019-01-03T08:37:12 <fanquake> wumpus: when you have time this arvo; #15065, 15081 & 15038 should be mergable.
812019-01-03T08:37:13 <gribble> https://github.com/bitcoin/bitcoin/issues/15065 | 0.17: GUI Backports #14123 #14133 #14383 #14597 by promag · Pull Request #15065 · bitcoin/bitcoin · GitHub
822019-01-03T08:39:19 *** aqquadro has joined #bitcoin-core-dev
832019-01-03T08:39:19 *** aqquadro has joined #bitcoin-core-dev
842019-01-03T08:40:17 *** AaronvanW has quit IRC
852019-01-03T08:41:36 *** EagleTM has joined #bitcoin-core-dev
862019-01-03T08:51:20 *** jungly has joined #bitcoin-core-dev
872019-01-03T08:51:28 *** e4xit_ has joined #bitcoin-core-dev
882019-01-03T08:51:36 <wumpus> fanquake: thank you, will have a look
892019-01-03T08:52:37 *** qu4ku has joined #bitcoin-core-dev
902019-01-03T08:53:43 *** e4xit has quit IRC
912019-01-03T08:55:19 *** bitcoin-git has joined #bitcoin-core-dev
922019-01-03T08:55:20 <bitcoin-git> [bitcoin] laanwj pushed 9 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/16521ce08676...5ff7b372cdbd
932019-01-03T08:55:20 <bitcoin-git> bitcoin/0.17 298dc15 João Barbosa: gui: Favor macOS show / hide action in dock menu...
942019-01-03T08:55:21 <bitcoin-git> bitcoin/0.17 d2ed162 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode...
952019-01-03T08:55:21 <bitcoin-git> bitcoin/0.17 4d4bc37 Hennadii Stepanov: Remove obj_c for macOS Dock icon setting...
962019-01-03T08:55:22 *** bitcoin-git has left #bitcoin-core-dev
972019-01-03T08:57:56 <wumpus> fanquake: please approve #15081 it still shows as "fanquake requested changes"
982019-01-03T08:57:57 <gribble> https://github.com/bitcoin/bitcoin/issues/15081 | Doc: Update release notes for master through to 2019-01-01 by harding · Pull Request #15081 · bitcoin/bitcoin · GitHub
992019-01-03T08:59:02 <fanquake> wumpus: sorry, should be fixed now I think.
1002019-01-03T08:59:48 <wumpus> yep!
1012019-01-03T09:03:10 *** AaronvanW has joined #bitcoin-core-dev
1022019-01-03T09:03:51 *** Murch has joined #bitcoin-core-dev
1032019-01-03T09:08:06 *** AaronvanW has quit IRC
1042019-01-03T09:15:25 *** dermoth has quit IRC
1052019-01-03T09:16:30 *** dermoth has joined #bitcoin-core-dev
1062019-01-03T09:18:25 *** dermoth has quit IRC
1072019-01-03T09:23:58 *** Zenton has joined #bitcoin-core-dev
1082019-01-03T09:24:04 *** bitcoin-git has joined #bitcoin-core-dev
1092019-01-03T09:24:04 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fb52d0684e0f...031e3a32b245
1102019-01-03T09:24:05 <bitcoin-git> bitcoin/master 97fbe67 David A. Harding: Release notes: update notes through fb52d0684
1112019-01-03T09:24:05 <bitcoin-git> bitcoin/master f3d7d75 David A. Harding: Release notes: integrate detached release notes
1122019-01-03T09:24:06 <bitcoin-git> bitcoin/master 031e3a3 Wladimir J. van der Laan: Merge #15081: Doc: Update release notes for master through to 2019-01-01...
1132019-01-03T09:24:06 *** bitcoin-git has left #bitcoin-core-dev
1142019-01-03T09:24:53 *** bitcoin-git has joined #bitcoin-core-dev
1152019-01-03T09:24:53 <bitcoin-git> [bitcoin] laanwj closed pull request #15081: Doc: Update release notes for master through to 2019-01-01 (master...2019-01-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15081
1162019-01-03T09:24:53 *** bitcoin-git has left #bitcoin-core-dev
1172019-01-03T09:28:59 *** setpill has joined #bitcoin-core-dev
1182019-01-03T09:45:43 <hebasto> fanquake: hi, did your check macOS notifications after merging #15000?
1192019-01-03T09:45:44 <gribble> https://github.com/bitcoin/bitcoin/issues/15000 | qt: Fix broken notificator on GNOME by hebasto · Pull Request #15000 · bitcoin/bitcoin · GitHub
1202019-01-03T09:49:11 <hebasto> *you
1212019-01-03T09:54:28 <fanquake> hebasto I tested with #15007, but not with just master. Can have another look tonight.
1222019-01-03T09:54:30 <gribble> https://github.com/bitcoin/bitcoin/issues/15007 | qt: Notificator class refactoring by hebasto · Pull Request #15007 · bitcoin/bitcoin · GitHub
1232019-01-03T10:09:08 *** elichai2 has joined #bitcoin-core-dev
1242019-01-03T10:09:20 *** e4xit_ has left #bitcoin-core-dev
1252019-01-03T10:10:18 *** e4xit has joined #bitcoin-core-dev
1262019-01-03T10:20:08 *** AaronvanW has joined #bitcoin-core-dev
1272019-01-03T10:24:40 *** AaronvanW has quit IRC
1282019-01-03T10:37:00 *** Murch has quit IRC
1292019-01-03T10:42:08 *** Murch has joined #bitcoin-core-dev
1302019-01-03T10:43:47 *** e4xit has quit IRC
1312019-01-03T10:46:02 *** e4xit has joined #bitcoin-core-dev
1322019-01-03T10:54:17 *** spinza has quit IRC
1332019-01-03T10:57:58 *** jungly has quit IRC
1342019-01-03T10:59:07 *** phyrexia has joined #bitcoin-core-dev
1352019-01-03T11:01:41 *** jungly has joined #bitcoin-core-dev
1362019-01-03T11:06:09 *** spinza has joined #bitcoin-core-dev
1372019-01-03T11:17:08 *** bitcoin-git has joined #bitcoin-core-dev
1382019-01-03T11:17:09 <bitcoin-git> [bitcoin] MeshCollider opened pull request #15087: Error if rpcpassword contains hash in conf sections (master...201901_pass_hash_fix) https://github.com/bitcoin/bitcoin/pull/15087
1392019-01-03T11:17:09 *** bitcoin-git has left #bitcoin-core-dev
1402019-01-03T11:30:21 *** qu4ku has quit IRC
1412019-01-03T11:56:51 *** bitcoin-git has joined #bitcoin-core-dev
1422019-01-03T11:56:51 <bitcoin-git> [bitcoin] cyberknight01 opened pull request #15088: Revert 1 master (master...revert-1-master) https://github.com/bitcoin/bitcoin/pull/15088
1432019-01-03T11:56:51 *** bitcoin-git has left #bitcoin-core-dev
1442019-01-03T11:57:00 *** bitcoin-git has joined #bitcoin-core-dev
1452019-01-03T11:57:00 <bitcoin-git> [bitcoin] cyberknight01 closed pull request #15088: Revert 1 master (master...revert-1-master) https://github.com/bitcoin/bitcoin/pull/15088
1462019-01-03T11:57:00 *** bitcoin-git has left #bitcoin-core-dev
1472019-01-03T12:09:19 *** Murch has quit IRC
1482019-01-03T12:11:57 *** AaronvanW has joined #bitcoin-core-dev
1492019-01-03T12:13:52 *** EagleTM has quit IRC
1502019-01-03T12:17:54 *** AaronvanW has quit IRC
1512019-01-03T12:23:33 *** Murch has joined #bitcoin-core-dev
1522019-01-03T12:40:02 *** rh0nj has quit IRC
1532019-01-03T12:41:07 *** rh0nj has joined #bitcoin-core-dev
1542019-01-03T13:20:40 *** rafalcpp has quit IRC
1552019-01-03T13:20:45 <fanquake> Is there a meeting tonight?
1562019-01-03T13:20:58 *** rafalcpp has joined #bitcoin-core-dev
1572019-01-03T13:36:03 *** aqquadro has quit IRC
1582019-01-03T13:42:19 *** dermoth has joined #bitcoin-core-dev
1592019-01-03T13:43:42 *** promag has joined #bitcoin-core-dev
1602019-01-03T13:46:39 *** ExtraCrispy has joined #bitcoin-core-dev
1612019-01-03T13:54:04 <promag> fanquake: I have tested both versions: make and make deploy
1622019-01-03T13:55:09 <promag> for high priority I'd like #14941 there
1632019-01-03T13:55:10 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
1642019-01-03T13:55:20 <promag> but can ask later in the meeting
1652019-01-03T13:55:41 <fanquake> promag I've added it anyways
1662019-01-03T13:55:45 <promag> reason: changes behavior and its for backport
1672019-01-03T13:55:53 <promag> oh thanks!
1682019-01-03T13:56:21 <fanquake> np. I think I'll miss the meeting anyways.
1692019-01-03T14:06:54 <fanquake> If we run out of topics, I'd suggest discussing minimum Qt. Seems to be some consensus around 5.6 for 0.18.0, and I think that would be a good target.
1702019-01-03T14:13:19 *** promag has quit IRC
1712019-01-03T14:15:13 *** Guyver2 has joined #bitcoin-core-dev
1722019-01-03T14:26:32 *** promag has joined #bitcoin-core-dev
1732019-01-03T14:52:33 <wumpus> fanquake: yes, today there is a meeting
1742019-01-03T14:59:52 *** promag has quit IRC
1752019-01-03T15:14:43 *** aqquadro has joined #bitcoin-core-dev
1762019-01-03T15:14:43 *** aqquadro has joined #bitcoin-core-dev
1772019-01-03T15:17:51 *** michaelsdunn1 has joined #bitcoin-core-dev
1782019-01-03T15:33:41 *** bitcoin-git has joined #bitcoin-core-dev
1792019-01-03T15:33:42 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/031e3a32b245...d1effa11aded
1802019-01-03T15:33:43 <bitcoin-git> bitcoin/master 7514361 Hennadii Stepanov: Correct misleading "overridden options" label...
1812019-01-03T15:33:43 <bitcoin-git> bitcoin/master d1effa1 Wladimir J. van der Laan: Merge #14375: qt: Correct misleading "overridden options" label...
1822019-01-03T15:33:44 *** bitcoin-git has left #bitcoin-core-dev
1832019-01-03T15:34:15 *** bitcoin-git has joined #bitcoin-core-dev
1842019-01-03T15:34:15 <bitcoin-git> [bitcoin] laanwj closed pull request #14375: qt: Correct misleading "overridden options" label (master...20181002-gui-overridden-options) https://github.com/bitcoin/bitcoin/pull/14375
1852019-01-03T15:34:15 *** bitcoin-git has left #bitcoin-core-dev
1862019-01-03T15:37:14 *** ddustin has quit IRC
1872019-01-03T15:37:50 *** ddustin has joined #bitcoin-core-dev
1882019-01-03T15:42:03 *** ddustin has quit IRC
1892019-01-03T15:44:08 *** Murch has quit IRC
1902019-01-03T15:44:11 *** bitcoin-git has joined #bitcoin-core-dev
1912019-01-03T15:44:12 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1effa11aded...06fabfa2878e
1922019-01-03T15:44:13 <bitcoin-git> bitcoin/master 1db71d4 Graham Krizek: Add names to Travis jobs...
1932019-01-03T15:44:13 <bitcoin-git> bitcoin/master 06fabfa MarcoFalke: Merge #15020: Build: add names to Travis jobs...
1942019-01-03T15:44:14 *** bitcoin-git has left #bitcoin-core-dev
1952019-01-03T15:44:48 *** bitcoin-git has joined #bitcoin-core-dev
1962019-01-03T15:44:48 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15020: Build: add names to Travis jobs (master...travis-job-names) https://github.com/bitcoin/bitcoin/pull/15020
1972019-01-03T15:44:48 *** bitcoin-git has left #bitcoin-core-dev
1982019-01-03T16:01:35 *** bitcoin-git has joined #bitcoin-core-dev
1992019-01-03T16:01:36 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/06fabfa2878e...1d73636fdf1e
2002019-01-03T16:01:36 <bitcoin-git> bitcoin/master 79f0a3f Hennadii Stepanov: Get more info about GUI-related issue on Linux
2012019-01-03T16:01:37 <bitcoin-git> bitcoin/master 1d73636 Wladimir J. van der Laan: Merge #15038: docs: Get more info about GUI-related issue on Linux...
2022019-01-03T16:01:37 *** bitcoin-git has left #bitcoin-core-dev
2032019-01-03T16:02:09 *** bitcoin-git has joined #bitcoin-core-dev
2042019-01-03T16:02:09 <bitcoin-git> [bitcoin] laanwj closed pull request #15038: docs: Get more info about GUI-related issue on Linux (master...20181226-issue-template-gui-linux) https://github.com/bitcoin/bitcoin/pull/15038
2052019-01-03T16:02:09 *** bitcoin-git has left #bitcoin-core-dev
2062019-01-03T16:03:03 *** aqquadro has quit IRC
2072019-01-03T16:05:21 *** aqquadro has joined #bitcoin-core-dev
2082019-01-03T16:11:08 *** aqquadro has quit IRC
2092019-01-03T16:11:57 *** aqquadro has joined #bitcoin-core-dev
2102019-01-03T16:14:16 *** setpill has quit IRC
2112019-01-03T16:19:38 *** aqquadro has quit IRC
2122019-01-03T16:29:22 *** CodeBlue1776 has quit IRC
2132019-01-03T16:30:07 *** CodeBlue1776 has joined #bitcoin-core-dev
2142019-01-03T16:32:31 *** timothy has quit IRC
2152019-01-03T16:34:13 *** aqquadro has joined #bitcoin-core-dev
2162019-01-03T16:34:13 *** aqquadro has joined #bitcoin-core-dev
2172019-01-03T16:35:16 *** timothy has joined #bitcoin-core-dev
2182019-01-03T16:36:25 *** jarthur has joined #bitcoin-core-dev
2192019-01-03T16:42:01 *** rh0nj has quit IRC
2202019-01-03T16:43:07 *** rh0nj has joined #bitcoin-core-dev
2212019-01-03T16:43:32 <dongcarl> If anyone's familiar with the qt side of things, I'd really appreciate some help here: https://github.com/bitcoin/bitcoin/pull/14856#issuecomment-451200652
2222019-01-03T16:51:56 *** spinza has quit IRC
2232019-01-03T16:56:30 *** promag has joined #bitcoin-core-dev
2242019-01-03T16:58:18 *** bitcoin-git has joined #bitcoin-core-dev
2252019-01-03T16:58:18 <bitcoin-git> [bitcoin] DrahtBot closed pull request #12153: Avoid permanent cs_main lock in getblockheader (master...2018-01-getblockheader) https://github.com/bitcoin/bitcoin/pull/12153
2262019-01-03T16:58:18 *** bitcoin-git has left #bitcoin-core-dev
2272019-01-03T17:13:58 <wumpus> dongcarl: maybe ask ryanofsky he'll probably know the most about the interface:: stuff
2282019-01-03T17:14:41 *** aqquadro has quit IRC
2292019-01-03T17:16:05 *** aqquadro has joined #bitcoin-core-dev
2302019-01-03T17:16:06 *** aqquadro has joined #bitcoin-core-dev
2312019-01-03T17:19:36 <promag> MarcoFalke: maybe I should rebase #12151 to get a fresh travis build?
2322019-01-03T17:19:38 <gribble> https://github.com/bitcoin/bitcoin/issues/12151 | rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
2332019-01-03T17:22:13 <wumpus> promag: you want a fresh travis build? I can retrigger travis if you want
2342019-01-03T17:22:26 <promag> but does it rebase with master?
2352019-01-03T17:23:48 <wumpus> it should
2362019-01-03T17:24:00 <promag> ok then!
2372019-01-03T17:26:18 *** aqquadro has quit IRC
2382019-01-03T17:30:20 *** spinza has joined #bitcoin-core-dev
2392019-01-03T18:19:33 *** AaronvanW has joined #bitcoin-core-dev
2402019-01-03T18:20:21 *** jungly has quit IRC
2412019-01-03T18:32:09 *** Zenton has quit IRC
2422019-01-03T18:37:28 <moneyball> for today's meeting, there is one topic proposed ahead of time, which was discussed a bit after proposal, but achow101 may want to address further today: topic proposed by achow101: having users create their wallets instead of automatically creating a default wallet
2432019-01-03T18:38:21 <sipa> I will probably miss the meeting
2442019-01-03T18:51:23 *** Aaronvan_ has joined #bitcoin-core-dev
2452019-01-03T18:53:51 *** AaronvanW has quit IRC
2462019-01-03T19:01:11 <jonasschnelli> hi
2472019-01-03T19:01:17 <gleb> hi
2482019-01-03T19:01:17 <achow101> hi
2492019-01-03T19:01:34 <moneyball> hi
2502019-01-03T19:01:41 <wumpus> hi
2512019-01-03T19:01:48 <wumpus> #startmeeting
2522019-01-03T19:01:48 <lightningbot> Meeting started Thu Jan 3 19:01:48 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2532019-01-03T19:01:48 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2542019-01-03T19:01:54 <moneyball> happy 10 year genesis block
2552019-01-03T19:02:07 <meshcollider> hi
2562019-01-03T19:02:07 <jonasschnelli> \o/
2572019-01-03T19:02:17 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
2582019-01-03T19:02:29 <jamesob> hi
2592019-01-03T19:02:32 <promag> hi
2602019-01-03T19:02:35 <instagibbs> happy 10 years wumpus, who i assume is satoshi
2612019-01-03T19:02:36 <wumpus> yes \o/
2622019-01-03T19:02:45 <instagibbs> hi
2632019-01-03T19:02:48 <wumpus> lol instagibbs
2642019-01-03T19:04:11 <wumpus> #topic high priority for review
2652019-01-03T19:05:33 <wumpus> #11082 #14491 #14941
2662019-01-03T19:05:36 <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
2672019-01-03T19:05:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
2682019-01-03T19:05:40 <wumpus> are the current PRs
2692019-01-03T19:05:40 <phantomcircuit> hi
2702019-01-03T19:05:41 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
2712019-01-03T19:05:58 <wumpus> promag would like to add #14941
2722019-01-03T19:06:00 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
2732019-01-03T19:06:06 <wumpus> eh wait, that's already on there?
2742019-01-03T19:06:09 <jamesob> can I nominate jimpo's BIP157/8-related PRs that've been hanging out for a while? maybe starting with #14111?
2752019-01-03T19:06:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14111 | index: Create IndexRunner class for activing indexes. by jimpo · Pull Request #14111 · bitcoin/bitcoin · GitHub
2762019-01-03T19:06:13 <promag> fanquake added
2772019-01-03T19:06:42 <achow101> #15006
2782019-01-03T19:06:43 <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
2792019-01-03T19:07:02 *** Tralfaz has quit IRC
2802019-01-03T19:07:24 <jamesob> also ryanofsky's next step in the process separation project, #14711
2812019-01-03T19:07:26 <gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub
2822019-01-03T19:07:27 <achow101> I guess #14938 should go first as 15006 depends on it
2832019-01-03T19:07:30 <gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub
2842019-01-03T19:09:17 <wumpus> #14938 first then?
2852019-01-03T19:09:19 <gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub
2862019-01-03T19:09:19 <wumpus> right
2872019-01-03T19:09:23 <jonasschnelli> yes
2882019-01-03T19:10:29 <jamesob> oops I'm sorry -- that jimpo PR isn't critical path for BIP157; I meant #14085
2892019-01-03T19:10:31 <gribble> https://github.com/bitcoin/bitcoin/issues/14085 | index: Fix for indexers skipping genesis block. by jimpo · Pull Request #14085 · bitcoin/bitcoin · GitHub
2902019-01-03T19:10:33 <wumpus> ok added the mentioned ones
2912019-01-03T19:10:52 <wumpus> jamesob: ok, will replace it then
2922019-01-03T19:11:05 <jamesob> wumpus: thanks. fwiw ultimately I'm after #14121, but that PR is a dep
2932019-01-03T19:11:08 <gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
2942019-01-03T19:11:42 <wumpus> right, better to put that one then, the idea of high priority for review is PRs that are dependencies of others
2952019-01-03T19:12:50 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
2962019-01-03T19:13:12 <wumpus> #topic having users create their wallets instead of automatically creating a default wallet (achow101)
2972019-01-03T19:13:40 <achow101> this was discussed briefly when I first mentioned it
2982019-01-03T19:13:44 <jonasschnelli> I like the concept
2992019-01-03T19:13:56 <achow101> the end goal is to make wallets that were "born encrypted"
3002019-01-03T19:14:08 <luke-jr> I suspect it may be confusing to some users
3012019-01-03T19:14:30 <wumpus> I think both should be possible
3022019-01-03T19:14:37 <jonasschnelli> I don't think it confuses users... we could still trigger the "create" wallet process at first launch in the GUI
3032019-01-03T19:15:09 <wumpus> ideally, if you want the default wallet, that's fine, if you want to create something customized and start with nothing, that should be possible
3042019-01-03T19:15:43 <jonasschnelli> but that sounds after a lot of configuration options.. do you mean a -nodefaultwallet options?
3052019-01-03T19:15:45 <wumpus> I think having to set an encryption key at first used has been argued against in the past though
3062019-01-03T19:16:08 <achow101> My idea is to get rid of the default wallet entirely. I don't think there really should be a default wallet
3072019-01-03T19:16:29 <meshcollider> Can't a default wallet setup box or something pop up like the datadir one on first launch
3082019-01-03T19:16:39 <achow101> and having the default wallet with createwallet can be confusing. users may mistakenly send things to the default wallet when they meant to use some other wallet
3092019-01-03T19:16:43 <wumpus> meshcollider: exactly; that could be skippable
3102019-01-03T19:16:48 <jonasschnelli> I agree... wallets should probably created intentionally since its an important data file
3112019-01-03T19:17:06 <gmaxwell> jonasschnelli: doing something automatically on first _launch_ would largely defeat the point.
3122019-01-03T19:17:22 <gmaxwell> jonasschnelli: the behavior I've been recommending is triggering it when the user attempts to get an address.
3132019-01-03T19:17:26 <jonasschnelli> gmaxwell: only in the GUI (wizzard) ....
3142019-01-03T19:17:34 <wumpus> I think changing this is too late for 0.18
3152019-01-03T19:17:38 <gmaxwell> jonasschnelli: yes, that still defeats the point.
3162019-01-03T19:17:41 <jonasschnelli> though I'm not convince... only if we "confuse" users with removing the default wallet
3172019-01-03T19:17:58 <achow101> gmaxwell: so I investigated the create wallet on use stuff before and I think it would be rather fragile or require a lot more refactoring
3182019-01-03T19:18:12 <jonasschnelli> But yeah,.. I agree with you gmaxwell
3192019-01-03T19:18:21 <gmaxwell> achow101: But do you not agree that it's the right behavior?
3202019-01-03T19:18:34 <promag> gmaxwell: also for rpc clients?
3212019-01-03T19:18:58 *** irc_viewer_test has joined #bitcoin-core-dev
3222019-01-03T19:19:07 <achow101> gmaxwell: yes. but I think that having the user explicitly create the wallet is a suitable replacement too
3232019-01-03T19:19:27 <gmaxwell> promag: I have less strong opinions on that, I could go either way. The RPC can't prompt you to answer more questions (like encryption), while the gui can.
3242019-01-03T19:19:57 <wumpus> but for RPC the client could use createwallet explicitly to create the first wallet
3252019-01-03T19:19:58 <ryanofsky> Will add my +1 for Greg's idea. I think creating a default wallet when needed is more user friendly.
3262019-01-03T19:20:03 <gmaxwell> achow101: what exactly does that mean? do you mean getnewaddress should be missing from the UI otherwise, or it should silently fail?
3272019-01-03T19:20:09 <promag> gmaxwell: I'd love to remove the implicit wallet endpoint
3282019-01-03T19:20:43 <jonasschnelli> When the wallet is auto-creating when it's needed, there is (probably) no place for additional options
3292019-01-03T19:20:46 <achow101> gmaxwell: i mean that getnewaddress would give you an error saying "do createwallet first"
3302019-01-03T19:20:54 <gmaxwell> achow101: because if the GUI would offer the options but pop up a message, then that could simply start wallet creation: so I don't see where the additional refactoring comes in there for the gui.
3312019-01-03T19:21:26 <wumpus> this is similar to say, SQL servers, they don't usually create a default database either but assume the client will create one
3322019-01-03T19:21:50 <wumpus> for RPC that makes perfect sense, for the GUI, I don't know
3332019-01-03T19:22:07 <promag> achow101: not only that imo, all wallet methods
3342019-01-03T19:22:08 <achow101> gmaxwell: in the gui, i imagine it would be like the disablewallet ui but a button that says "click here to make a wallet"
3352019-01-03T19:22:22 <gmaxwell> promag: if the endpoint is gone, then users will just get a command not found. We can do that, but kinda lugly.
3362019-01-03T19:22:41 <jonasschnelli> I think the GUI with no wallet will require (decent) refactoring to show the receive tab in order to let the user click on "new address"
3372019-01-03T19:22:41 *** hebasto has quit IRC
3382019-01-03T19:22:50 <gmaxwell> achow101: If it's made conspicious enough, thats fine with me I suppose.
3392019-01-03T19:23:07 <gmaxwell> We just need to be careful to not make the software unusable for new users.
3402019-01-03T19:23:13 <wumpus> gmaxwell: that is an implementation detail depending on how it's handled, it could just as well return a message to create a wallet first
3412019-01-03T19:23:28 <achow101> the point is that it's going to be totally obvious that you need to make a new wallet. there shouldn't be any magic in the background
3422019-01-03T19:23:30 <gmaxwell> like they shouldn't have to dig through menus to make expected options appear or anything like that.
3432019-01-03T19:23:34 <jonasschnelli> Why not do it like other wallets,... if the GUI detects no wallet, allow to load or create a wallet
3442019-01-03T19:23:49 <wumpus> jonasschnelli: exactly
3452019-01-03T19:23:58 <wumpus> that makes perfect sense for the GUI
3462019-01-03T19:24:01 <gmaxwell> jonasschnelli: when?
3472019-01-03T19:24:09 <wumpus> at start, when there's no wallet.dat
3482019-01-03T19:24:12 <luke-jr> maybe after the first-launch screen it should open some new wallet wizard with a Skip button
3492019-01-03T19:24:19 <jonasschnelli> When the GUI loads and no wallet has been detected (but was compiled with wallet support)
3502019-01-03T19:24:22 <jonasschnelli> Ask: new / open
3512019-01-03T19:24:24 <wumpus> and no -disablewallet or -nowallet or such was specified
3522019-01-03T19:24:30 <jonasschnelli> yes
3532019-01-03T19:24:36 <gmaxwell> The point of not creating the wallet on start is so that the wallet will not be created unencrypted, and also so that you don't end up with a lot of unusued wallet files laying around.
3542019-01-03T19:24:47 <wumpus> gmaxwell: right
3552019-01-03T19:24:58 <wumpus> that's one advantage of never creating wallet.dat without prompting
3562019-01-03T19:25:05 <gmaxwell> And you don't prompt for an encrypted key at initial start because users will set something random forget it, then months later send funds to it.
3572019-01-03T19:25:17 <achow101> gmaxwell: that would be part of the ui prompt
3582019-01-03T19:25:28 <jonasschnelli> That is a critical point
3592019-01-03T19:25:31 <achow101> gmaxwell: something like what electrum does on its first start
3602019-01-03T19:25:38 <gmaxwell> (Electrum insututed a complicated UI flow that forces users to write down a recovery code to address that issue)
3612019-01-03T19:25:44 <promag> gmaxwell: actually I'm working on "File -> Reopen Wallet -> ..." which requires saving a history.. if this is empty it could prompt the wizard
3622019-01-03T19:26:20 <jonasschnelli> Electrum is too much handholding IMO
3632019-01-03T19:26:51 <gmaxwell> Electrum's behavior was driven by massive amounts of funds loss that happened when prompting users for encryption keys months before using the wallet.
3642019-01-03T19:27:05 *** Skirmant has quit IRC
3652019-01-03T19:27:16 <wumpus> it'd be possible to skip wallet creation completely
3662019-01-03T19:27:23 <jonasschnelli> That would speak for the create-on-first-new-address
3672019-01-03T19:27:23 *** Skirmant has joined #bitcoin-core-dev
3682019-01-03T19:27:35 <gmaxwell> jonasschnelli: or just having a clear create button.
3692019-01-03T19:27:38 <achow101> as I said earlier, I think the ideal solution would be to just have a button in the main ui that says "click here to make a wallet"
3702019-01-03T19:27:43 <gmaxwell> Or having error messages on use that tell you to create.
3712019-01-03T19:28:00 <wumpus> yes that was suggested, show the GUI in zero-wallet mode and have a 'create wallet' mode
3722019-01-03T19:28:01 <gmaxwell> Though if you are going to have an error message, it could just start the create dialog.
3732019-01-03T19:28:13 <wumpus> button
3742019-01-03T19:28:23 <luke-jr> use the webcam to make the user prove they wrote down the passphrase /s
3752019-01-03T19:28:28 <gmaxwell> That sounds okay to me, the implementation just needs to be conspicious.
3762019-01-03T19:28:33 <jonasschnelli> Ideally the GUI is completely usable (explore) without a wallet... and the wallet is created on first address
3772019-01-03T19:28:35 <promag> regarding the -wallet arg, should it stay "load or create"?
3782019-01-03T19:28:38 <wumpus> luke-jr: doesn't everyone have a sticker over those xD
3792019-01-03T19:28:52 <gmaxwell> luke-jr: electrum disables copy/paste and then makes you reenter on another screen. less computer vision required. :P
3802019-01-03T19:29:25 <gmaxwell> promag: probably load or create, maybe introduce a -walletfile that doesn't create?
3812019-01-03T19:29:45 <gmaxwell> and consider depricating the create version later?
3822019-01-03T19:30:10 <luke-jr> gmaxwell: I've always found that super annoying for network passwords (but haven't given it a lot of thought for wallet passphrases, or seeds) since it prevents password management
3832019-01-03T19:30:10 <achow101> promag: imo it should just be a load option. no create
3842019-01-03T19:30:38 <phantomcircuit> gmaxwell, i have so many completely empty wallet files backed up it's silly
3852019-01-03T19:30:56 <achow101> promag: maybe even error when the wallet file can't be found to load
3862019-01-03T19:31:18 <promag> achow101: maybe lazy creation - on actual usage?
3872019-01-03T19:31:39 <wumpus> I think we're starting to go in circles
3882019-01-03T19:31:51 <jonasschnelli> jup
3892019-01-03T19:31:54 <wumpus> any other topics?
3902019-01-03T19:32:11 <promag> anyway, too late for 0.18, and too many breaking changes
3912019-01-03T19:32:37 <wumpus> yes, let's aim to have the creat-with-password RPC in 0.18, but don't change any defaults
3922019-01-03T19:32:54 <jonasschnelli> ack
3932019-01-03T19:34:06 <promag> I'd like some feedback here #14941, so far only ryanofsky reviewed
3942019-01-03T19:34:08 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
3952019-01-03T19:34:59 <wumpus> #action review #14941
3962019-01-03T19:35:01 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
3972019-01-03T19:36:15 *** irc_viewer_test has quit IRC
3982019-01-03T19:36:15 <wumpus> ok if there's no other topics, let's close the meeting early
3992019-01-03T19:36:18 <gmaxwell> achow101: error on failure is nice.
4002019-01-03T19:37:02 <promag> o/
4012019-01-03T19:37:39 *** ddustin has joined #bitcoin-core-dev
4022019-01-03T19:37:44 <wumpus> yes, having it wait for the unload before returning is certainly better conceptually, having it asynchronous only causes complexity
4032019-01-03T19:38:21 <wumpus> (and indeed, leaves no way to return errors)
4042019-01-03T19:39:03 <wumpus> #endmeeting
4052019-01-03T19:39:03 <lightningbot> Meeting ended Thu Jan 3 19:39:03 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4062019-01-03T19:39:03 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-03-19.01.html
4072019-01-03T19:39:03 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-03-19.01.txt
4082019-01-03T19:39:03 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-03-19.01.log.html
4092019-01-03T19:40:07 <luke-jr> O.o
4102019-01-03T19:45:37 <wumpus> o.O?
4112019-01-03T19:47:24 *** timothy has quit IRC
4122019-01-03T19:47:45 *** irc_viewer_test1 has joined #bitcoin-core-dev
4132019-01-03T19:48:19 *** irc_viewer_test1 has quit IRC
4142019-01-03T19:50:07 *** Krellan has quit IRC
4152019-01-03T19:56:26 <jl2012> what is the meaning of ~0 ? I read that in some github comments
4162019-01-03T19:58:49 *** dgenr8 has joined #bitcoin-core-dev
4172019-01-03T20:00:28 *** michaelsdunn1 has quit IRC
4182019-01-03T20:00:38 <BlueMatt> jl2012: 0xffffffff?
4192019-01-03T20:00:51 *** elichai2 has quit IRC
4202019-01-03T20:01:03 <BlueMatt> or ~= 0, ie the exact opposite, depending on the context
4212019-01-03T20:01:33 <jl2012> https://github.com/bitcoin/bitcoin/pull/14085#issuecomment-417782919
4222019-01-03T20:03:00 <achow101> jl2012: it means they are neither acking nor nacking the pr. they don't really support it, but aren't completely opposed to it. kind of like apathy
4232019-01-03T20:03:07 <BlueMatt> jl2012: oh, I think wumpus meant -0
4242019-01-03T20:04:18 <jl2012> ok, thanks!
4252019-01-03T20:06:26 <wumpus> "approximately zero", as in, I don't care about it
4262019-01-03T20:07:51 *** jarthur has quit IRC
4272019-01-03T20:13:39 *** justanotheruser has quit IRC
4282019-01-03T20:13:58 <wumpus> but it looks a lot of people have utACKed it so doesn't matter
4292019-01-03T20:14:31 *** michaelsdunn1 has joined #bitcoin-core-dev
4302019-01-03T20:14:56 <wumpus> could merge it, though the last post does make me doubt again?
4312019-01-03T20:19:00 <wumpus> I mean, if the BIP is changed, it doesn't need to be merged, right?
4322019-01-03T20:27:00 *** promag has quit IRC
4332019-01-03T20:27:30 *** aqquadro has joined #bitcoin-core-dev
4342019-01-03T20:33:21 *** Zenton has joined #bitcoin-core-dev
4352019-01-03T20:33:25 *** promag has joined #bitcoin-core-dev
4362019-01-03T20:37:56 *** profmac has quit IRC
4372019-01-03T20:41:33 *** Tennis has joined #bitcoin-core-dev
4382019-01-03T20:50:56 *** profmac has joined #bitcoin-core-dev
4392019-01-03T21:10:18 *** Krellan has joined #bitcoin-core-dev
4402019-01-03T21:11:15 *** michaelsdunn1 has quit IRC
4412019-01-03T21:13:49 *** michaelsdunn1 has joined #bitcoin-core-dev
4422019-01-03T21:15:13 *** Aaronvan_ has quit IRC
4432019-01-03T21:23:13 *** emilengler has joined #bitcoin-core-dev
4442019-01-03T21:23:17 *** promag has quit IRC
4452019-01-03T21:24:07 *** emilengler has left #bitcoin-core-dev
4462019-01-03T21:30:22 *** promag has joined #bitcoin-core-dev
4472019-01-03T21:36:31 *** promag has quit IRC
4482019-01-03T21:41:42 *** Zenton has quit IRC
4492019-01-03T21:41:50 *** Zenton has joined #bitcoin-core-dev
4502019-01-03T21:45:31 *** bitcoin-git has joined #bitcoin-core-dev
4512019-01-03T21:45:31 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15091: GUI: fix model overlay header sync (master...2019/01/qt_fix_modal) https://github.com/bitcoin/bitcoin/pull/15091
4522019-01-03T21:45:31 *** bitcoin-git has left #bitcoin-core-dev
4532019-01-03T21:46:39 *** promag has joined #bitcoin-core-dev
4542019-01-03T21:51:56 *** AaronvanW has joined #bitcoin-core-dev
4552019-01-03T21:58:51 *** promag has quit IRC
4562019-01-03T22:06:09 <jonasschnelli> Thanks for reviewing #14353 (is a simple REST addition)
4572019-01-03T22:06:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
4582019-01-03T22:06:19 <jonasschnelli> Its helpful for personal block explorers
4592019-01-03T22:09:26 *** spinza has quit IRC
4602019-01-03T22:09:54 *** AaronvanW has quit IRC
4612019-01-03T22:25:14 *** ddustin has quit IRC
4622019-01-03T22:25:43 *** ddustin has joined #bitcoin-core-dev
4632019-01-03T22:30:32 *** ddustin has quit IRC
4642019-01-03T22:31:19 *** spinza has joined #bitcoin-core-dev
4652019-01-03T22:43:37 *** bitcoin-git has joined #bitcoin-core-dev
4662019-01-03T22:43:38 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d73636fdf1e...d71d0d7b7f3f
4672019-01-03T22:43:38 <bitcoin-git> bitcoin/master 5bb0164 Chun Kuan Lee: depends: Enable unicode support on dbd for Windows
4682019-01-03T22:43:39 <bitcoin-git> bitcoin/master d71d0d7 MarcoFalke: Merge #13884: depends: Enable bdb unicode support for Windows...
4692019-01-03T22:43:39 *** bitcoin-git has left #bitcoin-core-dev
4702019-01-03T22:44:02 *** bitcoin-git has joined #bitcoin-core-dev
4712019-01-03T22:44:03 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13884: depends: Enable bdb unicode support for Windows (master...bdb-utf8) https://github.com/bitcoin/bitcoin/pull/13884
4722019-01-03T22:44:03 *** bitcoin-git has left #bitcoin-core-dev
4732019-01-03T22:44:38 *** bitcoin-git has joined #bitcoin-core-dev
4742019-01-03T22:44:38 <bitcoin-git> [bitcoin] marcinja opened pull request #15093: rpc: Change importwallet to return additional errors (master...add-errors-to-importwallet) https://github.com/bitcoin/bitcoin/pull/15093
4752019-01-03T22:44:38 *** bitcoin-git has left #bitcoin-core-dev
4762019-01-03T22:45:42 *** AaronvanW has joined #bitcoin-core-dev
4772019-01-03T22:48:04 *** Guyver2 has quit IRC
4782019-01-03T22:48:44 *** ChA1NsAw has quit IRC
4792019-01-03T22:50:03 *** aqquadro has quit IRC
4802019-01-03T23:08:23 *** Krellan has quit IRC
4812019-01-03T23:09:42 *** bitcoin-git has joined #bitcoin-core-dev
4822019-01-03T23:09:42 <bitcoin-git> [bitcoin] benthecarman opened pull request #15094: 0.17: Backport for #15085 (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/15094
4832019-01-03T23:09:42 *** bitcoin-git has left #bitcoin-core-dev
4842019-01-03T23:10:55 *** justanotheruser has joined #bitcoin-core-dev
4852019-01-03T23:18:39 *** promag has joined #bitcoin-core-dev
4862019-01-03T23:18:45 *** ddustin has joined #bitcoin-core-dev
4872019-01-03T23:20:08 *** bitcoin-git has joined #bitcoin-core-dev
4882019-01-03T23:20:08 <bitcoin-git> [bitcoin] benthecarman closed pull request #15094: 0.17: Backport for #15085 (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/15094
4892019-01-03T23:20:08 *** bitcoin-git has left #bitcoin-core-dev
4902019-01-03T23:25:35 <fanquake> promag <.<
4912019-01-03T23:25:43 <promag> :)
4922019-01-03T23:26:34 <promag> thanks for pointing the script
4932019-01-03T23:28:35 *** Krellan has joined #bitcoin-core-dev
4942019-01-03T23:36:21 *** Krellan has quit IRC
4952019-01-03T23:36:51 *** Krellan has joined #bitcoin-core-dev
4962019-01-03T23:40:28 *** EagleTM has joined #bitcoin-core-dev
4972019-01-03T23:59:43 *** EagleTM has quit IRC