12019-01-05T00:00:29  <promag> #12153 is ready to merge imo
  22019-01-05T00:00:30  <gribble> https://github.com/bitcoin/bitcoin/issues/12153 | Avoid permanent cs_main lock in getblockheader by promag · Pull Request #12153 · bitcoin/bitcoin · GitHub
  32019-01-05T00:06:01  *** justanotheruser has quit IRC
  42019-01-05T00:19:43  *** jwhoisthat has quit IRC
  52019-01-05T00:25:40  *** bitcoin-git has joined #bitcoin-core-dev
  62019-01-05T00:25:40  <bitcoin-git> [bitcoin] promag opened pull request #15107: rest: Return 404 in /rest/headers if block hash does not exists (master...2019-rest-header-404) https://github.com/bitcoin/bitcoin/pull/15107
  72019-01-05T00:25:40  *** bitcoin-git has left #bitcoin-core-dev
  82019-01-05T00:25:47  *** justanotheruser has joined #bitcoin-core-dev
  92019-01-05T00:27:09  *** jwhoisthat has joined #bitcoin-core-dev
 102019-01-05T00:54:07  *** Krellan has joined #bitcoin-core-dev
 112019-01-05T00:58:23  *** jwhoisthat has quit IRC
 122019-01-05T01:13:53  *** jwhoisthat has joined #bitcoin-core-dev
 132019-01-05T01:29:01  *** rh0nj has quit IRC
 142019-01-05T01:30:07  *** rh0nj has joined #bitcoin-core-dev
 152019-01-05T01:31:47  *** IGHOR has quit IRC
 162019-01-05T01:37:20  *** IGHOR has joined #bitcoin-core-dev
 172019-01-05T02:01:27  *** millerti has quit IRC
 182019-01-05T02:08:09  *** jwhoisthat has quit IRC
 192019-01-05T02:09:31  *** dviola has quit IRC
 202019-01-05T02:23:36  *** jwhoisthat has joined #bitcoin-core-dev
 212019-01-05T02:33:35  *** bitcoin-git has joined #bitcoin-core-dev
 222019-01-05T02:33:35  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15108: [tests] tidy up wallet_importmulti.py (master...14952_rebase) https://github.com/bitcoin/bitcoin/pull/15108
 232019-01-05T02:33:35  *** bitcoin-git has left #bitcoin-core-dev
 242019-01-05T02:34:26  *** spinza has quit IRC
 252019-01-05T02:38:12  *** spinza has joined #bitcoin-core-dev
 262019-01-05T02:52:41  *** justanotheruser has quit IRC
 272019-01-05T02:59:16  *** brianhoffman has quit IRC
 282019-01-05T02:59:46  *** brianhoffman has joined #bitcoin-core-dev
 292019-01-05T03:08:43  *** justanotheruser has joined #bitcoin-core-dev
 302019-01-05T03:16:46  *** justanotheruser has quit IRC
 312019-01-05T03:24:49  *** jwhoisthat has quit IRC
 322019-01-05T03:42:53  *** qubenix has quit IRC
 332019-01-05T03:53:09  *** qubenix has joined #bitcoin-core-dev
 342019-01-05T04:06:08  *** justanotheruser has joined #bitcoin-core-dev
 352019-01-05T04:28:04  *** owowo has quit IRC
 362019-01-05T04:36:56  *** arubi has quit IRC
 372019-01-05T04:37:22  *** arubi has joined #bitcoin-core-dev
 382019-01-05T04:37:57  *** riemann_ has joined #bitcoin-core-dev
 392019-01-05T04:40:27  *** riemann has quit IRC
 402019-01-05T05:31:01  *** rh0nj has quit IRC
 412019-01-05T05:32:08  *** rh0nj has joined #bitcoin-core-dev
 422019-01-05T06:07:10  *** bitcoin-git has joined #bitcoin-core-dev
 432019-01-05T06:07:10  <bitcoin-git> [bitcoin] fanquake closed pull request #13621: Check for datadir after the config files were read (master...init-swap-datadir-readconf) https://github.com/bitcoin/bitcoin/pull/13621
 442019-01-05T06:07:10  *** bitcoin-git has left #bitcoin-core-dev
 452019-01-05T06:09:50  <fanquake> dongcarl Is #14442 still relevant after your updates to 12255 (or relevant at all)?
 462019-01-05T06:09:51  <gribble> https://github.com/bitcoin/bitcoin/issues/14442 | quit nicely with bitcoin-cli stop; use simple mode by colourful-land · Pull Request #14442 · bitcoin/bitcoin · GitHub
 472019-01-05T06:14:24  *** jarthur has joined #bitcoin-core-dev
 482019-01-05T06:16:58  *** bitcoin-git has joined #bitcoin-core-dev
 492019-01-05T06:16:58  <bitcoin-git> [bitcoin] fanquake closed pull request #14167: [WIP] docs: improve linux tar packages (master...fix-10746) https://github.com/bitcoin/bitcoin/pull/14167
 502019-01-05T06:16:58  *** bitcoin-git has left #bitcoin-core-dev
 512019-01-05T06:18:59  *** rex4539 has joined #bitcoin-core-dev
 522019-01-05T07:09:51  *** hebasto has joined #bitcoin-core-dev
 532019-01-05T07:20:11  <dongcarl> fanquake: Nope, I think both the "quit nicely with bitcoin-cli stop" part and the "use simple mode" part were shown not to be the best idea. I will comment on that PR with more context but it should be closed at some point.
 542019-01-05T08:34:49  *** jarthur has quit IRC
 552019-01-05T08:40:45  *** mistergold has joined #bitcoin-core-dev
 562019-01-05T09:01:06  *** CodeBlue1776 has quit IRC
 572019-01-05T09:02:16  *** CodeBlue1776 has joined #bitcoin-core-dev
 582019-01-05T09:06:54  *** mistergold has quit IRC
 592019-01-05T09:09:20  *** Bullit has joined #bitcoin-core-dev
 602019-01-05T09:30:06  *** Kevin__6 has joined #bitcoin-core-dev
 612019-01-05T09:33:01  *** rh0nj has quit IRC
 622019-01-05T09:34:08  *** rh0nj has joined #bitcoin-core-dev
 632019-01-05T09:41:46  *** bitcoin-git has joined #bitcoin-core-dev
 642019-01-05T09:41:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14952: [do not merge] [tests] tidy up wallet_importmulti.py (master...14886_review_comments) https://github.com/bitcoin/bitcoin/pull/14952
 652019-01-05T09:41:46  *** bitcoin-git has left #bitcoin-core-dev
 662019-01-05T09:42:53  *** owowo has joined #bitcoin-core-dev
 672019-01-05T10:01:09  *** bitcoin-git has joined #bitcoin-core-dev
 682019-01-05T10:01:09  <bitcoin-git> [bitcoin] fanquake closed pull request #14442: quit nicely with bitcoin-cli stop; use simple mode (master...master) https://github.com/bitcoin/bitcoin/pull/14442
 692019-01-05T10:01:09  *** bitcoin-git has left #bitcoin-core-dev
 702019-01-05T10:01:09  *** ddustin has quit IRC
 712019-01-05T10:01:32  *** ddustin has joined #bitcoin-core-dev
 722019-01-05T10:06:13  <dongcarl> fanquake: Wondering what you mean here: https://github.com/bitcoin/bitcoin/pull/12255#pullrequestreview-189592116
 732019-01-05T10:07:03  <dongcarl> What do you mean by "when release notes are merged"? The release notes I wrote are in the same PR as the actual changes, should I separate them?
 742019-01-05T10:08:10  <fanquake> dongcarl I mean when the release notes are merged into release-notes.md. Either at release time, or in one of the "roll ups", like we just had in #15081.
 752019-01-05T10:08:12  <gribble> https://github.com/bitcoin/bitcoin/issues/15081 | Doc: Update release notes for master through to 2019-01-01 by harding · Pull Request #15081 · bitcoin/bitcoin · GitHub
 762019-01-05T10:08:30  <fanquake> So nah, leave them as is. All good.
 772019-01-05T10:10:06  <fanquake> Can deal with all the nits then, rather than block PRs.
 782019-01-05T10:11:26  *** chenpo has joined #bitcoin-core-dev
 792019-01-05T10:13:34  *** chenpo has quit IRC
 802019-01-05T10:17:56  *** chenpo has joined #bitcoin-core-dev
 812019-01-05T10:21:37  *** chenpo has quit IRC
 822019-01-05T10:32:39  <dongcarl> kk
 832019-01-05T10:56:44  *** TheFuzzStone[m] has quit IRC
 842019-01-05T10:56:45  *** kewde[m] has quit IRC
 852019-01-05T10:56:54  *** ajtowns[m] has quit IRC
 862019-01-05T10:56:56  *** savil has quit IRC
 872019-01-05T10:58:33  *** spinza has quit IRC
 882019-01-05T10:58:58  *** EagleTM has joined #bitcoin-core-dev
 892019-01-05T10:59:24  *** Apocalyptic has quit IRC
 902019-01-05T11:02:20  *** Apocalyptic has joined #bitcoin-core-dev
 912019-01-05T11:02:24  *** bitcoin-git has joined #bitcoin-core-dev
 922019-01-05T11:02:24  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15109: refactor: Use C++11 default member initializers (master...Mf1901-ctorClean) https://github.com/bitcoin/bitcoin/pull/15109
 932019-01-05T11:02:24  *** bitcoin-git has left #bitcoin-core-dev
 942019-01-05T11:05:41  *** ajtowns[m] has joined #bitcoin-core-dev
 952019-01-05T11:10:41  <promag> provoostenator: ping #12134
 962019-01-05T11:10:44  <gribble> https://github.com/bitcoin/bitcoin/issues/12134 | Build previous releases and run functional tests by Sjors · Pull Request #12134 · bitcoin/bitcoin · GitHub
 972019-01-05T11:13:55  <promag> imo #11911 should be in hp for review
 982019-01-05T11:13:57  <gribble> https://github.com/bitcoin/bitcoin/issues/11911 | Free BerkeleyEnvironment instances when not in use by ryanofsky · Pull Request #11911 · bitcoin/bitcoin · GitHub
 992019-01-05T11:14:16  *** spinza has joined #bitcoin-core-dev
1002019-01-05T11:16:47  *** savil has joined #bitcoin-core-dev
1012019-01-05T11:16:48  *** kewde[m] has joined #bitcoin-core-dev
1022019-01-05T11:16:48  *** TheFuzzStone[m] has joined #bitcoin-core-dev
1032019-01-05T11:27:39  *** bitcoin-git has joined #bitcoin-core-dev
1042019-01-05T11:27:40  <bitcoin-git> [bitcoin] luke-jr closed pull request #14782: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (0.17...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14782
1052019-01-05T11:27:40  *** bitcoin-git has left #bitcoin-core-dev
1062019-01-05T11:28:07  *** bitcoin-git has joined #bitcoin-core-dev
1072019-01-05T11:28:07  <bitcoin-git> [bitcoin] luke-jr closed pull request #14602: Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_untrusted) https://github.com/bitcoin/bitcoin/pull/14602
1082019-01-05T11:28:07  *** bitcoin-git has left #bitcoin-core-dev
1092019-01-05T11:49:23  *** rex4539 has quit IRC
1102019-01-05T13:01:45  *** suser_ has joined #bitcoin-core-dev
1112019-01-05T13:03:17  *** bitcoin-git has joined #bitcoin-core-dev
1122019-01-05T13:03:17  <bitcoin-git> [bitcoin] fanquake reopened pull request #15094: 0.17: Backport for #15085 (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/15094
1132019-01-05T13:03:17  *** bitcoin-git has left #bitcoin-core-dev
1142019-01-05T13:10:02  *** rh0nj has quit IRC
1152019-01-05T13:11:14  *** rh0nj has joined #bitcoin-core-dev
1162019-01-05T13:30:15  *** Kevin__6 has quit IRC
1172019-01-05T13:37:18  *** timothy has joined #bitcoin-core-dev
1182019-01-05T13:38:28  *** Kevin__6 has joined #bitcoin-core-dev
1192019-01-05T13:39:10  <provoostenator> promag: I'll update that soonish.
1202019-01-05T13:50:04  *** someguy has joined #bitcoin-core-dev
1212019-01-05T13:54:59  *** cc5f has joined #bitcoin-core-dev
1222019-01-05T13:57:42  *** spinza has quit IRC
1232019-01-05T14:01:24  *** spinza has joined #bitcoin-core-dev
1242019-01-05T14:05:44  <fanquake> provoostenator will that scope of that testing still be 0.17.x -> master, or are you planning on building older releases?
1252019-01-05T14:06:16  <provoostenator> I was thinking of only supporting every major release, with the latest patch version.
1262019-01-05T14:06:27  <provoostenator> so 0.17.1 and 0.18.0 when it comes out
1272019-01-05T14:07:08  <provoostenator> The reason it doesn't support 0.16.* currently is that I haven't bothered to figure out some of the errors, so I'd rather just keep it simple.
1282019-01-05T14:08:28  *** bitcoin-git has joined #bitcoin-core-dev
1292019-01-05T14:08:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe5a70b9fefa...88bbcdc4e9b6
1302019-01-05T14:08:29  <provoostenator> The problem with 0.16 might be as simple as the new [testnet] syntax for config files, but I couldn't figure it out last time I looked into it (a bit).
1312019-01-05T14:08:29  <bitcoin-git> bitcoin/master 958e1a3 practicalswift: streams: Remove unused seek(size_t)
1322019-01-05T14:08:29  <bitcoin-git> bitcoin/master 4f4993f practicalswift: Remove UBSan suppression
1332019-01-05T14:08:30  <bitcoin-git> bitcoin/master 88bbcdc MarcoFalke: Merge #14357: streams: Fix broken streams_vector_reader test. Remove unused seek(size_t)....
1342019-01-05T14:08:30  *** bitcoin-git has left #bitcoin-core-dev
1352019-01-05T14:08:53  *** bitcoin-git has joined #bitcoin-core-dev
1362019-01-05T14:08:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14357: streams: Fix broken streams_vector_reader test. Remove unused seek(size_t). (master...vectorreader-seek-n-with-negative-n) https://github.com/bitcoin/bitcoin/pull/14357
1372019-01-05T14:08:54  *** bitcoin-git has left #bitcoin-core-dev
1382019-01-05T14:23:29  *** fabianfabian has joined #bitcoin-core-dev
1392019-01-05T14:30:14  *** Guyver2 has joined #bitcoin-core-dev
1402019-01-05T14:30:52  *** EagleTM has quit IRC
1412019-01-05T14:32:13  *** r3dh4r7 has joined #bitcoin-core-dev
1422019-01-05T14:33:53  *** Guyver2_ has joined #bitcoin-core-dev
1432019-01-05T14:36:04  *** Guyver2 has quit IRC
1442019-01-05T14:45:41  *** someguy has quit IRC
1452019-01-05T15:07:00  *** bitcoin-git has joined #bitcoin-core-dev
1462019-01-05T15:07:00  <bitcoin-git> [bitcoin] bytting closed pull request #15083: wallet: Fix a bug where memcmp takes a pointer address as second argument (master...20190103-fix-memcmp) https://github.com/bitcoin/bitcoin/pull/15083
1472019-01-05T15:07:00  *** bitcoin-git has left #bitcoin-core-dev
1482019-01-05T15:13:26  *** brianhoffman_ has joined #bitcoin-core-dev
1492019-01-05T15:16:34  *** brianhoffman has quit IRC
1502019-01-05T15:16:35  *** brianhoffman_ is now known as brianhoffman
1512019-01-05T15:20:35  *** bitcoin-git has joined #bitcoin-core-dev
1522019-01-05T15:20:35  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/88bbcdc4e9b6...9c719987718d
1532019-01-05T15:20:36  <bitcoin-git> bitcoin/master d2a1adf João Barbosa: qt: Factor out WalletModel::getDisplayName()
1542019-01-05T15:20:36  <bitcoin-git> bitcoin/master b2ce86c João Barbosa: qt: Use WalletModel* instead of wallet name in main window
1552019-01-05T15:20:37  <bitcoin-git> bitcoin/master 91b0c5b João Barbosa: qt: Use WalletModel* instead of wallet name in console window
1562019-01-05T15:20:37  *** bitcoin-git has left #bitcoin-core-dev
1572019-01-05T15:20:59  *** bitcoin-git has joined #bitcoin-core-dev
1582019-01-05T15:20:59  <bitcoin-git> [bitcoin] laanwj closed pull request #14784: qt: Use WalletModel* instead of the wallet name as map key (master...2018-11-qtwalletmodel) https://github.com/bitcoin/bitcoin/pull/14784
1592019-01-05T15:20:59  *** bitcoin-git has left #bitcoin-core-dev
1602019-01-05T15:38:01  *** EagleTM has joined #bitcoin-core-dev
1612019-01-05T15:42:00  *** r3dh4r7 has quit IRC
1622019-01-05T15:48:04  *** dviola has joined #bitcoin-core-dev
1632019-01-05T16:08:18  <fanquake> Can someone doing native Windows builds clarify if you are meant to/need to install secp & leveldb with vcpkg?
1642019-01-05T16:12:26  *** bralyclow has quit IRC
1652019-01-05T16:20:30  *** bitcoin-git has joined #bitcoin-core-dev
1662019-01-05T16:20:30  <bitcoin-git> [bitcoin] Mr-Leshiy opened pull request #15110: Fix the build problem in libbitcoin_server (master...MrLeshiy_Fix_Build) https://github.com/bitcoin/bitcoin/pull/15110
1672019-01-05T16:20:30  *** bitcoin-git has left #bitcoin-core-dev
1682019-01-05T16:27:12  *** cc5f has quit IRC
1692019-01-05T16:32:42  *** greenparhelia has joined #bitcoin-core-dev
1702019-01-05T16:34:16  *** EagleTM has quit IRC
1712019-01-05T16:35:26  *** AaronvanW has joined #bitcoin-core-dev
1722019-01-05T16:49:27  *** AaronvanW has quit IRC
1732019-01-05T16:50:19  *** AaronvanW has joined #bitcoin-core-dev
1742019-01-05T16:56:10  *** Aaronvan_ has joined #bitcoin-core-dev
1752019-01-05T16:56:51  *** AaronvanW has quit IRC
1762019-01-05T17:39:17  *** aqquadro has quit IRC
1772019-01-05T17:43:58  *** jhfrontz has joined #bitcoin-core-dev
1782019-01-05T17:45:45  *** suser_ has quit IRC
1792019-01-05T17:51:43  *** aqquadro has joined #bitcoin-core-dev
1802019-01-05T17:51:43  *** aqquadro has joined #bitcoin-core-dev
1812019-01-05T17:52:01  *** Murch has joined #bitcoin-core-dev
1822019-01-05T18:19:37  <provoostenator> Boy I wish the function test runner would scream in protest if you forget to compile first :-)
1832019-01-05T18:20:32  <provoostenator> Maybe it could ask make if anything is outdated and then give a warning? Or would that be super brittle?
1842019-01-05T18:21:23  *** rex4539 has joined #bitcoin-core-dev
1852019-01-05T18:21:43  <gmaxwell> provoostenator: just adopt a practice of using make on the same commandline you run the test with
1862019-01-05T18:21:50  <gmaxwell> make && ./foo
1872019-01-05T18:22:25  <gmaxwell> alternatively we could make a target for the tests
1882019-01-05T18:22:53  <gmaxwell> e.g. make check ... or in fact, make make check run the functional tests.
1892019-01-05T18:24:10  <provoostenator> That is a good practice.
1902019-01-05T18:25:14  <provoostenator> I usually run just a single test, so make check probably wouldn't be a good fit. Unless we make it really smart.
1912019-01-05T18:27:34  <provoostenator> "JSONRPCException: Unknown named parameter wait" - getting this during a rebase; did we recently change something related?
1922019-01-05T18:29:39  <gmaxwell> there is a PR that had a wait argument and lost it... something with wallet unloading or shutdown or something
1932019-01-05T18:29:55  <gmaxwell> https://github.com/bitcoin/bitcoin/pull/14941
1942019-01-05T18:35:45  *** davec has quit IRC
1952019-01-05T18:37:12  *** davec has joined #bitcoin-core-dev
1962019-01-05T18:42:27  *** greenparhelia has quit IRC
1972019-01-05T18:44:28  *** bzb_ has joined #bitcoin-core-dev
1982019-01-05T18:51:56  *** rex4539 has quit IRC
1992019-01-05T19:01:24  *** bzb_ has quit IRC
2002019-01-05T19:01:37  *** bzb has joined #bitcoin-core-dev
2012019-01-05T19:02:38  <provoostenator> It's this change: https://github.com/bitcoin/bitcoin/commit/ef7c54c1eceb0eb938dd4e8312283c7433fe0c8f
2022019-01-05T19:03:01  <provoostenator> It causes the 0.17.1 node to explode in my backwards compatilibyt test. I think I can work around it though.
2032019-01-05T19:04:14  *** bzb has quit IRC
2042019-01-05T19:24:57  *** rex4539 has joined #bitcoin-core-dev
2052019-01-05T19:26:57  *** Murch has quit IRC
2062019-01-05T19:35:48  *** Aaronvan_ has quit IRC
2072019-01-05T19:59:00  *** achow101 has quit IRC
2082019-01-05T20:01:21  *** achow101 has joined #bitcoin-core-dev
2092019-01-05T20:14:20  *** EagleTM has joined #bitcoin-core-dev
2102019-01-05T20:25:46  *** Zenton has quit IRC
2112019-01-05T20:25:54  *** Zenton has joined #bitcoin-core-dev
2122019-01-05T21:10:27  *** bitcoin-git has joined #bitcoin-core-dev
2132019-01-05T21:10:27  <bitcoin-git> [bitcoin] practicalswift opened pull request #15111: Avoid UB (member call on nullptr) when failing to read randomness in the startup process (master...random-ub) https://github.com/bitcoin/bitcoin/pull/15111
2142019-01-05T21:10:27  *** bitcoin-git has left #bitcoin-core-dev
2152019-01-05T21:14:41  *** Hilobrain has joined #bitcoin-core-dev
2162019-01-05T21:15:53  *** nullptr| has quit IRC
2172019-01-05T21:17:28  *** nullptr| has joined #bitcoin-core-dev
2182019-01-05T21:45:18  *** millerti has joined #bitcoin-core-dev
2192019-01-05T22:32:43  *** rex4539 has quit IRC
2202019-01-05T22:37:01  *** rh0nj has quit IRC
2212019-01-05T22:38:08  *** rh0nj has joined #bitcoin-core-dev
2222019-01-05T22:39:36  *** EagleTM has quit IRC
2232019-01-05T22:47:58  *** bitcoin-git has joined #bitcoin-core-dev
2242019-01-05T22:47:58  <bitcoin-git> [bitcoin] Empact opened pull request #15112: build: Enable -Wzero-as-null-pointer-constant (master...zero-as-null-pointer-constant) https://github.com/bitcoin/bitcoin/pull/15112
2252019-01-05T22:47:58  *** bitcoin-git has left #bitcoin-core-dev
2262019-01-05T22:50:28  *** Guyver2_ has quit IRC
2272019-01-05T23:00:12  *** spinza has quit IRC
2282019-01-05T23:04:15  *** spinza has joined #bitcoin-core-dev
2292019-01-05T23:21:07  <promag> provoostenator: how does that change affect your work?
2302019-01-05T23:31:00  *** EagleTM has joined #bitcoin-core-dev
2312019-01-05T23:33:42  *** CodeBlue1776 has quit IRC
2322019-01-05T23:35:33  *** CodeBlue1776 has joined #bitcoin-core-dev
2332019-01-05T23:38:13  *** tryphe has quit IRC
2342019-01-05T23:39:29  *** tryphe has joined #bitcoin-core-dev
2352019-01-05T23:53:43  *** mmlinx has joined #bitcoin-core-dev
2362019-01-05T23:53:54  *** dviola has quit IRC