12019-01-07T00:10:51  *** aqquadro has quit IRC
  22019-01-07T00:15:39  *** justanotheruser has quit IRC
  32019-01-07T00:19:52  *** justanotheruser has joined #bitcoin-core-dev
  42019-01-07T00:23:23  *** ap4lmtree has quit IRC
  52019-01-07T00:24:58  *** ap4lmtree has joined #bitcoin-core-dev
  62019-01-07T00:27:41  *** ap4lmtree has quit IRC
  72019-01-07T00:28:06  *** ap4lmtree has joined #bitcoin-core-dev
  82019-01-07T00:47:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  92019-01-07T00:56:34  *** promag has quit IRC
 102019-01-07T01:00:17  *** Chris_Stewart_5 has quit IRC
 112019-01-07T01:22:47  *** Victorsueca has quit IRC
 122019-01-07T01:27:45  *** grubles has quit IRC
 132019-01-07T01:28:06  *** Victorsueca has joined #bitcoin-core-dev
 142019-01-07T01:28:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 152019-01-07T01:31:42  *** SatoshiNakamoto has joined #bitcoin-core-dev
 162019-01-07T01:31:50  <SatoshiNakamoto> Thanks
 172019-01-07T01:32:47  <SatoshiNakamoto> Im come back
 182019-01-07T01:36:39  <SatoshiNakamoto> !
 192019-01-07T01:36:42  <SatoshiNakamoto> !!!
 202019-01-07T01:36:42  <lightningbot> SatoshiNakamoto: Error: "!" is not a valid command.
 212019-01-07T01:36:42  <gribble> Error: "!!" is not a valid command.
 222019-01-07T01:36:49  <SatoshiNakamoto> ok
 232019-01-07T01:37:00  <SatoshiNakamoto> Send Bitcoin
 242019-01-07T01:41:08  <fanquake> wumpus / sipa ^
 252019-01-07T01:46:17  *** SatoshiNakamoto has quit IRC
 262019-01-07T01:48:26  *** Chris_Stewart_5 has quit IRC
 272019-01-07T01:48:51  *** justanotheruser has quit IRC
 282019-01-07T01:51:48  *** grubles has joined #bitcoin-core-dev
 292019-01-07T02:18:46  *** ap4lmtree has quit IRC
 302019-01-07T02:19:17  *** ap4lmtree has joined #bitcoin-core-dev
 312019-01-07T02:24:14  *** justanotheruser has joined #bitcoin-core-dev
 322019-01-07T02:26:20  *** ap4lmtree has quit IRC
 332019-01-07T02:46:56  *** AaronvanW has joined #bitcoin-core-dev
 342019-01-07T03:06:28  *** AaronvanW has quit IRC
 352019-01-07T03:09:01  *** Phungmobile has quit IRC
 362019-01-07T03:20:59  *** ap4lmtree has joined #bitcoin-core-dev
 372019-01-07T03:47:01  *** rh0nj has quit IRC
 382019-01-07T04:16:55  *** Eagle[TM] has joined #bitcoin-core-dev
 392019-01-07T04:19:14  *** EagleTM has quit IRC
 402019-01-07T04:37:52  *** TD-Linux has quit IRC
 412019-01-07T04:40:20  *** TD-Linux has joined #bitcoin-core-dev
 422019-01-07T05:07:08  *** Klox has quit IRC
 432019-01-07T05:07:43  *** Klox has joined #bitcoin-core-dev
 442019-01-07T05:12:12  *** rex4539 has joined #bitcoin-core-dev
 452019-01-07T05:43:08  *** rh0nj has joined #bitcoin-core-dev
 462019-01-07T06:05:05  *** rex4539 has quit IRC
 472019-01-07T06:29:32  <fanquake> promag re your Windows testing questions, I've added a VM setup guide (for native builds) here: https://github.com/fanquake/core-review/blob/master/windows.md
 482019-01-07T06:30:56  *** DougieBot5000_ has joined #bitcoin-core-dev
 492019-01-07T06:33:14  *** bitcoin-git has joined #bitcoin-core-dev
 502019-01-07T06:33:14  <bitcoin-git> [bitcoin] jimpo opened pull request #15118: Flatfile (master...flatfile) https://github.com/bitcoin/bitcoin/pull/15118
 512019-01-07T06:33:14  *** bitcoin-git has left #bitcoin-core-dev
 522019-01-07T06:33:27  *** DougieBot5000 has quit IRC
 532019-01-07T06:40:01  *** Euclid2010 has joined #bitcoin-core-dev
 542019-01-07T06:40:31  *** wolfspraul has quit IRC
 552019-01-07T06:40:38  *** wolfspraul has joined #bitcoin-core-dev
 562019-01-07T06:45:15  <Euclid2010> Hello guys I have an old wallet back in 2011 I want to access funds in the wallet now however the wallet is password encrypted and I forgot the password I suppose I can erase the password in db4.8_dump however upon doing so the receiving address change in sending address does anyone know a way to work around this problem?
 572019-01-07T06:46:26  <luke-jr> Euclid2010: it's impossible
 582019-01-07T06:46:49  <luke-jr> the only way to access an encrypted wallet, is to have the password
 592019-01-07T06:47:02  <luke-jr> also, this is not the right channel for this conversation - move to #bitcoin with it please
 602019-01-07T06:47:57  <Euclid2010> I also ask the same question in #bitcoin pardon.
 612019-01-07T07:23:14  *** Eagle[TM] has quit IRC
 622019-01-07T07:47:10  *** TX1683 has quit IRC
 632019-01-07T07:48:54  *** TX1683 has joined #bitcoin-core-dev
 642019-01-07T07:48:59  *** Euclid2010 has left #bitcoin-core-dev
 652019-01-07T07:50:40  *** TX1683 has quit IRC
 662019-01-07T07:51:00  *** TX1683 has joined #bitcoin-core-dev
 672019-01-07T08:28:35  *** jungly has joined #bitcoin-core-dev
 682019-01-07T08:40:09  *** hebasto has joined #bitcoin-core-dev
 692019-01-07T09:02:22  *** promag_ has joined #bitcoin-core-dev
 702019-01-07T09:05:43  <promag_> fanquake: cool thanks
 712019-01-07T09:09:01  *** setpill has joined #bitcoin-core-dev
 722019-01-07T09:32:28  *** CodeBlue1776 has quit IRC
 732019-01-07T09:32:58  *** CodeBlue1776 has joined #bitcoin-core-dev
 742019-01-07T09:34:09  *** echonaut has quit IRC
 752019-01-07T09:34:21  *** echonaut has joined #bitcoin-core-dev
 762019-01-07T09:44:02  *** rh0nj has quit IRC
 772019-01-07T09:45:08  *** rh0nj has joined #bitcoin-core-dev
 782019-01-07T09:45:41  *** Guyver2 has joined #bitcoin-core-dev
 792019-01-07T09:45:47  *** rex4539 has joined #bitcoin-core-dev
 802019-01-07T09:47:51  <promag_> #12153 ready to merge?
 812019-01-07T09:47:53  <gribble> https://github.com/bitcoin/bitcoin/issues/12153 | Avoid permanent cs_main lock in getblockheader by promag · Pull Request #12153 · bitcoin/bitcoin · GitHub
 822019-01-07T09:49:37  *** promag_ has quit IRC
 832019-01-07T09:55:15  *** Freed has joined #bitcoin-core-dev
 842019-01-07T10:01:15  *** Freed has quit IRC
 852019-01-07T10:06:11  *** aqquadro has joined #bitcoin-core-dev
 862019-01-07T10:06:11  *** aqquadro has joined #bitcoin-core-dev
 872019-01-07T10:17:41  *** promag_ has joined #bitcoin-core-dev
 882019-01-07T10:19:08  <fanquake> promag_ looks like it will be
 892019-01-07T10:20:20  <luke-jr> is Travis fubar'd again? got functional tests failing from Qt-only changes..
 902019-01-07T10:20:31  *** promag_ has quit IRC
 912019-01-07T10:28:03  *** rafalcpp has quit IRC
 922019-01-07T10:28:03  *** queip has quit IRC
 932019-01-07T10:29:40  <fanquake> Could be GitHub, I'm seeing unicorns occasionally.
 942019-01-07T10:30:18  *** promag_ has joined #bitcoin-core-dev
 952019-01-07T10:31:04  <luke-jr> nah, GitHub wouldn't cause PSBT tests to fail
 962019-01-07T10:31:15  <luke-jr> and feature_shutdown O.o
 972019-01-07T10:34:26  *** promag_ has quit IRC
 982019-01-07T10:38:34  *** promag_ has joined #bitcoin-core-dev
 992019-01-07T10:39:45  *** cmdpwnd has joined #bitcoin-core-dev
1002019-01-07T10:40:01  *** promag_ has quit IRC
1012019-01-07T10:40:20  *** timothy has joined #bitcoin-core-dev
1022019-01-07T10:41:20  *** spinza has quit IRC
1032019-01-07T10:45:03  *** spinza has joined #bitcoin-core-dev
1042019-01-07T10:45:08  *** cluelessperson has quit IRC
1052019-01-07T10:45:53  *** rafalcpp has joined #bitcoin-core-dev
1062019-01-07T10:46:15  *** queip has joined #bitcoin-core-dev
1072019-01-07T10:48:12  *** promag_ has joined #bitcoin-core-dev
1082019-01-07T10:50:27  *** promag_ has quit IRC
1092019-01-07T10:50:54  *** promag_ has joined #bitcoin-core-dev
1102019-01-07T10:51:10  *** cmdpwnd has quit IRC
1112019-01-07T10:51:15  <luke-jr> yeah, retrying fixed it for now :x
1122019-01-07T10:54:48  *** cluelessperson has joined #bitcoin-core-dev
1132019-01-07T11:05:27  <promag_> luke-jr: is your branch rebased?
1142019-01-07T11:06:23  <promag_> luke-jr: nevermind, it is
1152019-01-07T11:06:59  <promag_> luke-jr: you might want to try #14958
1162019-01-07T11:07:01  <gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
1172019-01-07T11:07:08  <promag_> s/try/review x)
1182019-01-07T11:08:52  *** bitcoin-git has joined #bitcoin-core-dev
1192019-01-07T11:08:52  <bitcoin-git> [bitcoin] thedevworks closed pull request #15105: gui: Use MINUS (U+2212) instead of HYPHEN-MINUS (U+002D) (master...2019-1-4-hyphenminus) https://github.com/bitcoin/bitcoin/pull/15105
1202019-01-07T11:08:52  *** bitcoin-git has left #bitcoin-core-dev
1212019-01-07T11:11:27  <luke-jr> promag_: why would it ever get to the stop before everything else is done? O.o
1222019-01-07T11:16:50  <promag_> because Thread(...).start() is async?
1232019-01-07T11:17:10  <promag_> and then it calls stop_node
1242019-01-07T11:17:56  <promag_> at that point waitfornewblock may or not be running
1252019-01-07T11:18:09  <promag_> that's the race
1262019-01-07T11:18:37  <promag_> that 14958 ensures it's running
1272019-01-07T11:28:27  *** elichai2 has joined #bitcoin-core-dev
1282019-01-07T11:48:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1292019-01-07T12:01:06  *** bitcoin-git has joined #bitcoin-core-dev
1302019-01-07T12:01:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c719987718d...295a1ad52235
1312019-01-07T12:01:07  <bitcoin-git> bitcoin/master fac4e73 MarcoFalke: test: Run invalid_txs.InputMissing test in feature_block
1322019-01-07T12:01:08  <bitcoin-git> bitcoin/master 295a1ad MarcoFalke: Merge #15102: test: Run invalid_txs.InputMissing test in feature_block...
1332019-01-07T12:01:08  *** bitcoin-git has left #bitcoin-core-dev
1342019-01-07T12:01:49  *** bitcoin-git has joined #bitcoin-core-dev
1352019-01-07T12:01:49  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15102: test: Run invalid_txs.InputMissing test in feature_block (master...Mf1901-testInputMissing) https://github.com/bitcoin/bitcoin/pull/15102
1362019-01-07T12:01:49  *** bitcoin-git has left #bitcoin-core-dev
1372019-01-07T12:04:03  *** promag_ has quit IRC
1382019-01-07T12:22:25  <provoostenator> promag: the test suite uses the new "wait" parameter, which then causes old node versions to throw an error. I just added versions to the testnode class.
1392019-01-07T12:22:34  <provoostenator> *promag_
1402019-01-07T12:48:12  *** promag_ has joined #bitcoin-core-dev
1412019-01-07T12:49:37  *** promag_ has quit IRC
1422019-01-07T12:52:01  *** promag_ has joined #bitcoin-core-dev
1432019-01-07T12:53:34  *** promag_ has quit IRC
1442019-01-07T12:54:42  *** TX1683 has quit IRC
1452019-01-07T13:02:35  *** Chris_Stewart_5 has quit IRC
1462019-01-07T13:05:46  *** TX1683 has joined #bitcoin-core-dev
1472019-01-07T13:07:31  *** promag_ has joined #bitcoin-core-dev
1482019-01-07T13:08:23  <fanquake> wumpus: #15110, 15094 mergable. Maybe 12153 too.
1492019-01-07T13:08:25  <gribble> https://github.com/bitcoin/bitcoin/issues/15110 | build_msvc: Fix the build problem in libbitcoin_server by Mr-Leshiy · Pull Request #15110 · bitcoin/bitcoin · GitHub
1502019-01-07T13:08:57  <wumpus> fanquake: thanks!
1512019-01-07T13:11:07  <wumpus> does anyone disagree with giving fanquake ops here? would help if he can kick out the satoshi jokers in the middle of the (european) night
1522019-01-07T13:13:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1532019-01-07T13:31:26  *** TX1683 has quit IRC
1542019-01-07T13:32:50  <wumpus> 15110 doesn't have a single (utACK), I can't test anything MSVC either
1552019-01-07T13:33:03  <wumpus> oh you tested, nm
1562019-01-07T13:33:28  *** TX1683 has joined #bitcoin-core-dev
1572019-01-07T13:34:15  *** bitcoin-git has joined #bitcoin-core-dev
1582019-01-07T13:34:16  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/295a1ad52235...f0fa6bad00f1
1592019-01-07T13:34:17  <bitcoin-git> bitcoin/master c98f886 Alexey Poghilenkov: Fix the build problem in libbitcoin_server
1602019-01-07T13:34:17  <bitcoin-git> bitcoin/master f0fa6ba Wladimir J. van der Laan: Merge #15110: build_msvc: Fix the build problem in libbitcoin_server...
1612019-01-07T13:34:18  *** bitcoin-git has left #bitcoin-core-dev
1622019-01-07T13:35:00  *** bitcoin-git has joined #bitcoin-core-dev
1632019-01-07T13:35:01  <bitcoin-git> [bitcoin] laanwj closed pull request #15110: build_msvc: Fix the build problem in libbitcoin_server (master...MrLeshiy_Fix_Build) https://github.com/bitcoin/bitcoin/pull/15110
1642019-01-07T13:35:01  *** bitcoin-git has left #bitcoin-core-dev
1652019-01-07T13:36:59  <fanquake> Surprisingly, getting the native windows builds setup wasn't as difficult as I expected
1662019-01-07T13:37:10  <cdecker> +1 on ops for fanquake :-)
1672019-01-07T13:37:25  <fanquake> Although nearly managed to run out of room in the VM <.<
1682019-01-07T13:39:48  *** spaced0ut has joined #bitcoin-core-dev
1692019-01-07T13:43:29  *** bitcoin-git has joined #bitcoin-core-dev
1702019-01-07T13:43:29  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5ff7b372cdbd...0a0b2ea11fde
1712019-01-07T13:43:30  <bitcoin-git> bitcoin/0.17 59dd855 Ben Carman: gui: Fix for Incorrect application name when passing -regtest...
1722019-01-07T13:43:31  <bitcoin-git> bitcoin/0.17 0a0b2ea Wladimir J. van der Laan: Merge #15094: 0.17: Backport for #15085...
1732019-01-07T13:43:31  *** bitcoin-git has left #bitcoin-core-dev
1742019-01-07T13:49:04  *** Chris_Stewart_5 has quit IRC
1752019-01-07T13:50:48  *** jungly has quit IRC
1762019-01-07T13:51:58  *** jungly has joined #bitcoin-core-dev
1772019-01-07T13:53:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1782019-01-07T13:59:56  *** Chris_Stewart_5 has quit IRC
1792019-01-07T14:00:20  *** spinza has quit IRC
1802019-01-07T14:11:37  *** spinza has joined #bitcoin-core-dev
1812019-01-07T14:24:32  <provoostenator> ACK fanquake op
1822019-01-07T14:24:48  <provoostenator> Well, concept ACK, since I can't verify his identity on IRC :-)
1832019-01-07T14:30:23  <wumpus> hehe
1842019-01-07T14:30:56  *** TX1683_ has joined #bitcoin-core-dev
1852019-01-07T14:33:39  *** booyah has quit IRC
1862019-01-07T14:34:06  *** TX1683 has quit IRC
1872019-01-07T14:34:06  *** TX1683_ is now known as TX1683
1882019-01-07T14:34:25  *** booyah has joined #bitcoin-core-dev
1892019-01-07T14:40:34  *** promag_ has joined #bitcoin-core-dev
1902019-01-07T14:42:59  *** bitcoin-git has joined #bitcoin-core-dev
1912019-01-07T14:43:00  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0fa6bad00f1...fcc618d508e6
1922019-01-07T14:43:00  <bitcoin-git> bitcoin/master fab3f14 MarcoFalke: rpc: Document bytessent_per_msg and bytesrecv_per_msg
1932019-01-07T14:43:01  <bitcoin-git> bitcoin/master fcc618d Wladimir J. van der Laan: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg...
1942019-01-07T14:43:01  *** bitcoin-git has left #bitcoin-core-dev
1952019-01-07T14:43:47  *** bitcoin-git has joined #bitcoin-core-dev
1962019-01-07T14:43:48  <bitcoin-git> [bitcoin] laanwj closed pull request #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg (master...Mf1901-docRpcGetPeerInfo) https://github.com/bitcoin/bitcoin/pull/15078
1972019-01-07T14:43:48  *** bitcoin-git has left #bitcoin-core-dev
1982019-01-07T14:47:08  *** justanotheruser has quit IRC
1992019-01-07T14:56:37  *** bitcoin-git has joined #bitcoin-core-dev
2002019-01-07T14:56:38  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fcc618d508e6...1973257da050
2012019-01-07T14:56:38  <bitcoin-git> bitcoin/master fa38d3d MarcoFalke: [rpc] Correct reconsiderblock help text, add test
2022019-01-07T14:56:38  <bitcoin-git> bitcoin/master 1973257 Wladimir J. van der Laan: Merge #15057: [rpc] Correct reconsiderblock help text, add test...
2032019-01-07T14:56:39  *** bitcoin-git has left #bitcoin-core-dev
2042019-01-07T14:57:27  *** bitcoin-git has joined #bitcoin-core-dev
2052019-01-07T14:57:27  <bitcoin-git> [bitcoin] laanwj closed pull request #15057: [rpc] Correct reconsiderblock help text, add test (master...Mf1608-qaAssert) https://github.com/bitcoin/bitcoin/pull/15057
2062019-01-07T14:57:27  *** bitcoin-git has left #bitcoin-core-dev
2072019-01-07T14:59:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2082019-01-07T15:06:23  *** promag_ has quit IRC
2092019-01-07T15:07:33  *** promag_ has joined #bitcoin-core-dev
2102019-01-07T15:09:17  *** setpill has quit IRC
2112019-01-07T15:21:05  *** baroda has joined #bitcoin-core-dev
2122019-01-07T15:33:58  *** aqquadro has quit IRC
2132019-01-07T15:35:20  *** michaelsdunn1 has joined #bitcoin-core-dev
2142019-01-07T15:46:00  <promag_> +1 op for fanquake
2152019-01-07T15:46:52  <promag_> provoostenator: oh I see
2162019-01-07T15:55:19  *** promag_ is now known as promag
2172019-01-07T16:08:49  *** jungly has quit IRC
2182019-01-07T16:10:50  *** brickinedifice has joined #bitcoin-core-dev
2192019-01-07T16:15:33  *** brickinedifice has quit IRC
2202019-01-07T16:19:21  <promag> provoostenator: regarding "it tends to return "unable to".", where do you get that?
2212019-01-07T16:21:28  <provoostenator> If I do "unloadwallet B" in the GUI console I get "Cannot unload the requested wallet (code -8)". It works from command line though.
2222019-01-07T16:21:29  *** owowo has joined #bitcoin-core-dev
2232019-01-07T16:22:16  *** dviola has joined #bitcoin-core-dev
2242019-01-07T16:23:05  <promag> provoostenator: right, because you have a wallet selected
2252019-01-07T16:23:27  <promag> just run "unloadwallet" to unload the current selected wallet
2262019-01-07T16:23:48  <promag> or select "None" and run "unloadwallet B" to unload that wallet
2272019-01-07T16:24:20  <promag> that's why I'm changing this https://github.com/bitcoin/bitcoin/pull/15101#discussion_r245687054
2282019-01-07T16:25:26  <provoostenator> promag: selecting wallet B in the main GUI doesn't help. Selecting any of the wallets or no wallet in console UI doesn't help.
2292019-01-07T16:25:45  <promag> not in the mainwindow, but in the console
2302019-01-07T16:26:02  <provoostenator> Doesn't matter what I select there, same error
2312019-01-07T16:26:11  <promag> huh, let me see
2322019-01-07T16:26:12  <provoostenator> Oh no
2332019-01-07T16:26:24  <provoostenator> Now it's working for None, I'm pretty sure it complained before.
2342019-01-07T16:26:45  <provoostenator> Crash
2352019-01-07T16:26:52  <provoostenator> When I load it again
2362019-01-07T16:26:57  <provoostenator> And then unload with None
2372019-01-07T16:27:07  <provoostenator> May want to double check that area of the code (this was on your branch).
2382019-01-07T16:27:21  <promag> let me try to reproduce
2392019-01-07T16:27:49  <provoostenator> My bitcoin.conf has one wallet in it, called A (in case that matters). I then just load and unload wallet B a bunch of times from the GUI console..
2402019-01-07T16:28:09  <provoostenator> "pointer being freed was not allocated"
2412019-01-07T16:28:49  <promag> yup, got it
2422019-01-07T16:29:29  <provoostenator> Yeah, it's pretty easy to reproduce.
2432019-01-07T16:30:35  *** millerti has joined #bitcoin-core-dev
2442019-01-07T16:42:00  <promag> provoostenator: pushed a fix, let me know how it looks
2452019-01-07T16:44:01  *** jungly has joined #bitcoin-core-dev
2462019-01-07T16:45:47  <promag> provoostenator: pushed a fix, let me know how it looks
2472019-01-07T16:48:51  *** Murch has joined #bitcoin-core-dev
2482019-01-07T16:50:02  <promag> dejavu
2492019-01-07T16:55:01  *** rh0nj has quit IRC
2502019-01-07T16:58:07  *** rh0nj has joined #bitcoin-core-dev
2512019-01-07T17:01:34  *** aqquadro has joined #bitcoin-core-dev
2522019-01-07T17:01:34  *** aqquadro has joined #bitcoin-core-dev
2532019-01-07T17:04:00  <jimpo> gmaxwall Regarding block filter construction, would you prefer that be in the block validation ConnectBlock code path instead of a separate index?
2542019-01-07T17:07:47  *** bitcoin-git has joined #bitcoin-core-dev
2552019-01-07T17:07:47  <bitcoin-git> [bitcoin] jnewbery opened pull request #15122: [docs] Expand release notes for importmulti changes (master...pr14565_release_notes) https://github.com/bitcoin/bitcoin/pull/15122
2562019-01-07T17:07:47  *** bitcoin-git has left #bitcoin-core-dev
2572019-01-07T17:13:21  *** rex4539 has quit IRC
2582019-01-07T17:19:40  *** aqquadro has quit IRC
2592019-01-07T17:34:53  *** baroda has quit IRC
2602019-01-07T18:05:41  *** jungly has quit IRC
2612019-01-07T18:07:25  *** timothy has quit IRC
2622019-01-07T18:09:09  *** hebasto has quit IRC
2632019-01-07T18:11:46  *** rex4539 has joined #bitcoin-core-dev
2642019-01-07T18:20:47  *** Chris_Stewart_5 has quit IRC
2652019-01-07T18:21:44  *** jarthur has joined #bitcoin-core-dev
2662019-01-07T18:24:36  *** relligions has joined #bitcoin-core-dev
2672019-01-07T18:24:38  <relligions> hi
2682019-01-07T18:24:54  <relligions> which is the general #altcoins chanel, it seems gone?
2692019-01-07T18:25:47  <relligions> phantomcircuit: where is the general crypto chat channel
2702019-01-07T18:26:07  <luke-jr> ##altcoin-dev
2712019-01-07T18:26:18  *** spaced0ut has quit IRC
2722019-01-07T18:26:29  <relligions> no it's a dev channel, the old one ##altcoins seems to be gone for users not devs
2732019-01-07T18:26:55  *** spaced0ut has joined #bitcoin-core-dev
2742019-01-07T18:27:54  <relligions> luke-jr: bch is bitcoin
2752019-01-07T18:28:03  <relligions> I got banned on #bitcoin for discussing bch
2762019-01-07T18:28:19  <relligions> lightning network is clearly not the Satoshi's bitcoin
2772019-01-07T18:28:34  <relligions> It's following the original bitcoin protocol
2782019-01-07T18:29:08  <luke-jr> you're about to be banned here too
2792019-01-07T18:29:36  <jarthur> relligions: you probably want #BitcoinCash
2802019-01-07T18:29:37  <relligions> for what
2812019-01-07T18:29:44  <relligions> jarthur: yes!
2822019-01-07T18:30:40  <jarthur> relligions: this is the development/operations channel for a popular Bitcoin reference client, the altcoin chat is off-topic and getting in the way. That's why you'd be banned.
2832019-01-07T18:30:54  <relligions> jarthur exactly!
2842019-01-07T18:31:06  <relligions> so blockstreamcoin is offtopic
2852019-01-07T18:31:12  *** spaced0ut has quit IRC
2862019-01-07T18:31:15  *** ChanServ sets mode: +o luke-jr
2872019-01-07T18:31:17  <relligions> and Satoshi Nakamotos
2882019-01-07T18:31:19  <relligions> is ontopic
2892019-01-07T18:31:20  *** relligions was kicked by luke-jr (trolling)
2902019-01-07T18:31:23  *** luke-jr sets mode: -o luke-jr
2912019-01-07T18:32:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2922019-01-07T18:38:29  *** spaced0ut has joined #bitcoin-core-dev
2932019-01-07T18:49:36  *** Murch has quit IRC
2942019-01-07T18:50:29  *** Murch has joined #bitcoin-core-dev
2952019-01-07T18:58:37  *** bitcoin-git has joined #bitcoin-core-dev
2962019-01-07T18:58:37  <bitcoin-git> [bitcoin] Empact opened pull request #15124: Fail if either disk space check fails (master...disk-space-check) https://github.com/bitcoin/bitcoin/pull/15124
2972019-01-07T18:58:37  *** bitcoin-git has left #bitcoin-core-dev
2982019-01-07T19:08:16  *** Chris_Stewart_5 has quit IRC
2992019-01-07T19:08:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3002019-01-07T19:09:29  *** rex4539 has quit IRC
3012019-01-07T19:10:14  *** rex4539 has joined #bitcoin-core-dev
3022019-01-07T19:10:50  *** Murch has quit IRC
3032019-01-07T19:17:32  *** Murch has joined #bitcoin-core-dev
3042019-01-07T19:19:45  *** drexl has joined #bitcoin-core-dev
3052019-01-07T19:31:31  *** dermoth has quit IRC
3062019-01-07T19:31:59  *** dermoth has joined #bitcoin-core-dev
3072019-01-07T19:36:11  <jamesob> is it a reasonable to say that in general `cd depends && make` is safer than using distro-specific packaging?
3082019-01-07T19:59:53  *** dermoth has quit IRC
3092019-01-07T20:07:56  <wumpus> jamesob: it shouldn't be, really
3102019-01-07T20:08:38  <wumpus> the distro dependencies should be as good, as long as they are at least the versions mentioned as minimum in doc/dependencies.md
3112019-01-07T20:09:30  <wumpus> 'depends' is a tool for convenenience and for building the packaged executables, if it's essential that some dependency matches (such as for secp256k1) the version it's included as subtree
3122019-01-07T20:10:47  <jamesob> as well as for cross-compilation, I guess. gotcha.
3132019-01-07T20:10:59  <jamesob> didn't know if there was some something-something-deterministic-build-something-something going on or planned
3142019-01-07T20:11:16  <jamesob> (have fun parsing that)
3152019-01-07T20:12:21  *** dermoth has joined #bitcoin-core-dev
3162019-01-07T20:13:02  *** rh0nj has quit IRC
3172019-01-07T20:13:45  <wumpus> yup, for cross-compilation it's also useful for convenience, not strictly necessary if you build the other dependencies using say, buildroot, yocto
3182019-01-07T20:15:20  <jamesob> wumpus: thanks
3192019-01-07T20:16:08  *** rh0nj has joined #bitcoin-core-dev
3202019-01-07T20:20:13  <wumpus> deterministic builds that's what gitian is for, which in turn uses depends, using depends on its own is not enough to get deterministic builds
3212019-01-07T20:20:15  *** ddustin_ has quit IRC
3222019-01-07T20:20:44  *** ddustin has joined #bitcoin-core-dev
3232019-01-07T20:24:36  *** EagleTM has joined #bitcoin-core-dev
3242019-01-07T20:25:34  *** ddustin has quit IRC
3252019-01-07T20:36:59  *** Chris_Stewart_5 has quit IRC
3262019-01-07T20:37:47  *** Krellan has quit IRC
3272019-01-07T20:40:57  <jnewbery> meshcollider: what's the eventual plan for private keys in importmulti with descriptors? After #15024, there are two ways of importing the privkeys: either in the descriptor itself or with the keys argument. Would it be better to only allow importing privkeys from the descriptor itself?
3282019-01-07T20:40:59  <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
3292019-01-07T20:42:40  <jnewbery> If you agree, then I think it makes sense to flip the ordering of the PRs (ie reduce 15024 to just commit https://github.com/bitcoin/bitcoin/pull/15024/commits/8a270b9582d82991766172430d508a1a7358e80d and merge that first, and then have 14491 following it)
3302019-01-07T20:45:17  *** gekisai has joined #bitcoin-core-dev
3312019-01-07T21:01:15  *** dviola has quit IRC
3322019-01-07T21:11:54  *** fabianfabian has joined #bitcoin-core-dev
3332019-01-07T21:12:28  <jnewbery> promag: is #13100 blocked on anything?
3342019-01-07T21:12:31  <gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
3352019-01-07T21:14:28  *** ossifrage has quit IRC
3362019-01-07T21:24:29  *** riemann has joined #bitcoin-core-dev
3372019-01-07T21:31:41  *** ExtraCrispy has quit IRC
3382019-01-07T21:32:40  <dongcarl> Is it possible to `-connect` or `-addnode` a node with a custom listening port?
3392019-01-07T21:33:31  <sipa> sure
3402019-01-07T21:33:41  <sipa> use ip:port notation
3412019-01-07T21:33:49  <sipa> or [ip]:port for ipv6
3422019-01-07T21:38:00  <dongcarl> Thanks! Wasn't in the help page I think
3432019-01-07T21:40:06  *** ossifrage has joined #bitcoin-core-dev
3442019-01-07T21:40:13  <sipa> perhaps that should get fixed then
3452019-01-07T21:40:38  *** spinza has quit IRC
3462019-01-07T21:41:17  *** spinza has joined #bitcoin-core-dev
3472019-01-07T21:43:57  *** ExtraCrispy has joined #bitcoin-core-dev
3482019-01-07T21:48:57  *** Krellan has joined #bitcoin-core-dev
3492019-01-07T21:53:07  *** Krellan has quit IRC
3502019-01-07T22:00:40  *** spinza has quit IRC
3512019-01-07T22:03:00  *** rex4539 has quit IRC
3522019-01-07T22:09:25  *** spinza has joined #bitcoin-core-dev
3532019-01-07T22:09:53  *** Tralfaz has quit IRC
3542019-01-07T22:10:00  *** Tralfaz has joined #bitcoin-core-dev
3552019-01-07T22:12:02  *** EagleTM has quit IRC
3562019-01-07T22:14:28  *** Guyver2 has quit IRC
3572019-01-07T22:16:28  *** AaronvanW has joined #bitcoin-core-dev
3582019-01-07T22:17:36  *** AaronvanW has quit IRC
3592019-01-07T22:19:01  *** AaronvanW has joined #bitcoin-core-dev
3602019-01-07T22:20:27  *** Aaronvan_ has joined #bitcoin-core-dev
3612019-01-07T22:21:51  *** arubi has quit IRC
3622019-01-07T22:21:55  *** arubi_ has joined #bitcoin-core-dev
3632019-01-07T22:23:52  *** AaronvanW has quit IRC
3642019-01-07T22:26:18  *** Aaronvan_ has quit IRC
3652019-01-07T22:28:57  <promag> jnewbery: you could look #15101
3662019-01-07T22:28:59  <gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
3672019-01-07T22:36:20  *** riemann has quit IRC
3682019-01-07T22:43:45  *** aqquadro has joined #bitcoin-core-dev
3692019-01-07T22:43:45  *** aqquadro has joined #bitcoin-core-dev
3702019-01-07T22:59:52  <jnewbery> thanks promag. Will check it out tomorrow
3712019-01-07T23:00:36  <promag> jnewbery: cool thanks
3722019-01-07T23:01:26  <promag> jnewbery: after that one the simple ones are "Close Current Wallet" and "Open External Wallet"
3732019-01-07T23:01:51  <promag> jnewbery: "New Wallet" and "Open Wallet" require custom dialog
3742019-01-07T23:03:20  <promag> jnewbery: don't want to push all of this to 13100
3752019-01-07T23:03:39  <promag> jnewbery: btw, you could check #14941 too
3762019-01-07T23:03:41  <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
3772019-01-07T23:11:06  *** keymone has quit IRC
3782019-01-07T23:13:47  *** keymone has joined #bitcoin-core-dev
3792019-01-07T23:14:09  <promag> jimpo: could drop () here https://github.com/bitcoin/bitcoin/pull/15118/files#diff-24efdb00bfbe56b140fb006b562cc70bR314 ?
3802019-01-07T23:15:50  <promag> nevermind
3812019-01-07T23:18:46  *** jarthur has quit IRC
3822019-01-07T23:23:36  *** ossifrage has quit IRC
3832019-01-07T23:24:58  *** Aaronvan_ has joined #bitcoin-core-dev
3842019-01-07T23:25:35  *** Guest988 has joined #bitcoin-core-dev
3852019-01-07T23:26:30  *** justanotheruser has joined #bitcoin-core-dev
3862019-01-07T23:26:57  *** Guest988 has left #bitcoin-core-dev
3872019-01-07T23:29:07  *** Aaronvan_ has quit IRC
3882019-01-07T23:39:15  *** michaelsdunn1 has quit IRC