12019-01-14T00:01:09 *** kexkey has quit IRC
22019-01-14T00:01:17 *** Guyver2 has quit IRC
32019-01-14T00:03:31 *** rh0nj has quit IRC
42019-01-14T00:06:07 *** rh0nj has joined #bitcoin-core-dev
52019-01-14T00:11:41 *** kexkey has joined #bitcoin-core-dev
62019-01-14T00:12:45 *** EagleTM has joined #bitcoin-core-dev
72019-01-14T00:14:56 *** Murch has quit IRC
82019-01-14T00:17:39 *** Murch has joined #bitcoin-core-dev
92019-01-14T00:19:57 *** Murch has quit IRC
102019-01-14T00:32:21 *** Zenton has quit IRC
112019-01-14T00:40:06 *** Chris_Stewart_5 has quit IRC
122019-01-14T00:53:03 *** kexkey has quit IRC
132019-01-14T00:54:26 *** Emcy has quit IRC
142019-01-14T00:57:03 *** Emcy has joined #bitcoin-core-dev
152019-01-14T01:01:34 *** miknotauro has quit IRC
162019-01-14T01:11:54 *** zenogais has quit IRC
172019-01-14T01:13:27 *** EagleTM has quit IRC
182019-01-14T01:14:35 *** drexl has joined #bitcoin-core-dev
192019-01-14T01:16:03 *** DeanGuss has quit IRC
202019-01-14T01:17:02 *** AaronvanW has joined #bitcoin-core-dev
212019-01-14T01:33:19 *** DeanGuss has joined #bitcoin-core-dev
222019-01-14T01:39:12 *** jhfrontz has joined #bitcoin-core-dev
232019-01-14T01:46:08 *** zenogais has joined #bitcoin-core-dev
242019-01-14T01:46:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
252019-01-14T01:47:14 *** AaronvanW has quit IRC
262019-01-14T01:52:02 *** Chris_Stewart_5 has quit IRC
272019-01-14T01:54:26 *** AaronvanW has joined #bitcoin-core-dev
282019-01-14T01:54:38 *** promag has quit IRC
292019-01-14T01:59:02 *** AaronvanW has quit IRC
302019-01-14T02:00:53 *** mistergo1d has quit IRC
312019-01-14T02:19:54 *** pinheadmz has joined #bitcoin-core-dev
322019-01-14T02:25:25 *** echeveria has left #bitcoin-core-dev
332019-01-14T02:26:13 *** AaronvanW has joined #bitcoin-core-dev
342019-01-14T02:30:28 *** AaronvanW has quit IRC
352019-01-14T02:48:53 *** kexkey has joined #bitcoin-core-dev
362019-01-14T02:58:13 *** drexl has quit IRC
372019-01-14T02:58:51 *** AaronvanW has joined #bitcoin-core-dev
382019-01-14T03:09:35 *** pinheadmz has quit IRC
392019-01-14T03:11:47 *** justanotheruser has joined #bitcoin-core-dev
402019-01-14T03:13:05 *** pinheadmz has joined #bitcoin-core-dev
412019-01-14T03:29:53 *** pinheadmz has quit IRC
422019-01-14T03:31:18 *** justanotheruser has quit IRC
432019-01-14T03:32:49 *** AaronvanW has quit IRC
442019-01-14T03:45:35 *** mistergold has joined #bitcoin-core-dev
452019-01-14T03:51:23 *** mistergold has quit IRC
462019-01-14T03:54:07 *** pinheadmz has joined #bitcoin-core-dev
472019-01-14T03:56:25 *** kexkey has quit IRC
482019-01-14T03:58:38 *** kexkey has joined #bitcoin-core-dev
492019-01-14T04:00:08 *** thaumavorio has quit IRC
502019-01-14T04:01:53 *** thaumavorio has joined #bitcoin-core-dev
512019-01-14T04:02:58 <phantomcircuit> sipa, can you find a new host for gods sake, that one is still randomly banning half the internet
522019-01-14T04:07:01 *** rh0nj has quit IRC
532019-01-14T04:08:07 *** rh0nj has joined #bitcoin-core-dev
542019-01-14T04:08:31 <sipa> hmm?
552019-01-14T04:08:34 <sipa> which one?
562019-01-14T04:08:56 <phantomcircuit> bitcoin.sipa.be
572019-01-14T04:10:45 *** ddustin has quit IRC
582019-01-14T04:13:59 *** Bullit has quit IRC
592019-01-14T04:19:12 <sipa> what's wrong with it?
602019-01-14T04:25:35 <phantomcircuit> sipa, it blocks basically any ip that's shared by more than 1 person, including virtually every ipv4 address used by att mobile
612019-01-14T04:27:42 <phantomcircuit> sipa, is there some kind of firewall in their settings or something
622019-01-14T04:30:26 *** rhavar has joined #bitcoin-core-dev
632019-01-14T04:38:32 *** miknotauro has joined #bitcoin-core-dev
642019-01-14T04:40:06 <sipa> phantomcircuit: and what do you think is blocking me?
652019-01-14T04:41:29 <phantomcircuit> sipa, is blocking you?
662019-01-14T04:43:49 <gmaxwell> phantomcircuit: you've got it backwards I think.
672019-01-14T04:44:13 <gmaxwell> The problem is that the seenode domain resolves to "bad hosts" from time to time.
682019-01-14T04:44:35 <gmaxwell> So then this causes shitbag (technical term) ISPs like AT&T mobile to ban the domain.
692019-01-14T04:45:35 <gmaxwell> We've fretted about this before and it was suggested that the IPs returned by the seednodes be obfscuated somehow, but unfortunately many kinds of obfscuation will result in recursive resolvers dropping those results.
702019-01-14T04:45:57 <gmaxwell> (e.g. it's not uncommon for recursive resolvers to drop unroutable IP prefixes.)
712019-01-14T04:47:03 <phantomcircuit> gmaxwell, im talking about bitcoin.sipa.be, which isn't the thing resolving to weird stuff
722019-01-14T04:47:11 <sipa> oh
732019-01-14T04:47:25 <sipa> but maybe by being similar to seed.bitcoin.sipa.be ?
742019-01-14T04:48:06 <gmaxwell> phantomcircuit: I think they block access to the anything at the IP of the nameserver serving it, because they think it's a botnet fast flux control.
752019-01-14T04:49:25 <phantomcircuit> gmaxwell, hmm interesting
762019-01-14T04:52:09 *** justanotheruser has joined #bitcoin-core-dev
772019-01-14T04:56:45 *** AaronvanW has joined #bitcoin-core-dev
782019-01-14T05:01:37 *** Skirmant has quit IRC
792019-01-14T05:04:37 *** pinheadmz has quit IRC
802019-01-14T05:21:30 *** ddustin has joined #bitcoin-core-dev
812019-01-14T05:24:28 *** spinza has quit IRC
822019-01-14T05:27:54 *** AaronvanW has quit IRC
832019-01-14T05:40:31 *** spinza has joined #bitcoin-core-dev
842019-01-14T06:00:01 *** pinheadmz has joined #bitcoin-core-dev
852019-01-14T06:00:08 *** Murch has joined #bitcoin-core-dev
862019-01-14T06:02:08 *** mistergold has joined #bitcoin-core-dev
872019-01-14T06:03:09 *** ap4lmtree has quit IRC
882019-01-14T06:03:36 *** ap4lmtree has joined #bitcoin-core-dev
892019-01-14T06:05:45 *** zenogais has quit IRC
902019-01-14T06:09:58 *** dermoth has quit IRC
912019-01-14T06:10:38 *** dermoth has joined #bitcoin-core-dev
922019-01-14T06:27:42 *** Murch has quit IRC
932019-01-14T06:28:33 *** DeanGuss has quit IRC
942019-01-14T06:34:30 *** pinheadmz has quit IRC
952019-01-14T06:36:55 *** AaronvanW has joined #bitcoin-core-dev
962019-01-14T06:53:42 *** DeanGuss has joined #bitcoin-core-dev
972019-01-14T06:56:58 *** pinheadmz has joined #bitcoin-core-dev
982019-01-14T07:10:10 *** AaronvanW has quit IRC
992019-01-14T07:18:43 *** AaronvanW has joined #bitcoin-core-dev
1002019-01-14T07:23:10 *** AaronvanW has quit IRC
1012019-01-14T07:31:27 *** promag has joined #bitcoin-core-dev
1022019-01-14T07:37:48 *** promag has quit IRC
1032019-01-14T07:41:29 *** Skirmant has joined #bitcoin-core-dev
1042019-01-14T07:53:52 *** AaronvanW has joined #bitcoin-core-dev
1052019-01-14T07:53:59 *** rex4539 has quit IRC
1062019-01-14T07:58:38 *** AaronvanW has quit IRC
1072019-01-14T08:01:04 *** promag has joined #bitcoin-core-dev
1082019-01-14T08:09:02 *** rh0nj has quit IRC
1092019-01-14T08:10:07 *** rh0nj has joined #bitcoin-core-dev
1102019-01-14T08:15:28 *** promag has quit IRC
1112019-01-14T08:20:31 <booyah> fyi going to "http://bitcoin.sipa.be/depths.png" --> "Warning: Unsafe Website Blocked!" (I was redirected to http://warn.recursive.dnsbycomodo.com/?host=bitcoin.sipa.be )
1122019-01-14T08:21:16 <booyah> and same thing for seed.
1132019-01-14T08:23:08 *** pinheadmz has quit IRC
1142019-01-14T08:25:27 *** AaronvanW has joined #bitcoin-core-dev
1152019-01-14T08:32:45 *** promag has joined #bitcoin-core-dev
1162019-01-14T08:37:21 *** promag has quit IRC
1172019-01-14T08:43:09 *** DeanGuss has quit IRC
1182019-01-14T08:57:52 *** guoguo has joined #bitcoin-core-dev
1192019-01-14T08:59:02 *** AaronvanW has quit IRC
1202019-01-14T09:03:23 *** setpill has joined #bitcoin-core-dev
1212019-01-14T09:05:12 *** rafalcpp has quit IRC
1222019-01-14T09:05:13 *** queip has quit IRC
1232019-01-14T09:05:24 *** setpill has quit IRC
1242019-01-14T09:05:44 *** jungly has joined #bitcoin-core-dev
1252019-01-14T09:06:40 *** setpill has joined #bitcoin-core-dev
1262019-01-14T09:09:35 *** rhavar has quit IRC
1272019-01-14T09:18:43 *** rafalcpp has joined #bitcoin-core-dev
1282019-01-14T09:19:07 *** queip has joined #bitcoin-core-dev
1292019-01-14T09:23:05 *** owowo has quit IRC
1302019-01-14T09:38:35 *** Guyver2 has joined #bitcoin-core-dev
1312019-01-14T09:40:09 *** guoguo has quit IRC
1322019-01-14T09:41:24 *** rafalcpp has quit IRC
1332019-01-14T09:41:24 *** queip has quit IRC
1342019-01-14T09:41:32 *** rafalcpp_ has joined #bitcoin-core-dev
1352019-01-14T09:44:44 *** AaronvanW has joined #bitcoin-core-dev
1362019-01-14T09:46:50 *** queip has joined #bitcoin-core-dev
1372019-01-14T09:48:02 *** DeanGuss has joined #bitcoin-core-dev
1382019-01-14T09:48:52 *** Zenton has joined #bitcoin-core-dev
1392019-01-14T09:49:09 *** AaronvanW has quit IRC
1402019-01-14T09:49:15 *** promag has joined #bitcoin-core-dev
1412019-01-14T09:50:31 *** ddustin has quit IRC
1422019-01-14T09:53:45 *** promag has quit IRC
1432019-01-14T10:02:01 *** timothy has joined #bitcoin-core-dev
1442019-01-14T10:02:52 *** kexkey has quit IRC
1452019-01-14T10:16:05 *** promag has joined #bitcoin-core-dev
1462019-01-14T10:16:11 *** AaronvanW has joined #bitcoin-core-dev
1472019-01-14T10:18:03 *** rex4539 has joined #bitcoin-core-dev
1482019-01-14T10:32:34 *** promag has quit IRC
1492019-01-14T10:36:53 *** promag has joined #bitcoin-core-dev
1502019-01-14T10:42:02 *** Dean_Guss has joined #bitcoin-core-dev
1512019-01-14T10:43:17 *** DeanGuss has quit IRC
1522019-01-14T10:51:18 *** AaronvanW has quit IRC
1532019-01-14T10:51:38 *** AaronvanW has joined #bitcoin-core-dev
1542019-01-14T10:55:11 *** Dean_Guss has quit IRC
1552019-01-14T10:56:19 *** Aaronvan_ has joined #bitcoin-core-dev
1562019-01-14T10:57:58 *** AaronvanW has quit IRC
1572019-01-14T10:58:37 *** spinza has quit IRC
1582019-01-14T11:02:47 *** spinza has joined #bitcoin-core-dev
1592019-01-14T11:29:22 *** brianhoffman_ has joined #bitcoin-core-dev
1602019-01-14T11:30:40 *** brianhoffman has quit IRC
1612019-01-14T11:30:40 *** brianhoffman_ is now known as brianhoffman
1622019-01-14T11:39:34 *** AaronvanW has joined #bitcoin-core-dev
1632019-01-14T11:41:03 *** e4xit has joined #bitcoin-core-dev
1642019-01-14T11:42:56 *** Aaronvan_ has quit IRC
1652019-01-14T11:46:37 *** rex4539 has quit IRC
1662019-01-14T11:47:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1672019-01-14T11:48:38 *** rex4539 has joined #bitcoin-core-dev
1682019-01-14T11:49:38 *** fanquake has joined #bitcoin-core-dev
1692019-01-14T11:49:57 *** ap4lmtree has quit IRC
1702019-01-14T11:50:22 <fanquake> wumpus / sipa can you block sinette on GH. Spamming, and by the look of their profile doing in on multiple repos.
1712019-01-14T11:53:21 <wumpus> sure
1722019-01-14T11:55:43 *** rex4539 has quit IRC
1732019-01-14T11:56:59 <wumpus> done
1742019-01-14T11:57:10 *** Aaronvan_ has joined #bitcoin-core-dev
1752019-01-14T12:00:04 *** AaronvanW has quit IRC
1762019-01-14T12:01:12 *** tintin has joined #bitcoin-core-dev
1772019-01-14T12:05:27 *** ExtraCrispy has quit IRC
1782019-01-14T12:05:28 *** arubi has quit IRC
1792019-01-14T12:07:40 *** ExtraCrispy has joined #bitcoin-core-dev
1802019-01-14T12:09:47 *** arubi has joined #bitcoin-core-dev
1812019-01-14T12:13:50 *** e4xit has quit IRC
1822019-01-14T12:24:12 *** pbase has joined #bitcoin-core-dev
1832019-01-14T12:30:54 *** e4xit has joined #bitcoin-core-dev
1842019-01-14T12:33:27 *** ap4lmtree has joined #bitcoin-core-dev
1852019-01-14T12:33:53 <pbase> what should be the starting point to start understanding the bitcoin-core code?
1862019-01-14T12:35:04 *** Aaronvan_ is now known as AaronvanW
1872019-01-14T12:36:08 *** keymone has quit IRC
1882019-01-14T12:42:06 *** promag has quit IRC
1892019-01-14T12:46:15 *** keymone has joined #bitcoin-core-dev
1902019-01-14T12:48:23 <wumpus> pbase: what part are you interested in?
1912019-01-14T12:48:50 *** promag has joined #bitcoin-core-dev
1922019-01-14T12:49:02 <wumpus> validation, the wallet, etc, that already provides a place to start looking
1932019-01-14T12:49:10 <pbase> wumpus, i intend to create a decentralized identity system from it
1942019-01-14T12:49:21 <pbase> wumpus, so guess all the components
1952019-01-14T12:50:03 <pbase> will have to forgo anonymity
1962019-01-14T12:53:52 *** promag has quit IRC
1972019-01-14T12:56:52 *** Chris_Stewart_5 has quit IRC
1982019-01-14T13:00:11 *** rex4539 has joined #bitcoin-core-dev
1992019-01-14T13:02:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2002019-01-14T13:06:27 <pbase> Will it be a good idea to start from the first version of the code?
2012019-01-14T13:08:48 *** rex4539 has quit IRC
2022019-01-14T13:10:40 *** Chris_Stewart_5 has quit IRC
2032019-01-14T13:16:26 *** schnerchi has joined #bitcoin-core-dev
2042019-01-14T13:27:26 *** luke-jr has quit IRC
2052019-01-14T13:30:05 *** fanquake has quit IRC
2062019-01-14T13:46:23 <wumpus> pbase: not necessarily, newer versions tend to have more code, but also cleaned up a lot of the code, made better abstractions, and so on
2072019-01-14T13:47:06 <wumpus> and better comments (hopefully)
2082019-01-14T13:56:14 *** luke-jr has joined #bitcoin-core-dev
2092019-01-14T14:01:59 *** rex4539 has joined #bitcoin-core-dev
2102019-01-14T14:02:31 *** promag has joined #bitcoin-core-dev
2112019-01-14T14:15:06 <promag> what's the deal with travis failures?
2122019-01-14T14:15:19 <wumpus> I don't knowâ¦
2132019-01-14T14:15:24 <promag> "SC2236: Use -z instead of ! -n"
2142019-01-14T14:15:33 <promag> https://travis-ci.org/bitcoin/bitcoin/jobs/479413409
2152019-01-14T14:16:18 *** rex4539 has quit IRC
2162019-01-14T14:16:19 <wumpus> it's not failing on master is it?
2172019-01-14T14:16:29 <wumpus> not getting mails at least
2182019-01-14T14:16:59 <promag> update to shellcheck?
2192019-01-14T14:18:43 <promag> doesn't look like
2202019-01-14T14:19:36 <wumpus> please not another linter issue I can't survive this...
2212019-01-14T14:21:08 <promag> keep calm and fix linter
2222019-01-14T14:23:28 *** kexkey has joined #bitcoin-core-dev
2232019-01-14T14:24:01 <wumpus> rm -rf /linters
2242019-01-14T14:24:12 <promag> path not found
2252019-01-14T14:24:27 <promag> well honestly I like linters
2262019-01-14T14:24:44 <wumpus> everyone does but me
2272019-01-14T14:24:59 <promag> most of the time they play on our side
2282019-01-14T14:25:38 <promag> on my system it's "version: 0.4.7", on travis 0.6.0
2292019-01-14T14:27:13 <promag> weird, that's not on bionic
2302019-01-14T14:27:26 <promag> where does that come from?
2312019-01-14T14:28:04 <wumpus> I like static checking that finds bugs, or rules out classes of bugs. What I don't like is test failures because of what are essentially style suggestions.
2322019-01-14T14:28:41 <wumpus> ! -n is perfectly fine, yes -z is shorter no shit no that's not something that needs to be fixed
2332019-01-14T14:28:42 <gribble> Error: "-n" is not a valid command.
2342019-01-14T14:29:32 <promag> ok, upgraded shellcheck to 0.6.1 and got that error
2352019-01-14T14:31:30 *** michaelfolkson has joined #bitcoin-core-dev
2362019-01-14T14:31:38 <promag> pushing fix
2372019-01-14T14:32:06 <wumpus> I think SC2236 needs to be added to 'shellcheck -e ...'. though if they change the shellcheck version arbitrarily it'd be better to list the cases that should be checked inclusively, instead of excluding certain checks
2382019-01-14T14:32:34 <promag> yes
2392019-01-14T14:32:46 *** Tralfaz has joined #bitcoin-core-dev
2402019-01-14T14:33:50 <wumpus> https://github.com/bitcoin/bitcoin/commit/908a559f33 is similar
2412019-01-14T14:34:32 *** michaelfolkson has quit IRC
2422019-01-14T14:36:24 *** michaelfolkson has joined #bitcoin-core-dev
2432019-01-14T14:37:46 <promag> #15164
2442019-01-14T14:37:47 <gribble> https://github.com/bitcoin/bitcoin/issues/15164 | qa: Ignore shellcheck warning SC2236 by promag · Pull Request #15164 · bitcoin/bitcoin · GitHub
2452019-01-14T14:42:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2462019-01-14T14:42:48 *** guga has joined #bitcoin-core-dev
2472019-01-14T14:44:03 <wumpus> I'm confused by #15104, how can adding unit tests *decrease* test coverage
2482019-01-14T14:44:04 <gribble> https://github.com/bitcoin/bitcoin/issues/15104 | Tests: Add unit testing for the CompressScript function by mmachicao · Pull Request #15104 · bitcoin/bitcoin · GitHub
2492019-01-14T14:52:23 <promag> wumpus: green https://travis-ci.org/bitcoin/bitcoin/jobs/479425164
2502019-01-14T14:52:30 <wumpus> good
2512019-01-14T14:57:03 <wumpus> $ ../devtools/github-merge.py 15164
2522019-01-14T14:57:05 <wumpus> Warning: unable to retrieve pull information from github: HTTP Error 403: Forbidden
2532019-01-14T14:57:21 <wumpus> this happens a lot lately, did github change the request limits?
2542019-01-14T14:57:56 <wumpus> --might make sense to add reporting of the detailed http error to gh-merge
2552019-01-14T15:03:22 *** setpill has quit IRC
2562019-01-14T15:03:51 *** jhfrontz has quit IRC
2572019-01-14T15:05:25 *** jhfrontz has joined #bitcoin-core-dev
2582019-01-14T15:08:22 *** spaced0ut has joined #bitcoin-core-dev
2592019-01-14T15:09:41 <promag> https://developer.github.com/v3/#rate-limiting
2602019-01-14T15:09:49 <promag> do you exceed 5000req/hr?
2612019-01-14T15:09:58 <wumpus> yep... "message":"API rate limit exceeded for X.X.X.X"
2622019-01-14T15:10:28 <wumpus> eh definitely not
2632019-01-14T15:10:39 <promag> it counts all your requests
2642019-01-14T15:11:14 <promag> "all OAuth applications authorized by a user share the same quota of 5000 requests per hour when they authenticate with different tokens owned by the same user."
2652019-01-14T15:12:02 <wumpus> this is for *authenticated requests*? FWIW, that script uses unauthenticated ones
2662019-01-14T15:12:54 <promag> then it's 60 requests per hour
2672019-01-14T15:13:39 <wumpus> that's still somewhat unlikely but of a more realistic magnitude
2682019-01-14T15:13:45 <promag> but it could use your PAT?
2692019-01-14T15:14:32 <promag> it's for retrieve_pr_info?
2702019-01-14T15:15:04 *** testbot_ has joined #bitcoin-core-dev
2712019-01-14T15:15:34 <wumpus> req = Request("https://api.github.com/repos/"+repo+"/pulls/"+pull)
2722019-01-14T15:15:48 <wumpus> yes
2732019-01-14T15:15:57 *** testbot_ has quit IRC
2742019-01-14T15:16:19 <wumpus> hi testbot_
2752019-01-14T15:17:59 <wumpus> just going to patch it locally for now to put in my token
2762019-01-14T15:23:12 <wumpus> that works !
2772019-01-14T15:23:37 <promag> \o/
2782019-01-14T15:31:30 *** miknotauro has quit IRC
2792019-01-14T15:51:00 *** michaelsdunn1 has joined #bitcoin-core-dev
2802019-01-14T15:54:45 <promag> wumpus: I don't think we should encourage that
2812019-01-14T15:54:55 <promag> .. git config for secrets
2822019-01-14T15:57:06 <promag> I'd say something like "set environment variable GITHUB_TOKEN with Github Personal Access Token to overcome API rate limits"
2832019-01-14T15:58:42 <wumpus> environment variables are not better!
2842019-01-14T15:58:56 <wumpus> FWIW what i have myself is
2852019-01-14T15:58:58 <wumpus> [include]
2862019-01-14T15:59:00 <wumpus> path = ~/.gitsecrets
2872019-01-14T16:00:18 <promag> wumpus: I don't mean to have the envvar in the shell
2882019-01-14T16:00:21 <wumpus> but I thought that would be overly pedantic to suggest in the documentation, this is a token without privileges
2892019-01-14T16:00:41 <promag> is it?
2902019-01-14T16:00:46 <wumpus> yes
2912019-01-14T16:01:48 <wumpus> where else would you have environment variables than in the shell? it's often possible to get the envvars in 'ps' output on a shared system, at least configuration files can be set with appropriate permissions
2922019-01-14T16:02:32 <promag> I mean PAT=(securely get my pat) ./gh-merge
2932019-01-14T16:02:38 <wumpus> then agian, I don't feel like having an argument about this, closing that PR if this is controversial
2942019-01-14T16:03:16 <promag> don't do that
2952019-01-14T16:03:20 <wumpus> promag: that has the same result! and do you want to copy/paste the token every time you use the script?
2962019-01-14T16:05:58 <wumpus> also that exposes it to shoulder surfers
2972019-01-14T16:06:14 <promag> PAT=(run-command-to-securely-get-my-pat) ./gh-merge is unsecure? anyway I'm too dumb in this regard.. :P
2982019-01-14T16:07:27 <wumpus> I thought about suggesting to add the token in the *local* git config, might be less likely to accidentally check that in
2992019-01-14T16:07:55 <wumpus> (e.g. it's part of the .git directory so I don't think you even can)
3002019-01-14T16:08:17 <promag> https://stackoverflow.com/a/51505417
3012019-01-14T16:08:18 *** pbase has quit IRC
3022019-01-14T16:08:25 <wumpus> for me, though, it's much more useful to have it globally available
3032019-01-14T16:08:42 <wumpus> (I use the tool for more repos)
3042019-01-14T16:09:27 <promag> err nevermind that, that's for git via http iiuc
3052019-01-14T16:10:33 <promag> moving forward X)
3062019-01-14T16:11:22 <wumpus> promag: I don't know, I might be confused too, but isn't this what 'ps e' is?
3072019-01-14T16:11:54 <promag> mother-of-god
3082019-01-14T16:12:09 <promag> back to linux for dummies
3092019-01-14T16:12:16 *** rabidus has quit IRC
3102019-01-14T16:12:56 *** michaelfolkson has quit IRC
3112019-01-14T16:14:03 *** rabidus has joined #bitcoin-core-dev
3122019-01-14T16:18:43 *** tintin has quit IRC
3132019-01-14T16:20:57 <promag> wumpus: since you utACK on #14941 do you mind weight about ryanofsky suggestion?
3142019-01-14T16:21:01 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
3152019-01-14T16:22:11 <wumpus> promag: will take a look
3162019-01-14T16:22:17 <promag> ty
3172019-01-14T16:33:07 <wumpus> promag: he makes a valid suggestion IMO, no strong opinion on it, I'd slightly prefer simpler code (I don't think it's too bad that the last RPC wallet call, if it's still in progress, has to wait too -- I think it is unlikely in practice that that happens at the same time)
3182019-01-14T16:33:51 <promag> wumpus: yap, I agree with you all
3192019-01-14T16:34:13 <promag> if that turns to be a problem then it can be avoided
3202019-01-14T16:40:14 <MarcoFalke> [09:44] <wumpus> I'm confused by #15104, how can adding unit tests *decrease* test coverage
3212019-01-14T16:40:15 <gribble> https://github.com/bitcoin/bitcoin/issues/15104 | Tests: Add unit testing for the CompressScript function by mmachicao · Pull Request #15104 · bitcoin/bitcoin · GitHub
3222019-01-14T16:40:25 <MarcoFalke> They are not deterministic right now, so you get different coverage each run
3232019-01-14T16:41:08 *** rhavar has joined #bitcoin-core-dev
3242019-01-14T16:52:38 <wumpus> MarcoFalke: right, so the interpretation would be: the gain in test coverage, if any, is within the random margin
3252019-01-14T16:53:21 <MarcoFalke> Yeah, to see where coverage increases you'd have to manually discard all files which you think shouldn't change
3262019-01-14T16:55:44 <MarcoFalke> So compare
3272019-01-14T16:55:46 <MarcoFalke> https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/15104/total.coverage/src/compressor.cpp.gcov.html#54
3282019-01-14T16:55:51 <MarcoFalke> https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/master/total.coverage/src/compressor.cpp.gcov.html#54
3292019-01-14T16:55:51 <gribble> https://github.com/bitcoin/bitcoin/issues/54 | do not create "Your Address" account when creating a new wallet by tcatm · Pull Request #54 · bitcoin/bitcoin · GitHub
3302019-01-14T16:55:53 <gribble> https://github.com/bitcoin/bitcoin/issues/54 | do not create "Your Address" account when creating a new wallet by tcatm · Pull Request #54 · bitcoin/bitcoin · GitHub
3312019-01-14T16:56:51 <MarcoFalke> Looks like coverage is already there, but I wouldn't mind additional tests if they make sense
3322019-01-14T16:58:18 *** zenogais has joined #bitcoin-core-dev
3332019-01-14T16:59:07 *** guga has quit IRC
3342019-01-14T17:01:37 * luke-jr pokes gribble
3352019-01-14T17:02:04 *** pinheadmz has joined #bitcoin-core-dev
3362019-01-14T17:07:49 <wumpus> MarcoFalke: +1
3372019-01-14T17:08:52 <wumpus> also don't think those few extra unit tests make test_bitcoin take significantly more time
3382019-01-14T17:14:21 <gmaxwell> Re: coverage, is the coverage analysis excluding the tests themselves? If they aren't it's totally unsurprising that adding a test would reduce coverage.
3392019-01-14T17:24:13 *** Dean_Guss has joined #bitcoin-core-dev
3402019-01-14T17:26:40 *** pinheadmz has quit IRC
3412019-01-14T17:27:04 *** pinheadmz has joined #bitcoin-core-dev
3422019-01-14T17:51:01 *** Murch has joined #bitcoin-core-dev
3432019-01-14T17:51:10 *** sergey has joined #bitcoin-core-dev
3442019-01-14T17:52:46 *** sergey has left #bitcoin-core-dev
3452019-01-14T17:56:21 *** jungly has quit IRC
3462019-01-14T18:01:19 *** Murch has quit IRC
3472019-01-14T18:08:52 <MarcoFalke> They are not excluded, but since they are run, they are covered
3482019-01-14T18:10:05 <gmaxwell> MarcoFalke: tests frequently contain error handling code which doesn't run (because the tests pass), which means that adding a test that mostly covers otherwise covered code can reduce coverage.
3492019-01-14T18:11:15 <MarcoFalke> Right. Though, we mostly use the BOOST_* macros for error handling/reporting and those system libs are excluded from coverage
3502019-01-14T18:28:58 <luke-jr> macros != libs; are you sure they're excluded?
3512019-01-14T18:31:25 <MarcoFalke> This is all that is included: https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/master/total.coverage/index.html
3522019-01-14T18:31:34 <MarcoFalke> (Only folders or files in /src)
3532019-01-14T18:33:18 <MarcoFalke> Makefile.am:LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1"
3542019-01-14T18:35:16 *** Zenton has quit IRC
3552019-01-14T18:35:17 *** michaels_ has joined #bitcoin-core-dev
3562019-01-14T18:38:23 *** michaelsdunn1 has quit IRC
3572019-01-14T18:39:21 *** miknotauro has joined #bitcoin-core-dev
3582019-01-14T18:39:57 <luke-jr> MarcoFalke: yeah, but I'm not sure how it determines which file it's in
3592019-01-14T18:40:13 <luke-jr> with a macro, it could very well be considered part of the test file
3602019-01-14T18:40:29 <MarcoFalke> Ah
3612019-01-14T18:40:40 <MarcoFalke> Yeah, for branch coverage it does, I think.
3622019-01-14T18:41:21 <MarcoFalke> I couldn't really get meaningful data for branch coverage anyway. I guess the compiler is adding too many optimization branches or removes them
3632019-01-14T18:41:47 <MarcoFalke> For line and function coverage it doesn't matter
3642019-01-14T18:42:17 *** jarthur has joined #bitcoin-core-dev
3652019-01-14T18:42:56 *** Murch has joined #bitcoin-core-dev
3662019-01-14T18:45:01 <gmaxwell> MarcoFalke: what do you mean you couldn't get meaningful data?
3672019-01-14T18:46:51 <MarcoFalke> I mean that I am too dumb to parse the html output
3682019-01-14T18:46:55 <MarcoFalke> See for example https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/master/total.coverage/src/logging.h.gcov.html
3692019-01-14T18:47:10 <MarcoFalke> bool Enabled() const has two branches
3702019-01-14T18:47:55 <MarcoFalke> But the compiler adds hundered or so more
3712019-01-14T18:48:40 <MarcoFalke> Could be some inlining of the template stuff further down, idk
3722019-01-14T18:49:19 *** Murch has quit IRC
3732019-01-14T18:58:36 *** Chris_Stewart_5 has quit IRC
3742019-01-14T19:01:19 *** spinza has quit IRC
3752019-01-14T19:02:12 *** pinheadmz has quit IRC
3762019-01-14T19:03:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3772019-01-14T19:03:38 <gmaxwell> MarcoFalke: yes, thats totally sensible, those are real branches that come in due to exception handling and templates.
3782019-01-14T19:03:41 *** pinheadmz has joined #bitcoin-core-dev
3792019-01-14T19:04:10 *** Krellan has quit IRC
3802019-01-14T19:04:18 *** miknotauro has quit IRC
3812019-01-14T19:10:26 *** spinza has joined #bitcoin-core-dev
3822019-01-14T19:26:46 *** jarthur has quit IRC
3832019-01-14T19:32:25 *** Murch has joined #bitcoin-core-dev
3842019-01-14T20:00:03 *** timothy has quit IRC
3852019-01-14T20:06:11 *** CubicEarth has quit IRC
3862019-01-14T20:09:41 *** CubicEarth has joined #bitcoin-core-dev
3872019-01-14T20:13:06 *** michaelfolkson has joined #bitcoin-core-dev
3882019-01-14T20:36:12 *** michaels_ has quit IRC
3892019-01-14T20:36:57 *** Krellan has joined #bitcoin-core-dev
3902019-01-14T20:38:57 *** rex4539 has joined #bitcoin-core-dev
3912019-01-14T20:42:23 *** michaelsdunn1 has joined #bitcoin-core-dev
3922019-01-14T20:45:19 *** yxz has joined #bitcoin-core-dev
3932019-01-14T20:45:48 *** michaelfolkson has quit IRC
3942019-01-14T20:50:23 *** michaelfolkson has joined #bitcoin-core-dev
3952019-01-14T21:04:31 *** karelb_ has joined #bitcoin-core-dev
3962019-01-14T21:04:36 *** hsmiths__ has joined #bitcoin-core-dev
3972019-01-14T21:04:54 *** RubenSomsen_ has joined #bitcoin-core-dev
3982019-01-14T21:04:57 *** noganoo_ has joined #bitcoin-core-dev
3992019-01-14T21:05:32 *** jarthur has joined #bitcoin-core-dev
4002019-01-14T21:07:21 *** nodweber2 has joined #bitcoin-core-dev
4012019-01-14T21:08:00 *** Bullit has joined #bitcoin-core-dev
4022019-01-14T21:11:38 *** hsmiths_ has quit IRC
4032019-01-14T21:11:39 *** ajtowns[m] has quit IRC
4042019-01-14T21:11:39 *** karelb has quit IRC
4052019-01-14T21:11:39 *** _flow_ has quit IRC
4062019-01-14T21:11:39 *** nodweber has quit IRC
4072019-01-14T21:11:43 *** nsh has quit IRC
4082019-01-14T21:11:43 *** noganoo has quit IRC
4092019-01-14T21:11:45 *** RubenSomsen has quit IRC
4102019-01-14T21:11:45 *** noganoo_ is now known as noganoo
4112019-01-14T21:11:45 *** karelb_ is now known as karelb
4122019-01-14T21:11:46 *** RubenSomsen_ is now known as RubenSomsen
4132019-01-14T21:12:27 *** ajtowns[m] has joined #bitcoin-core-dev
4142019-01-14T21:13:22 *** _flow_ has joined #bitcoin-core-dev
4152019-01-14T21:15:37 *** nsh has joined #bitcoin-core-dev
4162019-01-14T21:38:20 *** echeveria has joined #bitcoin-core-dev
4172019-01-14T21:50:03 *** michaelfolkson has quit IRC
4182019-01-14T21:55:14 *** michaelfolkson has joined #bitcoin-core-dev
4192019-01-14T21:55:59 *** pinheadmz has quit IRC
4202019-01-14T21:57:46 *** Tralfaz has quit IRC
4212019-01-14T21:58:26 *** Tralfaz has joined #bitcoin-core-dev
4222019-01-14T22:02:15 *** Tralfaz has quit IRC
4232019-01-14T22:02:54 *** Tralfaz has joined #bitcoin-core-dev
4242019-01-14T22:06:15 <promag> should I include release notes in a backport?
4252019-01-14T22:11:01 *** dviola has joined #bitcoin-core-dev
4262019-01-14T22:15:20 <luke-jr> probably depends on which gets released first
4272019-01-14T22:18:48 *** Chris_Stewart_5 has quit IRC
4282019-01-14T22:19:55 *** hsmiths__ is now known as hsmiths
4292019-01-14T22:21:06 <promag> makes sense
4302019-01-14T22:21:56 <promag> luke-jr: do you still dislike #15149?
4312019-01-14T22:21:58 <gribble> https://github.com/bitcoin/bitcoin/issues/15149 | gui: Show current wallet name in window title by promag · Pull Request #15149 · bitcoin/bitcoin · GitHub
4322019-01-14T22:23:48 *** pinheadmz has joined #bitcoin-core-dev
4332019-01-14T22:25:15 <luke-jr> promag: no, the responses satisfy my concern
4342019-01-14T22:25:37 <promag> cool thanks
4352019-01-14T22:25:44 * luke-jr edits a strikeout into his comment
4362019-01-14T22:26:00 <luke-jr> I mean, I guess I dislike it, but it's not unreasonable
4372019-01-14T22:26:20 <luke-jr> I actually am annoyed sometimes that I can search my open browser windows, but it misses non-active tabs :P
4382019-01-14T22:28:47 *** ExtraCrispy has quit IRC
4392019-01-14T22:28:53 <phantomcircuit> i've almost got the 0.7 bdb based node to 2018, it's been literally a month i think
4402019-01-14T22:34:01 *** michaelfolkson has quit IRC
4412019-01-14T22:34:10 *** mistergold has joined #bitcoin-core-dev
4422019-01-14T22:45:05 <promag> I think hebasto can be added to the gh org?
4432019-01-14T22:45:29 *** spinza has quit IRC
4442019-01-14T22:57:35 *** bitcoin-git has joined #bitcoin-core-dev
4452019-01-14T22:57:35 <bitcoin-git> [bitcoin] promag closed pull request #15107: rest: Return 404 in /rest/headers if block hash does not exists (master...2019-rest-header-404) https://github.com/bitcoin/bitcoin/pull/15107
4462019-01-14T22:57:35 *** bitcoin-git has left #bitcoin-core-dev
4472019-01-14T23:01:37 *** bzb has joined #bitcoin-core-dev
4482019-01-14T23:04:37 *** miknotauro has joined #bitcoin-core-dev
4492019-01-14T23:05:35 *** jarthur has quit IRC
4502019-01-14T23:07:12 *** Zenton has joined #bitcoin-core-dev
4512019-01-14T23:09:44 *** spinza has joined #bitcoin-core-dev
4522019-01-14T23:19:39 <gkrizek> ^^ GitHub IRC Service is out of its brown out until the 31st when itâs fully depreciated. Iâm still working on a replacement and itâs close to done. Will def be done before the 31st.
4532019-01-14T23:22:37 *** ddustin has joined #bitcoin-core-dev
4542019-01-14T23:27:26 *** michaelsdunn1 has quit IRC
4552019-01-14T23:29:55 <gwillen> meshcollider: as wallet maintainer do you have any official opinion on how much more review #14978 should have
4562019-01-14T23:29:58 <gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
4572019-01-14T23:32:04 *** Guyver2 has quit IRC
4582019-01-14T23:35:46 *** bzb_ has joined #bitcoin-core-dev
4592019-01-14T23:39:24 *** bzb has quit IRC
4602019-01-14T23:44:00 *** spinza has quit IRC
4612019-01-14T23:50:21 *** hebasto has quit IRC
4622019-01-14T23:53:08 *** ddustin has quit IRC
4632019-01-14T23:53:11 *** spinza has joined #bitcoin-core-dev