12019-01-18T00:15:32 *** Zenton has quit IRC
22019-01-18T00:16:36 *** xor216 has joined #bitcoin-core-dev
32019-01-18T00:36:20 *** ThomasLuong has quit IRC
42019-01-18T00:36:43 *** miknotauro has quit IRC
52019-01-18T00:39:32 *** riemann_ has joined #bitcoin-core-dev
62019-01-18T00:41:47 *** riemann has quit IRC
72019-01-18T00:43:22 <promag> dongcarl: sorry didn't complete the review
82019-01-18T00:43:23 *** asoltys has quit IRC
92019-01-18T00:44:13 *** sdaftuar has quit IRC
102019-01-18T00:44:21 *** asoltys has joined #bitcoin-core-dev
112019-01-18T00:45:19 *** elichai2 has quit IRC
122019-01-18T00:45:41 *** bitcoin-git has joined #bitcoin-core-dev
132019-01-18T00:45:41 <bitcoin-git> [bitcoin] promag opened pull request #15195: gui: Add close wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195
142019-01-18T00:45:41 *** bitcoin-git has left #bitcoin-core-dev
152019-01-18T00:47:55 *** sdaftuar has joined #bitcoin-core-dev
162019-01-18T01:09:40 *** promag has quit IRC
172019-01-18T01:25:01 *** fanquake has quit IRC
182019-01-18T01:33:57 *** xor216 has left #bitcoin-core-dev
192019-01-18T01:35:37 *** Krellan has joined #bitcoin-core-dev
202019-01-18T01:37:19 *** pinheadmz has quit IRC
212019-01-18T01:40:41 *** promag has joined #bitcoin-core-dev
222019-01-18T01:45:28 *** promag has quit IRC
232019-01-18T01:50:39 *** brianhoffman_ has joined #bitcoin-core-dev
242019-01-18T01:51:15 *** Bullitje has joined #bitcoin-core-dev
252019-01-18T01:51:34 *** riemann has joined #bitcoin-core-dev
262019-01-18T01:52:00 *** schmidty_ has joined #bitcoin-core-dev
272019-01-18T01:52:44 *** TheRec_ has joined #bitcoin-core-dev
282019-01-18T01:52:45 *** TheRec_ has joined #bitcoin-core-dev
292019-01-18T01:53:38 *** StopAndDecrypt_ has joined #bitcoin-core-dev
302019-01-18T01:55:12 *** IGHOR_ has joined #bitcoin-core-dev
312019-01-18T01:55:36 *** achow101_ has joined #bitcoin-core-dev
322019-01-18T01:55:59 *** rafalcpp has joined #bitcoin-core-dev
332019-01-18T01:56:13 *** asoltys_ has joined #bitcoin-core-dev
342019-01-18T01:57:14 *** mistergold has quit IRC
352019-01-18T01:58:07 *** achow101 has quit IRC
362019-01-18T01:58:11 *** achow101_ is now known as achow101
372019-01-18T01:59:25 *** Pasha has joined #bitcoin-core-dev
382019-01-18T02:00:13 *** pinheadmz has joined #bitcoin-core-dev
392019-01-18T02:00:18 *** asoltys has quit IRC
402019-01-18T02:00:18 *** riemann_ has quit IRC
412019-01-18T02:00:18 *** rh0nj has quit IRC
422019-01-18T02:00:18 *** TheRec has quit IRC
432019-01-18T02:00:18 *** schmidty has quit IRC
442019-01-18T02:00:18 *** brianhoffman has quit IRC
452019-01-18T02:00:18 *** Cory has quit IRC
462019-01-18T02:00:18 *** StopAndDecrypt has quit IRC
472019-01-18T02:00:18 *** Bullit has quit IRC
482019-01-18T02:00:18 *** rafalcpp_ has quit IRC
492019-01-18T02:00:18 *** IGHOR has quit IRC
502019-01-18T02:00:20 *** brianhoffman_ is now known as brianhoffman
512019-01-18T02:01:08 *** rh0nj has joined #bitcoin-core-dev
522019-01-18T02:02:37 *** Pasha is now known as Cory
532019-01-18T02:17:50 *** pinheadmz has quit IRC
542019-01-18T02:25:37 *** pinheadmz has joined #bitcoin-core-dev
552019-01-18T02:28:44 *** m8tion has quit IRC
562019-01-18T02:40:20 *** jarthur has quit IRC
572019-01-18T02:45:51 *** Murch has quit IRC
582019-01-18T02:47:17 *** ddustin has quit IRC
592019-01-18T02:47:57 *** ddustin has joined #bitcoin-core-dev
602019-01-18T02:53:00 *** ddustin has quit IRC
612019-01-18T03:04:07 *** Krellan has quit IRC
622019-01-18T03:04:56 *** pinheadmz has quit IRC
632019-01-18T03:05:27 *** pinheadmz has joined #bitcoin-core-dev
642019-01-18T03:23:23 *** zenogais has quit IRC
652019-01-18T03:24:05 *** arshbot has joined #bitcoin-core-dev
662019-01-18T03:26:16 *** pinheadmz has quit IRC
672019-01-18T03:38:59 *** DeanGuss has joined #bitcoin-core-dev
682019-01-18T03:50:09 *** ThomasLuong has joined #bitcoin-core-dev
692019-01-18T03:51:48 *** pinheadmz has joined #bitcoin-core-dev
702019-01-18T03:52:31 *** zenogais has joined #bitcoin-core-dev
712019-01-18T03:55:38 *** DeanGuss has quit IRC
722019-01-18T03:56:05 *** DeanGuss has joined #bitcoin-core-dev
732019-01-18T04:00:12 *** Murch has joined #bitcoin-core-dev
742019-01-18T04:03:28 *** schnerch_ has joined #bitcoin-core-dev
752019-01-18T04:06:43 *** schnerchi has quit IRC
762019-01-18T04:07:38 *** pinheadmz has quit IRC
772019-01-18T04:09:02 *** pinheadmz has joined #bitcoin-core-dev
782019-01-18T04:11:29 *** schmidty_ has quit IRC
792019-01-18T04:13:13 *** schmidty has joined #bitcoin-core-dev
802019-01-18T04:13:54 *** miknotauro has joined #bitcoin-core-dev
812019-01-18T04:18:10 *** schmidty has quit IRC
822019-01-18T04:30:47 *** pinheadmz has quit IRC
832019-01-18T04:41:20 *** ThomasLuong has quit IRC
842019-01-18T04:48:06 *** schmidty has joined #bitcoin-core-dev
852019-01-18T04:54:05 *** bitcoin-git has joined #bitcoin-core-dev
862019-01-18T04:54:06 <bitcoin-git> [bitcoin] gkrizek opened pull request #15196: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196
872019-01-18T04:54:06 *** bitcoin-git has left #bitcoin-core-dev
882019-01-18T04:56:12 <gkrizek> wumpus: ^
892019-01-18T05:11:43 *** zenogais has quit IRC
902019-01-18T05:15:21 *** rhavar_ has joined #bitcoin-core-dev
912019-01-18T05:17:07 *** pinheadmz has joined #bitcoin-core-dev
922019-01-18T05:25:22 *** Mutter has joined #bitcoin-core-dev
932019-01-18T05:26:51 *** Mutter_ has joined #bitcoin-core-dev
942019-01-18T05:27:33 *** schmidty has quit IRC
952019-01-18T05:30:27 *** Mutter has quit IRC
962019-01-18T05:30:35 *** Murch has quit IRC
972019-01-18T05:38:29 *** Murch has joined #bitcoin-core-dev
982019-01-18T05:39:34 *** Mutter_ has quit IRC
992019-01-18T06:02:02 *** rh0nj has quit IRC
1002019-01-18T06:03:07 *** rh0nj has joined #bitcoin-core-dev
1012019-01-18T06:05:48 *** promag has joined #bitcoin-core-dev
1022019-01-18T06:09:52 *** schmidty has joined #bitcoin-core-dev
1032019-01-18T06:10:23 *** promag has quit IRC
1042019-01-18T06:15:17 *** schmidty has quit IRC
1052019-01-18T06:23:12 *** pinheadmz has quit IRC
1062019-01-18T06:26:16 *** Alixe has joined #bitcoin-core-dev
1072019-01-18T06:27:18 <Alixe> Hello
1082019-01-18T06:27:38 <Alixe> Can I ask questions here regarding full node?
1092019-01-18T06:29:17 <arshbot> shoot
1102019-01-18T06:29:21 *** schmidty has joined #bitcoin-core-dev
1112019-01-18T06:31:46 <Alixe> So I think mining hash power can't do anything because full nodes enforce consensus rules. But some people think governments or corporates can buy a lot of nodes to affect Bitcoin with having majority of full nodes. Is it possible?
1122019-01-18T06:32:18 *** pinheadmz has joined #bitcoin-core-dev
1132019-01-18T06:32:45 <sipa> #bitcoin
1142019-01-18T06:33:47 *** schmidty has quit IRC
1152019-01-18T06:40:16 <Alixe> I really want to know devs opinion on this
1162019-01-18T06:41:00 <luke-jr> Alixe: this is not "talk to devs", it is "talk about development", and your question is not about development. some of us are in #bitcoin too
1172019-01-18T06:41:00 *** arshbot has quit IRC
1182019-01-18T06:42:27 *** farmerwampum has joined #bitcoin-core-dev
1192019-01-18T06:43:45 *** farmerwampum has left #bitcoin-core-dev
1202019-01-18T06:51:04 <Alixe> I guess everyone is busy
1212019-01-18T06:51:27 <Alixe> Will ask on slack maybe
1222019-01-18T06:51:39 *** Alixe has quit IRC
1232019-01-18T07:04:51 *** bitcoin-git has joined #bitcoin-core-dev
1242019-01-18T07:04:52 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197
1252019-01-18T07:04:52 *** bitcoin-git has left #bitcoin-core-dev
1262019-01-18T07:07:13 <wumpus> gkrizek: thanks!
1272019-01-18T07:08:07 <gkrizek> No problem!
1282019-01-18T07:28:09 *** guga has joined #bitcoin-core-dev
1292019-01-18T07:28:11 *** pinheadmz has quit IRC
1302019-01-18T07:31:21 *** Murch has quit IRC
1312019-01-18T07:33:20 *** Murch has joined #bitcoin-core-dev
1322019-01-18T07:34:25 *** Murch has quit IRC
1332019-01-18T07:41:00 *** Murch has joined #bitcoin-core-dev
1342019-01-18T07:52:22 *** schmidty has joined #bitcoin-core-dev
1352019-01-18T07:55:59 *** hebasto has joined #bitcoin-core-dev
1362019-01-18T07:57:04 *** schmidty has quit IRC
1372019-01-18T07:57:51 *** guga has quit IRC
1382019-01-18T07:57:51 *** Murch has quit IRC
1392019-01-18T07:58:09 *** guga has joined #bitcoin-core-dev
1402019-01-18T07:58:30 *** Murch has joined #bitcoin-core-dev
1412019-01-18T07:58:30 *** pinheadmz has joined #bitcoin-core-dev
1422019-01-18T08:01:46 *** pinheadmz has quit IRC
1432019-01-18T08:06:51 *** promag has joined #bitcoin-core-dev
1442019-01-18T08:11:07 *** promag has quit IRC
1452019-01-18T08:18:38 *** promag has joined #bitcoin-core-dev
1462019-01-18T08:22:01 *** schmidty has joined #bitcoin-core-dev
1472019-01-18T08:23:03 *** promag has quit IRC
1482019-01-18T08:26:43 *** schmidty has quit IRC
1492019-01-18T08:32:56 *** jungly has joined #bitcoin-core-dev
1502019-01-18T08:39:16 *** dufferzafar has joined #bitcoin-core-dev
1512019-01-18T08:40:27 <dufferzafar> i'm doing some network measurement experiments on bitcoin
1522019-01-18T08:40:31 <dufferzafar> i have bitcoin daemons running on multiple machines
1532019-01-18T08:40:34 <dufferzafar> and to simulate real network like delays and latencies i'm using Linux's tc/netem
1542019-01-18T08:40:36 <dufferzafar> i want to add delays between P2P ports of machines
1552019-01-18T08:40:39 <dufferzafar> but i think the p2p ports aren't fixed
1562019-01-18T08:40:42 <dufferzafar> how would i go about adding delays?
1572019-01-18T08:41:58 <wumpus> "but i think the p2p ports aren't fixed" by default it is always 8333, unless you change it, which you obviously wouldn't do for a simulated network
1582019-01-18T08:47:37 *** Krellan has joined #bitcoin-core-dev
1592019-01-18T08:52:18 *** Krellan has quit IRC
1602019-01-18T08:55:04 <wumpus> (8333 is assuming this is mainnet; testnet and regtest networks have different, but also fixed ports)
1612019-01-18T08:57:28 *** luke-jr has quit IRC
1622019-01-18T09:08:58 *** murrayn_ has joined #bitcoin-core-dev
1632019-01-18T09:10:20 *** murrayn has quit IRC
1642019-01-18T09:11:26 *** rh0nj has quit IRC
1652019-01-18T09:12:14 *** rh0nj has joined #bitcoin-core-dev
1662019-01-18T09:17:32 *** Murch has quit IRC
1672019-01-18T09:18:13 *** AaronvanW has joined #bitcoin-core-dev
1682019-01-18T09:18:16 <dufferzafar> wumpus: i did change the p2p port, but bitcoind is binding to some other ports as well
1692019-01-18T09:18:21 <dufferzafar> it only listens on the p2p port
1702019-01-18T09:18:42 <dufferzafar> but i think data transmissions happen on other ports (which can't be configured?)
1712019-01-18T09:18:50 <wumpus> by default it will listen on the P2P publicly and the RPC port localhost-only
1722019-01-18T09:19:40 <wumpus> no, there is only one kind of P2P connection and that always connects to a P2P port
1732019-01-18T09:20:14 *** Aaronvan_ has joined #bitcoin-core-dev
1742019-01-18T09:20:25 <dufferzafar> let me explain by the output of "lsof -i" (lists all open ports)
1752019-01-18T09:20:28 <dufferzafar> bitcoind 22139 baadalvm IPv4 TCP btc1:33542->btc2:12476 (ESTABLISHED)
1762019-01-18T09:20:30 <dufferzafar> bitcoind 22139 baadalvm IPv4 TCP *:12192 (LISTEN)
1772019-01-18T09:20:31 <dufferzafar> bitcoind 22139 baadalvm IPv4 TCP btc1:12192->btc2:60332 (ESTABLISHED)
1782019-01-18T09:21:01 <dufferzafar> so, the ports 12192 & 12476 are the ones the two bitcoin processes (btc1 & btc2) are listening on
1792019-01-18T09:21:07 <dufferzafar> these are the p2p ports
1802019-01-18T09:21:08 <wumpus> there are two possiblities: incoming connections, which go *to* the P2P port on the local host, or outgoing connections which go to the P2P port of a remote host
1812019-01-18T09:22:45 <dufferzafar> i don't get where the ports 33542 & 60332 are coming from
1822019-01-18T09:22:57 <dufferzafar> i didn't specify these numbers anywhere in the config
1832019-01-18T09:23:24 <wumpus> aren't they the ephermal source ports for the TCP connections?
1842019-01-18T09:23:27 *** AaronvanW has quit IRC
1852019-01-18T09:24:48 <dufferzafar> yeah, but they're dynamic right
1862019-01-18T09:25:01 <dufferzafar> so i won't be able to set a delay
1872019-01-18T09:25:15 <dufferzafar> because that requires me knowing the ports beforehand
1882019-01-18T09:25:30 <dufferzafar> i was running a command like: "tcset ens3 --delay 120s --dst-network 10.17.6.18 --src-port 12476 --dst-port 12192"
1892019-01-18T09:26:00 <dufferzafar> but since the data is being transmitted over the ephemeral ports, the delay doesn't work
1902019-01-18T09:26:23 *** jb55 has joined #bitcoin-core-dev
1912019-01-18T09:26:48 <wumpus> source ports for TCP connections are *always* dynamic, remember that the (source host:port, target host:port) tuple has to be unique for a connection, so otherwise you could only have one connection to a certain service from one host!
1922019-01-18T09:27:37 <dufferzafar> yeah, i understand why it has to be dynamic
1932019-01-18T09:27:49 <dufferzafar> but i don't get how i would be able to add delays then
1942019-01-18T09:27:54 <wumpus> I think you need to read up on how your tooling is used with other TCP protocols, it's not really different for bitcoin
1952019-01-18T09:28:48 <dufferzafar> i even tried something like: "tcset ens3 --delay 120s --dst-port 12192"
1962019-01-18T09:28:53 <dufferzafar> but that doesn't work either
1972019-01-18T09:29:15 <dufferzafar> leading me to believe that the P2P port isn't being used
1982019-01-18T09:29:36 <echeveria> isnât being used?
1992019-01-18T09:29:51 *** schmidty has joined #bitcoin-core-dev
2002019-01-18T09:29:51 <dufferzafar> as in, it is only being used to listen for new clients
2012019-01-18T09:30:06 <dufferzafar> but the actual data is transmitted on some other port
2022019-01-18T09:30:08 <wumpus> it is being used, believe me
2032019-01-18T09:30:11 <dufferzafar> (just my hypothesis)
2042019-01-18T09:30:12 <echeveria> no.
2052019-01-18T09:30:34 <wumpus> if it's not being used then your node has no connection in the first place
2062019-01-18T09:30:40 <echeveria> youâre not listening to experts that know the system. it does not use other ports. your hypothesis is utterly irrelevant.
2072019-01-18T09:31:19 <wumpus> I suggest you ask in the help channel for your simulation tooling why it isn't working, I don't think anyone can help you here
2082019-01-18T09:31:35 <wumpus> also this isn't a help channel, it's about development
2092019-01-18T09:32:11 <dufferzafar> okay, is it bitcoin-help? i saw this channel mentioned on slack, so came here
2102019-01-18T09:32:22 *** dufferzafar has left #bitcoin-core-dev
2112019-01-18T09:32:53 <wumpus> it's fine as long as you don't go arguing how bitcoin's P2P protocol works...
2122019-01-18T09:33:22 *** laurentmt has joined #bitcoin-core-dev
2132019-01-18T09:41:28 *** Zenton has joined #bitcoin-core-dev
2142019-01-18T09:44:30 *** rhavar_ has quit IRC
2152019-01-18T09:51:40 *** mistergold has joined #bitcoin-core-dev
2162019-01-18T09:55:13 *** owowo has joined #bitcoin-core-dev
2172019-01-18T10:04:33 <DeanGuss> Anybody happen to know why wallet.cpp shuts bitcoind down when encryptwallet rpc command is called? https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp line 676
2182019-01-18T10:08:59 <wumpus> DeanGuss: it was a crude but effective way to be sure that all the unencrypted data is removed from memory, and to be sure only the encrypted wallet is loaded next time
2192019-01-18T10:09:59 <wumpus> the behavior is removed in #12493
2202019-01-18T10:10:05 <gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
2212019-01-18T10:10:43 <wumpus> if it still shuts down it's a bug
2222019-01-18T10:11:21 <DeanGuss> it definitely does
2232019-01-18T10:11:38 <DeanGuss> running 0.17.1
2242019-01-18T10:11:39 <wumpus> then, please file a bug report with as much info about the issue as possible: https://github.com/bitcoin/bitcoin/issues/new
2252019-01-18T10:11:54 <DeanGuss> cool will do
2262019-01-18T10:11:56 <wumpus> oh, in 0.17.1 that's expected
2272019-01-18T10:12:20 <wumpus> you posted a link to master, which shouldn't have it anymore
2282019-01-18T10:12:35 <wumpus> master will be 0.18.0
2292019-01-18T10:12:35 <DeanGuss> ah.. ok cool, so next release?
2302019-01-18T10:12:51 <wumpus> next major release
2312019-01-18T10:12:53 <DeanGuss> sweet! Thanks
2322019-01-18T10:13:28 <DeanGuss> any idea when that will be?
2332019-01-18T10:14:04 <wumpus> see #14438
2342019-01-18T10:14:06 <gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
2352019-01-18T10:15:05 <DeanGuss> awesome thanks
2362019-01-18T10:17:27 *** schmidty has quit IRC
2372019-01-18T10:18:42 *** spinza has quit IRC
2382019-01-18T10:20:56 *** schmidty has joined #bitcoin-core-dev
2392019-01-18T10:22:40 *** promag has joined #bitcoin-core-dev
2402019-01-18T10:24:36 *** miknotauro has quit IRC
2412019-01-18T10:25:28 *** schmidty has quit IRC
2422019-01-18T10:26:47 *** promag has quit IRC
2432019-01-18T10:30:05 *** spinza has joined #bitcoin-core-dev
2442019-01-18T10:31:35 *** bitcoin-git has joined #bitcoin-core-dev
2452019-01-18T10:31:35 <bitcoin-git> [bitcoin] DesWurstes opened pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
2462019-01-18T10:31:35 *** bitcoin-git has left #bitcoin-core-dev
2472019-01-18T10:32:58 *** owowo has quit IRC
2482019-01-18T10:39:15 *** promag has joined #bitcoin-core-dev
2492019-01-18T10:41:19 *** hebasto has quit IRC
2502019-01-18T10:41:21 *** owowo has joined #bitcoin-core-dev
2512019-01-18T10:41:25 *** hebasto_ has joined #bitcoin-core-dev
2522019-01-18T10:49:07 <promag> jnewbery: jonasschnelli: #15195 the open/close walelt actions (it includes #15101 and #15153)
2532019-01-18T10:49:09 <gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
2542019-01-18T10:49:11 <gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
2552019-01-18T10:49:13 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
2562019-01-18T10:50:02 <promag> it would be nice someone test 15195 in linux/windows
2572019-01-18T11:06:43 *** hebasto_ has quit IRC
2582019-01-18T11:07:02 *** hebasto_ has joined #bitcoin-core-dev
2592019-01-18T11:22:09 *** schmidty has joined #bitcoin-core-dev
2602019-01-18T11:27:39 *** sipa has quit IRC
2612019-01-18T11:27:54 *** guga has quit IRC
2622019-01-18T11:28:49 *** sipa has joined #bitcoin-core-dev
2632019-01-18T11:35:48 *** Krellan has joined #bitcoin-core-dev
2642019-01-18T11:35:57 *** schmidty has quit IRC
2652019-01-18T11:40:26 *** Krellan has quit IRC
2662019-01-18T11:46:06 *** guga has joined #bitcoin-core-dev
2672019-01-18T11:49:06 *** rabidus has quit IRC
2682019-01-18T12:00:03 *** rabidus has joined #bitcoin-core-dev
2692019-01-18T12:01:23 *** schmidty has joined #bitcoin-core-dev
2702019-01-18T12:02:19 *** Aaronvan_ is now known as AaronvanW
2712019-01-18T12:06:00 *** schmidty has quit IRC
2722019-01-18T12:08:28 *** mistergold has quit IRC
2732019-01-18T12:09:25 *** schmidty has joined #bitcoin-core-dev
2742019-01-18T12:13:28 *** schmidty has quit IRC
2752019-01-18T12:13:44 *** schmidty has joined #bitcoin-core-dev
2762019-01-18T12:30:33 *** laurentmt has quit IRC
2772019-01-18T12:48:06 *** promag has quit IRC
2782019-01-18T12:57:01 *** rh0nj has quit IRC
2792019-01-18T12:58:08 *** rh0nj has joined #bitcoin-core-dev
2802019-01-18T13:23:21 *** promag has joined #bitcoin-core-dev
2812019-01-18T13:27:33 *** promag has quit IRC
2822019-01-18T13:35:27 *** guga_ has joined #bitcoin-core-dev
2832019-01-18T13:37:27 *** owowo has quit IRC
2842019-01-18T13:38:40 *** guga has quit IRC
2852019-01-18T13:42:35 *** owowo has joined #bitcoin-core-dev
2862019-01-18T13:49:13 *** farmerwampum has joined #bitcoin-core-dev
2872019-01-18T13:52:22 *** farmerwampum has left #bitcoin-core-dev
2882019-01-18T13:58:23 *** promag has joined #bitcoin-core-dev
2892019-01-18T14:03:20 *** promag has quit IRC
2902019-01-18T14:19:05 *** kexkey has joined #bitcoin-core-dev
2912019-01-18T14:24:05 *** miknotauro has joined #bitcoin-core-dev
2922019-01-18T14:33:48 *** miknotauro has quit IRC
2932019-01-18T14:34:44 *** Guyver2 has joined #bitcoin-core-dev
2942019-01-18T14:38:14 *** laurentmt has joined #bitcoin-core-dev
2952019-01-18T14:52:38 *** rafalcpp has quit IRC
2962019-01-18T14:52:40 *** queip has quit IRC
2972019-01-18T15:02:53 *** rafalcpp has joined #bitcoin-core-dev
2982019-01-18T15:07:57 *** queip has joined #bitcoin-core-dev
2992019-01-18T15:18:28 *** arshbot_ has joined #bitcoin-core-dev
3002019-01-18T15:21:40 *** laurentmt has quit IRC
3012019-01-18T15:26:58 *** promag has joined #bitcoin-core-dev
3022019-01-18T15:30:03 *** sakalli_ has joined #bitcoin-core-dev
3032019-01-18T15:30:20 *** sakalli_ has joined #bitcoin-core-dev
3042019-01-18T15:31:51 *** bitcoin-git has joined #bitcoin-core-dev
3052019-01-18T15:31:51 <bitcoin-git> [bitcoin] practicalswift opened pull request #15201: net: Add missing cs_vNodes lock in CConnman::Stop(). Add missing locking annotation. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
3062019-01-18T15:31:51 *** bitcoin-git has left #bitcoin-core-dev
3072019-01-18T15:32:26 *** sakalli_ has quit IRC
3082019-01-18T15:32:43 *** bitcoin-git has joined #bitcoin-core-dev
3092019-01-18T15:32:43 <bitcoin-git> [bitcoin] promag opened pull request #15202: gui: Add Close All Wallets action (master...2019-01-closeallwallets) https://github.com/bitcoin/bitcoin/pull/15202
3102019-01-18T15:32:43 *** bitcoin-git has left #bitcoin-core-dev
3112019-01-18T15:37:59 *** bitcoin-git has joined #bitcoin-core-dev
3122019-01-18T15:37:59 <bitcoin-git> [bitcoin] DesWurstes closed pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
3132019-01-18T15:37:59 *** bitcoin-git has left #bitcoin-core-dev
3142019-01-18T15:44:31 *** michaelsdunn1 has joined #bitcoin-core-dev
3152019-01-18T15:48:45 <rafalcpp> hi, how Bitcoin achieves deterministic builds of Qt client too?
3162019-01-18T15:50:14 <rafalcpp> the Qt library itself, must be built in cross-build version, that is also deterministic and static?
3172019-01-18T15:55:07 *** arshbot_ has quit IRC
3182019-01-18T15:55:37 *** guga_ has quit IRC
3192019-01-18T15:55:56 *** bitcoin-git has joined #bitcoin-core-dev
3202019-01-18T15:55:56 <bitcoin-git> [bitcoin] dooglus opened pull request #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) (master...fix-startup-crash) https://github.com/bitcoin/bitcoin/pull/15203
3212019-01-18T15:55:56 *** bitcoin-git has left #bitcoin-core-dev
3222019-01-18T16:03:56 *** bitcoin-git has joined #bitcoin-core-dev
3232019-01-18T16:03:56 <bitcoin-git> [bitcoin] promag opened pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
3242019-01-18T16:03:56 *** bitcoin-git has left #bitcoin-core-dev
3252019-01-18T16:07:06 *** Meee3333 has joined #bitcoin-core-dev
3262019-01-18T16:07:17 *** Meee3333 has quit IRC
3272019-01-18T16:08:53 *** miknotauro has joined #bitcoin-core-dev
3282019-01-18T16:13:21 <promag> jnewbery: jonasschnelli: see #15204 for most complete GUI work, missing "New Wallet..." action
3292019-01-18T16:13:22 <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
3302019-01-18T16:13:30 <achow101> rafalcpp: the depends system is used to compile all dependencies deterministically and as static libraries
3312019-01-18T16:18:39 <rafalcpp> achow101: is there any plan on moving to cmake one day? I'm looking to recreating this but in cmake, in next months
3322019-01-18T16:19:01 <achow101> rafalcpp: no
3332019-01-18T16:19:48 <achow101> autotools currently works. changing to a completely different build system would require tons of work and probably no one would review it since not many people understand build systems
3342019-01-18T16:20:26 <rafalcpp> I wonder if automake is not even harder to understand though
3352019-01-18T16:23:35 *** schnerch_ has quit IRC
3362019-01-18T16:27:35 *** arshbot_ has joined #bitcoin-core-dev
3372019-01-18T16:28:23 *** kexkey has quit IRC
3382019-01-18T16:28:53 *** promag has quit IRC
3392019-01-18T16:35:14 *** pinheadmz has joined #bitcoin-core-dev
3402019-01-18T16:37:55 *** kexkey has joined #bitcoin-core-dev
3412019-01-18T16:53:08 *** arshbot_ has quit IRC
3422019-01-18T16:59:01 *** rh0nj has quit IRC
3432019-01-18T17:00:11 *** rh0nj has joined #bitcoin-core-dev
3442019-01-18T17:01:10 *** miknotauro has quit IRC
3452019-01-18T17:02:44 *** zenogais has joined #bitcoin-core-dev
3462019-01-18T17:09:21 *** jarthur has joined #bitcoin-core-dev
3472019-01-18T17:13:14 *** Zenton has quit IRC
3482019-01-18T17:24:15 <wumpus> I understand automake/autoconf better than cmake and that's not saying a lot
3492019-01-18T17:25:11 *** ThomasLuong has joined #bitcoin-core-dev
3502019-01-18T17:25:16 <wumpus> I'd nack moving to a different build system, it's just not a good use of limited reviewer bandwidth, and it will take ages to fix all the little problems again we've managed to with this build system
3512019-01-18T17:40:39 *** ikus has joined #bitcoin-core-dev
3522019-01-18T17:40:41 <ikus> Hello
3532019-01-18T17:42:12 *** luke-jr has joined #bitcoin-core-dev
3542019-01-18T17:53:36 *** jungly has quit IRC
3552019-01-18T17:58:53 *** achow101 has quit IRC
3562019-01-18T18:00:02 *** achow101 has joined #bitcoin-core-dev
3572019-01-18T18:01:50 *** promag has joined #bitcoin-core-dev
3582019-01-18T18:02:28 *** zenogais has quit IRC
3592019-01-18T18:10:28 *** luke-jr has quit IRC
3602019-01-18T18:23:16 *** zenogais has joined #bitcoin-core-dev
3612019-01-18T18:26:51 *** Aaronvan_ has joined #bitcoin-core-dev
3622019-01-18T18:27:27 *** AaronvanW has quit IRC
3632019-01-18T18:31:07 *** pinheadmz has quit IRC
3642019-01-18T18:31:53 *** pinheadmz has joined #bitcoin-core-dev
3652019-01-18T18:35:14 <jnewbery> promag: thanks. After #15204, is there just a 'create wallet' menu item to add and then we're done?
3662019-01-18T18:35:15 <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
3672019-01-18T18:38:40 <promag> jnewbery: yes I think so
3682019-01-18T18:39:30 <promag> jnewbery: create wallet should open a dialog to ask for: name / external path, create empty? encrypted?
3692019-01-18T18:39:34 *** luke-jr has joined #bitcoin-core-dev
3702019-01-18T18:44:34 *** Murch has joined #bitcoin-core-dev
3712019-01-18T18:44:55 <midnightmagic> Well.. boost's jam is way easier to build for, and a faster build too. But. Lot of work and hard to get right for multi-platform. :-/
3722019-01-18T18:45:41 *** DeanGuss has quit IRC
3732019-01-18T18:45:44 <jnewbery> I'd leave createempty and encrypted out for now to avoid dependency on 14938 and 15006. Seems like it shouldn't be too difficult to add those checkboxes in a follow-up
3742019-01-18T18:46:47 *** Aaronvan_ has quit IRC
3752019-01-18T18:46:52 <jnewbery> I'd really love to see load/unload/create wallet in the GUI for 0.18. Avoiding dependencies on other PRs increases the chances of us making it.
3762019-01-18T18:47:28 *** AaronvanW has joined #bitcoin-core-dev
3772019-01-18T18:54:29 *** ThomasLuong has quit IRC
3782019-01-18T18:54:44 <promag> I think I can submit the "create wallet" pr this weekend
3792019-01-18T18:55:02 *** ThomasLuong has joined #bitcoin-core-dev
3802019-01-18T18:55:27 <promag> jnewbery: Avoiding dependencies on other PRs increases the chances of us making it -> you mean dependencies to 14938 and 15006?
3812019-01-18T18:55:37 <promag> I don't want to depend on those
3822019-01-18T18:56:35 <promag> initially I had the "file -> new wallet" use QInputDialog to type the wallet name
3832019-01-18T18:57:02 <promag> and "file -> new external wallet" to use QFileDialog
3842019-01-18T18:57:36 <promag> but I think I should create a dialog/wizard to easily extend with those options later
3852019-01-18T19:03:09 <jnewbery> I think the distinction between open wallet and open external wallet (also new wallet and new external wallet) is probably confusing for most users. I'd lean towards just having one menu item for each
3862019-01-18T19:03:43 <jnewbery> yes, I mean avoid having createempty and encrypted as options for create wallet, since that's unmerged functionality
3872019-01-18T19:04:24 <promag> fot that (just one open wallet action) I would have to create a custom dialog
3882019-01-18T19:05:20 <promag> Unless I add "file -> open wallet -> other ..." at the end of the menu
3892019-01-18T19:06:12 *** pinheadmz has quit IRC
3902019-01-18T19:07:16 <promag> jnewbery: I also think it's fair to improve after 0.18
3912019-01-18T19:07:22 *** pinheadmz has joined #bitcoin-core-dev
3922019-01-18T19:08:52 *** bitcoin-git has joined #bitcoin-core-dev
3932019-01-18T19:08:52 <bitcoin-git> [bitcoin] jamesob opened pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
3942019-01-18T19:08:52 *** bitcoin-git has left #bitcoin-core-dev
3952019-01-18T19:11:15 *** ikus has quit IRC
3962019-01-18T19:14:28 *** kexkey has quit IRC
3972019-01-18T19:14:56 *** promag has quit IRC
3982019-01-18T19:15:00 *** kexkey has joined #bitcoin-core-dev
3992019-01-18T19:32:04 *** Victorsueca has joined #bitcoin-core-dev
4002019-01-18T19:37:31 *** Murch has quit IRC
4012019-01-18T19:48:25 *** owowo has quit IRC
4022019-01-18T19:50:30 *** Murch has joined #bitcoin-core-dev
4032019-01-18T19:53:40 *** owowo has joined #bitcoin-core-dev
4042019-01-18T19:55:44 *** spaced0ut has quit IRC
4052019-01-18T19:59:58 *** spaced0ut has joined #bitcoin-core-dev
4062019-01-18T20:08:30 *** farmerwampum has joined #bitcoin-core-dev
4072019-01-18T20:21:37 *** bitcoin-git has joined #bitcoin-core-dev
4082019-01-18T20:21:37 <bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd42553b1178...63144335becb
4092019-01-18T20:21:38 <bitcoin-git> bitcoin/master cefb399 João Barbosa: gui: Use AutoConnection for WalletModel::unload signal
4102019-01-18T20:21:38 <bitcoin-git> bitcoin/master 8fa271f João Barbosa: gui: Add WalletController
4112019-01-18T20:21:39 <bitcoin-git> bitcoin/master 0dd9bde João Barbosa: gui: Refactor to use WalletController
4122019-01-18T20:21:39 *** bitcoin-git has left #bitcoin-core-dev
4132019-01-18T20:22:16 *** bitcoin-git has joined #bitcoin-core-dev
4142019-01-18T20:22:17 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #15101: gui: Add WalletController (master...2019-01-walletcontroller) https://github.com/bitcoin/bitcoin/pull/15101
4152019-01-18T20:22:17 *** bitcoin-git has left #bitcoin-core-dev
4162019-01-18T20:24:37 *** kexkey has quit IRC
4172019-01-18T20:28:35 *** farmerwampum has quit IRC
4182019-01-18T20:28:59 *** farmerwampum has joined #bitcoin-core-dev
4192019-01-18T20:30:03 *** riemann_ has joined #bitcoin-core-dev
4202019-01-18T20:30:24 *** luke-jr has quit IRC
4212019-01-18T20:32:14 *** laurentmt has joined #bitcoin-core-dev
4222019-01-18T20:32:33 *** riemann has quit IRC
4232019-01-18T20:33:06 *** farmerwampum has quit IRC
4242019-01-18T20:33:30 *** farmerwampum has joined #bitcoin-core-dev
4252019-01-18T20:34:11 *** promag has joined #bitcoin-core-dev
4262019-01-18T20:34:15 *** luke-jr has joined #bitcoin-core-dev
4272019-01-18T20:39:03 <promag> jonasschnelli ty \o/
4282019-01-18T20:39:22 <jnewbery> I agree! \o/
4292019-01-18T20:39:32 *** DougieBot5000_ has joined #bitcoin-core-dev
4302019-01-18T20:39:44 <jonasschnelli> I think its good enough,... minor comment improvements (and similar things) can be done later
4312019-01-18T20:39:46 <promag> jnewbery: typo in "Add an "opem wallet" command in bitcoin-qt" 13059
4322019-01-18T20:39:52 *** DougieBot5000 is now known as Guest50915
4332019-01-18T20:39:52 *** DougieBot5000_ is now known as DougieBot5000
4342019-01-18T20:40:07 <jnewbery> fixed. Thanks
4352019-01-18T20:40:10 *** bitcoin-git has joined #bitcoin-core-dev
4362019-01-18T20:40:11 <bitcoin-git> [bitcoin] promag closed pull request #13100: gui: Add dynamic wallets support (master...2018-04-ui-open-wallet) https://github.com/bitcoin/bitcoin/pull/13100
4372019-01-18T20:40:11 *** bitcoin-git has left #bitcoin-core-dev
4382019-01-18T20:41:36 <jnewbery> #15153 is next in the sequence I think. Mind if I add it to high priority?
4392019-01-18T20:41:39 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
4402019-01-18T20:41:44 <promag> sure
4412019-01-18T20:41:51 *** laurentmt has quit IRC
4422019-01-18T20:41:56 <promag> hope we get "open wallet" and "close wallet" the next couple of days
4432019-01-18T20:42:32 *** Guest50915 has quit IRC
4442019-01-18T20:42:34 <jnewbery> That'd be great. Thanks for all your work on this!
4452019-01-18T20:42:58 <promag> "close all wallets" is optional I think
4462019-01-18T20:43:11 <promag> no problem, sorry for the delay
4472019-01-18T20:44:48 <promag> had to make listwalletdir, walletlocation in before this. also #14670 to a lot to fix
4482019-01-18T20:44:50 <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
4492019-01-18T20:44:54 <promag> *took a lot
4502019-01-18T20:46:16 <jnewbery> yeah, that one took a while. I don't think there have been any complaints since 14670 so hopefully we won't have to touch that again
4512019-01-18T20:50:08 *** promag has quit IRC
4522019-01-18T20:50:44 *** promag has joined #bitcoin-core-dev
4532019-01-18T20:53:33 *** ranabd36 has joined #bitcoin-core-dev
4542019-01-18T20:53:43 <jonasschnelli> #14353 needs re-acks and another review (easy to review)
4552019-01-18T20:53:45 <gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
4562019-01-18T20:54:57 *** pinheadmz has quit IRC
4572019-01-18T20:55:11 *** promag has quit IRC
4582019-01-18T20:55:12 *** ranabd36 has quit IRC
4592019-01-18T21:02:40 *** mistergold has joined #bitcoin-core-dev
4602019-01-18T21:04:49 *** zivl has joined #bitcoin-core-dev
4612019-01-18T21:08:13 *** riemann_ has quit IRC
4622019-01-18T21:11:08 *** dgenr8 has joined #bitcoin-core-dev
4632019-01-18T21:16:31 *** bitcoin-git has joined #bitcoin-core-dev
4642019-01-18T21:16:31 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15206: p2p: immediately disconnect on invalid net message checksum (master...2019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
4652019-01-18T21:16:31 *** bitcoin-git has left #bitcoin-core-dev
4662019-01-18T21:31:26 *** kinlo has quit IRC
4672019-01-18T21:31:41 *** Krellan has joined #bitcoin-core-dev
4682019-01-18T21:35:45 *** kinlo has joined #bitcoin-core-dev
4692019-01-18T21:36:45 *** spinza has quit IRC
4702019-01-18T21:38:36 *** farmerwampum has quit IRC
4712019-01-18T21:39:21 *** spaced0ut has quit IRC
4722019-01-18T21:40:48 *** spinza has joined #bitcoin-core-dev
4732019-01-18T21:44:49 *** pinheadmz has joined #bitcoin-core-dev
4742019-01-18T21:45:44 *** farmerwampum has joined #bitcoin-core-dev
4752019-01-18T21:48:36 *** DeanGuss has joined #bitcoin-core-dev
4762019-01-18T21:50:23 *** Murch has quit IRC
4772019-01-18T21:54:14 *** Murch has joined #bitcoin-core-dev
4782019-01-18T22:01:51 *** pinheadmz has quit IRC
4792019-01-18T22:02:56 *** pinheadmz has joined #bitcoin-core-dev
4802019-01-18T22:04:12 *** mistergo1d has joined #bitcoin-core-dev
4812019-01-18T22:05:02 *** luke-jr has quit IRC
4822019-01-18T22:07:53 *** spinza has quit IRC
4832019-01-18T22:08:02 *** mistergold has quit IRC
4842019-01-18T22:09:50 <jnewbery> jonasschnelli: done!
4852019-01-18T22:10:11 *** Guyver2 has quit IRC
4862019-01-18T22:32:08 *** spinza has joined #bitcoin-core-dev
4872019-01-18T22:32:45 *** luke-jr has joined #bitcoin-core-dev
4882019-01-18T22:46:27 *** jarthur_ has joined #bitcoin-core-dev
4892019-01-18T22:48:07 *** jarthur has quit IRC
4902019-01-18T22:49:05 *** spinza has quit IRC
4912019-01-18T22:50:17 *** farmerwampum has quit IRC
4922019-01-18T22:56:48 *** spinza has joined #bitcoin-core-dev
4932019-01-18T22:57:16 *** rh0nj has quit IRC
4942019-01-18T22:58:08 *** rh0nj has joined #bitcoin-core-dev
4952019-01-18T23:01:38 *** spinza has quit IRC
4962019-01-18T23:03:38 *** Murch has quit IRC
4972019-01-18T23:05:30 *** kexkey has joined #bitcoin-core-dev
4982019-01-18T23:05:58 *** spinza has joined #bitcoin-core-dev
4992019-01-18T23:07:49 *** jarthur_ is now known as jarthur
5002019-01-18T23:09:22 *** TX1683 has quit IRC
5012019-01-18T23:10:44 *** kexkey has quit IRC
5022019-01-18T23:10:54 *** michaelsdunn1 has quit IRC
5032019-01-18T23:12:21 *** Murch has joined #bitcoin-core-dev
5042019-01-18T23:15:32 *** TX1683 has joined #bitcoin-core-dev
5052019-01-18T23:26:16 *** kexkey has joined #bitcoin-core-dev
5062019-01-18T23:32:20 *** ratonlaveur has joined #bitcoin-core-dev
5072019-01-18T23:33:23 *** farmerwampum has joined #bitcoin-core-dev
5082019-01-18T23:38:31 *** jarthur has quit IRC
5092019-01-18T23:38:51 *** farmerwampum has quit IRC
5102019-01-18T23:38:58 *** jarthur has joined #bitcoin-core-dev
5112019-01-18T23:40:50 *** pinheadmz has quit IRC
5122019-01-18T23:42:18 *** ratonlaveur_ has joined #bitcoin-core-dev
5132019-01-18T23:42:54 *** ratonlaveur__ has joined #bitcoin-core-dev
5142019-01-18T23:42:59 *** ratonlaveur has quit IRC
5152019-01-18T23:47:19 *** ratonlaveur_ has quit IRC
5162019-01-18T23:56:17 *** jarthur has quit IRC
5172019-01-18T23:58:48 *** coco has joined #bitcoin-core-dev