12019-01-22T00:03:01 *** michaelsdunn1 has joined #bitcoin-core-dev
22019-01-22T00:06:03 *** cubancorona has quit IRC
32019-01-22T00:11:26 *** ddustin has quit IRC
42019-01-22T00:11:55 *** ddustin has joined #bitcoin-core-dev
52019-01-22T00:13:32 *** pinheadmz has quit IRC
62019-01-22T00:14:05 *** pinheadmz has joined #bitcoin-core-dev
72019-01-22T00:16:18 *** ddustin has quit IRC
82019-01-22T00:30:23 *** ratonlaveur has joined #bitcoin-core-dev
92019-01-22T00:30:57 *** ratonlaveur_ has joined #bitcoin-core-dev
102019-01-22T00:34:42 *** ratonlaveur has quit IRC
112019-01-22T00:34:49 *** _luc__ has joined #bitcoin-core-dev
122019-01-22T00:40:17 *** _luc__ has quit IRC
132019-01-22T00:43:00 *** Murch has joined #bitcoin-core-dev
142019-01-22T00:44:15 *** _luc_ has joined #bitcoin-core-dev
152019-01-22T00:44:21 *** Aaronvan_ has quit IRC
162019-01-22T00:46:04 *** bitcoin-git has joined #bitcoin-core-dev
172019-01-22T00:46:04 <bitcoin-git> [bitcoin] Empact closed pull request #15221: lint: Bump flake8 to 3.6.0 (master...flake-36) https://github.com/bitcoin/bitcoin/pull/15221
182019-01-22T00:46:04 *** bitcoin-git has left #bitcoin-core-dev
192019-01-22T00:50:37 *** jarthur has quit IRC
202019-01-22T00:53:09 *** Dean_Guss has quit IRC
212019-01-22T00:53:31 *** TheRec has joined #bitcoin-core-dev
222019-01-22T00:54:54 *** miknotauro has quit IRC
232019-01-22T00:55:00 *** AaronvanW has joined #bitcoin-core-dev
242019-01-22T00:57:02 *** _luc_ has quit IRC
252019-01-22T00:57:18 *** Krellan has joined #bitcoin-core-dev
262019-01-22T00:59:50 *** AaronvanW has quit IRC
272019-01-22T01:06:13 *** michaelsdunn1 has quit IRC
282019-01-22T01:06:47 *** IZooo has quit IRC
292019-01-22T01:08:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
302019-01-22T01:10:30 *** Murch has quit IRC
312019-01-22T01:18:04 *** michaelsdunn1 has joined #bitcoin-core-dev
322019-01-22T01:19:38 *** Chris_Stewart_5 has quit IRC
332019-01-22T01:28:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
342019-01-22T01:38:24 *** AaronvanW has joined #bitcoin-core-dev
352019-01-22T01:42:58 *** AaronvanW has quit IRC
362019-01-22T01:48:10 <Chris_Stewart_5> exit
372019-01-22T01:48:12 *** Chris_Stewart_5 has quit IRC
382019-01-22T01:50:11 *** spinza has quit IRC
392019-01-22T02:06:02 *** rh0nj has quit IRC
402019-01-22T02:07:08 *** rh0nj has joined #bitcoin-core-dev
412019-01-22T02:10:50 *** AaronvanW has joined #bitcoin-core-dev
422019-01-22T02:16:44 *** pinheadmz has quit IRC
432019-01-22T02:23:15 *** ossifrage has quit IRC
442019-01-22T02:23:39 *** ossifrage has joined #bitcoin-core-dev
452019-01-22T02:32:10 *** michaelsdunn1 has quit IRC
462019-01-22T02:32:59 *** pinheadmz has joined #bitcoin-core-dev
472019-01-22T02:41:54 *** pinheadmz has quit IRC
482019-01-22T02:44:16 *** AaronvanW has quit IRC
492019-01-22T02:48:35 *** spinza has joined #bitcoin-core-dev
502019-01-22T02:59:01 *** Murch has joined #bitcoin-core-dev
512019-01-22T02:59:37 *** Murch has quit IRC
522019-01-22T03:16:02 *** benthecarman has joined #bitcoin-core-dev
532019-01-22T03:18:35 *** ratonlaveur_ has quit IRC
542019-01-22T03:32:07 *** bitcoin-git has joined #bitcoin-core-dev
552019-01-22T03:32:07 <bitcoin-git> [bitcoin] achow101 opened pull request #15226: Allow creating blank (empty) wallets (master...blank-wallets) https://github.com/bitcoin/bitcoin/pull/15226
562019-01-22T03:32:07 *** bitcoin-git has left #bitcoin-core-dev
572019-01-22T03:45:09 *** TSWR has quit IRC
582019-01-22T03:57:56 *** Krellan has quit IRC
592019-01-22T04:06:49 *** AaronvanW has joined #bitcoin-core-dev
602019-01-22T04:11:37 *** harrymm has quit IRC
612019-01-22T04:16:28 *** mistergo1d has joined #bitcoin-core-dev
622019-01-22T04:19:36 *** mistergold has quit IRC
632019-01-22T04:21:46 *** jb55 has quit IRC
642019-01-22T04:23:22 *** jb55 has joined #bitcoin-core-dev
652019-01-22T04:38:45 *** AaronvanW has quit IRC
662019-01-22T04:42:11 *** irc_viewer_test has joined #bitcoin-core-dev
672019-01-22T04:56:29 *** ddustin has joined #bitcoin-core-dev
682019-01-22T04:58:41 *** DeanGuss has joined #bitcoin-core-dev
692019-01-22T05:08:08 *** irc_viewer_test1 has joined #bitcoin-core-dev
702019-01-22T05:09:22 *** irc_viewer_test has quit IRC
712019-01-22T05:10:00 *** AaronvanW has joined #bitcoin-core-dev
722019-01-22T05:10:32 *** irc_viewer_test1 has quit IRC
732019-01-22T05:12:18 *** murrayn has joined #bitcoin-core-dev
742019-01-22T05:13:32 *** emilr has quit IRC
752019-01-22T05:14:12 *** AaronvanW has quit IRC
762019-01-22T05:15:13 *** ddustin has quit IRC
772019-01-22T05:16:20 *** ddustin has joined #bitcoin-core-dev
782019-01-22T05:35:01 *** MrPaz has joined #bitcoin-core-dev
792019-01-22T05:38:34 *** mistergo1d has quit IRC
802019-01-22T05:42:33 *** ratonlaveur_ has joined #bitcoin-core-dev
812019-01-22T05:45:10 *** jarthur has joined #bitcoin-core-dev
822019-01-22T05:46:35 *** AaronvanW has joined #bitcoin-core-dev
832019-01-22T06:01:03 *** _luc_ has joined #bitcoin-core-dev
842019-01-22T06:08:01 *** rh0nj has quit IRC
852019-01-22T06:09:07 *** rh0nj has joined #bitcoin-core-dev
862019-01-22T06:14:47 *** jarthur has quit IRC
872019-01-22T06:19:55 *** AaronvanW has quit IRC
882019-01-22T06:37:26 *** Krellan has joined #bitcoin-core-dev
892019-01-22T06:41:44 *** Krellan has quit IRC
902019-01-22T06:43:09 *** shesek has joined #bitcoin-core-dev
912019-01-22T06:43:09 *** shesek has joined #bitcoin-core-dev
922019-01-22T06:54:42 *** rex4539 has quit IRC
932019-01-22T06:57:28 *** AaronvanW has joined #bitcoin-core-dev
942019-01-22T07:02:00 *** AaronvanW has quit IRC
952019-01-22T07:13:49 *** _luc_ has quit IRC
962019-01-22T07:36:21 *** andytoshi has quit IRC
972019-01-22T07:37:34 *** AaronvanW has joined #bitcoin-core-dev
982019-01-22T07:46:12 *** rex4539 has joined #bitcoin-core-dev
992019-01-22T08:00:00 *** pinheadmz has joined #bitcoin-core-dev
1002019-01-22T08:00:23 *** ratonlaveur_ has quit IRC
1012019-01-22T08:05:02 *** pinheadmz has quit IRC
1022019-01-22T08:18:43 *** emilr has joined #bitcoin-core-dev
1032019-01-22T08:27:34 *** jungly has joined #bitcoin-core-dev
1042019-01-22T08:31:22 *** JackH has quit IRC
1052019-01-22T08:47:04 *** guga has joined #bitcoin-core-dev
1062019-01-22T08:47:58 *** AaronvanW has quit IRC
1072019-01-22T08:48:53 *** IZooo has joined #bitcoin-core-dev
1082019-01-22T08:51:18 *** jb55 has quit IRC
1092019-01-22T08:53:17 <IZooo> Hello !
1102019-01-22T09:03:09 *** jb55 has joined #bitcoin-core-dev
1112019-01-22T09:08:43 *** setpill has joined #bitcoin-core-dev
1122019-01-22T09:08:52 *** andytoshi has joined #bitcoin-core-dev
1132019-01-22T09:08:52 *** andytoshi has joined #bitcoin-core-dev
1142019-01-22T09:15:43 *** JackH has joined #bitcoin-core-dev
1152019-01-22T09:24:18 <meshcollider> jonasschnelli: to rebuild appveyor, just make sure you're logged in with github and click Re-Build PR at the top of the page, next to Log
1162019-01-22T09:24:53 <meshcollider> https://usercontent.irccloud-cdn.com/file/pMKT5Pjm/screenshot.png
1172019-01-22T09:25:43 <jonasschnelli> meshcollider: I don't have a restart button (logged in via GitHub)
1182019-01-22T09:31:04 <meshcollider> jonasschnelli: weird, in your github settings on the Authorized OAuth Apps page, does AppVeyor have access to read org and team membership, and the bitcoin org?
1192019-01-22T09:33:48 *** AaronvanW has joined #bitcoin-core-dev
1202019-01-22T09:39:04 *** AaronvanW has quit IRC
1212019-01-22T09:42:10 *** phwalkr has joined #bitcoin-core-dev
1222019-01-22T10:05:57 *** paracyst_ has joined #bitcoin-core-dev
1232019-01-22T10:06:42 *** paracyst has quit IRC
1242019-01-22T10:07:29 *** AaronvanW has joined #bitcoin-core-dev
1252019-01-22T10:16:17 *** AaronvanW has quit IRC
1262019-01-22T10:22:30 *** spinza has quit IRC
1272019-01-22T10:22:32 *** rex4539 has quit IRC
1282019-01-22T10:25:35 *** elichai2 has joined #bitcoin-core-dev
1292019-01-22T10:31:42 *** AaronvanW has joined #bitcoin-core-dev
1302019-01-22T10:35:47 *** AaronvanW has quit IRC
1312019-01-22T10:48:25 *** ddustin has quit IRC
1322019-01-22T10:49:05 *** miknotauro has joined #bitcoin-core-dev
1332019-01-22T10:51:38 *** spinza has joined #bitcoin-core-dev
1342019-01-22T10:57:39 *** fanquake has joined #bitcoin-core-dev
1352019-01-22T11:04:34 *** AaronvanW has joined #bitcoin-core-dev
1362019-01-22T11:37:54 *** AaronvanW has quit IRC
1372019-01-22T11:38:17 *** rex4539 has joined #bitcoin-core-dev
1382019-01-22T11:49:21 *** promag has joined #bitcoin-core-dev
1392019-01-22T11:54:14 *** AaronvanW has joined #bitcoin-core-dev
1402019-01-22T11:58:21 *** luke-jr has quit IRC
1412019-01-22T12:00:15 *** luke-jr has joined #bitcoin-core-dev
1422019-01-22T12:16:57 *** nodweber2 has quit IRC
1432019-01-22T12:17:17 *** nodweber has joined #bitcoin-core-dev
1442019-01-22T12:17:43 *** luke-jr has quit IRC
1452019-01-22T12:18:12 *** luke-jr has joined #bitcoin-core-dev
1462019-01-22T12:19:55 <wumpus> #14711 seems almost ready for merge for a while, really just waiting for ryanofsky to respond to empact's comment on the test
1472019-01-22T12:20:00 <gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub
1482019-01-22T12:25:03 *** arubi has quit IRC
1492019-01-22T12:25:04 *** sipa has quit IRC
1502019-01-22T12:25:49 <promag> jonasschnelli: what do you think of #15153, if it should open the wallet asynchronously to not block the UI?
1512019-01-22T12:25:51 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
1522019-01-22T12:27:08 *** luke-jr has quit IRC
1532019-01-22T12:29:50 *** luke-jr has joined #bitcoin-core-dev
1542019-01-22T12:31:02 <wumpus> promag: seems like something that can be done later, blocking the GUI a little bit when opening a file is more or less expecated
1552019-01-22T12:31:34 *** arubi has joined #bitcoin-core-dev
1562019-01-22T12:31:37 <wumpus> (unless it takes so long it needs a progress indicator)
1572019-01-22T12:31:38 *** sipa has joined #bitcoin-core-dev
1582019-01-22T12:32:08 <promag> wumpus: no, I kind of have that, it just doesn't show the progress
1592019-01-22T12:32:13 <promag> 0 -> 100%
1602019-01-22T12:32:26 <promag> it's a indeterminate progress dialog
1612019-01-22T12:32:32 <fanquake> promag I'll have a look again
1622019-01-22T12:32:50 <promag> fanquake: hi, I'll push the progress dialog in a bit
1632019-01-22T12:32:57 <promag> I'll let you know
1642019-01-22T12:32:59 <wumpus> the risk of blocking the GUI thread too long is that some operating systems (as well as users) will conclude that the program crashed and terminate it
1652019-01-22T12:33:11 <promag> or the user
1662019-01-22T12:33:40 <fanquake> wumpus yea, in the original PR, the gui would essentially freeze, and you'd get the macOS beach ball, so a user would conclude a crash.
1672019-01-22T12:33:51 <promag> someone should come up with a good text, like "Opening wallet foobar, please wait bla bla...2
1682019-01-22T12:33:55 <wumpus> fanquake: right
1692019-01-22T12:34:31 <promag> fanquake: I put some millisleep in the rescan loop and it is indeed bad
1702019-01-22T12:34:58 <promag> this doesn't happen when opening the wallet with loadwallet RPC in the RPC console
1712019-01-22T12:35:08 <promag> as the command is executed in a background thread
1722019-01-22T12:35:16 <promag> *RPC server thread
1732019-01-22T13:00:56 *** timothy has quit IRC
1742019-01-22T13:04:54 <promag> fanquake: provoostenator: added a progress indicator while the open is loading
1752019-01-22T13:05:38 <fanquake> promag cool, i'll try have a look tonight
1762019-01-22T13:41:18 *** ezzzy has joined #bitcoin-core-dev
1772019-01-22T13:46:36 *** bitcoin-git has joined #bitcoin-core-dev
1782019-01-22T13:46:37 <bitcoin-git> [bitcoin] hebasto closed pull request #15220: Qt, Trivial: Refactor UI forms (master...20190120-form-ui-refactor) https://github.com/bitcoin/bitcoin/pull/15220
1792019-01-22T13:46:37 *** bitcoin-git has left #bitcoin-core-dev
1802019-01-22T14:01:58 *** owowo has quit IRC
1812019-01-22T14:06:15 *** owowo has joined #bitcoin-core-dev
1822019-01-22T14:13:17 *** promag has quit IRC
1832019-01-22T14:16:56 *** promag_ has joined #bitcoin-core-dev
1842019-01-22T14:20:53 *** owowo has quit IRC
1852019-01-22T14:21:25 *** promag_ has quit IRC
1862019-01-22T14:22:15 *** kexkey has joined #bitcoin-core-dev
1872019-01-22T14:22:16 *** owowo has joined #bitcoin-core-dev
1882019-01-22T14:23:31 *** promag has joined #bitcoin-core-dev
1892019-01-22T14:25:15 *** promag_ has joined #bitcoin-core-dev
1902019-01-22T14:26:28 *** promag has quit IRC
1912019-01-22T14:26:51 *** Guyver2 has joined #bitcoin-core-dev
1922019-01-22T14:29:56 *** mistergold has joined #bitcoin-core-dev
1932019-01-22T14:32:57 *** owowo has quit IRC
1942019-01-22T14:34:42 <provoostenator> promag: cool! Checking now.
1952019-01-22T14:38:04 *** jhfrontz has quit IRC
1962019-01-22T14:38:18 *** owowo has joined #bitcoin-core-dev
1972019-01-22T14:39:00 *** jhfrontz has joined #bitcoin-core-dev
1982019-01-22T14:41:11 <promag_> provoostenator: I think we should do as little as possible regarding fancy GUI and threading jiggling
1992019-01-22T14:41:17 *** promag_ is now known as promag
2002019-01-22T14:46:49 <provoostenator> As little as ppossible yes, but a blocking UI and/or missing transactions without explanation is not acceptable either.
2012019-01-22T14:49:47 <provoostenator> See my new comment. However if it's too difficult, we could also just add a standard warning, if the wallet is more than N blocks old, that "this may take a while".
2022019-01-22T14:50:34 <provoostenator> A progress bar plus a way to abort seems way nicer though, and you've made good progress :-)
2032019-01-22T14:53:58 <promag> provoostenator: what you mean by "I don't think the progress bar actually works." ?
2042019-01-22T14:54:43 *** qrestlove has quit IRC
2052019-01-22T14:54:51 <provoostenator> It just shows 100% all the time.
2062019-01-22T14:56:07 <wumpus> progess bar doesn't work for things that run in the GUI thread
2072019-01-22T14:56:40 <wumpus> to update the GUI it needs a running GUI event loop
2082019-01-22T14:58:01 <wumpus> a long time ago there was the same problem for initialization/shutdown, which is why it was moved to a separate thread
2092019-01-22T14:59:01 *** kexkey_ has joined #bitcoin-core-dev
2102019-01-22T14:59:33 *** kexkey has quit IRC
2112019-01-22T15:02:01 <promag> provoostenator: it's inderterminate
2122019-01-22T15:03:08 <promag> provoostenator: from http://doc.qt.io/qt-5/qprogressbar.html#details > If minimum and maximum both are set to 0, the bar shows a busy indicator instead of a percentage of steps.
2132019-01-22T15:03:30 *** Bullit has quit IRC
2142019-01-22T15:04:35 <provoostenator> wumpus: rescan wallet has a pretty descent progress bar in the GUI though.
2152019-01-22T15:04:52 <provoostenator> (oh wait, you mean GUI thread, not GUI period)
2162019-01-22T15:05:24 <wumpus> I think that runs in a separate thread that sends progress notifications to the GUI event loop thread
2172019-01-22T15:05:26 <wumpus> yea
2182019-01-22T15:05:42 <provoostenator> Imo it should figure out which blocks the rescan covers, because it can take a *long* time.
2192019-01-22T15:06:11 <provoostenator> The logs do show this progress by the way, so it's "known" by something.
2202019-01-22T15:07:07 *** ExtraCrispy has quit IRC
2212019-01-22T15:07:50 *** qrestlove has joined #bitcoin-core-dev
2222019-01-22T15:13:15 <promag> provoostenator: the problem is that the progress notification is a global notification
2232019-01-22T15:13:41 <promag> for instance, it would be problematic if there are 2 tasks reporting progress
2242019-01-22T15:14:28 <promag> and while that works for dumping progress to the log, for the GUI it should be more contained
2252019-01-22T15:17:11 *** fanquake has quit IRC
2262019-01-22T15:17:36 <promag> what I mean is that interfaces::Node::loadWallet should probably return an interfaces::Activity, and this would allow to know the progress, errors etc and also to pause, cancel etc
2272019-01-22T15:22:13 <promag> provoostenator: pushed, let me know
2282019-01-22T15:29:23 *** michaelsdunn1 has joined #bitcoin-core-dev
2292019-01-22T15:37:17 *** wxss has quit IRC
2302019-01-22T15:38:28 *** mistergold has quit IRC
2312019-01-22T15:41:14 *** ExtraCrispy has joined #bitcoin-core-dev
2322019-01-22T15:51:53 *** ExtraCrispy has quit IRC
2332019-01-22T15:54:29 *** booyah has quit IRC
2342019-01-22T15:58:30 *** ezzzy has quit IRC
2352019-01-22T16:01:15 *** Mohamed has quit IRC
2362019-01-22T16:03:30 *** guga has quit IRC
2372019-01-22T16:04:53 *** setpill has quit IRC
2382019-01-22T16:04:55 <jamesob> do we prefer (i) more #ifdefs or (2) very light unnecessary header bloat?
2392019-01-22T16:06:15 *** setpill has joined #bitcoin-core-dev
2402019-01-22T16:07:53 <jamesob> (in the context of https://github.com/bitcoin/bitcoin/pull/15205#discussion_r249681321)
2412019-01-22T16:08:16 *** promag has quit IRC
2422019-01-22T16:08:33 *** Bullit has joined #bitcoin-core-dev
2432019-01-22T16:09:28 <gmaxwell> :-/
2442019-01-22T16:12:13 <jamesob> gmaxwell: what ails ye
2452019-01-22T16:12:24 *** setpill has quit IRC
2462019-01-22T16:12:30 *** kexkey_ has quit IRC
2472019-01-22T16:19:24 <sipa> jamesob: have you seen #14289 ?
2482019-01-22T16:19:25 <gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
2492019-01-22T16:20:02 <jamesob> sipa: missed that, will give it a read. thanks for the pointer
2502019-01-22T16:20:23 <sipa> one of the ideas i suggested there was to have a debug mode where the queue depth is 0, which would cause the deadlock detector to trigger on anything that would become a deadlock in case of queue overflow
2512019-01-22T16:20:42 <sipa> though there are existing violations in the code
2522019-01-22T16:25:38 <jamesob> sipa: so that would effectively collapse the scheduler thread into the caller's?
2532019-01-22T16:26:14 <sipa> yes
2542019-01-22T16:26:55 <sipa> and if that works, there should be no risk in having a limited (but bounded) queue depth to increase parallellism for taks that can meaningfully be done in the background
2552019-01-22T16:27:14 <jamesob> sipa: seems like that might make it harder to find races when the deadlock detector is enabled though, no?
2562019-01-22T16:27:23 <sipa> how so?
2572019-01-22T16:27:38 <jamesob> you're losing the asynchronicity of the scheduler
2582019-01-22T16:28:10 <sipa> it immediately causes every callsite of a scheduled task to not hold the locks that its background task will need
2592019-01-22T16:28:23 <sipa> and makes the deadlock detector notice these
2602019-01-22T16:29:11 <sipa> it's still possible to have two different modules with different locks that both post a background task that runs in the other module's locks... but that would be a circular dependency in the code anyway
2612019-01-22T16:30:07 <sipa> i'm not saying this should be the only way of testing the scheduler
2622019-01-22T16:30:35 <jamesob> sure
2632019-01-22T16:31:25 <sipa> it just feels that your PR is very specialized to one instance of a background task
2642019-01-22T16:31:40 <jamesob> yeah, agreed
2652019-01-22T16:31:47 <sipa> and with that approach i expect we'll miss future introductions
2662019-01-22T16:31:48 <sipa> hmm
2672019-01-22T16:32:06 <sipa> what if we require that all calls to scheduler posts are done with no locks held?
2682019-01-22T16:32:20 <jamesob> heh, that sounds like a huge refactor
2692019-01-22T16:32:26 <jamesob> well maybe not huge
2702019-01-22T16:32:27 <sipa> i don't think so
2712019-01-22T16:32:32 <sipa> it's almost the case already
2722019-01-22T16:32:48 <sipa> apart from invalidateblock
2732019-01-22T16:34:38 *** miknotauro has quit IRC
2742019-01-22T16:36:41 *** twistedline has quit IRC
2752019-01-22T16:39:48 *** promag has joined #bitcoin-core-dev
2762019-01-22T16:41:59 *** Murch has joined #bitcoin-core-dev
2772019-01-22T16:44:04 *** promag has quit IRC
2782019-01-22T16:47:59 <jamesob> sipa: talked a bit with sdaftuar and ryanofsky offline; sounds like it'd be worth trying to write the depth=0 mode and seeing where it breaks down
2792019-01-22T16:48:37 *** pinheadmz has joined #bitcoin-core-dev
2802019-01-22T16:49:57 *** booyah has joined #bitcoin-core-dev
2812019-01-22T16:52:05 *** ddustin has joined #bitcoin-core-dev
2822019-01-22T16:52:56 *** promag has joined #bitcoin-core-dev
2832019-01-22T16:55:48 <sipa> jamesob: i think now that trying to just enforce no locks when posting is better
2842019-01-22T16:56:10 <sipa> you could have two modules that bothbrequire different locks, and each posts a job that needs the other's lock
2852019-01-22T16:56:21 <sipa> which you don't detect with the deoth=0 thing
2862019-01-22T16:57:08 *** promag has quit IRC
2872019-01-22T16:57:18 <sipa> no locks at all is overkill, but just as easy to achieve (from my limited memory), and much more tight
2882019-01-22T16:59:24 <provoostenator> Is there an easy way to change the wallet height directly in a wallet.dat file (to trigger a rescan upon load)?
2892019-01-22T16:59:42 *** twistedline has joined #bitcoin-core-dev
2902019-01-22T17:00:44 *** jarthur has joined #bitcoin-core-dev
2912019-01-22T17:06:44 *** laurentmt has joined #bitcoin-core-dev
2922019-01-22T17:10:59 *** laurentmt has quit IRC
2932019-01-22T17:14:38 <wumpus> omg apt vulnerable to MITM attack https://lists.debian.org/debian-security-announce/2019/msg00010.html
2942019-01-22T17:15:47 *** bitcoin-git has joined #bitcoin-core-dev
2952019-01-22T17:15:47 <bitcoin-git> [bitcoin] Sjors closed pull request #14938: Support creating an empty wallet (master...2018/12/create-empty-wallet) https://github.com/bitcoin/bitcoin/pull/14938
2962019-01-22T17:15:47 *** bitcoin-git has left #bitcoin-core-dev
2972019-01-22T17:20:20 *** JackH has quit IRC
2982019-01-22T17:21:20 *** dqx has quit IRC
2992019-01-22T17:22:12 *** dqx has joined #bitcoin-core-dev
3002019-01-22T17:27:26 *** elichai2 has quit IRC
3012019-01-22T17:33:38 *** laurentmt has joined #bitcoin-core-dev
3022019-01-22T17:40:08 *** promag has joined #bitcoin-core-dev
3032019-01-22T17:43:43 *** ghost43 has quit IRC
3042019-01-22T17:43:59 *** ghost43 has joined #bitcoin-core-dev
3052019-01-22T17:44:16 *** zshlyk has quit IRC
3062019-01-22T17:44:32 *** ratonlaveur has joined #bitcoin-core-dev
3072019-01-22T17:45:02 *** ratonlaveur_ has joined #bitcoin-core-dev
3082019-01-22T17:45:12 *** zshlyk has joined #bitcoin-core-dev
3092019-01-22T17:48:47 *** ratonlaveur has quit IRC
3102019-01-22T17:53:25 *** _luc_ has joined #bitcoin-core-dev
3112019-01-22T17:55:34 <phantomcircuit> sipa, wait openssl gutted a function and replaced it with a stub that didn't even try to do what the original did?
3122019-01-22T17:55:36 <phantomcircuit> the fuck
3132019-01-22T17:57:47 *** _luc_ has quit IRC
3142019-01-22T18:03:24 *** ddustin has quit IRC
3152019-01-22T18:03:56 *** JackH has joined #bitcoin-core-dev
3162019-01-22T18:04:04 *** promag has quit IRC
3172019-01-22T18:04:40 <wumpus> provoostenator: hmm maybe one of the db4.8_ tools can be used to change the concerning key/value directly?
3182019-01-22T18:05:24 <wumpus> (a very crude way would be to use db_dump, edit the output, then db_load that to a new database)
3192019-01-22T18:05:59 <provoostenator> The db_dump route sounds reasonable, if that's more readable then the .dat file itself. I only have to do it once, and then just keep a copy around.
3202019-01-22T18:07:00 <wumpus> well it's hex...
3212019-01-22T18:07:56 <jamesob> sipa: what would we do with all the GetMainSignals(). calls in, say ConnectTip, while we're holding cs_main (of which there are many per ABC call)? buffer them up?
3222019-01-22T18:11:31 *** dqx has quit IRC
3232019-01-22T18:12:38 <jamesob> swapping out scheduler execution for an immediate blocking call sounds really easy compared to enforcing a no-lock push, and it seems like we'd get the same testing benefit
3242019-01-22T18:13:23 <sipa> jamesob ok
3252019-01-22T18:17:20 *** dqx has joined #bitcoin-core-dev
3262019-01-22T18:19:28 <hebasto> bionic used for gitian builds has apt 1.6.6ubuntu0.1 with fixed CVE-2019-3462
3272019-01-22T18:22:49 *** jungly has quit IRC
3282019-01-22T18:30:59 *** jhfrontz has quit IRC
3292019-01-22T18:31:42 *** wxss has joined #bitcoin-core-dev
3302019-01-22T18:33:00 *** wxss has quit IRC
3312019-01-22T18:33:26 *** wxss has joined #bitcoin-core-dev
3322019-01-22T18:35:17 *** ddustin has joined #bitcoin-core-dev
3332019-01-22T18:38:18 *** wxss has quit IRC
3342019-01-22T18:38:47 *** wxss has joined #bitcoin-core-dev
3352019-01-22T18:39:47 *** ddustin has quit IRC
3362019-01-22T18:40:57 <jamesob> sipa: but if you can think of an easyish way to do it, I'm happy to try
3372019-01-22T18:44:40 <sipa> jamesob: we can do one first and the other later
3382019-01-22T18:44:53 <sipa> both will require breaking up invalidateblock though
3392019-01-22T18:47:25 <wumpus> hebasto: I'm sure it will be widely patched now; what is kind of worrying to me is all the time that this issue did exist, people that knew about it could install arbitrary packages on every debian* system
3402019-01-22T18:47:59 *** _luc_ has joined #bitcoin-core-dev
3412019-01-22T18:50:04 <wumpus> hebasto: MITMing a mirror is not trivial and requires access to someone's network, but say, open wifi networks or tor exit nodes would certainly be a vector
3422019-01-22T18:51:16 <harding> Don't apt packages require an approved signature in order to be installed? The linked post doesn't describe how that protection is bypassed.
3432019-01-22T18:51:53 <wumpus> harding: I'm not sure either
3442019-01-22T18:52:23 *** _luc_ has quit IRC
3452019-01-22T18:54:54 <jamesob> harding: see "Planting the malicious package" here: https://justi.cz/security/2019/01/22/apt-rce.html
3462019-01-22T18:55:15 <wumpus> you're right that signing *should* prevent this, I think that's what evryone expected
3472019-01-22T19:06:06 <harding> jamesob: ah, thanks! "The parent process will trust the hashes returned in the injected 201 URI Done response, and compare them with the values from the signed package manifest. Since the attacker controls the reported hashes, they can use this vulnerability to convincingly forge any package."
3482019-01-22T19:06:52 *** jhfrontz has joined #bitcoin-core-dev
3492019-01-22T19:09:08 <hebasto> wow ^
3502019-01-22T19:10:30 *** zivl has quit IRC
3512019-01-22T19:11:02 *** ddustin has joined #bitcoin-core-dev
3522019-01-22T19:12:18 <wumpus> ouch.
3532019-01-22T19:15:41 <sipa> ouch.
3542019-01-22T19:15:47 *** ddustin has quit IRC
3552019-01-22T19:17:23 *** pinheadmz has quit IRC
3562019-01-22T19:18:17 *** pinheadmz has joined #bitcoin-core-dev
3572019-01-22T19:19:12 *** dviola has joined #bitcoin-core-dev
3582019-01-22T19:19:38 *** IZooo has quit IRC
3592019-01-22T19:26:19 *** zivl has joined #bitcoin-core-dev
3602019-01-22T19:29:06 <luke-jr> does apt-cacher prevent this?
3612019-01-22T19:33:46 *** pinheadmz has quit IRC
3622019-01-22T19:39:17 <wumpus> that's hard to say, depends on whether it simply dumbly caches and forwards the response, or does its own validation
3632019-01-22T19:42:16 *** _luc_ has joined #bitcoin-core-dev
3642019-01-22T19:42:59 <wumpus> A *normal* http proxy at least is not going to stop this
3652019-01-22T19:43:26 <wumpus> I wonder if the apt packages are served over https
3662019-01-22T19:43:48 <luke-jr> apt ships without https support
3672019-01-22T19:44:09 <wumpus> bleh
3682019-01-22T19:44:24 <luke-jr> I do wonder how they expect people to patch this
3692019-01-22T19:44:31 <luke-jr> since updating apt implies exposing yourself
3702019-01-22T19:44:45 <wumpus> apparently the flag "apt -o Acquire::http::AllowRedirect=false" prevents the issue
3712019-01-22T19:44:51 <luke-jr> ah
3722019-01-22T19:45:14 <wumpus> the idea is that you need to use that once for both update and upgrade, then make sure it updates your apt
3732019-01-22T19:45:51 <luke-jr> -bash: apt: command not found
3742019-01-22T19:45:54 <luke-jr> XD
3752019-01-22T19:46:33 <luke-jr> aptitude seems to work the same
3762019-01-22T19:46:51 *** _luc_ has quit IRC
3772019-01-22T19:46:53 <wumpus> that's another question, whether aptitude is affected
3782019-01-22T19:47:17 <luke-jr> W: Failed to fetch http://security.debian.org/dists/wheezy/updates/main/binary-amd64/Packages: 302 Found [IP: 2001:4f8:1:c::14 80]
3792019-01-22T19:47:18 <luke-jr> :|
3802019-01-22T19:47:25 <wumpus> I wouldn't be surprised if it shares the same code
3812019-01-22T19:47:34 <luke-jr> apparently, since the option broke it
3822019-01-22T19:48:52 <wumpus> why is it redirecting to some weird IPv6
3832019-01-22T19:49:34 <luke-jr> MITM?\
3842019-01-22T19:50:25 <wumpus> it is suspicious for sure
3852019-01-22T19:50:39 <luke-jr> I have bigger problems I guess "Wheezy also benefits from Long Term Support (LTS) until the end of May 2018."
3862019-01-22T19:50:52 <hebasto> luke-jr: Debian ha apt pkg since jessie: https://packages.debian.org/sid/apt
3872019-01-22T19:50:59 <hebasto> *has
3882019-01-22T19:51:20 <luke-jr> hebasto: probably not in the super-stripped-down-minimal installs?
3892019-01-22T19:52:00 <hebasto> luke-jr: are you using wheezy?
3902019-01-22T19:52:24 <wumpus> this mentions the specific IPv6 address: https://www.reddit.com/r/debian/comments/727ti9/issues_with_aptget_update/ I think it's debian's own
3912019-01-22T19:52:40 <luke-jr> hebasto: on that particular system
3922019-01-22T19:53:25 <hebasto> wheezy definitely has no apt pkg
3932019-01-22T19:53:53 <wumpus> $ host mirror-isc2.debian.org
3942019-01-22T19:53:55 <wumpus> mirror-isc2.debian.org has address 149.20.4.14
3952019-01-22T19:53:57 <wumpus> mirror-isc2.debian.org has IPv6 address 2001:4f8:1:c::14
3962019-01-22T19:54:17 <wumpus> still I don't understand why it would redirect but ok--
3972019-01-22T19:54:19 <booyah> maybe apt-based distro developers should consider keys compromised, reinstall and make new signing keys...
3982019-01-22T19:54:31 <luke-jr> why?
3992019-01-22T19:54:52 <booyah> luke-jr: above mentioned apt exploit. Everyone running Debian could easily be compromised (remote root)
4002019-01-22T19:55:12 <luke-jr> oh, including the people who have those keys
4012019-01-22T19:55:33 <booyah> oh I ment, maybe developers of Bitcoin, who use such vulnerable system
4022019-01-22T19:57:15 *** ratonlaveur__ has joined #bitcoin-core-dev
4032019-01-22T19:58:46 *** ratonlaveur has joined #bitcoin-core-dev
4042019-01-22T20:00:26 *** ratonlaveur_ has quit IRC
4052019-01-22T20:00:33 <luke-jr> ah
4062019-01-22T20:00:54 <luke-jr> (FWIW, my keys are NOT on such a system)
4072019-01-22T20:01:20 <wumpus> mine are on a yubikey
4082019-01-22T20:01:40 *** ratonlaveur__ has quit IRC
4092019-01-22T20:02:05 <wumpus> not that it helps much if the system is compromised it's easy enough to MITM that to sign something else than you expect
4102019-01-22T20:02:17 <wumpus> but to go completely scorched earth...
4112019-01-22T20:02:58 *** pinheadmz has joined #bitcoin-core-dev
4122019-01-22T20:03:27 <cjd> https://bgp.he.net/ip/2001:4f8:1:c::14#_ipinfo
4132019-01-22T20:04:03 <cjd> IMO that's highly sketchy, no actual whois for the address
4142019-01-22T20:04:23 <cjd> it looks like a bgp hijack
4152019-01-22T20:06:28 <cjd> on my system:
4162019-01-22T20:06:29 <cjd> $ curl -v http://security.debian.org/dists/wheezy/updates/mainry-amd64/Packages >/dev/null
4172019-01-22T20:06:38 <cjd> < Location: http://security-cdn.debian.org/dists/wheezy/updates/main/binary-amd64/Packages
4182019-01-22T20:06:46 *** lukedashjr has joined #bitcoin-core-dev
4192019-01-22T20:06:58 <cjd> host security-cdn.debian.org
4202019-01-22T20:07:15 <cjd> prod.debian.map.fastly.net, 151.101.60.204, 2a04:4e42:f::204
4212019-01-22T20:07:28 <cjd> that's much more what I'd expect to see
4222019-01-22T20:07:46 <cjd> and `whois 2a04:4e42:f::204` gives you an actual company
4232019-01-22T20:08:36 *** luke-jr has quit IRC
4242019-01-22T20:11:58 <jnewbery> #proposedmeetingtopic Chaincode summer residency
4252019-01-22T20:12:20 <jnewbery> ^^ looking for (remote) mentors and recommendations for residents
4262019-01-22T20:12:33 <wumpus> probably best to tag moneyball ^^
4272019-01-22T20:13:49 <jnewbery> thanks wumpus
4282019-01-22T20:14:14 *** lukedashjr has quit IRC
4292019-01-22T20:16:10 <jnewbery> I'm removing #15141 from high priority while sdaftuar reworks it
4302019-01-22T20:16:15 <gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
4312019-01-22T20:16:38 <jnewbery> Also removing #14938 and replacing it with #15226
4322019-01-22T20:16:43 <gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub
4332019-01-22T20:16:45 <gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
4342019-01-22T20:17:04 *** laurentmt has quit IRC
4352019-01-22T20:21:45 *** pinheadmz has quit IRC
4362019-01-22T20:22:30 *** arubi has quit IRC
4372019-01-22T20:25:27 *** arubi has joined #bitcoin-core-dev
4382019-01-22T20:32:26 <gkrizek> wumpus: I finally finished my GitHub IRC Service replacement. https://github.com/gkrizek/ghi I had several others ask for it too so I made it really configurable, much like the original service.
4392019-01-22T20:32:32 <gkrizek> I'm more than happy to host the service myself, but can help you set it up elsewhere if you prefer.
4402019-01-22T20:32:45 <wumpus> gkrizek: awesome!
4412019-01-22T20:36:22 <wumpus> looks very neat
4422019-01-22T20:36:37 *** _luc_ has joined #bitcoin-core-dev
4432019-01-22T20:37:32 *** kexkey has joined #bitcoin-core-dev
4442019-01-22T20:37:56 <gkrizek> Thanks!
4452019-01-22T20:41:15 <wumpus> and the documentation seems quite clear, I'll probably succeed in setting it up :)
4462019-01-22T20:41:17 *** _luc_ has quit IRC
4472019-01-22T20:42:19 <gkrizek> wumpus: great, that was the goal! Don't hesitate to ask. I can give you an example '.ghi.yml' file to use if you would like as well.
4482019-01-22T20:43:05 <gkrizek> I was thinking it might be nice to add it as a webhook now and have it post to the #bitcoin-commits channel. That way we can test it out and see how it compares to the GitHub Service before it's EOL.
4492019-01-22T20:43:38 <wumpus> good idea
4502019-01-22T20:44:59 *** bitcoin-git has joined #bitcoin-core-dev
4512019-01-22T20:44:59 <bitcoin-git> [bitcoin] jamesob closed pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
4522019-01-22T20:44:59 *** bitcoin-git has left #bitcoin-core-dev
4532019-01-22T20:46:40 *** spinza has quit IRC
4542019-01-22T20:49:04 <wumpus> gkrizek: I've removed the github service from #bitcoin-commits, right setting up an account on my server to run ghi, and sure an example could be helpful :)
4552019-01-22T20:51:07 <gkrizek> Awesome, I'll create one
4562019-01-22T20:51:47 *** spinza has joined #bitcoin-core-dev
4572019-01-22T20:54:38 <gkrizek> wumpus is the bitcoin-git Nick registered (ie; needs a password)?
4582019-01-22T20:55:36 *** promag has joined #bitcoin-core-dev
4592019-01-22T21:00:03 *** promag has quit IRC
4602019-01-22T21:02:06 <wumpus> gkrizek: it's not registered, probably should be tho
4612019-01-22T21:02:27 <gkrizek> Yeah, I would suggest it. But it will work either way
4622019-01-22T21:05:55 <gkrizek> wumpus: Example config file: https://gist.github.com/gkrizek/8ff05e1dd3196d488a71510838fcac72
4632019-01-22T21:07:04 <gkrizek> I think that should match the current GitHub service from what iI understand of it.
4642019-01-22T21:07:07 <gkrizek> I*
4652019-01-22T21:09:04 <wumpus> I guess boto3 is not necessary when not running from amazon?
4662019-01-22T21:10:48 *** Krellan has joined #bitcoin-core-dev
4672019-01-22T21:11:43 <wumpus> gkrizek: the secret is simply an API token without special permissions?
4682019-01-22T21:11:44 <gkrizek> wumpus: no it's not. I was meaning to create two separate `requirements.txt` files. One for server, one for AWS but I forgot
4692019-01-22T21:12:08 <gkrizek> wumpus No, the Secret is something you make up.
4702019-01-22T21:12:43 <gkrizek> https://developer.github.com/webhooks/securing/#setting-your-secret-token
4712019-01-22T21:13:11 <wumpus> ohh right, it gets pushed events, it doesn't pull them
4722019-01-22T21:13:57 <gkrizek> Exactly. And that's how Ghi can validate that it actually came from GitHub and someone isn't trying to MITM/spoof/etc
4732019-01-22T21:14:30 <wumpus> makes sense!
4742019-01-22T21:15:09 *** sipa has quit IRC
4752019-01-22T21:15:23 *** sipa has joined #bitcoin-core-dev
4762019-01-22T21:16:12 *** ratonlaveur has quit IRC
4772019-01-22T21:24:36 <wumpus> hm "2019-01-22 22:23:51 [ghi] Received repository 'bitcoin/bitcoin', but no pool is configured for it."
4782019-01-22T21:25:10 <wumpus> (after running it and setting up the webhook)
4792019-01-22T21:25:58 <gkrizek> Did you setup the .ghi.yml file? I linked you to an example
4802019-01-22T21:26:02 <gkrizek> https://gist.github.com/gkrizek/8ff05e1dd3196d488a71510838fcac72
4812019-01-22T21:27:25 <wumpus> I use that, only filled in the secret and changed the nick (to not conflict with github), and it says "2019-01-22 22:23:51 [ghi] Found configuration file at '/home/ghi/ghi/.ghi.yml'"
4822019-01-22T21:27:38 <wumpus> oh! no, it's picking up the wrong file
4832019-01-22T21:28:39 <gkrizek> Where did you put your .ghi.yml that I sent you? The repo contains a template that is in the root of the repo, so you should really edit that. Or delete it and put yours somewhere else
4842019-01-22T21:29:10 <wumpus> I've put it in the homedir, but it was picking up the one in the local directory, launching it from somewhere else now
4852019-01-22T21:29:12 <gkrizek> Good testing though! haha I didn't quiet think about that being confusing, but I can definitely see where that could cause problems
4862019-01-22T21:30:03 <gkrizek> I should probably just delete the template .ghi.yml from the root of the project. That way you are forced to create one on start and it doesn't use the template
4872019-01-22T21:30:58 *** _luc_ has joined #bitcoin-core-dev
4882019-01-22T21:31:10 <wumpus> or maybe rename it to ghi.yml.example
4892019-01-22T21:31:34 <wumpus> I agree having a life configuration file in the repo is probably not a good idea, wouldn't want to accidentally check it in with the secret in it
4902019-01-22T21:31:56 <wumpus> (which is why I used a location outside the repo)
4912019-01-22T21:33:30 <gkrizek> Yep, I think you are exactly right.
4922019-01-22T21:33:48 <gkrizek> Did the homedir file work now?
4932019-01-22T21:34:32 <wumpus> I don't know if I can make it re-send the initial event
4942019-01-22T21:34:38 <wumpus> should I recreate the webhook?
4952019-01-22T21:34:40 <gkrizek> You can, one sec
4962019-01-22T21:34:46 <gkrizek> I'll try to find Docs
4972019-01-22T21:34:58 <wumpus> oh I see, "redeliver" lol
4982019-01-22T21:35:13 <gkrizek> https://developer.github.com/webhooks/testing/
4992019-01-22T21:35:17 <gkrizek> Yep, that's it
5002019-01-22T21:35:24 <Lightsword> we should probably mark #15063 as a 0.18 milestone requirement right?
5012019-01-22T21:35:27 *** _luc_ has quit IRC
5022019-01-22T21:35:34 <gribble> https://github.com/bitcoin/bitcoin/issues/15063 | GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing by luke-jr · Pull Request #15063 · bitcoin/bitcoin · GitHub
5032019-01-22T21:36:39 <wumpus> Lightsword: would be nice to have it in, yes, will add milestone
5042019-01-22T21:37:37 <wumpus> gkrizek: "ModuleNotFoundError: No module named 'ghi.index'" :-(
5052019-01-22T21:38:24 <gkrizek> wumpus how are you executing it? If you are not in the current dir of the repo, you should set `PYTHONPATH="/home/ghi/ghi/"`
5062019-01-22T21:38:55 <gkrizek> Like in this systemd example: https://github.com/gkrizek/ghi/blob/master/examples/ghi.service.md
5072019-01-22T21:40:01 <wumpus> ok!
5082019-01-22T21:41:25 <gkrizek> I'll probably try to iron this out a little better in the future so it installs globally and you can just do `$ ghi start` or something. But didn't get there yet!
5092019-01-22T21:41:46 *** promag has joined #bitcoin-core-dev
5102019-01-22T21:42:05 <wumpus> 2019-01-22 22:41:39 [ghi] Received the 'ping' event
5112019-01-22T21:42:07 <wumpus> 2019-01-22 22:41:39 [ghi] Sent 'pong
5122019-01-22T21:42:13 <wumpus> that looks better!
5132019-01-22T21:42:38 <wumpus> that's what I initially tried, python3 install.py --user, but that made an 'egg' file without a command to launch it :)
5142019-01-22T21:43:17 <gkrizek> Ah gotcha. Yeah sorry not there yet! But yes that looks like the correct response!
5152019-01-22T21:44:28 <wumpus> okay, now I should merge something I guess
5162019-01-22T21:45:53 *** promag has quit IRC
5172019-01-22T21:46:30 *** Guyver2 has quit IRC
5182019-01-22T21:48:55 *** spaced0ut has quit IRC
5192019-01-22T21:48:55 *** jnewbery has quit IRC
5202019-01-22T21:49:08 <achow101> jonasschnelli: should a wallet with disabled private keys be able to import a private key?
5212019-01-22T21:49:11 *** jnewbery has joined #bitcoin-core-dev
5222019-01-22T21:52:46 *** jnewbery has quit IRC
5232019-01-22T21:53:02 *** jnewbery has joined #bitcoin-core-dev
5242019-01-22T21:53:46 *** bitcoin-git has joined #bitcoin-core-dev
5252019-01-22T21:53:46 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bad1e0b22c1...94167e2b5b7b
5262019-01-22T21:53:46 <bitcoin-git> bitcoin/master 516437a Jonas Schnelli: Qt: remove macOS launch-at-startup option when compiled with > macOS 10.11
5272019-01-22T21:53:46 <bitcoin-git> bitcoin/master da60118 Jonas Schnelli: Fix macOS launch-at-startup memory issue
5282019-01-22T21:53:46 <bitcoin-git> bitcoin/master 94167e2 Wladimir J. van der Laan: Merge #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement...
5292019-01-22T21:53:46 *** bitcoin-git has left #bitcoin-core-dev
5302019-01-22T21:54:20 <wumpus> gkrizek: looks like it didn't trigger
5312019-01-22T21:54:33 *** bitcoin-git has joined #bitcoin-core-dev
5322019-01-22T21:54:33 <bitcoin-git> [bitcoin] laanwj closed pull request #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement (master...2019/01/macos_autostart) https://github.com/bitcoin/bitcoin/pull/15208
5332019-01-22T21:54:33 *** bitcoin-git has left #bitcoin-core-dev
5342019-01-22T21:54:33 <wumpus> gkrizek: log shows "2019-01-22 22:53:33 [ghi] /bin/sh: 1: Syntax error: "(" unexpected"
5352019-01-22T21:55:59 <wumpus> is it supposed to be calling into a shell?
5362019-01-22T21:57:23 *** DeanGuss has quit IRC
5372019-01-22T22:00:30 <gkrizek> Ah, yes. it does to execute the main function. The Server is essentially just an API endpoint that executed the main function. I haven't tested it with /bin/sh, only /bin/bash
5382019-01-22T22:01:11 <gkrizek> Are you running it with Python 3?
5392019-01-22T22:03:05 <gkrizek> https://github.com/gkrizek/ghi/blob/master/ghi/server.py#L40-L54
5402019-01-22T22:04:55 <gkrizek> Hmmm mine still works with /bin/sh
5412019-01-22T22:05:01 *** jnewbery has joined #bitcoin-core-dev
5422019-01-22T22:06:08 <wumpus> yep python3 ghi/ghi/server.py --port ...
5432019-01-22T22:07:40 <wumpus> where does it get the /bin/sh from? can I change it to /bin/bash?
5442019-01-22T22:07:45 <gkrizek> What OS are you running? I'll try to reproduce it
5452019-01-22T22:08:25 <wumpus> Ubuntu 18.04.1 LTS
5462019-01-22T22:08:37 <wumpus> I can give you access to the account if that helps
5472019-01-22T22:09:23 <gkrizek> Sure, that would be great.
5482019-01-22T22:10:21 <gkrizek> https://krizek.io/ssh
5492019-01-22T22:24:02 *** IZooo has joined #bitcoin-core-dev
5502019-01-22T22:28:47 *** justanotheruser has quit IRC
5512019-01-22T22:36:20 *** justanotheruser has joined #bitcoin-core-dev
5522019-01-22T22:37:36 *** hebasto has quit IRC
5532019-01-22T22:45:12 *** dviola has quit IRC
5542019-01-22T22:49:45 *** spinza has quit IRC
5552019-01-22T22:49:54 *** Victorsueca has joined #bitcoin-core-dev
5562019-01-22T22:54:01 *** spinza has joined #bitcoin-core-dev
5572019-01-22T22:59:28 *** ratonlaveur_ has joined #bitcoin-core-dev
5582019-01-22T23:01:51 *** bitcoin-git has joined #bitcoin-core-dev
5592019-01-22T23:01:51 <bitcoin-git> [bitcoin] Empact opened pull request #15231: Drop defunct Windows LookupIntern exception (master...ai-addrconfig) https://github.com/bitcoin/bitcoin/pull/15231
5602019-01-22T23:01:51 *** bitcoin-git has left #bitcoin-core-dev
5612019-01-22T23:04:21 *** miknotauro has joined #bitcoin-core-dev
5622019-01-22T23:10:47 *** ratonlaveur_ has quit IRC
5632019-01-22T23:14:07 *** phwalkr has quit IRC
5642019-01-22T23:23:16 *** ThomasLuong has joined #bitcoin-core-dev
5652019-01-22T23:29:10 *** luke-jr has joined #bitcoin-core-dev
5662019-01-22T23:34:06 *** gribble has quit IRC
5672019-01-22T23:40:25 *** gribble has joined #bitcoin-core-dev
5682019-01-22T23:58:07 *** michaelsdunn1 has quit IRC