12019-02-03T00:01:48 *** pinheadmz has joined #bitcoin-core-dev
22019-02-03T00:08:32 *** pinheadmz has quit IRC
32019-02-03T00:17:10 <sipa> gmaxwell: exactly 37000 degree8 len32767+len33825 hd4 codes
42019-02-03T00:17:20 <sipa> always surprising to see these large powers of 10 as factor appear
52019-02-03T00:18:09 *** hebasto has quit IRC
62019-02-03T00:21:12 <sipa> around 10% of those are len512 hd5
72019-02-03T00:21:42 <sipa> so the next question is how to prioritize hd5 length vs hd6 length
82019-02-03T00:22:15 <sipa> without ability to reach hd6 len222 at all, we should probably just maximize hd5 length
92019-02-03T00:27:57 *** pinheadmz has joined #bitcoin-core-dev
102019-02-03T00:28:12 <gmaxwell> Agreed.
112019-02-03T00:28:52 <gmaxwell> It might be interesting to see what we end up with under each criteria? what do we get prioritizing hd6 length, then hd5 lenght, what do we get prioriting hd6 length then hd5 lenght?
122019-02-03T00:29:06 <sipa> yup
132019-02-03T00:54:25 *** pinheadmz has quit IRC
142019-02-03T01:05:28 *** bitcoin-git has joined #bitcoin-core-dev
152019-02-03T01:05:29 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e6b859f85a8...2fbf6a57d282
162019-02-03T01:05:29 <bitcoin-git> bitcoin/master fac3a05 MarcoFalke: test: Fix race in p2p_invalid_messages
172019-02-03T01:05:30 <bitcoin-git> bitcoin/master 2fbf6a5 MarcoFalke: Merge #15330: test: Fix race in p2p_invalid_messages
182019-02-03T01:05:32 *** bitcoin-git has left #bitcoin-core-dev
192019-02-03T01:06:08 *** bitcoin-git has joined #bitcoin-core-dev
202019-02-03T01:06:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15330: test: Fix race in p2p_invalid_messages (master...Mf1902-qaRaceMagic) https://github.com/bitcoin/bitcoin/pull/15330
212019-02-03T01:06:21 *** bitcoin-git has left #bitcoin-core-dev
222019-02-03T01:06:53 *** fleshwounded has quit IRC
232019-02-03T01:16:26 *** justanotheruser has quit IRC
242019-02-03T01:22:11 *** shesek has joined #bitcoin-core-dev
252019-02-03T01:32:41 *** justanotheruser has joined #bitcoin-core-dev
262019-02-03T01:40:41 *** DeanGuss has quit IRC
272019-02-03T01:45:18 *** AaronvanW has joined #bitcoin-core-dev
282019-02-03T01:48:50 *** bitcoin-git has joined #bitcoin-core-dev
292019-02-03T01:48:50 <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15332: [Docs] Small updates to getrawtransaction description (master...get_transaction_docs) https://github.com/bitcoin/bitcoin/pull/15332
302019-02-03T01:48:56 *** bitcoin-git has left #bitcoin-core-dev
312019-02-03T02:01:11 *** pinheadmz has joined #bitcoin-core-dev
322019-02-03T02:03:25 *** pinheadmz has quit IRC
332019-02-03T02:06:31 *** pinheadmz has joined #bitcoin-core-dev
342019-02-03T02:13:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
352019-02-03T02:15:55 *** justanotheruser has quit IRC
362019-02-03T02:31:36 *** DeanGuss has joined #bitcoin-core-dev
372019-02-03T02:35:12 *** Chris_Stewart_5 has quit IRC
382019-02-03T02:41:19 *** ghost43 has quit IRC
392019-02-03T02:41:20 *** dermoth has quit IRC
402019-02-03T02:43:03 *** owowo has quit IRC
412019-02-03T02:46:47 *** ghost43 has joined #bitcoin-core-dev
422019-02-03T02:48:26 *** owowo has joined #bitcoin-core-dev
432019-02-03T03:04:39 *** AaronvanW has quit IRC
442019-02-03T03:12:19 *** AaronvanW has joined #bitcoin-core-dev
452019-02-03T03:14:35 *** jtimon has quit IRC
462019-02-03T03:16:43 *** AaronvanW has quit IRC
472019-02-03T03:17:10 *** Skirmant has quit IRC
482019-02-03T03:47:38 *** AaronvanW has joined #bitcoin-core-dev
492019-02-03T03:52:44 *** AaronvanW has quit IRC
502019-02-03T03:55:10 *** phwalkr has quit IRC
512019-02-03T04:06:44 *** drexl has quit IRC
522019-02-03T04:22:56 <sipa> gmaxwell: longest hd6 is len131
532019-02-03T04:23:09 <sipa> not enough for 2 public keys even
542019-02-03T04:24:21 <sipa> that one is len788 hd5
552019-02-03T04:24:45 <phantomcircuit> wumpus, enums for error codes is definitely the way to go
562019-02-03T04:25:41 *** AaronvanW has joined #bitcoin-core-dev
572019-02-03T04:30:21 *** AaronvanW has quit IRC
582019-02-03T04:30:33 <sipa> gmaxwell: longest hd5 is len1318
592019-02-03T04:33:20 <sipa> which is only len22 hd6
602019-02-03T04:36:22 *** dermoth has joined #bitcoin-core-dev
612019-02-03T04:50:16 *** bitcoin-git has joined #bitcoin-core-dev
622019-02-03T04:50:16 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15206: Immediately disconnect on invalid net message checksum (master...019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
632019-02-03T04:50:17 *** bitcoin-git has left #bitcoin-core-dev
642019-02-03T04:50:31 *** bitcoin-git has joined #bitcoin-core-dev
652019-02-03T04:50:31 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15206: Immediately disconnect on invalid net message checksum (master...019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
662019-02-03T04:50:40 *** bitcoin-git has left #bitcoin-core-dev
672019-02-03T05:04:21 *** AaronvanW has joined #bitcoin-core-dev
682019-02-03T05:08:27 *** AaronvanW has quit IRC
692019-02-03T05:36:44 *** AaronvanW has joined #bitcoin-core-dev
702019-02-03T05:41:30 *** AaronvanW has quit IRC
712019-02-03T06:15:25 *** AaronvanW has joined #bitcoin-core-dev
722019-02-03T06:20:07 *** AaronvanW has quit IRC
732019-02-03T06:47:59 *** AaronvanW has joined #bitcoin-core-dev
742019-02-03T06:49:01 *** rh0nj has quit IRC
752019-02-03T06:52:08 *** AaronvanW has quit IRC
762019-02-03T06:59:22 *** TheHoliestRoger has quit IRC
772019-02-03T07:04:04 *** TheHoliestRoger has joined #bitcoin-core-dev
782019-02-03T07:24:26 *** AaronvanW has joined #bitcoin-core-dev
792019-02-03T07:29:11 *** AaronvanW has quit IRC
802019-02-03T07:55:46 *** AaronvanW has joined #bitcoin-core-dev
812019-02-03T07:57:50 *** pinheadmz has joined #bitcoin-core-dev
822019-02-03T07:59:56 *** AaronvanW has quit IRC
832019-02-03T08:02:44 *** pinheadmz has quit IRC
842019-02-03T08:08:42 *** pinheadmz has joined #bitcoin-core-dev
852019-02-03T08:13:13 *** pinheadmz has quit IRC
862019-02-03T08:15:51 *** pinheadmz has joined #bitcoin-core-dev
872019-02-03T08:22:29 *** hebasto has joined #bitcoin-core-dev
882019-02-03T08:36:26 *** AaronvanW has joined #bitcoin-core-dev
892019-02-03T08:42:48 *** AaronvanW has quit IRC
902019-02-03T09:01:05 *** promag has joined #bitcoin-core-dev
912019-02-03T09:05:52 *** pinheadmz has quit IRC
922019-02-03T09:06:05 *** promag has quit IRC
932019-02-03T09:06:31 *** AaronvanW has joined #bitcoin-core-dev
942019-02-03T09:16:25 *** yoctopede has joined #bitcoin-core-dev
952019-02-03T09:16:51 *** zshlyk has quit IRC
962019-02-03T10:02:01 *** kexkey_ has quit IRC
972019-02-03T10:19:50 *** jtimon has joined #bitcoin-core-dev
982019-02-03T10:41:16 *** spinza has quit IRC
992019-02-03T10:45:21 *** spinza has joined #bitcoin-core-dev
1002019-02-03T11:16:00 *** Skirmant has joined #bitcoin-core-dev
1012019-02-03T12:46:55 *** mistergold has joined #bitcoin-core-dev
1022019-02-03T12:53:48 *** drexl has joined #bitcoin-core-dev
1032019-02-03T12:55:08 *** rh0nj has joined #bitcoin-core-dev
1042019-02-03T12:57:01 *** AaronvanW has quit IRC
1052019-02-03T12:57:21 *** AaronvanW has joined #bitcoin-core-dev
1062019-02-03T13:36:38 *** phwalkr has joined #bitcoin-core-dev
1072019-02-03T13:41:39 *** phwalkr has quit IRC
1082019-02-03T14:27:05 *** Dean_Guss has joined #bitcoin-core-dev
1092019-02-03T14:29:39 *** DeanGuss has quit IRC
1102019-02-03T14:29:43 *** phwalkr has joined #bitcoin-core-dev
1112019-02-03T14:53:37 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1122019-02-03T14:58:07 *** mistergold has quit IRC
1132019-02-03T15:09:13 *** fabianfabian has joined #bitcoin-core-dev
1142019-02-03T15:16:24 *** darosior has joined #bitcoin-core-dev
1152019-02-03T15:53:25 *** fabianfabian has quit IRC
1162019-02-03T15:56:48 *** goatpig has joined #bitcoin-core-dev
1172019-02-03T16:08:20 *** justanotheruser has joined #bitcoin-core-dev
1182019-02-03T16:14:59 *** Bastinkie has joined #bitcoin-core-dev
1192019-02-03T16:15:06 *** Bastinkie has left #bitcoin-core-dev
1202019-02-03T16:21:55 *** darosior has quit IRC
1212019-02-03T16:43:32 *** Guyver2 has joined #bitcoin-core-dev
1222019-02-03T16:44:28 *** promag has joined #bitcoin-core-dev
1232019-02-03T16:48:45 *** promag has quit IRC
1242019-02-03T16:49:03 *** fabianfabian has joined #bitcoin-core-dev
1252019-02-03T17:00:08 *** justanotheruser has quit IRC
1262019-02-03T17:05:24 *** so has quit IRC
1272019-02-03T17:06:23 *** jtimon has quit IRC
1282019-02-03T17:10:11 *** so has joined #bitcoin-core-dev
1292019-02-03T17:20:57 *** asdfasdfdfasd has joined #bitcoin-core-dev
1302019-02-03T17:23:11 *** promag has joined #bitcoin-core-dev
1312019-02-03T17:33:44 *** pinheadmz has joined #bitcoin-core-dev
1322019-02-03T17:44:56 *** promag has quit IRC
1332019-02-03T17:45:36 *** miknotauro has joined #bitcoin-core-dev
1342019-02-03T17:56:02 *** phwalkr has quit IRC
1352019-02-03T17:57:38 *** phwalkr has joined #bitcoin-core-dev
1362019-02-03T17:57:51 *** phwalkr has joined #bitcoin-core-dev
1372019-02-03T18:15:48 *** phwalkr has quit IRC
1382019-02-03T18:17:45 *** AaronvanW has quit IRC
1392019-02-03T18:18:21 *** copumpkin has joined #bitcoin-core-dev
1402019-02-03T18:22:37 *** pinheadmz has quit IRC
1412019-02-03T18:31:11 <sipa> gmaxwell: what do you think about letting the existing descriptor-capable RPCs (scantxoutset and deriveaddress) accept both descriptors with and without checksum (but if a checksum is present, it must be correct), but enforcing checksum for future importing RPCs
1422019-02-03T18:32:00 *** AaronvanW has joined #bitcoin-core-dev
1432019-02-03T18:36:57 *** spinza has quit IRC
1442019-02-03T18:46:21 *** Dean_Guss has quit IRC
1452019-02-03T18:52:08 *** asdfasdfdfasd has quit IRC
1462019-02-03T19:00:47 *** spinza has joined #bitcoin-core-dev
1472019-02-03T19:08:37 *** promag has joined #bitcoin-core-dev
1482019-02-03T19:09:52 *** promag has quit IRC
1492019-02-03T19:10:47 *** Chris_Stewart_5 has quit IRC
1502019-02-03T19:12:26 *** Victorsueca has quit IRC
1512019-02-03T19:16:32 *** Victorsueca has joined #bitcoin-core-dev
1522019-02-03T19:21:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1532019-02-03T19:23:35 <gmaxwell> sipa: scantxoutset is probably okay, but deriveaddress sounds dangerous.
1542019-02-03T19:28:59 <gwillen> agreed about deriveaddress I think? Certainly it ought to warn. Deriving an address is the most dangerous operation.
1552019-02-03T19:31:45 <sipa> right, agree
1562019-02-03T19:32:03 <sipa> there is no recourse if you get that step wrong
1572019-02-03T19:39:26 *** jtimon has joined #bitcoin-core-dev
1582019-02-03T19:41:15 <sipa> so my thinking is i can probably analyse all 5797 deg8_len512hd5 codes up to length 300 for up to 6 errors, and then pick the one that performs the best at that length (300) for say 1% errors
1592019-02-03T19:42:17 *** bitcoin-git has joined #bitcoin-core-dev
1602019-02-03T19:42:17 <bitcoin-git> [bitcoin] hebasto opened pull request #15334: wallet: Log subdirectory for the named wallets (master...0190203-wallet-env-log) https://github.com/bitcoin/bitcoin/pull/15334
1612019-02-03T19:42:29 *** bitcoin-git has left #bitcoin-core-dev
1622019-02-03T19:43:27 <sipa> 300 is enough for a k-of-3 wsh/multi with hex pubkeys, where the class symbols are inline
1632019-02-03T19:53:10 *** pinheadmz has joined #bitcoin-core-dev
1642019-02-03T20:39:25 *** pinheadmz has quit IRC
1652019-02-03T20:41:23 *** sipa has quit IRC
1662019-02-03T20:43:16 *** sipa has joined #bitcoin-core-dev
1672019-02-03T20:45:19 *** pinheadmz has joined #bitcoin-core-dev
1682019-02-03T21:01:33 *** pinheadmz has quit IRC
1692019-02-03T21:07:34 *** Chris_Stewart_5 has quit IRC
1702019-02-03T21:12:12 *** pinheadmz has joined #bitcoin-core-dev
1712019-02-03T21:20:29 *** ap4lmtree- has joined #bitcoin-core-dev
1722019-02-03T21:22:21 *** pinheadmz has quit IRC
1732019-02-03T21:22:52 *** EagleTM has joined #bitcoin-core-dev
1742019-02-03T21:24:32 *** ap4lmtree has quit IRC
1752019-02-03T21:25:06 *** marcoagner has quit IRC
1762019-02-03T21:31:13 *** hebasto has quit IRC
1772019-02-03T21:50:35 *** promag has joined #bitcoin-core-dev
1782019-02-03T21:54:27 *** Dean_Guss has joined #bitcoin-core-dev
1792019-02-03T21:54:59 *** justanotheruser has joined #bitcoin-core-dev
1802019-02-03T22:03:35 *** fabianfabian has quit IRC
1812019-02-03T22:11:35 *** spinza has quit IRC
1822019-02-03T22:14:20 <promag> MarcoFalke: regarding your comment, could you open an issue with more details of your idea?
1832019-02-03T22:14:27 <promag> https://github.com/bitcoin/bitcoin/pull/15322#issuecomment-459897285
1842019-02-03T22:29:03 *** Dean_Guss has quit IRC
1852019-02-03T22:30:44 *** EagleTM has quit IRC
1862019-02-03T22:31:33 *** ap4lmtree- has quit IRC
1872019-02-03T22:32:03 *** sakalli_ has joined #bitcoin-core-dev
1882019-02-03T22:34:28 *** sakalli_ has quit IRC
1892019-02-03T22:47:11 *** ole__ has joined #bitcoin-core-dev
1902019-02-03T22:51:52 *** ole__ has left #bitcoin-core-dev
1912019-02-03T22:54:16 *** ap4lmtree has joined #bitcoin-core-dev
1922019-02-03T22:57:52 <promag> would appreciate review/merge on #15280, it's required for #15153
1932019-02-03T22:57:53 <gribble> https://github.com/bitcoin/bitcoin/issues/15280 | gui: Fix shutdown order by promag · Pull Request #15280 · bitcoin/bitcoin · GitHub
1942019-02-03T22:57:56 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
1952019-02-03T23:04:22 *** Guyver2 has quit IRC
1962019-02-03T23:05:49 *** promag has quit IRC
1972019-02-03T23:07:44 *** spinza has joined #bitcoin-core-dev
1982019-02-03T23:18:00 *** riclas has joined #bitcoin-core-dev
1992019-02-03T23:18:38 *** riclas has left #bitcoin-core-dev
2002019-02-03T23:42:11 *** Zenton has quit IRC
2012019-02-03T23:49:14 *** jarthur has joined #bitcoin-core-dev
2022019-02-03T23:54:11 *** pinheadmz has joined #bitcoin-core-dev