12019-02-05T00:01:47  *** pinheadmz has joined #bitcoin-core-dev
  22019-02-05T00:11:01  *** rh0nj has quit IRC
  32019-02-05T00:12:07  *** Murch has joined #bitcoin-core-dev
  42019-02-05T00:12:08  *** rh0nj has joined #bitcoin-core-dev
  52019-02-05T00:12:47  *** jtimon has quit IRC
  62019-02-05T00:14:37  *** Krellan_ has joined #bitcoin-core-dev
  72019-02-05T00:15:12  *** hebasto has quit IRC
  82019-02-05T00:17:12  *** Krellan has quit IRC
  92019-02-05T00:23:17  *** jtimon has joined #bitcoin-core-dev
 102019-02-05T00:49:50  *** miknotauro has joined #bitcoin-core-dev
 112019-02-05T01:00:14  *** Murch has quit IRC
 122019-02-05T01:05:55  *** sipa has quit IRC
 132019-02-05T01:06:37  *** sipa has joined #bitcoin-core-dev
 142019-02-05T01:14:46  *** spinza has quit IRC
 152019-02-05T01:21:28  *** pinheadmz has quit IRC
 162019-02-05T01:26:42  *** spinza has joined #bitcoin-core-dev
 172019-02-05T01:31:22  *** IGHOR has quit IRC
 182019-02-05T01:33:36  *** IGHOR has joined #bitcoin-core-dev
 192019-02-05T01:42:18  *** Murch has joined #bitcoin-core-dev
 202019-02-05T01:45:57  *** Murch has quit IRC
 212019-02-05T02:13:17  *** miknotauro has quit IRC
 222019-02-05T02:15:58  *** miknotauro has joined #bitcoin-core-dev
 232019-02-05T02:16:08  *** AaronvanW has quit IRC
 242019-02-05T02:33:08  *** DeanGuss has joined #bitcoin-core-dev
 252019-02-05T02:34:01  *** miknotauro has quit IRC
 262019-02-05T02:37:23  *** bitcoin-git has joined #bitcoin-core-dev
 272019-02-05T02:37:24  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/452acee4da20...e50853501b79
 282019-02-05T02:37:24  <bitcoin-git> bitcoin/master e1b6436 Hennadii Stepanov: Fix build after pr 15266 merged
 292019-02-05T02:37:25  <bitcoin-git> bitcoin/master e508535 Wladimir J. van der Laan: Merge #15347: Fix build after pr 15266 merged
 302019-02-05T02:37:28  *** bitcoin-git has left #bitcoin-core-dev
 312019-02-05T02:38:09  *** bitcoin-git has joined #bitcoin-core-dev
 322019-02-05T02:38:09  <bitcoin-git> [bitcoin] laanwj merged pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347
 332019-02-05T02:38:12  *** bitcoin-git has left #bitcoin-core-dev
 342019-02-05T02:45:29  *** bitcoin-git has joined #bitcoin-core-dev
 352019-02-05T02:45:29  <bitcoin-git> [bitcoin] Empact closed pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344
 362019-02-05T02:45:31  *** bitcoin-git has left #bitcoin-core-dev
 372019-02-05T02:48:04  *** pinheadmz has joined #bitcoin-core-dev
 382019-02-05T02:53:25  *** jarthur has quit IRC
 392019-02-05T02:55:48  *** Empact has joined #bitcoin-core-dev
 402019-02-05T02:55:49  *** StopAndDecrypt has joined #bitcoin-core-dev
 412019-02-05T03:04:55  *** Empact has quit IRC
 422019-02-05T03:06:21  *** Empact has joined #bitcoin-core-dev
 432019-02-05T03:19:27  *** pinheadmz has quit IRC
 442019-02-05T03:20:05  *** Krellan_ has quit IRC
 452019-02-05T03:23:41  *** Empact has quit IRC
 462019-02-05T03:26:51  *** Empact has joined #bitcoin-core-dev
 472019-02-05T03:27:08  *** Empact has quit IRC
 482019-02-05T03:28:27  *** pinheadmz has joined #bitcoin-core-dev
 492019-02-05T03:31:31  *** Empact has joined #bitcoin-core-dev
 502019-02-05T03:43:06  *** ThomasLuong has joined #bitcoin-core-dev
 512019-02-05T03:48:18  *** pinheadmz has quit IRC
 522019-02-05T03:50:32  *** Empact has quit IRC
 532019-02-05T04:03:34  *** achow101 has quit IRC
 542019-02-05T04:11:17  *** achow101 has joined #bitcoin-core-dev
 552019-02-05T04:29:27  *** skyikot has joined #bitcoin-core-dev
 562019-02-05T04:42:57  *** skyikot has quit IRC
 572019-02-05T04:46:09  *** skyikot has joined #bitcoin-core-dev
 582019-02-05T04:48:23  *** skyikot has quit IRC
 592019-02-05T04:54:41  *** skyikot has joined #bitcoin-core-dev
 602019-02-05T05:06:26  *** pinheadmz has joined #bitcoin-core-dev
 612019-02-05T05:23:18  *** pinheadmz has quit IRC
 622019-02-05T05:26:25  *** rex4539 has joined #bitcoin-core-dev
 632019-02-05T05:42:44  *** nelsonhb has joined #bitcoin-core-dev
 642019-02-05T05:45:46  *** skyikot has quit IRC
 652019-02-05T06:00:51  *** tryphe_ has joined #bitcoin-core-dev
 662019-02-05T06:03:56  *** tryphe has quit IRC
 672019-02-05T06:06:43  *** jtimon has quit IRC
 682019-02-05T06:07:48  *** ThomasLuong has quit IRC
 692019-02-05T06:12:45  *** pinheadmz has joined #bitcoin-core-dev
 702019-02-05T06:24:44  *** skyikot has joined #bitcoin-core-dev
 712019-02-05T06:26:42  *** nelsonhb has quit IRC
 722019-02-05T06:46:21  <meshcollider> provoostenator: I've just cleaned up #14491 now, feel free to rebase your stuff on top of it again :)
 732019-02-05T06:46:24  <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
 742019-02-05T07:16:10  *** hebasto has joined #bitcoin-core-dev
 752019-02-05T07:23:31  <meshcollider> whats up with the "Reading package lists...
 762019-02-05T07:23:31  <meshcollider> No output has been received in the last 10m0s" failures on travis atm
 772019-02-05T07:24:55  <meshcollider> https://travis-ci.org/bitcoin/bitcoin/builds/488891564
 782019-02-05T07:29:33  *** skyikot has quit IRC
 792019-02-05T07:43:32  *** darosior has joined #bitcoin-core-dev
 802019-02-05T07:45:41  *** pinheadmz has quit IRC
 812019-02-05T07:48:40  *** jimmysong has quit IRC
 822019-02-05T07:49:03  *** jimmysong has joined #bitcoin-core-dev
 832019-02-05T08:13:01  *** rh0nj has quit IRC
 842019-02-05T08:14:07  *** rh0nj has joined #bitcoin-core-dev
 852019-02-05T08:14:52  *** fanquake has joined #bitcoin-core-dev
 862019-02-05T08:20:07  *** romain has quit IRC
 872019-02-05T08:27:14  *** Sentineo has quit IRC
 882019-02-05T08:27:55  *** Empact has joined #bitcoin-core-dev
 892019-02-05T08:29:58  *** phwalkr has joined #bitcoin-core-dev
 902019-02-05T08:31:56  *** Empact_ has joined #bitcoin-core-dev
 912019-02-05T08:32:34  *** rex4539 has quit IRC
 922019-02-05T08:32:44  *** Empact_ has quit IRC
 932019-02-05T08:38:36  <meshcollider> nvm its working now
 942019-02-05T08:39:13  *** promag has quit IRC
 952019-02-05T08:46:58  *** Sentineo has joined #bitcoin-core-dev
 962019-02-05T09:00:17  *** darosior has quit IRC
 972019-02-05T09:00:32  *** nelsonhb has joined #bitcoin-core-dev
 982019-02-05T09:00:49  *** volkov has joined #bitcoin-core-dev
 992019-02-05T09:06:02  *** hebasto has quit IRC
1002019-02-05T09:11:26  *** setpill has joined #bitcoin-core-dev
1012019-02-05T09:26:28  *** nelsonhb has quit IRC
1022019-02-05T09:26:54  *** timothy has joined #bitcoin-core-dev
1032019-02-05T09:44:44  *** volkov has quit IRC
1042019-02-05T09:57:39  *** jungly has joined #bitcoin-core-dev
1052019-02-05T09:58:31  *** dqx has quit IRC
1062019-02-05T10:14:33  *** dqx has joined #bitcoin-core-dev
1072019-02-05T10:25:28  *** promag has joined #bitcoin-core-dev
1082019-02-05T10:29:20  <meshcollider> anyone willing to give #14667 a quick review?
1092019-02-05T10:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddresses RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
1102019-02-05T10:33:21  *** spinza has quit IRC
1112019-02-05T10:40:28  *** rex4539 has joined #bitcoin-core-dev
1122019-02-05T10:40:42  *** pergaminho has joined #bitcoin-core-dev
1132019-02-05T10:46:09  *** spinza has joined #bitcoin-core-dev
1142019-02-05T11:05:54  *** davec has quit IRC
1152019-02-05T11:05:54  *** qubenix has quit IRC
1162019-02-05T11:05:54  *** wxss has quit IRC
1172019-02-05T11:06:11  *** davec has joined #bitcoin-core-dev
1182019-02-05T11:06:27  *** lnostdal has quit IRC
1192019-02-05T11:06:52  *** wxss has joined #bitcoin-core-dev
1202019-02-05T11:11:49  *** lnostdal has joined #bitcoin-core-dev
1212019-02-05T11:15:55  *** tryphe_ has quit IRC
1222019-02-05T11:16:17  *** tryphe_ has joined #bitcoin-core-dev
1232019-02-05T11:16:27  *** promag has quit IRC
1242019-02-05T11:19:29  *** qubenix has joined #bitcoin-core-dev
1252019-02-05T11:20:36  *** spinza has quit IRC
1262019-02-05T11:20:58  *** cluelessperson has quit IRC
1272019-02-05T11:21:19  *** cluelessperson has joined #bitcoin-core-dev
1282019-02-05T11:29:42  *** spinza has joined #bitcoin-core-dev
1292019-02-05T11:31:47  *** promag has joined #bitcoin-core-dev
1302019-02-05T11:34:37  *** lnostdal has quit IRC
1312019-02-05T11:35:48  *** lnostdal has joined #bitcoin-core-dev
1322019-02-05T11:51:11  *** AaronvanW has joined #bitcoin-core-dev
1332019-02-05T12:03:33  *** pergaminho has quit IRC
1342019-02-05T12:04:21  *** pergaminho has joined #bitcoin-core-dev
1352019-02-05T12:10:03  *** pergaminho has quit IRC
1362019-02-05T12:21:57  *** pergaminho has joined #bitcoin-core-dev
1372019-02-05T12:25:36  *** arubi has joined #bitcoin-core-dev
1382019-02-05T12:26:32  *** marcoagner has quit IRC
1392019-02-05T12:27:36  *** promag has quit IRC
1402019-02-05T12:42:24  *** nelsonhb has joined #bitcoin-core-dev
1412019-02-05T13:01:19  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1422019-02-05T13:01:19  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1432019-02-05T13:28:14  *** rex4539 has quit IRC
1442019-02-05T13:31:51  *** Guyver2 has joined #bitcoin-core-dev
1452019-02-05T13:39:03  *** promag has joined #bitcoin-core-dev
1462019-02-05T13:40:01  *** Cogito_Ergo_Sum has quit IRC
1472019-02-05T13:43:26  *** promag has quit IRC
1482019-02-05T13:47:20  *** pergaminho has quit IRC
1492019-02-05T13:47:33  *** pergaminho has joined #bitcoin-core-dev
1502019-02-05T13:50:59  *** nelsonhb has quit IRC
1512019-02-05T13:57:55  *** otoburb has joined #bitcoin-core-dev
1522019-02-05T14:02:37  *** queip has quit IRC
1532019-02-05T14:03:16  *** rafalcpp has quit IRC
1542019-02-05T14:09:22  *** oneark has joined #bitcoin-core-dev
1552019-02-05T14:10:57  <instagibbs> pure utility rpcs? Not that I wouldn't appreciate the functionality but I don't think the motivation for adding it versus other utility rpcs has been given
1562019-02-05T14:29:04  *** queip has joined #bitcoin-core-dev
1572019-02-05T14:34:59  *** promag has joined #bitcoin-core-dev
1582019-02-05T14:45:22  <promag> 0.18 list is quite big
1592019-02-05T14:46:37  *** rex4539 has joined #bitcoin-core-dev
1602019-02-05T14:57:55  *** promag has quit IRC
1612019-02-05T15:08:17  *** mn949588 has joined #bitcoin-core-dev
1622019-02-05T15:08:24  *** mn9495881 has quit IRC
1632019-02-05T15:24:36  <fanquake> promag Some stuff on there that'll get dropped, as well as issues that dont actually require any more action
1642019-02-05T15:26:09  *** hebasto has joined #bitcoin-core-dev
1652019-02-05T15:30:20  <fanquake> sipa I know it's arbitrary, but how long would you expect test-exhaust (from minisketch) to run for?
1662019-02-05T15:31:36  *** setpill has quit IRC
1672019-02-05T15:32:01  *** kexkey has joined #bitcoin-core-dev
1682019-02-05T15:40:05  *** michaelsdunn1 has joined #bitcoin-core-dev
1692019-02-05T15:40:05  *** michaelsdunn1 has quit IRC
1702019-02-05T15:40:05  *** michaelsdunn1 has joined #bitcoin-core-dev
1712019-02-05T15:41:06  *** bitcoin-git has joined #bitcoin-core-dev
1722019-02-05T15:41:08  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e50853501b79...bbdcc0b0ff0e
1732019-02-05T15:41:08  <bitcoin-git> bitcoin/master 95a812b Russell Yanofsky: Rename ScanResult stop_block field
1742019-02-05T15:41:09  <bitcoin-git> bitcoin/master a8d645c Russell Yanofsky: Update ScanForWalletTransactions result comment
1752019-02-05T15:41:10  <bitcoin-git> bitcoin/master db2d093 Russell Yanofsky: Add suggested rescanblockchain comments
1762019-02-05T15:41:12  *** bitcoin-git has left #bitcoin-core-dev
1772019-02-05T15:41:56  *** bitcoin-git has joined #bitcoin-core-dev
1782019-02-05T15:41:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15342: Suggested wallet code cleanups from #14711 (master...pr/wclean) https://github.com/bitcoin/bitcoin/pull/15342
1792019-02-05T15:41:57  *** bitcoin-git has left #bitcoin-core-dev
1802019-02-05T15:48:16  *** bitcoin-git has joined #bitcoin-core-dev
1812019-02-05T15:48:17  <bitcoin-git> [bitcoin] dongcarl opened pull request #15348: doc: Add separate productivity notes document (master...2019-02-productivity-md) https://github.com/bitcoin/bitcoin/pull/15348
1822019-02-05T15:48:20  *** bitcoin-git has left #bitcoin-core-dev
1832019-02-05T15:51:24  *** bitcoin-git has joined #bitcoin-core-dev
1842019-02-05T15:51:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbdcc0b0ff0e...fc21bb4e3590
1852019-02-05T15:51:25  <bitcoin-git> bitcoin/master 851380c Gregory Sanders: remove deprecated mentions of signrawtransaction from fundraw help
1862019-02-05T15:51:25  <bitcoin-git> bitcoin/master fc21bb4 MarcoFalke: Merge #15245: remove deprecated mentions of signrawtransaction from fundra...
1872019-02-05T15:51:26  *** bitcoin-git has left #bitcoin-core-dev
1882019-02-05T15:52:11  *** bitcoin-git has joined #bitcoin-core-dev
1892019-02-05T15:52:12  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15245: remove deprecated mentions of signrawtransaction from fundraw help (master...fundraw_signraw) https://github.com/bitcoin/bitcoin/pull/15245
1902019-02-05T15:52:15  *** bitcoin-git has left #bitcoin-core-dev
1912019-02-05T16:11:44  *** jarthur has joined #bitcoin-core-dev
1922019-02-05T16:17:10  *** rafalcpp has joined #bitcoin-core-dev
1932019-02-05T16:19:05  *** darosior has joined #bitcoin-core-dev
1942019-02-05T16:21:21  *** rockhouse has quit IRC
1952019-02-05T16:21:21  *** victorSN has quit IRC
1962019-02-05T16:24:46  *** rockhouse has joined #bitcoin-core-dev
1972019-02-05T16:25:32  *** victorSN has joined #bitcoin-core-dev
1982019-02-05T16:26:08  *** fanquake has quit IRC
1992019-02-05T16:32:20  *** jtimon has joined #bitcoin-core-dev
2002019-02-05T16:54:10  *** jungly has quit IRC
2012019-02-05T16:57:04  *** jarthur_ has joined #bitcoin-core-dev
2022019-02-05T16:57:22  *** hebasto has quit IRC
2032019-02-05T16:59:02  *** pinheadmz has joined #bitcoin-core-dev
2042019-02-05T16:59:12  <dongcarl> I'm talking to distro maintainers about #12255, when checking if a directory is a valid bitcoin directory, would checking `[ -f foo/bar/peers.dat ]` be sufficient? Would it be better to check `[ -f foo/bar/.lock ]`?
2052019-02-05T16:59:14  <gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
2062019-02-05T17:00:07  *** jarthur has quit IRC
2072019-02-05T17:08:15  *** ddustin has joined #bitcoin-core-dev
2082019-02-05T17:09:20  *** ddustin has joined #bitcoin-core-dev
2092019-02-05T17:09:58  *** ddustin has quit IRC
2102019-02-05T17:10:33  *** ddustin has joined #bitcoin-core-dev
2112019-02-05T17:11:01  *** darosior has quit IRC
2122019-02-05T17:11:01  *** ddustin has quit IRC
2132019-02-05T17:11:38  *** ddustin has joined #bitcoin-core-dev
2142019-02-05T17:13:50  *** jarthur_ has quit IRC
2152019-02-05T17:14:31  *** ThomasLuong has joined #bitcoin-core-dev
2162019-02-05T17:15:50  *** bitcoin-git has joined #bitcoin-core-dev
2172019-02-05T17:15:51  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fc21bb4e3590...3a573fd46c75
2182019-02-05T17:15:52  <bitcoin-git> bitcoin/master 1bd9ffd Chun Kuan Lee: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
2192019-02-05T17:15:53  <bitcoin-git> bitcoin/master d8a2992 Chun Kuan Lee: windows: Call SetProcessDEPPolicy directly
2202019-02-05T17:15:54  <bitcoin-git> bitcoin/master d0522ec Ben Woosley: Drop defunct Windows compat fixes
2212019-02-05T17:15:55  *** bitcoin-git has left #bitcoin-core-dev
2222019-02-05T17:16:21  *** bitcoin-git has joined #bitcoin-core-dev
2232019-02-05T17:16:21  <bitcoin-git> [bitcoin] laanwj merged pull request #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
2242019-02-05T17:16:22  *** bitcoin-git has left #bitcoin-core-dev
2252019-02-05T17:18:28  *** hebasto has joined #bitcoin-core-dev
2262019-02-05T17:19:50  *** jarthur has joined #bitcoin-core-dev
2272019-02-05T17:21:48  *** jarthur has joined #bitcoin-core-dev
2282019-02-05T17:22:28  *** ThomasLuong has quit IRC
2292019-02-05T17:31:18  *** promag has joined #bitcoin-core-dev
2302019-02-05T17:44:15  *** EagleTM has joined #bitcoin-core-dev
2312019-02-05T17:48:55  *** oneark has quit IRC
2322019-02-05T17:52:30  *** dqx has quit IRC
2332019-02-05T17:52:35  *** EagleTM has quit IRC
2342019-02-05T18:05:44  <promag> is #15153 for 0.18? if so it needs the label
2352019-02-05T18:05:47  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
2362019-02-05T18:11:55  <wumpus> sure, the 0.18 label isn't more than 'would be nice if it made 0.18'
2372019-02-05T18:13:59  *** dqx has joined #bitcoin-core-dev
2382019-02-05T18:16:58  *** Murch has joined #bitcoin-core-dev
2392019-02-05T18:18:42  *** dqx has quit IRC
2402019-02-05T18:19:06  <promag> just saw #15309 :/
2412019-02-05T18:19:07  <gribble> https://github.com/bitcoin/bitcoin/issues/15309 | tests: Running with --usecli ~5x slower than without · Issue #15309 · bitcoin/bitcoin · GitHub
2422019-02-05T18:20:02  <promag> I'll dig into that cc sdaftuar
2432019-02-05T18:20:11  *** promag has quit IRC
2442019-02-05T18:28:53  <gleb> It seems like we restricted getdata on sending to 100 entries, and on receiving to 50,000 entries :)
2452019-02-05T18:29:45  *** dqx has joined #bitcoin-core-dev
2462019-02-05T18:30:44  *** ap4lmtree has quit IRC
2472019-02-05T18:32:26  <gleb> If we restrict getdata to 100 on receive, it seems we would punish btcd nodes for misbehaving :)
2482019-02-05T18:33:36  <gleb> If this is done on purpose, perhaps we should leave a comment at least...
2492019-02-05T18:34:14  <sdaftuar> you mean leave a comment as to why we picked 100?
2502019-02-05T18:34:39  <gleb> Why there are 2 different numbers where it is expected to have the same number (because we don't want to punish btcd?)
2512019-02-05T18:34:55  <sdaftuar> or punish old nodes
2522019-02-05T18:35:00  <sipa> well, it's always been 50000
2532019-02-05T18:35:07  <sipa> we can't just change what we accept
2542019-02-05T18:35:11  <sipa> we can change what we send
2552019-02-05T18:35:12  <sdaftuar> ^ right
2562019-02-05T18:35:29  *** ap4lmtree has joined #bitcoin-core-dev
2572019-02-05T18:35:40  <sipa> so indeed, the needed comment is why are we only sending 100 :)
2582019-02-05T18:37:19  <gmaxwell> we should probably limit rx too, that just takes coordination time.
2592019-02-05T18:38:36  <sdaftuar> limiting rx implies creating some rate limit (to be useful).  not sure what we gain otherwise except coordination headache
2602019-02-05T18:41:19  <sdaftuar> gleb: i picked 100 by looking at the already_asked_for size relative to the number of peers i thought you might reasonably have, and picking a round number that would give us some buffer
2612019-02-05T18:42:34  <gmaxwell> sdaftuar: not a rate limit, but the number of invs in a single message.
2622019-02-05T18:42:38  *** EagleTM has joined #bitcoin-core-dev
2632019-02-05T18:42:45  <sdaftuar> gmaxwell: what purpose would that serve?
2642019-02-05T18:42:54  <gmaxwell> We should not have 1.8MB packets in the protocol, they insert huge latency/processing spikes.
2652019-02-05T18:43:09  <sdaftuar> ah, i guess that's fair
2662019-02-05T18:43:33  <sdaftuar> we could also make our code smarter and allow interruption of processing such messages
2672019-02-05T18:43:55  <gmaxwell> not the most critical of issues, but I can't see any reason why we'd ever want getdatas that large.
2682019-02-05T18:44:04  <sipa> sdaftuar: i think we do, for getdata
2692019-02-05T18:44:08  <sdaftuar> sipa: yep
2702019-02-05T18:44:12  <sdaftuar> but for tx announcements
2712019-02-05T18:44:17  <gmaxwell> sdaftuar: still have to buffer them.
2722019-02-05T18:45:02  <gmaxwell> an obvious thing to do would be to limit them with the introduction of the encrypted transport.
2732019-02-05T18:47:38  <sdaftuar> sure
2742019-02-05T18:47:53  <gleb> But huge getdatas are as bad as huge invs, right?
2752019-02-05T18:48:08  <sdaftuar> i think so
2762019-02-05T18:48:13  <sdaftuar> we queue them up for processing
2772019-02-05T18:48:38  <sdaftuar> in theory getdatas should be limited by what we announce, which is rate limited
2782019-02-05T18:48:43  <sdaftuar> a misbehaving peer could send us garbage
2792019-02-05T18:48:51  *** hebasto has quit IRC
2802019-02-05T18:48:52  <sdaftuar> and we wouldn't punish (instead, we helpfully send notfound's)
2812019-02-05T18:49:06  <gmaxwell> I thought we stopped sending notfounds?
2822019-02-05T18:49:13  <sdaftuar> no, we stopped sending rejects i think
2832019-02-05T18:49:18  *** hebasto has joined #bitcoin-core-dev
2842019-02-05T18:49:25  <sdaftuar> i have a PR coming that will use the NOTFOUNDs! so i hope we don't get rid of those
2852019-02-05T18:50:23  <gmaxwell> what would you use them for?
2862019-02-05T18:50:38  <sdaftuar> to request a transaction from someone else.  my thought was that we can make it so that not providing a transaciton is no longer a DoS on our peer
2872019-02-05T18:50:52  <sdaftuar> and this would be a way to eventually drop mapRelay
2882019-02-05T18:56:20  <gmaxwell> that requires the peer to cooperate, a DOS attacker wouldn't...
2892019-02-05T18:56:39  <sdaftuar> gmaxwell: agree, but a DoS attacker has no bearing on whether we keep mapRelay around
2902019-02-05T18:56:53  <gmaxwell> So all that would do is speed things up in the cooperative case?  which sounds okay to me, but I don't see how we could drop maprelay?
2912019-02-05T18:57:07  <sdaftuar> well i think then we can just serve things from the mempool
2922019-02-05T18:57:12  <sdaftuar> and give a notfound otherwise
2932019-02-05T18:57:46  <gmaxwell> oh maprealy sorry, being dumb and thinking you were talking about the map we use to schedule rerequests.
2942019-02-05T18:57:47  <gmaxwell> sounds good.
2952019-02-05T18:58:26  <sdaftuar> this should be easy to implement after gleb's PR, so i was hoping we might slip it into 0.18
2962019-02-05T18:59:27  <sdaftuar> (the smarter behavior after receiving a NOTFOUND, i mean)
2972019-02-05T19:00:41  <gmaxwell> I like this idea.
2982019-02-05T19:02:24  *** wolfspraul has quit IRC
2992019-02-05T19:02:32  *** wolfspraul has joined #bitcoin-core-dev
3002019-02-05T19:05:42  <phantomcircuit> gmaxwell, im not sure how much of a processing spike a 1.8MB inv would cause, since it gets pushed into it's own queue and each inv is processed individually
3012019-02-05T19:05:58  <phantomcircuit> (s/inv/getdata/)
3022019-02-05T19:06:26  *** wolfspraul has quit IRC
3032019-02-05T19:06:50  *** wolfspraul has joined #bitcoin-core-dev
3042019-02-05T19:07:44  <gmaxwell> not processing spike, as much as it head of line blocks the socket, uses up a big buffer just checksumming it, etc. It's not much of a problem but it serves no use.
3052019-02-05T19:08:38  <phantomcircuit> think the only issue there is the memory it uses
3062019-02-05T19:09:10  <phantomcircuit> blocking the socket for the peer that's being stupid seems fine to me
3072019-02-05T19:12:31  <gmaxwell> right, I said about it isn't so much a problem as its just dumb.
3082019-02-05T19:13:04  <gmaxwell> though it does mean that we need to be willing to buffer 1.8mb of memory, but we have to for other messages in any case.
3092019-02-05T19:13:09  <gmaxwell> (in particular, block messages)
3102019-02-05T19:18:52  *** pergaminho has quit IRC
3112019-02-05T19:19:52  *** ghost43 has quit IRC
3122019-02-05T19:22:05  *** ghost43 has joined #bitcoin-core-dev
3132019-02-05T19:57:03  *** michaelsdunn1 has quit IRC
3142019-02-05T19:58:46  *** michaelsdunn1 has joined #bitcoin-core-dev
3152019-02-05T20:08:31  *** mn9495882 has joined #bitcoin-core-dev
3162019-02-05T20:09:47  *** mn949588 has quit IRC
3172019-02-05T20:14:23  *** EagleTM has quit IRC
3182019-02-05T20:15:34  *** Krellan has joined #bitcoin-core-dev
3192019-02-05T20:25:04  *** Murch has quit IRC
3202019-02-05T20:26:31  *** Murch has joined #bitcoin-core-dev
3212019-02-05T20:28:53  *** promag has joined #bitcoin-core-dev
3222019-02-05T20:29:49  *** promag_ has joined #bitcoin-core-dev
3232019-02-05T20:31:10  *** jarthur_ has joined #bitcoin-core-dev
3242019-02-05T20:31:46  *** Krellan_ has joined #bitcoin-core-dev
3252019-02-05T20:32:27  *** Murch has quit IRC
3262019-02-05T20:33:06  *** promag has quit IRC
3272019-02-05T20:33:39  *** michaelsdunn1 has quit IRC
3282019-02-05T20:34:08  *** jarthur has quit IRC
3292019-02-05T20:34:16  *** Krellan has quit IRC
3302019-02-05T20:34:30  *** tryphe_ is now known as tryphe
3312019-02-05T20:37:29  *** michaelsdunn1 has joined #bitcoin-core-dev
3322019-02-05T20:38:01  *** hebasto has quit IRC
3332019-02-05T20:38:05  *** Murch has joined #bitcoin-core-dev
3342019-02-05T20:39:49  *** EagleTM has joined #bitcoin-core-dev
3352019-02-05T20:41:21  *** michaelsdunn1 has quit IRC
3362019-02-05T20:44:39  *** michaelsdunn1 has joined #bitcoin-core-dev
3372019-02-05T20:46:15  *** Murch has quit IRC
3382019-02-05T20:51:37  *** skyikot has joined #bitcoin-core-dev
3392019-02-05T20:54:56  *** dqx has quit IRC
3402019-02-05T20:56:06  *** dqx has joined #bitcoin-core-dev
3412019-02-05T20:56:09  *** lnostdal has quit IRC
3422019-02-05T20:57:24  *** skyikot has quit IRC
3432019-02-05T20:59:01  *** Guyver2 has quit IRC
3442019-02-05T21:01:10  *** StopAndDecrypt has quit IRC
3452019-02-05T21:05:57  *** phwalkr has quit IRC
3462019-02-05T21:06:10  *** StopAndDecrypt has joined #bitcoin-core-dev
3472019-02-05T21:06:19  *** StopAndDecrypt has quit IRC
3482019-02-05T21:06:19  *** StopAndDecrypt has joined #bitcoin-core-dev
3492019-02-05T21:07:03  *** dqx has quit IRC
3502019-02-05T21:08:15  *** dqx has joined #bitcoin-core-dev
3512019-02-05T21:11:50  *** bitcoin-git has joined #bitcoin-core-dev
3522019-02-05T21:11:51  <bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3a573fd46c75...30e799a5f705
3532019-02-05T21:11:52  <bitcoin-git> bitcoin/master 8602a1e João Barbosa: wallet: Close dbenv error file db.log
3542019-02-05T21:11:53  <bitcoin-git> bitcoin/master 2f8b8f4 João Barbosa: wallet: Close wallet env lock file
3552019-02-05T21:11:54  <bitcoin-git> bitcoin/master d3bf3b9 João Barbosa: qa: Test .walletlock file is closed
3562019-02-05T21:11:55  *** bitcoin-git has left #bitcoin-core-dev
3572019-02-05T21:12:38  *** bitcoin-git has joined #bitcoin-core-dev
3582019-02-05T21:12:38  <bitcoin-git> [bitcoin] MeshCollider merged pull request #15297: wallet: Releases dangling files on BerkeleyEnvironment::Close (master...2019-01-close-dbenv-files) https://github.com/bitcoin/bitcoin/pull/15297
3592019-02-05T21:12:48  *** bitcoin-git has left #bitcoin-core-dev
3602019-02-05T21:13:15  *** EagleTM has quit IRC
3612019-02-05T21:14:22  *** dviola has joined #bitcoin-core-dev
3622019-02-05T21:15:40  *** Aaronvan_ has joined #bitcoin-core-dev
3632019-02-05T21:19:03  *** dviola has quit IRC
3642019-02-05T21:19:14  *** AaronvanW has quit IRC
3652019-02-05T21:19:46  *** dviola has joined #bitcoin-core-dev
3662019-02-05T21:24:10  *** Murch has joined #bitcoin-core-dev
3672019-02-05T21:32:26  *** EagleTM has joined #bitcoin-core-dev
3682019-02-05T21:36:04  <promag_> sdaftuar: found the problem
3692019-02-05T21:36:11  *** promag_ is now known as promag
3702019-02-05T21:36:15  *** lnostdal has joined #bitcoin-core-dev
3712019-02-05T21:36:23  <sdaftuar> promag: great!  what is the issue?
3722019-02-05T21:36:40  <promag> as usual (?) code is right
3732019-02-05T21:37:07  <promag> so the issue is in wait_for_rpc_connection
3742019-02-05T21:37:48  <promag> when using --usecli the TestNode still establishes a RPC connection
3752019-02-05T21:37:57  <promag> to see if the RPC interface is ready
3762019-02-05T21:38:06  <promag> however that connection is persistent by default
3772019-02-05T21:38:56  <sdaftuar> so the issue is that the python tests aren't properly closing the connection, when using --usecli?
3782019-02-05T21:39:40  <promag> in other words, if the daemon has 2 persistent connections, and 1 sends stop, the server (at the moment) won't force disconnect the other, it will timeout
3792019-02-05T21:39:45  <promag> yes
3802019-02-05T21:39:49  <sdaftuar> what's the mechanism for that to work when we're not using --usecli?
3812019-02-05T21:40:26  <sdaftuar> oh the daemon will initiate the close?
3822019-02-05T21:41:56  *** jarthur_ has quit IRC
3832019-02-05T21:42:02  <promag> when not using --usecli the rpc connection will receive the header Connection: close, because the server is shutting down
3842019-02-05T21:42:12  *** bitcoin-git has joined #bitcoin-core-dev
3852019-02-05T21:42:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30e799a5f705...9b63c436a699
3862019-02-05T21:42:12  <bitcoin-git> bitcoin/master 364cff1 Chris Moore: Fix issue #9683 "gui, wallet: random abort (segmentation fault) running ma...
3872019-02-05T21:42:12  <sdaftuar> ok i think i sort of understand
3882019-02-05T21:42:13  <bitcoin-git> bitcoin/master 9b63c43 MarcoFalke: Merge #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fau...
3892019-02-05T21:42:13  <promag> but if the connection is idle then no header is sent
3902019-02-05T21:42:14  *** bitcoin-git has left #bitcoin-core-dev
3912019-02-05T21:42:41  <sdaftuar> i did notice that my test in #15305 seems very slow -- the issue there is that i'm constructing a scenario where bitcoind AbortNode()'s
3922019-02-05T21:42:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
3932019-02-05T21:42:46  *** bitcoin-git has joined #bitcoin-core-dev
3942019-02-05T21:42:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) (master...fix-startup-crash) https://github.com/bitcoin/bitcoin/pull/15203
3952019-02-05T21:42:46  <sdaftuar> and the http server is slow to shut down
3962019-02-05T21:42:47  *** bitcoin-git has left #bitcoin-core-dev
3972019-02-05T21:42:48  <promag> one way to fix this is to send the close header if --usecli
3982019-02-05T21:43:05  *** jarthur has joined #bitcoin-core-dev
3992019-02-05T21:43:29  <promag> however I'm still curious of what should be the correct behavior of stop
4002019-02-05T21:43:43  *** jarthur has joined #bitcoin-core-dev
4012019-02-05T21:43:43  <promag> stop command should force close everything?
4022019-02-05T21:43:54  <sdaftuar> yeah i don't know, i haven't given this much though
4032019-02-05T21:43:56  <sdaftuar> thought*
4042019-02-05T21:44:27  <promag> anyway I'll see if I can fix this with the above idea
4052019-02-05T21:44:58  <sdaftuar> ok thanks for working on this, hopefully others more knowledgeable about the design here can chime in with suggestions
4062019-02-05T21:45:37  <promag> well maybe wait_for_rpc_connection should also --usecli
4072019-02-05T21:45:46  <promag> jnewbery: ^
4082019-02-05T21:46:50  <promag> bbl with a pr, sorry for the inconvenient
4092019-02-05T21:48:37  *** ExtraCrispy has quit IRC
4102019-02-05T21:49:40  *** promag has quit IRC
4112019-02-05T22:00:06  *** esotericnonsense has quit IRC
4122019-02-05T22:03:15  *** esotericnonsense has joined #bitcoin-core-dev
4132019-02-05T22:06:28  *** jarthur has quit IRC
4142019-02-05T22:07:02  *** spinza has quit IRC
4152019-02-05T22:17:30  *** bitcoin-git has joined #bitcoin-core-dev
4162019-02-05T22:17:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b63c436a699...9e7f8f6c8271
4172019-02-05T22:17:31  <bitcoin-git> bitcoin/master ef0b012 practicalswift: tests: Make updatecoins_simulation_test deterministic
4182019-02-05T22:17:32  <bitcoin-git> bitcoin/master 9e7f8f6 MarcoFalke: Merge #15327: tests: Make test updatecoins_simulation_test deterministic
4192019-02-05T22:17:35  *** bitcoin-git has left #bitcoin-core-dev
4202019-02-05T22:18:10  *** bitcoin-git has joined #bitcoin-core-dev
4212019-02-05T22:18:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15327: tests: Make test updatecoins_simulation_test deterministic (master...SeedInsecureRand(true);) https://github.com/bitcoin/bitcoin/pull/15327
4222019-02-05T22:18:12  *** bitcoin-git has left #bitcoin-core-dev
4232019-02-05T22:21:34  *** bitcoin-git has joined #bitcoin-core-dev
4242019-02-05T22:21:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e7f8f6c8271...baf125b31d0b
4252019-02-05T22:21:35  <bitcoin-git> bitcoin/master 4701239 Amiti Uttarwar: [Docs] Small updates to getrawtransaction description
4262019-02-05T22:21:35  <bitcoin-git> bitcoin/master baf125b MarcoFalke: Merge #15332: [Docs] Small updates to getrawtransaction description
4272019-02-05T22:21:37  *** bitcoin-git has left #bitcoin-core-dev
4282019-02-05T22:22:19  *** bitcoin-git has joined #bitcoin-core-dev
4292019-02-05T22:22:19  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15332: [Docs] Small updates to getrawtransaction description (master...get_transaction_docs) https://github.com/bitcoin/bitcoin/pull/15332
4302019-02-05T22:22:23  *** bitcoin-git has left #bitcoin-core-dev
4312019-02-05T22:22:42  *** pinheadmz has quit IRC
4322019-02-05T22:24:09  *** kexkey has quit IRC
4332019-02-05T22:26:37  *** spinza has joined #bitcoin-core-dev
4342019-02-05T22:29:25  *** promag has joined #bitcoin-core-dev
4352019-02-05T22:30:25  *** michaelsdunn1 has quit IRC
4362019-02-05T22:38:37  *** Murch has quit IRC
4372019-02-05T22:39:59  *** Murch has joined #bitcoin-core-dev
4382019-02-05T22:43:18  *** bitcoin-git has joined #bitcoin-core-dev
4392019-02-05T22:43:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/baf125b31d0b...5029e94f855c
4402019-02-05T22:43:19  <bitcoin-git> bitcoin/master 58180b5 James O'Beirne: tests: add utility to easily profile node performance with perf
4412019-02-05T22:43:20  <bitcoin-git> bitcoin/master 13782b8 James O'Beirne: docs: add perf section to developer docs
4422019-02-05T22:43:21  <bitcoin-git> bitcoin/master 5029e94 MarcoFalke: Merge #14519: tests: add utility to easily profile node performance with p...
4432019-02-05T22:43:22  *** bitcoin-git has left #bitcoin-core-dev
4442019-02-05T22:43:46  *** bitcoin-git has joined #bitcoin-core-dev
4452019-02-05T22:43:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14519: tests: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
4462019-02-05T22:43:52  *** bitcoin-git has left #bitcoin-core-dev
4472019-02-05T22:45:28  *** Skirmant has joined #bitcoin-core-dev
4482019-02-05T22:47:13  *** EagleTM has quit IRC
4492019-02-05T22:51:18  *** dqx has quit IRC
4502019-02-05T23:00:48  *** Murch has quit IRC
4512019-02-05T23:04:59  *** pinheadmz has joined #bitcoin-core-dev
4522019-02-05T23:05:24  *** IGHOR has quit IRC
4532019-02-05T23:07:16  *** IGHOR has joined #bitcoin-core-dev
4542019-02-05T23:07:41  *** dqx has joined #bitcoin-core-dev
4552019-02-05T23:08:20  *** Murch has joined #bitcoin-core-dev
4562019-02-05T23:08:34  *** twistedline has quit IRC
4572019-02-05T23:17:10  <gleb> It's confusing that we do not log "AcceptToMemoryPool" upon accepting orphan transactions (when receive a valid parent)
4582019-02-05T23:17:28  <jnewbery> promag: I'm not sure without digging into it. Feel free to @ me on the PR
4592019-02-05T23:17:46  <gleb> We do it for a parent, but not for an not-orphan-anymore child...
4602019-02-05T23:23:20  *** bitcoin-git has joined #bitcoin-core-dev
4612019-02-05T23:23:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349
4622019-02-05T23:23:23  *** bitcoin-git has left #bitcoin-core-dev
4632019-02-05T23:23:32  <gmaxwell> gleb: weird. patch accepted?
4642019-02-05T23:23:49  *** DeanGuss has quit IRC
4652019-02-05T23:25:48  <gleb> gmaxwell: Sorry not sure what you're asking, are you suggesting me to fix it?
4662019-02-05T23:54:02  <gmaxwell> gleb: yes, I agree it's weird that we don't log. it also should be a trivial change to add a log entry for it.
4672019-02-05T23:54:12  <gmaxwell> So I'm suggesting you go add it. :)