12019-03-13T00:00:45  *** jimmysong has joined #bitcoin-core-dev
  22019-03-13T00:06:06  <promag> it'd be nice to label all pulls that "fix something"
  32019-03-13T00:07:32  <promag> see pulls listed in #15575 description, only common label is "wallet"
  42019-03-13T00:07:34  <gribble> https://github.com/bitcoin/bitcoin/issues/15575 | 0.17: Backport 15297 by promag · Pull Request #15575 · bitcoin/bitcoin · GitHub
  52019-03-13T00:08:35  <promag> add label or place them in some gh project
  62019-03-13T00:12:10  <fanquake> promag you keep adding new backports to that :p, the labels can't keep up
  72019-03-13T00:12:12  *** timothy has quit IRC
  82019-03-13T00:14:38  <promag> what I mean is that, for instance, #11911 could have a "backport candidate" label or something like that
  92019-03-13T00:14:41  <gribble> https://github.com/bitcoin/bitcoin/issues/11911 | Free BerkeleyEnvironment instances when not in use by ryanofsky · Pull Request #11911 · bitcoin/bitcoin · GitHub
 102019-03-13T00:15:16  <promag> it's not a new feature, it's kind of fix
 112019-03-13T00:15:45  *** pinheadmz has quit IRC
 122019-03-13T00:16:04  *** captjakk has quit IRC
 132019-03-13T00:16:38  *** captjakk has joined #bitcoin-core-dev
 142019-03-13T00:19:10  <fanquake> promag right, ok
 152019-03-13T00:19:30  *** fanquake has quit IRC
 162019-03-13T00:21:10  *** captjakk has quit IRC
 172019-03-13T00:33:57  *** jonatack has quit IRC
 182019-03-13T00:48:09  *** fanquake has joined #bitcoin-core-dev
 192019-03-13T00:50:34  *** ap4lmtree has quit IRC
 202019-03-13T00:50:52  *** ap4lmtree has joined #bitcoin-core-dev
 212019-03-13T00:53:42  *** owowo has quit IRC
 222019-03-13T00:56:10  *** owowo has joined #bitcoin-core-dev
 232019-03-13T00:59:30  *** ap4lmtree has quit IRC
 242019-03-13T01:00:04  *** ap4lmtree has joined #bitcoin-core-dev
 252019-03-13T01:07:37  *** ap4lmtree has quit IRC
 262019-03-13T01:07:55  *** ap4lmtree has joined #bitcoin-core-dev
 272019-03-13T01:11:24  *** zhangzf has joined #bitcoin-core-dev
 282019-03-13T01:12:53  *** ap4lmtree has quit IRC
 292019-03-13T01:13:13  *** ap4lmtree has joined #bitcoin-core-dev
 302019-03-13T01:13:34  *** d_t has joined #bitcoin-core-dev
 312019-03-13T01:15:12  *** owowo has quit IRC
 322019-03-13T01:20:18  *** ap4lmtree has quit IRC
 332019-03-13T01:30:45  *** pinheadmz has joined #bitcoin-core-dev
 342019-03-13T01:31:43  *** owowo has joined #bitcoin-core-dev
 352019-03-13T01:44:58  *** harding has quit IRC
 362019-03-13T01:45:23  *** murrayn has quit IRC
 372019-03-13T01:45:27  *** promag has quit IRC
 382019-03-13T01:46:17  *** harding has joined #bitcoin-core-dev
 392019-03-13T01:56:41  *** booyah has quit IRC
 402019-03-13T01:59:37  *** Cory has quit IRC
 412019-03-13T02:02:27  *** pinheadmz has quit IRC
 422019-03-13T02:05:59  *** Cory has joined #bitcoin-core-dev
 432019-03-13T02:11:03  *** pinheadmz has joined #bitcoin-core-dev
 442019-03-13T02:15:48  *** ap4lmtree has joined #bitcoin-core-dev
 452019-03-13T02:27:11  *** pinheadmz has quit IRC
 462019-03-13T02:27:19  *** shesek has quit IRC
 472019-03-13T02:55:55  *** AaronvanW has quit IRC
 482019-03-13T02:56:48  *** pinheadmz has joined #bitcoin-core-dev
 492019-03-13T02:59:35  *** bitcoin-git has joined #bitcoin-core-dev
 502019-03-13T02:59:36  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15587: wallet: Remove GetLegacyBalance (master...1903-walletRemoveLegacyBal) https://github.com/bitcoin/bitcoin/pull/15587
 512019-03-13T02:59:49  *** bitcoin-git has left #bitcoin-core-dev
 522019-03-13T03:04:24  *** spaced0ut has quit IRC
 532019-03-13T03:04:58  <gwillen> sipa: when you get a moment, can you explain to me a bit more about your most recent comment on #15508
 542019-03-13T03:05:00  <gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
 552019-03-13T03:05:35  *** test12345 has joined #bitcoin-core-dev
 562019-03-13T03:06:07  <gwillen> i.e. specifically why it is that mempool code needs to care about potential insanely-signature-happy transactions, but we don't need to worry that we might have to deal with one here?
 572019-03-13T03:06:29  <gwillen> Is it that there is some reason one would not be possible, or just that such a transaction is so abusive that we never expect to see one in a non-adversarial context in practice?
 582019-03-13T03:09:44  <sipa> gwillen: in the mempool crazy things are possible, because they're constructed by third parties
 592019-03-13T03:10:18  <sipa> the size estimation code in analyzepsbt obviously only works for transactions that fully consist of inputs we at least understand
 602019-03-13T03:11:03  <sipa> those crazy sigoo-limited transactions are not we're able to sign for regardless
 612019-03-13T03:12:39  <gmaxwell> currently.
 622019-03-13T03:13:23  <sipa> gmaxwell: can you imagine any where that isn't the case?
 632019-03-13T03:14:01  <sipa> miniscript doesn't include anything where sigop cost would dominate either
 642019-03-13T03:15:13  <gmaxwell> for sigops cost to dominate there needs to be reused signatures?
 652019-03-13T03:15:56  <sipa> yes, by a factor 3x
 662019-03-13T03:16:03  *** pinheadmz has quit IRC
 672019-03-13T03:16:27  <sipa> and that is ignoring pubkey sizes
 682019-03-13T03:17:12  <gmaxwell> okay, then no, I don't.
 692019-03-13T03:17:23  <gmaxwell> (sorry, the currently was a thoughtless comment)
 702019-03-13T03:18:06  <gmaxwell> and I hope in the future any sigops limits we do are just achieved via weight adjustment... (or at worst per txin limits...)
 712019-03-13T03:18:07  *** pinheadmz has joined #bitcoin-core-dev
 722019-03-13T03:19:02  <sipa> gmaxwell: weight adjustment is painful, as it means you can't compute weight without knowing utxos being spent
 732019-03-13T03:19:37  <sipa> but otherwise i agree, i hope that going forward we can get rid of the two distinct resource limits
 742019-03-13T03:23:52  <gmaxwell> sipa: with segwit you don't need to know the utxo, redeemscript is present in the transaction itself, always.
 752019-03-13T03:24:13  <gmaxwell> though perhaps we sould make the version explicit in the transaction itself in future script versions!
 762019-03-13T03:24:17  <gmaxwell> (for this reason!)
 772019-03-13T03:24:33  <MarcoFalke> promag: fanquake: The gitian build takes about 12h for master and about 12h per pull (if it is in the same loop run). So the worst case for two pulls (assuming two loops are run for two pulls, because for example the second pull was labelled after the first one started) is 48 hours wait time.
 782019-03-13T03:25:20  <sipa> gmaxwell: but you can't know from the spending tx what segwit version it is
 792019-03-13T03:25:37  <sipa> say, there could be a p2wpkh spend that looks like a p2wsh
 802019-03-13T03:25:52  <sipa> and with future witness versions this may become even harder
 812019-03-13T03:25:52  <gmaxwell> we could fix that in future versions.
 822019-03-13T03:26:02  <sipa> i don't think so
 832019-03-13T03:26:35  <fanquake> MarcoFalke thanks
 842019-03-13T03:26:43  <gmaxwell> luke-jr solve this problem for us.
 852019-03-13T03:27:01  <gmaxwell> :P
 862019-03-13T03:27:13  * sipa likes a rule that the sigop cost of a spend can't exceed its witness size
 872019-03-13T03:27:24  <gmaxwell> We could fix it with a softfork that makes some classes of otherwise valid v1 scripts invalid.
 882019-03-13T03:27:48  <gmaxwell> sipa: the idea of data stuffing (or never being able to have expensive opcodes) makes me sad.
 892019-03-13T03:28:02  <gmaxwell> Esp with taproot where many features can mostly exist as threats more than reality.
 902019-03-13T03:28:25  <gmaxwell> It would be reasonable to have absurdly expensive opcodes (e.g. like pairings), which are virtually never executed.
 912019-03-13T03:28:57  <sipa> yeah, when there are opcodes that have a (much) higher cpu cost per byte than things we currently have, that approach isn't viable
 922019-03-13T03:29:03  *** gkrizek has joined #bitcoin-core-dev
 932019-03-13T03:29:47  <gmaxwell> I dunno if pairings are there yet, but its at least plausable to me that they are.
 942019-03-13T03:30:17  <gmaxwell> certantly if we use checksig as the standard of acceptable cpu/byte they are.
 952019-03-13T03:30:30  <gmaxwell> as they're >10x worse.
 962019-03-13T03:32:34  <gwillen> sipa: ok thanks that makes sense to me
 972019-03-13T03:33:35  *** andrewbenson has joined #bitcoin-core-dev
 982019-03-13T03:33:54  <sipa> gmaxwell: p2p/storage update that RLE encodes big zeroes in witness elements; then have a rule that every OP_PAIRING must be followed by a push of 100 zero bytes :)
 992019-03-13T03:35:22  <gwillen> at that point you've pretty much turned it into size plus ops, you could just make the representation of each opcode equal in size to its op cost ;-)
1002019-03-13T03:35:29  <gmaxwell> this did occure to me, but unlike you I had the good taste to not mention it. :P
1012019-03-13T03:38:33  *** andrewbenson has quit IRC
1022019-03-13T03:41:04  *** pinheadmz has quit IRC
1032019-03-13T03:43:32  *** andrewbenson has joined #bitcoin-core-dev
1042019-03-13T03:44:46  <fanquake> MarcoFalke what is the meaning of the egg
1052019-03-13T03:51:09  *** andrewbenson has quit IRC
1062019-03-13T03:52:01  <echeveria> be thankful we can validate unconfirmed transactions at all
1072019-03-13T03:52:13  <echeveria> in ethereum you can't validate transactions really until they're in a block.
1082019-03-13T03:53:50  <gmaxwell> it's not an accident...
1092019-03-13T03:54:18  <gmaxwell> like, we've shot down and reformed proposals that make that harder.
1102019-03-13T04:21:07  *** luke-jr has quit IRC
1112019-03-13T04:26:31  *** EagleTM has joined #bitcoin-core-dev
1122019-03-13T04:27:35  *** Eagle[TM] has quit IRC
1132019-03-13T04:28:08  *** luke-jr has joined #bitcoin-core-dev
1142019-03-13T04:30:38  *** dviola has joined #bitcoin-core-dev
1152019-03-13T04:31:49  *** lukedashjr has joined #bitcoin-core-dev
1162019-03-13T04:34:00  *** luke-jr has quit IRC
1172019-03-13T04:36:45  *** lukedashjr is now known as luke-jr
1182019-03-13T04:42:47  *** luke-jr has quit IRC
1192019-03-13T04:46:11  *** luke-jr has joined #bitcoin-core-dev
1202019-03-13T05:06:54  *** dviola has quit IRC
1212019-03-13T05:07:22  *** pinheadmz has joined #bitcoin-core-dev
1222019-03-13T05:14:17  *** bitcoin-git has joined #bitcoin-core-dev
1232019-03-13T05:14:17  <bitcoin-git> [bitcoin] achow101 opened pull request #15588: Log the actual wallet file version and no longer publicly expose the "version" record (master...rm-wallet-nfileversion) https://github.com/bitcoin/bitcoin/pull/15588
1242019-03-13T05:14:19  *** bitcoin-git has left #bitcoin-core-dev
1252019-03-13T05:16:49  *** d_t has quit IRC
1262019-03-13T05:30:54  *** Victorsueca has quit IRC
1272019-03-13T05:31:39  *** Victorsueca has joined #bitcoin-core-dev
1282019-03-13T05:32:52  *** ctrlbreak_MAD has joined #bitcoin-core-dev
1292019-03-13T05:36:27  *** ctrlbreak has quit IRC
1302019-03-13T05:51:10  *** pinheadmz has quit IRC
1312019-03-13T06:03:55  <fanquake> dongcarl what are you doing your testing with guix on? I've been running 0.16.0 with QEMU on macOS
1322019-03-13T06:04:04  *** Victorsueca has quit IRC
1332019-03-13T06:04:07  *** Victor_sueca has joined #bitcoin-core-dev
1342019-03-13T06:04:23  <fanquake> Currently looking at setting up a alpine/guix docker container for building etc.
1352019-03-13T06:10:13  <dongcarl> fanquake: I’ve been doing it on my Arch machine... I haven’t tested nested containers yet unfortunately but you should give it a go and see if it works
1362019-03-13T06:10:59  <dongcarl> Your normal OS is macOS I presume?
1372019-03-13T06:11:09  <fanquake> Yea, running 10.14.x at the moment
1382019-03-13T06:16:25  *** pinheadmz has joined #bitcoin-core-dev
1392019-03-13T06:26:28  *** brianhoffman_ has joined #bitcoin-core-dev
1402019-03-13T06:28:30  *** brianhoffman has quit IRC
1412019-03-13T06:28:31  *** brianhoffman_ is now known as brianhoffman
1422019-03-13T06:30:06  *** a5m0 has quit IRC
1432019-03-13T06:30:17  *** instagibbs has quit IRC
1442019-03-13T06:33:33  *** instagibbs has joined #bitcoin-core-dev
1452019-03-13T06:34:31  *** a5m0 has joined #bitcoin-core-dev
1462019-03-13T06:36:20  *** d_t has joined #bitcoin-core-dev
1472019-03-13T06:45:56  *** luke-jr has quit IRC
1482019-03-13T06:54:38  *** d_t has quit IRC
1492019-03-13T07:08:41  *** luke-jr has joined #bitcoin-core-dev
1502019-03-13T07:17:43  *** luke-jr has quit IRC
1512019-03-13T07:20:16  *** fanquake has quit IRC
1522019-03-13T07:21:43  *** davec has quit IRC
1532019-03-13T07:22:33  *** DeanGuss has quit IRC
1542019-03-13T07:23:29  *** luke-jr has joined #bitcoin-core-dev
1552019-03-13T07:26:09  *** EagleTM has quit IRC
1562019-03-13T07:27:54  *** davec has joined #bitcoin-core-dev
1572019-03-13T07:27:57  *** luke-jr has quit IRC
1582019-03-13T07:32:18  *** pinheadmz has quit IRC
1592019-03-13T07:33:04  <wumpus> promag: it'd be nice to label all pulls that "fix something" -> this is what the "bug" label is for, in principle
1602019-03-13T07:33:28  <wumpus> I don't think PRs get labeled with that in practice, but it was the idea
1612019-03-13T07:33:48  *** davec has quit IRC
1622019-03-13T07:34:00  <wumpus> but I fully agree it would be useful when you want to wade through the zillions refactoring PRs and find those that actually solve problems
1632019-03-13T07:35:28  *** luke-jr has joined #bitcoin-core-dev
1642019-03-13T07:35:52  *** ccdle12 has joined #bitcoin-core-dev
1652019-03-13T07:42:03  *** luke-jr has quit IRC
1662019-03-13T07:53:45  <aj> wumpus: maybe rename the label to "bugfix" then?
1672019-03-13T07:54:37  <wumpus> bahh
1682019-03-13T07:55:12  <wumpus> I mean, that would work less well for issues, but I don't think discussing names is very useful in any case
1692019-03-13T07:57:43  <aj> wumpus: *shrug* it just never would've occurred to me to search PR's for label:bug
1702019-03-13T08:08:11  *** d_t has joined #bitcoin-core-dev
1712019-03-13T08:10:36  *** murrayn has joined #bitcoin-core-dev
1722019-03-13T08:13:18  <kallewoof> alternatively, we tag up the refactor PRs and you do "-label:refactor"
1732019-03-13T08:14:08  <kallewoof> i.e. https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=is%3Aopen+-label%3ARefactoring+
1742019-03-13T08:16:58  <kallewoof> that could probably use an additional "is:pr"..
1752019-03-13T08:17:36  *** phwalkr has joined #bitcoin-core-dev
1762019-03-13T08:22:43  <wumpus> but that gets features/documentation and all other categories as well, but ok good point
1772019-03-13T08:30:02  *** jungly has joined #bitcoin-core-dev
1782019-03-13T08:38:25  *** d_t has quit IRC
1792019-03-13T09:00:23  *** mmgen has joined #bitcoin-core-dev
1802019-03-13T09:07:37  *** luke-jr has joined #bitcoin-core-dev
1812019-03-13T09:20:25  *** Soligor has quit IRC
1822019-03-13T09:20:39  *** phwalkr has quit IRC
1832019-03-13T09:30:45  *** booyah has joined #bitcoin-core-dev
1842019-03-13T09:33:16  <luke-jr> [03:24:13] <gmaxwell> though perhaps we sould make the version explicit in the transaction itself in future script versions! <-- like the witness v1 draft I did in ~2017? :P
1852019-03-13T09:34:36  *** setpill has joined #bitcoin-core-dev
1862019-03-13T09:36:21  <luke-jr> (although I came away from that thinking it needed a substantial redesign)
1872019-03-13T09:37:17  *** dta_ has joined #bitcoin-core-dev
1882019-03-13T09:37:21  *** setpill has quit IRC
1892019-03-13T09:37:47  <dta_> chat
1902019-03-13T09:37:56  <dta_> bip16?
1912019-03-13T09:38:15  *** dta_ has quit IRC
1922019-03-13T09:38:46  *** newbie2019258_ has joined #bitcoin-core-dev
1932019-03-13T09:39:46  *** setpill has joined #bitcoin-core-dev
1942019-03-13T09:39:59  *** bitcoin-git has joined #bitcoin-core-dev
1952019-03-13T09:40:00  <bitcoin-git> [bitcoin] Sjors closed pull request #15567: Make OutputType consistent with Descriptor and return it (master...2019/03/descriptor-output-type) https://github.com/bitcoin/bitcoin/pull/15567
1962019-03-13T09:40:13  *** bitcoin-git has left #bitcoin-core-dev
1972019-03-13T09:41:22  <newbie2019258_> Hi guys, I got error message when I tried to use the /share/rpcauthrpcauth.py ANY help please?
1982019-03-13T09:43:37  <wumpus> which error message ?
1992019-03-13T09:45:20  *** timothy has joined #bitcoin-core-dev
2002019-03-13T09:46:37  <newbie2019258_> python ./rpcauth.py berlin2019RpcUser --->   File "/usr/lib/python2.7/hmac.py", line 50, in <lambda>     self.digest_cons = lambda d='': digestmod.new(d) AttributeError: 'str' object has no attribute 'new'
2012019-03-13T09:47:53  <wumpus> try 'python3' instead of 'python'
2022019-03-13T09:53:09  <newbie2019258_> YES! Perfect, thank you, working!!!
2032019-03-13T09:53:42  <wumpus> great!
2042019-03-13T09:54:12  <wumpus> to ask, was there any documentation that you followed that made you use 'python'?
2052019-03-13T09:54:46  <wumpus> if so that needs to be corrected
2062019-03-13T10:04:22  *** Guyver2 has joined #bitcoin-core-dev
2072019-03-13T10:06:48  <newbie2019258_> I searched a lot of on the web. But unfortunately I don't fund any "normal" documentation about this.
2082019-03-13T10:08:50  <newbie2019258_> Example: This topic also "unanswered" ---> https://bitcointalk.to/index.php?topic=4946696.0
2092019-03-13T10:11:42  *** luke-jr has quit IRC
2102019-03-13T10:12:06  *** luke-jr has joined #bitcoin-core-dev
2112019-03-13T10:13:02  <wumpus> i think the best place to search for or ask usage questions is the bitcoin stack overflow (https://bitcoin.stackexchange.com/)
2122019-03-13T10:16:01  <wumpus> the script is prefixed with "#!/usr/bin/env python3" so it should find the correct python interpreter if you execute the script without specifying one
2132019-03-13T10:18:13  *** sipa has quit IRC
2142019-03-13T10:18:31  <newbie2019258_> Yes, thank you, unfortunately I missed to check the shebang of the script.
2152019-03-13T10:18:44  *** sipa has joined #bitcoin-core-dev
2162019-03-13T10:20:14  <Sentineo> is verify-commits.py broken? It jus returns "origin/master was not signed with a trusted key!". Not saying which key is to blame.
2172019-03-13T10:23:29  <newbie2019258_> One more question please: After I added the rpcauth=... line into the config file (bitcoin.conf) how to need activate/accept, I mean maybe need to reload some service(s) or something like that? (I want to use the PHP wrapper to manage bitcoind over RPC)
2182019-03-13T10:25:05  <wumpus> Sentineo: gpg --refresh-keys might help
2192019-03-13T10:28:04  <wumpus> Sentineo: oh, it's broken here too
2202019-03-13T10:29:06  <wumpus> sipa's key 0xAC6626172E00A82CFFAE8972A636E97631F767E0 has expired and trying to refresh it gives me "gpg: keyserver refresh failed: No data"  :shrug:
2212019-03-13T10:37:46  *** bitcoin-git has joined #bitcoin-core-dev
2222019-03-13T10:37:46  <bitcoin-git> [bitcoin] practicalswift opened pull request #15589: lint: Teach lint-whitespace.sh to detect missing newline at end of file (master...lint-newline-at-eof) https://github.com/bitcoin/bitcoin/pull/15589
2232019-03-13T10:37:59  *** bitcoin-git has left #bitcoin-core-dev
2242019-03-13T10:40:51  <wumpus> oh no more linting PRs
2252019-03-13T10:41:10  <wumpus> can we stop doing that please ... :(
2262019-03-13T10:45:21  <gmaxwell> might be a better use of time to tell people how to set color.diff.whitespace in their local git configs.
2272019-03-13T10:45:25  *** jonatack has joined #bitcoin-core-dev
2282019-03-13T10:46:26  <wumpus> I don't care about EOL at the end of files and other micro-aesthetic obsessions
2292019-03-13T10:47:03  <wumpus> this is getting out of hand, has been for a while, maybe it's time to set a requirement that every PR fixes a reported problem
2302019-03-13T10:47:08  *** spinza has quit IRC
2312019-03-13T10:47:40  <gmaxwell> \O/
2322019-03-13T10:57:29  *** zhangzf has quit IRC
2332019-03-13T11:00:30  *** spinza has joined #bitcoin-core-dev
2342019-03-13T11:03:12  <Sentineo> is verify-commits.py broken? It jus returns "origin/master was not signed with a trusted key!". Not saying which key is to blame.
2352019-03-13T11:03:40  <luke-jr> gmaxwell: isn't color.diff.whitespace the default?
2362019-03-13T11:03:40  <Sentineo> hm sorry for pasting it again, exidentaly
2372019-03-13T11:03:43  <wumpus> Sentineo you're repeating yourself
2382019-03-13T11:03:49  <wumpus> ohh okay
2392019-03-13T11:03:54  *** bitcoin-git has joined #bitcoin-core-dev
2402019-03-13T11:03:55  <bitcoin-git> [bitcoin] practicalswift closed pull request #15589: tests: Teach lint-whitespace.sh to detect missing newline at end of file (master...lint-newline-at-eof) https://github.com/bitcoin/bitcoin/pull/15589
2412019-03-13T11:04:00  *** bitcoin-git has left #bitcoin-core-dev
2422019-03-13T11:05:15  *** shesek has joined #bitcoin-core-dev
2432019-03-13T11:05:15  *** shesek has joined #bitcoin-core-dev
2442019-03-13T11:18:51  *** bitcoin-git has joined #bitcoin-core-dev
2452019-03-13T11:18:52  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b1cb958f7c...8e1704c01537
2462019-03-13T11:18:53  <bitcoin-git> bitcoin/master a4d0fd0 fanquake: doc: correct analysepsbt rpc doc
2472019-03-13T11:18:53  <bitcoin-git> bitcoin/master 335931d fanquake: rpc: return a number for estimated_feerate in analyzepsbt
2482019-03-13T11:18:54  <bitcoin-git> bitcoin/master 8e1704c Wladimir J. van der Laan: Merge #15559: doc: correct analyzepsbt rpc doc
2492019-03-13T11:18:55  *** bitcoin-git has left #bitcoin-core-dev
2502019-03-13T11:19:32  *** bitcoin-git has joined #bitcoin-core-dev
2512019-03-13T11:19:32  <bitcoin-git> [bitcoin] laanwj merged pull request #15559: doc: correct analyzepsbt rpc doc (master...fixup-analysepsbt-rpc-doc) https://github.com/bitcoin/bitcoin/pull/15559
2522019-03-13T11:19:43  *** bitcoin-git has left #bitcoin-core-dev
2532019-03-13T11:20:42  *** bitcoin-git has joined #bitcoin-core-dev
2542019-03-13T11:20:43  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/021a9ad6f19b...2edd0c40c34b
2552019-03-13T11:20:44  <bitcoin-git> bitcoin/0.18 20fd64f fanquake: doc: correct analysepsbt rpc doc
2562019-03-13T11:20:45  <bitcoin-git> bitcoin/0.18 2edd0c4 fanquake: rpc: return a number for estimated_feerate in analyzepsbt
2572019-03-13T11:20:52  *** bitcoin-git has left #bitcoin-core-dev
2582019-03-13T11:49:12  *** darosior has joined #bitcoin-core-dev
2592019-03-13T12:04:14  <wumpus> re: #15583 yes I feel really strongly about not ignoring errors, it has given me so much pain...
2602019-03-13T12:04:15  <gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Ignore recursive_directory_iterator errors in ListWalletDir by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
2612019-03-13T12:08:39  *** drgrid is now known as TheCharlatan
2622019-03-13T12:16:05  *** sipa has quit IRC
2632019-03-13T12:16:16  *** zhangzf has joined #bitcoin-core-dev
2642019-03-13T12:18:18  *** spaced0ut has joined #bitcoin-core-dev
2652019-03-13T12:19:47  *** bitcoin-git has joined #bitcoin-core-dev
2662019-03-13T12:19:48  <bitcoin-git> [bitcoin] Sjors opened pull request #15590: Descriptor: add GetAddressType() -> base58 / bech32 (master...2019/03/descriptor-address-type) https://github.com/bitcoin/bitcoin/pull/15590
2672019-03-13T12:19:58  *** bitcoin-git has left #bitcoin-core-dev
2682019-03-13T12:23:32  *** sipa has joined #bitcoin-core-dev
2692019-03-13T12:44:00  *** darosior has quit IRC
2702019-03-13T12:52:43  *** fanquake has joined #bitcoin-core-dev
2712019-03-13T13:01:40  *** Zenton has quit IRC
2722019-03-13T13:06:23  *** AaronvanW has joined #bitcoin-core-dev
2732019-03-13T13:12:18  <dongcarl> fanquake: it would seem that all you need is docker --privileged to be able to nest. Lemme know if you encounter any problems.
2742019-03-13T13:12:19  *** drexl has joined #bitcoin-core-dev
2752019-03-13T13:13:09  <fanquake> dongcarl Thanks, I've seen similar in some mailing list discussions. I don't think it should be too hard to get setup.
2762019-03-13T13:13:21  <dongcarl> If you’re trying it out for the first time, I’d suggest using the install script and enabling binary downloads for packages. Otherwise you’ll be building the whole world from scratch
2772019-03-13T13:14:02  <fanquake> :o
2782019-03-13T13:16:49  <dongcarl> Haha yeah, very desirable for bootstrappability, but somewhat less so if you’re just trying things out haha
2792019-03-13T13:17:05  <dongcarl> You’ll be prompted for it when you run the install script I believe
2802019-03-13T13:17:23  <fanquake> Yea no worries, I'll keep a look out
2812019-03-13T13:26:11  *** Zenton has joined #bitcoin-core-dev
2822019-03-13T13:33:24  *** Karyon has quit IRC
2832019-03-13T13:35:03  *** Karyon has joined #bitcoin-core-dev
2842019-03-13T13:41:55  *** promag has joined #bitcoin-core-dev
2852019-03-13T13:43:30  *** fanquake has quit IRC
2862019-03-13T13:58:11  *** davec has joined #bitcoin-core-dev
2872019-03-13T14:01:23  *** ap4lmtree has quit IRC
2882019-03-13T14:01:42  *** ap4lmtree has joined #bitcoin-core-dev
2892019-03-13T14:32:37  *** justan0theruser has quit IRC
2902019-03-13T14:39:55  <promag> ryanofsky: I'm checking removing read access etc on walletdir and on each wallet file
2912019-03-13T14:40:46  <promag> ryanofsky: I don't think it results in an infinite loop
2922019-03-13T14:44:59  *** ap4lmtree has quit IRC
2932019-03-13T14:45:41  *** pinheadmz has joined #bitcoin-core-dev
2942019-03-13T14:53:11  *** justan0theruser has joined #bitcoin-core-dev
2952019-03-13T14:55:02  *** promag has quit IRC
2962019-03-13T14:55:51  *** promag has joined #bitcoin-core-dev
2972019-03-13T14:59:29  *** pinheadmz has quit IRC
2982019-03-13T15:03:09  *** zhangzf has quit IRC
2992019-03-13T15:04:18  *** zhangzf has joined #bitcoin-core-dev
3002019-03-13T15:11:46  <MarcoFalke> Sentineo: It seems so. Please file an issue about that
3012019-03-13T15:16:48  <MarcoFalke> Interesting that it took so long for someone to find out
3022019-03-13T15:17:29  <MarcoFalke> Or instead of filing an issue, ping sipa to upload his unexpired key
3032019-03-13T15:21:49  *** zhangzf has quit IRC
3042019-03-13T15:27:08  <MarcoFalke> hmm sub   4096R/C4EB3A28 2017-02-27 [expires: 2022-02-26]
3052019-03-13T15:28:26  *** jonatack has quit IRC
3062019-03-13T15:29:49  <MarcoFalke> ugh, gpg hides expired keys
3072019-03-13T15:31:21  <MarcoFalke> gpg --list-options show-unusable-subkeys --list-key --fingerprint --fingerprint 4E669320
3082019-03-13T15:31:37  *** captjakk has joined #bitcoin-core-dev
3092019-03-13T15:32:10  *** bitcoin-git has joined #bitcoin-core-dev
3102019-03-13T15:32:10  <bitcoin-git> [bitcoin] pajasevi opened pull request #15594: Changed Czech translation of the word "blockchain" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15594
3112019-03-13T15:32:11  *** bitcoin-git has left #bitcoin-core-dev
3122019-03-13T15:35:13  *** Soligor has joined #bitcoin-core-dev
3132019-03-13T15:38:55  *** promag has quit IRC
3142019-03-13T15:39:09  *** promag has joined #bitcoin-core-dev
3152019-03-13T15:47:11  *** pinheadmz has joined #bitcoin-core-dev
3162019-03-13T15:51:58  *** vexbuy has joined #bitcoin-core-dev
3172019-03-13T15:54:22  *** vexbuy has quit IRC
3182019-03-13T16:00:28  *** setpill has quit IRC
3192019-03-13T16:14:12  *** Ll1i1lL has quit IRC
3202019-03-13T16:14:30  *** Ll1i1lL has joined #bitcoin-core-dev
3212019-03-13T16:41:16  *** spinza has quit IRC
3222019-03-13T16:44:48  *** bitcoin-git has joined #bitcoin-core-dev
3232019-03-13T16:44:49  <bitcoin-git> [bitcoin] promag closed pull request #14826: Avoid expanding descriptor scriptPubKeys (master...2018-11-faster-descriptor-expand) https://github.com/bitcoin/bitcoin/pull/14826
3242019-03-13T16:45:01  *** bitcoin-git has left #bitcoin-core-dev
3252019-03-13T16:59:22  *** luke-jr has quit IRC
3262019-03-13T17:05:25  *** promag has quit IRC
3272019-03-13T17:05:59  *** promag has joined #bitcoin-core-dev
3282019-03-13T17:08:34  *** luke-jr has joined #bitcoin-core-dev
3292019-03-13T17:11:13  *** hebasto has joined #bitcoin-core-dev
3302019-03-13T17:12:22  *** luke-jr has quit IRC
3312019-03-13T17:12:47  *** luke-jr has joined #bitcoin-core-dev
3322019-03-13T17:15:43  *** captjakk has quit IRC
3332019-03-13T17:16:36  *** hebasto has quit IRC
3342019-03-13T17:17:07  *** luke-jr has quit IRC
3352019-03-13T17:29:12  *** luke-jr has joined #bitcoin-core-dev
3362019-03-13T17:36:45  *** ghost43 has quit IRC
3372019-03-13T17:36:59  *** ghost43 has joined #bitcoin-core-dev
3382019-03-13T17:40:25  *** spinza has joined #bitcoin-core-dev
3392019-03-13T17:42:39  *** bitcoin-git has joined #bitcoin-core-dev
3402019-03-13T17:42:40  <bitcoin-git> [bitcoin] laanwj closed pull request #15594: Changed Czech translation of the word "blockchain" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15594
3412019-03-13T17:42:45  *** bitcoin-git has left #bitcoin-core-dev
3422019-03-13T17:47:50  *** brianhoffman has quit IRC
3432019-03-13T17:49:36  *** brianhoffman has joined #bitcoin-core-dev
3442019-03-13T17:50:27  *** brianhoffman has quit IRC
3452019-03-13T17:53:12  *** brianhoffman has joined #bitcoin-core-dev
3462019-03-13T18:02:03  <wumpus> ahhh I hate gpg, no one understands it
3472019-03-13T18:02:12  <wumpus> (re #15592)
3482019-03-13T18:02:13  <gribble> https://github.com/bitcoin/bitcoin/issues/15592 | Bitcoin signing key by @laanwj expired on 2019-02-14 · Issue #15592 · bitcoin/bitcoin · GitHub
3492019-03-13T18:02:55  <wumpus> and the tons of mails I got about it
3502019-03-13T18:03:05  <wumpus> really, just retire the thing
3512019-03-13T18:03:41  *** darosior has joined #bitcoin-core-dev
3522019-03-13T18:05:12  <wumpus> I guess the whole expiration date thing is non-obvious but that's not my fault, I 'm only using the software, I don't deserve this
3532019-03-13T18:08:09  <sipa> wumpus: some people will always be confused
3542019-03-13T18:08:44  <luke-jr> I think someone needs to write an article going over how to use GPG
3552019-03-13T18:09:02  <luke-jr> it's a pain, though, because it needs to be just right :x
3562019-03-13T18:09:22  <wumpus> sipa: I don't really blame the people that are confused
3572019-03-13T18:11:54  <wumpus> luke-jr: we first have to find someone that is not confused about gpg to write it though
3582019-03-13T18:12:15  <wumpus> :-)
3592019-03-13T18:12:53  <luke-jr> the hard part is key verification :P
3602019-03-13T18:13:08  <wumpus> yes
3612019-03-13T18:18:56  *** ap4lmtree has joined #bitcoin-core-dev
3622019-03-13T18:21:39  <MarcoFalke> wumpus: Mind to backport #15582, so it doesn't miss rc2?
3632019-03-13T18:21:41  <gribble> https://github.com/bitcoin/bitcoin/issues/15582 | Fix overflow bug in analyzepsbt fee: CAmount instead of int by sipa · Pull Request #15582 · bitcoin/bitcoin · GitHub
3642019-03-13T18:23:00  <MarcoFalke> Should be a clean cherry-pick. I can backport it as well, but I would have to create a pull for it. Not sure if you prefer that
3652019-03-13T18:29:37  *** shesek has quit IRC
3662019-03-13T18:29:59  *** d_t has joined #bitcoin-core-dev
3672019-03-13T18:35:52  *** tripleslash has joined #bitcoin-core-dev
3682019-03-13T18:36:12  <wumpus> MarcoFalke: sure
3692019-03-13T18:36:35  *** tripleslash has joined #bitcoin-core-dev
3702019-03-13T18:36:36  *** tripleslash has quit IRC
3712019-03-13T18:37:12  *** bitcoin-git has joined #bitcoin-core-dev
3722019-03-13T18:37:12  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/2edd0c40c34b...232ef630ecd3
3732019-03-13T18:37:12  <bitcoin-git> bitcoin/0.18 232ef63 Pieter Wuille: Fix overflow bug in analyzepsbt fee: CAmount instead of int
3742019-03-13T18:37:14  *** bitcoin-git has left #bitcoin-core-dev
3752019-03-13T18:37:30  *** tripleslash has joined #bitcoin-core-dev
3762019-03-13T18:38:30  *** Victor_sueca is now known as Victorsueca
3772019-03-13T18:43:03  *** jarthur has joined #bitcoin-core-dev
3782019-03-13T18:43:44  *** CubicEarth has quit IRC
3792019-03-13T18:45:34  *** jonatack has joined #bitcoin-core-dev
3802019-03-13T18:45:46  *** CubicEarth has joined #bitcoin-core-dev
3812019-03-13T18:50:14  *** anome has joined #bitcoin-core-dev
3822019-03-13T19:04:01  *** schmidty_ has joined #bitcoin-core-dev
3832019-03-13T19:04:32  *** schmidty has quit IRC
3842019-03-13T19:05:07  *** rev_strangehope has quit IRC
3852019-03-13T19:07:52  *** rev_strangehope has joined #bitcoin-core-dev
3862019-03-13T19:20:07  *** anome has quit IRC
3872019-03-13T19:27:54  *** justan0theruser has quit IRC
3882019-03-13T19:29:55  *** anome has joined #bitcoin-core-dev
3892019-03-13T19:30:03  *** spaced0ut has quit IRC
3902019-03-13T19:31:25  *** darosior has quit IRC
3912019-03-13T19:33:01  <wumpus> rc2 tomorrow after the meeting?
3922019-03-13T19:33:21  *** anome has quit IRC
3932019-03-13T19:35:17  *** shesek has joined #bitcoin-core-dev
3942019-03-13T19:35:17  *** shesek has joined #bitcoin-core-dev
3952019-03-13T19:41:41  <MarcoFalke> I'd say so
3962019-03-13T19:44:17  <gmaxwell> Why not now? :P
3972019-03-13T19:45:13  *** AaronvanW has quit IRC
3982019-03-13T19:50:45  *** anome has joined #bitcoin-core-dev
3992019-03-13T19:54:09  *** luke-jr has quit IRC
4002019-03-13T19:54:31  *** luke-jr has joined #bitcoin-core-dev
4012019-03-13T19:55:26  <jonasschnelli> Any idea why Draht reports conflicts multiple times? https://github.com/bitcoin/bitcoin/pull/14032#issuecomment-471980504
4022019-03-13T19:55:30  <jonasschnelli> Maybe MarcoFalke
4032019-03-13T19:56:33  <MarcoFalke> Sorry, thats a bug
4042019-03-13T19:58:24  *** anome has quit IRC
4052019-03-13T19:59:40  <jonasschnelli> No worries and thanks for fixing MarcoFalke
4062019-03-13T20:04:24  <MarcoFalke> What is the git repo again that mirrors all bitcoin core github comments?
4072019-03-13T20:11:38  <echeveria> https://www.gharchive.org/
4082019-03-13T20:14:01  <echeveria> eg, curl -s http://data.gharchive.org/2015-01-01-{1..31}.json.gz | zgrep "github.com/bitcoin/bitcoin"
4092019-03-13T20:16:39  *** DeanGuss has joined #bitcoin-core-dev
4102019-03-13T20:18:45  <wumpus> gmaxwell: there's still #15583 tagged
4112019-03-13T20:18:47  <gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Log errors in ListWalletDir and IsBerkeleyBtree by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
4122019-03-13T20:19:03  <wumpus> otherwise, yeah I agree
4132019-03-13T20:20:05  *** AaronvanW has joined #bitcoin-core-dev
4142019-03-13T20:21:14  <wumpus> MarcoFalke: https://github.com/zw/bitcoin-gh-meta.git is what I used but it seems it hasn't been updated in a while :(
4152019-03-13T20:21:43  *** lnostdal has quit IRC
4162019-03-13T20:21:54  *** anome has joined #bitcoin-core-dev
4172019-03-13T20:24:08  *** lnostdal has joined #bitcoin-core-dev
4182019-03-13T20:24:14  *** justanotheruser has joined #bitcoin-core-dev
4192019-03-13T20:24:43  *** AaronvanW has quit IRC
4202019-03-13T20:30:47  *** ghost43 has quit IRC
4212019-03-13T20:31:51  *** ghost43 has joined #bitcoin-core-dev
4222019-03-13T20:36:27  *** DeanGuss has quit IRC
4232019-03-13T20:40:08  *** promag has quit IRC
4242019-03-13T20:40:20  *** promag has joined #bitcoin-core-dev
4252019-03-13T20:44:33  *** DeanGuss has joined #bitcoin-core-dev
4262019-03-13T20:45:14  *** bitcoin-git has joined #bitcoin-core-dev
4272019-03-13T20:45:15  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15595: rpc: Actually use sendmany::minconf (master...1903-rpcWalletDummySendmany) https://github.com/bitcoin/bitcoin/pull/15595
4282019-03-13T20:45:15  *** bitcoin-git has left #bitcoin-core-dev
4292019-03-13T20:47:49  *** CubicEarth has quit IRC
4302019-03-13T20:49:28  *** CubicEarth has joined #bitcoin-core-dev
4312019-03-13T20:51:08  <MarcoFalke> ^ not for 0.18.0 imo
4322019-03-13T21:02:34  *** Dean_Guss has joined #bitcoin-core-dev
4332019-03-13T21:02:36  *** promag has quit IRC
4342019-03-13T21:02:38  *** DeanGuss has quit IRC
4352019-03-13T21:03:10  *** promag has joined #bitcoin-core-dev
4362019-03-13T21:05:28  *** anome has quit IRC
4372019-03-13T21:05:51  *** anome has joined #bitcoin-core-dev
4382019-03-13T21:07:57  *** anome has quit IRC
4392019-03-13T21:15:34  *** mmgen has quit IRC
4402019-03-13T21:18:45  *** Dean_Guss has quit IRC
4412019-03-13T21:19:04  *** Dean_Guss has joined #bitcoin-core-dev
4422019-03-13T21:26:27  *** promag has quit IRC
4432019-03-13T21:26:40  *** promag has joined #bitcoin-core-dev
4442019-03-13T21:27:00  *** timothy has quit IRC
4452019-03-13T21:37:39  *** Dean_Guss has quit IRC
4462019-03-13T21:49:36  *** Dean_Guss has joined #bitcoin-core-dev
4472019-03-13T21:53:02  *** cubancorona has quit IRC
4482019-03-13T21:53:24  *** cubancorona has joined #bitcoin-core-dev
4492019-03-13T21:58:16  *** Guyver2 has quit IRC
4502019-03-13T21:59:36  *** dviola has joined #bitcoin-core-dev
4512019-03-13T22:00:37  *** dviola has joined #bitcoin-core-dev
4522019-03-13T22:07:37  *** DeanWeen has joined #bitcoin-core-dev
4532019-03-13T22:08:12  *** dviola has quit IRC
4542019-03-13T22:08:26  *** darosior has joined #bitcoin-core-dev
4552019-03-13T22:10:27  *** spinza has quit IRC
4562019-03-13T22:10:31  *** Dean_Guss has quit IRC
4572019-03-13T22:11:26  *** AaronvanW has joined #bitcoin-core-dev
4582019-03-13T22:11:58  *** darosior has quit IRC
4592019-03-13T22:12:28  *** davec has quit IRC
4602019-03-13T22:12:52  *** owowo has quit IRC
4612019-03-13T22:14:18  *** davec has joined #bitcoin-core-dev
4622019-03-13T22:18:31  *** Aaronvan_ has joined #bitcoin-core-dev
4632019-03-13T22:19:45  *** owowo has joined #bitcoin-core-dev
4642019-03-13T22:22:17  *** AaronvanW has quit IRC
4652019-03-13T22:25:41  *** sipa has quit IRC
4662019-03-13T22:25:54  *** sipa has joined #bitcoin-core-dev
4672019-03-13T22:26:13  *** dviola has joined #bitcoin-core-dev
4682019-03-13T22:26:18  *** bitcoin-git has joined #bitcoin-core-dev
4692019-03-13T22:26:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15596: rpc: Ignore sendmany::minconf as dummy value (master...1903-rpcWalletDummySendmany_2) https://github.com/bitcoin/bitcoin/pull/15596
4702019-03-13T22:26:30  *** bitcoin-git has left #bitcoin-core-dev
4712019-03-13T22:27:54  *** ccdle12 has quit IRC
4722019-03-13T22:32:08  *** bitcoin-git has joined #bitcoin-core-dev
4732019-03-13T22:32:08  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15595: rpc: Actually use sendmany::minconf (master...1903-rpcWalletDummySendmany) https://github.com/bitcoin/bitcoin/pull/15595
4742019-03-13T22:32:09  *** bitcoin-git has left #bitcoin-core-dev
4752019-03-13T22:33:44  *** bitcoin-git has joined #bitcoin-core-dev
4762019-03-13T22:33:44  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15587: wallet: Remove GetLegacyBalance (master...1903-walletRemoveLegacyBal) https://github.com/bitcoin/bitcoin/pull/15587
4772019-03-13T22:33:56  *** bitcoin-git has left #bitcoin-core-dev
4782019-03-13T22:35:07  *** dviola has quit IRC
4792019-03-13T22:38:54  *** diego2 has joined #bitcoin-core-dev
4802019-03-13T22:39:26  *** diego2 has left #bitcoin-core-dev
4812019-03-13T22:45:00  *** spinza has joined #bitcoin-core-dev
4822019-03-13T22:55:14  *** ccdle12 has joined #bitcoin-core-dev
4832019-03-13T23:00:50  *** cubancorona has quit IRC
4842019-03-13T23:01:33  *** captjakk has joined #bitcoin-core-dev
4852019-03-13T23:04:56  *** ccdle12 has quit IRC
4862019-03-13T23:09:19  *** promag has quit IRC
4872019-03-13T23:09:58  *** promag has joined #bitcoin-core-dev
4882019-03-13T23:13:17  *** rex4539 has joined #bitcoin-core-dev
4892019-03-13T23:32:48  *** justanotheruser is now known as biden
4902019-03-13T23:33:53  *** biden is now known as justanotheruser
4912019-03-13T23:37:43  *** pinheadmz has quit IRC
4922019-03-13T23:39:35  *** pinheadmz has joined #bitcoin-core-dev
4932019-03-13T23:50:52  *** Dean_Guss has joined #bitcoin-core-dev
4942019-03-13T23:51:57  *** DeanWeen has quit IRC
4952019-03-13T23:58:34  *** jarthur has quit IRC