12019-03-18T00:02:50  *** promag has quit IRC
  22019-03-18T00:03:03  *** promag_ has quit IRC
  32019-03-18T00:28:38  *** AaronvanW has quit IRC
  42019-03-18T00:34:43  *** shesek has joined #bitcoin-core-dev
  52019-03-18T00:51:24  *** jonatack has quit IRC
  62019-03-18T00:54:21  *** promag has joined #bitcoin-core-dev
  72019-03-18T01:13:43  *** fanquake has quit IRC
  82019-03-18T01:18:19  *** belcher has joined #bitcoin-core-dev
  92019-03-18T01:19:59  *** zhangzf has joined #bitcoin-core-dev
 102019-03-18T01:26:27  *** harrymm has quit IRC
 112019-03-18T01:31:42  *** pinheadmz has quit IRC
 122019-03-18T01:35:22  *** fanquake has joined #bitcoin-core-dev
 132019-03-18T01:37:06  *** pinheadmz has joined #bitcoin-core-dev
 142019-03-18T01:51:10  *** AaronvanW has joined #bitcoin-core-dev
 152019-03-18T01:52:15  *** zhangzf_ has joined #bitcoin-core-dev
 162019-03-18T01:52:20  *** zhangzf has quit IRC
 172019-03-18T01:55:04  *** promag has quit IRC
 182019-03-18T01:55:45  *** promag has joined #bitcoin-core-dev
 192019-03-18T01:56:04  *** bitcoin-git has joined #bitcoin-core-dev
 202019-03-18T01:56:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15616: rpc: Remove hex from decodescript RPCResult doc (master...1903-rpcDocDecodeS) https://github.com/bitcoin/bitcoin/pull/15616
 212019-03-18T01:56:06  *** bitcoin-git has left #bitcoin-core-dev
 222019-03-18T02:12:48  *** promag has quit IRC
 232019-03-18T02:13:12  *** promag has joined #bitcoin-core-dev
 242019-03-18T02:29:00  *** e4xit has quit IRC
 252019-03-18T02:35:46  *** EagleTM has quit IRC
 262019-03-18T02:41:09  *** promag_ has joined #bitcoin-core-dev
 272019-03-18T02:41:09  *** promag has quit IRC
 282019-03-18T02:42:50  <warren> fanquake: btw why the alpine container to use guix? the entire point of using guix is to eliminate other non-deterministic tools, the container should be directly guix (and separately the contents of that container are verifiably determinstic)
 292019-03-18T02:44:25  *** justanotheruser has quit IRC
 302019-03-18T02:45:25  *** promag_ has quit IRC
 312019-03-18T02:50:39  <fanquake> warren It seemed like the easiest way to get started. As far as I'm aware I can't run/use guix natively on macOS, so I need the container to actually install/run guix inside. The simplest/smallest choice seemed to be Alpine. Very open to other suggestions if you have any.
 322019-03-18T02:50:55  <fanquake> Related guix on macOS discussion here: https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00111.html
 332019-03-18T02:52:37  *** justanotheruser has joined #bitcoin-core-dev
 342019-03-18T02:56:08  *** Zenton has joined #bitcoin-core-dev
 352019-03-18T03:06:18  *** pinheadmz has quit IRC
 362019-03-18T03:12:51  *** pinheadmz has joined #bitcoin-core-dev
 372019-03-18T03:22:06  *** promag has joined #bitcoin-core-dev
 382019-03-18T03:28:14  *** pinheadmz has quit IRC
 392019-03-18T03:31:47  *** pinheadmz has joined #bitcoin-core-dev
 402019-03-18T03:36:17  *** AaronvanW has quit IRC
 412019-03-18T03:44:24  *** fanquake_ has joined #bitcoin-core-dev
 422019-03-18T03:47:13  *** fanquake has quit IRC
 432019-03-18T03:50:54  *** DeanGuss has joined #bitcoin-core-dev
 442019-03-18T03:52:36  *** pinheadmz has quit IRC
 452019-03-18T04:17:01  <warren> fanquake_: I suppose it's good to have any working way for macos to additionally replicate the same build for bit-for-bit verification, but given that you rely on osx -> alpine -> guix that's a lot of non-deterministic stuff. I  think verifying determinism of the build environment can be done separately and less often (don't bother to bootstrap guix on a system that can't)
 462019-03-18T05:07:00  *** pinheadmz has joined #bitcoin-core-dev
 472019-03-18T05:07:35  *** bitcoin-git has joined #bitcoin-core-dev
 482019-03-18T05:07:35  <bitcoin-git> [bitcoin] sipa opened pull request #15617: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
 492019-03-18T05:07:36  *** bitcoin-git has left #bitcoin-core-dev
 502019-03-18T05:13:13  *** davec has quit IRC
 512019-03-18T05:15:00  *** davec has joined #bitcoin-core-dev
 522019-03-18T05:40:19  *** pinheadmz has quit IRC
 532019-03-18T05:48:47  *** pinheadmz has joined #bitcoin-core-dev
 542019-03-18T06:36:18  *** rex4539 has quit IRC
 552019-03-18T06:46:18  *** rex4539 has joined #bitcoin-core-dev
 562019-03-18T07:05:57  *** pinheadmz has quit IRC
 572019-03-18T07:13:45  *** DeanGuss has quit IRC
 582019-03-18T07:31:54  *** ccdle12 has quit IRC
 592019-03-18T07:34:39  *** ccdle12 has joined #bitcoin-core-dev
 602019-03-18T07:37:26  *** bitcoin-git has joined #bitcoin-core-dev
 612019-03-18T07:37:27  <bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/acbbb7bf0d45...7ec7aea44281
 622019-03-18T07:37:27  <bitcoin-git> bitcoin/master faf3698 Glenn Willen: wallet: Improve log output for errors during load
 632019-03-18T07:37:28  <bitcoin-git> bitcoin/master 7ec7aea MeshCollider: Merge #15491: wallet: Improve log output for errors during load
 642019-03-18T07:37:30  *** bitcoin-git has left #bitcoin-core-dev
 652019-03-18T07:38:07  *** bitcoin-git has joined #bitcoin-core-dev
 662019-03-18T07:38:07  <bitcoin-git> [bitcoin] MeshCollider merged pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
 672019-03-18T07:38:09  *** bitcoin-git has left #bitcoin-core-dev
 682019-03-18T07:39:42  *** lnostdal has quit IRC
 692019-03-18T07:41:07  *** ppisati has quit IRC
 702019-03-18T07:41:22  *** lnostdal has joined #bitcoin-core-dev
 712019-03-18T07:43:50  *** ppisati has joined #bitcoin-core-dev
 722019-03-18T07:55:51  *** jouke_ has quit IRC
 732019-03-18T08:14:16  *** spinza has quit IRC
 742019-03-18T08:15:28  *** luke-jr has quit IRC
 752019-03-18T08:19:13  *** luke-jr has joined #bitcoin-core-dev
 762019-03-18T08:35:39  *** DeanGuss has joined #bitcoin-core-dev
 772019-03-18T08:36:52  *** spinza has joined #bitcoin-core-dev
 782019-03-18T09:23:29  *** ccdle12 has quit IRC
 792019-03-18T09:24:41  *** ccdle12 has joined #bitcoin-core-dev
 802019-03-18T09:24:59  *** DeanGuss has quit IRC
 812019-03-18T09:25:35  *** DeanGuss has joined #bitcoin-core-dev
 822019-03-18T09:40:06  *** setpill has joined #bitcoin-core-dev
 832019-03-18T09:40:27  *** shesek has quit IRC
 842019-03-18T09:44:46  *** setpill has quit IRC
 852019-03-18T09:46:30  *** setpill has joined #bitcoin-core-dev
 862019-03-18T09:47:10  *** Guyver2 has joined #bitcoin-core-dev
 872019-03-18T09:51:43  *** promag_ has joined #bitcoin-core-dev
 882019-03-18T09:52:28  *** timothy has joined #bitcoin-core-dev
 892019-03-18T09:58:40  *** mmgen has joined #bitcoin-core-dev
 902019-03-18T10:09:09  *** TheCharlatan has quit IRC
 912019-03-18T10:12:31  *** shesek has joined #bitcoin-core-dev
 922019-03-18T10:20:40  *** promag_ has quit IRC
 932019-03-18T10:25:03  *** DeanGuss has quit IRC
 942019-03-18T10:25:40  *** DeanGuss has joined #bitcoin-core-dev
 952019-03-18T10:26:14  *** jungly has joined #bitcoin-core-dev
 962019-03-18T10:28:10  *** promag_ has joined #bitcoin-core-dev
 972019-03-18T10:31:24  *** ExtraCrispy has joined #bitcoin-core-dev
 982019-03-18T10:32:28  <wumpus> rc2 binaries up https://bitcoincore.org/bin/bitcoin-core-0.18.0/test.rc2/
 992019-03-18T10:41:03  *** promag_ has quit IRC
1002019-03-18T10:42:39  *** ExtraCrispy has quit IRC
1012019-03-18T10:43:52  *** promag_ has joined #bitcoin-core-dev
1022019-03-18T10:45:46  *** DavidMitchell[m] has joined #bitcoin-core-dev
1032019-03-18T10:45:58  *** promag_ has quit IRC
1042019-03-18T10:47:52  *** spinza has quit IRC
1052019-03-18T10:49:18  *** promag_ has joined #bitcoin-core-dev
1062019-03-18T10:51:03  *** promag_ has quit IRC
1072019-03-18T10:55:31  *** promag_ has joined #bitcoin-core-dev
1082019-03-18T10:55:36  *** ExtraCrispy has joined #bitcoin-core-dev
1092019-03-18T10:55:49  *** spinza has joined #bitcoin-core-dev
1102019-03-18T10:57:24  *** zhangzf_ has quit IRC
1112019-03-18T11:02:43  *** promag_ has quit IRC
1122019-03-18T11:06:56  *** promag_ has joined #bitcoin-core-dev
1132019-03-18T11:17:32  *** promag_ has quit IRC
1142019-03-18T11:20:57  *** fanquake_ has quit IRC
1152019-03-18T11:22:10  *** promag_ has joined #bitcoin-core-dev
1162019-03-18T11:26:35  *** promag_ has quit IRC
1172019-03-18T11:34:15  *** promag_ has joined #bitcoin-core-dev
1182019-03-18T11:36:55  *** promag_ has quit IRC
1192019-03-18T11:51:13  *** fanquake has joined #bitcoin-core-dev
1202019-03-18T11:54:46  <fanquake> \o/
1212019-03-18T11:55:08  <fanquake> provoostenator hope you don't mind, I've updated 15555 with the new link.
1222019-03-18T11:56:56  *** promag_ has joined #bitcoin-core-dev
1232019-03-18T12:01:52  *** promag_ has quit IRC
1242019-03-18T12:08:18  *** DeanGuss has quit IRC
1252019-03-18T12:08:33  *** DeanGuss has joined #bitcoin-core-dev
1262019-03-18T12:14:24  *** AaronvanW has joined #bitcoin-core-dev
1272019-03-18T12:56:35  *** zhangzf has joined #bitcoin-core-dev
1282019-03-18T13:13:46  *** Aaronvan_ has joined #bitcoin-core-dev
1292019-03-18T13:14:49  *** spaced0ut has joined #bitcoin-core-dev
1302019-03-18T13:16:56  *** AaronvanW has quit IRC
1312019-03-18T13:36:15  *** jonatack has joined #bitcoin-core-dev
1322019-03-18T13:43:19  *** Emcy has quit IRC
1332019-03-18T14:01:09  *** Emcy has joined #bitcoin-core-dev
1342019-03-18T14:11:24  *** Emcy has quit IRC
1352019-03-18T14:30:53  *** owowo has quit IRC
1362019-03-18T14:33:45  *** muoitran has joined #bitcoin-core-dev
1372019-03-18T14:42:08  <muoitran> Hi, I'm looking at the AcceptConnection() of the net.cpp and I notice that whenever there is a new incoming connection and nInbound >= nMaxInbound, likely one existing incoming connection will be evicted.
1382019-03-18T14:43:45  <muoitran> Is this a bug or a design choice? Because doesn't this allow an adversary to evict some current legitimate incoming connections?
1392019-03-18T14:57:13  *** pinheadmz has joined #bitcoin-core-dev
1402019-03-18T14:57:45  <dongcarl> fanquake: Absolutely marvelous work with the Docker image! Will most likely get to test it out today.
1412019-03-18T15:02:37  *** captjakk has joined #bitcoin-core-dev
1422019-03-18T15:07:07  *** dqx_ has joined #bitcoin-core-dev
1432019-03-18T15:08:05  *** pinheadmz has quit IRC
1442019-03-18T15:25:20  *** _Sam-- has quit IRC
1452019-03-18T15:26:17  *** _Sam-- has joined #bitcoin-core-dev
1462019-03-18T15:27:56  *** bitcoin-git has joined #bitcoin-core-dev
1472019-03-18T15:27:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ec7aea44281...27781b6530c0
1482019-03-18T15:27:57  <bitcoin-git> bitcoin/master 2e5d482 Steven Roose: tests: Print remaining jobs in test_runner.py
1492019-03-18T15:27:58  <bitcoin-git> bitcoin/master 27781b6 MarcoFalke: Merge #15466: tests: Print remaining jobs in test_runner.py
1502019-03-18T15:28:09  *** bitcoin-git has left #bitcoin-core-dev
1512019-03-18T15:28:44  *** bitcoin-git has joined #bitcoin-core-dev
1522019-03-18T15:28:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15466: tests: Print remaining jobs in test_runner.py (master...remaining-jobs) https://github.com/bitcoin/bitcoin/pull/15466
1532019-03-18T15:28:47  *** bitcoin-git has left #bitcoin-core-dev
1542019-03-18T15:30:56  *** setpill has quit IRC
1552019-03-18T15:33:04  *** bitcoin-git has joined #bitcoin-core-dev
1562019-03-18T15:33:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/27781b6530c0...2c336a9ccdf4
1572019-03-18T15:33:06  <bitcoin-git> bitcoin/master 340ef50 Carl Dong: depends: Defer to Python detected by autoconf
1582019-03-18T15:33:07  <bitcoin-git> bitcoin/master 89bee1b Carl Dong: depends: tar: Always extract as yourself
1592019-03-18T15:33:08  <bitcoin-git> bitcoin/master f7696e6 Carl Dong: depends: qt: Don't hardcode pwd path
1602019-03-18T15:33:10  *** bitcoin-git has left #bitcoin-core-dev
1612019-03-18T15:33:46  *** bitcoin-git has joined #bitcoin-core-dev
1622019-03-18T15:33:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15581: depends: Make less assumptions about build env (master...2019-03-true-neutral-depends) https://github.com/bitcoin/bitcoin/pull/15581
1632019-03-18T15:33:49  *** bitcoin-git has left #bitcoin-core-dev
1642019-03-18T15:35:48  *** promag_ has joined #bitcoin-core-dev
1652019-03-18T15:35:48  *** promag has quit IRC
1662019-03-18T15:37:35  *** promag has joined #bitcoin-core-dev
1672019-03-18T15:37:35  *** promag_ has quit IRC
1682019-03-18T15:41:47  *** jonatack has quit IRC
1692019-03-18T15:42:40  *** mn949588 has quit IRC
1702019-03-18T15:42:40  *** mn94958812 has quit IRC
1712019-03-18T15:42:59  *** mn94958814 has joined #bitcoin-core-dev
1722019-03-18T15:42:59  *** mn949588 has joined #bitcoin-core-dev
1732019-03-18T15:47:34  *** MarcoFalke has quit IRC
1742019-03-18T15:48:24  *** MarcoFalke has joined #bitcoin-core-dev
1752019-03-18T15:50:18  *** cubancorona has quit IRC
1762019-03-18T15:55:22  *** TheCharlatan has joined #bitcoin-core-dev
1772019-03-18T16:02:39  *** StopAndDecrypt has quit IRC
1782019-03-18T16:02:48  *** StopAndDecrypt_ has joined #bitcoin-core-dev
1792019-03-18T16:03:08  *** pinheadmz has joined #bitcoin-core-dev
1802019-03-18T16:03:57  *** pinheadmz has quit IRC
1812019-03-18T16:04:43  *** pinheadmz has joined #bitcoin-core-dev
1822019-03-18T16:07:00  *** StopAndDecrypt has joined #bitcoin-core-dev
1832019-03-18T16:07:09  *** StopAndDecrypt has quit IRC
1842019-03-18T16:07:09  *** StopAndDecrypt has joined #bitcoin-core-dev
1852019-03-18T16:07:40  *** StopAndDecrypt_ has quit IRC
1862019-03-18T16:11:45  *** StopAndDecrypt has quit IRC
1872019-03-18T16:12:19  *** StopAndDecrypt has joined #bitcoin-core-dev
1882019-03-18T16:12:28  *** StopAndDecrypt has quit IRC
1892019-03-18T16:12:29  *** StopAndDecrypt has joined #bitcoin-core-dev
1902019-03-18T16:16:02  *** zhangzf has quit IRC
1912019-03-18T16:23:21  *** hebasto has joined #bitcoin-core-dev
1922019-03-18T16:29:50  *** belcher has quit IRC
1932019-03-18T16:32:21  *** muoitran has quit IRC
1942019-03-18T16:34:46  *** muoitran has joined #bitcoin-core-dev
1952019-03-18T16:54:50  *** promag has quit IRC
1962019-03-18T16:57:20  *** promag has joined #bitcoin-core-dev
1972019-03-18T17:01:48  *** instagibbs has quit IRC
1982019-03-18T17:02:04  *** promag has quit IRC
1992019-03-18T17:03:01  *** jarthur has joined #bitcoin-core-dev
2002019-03-18T17:04:00  *** instagibbs has joined #bitcoin-core-dev
2012019-03-18T17:09:11  *** jungly has quit IRC
2022019-03-18T17:15:25  *** muoitran has quit IRC
2032019-03-18T17:23:21  *** pinheadmz has quit IRC
2042019-03-18T17:24:29  *** pinheadmz has joined #bitcoin-core-dev
2052019-03-18T17:24:40  *** bitcoin-git has joined #bitcoin-core-dev
2062019-03-18T17:24:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2c336a9ccdf4...c033c4b5cef8
2072019-03-18T17:24:41  <bitcoin-git> bitcoin/master e5efacb Karl-Johan Alm: test: Refactor vout fetches in rpc_rawtransaction
2082019-03-18T17:24:41  <bitcoin-git> bitcoin/master 6c0a6f7 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to sendrawtransaction
2092019-03-18T17:24:42  <bitcoin-git> bitcoin/master 7abd2e6 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to testmempoolaccept
2102019-03-18T17:24:43  *** bitcoin-git has left #bitcoin-core-dev
2112019-03-18T17:25:00  *** bitcoin-git has joined #bitcoin-core-dev
2122019-03-18T17:25:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #13541: wallet/rpc: sendrawtransaction maxfeerate (master...sendrawtransaction-maxfeerate) https://github.com/bitcoin/bitcoin/pull/13541
2132019-03-18T17:25:12  *** bitcoin-git has left #bitcoin-core-dev
2142019-03-18T17:33:25  *** bitcoin-git has joined #bitcoin-core-dev
2152019-03-18T17:33:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
2162019-03-18T17:33:30  *** bitcoin-git has left #bitcoin-core-dev
2172019-03-18T17:33:56  <MarcoFalke> Sorry, I missed this during merge ^
2182019-03-18T17:34:42  <MarcoFalke> sneaky attempt of kallewoof to get signet merged? hmm :)
2192019-03-18T17:42:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2202019-03-18T17:43:04  *** Krellan has quit IRC
2212019-03-18T17:43:32  *** Krellan has joined #bitcoin-core-dev
2222019-03-18T17:47:26  *** Emcy has joined #bitcoin-core-dev
2232019-03-18T17:48:00  *** jb55 has quit IRC
2242019-03-18T17:48:30  *** Krellan has quit IRC
2252019-03-18T17:57:08  *** promag has joined #bitcoin-core-dev
2262019-03-18T18:03:18  *** bitcoin-git has joined #bitcoin-core-dev
2272019-03-18T18:03:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15620: rpc: Uncouple rpcs from maxTxFee global (master...1903-rpcNoMaxTxFee) https://github.com/bitcoin/bitcoin/pull/15620
2282019-03-18T18:03:20  *** bitcoin-git has left #bitcoin-core-dev
2292019-03-18T18:14:03  *** Deebo_ has joined #bitcoin-core-dev
2302019-03-18T18:15:19  *** jb55 has joined #bitcoin-core-dev
2312019-03-18T18:18:59  *** owowo has joined #bitcoin-core-dev
2322019-03-18T18:24:11  *** belcher has joined #bitcoin-core-dev
2332019-03-18T18:24:50  *** promag has quit IRC
2342019-03-18T18:26:40  *** spaced0ut has quit IRC
2352019-03-18T18:27:23  *** Deebo_ has quit IRC
2362019-03-18T18:30:26  <wumpus> MarcoFalke: ouch
2372019-03-18T18:30:52  *** Emcy has quit IRC
2382019-03-18T18:31:27  <wumpus> wallet/rpc should definitely not touch validation.cpp
2392019-03-18T18:32:56  *** promag has joined #bitcoin-core-dev
2402019-03-18T18:38:42  *** spaced0ut has joined #bitcoin-core-dev
2412019-03-18T18:42:26  *** captjakk has quit IRC
2422019-03-18T18:46:27  *** Aaronvan_ is now known as AaronvanW
2432019-03-18T18:48:31  *** captjakk has joined #bitcoin-core-dev
2442019-03-18T18:49:25  *** captjakk has quit IRC
2452019-03-18T18:49:56  *** captjakk has joined #bitcoin-core-dev
2462019-03-18T18:55:56  *** Krellan has joined #bitcoin-core-dev
2472019-03-18T19:00:19  *** Krellan has quit IRC
2482019-03-18T19:07:09  *** bitcoin-git has joined #bitcoin-core-dev
2492019-03-18T19:07:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c033c4b5cef8...e45b7f20e651
2502019-03-18T19:07:10  <bitcoin-git> bitcoin/master fa5c511 MarcoFalke: refactor: Remove unused function
2512019-03-18T19:07:10  <bitcoin-git> bitcoin/master e45b7f2 Wladimir J. van der Laan: Merge #15618: refactor: Remove unused function
2522019-03-18T19:07:19  *** bitcoin-git has left #bitcoin-core-dev
2532019-03-18T19:07:57  *** bitcoin-git has joined #bitcoin-core-dev
2542019-03-18T19:07:57  <bitcoin-git> [bitcoin] laanwj merged pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
2552019-03-18T19:08:09  *** bitcoin-git has left #bitcoin-core-dev
2562019-03-18T19:15:39  <MarcoFalke> Indeed
2572019-03-18T19:15:58  <MarcoFalke> I will get my DrahtBot script to tag pull requests up and running
2582019-03-18T19:17:39  <MarcoFalke> That script could be useful on its own
2592019-03-18T19:32:45  *** promag has quit IRC
2602019-03-18T19:40:22  *** AaronvanW has quit IRC
2612019-03-18T19:40:47  *** AaronvanW has joined #bitcoin-core-dev
2622019-03-18T20:00:49  *** spinza has quit IRC
2632019-03-18T20:04:40  *** captjakk has quit IRC
2642019-03-18T20:05:37  *** shesek has quit IRC
2652019-03-18T20:06:08  *** shesek has joined #bitcoin-core-dev
2662019-03-18T20:12:19  *** shesek has quit IRC
2672019-03-18T20:12:44  *** captjakk has joined #bitcoin-core-dev
2682019-03-18T20:13:32  *** captjakk has joined #bitcoin-core-dev
2692019-03-18T20:15:24  *** spinza has joined #bitcoin-core-dev
2702019-03-18T20:15:24  <moneyball> hi, i tried setting gmaxwell ban list in the Core GUI debug console, and in response i got "Error: IP/Subnet already banned (code -23)" even though i've never done this before. is there a reason they were already banned for my node?
2712019-03-18T20:23:57  <warren> moneyball: grep your debug.log, maybe they already triggered ban scores. in any case I think you'd be best to feed it into RPC with a script and ignore the output.
2722019-03-18T20:26:00  <moneyball> warren: maybe that error message is just referring to a subset of the list as having already been banned. i'll check the debug log...but i doubt all of them have already been banned? in any case, it seems like a more useful response could be provided to the user to avoid confusion? (i can create a github issue if appropriate)
2732019-03-18T20:29:54  *** Chris_Stewart_5 has quit IRC
2742019-03-18T20:32:45  <sipa> moneyball: they may be banned due to automatic behavior
2752019-03-18T20:33:34  <moneyball> ok. grep'ing for 'ban' reveals one, although i don't see that IP in greg's ban list: 2018-07-28 03:11:56 Misbehaving: 137.74.157.8:8333 peer=302 (80 -> 100) BAN THRESHOLD EXCEEDED
2762019-03-18T20:33:41  *** DeanGuss has quit IRC
2772019-03-18T20:34:33  *** Emcy has joined #bitcoin-core-dev
2782019-03-18T20:36:50  *** darosior has joined #bitcoin-core-dev
2792019-03-18T21:17:15  *** e4xit has joined #bitcoin-core-dev
2802019-03-18T21:19:49  <moneyball> i used bitcoin-cli listbanned to determine i have 474 banned, all of which are manually added. greg's list has 670. so i am wondering why my ban list is less (likely due to error aborting prematurely?). i am also still wondering about the "already banned" error message since i have none in the ban list that are shown as automatic.
2812019-03-18T21:20:07  <moneyball> (i can take this to another channel, or, to a github issue, if you'd prefer. just say the word.)
2822019-03-18T21:23:41  *** mmgen has quit IRC
2832019-03-18T21:24:52  <gwillen> moneyball: is it possible that you loaded a version of greg's list or similar in the past?
2842019-03-18T21:25:02  <echeveria> moneyball: some ranges could overlap.
2852019-03-18T21:25:34  <moneyball> gwillen: doubtful as i've never done anything around ban lists
2862019-03-18T21:30:02  <warren> I haven't looked at his ban list, you sure it doesn't have duplicates? Did you run it through sort then uniq and compare the before/after line count?
2872019-03-18T21:31:36  <warren> If he's using the GUI then I'm guessing it isn't a long lived node that would have a large ban list. Also GUI is a lot less likely to have incoming connections unless you configured your NAT/firewall to allow it. The ban list is mainly relevant to incoming connections.
2882019-03-18T21:33:13  <moneyball> for context, i'm just testing this out as it is referenced in this week's optech newsletter, so i wanted to make sure our readers have a good experience
2892019-03-18T21:40:05  *** Krellan has joined #bitcoin-core-dev
2902019-03-18T21:43:43  <gmaxwell> There is a small range overlap in my banlist, but it shouldn't reject bans for that reason.
2912019-03-18T21:44:40  <gmaxwell> IIRC There are only two ranges in my banlist at all, one has no overlap in the list because I removed all the overlapped addresses, and the other one I left them in.
2922019-03-18T21:45:18  <gmaxwell> (removed because it was 245 out of the 256 ips in the range, left the other one in because it was only 20 or so ips out of the range, and thought maybe the range was a bit questionable and might remove it later)
2932019-03-18T21:46:28  <gmaxwell> moneyball: if you only got one "already banned" that just means there was only one overlap.
2942019-03-18T21:46:54  <gmaxwell> moneyball: how are you counting in listbanned?
2952019-03-18T21:47:06  <gmaxwell> $ ./bitcoin-cli listbanned | grep address | wc -l
2962019-03-18T21:47:06  <gmaxwell> 723
2972019-03-18T21:47:47  <moneyball> that is how i counted
2982019-03-18T21:48:06  <moneyball> $bitcoin-cli listbanned | grep address | wc -l
2992019-03-18T21:48:06  <moneyball>      474
3002019-03-18T21:48:29  <moneyball> $bitcoin-cli listbanned | grep manually | wc -l
3012019-03-18T21:48:29  <moneyball>      474
3022019-03-18T21:48:37  <moneyball> $cat ~/Downloads/banlist.gui.txt | wc -l
3032019-03-18T21:48:38  <moneyball>      670
3042019-03-18T21:49:28  <gmaxwell> Is it possible that you used a cached copy (in your browser) of the list? 474 is more like the length of the list last week.
3052019-03-18T21:51:28  <gmaxwell> I guess I do have one dupe in the list, fixing.
3062019-03-18T21:51:29  <gmaxwell> https://0bin.net/paste/1hoyzTHrz-Lk94Cl#BcjjsSoYSzUlEhohe82jhANopBG5OL4gE04ke-+gBop
3072019-03-18T21:52:39  <gmaxwell> hm I don't see the dupe.
3082019-03-18T21:54:38  <gmaxwell> found it
3092019-03-18T21:55:04  <gmaxwell> There was just one in there without its /32.
3102019-03-18T21:55:13  <gmaxwell> maybe that messed up the paste in the gui?
3112019-03-18T21:56:17  <moneyball> i'm using https://people.xiph.org/~greg/banlist.gui.txt
3122019-03-18T21:56:50  <moneyball> gmaxwell: let me try again
3132019-03-18T21:56:52  *** jarthur has quit IRC
3142019-03-18T21:57:24  <gmaxwell> moneyball: right, they're the same (as in anytime I update cli I regenerate gui by running cat banlist.cli.txt  | cut -d' ' -f2- | sort > banlist.gui.txt )
3152019-03-18T21:58:26  <moneyball> https://www.irccloud.com/pastebin/z8Vn1pIW/
3162019-03-18T21:58:39  <moneyball> so maybe the GUI doesn't handle pasting that many items
3172019-03-18T21:58:44  <gmaxwell> lol :(
3182019-03-18T21:58:50  <moneyball> i'll try to break it into chunks
3192019-03-18T21:59:33  <gmaxwell> ::sigh:: maybe I should reorder it so the most important ones are first.
3202019-03-18T22:00:30  <moneyball> hmmm. even if i paste just ONE into the GUI, i now get this "Method not found" error
3212019-03-18T22:01:02  <harding> moneyball: are you using the version with ./bitcoin-cli embedded?  You need the one where the lines start with "setban"
3222019-03-18T22:02:25  <moneyball> harding: whoops!
3232019-03-18T22:02:34  <moneyball> i switched lists...
3242019-03-18T22:05:03  *** ThomasLuong has joined #bitcoin-core-dev
3252019-03-18T22:05:43  <harding> Testing on a regtest node, I can paste the current full list into the GUI, have it evaluate without error, and confirm via listbanned that the expected number of bans have been set.
3262019-03-18T22:06:00  <harding> (Linux here.)
3272019-03-18T22:06:16  <moneyball> gmaxwell: fyi  the line "setban 47.90.209.151 add 31557600" is still missing the /32. i tried loading in a different browser to confirm. did you push the change?
3282019-03-18T22:07:14  <gmaxwell> moneyball: that one didn't have it, it wasn't a dupe though. the /32 isn't required.
3292019-03-18T22:07:38  <gmaxwell> (I include it just so the output from list banned is consistent with my list)
3302019-03-18T22:07:43  <gmaxwell> (I added that one now)
3312019-03-18T22:09:48  <gmaxwell> harding: maybe it's OS specific? moneyball's latest paste looks pretty clearly like a truncation-- its cutoff in the middle of a line.
3322019-03-18T22:10:26  <luke-jr> aside: 162.218.65.0/24 is actually all attackers?
3332019-03-18T22:10:45  <luke-jr> (just seems strange most of the peers I know there claim to be btcd)
3342019-03-18T22:11:39  <moneyball> fwiw i'm MacOS, Chrome, Core v0.18rc2
3352019-03-18T22:12:55  <gmaxwell> luke-jr: yes.  245 out of the 256 IPs in that subnet connected to me falsely claiming to be android wallet, which they clearly are not, and then sit connected listening to all invs.
3362019-03-18T22:12:56  <midnightmagic> luke-jr: yes. The /24 is one I personally triangulated with someone else. ban one, another takes its place, randomly, in the /24. We got to 64 and then just killed the whole lot. None of them are even real nodes, and someone else has fingerprinted them.
3372019-03-18T22:13:03  <moneyball> i pasted just the last few dozen in the list into the GUI, and no error message, although the response i get is "null" ... which isn't very user friendly. is it expected?
3382019-03-18T22:13:31  <gmaxwell> moneyball: I think it has no response on a successful ban, yes.
3392019-03-18T22:13:38  <moneyball> also it increased by banned list to 509, which now strongly suggests the paste is being truncated
3402019-03-18T22:13:50  <moneyball> my*
3412019-03-18T22:16:29  <moneyball> i've managed to get my ban list up to 669, one short of gmaxwell's list of 670. to be clear, is there one dup/overlap in the list that would cause this?
3422019-03-18T22:16:37  <luke-jr> midnightmagic: yeah. looking like some kind of botnet
3432019-03-18T22:16:43  <harding> moneyball: the list is now 669 long.
3442019-03-18T22:16:54  <harding> I mean, it was 10 minutes ago.
3452019-03-18T22:17:43  <moneyball> ok i re-downloaded...confirmed
3462019-03-18T22:17:55  <gmaxwell> I dropped one that was actually duplicated, based on moneyball's report earlier.
3472019-03-18T22:18:09  <moneyball> so harding, for the newsletter, we might want to point out the pasting challenge.
3482019-03-18T22:18:11  <gmaxwell> so it sounds like maybe on OSX there is a paste limit that is getting in the way.
3492019-03-18T22:18:20  <moneyball> gmaxwell yeah
3502019-03-18T22:18:50  <gmaxwell> :(
3512019-03-18T22:23:04  <midnightmagic> gmaxwell: there's also a paste limitation when working through..  mosh I think and some kinds of shell connections. Easier to just wget it first and pipe.
3522019-03-18T22:23:53  *** spinza has quit IRC
3532019-03-18T22:26:40  *** ccdle12 has quit IRC
3542019-03-18T22:41:56  *** spinza has joined #bitcoin-core-dev
3552019-03-18T22:52:21  <luke-jr> gmaxwell: are ALL of your banned IPs implicated in the attack?
3562019-03-18T23:02:59  *** dqx_ has quit IRC
3572019-03-18T23:03:47  *** dqx_ has joined #bitcoin-core-dev
3582019-03-18T23:03:56  *** DeanGuss has joined #bitcoin-core-dev
3592019-03-18T23:05:02  <gmaxwell> luke-jr: 245 out of 256.
3602019-03-18T23:05:39  <luke-jr> gmaxwell: how about the specific one I PM'd you?
3612019-03-18T23:05:48  *** Zenton has quit IRC
3622019-03-18T23:05:59  <gmaxwell> oh you weren't asking about that /24.
3632019-03-18T23:07:59  <gmaxwell> Just answering the general question in public: no the IPs in my ban list are either addresses that are mass connecting to (nearly) every reachable node in the network and leaving connections up, OR were directly connecting to a node I control and behaving in a clearly abusive way, OR are part of an apparently eclipse attack in a clearly identifyable way. I'll follow up in PM about the specific
3642019-03-18T23:07:59  <gmaxwell> ones you're talking about.
3652019-03-18T23:08:43  *** dqx_ has quit IRC
3662019-03-18T23:10:19  *** darosior has quit IRC
3672019-03-18T23:11:44  *** ThomasLuong has quit IRC
3682019-03-18T23:13:31  *** ap4lmtree has quit IRC
3692019-03-18T23:13:56  *** ap4lmtree has joined #bitcoin-core-dev
3702019-03-18T23:21:17  *** Guyver2 has quit IRC
3712019-03-18T23:24:04  *** justanotheruser has quit IRC
3722019-03-18T23:24:59  *** justanotheruser has joined #bitcoin-core-dev
3732019-03-18T23:26:15  *** justanotheruser has quit IRC
3742019-03-18T23:26:32  <fanquake> dongcarl cheers. I'll take a look at your changes today.
3752019-03-18T23:26:46  *** justanotheruser has joined #bitcoin-core-dev
3762019-03-18T23:32:59  *** pinheadmz has quit IRC
3772019-03-18T23:36:09  <warren> fanquake: try downloading all of the depends prior to running the build inside guix, ideally the builder should work without any networking at all. That also bypasses the permission issue.
3782019-03-18T23:48:10  *** promag has joined #bitcoin-core-dev
3792019-03-18T23:55:19  *** ap4lmtree has quit IRC
3802019-03-18T23:55:41  *** pinheadmz has joined #bitcoin-core-dev
3812019-03-18T23:55:54  *** rex4539 has joined #bitcoin-core-dev
3822019-03-18T23:59:04  *** muoitran has joined #bitcoin-core-dev