12019-04-17T00:00:24 *** dviola has joined #bitcoin-core-dev
22019-04-17T00:02:27 *** captjakk has quit IRC
32019-04-17T00:06:18 *** StopAndDecrypt has quit IRC
42019-04-17T00:13:41 *** fanquake has joined #bitcoin-core-dev
52019-04-17T00:14:03 *** jarthur has quit IRC
62019-04-17T00:14:28 *** Dean_Guss has joined #bitcoin-core-dev
72019-04-17T00:20:23 *** StopAndDecrypt has joined #bitcoin-core-dev
82019-04-17T00:35:25 *** captjakk has joined #bitcoin-core-dev
92019-04-17T00:37:01 <luke-jr> can someone tag #15801 for 0.18 backport before it gets forgotten?
102019-04-17T00:37:04 <gribble> https://github.com/bitcoin/bitcoin/issues/15801 | Bugfix: GUI: Options: Initialise prune setting range before loading current value, and remove upper bound limit by luke-jr · Pull Request #15801 · bitcoin/bitcoin · GitHub
112019-04-17T00:39:47 *** justanotheruser has joined #bitcoin-core-dev
122019-04-17T00:40:03 *** captjakk has quit IRC
132019-04-17T00:40:46 *** bitcoin-git has joined #bitcoin-core-dev
142019-04-17T00:40:46 <bitcoin-git> [bitcoin] sdaftuar opened pull request #15834: Fix NOTFOUND bug and expire getdata requests for transactions (master...2019-04-fix-getdata) https://github.com/bitcoin/bitcoin/pull/15834
152019-04-17T00:40:59 *** bitcoin-git has left #bitcoin-core-dev
162019-04-17T00:48:09 <fanquake> luke-jr done
172019-04-17T00:49:45 <luke-jr> thx
182019-04-17T00:58:46 *** meotimdihia has joined #bitcoin-core-dev
192019-04-17T01:05:41 *** meotimdihia has quit IRC
202019-04-17T01:17:20 *** captjakk has joined #bitcoin-core-dev
212019-04-17T01:22:11 *** captjakk has quit IRC
222019-04-17T01:37:24 *** captjakk has joined #bitcoin-core-dev
232019-04-17T01:40:02 *** scoop has quit IRC
242019-04-17T01:41:47 *** captjakk has quit IRC
252019-04-17T01:46:34 *** scoop has joined #bitcoin-core-dev
262019-04-17T02:17:44 *** captjakk has joined #bitcoin-core-dev
272019-04-17T02:22:21 *** captjakk has quit IRC
282019-04-17T02:34:01 *** captjakk has joined #bitcoin-core-dev
292019-04-17T02:38:07 *** captjakk has quit IRC
302019-04-17T02:47:18 *** scoop has quit IRC
312019-04-17T02:54:01 *** scoop has joined #bitcoin-core-dev
322019-04-17T02:54:42 *** captjakk has joined #bitcoin-core-dev
332019-04-17T02:59:05 *** scoop has quit IRC
342019-04-17T02:59:07 *** captjakk has quit IRC
352019-04-17T03:00:42 *** scoop has joined #bitcoin-core-dev
362019-04-17T03:02:04 *** scoop_ has joined #bitcoin-core-dev
372019-04-17T03:05:03 *** scoop has quit IRC
382019-04-17T03:06:16 *** scoop_ has quit IRC
392019-04-17T03:07:05 *** shesek has quit IRC
402019-04-17T03:15:07 *** dviola has quit IRC
412019-04-17T03:36:08 *** captjakk has joined #bitcoin-core-dev
422019-04-17T03:38:47 *** scoop has joined #bitcoin-core-dev
432019-04-17T03:41:00 *** captjakk has quit IRC
442019-04-17T03:43:34 *** scoop has quit IRC
452019-04-17T04:13:11 *** Dean_Guss has quit IRC
462019-04-17T04:15:44 *** scoop has joined #bitcoin-core-dev
472019-04-17T04:16:03 *** millerti has quit IRC
482019-04-17T04:17:39 *** captjakk has joined #bitcoin-core-dev
492019-04-17T04:20:10 *** scoop has quit IRC
502019-04-17T04:22:48 *** captjakk has quit IRC
512019-04-17T04:32:20 *** spinza has quit IRC
522019-04-17T04:35:33 *** captjakk has joined #bitcoin-core-dev
532019-04-17T04:40:07 *** captjakk has quit IRC
542019-04-17T04:50:42 *** Karyon has quit IRC
552019-04-17T04:51:15 *** scoop has joined #bitcoin-core-dev
562019-04-17T04:52:06 *** Karyon has joined #bitcoin-core-dev
572019-04-17T04:55:39 *** scoop has quit IRC
582019-04-17T04:56:47 *** Zenton has quit IRC
592019-04-17T04:57:02 *** Zenton has joined #bitcoin-core-dev
602019-04-17T05:00:57 *** Ll1i1lL has quit IRC
612019-04-17T05:03:59 *** scoop has joined #bitcoin-core-dev
622019-04-17T05:06:01 *** spinza has joined #bitcoin-core-dev
632019-04-17T05:08:25 *** scoop has quit IRC
642019-04-17T05:10:14 *** rex4539 has quit IRC
652019-04-17T05:16:28 *** bitcoin-git has joined #bitcoin-core-dev
662019-04-17T05:16:29 <bitcoin-git> [bitcoin] ajtowns closed pull request #15776: Expire inflight GETDATA requests (master...201904-inflighttxtimeout) https://github.com/bitcoin/bitcoin/pull/15776
672019-04-17T05:16:32 *** bitcoin-git has left #bitcoin-core-dev
682019-04-17T05:17:29 <aj> fanquake: mind replacing 15776 in high-pri list with #15834 ?
692019-04-17T05:17:30 <gribble> https://github.com/bitcoin/bitcoin/issues/15834 | Fix NOTFOUND bug and expire getdata requests for transactions by sdaftuar · Pull Request #15834 · bitcoin/bitcoin · GitHub
702019-04-17T05:17:39 <fanquake> aj sure
712019-04-17T05:17:56 *** bralyclo_ has joined #bitcoin-core-dev
722019-04-17T05:20:33 *** bralyclow has quit IRC
732019-04-17T05:23:48 *** bralyclo_ has quit IRC
742019-04-17T05:24:27 *** bralyclow has joined #bitcoin-core-dev
752019-04-17T05:29:38 *** bralyclow has quit IRC
762019-04-17T05:36:31 *** Ll1i1lL has joined #bitcoin-core-dev
772019-04-17T05:40:03 *** scoop has joined #bitcoin-core-dev
782019-04-17T05:44:28 *** scoop has quit IRC
792019-04-17T05:46:33 *** rex4539 has joined #bitcoin-core-dev
802019-04-17T05:55:39 *** rex4539 has quit IRC
812019-04-17T06:10:01 *** dqx_ has joined #bitcoin-core-dev
822019-04-17T06:10:42 *** dqx_ has quit IRC
832019-04-17T06:14:34 *** scoop has joined #bitcoin-core-dev
842019-04-17T06:16:16 *** bitcoin-git has joined #bitcoin-core-dev
852019-04-17T06:16:16 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15836: Add feerate histogram to getmempoolinfo (master...2019/04/feeinfo) https://github.com/bitcoin/bitcoin/pull/15836
862019-04-17T06:16:28 *** bitcoin-git has left #bitcoin-core-dev
872019-04-17T06:18:39 *** scoop has quit IRC
882019-04-17T06:32:34 *** ccdle12 has joined #bitcoin-core-dev
892019-04-17T06:37:20 *** captjakk has joined #bitcoin-core-dev
902019-04-17T06:37:38 *** scoop has joined #bitcoin-core-dev
912019-04-17T06:41:44 *** scoop has quit IRC
922019-04-17T06:41:57 *** captjakk has quit IRC
932019-04-17T06:45:52 *** harding has quit IRC
942019-04-17T06:47:49 *** harding has joined #bitcoin-core-dev
952019-04-17T06:50:15 *** scoop has joined #bitcoin-core-dev
962019-04-17T06:54:38 *** scoop has quit IRC
972019-04-17T06:55:01 *** bralyclow has joined #bitcoin-core-dev
982019-04-17T06:58:30 *** captjakk has joined #bitcoin-core-dev
992019-04-17T07:02:51 *** captjakk has quit IRC
1002019-04-17T07:07:30 *** a5m0 has quit IRC
1012019-04-17T07:15:06 *** scoop has joined #bitcoin-core-dev
1022019-04-17T07:19:12 *** scoop has quit IRC
1032019-04-17T07:28:05 *** EagleTM has joined #bitcoin-core-dev
1042019-04-17T07:28:39 *** bralyclow has quit IRC
1052019-04-17T07:29:06 *** Dean_Guss has joined #bitcoin-core-dev
1062019-04-17T07:32:03 *** a5m0 has joined #bitcoin-core-dev
1072019-04-17T07:39:52 *** captjakk has joined #bitcoin-core-dev
1082019-04-17T07:42:20 *** ccdle12_ has joined #bitcoin-core-dev
1092019-04-17T07:42:32 *** kljasdfvv has joined #bitcoin-core-dev
1102019-04-17T07:44:06 *** fanquake has quit IRC
1112019-04-17T07:44:46 *** ccdle12 has quit IRC
1122019-04-17T07:44:49 *** captjakk has quit IRC
1132019-04-17T07:45:53 *** scoop has joined #bitcoin-core-dev
1142019-04-17T07:46:36 *** Bullitje_enable has quit IRC
1152019-04-17T07:48:31 *** kljasdfvv has quit IRC
1162019-04-17T07:50:15 *** scoop has quit IRC
1172019-04-17T07:57:22 *** kljasdfvv has joined #bitcoin-core-dev
1182019-04-17T08:03:54 *** scoop has joined #bitcoin-core-dev
1192019-04-17T08:05:31 *** EagleTM has quit IRC
1202019-04-17T08:08:10 *** scoop has quit IRC
1212019-04-17T08:15:28 *** ccdle12_ has quit IRC
1222019-04-17T08:17:00 *** fanquake has joined #bitcoin-core-dev
1232019-04-17T08:21:17 *** captjakk has joined #bitcoin-core-dev
1242019-04-17T08:24:20 *** EagleTM has joined #bitcoin-core-dev
1252019-04-17T08:26:25 *** captjakk has quit IRC
1262019-04-17T08:27:56 *** scoop has joined #bitcoin-core-dev
1272019-04-17T08:32:47 *** scoop has quit IRC
1282019-04-17T08:37:08 *** Bullit has joined #bitcoin-core-dev
1292019-04-17T08:41:01 *** captjakk has joined #bitcoin-core-dev
1302019-04-17T08:44:56 *** ccdle12 has joined #bitcoin-core-dev
1312019-04-17T08:45:39 *** captjakk has quit IRC
1322019-04-17T08:48:27 *** promag has joined #bitcoin-core-dev
1332019-04-17T08:52:10 *** scoop has joined #bitcoin-core-dev
1342019-04-17T08:52:46 *** promag has quit IRC
1352019-04-17T08:54:14 *** timothy has joined #bitcoin-core-dev
1362019-04-17T08:56:30 *** scoop has quit IRC
1372019-04-17T09:02:02 *** promag has joined #bitcoin-core-dev
1382019-04-17T09:09:02 *** laptop500 has joined #bitcoin-core-dev
1392019-04-17T09:15:01 *** scoop has joined #bitcoin-core-dev
1402019-04-17T09:17:30 *** EagleTM has quit IRC
1412019-04-17T09:19:19 *** scoop has quit IRC
1422019-04-17T09:22:42 *** captjakk has joined #bitcoin-core-dev
1432019-04-17T09:24:50 *** bralyclow has joined #bitcoin-core-dev
1442019-04-17T09:27:35 *** captjakk has quit IRC
1452019-04-17T09:33:03 *** promag has quit IRC
1462019-04-17T09:35:55 *** blackbaba has joined #bitcoin-core-dev
1472019-04-17T09:37:49 *** promag has joined #bitcoin-core-dev
1482019-04-17T09:38:25 *** scoop has joined #bitcoin-core-dev
1492019-04-17T09:38:44 *** timothy has quit IRC
1502019-04-17T09:39:50 *** captjakk has joined #bitcoin-core-dev
1512019-04-17T09:40:56 *** Guyver2 has joined #bitcoin-core-dev
1522019-04-17T09:43:04 *** scoop has quit IRC
1532019-04-17T09:44:51 *** captjakk has quit IRC
1542019-04-17T09:45:51 *** blackbaba_ has joined #bitcoin-core-dev
1552019-04-17T09:48:25 *** blackbaba has quit IRC
1562019-04-17T09:48:34 *** blackbaba_ is now known as blackbaba
1572019-04-17T09:49:39 *** promag has quit IRC
1582019-04-17T09:55:52 *** dviola has joined #bitcoin-core-dev
1592019-04-17T09:58:15 *** bralyclow has quit IRC
1602019-04-17T10:00:02 *** shesek has joined #bitcoin-core-dev
1612019-04-17T10:00:07 *** timothy has joined #bitcoin-core-dev
1622019-04-17T10:02:01 *** blackbaba has quit IRC
1632019-04-17T10:09:39 *** spinza has quit IRC
1642019-04-17T10:21:15 *** captjakk has joined #bitcoin-core-dev
1652019-04-17T10:25:16 *** scoop has joined #bitcoin-core-dev
1662019-04-17T10:26:10 *** captjakk has quit IRC
1672019-04-17T10:29:51 *** spinza has joined #bitcoin-core-dev
1682019-04-17T10:29:58 *** scoop has quit IRC
1692019-04-17T10:31:53 *** AaronvanW has joined #bitcoin-core-dev
1702019-04-17T10:35:03 *** Aaronvan_ has joined #bitcoin-core-dev
1712019-04-17T10:38:07 *** AaronvanW has quit IRC
1722019-04-17T10:39:37 *** captjakk has joined #bitcoin-core-dev
1732019-04-17T10:41:01 *** rh0nj has quit IRC
1742019-04-17T10:42:07 *** rh0nj has joined #bitcoin-core-dev
1752019-04-17T10:43:39 *** promag has joined #bitcoin-core-dev
1762019-04-17T10:43:57 *** captjakk has quit IRC
1772019-04-17T10:52:03 *** Skirmant has quit IRC
1782019-04-17T10:53:36 *** Victorsueca has quit IRC
1792019-04-17T10:54:45 *** Victorsueca has joined #bitcoin-core-dev
1802019-04-17T10:57:28 *** chriswang2019 has joined #bitcoin-core-dev
1812019-04-17T10:57:29 *** shesek has quit IRC
1822019-04-17T11:00:14 *** captjakk has joined #bitcoin-core-dev
1832019-04-17T11:02:09 *** jonatack has quit IRC
1842019-04-17T11:02:36 *** ccdle12 has quit IRC
1852019-04-17T11:05:01 *** captjakk has quit IRC
1862019-04-17T11:06:45 *** EagleTM has joined #bitcoin-core-dev
1872019-04-17T11:12:10 *** scoop has joined #bitcoin-core-dev
1882019-04-17T11:13:00 *** chriswang2019 has quit IRC
1892019-04-17T11:16:40 *** scoop has quit IRC
1902019-04-17T11:32:46 *** promag has quit IRC
1912019-04-17T11:33:51 *** promag has joined #bitcoin-core-dev
1922019-04-17T11:38:27 *** captjakk has joined #bitcoin-core-dev
1932019-04-17T11:39:57 *** scoop has joined #bitcoin-core-dev
1942019-04-17T11:41:43 *** EagleTM has quit IRC
1952019-04-17T11:43:15 *** captjakk has quit IRC
1962019-04-17T11:44:13 *** scoop has quit IRC
1972019-04-17T11:53:11 *** promag has quit IRC
1982019-04-17T11:55:05 *** bralyclow has joined #bitcoin-core-dev
1992019-04-17T11:59:53 *** captjakk has joined #bitcoin-core-dev
2002019-04-17T12:04:07 *** captjakk has quit IRC
2012019-04-17T12:08:15 *** scoop has joined #bitcoin-core-dev
2022019-04-17T12:18:42 *** spinza has quit IRC
2032019-04-17T12:20:22 *** Guyver2 has quit IRC
2042019-04-17T12:20:23 *** captjakk has joined #bitcoin-core-dev
2052019-04-17T12:25:09 *** captjakk has quit IRC
2062019-04-17T12:28:25 *** bralyclow has quit IRC
2072019-04-17T12:37:06 *** captjakk has joined #bitcoin-core-dev
2082019-04-17T12:38:23 *** Aaronvan_ is now known as AaronvanW
2092019-04-17T12:38:54 *** spinza has joined #bitcoin-core-dev
2102019-04-17T12:41:50 *** captjakk has quit IRC
2112019-04-17T12:46:13 *** lukedashjr has joined #bitcoin-core-dev
2122019-04-17T12:48:00 *** luke-jr has quit IRC
2132019-04-17T12:50:58 *** lukedashjr is now known as luke-jr
2142019-04-17T12:56:59 *** Aaronvan_ has joined #bitcoin-core-dev
2152019-04-17T12:57:08 *** AaronvanW has quit IRC
2162019-04-17T13:01:04 *** scoop has quit IRC
2172019-04-17T13:04:17 *** scoop has joined #bitcoin-core-dev
2182019-04-17T13:06:23 *** Skirmant has joined #bitcoin-core-dev
2192019-04-17T13:08:37 *** scoop has quit IRC
2202019-04-17T13:09:48 *** jonatack has joined #bitcoin-core-dev
2212019-04-17T13:30:52 *** bralyclow has joined #bitcoin-core-dev
2222019-04-17T13:38:03 *** captjakk has joined #bitcoin-core-dev
2232019-04-17T13:42:42 *** captjakk has quit IRC
2242019-04-17T13:42:45 *** darosior has joined #bitcoin-core-dev
2252019-04-17T13:50:45 <wumpus> strange, how to get an old wallet to generate a p2sh-segwit of bech32 receiving address? I don't seem to be able to from the GUI, I've done -upgradewallet and it upgrades the wallet in the log, but still, I get a 1xxxxx address when I generate a receiving address (and I've tried to uncheck "generate legacy address"
2262019-04-17T13:52:00 <wumpus> fwiw it did "Performing wallet upgrade to 169900" "Upgrading wallet to HD" "Upgrading wallet to use HD chain split"
2272019-04-17T13:53:18 <wumpus> we might want to disable that checkbox completely in this case
2282019-04-17T14:04:17 *** jonatack has quit IRC
2292019-04-17T14:14:06 *** Skirmant has quit IRC
2302019-04-17T14:15:09 <achow101> wumpus: the wallet version shouldn't matter
2312019-04-17T14:15:46 <achow101> try setting addresstype=p2sh-segwit?
2322019-04-17T14:19:00 <wumpus> I've done that, didn't work, I don't think that's supposed to affect the GUI. Also checked that it did work with a new wallet.
2332019-04-17T14:19:53 *** captjakk has joined #bitcoin-core-dev
2342019-04-17T14:23:52 <wumpus> I was asking in case the answer was obvious and I was missing soething, but apparently not :) I'll investigate deeper later, have some administration to do now
2352019-04-17T14:24:30 *** captjakk has quit IRC
2362019-04-17T14:24:48 <achow101> it's supposed to effect the gui and it has been for me (at least addresstype=bech32 does)
2372019-04-17T14:25:54 *** bralyclo_ has joined #bitcoin-core-dev
2382019-04-17T14:25:55 *** shesek has joined #bitcoin-core-dev
2392019-04-17T14:25:55 *** shesek has joined #bitcoin-core-dev
2402019-04-17T14:25:59 *** bralyclo_ has quit IRC
2412019-04-17T14:29:05 *** bralyclow has quit IRC
2422019-04-17T14:29:06 *** captjakk has joined #bitcoin-core-dev
2432019-04-17T14:31:43 *** bitcoin-git has joined #bitcoin-core-dev
2442019-04-17T14:31:43 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c9de67f343c...e2b5fdee0068
2452019-04-17T14:31:44 <bitcoin-git> bitcoin/master e377846 João Barbosa: rest/rpc: Make mempoolinfo atomic
2462019-04-17T14:31:44 <bitcoin-git> bitcoin/master e2b5fde MarcoFalke: Merge #15474: rest/rpc: Make mempoolinfo atomic
2472019-04-17T14:31:46 *** bitcoin-git has left #bitcoin-core-dev
2482019-04-17T14:32:24 *** bitcoin-git has joined #bitcoin-core-dev
2492019-04-17T14:32:24 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15474: rest/rpc: Make mempoolinfo atomic (master...2019-02-atomic-mempoolinfo) https://github.com/bitcoin/bitcoin/pull/15474
2502019-04-17T14:32:27 *** bitcoin-git has left #bitcoin-core-dev
2512019-04-17T14:33:13 *** pinheadmz has quit IRC
2522019-04-17T14:33:49 *** scoop has joined #bitcoin-core-dev
2532019-04-17T14:34:07 *** jeremyrubin has quit IRC
2542019-04-17T14:38:51 *** shesek has quit IRC
2552019-04-17T14:42:13 *** davterra has joined #bitcoin-core-dev
2562019-04-17T14:56:38 *** DougieBot5000_ has joined #bitcoin-core-dev
2572019-04-17T14:58:13 *** scoop has quit IRC
2582019-04-17T14:58:46 *** scoop has joined #bitcoin-core-dev
2592019-04-17T14:59:28 *** DougieBot5000 has quit IRC
2602019-04-17T15:03:36 <provoostenator> addresstype=bech32 should indeed affect the GUI, but it merely changes the default checkbox. 1x addresses suggest a different problem.
2612019-04-17T15:04:54 *** scoop has quit IRC
2622019-04-17T15:25:32 *** pinheadmz has joined #bitcoin-core-dev
2632019-04-17T15:32:06 *** jarthur has joined #bitcoin-core-dev
2642019-04-17T15:32:22 <sdaftuar> gmaxwell: i wonder if we should just revert #14897 for 0.18? i would like those changes to go in but i'm nervous about the edge cases we have overlooked thus far, which result in things like tx relay failing en masse and fill-up-your-memory attacks.
2652019-04-17T15:32:26 <gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
2662019-04-17T15:33:45 <sdaftuar> (well, maybe the memory issue is just in the bugfix PR, i need to re-read aj's comment)
2672019-04-17T15:35:27 *** kljasdfvv has quit IRC
2682019-04-17T15:35:41 *** gggggggggggg has joined #bitcoin-core-dev
2692019-04-17T15:41:37 *** bitcoin-git has joined #bitcoin-core-dev
2702019-04-17T15:41:37 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e2b5fdee0068...429a7cf34fa8
2712019-04-17T15:41:38 <bitcoin-git> bitcoin/master fad81d8 MarcoFalke: test: Fixup creatmultisig documentation and whitespace
2722019-04-17T15:41:38 <bitcoin-git> bitcoin/master fab6a0a MarcoFalke: test: Add test that addmultisigaddress fails for watchonly addresses
2732019-04-17T15:41:39 <bitcoin-git> bitcoin/master 429a7cf MarcoFalke: Merge #15831: test: Add test that addmultisigaddress fails for watchonly a...
2742019-04-17T15:41:49 *** bitcoin-git has left #bitcoin-core-dev
2752019-04-17T15:42:23 *** bitcoin-git has joined #bitcoin-core-dev
2762019-04-17T15:42:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15831: test: Add test that addmultisigaddress fails for watchonly addresses (master...1904-testMulti) https://github.com/bitcoin/bitcoin/pull/15831
2772019-04-17T15:42:26 *** bitcoin-git has left #bitcoin-core-dev
2782019-04-17T15:53:03 *** irc_viewer_test has joined #bitcoin-core-dev
2792019-04-17T15:54:26 *** irc_viewer_test has quit IRC
2802019-04-17T15:57:19 *** scoop has joined #bitcoin-core-dev
2812019-04-17T16:01:43 *** scoop has quit IRC
2822019-04-17T16:05:05 *** millerti has joined #bitcoin-core-dev
2832019-04-17T16:12:48 *** scoop has joined #bitcoin-core-dev
2842019-04-17T16:16:55 *** scoop has quit IRC
2852019-04-17T16:19:11 *** davterra has quit IRC
2862019-04-17T16:24:23 *** murrayn_ has joined #bitcoin-core-dev
2872019-04-17T16:27:08 *** bitcoin-git has joined #bitcoin-core-dev
2882019-04-17T16:27:08 <bitcoin-git> [bitcoin] nkostoulas opened pull request #15838: scripts and tools: Fetch missing review comments in github-merge.py (master...2019-04-fix-merge-script) https://github.com/bitcoin/bitcoin/pull/15838
2892019-04-17T16:27:09 *** bitcoin-git has left #bitcoin-core-dev
2902019-04-17T16:27:18 *** jb55 has quit IRC
2912019-04-17T16:27:39 *** murrayn has quit IRC
2922019-04-17T16:29:39 *** jb55 has joined #bitcoin-core-dev
2932019-04-17T16:32:41 *** Dean_Guss has quit IRC
2942019-04-17T16:39:37 *** jb55 has quit IRC
2952019-04-17T16:43:40 *** scoop has joined #bitcoin-core-dev
2962019-04-17T16:44:17 *** EagleTM has joined #bitcoin-core-dev
2972019-04-17T16:48:11 *** scoop has quit IRC
2982019-04-17T16:48:31 *** jeremyrubin has joined #bitcoin-core-dev
2992019-04-17T16:59:25 *** scoop has joined #bitcoin-core-dev
3002019-04-17T17:03:28 *** scoop has quit IRC
3012019-04-17T17:17:32 *** bitcoin-git has joined #bitcoin-core-dev
3022019-04-17T17:17:32 <bitcoin-git> [bitcoin] sdaftuar opened pull request #15839: [0.18] Revert GetData randomization change (#14897) (0.18...2019-04-revert-14897) https://github.com/bitcoin/bitcoin/pull/15839
3032019-04-17T17:17:44 *** bitcoin-git has left #bitcoin-core-dev
3042019-04-17T17:24:19 *** morcos has joined #bitcoin-core-dev
3052019-04-17T17:30:26 *** scoop has joined #bitcoin-core-dev
3062019-04-17T17:31:28 *** dqx_ has joined #bitcoin-core-dev
3072019-04-17T17:34:50 *** scoop has quit IRC
3082019-04-17T17:37:10 *** bitcoin-git has joined #bitcoin-core-dev
3092019-04-17T17:37:10 <bitcoin-git> [bitcoin] abitfan opened pull request #15840: Contrib scripts: Filter IPv6 by ASN (master...dnsseeder) https://github.com/bitcoin/bitcoin/pull/15840
3102019-04-17T17:37:11 *** bitcoin-git has left #bitcoin-core-dev
3112019-04-17T17:40:31 *** hebasto has joined #bitcoin-core-dev
3122019-04-17T17:42:09 *** darosior has quit IRC
3132019-04-17T17:45:57 *** scoop has joined #bitcoin-core-dev
3142019-04-17T17:50:03 *** scoop has quit IRC
3152019-04-17T17:54:12 *** Guyver2 has joined #bitcoin-core-dev
3162019-04-17T17:56:46 *** elichai2 has joined #bitcoin-core-dev
3172019-04-17T18:01:30 *** scoop has joined #bitcoin-core-dev
3182019-04-17T18:12:53 *** hebasto has quit IRC
3192019-04-17T18:33:51 *** scoop has quit IRC
3202019-04-17T18:35:19 *** scoop has joined #bitcoin-core-dev
3212019-04-17T18:41:51 *** owowo has quit IRC
3222019-04-17T18:46:22 <instagibbs> is there a static fully valid pubkey somewhere in the Core codebase to reference in say unit tests?
3232019-04-17T18:46:42 <sipa> use the generator? :)
3242019-04-17T18:46:44 *** owowo has joined #bitcoin-core-dev
3252019-04-17T18:47:08 <instagibbs> "no" is also an acceptable answer
3262019-04-17T18:49:33 <gmaxwell> The generator is a fully valid pubkey...
3272019-04-17T18:50:09 <sipa> 0x0279BE667EF9DCBBAC55A06295CE870B07029BFCDB2DCE28D959F2815B16F81798 FYI :)
3282019-04-17T18:50:22 <sipa> (with secret key 0x0000....00001)
3292019-04-17T18:50:23 <instagibbs> indeed, hence "no", I'll have to make it
3302019-04-17T18:50:38 <sipa> instagibbs: i'm confused
3312019-04-17T18:50:54 <instagibbs> im asking if it's in the core codebase, it's not confusing at all
3322019-04-17T18:50:59 <instagibbs> "make your own" is fine
3332019-04-17T18:51:07 <sipa> sure; it's hardcoded in secp256k1
3342019-04-17T18:51:28 <instagibbs> it's all ok
3352019-04-17T18:51:44 <sipa> ok.
3362019-04-17T18:54:29 *** sdaftuar_ has joined #bitcoin-core-dev
3372019-04-17T18:55:29 <instagibbs> functional test harness has static keys for quick reference when wallet isn't compiled in, was just checking if that existed
3382019-04-17T18:56:20 *** sdaftuar_ has quit IRC
3392019-04-17T18:56:31 *** sdaftuar_ has joined #bitcoin-core-dev
3402019-04-17T18:59:31 *** sdaftuar has left #bitcoin-core-dev
3412019-04-17T19:01:52 *** midnightmagic has quit IRC
3422019-04-17T19:04:19 *** scoop has quit IRC
3432019-04-17T19:06:58 *** sdaftuar_ is now known as sdaftuar
3442019-04-17T19:09:55 <MarcoFalke> instagibbs: ADDRESS_BCRT1_UNSPENDABLE or self.nodes[i].get_deterministic_priv_key().address ?
3452019-04-17T19:12:21 *** captjakk has quit IRC
3462019-04-17T19:13:40 <instagibbs> right I've used those, was just curious about C++ land
3472019-04-17T19:15:22 *** bitcoin-git has joined #bitcoin-core-dev
3482019-04-17T19:15:22 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/429a7cf34fa8...dae72998e857
3492019-04-17T19:15:23 <bitcoin-git> bitcoin/master fa46ac3 MarcoFalke: bench: Add wallet_balance benchmarks
3502019-04-17T19:15:24 <bitcoin-git> bitcoin/master fad7c33 MarcoFalke: refactor: Add handleNotifications method to wallet
3512019-04-17T19:15:24 <bitcoin-git> bitcoin/master dae7299 MarcoFalke: Merge #15779: test: Add wallet_balance benchmark
3522019-04-17T19:15:26 *** bitcoin-git has left #bitcoin-core-dev
3532019-04-17T19:16:12 *** bitcoin-git has joined #bitcoin-core-dev
3542019-04-17T19:16:12 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
3552019-04-17T19:16:25 *** bitcoin-git has left #bitcoin-core-dev
3562019-04-17T19:16:30 <MarcoFalke> instagibbs: ADDRESS_BCRT1_UNSPENDABLE is also in cpp ;)
3572019-04-17T19:16:42 <MarcoFalke> Just merged a second ago
3582019-04-17T19:17:08 <instagibbs> :shakes fist:
3592019-04-17T19:17:17 <instagibbs> thanks
3602019-04-17T19:21:00 *** laptop500 has quit IRC
3612019-04-17T19:26:49 *** bitbee is now known as netcat
3622019-04-17T19:26:53 *** netcat is now known as bitbee
3632019-04-17T19:35:55 *** scoop has joined #bitcoin-core-dev
3642019-04-17T19:40:38 *** scoop has quit IRC
3652019-04-17T19:48:07 *** bitbee has joined #bitcoin-core-dev
3662019-04-17T19:48:37 *** freedomcode has quit IRC
3672019-04-17T19:48:54 *** reardencode has joined #bitcoin-core-dev
3682019-04-17T19:50:32 *** laptop500 has joined #bitcoin-core-dev
3692019-04-17T20:01:20 *** scoop has joined #bitcoin-core-dev
3702019-04-17T20:03:52 *** scoop has quit IRC
3712019-04-17T20:04:22 *** shesek has joined #bitcoin-core-dev
3722019-04-17T20:04:22 *** shesek has joined #bitcoin-core-dev
3732019-04-17T20:04:43 *** scoop has joined #bitcoin-core-dev
3742019-04-17T20:11:32 *** scoop has quit IRC
3752019-04-17T20:12:34 *** darosior has joined #bitcoin-core-dev
3762019-04-17T20:13:45 *** scoop has joined #bitcoin-core-dev
3772019-04-17T20:15:22 *** scoop has quit IRC
3782019-04-17T20:26:20 *** scoop has joined #bitcoin-core-dev
3792019-04-17T20:26:57 *** scoop has quit IRC
3802019-04-17T20:36:51 *** morcos has quit IRC
3812019-04-17T20:37:15 *** morcos has joined #bitcoin-core-dev
3822019-04-17T20:37:40 *** OneFive has joined #bitcoin-core-dev
3832019-04-17T20:40:42 *** justanotheruser has quit IRC
3842019-04-17T20:51:57 * luke-jr wonders if #15617 should be backported
3852019-04-17T20:52:00 <gribble> https://github.com/bitcoin/bitcoin/issues/15617 | p2p: Do not relay banned IP addresses by sipa · Pull Request #15617 · bitcoin/bitcoin · GitHub
3862019-04-17T20:54:04 <gmaxwell> Probably but otoh, backports appear to be a waste of time.
3872019-04-17T20:54:36 <gmaxwell> (beyond the most recent major version)
3882019-04-17T21:01:25 *** bitcoin-git has joined #bitcoin-core-dev
3892019-04-17T21:01:25 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15841: test: append node stderr and stdout if it exists (master...1904-testLogStdErr) https://github.com/bitcoin/bitcoin/pull/15841
3902019-04-17T21:01:38 *** bitcoin-git has left #bitcoin-core-dev
3912019-04-17T21:01:49 <luke-jr> gmaxwell: well, in this case a backport would be to 0.18 ;)
3922019-04-17T21:02:32 <gmaxwell> oh that was supposted to go into 0.18.
3932019-04-17T21:02:37 <gmaxwell> Did it get missed? :-/
3942019-04-17T21:02:47 <luke-jr> oh, nm, I see it there, just didn't get noted on github
3952019-04-17T21:03:20 <luke-jr> ⦠or I just somehow entirely didn't see it :/
3962019-04-17T21:05:10 <instagibbs> MarcoFalke, do we normally close issues when someone opens a related PR? (re 15841)
3972019-04-17T21:05:14 <luke-jr> I guess after reviewing the code, I ended up scrolled past the backport stuff
3982019-04-17T21:05:58 <sipa> 15617 is in 0.18 (commit 238ef336929606632f0564e417ee0b6fd649c2a9)
3992019-04-17T21:07:28 <MarcoFalke> instagibbs: Usually we don't
4002019-04-17T21:08:40 <MarcoFalke> But I close my issues when no one has picked them up, which shows a lack of interest
4012019-04-17T21:09:05 <instagibbs> got it
4022019-04-17T21:24:05 *** ghost43 has joined #bitcoin-core-dev
4032019-04-17T21:24:59 *** darosior has quit IRC
4042019-04-17T21:31:57 *** Guyver2 has quit IRC
4052019-04-17T21:32:21 *** scoop has joined #bitcoin-core-dev
4062019-04-17T21:32:39 *** scoop has quit IRC
4072019-04-17T21:32:46 *** scoop has joined #bitcoin-core-dev
4082019-04-17T21:35:54 *** elichai2 has quit IRC
4092019-04-17T21:41:28 *** DougieBot5000_ is now known as DougieBot5000
4102019-04-17T21:43:23 *** thaumavorio has quit IRC
4112019-04-17T21:43:59 *** jarthur has quit IRC
4122019-04-17T21:44:38 *** thaumavorio has joined #bitcoin-core-dev
4132019-04-17T21:45:04 *** scoop has quit IRC
4142019-04-17T21:47:40 *** scoop has joined #bitcoin-core-dev
4152019-04-17T21:52:08 *** scoop has quit IRC
4162019-04-17T21:59:12 *** OneFive has quit IRC
4172019-04-17T21:59:36 *** OneFive has joined #bitcoin-core-dev
4182019-04-17T22:11:06 *** OneFive has quit IRC
4192019-04-17T22:16:50 *** spinza has quit IRC
4202019-04-17T22:34:00 *** spinza has joined #bitcoin-core-dev
4212019-04-17T22:48:27 *** EagleTM has quit IRC
4222019-04-17T22:51:50 *** dqx_ has quit IRC
4232019-04-17T22:52:37 *** dqx_ has joined #bitcoin-core-dev
4242019-04-17T22:53:09 *** dqx_ has quit IRC
4252019-04-17T22:55:34 *** dqx_ has joined #bitcoin-core-dev
4262019-04-17T23:00:09 *** dqx_ has quit IRC
4272019-04-17T23:03:54 *** scoop has joined #bitcoin-core-dev
4282019-04-17T23:15:12 *** Aaronvan_ is now known as AaronvanW
4292019-04-17T23:27:06 *** laptop500 has quit IRC
4302019-04-17T23:31:03 *** timothy has quit IRC
4312019-04-17T23:51:06 *** AaronvanW has quit IRC