12019-04-24T00:00:02 *** ericbsd1 has quit IRC
22019-04-24T00:00:56 *** udecker has quit IRC
32019-04-24T00:02:01 *** BlueMatt has quit IRC
42019-04-24T00:02:13 *** Aaronvan_ has joined #bitcoin-core-dev
52019-04-24T00:05:02 *** AaronvanW has quit IRC
62019-04-24T00:07:12 *** promag has quit IRC
72019-04-24T00:07:33 *** Cory has quit IRC
82019-04-24T00:15:03 *** DeanGuss has joined #bitcoin-core-dev
92019-04-24T00:15:11 *** phyll1s_work has joined #bitcoin-core-dev
102019-04-24T00:20:04 *** Pasha has joined #bitcoin-core-dev
112019-04-24T00:23:15 *** Pasha is now known as Cory
122019-04-24T00:23:30 *** Jeff1212 has joined #bitcoin-core-dev
132019-04-24T00:35:06 *** scoop has joined #bitcoin-core-dev
142019-04-24T00:39:37 *** scoop has quit IRC
152019-04-24T00:41:55 *** justanotheruser has quit IRC
162019-04-24T00:45:39 *** DeanGuss has quit IRC
172019-04-24T00:57:55 *** justanotheruser has joined #bitcoin-core-dev
182019-04-24T01:03:29 *** tripleslash has quit IRC
192019-04-24T01:09:56 *** lukedashjr has joined #bitcoin-core-dev
202019-04-24T01:09:57 *** luke-jr has quit IRC
212019-04-24T01:12:58 *** lukedashjr has quit IRC
222019-04-24T01:13:01 *** scoop has joined #bitcoin-core-dev
232019-04-24T01:13:17 *** luke-jr has joined #bitcoin-core-dev
242019-04-24T01:17:27 *** Jeff1212 has quit IRC
252019-04-24T01:22:48 *** michagogo has joined #bitcoin-core-dev
262019-04-24T02:03:10 *** Zenton has joined #bitcoin-core-dev
272019-04-24T02:16:25 *** ccdle12 has joined #bitcoin-core-dev
282019-04-24T02:21:26 *** btcquant has joined #bitcoin-core-dev
292019-04-24T02:22:08 *** spaced0ut has quit IRC
302019-04-24T02:30:40 *** scoop has quit IRC
312019-04-24T02:31:22 *** scoop has joined #bitcoin-core-dev
322019-04-24T02:31:28 *** scoop has quit IRC
332019-04-24T02:31:35 *** scoop has joined #bitcoin-core-dev
342019-04-24T02:32:10 *** Victorsueca has joined #bitcoin-core-dev
352019-04-24T02:32:59 *** Victor_sueca has quit IRC
362019-04-24T02:35:25 *** scoop has quit IRC
372019-04-24T02:35:41 *** scoop has joined #bitcoin-core-dev
382019-04-24T02:41:48 *** scoop has quit IRC
392019-04-24T02:42:15 *** scoop has joined #bitcoin-core-dev
402019-04-24T02:42:44 *** scoop has quit IRC
412019-04-24T02:42:52 *** scoop has joined #bitcoin-core-dev
422019-04-24T02:52:31 *** scoop has quit IRC
432019-04-24T02:54:36 *** scoop has joined #bitcoin-core-dev
442019-04-24T02:57:45 *** scoop has quit IRC
452019-04-24T03:00:01 *** phyll1s_work has quit IRC
462019-04-24T03:02:13 *** scoop has joined #bitcoin-core-dev
472019-04-24T03:02:16 *** scoop has quit IRC
482019-04-24T03:02:23 *** scoop has joined #bitcoin-core-dev
492019-04-24T03:04:31 *** scoop has quit IRC
502019-04-24T03:04:58 *** scoop has joined #bitcoin-core-dev
512019-04-24T03:08:41 *** Dieterbe1 has joined #bitcoin-core-dev
522019-04-24T03:09:27 *** scoop has quit IRC
532019-04-24T03:12:54 *** DeanGuss has joined #bitcoin-core-dev
542019-04-24T03:18:34 *** spinza has quit IRC
552019-04-24T03:27:20 *** btcquant has quit IRC
562019-04-24T03:27:55 *** spinza has joined #bitcoin-core-dev
572019-04-24T03:33:39 *** pinheadmz has quit IRC
582019-04-24T03:37:02 *** pinheadmz has joined #bitcoin-core-dev
592019-04-24T03:39:01 *** Cory has quit IRC
602019-04-24T03:43:57 *** Pasha has joined #bitcoin-core-dev
612019-04-24T03:47:09 *** Pasha is now known as Cory
622019-04-24T04:02:58 *** instagibbs has quit IRC
632019-04-24T04:10:27 *** hebasto has joined #bitcoin-core-dev
642019-04-24T04:17:20 *** hebasto has quit IRC
652019-04-24T04:18:11 *** ccdle12 has quit IRC
662019-04-24T04:18:40 *** ccdle12 has joined #bitcoin-core-dev
672019-04-24T05:49:21 *** dqx has quit IRC
682019-04-24T05:51:39 *** teardown has quit IRC
692019-04-24T05:52:25 *** teardown has joined #bitcoin-core-dev
702019-04-24T05:55:14 *** pinheadmz has quit IRC
712019-04-24T06:00:02 *** Dieterbe1 has quit IRC
722019-04-24T06:04:11 *** armin76 has joined #bitcoin-core-dev
732019-04-24T06:04:12 *** jeremyrubin has quit IRC
742019-04-24T06:10:30 *** ccdle12 has joined #bitcoin-core-dev
752019-04-24T06:24:43 *** dqx has joined #bitcoin-core-dev
762019-04-24T06:38:48 *** ElePHPhant has joined #bitcoin-core-dev
772019-04-24T06:39:13 <ElePHPhant> Can somebody please take a look at this question posted in 2014 which still applies today in 2019 for the latest stable Bitcoin Core on Windows? https://bitcoin.stackexchange.com/questions/23999/blocknotify-walletnotify-but-without-the-console-window
782019-04-24T06:39:37 <ElePHPhant> This bug/issue/mistake/whatever-it-is is preventing me from running my Bitcoin payment system properly.
792019-04-24T06:43:00 *** promag has joined #bitcoin-core-dev
802019-04-24T06:44:50 *** promag has quit IRC
812019-04-24T07:07:25 *** promag has joined #bitcoin-core-dev
822019-04-24T07:14:56 *** promag has quit IRC
832019-04-24T07:20:58 *** ccdle12 has quit IRC
842019-04-24T07:36:56 *** csknk has joined #bitcoin-core-dev
852019-04-24T07:40:33 <jonasschnelli> I think wallet notify should finally be replaced with something more flexible...
862019-04-24T07:40:39 <jonasschnelli> #13262 was my attempt
872019-04-24T07:40:42 <gribble> https://github.com/bitcoin/bitcoin/issues/13262 | Wallet/RPC: Add listsincetx method with a stateless (server-side) long polling option by jonasschnelli · Pull Request #13262 · bitcoin/bitcoin · GitHub
882019-04-24T07:41:25 <jonasschnelli> That PR includes a python scripts that demonstrate the push function
892019-04-24T07:41:41 <jonasschnelli> (with pure RPC usage)
902019-04-24T07:42:59 <jonasschnelli> Since its stateless and similar to "listsinceblock",... missing transactions is really hard
912019-04-24T08:21:14 <ElePHPhant> jonasschnelli: Well, I use the notify things purely to know *when* to immediately do the normal polling of data from the API.
922019-04-24T08:21:22 <ElePHPhant> jonasschnelli: It's done regularly anyway.
932019-04-24T08:21:32 <ElePHPhant> jonasschnelli: But those *notify things make it much snappier.
942019-04-24T08:22:06 <ElePHPhant> Must take a walk to avoid going insane.
952019-04-24T08:22:20 <ElePHPhant> Will come back soon.
962019-04-24T08:22:38 *** ElePHPhant has quit IRC
972019-04-24T08:31:24 *** elichai2 has joined #bitcoin-core-dev
982019-04-24T08:38:53 <provoostenator> ElePHPhant jonasschnelli: related #15382 adds boost process as a dependency, which gives us more flexility on how to execute commands.
992019-04-24T08:38:56 <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
1002019-04-24T08:39:36 <provoostenator> The PR lists some alternative dependencies too. Maybe that can solve the Windows thing, but I have no idea.
1012019-04-24T08:39:53 <provoostenator> (I solved all my Windows problems 10+ years ago)
1022019-04-24T08:43:51 *** promag has joined #bitcoin-core-dev
1032019-04-24T08:44:22 <sipa> provoostenator: by not using it anymore?
1042019-04-24T08:44:49 *** ElePHPhant has joined #bitcoin-core-dev
1052019-04-24T08:49:49 <ElePHPhant> Back.
1062019-04-24T08:50:08 <ElePHPhant> jonasschnelli: What happened to your suggestion?
1072019-04-24T08:50:20 <ElePHPhant> jonasschnelli: And will my bug be officially filed somehow now that I've reported it?
1082019-04-24T08:50:58 <sipa> ElePHPhant: not if you don't file it
1092019-04-24T08:51:12 <sipa> https://github.com/bitcoin/bitcoin/issues
1102019-04-24T08:54:10 <sipa> seems there is a fix in that stackexchange answer too; seems like a no-brainer to apply it, but it'll need developing on windows to champion it
1112019-04-24T08:54:28 <sipa> (even if just to know that it works)
1122019-04-24T09:00:02 *** armin76 has quit IRC
1132019-04-24T09:04:04 *** fnichol has joined #bitcoin-core-dev
1142019-04-24T09:15:46 *** scoop has joined #bitcoin-core-dev
1152019-04-24T09:17:05 *** jtimon has joined #bitcoin-core-dev
1162019-04-24T09:20:18 *** scoop has quit IRC
1172019-04-24T09:21:56 <ElePHPhant> sipa: Any chance you could file the issue for me? So it's done right?
1182019-04-24T09:38:35 *** queip has quit IRC
1192019-04-24T09:39:05 *** phwalkr has joined #bitcoin-core-dev
1202019-04-24T09:39:48 *** rafalcpp has quit IRC
1212019-04-24T09:39:53 *** rafalcpp_ has joined #bitcoin-core-dev
1222019-04-24T09:51:37 *** rafalcpp has joined #bitcoin-core-dev
1232019-04-24T09:52:34 *** rafalcpp_ has quit IRC
1242019-04-24T09:56:02 *** meshcoll- has quit IRC
1252019-04-24T09:56:56 *** meshcollider has joined #bitcoin-core-dev
1262019-04-24T09:59:27 *** rafalcpp_ has joined #bitcoin-core-dev
1272019-04-24T09:59:46 *** rafalcpp has quit IRC
1282019-04-24T10:05:23 *** phwalkr has quit IRC
1292019-04-24T10:05:57 *** queip has joined #bitcoin-core-dev
1302019-04-24T10:16:13 *** DeanGuss has quit IRC
1312019-04-24T10:16:26 *** DeanGuss has joined #bitcoin-core-dev
1322019-04-24T10:28:22 *** promag has quit IRC
1332019-04-24T10:31:31 *** promag has joined #bitcoin-core-dev
1342019-04-24T10:32:37 *** promag_ has joined #bitcoin-core-dev
1352019-04-24T10:32:37 *** promag has quit IRC
1362019-04-24T10:45:35 *** spinza has quit IRC
1372019-04-24T11:01:25 *** spinza has joined #bitcoin-core-dev
1382019-04-24T11:07:20 *** ccdle12 has joined #bitcoin-core-dev
1392019-04-24T11:15:50 *** AaronvanW has joined #bitcoin-core-dev
1402019-04-24T11:53:00 *** jtimon has quit IRC
1412019-04-24T11:55:06 *** needhelpplz has joined #bitcoin-core-dev
1422019-04-24T11:59:02 *** Guyver2 has joined #bitcoin-core-dev
1432019-04-24T12:00:02 *** fnichol has quit IRC
1442019-04-24T12:02:54 *** promag_ has quit IRC
1452019-04-24T12:03:19 *** promag has joined #bitcoin-core-dev
1462019-04-24T12:05:03 *** MarconM has joined #bitcoin-core-dev
1472019-04-24T12:05:08 *** bitcoin-git has joined #bitcoin-core-dev
1482019-04-24T12:05:08 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15868: rpc: Add have_pruned to getblockchaininfo (master...1904-rpcPruned) https://github.com/bitcoin/bitcoin/pull/15868
1492019-04-24T12:05:09 *** bitcoin-git has left #bitcoin-core-dev
1502019-04-24T12:05:24 <ElePHPhant> Sigh... I guess not...
1512019-04-24T12:14:47 <ElePHPhant> I created an issue myself now...
1522019-04-24T12:29:38 *** promag has quit IRC
1532019-04-24T12:35:27 *** scoop has joined #bitcoin-core-dev
1542019-04-24T12:39:48 *** scoop has quit IRC
1552019-04-24T12:40:56 *** setpill has joined #bitcoin-core-dev
1562019-04-24T12:45:16 *** instagibbs has joined #bitcoin-core-dev
1572019-04-24T13:01:57 *** promag has joined #bitcoin-core-dev
1582019-04-24T13:06:21 *** promag has quit IRC
1592019-04-24T13:25:53 *** promag has joined #bitcoin-core-dev
1602019-04-24T13:29:19 *** spinza has quit IRC
1612019-04-24T13:46:40 *** promag has quit IRC
1622019-04-24T13:48:10 *** promag has joined #bitcoin-core-dev
1632019-04-24T13:48:55 *** promag has joined #bitcoin-core-dev
1642019-04-24T13:50:47 *** spinza has joined #bitcoin-core-dev
1652019-04-24T13:53:26 *** scoop has joined #bitcoin-core-dev
1662019-04-24T13:53:30 *** promag has quit IRC
1672019-04-24T13:54:14 *** spaced0ut has joined #bitcoin-core-dev
1682019-04-24T14:10:01 *** afk11 has quit IRC
1692019-04-24T14:17:59 <waxwing> can i ask what the "traditional partial signatures format" referred to on this line is? https://github.com/bitcoin/bitcoin/blob/master/src/script/sign.h#L131
1702019-04-24T14:19:36 *** promag has joined #bitcoin-core-dev
1712019-04-24T14:19:55 *** promag_ has joined #bitcoin-core-dev
1722019-04-24T14:22:21 *** promag has quit IRC
1732019-04-24T14:22:42 *** luke-jr has quit IRC
1742019-04-24T14:22:50 *** lukedashjr has joined #bitcoin-core-dev
1752019-04-24T14:22:55 *** promag has joined #bitcoin-core-dev
1762019-04-24T14:25:22 *** bralyclow has joined #bitcoin-core-dev
1772019-04-24T14:25:30 *** promag has quit IRC
1782019-04-24T14:26:08 *** scoop has quit IRC
1792019-04-24T14:27:37 *** lukedashjr is now known as luke-jr
1802019-04-24T14:29:33 *** luke-jr has quit IRC
1812019-04-24T14:30:01 *** luke-jr has joined #bitcoin-core-dev
1822019-04-24T14:34:16 *** promag has joined #bitcoin-core-dev
1832019-04-24T14:36:06 *** promag has quit IRC
1842019-04-24T14:37:30 *** ElePHPhant has quit IRC
1852019-04-24T14:40:16 *** scoop has joined #bitcoin-core-dev
1862019-04-24T14:40:48 <cfields> wumpus: fyi, I'll be away and unable to sign releases Friday-Tuesday. Headed to Boston to sign the docs for our new place there :)
1872019-04-24T14:42:53 <instagibbs> anyone know why data carrier outputs have to be push-only in relay policy?
1882019-04-24T14:43:18 *** bralyclow has quit IRC
1892019-04-24T14:43:19 <instagibbs> seems wasteful for no reason
1902019-04-24T14:43:20 <harding> waxwing: I think it's just talking about when you have fewer than the needed number of signatures. E.g., you need 2 signatures but you call signrawtransactionwithprivatekey (or whatever untweetable name it has) with only one key. You'll get your input transaction returned back to you with the push of just that single signature in it and an "incomplete" flag in a separate field.
1912019-04-24T14:44:09 <harding> waxwing: I don't think it means partial in the sense of less-than-one signatures.
1922019-04-24T14:47:07 *** scoop has quit IRC
1932019-04-24T14:48:36 <harding> instagibbs: maybe to avoid people putting CHECKSIG-type opcodes in there that would count towards the block's sigop limit even though we know they'd never be evaluated (and that counting sigops in scriptPubKeys is wrong)?
1942019-04-24T14:49:01 <instagibbs> harding, ehhh just count those then :) (good point regardless)
1952019-04-24T14:49:40 <instagibbs> it would also mess with the "virtual size" right?
1962019-04-24T14:51:01 *** lukedashjr has joined #bitcoin-core-dev
1972019-04-24T14:53:18 *** setpill has quit IRC
1982019-04-24T14:53:48 *** luke-jr has quit IRC
1992019-04-24T14:55:31 *** lukedashjr is now known as luke-jr
2002019-04-24T14:58:05 <waxwing> harding, makes sense thanks. i always end up looking up the difference between witnessscript and scriptwitness hence i end up there, the question was only tangential :)
2012019-04-24T14:58:08 *** scoop has joined #bitcoin-core-dev
2022019-04-24T14:59:32 *** scoop has quit IRC
2032019-04-24T15:00:02 *** MarconM has quit IRC
2042019-04-24T15:00:18 *** scoop has joined #bitcoin-core-dev
2052019-04-24T15:01:55 *** luke-jr has quit IRC
2062019-04-24T15:02:16 *** luke-jr has joined #bitcoin-core-dev
2072019-04-24T15:03:13 *** kees1 has joined #bitcoin-core-dev
2082019-04-24T15:04:48 *** scoop has quit IRC
2092019-04-24T15:06:11 *** promag_ has quit IRC
2102019-04-24T15:16:38 *** scoop has joined #bitcoin-core-dev
2112019-04-24T15:20:21 *** bitcoin-git has joined #bitcoin-core-dev
2122019-04-24T15:20:21 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15858: Faster tests with topological mempool rpc sync ð (master...1904-qaSync) https://github.com/bitcoin/bitcoin/pull/15858
2132019-04-24T15:20:22 *** bitcoin-git has left #bitcoin-core-dev
2142019-04-24T15:21:51 *** scoop has quit IRC
2152019-04-24T15:26:47 *** scoop has joined #bitcoin-core-dev
2162019-04-24T15:27:35 *** scoop has quit IRC
2172019-04-24T15:38:42 *** luke-jr has quit IRC
2182019-04-24T15:38:58 *** Aaronvan_ has joined #bitcoin-core-dev
2192019-04-24T15:42:07 *** AaronvanW has quit IRC
2202019-04-24T15:48:25 *** scoop has joined #bitcoin-core-dev
2212019-04-24T15:49:25 *** AaronvanW has joined #bitcoin-core-dev
2222019-04-24T15:52:14 *** jarthur has joined #bitcoin-core-dev
2232019-04-24T15:52:32 *** Aaronvan_ has quit IRC
2242019-04-24T15:56:30 *** scoop has quit IRC
2252019-04-24T15:59:19 *** luke-jr has joined #bitcoin-core-dev
2262019-04-24T15:59:56 *** pinheadmz has joined #bitcoin-core-dev
2272019-04-24T16:14:57 *** ccdle12 has quit IRC
2282019-04-24T16:17:00 *** ccdle12 has joined #bitcoin-core-dev
2292019-04-24T16:21:02 *** jarthur has quit IRC
2302019-04-24T16:21:36 *** ccdle12 has quit IRC
2312019-04-24T16:25:13 *** Aaronvan_ has joined #bitcoin-core-dev
2322019-04-24T16:27:28 *** scoop has joined #bitcoin-core-dev
2332019-04-24T16:27:39 *** AaronvanW has quit IRC
2342019-04-24T16:28:14 *** jarthur has joined #bitcoin-core-dev
2352019-04-24T16:32:58 *** jarthur has quit IRC
2362019-04-24T16:35:22 *** scoop has quit IRC
2372019-04-24T16:44:36 *** scoop has joined #bitcoin-core-dev
2382019-04-24T16:45:57 *** jarthur has joined #bitcoin-core-dev
2392019-04-24T16:48:48 *** scoop has quit IRC
2402019-04-24T16:51:21 *** scoop has joined #bitcoin-core-dev
2412019-04-24T16:52:53 *** brianhoffman_ has joined #bitcoin-core-dev
2422019-04-24T16:55:24 *** brianhoffman has quit IRC
2432019-04-24T16:55:25 *** brianhoffman_ is now known as brianhoffman
2442019-04-24T16:56:42 *** scoop has quit IRC
2452019-04-24T16:57:30 *** promag has joined #bitcoin-core-dev
2462019-04-24T16:58:57 *** promag_ has joined #bitcoin-core-dev
2472019-04-24T17:01:48 *** promag has quit IRC
2482019-04-24T17:03:33 *** promag_ has quit IRC
2492019-04-24T17:10:10 *** owowo has quit IRC
2502019-04-24T17:11:22 *** owowo has joined #bitcoin-core-dev
2512019-04-24T17:18:48 *** promag has joined #bitcoin-core-dev
2522019-04-24T17:24:23 *** scoop has joined #bitcoin-core-dev
2532019-04-24T17:25:42 *** elichai2 has quit IRC
2542019-04-24T17:28:57 *** scoop has quit IRC
2552019-04-24T17:30:40 <dongcarl> w/re #15717, I wish to stop confusing the poor man. I think we should make it a shared library dependency just as we do with `miniupnp`, in that case, we should not submit any more reviews on the subtree-d code which should be removed and make it clear that we really need is another depends package.
2562019-04-24T17:30:42 <gribble> https://github.com/bitcoin/bitcoin/issues/15717 | Changes to support NAT-PMP by MishraShivendra · Pull Request #15717 · bitcoin/bitcoin · GitHub
2572019-04-24T17:32:33 <dongcarl> My reading of #11902 was that we'll keep uPNP as an option that's off by default, and introduce NAT-PMP as ON by default, which I'm not sure how I feel about. wumpus perhaps you can enlighten me?
2582019-04-24T17:32:35 <gribble> https://github.com/bitcoin/bitcoin/issues/11902 | NAT-PMP port forwarding support · Issue #11902 · bitcoin/bitcoin · GitHub
2592019-04-24T17:35:28 <gmaxwell> dongcarl: do you think wumpus is your shrink? you appear to be asking him to advise you on your feelings. :)
2602019-04-24T17:36:54 <dongcarl> Hahahaha well... I guess more concretely I'm asking for any info I might be missing :-)
2612019-04-24T17:36:58 <gmaxwell> miniupnp library is a security disaster-- adhoc xml parsing using lulzical pointer frobbing, nothing has changed about that AFAIK.
2622019-04-24T17:37:24 * dongcarl adds lulzical pointer frobber to his list of insults
2632019-04-24T17:38:20 <gmaxwell> And thats pretty bad since by its very nature its exposed to untrustworthy network inputs ... So we're unwilling to enable it by default because it continues to look like a timebomb.
2642019-04-24T17:38:36 <dongcarl> that makes sense for sure
2652019-04-24T17:39:06 *** scoop has joined #bitcoin-core-dev
2662019-04-24T17:40:20 <gmaxwell> (Ideally we'd replace the library with something that isn't so terror inducing, but at least when we looked before there wasn't anything.. in part because upnp is an awful spec...)
2672019-04-24T17:40:52 <dongcarl> So given that NAT-PMP is a much simpler protocol that's harder to footgun, we can enable it by default, because if someone's got a NAT-PMP server on their gateway they're most likely okay with auto-port forwarding?
2682019-04-24T17:43:48 *** scoop has quit IRC
2692019-04-24T17:46:22 *** hebasto has joined #bitcoin-core-dev
2702019-04-24T17:51:19 *** DeanGuss has quit IRC
2712019-04-24T17:58:06 *** jannes has joined #bitcoin-core-dev
2722019-04-24T18:00:01 *** kees1 has quit IRC
2732019-04-24T18:04:30 *** promag has quit IRC
2742019-04-24T18:05:25 <gmaxwell> dongcarl: the on/off by default dosn't have anything to do with being okay with port forwarding.
2752019-04-24T18:05:58 <gmaxwell> It's entirely because of the multiple past RCE bugs in that particular library and the codebase that looks like it'll have more in the future.
2762019-04-24T18:07:59 *** scoop has joined #bitcoin-core-dev
2772019-04-24T18:08:44 *** kerbyu has joined #bitcoin-core-dev
2782019-04-24T18:09:24 *** scoop has quit IRC
2792019-04-24T18:09:58 *** scoop has joined #bitcoin-core-dev
2802019-04-24T18:14:57 *** scoop has quit IRC
2812019-04-24T18:29:16 *** promag has joined #bitcoin-core-dev
2822019-04-24T18:32:30 *** BlueMatt has joined #bitcoin-core-dev
2832019-04-24T18:34:35 *** promag has quit IRC
2842019-04-24T18:39:34 *** promag has joined #bitcoin-core-dev
2852019-04-24T18:40:32 *** scoop has joined #bitcoin-core-dev
2862019-04-24T18:43:12 *** promag has quit IRC
2872019-04-24T18:43:13 *** dbcx has joined #bitcoin-core-dev
2882019-04-24T18:45:13 *** scoop has quit IRC
2892019-04-24T18:54:36 *** needhelpplz has quit IRC
2902019-04-24T19:02:00 *** lnostdal has quit IRC
2912019-04-24T19:24:07 *** scoop has joined #bitcoin-core-dev
2922019-04-24T19:36:15 *** promag has joined #bitcoin-core-dev
2932019-04-24T19:37:07 <dongcarl> gmaxwell: Okay, so should NAT-PMP be on by default or no?
2942019-04-24T20:10:17 *** scoop has quit IRC
2952019-04-24T20:13:12 *** BlueMatt has quit IRC
2962019-04-24T20:14:09 <gmaxwell> Yes
2972019-04-24T20:15:53 <gmaxwell> dongcarl: it should be on by default, unless turned off-- and solf-set off by discover being off (either directly off, or indirectly off via listen off)
2982019-04-24T20:15:59 *** promag has quit IRC
2992019-04-24T20:25:53 *** pinheadmz has quit IRC
3002019-04-24T20:27:35 *** DeanGuss has joined #bitcoin-core-dev
3012019-04-24T20:29:34 <dongcarl> gmaxwell: Roger
3022019-04-24T20:29:55 *** csknk has quit IRC
3032019-04-24T20:30:14 *** pinheadmz has joined #bitcoin-core-dev
3042019-04-24T20:32:26 *** Guyver2 has quit IRC
3052019-04-24T20:35:48 *** scoop has joined #bitcoin-core-dev
3062019-04-24T20:35:59 <gmaxwell> soft*
3072019-04-24T20:37:19 *** owowo has quit IRC
3082019-04-24T20:40:37 *** scoop has quit IRC
3092019-04-24T20:41:18 *** scoop has joined #bitcoin-core-dev
3102019-04-24T20:43:10 *** jaybny has joined #bitcoin-core-dev
3112019-04-24T20:43:42 *** owowo has joined #bitcoin-core-dev
3122019-04-24T20:45:58 *** scoop has quit IRC
3132019-04-24T20:49:03 *** bitcoin-git has joined #bitcoin-core-dev
3142019-04-24T20:49:04 <bitcoin-git> [bitcoin] hebasto opened pull request #15886: qt, wallet: Revamp SendConfirmationDialog (master...20190424-send-confirmation-dialog) https://github.com/bitcoin/bitcoin/pull/15886
3152019-04-24T20:49:05 *** bitcoin-git has left #bitcoin-core-dev
3162019-04-24T20:49:20 *** scoop has joined #bitcoin-core-dev
3172019-04-24T20:53:02 *** jaybny has left #bitcoin-core-dev
3182019-04-24T20:53:19 *** jannes has quit IRC
3192019-04-24T20:56:59 *** jaybny has joined #bitcoin-core-dev
3202019-04-24T20:58:05 *** promag has joined #bitcoin-core-dev
3212019-04-24T21:00:02 *** kerbyu has quit IRC
3222019-04-24T21:02:07 *** promag has quit IRC
3232019-04-24T21:03:02 *** AaronvanW has joined #bitcoin-core-dev
3242019-04-24T21:05:54 *** Aaronvan_ has quit IRC
3252019-04-24T21:11:21 *** UltimateNate has joined #bitcoin-core-dev
3262019-04-24T21:22:19 *** promag has joined #bitcoin-core-dev
3272019-04-24T21:24:19 *** bitcoin-git has joined #bitcoin-core-dev
3282019-04-24T21:24:19 <bitcoin-git> [bitcoin] hebasto opened pull request #15887: docs: Align code example style with clang-format (master...20190424-coding-style) https://github.com/bitcoin/bitcoin/pull/15887
3292019-04-24T21:24:32 *** bitcoin-git has left #bitcoin-core-dev
3302019-04-24T21:34:54 *** scoop has quit IRC
3312019-04-24T21:35:21 *** scoop has joined #bitcoin-core-dev
3322019-04-24T21:39:17 *** hebasto has quit IRC
3332019-04-24T21:39:36 *** scoop has quit IRC
3342019-04-24T21:59:55 *** jarthur has quit IRC
3352019-04-24T22:01:01 *** spinza has quit IRC
3362019-04-24T22:01:34 *** jb55 has quit IRC
3372019-04-24T22:07:35 *** cazyjoker96 has joined #bitcoin-core-dev
3382019-04-24T22:13:46 *** scoop has joined #bitcoin-core-dev
3392019-04-24T22:14:15 *** DeanGuss has quit IRC
3402019-04-24T22:19:37 *** davec has quit IRC
3412019-04-24T22:20:47 *** spinza has joined #bitcoin-core-dev
3422019-04-24T22:21:48 *** davec has joined #bitcoin-core-dev
3432019-04-24T22:27:54 *** Aaronvan_ has joined #bitcoin-core-dev
3442019-04-24T22:28:42 *** jb55 has joined #bitcoin-core-dev
3452019-04-24T22:31:18 *** AaronvanW has quit IRC
3462019-04-24T22:42:15 *** promag_ has joined #bitcoin-core-dev
3472019-04-24T22:58:01 *** promag has quit IRC
3482019-04-24T22:58:25 *** promag has joined #bitcoin-core-dev
3492019-04-24T23:00:51 *** promag has quit IRC
3502019-04-24T23:33:31 *** davec has quit IRC
3512019-04-24T23:34:57 *** davec has joined #bitcoin-core-dev
3522019-04-24T23:36:56 *** shesek has quit IRC
3532019-04-24T23:38:11 *** afk11 has joined #bitcoin-core-dev
3542019-04-24T23:39:16 *** afk11 has joined #bitcoin-core-dev
3552019-04-24T23:42:40 *** afk11 has quit IRC
3562019-04-24T23:50:05 *** shesek has joined #bitcoin-core-dev
3572019-04-24T23:50:05 *** shesek has joined #bitcoin-core-dev
3582019-04-24T23:58:05 *** dviola has joined #bitcoin-core-dev
3592019-04-24T23:58:13 *** shesek has quit IRC