12019-05-02T00:00:02 *** paolo|out has quit IRC
22019-05-02T00:04:10 *** Guest42 has quit IRC
32019-05-02T00:11:08 *** Guest42 has joined #bitcoin-core-dev
42019-05-02T00:13:27 *** Randolf has joined #bitcoin-core-dev
52019-05-02T00:27:16 *** AaronvanW has quit IRC
62019-05-02T00:28:21 *** ddustin has quit IRC
72019-05-02T00:29:01 *** ddustin has joined #bitcoin-core-dev
82019-05-02T00:33:32 *** ddustin has quit IRC
92019-05-02T00:34:28 *** scoop has joined #bitcoin-core-dev
102019-05-02T00:39:10 *** scoop has quit IRC
112019-05-02T00:43:38 *** justanotheruser has quit IRC
122019-05-02T00:44:10 *** scoop has joined #bitcoin-core-dev
132019-05-02T00:44:38 *** promag_ has joined #bitcoin-core-dev
142019-05-02T00:52:40 *** scoop has quit IRC
152019-05-02T00:54:01 *** scoop has joined #bitcoin-core-dev
162019-05-02T00:56:53 *** promag_ has quit IRC
172019-05-02T00:58:36 *** justanotheruser has joined #bitcoin-core-dev
182019-05-02T00:59:27 *** bralyclow has joined #bitcoin-core-dev
192019-05-02T01:04:13 *** jtimon has quit IRC
202019-05-02T01:13:11 *** michagogo has quit IRC
212019-05-02T01:23:29 *** scoop has quit IRC
222019-05-02T01:23:52 *** Jackielove4u has quit IRC
232019-05-02T01:26:44 *** MrPaz has quit IRC
242019-05-02T01:26:47 *** scoop has joined #bitcoin-core-dev
252019-05-02T01:28:47 *** bosma has quit IRC
262019-05-02T01:33:07 *** valwal_ has quit IRC
272019-05-02T01:37:06 *** scoop has quit IRC
282019-05-02T01:39:37 *** scoop has joined #bitcoin-core-dev
292019-05-02T01:39:38 *** bosma has joined #bitcoin-core-dev
302019-05-02T01:41:12 *** cepinheiro has joined #bitcoin-core-dev
312019-05-02T01:41:34 *** bosma has quit IRC
322019-05-02T01:47:47 *** bosma has joined #bitcoin-core-dev
332019-05-02T01:49:40 *** valwal_ has joined #bitcoin-core-dev
342019-05-02T01:53:00 *** Jackielove4u has joined #bitcoin-core-dev
352019-05-02T02:02:21 *** cepinheiro has quit IRC
362019-05-02T02:02:58 *** cepinheiro has joined #bitcoin-core-dev
372019-05-02T02:08:48 *** wpaulino has joined #bitcoin-core-dev
382019-05-02T02:15:48 *** cubancorona has quit IRC
392019-05-02T02:16:13 *** cubancorona has joined #bitcoin-core-dev
402019-05-02T02:19:28 <wpaulino> > The replacement transaction pays an absolute fee of at least the sum paid by the original transactions.
412019-05-02T02:19:59 <wpaulino> looking at bip 125, in the case of multiple replacements, is âoriginal transactionsâ meant to just be the previous replacement with its descendants (if any)?
422019-05-02T02:25:48 <wpaulino> double checking with the validation code, that seems to be the case. just want to make sure tho as the wording is kinda weird
432019-05-02T02:26:42 <luke-jr> wpaulino: any and all transactions the new one conflicts with
442019-05-02T02:27:14 <luke-jr> so if the new one has two inputs conflicting with two different and unrelated transactions, it includes both of them and all their descendents
452019-05-02T02:27:46 <luke-jr> potentially conflicts could be huge, but I think there's a limit to what we process
462019-05-02T02:30:07 <wpaulino> luke-jr: gotcha, thanks
472019-05-02T02:49:18 <phantomcircuit> luke-jr, nope they're actually separate buffers
482019-05-02T02:49:32 <phantomcircuit> somethings just happen to map to both
492019-05-02T02:52:32 <luke-jr> phantomcircuit: ?
502019-05-02T02:52:37 <luke-jr> oh
512019-05-02T02:52:59 <luke-jr> phantomcircuit: but terminal programs don't have their own clipboardsâ¦
522019-05-02T02:53:06 <luke-jr> they use the same ones every other program does
532019-05-02T03:02:22 <phantomcircuit> luke-jr, actually they don't by default, they're just virtually universally configured to copy into both the "primary" and "clipboard"
542019-05-02T03:06:07 <luke-jr> phantomcircuit: QClipboard doesn't even support 4 clipboards, so what you're claiming is extremely unlikely
552019-05-02T03:06:48 <luke-jr> and the 3rd one is only supported on macOS
562019-05-02T03:06:57 <phantomcircuit> luke-jr, see xclip
572019-05-02T03:07:05 <luke-jr> bash: xclip: command not found
582019-05-02T03:07:34 <luke-jr> phantomcircuit: ancient terminals nobody uses != all or normal terminals
592019-05-02T03:11:53 *** Eagle[TM] has joined #bitcoin-core-dev
602019-05-02T03:12:44 *** scoop has quit IRC
612019-05-02T03:13:22 *** Guest42 has quit IRC
622019-05-02T03:13:48 *** EagleTM has quit IRC
632019-05-02T03:22:08 *** bralyclow2 has joined #bitcoin-core-dev
642019-05-02T03:22:21 *** cubancorona has quit IRC
652019-05-02T03:22:41 *** cubancorona has joined #bitcoin-core-dev
662019-05-02T03:29:44 *** cubancorona has quit IRC
672019-05-02T03:30:05 *** cubancorona has joined #bitcoin-core-dev
682019-05-02T03:30:59 *** bralyclow2 has quit IRC
692019-05-02T03:36:09 *** davterra has joined #bitcoin-core-dev
702019-05-02T03:50:00 *** scoop_ has joined #bitcoin-core-dev
712019-05-02T03:57:53 *** bralyclow has quit IRC
722019-05-02T03:59:00 *** bralyclow has joined #bitcoin-core-dev
732019-05-02T04:14:44 *** scoop_ has quit IRC
742019-05-02T04:27:16 *** cubancorona has quit IRC
752019-05-02T04:27:38 *** cubancorona has joined #bitcoin-core-dev
762019-05-02T04:30:02 *** bralyclow has quit IRC
772019-05-02T04:30:24 *** bralyclow has joined #bitcoin-core-dev
782019-05-02T04:37:49 <wumpus> luke-jr: they could go in separate files IMO
792019-05-02T04:38:33 <wumpus> luke-jr: the usual qt convention seems to be one file pair = one class, which makes it easy to find where a class lives, so makes a sensible default unless you're dealing with lots of small classes
802019-05-02T04:41:46 <luke-jr> fair enough
812019-05-02T04:47:58 *** justanotheruser has quit IRC
822019-05-02T04:55:14 *** DeanGuss has joined #bitcoin-core-dev
832019-05-02T04:58:46 <fanquake> 4x signed sigs for v0.18.0 so far.
842019-05-02T04:59:52 *** cubancorona has quit IRC
852019-05-02T05:00:14 *** cubancorona has joined #bitcoin-core-dev
862019-05-02T05:04:55 *** bralyclow has quit IRC
872019-05-02T05:05:19 *** bralyclow has joined #bitcoin-core-dev
882019-05-02T05:10:03 *** bralyclow has quit IRC
892019-05-02T05:27:55 *** spaced0ut has quit IRC
902019-05-02T05:46:23 *** murrayn_ has quit IRC
912019-05-02T05:46:42 *** murrayn has joined #bitcoin-core-dev
922019-05-02T05:46:42 *** murrayn has joined #bitcoin-core-dev
932019-05-02T06:15:08 *** jarthur has joined #bitcoin-core-dev
942019-05-02T06:15:11 *** scoop has joined #bitcoin-core-dev
952019-05-02T06:19:38 *** scoop has quit IRC
962019-05-02T06:26:35 *** bitcoin-git has joined #bitcoin-core-dev
972019-05-02T06:26:35 <bitcoin-git> [bitcoin] practicalswift opened pull request #15938: Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp (master...psbt-return-type-warning) https://github.com/bitcoin/bitcoin/pull/15938
982019-05-02T06:26:39 *** bitcoin-git has left #bitcoin-core-dev
992019-05-02T06:27:04 *** Eagle[TM] has quit IRC
1002019-05-02T06:33:25 <wumpus> fanquake: goign fast
1012019-05-02T06:39:20 <luke-jr> now if only more of them would build Knots too ;)
1022019-05-02T07:17:24 <wumpus> no problem, which repo/tag is that?
1032019-05-02T07:20:46 <luke-jr> wumpus: will announce here when tagged, thanks ⺠(probably an hour or so)
1042019-05-02T07:23:51 *** zakk has joined #bitcoin-core-dev
1052019-05-02T07:29:36 <luke-jr> hrm, Launchpad is timing out trying to get PPA download counts for Core - hopefully it will get fixed before Matt pushes 0.18 XD
1062019-05-02T07:46:24 *** ccdle12 has joined #bitcoin-core-dev
1072019-05-02T07:46:49 *** laptop_ has joined #bitcoin-core-dev
1082019-05-02T07:51:36 *** Randolf has quit IRC
1092019-05-02T07:52:00 *** Randolf has joined #bitcoin-core-dev
1102019-05-02T07:53:48 *** ccdle12 has quit IRC
1112019-05-02T08:00:03 *** DeanGuss has quit IRC
1122019-05-02T08:00:10 *** RandolfR has joined #bitcoin-core-dev
1132019-05-02T08:02:28 *** Randolf has quit IRC
1142019-05-02T08:13:42 *** Guest42 has joined #bitcoin-core-dev
1152019-05-02T08:16:38 <luke-jr> hmm
1162019-05-02T08:16:49 <luke-jr> the big "Download Bitcoin Core" button on the website links ot the non-existent win32 :/
1172019-05-02T08:17:16 *** cepinheiro has quit IRC
1182019-05-02T08:17:32 <luke-jr> wumpus: can you fix that quickly? otherwise it may skew our goal of finding out who cares
1192019-05-02T08:17:42 *** cepinheiro has joined #bitcoin-core-dev
1202019-05-02T08:17:48 <luke-jr> (ie, people may care that the default doesn't work, even if they don't necessarily care about win32 specifically)
1212019-05-02T08:18:04 <wumpus> I don't really know how to do website stuff
1222019-05-02T08:18:14 <wumpus> surprised anyone's default would be win32 though
1232019-05-02T08:18:25 <wumpus> ping @ harding
1242019-05-02T08:20:04 <luke-jr> probably just need to change win32exe to win64exe on line 21
1252019-05-02T08:20:11 <luke-jr> of _includes/templates/download.html
1262019-05-02T08:21:09 <wumpus> so this means *everyone* with windows was suggested the 32-bit download? ouch
1272019-05-02T08:21:10 <wumpus> will change
1282019-05-02T08:21:34 <gmaxwell> ugh
1292019-05-02T08:21:51 <luke-jr> wumpus: does it try to detect even? I got that link on Linux
1302019-05-02T08:22:06 <luke-jr> looks like it's a win32 link for everyone
1312019-05-02T08:22:26 <wumpus> it used to detect, maybe no more
1322019-05-02T08:23:02 <gmaxwell> maybe it correctly detects 64 bits on win64 but elsewhere just does 32bits?
1332019-05-02T08:23:13 <luke-jr> gmaxwell: i don't see any conditional logic
1342019-05-02T08:23:24 <luke-jr> bet it was lost with bitcoin.org -> bitcoincore.org
1352019-05-02T08:23:36 *** setpill has joined #bitcoin-core-dev
1362019-05-02T08:24:06 <wumpus> https://github.com/bitcoin-core/bitcoincore.org/pull/650
1372019-05-02T08:24:58 <wumpus> luke-jr: oh good point, I guess the bitcoin.org PR will fail because it's missing the 32-bit windows files
1382019-05-02T08:28:12 <luke-jr> bitcoin.org indeed has OS detection Javascript
1392019-05-02T08:28:22 *** ossifrage has quit IRC
1402019-05-02T08:28:26 *** promag_ has joined #bitcoin-core-dev
1412019-05-02T08:37:32 *** jarthur has quit IRC
1422019-05-02T08:40:49 *** ossifrage has joined #bitcoin-core-dev
1432019-05-02T08:40:58 *** promag_ has quit IRC
1442019-05-02T08:41:18 *** promag_ has joined #bitcoin-core-dev
1452019-05-02T08:56:32 *** Guyver2 has joined #bitcoin-core-dev
1462019-05-02T09:00:02 *** zakk has quit IRC
1472019-05-02T09:03:43 *** timothy has joined #bitcoin-core-dev
1482019-05-02T09:20:34 *** miyamofigo_ has joined #bitcoin-core-dev
1492019-05-02T09:21:33 <luke-jr> wumpus: nevermind, it'll be a while. something broke with the power64 gitian builds :/
1502019-05-02T09:22:42 *** miyamofigo_ has quit IRC
1512019-05-02T09:41:12 <luke-jr> apparently a bug with Ubuntu's GCC 8 for older ppc64
1522019-05-02T09:41:25 * luke-jr ponders whether to bump up the ppc64 -mcpu, or drop to GCC 7
1532019-05-02T09:53:53 <wumpus> bumping the cpu sounds better, at least if it's still suppported on the TALOS
1542019-05-02T09:54:34 <luke-jr> yeah, it needs power7 for __float128, which glibcxx's headers assume is available
1552019-05-02T09:55:07 *** promag_ has quit IRC
1562019-05-02T09:56:13 <gmaxwell> forcing down to older power probably hurts performance in any case, is anyone running this on anything less than power9?
1572019-05-02T09:57:55 <luke-jr> gmaxwell: awilfox was pushing for 970 (G5)
1582019-05-02T09:58:20 <luke-jr> gmaxwell: and ironically, it performs better on POWER9 with an older target, than if targetting power9
1592019-05-02T09:59:28 <wumpus> that's interesting
1602019-05-02T10:00:14 *** jonatack has joined #bitcoin-core-dev
1612019-05-02T10:00:28 <wumpus> FWIW I'm surprised how good recent gcc's risc-v code generation is, it took ages to get to that level for ARM, for a long time it did kind of dumb things like juggle results between registers and memory unnecessarily
1622019-05-02T10:00:33 <luke-jr> it's -misel that makes the performance hit specifically
1632019-05-02T10:01:09 <gmaxwell> wumpus: might help that GCC is presumably the compiler the risc-v designers use, while arm was focused on their own toolchain for a long time
1642019-05-02T10:01:18 <wumpus> gmaxwell: yup
1652019-05-02T10:02:54 <gmaxwell> luke-jr: IIRC isel is some predicated execution thing? it might want branch profiling...
1662019-05-02T10:03:28 <wumpus> gcc is the only feasible toolchain for RISC-V at the moment, clang doesn't support everything yet for full linux rv64gc
1672019-05-02T10:06:04 <luke-jr> gmaxwell: well, supposedly POWER8 had it, but it performed worse, so GCC disabled it by default.. I imagine they'll end up doing the same for POWER9
1682019-05-02T10:07:53 <gmaxwell> Predication like features can result in big performance gains, but only when they're used on frequently executed low predictability branches, if you use it on a branch that always goes the right way on many that are rarely executed they hurt performance.... This was a super big deal on itanium.
1692019-05-02T10:08:34 <gmaxwell> without profiles GCC has some guesses, e.g. exceptions are rare... malloc failures seldom happen, etc.
1702019-05-02T10:10:23 <luke-jr> should we begin littering our code with likely()/unlikely()? :P
1712019-05-02T10:12:26 <wumpus> luke-jr: the performance critical parts, maybe yes, that'll also help for other platforms
1722019-05-02T10:12:26 *** Guest11323 has joined #bitcoin-core-dev
1732019-05-02T10:12:39 <gmaxwell> Littering, probably not, but there might be a couple places where they make sense... but PGO is better from a maintance perspective!
1742019-05-02T10:12:48 <wumpus> although I've never seen those in c++ code, only c code
1752019-05-02T10:13:02 <luke-jr> PGO?
1762019-05-02T10:13:14 <gmaxwell> profile guided optimization.
1772019-05-02T10:13:24 <wumpus> e.g. MESA is littered with them (but that makes sense, almost everything in GPU drivers is perf critical that's the whole reason they exist)
1782019-05-02T10:13:28 <gmaxwell> I think for C++ you can't manage to likely tag all the important stuff...
1792019-05-02T10:14:22 <wumpus> the problem with PGO in our case might be reproducibility
1802019-05-02T10:14:38 <gmaxwell> luke-jr: -fprofile-generate and then run -fprofile-use.
1812019-05-02T10:14:38 <wumpus> yes, I also suspect it's more difficult due to more implicit behavior
1822019-05-02T10:14:47 <luke-jr> does PGO do cross anyway?
1832019-05-02T10:14:49 <gmaxwell> I believe mozilla has addressed PGO + reproducability.
1842019-05-02T10:15:17 <gmaxwell> but I'm not sure where that stands, in theory you should just be able to ship the profiles as side information along with the source.
1852019-05-02T10:15:44 <gmaxwell> in any case, might be worth benchmarking, if just to know even if its too much trouble to use.
1862019-05-02T10:16:09 <wumpus> right
1872019-05-02T10:16:18 <gmaxwell> If it gets a big speedup anywhere that might suggest likely() usage and/or refactoring to avoid confusing compiler hurestics.
1882019-05-02T10:17:42 <gmaxwell> (we do use builtin_expect in secp256k1, but mostly just around error handling code to get it to turn those into distant jumps)
1892019-05-02T10:19:43 *** rockhouse has quit IRC
1902019-05-02T10:20:18 *** spinza has quit IRC
1912019-05-02T10:20:44 *** rockhouse has joined #bitcoin-core-dev
1922019-05-02T10:25:07 *** timothy has quit IRC
1932019-05-02T10:25:39 *** promag_ has joined #bitcoin-core-dev
1942019-05-02T10:31:43 *** Skirmant has quit IRC
1952019-05-02T10:45:03 *** b10c has joined #bitcoin-core-dev
1962019-05-02T10:46:43 *** spinza has joined #bitcoin-core-dev
1972019-05-02T10:51:58 <harding> wumpus: did you get the win32/64 thing for the website sorted out? (Sorry; I thought I tested that for the removal.)
1982019-05-02T10:52:27 <luke-jr> harding: looks like it
1992019-05-02T10:53:01 <harding> luke-jr: cool. Thanks for noticing it was broken.
2002019-05-02T10:59:46 <gmaxwell> achow101: awake? time for a new bitcoin release thread on bitcointalk
2012019-05-02T11:07:21 *** Guest42 has quit IRC
2022019-05-02T11:13:10 <gmaxwell> achow101: you snooze you loose, https://bitcointalk.org/index.php?topic=5138532.0
2032019-05-02T11:14:08 <luke-jr> lol
2042019-05-02T11:17:34 *** AaronvanW has joined #bitcoin-core-dev
2052019-05-02T11:18:49 <wumpus> harding: I think so, made a minimal change to fix the broken link, suggested by luke-jr
2062019-05-02T11:23:04 *** Guest42 has joined #bitcoin-core-dev
2072019-05-02T11:24:36 *** Guest42 has quit IRC
2082019-05-02T11:27:06 *** Guest42 has joined #bitcoin-core-dev
2092019-05-02T11:29:06 <harding> wumpus: thanks! Sorry I missed that in the release PR.
2102019-05-02T11:30:19 <wumpus> no problem
2112019-05-02T11:31:22 *** timothy has joined #bitcoin-core-dev
2122019-05-02T11:32:37 *** jonatack has quit IRC
2132019-05-02T11:33:01 *** EagleTM has joined #bitcoin-core-dev
2142019-05-02T11:33:26 <Lauda> IsBerkeleyBtree: The system cannot find the file specified D:\Disk 1\Bitcoin\blocks\wallet.dat
2152019-05-02T11:33:26 <Lauda> is this intended in 18?
2162019-05-02T11:33:34 <Lauda> Seems to go through all folders looking for wallet.dat
2172019-05-02T11:34:21 <luke-jr> Lauda: that looks weird
2182019-05-02T11:34:37 <luke-jr> maybe trying to build the wallet list?
2192019-05-02T11:35:04 <Lauda> follow up is remaining folders
2202019-05-02T11:35:09 <Lauda> well it sounds weird 'find the file specified'
2212019-05-02T11:35:12 <Lauda> I didn't specify anything
2222019-05-02T11:41:48 *** spinza has quit IRC
2232019-05-02T11:48:37 <wumpus> bitcoin_test is really noisy on 0.18.0 RISC-V "Error: Specified -walletdir "/tmp/test_bitcoin/1556792182_943311758/tempdir/path_does_not_exist" does not exist" a zillion times, but the tests pass OK so I suppose these are expected errors
2242019-05-02T11:49:20 *** jonatack has joined #bitcoin-core-dev
2252019-05-02T11:49:56 <luke-jr> also on x86_64 IIRC
2262019-05-02T11:50:29 <wumpus> on master x86_64 it prints three errors, which is better, but still not ideal
2272019-05-02T11:59:45 *** promag_ has quit IRC
2282019-05-02T12:00:01 *** Guest11323 has quit IRC
2292019-05-02T12:00:37 *** spinza has joined #bitcoin-core-dev
2302019-05-02T12:03:04 *** jtimon has joined #bitcoin-core-dev
2312019-05-02T12:03:24 *** tryphe has quit IRC
2322019-05-02T12:03:47 *** tryphe has joined #bitcoin-core-dev
2332019-05-02T12:09:01 *** b10c has quit IRC
2342019-05-02T12:09:27 *** jonatack has quit IRC
2352019-05-02T12:21:50 *** scoop has joined #bitcoin-core-dev
2362019-05-02T12:36:53 *** b10c has joined #bitcoin-core-dev
2372019-05-02T12:41:19 *** bitcoin-git has joined #bitcoin-core-dev
2382019-05-02T12:41:19 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15939: gitian: Remove Windows 32 bit build (master...1904-GitianWin) https://github.com/bitcoin/bitcoin/pull/15939
2392019-05-02T12:41:21 *** bitcoin-git has left #bitcoin-core-dev
2402019-05-02T12:42:10 *** promag_ has joined #bitcoin-core-dev
2412019-05-02T12:45:38 *** bitcoin-git has joined #bitcoin-core-dev
2422019-05-02T12:45:38 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0936f35f65ad...c4560a7dfee9
2432019-05-02T12:45:39 <bitcoin-git> bitcoin/master 5d35ae3 Luca Venturini: Handle the result of posix_fallocate system call
2442019-05-02T12:45:39 <bitcoin-git> bitcoin/master c4560a7 MarcoFalke: Merge #15650: Handle the result of posix_fallocate system call
2452019-05-02T12:45:41 *** bitcoin-git has left #bitcoin-core-dev
2462019-05-02T12:46:13 *** bitcoin-git has joined #bitcoin-core-dev
2472019-05-02T12:46:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15650: Handle the result of posix_fallocate system call (master...handle-posix-fallocate) https://github.com/bitcoin/bitcoin/pull/15650
2482019-05-02T12:46:15 *** bitcoin-git has left #bitcoin-core-dev
2492019-05-02T12:50:22 *** Y_Ichiro has joined #bitcoin-core-dev
2502019-05-02T12:53:15 *** wbnns has joined #bitcoin-core-dev
2512019-05-02T13:04:59 *** hashist has joined #bitcoin-core-dev
2522019-05-02T13:05:17 *** hashist has left #bitcoin-core-dev
2532019-05-02T13:16:13 *** bitcoin-git has joined #bitcoin-core-dev
2542019-05-02T13:16:13 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c4560a7dfee9...c1ba1182eb43
2552019-05-02T13:16:13 <bitcoin-git> bitcoin/master beb42d7 practicalswift: Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn...
2562019-05-02T13:16:14 <bitcoin-git> bitcoin/master c1ba118 MarcoFalke: Merge #15938: refactor: Silence "control reaches end of non-void function"...
2572019-05-02T13:16:15 *** bitcoin-git has left #bitcoin-core-dev
2582019-05-02T13:16:39 *** bitcoin-git has joined #bitcoin-core-dev
2592019-05-02T13:16:39 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15938: refactor: Silence "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp (master...psbt-return-type-warning) https://github.com/bitcoin/bitcoin/pull/15938
2602019-05-02T13:16:40 *** bitcoin-git has left #bitcoin-core-dev
2612019-05-02T13:17:14 *** justanotheruser has joined #bitcoin-core-dev
2622019-05-02T13:23:32 *** spaced0ut has joined #bitcoin-core-dev
2632019-05-02T13:26:30 *** promag_ has quit IRC
2642019-05-02T13:35:31 *** sdaftuar has quit IRC
2652019-05-02T13:36:25 *** alex___ has joined #bitcoin-core-dev
2662019-05-02T13:37:31 *** sdaftuar has joined #bitcoin-core-dev
2672019-05-02T13:37:35 *** alex___ has quit IRC
2682019-05-02T13:38:50 *** ccdle12 has joined #bitcoin-core-dev
2692019-05-02T13:39:58 *** ossifrage_ has joined #bitcoin-core-dev
2702019-05-02T13:41:06 *** ossifrage has quit IRC
2712019-05-02T13:50:03 *** ossifrage_ has quit IRC
2722019-05-02T13:50:27 *** ossifrage_ has joined #bitcoin-core-dev
2732019-05-02T14:02:34 *** justanotheruser has quit IRC
2742019-05-02T14:02:49 *** scoop has quit IRC
2752019-05-02T14:08:22 *** baldur has quit IRC
2762019-05-02T14:11:41 *** bitcoin-git has joined #bitcoin-core-dev
2772019-05-02T14:11:41 <bitcoin-git> [bitcoin] laanwj opened pull request #15941: doc: Add historical release notes for 0.18.0 (master...2019_05_historical_release_notes) https://github.com/bitcoin/bitcoin/pull/15941
2782019-05-02T14:11:44 *** bitcoin-git has left #bitcoin-core-dev
2792019-05-02T14:14:35 *** Guest42 has quit IRC
2802019-05-02T14:15:15 *** bitcoin-git has joined #bitcoin-core-dev
2812019-05-02T14:15:15 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/2472733a24a9...be92be5644a7
2822019-05-02T14:15:15 <bitcoin-git> bitcoin/0.18 be92be5 Wladimir J. van der Laan: doc: Clean out release notes post-0.18.0
2832019-05-02T14:15:29 *** bitcoin-git has left #bitcoin-core-dev
2842019-05-02T14:16:55 *** Guest42 has joined #bitcoin-core-dev
2852019-05-02T14:18:21 *** shesek has quit IRC
2862019-05-02T14:19:54 <achow101> gmaxwell: 7 am is too early for me
2872019-05-02T14:20:13 *** scoop has joined #bitcoin-core-dev
2882019-05-02T14:21:44 *** baldur has joined #bitcoin-core-dev
2892019-05-02T14:23:56 *** justanotheruser has joined #bitcoin-core-dev
2902019-05-02T14:24:21 *** scoop has quit IRC
2912019-05-02T14:24:48 *** bitcoin-git has joined #bitcoin-core-dev
2922019-05-02T14:24:49 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1ba1182eb43...24dfcf3a56f9
2932019-05-02T14:24:49 <bitcoin-git> bitcoin/master da9f1ac Wladimir J. van der Laan: doc: Add historical release notes for 0.18.0
2942019-05-02T14:24:50 <bitcoin-git> bitcoin/master 24dfcf3 Wladimir J. van der Laan: Merge #15941: doc: Add historical release notes for 0.18.0
2952019-05-02T14:24:50 *** Tralfaz has joined #bitcoin-core-dev
2962019-05-02T14:25:00 *** bitcoin-git has left #bitcoin-core-dev
2972019-05-02T14:25:32 *** hebasto has joined #bitcoin-core-dev
2982019-05-02T14:25:33 *** bitcoin-git has joined #bitcoin-core-dev
2992019-05-02T14:25:33 <bitcoin-git> [bitcoin] laanwj merged pull request #15941: doc: Add historical release notes for 0.18.0 (master...2019_05_historical_release_notes) https://github.com/bitcoin/bitcoin/pull/15941
3002019-05-02T14:25:40 *** bitcoin-git has left #bitcoin-core-dev
3012019-05-02T14:26:42 *** Aaronvan_ has joined #bitcoin-core-dev
3022019-05-02T14:27:16 *** davterra has quit IRC
3032019-05-02T14:30:14 *** AaronvanW has quit IRC
3042019-05-02T14:31:19 *** davterra has joined #bitcoin-core-dev
3052019-05-02T14:32:10 *** StopAndDecrypt has quit IRC
3062019-05-02T14:33:40 *** Tralfaz has quit IRC
3072019-05-02T14:40:53 *** ossifrage_ has quit IRC
3082019-05-02T14:41:05 *** ossifrage_ has joined #bitcoin-core-dev
3092019-05-02T15:00:02 *** Y_Ichiro has quit IRC
3102019-05-02T15:02:36 *** jimmysong has quit IRC
3112019-05-02T15:04:35 *** furkanmustafa has joined #bitcoin-core-dev
3122019-05-02T15:09:18 *** WarrenBuffet has joined #bitcoin-core-dev
3132019-05-02T15:09:46 <hebasto> wumpus: #15940 "for 0.18.0" - typo?
3142019-05-02T15:09:47 <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
3152019-05-02T15:11:36 *** Guest42 has quit IRC
3162019-05-02T15:14:11 *** dgenr8 has quit IRC
3172019-05-02T15:21:34 *** shivendra has joined #bitcoin-core-dev
3182019-05-02T15:25:29 <wumpus> hebasto: yes, thanks, updated
3192019-05-02T15:26:03 *** _Sam-- has joined #bitcoin-core-dev
3202019-05-02T15:29:10 *** Eagle[TM] has joined #bitcoin-core-dev
3212019-05-02T15:30:37 *** EagleTM has quit IRC
3222019-05-02T15:32:35 *** dgenr8 has joined #bitcoin-core-dev
3232019-05-02T15:35:59 *** ccdle12 has quit IRC
3242019-05-02T15:38:31 *** scoop has joined #bitcoin-core-dev
3252019-05-02T15:41:37 *** jimmysong has joined #bitcoin-core-dev
3262019-05-02T15:44:43 *** DeanGuss has joined #bitcoin-core-dev
3272019-05-02T15:50:43 *** setpill has quit IRC
3282019-05-02T16:11:12 *** ossifrage_ has quit IRC
3292019-05-02T16:12:30 *** spaced0ut has quit IRC
3302019-05-02T16:20:16 *** cepinheiro has quit IRC
3312019-05-02T16:26:09 *** ossifrage has joined #bitcoin-core-dev
3322019-05-02T16:28:11 *** shivendra has quit IRC
3332019-05-02T16:28:16 *** scoop has quit IRC
3342019-05-02T16:36:35 *** hebasto has quit IRC
3352019-05-02T16:42:05 *** Eagle[TM] has quit IRC
3362019-05-02T16:56:40 *** afk11 has quit IRC
3372019-05-02T17:18:06 *** bitcoin-git has joined #bitcoin-core-dev
3382019-05-02T17:18:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15942: tests: Use BOOST_CHECK_EQUAL for verbose prints on fail (master...1905-testCryptoEqual) https://github.com/bitcoin/bitcoin/pull/15942
3392019-05-02T17:18:07 *** bitcoin-git has left #bitcoin-core-dev
3402019-05-02T17:34:05 *** sipa has quit IRC
3412019-05-02T17:35:51 *** sipa has joined #bitcoin-core-dev
3422019-05-02T17:47:44 <luke-jr> apparently GCC 8.2 is broken on PPC in other ways too so just reverting to GCC 7
3432019-05-02T17:47:58 <luke-jr> (has anyone checked that 8.2 isn't broken on other platforms we support?)
3442019-05-02T17:48:08 <luke-jr> wumpus: ^
3452019-05-02T17:53:48 <wumpus> no problems with it for risc-v nor x86
3462019-05-02T17:59:32 *** timothy has quit IRC
3472019-05-02T18:00:01 *** furkanmustafa has quit IRC
3482019-05-02T18:01:17 *** nullptr| has quit IRC
3492019-05-02T18:05:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3502019-05-02T18:07:38 *** nullptr| has joined #bitcoin-core-dev
3512019-05-02T18:08:53 *** Victorsueca is now known as Tipper
3522019-05-02T18:08:59 *** Tipper is now known as Victorsueca
3532019-05-02T18:22:45 *** perrito6661 has joined #bitcoin-core-dev
3542019-05-02T18:28:58 *** hebasto has joined #bitcoin-core-dev
3552019-05-02T18:33:02 *** DeanGuss has quit IRC
3562019-05-02T18:51:56 *** bitcoin-git has joined #bitcoin-core-dev
3572019-05-02T18:51:57 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15942: tests: Use BOOST_CHECK_EQUAL for verbose prints on fail (master...1905-testCryptoEqual) https://github.com/bitcoin/bitcoin/pull/15942
3582019-05-02T18:51:58 *** bitcoin-git has left #bitcoin-core-dev
3592019-05-02T19:01:08 <wumpus> #startmeeting
3602019-05-02T19:01:08 <lightningbot> Meeting started Thu May 2 19:01:08 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3612019-05-02T19:01:08 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3622019-05-02T19:01:20 <sipa> hi
3632019-05-02T19:01:20 <luke-jr> hi
3642019-05-02T19:01:22 <kanzure> hi
3652019-05-02T19:01:22 <jnewbery> hi
3662019-05-02T19:01:41 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
3672019-05-02T19:02:01 <sdaftuar> hi
3682019-05-02T19:02:21 <achow101> hi
3692019-05-02T19:02:27 <wumpus> congrats on release 0.18.0 everyone !
3702019-05-02T19:02:36 <sipa> indeed!
3712019-05-02T19:02:51 <jamesob> hi
3722019-05-02T19:02:54 <jonasschnelli> hi
3732019-05-02T19:02:57 <sdaftuar> \o/
3742019-05-02T19:03:18 <jtimon> still not sure what I did for this release exactly...but thanks, I guess :)
3752019-05-02T19:03:33 <wumpus> I've created an issue with the release schedule for 0.19: #15940
3762019-05-02T19:03:34 <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
3772019-05-02T19:04:32 <wumpus> any proposed topics? nothing on moneyball's list this week
3782019-05-02T19:05:27 <instagibbs> \o/
3792019-05-02T19:05:32 <wumpus> #topic high priority for review
3802019-05-02T19:05:46 <sipa> i've been busy with some other things, i'll be more active soon
3812019-05-02T19:05:48 <phantomcircuit> hi
3822019-05-02T19:06:19 <wumpus> currently on the list: #15427 #15024 #15006 #15141 #15512
3832019-05-02T19:06:21 <gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
3842019-05-02T19:06:23 <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
3852019-05-02T19:06:26 <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
3862019-05-02T19:06:28 <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
3872019-05-02T19:06:29 <wumpus> sipa: good to know!
3882019-05-02T19:06:33 <gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
3892019-05-02T19:06:50 <wumpus> anything to add/remove?
3902019-05-02T19:07:09 <jonasschnelli> If you want progress on the p2p encryption, review the ChaCha20 stuff in #15512 (</ad>)
3912019-05-02T19:07:11 <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
3922019-05-02T19:07:33 <wumpus> right!
3932019-05-02T19:07:34 *** promag_ has joined #bitcoin-core-dev
3942019-05-02T19:07:34 <sipa> jonasschnelli: will do, promise
3952019-05-02T19:07:41 <jonasschnelli> thanks
3962019-05-02T19:07:42 <jamesob> psa: going to be putting up the first of the assumeutxo-related PRs in the next few days; if you're interested and haven't reviewed the general proposal you can do so here: https://github.com/jamesob/assumeutxo-docs/pull/1
3972019-05-02T19:08:22 <wumpus> jamesob: yes, some context is always useful
3982019-05-02T19:10:01 <wumpus> any other topics? (or, more to discuss about assumeutxo)
3992019-05-02T19:10:43 <jamesob> not on my end, though happy to chat about assumeutxo if anyone has questions
4002019-05-02T19:11:48 *** joe___ has joined #bitcoin-core-dev
4012019-05-02T19:12:27 <wumpus> okay
4022019-05-02T19:13:15 <wumpus> a short meeting then, I guess
4032019-05-02T19:13:28 <jonasschnelli> new record
4042019-05-02T19:13:29 <jnewbery> short meetings are good meetings
4052019-05-02T19:13:52 <wumpus> very efficient
4062019-05-02T19:14:00 <wumpus> #endmeeting
4072019-05-02T19:14:00 <lightningbot> Meeting ended Thu May 2 19:14:00 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4082019-05-02T19:14:00 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-02-19.01.html
4092019-05-02T19:14:00 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-02-19.01.txt
4102019-05-02T19:14:00 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-02-19.01.log.html
4112019-05-02T19:15:19 <MarcoFalke> Oh, I missed it
4122019-05-02T19:15:51 <sipa> MarcoFalke: you didn't miss much :p
4132019-05-02T19:15:57 <MarcoFalke> heh
4142019-05-02T19:15:59 <luke-jr> we need to have another meeting for MarcoFalke
4152019-05-02T19:16:03 <MarcoFalke> can I add #15870?
4162019-05-02T19:16:05 <gribble> https://github.com/bitcoin/bitcoin/issues/15870 | wallet: Only fail rescan when blocks have actually been pruned by MarcoFalke · Pull Request #15870 · bitcoin/bitcoin · GitHub
4172019-05-02T19:16:39 <MarcoFalke> to high priority?
4182019-05-02T19:20:05 <wumpus> MarcoFalke :sure
4192019-05-02T19:20:19 <MarcoFalke> cool thx
4202019-05-02T19:20:30 * MarcoFalke #end meeting for MarcoFalke
4212019-05-02T19:30:30 *** promag_ has quit IRC
4222019-05-02T19:32:10 *** promag_ has joined #bitcoin-core-dev
4232019-05-02T19:34:45 *** promag_ has quit IRC
4242019-05-02T19:36:53 *** promag_ has joined #bitcoin-core-dev
4252019-05-02T19:39:40 <jtimon> jamesob: reading the proposal, looks very nice
4262019-05-02T19:39:57 <jamesob> jtimon: cool, thanks!
4272019-05-02T19:41:55 *** promag_ has quit IRC
4282019-05-02T19:42:42 *** owowo has quit IRC
4292019-05-02T19:43:21 *** joe___ has quit IRC
4302019-05-02T19:43:51 *** promag_ has joined #bitcoin-core-dev
4312019-05-02T19:47:26 *** owowo has joined #bitcoin-core-dev
4322019-05-02T20:03:54 *** stephan3000 has joined #bitcoin-core-dev
4332019-05-02T20:08:26 *** Guyver2 has quit IRC
4342019-05-02T20:09:33 <phantomcircuit> sipa, the CAddrMan Unserialize method trusts that the nSize parameter isn't corrupted, is there an upper bound for that we could set to prevent an infinite loop on disk corruption?
4352019-05-02T20:11:14 <sipa> phantomcircuit: the total number of entries is capped by the number and size of the buckets, so yes
4362019-05-02T20:11:40 <sipa> though we may want to set the limit a small factor higher to permit downgrading if the bucket layout ever changes
4372019-05-02T20:12:05 <phantomcircuit> sipa, line 423 in addrman.h , so it's the "new" table
4382019-05-02T20:12:36 *** ddustin has joined #bitcoin-core-dev
4392019-05-02T20:13:29 *** promag_ has quit IRC
4402019-05-02T20:13:41 *** ddustin has joined #bitcoin-core-dev
4412019-05-02T20:16:03 *** user2019 has joined #bitcoin-core-dev
4422019-05-02T20:16:17 *** davterra has quit IRC
4432019-05-02T20:19:37 *** stephan3000 has quit IRC
4442019-05-02T20:27:33 *** promag_ has joined #bitcoin-core-dev
4452019-05-02T20:32:16 *** bitcoin-git has joined #bitcoin-core-dev
4462019-05-02T20:32:16 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15943: tests: Fail if RPC has been added without tests (master...1905-testFailNoRpcCov) https://github.com/bitcoin/bitcoin/pull/15943
4472019-05-02T20:32:30 *** bitcoin-git has left #bitcoin-core-dev
4482019-05-02T20:33:32 <phantomcircuit> sipa, i guess it mostly doesn't matter cause the stream will probably fault before it loops for too long
4492019-05-02T20:35:08 <sipa> phantomcircuit: i think there are at most 64*1024 entries in the 'new' table
4502019-05-02T20:35:18 <sipa> #define ADDRMAN_NEW_BUCKET_COUNT_LOG2 10
4512019-05-02T20:35:26 <sipa> #define ADDRMAN_BUCKET_SIZE_LOG2 6
4522019-05-02T20:54:42 <sipa> MarcoFalke: that sha256d64 test failing is scary
4532019-05-02T21:00:02 *** perrito6661 has quit IRC
4542019-05-02T21:00:19 <phantomcircuit> sipa, thinking about it more i dont think it really matters cause the stream reads will just throw an exception once it's past the end of the file
4552019-05-02T21:00:38 <sipa> yes
4562019-05-02T21:01:14 <sipa> phantomcircuit: i guess the only thing to worry about is if a garbage file can cause us to allocate a ginormous amount of memory immediately
4572019-05-02T21:01:26 <sipa> but the normal vector serialization functions allocate incrementally to prevent that
4582019-05-02T21:01:33 <sipa> *deserialization
4592019-05-02T21:02:37 *** ddustin has quit IRC
4602019-05-02T21:03:19 *** ddustin has joined #bitcoin-core-dev
4612019-05-02T21:04:18 *** davec has quit IRC
4622019-05-02T21:04:34 *** hebasto has quit IRC
4632019-05-02T21:05:26 *** ddustin has joined #bitcoin-core-dev
4642019-05-02T21:08:12 *** mryandao_ has joined #bitcoin-core-dev
4652019-05-02T21:09:26 *** mryandao has quit IRC
4662019-05-02T21:10:44 *** brantje has joined #bitcoin-core-dev
4672019-05-02T21:12:53 *** Chris_Stewart_5 has quit IRC
4682019-05-02T21:12:53 *** reardencode has quit IRC
4692019-05-02T21:15:03 <phantomcircuit> sipa, and this is just reading integers so it cant be more than 32bits at a time
4702019-05-02T21:22:10 <MarcoFalke> yeah, indeed scary
4712019-05-02T21:22:39 <MarcoFalke> So bitcoind is using a different sha than the tests do?
4722019-05-02T21:23:08 <MarcoFalke> Otherwise, how could it sync
4732019-05-02T21:25:37 <sipa> MarcoFalke: how many times do you get the "check memcmp(...) == 0 has failed" ?
4742019-05-02T21:25:49 <MarcoFalke> 32
4752019-05-02T21:26:28 <sipa> what happens if you add a SHA256AutoDetect() call in the test?
4762019-05-02T21:28:02 <MarcoFalke> Same
4772019-05-02T21:28:18 <MarcoFalke> I guess it is already called in BasicTestingSetup()
4782019-05-02T21:29:18 <sipa> ok, what if you comment out the "if (have_avx2 && have_avx && enabled_avx) {" block in crpyto/sha256.cpp ?
4792019-05-02T21:32:15 <MarcoFalke> Same with if (true||have_avx2 && have_avx && enabled_avx) {
4802019-05-02T21:33:11 *** davec has joined #bitcoin-core-dev
4812019-05-02T21:33:20 <sipa> what if you disable it entirely (as in: don't use avx2)
4822019-05-02T21:33:49 <MarcoFalke> still fails
4832019-05-02T21:34:46 <sipa> what if you comment out the "TransformD64_4way = sha256d64_sse41::Transform_4way" line and the "TransformD64_8way = sha256d64_avx2::Transform_8way;" line?
4842019-05-02T21:34:52 * sipa is baffled
4852019-05-02T21:35:47 <MarcoFalke> same
4862019-05-02T21:35:58 * MarcoFalke yes I double checked that I compiled it again
4872019-05-02T21:37:44 <MarcoFalke> 2019-05-02T21:37:33Z Using the 'standard' SHA256 implementation
4882019-05-02T21:38:03 <sipa> sense, it makes none.
4892019-05-02T21:38:31 <luke-jr> NSA disagrees
4902019-05-02T21:38:32 <sipa> can you add an assert inside the avx2/sse4 implementations to make sure they're not invoked?
4912019-05-02T21:40:34 *** michaelfolkson has joined #bitcoin-core-dev
4922019-05-02T21:41:16 *** promag_ has quit IRC
4932019-05-02T21:44:49 <MarcoFalke> I think it calls TransformD64
4942019-05-02T21:45:26 <MarcoFalke> and Transform
4952019-05-02T21:46:39 <MarcoFalke> sha256_sse4::Transform and Transform_8way have an assert(false)
4962019-05-02T21:48:48 <sipa> what if you set TransformD64 to TransformD64Wrapper<sha256::Transform> (and make SHA256AutoDetect a no-op)?
4972019-05-02T21:49:20 <sipa> in the initializer
4982019-05-02T21:51:44 *** reardencode has joined #bitcoin-core-dev
4992019-05-02T21:53:01 <MarcoFalke> still fails
5002019-05-02T22:01:00 <luke-jr> MarcoFalke: what GCC version?
5012019-05-02T22:01:58 <MarcoFalke> $ gcc --version === gcc (GCC) 9.0.1 20190312 (Red Hat 9.0.1-0.10)
5022019-05-02T22:05:26 <luke-jr> hrm, I'd guess probably not the issue, but it might indicate GCC has been playing with memory stuff? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88273
5032019-05-02T22:06:03 <luke-jr> might be worth recompiling with GCC 7 just to see if it's compiler-dependent
5042019-05-02T22:07:05 <MarcoFalke> Someone else reported it with fedora 29, which has gcc8?
5052019-05-02T22:07:16 <MarcoFalke> But I will try with clang
5062019-05-02T22:07:44 <MarcoFalke> Might take a while since 32 bit only gives me 2gb of ram
5072019-05-02T22:07:48 <sipa> MarcoFalke: does compiling with ubsan or asan give any interesting results
5082019-05-02T22:07:51 <sipa> ?
5092019-05-02T22:08:04 <MarcoFalke> rip ram
5102019-05-02T22:08:20 <MarcoFalke> will have results in an hour earliest
5112019-05-02T22:08:42 *** ddustin has quit IRC
5122019-05-02T22:09:01 *** ddustin has joined #bitcoin-core-dev
5132019-05-02T22:09:41 *** ddustin has quit IRC
5142019-05-02T22:10:03 *** sdaftuar has quit IRC
5152019-05-02T22:10:07 <luke-jr> MarcoFalke: since this is a not-very-likely cause, I'd suggest continuing to troubleshoot with sipa while it builds
5162019-05-02T22:10:17 *** ddustin has joined #bitcoin-core-dev
5172019-05-02T22:10:28 <luke-jr> although I guess rebuilding with sanitizers are going to take just as long :x
5182019-05-02T22:10:47 <luke-jr> I would be surprised if asan supported x86_32 since it requires so much virtual memory space
5192019-05-02T22:10:49 *** sdaftuar has joined #bitcoin-core-dev
5202019-05-02T22:10:50 *** ddustin has quit IRC
5212019-05-02T22:11:37 *** ddustin has joined #bitcoin-core-dev
5222019-05-02T22:13:45 <MarcoFalke> So just to confirm this should be the call stack?
5232019-05-02T22:13:47 <MarcoFalke> https://pastebin.ubuntu.com/p/tSVxBJvTZy/
5242019-05-02T22:14:04 <MarcoFalke> SHA256D64 calls Transform?
5252019-05-02T22:14:31 <sipa> yeah, that looks right
5262019-05-02T22:14:58 <sipa> it calls TransformD64, which is a function pointer to a wrapper function that invokes Transform
5272019-05-02T22:19:35 <MarcoFalke> ok, building on clang with sanitizers = address,undefined
5282019-05-02T22:22:00 *** spinza has quit IRC
5292019-05-02T22:23:23 *** Randolf has joined #bitcoin-core-dev
5302019-05-02T22:25:16 *** RandolfR has quit IRC
5312019-05-02T22:25:25 *** user2019 has quit IRC
5322019-05-02T22:32:29 *** spinza has joined #bitcoin-core-dev
5332019-05-02T22:35:10 *** laptop_ has quit IRC
5342019-05-02T22:42:47 *** Guest42 has joined #bitcoin-core-dev
5352019-05-02T22:44:12 *** Zenton has quit IRC
5362019-05-02T22:58:04 <phantomcircuit> so apparently GetTimeMillis() can throw an exception, which isn't handled like anywhere
5372019-05-02T22:58:17 <sipa> phantomcircuit: define 'can'
5382019-05-02T22:58:25 <phantomcircuit> actually it can't nvm
5392019-05-02T22:58:33 <phantomcircuit> sorry
5402019-05-02T22:58:54 <phantomcircuit> boost::gregorian::date can but not with the constants we use
5412019-05-02T22:59:01 <MarcoFalke> So it passes with clang and address sanitizer
5422019-05-02T22:59:03 <MarcoFalke> !?
5432019-05-02T22:59:03 <gribble> (misc help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin.
5442019-05-02T22:59:23 <sipa> MarcoFalke: gcc 9 bug?
5452019-05-02T22:59:24 * MarcoFalke off
5462019-05-02T22:59:45 <MarcoFalke> Maybe.
5472019-05-02T22:59:51 <MarcoFalke> Could also be 8
5482019-05-02T23:00:01 <MarcoFalke> Will update the issue tomorrow
5492019-05-02T23:00:14 <luke-jr> hopefully not 8, as we just shipped built with 8 :x
5502019-05-02T23:00:32 <MarcoFalke> luke-jr: The issue is there since 0.17.1
5512019-05-02T23:00:45 <MarcoFalke> So yes, likely also gcc 8
5522019-05-02T23:01:02 <luke-jr> :|
5532019-05-02T23:02:52 *** scoop has joined #bitcoin-core-dev
5542019-05-02T23:04:04 *** justanotheruser has quit IRC
5552019-05-02T23:05:22 <booyah> on limited memory maybe just run in valgrind, if you have memory problems? (though always few false positives)
5562019-05-02T23:19:15 *** justanotheruser has joined #bitcoin-core-dev
5572019-05-02T23:19:54 *** Skirmant has joined #bitcoin-core-dev
5582019-05-02T23:20:20 <sipa> MarcoFalke: i can reproduce
5592019-05-02T23:55:47 * luke-jr looks forward to the day he can do these gitian builds on ppc64