12019-05-08T00:00:00 *** scoop has quit IRC
22019-05-08T00:00:00 *** instagibbs has quit IRC
32019-05-08T00:00:02 *** feedoo1 has quit IRC
42019-05-08T00:17:42 *** rlaager1 has joined #bitcoin-core-dev
52019-05-08T00:23:06 *** fanquake has joined #bitcoin-core-dev
62019-05-08T00:24:35 *** chriswang2019 has joined #bitcoin-core-dev
72019-05-08T00:32:59 *** Chris_Stewart_5 has quit IRC
82019-05-08T00:35:56 *** chriswang2019 has quit IRC
92019-05-08T00:55:44 *** pinheadmz has quit IRC
102019-05-08T00:57:53 *** promag_ has quit IRC
112019-05-08T00:59:07 *** pinheadmz has joined #bitcoin-core-dev
122019-05-08T01:01:48 *** side^effects has quit IRC
132019-05-08T01:05:37 *** promag has joined #bitcoin-core-dev
142019-05-08T01:06:15 <promag> an alternative to force the build is to redeliver the webhook, however there's no official API for this. But I think it should be possible by using GET https://github.com/hooks/$HOOK_ID/deliveries and POST https://github.com/hooks/$HOOK_ID/deliveries/$DELIVERY_ID/redeliver with the right headers
152019-05-08T01:07:09 *** promag has quit IRC
162019-05-08T01:07:11 *** pinheadmz has quit IRC
172019-05-08T01:07:28 *** pinheadmz has joined #bitcoin-core-dev
182019-05-08T01:28:21 *** instagibbs has joined #bitcoin-core-dev
192019-05-08T01:30:36 *** promag has joined #bitcoin-core-dev
202019-05-08T01:33:40 *** bitcoin-git has joined #bitcoin-core-dev
212019-05-08T01:33:40 <bitcoin-git> [bitcoin] dongcarl opened pull request #15978: .gitignore: Don't ignore depends patches (master...2019-05-no-ignore-depends-patches) https://github.com/bitcoin/bitcoin/pull/15978
222019-05-08T01:33:41 *** bitcoin-git has left #bitcoin-core-dev
232019-05-08T01:33:44 *** pinheadmz has quit IRC
242019-05-08T01:34:17 *** hyperwang has joined #bitcoin-core-dev
252019-05-08T01:35:04 *** promag has quit IRC
262019-05-08T01:36:05 *** hyperwang has quit IRC
272019-05-08T01:36:13 *** pinheadmz has joined #bitcoin-core-dev
282019-05-08T01:59:27 *** jtimon has quit IRC
292019-05-08T02:06:05 *** jhfrontz has joined #bitcoin-core-dev
302019-05-08T02:43:47 <luke-jr> achow101: the travis restart thing won't?
312019-05-08T02:45:03 <achow101> restarting a job will just use the same commit for that job
322019-05-08T02:45:18 <achow101> you'd need to trigger a new build for the pr, which isn't possible at least from the web ui
332019-05-08T02:46:27 <luke-jr> what if we modify our travis scripts to fetch master explicitly?
342019-05-08T02:47:51 *** AaronvanW has quit IRC
352019-05-08T03:00:01 *** rlaager1 has quit IRC
362019-05-08T03:05:50 *** Eagle[TM] has joined #bitcoin-core-dev
372019-05-08T03:07:32 *** EagleTM has quit IRC
382019-05-08T03:18:02 *** aowi has joined #bitcoin-core-dev
392019-05-08T03:29:17 <gmaxwell> luke-jr: re your list post, "If that is inacceptable, pick as internal key a point with unknown discrete logarithm." there is no reason your forced to have a everyone agress bypass.
402019-05-08T04:20:37 *** hebasto_ has quit IRC
412019-05-08T04:58:01 *** ghost43 has quit IRC
422019-05-08T04:58:16 *** ghost43 has joined #bitcoin-core-dev
432019-05-08T05:29:42 *** murchandamus has left #bitcoin-core-dev
442019-05-08T05:32:04 *** murch has joined #bitcoin-core-dev
452019-05-08T05:32:14 *** promag has joined #bitcoin-core-dev
462019-05-08T05:33:49 *** dermoth has quit IRC
472019-05-08T05:36:59 *** promag has quit IRC
482019-05-08T05:42:45 *** dermoth has joined #bitcoin-core-dev
492019-05-08T05:49:22 *** pinheadmz has quit IRC
502019-05-08T06:00:02 *** aowi has quit IRC
512019-05-08T06:04:56 *** jtimon has joined #bitcoin-core-dev
522019-05-08T06:20:30 *** hyperwang has joined #bitcoin-core-dev
532019-05-08T06:22:01 *** hyperwang has quit IRC
542019-05-08T06:22:28 *** hyperwang has joined #bitcoin-core-dev
552019-05-08T06:23:56 *** hyperwang has joined #bitcoin-core-dev
562019-05-08T06:25:22 *** Eagle[TM] has quit IRC
572019-05-08T06:25:25 *** hyperwang has joined #bitcoin-core-dev
582019-05-08T06:26:26 *** hyperwang has quit IRC
592019-05-08T06:26:53 *** hyperwang has joined #bitcoin-core-dev
602019-05-08T06:27:55 *** hyperwang has quit IRC
612019-05-08T06:28:22 *** hyperwang has joined #bitcoin-core-dev
622019-05-08T06:29:57 *** hyperwang has joined #bitcoin-core-dev
632019-05-08T06:31:25 *** hyperwang has joined #bitcoin-core-dev
642019-05-08T06:32:26 *** hyperwang has quit IRC
652019-05-08T06:32:53 *** hyperwang has joined #bitcoin-core-dev
662019-05-08T06:33:16 <tryphe> i noticed there's not a lot of usage of 'const' in a lot of bitcoin code where there could be. is this for readability purposes, or are changes welcome?
672019-05-08T06:34:16 *** hyperwang has quit IRC
682019-05-08T06:35:09 *** feth1 has joined #bitcoin-core-dev
692019-05-08T06:36:14 *** hyperwang has joined #bitcoin-core-dev
702019-05-08T06:36:27 <sipa> tryphe: we reject patches that only improve coding stylr
712019-05-08T06:36:30 <sipa> *style
722019-05-08T06:37:46 *** hyperwang has quit IRC
732019-05-08T06:38:00 <tryphe> sipa, i was thinking of an improvement like so: say you pass a pointer to a thread, and you expect the pointer to be accessed non-const but the address value to not be modified. now you could enforce that with coverage tests and stuff.
742019-05-08T06:38:09 <tryphe> gah, thread/function*
752019-05-08T06:38:13 *** hyperwang has joined #bitcoin-core-dev
762019-05-08T06:38:46 <tryphe> whereas if you don't enforce it, you won't know if you accidentally modified a value
772019-05-08T06:39:21 <sipa> yes, improving that is great, but it is very low priority noise compared to other potential changes
782019-05-08T06:39:32 <sipa> and review time is limited and precious
792019-05-08T06:39:40 *** Karyon has quit IRC
802019-05-08T06:39:52 <tryphe> true, but in terms of undefined behavior i think it could be helpful
812019-05-08T06:40:15 <gwillen> adding "const" feels like it should be slightly different from "mere style" changes, since it's functional rather than aesthetic, and any instance the compiler accepts is almost surely correct
822019-05-08T06:40:28 <gwillen> (so review effort ought to be limited)
832019-05-08T06:40:39 <sipa> if you actually find an issue, for example by adding const where you expect it to work and it doesn't, it is different
842019-05-08T06:40:42 *** jtimon has quit IRC
852019-05-08T06:40:45 <tryphe> (i realized it's impractical to change this though, there's a crapload of changes that would need be done to enforce this example above)
862019-05-08T06:40:45 <gwillen> *nods*
872019-05-08T06:41:05 <sipa> but adding const in places where the code already works has no effect except add assurances
882019-05-08T06:41:08 <tryphe> alright, that makes sense. i guess there's enough tests anyways to catch most issues.
892019-05-08T06:42:08 *** hyperwang has quit IRC
902019-05-08T06:42:35 *** hyperwang has joined #bitcoin-core-dev
912019-05-08T06:43:59 *** Karyon has joined #bitcoin-core-dev
922019-05-08T06:44:02 <gmaxwell> you can also introduce bugs by peppering around const, so it's not like those changes are free to review, even ignoring the effect on change flow.
932019-05-08T06:44:15 *** hyperwang has joined #bitcoin-core-dev
942019-05-08T06:45:10 <sipa> in general adding const can't have too much effect if the code works both before and after... but there are some
952019-05-08T06:45:41 <sipa> for example moving a const argument will silently introduce a (deep) copy of certain objects, where a move was expected
962019-05-08T06:45:47 <tryphe> yeah, the problem is knowing the intent of the code you are modifying
972019-05-08T06:45:58 <sipa> tryphe: exactly!
982019-05-08T06:46:38 <sipa> adding such things where they are intended is great, but adding them mechanically is mostly useless without careful review of every individual case
992019-05-08T06:47:38 *** hyperwang has quit IRC
1002019-05-08T06:48:16 *** hyperwang has joined #bitcoin-core-dev
1012019-05-08T06:48:38 <gmaxwell> That is also a general problem with broad 'cleanup' changes, they're done without much understanding or care about the code they're changing.
1022019-05-08T06:49:38 *** hyperwang has quit IRC
1032019-05-08T06:50:14 *** hyperwang has joined #bitcoin-core-dev
1042019-05-08T06:51:53 *** hyperwang has joined #bitcoin-core-dev
1052019-05-08T06:53:21 *** hyperwang has joined #bitcoin-core-dev
1062019-05-08T06:54:22 *** hyperwang has quit IRC
1072019-05-08T06:55:00 *** hyperwang has joined #bitcoin-core-dev
1082019-05-08T06:56:01 *** hyperwang has quit IRC
1092019-05-08T06:56:34 *** hyperwang has joined #bitcoin-core-dev
1102019-05-08T06:57:35 *** hyperwang has quit IRC
1112019-05-08T06:58:03 *** hyperwang has joined #bitcoin-core-dev
1122019-05-08T06:58:25 *** blkwolf has joined #bitcoin-core-dev
1132019-05-08T06:59:25 *** hyperwang has quit IRC
1142019-05-08T06:59:53 *** hyperwang has joined #bitcoin-core-dev
1152019-05-08T07:01:22 *** hyperwang has joined #bitcoin-core-dev
1162019-05-08T07:02:23 *** hyperwang has quit IRC
1172019-05-08T07:02:49 *** hyperwang has joined #bitcoin-core-dev
1182019-05-08T07:03:50 *** hyperwang has quit IRC
1192019-05-08T07:04:19 *** hyperwang has joined #bitcoin-core-dev
1202019-05-08T07:05:20 *** hyperwang has quit IRC
1212019-05-08T07:05:51 *** hyperwang has joined #bitcoin-core-dev
1222019-05-08T07:07:20 *** hyperwang has joined #bitcoin-core-dev
1232019-05-08T07:08:21 *** hyperwang has quit IRC
1242019-05-08T07:08:59 *** hyperwang has joined #bitcoin-core-dev
1252019-05-08T07:09:13 *** blkwolf has left #bitcoin-core-dev
1262019-05-08T07:09:59 *** blkwolf has joined #bitcoin-core-dev
1272019-05-08T07:10:17 <tryphe> one good reason i like to do it, though, is because i get a compiler error when i try to modify something that wasn't intended by the programmer. it's easy for someone to... misuse the code i guess is a better way to put it.
1282019-05-08T07:10:25 *** blkwolf has left #bitcoin-core-dev
1292019-05-08T07:11:25 *** hyperwang has quit IRC
1302019-05-08T07:12:03 *** hyperwang has joined #bitcoin-core-dev
1312019-05-08T07:13:15 <tryphe> sorta like using nullptr instead of 0, you state the intention of the usage for future programmers to reference, instead of relying on them to make a good guess, hehe
1322019-05-08T07:13:31 *** hyperwang has joined #bitcoin-core-dev
1332019-05-08T07:14:18 <tryphe> good/correct*
1342019-05-08T07:15:19 *** hyperwang has quit IRC
1352019-05-08T07:15:45 *** hyperwang has joined #bitcoin-core-dev
1362019-05-08T07:16:46 *** hyperwang has quit IRC
1372019-05-08T07:17:13 *** hyperwang has joined #bitcoin-core-dev
1382019-05-08T07:18:14 *** hyperwang has quit IRC
1392019-05-08T07:18:41 *** hyperwang has joined #bitcoin-core-dev
1402019-05-08T07:20:08 *** hyperwang has joined #bitcoin-core-dev
1412019-05-08T07:21:10 *** hyperwang has quit IRC
1422019-05-08T07:21:36 *** hyperwang has joined #bitcoin-core-dev
1432019-05-08T07:22:37 *** hyperwang has quit IRC
1442019-05-08T07:23:05 *** hyperwang has joined #bitcoin-core-dev
1452019-05-08T07:24:06 *** hyperwang has quit IRC
1462019-05-08T07:24:33 *** hyperwang has joined #bitcoin-core-dev
1472019-05-08T07:26:12 *** hyperwang has joined #bitcoin-core-dev
1482019-05-08T07:27:40 *** hyperwang has joined #bitcoin-core-dev
1492019-05-08T07:28:41 *** hyperwang has quit IRC
1502019-05-08T07:29:02 *** bitcoin-git has joined #bitcoin-core-dev
1512019-05-08T07:29:02 <bitcoin-git> [bitcoin] Bushstar opened pull request #15979: Replace incorrectly named comment with func (master...replace-with-func) https://github.com/bitcoin/bitcoin/pull/15979
1522019-05-08T07:29:03 *** bitcoin-git has left #bitcoin-core-dev
1532019-05-08T07:29:18 *** hyperwang has joined #bitcoin-core-dev
1542019-05-08T07:29:24 *** bushstar has joined #bitcoin-core-dev
1552019-05-08T07:30:24 *** hyperwang has quit IRC
1562019-05-08T07:30:52 *** hyperwang has joined #bitcoin-core-dev
1572019-05-08T07:32:20 *** hyperwang has joined #bitcoin-core-dev
1582019-05-08T07:33:21 *** hyperwang has quit IRC
1592019-05-08T07:33:59 *** hyperwang has joined #bitcoin-core-dev
1602019-05-08T07:35:01 *** hyperwang has quit IRC
1612019-05-08T07:35:38 *** hyperwang has joined #bitcoin-core-dev
1622019-05-08T07:36:39 *** hyperwang has quit IRC
1632019-05-08T07:37:06 *** hyperwang has joined #bitcoin-core-dev
1642019-05-08T07:38:07 *** hyperwang has quit IRC
1652019-05-08T07:38:36 *** hyperwang has joined #bitcoin-core-dev
1662019-05-08T07:39:10 *** drexl has quit IRC
1672019-05-08T07:40:11 *** hyperwang has quit IRC
1682019-05-08T07:40:38 *** hyperwang has joined #bitcoin-core-dev
1692019-05-08T07:42:07 *** hyperwang has joined #bitcoin-core-dev
1702019-05-08T07:43:35 *** hyperwang has joined #bitcoin-core-dev
1712019-05-08T07:44:36 *** hyperwang has quit IRC
1722019-05-08T07:45:04 *** hyperwang has joined #bitcoin-core-dev
1732019-05-08T07:46:05 *** hyperwang has quit IRC
1742019-05-08T07:46:33 *** hyperwang has joined #bitcoin-core-dev
1752019-05-08T07:48:02 *** hyperwang has joined #bitcoin-core-dev
1762019-05-08T07:49:04 *** hyperwang has quit IRC
1772019-05-08T07:49:51 *** hyperwang has joined #bitcoin-core-dev
1782019-05-08T07:50:53 *** hyperwang has quit IRC
1792019-05-08T07:51:19 *** hyperwang has joined #bitcoin-core-dev
1802019-05-08T07:52:21 *** hyperwang has quit IRC
1812019-05-08T07:52:47 *** hyperwang has joined #bitcoin-core-dev
1822019-05-08T07:56:15 *** fanquake has quit IRC
1832019-05-08T07:57:42 *** booyah has quit IRC
1842019-05-08T08:00:03 *** Dean_Guss has joined #bitcoin-core-dev
1852019-05-08T08:16:34 *** talesfromthecryp has joined #bitcoin-core-dev
1862019-05-08T08:20:59 *** kevinryan has joined #bitcoin-core-dev
1872019-05-08T08:21:57 *** talesfromthecryp has quit IRC
1882019-05-08T08:31:07 *** kevinryan has quit IRC
1892019-05-08T08:35:23 *** Zenton has joined #bitcoin-core-dev
1902019-05-08T08:39:11 *** fanquake has joined #bitcoin-core-dev
1912019-05-08T08:44:48 *** laptop500 has joined #bitcoin-core-dev
1922019-05-08T08:45:04 *** justanotheruser has quit IRC
1932019-05-08T08:45:40 *** murrayn has joined #bitcoin-core-dev
1942019-05-08T08:45:40 *** murrayn has joined #bitcoin-core-dev
1952019-05-08T08:52:54 *** promag has joined #bitcoin-core-dev
1962019-05-08T08:59:05 *** promag has quit IRC
1972019-05-08T09:00:02 *** feth1 has quit IRC
1982019-05-08T09:04:46 *** Fuchs1 has joined #bitcoin-core-dev
1992019-05-08T09:10:44 *** queip has quit IRC
2002019-05-08T09:11:56 *** rafalcpp_ has joined #bitcoin-core-dev
2012019-05-08T09:12:01 *** rafalcpp has quit IRC
2022019-05-08T09:21:22 *** timothy has joined #bitcoin-core-dev
2032019-05-08T09:21:29 *** promag has joined #bitcoin-core-dev
2042019-05-08T09:23:48 *** queip has joined #bitcoin-core-dev
2052019-05-08T09:34:35 *** csknk has joined #bitcoin-core-dev
2062019-05-08T09:37:21 *** csknk has quit IRC
2072019-05-08T10:04:43 *** davec has quit IRC
2082019-05-08T10:07:29 *** kevinryan has joined #bitcoin-core-dev
2092019-05-08T10:07:54 *** setpill has joined #bitcoin-core-dev
2102019-05-08T10:22:37 *** spinza has quit IRC
2112019-05-08T10:24:57 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2122019-05-08T10:28:29 *** arubi has quit IRC
2132019-05-08T10:30:01 *** arubi has joined #bitcoin-core-dev
2142019-05-08T10:30:23 *** bitcoin-git has joined #bitcoin-core-dev
2152019-05-08T10:30:23 <bitcoin-git> [bitcoin] Bushstar opened pull request #15981: Use __func__ for log messages (master...replace-all-with-func) https://github.com/bitcoin/bitcoin/pull/15981
2162019-05-08T10:30:24 *** bitcoin-git has left #bitcoin-core-dev
2172019-05-08T10:31:59 *** kevinryan has quit IRC
2182019-05-08T10:32:15 *** kevinryan has joined #bitcoin-core-dev
2192019-05-08T10:37:29 *** kevinryan has quit IRC
2202019-05-08T10:37:53 *** spinza has joined #bitcoin-core-dev
2212019-05-08T10:38:15 *** promag has quit IRC
2222019-05-08T10:39:07 *** promag has joined #bitcoin-core-dev
2232019-05-08T10:40:02 *** kevinryan has joined #bitcoin-core-dev
2242019-05-08T10:46:33 *** kevinryan has quit IRC
2252019-05-08T10:47:08 *** Chris_Stewart_5 has quit IRC
2262019-05-08T10:53:14 *** promag has quit IRC
2272019-05-08T10:56:08 *** davec has joined #bitcoin-core-dev
2282019-05-08T11:02:47 *** promag has joined #bitcoin-core-dev
2292019-05-08T11:03:55 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2302019-05-08T11:06:15 *** promag has quit IRC
2312019-05-08T11:07:34 *** promag has joined #bitcoin-core-dev
2322019-05-08T11:12:22 *** Chris_Stewart_5 has quit IRC
2332019-05-08T11:29:28 *** promag has quit IRC
2342019-05-08T11:33:35 *** promag has joined #bitcoin-core-dev
2352019-05-08T11:47:09 *** promag has quit IRC
2362019-05-08T11:52:52 *** AaronvanW has joined #bitcoin-core-dev
2372019-05-08T11:53:43 *** queip has quit IRC
2382019-05-08T11:53:54 *** lipsch_hth has joined #bitcoin-core-dev
2392019-05-08T11:55:29 *** rafalcpp_ has quit IRC
2402019-05-08T11:55:43 *** rafalcpp_ has joined #bitcoin-core-dev
2412019-05-08T11:59:33 *** Aaronvan_ has joined #bitcoin-core-dev
2422019-05-08T12:00:01 *** Fuchs1 has quit IRC
2432019-05-08T12:00:21 *** lipsch_hth has quit IRC
2442019-05-08T12:00:31 *** rafalcpp has joined #bitcoin-core-dev
2452019-05-08T12:01:19 *** rafalcpp_ has quit IRC
2462019-05-08T12:01:45 *** bitcoin-git has joined #bitcoin-core-dev
2472019-05-08T12:01:46 <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b2a6b0216192...ef802ef5d694
2482019-05-08T12:01:47 <bitcoin-git> bitcoin/master 4f65af9 Hennadii Stepanov: Remove dead code for walletFile check
2492019-05-08T12:01:48 <bitcoin-git> bitcoin/master a0a222e Hennadii Stepanov: Replace deprecated Boost Filesystem function
2502019-05-08T12:01:49 <bitcoin-git> bitcoin/master ef802ef MeshCollider: Merge #15880: utils and libraries: Replace deprecated Boost Filesystem fun...
2512019-05-08T12:01:50 *** bitcoin-git has left #bitcoin-core-dev
2522019-05-08T12:02:03 *** AaronvanW has quit IRC
2532019-05-08T12:02:30 *** bitcoin-git has joined #bitcoin-core-dev
2542019-05-08T12:02:30 <bitcoin-git> [bitcoin] meshcollider merged pull request #15880: utils and libraries: Replace deprecated Boost Filesystem functions (master...20190423-boost-coding-guidelines) https://github.com/bitcoin/bitcoin/pull/15880
2552019-05-08T12:02:32 *** bitcoin-git has left #bitcoin-core-dev
2562019-05-08T12:05:03 *** Leo-WAC-WAC has joined #bitcoin-core-dev
2572019-05-08T12:05:17 *** queip has joined #bitcoin-core-dev
2582019-05-08T12:14:44 *** promag has joined #bitcoin-core-dev
2592019-05-08T12:14:49 *** promag has quit IRC
2602019-05-08T12:15:54 *** michaelfolkson has joined #bitcoin-core-dev
2612019-05-08T12:18:06 *** queip has quit IRC
2622019-05-08T12:18:38 <jonasschnelli> #15512 is waiting on a final review from sipa
2632019-05-08T12:18:41 <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
2642019-05-08T12:18:55 *** rafalcpp has quit IRC
2652019-05-08T12:19:14 *** rafalcpp has joined #bitcoin-core-dev
2662019-05-08T12:20:17 *** bitcoin-git has joined #bitcoin-core-dev
2672019-05-08T12:20:17 <bitcoin-git> [bitcoin] fanquake closed pull request #15979: Replace incorrectly named comment with func (master...replace-with-func) https://github.com/bitcoin/bitcoin/pull/15979
2682019-05-08T12:20:18 *** bitcoin-git has left #bitcoin-core-dev
2692019-05-08T12:20:58 *** queip has joined #bitcoin-core-dev
2702019-05-08T12:21:12 <fanquake> jonasschnelli Could use some more input from you in #15957 when you have a chance.
2712019-05-08T12:21:14 <gribble> https://github.com/bitcoin/bitcoin/issues/15957 | Show "No wallets available" in open menu instead of nothing by meshcollider · Pull Request #15957 · bitcoin/bitcoin · GitHub
2722019-05-08T12:26:04 *** bitcoin-git has joined #bitcoin-core-dev
2732019-05-08T12:26:04 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef802ef5d694...bbb7119ca835
2742019-05-08T12:26:05 <bitcoin-git> bitcoin/master a3592c9 Carl Dong: .gitignore: Don't ignore depends patches
2752019-05-08T12:26:05 <bitcoin-git> bitcoin/master bbb7119 MarcoFalke: Merge #15978: .gitignore: Don't ignore depends patches
2762019-05-08T12:26:07 *** bitcoin-git has left #bitcoin-core-dev
2772019-05-08T12:26:38 *** drexl has joined #bitcoin-core-dev
2782019-05-08T12:26:54 *** bitcoin-git has joined #bitcoin-core-dev
2792019-05-08T12:26:54 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15978: .gitignore: Don't ignore depends patches (master...2019-05-no-ignore-depends-patches) https://github.com/bitcoin/bitcoin/pull/15978
2802019-05-08T12:26:56 *** bitcoin-git has left #bitcoin-core-dev
2812019-05-08T12:32:58 <fanquake> eh https://imgur.com/a/LJSJIKD ?
2822019-05-08T12:33:34 <luke-jr> gmaxwell: how do you prove it's unknown?
2832019-05-08T12:35:05 <gmaxwell> luke-jr: hash of G is sufficient.
2842019-05-08T12:35:33 <gmaxwell> or hash of G concatinated with whatever random number you want, if you want per application randomization for privacy (preferable)
2852019-05-08T12:36:41 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2862019-05-08T12:36:43 <gmaxwell> (it's better to randomize it so that later when you spend third parties can't tell that there wasn't a key-only path)
2872019-05-08T12:40:47 *** jtimon has joined #bitcoin-core-dev
2882019-05-08T12:46:10 *** Guyver2 has joined #bitcoin-core-dev
2892019-05-08T12:50:32 *** jonatack has joined #bitcoin-core-dev
2902019-05-08T12:57:44 *** scoop has joined #bitcoin-core-dev
2912019-05-08T13:02:31 *** justanotheruser has joined #bitcoin-core-dev
2922019-05-08T13:10:59 *** millerti has joined #bitcoin-core-dev
2932019-05-08T13:21:55 *** bitcoin-git has joined #bitcoin-core-dev
2942019-05-08T13:21:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbb7119ca835...49c1aa5f83d0
2952019-05-08T13:21:55 <bitcoin-git> bitcoin/master 62d50ef practicalswift: Add LOCKS_EXCLUDED(cs_main) to LimitValidationInterfaceQueue(...) which do...
2962019-05-08T13:21:56 <bitcoin-git> bitcoin/master 49c1aa5 MarcoFalke: Merge #15971: validation: Add compile-time checking for negative locking r...
2972019-05-08T13:21:57 *** bitcoin-git has left #bitcoin-core-dev
2982019-05-08T13:22:38 *** bitcoin-git has joined #bitcoin-core-dev
2992019-05-08T13:22:38 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15971: validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue (master...negative-locks) https://github.com/bitcoin/bitcoin/pull/15971
3002019-05-08T13:22:39 *** bitcoin-git has left #bitcoin-core-dev
3012019-05-08T13:29:54 *** promag has joined #bitcoin-core-dev
3022019-05-08T13:30:32 <jonasschnelli> fanquake: thanks... I'll have a look at that asap
3032019-05-08T13:34:58 *** promag_ has joined #bitcoin-core-dev
3042019-05-08T13:39:11 *** promag_ has quit IRC
3052019-05-08T13:43:55 *** bitcoin-git has joined #bitcoin-core-dev
3062019-05-08T13:43:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/49c1aa5f83d0...c459c5f70176
3072019-05-08T13:43:56 <bitcoin-git> bitcoin/master 124ea38 Gregory Sanders: change default Python block serialization to witness
3082019-05-08T13:43:57 <bitcoin-git> bitcoin/master c459c5f MarcoFalke: Merge #15664: change default Python block serialization to witness
3092019-05-08T13:43:58 *** bitcoin-git has left #bitcoin-core-dev
3102019-05-08T13:44:29 *** bitcoin-git has joined #bitcoin-core-dev
3112019-05-08T13:44:30 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15664: change default Python block serialization to witness (master...default_wit_block) https://github.com/bitcoin/bitcoin/pull/15664
3122019-05-08T13:44:31 *** bitcoin-git has left #bitcoin-core-dev
3132019-05-08T13:44:37 *** jonatack has quit IRC
3142019-05-08T13:46:15 *** _Sam-- has joined #bitcoin-core-dev
3152019-05-08T13:47:54 <instagibbs> provoostenator, meshcollider re-review beg of #15452
3162019-05-08T13:47:56 <gribble> https://github.com/bitcoin/bitcoin/issues/15452 | Replace CScriptID and CKeyID in CTxDestination with dedicated types by instagibbs · Pull Request #15452 · bitcoin/bitcoin · GitHub
3172019-05-08T14:00:25 *** sdaftuar has quit IRC
3182019-05-08T14:01:13 *** bitcoin-git has joined #bitcoin-core-dev
3192019-05-08T14:01:13 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15982: test: Remove True argument to CBlock::serialize (master...1905-testWitnessTrue) https://github.com/bitcoin/bitcoin/pull/15982
3202019-05-08T14:01:17 *** bitcoin-git has left #bitcoin-core-dev
3212019-05-08T14:01:57 *** promag_ has joined #bitcoin-core-dev
3222019-05-08T14:02:42 *** scoop has quit IRC
3232019-05-08T14:02:49 *** drexl has quit IRC
3242019-05-08T14:05:04 *** drexl_ has joined #bitcoin-core-dev
3252019-05-08T14:23:23 *** sdaftuar has joined #bitcoin-core-dev
3262019-05-08T14:29:58 *** promag_ has quit IRC
3272019-05-08T14:31:43 <luke-jr> does C++ have a way to say "this method can be called with a const or non-const `this`, but the types yielded by it have the same constness"?
3282019-05-08T14:34:14 *** pinheadmz has joined #bitcoin-core-dev
3292019-05-08T14:34:52 *** scoop has joined #bitcoin-core-dev
3302019-05-08T14:35:45 *** spinza has quit IRC
3312019-05-08T14:42:16 *** drexl_ has left #bitcoin-core-dev
3322019-05-08T14:42:33 *** spinza has joined #bitcoin-core-dev
3332019-05-08T14:59:24 *** kevinryan has joined #bitcoin-core-dev
3342019-05-08T15:00:02 *** Leo-WAC-WAC has quit IRC
3352019-05-08T15:02:55 *** kevinryan has quit IRC
3362019-05-08T15:03:15 *** kevinryan has joined #bitcoin-core-dev
3372019-05-08T15:18:09 *** Dimlock has joined #bitcoin-core-dev
3382019-05-08T15:20:28 *** kevinryan has quit IRC
3392019-05-08T15:21:04 *** michaelfolkson has quit IRC
3402019-05-08T15:22:55 *** kevinryan has joined #bitcoin-core-dev
3412019-05-08T15:38:04 *** kevinryan has quit IRC
3422019-05-08T15:41:37 *** shesek has quit IRC
3432019-05-08T15:44:24 *** ccdle12 has joined #bitcoin-core-dev
3442019-05-08T15:58:21 *** laptop500 has quit IRC
3452019-05-08T16:00:52 *** csknk has joined #bitcoin-core-dev
3462019-05-08T16:08:10 *** setpill has quit IRC
3472019-05-08T16:13:10 *** Aaronvan_ is now known as AaronvanW
3482019-05-08T16:13:25 *** scoop has quit IRC
3492019-05-08T16:13:58 *** scoop has joined #bitcoin-core-dev
3502019-05-08T16:21:16 *** michaelfolkson has joined #bitcoin-core-dev
3512019-05-08T16:26:43 *** scoop has quit IRC
3522019-05-08T16:36:39 *** JulioBarros has joined #bitcoin-core-dev
3532019-05-08T16:38:29 *** scoop has joined #bitcoin-core-dev
3542019-05-08T16:42:49 *** scoop has quit IRC
3552019-05-08T16:47:35 *** shesek has joined #bitcoin-core-dev
3562019-05-08T16:54:47 *** scoop has joined #bitcoin-core-dev
3572019-05-08T16:59:09 *** scoop has quit IRC
3582019-05-08T17:03:47 *** Chris_Stewart_5 has quit IRC
3592019-05-08T17:07:23 *** promag_ has joined #bitcoin-core-dev
3602019-05-08T17:07:55 *** jarthur has joined #bitcoin-core-dev
3612019-05-08T17:11:48 *** promag_ has quit IRC
3622019-05-08T17:14:20 *** scoop has joined #bitcoin-core-dev
3632019-05-08T17:17:41 *** timothy has quit IRC
3642019-05-08T17:18:51 *** scoop has quit IRC
3652019-05-08T17:40:15 *** cubancorona has joined #bitcoin-core-dev
3662019-05-08T17:41:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3672019-05-08T17:43:23 <jb55> can you re-org from genesis in principle? there's nothing preventing that in the code right?
3682019-05-08T17:43:55 *** Zenton has quit IRC
3692019-05-08T17:43:55 <sipa> genesis is hardcoded, you can't reorg away from the genesis block
3702019-05-08T17:44:02 <sipa> even if you disable checkpoints
3712019-05-08T17:44:44 <jb55> I mean from one after genesis
3722019-05-08T17:46:07 <sipa> yes
3732019-05-08T17:46:27 <jb55> kk thx
3742019-05-08T17:47:46 *** Elkim has joined #bitcoin-core-dev
3752019-05-08T17:48:17 *** b10c has joined #bitcoin-core-dev
3762019-05-08T17:53:18 *** scoop has joined #bitcoin-core-dev
3772019-05-08T17:54:18 *** scoop has quit IRC
3782019-05-08T17:54:29 *** scoop has joined #bitcoin-core-dev
3792019-05-08T18:00:02 *** Dimlock has quit IRC
3802019-05-08T18:00:34 *** Elkim has left #bitcoin-core-dev
3812019-05-08T18:01:27 *** michaelsdunn1 has joined #bitcoin-core-dev
3822019-05-08T18:03:05 <luke-jr> jb55: checkpoints prevent that, but can be disabled as sipa points out
3832019-05-08T18:07:05 *** csknk has quit IRC
3842019-05-08T18:08:20 *** ccdle12 has quit IRC
3852019-05-08T18:09:24 *** michaelfolkson has quit IRC
3862019-05-08T18:15:53 <phantomcircuit> luke-jr, iirc the checkpoints don't prevent a re-org like that either exactly
3872019-05-08T18:16:59 <sipa> they do
3882019-05-08T18:17:12 <sipa> assumevalid does not
3892019-05-08T18:17:23 <sipa> but checkpoints actually prevent reorging away feom
3902019-05-08T18:19:21 *** shesek has quit IRC
3912019-05-08T18:19:55 *** b_b1 has joined #bitcoin-core-dev
3922019-05-08T18:20:20 *** bitcoin-git has joined #bitcoin-core-dev
3932019-05-08T18:20:20 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15983: build with -fstack-reuse=none (master...1905-buildStackReuseNone) https://github.com/bitcoin/bitcoin/pull/15983
3942019-05-08T18:20:33 *** bitcoin-git has left #bitcoin-core-dev
3952019-05-08T18:22:01 *** scoop has quit IRC
3962019-05-08T18:22:35 *** scoop has joined #bitcoin-core-dev
3972019-05-08T18:23:24 *** bitcoin-git has joined #bitcoin-core-dev
3982019-05-08T18:23:24 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15959: refactor: Work around gcc compiler bug 90348 (master...1905-gccBugWorkaround) https://github.com/bitcoin/bitcoin/pull/15959
3992019-05-08T18:23:25 *** bitcoin-git has left #bitcoin-core-dev
4002019-05-08T18:27:39 *** scoop has quit IRC
4012019-05-08T18:30:42 *** scoop has joined #bitcoin-core-dev
4022019-05-08T18:47:01 *** michaelfolkson has joined #bitcoin-core-dev
4032019-05-08T18:47:01 *** b10c has quit IRC
4042019-05-08T18:47:04 *** cubancorona has quit IRC
4052019-05-08T18:47:26 *** cubancorona has joined #bitcoin-core-dev
4062019-05-08T18:55:51 *** hebasto has joined #bitcoin-core-dev
4072019-05-08T19:00:44 *** EagleTM has joined #bitcoin-core-dev
4082019-05-08T19:02:05 *** roconnor has joined #bitcoin-core-dev
4092019-05-08T19:07:31 *** scoop has quit IRC
4102019-05-08T19:08:03 *** scoop has joined #bitcoin-core-dev
4112019-05-08T19:09:16 *** scoop has quit IRC
4122019-05-08T19:09:27 *** scoop has joined #bitcoin-core-dev
4132019-05-08T19:10:52 *** queip has quit IRC
4142019-05-08T19:12:01 *** rafalcpp_ has joined #bitcoin-core-dev
4152019-05-08T19:12:27 *** rafalcpp has quit IRC
4162019-05-08T19:15:39 *** Lightlike has joined #bitcoin-core-dev
4172019-05-08T19:20:11 *** scoop has quit IRC
4182019-05-08T19:30:37 *** queip has joined #bitcoin-core-dev
4192019-05-08T19:41:43 *** ovovo has quit IRC
4202019-05-08T19:46:46 *** Zenton has joined #bitcoin-core-dev
4212019-05-08T19:46:58 *** shesek has joined #bitcoin-core-dev
4222019-05-08T19:47:58 *** laptop500 has joined #bitcoin-core-dev
4232019-05-08T19:50:02 *** fanquake has quit IRC
4242019-05-08T19:51:23 *** fanquake has joined #bitcoin-core-dev
4252019-05-08T19:56:03 *** Emcy has quit IRC
4262019-05-08T19:56:39 *** Emcy has joined #bitcoin-core-dev
4272019-05-08T20:01:28 *** bitcoin-git has joined #bitcoin-core-dev
4282019-05-08T20:01:29 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c459c5f70176...08788ce1701a
4292019-05-08T20:01:29 <bitcoin-git> bitcoin/master e0bb279 David A. Harding: Doc: remove text about txes always relayed from -whitelist
4302019-05-08T20:01:30 <bitcoin-git> bitcoin/master 08788ce MarcoFalke: Merge #15890: Doc: remove text about txes always relayed from -whitelist
4312019-05-08T20:01:32 *** bitcoin-git has left #bitcoin-core-dev
4322019-05-08T20:02:08 *** bitcoin-git has joined #bitcoin-core-dev
4332019-05-08T20:02:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15890: Doc: remove text about txes always relayed from -whitelist (master...2019-04-whitelist-help) https://github.com/bitcoin/bitcoin/pull/15890
4342019-05-08T20:02:10 *** bitcoin-git has left #bitcoin-core-dev
4352019-05-08T20:03:47 *** scoop has joined #bitcoin-core-dev
4362019-05-08T20:07:55 *** scoop has quit IRC
4372019-05-08T20:11:54 *** DougieBot5000_ has joined #bitcoin-core-dev
4382019-05-08T20:15:03 *** waxwing has quit IRC
4392019-05-08T20:15:03 *** baldur has quit IRC
4402019-05-08T20:15:03 *** rockhouse has quit IRC
4412019-05-08T20:15:03 *** votesmith has quit IRC
4422019-05-08T20:15:28 *** rafalcpp_ has quit IRC
4432019-05-08T20:15:29 *** DougieBot5000 has quit IRC
4442019-05-08T20:15:29 *** gnusha has quit IRC
4452019-05-08T20:15:39 *** rockhouse has joined #bitcoin-core-dev
4462019-05-08T20:16:14 *** rafalcpp_ has joined #bitcoin-core-dev
4472019-05-08T20:17:15 *** gnusha has joined #bitcoin-core-dev
4482019-05-08T20:18:34 *** scoop has joined #bitcoin-core-dev
4492019-05-08T20:20:38 *** votesmith has joined #bitcoin-core-dev
4502019-05-08T20:21:22 *** waxwing has joined #bitcoin-core-dev
4512019-05-08T20:21:54 *** waxwing has quit IRC
4522019-05-08T20:21:55 *** waxwing has joined #bitcoin-core-dev
4532019-05-08T20:22:23 *** hebasto has quit IRC
4542019-05-08T20:22:58 *** scoop has quit IRC
4552019-05-08T20:27:35 *** baldur has joined #bitcoin-core-dev
4562019-05-08T20:33:13 *** bitcoin-git has joined #bitcoin-core-dev
4572019-05-08T20:33:13 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15984: net: Remove -whitelistrelay (master...1905-netWhitelistRelay) https://github.com/bitcoin/bitcoin/pull/15984
4582019-05-08T20:33:14 *** bitcoin-git has left #bitcoin-core-dev
4592019-05-08T20:34:30 *** scoop has joined #bitcoin-core-dev
4602019-05-08T20:34:35 *** scoop has quit IRC
4612019-05-08T20:44:19 *** bitcoin-git has joined #bitcoin-core-dev
4622019-05-08T20:44:19 <bitcoin-git> [bitcoin] sipa opened pull request #15985: Add test for GCC bug 90348 (master...201905_gccbug90348) https://github.com/bitcoin/bitcoin/pull/15985
4632019-05-08T20:44:32 *** bitcoin-git has left #bitcoin-core-dev
4642019-05-08T21:00:01 *** b_b1 has quit IRC
4652019-05-08T21:00:12 <MarcoFalke> gmaxwell: Wouldn't the (blocksonly) border node need to accept txs from whitelisted wallets?
4662019-05-08T21:00:52 <MarcoFalke> Also, if blocksonly is recommended for security or resource conversation, it shouldn't be a hidden debug option
4672019-05-08T21:01:43 <MarcoFalke> Anyway, I tend to agree with your idea to make whitelisting more specific
4682019-05-08T21:03:13 *** Chris_Stewart_5 has quit IRC
4692019-05-08T21:03:20 <MarcoFalke> But that should probably happen on a per-node basis. E.g. whitelistfortxrelay=${Node_Address}:{Whitelist_Level}
4702019-05-08T21:04:46 <gmaxwell> It shouldn't be hidden.
4712019-05-08T21:05:13 <gmaxwell> MarcoFalke: not levels, flags, most things whitelisty things are not ordereable.
4722019-05-08T21:05:42 <gmaxwell> It's hidden because of historical reasons, I'd forgotten it was. it's frequently recommended.
4732019-05-08T21:05:56 <MarcoFalke> So that should be changed first, I guess
4742019-05-08T21:07:13 <gmaxwell> Flags would be pretty awesome.
4752019-05-08T21:11:16 *** hashist has joined #bitcoin-core-dev
4762019-05-08T21:21:46 *** bitcoin-git has joined #bitcoin-core-dev
4772019-05-08T21:21:46 <bitcoin-git> [bitcoin] sipa opened pull request #15986: Add unmodified-descriptor-with-checksum to getdescriptorinfo (master...201905_justchecksum) https://github.com/bitcoin/bitcoin/pull/15986
4782019-05-08T21:21:47 *** bitcoin-git has left #bitcoin-core-dev
4792019-05-08T21:23:22 *** thaumavorio_ is now known as thaumavorio
4802019-05-08T21:26:30 *** michaelfolkson has quit IRC
4812019-05-08T21:35:02 *** bushstar has quit IRC
4822019-05-08T21:42:26 *** bitcoin-git has joined #bitcoin-core-dev
4832019-05-08T21:42:26 <bitcoin-git> [bitcoin] luke-jr opened pull request #15987: Wallet, GUI: Warn when sending to already-used Bitcoin addresses (also RPC: include such information in getaddressinfo) (master...wallet_no_reuse) https://github.com/bitcoin/bitcoin/pull/15987
4842019-05-08T21:42:27 *** bitcoin-git has left #bitcoin-core-dev
4852019-05-08T21:44:12 <gmaxwell> \O/
4862019-05-08T21:47:47 *** indolering has joined #bitcoin-core-dev
4872019-05-08T22:04:09 *** spinza has quit IRC
4882019-05-08T22:04:57 *** side^effects has joined #bitcoin-core-dev
4892019-05-08T22:07:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4902019-05-08T22:12:30 *** spinza has joined #bitcoin-core-dev
4912019-05-08T22:18:49 *** Chris_Stewart_5 has quit IRC
4922019-05-08T22:26:20 *** michaelsdunn1 has quit IRC
4932019-05-08T22:30:23 *** Guyver2 has quit IRC
4942019-05-08T22:40:03 *** Dean_Guss has quit IRC
4952019-05-08T22:42:57 *** Lightlike has quit IRC
4962019-05-08T22:43:35 *** michaelfolkson has joined #bitcoin-core-dev
4972019-05-08T22:49:41 *** JulioBarros has quit IRC
4982019-05-08T22:51:15 *** michaelfolkson has quit IRC
4992019-05-08T23:00:04 *** bushstar has joined #bitcoin-core-dev
5002019-05-08T23:02:35 *** scoop has joined #bitcoin-core-dev
5012019-05-08T23:03:59 *** jarthur_ has joined #bitcoin-core-dev
5022019-05-08T23:04:51 *** bushstar has quit IRC
5032019-05-08T23:06:13 *** scoop has quit IRC
5042019-05-08T23:06:19 *** scoop has joined #bitcoin-core-dev
5052019-05-08T23:07:20 *** jarthur has quit IRC
5062019-05-08T23:08:33 *** jarthur_ has quit IRC
5072019-05-08T23:17:00 *** laptop500 has quit IRC
5082019-05-08T23:18:19 *** jarthur has joined #bitcoin-core-dev
5092019-05-08T23:19:14 *** scoop has quit IRC
5102019-05-08T23:32:05 *** scoop has joined #bitcoin-core-dev
5112019-05-08T23:36:12 *** scoop has quit IRC
5122019-05-08T23:40:09 *** dfsg has joined #bitcoin-core-dev
5132019-05-08T23:40:58 *** dfsg has left #bitcoin-core-dev
5142019-05-08T23:41:15 *** booyah has joined #bitcoin-core-dev
5152019-05-08T23:43:52 *** murrayn has quit IRC
5162019-05-08T23:50:04 *** scoop has joined #bitcoin-core-dev
5172019-05-08T23:52:56 *** scoop has quit IRC
5182019-05-08T23:55:27 *** scoop has joined #bitcoin-core-dev