12019-05-09T00:00:02 *** indolering has quit IRC
22019-05-09T00:00:29 *** jarthur has quit IRC
32019-05-09T00:02:32 *** jarthur has joined #bitcoin-core-dev
42019-05-09T00:08:58 *** jarthur has quit IRC
52019-05-09T00:17:39 *** ajbiz11 has joined #bitcoin-core-dev
62019-05-09T00:27:17 *** AaronvanW has quit IRC
72019-05-09T00:31:38 *** scoop has quit IRC
82019-05-09T00:32:51 *** scoop has joined #bitcoin-core-dev
92019-05-09T00:36:06 *** scoop has quit IRC
102019-05-09T00:37:06 *** scoop has joined #bitcoin-core-dev
112019-05-09T00:43:37 *** scoop has quit IRC
122019-05-09T00:56:36 *** scoop has joined #bitcoin-core-dev
132019-05-09T00:59:53 *** DougieBot5000_ is now known as DougieBot5000
142019-05-09T01:00:52 *** scoop has quit IRC
152019-05-09T01:04:02 *** ccdle12 has joined #bitcoin-core-dev
162019-05-09T01:09:22 *** scoop has joined #bitcoin-core-dev
172019-05-09T01:14:20 *** millerti has quit IRC
182019-05-09T01:15:07 *** EagleTM has quit IRC
192019-05-09T01:17:27 *** fanquake has quit IRC
202019-05-09T01:26:07 *** michaelfolkson has joined #bitcoin-core-dev
212019-05-09T01:53:03 *** jtimon has quit IRC
222019-05-09T02:07:27 *** fanquake has joined #bitcoin-core-dev
232019-05-09T02:11:14 *** jarthur has joined #bitcoin-core-dev
242019-05-09T02:20:46 *** michaelfolkson has quit IRC
252019-05-09T02:42:08 *** scoop has quit IRC
262019-05-09T02:45:53 *** fanquake has quit IRC
272019-05-09T02:46:49 *** fanquake has joined #bitcoin-core-dev
282019-05-09T03:00:01 *** ajbiz11 has quit IRC
292019-05-09T03:00:34 *** bushstar has joined #bitcoin-core-dev
302019-05-09T03:05:39 *** fanquake has quit IRC
312019-05-09T03:06:03 *** Apocalyptic has quit IRC
322019-05-09T03:07:24 *** kierra has joined #bitcoin-core-dev
332019-05-09T03:07:48 *** kierra is now known as Guest43444
342019-05-09T03:11:54 *** AaronvanW has joined #bitcoin-core-dev
352019-05-09T03:14:03 *** scoop has joined #bitcoin-core-dev
362019-05-09T03:14:19 *** fanquake has joined #bitcoin-core-dev
372019-05-09T03:15:14 *** fanquake has quit IRC
382019-05-09T03:15:31 *** fanquake has joined #bitcoin-core-dev
392019-05-09T03:25:35 *** fanquake has quit IRC
402019-05-09T03:25:57 *** fanquake has joined #bitcoin-core-dev
412019-05-09T03:35:59 *** fanquake has quit IRC
422019-05-09T03:39:07 *** fanquake has joined #bitcoin-core-dev
432019-05-09T03:40:36 <gmaxwell> re https://github.com/bitcoin/bitcoin/pull/15985 ... it's not great if almost all our travis runs are using sanitizers, they radically change the compilers behavior (as that PR observes)
442019-05-09T03:42:06 *** AaronvanW has quit IRC
452019-05-09T03:47:20 *** Apocalyptic has joined #bitcoin-core-dev
462019-05-09T04:00:50 *** scoop has quit IRC
472019-05-09T04:02:18 *** scoop has joined #bitcoin-core-dev
482019-05-09T04:02:55 *** ccdle12 has quit IRC
492019-05-09T04:04:36 *** scoop has quit IRC
502019-05-09T04:05:36 *** jarthur has quit IRC
512019-05-09T04:05:51 *** scoop has joined #bitcoin-core-dev
522019-05-09T04:06:17 *** jarthur has joined #bitcoin-core-dev
532019-05-09T04:09:45 *** jimmysong_ has joined #bitcoin-core-dev
542019-05-09T04:10:03 *** scoop has quit IRC
552019-05-09T04:12:53 *** jimmysong has quit IRC
562019-05-09T04:16:32 *** jarthur has quit IRC
572019-05-09T04:29:40 *** StopAndDecrypt has quit IRC
582019-05-09T04:29:51 *** StopAndDecrypt has joined #bitcoin-core-dev
592019-05-09T04:30:00 *** StopAndDecrypt has quit IRC
602019-05-09T04:30:00 *** StopAndDecrypt has joined #bitcoin-core-dev
612019-05-09T05:00:49 *** jarthur has joined #bitcoin-core-dev
622019-05-09T05:13:32 *** jarthur has quit IRC
632019-05-09T05:39:32 *** AaronvanW has joined #bitcoin-core-dev
642019-05-09T05:43:03 *** spinza has quit IRC
652019-05-09T05:49:54 *** pinheadmz has quit IRC
662019-05-09T05:53:04 *** spinza has joined #bitcoin-core-dev
672019-05-09T05:57:21 *** murrayn has joined #bitcoin-core-dev
682019-05-09T05:57:21 *** murrayn has joined #bitcoin-core-dev
692019-05-09T06:00:01 *** Guest43444 has quit IRC
702019-05-09T06:04:17 *** EagleTM has joined #bitcoin-core-dev
712019-05-09T06:13:11 *** AaronvanW has quit IRC
722019-05-09T06:18:04 *** jungnam has joined #bitcoin-core-dev
732019-05-09T06:21:15 *** EagleTM has quit IRC
742019-05-09T06:21:39 *** pinheadmz has joined #bitcoin-core-dev
752019-05-09T06:35:05 *** jeremyrubin has quit IRC
762019-05-09T06:44:32 *** spaced0ut has quit IRC
772019-05-09T06:55:21 *** hebasto has joined #bitcoin-core-dev
782019-05-09T06:56:08 *** jeremyrubin has joined #bitcoin-core-dev
792019-05-09T07:01:14 *** promag_ has joined #bitcoin-core-dev
802019-05-09T07:06:43 *** fanquake has quit IRC
812019-05-09T07:19:23 *** promag has quit IRC
822019-05-09T07:31:23 *** pinheadmz has quit IRC
832019-05-09T07:32:16 *** Dean_Guss has joined #bitcoin-core-dev
842019-05-09T07:47:36 *** ExEric3 has quit IRC
852019-05-09T07:48:20 *** ExEric3 has joined #bitcoin-core-dev
862019-05-09T07:49:09 *** ccdle12 has joined #bitcoin-core-dev
872019-05-09T07:53:38 *** ExEric3 has quit IRC
882019-05-09T07:56:55 *** ExEric3 has joined #bitcoin-core-dev
892019-05-09T07:59:16 *** knight__ has joined #bitcoin-core-dev
902019-05-09T07:59:23 *** ccdle12 has quit IRC
912019-05-09T07:59:39 *** ccdle12 has joined #bitcoin-core-dev
922019-05-09T08:00:18 *** kevinryan has joined #bitcoin-core-dev
932019-05-09T08:01:39 *** laptop500 has joined #bitcoin-core-dev
942019-05-09T08:03:51 *** setpill has joined #bitcoin-core-dev
952019-05-09T08:10:27 *** AaronvanW has joined #bitcoin-core-dev
962019-05-09T08:14:59 *** ExEric3 has quit IRC
972019-05-09T08:18:42 *** fanquake has joined #bitcoin-core-dev
982019-05-09T08:20:54 *** promag has joined #bitcoin-core-dev
992019-05-09T08:29:34 *** promag has quit IRC
1002019-05-09T08:30:48 *** promag has joined #bitcoin-core-dev
1012019-05-09T08:37:00 *** promag has quit IRC
1022019-05-09T08:38:00 *** promag has joined #bitcoin-core-dev
1032019-05-09T08:39:07 *** ExEric3 has joined #bitcoin-core-dev
1042019-05-09T08:43:47 *** AaronvanW has quit IRC
1052019-05-09T08:44:31 *** justanotheruser has quit IRC
1062019-05-09T08:50:45 *** timothy has joined #bitcoin-core-dev
1072019-05-09T08:52:12 *** ccdle12_ has joined #bitcoin-core-dev
1082019-05-09T08:52:14 *** ccdle12 has quit IRC
1092019-05-09T08:55:03 *** kevinryan has quit IRC
1102019-05-09T09:00:02 *** jungnam has quit IRC
1112019-05-09T09:03:14 *** kevinryan has joined #bitcoin-core-dev
1122019-05-09T09:05:59 *** hashist has quit IRC
1132019-05-09T09:12:27 *** jb55 has quit IRC
1142019-05-09T09:19:48 <booyah> perhaps tests should be run few times, for normal build, for ASAN, for UBSAN+TSAN
1152019-05-09T09:22:29 *** jpthor has joined #bitcoin-core-dev
1162019-05-09T09:28:16 *** ccdle12_ has quit IRC
1172019-05-09T09:31:31 *** AaronvanW has joined #bitcoin-core-dev
1182019-05-09T09:31:42 *** sunetoft has joined #bitcoin-core-dev
1192019-05-09T09:38:42 *** jpthor has quit IRC
1202019-05-09T09:39:26 *** jb55 has joined #bitcoin-core-dev
1212019-05-09T09:41:16 *** Guyver2 has joined #bitcoin-core-dev
1222019-05-09T09:51:42 *** AaronvanW has quit IRC
1232019-05-09T09:51:59 *** AaronvanW has joined #bitcoin-core-dev
1242019-05-09T09:53:16 <gmaxwell> sipa: fun fact, buggy cpus exist where rdrand actually returns an error https://github.com/systemd/systemd/issues/11810#issuecomment-490165413 (also fun fact, systemd apparently iplements is own 'rng' call that uses rdrand only when available, and is caused to fail by this)
1252019-05-09T09:55:57 *** kevinryan has quit IRC
1262019-05-09T09:59:30 *** kevinryan has joined #bitcoin-core-dev
1272019-05-09T10:10:33 *** sunetoft has quit IRC
1282019-05-09T10:14:11 *** spinza has quit IRC
1292019-05-09T10:14:38 *** aljungberg has joined #bitcoin-core-dev
1302019-05-09T10:16:23 *** kevinryan has quit IRC
1312019-05-09T10:16:40 *** kevinryan has joined #bitcoin-core-dev
1322019-05-09T10:19:14 *** ExEric3 has quit IRC
1332019-05-09T10:19:41 *** ExEric3 has joined #bitcoin-core-dev
1342019-05-09T10:22:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1352019-05-09T10:22:32 <wumpus> this was just a matter of time, using RDRAND only always was a bad idea
1362019-05-09T10:24:28 <wumpus> good for them the chip start returnsing an error instead of just predictable data
1372019-05-09T10:24:53 <wumpus> that would have been a much more subtle and hard to detect scenario
1382019-05-09T10:26:33 *** kevinryan has quit IRC
1392019-05-09T10:26:36 *** michaelfolkson has joined #bitcoin-core-dev
1402019-05-09T10:27:20 *** kevinryan has joined #bitcoin-core-dev
1412019-05-09T10:27:29 *** Deinogalerix21 has joined #bitcoin-core-dev
1422019-05-09T10:29:27 <gmaxwell> yeah, it returns an error, but most code doesn't check.
1432019-05-09T10:30:05 <gmaxwell> We recently added checks for the error condition because I went and read the intel docs, previously the code was just modeled after code sipa read elsewhere. (for our use, it's less critical to do any error handling)
1442019-05-09T10:31:28 <wumpus> right, failing to check is a less serious issue if it's only one of many randomness sources used, although you'd still want to detect "all random sources failed"
1452019-05-09T10:31:42 *** kevinryan has quit IRC
1462019-05-09T10:34:28 <gmaxwell> unfortunately some sources are "cannot ever fail" which of course means there is no way to tell if they failed. :P
1472019-05-09T10:34:35 <wumpus> https://software.intel.com/en-us/blogs/2014/01/13/rdrand-do-i-need-to-check-the-carry-flag-or-can-i-just-check-for-zero this makes my head hurt, apparently early RDRAND implementations could not return 0 as an actual random value
1482019-05-09T10:35:22 <gmaxwell> yep.
1492019-05-09T10:35:47 *** spinza has joined #bitcoin-core-dev
1502019-05-09T10:35:47 <gmaxwell> which is obnoxious when you really want actually uniform randomness, not close but no cigar uniformity.
1512019-05-09T10:35:49 <wumpus> at least it's 64 bit so a value of 0 is *very* unlikely, this is much worse for 32 bit APIs (where I've seen this too), but it's a stupid kind of bias
1522019-05-09T10:36:25 <wumpus> yes
1532019-05-09T10:40:00 <gmaxwell> the stm32 stuff seemed moderately concerning to me. (stuff in the trezor)
1542019-05-09T10:41:37 <gmaxwell> with weird rules about not using the first value out, and strange comments refreencing a LFSR...
1552019-05-09T10:44:30 *** Deinogalerix21 has quit IRC
1562019-05-09T10:44:35 <wumpus> ouch
1572019-05-09T10:49:27 <wumpus> you can generally trust hardware vendors to do the cheapest thing possible that they can get away with for ancillary functions like hw rng, in any case it's a black box, the most surprising thing is a way-too-common assumption "it's hardware randomness so it must be good!"
1582019-05-09T10:52:38 <wumpus> having some unlocked PLL feed into a LFSR sounds like a nice and cheap solution to get some random-ish output
1592019-05-09T11:05:47 *** scoop has joined #bitcoin-core-dev
1602019-05-09T11:10:10 *** scoop has quit IRC
1612019-05-09T11:27:05 *** mryandao has quit IRC
1622019-05-09T11:27:35 *** mryandao has joined #bitcoin-core-dev
1632019-05-09T11:30:31 *** bitcoin-git has joined #bitcoin-core-dev
1642019-05-09T11:30:32 <bitcoin-git> [bitcoin] ryanofsky opened pull request #15988: Add test for ArgsManager::GetChainName (master...pr/testset2) https://github.com/bitcoin/bitcoin/pull/15988
1652019-05-09T11:30:33 *** bitcoin-git has left #bitcoin-core-dev
1662019-05-09T11:33:28 *** kevinryan has joined #bitcoin-core-dev
1672019-05-09T11:55:29 *** Chris_Stewart_5 has quit IRC
1682019-05-09T11:57:22 *** promag has quit IRC
1692019-05-09T11:57:34 <fanquake> hey wumpus. 15766, 15794 & 15452 probably mergable
1702019-05-09T12:00:01 *** aljungberg has quit IRC
1712019-05-09T12:02:19 *** spaced0ut has joined #bitcoin-core-dev
1722019-05-09T12:06:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1732019-05-09T12:06:38 *** quaid1 has joined #bitcoin-core-dev
1742019-05-09T12:13:53 *** Chris_Stewart_5 has quit IRC
1752019-05-09T12:20:40 *** Guyver2 has quit IRC
1762019-05-09T12:24:46 *** michaelfolkson has quit IRC
1772019-05-09T12:29:05 *** michaelfolkson has joined #bitcoin-core-dev
1782019-05-09T12:40:06 *** ccdle12 has joined #bitcoin-core-dev
1792019-05-09T12:43:42 *** jonatack has joined #bitcoin-core-dev
1802019-05-09T12:50:34 *** justanotheruser has joined #bitcoin-core-dev
1812019-05-09T12:50:41 *** jonatack has quit IRC
1822019-05-09T12:51:12 *** cubancorona has quit IRC
1832019-05-09T12:52:38 *** ccdle12 has quit IRC
1842019-05-09T12:53:19 *** ccdle12 has joined #bitcoin-core-dev
1852019-05-09T12:59:32 *** promag has joined #bitcoin-core-dev
1862019-05-09T13:00:32 *** qu4ku has joined #bitcoin-core-dev
1872019-05-09T13:00:46 *** kevinryan has quit IRC
1882019-05-09T13:10:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1892019-05-09T13:19:18 *** scoop has joined #bitcoin-core-dev
1902019-05-09T13:19:58 *** jonatack has joined #bitcoin-core-dev
1912019-05-09T13:20:39 *** ExEric3 has quit IRC
1922019-05-09T13:23:15 *** kevinryan has joined #bitcoin-core-dev
1932019-05-09T13:56:38 *** ccdle12_ has joined #bitcoin-core-dev
1942019-05-09T13:57:53 *** ccdle12 has quit IRC
1952019-05-09T13:58:33 *** pinheadmz has joined #bitcoin-core-dev
1962019-05-09T13:59:34 *** qu4ku has quit IRC
1972019-05-09T14:10:55 *** kevinryan has quit IRC
1982019-05-09T14:16:46 *** bitcoin-git has joined #bitcoin-core-dev
1992019-05-09T14:16:46 <bitcoin-git> [bitcoin] hebasto opened pull request #15989: RPC: Do not use cookie auth if -rpcauth set (master...20190509-rpcauth) https://github.com/bitcoin/bitcoin/pull/15989
2002019-05-09T14:16:47 *** bitcoin-git has left #bitcoin-core-dev
2012019-05-09T14:28:09 *** jonatack has quit IRC
2022019-05-09T14:30:34 *** kevinryan has joined #bitcoin-core-dev
2032019-05-09T14:35:42 *** bitcoin-git has joined #bitcoin-core-dev
2042019-05-09T14:35:42 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15990: Add tests and documentation for blocksonly (master...1905-docTestBlocksOnly) https://github.com/bitcoin/bitcoin/pull/15990
2052019-05-09T14:35:43 *** bitcoin-git has left #bitcoin-core-dev
2062019-05-09T14:40:20 *** michaelsdunn1 has joined #bitcoin-core-dev
2072019-05-09T14:42:22 *** ccdle12_ has quit IRC
2082019-05-09T14:50:18 *** Guyver2 has joined #bitcoin-core-dev
2092019-05-09T14:53:18 *** kevinryan has quit IRC
2102019-05-09T14:54:00 *** ccdle12 has joined #bitcoin-core-dev
2112019-05-09T15:00:02 *** quaid1 has quit IRC
2122019-05-09T15:04:55 *** quaid1 has joined #bitcoin-core-dev
2132019-05-09T15:08:16 *** kevinryan has joined #bitcoin-core-dev
2142019-05-09T15:11:03 *** kevinryan has quit IRC
2152019-05-09T15:11:19 *** kevinryan has joined #bitcoin-core-dev
2162019-05-09T15:12:04 *** kevinrya_ has joined #bitcoin-core-dev
2172019-05-09T15:12:04 *** kevinryan has quit IRC
2182019-05-09T15:17:08 *** ccdle12 has quit IRC
2192019-05-09T15:30:19 *** bitcoin-git has joined #bitcoin-core-dev
2202019-05-09T15:30:19 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/08788ce1701a...a65fd92f7b8e
2212019-05-09T15:30:20 <bitcoin-git> bitcoin/master beda0da Hennadii Stepanov: Upgrade gitian image before signing
2222019-05-09T15:30:20 <bitcoin-git> bitcoin/master a65fd92 Wladimir J. van der Laan: Merge #15766: scripts and tools: Upgrade gitian image before signing
2232019-05-09T15:30:22 *** bitcoin-git has left #bitcoin-core-dev
2242019-05-09T15:31:16 *** bitcoin-git has joined #bitcoin-core-dev
2252019-05-09T15:31:16 <bitcoin-git> [bitcoin] laanwj merged pull request #15766: scripts and tools: Upgrade gitian image before signing (master...20190407-gitian-upgrade-image) https://github.com/bitcoin/bitcoin/pull/15766
2262019-05-09T15:31:17 *** bitcoin-git has left #bitcoin-core-dev
2272019-05-09T15:35:32 *** scoop has quit IRC
2282019-05-09T15:36:38 *** setpill has quit IRC
2292019-05-09T15:36:42 *** sdaftuar has quit IRC
2302019-05-09T15:38:43 *** bitcoin-git has joined #bitcoin-core-dev
2312019-05-09T15:38:43 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15991: Bugfix: fix pruneblockchain returned prune height (master...2019/05/pruning_test) https://github.com/bitcoin/bitcoin/pull/15991
2322019-05-09T15:38:48 *** bitcoin-git has left #bitcoin-core-dev
2332019-05-09T15:40:55 *** jnewbery has quit IRC
2342019-05-09T15:47:11 *** millerti has joined #bitcoin-core-dev
2352019-05-09T16:04:38 *** bitcoin-git has joined #bitcoin-core-dev
2362019-05-09T16:04:38 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a65fd92f7b8e...aebe990dfeb4
2372019-05-09T16:04:39 <bitcoin-git> bitcoin/master f4a230b Carl Dong: docs: Clarify PR guidelines w/re documentation
2382019-05-09T16:04:39 <bitcoin-git> bitcoin/master aebe990 Wladimir J. van der Laan: Merge #15794: docs: Clarify PR guidelines w/re documentation
2392019-05-09T16:04:41 *** bitcoin-git has left #bitcoin-core-dev
2402019-05-09T16:05:16 *** bitcoin-git has joined #bitcoin-core-dev
2412019-05-09T16:05:17 <bitcoin-git> [bitcoin] laanwj merged pull request #15794: docs: Clarify PR guidelines w/re documentation (master...2019-04-doc-doc) https://github.com/bitcoin/bitcoin/pull/15794
2422019-05-09T16:05:18 *** bitcoin-git has left #bitcoin-core-dev
2432019-05-09T16:11:31 *** kevinrya_ has quit IRC
2442019-05-09T16:13:52 *** WalkingCoin has joined #bitcoin-core-dev
2452019-05-09T16:14:07 *** kevinryan has joined #bitcoin-core-dev
2462019-05-09T16:18:28 *** kevinryan has quit IRC
2472019-05-09T16:27:33 *** bitcoin-git has joined #bitcoin-core-dev
2482019-05-09T16:27:33 <bitcoin-git> [bitcoin] Empact opened pull request #15992: Refactor (master...relay-inventory) https://github.com/bitcoin/bitcoin/pull/15992
2492019-05-09T16:27:35 *** bitcoin-git has left #bitcoin-core-dev
2502019-05-09T16:28:40 *** promag_ has joined #bitcoin-core-dev
2512019-05-09T16:31:03 *** Dean_Guss has quit IRC
2522019-05-09T16:40:45 *** WalkingCoin has quit IRC
2532019-05-09T16:41:34 <hebasto> promag: hi, could you elaborate your latest comment in #15684?
2542019-05-09T16:41:36 <gribble> https://github.com/bitcoin/bitcoin/issues/15684 | doc/dependencies: Fix typo libsrvg->librsvg by luke-jr · Pull Request #15684 · bitcoin/bitcoin · GitHub
2552019-05-09T16:42:48 <hebasto> The main purpose of GetDataDir() is to create the datadir, right?
2562019-05-09T16:43:44 <hebasto> promag: #15864 not 15684
2572019-05-09T16:43:47 <gribble> https://github.com/bitcoin/bitcoin/issues/15864 | Fix datadir handling by hebasto · Pull Request #15864 · bitcoin/bitcoin · GitHub
2582019-05-09T16:49:35 *** bitcoin-git has joined #bitcoin-core-dev
2592019-05-09T16:49:35 <bitcoin-git> [bitcoin] hebasto opened pull request #15993: net: Drop the ancient miniUPnPc API version support (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993
2602019-05-09T16:49:38 *** bitcoin-git has left #bitcoin-core-dev
2612019-05-09T16:50:03 *** roconnor has quit IRC
2622019-05-09T16:52:18 *** CubicEarth has quit IRC
2632019-05-09T16:55:28 *** bitcoin-git has joined #bitcoin-core-dev
2642019-05-09T16:55:28 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/aebe990dfeb4...de5af41e3567
2652019-05-09T16:55:29 <bitcoin-git> bitcoin/master 70946e7 Gregory Sanders: Replace CScriptID and CKeyID in CTxDestination with dedicated types
2662019-05-09T16:55:29 <bitcoin-git> bitcoin/master 78e407a Gregory Sanders: GetKeyBirthTimes should return key ids, not destinations
2672019-05-09T16:55:30 <bitcoin-git> bitcoin/master de5af41 Wladimir J. van der Laan: Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicate...
2682019-05-09T16:55:31 *** bitcoin-git has left #bitcoin-core-dev
2692019-05-09T16:55:58 *** bitcoin-git has joined #bitcoin-core-dev
2702019-05-09T16:55:58 <bitcoin-git> [bitcoin] laanwj merged pull request #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types (master...key_script_dest) https://github.com/bitcoin/bitcoin/pull/15452
2712019-05-09T16:55:59 *** bitcoin-git has left #bitcoin-core-dev
2722019-05-09T17:01:31 *** timothy has quit IRC
2732019-05-09T17:05:36 *** CubicEarth has joined #bitcoin-core-dev
2742019-05-09T17:14:26 *** roconnor has joined #bitcoin-core-dev
2752019-05-09T17:14:57 *** michaelfolkson has quit IRC
2762019-05-09T17:21:47 *** scoop has joined #bitcoin-core-dev
2772019-05-09T17:24:54 *** Flatbyte has joined #bitcoin-core-dev
2782019-05-09T17:25:53 *** promag_ has quit IRC
2792019-05-09T17:26:00 *** scoop has quit IRC
2802019-05-09T17:26:20 *** promag_ has joined #bitcoin-core-dev
2812019-05-09T17:30:15 *** Flatbyte has quit IRC
2822019-05-09T17:32:23 *** Chris_Stewart_5 has quit IRC
2832019-05-09T17:34:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2842019-05-09T17:37:42 *** promag_ has quit IRC
2852019-05-09T17:38:48 *** ExEric3 has joined #bitcoin-core-dev
2862019-05-09T17:40:07 *** Flatbyte has joined #bitcoin-core-dev
2872019-05-09T17:45:56 *** EagleTM has joined #bitcoin-core-dev
2882019-05-09T17:59:59 *** StopAndDecrypt has joined #bitcoin-core-dev
2892019-05-09T18:00:02 *** quaid1 has quit IRC
2902019-05-09T18:11:04 *** promag_ has joined #bitcoin-core-dev
2912019-05-09T18:14:44 <harding> sipa: will OP_CLTV and OP_CSV still require OP_DROP in tapscript? If so, it seems a tiny bit unfair counting that as two opcodes towards the opcode limit (although that seems like a very minor unfairness).
2922019-05-09T18:15:33 *** promag_ has quit IRC
2932019-05-09T18:22:35 *** scoop has joined #bitcoin-core-dev
2942019-05-09T18:26:42 *** roconnor has quit IRC
2952019-05-09T18:27:16 *** scoop has quit IRC
2962019-05-09T18:28:41 *** gribble has quit IRC
2972019-05-09T18:32:25 *** gdude2002 has joined #bitcoin-core-dev
2982019-05-09T18:33:36 *** gribble has joined #bitcoin-core-dev
2992019-05-09T18:34:44 <sipa> harding: yes
3002019-05-09T18:39:12 *** hashist has joined #bitcoin-core-dev
3012019-05-09T18:39:36 *** hashist has left #bitcoin-core-dev
3022019-05-09T18:39:55 *** instagibbs has quit IRC
3032019-05-09T18:46:02 *** Flatbyte has quit IRC
3042019-05-09T18:46:22 *** instagibbs has joined #bitcoin-core-dev
3052019-05-09T18:56:01 <moneyball> wumpus: fyi one topic was proposed the past week ... topic proposed by MarcoFalke: windows 32 bit
3062019-05-09T18:57:18 <wumpus> ok
3072019-05-09T18:57:20 <wumpus> thanks !
3082019-05-09T18:57:56 <sipa> harding: there are many 'unfair' things in the scripting language i'm sure and nits to improve, but i fear a bikeshedding fest if we go into those
3092019-05-09T18:58:41 *** tryphe_ has joined #bitcoin-core-dev
3102019-05-09T18:59:57 *** nkohen has joined #bitcoin-core-dev
3112019-05-09T19:00:17 *** tryphe has quit IRC
3122019-05-09T19:01:18 <wumpus> #startmeeting
3132019-05-09T19:01:18 <lightningbot> Meeting started Thu May 9 19:01:18 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3142019-05-09T19:01:18 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3152019-05-09T19:01:52 <jonasschnelli> hi
3162019-05-09T19:02:02 <sipa> hi
3172019-05-09T19:02:14 <achow101> hi
3182019-05-09T19:02:20 <luke-jr> hello there
3192019-05-09T19:02:22 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
3202019-05-09T19:02:29 <Chris_Stewart_5> hello
3212019-05-09T19:02:39 <meshcollider> hi
3222019-05-09T19:03:37 <wumpus> any proposed topics?
3232019-05-09T19:03:45 <wumpus> (besides moneyball's)
3242019-05-09T19:03:54 <MarcoFalke> hi
3252019-05-09T19:03:55 <luke-jr> MarcoFalke's*
3262019-05-09T19:04:15 <kanzure> hi
3272019-05-09T19:04:19 <kanzure> i have a small topic later about topics
3282019-05-09T19:04:31 <luke-jr> ._.
3292019-05-09T19:04:49 <kanzure> it's just topic collection for upcoming physical meeting.
3302019-05-09T19:04:57 <wumpus> #topic high priority for review
3312019-05-09T19:05:37 <wumpus> currently: #15427 #15024 #15006 #15512 #15870
3322019-05-09T19:05:39 <gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
3332019-05-09T19:05:42 <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
3342019-05-09T19:05:44 <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
3352019-05-09T19:05:49 <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
3362019-05-09T19:05:51 <gribble> https://github.com/bitcoin/bitcoin/issues/15870 | wallet: Only fail rescan when blocks have actually been pruned by MarcoFalke · Pull Request #15870 · bitcoin/bitcoin · GitHub
3372019-05-09T19:06:05 <wumpus> anything to add/remove/remark?
3382019-05-09T19:06:06 <instagibbs> hi
3392019-05-09T19:06:43 <sipa> looks good to me, i'll try to go through those soon
3402019-05-09T19:06:58 <wumpus> thanks
3412019-05-09T19:08:19 <wumpus> that's all about this topic, I guess
3422019-05-09T19:08:27 <wumpus> please help review those ^^
3432019-05-09T19:08:49 <wumpus> #topic windows 32 bit (MarcoFalke)
3442019-05-09T19:09:13 <MarcoFalke> There has been at least one user who is running Bitcoin Core on windows 32 bit
3452019-05-09T19:09:16 <wumpus> #15939
3462019-05-09T19:09:19 <gribble> https://github.com/bitcoin/bitcoin/issues/15939 | gitian: Remove Windows 32 bit build by MarcoFalke · Pull Request #15939 · bitcoin/bitcoin · GitHub
3472019-05-09T19:09:36 <MarcoFalke> I didn't expect that initially
3482019-05-09T19:09:40 *** _jnewbery has joined #bitcoin-core-dev
3492019-05-09T19:09:43 <wumpus> I've said what I wanted to say here: https://github.com/bitcoin/bitcoin/pull/15939#issuecomment-489568065
3502019-05-09T19:09:46 <luke-jr> MarcoFalke: does Windows still support 32-bit only?
3512019-05-09T19:10:04 <MarcoFalke> Windows 10 can be installed as 32 bit
3522019-05-09T19:10:42 <luke-jr> on 32-bit only CPUs?
3532019-05-09T19:10:43 <wumpus> e.g. there's good reason to only support MacOS and Windows on one architecture
3542019-05-09T19:11:08 <jonasschnelli> Yes
3552019-05-09T19:11:17 <MarcoFalke> So we ask users to upgrade their windows to 64 bit or buy new hardware?
3562019-05-09T19:11:24 <jonasschnelli> Also,... do we care about that "one" user?
3572019-05-09T19:11:30 <wumpus> that there's one windows 32 user left, well, I'm sorry for them :(
3582019-05-09T19:11:41 <MarcoFalke> A lot might be shy to report
3592019-05-09T19:12:05 <wumpus> come on, the last x86 hardware that didn't support 64 bit is from 2005 or so?
3602019-05-09T19:12:33 <wumpus> you can buy a raspberry pi 3 for <$100 and have faster hardware
3612019-05-09T19:12:36 *** roconnor has joined #bitcoin-core-dev
3622019-05-09T19:12:55 <wumpus> and 64 bit ARM, at that
3632019-05-09T19:13:05 <MarcoFalke> Yeah
3642019-05-09T19:13:10 <wumpus> so, yeah, let's drop it
3652019-05-09T19:13:14 <booyah> why not support, is it about resources to gitian build?
3662019-05-09T19:13:19 <MarcoFalke> Enough for this topic
3672019-05-09T19:13:22 <wumpus> no, read my post
3682019-05-09T19:13:23 <MarcoFalke> booyah: No, testing
3692019-05-09T19:13:37 <wumpus> computer resources don't matter
3702019-05-09T19:13:47 *** esnapolinaire has joined #bitcoin-core-dev
3712019-05-09T19:13:50 <sipa> in 2011 apparently the last general computing intel cpu that was 32-bit only was introduced (some atom)
3722019-05-09T19:14:14 <wumpus> yes... so.. next topic
3732019-05-09T19:14:19 <luke-jr> booyah: the question at the end of the day is, if there's a problem, is anyone willing to deal with it?
3742019-05-09T19:14:33 <MarcoFalke> [15:04] <kanzure> i have a small topic later about topics
3752019-05-09T19:14:45 <wumpus> #topic a topic about topics (kanzure)
3762019-05-09T19:14:47 <achow101> there was at least one complaint about win32 support on bitcointalk.
3772019-05-09T19:14:49 <ryanofsky> are there 32 bit versions of windows running on 64 bit hardware that can now no longer run bitccoin?
3782019-05-09T19:15:10 *** spinza has quit IRC
3792019-05-09T19:15:25 *** esnapolinaire has left #bitcoin-core-dev
3802019-05-09T19:15:28 *** wallet42 has joined #bitcoin-core-dev
3812019-05-09T19:15:33 <MarcoFalke> achow101: Link?
3822019-05-09T19:15:46 <luke-jr> if anyone is willing to support Win32, we should keep supporting it; if not, we can't realistically :p
3832019-05-09T19:15:54 <meshcollider> Presumably there'd be at least a few out there
3842019-05-09T19:16:28 <achow101> MarcoFalke: https://bitcointalk.org/index.php?topic=5139689.0 although I'm not sure whether the OP is just wondering why there is no win32 or whether they need win32
3852019-05-09T19:16:38 <wumpus> so the question is: is anyone willing to test and support windows 32, an debug problems that happen on it?
3862019-05-09T19:16:39 <ryanofsky> ok just responding to sipa's note about 2011 hardware, wondering if the last 32 bit windows was also released around that time or if it would matter
3872019-05-09T19:16:58 <wumpus> if no, it doesn't matter that 1 or 2 people are still using it
3882019-05-09T19:17:05 <luke-jr> I suppose there's a side question of: does testing Win32 identify any general code issues that other tests don't?
3892019-05-09T19:17:07 <ryanofsky> ok happy to move on
3902019-05-09T19:17:09 <achow101> ryanofsky: windows still makes 32 bit releases. you can download windows 10 32 bit
3912019-05-09T19:17:16 <wumpus> yes, let's move on
3922019-05-09T19:17:19 <wumpus> kanzure: you had a topic?
3932019-05-09T19:17:39 *** kexkey has joined #bitcoin-core-dev
3942019-05-09T19:18:10 <wumpus> luke-jr: not more than ARM or Linux x86 32 identifies
3952019-05-09T19:19:40 <sipa> arguably win64 should catch more things (it's the only 64 bit platform where a 'long' is 32 bits)
3962019-05-09T19:20:53 <sipa> kanzure: ^
3972019-05-09T19:21:13 <luke-jr> I think he just wanted to solicit topics for Amsterdam
3982019-05-09T19:21:35 <MarcoFalke> close meeting?
3992019-05-09T19:21:46 <wumpus> #endmeeting
4002019-05-09T19:21:46 <lightningbot> Meeting ended Thu May 9 19:21:46 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4012019-05-09T19:21:46 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-09-19.01.html
4022019-05-09T19:21:46 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-09-19.01.txt
4032019-05-09T19:21:46 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-09-19.01.log.html
4042019-05-09T19:21:49 <sipa> let's assume he does, so #action: send topics for Amsterdam to kanzure
4052019-05-09T19:21:58 <sipa> i like these short meetings
4062019-05-09T19:22:41 *** spinza has joined #bitcoin-core-dev
4072019-05-09T19:22:45 <gwillen> so in principle, people still on 32-bit windows could build it htemselves, right?
4082019-05-09T19:22:50 <gwillen> (except it's probably a big pain in the ass)
4092019-05-09T19:22:51 *** bitcoin-git has joined #bitcoin-core-dev
4102019-05-09T19:22:52 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/de5af41e3567...79046d574980
4112019-05-09T19:22:52 <bitcoin-git> bitcoin/master faf666f MarcoFalke: Remove Windows 32 bit build
4122019-05-09T19:22:53 <bitcoin-git> bitcoin/master fa193dc MarcoFalke: doc: Remove win32 from the release process
4132019-05-09T19:22:53 <bitcoin-git> bitcoin/master 79046d5 Wladimir J. van der Laan: Merge #15939: gitian: Remove Windows 32 bit build
4142019-05-09T19:22:56 *** bitcoin-git has left #bitcoin-core-dev
4152019-05-09T19:23:05 <wumpus> gwillen: maybe? does MSVC still support 32 bit?
4162019-05-09T19:23:25 <MarcoFalke> msvc is only for debug builds
4172019-05-09T19:23:28 <gwillen> well, if they're on a 32-bit platform they probably have an old MSVC to go with it
4182019-05-09T19:23:45 *** bitcoin-git has joined #bitcoin-core-dev
4192019-05-09T19:23:45 <bitcoin-git> [bitcoin] laanwj merged pull request #15939: gitian: Remove Windows 32 bit build (master...1904-GitianWin) https://github.com/bitcoin/bitcoin/pull/15939
4202019-05-09T19:23:47 *** bitcoin-git has left #bitcoin-core-dev
4212019-05-09T19:23:55 *** hebasto has quit IRC
4222019-05-09T19:24:53 <kanzure> sipa: yeah that's all it was, i thought it didn't need explanation :)
4232019-05-09T19:25:56 <wumpus> pretty sure sipsorcery & other MSVC builders only use windows 64, too, also, anything x86 32-bit-only is going to be too slow to either compile bitcoin core or do the initial sync
4242019-05-09T19:26:05 <wumpus> it's just a non issue
4252019-05-09T19:28:03 <gmaxwell> luke-jr: are you going to provide win32 builds of knots?
4262019-05-09T19:28:34 <luke-jr> gmaxwell: I am presently. I might so long as they continue to build, TBD
4272019-05-09T19:29:17 <luke-jr> (and then just drop them when they fail to build or someone reports them broken)
4282019-05-09T19:29:26 <instagibbs> If I were to remove bumpfee's totalFee argument, should I put it behind deprecation for a single release?
4292019-05-09T19:29:39 <instagibbs> just in case someone actually uses it?
4302019-05-09T19:29:43 <gmaxwell> I agree with wumpus on this but I also agree that a few complaints mean that there probably are a fair number of users, it would be nice if they had options.
4312019-05-09T19:30:53 <luke-jr> I suppose when there's something broken, we can always revisit the topic then
4322019-05-09T19:30:59 *** _jnewbery has quit IRC
4332019-05-09T19:31:33 *** promag_ has joined #bitcoin-core-dev
4342019-05-09T19:32:21 <ryanofsky> instagibbs, that seems like a good idea assuming it's not difficult to do
4352019-05-09T19:33:15 <wumpus> instagibbs: yes, that'd be the normal way to do it, deprecate it for one release then remove it the next
4362019-05-09T19:33:19 <instagibbs> is there a doc on deprecation procedure or a great example?
4372019-05-09T19:33:24 <instagibbs> of something in master
4382019-05-09T19:35:21 <luke-jr> git grep Deprec
4392019-05-09T19:36:15 <instagibbs> ok seems to be one example in master, thanks
4402019-05-09T19:36:49 <wumpus> deprecation can be as simple as mentioning it in the RPC help for the method and in the release notes
4412019-05-09T19:37:29 <wumpus> there's also IsDeprecatedRPCEnabled(...) but that's for deprecating entire entry points, not individual arguments
4422019-05-09T19:38:27 <instagibbs> looks like it's used for hiding "size" value of mempool entries under "size" label
4432019-05-09T19:39:45 <gwillen> luke-jr: my guess is the answer for people complaining will be "you can upgrade one final time to knots 0.18, and if you ever need 0.19 you're probably on your own"
4442019-05-09T19:40:23 <gwillen> and given that older versions will continue to function for a long time unless there are major forking changes in the future, and even then should somewhat function
4452019-05-09T19:40:29 <gwillen> this doesn't seem unreasonable
4462019-05-09T19:41:57 <luke-jr> I don't really expect Win32 to break unless we go out of the way to break it, anyway
4472019-05-09T19:42:02 <luke-jr> so it might even work with 0.19 *shrug*
4482019-05-09T19:42:24 <ryanofsky> i think it'd be fine to use IsDeprecatedRPCEnabled / Chain::rpcEnableDeprecated, it just needs a string describing the deprecated feature, not necessary a method name
4492019-05-09T19:44:08 *** scoop has joined #bitcoin-core-dev
4502019-05-09T19:48:38 *** scoop has quit IRC
4512019-05-09T20:06:11 <jonasschnelli> would someone be opposed to add a generatetowallet call?
4522019-05-09T20:07:51 <wumpus> didn't we deprecate mining to wallet only very shortly ago?
4532019-05-09T20:07:59 <wumpus> (or rather, even, remove)
4542019-05-09T20:09:40 *** omonk has quit IRC
4552019-05-09T20:10:36 <instagibbs> it was *just* removed
4562019-05-09T20:10:36 <instagibbs> lol
4572019-05-09T20:10:36 <ryanofsky> i think part of the motivation for #15492 was that non-wallet code was calling wallet code
4582019-05-09T20:10:38 <gribble> https://github.com/bitcoin/bitcoin/issues/15492 | [rpc] remove deprecated generate method by Sjors · Pull Request #15492 · bitcoin/bitcoin · GitHub
4592019-05-09T20:12:01 <ryanofsky> so if the call was handled in the wallet, maybe it would be ok?
4602019-05-09T20:12:25 *** promag_ has quit IRC
4612019-05-09T20:12:48 *** omonk has joined #bitcoin-core-dev
4622019-05-09T20:14:28 <wumpus> generate is only used in test code isn't it? I'm not sure it warrants adding additional RPCs
4632019-05-09T20:14:51 <instagibbs> it's very easy to chain generatetoaddress with getnewaddress, imo
4642019-05-09T20:14:59 <instagibbs> functional tests implicitly do this already
4652019-05-09T20:15:18 <wumpus> right
4662019-05-09T20:30:15 *** Guyver2 has quit IRC
4672019-05-09T20:37:18 *** nkohen has quit IRC
4682019-05-09T20:41:47 *** michaelsdunn1 has quit IRC
4692019-05-09T20:42:21 *** bitcoin-git has joined #bitcoin-core-dev
4702019-05-09T20:42:21 <bitcoin-git> [bitcoin] sipsorcery opened pull request #15995: systemd service script: set usable permissions on /etc/bitcoin config dir (master...systemdconfig) https://github.com/bitcoin/bitcoin/pull/15995
4712019-05-09T20:42:22 *** bitcoin-git has left #bitcoin-core-dev
4722019-05-09T20:46:47 *** promag_ has joined #bitcoin-core-dev
4732019-05-09T20:48:52 *** bitcoin-git has joined #bitcoin-core-dev
4742019-05-09T20:48:52 <bitcoin-git> [bitcoin] instagibbs opened pull request #15996: Deprecate totalfee argument in `bumpfee` (master...deprecate_totalfee) https://github.com/bitcoin/bitcoin/pull/15996
4752019-05-09T20:48:53 *** bitcoin-git has left #bitcoin-core-dev
4762019-05-09T20:55:58 *** bitcoin-git has joined #bitcoin-core-dev
4772019-05-09T20:55:58 <bitcoin-git> [bitcoin] promag opened pull request #15997: refactor: GuessVerificationProgress requires cs_main lock (master...2019-05-gvp) https://github.com/bitcoin/bitcoin/pull/15997
4782019-05-09T20:55:59 *** bitcoin-git has left #bitcoin-core-dev
4792019-05-09T21:00:01 *** gdude2002 has quit IRC
4802019-05-09T21:03:08 *** KaizenNaka has joined #bitcoin-core-dev
4812019-05-09T21:12:33 *** tss1 has joined #bitcoin-core-dev
4822019-05-09T21:12:44 *** scoop has joined #bitcoin-core-dev
4832019-05-09T21:13:34 *** tryphe_ is now known as tryphe
4842019-05-09T21:30:44 *** bitcoin-git has joined #bitcoin-core-dev
4852019-05-09T21:30:44 <bitcoin-git> [bitcoin] promag opened pull request #15998: refactor: Drop trivial X macro (master...2019-05-x) https://github.com/bitcoin/bitcoin/pull/15998
4862019-05-09T21:30:57 *** bitcoin-git has left #bitcoin-core-dev
4872019-05-09T21:32:16 *** Chris_Stewart_5 has quit IRC
4882019-05-09T21:33:48 *** KaizenNaka has quit IRC
4892019-05-09T21:34:37 *** bushstar has quit IRC
4902019-05-09T21:35:51 *** Tralfaz has joined #bitcoin-core-dev
4912019-05-09T21:36:48 *** promag_ has quit IRC
4922019-05-09T21:37:40 *** victorSN has quit IRC
4932019-05-09T21:37:40 *** rockhouse has quit IRC
4942019-05-09T21:39:01 *** Tralfaz has quit IRC
4952019-05-09T21:55:41 *** bitcoin-git has joined #bitcoin-core-dev
4962019-05-09T21:55:41 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15999: init: Remove dead code in LoadChainTip (master...1905-initNoDead) https://github.com/bitcoin/bitcoin/pull/15999
4972019-05-09T21:55:42 *** bitcoin-git has left #bitcoin-core-dev
4982019-05-09T22:01:13 *** rhavar has joined #bitcoin-core-dev
4992019-05-09T22:07:48 *** jnewbery has joined #bitcoin-core-dev
5002019-05-09T22:09:16 *** emzy has quit IRC
5012019-05-09T22:09:49 *** bitcoin-git has joined #bitcoin-core-dev
5022019-05-09T22:09:49 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15998: refactor: Drop trivial X macro (master...2019-05-x) https://github.com/bitcoin/bitcoin/pull/15998
5032019-05-09T22:09:52 *** bitcoin-git has left #bitcoin-core-dev
5042019-05-09T22:12:56 *** bitcoin-git has joined #bitcoin-core-dev
5052019-05-09T22:12:56 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15933: Make chain state immutable outside of validation (master...1905-immVal) https://github.com/bitcoin/bitcoin/pull/15933
5062019-05-09T22:12:57 *** bitcoin-git has left #bitcoin-core-dev
5072019-05-09T22:16:30 <MarcoFalke> Someone should add the `generate` method to the gui
5082019-05-09T22:16:47 <MarcoFalke> Would save me a lot of typing
5092019-05-09T22:18:37 <MarcoFalke> #16000
5102019-05-09T22:18:38 <gribble> https://github.com/bitcoin/bitcoin/issues/16000 | GUI: Add generate method · Issue #16000 · bitcoin/bitcoin · GitHub
5112019-05-09T22:19:37 <sipa> heh?
5122019-05-09T22:20:07 <sipa> any reason to specifically have that in the GUI?
5132019-05-09T22:20:20 <sipa> seems much easier to automate through RPC
5142019-05-09T22:24:43 <gmaxwell> maybe you should make it run it if you click the bitcoin logo ten times in quick succession.
5152019-05-09T22:25:27 <MarcoFalke> Lol, I am not trolling. It was removed from the rpc
5162019-05-09T22:27:10 <luke-jr> what is the use caseâ?
5172019-05-09T22:27:27 <sipa> MarcoFalke: a bash oneliner will work fin?
5182019-05-09T22:27:53 *** irc_viewer_test has joined #bitcoin-core-dev
5192019-05-09T22:28:09 <MarcoFalke> Excuse me? I am not using bash, that is for peasants
5202019-05-09T22:28:24 <sipa> lol
5212019-05-09T22:29:02 <MarcoFalke> I run my tests in the gui because it has autocomplete
5222019-05-09T22:30:04 * sipa checks if this is actually MarcoFalke
5232019-05-09T22:30:30 <luke-jr> >implying bash doesn't autocomplete
5242019-05-09T22:30:43 <luke-jr> how do you even run the tests in the GUI?
5252019-05-09T22:30:58 <gmaxwell> I doubt anyone has created a bash-completion module for bitcoin-cli :)
5262019-05-09T22:31:09 <MarcoFalke> I mean manual tests
5272019-05-09T22:31:15 <luke-jr> gmaxwell: it's in the git repo..
5282019-05-09T22:31:23 <MarcoFalke> to run the functional tests in the gui you pass BITCOIND=bitcoin-qt
5292019-05-09T22:31:55 <gmaxwell> luke-jr: oh lol
5302019-05-09T22:32:13 <luke-jr> has been for years
5312019-05-09T22:32:27 <luke-jr> it just queries bitcoin-cli for the possible commands
5322019-05-09T22:32:28 *** spinza has quit IRC
5332019-05-09T22:35:20 *** knight__ has quit IRC
5342019-05-09T22:35:36 *** knight__ has joined #bitcoin-core-dev
5352019-05-09T22:38:22 *** irc_viewer_test has quit IRC
5362019-05-09T22:49:38 *** spinza has joined #bitcoin-core-dev
5372019-05-09T22:59:39 *** Zenton has quit IRC
5382019-05-09T22:59:44 *** bushstar has joined #bitcoin-core-dev
5392019-05-09T23:02:19 *** laptop500 has quit IRC
5402019-05-09T23:04:04 *** bushstar has quit IRC
5412019-05-09T23:18:14 *** irc_viewer_test has joined #bitcoin-core-dev
5422019-05-09T23:21:12 *** jtash has joined #bitcoin-core-dev
5432019-05-09T23:22:43 *** jtash has joined #bitcoin-core-dev
5442019-05-09T23:24:50 *** d_t has joined #bitcoin-core-dev
5452019-05-09T23:26:02 *** irc_viewer_test has quit IRC
5462019-05-09T23:35:41 *** michaelfolkson has joined #bitcoin-core-dev
5472019-05-09T23:37:16 *** jtash has quit IRC
5482019-05-09T23:39:50 *** scoop has quit IRC
5492019-05-09T23:40:11 *** ccdle12 has joined #bitcoin-core-dev
5502019-05-09T23:44:00 *** scoop has joined #bitcoin-core-dev
5512019-05-09T23:49:15 *** scoop has quit IRC
5522019-05-09T23:49:27 *** cc has joined #bitcoin-core-dev
5532019-05-09T23:49:51 *** cc is now known as Guest80232
5542019-05-09T23:52:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5552019-05-09T23:53:23 *** scoop has joined #bitcoin-core-dev
5562019-05-09T23:59:37 *** kexkey has quit IRC