12019-05-30T00:00:02  *** toony1 has quit IRC
  22019-05-30T00:02:50  *** jarthur has quit IRC
  32019-05-30T00:04:04  *** engil1 has joined #bitcoin-core-dev
  42019-05-30T00:04:07  *** Lightsword has quit IRC
  52019-05-30T00:04:21  *** Lightsword has joined #bitcoin-core-dev
  62019-05-30T00:08:21  *** icek has joined #bitcoin-core-dev
  72019-05-30T00:12:14  *** pinheadmz has joined #bitcoin-core-dev
  82019-05-30T00:13:19  *** scoop has quit IRC
  92019-05-30T00:14:08  *** scoop has joined #bitcoin-core-dev
 102019-05-30T00:16:19  *** scoop has quit IRC
 112019-05-30T00:17:30  *** d_t has joined #bitcoin-core-dev
 122019-05-30T00:17:41  *** ghost43 has quit IRC
 132019-05-30T00:17:56  *** ghost43 has joined #bitcoin-core-dev
 142019-05-30T00:26:08  *** Chris_Stewart_5 has quit IRC
 152019-05-30T00:29:27  *** AaronvanW has joined #bitcoin-core-dev
 162019-05-30T00:31:51  *** murrayn is now known as murray
 172019-05-30T00:32:17  *** cltrbreak_MAD2 is now known as ctrlbreak
 182019-05-30T00:32:21  *** murray is now known as Guest45886
 192019-05-30T00:32:47  *** michaelfolkson has joined #bitcoin-core-dev
 202019-05-30T00:33:12  *** Guest45886 is now known as murrayn
 212019-05-30T00:34:08  *** AaronvanW has quit IRC
 222019-05-30T00:34:57  *** luke-jr has quit IRC
 232019-05-30T00:35:44  *** luke-jr has joined #bitcoin-core-dev
 242019-05-30T00:38:20  *** ccdle12 has quit IRC
 252019-05-30T00:38:34  *** luke-jr has quit IRC
 262019-05-30T00:41:00  *** luke-jr has joined #bitcoin-core-dev
 272019-05-30T00:43:47  *** d_t_ has joined #bitcoin-core-dev
 282019-05-30T00:43:48  *** spinza has quit IRC
 292019-05-30T00:44:28  *** ddustin_ has joined #bitcoin-core-dev
 302019-05-30T00:45:44  *** ddustin has quit IRC
 312019-05-30T00:46:42  *** dgenr8 has quit IRC
 322019-05-30T00:46:42  *** d_t has quit IRC
 332019-05-30T00:46:43  *** luke-jr has quit IRC
 342019-05-30T00:47:06  *** dgenr8 has joined #bitcoin-core-dev
 352019-05-30T00:47:22  *** luke-jr has joined #bitcoin-core-dev
 362019-05-30T00:50:06  *** jtimon has quit IRC
 372019-05-30T00:51:28  *** luke-jr has quit IRC
 382019-05-30T00:52:35  *** luke-jr has joined #bitcoin-core-dev
 392019-05-30T00:52:54  *** bitbee has quit IRC
 402019-05-30T00:53:20  *** spinza has joined #bitcoin-core-dev
 412019-05-30T00:53:25  *** bitbee has joined #bitcoin-core-dev
 422019-05-30T00:54:23  *** luke-jr has quit IRC
 432019-05-30T00:55:08  *** luke-jr has joined #bitcoin-core-dev
 442019-05-30T01:00:27  *** luke-jr has quit IRC
 452019-05-30T01:00:54  *** luke-jr has joined #bitcoin-core-dev
 462019-05-30T01:01:13  *** jb55 has quit IRC
 472019-05-30T01:02:40  *** luke-jr has quit IRC
 482019-05-30T01:03:16  *** luke-jr has joined #bitcoin-core-dev
 492019-05-30T01:05:35  *** sean8219 has joined #bitcoin-core-dev
 502019-05-30T01:08:50  *** luke-jr has quit IRC
 512019-05-30T01:09:46  *** luke-jr has joined #bitcoin-core-dev
 522019-05-30T01:13:58  *** luke-jr has quit IRC
 532019-05-30T01:15:10  *** bitcoin-git has joined #bitcoin-core-dev
 542019-05-30T01:15:10  <bitcoin-git> [bitcoin] Empact opened pull request #16123: Return error information on descriptor parse error (master...descriptor-parse-error) https://github.com/bitcoin/bitcoin/pull/16123
 552019-05-30T01:15:11  *** bitcoin-git has left #bitcoin-core-dev
 562019-05-30T01:16:34  *** justanotheruser has joined #bitcoin-core-dev
 572019-05-30T01:18:18  *** luke-jr has joined #bitcoin-core-dev
 582019-05-30T01:21:19  *** bg002h has joined #bitcoin-core-dev
 592019-05-30T01:23:34  *** AaronvanW has joined #bitcoin-core-dev
 602019-05-30T01:24:21  *** justan0theruser has joined #bitcoin-core-dev
 612019-05-30T01:24:58  *** justanotheruser has quit IRC
 622019-05-30T01:28:22  *** jb55 has joined #bitcoin-core-dev
 632019-05-30T01:35:14  *** michaelfolkson has quit IRC
 642019-05-30T01:38:44  *** ccdle12 has joined #bitcoin-core-dev
 652019-05-30T01:43:23  *** ccdle12 has quit IRC
 662019-05-30T01:43:50  *** sean8219 has quit IRC
 672019-05-30T01:44:10  *** openminded has joined #bitcoin-core-dev
 682019-05-30T01:46:31  *** openminded has quit IRC
 692019-05-30T01:46:50  *** openminded has joined #bitcoin-core-dev
 702019-05-30T01:48:04  *** ddustin_ has quit IRC
 712019-05-30T01:48:44  *** openminded has quit IRC
 722019-05-30T01:48:50  *** ddustin has joined #bitcoin-core-dev
 732019-05-30T01:49:03  *** sean8219 has joined #bitcoin-core-dev
 742019-05-30T01:53:47  *** sean8219 has quit IRC
 752019-05-30T01:53:52  *** ddustin has quit IRC
 762019-05-30T01:54:12  *** ddustin has joined #bitcoin-core-dev
 772019-05-30T01:54:49  *** ddustin has quit IRC
 782019-05-30T01:55:36  *** ddustin has joined #bitcoin-core-dev
 792019-05-30T01:55:40  *** sean8219 has joined #bitcoin-core-dev
 802019-05-30T01:56:10  *** ddustin has quit IRC
 812019-05-30T01:56:47  *** ddustin has joined #bitcoin-core-dev
 822019-05-30T01:56:49  *** teardown has joined #bitcoin-core-dev
 832019-05-30T01:57:16  *** AaronvanW has quit IRC
 842019-05-30T01:59:58  *** reitoukousen has joined #bitcoin-core-dev
 852019-05-30T02:03:45  *** sean8219 has quit IRC
 862019-05-30T02:06:33  *** reitoukousen has quit IRC
 872019-05-30T02:07:38  *** sean8219 has joined #bitcoin-core-dev
 882019-05-30T02:11:06  *** d_t_ has quit IRC
 892019-05-30T02:20:42  *** sean8219 has quit IRC
 902019-05-30T02:32:22  *** sean8219 has joined #bitcoin-core-dev
 912019-05-30T02:33:37  *** scoop has joined #bitcoin-core-dev
 922019-05-30T02:36:37  *** sean8219 has quit IRC
 932019-05-30T02:37:11  *** scoop has quit IRC
 942019-05-30T02:37:17  *** scoop has joined #bitcoin-core-dev
 952019-05-30T02:38:25  *** sean8219 has joined #bitcoin-core-dev
 962019-05-30T02:40:15  *** sean8219 has quit IRC
 972019-05-30T02:40:47  *** AaronvanW has joined #bitcoin-core-dev
 982019-05-30T02:45:20  *** AaronvanW has quit IRC
 992019-05-30T02:49:26  *** sean8219 has joined #bitcoin-core-dev
1002019-05-30T02:50:01  *** sean8219 has quit IRC
1012019-05-30T02:51:50  *** sean8219 has joined #bitcoin-core-dev
1022019-05-30T02:52:42  *** ddustin has quit IRC
1032019-05-30T02:53:17  *** TheRec has quit IRC
1042019-05-30T02:53:21  *** ddustin has joined #bitcoin-core-dev
1052019-05-30T02:57:09  *** sean8219 has quit IRC
1062019-05-30T02:59:01  *** sean8219 has joined #bitcoin-core-dev
1072019-05-30T03:00:01  *** engil1 has quit IRC
1082019-05-30T03:01:15  *** sean8219 has quit IRC
1092019-05-30T03:04:01  *** DragonEyes1 has joined #bitcoin-core-dev
1102019-05-30T03:05:10  *** sean8219 has joined #bitcoin-core-dev
1112019-05-30T03:05:33  *** TheRec has joined #bitcoin-core-dev
1122019-05-30T03:05:49  *** scoop has quit IRC
1132019-05-30T03:06:15  *** scoop has joined #bitcoin-core-dev
1142019-05-30T03:09:27  *** justan0theruser is now known as justanotheruser
1152019-05-30T03:10:22  *** scoop has quit IRC
1162019-05-30T03:13:57  *** sean8219 has quit IRC
1172019-05-30T03:14:30  *** sean8219 has joined #bitcoin-core-dev
1182019-05-30T03:17:13  *** sean8219 has joined #bitcoin-core-dev
1192019-05-30T03:18:17  *** sean8219 has quit IRC
1202019-05-30T03:25:00  *** sean8219 has joined #bitcoin-core-dev
1212019-05-30T03:27:07  *** ccdle12 has joined #bitcoin-core-dev
1222019-05-30T03:32:16  *** ccdle12 has quit IRC
1232019-05-30T03:34:54  *** AaronvanW has joined #bitcoin-core-dev
1242019-05-30T03:39:03  *** sean8219 has quit IRC
1252019-05-30T03:40:00  *** kljasdfvv has quit IRC
1262019-05-30T03:40:42  *** kljasdfvv has joined #bitcoin-core-dev
1272019-05-30T03:45:10  *** sean8219 has joined #bitcoin-core-dev
1282019-05-30T03:56:19  *** Eagle[TM] has joined #bitcoin-core-dev
1292019-05-30T03:58:38  *** EagleTM has quit IRC
1302019-05-30T04:05:06  *** michaelfolkson has joined #bitcoin-core-dev
1312019-05-30T04:08:07  *** AaronvanW has quit IRC
1322019-05-30T04:08:21  *** sean8219 has quit IRC
1332019-05-30T04:11:10  *** sean8219 has joined #bitcoin-core-dev
1342019-05-30T04:16:14  *** michaelfolkson has quit IRC
1352019-05-30T04:31:19  *** ccdle12 has joined #bitcoin-core-dev
1362019-05-30T04:31:58  *** sean8219 has quit IRC
1372019-05-30T04:32:27  *** michaelfolkson has joined #bitcoin-core-dev
1382019-05-30T04:32:28  *** michaelfolkson has quit IRC
1392019-05-30T04:38:30  *** sean8219 has joined #bitcoin-core-dev
1402019-05-30T04:39:19  *** sean8219_ has joined #bitcoin-core-dev
1412019-05-30T04:40:21  *** sean8219_ has quit IRC
1422019-05-30T04:41:22  *** sean8219 has quit IRC
1432019-05-30T04:59:02  *** AaronvanW has joined #bitcoin-core-dev
1442019-05-30T05:03:25  *** AaronvanW has quit IRC
1452019-05-30T05:21:57  *** bitcoin-git has joined #bitcoin-core-dev
1462019-05-30T05:21:58  <bitcoin-git> [bitcoin] Empact closed pull request #16123: Return error information on descriptor parse error (master...descriptor-parse-error) https://github.com/bitcoin/bitcoin/pull/16123
1472019-05-30T05:22:10  *** bitcoin-git has left #bitcoin-core-dev
1482019-05-30T05:37:02  *** luke-jr has quit IRC
1492019-05-30T05:37:51  *** luke-jr has joined #bitcoin-core-dev
1502019-05-30T05:41:20  *** luke-jr has quit IRC
1512019-05-30T05:44:41  *** luke-jr has joined #bitcoin-core-dev
1522019-05-30T05:50:30  *** luke-jr has quit IRC
1532019-05-30T05:51:37  *** luke-jr has joined #bitcoin-core-dev
1542019-05-30T05:53:02  *** AaronvanW has joined #bitcoin-core-dev
1552019-05-30T06:00:02  *** DragonEyes1 has quit IRC
1562019-05-30T06:02:36  *** while has joined #bitcoin-core-dev
1572019-05-30T06:04:14  *** dscho has joined #bitcoin-core-dev
1582019-05-30T06:26:20  *** rex4539 has quit IRC
1592019-05-30T06:27:12  *** AaronvanW has quit IRC
1602019-05-30T06:39:46  *** d_t has joined #bitcoin-core-dev
1612019-05-30T06:42:22  *** bitcoin-git has joined #bitcoin-core-dev
1622019-05-30T06:42:22  <bitcoin-git> [bitcoin] practicalswift opened pull request #16124: tests: Limit Python linting to files in the repo (master...lint-inside-repo) https://github.com/bitcoin/bitcoin/pull/16124
1632019-05-30T06:42:35  *** bitcoin-git has left #bitcoin-core-dev
1642019-05-30T06:57:10  *** laptop500 has joined #bitcoin-core-dev
1652019-05-30T07:02:58  *** d_t has quit IRC
1662019-05-30T07:06:17  *** AaronvanW has joined #bitcoin-core-dev
1672019-05-30T07:06:32  *** scoop has joined #bitcoin-core-dev
1682019-05-30T07:10:56  *** scoop has quit IRC
1692019-05-30T07:10:56  *** AaronvanW has quit IRC
1702019-05-30T07:16:16  *** promag has joined #bitcoin-core-dev
1712019-05-30T07:48:31  *** b10c has joined #bitcoin-core-dev
1722019-05-30T07:54:05  *** rex4539 has joined #bitcoin-core-dev
1732019-05-30T08:00:24  *** AaronvanW has joined #bitcoin-core-dev
1742019-05-30T08:28:12  *** mryandao_ has joined #bitcoin-core-dev
1752019-05-30T08:31:09  <stevenroose> Any idea what it could mean when Travis gives this error for the feature_notification.py test?
1762019-05-30T08:31:12  <stevenroose> node0 2019-05-29T20:16:15.512410Z runCommand error: system(echo > /tmp/test_runner_₿_🏃_20190529_201410/feature_notifications_45/blocknotify/03d5fa58ac73a6b5e2d1baf5849e0142355758746314509e3eff69683ffe9872) returned -1
1772019-05-30T08:31:15  *** mryandao has quit IRC
1782019-05-30T08:31:31  <stevenroose> Seems like it can't write to the file somehow. Or the directory doesn't exist or something.
1792019-05-30T08:34:22  *** AaronvanW has quit IRC
1802019-05-30T08:48:18  *** thaumavorio_ has quit IRC
1812019-05-30T08:49:49  *** thaumavorio has joined #bitcoin-core-dev
1822019-05-30T08:50:08  *** ccdle12 has quit IRC
1832019-05-30T08:51:45  *** ccdle12 has joined #bitcoin-core-dev
1842019-05-30T08:52:28  *** ccdle12 has joined #bitcoin-core-dev
1852019-05-30T08:53:46  *** siom has joined #bitcoin-core-dev
1862019-05-30T08:58:32  *** Guest46546 has joined #bitcoin-core-dev
1872019-05-30T09:00:02  *** dscho has quit IRC
1882019-05-30T09:03:01  *** promag_ has joined #bitcoin-core-dev
1892019-05-30T09:04:52  *** gorthx has joined #bitcoin-core-dev
1902019-05-30T09:04:56  *** luke-jr has quit IRC
1912019-05-30T09:05:39  *** luke-jr has joined #bitcoin-core-dev
1922019-05-30T09:09:12  *** luke-jr has quit IRC
1932019-05-30T09:09:28  *** Guest46546 has quit IRC
1942019-05-30T09:09:59  *** luke-jr has joined #bitcoin-core-dev
1952019-05-30T09:10:17  *** ccdle12 has quit IRC
1962019-05-30T09:11:24  *** luke-jr has quit IRC
1972019-05-30T09:14:27  *** luke-jr has joined #bitcoin-core-dev
1982019-05-30T09:18:30  *** timothy has joined #bitcoin-core-dev
1992019-05-30T09:20:32  *** luke-jr has quit IRC
2002019-05-30T09:21:22  *** luke-jr has joined #bitcoin-core-dev
2012019-05-30T09:23:00  *** sean8219 has joined #bitcoin-core-dev
2022019-05-30T09:23:36  *** luke-jr has quit IRC
2032019-05-30T09:24:26  *** AaronvanW has joined #bitcoin-core-dev
2042019-05-30T09:24:30  *** luke-jr has joined #bitcoin-core-dev
2052019-05-30T09:25:34  *** sean8219_ has joined #bitcoin-core-dev
2062019-05-30T09:27:07  *** Dean_Guss has joined #bitcoin-core-dev
2072019-05-30T09:28:48  *** AaronvanW has quit IRC
2082019-05-30T09:29:13  *** sean8219 has quit IRC
2092019-05-30T09:29:51  *** sean8219_ has joined #bitcoin-core-dev
2102019-05-30T09:31:31  *** luke-jr has quit IRC
2112019-05-30T09:32:11  *** darosior has joined #bitcoin-core-dev
2122019-05-30T09:32:30  *** luke-jr has joined #bitcoin-core-dev
2132019-05-30T09:37:42  *** luke-jr has quit IRC
2142019-05-30T09:39:36  *** luke-jr has joined #bitcoin-core-dev
2152019-05-30T09:45:27  *** luke-jr has quit IRC
2162019-05-30T09:45:48  *** sean8219_ has quit IRC
2172019-05-30T09:46:15  *** luke-jr has joined #bitcoin-core-dev
2182019-05-30T09:48:06  *** sean8219_ has joined #bitcoin-core-dev
2192019-05-30T09:56:03  *** rex4539 has quit IRC
2202019-05-30T10:03:34  *** spinza has quit IRC
2212019-05-30T10:07:39  *** jonatack has quit IRC
2222019-05-30T10:10:40  *** lnostdal has quit IRC
2232019-05-30T10:11:03  *** spinza has joined #bitcoin-core-dev
2242019-05-30T10:11:07  *** lnostdal has joined #bitcoin-core-dev
2252019-05-30T10:14:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2262019-05-30T10:15:10  *** lnostdal has quit IRC
2272019-05-30T10:15:28  *** lnostdal has joined #bitcoin-core-dev
2282019-05-30T10:17:52  *** AaronvanW has joined #bitcoin-core-dev
2292019-05-30T10:18:42  *** promag_ has quit IRC
2302019-05-30T10:22:21  *** AaronvanW has quit IRC
2312019-05-30T10:24:33  *** sean8219_ has quit IRC
2322019-05-30T10:26:45  *** sean8219_ has joined #bitcoin-core-dev
2332019-05-30T10:29:35  *** sean8219_ has quit IRC
2342019-05-30T10:30:06  *** mryandao_ is now known as mryandao
2352019-05-30T10:31:30  *** sean8219_ has joined #bitcoin-core-dev
2362019-05-30T10:35:32  *** rex4539 has joined #bitcoin-core-dev
2372019-05-30T10:36:44  *** Deinogalerix21 has joined #bitcoin-core-dev
2382019-05-30T10:41:02  *** promag_ has joined #bitcoin-core-dev
2392019-05-30T10:43:27  *** sean8219_ has quit IRC
2402019-05-30T10:44:12  *** shesek has quit IRC
2412019-05-30T10:44:20  *** sean8219_ has joined #bitcoin-core-dev
2422019-05-30T10:49:24  *** jonatack has joined #bitcoin-core-dev
2432019-05-30T10:54:54  *** sean8219_ has quit IRC
2442019-05-30T10:55:35  *** ccdle12 has joined #bitcoin-core-dev
2452019-05-30T10:56:11  *** sean8219_ has joined #bitcoin-core-dev
2462019-05-30T10:59:46  *** sean8219_ has quit IRC
2472019-05-30T11:00:58  *** sean8219_ has joined #bitcoin-core-dev
2482019-05-30T11:05:19  *** michaelfolkson has joined #bitcoin-core-dev
2492019-05-30T11:06:56  *** scoop has joined #bitcoin-core-dev
2502019-05-30T11:07:04  *** sean8219_ has quit IRC
2512019-05-30T11:07:30  *** sean8219_ has joined #bitcoin-core-dev
2522019-05-30T11:11:45  *** michaelfolkson has quit IRC
2532019-05-30T11:12:02  *** AaronvanW has joined #bitcoin-core-dev
2542019-05-30T11:12:04  *** scoop has quit IRC
2552019-05-30T11:16:56  *** AaronvanW has quit IRC
2562019-05-30T11:20:04  *** michaelfolkson has joined #bitcoin-core-dev
2572019-05-30T11:21:06  *** sfhi has joined #bitcoin-core-dev
2582019-05-30T11:26:46  *** sean8219_ has quit IRC
2592019-05-30T11:26:59  *** mats_ has quit IRC
2602019-05-30T11:27:18  *** Deinogalerix21 has quit IRC
2612019-05-30T11:30:43  *** AaronvanW has joined #bitcoin-core-dev
2622019-05-30T11:31:30  *** sean8219_ has joined #bitcoin-core-dev
2632019-05-30T11:32:10  *** Victorsueca has quit IRC
2642019-05-30T11:33:18  *** Victorsueca has joined #bitcoin-core-dev
2652019-05-30T11:34:14  *** sean8219_ has quit IRC
2662019-05-30T11:35:12  *** sean8219_ has joined #bitcoin-core-dev
2672019-05-30T11:35:53  *** Chris_Stewart_5 has quit IRC
2682019-05-30T11:40:54  *** rex4539 has quit IRC
2692019-05-30T11:43:41  *** sean8219_ has quit IRC
2702019-05-30T11:47:50  *** shesek has joined #bitcoin-core-dev
2712019-05-30T11:47:50  *** shesek has joined #bitcoin-core-dev
2722019-05-30T11:48:37  *** owowo has quit IRC
2732019-05-30T11:53:12  *** owowo has joined #bitcoin-core-dev
2742019-05-30T11:56:34  *** sean8219_ has joined #bitcoin-core-dev
2752019-05-30T11:56:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2762019-05-30T11:58:00  *** sean8219_ has quit IRC
2772019-05-30T11:58:14  *** sean8219_ has joined #bitcoin-core-dev
2782019-05-30T12:00:02  *** gorthx has quit IRC
2792019-05-30T12:00:42  *** promag_ has quit IRC
2802019-05-30T12:01:18  *** sean8219_ has quit IRC
2812019-05-30T12:01:51  *** sean8219_ has joined #bitcoin-core-dev
2822019-05-30T12:03:46  *** theGrg has joined #bitcoin-core-dev
2832019-05-30T12:04:37  *** michaelfolkson has quit IRC
2842019-05-30T12:09:44  *** Chris_Stewart_5 has quit IRC
2852019-05-30T12:09:53  *** michaelfolkson has joined #bitcoin-core-dev
2862019-05-30T12:16:15  *** michaelfolkson has quit IRC
2872019-05-30T12:17:25  *** qubenix has quit IRC
2882019-05-30T12:20:28  *** b10c has quit IRC
2892019-05-30T12:27:47  *** qubenix has joined #bitcoin-core-dev
2902019-05-30T12:28:57  *** sean8219_ has quit IRC
2912019-05-30T12:32:05  *** mryandao has quit IRC
2922019-05-30T12:38:13  *** obsrver has joined #bitcoin-core-dev
2932019-05-30T12:38:31  *** mryandao has joined #bitcoin-core-dev
2942019-05-30T12:44:58  *** sean8219_ has joined #bitcoin-core-dev
2952019-05-30T12:50:02  *** AaronvanW has quit IRC
2962019-05-30T12:55:18  *** sean8219_ has quit IRC
2972019-05-30T12:58:52  *** michaelfolkson has joined #bitcoin-core-dev
2982019-05-30T13:02:36  *** jb55 has quit IRC
2992019-05-30T13:02:50  *** sean8219_ has joined #bitcoin-core-dev
3002019-05-30T13:07:00  *** icek has quit IRC
3012019-05-30T13:09:59  *** sean8219_ has joined #bitcoin-core-dev
3022019-05-30T13:10:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3032019-05-30T13:13:11  *** sean8219_ has quit IRC
3042019-05-30T13:13:18  *** mdunnio has joined #bitcoin-core-dev
3052019-05-30T13:14:34  *** michaelsdunn1 has joined #bitcoin-core-dev
3062019-05-30T13:17:20  *** michaelsdunn1 has quit IRC
3072019-05-30T13:17:21  *** mdunnio has quit IRC
3082019-05-30T13:17:50  *** sean8219_ has joined #bitcoin-core-dev
3092019-05-30T13:24:29  *** scoop has joined #bitcoin-core-dev
3102019-05-30T13:29:36  *** shesek has quit IRC
3112019-05-30T13:29:38  *** jb55 has joined #bitcoin-core-dev
3122019-05-30T13:32:35  *** sean8219_ has quit IRC
3132019-05-30T13:34:30  *** sean8219_ has joined #bitcoin-core-dev
3142019-05-30T13:35:03  *** jonatack has quit IRC
3152019-05-30T13:36:34  *** AaronvanW has joined #bitcoin-core-dev
3162019-05-30T13:41:09  *** sean8219_ has quit IRC
3172019-05-30T13:41:18  *** AaronvanW has quit IRC
3182019-05-30T13:44:05  *** sean8219_ has joined #bitcoin-core-dev
3192019-05-30T13:50:38  *** d_t has joined #bitcoin-core-dev
3202019-05-30T13:51:03  *** shesek has joined #bitcoin-core-dev
3212019-05-30T13:51:03  *** shesek has joined #bitcoin-core-dev
3222019-05-30T13:55:03  *** d_t has quit IRC
3232019-05-30T13:57:09  *** darosior has quit IRC
3242019-05-30T14:12:21  *** michaelsdunn1 has joined #bitcoin-core-dev
3252019-05-30T14:14:18  *** scoop has quit IRC
3262019-05-30T14:14:52  *** AaronvanW has joined #bitcoin-core-dev
3272019-05-30T14:16:24  *** scoop has joined #bitcoin-core-dev
3282019-05-30T14:19:12  *** AaronvanW has quit IRC
3292019-05-30T14:20:48  *** scoop has quit IRC
3302019-05-30T14:21:00  *** sean8219_ has quit IRC
3312019-05-30T14:22:00  *** michaelfolkson has quit IRC
3322019-05-30T14:23:41  *** scoop has joined #bitcoin-core-dev
3332019-05-30T14:23:42  *** sean8219_ has joined #bitcoin-core-dev
3342019-05-30T14:28:39  *** sean8219_ has quit IRC
3352019-05-30T14:29:18  *** sean8219_ has joined #bitcoin-core-dev
3362019-05-30T14:37:25  *** sean8219_ has quit IRC
3372019-05-30T14:41:04  *** AaronvanW has joined #bitcoin-core-dev
3382019-05-30T14:44:20  *** sean8219_ has joined #bitcoin-core-dev
3392019-05-30T14:45:26  *** ccdle12 has quit IRC
3402019-05-30T14:46:10  *** AaronvanW has quit IRC
3412019-05-30T14:46:50  *** captjakk has joined #bitcoin-core-dev
3422019-05-30T14:49:06  *** laurentmt has joined #bitcoin-core-dev
3432019-05-30T14:49:50  *** sean8219_ has quit IRC
3442019-05-30T14:51:06  *** scoop has quit IRC
3452019-05-30T14:53:06  *** sean8219_ has joined #bitcoin-core-dev
3462019-05-30T14:56:54  *** ossifrage_ has joined #bitcoin-core-dev
3472019-05-30T14:58:08  <jnewbery> #proposedmeetingtopic - has travis got worse or have we just added so many builds to our job that it times out?
3482019-05-30T14:58:13  <jnewbery> moneyball: ^
3492019-05-30T14:58:22  *** ossifrage has quit IRC
3502019-05-30T14:59:20  *** michaelfolkson has joined #bitcoin-core-dev
3512019-05-30T14:59:31  <ryanofsky> MarcoFalke, could drahtbot just automatically restart travis jobs that fail with "Error! Initial build successful, but not enough time remains to run later build stages and tests."?
3522019-05-30T15:00:01  *** theGrg has quit IRC
3532019-05-30T15:02:49  *** laurentmt has quit IRC
3542019-05-30T15:05:58  *** sean8219_ has quit IRC
3552019-05-30T15:11:01  *** scoop has joined #bitcoin-core-dev
3562019-05-30T15:13:02  *** juhp has joined #bitcoin-core-dev
3572019-05-30T15:13:15  *** davterra has quit IRC
3582019-05-30T15:22:27  *** jonatack has joined #bitcoin-core-dev
3592019-05-30T15:40:12  *** jnewbery has quit IRC
3602019-05-30T15:42:04  *** jnewbery has joined #bitcoin-core-dev
3612019-05-30T15:44:07  *** Guyver2 has joined #bitcoin-core-dev
3622019-05-30T15:47:29  *** scoop has quit IRC
3632019-05-30T15:47:30  *** rex4539 has joined #bitcoin-core-dev
3642019-05-30T15:49:12  *** sfhi2 has joined #bitcoin-core-dev
3652019-05-30T15:52:25  *** sfhi has quit IRC
3662019-05-30T16:02:53  *** scoop has joined #bitcoin-core-dev
3672019-05-30T16:04:33  *** sean8219_ has joined #bitcoin-core-dev
3682019-05-30T16:07:23  *** scoop has quit IRC
3692019-05-30T16:11:09  *** Dean_Guss has quit IRC
3702019-05-30T16:11:32  *** Dean_Guss has joined #bitcoin-core-dev
3712019-05-30T16:12:08  *** timothy has quit IRC
3722019-05-30T16:16:46  *** hsmiths has quit IRC
3732019-05-30T16:19:58  *** scoop has joined #bitcoin-core-dev
3742019-05-30T16:21:23  *** scoop has quit IRC
3752019-05-30T16:22:26  *** scoop has joined #bitcoin-core-dev
3762019-05-30T16:23:51  *** scoop has quit IRC
3772019-05-30T16:24:07  *** sean8219_ has quit IRC
3782019-05-30T16:25:49  *** sean8219_ has joined #bitcoin-core-dev
3792019-05-30T16:25:57  *** scoop has joined #bitcoin-core-dev
3802019-05-30T16:29:40  *** sean8219_ has quit IRC
3812019-05-30T16:30:19  *** profmac has quit IRC
3822019-05-30T16:32:29  *** michaelfolkson has quit IRC
3832019-05-30T16:36:19  *** jarthur has joined #bitcoin-core-dev
3842019-05-30T16:39:11  *** cubancorona has quit IRC
3852019-05-30T16:42:55  <wumpus> ryanofsky: I don't think drahtbot queries/scans the travis logs right now
3862019-05-30T16:43:42  *** profmac has joined #bitcoin-core-dev
3872019-05-30T16:44:03  <wumpus> but it's a good topic I think, it definitely seems that travis is overloaded, I'm not sure what changed why it's like that now
3882019-05-30T17:01:53  *** nullptr| has quit IRC
3892019-05-30T17:04:23  *** nullptr| has joined #bitcoin-core-dev
3902019-05-30T17:05:28  *** Chris_Stewart_5 has quit IRC
3912019-05-30T17:05:36  *** dviola has joined #bitcoin-core-dev
3922019-05-30T17:20:04  *** scoop has quit IRC
3932019-05-30T17:21:21  *** siom has quit IRC
3942019-05-30T17:30:19  *** ossifrage_ has quit IRC
3952019-05-30T17:30:27  *** ossifrage_ has joined #bitcoin-core-dev
3962019-05-30T17:35:29  *** scoop has joined #bitcoin-core-dev
3972019-05-30T17:39:48  *** scoop has quit IRC
3982019-05-30T17:40:06  *** d_t has joined #bitcoin-core-dev
3992019-05-30T17:41:35  *** obsrver has quit IRC
4002019-05-30T17:41:42  *** obsrver has joined #bitcoin-core-dev
4012019-05-30T17:43:33  *** Karyon has quit IRC
4022019-05-30T17:43:44  *** Karyon_ has joined #bitcoin-core-dev
4032019-05-30T17:45:11  *** Karyon_ is now known as Karyon
4042019-05-30T17:54:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4052019-05-30T17:59:40  *** lightlike has joined #bitcoin-core-dev
4062019-05-30T18:00:01  *** juhp has quit IRC
4072019-05-30T18:05:44  *** obsrver has quit IRC
4082019-05-30T18:07:32  *** scoop has joined #bitcoin-core-dev
4092019-05-30T18:12:16  *** no_cluez has joined #bitcoin-core-dev
4102019-05-30T18:12:36  *** scoop has quit IRC
4112019-05-30T18:21:09  *** Dean_Guss has quit IRC
4122019-05-30T18:25:57  *** scoop has joined #bitcoin-core-dev
4132019-05-30T18:30:32  *** elichai2 has joined #bitcoin-core-dev
4142019-05-30T18:47:14  *** ddustin has quit IRC
4152019-05-30T18:47:32  *** ddustin has joined #bitcoin-core-dev
4162019-05-30T18:50:27  <fanquake> Are we at the free limit/tier with Travis? I know the idea of adding "another" CI wasn't liked too much, for risk of increasing the size of the slot machine, but if we need more capacity maybe we could look at Circle CI, and be able to add some BSDs while we are at it ?
4172019-05-30T18:53:13  <wumpus> right, I'd be for adding a CI only if it improves reliability by lowering the load on travis, the reason I'm against it otherwise is exactly that, even more different ways to fail randomly and different buttons to press to respin
4182019-05-30T19:00:15  <wumpus> #startmeeting
4192019-05-30T19:00:15  <lightningbot> Meeting started Thu May 30 19:00:15 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4202019-05-30T19:00:15  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4212019-05-30T19:00:20  <moneyball> hi!
4222019-05-30T19:00:23  <instagibbs> hi
4232019-05-30T19:00:25  <jamesob> hi
4242019-05-30T19:00:31  <meshcollider> hi
4252019-05-30T19:00:33  <moneyball> https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
4262019-05-30T19:00:38  <promag> hi
4272019-05-30T19:00:44  <jnewbery> hi
4282019-05-30T19:00:47  <jarthur> 'lo
4292019-05-30T19:00:50  <fanquake> hi
4302019-05-30T19:01:18  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
4312019-05-30T19:02:08  <wumpus> any proposed topics? (in addition to moneyball's) ?
4322019-05-30T19:02:41  <fanquake> Probably any suggestions for short talks at Core Dev? Is there a list of anything like that already?
4332019-05-30T19:02:49  <instagibbs> kanzure, ^
4342019-05-30T19:03:31  <fanquake> If so that's fine, let's discuss the other topics.
4352019-05-30T19:03:58  <moneyball> fanquake be sure to provide kanzure with any topics you'd like to discuss at CoreDev!
4362019-05-30T19:03:58  <sipa> about to get to the airport, i think we'll have better meeting time in amsterdam
4372019-05-30T19:04:24  <promag> jarthur:
4382019-05-30T19:04:25  <wumpus> #topic High priority for review
4392019-05-30T19:04:29  <promag> (ops)
4402019-05-30T19:04:48  <wumpus> 5 things on the list now https://github.com/bitcoin/bitcoin/projects/8
4412019-05-30T19:05:10  *** shesek has quit IRC
4422019-05-30T19:05:19  <promag> sorry, what is the date for 0.18.1?
4432019-05-30T19:05:23  <wumpus> anything to add/remove ?
4442019-05-30T19:05:31  <wumpus> promag: whaa? is 0.18.1 planned at all?
4452019-05-30T19:05:46  <wumpus> I don't think anything made it necessary yet
4462019-05-30T19:06:01  <achow101> hi
4472019-05-30T19:06:10  <fanquake> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.1
4482019-05-30T19:06:10  *** d_t has quit IRC
4492019-05-30T19:06:19  <promag> also https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+label%3A%22Needs+backport%22+
4502019-05-30T19:06:46  <achow101> #15450 for hi prio
4512019-05-30T19:06:49  <gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
4522019-05-30T19:07:04  <promag> but nevermind, I got it's too soon
4532019-05-30T19:07:12  <fanquake> added
4542019-05-30T19:07:55  <wumpus> absent any really important bug fix I think it's too soon, yes, we don't tend to do a lot of minor releases usually
4552019-05-30T19:08:23  <fanquake> There's a call for some more review on #15976, has 4 utACKs at the moment (already high-prio).
4562019-05-30T19:08:26  <gribble> https://github.com/bitcoin/bitcoin/issues/15976 | refactor: move methods under CChainState (pt. 1) by jamesob · Pull Request #15976 · bitcoin/bitcoin · GitHub
4572019-05-30T19:09:52  <wumpus> okay!
4582019-05-30T19:10:45  <wumpus> #topic Has travis got worse? (jnewbery)
4592019-05-30T19:10:54  <wumpus> "has travis got worse or have we just added so many builds to our job that it times out?"
4602019-05-30T19:11:16  <wumpus> I've wondered this, too, travis has been more unreliable on (PRs at least) than it used to be
4612019-05-30T19:11:22  <jnewbery> In the last couple of months, *a lot* of travis builds time out
4622019-05-30T19:11:29  <wumpus> while I don't notice this for local tests
4632019-05-30T19:11:31  <jamesob> hasn't seemed any worse to me recently, though we've had to rekick certain jobs for months
4642019-05-30T19:11:41  <jnewbery> I don't know if our builds got slower, travis got slower, or we just added to many jobs for travis to handle
4652019-05-30T19:11:51  <achow101> a lot of things have been added recently, maybe it's too much for them to handle?
4662019-05-30T19:11:57  <wumpus> at least we should be careful with making the tests even longer now
4672019-05-30T19:12:23  <fanquake> Also a lot of depends related PRs timing out recently, but not much that can be done about that.
4682019-05-30T19:12:24  <instagibbs> There is an element of how Travis is feeling that day
4692019-05-30T19:12:30  <instagibbs> lots of variance in build times
4702019-05-30T19:12:47  <wumpus> right, it's very possible that it's not our fault entirely though and it's simply the infrastructure becoming worse
4712019-05-30T19:13:11  <jnewbery> There are currently 10 different test stages. I know it used to be 6 or 7
4722019-05-30T19:13:20  <wumpus> I haven't noticed the tests nor builds becoming noticably slower locally
4732019-05-30T19:13:59  <wumpus> jnewbery: hmm might be time to evaluate whether they're really all contributing something useful
4742019-05-30T19:14:27  *** promag_ has joined #bitcoin-core-dev
4752019-05-30T19:14:52  *** spaced0ut has quit IRC
4762019-05-30T19:14:55  <instagibbs> in elements land we've been having weird issues too that might reflect travis being overly taxed, hard to say
4772019-05-30T19:15:06  <instagibbs> failure to write to files, that kind of stuff
4782019-05-30T19:15:27  <promag> best case I usually see is around 20min (for longest job 8)
4792019-05-30T19:15:36  <jnewbery> I know it runs those test stages in parallel
4802019-05-30T19:15:38  <wumpus> yes weird stuff happens but I don't think we have that often, it's mostly just timeouts
4812019-05-30T19:15:40  <luke-jr> instagibbs: does the Elements Travis have caching enabled?
4822019-05-30T19:15:46  <ryanofsky> are people seeing travis errors other than "Error! Initial build successful..."? This is the only travis error i see and restarting fixes it 100% of the time
4832019-05-30T19:16:04  <jnewbery> ryanofsky: yes, that's the error
4842019-05-30T19:16:22  <luke-jr> ryanofsky: I've seen cases where restarting *doesn't* fix it
4852019-05-30T19:16:22  <instagibbs> ryanofsky, that's when dpeends takes "too long"
4862019-05-30T19:16:22  <promag> ryanofsky: sometimes I see others and I leave a comment in the PR (before restarting) or create an issue
4872019-05-30T19:16:24  <instagibbs> and it early exits
4882019-05-30T19:16:32  <luke-jr> ryanofsky: but they mysteriously resolved before I could troubleshoot :/
4892019-05-30T19:16:45  <instagibbs> luke-jr, I believe so, the restarting thing fixes  that issue
4902019-05-30T19:17:08  <jnewbery> The longest running test stage is "sanitizers: address/leak (ASan + LSan) + undefined (UBSan) + integer". I wonder if the same hardware is shared between different test stages and whatever is running at the same time as that one might time out
4912019-05-30T19:17:10  <wumpus> it *should* be fixed by restarting, that's the point of that message, it's an ugly hack though
4922019-05-30T19:17:44  <jnewbery> yes, travis is supposed to save developer time, not add an extra step to opening a PR!
4932019-05-30T19:18:21  <luke-jr> jnewbery: on that note, it's annoying that AppVeyor doesn't use standard build tools, and requires duplicating changes for it
4942019-05-30T19:18:40  *** jeremyrubin has quit IRC
4952019-05-30T19:18:56  <meshcollider> Is it possible for a new drahtbot feature to auto-restart builds with that error?
4962019-05-30T19:19:02  *** promag_ has quit IRC
4972019-05-30T19:19:11  <achow101> apparently travis switched from docker containers on ec2 to vms on gce late last year, maybe that's related?
4982019-05-30T19:19:46  <jnewbery> has anyone raised this with travis? We have a paid account, right? Can we try to get support?
4992019-05-30T19:19:48  <promag> does it run multiple "build depends" with the same conf if needed? sounds unnecessary?
5002019-05-30T19:21:06  <luke-jr> jnewbery: Travis support is pretty useless in my experience :/
5012019-05-30T19:21:26  <luke-jr> jnewbery: I expect we'd at the very least need a very specific concern
5022019-05-30T19:21:47  <jnewbery> luke-jr: support is pretty useless in my experience :/
5032019-05-30T19:21:50  <wumpus> yes, filing an issue 'it is slow' probably won't do much, I'm sure they get that a lot
5042019-05-30T19:21:57  <jamesob> circleci (https://circleci.com/) execution is very good in my experience but I am definitely not volunteering to migrate our .travis.yml :)
5052019-05-30T19:22:22  <wumpus> migrating to another CI would definitely be an option if it's better
5062019-05-30T19:22:32  <meshcollider> jnewbery: Travis is free for open source projects, we don't pay
5072019-05-30T19:22:36  <wumpus> (and then I really mean migrating not adding another one)
5082019-05-30T19:22:48  <luke-jr> meshcollider: we do have a paid account, though
5092019-05-30T19:22:56  <meshcollider> Oh?
5102019-05-30T19:23:09  <luke-jr> meshcollider: afaik the Bitcoin Foundation set it up way back when
5112019-05-30T19:23:09  <jnewbery> well, what's the issue exactly? There's some specific job timout on travis, and so we cancel the build before that timeout to cache whatver has been built already? Can we ask them to increase the job timeout for us?
5122019-05-30T19:23:27  <jnewbery> I believe we have a paid account so we get more parallel builds
5132019-05-30T19:23:38  <jnewbery> because we were getting a backlog of PR builds a couple of years ago
5142019-05-30T19:23:48  <luke-jr> jnewbery: it used to also be required for caches (though I'm not sure if they expanded that to free accounts maybe)
5152019-05-30T19:23:52  <jamesob> meshcollider: Chaincode starting kicking in for Travis a year and change ago
5162019-05-30T19:24:02  <jamesob> *started
5172019-05-30T19:24:39  *** sean8219_ has joined #bitcoin-core-dev
5182019-05-30T19:24:51  <wumpus> but it didn't use to run into the timeout so often, so it's become slower, that's really the issue, not the timeout itself; increasing the timeout would work, up to a point, but doing that indefinitely makes the testing slower and slower which isn't good either
5192019-05-30T19:25:30  *** sean8219_ has quit IRC
5202019-05-30T19:26:15  <wumpus> are we somehow doing more travis builds than before? e.g. how often does drahtbot re-kick builds?
5212019-05-30T19:26:21  <jnewbery> yeah, someone needs to investigate where the slowness comes from. Is there an API to pull down all the build results from Travis for a project so we can at least get a sense for how often things are failing?
5222019-05-30T19:26:35  <wumpus> yes, travis has a quite extensive API
5232019-05-30T19:26:37  <luke-jr> jnewbery: there's certainly an API
5242019-05-30T19:26:48  <jnewbery> One issue is that restarting a build makes the logs for the failed build unavailable (at least on the website)
5252019-05-30T19:26:49  <luke-jr> (including one that lets you SSH into the VM)
5262019-05-30T19:27:16  *** spinza has quit IRC
5272019-05-30T19:27:36  <wumpus> jnewbery: I don't know if that's the case for the API, or the new log will get a new id
5282019-05-30T19:27:52  <luke-jr> wumpus: pretty sure it overwrites the existing log
5292019-05-30T19:28:09  <jamesob> I think there's some amdahl's law at work here though - is speeding up travis really going to make the process materially faster? we're pretty review-bound
5302019-05-30T19:28:13  <wumpus> ah yes I'm sure too--this is the URL: https://api.travis-ci.org/v3/job/$1/log.txt   it's per job, and it will have the same job id
5312019-05-30T19:28:35  <wumpus> jamesob: *making it fail less* will lower frustration
5322019-05-30T19:28:52  <jamesob> wumpus: yeah, agree spurious failures are annoying
5332019-05-30T19:29:17  <jnewbery> yeah, it's not about how long it takes, it's that if you open a PR, most of the time you'll need to log back in an hour later or more to rekick travis
5342019-05-30T19:29:18  <wumpus> it's really frustrating if tests fail randomly, if that happens too often people take them less seriously which means actual problems might be ignored
5352019-05-30T19:29:32  <luke-jr> maybe a flag to tell Travis "updated caches, please restart"?
5362019-05-30T19:29:40  * luke-jr ponders if the Travis job can call the API to restart itself
5372019-05-30T19:30:18  <jnewbery> wumpus: exactly that - inconsistently failing builds/tests lower confidence in the product/tests and hide real problems
5382019-05-30T19:30:19  <luke-jr> wumpus: well, false failures on tests is another issue IMO
5392019-05-30T19:31:27  <promag> luke-jr: it needs an auth token, not sure if there's a way to set secrets in travis
5402019-05-30T19:31:45  <jnewbery> luke-jr: that'd be nice, or to get drahtbot to do it, but this is just a variation on the increase timeouts and kick the can down the road, no?
5412019-05-30T19:32:01  <luke-jr> promag: there is, but it may be a dead idea since the job would still be running :/
5422019-05-30T19:32:21  <luke-jr> jnewbery: dunno, it might be nice to restart after cache updates regardless
5432019-05-30T19:32:35  <luke-jr> just to make it more deterministic for the actual tests
5442019-05-30T19:33:28  <wumpus> #topic GitHub feedback issue (moneyball)
5452019-05-30T19:33:32  <fanquake> Should we move onto another topic? Seems like the conclusion here is to go away adn investigate Travis/bot/other CI options and discuss in AMS?
5462019-05-30T19:33:34  <moneyball> hi!
5472019-05-30T19:33:48  <moneyball> so we have this issue https://github.com/bitcoin/bitcoin/issues/15847
5482019-05-30T19:33:49  <wumpus> ""please review GitHub feedback issue and vote with thumbs up on issues you think you make the top 10 https://github.com/bitcoin/bitcoin/issues/15847""
5492019-05-30T19:33:52  <moneyball> with many responses - thank you!
5502019-05-30T19:34:19  <moneyball> i would like to suggest folks take a look at the issue and "vote" for the ideas that resonate with you by doing a thumbs up
5512019-05-30T19:34:46  <fanquake> moneyball is there any timeline for when that meetup might happen?
5522019-05-30T19:34:51  <moneyball> this will help us figure out a top 10 for the CEO lunch, which is now scheduled for june 21, and sipa, cfields, and i plan to attend
5532019-05-30T19:35:20  <moneyball> we can also review this next week at CoreDev if there is interest
5542019-05-30T19:35:58  <moneyball> that's all i had to say, unless there are any other questions right now
5552019-05-30T19:36:20  <sipa> i think it's most useful to talk about issues with are mostly unique to our usage of github
5562019-05-30T19:36:37  <wumpus> thank you, yes this was expected to be a fairly short topic
5572019-05-30T19:36:42  <sipa> as i expect that there are a lot of grievances that are mostly shared between projects
5582019-05-30T19:36:46  <luke-jr> hmm, it'd be nice to use GitHub's code review stuff but also verify the diff against a local git instance somehow
5592019-05-30T19:37:05  <sipa> probably best to discuss on the issue tracker
5602019-05-30T19:37:09  <luke-jr> sometimes I review on GitHub, and therefore leave a commithash out of ACKs because I don't know for sure the commithash is what I reviewed
5612019-05-30T19:37:10  <moneyball> luke-jr please make sure to add your ideas to the github issue
5622019-05-30T19:37:23  <luke-jr> right, but I don't know if this is even a viable issue to address :p
5632019-05-30T19:39:09  <wumpus> ok, any other topics?
5642019-05-30T19:40:24  <wumpus> thanks everyone, see (some of) you next week in Amsterdam
5652019-05-30T19:40:32  <wumpus> #endmeeting
5662019-05-30T19:40:32  <lightningbot> Meeting ended Thu May 30 19:40:32 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5672019-05-30T19:40:32  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-30-19.00.html
5682019-05-30T19:40:32  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-30-19.00.txt
5692019-05-30T19:40:32  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-30-19.00.log.html
5702019-05-30T19:42:21  <luke-jr> I'm probably going to have to miss Amsterdam after all, FWIW
5712019-05-30T19:42:36  <wumpus> oh :(
5722019-05-30T19:47:15  *** spinza has joined #bitcoin-core-dev
5732019-05-30T19:50:20  *** promag_ has joined #bitcoin-core-dev
5742019-05-30T19:55:53  *** promag_ has quit IRC
5752019-05-30T20:01:46  *** laptop500 has quit IRC
5762019-05-30T20:08:47  *** dviola has quit IRC
5772019-05-30T20:27:43  *** jtimon has joined #bitcoin-core-dev
5782019-05-30T20:33:00  *** sean8219_ has joined #bitcoin-core-dev
5792019-05-30T20:34:56  *** lukedashjr has joined #bitcoin-core-dev
5802019-05-30T20:35:44  *** luke-jr has quit IRC
5812019-05-30T20:36:29  *** lukedashjr has quit IRC
5822019-05-30T20:37:29  <instagibbs> CScript(byte_vector) vs CScript(byte_vector.begin(), byte_vector.end()) whyyyy
5832019-05-30T20:38:07  <gwillen> I suspect because certain overloads didn't used to exist or something
5842019-05-30T20:38:16  *** Chris_Stewart_5 has quit IRC
5852019-05-30T20:39:36  <instagibbs> I don't think anyone actually tries using the former?
5862019-05-30T20:39:42  *** luke-jr has joined #bitcoin-core-dev
5872019-05-30T20:39:52  <instagibbs> intentionally*
5882019-05-30T20:40:10  *** elichai2 has quit IRC
5892019-05-30T20:40:19  <kanzure> also, i'm still seeking topics for amsterdam meeting
5902019-05-30T20:40:26  <instagibbs> just my nth time running into it, in case my annoyance is justified
5912019-05-30T20:40:37  <kanzure> and also, does anyone want to take over luke-jr things and be a substitute luke-jr?
5922019-05-30T20:41:10  <gwillen> instagibbs: wait I'm confused now, which of these do you consider preferable
5932019-05-30T20:41:25  <gwillen> I can't tell why you'd ever want to use the longer form
5942019-05-30T20:41:27  <instagibbs> gwillen, the former gives you a script with the first byte being the size of the vector, IIRC
5952019-05-30T20:41:36  <instagibbs> the latter gives you what you'd expect :D
5962019-05-30T20:41:42  <gwillen> oh, that seems like a horrifying bug that should be fixed
5972019-05-30T20:41:50  <instagibbs> CScript is a prevectoryadayada
5982019-05-30T20:42:06  *** scoop has quit IRC
5992019-05-30T20:42:18  *** luke-jr has quit IRC
6002019-05-30T20:42:34  *** scoop has joined #bitcoin-core-dev
6012019-05-30T20:42:53  *** luke-jr has joined #bitcoin-core-dev
6022019-05-30T20:43:18  <gwillen> it's not even clear to me how that would happen
6032019-05-30T20:43:59  <sipa> gwillen: CScript(vector) is the same as CScript() << vector
6042019-05-30T20:44:50  *** scoop has quit IRC
6052019-05-30T20:44:58  *** scoop has joined #bitcoin-core-dev
6062019-05-30T20:45:11  <sipa> it's the script that consists of pushing vector onto the stack
6072019-05-30T20:45:30  <sipa> the confusion is because CScript (used to be) a subclass of vector
6082019-05-30T20:45:51  <sipa> so CScript(script) would be the script that pushes script onto the stack
6092019-05-30T20:46:54  *** sean8219_ has quit IRC
6102019-05-30T20:49:33  *** luke-jr has quit IRC
6112019-05-30T20:50:21  *** luke-jr has joined #bitcoin-core-dev
6122019-05-30T20:51:18  *** sean8219_ has joined #bitcoin-core-dev
6132019-05-30T20:54:35  *** sean8219_ has joined #bitcoin-core-dev
6142019-05-30T21:00:02  *** no_cluez has quit IRC
6152019-05-30T21:05:19  *** pwgn has joined #bitcoin-core-dev
6162019-05-30T21:12:01  *** brianhoffman_ has joined #bitcoin-core-dev
6172019-05-30T21:12:57  *** scoop has quit IRC
6182019-05-30T21:14:05  *** brianhoffman has quit IRC
6192019-05-30T21:16:15  *** rex4539 has quit IRC
6202019-05-30T21:16:35  *** scoop has joined #bitcoin-core-dev
6212019-05-30T21:23:23  *** d_t has joined #bitcoin-core-dev
6222019-05-30T21:34:16  <gwillen> mmm, that seems really confusing and errorprone
6232019-05-30T21:35:07  <sipa> gwillen: yes
6242019-05-30T21:35:39  <sipa> i've tried to touch the CScript API once and almost introduced a consensus bug
6252019-05-30T21:35:44  <gwillen> ahhhhhhh, heh. I see.
6262019-05-30T21:36:13  <gwillen> are those constructors ever used intentionally, do you know?
6272019-05-30T21:36:27  <gwillen> (specifically the ones I would describe as ambiguous, and used directly and not via << or the like)
6282019-05-30T21:36:47  <sipa> if they're actually unused we should just get rid of them
6292019-05-30T21:37:08  <sipa> feel free to try and remove them, but i suspect we'd have caught them already
6302019-05-30T21:37:42  <gwillen> yeah, understood, I am going to go poke around but you've made me afraid to touch it much now ;-)
6312019-05-30T21:37:49  <sipa> i also don't want to imply we're forever stuck with this confusing convention; just that yoi really need to be careful about it
6322019-05-30T21:38:09  <gwillen> yeah, that makes total sense and I appreciate the clarification
6332019-05-30T21:38:46  * sipa ✈️
6342019-05-30T21:40:08  *** sean8219_ has joined #bitcoin-core-dev
6352019-05-30T21:40:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6362019-05-30T21:41:57  <jarthur> Have fun out there, everyone.
6372019-05-30T21:43:09  *** ghost43_ has joined #bitcoin-core-dev
6382019-05-30T21:43:27  *** ghost43 has quit IRC
6392019-05-30T21:45:12  *** sean8219_ has quit IRC
6402019-05-30T21:53:16  *** scoop has quit IRC
6412019-05-30T21:55:43  *** Guyver2 has quit IRC
6422019-05-30T21:57:42  *** ddustin has quit IRC
6432019-05-30T21:58:30  *** ddustin has joined #bitcoin-core-dev
6442019-05-30T21:59:12  *** jarthur_ has joined #bitcoin-core-dev
6452019-05-30T22:01:58  *** jarthur has quit IRC
6462019-05-30T22:02:46  *** ctrlbreak has quit IRC
6472019-05-30T22:03:29  *** jarthur_ has quit IRC
6482019-05-30T22:07:37  *** spinza has quit IRC
6492019-05-30T22:10:09  *** sfhi2 has quit IRC
6502019-05-30T22:12:35  *** sean8219_ has joined #bitcoin-core-dev
6512019-05-30T22:13:20  *** ddustin has quit IRC
6522019-05-30T22:13:34  *** ddustin has joined #bitcoin-core-dev
6532019-05-30T22:14:00  *** ddustin has quit IRC
6542019-05-30T22:14:01  *** sean8219_ has quit IRC
6552019-05-30T22:14:45  *** ddustin has joined #bitcoin-core-dev
6562019-05-30T22:15:57  *** ddustin has joined #bitcoin-core-dev
6572019-05-30T22:22:20  *** siom has joined #bitcoin-core-dev
6582019-05-30T22:30:57  *** ctrlbreak has joined #bitcoin-core-dev
6592019-05-30T22:48:43  *** Zenton has quit IRC
6602019-05-30T22:51:14  *** michaelsdunn1 has quit IRC
6612019-05-30T23:00:22  *** spinza has joined #bitcoin-core-dev
6622019-05-30T23:04:33  *** jonatack has quit IRC
6632019-05-30T23:08:30  *** ccdle12 has joined #bitcoin-core-dev
6642019-05-30T23:14:46  *** ddustin has quit IRC
6652019-05-30T23:15:26  *** ddustin has joined #bitcoin-core-dev
6662019-05-30T23:22:30  *** davterra has joined #bitcoin-core-dev
6672019-05-30T23:22:32  *** Zenton has joined #bitcoin-core-dev
6682019-05-30T23:23:03  *** scoop has joined #bitcoin-core-dev
6692019-05-30T23:24:30  *** Chris_Stewart_5 has quit IRC
6702019-05-30T23:25:13  *** lnostdal has quit IRC
6712019-05-30T23:31:21  *** jeremyrubin has joined #bitcoin-core-dev
6722019-05-30T23:31:58  *** lightlike has quit IRC
6732019-05-30T23:36:54  *** ctrlbreak has quit IRC
6742019-05-30T23:46:12  *** lnostdal has joined #bitcoin-core-dev
6752019-05-30T23:52:54  *** promag_ has joined #bitcoin-core-dev
6762019-05-30T23:57:54  *** promag_ has quit IRC