12019-05-31T00:00:01 *** pwgn has quit IRC
22019-05-31T00:04:07 *** ccdle12 has quit IRC
32019-05-31T00:04:15 *** gac410 has joined #bitcoin-core-dev
42019-05-31T00:04:37 *** gac410 is now known as Guest22956
52019-05-31T00:08:37 *** ccdle12 has joined #bitcoin-core-dev
62019-05-31T00:13:06 *** Victorsueca has quit IRC
72019-05-31T00:13:15 *** Victorsueca has joined #bitcoin-core-dev
82019-05-31T00:13:36 *** ccdle12 has quit IRC
92019-05-31T00:13:56 *** jtimon has quit IRC
102019-05-31T00:18:58 *** ctrlbreak has joined #bitcoin-core-dev
112019-05-31T00:19:43 *** jtimon has joined #bitcoin-core-dev
122019-05-31T00:22:28 *** captjakk has quit IRC
132019-05-31T00:27:37 *** inoor has joined #bitcoin-core-dev
142019-05-31T00:37:15 *** scoop has quit IRC
152019-05-31T00:37:51 *** scoop has joined #bitcoin-core-dev
162019-05-31T00:38:48 *** hex17or has quit IRC
172019-05-31T00:49:06 *** sean8219_ has joined #bitcoin-core-dev
182019-05-31T00:50:19 *** scoop has quit IRC
192019-05-31T00:50:46 *** scoop has joined #bitcoin-core-dev
202019-05-31T00:53:27 *** sean8219_ has joined #bitcoin-core-dev
212019-05-31T00:55:24 *** scoop has quit IRC
222019-05-31T01:07:21 *** ddustin has quit IRC
232019-05-31T01:07:37 *** ddustin has joined #bitcoin-core-dev
242019-05-31T01:16:32 *** sean8219_ has quit IRC
252019-05-31T01:19:28 *** sean8219_ has joined #bitcoin-core-dev
262019-05-31T01:25:05 <instagibbs> gwillen, turns out it's used exactly twice, in FindAndDelete :grimace:
272019-05-31T01:27:00 *** oneark has joined #bitcoin-core-dev
282019-05-31T01:31:07 *** sean8219_ has quit IRC
292019-05-31T01:36:16 *** sean8219_ has joined #bitcoin-core-dev
302019-05-31T01:38:05 <gwillen> ooooof
312019-05-31T01:39:06 *** ctrlbreak has quit IRC
322019-05-31T01:40:23 *** lnostdal has quit IRC
332019-05-31T01:41:58 *** ctrlbreak has joined #bitcoin-core-dev
342019-05-31T01:45:11 *** sean8219_ has joined #bitcoin-core-dev
352019-05-31T01:47:09 *** sean8219_ has quit IRC
362019-05-31T01:48:01 *** lnostdal has joined #bitcoin-core-dev
372019-05-31T02:00:25 *** sean8219_ has joined #bitcoin-core-dev
382019-05-31T02:04:22 *** bitcoin-git has joined #bitcoin-core-dev
392019-05-31T02:04:22 <bitcoin-git> [bitcoin] ajtowns opened pull request #16127: Add support for thread safety annotations when using std::mutex (master...201905-locking) https://github.com/bitcoin/bitcoin/pull/16127
402019-05-31T02:04:23 *** bitcoin-git has left #bitcoin-core-dev
412019-05-31T02:08:40 *** sean8219_ has quit IRC
422019-05-31T02:10:38 *** sean8219_ has joined #bitcoin-core-dev
432019-05-31T02:11:14 *** sean8219_ has quit IRC
442019-05-31T02:12:27 *** ghost43 has joined #bitcoin-core-dev
452019-05-31T02:13:45 *** ghost43_ has quit IRC
462019-05-31T02:14:15 <phantomcircuit> instagibbs, things calling FindAndDelete right?
472019-05-31T02:18:02 *** sean8219_ has joined #bitcoin-core-dev
482019-05-31T02:19:00 <phantomcircuit> instagibbs, explicit CScript(const std::vector<unsigned char>& b) { operator<<(b); }
492019-05-31T02:19:07 <phantomcircuit> and operator<< pushes them as bytes
502019-05-31T02:20:07 <phantomcircuit> it's pushing a byte array into the script, not copying a script directly
512019-05-31T02:20:27 <phantomcircuit> and yeah it's confusing and a potential cause of bugs if you're not careful about it
522019-05-31T02:23:26 *** sean8219_ has quit IRC
532019-05-31T02:27:24 *** jtimon has quit IRC
542019-05-31T02:47:10 *** ddustin has quit IRC
552019-05-31T02:47:57 *** ddustin has joined #bitcoin-core-dev
562019-05-31T03:00:02 *** Guest22956 has quit IRC
572019-05-31T03:10:49 *** hex17or has joined #bitcoin-core-dev
582019-05-31T03:20:40 *** lossyrob has joined #bitcoin-core-dev
592019-05-31T03:32:18 *** Dean_Guss has joined #bitcoin-core-dev
602019-05-31T03:54:30 *** promag_ has joined #bitcoin-core-dev
612019-05-31T03:55:05 *** EagleTM has joined #bitcoin-core-dev
622019-05-31T03:56:32 *** Eagle[TM] has quit IRC
632019-05-31T03:58:55 *** promag_ has quit IRC
642019-05-31T04:05:09 *** pinheadmz has quit IRC
652019-05-31T04:16:14 *** pinheadmz has joined #bitcoin-core-dev
662019-05-31T04:30:12 *** pinheadmz has quit IRC
672019-05-31T04:39:25 *** ccdle12 has joined #bitcoin-core-dev
682019-05-31T04:39:50 *** rex4539 has joined #bitcoin-core-dev
692019-05-31T04:56:04 *** rex4539 has quit IRC
702019-05-31T05:21:04 *** ddustin has quit IRC
712019-05-31T05:21:22 *** ddustin has joined #bitcoin-core-dev
722019-05-31T05:35:04 *** jtimon has joined #bitcoin-core-dev
732019-05-31T05:38:40 *** rex4539 has joined #bitcoin-core-dev
742019-05-31T05:45:10 *** arubi has quit IRC
752019-05-31T05:45:10 *** afk11 has quit IRC
762019-05-31T05:46:03 *** arubi has joined #bitcoin-core-dev
772019-05-31T05:47:18 *** d_t has quit IRC
782019-05-31T06:00:02 *** lossyrob has quit IRC
792019-05-31T06:03:18 *** Kant has joined #bitcoin-core-dev
802019-05-31T06:04:18 *** erwin_bullet has joined #bitcoin-core-dev
812019-05-31T06:07:28 *** michaelfolkson has joined #bitcoin-core-dev
822019-05-31T06:12:51 *** Kant has left #bitcoin-core-dev
832019-05-31T06:13:28 *** chinya has joined #bitcoin-core-dev
842019-05-31T06:13:43 *** chinya has left #bitcoin-core-dev
852019-05-31T06:14:13 *** jtimon has quit IRC
862019-05-31T06:16:49 *** jtimon has joined #bitcoin-core-dev
872019-05-31T06:18:00 *** rex4539 has quit IRC
882019-05-31T06:28:41 *** hebasto has joined #bitcoin-core-dev
892019-05-31T06:33:36 *** jtimon has quit IRC
902019-05-31T06:33:45 *** inoor has quit IRC
912019-05-31T06:38:13 *** michaelfolkson has quit IRC
922019-05-31T06:42:51 *** scoop has joined #bitcoin-core-dev
932019-05-31T06:43:29 *** michaelfolkson has joined #bitcoin-core-dev
942019-05-31T06:47:32 *** scoop has quit IRC
952019-05-31T07:05:28 *** michaelfolkson has quit IRC
962019-05-31T07:08:19 *** michaelfolkson has joined #bitcoin-core-dev
972019-05-31T07:09:26 *** promag_ has joined #bitcoin-core-dev
982019-05-31T07:09:30 *** promag has quit IRC
992019-05-31T07:10:35 *** promag has joined #bitcoin-core-dev
1002019-05-31T07:13:36 *** promag_ has quit IRC
1012019-05-31T07:15:03 *** promag has quit IRC
1022019-05-31T07:17:52 *** EagleTM has quit IRC
1032019-05-31T07:31:13 *** AaronvanW has joined #bitcoin-core-dev
1042019-05-31T07:33:56 *** spacecatbro has joined #bitcoin-core-dev
1052019-05-31T07:35:06 *** mryandao has quit IRC
1062019-05-31T07:37:11 *** mryandao has joined #bitcoin-core-dev
1072019-05-31T07:38:31 *** spacecatbro has quit IRC
1082019-05-31T07:38:50 *** Xianglo has joined #bitcoin-core-dev
1092019-05-31T07:45:28 *** Xianglo has quit IRC
1102019-05-31T07:48:58 *** Xianglo has joined #bitcoin-core-dev
1112019-05-31T07:57:58 *** darosior has joined #bitcoin-core-dev
1122019-05-31T07:59:25 *** Xianglo has quit IRC
1132019-05-31T08:08:46 *** NielsThijssen has joined #bitcoin-core-dev
1142019-05-31T08:11:06 *** jb55 has quit IRC
1152019-05-31T08:11:10 *** michaelfolkson has quit IRC
1162019-05-31T08:16:43 *** jb55 has joined #bitcoin-core-dev
1172019-05-31T08:18:56 *** jb55 has quit IRC
1182019-05-31T08:22:54 *** jb55 has joined #bitcoin-core-dev
1192019-05-31T09:00:02 *** erwin_bullet has quit IRC
1202019-05-31T09:04:36 *** bshum1 has joined #bitcoin-core-dev
1212019-05-31T09:10:19 *** timothy has joined #bitcoin-core-dev
1222019-05-31T09:23:28 *** bg002h has quit IRC
1232019-05-31T09:30:42 *** setpill has joined #bitcoin-core-dev
1242019-05-31T09:41:49 *** promag has joined #bitcoin-core-dev
1252019-05-31T09:44:37 *** promag has quit IRC
1262019-05-31T09:46:55 *** sean8219 has joined #bitcoin-core-dev
1272019-05-31T09:51:38 *** arubi has quit IRC
1282019-05-31T09:51:59 *** promag has joined #bitcoin-core-dev
1292019-05-31T09:54:47 *** promag_ has joined #bitcoin-core-dev
1302019-05-31T09:54:59 *** arubi has joined #bitcoin-core-dev
1312019-05-31T10:09:55 *** ccdle12 has quit IRC
1322019-05-31T10:18:33 *** spinza has quit IRC
1332019-05-31T10:19:21 *** AaronvanW has quit IRC
1342019-05-31T10:21:43 *** EagleTM has joined #bitcoin-core-dev
1352019-05-31T10:24:46 *** EagleTM has quit IRC
1362019-05-31T10:25:08 *** EagleTM has joined #bitcoin-core-dev
1372019-05-31T10:27:12 *** sean8219 has quit IRC
1382019-05-31T10:28:33 *** spinza has joined #bitcoin-core-dev
1392019-05-31T10:30:19 *** sean8219 has joined #bitcoin-core-dev
1402019-05-31T10:30:47 *** EagleTM has quit IRC
1412019-05-31T10:31:13 *** EagleTM has joined #bitcoin-core-dev
1422019-05-31T10:31:42 *** promag_ has quit IRC
1432019-05-31T10:37:10 *** EagleTM has quit IRC
1442019-05-31T10:37:33 *** EagleTM has joined #bitcoin-core-dev
1452019-05-31T10:39:09 *** sean8219 has quit IRC
1462019-05-31T10:40:31 *** sean8219 has joined #bitcoin-core-dev
1472019-05-31T10:41:24 *** EagleTM has quit IRC
1482019-05-31T10:41:48 *** EagleTM has joined #bitcoin-core-dev
1492019-05-31T10:43:56 *** EagleTM has quit IRC
1502019-05-31T10:50:20 *** ccdle12 has joined #bitcoin-core-dev
1512019-05-31T10:51:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1522019-05-31T10:54:46 *** ccdle12 has quit IRC
1532019-05-31T11:14:53 *** jonatack has joined #bitcoin-core-dev
1542019-05-31T11:15:57 *** sean8219 has quit IRC
1552019-05-31T11:17:52 *** siom has quit IRC
1562019-05-31T11:19:11 *** sean8219 has joined #bitcoin-core-dev
1572019-05-31T11:21:56 *** oneark has quit IRC
1582019-05-31T11:23:10 *** ddustin has quit IRC
1592019-05-31T11:24:06 *** neh7u72xiydibedi has left #bitcoin-core-dev
1602019-05-31T11:25:19 *** ccdle12 has joined #bitcoin-core-dev
1612019-05-31T11:26:27 *** siom has joined #bitcoin-core-dev
1622019-05-31T11:45:46 *** NielsThijssen has quit IRC
1632019-05-31T11:46:27 *** promag_ has joined #bitcoin-core-dev
1642019-05-31T11:47:58 *** Chris_Stewart_5 has quit IRC
1652019-05-31T11:49:00 *** siom has quit IRC
1662019-05-31T11:50:43 *** promag_ has quit IRC
1672019-05-31T11:53:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1682019-05-31T12:00:02 *** bshum1 has quit IRC
1692019-05-31T12:04:24 *** jdsharp has joined #bitcoin-core-dev
1702019-05-31T12:07:29 *** hebasto has quit IRC
1712019-05-31T12:07:44 *** hebasto has joined #bitcoin-core-dev
1722019-05-31T12:12:58 *** promag has quit IRC
1732019-05-31T12:13:47 *** sean8219 has quit IRC
1742019-05-31T12:14:49 *** hebasto has quit IRC
1752019-05-31T12:26:08 *** lightningbot has joined #bitcoin-core-dev
1762019-05-31T12:26:14 *** setpill has joined #bitcoin-core-dev
1772019-05-31T12:26:22 *** paracyst has joined #bitcoin-core-dev
1782019-05-31T12:26:32 *** gleb has joined #bitcoin-core-dev
1792019-05-31T12:28:09 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1802019-05-31T12:28:18 *** jb55 has joined #bitcoin-core-dev
1812019-05-31T12:28:40 *** promag has quit IRC
1822019-05-31T12:28:55 *** sean8219 has joined #bitcoin-core-dev
1832019-05-31T12:36:23 *** sean8219 has quit IRC
1842019-05-31T12:38:07 *** sean8219 has joined #bitcoin-core-dev
1852019-05-31T12:42:49 *** sean8219 has quit IRC
1862019-05-31T12:45:27 *** sean8219 has joined #bitcoin-core-dev
1872019-05-31T12:58:40 *** sean8219 has quit IRC
1882019-05-31T12:59:53 *** spaced0ut has joined #bitcoin-core-dev
1892019-05-31T13:05:02 *** hsmiths has joined #bitcoin-core-dev
1902019-05-31T13:09:17 *** siom has joined #bitcoin-core-dev
1912019-05-31T13:10:38 *** sean8219 has joined #bitcoin-core-dev
1922019-05-31T13:16:40 *** sean8219 has quit IRC
1932019-05-31T13:17:26 *** sean8219 has joined #bitcoin-core-dev
1942019-05-31T13:23:22 *** sean8219 has quit IRC
1952019-05-31T13:25:10 *** sean8219 has joined #bitcoin-core-dev
1962019-05-31T13:27:53 *** scoop has joined #bitcoin-core-dev
1972019-05-31T13:36:18 <instagibbs> phantomcircuit_, oh huh I am blind, there it is
1982019-05-31T13:43:15 *** _Sam-- has joined #bitcoin-core-dev
1992019-05-31T13:48:43 *** setpill has quit IRC
2002019-05-31T13:50:44 *** d_t has joined #bitcoin-core-dev
2012019-05-31T13:50:44 *** shesek has joined #bitcoin-core-dev
2022019-05-31T13:50:44 *** shesek has joined #bitcoin-core-dev
2032019-05-31T13:51:28 *** Chris_Stewart_5 has quit IRC
2042019-05-31T13:52:18 *** sean8219 has quit IRC
2052019-05-31T13:53:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2062019-05-31T13:53:53 *** sean8219 has joined #bitcoin-core-dev
2072019-05-31T14:05:15 *** cluelessperson has quit IRC
2082019-05-31T14:05:54 *** jtimon has joined #bitcoin-core-dev
2092019-05-31T14:07:36 *** bitcoin-git has joined #bitcoin-core-dev
2102019-05-31T14:07:36 <bitcoin-git> [bitcoin] instagibbs opened pull request #16128: Delete error-prone CScript constructor only used with FindAndDelete (master...cscript_construct) https://github.com/bitcoin/bitcoin/pull/16128
2112019-05-31T14:07:39 *** bitcoin-git has left #bitcoin-core-dev
2122019-05-31T14:16:06 *** Karyon has quit IRC
2132019-05-31T14:18:10 *** cluelessperson has joined #bitcoin-core-dev
2142019-05-31T14:22:21 *** timothy has quit IRC
2152019-05-31T14:30:58 *** kelvene has joined #bitcoin-core-dev
2162019-05-31T14:31:37 *** sean8219 has quit IRC
2172019-05-31T14:32:04 *** gmccklins has joined #bitcoin-core-dev
2182019-05-31T14:32:28 *** sean8219 has joined #bitcoin-core-dev
2192019-05-31T14:33:10 *** gmccklins has left #bitcoin-core-dev
2202019-05-31T14:33:42 *** michaelsdunn1 has joined #bitcoin-core-dev
2212019-05-31T14:34:37 *** pinheadmz has joined #bitcoin-core-dev
2222019-05-31T14:36:27 *** ccdle12 has quit IRC
2232019-05-31T14:51:20 *** d_t has quit IRC
2242019-05-31T14:52:27 *** sfhi has joined #bitcoin-core-dev
2252019-05-31T14:54:47 *** sfhi2 has joined #bitcoin-core-dev
2262019-05-31T14:54:49 *** scoop has quit IRC
2272019-05-31T14:55:28 *** scoop has joined #bitcoin-core-dev
2282019-05-31T14:57:24 *** sfhi has quit IRC
2292019-05-31T15:00:01 *** jdsharp has quit IRC
2302019-05-31T15:01:18 *** scoop has quit IRC
2312019-05-31T15:01:43 *** scoop has joined #bitcoin-core-dev
2322019-05-31T15:03:02 *** scoop has quit IRC
2332019-05-31T15:03:38 *** scoop has joined #bitcoin-core-dev
2342019-05-31T15:04:20 *** bitcoin-git has joined #bitcoin-core-dev
2352019-05-31T15:04:20 <bitcoin-git> [bitcoin] practicalswift opened pull request #16129: Make reasoning about dependencies easier by not including unused dependencies (master...decouple-translation-units) https://github.com/bitcoin/bitcoin/pull/16129
2362019-05-31T15:04:21 *** bitcoin-git has left #bitcoin-core-dev
2372019-05-31T15:04:27 *** Cotillion has joined #bitcoin-core-dev
2382019-05-31T15:08:43 *** scoop has quit IRC
2392019-05-31T15:09:08 *** siom has quit IRC
2402019-05-31T15:14:58 *** sfhi has joined #bitcoin-core-dev
2412019-05-31T15:15:41 *** captjakk has joined #bitcoin-core-dev
2422019-05-31T15:15:56 *** b10c has joined #bitcoin-core-dev
2432019-05-31T15:18:24 *** sfhi2 has quit IRC
2442019-05-31T15:18:37 *** sean8219 has quit IRC
2452019-05-31T15:19:58 *** sean8219 has joined #bitcoin-core-dev
2462019-05-31T15:21:20 *** sean8219 has joined #bitcoin-core-dev
2472019-05-31T15:25:21 *** jarthur has joined #bitcoin-core-dev
2482019-05-31T15:25:54 *** d_t has joined #bitcoin-core-dev
2492019-05-31T15:32:57 *** sean8219 has quit IRC
2502019-05-31T15:32:59 *** timothy has joined #bitcoin-core-dev
2512019-05-31T15:33:14 *** Karyon has joined #bitcoin-core-dev
2522019-05-31T15:33:59 *** scoop has joined #bitcoin-core-dev
2532019-05-31T15:34:13 *** sean8219 has joined #bitcoin-core-dev
2542019-05-31T15:37:26 *** Guyver2 has joined #bitcoin-core-dev
2552019-05-31T15:38:34 *** scoop has quit IRC
2562019-05-31T15:39:29 *** peltre has quit IRC
2572019-05-31T15:40:51 *** peltre has joined #bitcoin-core-dev
2582019-05-31T15:42:25 *** sean8219 has left #bitcoin-core-dev
2592019-05-31T15:45:51 *** spaced0ut has quit IRC
2602019-05-31T15:46:25 *** kelvene has left #bitcoin-core-dev
2612019-05-31T16:04:00 *** kljasdfvv has quit IRC
2622019-05-31T16:23:19 *** siom has joined #bitcoin-core-dev
2632019-05-31T16:29:40 *** siom has quit IRC
2642019-05-31T16:43:12 *** Chris_Stewart_5 has quit IRC
2652019-05-31T16:47:59 *** scoop has joined #bitcoin-core-dev
2662019-05-31T16:52:33 *** scoop has quit IRC
2672019-05-31T16:58:05 *** darosior has quit IRC
2682019-05-31T17:14:16 *** scoop has joined #bitcoin-core-dev
2692019-05-31T17:14:34 *** scoop has quit IRC
2702019-05-31T17:14:40 *** scoop has joined #bitcoin-core-dev
2712019-05-31T17:15:31 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2722019-05-31T17:34:40 *** scoop has quit IRC
2732019-05-31T17:37:20 *** scoop has joined #bitcoin-core-dev
2742019-05-31T17:39:27 *** scoop has quit IRC
2752019-05-31T17:40:34 *** scoop has joined #bitcoin-core-dev
2762019-05-31T17:41:30 *** scoop has quit IRC
2772019-05-31T17:41:37 *** scoop has joined #bitcoin-core-dev
2782019-05-31T18:00:02 *** Cotillion has quit IRC
2792019-05-31T18:14:25 *** angvp has joined #bitcoin-core-dev
2802019-05-31T18:14:29 *** angvp is now known as Guest93850
2812019-05-31T18:19:27 *** bitcoin-git has joined #bitcoin-core-dev
2822019-05-31T18:19:28 <bitcoin-git> [bitcoin] stevenroose opened pull request #16130: Don't GPG sign intermediate commits with github-merge tool (master...contrib-no-sign) https://github.com/bitcoin/bitcoin/pull/16130
2832019-05-31T18:19:28 *** bitcoin-git has left #bitcoin-core-dev
2842019-05-31T18:21:27 <stevenroose> Anyone else here has a Yubikey and .gitconfig configured to always sign commits?
2852019-05-31T18:22:05 <stevenroose> I use the python script a lot for Elements, I recognize that for bitcoin the subset of contributors that actually use the script is small.
2862019-05-31T18:22:07 <dongcarl> stevenroose: Yup, sup
2872019-05-31T18:23:01 <dongcarl> BTW, build system lessons with Cory happening in #bitcoin-builds right now if people wanna join
2882019-05-31T18:25:40 *** ldz27 has joined #bitcoin-core-dev
2892019-05-31T18:31:35 <ldz27> hi, I wanted to ask for the creation of the secp256k1_vc142 nuget-package. I see Pieter Wuille is the author of the older versions and I hope I am right here.
2902019-05-31T18:33:44 <sipa> i know nothing about nuget
2912019-05-31T18:35:38 <gwillen> ldz27: it looks like Erik Voskuil was making the -vc packages, according to https://www.nuget.org/packages?q=secp256k1
2922019-05-31T18:35:47 <gwillen> but it looks like he stopped in 2017
2932019-05-31T18:36:18 <gwillen> but I also know nothing about nuget so I'm not really sure how it works
2942019-05-31T18:36:39 <gwillen> it looks like there are a number of different people packaging libsecp256k1 for it under different names
2952019-05-31T18:36:57 <ldz27> sipa: ok, sorry for the confusion. gwillen: thank you for the information :)
2962019-05-31T18:37:11 <gwillen> no problem!
2972019-05-31T18:44:06 *** unknown-os has joined #bitcoin-core-dev
2982019-05-31T18:44:16 <jeremyrubin> Does anyone have any good documentation on how script parsing works around OP_IF and PUSHDATA
2992019-05-31T18:45:37 <jeremyrubin> I'm generally confused about how we handle the script: OP_IF PUSHDATA32 <OP_ELSE <30 bytes> OP_ENDIF> OP_ENDIF
3002019-05-31T18:46:29 <jeremyrubin> or I guess more confusingly
3012019-05-31T18:47:14 <jeremyrubin> OP_IF PUSHDATA32 <OP_ELSE <31 bytes>> OP_ENDIF
3022019-05-31T18:48:01 <jeremyrubin> Is it that we scan until the next OP_ELSE/END if OP_IF is false, but we parse pushdata along the way?
3032019-05-31T18:49:49 <luke-jr> OP_IF just restricts execution, not parsing
3042019-05-31T18:50:01 <luke-jr> indeed, an invalid opcode inside the OP_IF still causes the script to fail (IIRC)
3052019-05-31T18:50:24 <jeremyrubin> gotcha
3062019-05-31T18:51:57 <jeremyrubin> I guess my issue is that I'd like to introduce a new pushdata type opcode (for OP_COSHV related stuff). And the best way to do that seems to be to modify GetOp, but GetOp doesn't take flags, so I was wondering if it's generally safe to do inside of execution.
3072019-05-31T18:52:04 <jeremyrubin> But then this issue came up
3082019-05-31T18:52:13 <jeremyrubin> So I probably do need to end up adding flags to GetOp?
3092019-05-31T18:52:51 *** jonatack has quit IRC
3102019-05-31T18:56:09 *** Dean_Guss has quit IRC
3112019-05-31T18:56:20 *** Dean_Guss has joined #bitcoin-core-dev
3122019-05-31T19:00:25 *** phantomcircuit_ is now known as phantomcircuit
3132019-05-31T19:14:11 *** spinza has quit IRC
3142019-05-31T19:27:55 *** Dean_Guss has quit IRC
3152019-05-31T19:33:53 *** jarthur has quit IRC
3162019-05-31T19:34:46 *** hebasto has joined #bitcoin-core-dev
3172019-05-31T19:35:42 *** spinza has joined #bitcoin-core-dev
3182019-05-31T19:36:52 *** pinheadmz has quit IRC
3192019-05-31T19:37:37 *** shigeya has quit IRC
3202019-05-31T19:40:36 *** shigeya has joined #bitcoin-core-dev
3212019-05-31T19:43:14 *** jarthur has joined #bitcoin-core-dev
3222019-05-31T19:48:19 *** promag has joined #bitcoin-core-dev
3232019-05-31T20:08:32 *** Chris_Stewart_5 has quit IRC
3242019-05-31T20:10:20 *** EagleTM has joined #bitcoin-core-dev
3252019-05-31T20:10:45 *** promag has quit IRC
3262019-05-31T20:15:42 *** dgenr8 has quit IRC
3272019-05-31T20:25:15 *** scoop has quit IRC
3282019-05-31T20:25:41 *** scoop has joined #bitcoin-core-dev
3292019-05-31T20:29:03 *** scoop has quit IRC
3302019-05-31T20:29:10 *** scoop has joined #bitcoin-core-dev
3312019-05-31T20:29:22 *** pinheadmz has joined #bitcoin-core-dev
3322019-05-31T20:37:59 *** pinheadmz has quit IRC
3332019-05-31T20:38:46 *** pinheadmz has joined #bitcoin-core-dev
3342019-05-31T20:40:17 *** roconnor has joined #bitcoin-core-dev
3352019-05-31T20:43:58 <roconnor> I know this is core-dev, but FWIW, there are other ways of dividing up the parsing and execution of opcodes in Script. For my Haskell work I match up IFs ELSEIFs and ENDIFs at parsing time, and handle invalid opcodes inside OP_IF as parsing errors. This has the operational effect that in my implementation mismatched ENDIFs fail at parse time rather than execution time. However this doesn't cause any semantic difference
3362019-05-31T20:43:59 <roconnor> between how Bitcoin Core interprets Script.
3372019-05-31T20:45:13 <roconnor> Script opcodes are self-delimiting, that is why OP_IF PUSHDATA32 <OP_ELSE <31 bytes>> OP_ENDIF doesn't cause problems. PUSHDATA32 <OP_ELSE <31 bytes>> is a single (parameterized) opcode.
3382019-05-31T20:46:27 <roconnor> perhaps better written as PUSHDATA32[<OP_ELSE <31 bytes>>] or PUSHDATA32(<OP_ELSE <31 bytes>>).
3392019-05-31T20:51:18 *** sfhi has quit IRC
3402019-05-31T20:59:04 <phantomcircuit> roconnor, invalid opcodes only trigger an error if they're actually hit
3412019-05-31T20:59:06 <phantomcircuit> so it's a protocol violation to throw an exception on an invalid opcode in an OP_IF
3422019-05-31T20:59:08 <phantomcircuit> (i think
3432019-05-31T21:00:02 *** Guest93850 has quit IRC
3442019-05-31T21:00:27 <roconnor> I'm refering specifically to OP_VER and friends.
3452019-05-31T21:00:36 <roconnor> Sorry for not being clearer before.
3462019-05-31T21:00:42 *** pinheadmz has quit IRC
3472019-05-31T21:00:53 <roconnor> er, I mean OP_VERIF
3482019-05-31T21:01:32 <roconnor> Hmm, I thought there was more than just OP_VERIF and OP_VERNOTIF, but I guess that was it.
3492019-05-31T21:01:37 <jb55> phantomcircuit: correct https://jb55.com/s/e45a49f6af664e7a.txt
3502019-05-31T21:02:25 *** mryandao has quit IRC
3512019-05-31T21:02:44 *** mryandao has joined #bitcoin-core-dev
3522019-05-31T21:02:52 <roconnor> you are correct that other opcode must be parsed.
3532019-05-31T21:04:12 <jb55> so what's this idea with pushing script as pushdata? am I missing some context here
3542019-05-31T21:06:38 *** b10c has joined #bitcoin-core-dev
3552019-05-31T21:07:13 <roconnor> I think there was a question if if OP_IF were to naively scan over the bytearray representing script, it would stop when it finds the code for OP_ENDIF or OP_ELSE even within the parameter to an OP_PUSHDATA opcode.
3562019-05-31T21:11:54 *** Guyver2 has quit IRC
3572019-05-31T21:12:03 *** b10c has quit IRC
3582019-05-31T21:14:22 *** timothy has quit IRC
3592019-05-31T21:16:18 *** pinheadmz has joined #bitcoin-core-dev
3602019-05-31T21:17:09 *** dhart has joined #bitcoin-core-dev
3612019-05-31T21:20:31 *** d_t has quit IRC
3622019-05-31T21:22:01 <jb55> it wouldn't interpret it as endif it would interpret it as the length argument to pushdata if I'm understanding the question correctly
3632019-05-31T21:22:34 *** jarthur has quit IRC
3642019-05-31T21:23:56 <jb55> s/endif/else
3652019-05-31T21:25:21 *** scoop has quit IRC
3662019-05-31T21:26:11 <jb55> oh he said pushdata32, nm
3672019-05-31T21:27:08 *** scoop has joined #bitcoin-core-dev
3682019-05-31T21:29:07 <jb55> so this scenario https://jb55.com/s/9bcffd1e24209b53.txt, so basically what roconnor said
3692019-05-31T21:43:34 *** justan0theruser has joined #bitcoin-core-dev
3702019-05-31T21:44:32 *** justanotheruser has quit IRC
3712019-05-31T22:00:05 *** captjakk has quit IRC
3722019-05-31T22:00:32 *** arubi has quit IRC
3732019-05-31T22:00:58 *** arubi has joined #bitcoin-core-dev
3742019-05-31T22:03:31 *** petteri has quit IRC
3752019-05-31T22:11:21 *** promag has joined #bitcoin-core-dev
3762019-05-31T22:12:22 *** AaronvanW has joined #bitcoin-core-dev
3772019-05-31T22:15:29 *** promag has quit IRC
3782019-05-31T22:22:28 <warren> Regarding the mailing list, LF had higher priorities to deal with on infra for this time and they aren't going to shut down the existing list anytime soon because of other kernel subprojects. Their DoS mitigations seem to be holding it steady for now. Reapproaching this probably in June when folks are not traveling anymore.
3792019-05-31T22:23:30 <warren> It sucks that their mailman server was crippled by attacks on bitcoin-dev in particular. They remain blackholed to several major mail providers like Yahoo. I think bounces are also entirely disabled now as one of the DoS mitigation measures.
3802019-05-31T22:25:37 *** J has joined #bitcoin-core-dev
3812019-05-31T22:26:01 *** J is now known as Guest70113
3822019-05-31T22:26:03 *** scoop has quit IRC
3832019-05-31T22:26:23 *** pinheadmz has quit IRC
3842019-05-31T22:27:11 *** scoop has joined #bitcoin-core-dev
3852019-05-31T22:30:07 *** spinza has quit IRC
3862019-05-31T22:31:15 *** Guest70113 has quit IRC
3872019-05-31T22:31:45 *** scoop has quit IRC
3882019-05-31T22:32:46 *** michaelsdunn1 has quit IRC
3892019-05-31T22:33:08 <jb55> :(
3902019-05-31T22:35:14 *** pinheadmz has joined #bitcoin-core-dev
3912019-05-31T22:39:32 *** hebasto has quit IRC
3922019-05-31T22:40:56 *** jtimon_ has joined #bitcoin-core-dev
3932019-05-31T22:42:32 *** jtimon has quit IRC
3942019-05-31T22:42:39 *** jtimon_ has quit IRC
3952019-05-31T22:42:54 *** jtimon has joined #bitcoin-core-dev
3962019-05-31T22:43:06 *** d_t has joined #bitcoin-core-dev
3972019-05-31T22:51:59 *** scoop has joined #bitcoin-core-dev
3982019-05-31T22:53:03 *** spinza has joined #bitcoin-core-dev
3992019-05-31T23:00:50 *** ctrlbreak has quit IRC
4002019-05-31T23:16:34 *** ccdle12 has joined #bitcoin-core-dev
4012019-05-31T23:23:23 *** scoop has quit IRC
4022019-05-31T23:27:15 *** pinheadmz has quit IRC
4032019-05-31T23:28:57 *** pinheadmz has joined #bitcoin-core-dev
4042019-05-31T23:53:51 *** scoop has joined #bitcoin-core-dev
4052019-05-31T23:57:58 *** scoop has quit IRC