12019-06-21T00:00:01 *** chaosagent has quit IRC
22019-06-21T00:01:19 *** bitcoin-git has joined #bitcoin-core-dev
32019-06-21T00:01:19 <bitcoin-git> [bitcoin] Sjors opened pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257
42019-06-21T00:01:20 *** bitcoin-git has left #bitcoin-core-dev
52019-06-21T00:08:28 <promag> achow101: have you tested #16215?
62019-06-21T00:08:29 <gribble> https://github.com/bitcoin/bitcoin/issues/16215 | gui: Refactor wallet controller activities by promag · Pull Request #16215 · bitcoin/bitcoin · GitHub
72019-06-21T00:08:45 <promag> I can split, no problem
82019-06-21T00:10:53 *** Chris_Stewart_5 has joined #bitcoin-core-dev
92019-06-21T00:14:35 *** hugohn has joined #bitcoin-core-dev
102019-06-21T00:19:57 *** pwgn has joined #bitcoin-core-dev
112019-06-21T00:21:59 <promag> achow101: actually if I split then I'd have to implement CreateWalletActivity, like current OpenWalletActivity, which is not that great compared to 16215.
122019-06-21T00:24:18 <promag> ryanofsky suggestion makes sense because avoids refactor PRs, but if I split then we would have different refactor: refactor both activities to a better approach.
132019-06-21T00:25:34 *** hugohn has quit IRC
142019-06-21T00:26:31 <promag> what makes more sense to me is to first refactor OpenWalletActivity, then your PR could have my the remaining changes squashed in the correct commits.
152019-06-21T00:26:38 <promag> let me know what you think
162019-06-21T00:28:35 <promag> fanquake: mind testing #16231? ty
172019-06-21T00:28:36 <gribble> https://github.com/bitcoin/bitcoin/issues/16231 | gui: Fix open wallet menu initialization order by promag · Pull Request #16231 · bitcoin/bitcoin · GitHub
182019-06-21T00:28:41 *** dviola has quit IRC
192019-06-21T00:31:06 <fanquake> promag ok
202019-06-21T00:32:36 *** hugohn has joined #bitcoin-core-dev
212019-06-21T00:34:09 *** EagleTM has quit IRC
222019-06-21T00:51:45 *** ylbam has quit IRC
232019-06-21T00:51:49 *** jonatack has quit IRC
242019-06-21T00:59:03 *** promag has quit IRC
252019-06-21T01:14:53 *** bralyclow01 has joined #bitcoin-core-dev
262019-06-21T01:15:28 *** scoop has quit IRC
272019-06-21T01:17:29 *** justanotheruser has quit IRC
282019-06-21T01:17:31 *** AaronvanW has quit IRC
292019-06-21T01:18:36 *** bralyclow has quit IRC
302019-06-21T01:33:19 *** Chris_Stewart_5 has quit IRC
312019-06-21T01:36:42 *** queip has quit IRC
322019-06-21T01:36:49 *** rafalcpp has joined #bitcoin-core-dev
332019-06-21T01:37:16 *** rafalcpp_ has quit IRC
342019-06-21T01:43:21 *** queip has joined #bitcoin-core-dev
352019-06-21T01:44:48 *** spinza has quit IRC
362019-06-21T01:48:40 *** aseem has joined #bitcoin-core-dev
372019-06-21T01:51:28 *** hugohn has quit IRC
382019-06-21T01:52:16 *** d_t has quit IRC
392019-06-21T01:59:31 *** AaronvanW has joined #bitcoin-core-dev
402019-06-21T02:04:50 *** AaronvanW has quit IRC
412019-06-21T02:07:52 *** spinza has joined #bitcoin-core-dev
422019-06-21T02:12:52 *** AaronvanW has joined #bitcoin-core-dev
432019-06-21T02:25:46 *** ccdle12 has joined #bitcoin-core-dev
442019-06-21T02:27:08 *** ccdle12_ has joined #bitcoin-core-dev
452019-06-21T02:27:08 *** ccdle12 has quit IRC
462019-06-21T02:28:14 *** ccdle12_ has quit IRC
472019-06-21T02:28:31 *** ccdle12 has joined #bitcoin-core-dev
482019-06-21T02:31:57 *** dgenr8 has quit IRC
492019-06-21T02:37:48 *** bralyclow has joined #bitcoin-core-dev
502019-06-21T02:40:00 *** AaronvanW has quit IRC
512019-06-21T02:41:18 *** bralyclow01 has quit IRC
522019-06-21T02:43:44 *** scoop has joined #bitcoin-core-dev
532019-06-21T02:47:59 *** scoop has quit IRC
542019-06-21T02:50:29 *** scoop has joined #bitcoin-core-dev
552019-06-21T02:59:11 *** elichai2 has quit IRC
562019-06-21T02:59:40 *** promag has joined #bitcoin-core-dev
572019-06-21T03:00:01 *** pwgn has quit IRC
582019-06-21T03:02:56 *** DeanGuss has joined #bitcoin-core-dev
592019-06-21T03:04:01 *** promag has quit IRC
602019-06-21T03:04:28 *** gchaix1 has joined #bitcoin-core-dev
612019-06-21T03:14:06 *** justanotheruser has joined #bitcoin-core-dev
622019-06-21T03:15:26 *** ddustin has quit IRC
632019-06-21T03:16:12 *** ddustin has joined #bitcoin-core-dev
642019-06-21T03:16:54 *** ddustin has quit IRC
652019-06-21T03:17:01 *** scoop has quit IRC
662019-06-21T03:17:43 *** scoop has joined #bitcoin-core-dev
672019-06-21T03:19:26 *** skyikot has quit IRC
682019-06-21T03:27:04 *** scoop_ has joined #bitcoin-core-dev
692019-06-21T03:27:04 *** scoop has quit IRC
702019-06-21T03:29:15 *** aseem has quit IRC
712019-06-21T03:29:15 *** scoop_ has quit IRC
722019-06-21T03:29:36 *** scoop has joined #bitcoin-core-dev
732019-06-21T03:31:37 *** scoop_ has joined #bitcoin-core-dev
742019-06-21T03:31:37 *** scoop has quit IRC
752019-06-21T03:33:01 *** hebasto has joined #bitcoin-core-dev
762019-06-21T03:34:47 *** surja795 has joined #bitcoin-core-dev
772019-06-21T03:37:05 *** scoop has joined #bitcoin-core-dev
782019-06-21T03:37:14 *** scoop_ has quit IRC
792019-06-21T03:37:17 *** scoop has quit IRC
802019-06-21T03:39:11 *** scoop has joined #bitcoin-core-dev
812019-06-21T03:42:59 *** bralyclow01 has joined #bitcoin-core-dev
822019-06-21T03:43:08 *** scoop has quit IRC
832019-06-21T03:43:35 *** bralyclo_ has joined #bitcoin-core-dev
842019-06-21T03:44:01 *** scoop_ has joined #bitcoin-core-dev
852019-06-21T03:45:04 *** bralyclow has quit IRC
862019-06-21T03:45:11 *** bralycl__ has joined #bitcoin-core-dev
872019-06-21T03:46:27 *** scoop has joined #bitcoin-core-dev
882019-06-21T03:46:27 *** scoop_ has quit IRC
892019-06-21T03:47:08 *** bralyclow01 has quit IRC
902019-06-21T03:47:09 *** scoop has quit IRC
912019-06-21T03:48:40 *** scoop_ has joined #bitcoin-core-dev
922019-06-21T03:48:47 *** bralyclo_ has quit IRC
932019-06-21T03:49:09 *** scoop_ has quit IRC
942019-06-21T03:49:20 *** scoop_ has joined #bitcoin-core-dev
952019-06-21T03:52:09 *** scoop_ has quit IRC
962019-06-21T03:52:17 *** scoop has joined #bitcoin-core-dev
972019-06-21T03:57:03 *** scoop has quit IRC
982019-06-21T03:58:07 *** scoop has joined #bitcoin-core-dev
992019-06-21T03:58:14 *** AaronvanW has joined #bitcoin-core-dev
1002019-06-21T04:02:33 *** scoop has quit IRC
1012019-06-21T04:04:29 *** hebasto has quit IRC
1022019-06-21T04:06:58 *** scoop has joined #bitcoin-core-dev
1032019-06-21T04:09:02 *** rh0nj has quit IRC
1042019-06-21T04:11:11 *** scoop has quit IRC
1052019-06-21T04:12:07 *** rh0nj has joined #bitcoin-core-dev
1062019-06-21T04:23:22 *** surja795 has quit IRC
1072019-06-21T04:25:39 *** ccdle12 has quit IRC
1082019-06-21T04:31:42 *** AaronvanW has quit IRC
1092019-06-21T04:42:12 *** ccdle12 has joined #bitcoin-core-dev
1102019-06-21T04:53:12 *** midnightmagic has joined #bitcoin-core-dev
1112019-06-21T04:54:28 *** surja795 has joined #bitcoin-core-dev
1122019-06-21T04:59:01 *** ccdle12 has quit IRC
1132019-06-21T04:59:12 *** surja795 has quit IRC
1142019-06-21T05:02:17 *** bralycl__ has quit IRC
1152019-06-21T05:02:58 *** bralyclow has joined #bitcoin-core-dev
1162019-06-21T05:07:57 *** bralyclow has quit IRC
1172019-06-21T05:15:13 *** hebasto has joined #bitcoin-core-dev
1182019-06-21T05:17:28 *** ddustin has joined #bitcoin-core-dev
1192019-06-21T05:18:45 *** scoop has joined #bitcoin-core-dev
1202019-06-21T05:21:36 *** ddustin has quit IRC
1212019-06-21T05:29:00 *** surja795 has joined #bitcoin-core-dev
1222019-06-21T05:33:52 *** surja795 has quit IRC
1232019-06-21T05:40:27 *** reallll has quit IRC
1242019-06-21T05:46:07 *** reallll has joined #bitcoin-core-dev
1252019-06-21T05:48:52 *** bralyclow has joined #bitcoin-core-dev
1262019-06-21T05:53:50 *** scoop has quit IRC
1272019-06-21T05:59:00 *** bralyclow has quit IRC
1282019-06-21T05:59:16 *** bralyclow has joined #bitcoin-core-dev
1292019-06-21T06:00:02 *** gchaix1 has quit IRC
1302019-06-21T06:03:46 *** beng-nl1 has joined #bitcoin-core-dev
1312019-06-21T06:07:37 *** kallewoof has quit IRC
1322019-06-21T06:08:01 *** kallewoof has joined #bitcoin-core-dev
1332019-06-21T06:28:47 *** AaronvanW has joined #bitcoin-core-dev
1342019-06-21T06:31:39 *** rafalcpp_ has joined #bitcoin-core-dev
1352019-06-21T06:32:32 *** queip has quit IRC
1362019-06-21T06:32:40 *** rafalcpp has quit IRC
1372019-06-21T06:34:10 *** tryphe_ is now known as tryphe
1382019-06-21T06:38:58 *** queip has joined #bitcoin-core-dev
1392019-06-21T06:45:32 *** reallll is now known as belcher
1402019-06-21T06:54:27 <jonasschnelli> Is is somehow possible to emulate BE with Qemu? With reasonable performance? I remember doing it years ago but it was veeery slow?
1412019-06-21T06:55:23 <jonasschnelli> Or is it possible to use an ARM SoC-board (Odroid) to run a BE OS on ARM64?
1422019-06-21T06:57:35 <kallewoof> jonasschnelli: yes
1432019-06-21T06:57:51 <jonasschnelli> kallewoof: can you be more specific. :)
1442019-06-21T06:57:55 <kallewoof> I have a qemu instance for trying bitcoin compiling
1452019-06-21T06:58:00 <kallewoof> big endian.
1462019-06-21T06:58:20 <kallewoof> its not reasonable performance though, so... maybe "sorta" is more accurate than "yes".
1472019-06-21T06:58:50 <jonasschnelli> kallewoof: okay. But the compilation finishes at "some point"? Can you run the unit tests?
1482019-06-21T06:58:56 <kallewoof> yep!
1492019-06-21T06:59:21 <jonasschnelli> Great. Do you use PPC? Do you use Debian (since I guess they sill support PPC images)?
1502019-06-21T06:59:34 <kallewoof> its debian_wheezy_powerpc_standard.qcow2
1512019-06-21T06:59:47 <kallewoof> unfortunately debian stopped supporting ppc after wheezy
1522019-06-21T06:59:51 <jonasschnelli> Looks like everyone is using that
1532019-06-21T07:00:03 <jonasschnelli> The question is, if BE is reasonable anymore...
1542019-06-21T07:00:38 <kallewoof> i thought there was new hardware that was BE or could be BE
1552019-06-21T07:01:14 *** dviola has joined #bitcoin-core-dev
1562019-06-21T07:02:08 *** AaronvanW has quit IRC
1572019-06-21T07:04:55 <jonasschnelli> BE is probably relevant fpr the Power9 family
1582019-06-21T07:06:09 *** promag has joined #bitcoin-core-dev
1592019-06-21T07:07:21 *** mildly_risky has joined #bitcoin-core-dev
1602019-06-21T07:08:21 *** mildly_risky has quit IRC
1612019-06-21T07:26:12 *** bitcoin-git has joined #bitcoin-core-dev
1622019-06-21T07:26:12 <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
1632019-06-21T07:26:15 *** bitcoin-git has left #bitcoin-core-dev
1642019-06-21T07:37:13 <kallewoof> @sipa I am confused about a commit of yours from March 2016 (sorry..!), but someone else might be able to explain this: https://github.com/bitcoin/bitcoin/commit/8a253b342c5272496926ed391b078742bbe937ae -- the nInnerLoopCount restricts the nonce to 0..65535 (16 bits), but the nonce is 32 bits. Why? I realize if you make this 0xffffffff and try to Ctrl-C a bitcoind instance while trying to find a blokc, it will lock up and
1652019-06-21T07:37:13 <kallewoof> wait for the generate to finish. Is that why?
1662019-06-21T07:44:43 *** bitcoin-git has joined #bitcoin-core-dev
1672019-06-21T07:44:43 <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23815ee74dfd...303ec103bacf
1682019-06-21T07:44:43 <bitcoin-git> bitcoin/master a495034 Andrew Chow: Make and get the multisig redeemscript and destination in one function ins...
1692019-06-21T07:44:44 <bitcoin-git> bitcoin/master 303ec10 MeshCollider: Merge #16026: Ensure that uncompressed public keys in a multisig always re...
1702019-06-21T07:44:57 *** bitcoin-git has left #bitcoin-core-dev
1712019-06-21T07:45:33 *** bitcoin-git has joined #bitcoin-core-dev
1722019-06-21T07:45:33 <bitcoin-git> [bitcoin] meshcollider merged pull request #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address (master...dont-sw-ms-uncomp) https://github.com/bitcoin/bitcoin/pull/16026
1732019-06-21T07:45:46 *** bitcoin-git has left #bitcoin-core-dev
1742019-06-21T07:49:09 *** cncr04s has quit IRC
1752019-06-21T07:49:51 *** emilengler has joined #bitcoin-core-dev
1762019-06-21T07:54:36 *** astro has quit IRC
1772019-06-21T07:54:55 *** kljasdfvv has joined #bitcoin-core-dev
1782019-06-21T07:56:43 *** cncr04s has joined #bitcoin-core-dev
1792019-06-21T07:58:14 *** dviola has quit IRC
1802019-06-21T07:59:56 *** astro has joined #bitcoin-core-dev
1812019-06-21T08:00:13 *** bitcoin-git has joined #bitcoin-core-dev
1822019-06-21T08:00:14 <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/303ec103bacf...fd333e15a545
1832019-06-21T08:00:14 <bitcoin-git> bitcoin/master 7c611e2 Andrew Chow: Move ismine to wallet module
1842019-06-21T08:00:15 <bitcoin-git> bitcoin/master e61de63 Andrew Chow: Change ismine to take a CWallet instead of CKeyStore
1852019-06-21T08:00:15 <bitcoin-git> bitcoin/master fd333e1 MeshCollider: Merge #16226: Move ismine to the wallet module
1862019-06-21T08:00:17 *** bitcoin-git has left #bitcoin-core-dev
1872019-06-21T08:01:08 *** bitcoin-git has joined #bitcoin-core-dev
1882019-06-21T08:01:08 <bitcoin-git> [bitcoin] meshcollider merged pull request #16226: Move ismine to the wallet module (master...mv-ismine-wallet) https://github.com/bitcoin/bitcoin/pull/16226
1892019-06-21T08:01:13 *** bitcoin-git has left #bitcoin-core-dev
1902019-06-21T08:13:19 *** rex4539 has quit IRC
1912019-06-21T08:13:23 *** rafalcpp has joined #bitcoin-core-dev
1922019-06-21T08:13:43 *** queip has quit IRC
1932019-06-21T08:14:08 *** rafalcpp_ has quit IRC
1942019-06-21T08:18:37 *** kristapsk has quit IRC
1952019-06-21T08:20:11 *** queip has joined #bitcoin-core-dev
1962019-06-21T08:22:33 *** surja795 has joined #bitcoin-core-dev
1972019-06-21T08:23:57 *** DeanGuss has quit IRC
1982019-06-21T08:27:07 *** surja795 has quit IRC
1992019-06-21T08:36:00 *** Zenton has joined #bitcoin-core-dev
2002019-06-21T08:36:14 *** mryandao_ has joined #bitcoin-core-dev
2012019-06-21T08:36:22 *** mryandao has quit IRC
2022019-06-21T08:39:24 *** promag_ has joined #bitcoin-core-dev
2032019-06-21T08:40:00 *** sfhi has joined #bitcoin-core-dev
2042019-06-21T08:51:40 *** darosior has joined #bitcoin-core-dev
2052019-06-21T08:54:46 *** sfhi has quit IRC
2062019-06-21T09:00:01 *** beng-nl1 has quit IRC
2072019-06-21T09:00:25 *** AaronvanW has joined #bitcoin-core-dev
2082019-06-21T09:05:11 *** Honkeymagoo has joined #bitcoin-core-dev
2092019-06-21T09:12:31 *** timothy has joined #bitcoin-core-dev
2102019-06-21T09:14:45 *** EagleTM has joined #bitcoin-core-dev
2112019-06-21T09:26:10 *** rafalcpp_ has joined #bitcoin-core-dev
2122019-06-21T09:26:18 *** queip has quit IRC
2132019-06-21T09:27:11 *** rafalcpp has quit IRC
2142019-06-21T09:34:10 *** queip has joined #bitcoin-core-dev
2152019-06-21T09:48:48 *** EagleTM has quit IRC
2162019-06-21T09:50:50 *** anonymous8587 has joined #bitcoin-core-dev
2172019-06-21T09:53:08 *** anonymous8587 has quit IRC
2182019-06-21T09:56:46 *** darosior has quit IRC
2192019-06-21T10:04:10 *** AaronvanW has quit IRC
2202019-06-21T10:16:33 *** michaelfolkson has joined #bitcoin-core-dev
2212019-06-21T10:18:59 *** michaelfolkson has joined #bitcoin-core-dev
2222019-06-21T10:22:07 *** AaronvanW has joined #bitcoin-core-dev
2232019-06-21T10:33:10 *** michaelfolkson has quit IRC
2242019-06-21T10:37:41 *** astro has quit IRC
2252019-06-21T10:40:08 *** justanotheruser has quit IRC
2262019-06-21T10:41:25 *** Honkeymagoo has quit IRC
2272019-06-21T10:42:54 *** astro has joined #bitcoin-core-dev
2282019-06-21T10:42:56 *** bitcoin-git has joined #bitcoin-core-dev
2292019-06-21T10:42:57 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd333e15a545...32e94538185b
2302019-06-21T10:42:57 <bitcoin-git> bitcoin/master 5a88ea7 Jon Atack: doc: remove orphaned header in developer notes
2312019-06-21T10:42:58 <bitcoin-git> bitcoin/master 32e9453 fanquake: Merge #16256: doc: remove orphaned header in developer notes
2322019-06-21T10:43:00 *** bitcoin-git has left #bitcoin-core-dev
2332019-06-21T10:43:36 *** EagleTM has joined #bitcoin-core-dev
2342019-06-21T10:43:51 *** bitcoin-git has joined #bitcoin-core-dev
2352019-06-21T10:43:51 <bitcoin-git> [bitcoin] fanquake merged pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256
2362019-06-21T10:43:52 *** bitcoin-git has left #bitcoin-core-dev
2372019-06-21T10:44:31 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2382019-06-21T10:45:13 *** spinza has quit IRC
2392019-06-21T10:48:12 *** chriswang2019 has joined #bitcoin-core-dev
2402019-06-21T10:48:14 *** EagleTM has quit IRC
2412019-06-21T10:55:10 *** spinza has joined #bitcoin-core-dev
2422019-06-21T10:56:10 *** jonatack has joined #bitcoin-core-dev
2432019-06-21T10:56:45 *** chriswang2019 has quit IRC
2442019-06-21T10:59:03 *** lnostdal has quit IRC
2452019-06-21T10:59:37 *** queip has quit IRC
2462019-06-21T10:59:37 *** rafalcpp_ has quit IRC
2472019-06-21T10:59:54 *** rafalcpp_ has joined #bitcoin-core-dev
2482019-06-21T11:02:17 *** tlyu has joined #bitcoin-core-dev
2492019-06-21T11:04:10 *** justanotheruser has joined #bitcoin-core-dev
2502019-06-21T11:05:58 *** queip has joined #bitcoin-core-dev
2512019-06-21T11:09:36 *** lnostdal has joined #bitcoin-core-dev
2522019-06-21T11:21:40 *** rafalcpp has joined #bitcoin-core-dev
2532019-06-21T11:22:07 *** queip has quit IRC
2542019-06-21T11:22:08 *** rafalcpp_ has quit IRC
2552019-06-21T11:24:55 *** astro has quit IRC
2562019-06-21T11:28:26 *** queip has joined #bitcoin-core-dev
2572019-06-21T11:30:24 *** astro has joined #bitcoin-core-dev
2582019-06-21T11:32:09 *** bitcoin-git has joined #bitcoin-core-dev
2592019-06-21T11:32:09 <bitcoin-git> [bitcoin] natangl opened pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
2602019-06-21T11:32:10 *** bitcoin-git has left #bitcoin-core-dev
2612019-06-21T11:33:15 *** bitcoin-git has joined #bitcoin-core-dev
2622019-06-21T11:33:15 <bitcoin-git> [bitcoin] fanquake closed pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
2632019-06-21T11:33:18 *** bitcoin-git has left #bitcoin-core-dev
2642019-06-21T11:49:33 *** astro_ has joined #bitcoin-core-dev
2652019-06-21T11:51:55 *** astro has quit IRC
2662019-06-21T11:52:00 *** Chris_Stewart_5 has quit IRC
2672019-06-21T11:56:00 *** surja795 has joined #bitcoin-core-dev
2682019-06-21T11:56:24 *** promag_ has quit IRC
2692019-06-21T11:59:35 *** aiprivateexchang has joined #bitcoin-core-dev
2702019-06-21T12:00:02 *** tlyu has quit IRC
2712019-06-21T12:00:06 *** promag_ has joined #bitcoin-core-dev
2722019-06-21T12:00:07 *** aiprivateexchang has left #bitcoin-core-dev
2732019-06-21T12:00:58 *** qwebirc303118 has joined #bitcoin-core-dev
2742019-06-21T12:03:48 *** hds has joined #bitcoin-core-dev
2752019-06-21T12:12:01 *** promag_ has quit IRC
2762019-06-21T12:16:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2772019-06-21T12:18:05 *** darosior has joined #bitcoin-core-dev
2782019-06-21T12:26:40 *** surja795 has quit IRC
2792019-06-21T12:44:41 *** jonatack has quit IRC
2802019-06-21T12:57:15 *** provoostenator has quit IRC
2812019-06-21T13:06:33 *** shesek has quit IRC
2822019-06-21T13:08:03 *** shesek has joined #bitcoin-core-dev
2832019-06-21T13:09:32 *** scoop has joined #bitcoin-core-dev
2842019-06-21T13:12:42 *** shesek has quit IRC
2852019-06-21T13:13:04 *** Zenton has quit IRC
2862019-06-21T13:13:39 *** Zenton has joined #bitcoin-core-dev
2872019-06-21T13:14:43 *** shesek has joined #bitcoin-core-dev
2882019-06-21T13:21:28 *** shesek has quit IRC
2892019-06-21T13:31:25 *** provoostenator has joined #bitcoin-core-dev
2902019-06-21T13:34:50 *** promag_ has joined #bitcoin-core-dev
2912019-06-21T13:39:13 *** promag_ has quit IRC
2922019-06-21T13:40:47 *** hebasto has quit IRC
2932019-06-21T13:41:46 *** lightlike has joined #bitcoin-core-dev
2942019-06-21T13:45:59 *** bralyclow01 has joined #bitcoin-core-dev
2952019-06-21T13:46:39 *** elichai2 has joined #bitcoin-core-dev
2962019-06-21T13:49:53 *** bralyclow has quit IRC
2972019-06-21T13:50:21 *** d_t has joined #bitcoin-core-dev
2982019-06-21T13:53:22 *** aseem has joined #bitcoin-core-dev
2992019-06-21T13:55:19 <MarcoFalke> #proposedmeetingtopic 0.18.1: Backports #16035
3002019-06-21T13:55:21 <gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
3012019-06-21T14:03:04 *** dviola has joined #bitcoin-core-dev
3022019-06-21T14:08:31 *** mryandao has joined #bitcoin-core-dev
3032019-06-21T14:10:11 *** mryandao_ has quit IRC
3042019-06-21T14:16:54 *** provoostenator has quit IRC
3052019-06-21T14:17:26 *** Guyver2 has joined #bitcoin-core-dev
3062019-06-21T14:21:11 *** provoostenator has joined #bitcoin-core-dev
3072019-06-21T14:27:10 *** provoostenator has quit IRC
3082019-06-21T14:28:03 *** provoostenator has joined #bitcoin-core-dev
3092019-06-21T14:28:40 *** jonatack has joined #bitcoin-core-dev
3102019-06-21T14:30:12 *** hebasto has joined #bitcoin-core-dev
3112019-06-21T14:34:03 *** promag_ has joined #bitcoin-core-dev
3122019-06-21T14:34:15 *** michaelsdunn1 has joined #bitcoin-core-dev
3132019-06-21T14:37:39 *** PastaPasta has joined #bitcoin-core-dev
3142019-06-21T14:38:36 *** promag_ has quit IRC
3152019-06-21T14:40:50 *** captjakk has joined #bitcoin-core-dev
3162019-06-21T14:40:50 *** AaronvanW has quit IRC
3172019-06-21T14:46:26 *** pinheadmz has quit IRC
3182019-06-21T14:50:20 *** d_t has quit IRC
3192019-06-21T14:50:35 <phantomcircuit> kallewoof, there's a pr with comments https://github.com/bitcoin/bitcoin/pull/7663
3202019-06-21T14:56:00 <kallewoof> @phantomcircuit thanks!
3212019-06-21T14:58:42 *** shigeya has quit IRC
3222019-06-21T14:59:16 <phantomcircuit> kallewoof, you can get to those from the commit btw
3232019-06-21T14:59:27 <kallewoof> how?
3242019-06-21T14:59:36 <kallewoof> OH.
3252019-06-21T14:59:39 <kallewoof> doh. thanks.
3262019-06-21T14:59:40 <phantomcircuit> it's right above the author
3272019-06-21T14:59:48 <phantomcircuit> yeah i only noticed that recently
3282019-06-21T15:00:01 *** hds has quit IRC
3292019-06-21T15:01:18 *** bralyclow01 has quit IRC
3302019-06-21T15:01:57 *** bitcoin-git has joined #bitcoin-core-dev
3312019-06-21T15:01:58 <bitcoin-git> [bitcoin] promag opened pull request #16261: gui: Refactor OpenWalletActivity (master...2019-06-refactor-open-wallet) https://github.com/bitcoin/bitcoin/pull/16261
3322019-06-21T15:01:58 *** bitcoin-git has left #bitcoin-core-dev
3332019-06-21T15:02:00 *** bralyclow has joined #bitcoin-core-dev
3342019-06-21T15:03:27 *** shigeya has joined #bitcoin-core-dev
3352019-06-21T15:04:16 *** StopAndDecrypt has quit IRC
3362019-06-21T15:04:33 *** StopAndDecrypt has joined #bitcoin-core-dev
3372019-06-21T15:04:40 <kallewoof> phantomcircuit: unfortunately the PR doesnt give me any more clues as to why it only uses 16 out of 32 bits of the nonce...
3382019-06-21T15:04:42 *** StopAndDecrypt has quit IRC
3392019-06-21T15:04:42 *** StopAndDecrypt has joined #bitcoin-core-dev
3402019-06-21T15:07:38 *** bralyclow has quit IRC
3412019-06-21T15:07:59 <phantomcircuit> kallewoof, well it's just the inner loop
3422019-06-21T15:08:27 *** AaronvanW has joined #bitcoin-core-dev
3432019-06-21T15:08:32 <phantomcircuit> yeah actually not sure about that one
3442019-06-21T15:10:47 <kallewoof> I think the idea was to make it run 65535 times and then loop back and then run another 65535 times and then if it ran out of the nonce it would inccrement the extra nonce, but thats not what its doing at all.
3452019-06-21T15:16:00 *** aseem has quit IRC
3462019-06-21T15:21:57 *** aseem has joined #bitcoin-core-dev
3472019-06-21T15:23:59 *** rex4539 has joined #bitcoin-core-dev
3482019-06-21T15:34:41 *** pinheadmz has joined #bitcoin-core-dev
3492019-06-21T15:43:02 *** nyuszika7h1 has joined #bitcoin-core-dev
3502019-06-21T16:03:12 *** Zenton has quit IRC
3512019-06-21T16:06:17 *** bralyclow has joined #bitcoin-core-dev
3522019-06-21T16:11:29 *** DeanGuss has joined #bitcoin-core-dev
3532019-06-21T16:11:30 *** rafalcpp_ has joined #bitcoin-core-dev
3542019-06-21T16:12:10 *** queip has quit IRC
3552019-06-21T16:12:10 *** rafalcpp has quit IRC
3562019-06-21T16:15:14 *** aseem has quit IRC
3572019-06-21T16:16:20 *** bralyclow has quit IRC
3582019-06-21T16:17:23 *** bralyclow has joined #bitcoin-core-dev
3592019-06-21T16:17:31 *** d_t has joined #bitcoin-core-dev
3602019-06-21T16:18:14 *** queip has joined #bitcoin-core-dev
3612019-06-21T16:19:30 *** rex4539 has quit IRC
3622019-06-21T16:20:16 *** rex4539 has joined #bitcoin-core-dev
3632019-06-21T16:20:36 *** jarthur has joined #bitcoin-core-dev
3642019-06-21T16:21:43 *** bralyclow has quit IRC
3652019-06-21T16:22:27 *** kljasdfvv has quit IRC
3662019-06-21T16:23:42 *** aseem has joined #bitcoin-core-dev
3672019-06-21T16:24:04 *** rex4539 has quit IRC
3682019-06-21T16:33:55 *** brianhoffman has joined #bitcoin-core-dev
3692019-06-21T16:41:42 <phantomcircuit> kallewoof, i mean im sure it doesn't matter at least
3702019-06-21T16:42:31 <kallewoof> why not?
3712019-06-21T16:42:56 *** TheRec has quit IRC
3722019-06-21T16:45:00 <phantomcircuit> kallewoof, the inner loop is doing all of the hashing for the block again anyways
3732019-06-21T16:45:21 <phantomcircuit> so changing the extra nonce value even every loop wouldn't make it any slower
3742019-06-21T16:46:00 <kallewoof> you lose 16 bits worth of nonce space though
3752019-06-21T16:46:17 <phantomcircuit> so what
3762019-06-21T16:47:50 <phantomcircuit> that's not even a vaguely efficient loop regardless
3772019-06-21T16:47:52 <kallewoof> it doesnt matter for regtest, or other trivially mineable nets, no. i am having issues with signet though cause i have to actually re-create signatures every time you run out of nonces. having 32 bits intead of 16 would make things a lot less grumpifying.
3782019-06-21T16:48:27 <sipa> kallewoof: the code for the generate RPC is designed for simplicity, not efficiency
3792019-06-21T16:49:25 <kallewoof> sipa: yeah, just wondering if that 16 bit cap was for a reason or if it was just arbitrary
3802019-06-21T16:51:41 *** scoop has quit IRC
3812019-06-21T16:51:48 <phantomcircuit> sipa, wait wouldn't that be a hard stop at the inner loop limit instead of at the nmaxtries?
3822019-06-21T16:52:28 <phantomcircuit> actually nvm im dumb
3832019-06-21T16:53:55 <phantomcircuit> it should be a uint32_t though
3842019-06-21T16:53:56 * phantomcircuit runs
3852019-06-21T16:58:08 *** Emcy_ has quit IRC
3862019-06-21T17:01:30 <phantomcircuit> kallewoof, i cant measure a performance difference between the loop stopping at 16 vs 32 bits searched
3872019-06-21T17:01:55 <phantomcircuit> takes about 1 minute to generate 1000 blocks on a new regtest chain either way
3882019-06-21T17:02:02 <phantomcircuit> (sorry 10000)
3892019-06-21T17:02:21 <kallewoof> phantomcircuit: thats not the point. in signets case i have to actually ask every signer to resign whenever we run out of nonce space. i can use custom mining software but that seems overkill for a test network
3902019-06-21T17:03:48 <kallewoof> 65535 combos vs 4294967296 makes a big difference when you have to generate signatures and stuff. esp if you are doing multi-sig with peers all over the place.
3912019-06-21T17:04:25 <phantomcircuit> kallewoof, i don't see any reason not to make the search space 32 bits
3922019-06-21T17:04:48 <kallewoof> great! me neither. :)
3932019-06-21T17:05:00 <achow101> meshcollider: do you think #15588 is mergable? It's a pretty simple change
3942019-06-21T17:05:03 <gribble> https://github.com/bitcoin/bitcoin/issues/15588 | Log the actual wallet file version and no longer publicly expose the "version" record by achow101 · Pull Request #15588 · bitcoin/bitcoin · GitHub
3952019-06-21T17:05:17 <phantomcircuit> actually i dont see any reason for the inner loop check at all
3962019-06-21T17:07:35 <phantomcircuit> kallewoof, actually i see why, the ShutdownRequested() check in the loop
3972019-06-21T17:07:45 <phantomcircuit> only gets called once per search of the nonce space
3982019-06-21T17:07:48 <kallewoof> Yeah, that seems to be the only reason.
3992019-06-21T17:08:29 <kallewoof> And thats what I noticed when I upped it to 0xffffffff.. I couldnt actually ^C without waiting for the entire 32 bits to iterate through.
4002019-06-21T17:09:50 <phantomcircuit> on x86 it should be cheap enough to check that every inner loop
4012019-06-21T17:11:46 *** Chris_Stewart_5 has quit IRC
4022019-06-21T17:13:59 <sipa> this was before we had atomic variables
4032019-06-21T17:14:55 <phantomcircuit> sipa, yeah no criticism from me there
4042019-06-21T17:15:03 <phantomcircuit> makes perfect sense this is how you did it
4052019-06-21T17:15:24 *** timothy has quit IRC
4062019-06-21T17:19:21 *** Emcy has joined #bitcoin-core-dev
4072019-06-21T17:20:29 *** darosior has quit IRC
4082019-06-21T17:21:09 *** bralyclow has joined #bitcoin-core-dev
4092019-06-21T17:21:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4102019-06-21T17:26:15 *** DeanGuss has quit IRC
4112019-06-21T17:28:18 *** bitcoin-git has joined #bitcoin-core-dev
4122019-06-21T17:28:18 <bitcoin-git> [bitcoin] pstratem opened pull request #16262: Slightly simplify the mining loop. (master...2019-06-21-generateblocks) https://github.com/bitcoin/bitcoin/pull/16262
4132019-06-21T17:28:31 *** bitcoin-git has left #bitcoin-core-dev
4142019-06-21T17:29:02 *** PastaPasta has quit IRC
4152019-06-21T17:29:16 <phantomcircuit> i help
4162019-06-21T17:30:37 <kallewoof> i did something more complex. your solution is better.
4172019-06-21T17:32:10 *** scoop has joined #bitcoin-core-dev
4182019-06-21T17:32:20 *** scoop has quit IRC
4192019-06-21T17:34:06 *** surja795 has joined #bitcoin-core-dev
4202019-06-21T17:37:12 <promag> Can I have #16261 in HP?
4212019-06-21T17:37:14 <gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
4222019-06-21T17:37:51 <promag> achow101: FYI, if you rebase with that you'll have a couple of trivial conflicts
4232019-06-21T17:42:37 *** bitcoin-git has joined #bitcoin-core-dev
4242019-06-21T17:42:37 <bitcoin-git> [bitcoin] hebasto opened pull request #16263: qt: Use qInfo() if no error occurs (master...20190621-qInfo) https://github.com/bitcoin/bitcoin/pull/16263
4252019-06-21T17:42:39 *** bitcoin-git has left #bitcoin-core-dev
4262019-06-21T17:49:52 *** itsiku has quit IRC
4272019-06-21T17:54:41 *** bralyclow has quit IRC
4282019-06-21T17:54:53 *** TheRec has joined #bitcoin-core-dev
4292019-06-21T17:56:18 *** scoop has joined #bitcoin-core-dev
4302019-06-21T18:00:01 *** nyuszika7h1 has quit IRC
4312019-06-21T18:00:29 *** scoop has quit IRC
4322019-06-21T18:09:59 *** scoop has joined #bitcoin-core-dev
4332019-06-21T18:10:03 *** pabelanger1 has joined #bitcoin-core-dev
4342019-06-21T18:15:28 *** surja795 has quit IRC
4352019-06-21T18:16:40 *** aseem has quit IRC
4362019-06-21T18:17:21 *** aseem has joined #bitcoin-core-dev
4372019-06-21T18:18:11 *** scoop has quit IRC
4382019-06-21T18:20:26 *** scoop has joined #bitcoin-core-dev
4392019-06-21T18:20:43 *** bralyclow has joined #bitcoin-core-dev
4402019-06-21T18:20:59 *** rex4539 has joined #bitcoin-core-dev
4412019-06-21T18:22:22 *** scoop has quit IRC
4422019-06-21T18:22:38 *** scoop has joined #bitcoin-core-dev
4432019-06-21T18:26:42 *** lightlike has quit IRC
4442019-06-21T18:26:56 *** scoop has quit IRC
4452019-06-21T18:27:16 *** scoop has joined #bitcoin-core-dev
4462019-06-21T18:32:02 <sipa> if there is a wallet meeting today, i'll miss it (meeting with github)
4472019-06-21T18:40:23 *** bitcoin-git has joined #bitcoin-core-dev
4482019-06-21T18:40:23 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16264: policy: Add experimental -mempoolreplacement=full (off by default) (master...1906-policyFullRbf) https://github.com/bitcoin/bitcoin/pull/16264
4492019-06-21T18:40:27 *** bitcoin-git has left #bitcoin-core-dev
4502019-06-21T18:42:50 *** bralyclow has quit IRC
4512019-06-21T18:47:43 *** bralyclow has joined #bitcoin-core-dev
4522019-06-21T18:52:08 *** bralyclow has quit IRC
4532019-06-21T18:55:04 *** scoop has quit IRC
4542019-06-21T18:56:08 *** scoop has joined #bitcoin-core-dev
4552019-06-21T18:56:45 *** scoop has quit IRC
4562019-06-21T18:57:01 *** scoop has joined #bitcoin-core-dev
4572019-06-21T19:00:14 <achow101> wallet meeting?
4582019-06-21T19:00:21 <meshcollider> #startmeeting
4592019-06-21T19:00:21 <lightningbot> Meeting started Fri Jun 21 19:00:21 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
4602019-06-21T19:00:21 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4612019-06-21T19:00:38 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky
4622019-06-21T19:01:01 <kanzure> hi
4632019-06-21T19:01:05 <achow101> hi
4642019-06-21T19:02:13 <achow101> something I mentioned yesterday that we could discuss here: "I've been working on implementing the scriptpubkeymanager and I noticed a bunch of things related to key generation rely on the wallet version and wallet flags. Thoughts on how to handle those without introducing a circular dependency?"
4652019-06-21T19:03:02 <achow101> sipa's suggestion was to have flags and version be part of the constructors for SPKmanagers, but these things get updated during key generation and imports
4662019-06-21T19:03:40 <achow101> I tried having the spkmanager write out the updates to the wallet file, but then the parent cwallet instance wouldn't know about the flag changes. it also felt like a layer violation
4672019-06-21T19:03:45 <achow101> any thoughts on that?
4682019-06-21T19:04:23 <meshcollider> #topic scriptpubkeymanager wallet flags (achow101)
4692019-06-21T19:05:50 <kanzure> managers are assigned a key, or managers make keys?
4702019-06-21T19:06:01 <achow101> managers make keys
4712019-06-21T19:06:38 <meshcollider> Can the wallet pass a pointer on construction instead?
4722019-06-21T19:07:01 <achow101> yes, but locks..
4732019-06-21T19:07:23 <achow101> IIRC cs_wallet needs to be locked to modify flags but spkmanagers won't have access to cs_wallet
4742019-06-21T19:09:13 *** queip has quit IRC
4752019-06-21T19:09:13 *** rafalcpp has joined #bitcoin-core-dev
4762019-06-21T19:09:18 <achow101> FWIW all of the wallet flags are things that spkmanagers care about, not the wallet. so maybe it does make sense to just have the wallet's flag stuff call through to the spkmanager's?
4772019-06-21T19:09:19 <meshcollider> Hmm, pass a callback function down from the wallet then?
4782019-06-21T19:09:57 *** surja795 has joined #bitcoin-core-dev
4792019-06-21T19:10:01 *** rafalcpp_ has quit IRC
4802019-06-21T19:10:07 <instagibbs> which things/flags get updated on import, just to job my memory
4812019-06-21T19:10:23 <meshcollider> Which SPKManager would provide the flags then
4822019-06-21T19:11:14 <achow101> instagibbs: WALLET_FLAG_BLANK_WALLET changes on import and key generation. WALLET_FLAG_KEY_ORIGIN_METADATA can change on load. WALLET_FLAG_DISABLE_PRIVATE_KEYS is checked before keys are generated
4832019-06-21T19:11:45 <achow101> meshcollider: I think they would all have the same flags, so it doesn't matter. but I guess there's an update problem with that too..
4842019-06-21T19:12:08 <achow101> the only flag that SPKManagers won't use is WALLET_FLAG_AVOID_REUSE
4852019-06-21T19:12:46 *** infernix has quit IRC
4862019-06-21T19:13:12 <achow101> my initial thought was to have each spkmanager also store a pointer to it's parent cwallet, but that's circular
4872019-06-21T19:14:14 <meshcollider> I guess BLANK_ and KEY_ORIGIN_ can be per-spkmanager and the wallet can itetate over them all with OR
4882019-06-21T19:14:44 <meshcollider> Iterate*
4892019-06-21T19:15:25 <meshcollider> Whereas DISABLE_PRIV doesn't change does it
4902019-06-21T19:15:37 <achow101> it doesn't
4912019-06-21T19:15:43 *** queip has joined #bitcoin-core-dev
4922019-06-21T19:17:05 *** justan0theruser has joined #bitcoin-core-dev
4932019-06-21T19:17:06 <meshcollider> Am I right in thinking these flags only ever get set, never reset
4942019-06-21T19:17:15 <meshcollider> So you can just OR them all
4952019-06-21T19:17:18 <achow101> yeah
4962019-06-21T19:17:21 <meshcollider> bitwise
4972019-06-21T19:17:31 <achow101> so should there be a new wallet record for spkmanager flags?
4982019-06-21T19:19:13 <achow101> I don't think that approach will really work though since there won't necessarily be a way to uniquely identify spkmanagers
4992019-06-21T19:19:29 <achow101> the whole loading part is kind of an issue
5002019-06-21T19:19:48 *** justanotheruser has quit IRC
5012019-06-21T19:19:52 *** justan0theruser is now known as justanotheruser
5022019-06-21T19:21:29 <meshcollider> Just because one SPKManager changes a flag doesn't mean they all need to update their flags do they? It doesn't matter if they all get the same flags at reload?
5032019-06-21T19:21:49 *** timothy has joined #bitcoin-core-dev
5042019-06-21T19:21:51 <meshcollider> As long as whichever one updates can write it to the wallet file
5052019-06-21T19:23:34 <achow101> I think so?
5062019-06-21T19:27:25 *** bralyclow has joined #bitcoin-core-dev
5072019-06-21T19:28:33 <achow101> so i guess the conclusion is that spkmanagers will handle the storage of BLANK, KEY_ORIGIN, an DISABLE_PRIV flags and CWallet handles the storage of AVOID_REUSE
5082019-06-21T19:29:25 <meshcollider> seems sensible
5092019-06-21T19:29:33 <achow101> i can foresee some concurrency issues with this
5102019-06-21T19:30:43 <meshcollider> Hmm I don't really see why there needs to be concurrency issues if they're not being used to communicate with each other at runtime
5112019-06-21T19:32:01 <meshcollider> Are there any other topics or is this the only one? Just so we aren't holding up the meeting if we continue discussing this
5122019-06-21T19:32:43 <meshcollider> Doesn't seem like attendance is very high today so I assume this is it :)
5132019-06-21T19:33:14 <achow101> the flags between cwallet and each spkmanager can be out of sync, so the update of flags on one object can undo an update from another one
5142019-06-21T19:34:19 <meshcollider> But like I said earlier, isn't each flag only one-way
5152019-06-21T19:34:39 <achow101> e.g. cwallet has BLANK set. spkmanager unsets BLANK because a seed is set so it writes that to the file. CWallet still has BLANK set. it updates the flags because AVOID_REUSE is changed so now the old BLANK is written back to the wallet
5162019-06-21T19:35:26 <achow101> not so much concurrency than not updating objects i suppose
5172019-06-21T19:36:17 <meshcollider> CWallet wouldn't store BLANK anyway
5182019-06-21T19:36:30 <meshcollider> If it needs to know blank, it would ask the spkmanagers
5192019-06-21T19:36:37 *** astro_ has quit IRC
5202019-06-21T19:36:57 <achow101> yeah, but the wallet flags record is just a bitfield. it can't update it without updating the whole thing
5212019-06-21T19:37:00 *** astro has joined #bitcoin-core-dev
5222019-06-21T19:37:06 <achow101> so it needs to know all flags in effect
5232019-06-21T19:39:12 *** Chris_Stewart_5 has quit IRC
5242019-06-21T19:40:13 *** scoop has quit IRC
5252019-06-21T19:40:56 *** scoop has joined #bitcoin-core-dev
5262019-06-21T19:41:35 <achow101> maybe function callbacks are the best option
5272019-06-21T19:41:51 *** rex4539 has quit IRC
5282019-06-21T19:43:43 <meshcollider> It seems like it might be, or can you use the built in atomic stuff to avoid locks
5292019-06-21T19:44:08 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5302019-06-21T19:44:58 *** scoop has quit IRC
5312019-06-21T19:45:17 <achow101> i'll try it out
5322019-06-21T19:45:44 <meshcollider> Alright
5332019-06-21T19:45:57 <meshcollider> Yeah I don't see a particularly clean solution otherwise
5342019-06-21T19:46:21 <meshcollider> Ok let's end the meeting there then, too many people away today
5352019-06-21T19:46:24 <meshcollider> #endmeeting
5362019-06-21T19:46:24 <lightningbot> Meeting ended Fri Jun 21 19:46:24 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5372019-06-21T19:46:24 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.html
5382019-06-21T19:46:24 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.txt
5392019-06-21T19:46:24 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.log.html
5402019-06-21T19:46:45 <achow101> this refactor has turned out to be much harder than I thought it would be
5412019-06-21T19:46:57 <achow101> good luck reviewing it
5422019-06-21T19:49:22 *** aseem has quit IRC
5432019-06-21T19:50:42 *** jarthur_ has joined #bitcoin-core-dev
5442019-06-21T19:50:51 *** Zenton has joined #bitcoin-core-dev
5452019-06-21T19:54:01 *** aseem has joined #bitcoin-core-dev
5462019-06-21T19:54:20 *** jarthur has quit IRC
5472019-06-21T19:57:26 *** elichai2 has quit IRC
5482019-06-21T19:58:08 *** dviola has quit IRC
5492019-06-21T20:00:30 *** bralyclow has quit IRC
5502019-06-21T20:04:11 *** scoop has joined #bitcoin-core-dev
5512019-06-21T20:09:24 *** Guyver2 has quit IRC
5522019-06-21T20:13:03 *** bitcoin-git has joined #bitcoin-core-dev
5532019-06-21T20:13:03 <bitcoin-git> [bitcoin] asood123 opened pull request #16265: Update check disk space in bitcoind (master...patch-15813) https://github.com/bitcoin/bitcoin/pull/16265
5542019-06-21T20:13:07 *** bitcoin-git has left #bitcoin-core-dev
5552019-06-21T20:15:27 *** laptop500 has quit IRC
5562019-06-21T20:19:45 *** scoop has quit IRC
5572019-06-21T20:21:43 *** paracyst_ has quit IRC
5582019-06-21T20:22:57 *** dviola has joined #bitcoin-core-dev
5592019-06-21T20:28:43 *** paracyst has joined #bitcoin-core-dev
5602019-06-21T20:30:08 *** surja795 has quit IRC
5612019-06-21T20:31:01 *** scoop has joined #bitcoin-core-dev
5622019-06-21T20:34:26 *** paracyst has quit IRC
5632019-06-21T20:35:12 *** scoop has quit IRC
5642019-06-21T20:36:35 *** infernix has joined #bitcoin-core-dev
5652019-06-21T20:56:24 *** paracyst has joined #bitcoin-core-dev
5662019-06-21T20:56:51 *** jarthur_ has quit IRC
5672019-06-21T20:57:02 *** spinza has quit IRC
5682019-06-21T20:57:21 *** jarthur has joined #bitcoin-core-dev
5692019-06-21T21:00:03 *** pabelanger1 has quit IRC
5702019-06-21T21:00:58 *** surja795 has joined #bitcoin-core-dev
5712019-06-21T21:01:04 *** rafalcpp_ has joined #bitcoin-core-dev
5722019-06-21T21:02:11 *** DeanGuss has joined #bitcoin-core-dev
5732019-06-21T21:02:18 *** queip has quit IRC
5742019-06-21T21:02:18 *** rafalcpp has quit IRC
5752019-06-21T21:06:35 *** spinza has joined #bitcoin-core-dev
5762019-06-21T21:08:22 *** queip has joined #bitcoin-core-dev
5772019-06-21T21:20:49 *** k0da has joined #bitcoin-core-dev
5782019-06-21T21:21:44 *** emilengler has quit IRC
5792019-06-21T21:23:55 *** emilengler has joined #bitcoin-core-dev
5802019-06-21T21:26:56 *** Chris_Stewart_5 has quit IRC
5812019-06-21T21:27:26 *** hebasto has quit IRC
5822019-06-21T21:29:12 <gwillen> so I just ran into an issue (twice) where I broke one of the python tests in a confusing way with a typo
5832019-06-21T21:29:22 <gwillen> and ended up accidentally reusing an intermediate from a testcase in a subsequent test case without noticing it
5842019-06-21T21:29:50 <gwillen> my friend the python expert strongly recommends that the test cases should be separate functions as the best way to avoid this kind of issue, which doesn't seem crazy to me
5852019-06-21T21:29:58 <gwillen> but of course, it seems like most or all the tests are written in this style
5862019-06-21T21:30:01 <gwillen> so I'm curious what people think about that
5872019-06-21T21:32:35 <gwillen> the failure mode where one accidentally reuses an intermediate from a previous test case is EXTREMELY mystifying and hard to diagnose
5882019-06-21T21:32:37 *** aseem has quit IRC
5892019-06-21T21:33:02 <gwillen> and it's easy to induce when adding/removing or commenting or uncommenting lines, given that each testcase uses most of the same names for intermediates
5902019-06-21T21:33:28 <sipa> gwillen: my favorite *ahum* bug i ever had in python was when i had two classes with the same name, and the second just overwrote the first one, without warning
5912019-06-21T21:33:41 <gwillen> oh geez
5922019-06-21T21:33:58 <sipa> making me mystified why some obvioisly broken code in the first one wasn't causing problems
5932019-06-21T21:34:04 <gwillen> yeah.
5942019-06-21T21:34:18 <sipa> even google's internal linter at the time did not catch this
5952019-06-21T21:34:33 <gwillen> when I suspect something like that my next move is always to break something VERY blatant in the code I'm not sure is running, like make it throw on the first line
5962019-06-21T21:34:51 <sipa> yeah
5972019-06-21T21:35:01 <sipa> anyway, your suggestions sounds very reasonable
5982019-06-21T21:35:08 <sipa> but i'm not a python person myself
5992019-06-21T21:36:07 <gwillen> my friend is one of the maintainers of mypy, and one of the Python People at dropbox
6002019-06-21T21:36:20 <gwillen> so I take his suggestions on python style seriously :-)
6012019-06-21T21:36:41 <sipa> ping MarcoFalke ^
6022019-06-21T21:38:00 <gwillen> (he is also the author of "Peer-to-Peer Affine Commitment using Bitcoin", which describes the "Typecoin" system, and was almost named "Massively Multiplayer Online Linear Logic")
6032019-06-21T21:46:32 <sipa> lol
6042019-06-21T21:46:44 <sipa> mmoll
6052019-06-21T21:52:01 *** surja795 has quit IRC
6062019-06-21T21:54:44 *** surja795 has joined #bitcoin-core-dev
6072019-06-21T21:57:25 *** bralyclow has joined #bitcoin-core-dev
6082019-06-21T22:01:39 *** DeanGuss has quit IRC
6092019-06-21T22:05:29 <luke-jr> sdaftuar: ping
6102019-06-21T22:12:58 *** spinza has quit IRC
6112019-06-21T22:15:51 *** ddustin has joined #bitcoin-core-dev
6122019-06-21T22:16:46 *** ddustin has joined #bitcoin-core-dev
6132019-06-21T22:17:31 *** ddustin has joined #bitcoin-core-dev
6142019-06-21T22:21:42 *** shesek has joined #bitcoin-core-dev
6152019-06-21T22:21:42 *** shesek has joined #bitcoin-core-dev
6162019-06-21T22:23:49 *** rafalcpp has joined #bitcoin-core-dev
6172019-06-21T22:24:38 *** rafalcpp_ has quit IRC
6182019-06-21T22:24:46 *** scoop has joined #bitcoin-core-dev
6192019-06-21T22:25:54 *** queip has quit IRC
6202019-06-21T22:26:07 *** timothy has quit IRC
6212019-06-21T22:26:55 *** spinza has joined #bitcoin-core-dev
6222019-06-21T22:29:19 *** michaelsdunn1 has quit IRC
6232019-06-21T22:30:36 *** queip has joined #bitcoin-core-dev
6242019-06-21T22:30:52 *** bralyclow has quit IRC
6252019-06-21T22:43:20 *** Wasyl has joined #bitcoin-core-dev
6262019-06-21T22:47:11 *** Wasyl has quit IRC
6272019-06-21T22:57:11 *** bralyclow has joined #bitcoin-core-dev
6282019-06-21T23:04:01 *** surja795 has quit IRC
6292019-06-21T23:07:42 *** captjakk has quit IRC
6302019-06-21T23:09:20 *** jarthur has quit IRC
6312019-06-21T23:18:58 *** jtimon has joined #bitcoin-core-dev
6322019-06-21T23:19:36 *** emilengler has quit IRC
6332019-06-21T23:20:33 *** owowo has quit IRC
6342019-06-21T23:25:26 *** owowo has joined #bitcoin-core-dev
6352019-06-21T23:30:41 *** bralyclow has quit IRC
6362019-06-21T23:35:02 *** spinza has quit IRC
6372019-06-21T23:35:13 *** bralyclow has joined #bitcoin-core-dev
6382019-06-21T23:42:01 *** reallll has joined #bitcoin-core-dev
6392019-06-21T23:42:02 <jtimon> In regtest, I'm sending coins from bitcoin core to lightningd's newaddr but it doesn't seem to be receiving anything, I'm generating more blocks on the core node and calling dev_rescan_outputs on the lightning node, but still not seeing anything in listfunds and fundchannel says "Cannot afford transaction"
6402019-06-21T23:42:14 <jtimon> what may I be doing wrong?
6412019-06-21T23:43:27 <jtimon> sorry, wrong channel
6422019-06-21T23:43:31 *** spinza has joined #bitcoin-core-dev
6432019-06-21T23:43:43 *** jonatack has quit IRC
6442019-06-21T23:45:35 *** belcher has quit IRC
6452019-06-21T23:53:02 *** reallll is now known as belcher
6462019-06-21T23:57:22 *** Skirmant has joined #bitcoin-core-dev