12019-06-25T00:00:01 *** Guest53294 has quit IRC
22019-06-25T00:02:55 *** darosior has quit IRC
32019-06-25T00:04:22 *** freakofmimsy has joined #bitcoin-core-dev
42019-06-25T00:07:09 *** pinheadmz has joined #bitcoin-core-dev
52019-06-25T00:08:02 *** PastaPasta has quit IRC
62019-06-25T00:11:29 *** pinheadmz has quit IRC
72019-06-25T00:14:14 *** surja795 has joined #bitcoin-core-dev
82019-06-25T00:17:19 *** michaelfolkson has joined #bitcoin-core-dev
92019-06-25T00:21:00 *** scoop has quit IRC
102019-06-25T00:21:26 *** scoop has joined #bitcoin-core-dev
112019-06-25T00:25:28 *** scoop has quit IRC
122019-06-25T00:35:39 *** Guest45841 has quit IRC
132019-06-25T00:42:04 *** surja795 has quit IRC
142019-06-25T01:00:23 *** aseem has joined #bitcoin-core-dev
152019-06-25T01:08:45 *** ryanofsky has quit IRC
162019-06-25T01:09:24 *** morcos has quit IRC
172019-06-25T01:10:23 *** reallll has joined #bitcoin-core-dev
182019-06-25T01:10:31 *** e4xit has quit IRC
192019-06-25T01:13:49 *** belcher has quit IRC
202019-06-25T01:14:04 *** morcos has joined #bitcoin-core-dev
212019-06-25T01:23:50 *** michaelfolkson has quit IRC
222019-06-25T01:35:12 *** DeanGuss has joined #bitcoin-core-dev
232019-06-25T01:44:34 *** pinheadmz has joined #bitcoin-core-dev
242019-06-25T01:52:36 *** PastaPasta has joined #bitcoin-core-dev
252019-06-25T01:54:49 *** PastaPasta has quit IRC
262019-06-25T01:57:51 *** AaronvanW has joined #bitcoin-core-dev
272019-06-25T02:13:41 *** cubancorona has joined #bitcoin-core-dev
282019-06-25T02:15:35 <sdaftuar> luke-jr: hi -- saw you pinged me on friday?
292019-06-25T02:17:37 *** baldur has quit IRC
302019-06-25T02:20:17 *** luke-jr has quit IRC
312019-06-25T02:20:35 *** luke-jr has joined #bitcoin-core-dev
322019-06-25T02:20:41 *** aseem has quit IRC
332019-06-25T02:22:46 <aj> sdaftuar: hey, just sent an email based on having run the relay-parents code that we talked briefly about in amsterdam
342019-06-25T02:26:48 *** pinheadmz has quit IRC
352019-06-25T02:31:36 *** baldur has joined #bitcoin-core-dev
362019-06-25T02:34:57 <fanquake> sdaftuar while you're here, be good to get a quick sanity check from you in #16188.
372019-06-25T02:35:00 <gribble> https://github.com/bitcoin/bitcoin/issues/16188 | net: Document what happens to getdata of unknown type by MarcoFalke · Pull Request #16188 · bitcoin/bitcoin · GitHub
382019-06-25T02:39:14 <fanquake> sdaftuar cheers
392019-06-25T02:41:27 *** DeanGuss has quit IRC
402019-06-25T02:41:31 <sdaftuar> fanquake: thanks for the reminder
412019-06-25T02:41:56 *** DeanGuss has joined #bitcoin-core-dev
422019-06-25T02:42:30 *** MJ64 has joined #bitcoin-core-dev
432019-06-25T02:43:52 *** elichai2 has quit IRC
442019-06-25T02:44:13 <luke-jr> sdaftuar: yes, about the dbcrash test: I don't understand why after restarting the node that crashes on submitblock, it's okay to wait for the block to be the tip? What if it crashed BEFORE the block was processed? (as it seems to be when I run it)
452019-06-25T02:45:56 *** bralyclow01 has joined #bitcoin-core-dev
462019-06-25T02:48:36 *** MJ64 has quit IRC
472019-06-25T02:49:37 *** bralyclow has quit IRC
482019-06-25T02:51:25 <sdaftuar> luke-jr: that seems strange to me -- did you perhaps modify the test to run on a pruning node somehow?
492019-06-25T02:52:09 <sdaftuar> other than that, i don't see how FlushStateToDisk could be called before the new block is connected (which is where the crash happens)
502019-06-25T02:53:26 *** spinza has quit IRC
512019-06-25T02:54:31 <luke-jr> hmm
522019-06-25T02:55:48 *** AaronvanW has quit IRC
532019-06-25T02:55:48 *** arubi has quit IRC
542019-06-25T02:56:12 *** arubi has joined #bitcoin-core-dev
552019-06-25T02:58:17 <sdaftuar> oh, maybe there's a race condition somewhere else...
562019-06-25T03:00:02 *** freakofmimsy has quit IRC
572019-06-25T03:00:28 <sdaftuar> i guess ATMP calls FlushStateToDisk as well, so if the test is generating transactions and then occasionally submitting a block, there could be a race where the FSTD call in transaction acceptance triggers a crash right as submitblock is firing.
582019-06-25T03:01:14 <sdaftuar> i haven't actually looked at the test in-depth enough to know if that might be a plausible explanation though
592019-06-25T03:05:19 *** gchaix has joined #bitcoin-core-dev
602019-06-25T03:07:47 *** ddustin has joined #bitcoin-core-dev
612019-06-25T03:11:09 <sdaftuar> luke-jr: do you have a commit that the test fails on?
622019-06-25T03:13:42 *** bitcoin-git has joined #bitcoin-core-dev
632019-06-25T03:13:42 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e115a21f79c4...21bd6eb782ca
642019-06-25T03:13:43 <bitcoin-git> bitcoin/master dddd927 MarcoFalke: net: Document what happens to getdata of unknonw type
652019-06-25T03:13:43 <bitcoin-git> bitcoin/master 21bd6eb fanquake: Merge #16188: net: Document what happens to getdata of unknown type
662019-06-25T03:13:55 *** bitcoin-git has left #bitcoin-core-dev
672019-06-25T03:14:30 *** bitcoin-git has joined #bitcoin-core-dev
682019-06-25T03:14:30 <bitcoin-git> [bitcoin] stplaydog opened pull request #16281: [fix #1] Understand transaction_tests (master...transaction_tests) https://github.com/bitcoin/bitcoin/pull/16281
692019-06-25T03:14:33 *** bitcoin-git has left #bitcoin-core-dev
702019-06-25T03:14:50 *** bitcoin-git has joined #bitcoin-core-dev
712019-06-25T03:14:50 <bitcoin-git> [bitcoin] fanquake merged pull request #16188: net: Document what happens to getdata of unknown type (master...1906-netGetData) https://github.com/bitcoin/bitcoin/pull/16188
722019-06-25T03:14:53 *** bitcoin-git has left #bitcoin-core-dev
732019-06-25T03:19:15 *** bitcoin-git has joined #bitcoin-core-dev
742019-06-25T03:19:15 <bitcoin-git> [bitcoin] fanquake closed pull request #16281: [fix #1] Understand transaction_tests (master...transaction_tests) https://github.com/bitcoin/bitcoin/pull/16281
752019-06-25T03:19:19 *** bitcoin-git has left #bitcoin-core-dev
762019-06-25T03:27:58 *** surja795 has joined #bitcoin-core-dev
772019-06-25T03:29:20 *** AaronvanW has joined #bitcoin-core-dev
782019-06-25T03:30:25 *** spinza has joined #bitcoin-core-dev
792019-06-25T03:32:38 *** surja795 has quit IRC
802019-06-25T03:33:44 *** AaronvanW has quit IRC
812019-06-25T04:01:46 *** surja795 has joined #bitcoin-core-dev
822019-06-25T04:08:25 *** bralyclow01 has quit IRC
832019-06-25T04:11:02 *** surja795 has quit IRC
842019-06-25T04:18:09 *** spaced0ut has quit IRC
852019-06-25T04:19:02 *** DeanGuss has quit IRC
862019-06-25T04:19:16 *** DeanGuss has joined #bitcoin-core-dev
872019-06-25T04:40:06 *** instagibbs has quit IRC
882019-06-25T04:55:39 *** pinheadmz has joined #bitcoin-core-dev
892019-06-25T04:56:03 *** rex4539 has joined #bitcoin-core-dev
902019-06-25T04:58:27 *** instagibbs has joined #bitcoin-core-dev
912019-06-25T05:04:44 *** bralyclow has joined #bitcoin-core-dev
922019-06-25T05:10:03 *** jonatack has joined #bitcoin-core-dev
932019-06-25T05:16:17 *** bralyclow has quit IRC
942019-06-25T05:36:45 *** bralyclow has joined #bitcoin-core-dev
952019-06-25T05:41:21 *** bralyclow has quit IRC
962019-06-25T05:42:48 *** shesek has joined #bitcoin-core-dev
972019-06-25T05:42:48 *** shesek has joined #bitcoin-core-dev
982019-06-25T05:47:06 *** teardown has joined #bitcoin-core-dev
992019-06-25T05:47:10 *** teardown_ has joined #bitcoin-core-dev
1002019-06-25T05:47:38 *** teardown is now known as Guest79354
1012019-06-25T05:47:38 *** teardown_ is now known as teardown
1022019-06-25T05:59:25 *** bralyclow has joined #bitcoin-core-dev
1032019-06-25T06:00:01 *** gchaix has quit IRC
1042019-06-25T06:02:11 *** Guest79354 has quit IRC
1052019-06-25T06:20:10 *** evanpro has joined #bitcoin-core-dev
1062019-06-25T06:34:14 <kallewoof> With bech32, is MIN_STANDARD_TX_NONWITNESS_SIZE still 82 bytes?
1072019-06-25T06:34:58 <kallewoof> I am seeing failure in feature_bip68_sequence.py if I flip the default address type to bech32, cause it runs into a tx that is 62 bytes w/o witness stuff.
1082019-06-25T06:37:42 *** bitcoin-git has joined #bitcoin-core-dev
1092019-06-25T06:37:43 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21bd6eb782ca...bc948d4cfd6d
1102019-06-25T06:37:43 <bitcoin-git> bitcoin/master 30ea931 Carl Dong: depends: xtrans: Configure flags cleanup.
1112019-06-25T06:37:44 <bitcoin-git> bitcoin/master bc948d4 fanquake: Merge #16183: depends: xtrans: Configure flags cleanup.
1122019-06-25T06:37:55 *** bitcoin-git has left #bitcoin-core-dev
1132019-06-25T06:38:31 *** bitcoin-git has joined #bitcoin-core-dev
1142019-06-25T06:38:31 <bitcoin-git> [bitcoin] fanquake merged pull request #16183: depends: xtrans: Configure flags cleanup. (master...2019-06-leave-xtrans-alone-right-now) https://github.com/bitcoin/bitcoin/pull/16183
1152019-06-25T06:38:32 *** bitcoin-git has left #bitcoin-core-dev
1162019-06-25T06:42:37 *** hebasto has joined #bitcoin-core-dev
1172019-06-25T06:52:39 *** ddustin has quit IRC
1182019-06-25T06:53:00 *** ddustin has joined #bitcoin-core-dev
1192019-06-25T06:53:25 *** ddustin has quit IRC
1202019-06-25T06:53:47 *** ddustin has joined #bitcoin-core-dev
1212019-06-25T06:54:32 *** ddustin has joined #bitcoin-core-dev
1222019-06-25T06:55:19 *** ddustin has joined #bitcoin-core-dev
1232019-06-25T06:55:45 *** ddustin has quit IRC
1242019-06-25T06:56:09 *** ddustin has joined #bitcoin-core-dev
1252019-06-25T06:57:26 *** ddustin has joined #bitcoin-core-dev
1262019-06-25T07:00:52 *** Guyver2 has joined #bitcoin-core-dev
1272019-06-25T07:07:44 *** ddustin has quit IRC
1282019-06-25T07:15:25 *** AaronvanW has joined #bitcoin-core-dev
1292019-06-25T07:20:01 *** AaronvanW has quit IRC
1302019-06-25T07:22:14 *** hebasto has quit IRC
1312019-06-25T07:31:23 *** reallll is now known as belcher
1322019-06-25T07:40:34 *** aseem has joined #bitcoin-core-dev
1332019-06-25T07:41:20 *** AaronvanW has joined #bitcoin-core-dev
1342019-06-25T07:47:38 *** ctrlbreak has quit IRC
1352019-06-25T07:58:49 *** laptop500 has joined #bitcoin-core-dev
1362019-06-25T08:00:52 *** jonatack has quit IRC
1372019-06-25T08:07:47 *** omonk has quit IRC
1382019-06-25T08:12:40 *** omonk has joined #bitcoin-core-dev
1392019-06-25T08:13:52 *** darosior has joined #bitcoin-core-dev
1402019-06-25T08:14:34 *** aseem has quit IRC
1412019-06-25T08:14:59 *** setpill has joined #bitcoin-core-dev
1422019-06-25T08:16:00 <jonasschnelli> Hmm... compiling depends W64 (minGW64) on Ubuntu 18.04 fails... can't figure out why
1432019-06-25T08:16:33 <jonasschnelli> error: âmutexâ is not a member of âstdâ <---- looks like its not compiling with c++11, I tried even to force it with "CXXFLAGS="-std=gnu++11"" ... no success
1442019-06-25T08:16:36 <jonasschnelli> Probably missing a package?
1452019-06-25T08:20:50 <jonasschnelli> selecting the posix version through sudo update-alternatives --config x86_64-w64-mingw32-g++ fixed it
1462019-06-25T08:33:47 *** AaronvanW has quit IRC
1472019-06-25T08:36:25 <gertjaap> is there anything i should do if the DrahtBot reports a conflicting PR? Or just leave it for reviewers.
1482019-06-25T08:37:11 <fanquake> jonasschnelli just need to read the docs :p
1492019-06-25T08:37:18 <jonasschnelli> indeed... :)
1502019-06-25T08:37:35 <jonasschnelli> gertjaap: just informal,... no need to fix
1512019-06-25T08:37:38 <fanquake> gertjaap I wouldn't worry to much
1522019-06-25T08:37:54 <gertjaap> ok, cool
1532019-06-25T08:38:11 <fanquake> The conflicting PR could be quite possibly be 6 months old, need rebasing itself etc etc.
1542019-06-25T08:50:31 *** timothy has joined #bitcoin-core-dev
1552019-06-25T08:57:47 <meshcollider> I feel like the conflicting info is more useful for maintainers to decide what order to merge stuff in than it is for anyone else
1562019-06-25T09:00:02 *** evanpro has quit IRC
1572019-06-25T09:05:17 *** rex4539 has quit IRC
1582019-06-25T09:14:46 *** harrigan has joined #bitcoin-core-dev
1592019-06-25T09:28:10 *** AaronvanW has joined #bitcoin-core-dev
1602019-06-25T09:29:35 *** promag_ has joined #bitcoin-core-dev
1612019-06-25T09:36:27 *** omonk has quit IRC
1622019-06-25T09:37:40 *** AaronvanW has quit IRC
1632019-06-25T09:39:30 *** omonk has joined #bitcoin-core-dev
1642019-06-25T09:40:59 *** pinheadmz has quit IRC
1652019-06-25T09:42:06 *** peterpomade has joined #bitcoin-core-dev
1662019-06-25T09:43:44 *** pinheadmz has joined #bitcoin-core-dev
1672019-06-25T09:45:23 *** bitcoin-git has joined #bitcoin-core-dev
1682019-06-25T09:45:24 <bitcoin-git> [bitcoin] fanquake closed pull request #15572: Add auto select custom fee when smart fee not initialized. (master...dev) https://github.com/bitcoin/bitcoin/pull/15572
1692019-06-25T09:45:24 *** bitcoin-git has left #bitcoin-core-dev
1702019-06-25T09:50:00 *** AaronvanW has joined #bitcoin-core-dev
1712019-06-25T09:52:16 *** AaronvanW has quit IRC
1722019-06-25T09:53:59 *** michaelfolkson has joined #bitcoin-core-dev
1732019-06-25T09:55:20 *** promag_ has quit IRC
1742019-06-25T09:58:28 *** promag_ has joined #bitcoin-core-dev
1752019-06-25T10:00:21 *** promag_ has quit IRC
1762019-06-25T10:03:14 *** EagleTM has quit IRC
1772019-06-25T10:06:03 *** promag_ has joined #bitcoin-core-dev
1782019-06-25T10:07:34 <fanquake> wumpus Would you like to take a look at #15894 ?
1792019-06-25T10:07:37 <gribble> https://github.com/bitcoin/bitcoin/issues/15894 | Remove duplicated "Error: " prefix in logs by hebasto · Pull Request #15894 · bitcoin/bitcoin · GitHub
1802019-06-25T10:08:09 *** ctrlbreak has joined #bitcoin-core-dev
1812019-06-25T10:11:01 *** Guyver2 has quit IRC
1822019-06-25T10:11:03 *** promag_ has quit IRC
1832019-06-25T10:14:28 *** promag_ has joined #bitcoin-core-dev
1842019-06-25T10:15:09 *** bitcoin-git has joined #bitcoin-core-dev
1852019-06-25T10:15:09 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc948d4cfd6d...c52776e6ff4d
1862019-06-25T10:15:10 <bitcoin-git> bitcoin/master fad3d2a MarcoFalke: test: Create data dir in BasicTestingSetup
1872019-06-25T10:15:10 <bitcoin-git> bitcoin/master fa4a04a MarcoFalke: test: use common setup in gui tests
1882019-06-25T10:15:11 <bitcoin-git> bitcoin/master fabc57e MarcoFalke: test: Log to debug.log in all tests
1892019-06-25T10:15:12 *** bitcoin-git has left #bitcoin-core-dev
1902019-06-25T10:16:04 *** bitcoin-git has joined #bitcoin-core-dev
1912019-06-25T10:16:04 <bitcoin-git> [bitcoin] laanwj merged pull request #16252: test: Log to debug.log in all unit tests (master...1905-bufferLog) https://github.com/bitcoin/bitcoin/pull/16252
1922019-06-25T10:16:08 *** bitcoin-git has left #bitcoin-core-dev
1932019-06-25T10:17:36 *** promag_ has quit IRC
1942019-06-25T10:21:46 *** bitcoin-git has joined #bitcoin-core-dev
1952019-06-25T10:21:46 <bitcoin-git> [bitcoin] fanquake reopened pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
1962019-06-25T10:21:47 *** bitcoin-git has left #bitcoin-core-dev
1972019-06-25T10:26:35 *** harrigan has quit IRC
1982019-06-25T10:28:10 *** promag_ has joined #bitcoin-core-dev
1992019-06-25T10:28:34 *** spinza has quit IRC
2002019-06-25T10:32:21 *** promag_ has quit IRC
2012019-06-25T10:32:58 *** promag_ has joined #bitcoin-core-dev
2022019-06-25T10:33:37 *** DeanGuss has quit IRC
2032019-06-25T10:34:07 *** DeanGuss has joined #bitcoin-core-dev
2042019-06-25T10:34:09 *** spinza has joined #bitcoin-core-dev
2052019-06-25T10:38:00 *** promag_ has quit IRC
2062019-06-25T10:38:35 *** e4xit has joined #bitcoin-core-dev
2072019-06-25T10:39:50 *** spinza has quit IRC
2082019-06-25T10:45:40 *** laptop500 has quit IRC
2092019-06-25T10:49:00 *** harrigan has joined #bitcoin-core-dev
2102019-06-25T10:53:35 *** michaelfolkson has quit IRC
2112019-06-25T10:54:48 *** michaelfolkson has joined #bitcoin-core-dev
2122019-06-25T11:00:49 *** spinza has joined #bitcoin-core-dev
2132019-06-25T11:02:50 <wumpus> fanquake: sure
2142019-06-25T11:07:35 *** michaelfolkson has quit IRC
2152019-06-25T11:08:11 *** michaelfolkson has joined #bitcoin-core-dev
2162019-06-25T11:12:55 *** EagleTM has joined #bitcoin-core-dev
2172019-06-25T11:14:26 *** laptop500 has joined #bitcoin-core-dev
2182019-06-25T11:16:06 *** TheHoliestRoger has quit IRC
2192019-06-25T11:16:51 *** TheHoliestRoger has joined #bitcoin-core-dev
2202019-06-25T11:21:13 *** Skirmant has quit IRC
2212019-06-25T11:21:46 *** michaelfolkson has quit IRC
2222019-06-25T11:26:25 *** michaelfolkson has joined #bitcoin-core-dev
2232019-06-25T11:27:55 *** AaronvanW has joined #bitcoin-core-dev
2242019-06-25T11:28:07 *** michaelfolkson has quit IRC
2252019-06-25T11:29:03 *** michaelfolkson has joined #bitcoin-core-dev
2262019-06-25T11:31:44 *** rafalcpp has joined #bitcoin-core-dev
2272019-06-25T11:33:24 *** bitcoin-git has joined #bitcoin-core-dev
2282019-06-25T11:33:25 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c52776e6ff4d...332c6134bb15
2292019-06-25T11:33:25 <bitcoin-git> bitcoin/master f0641f2 Hennadii Stepanov: Prepend the error/warning prefix for GUI messages
2302019-06-25T11:33:26 <bitcoin-git> bitcoin/master 96fd4ee Hennadii Stepanov: Add MSG_NOPREFIX flag for user messages
2312019-06-25T11:33:27 <bitcoin-git> bitcoin/master f724f31 Hennadii Stepanov: Make AbortNode() aware of MSG_NOPREFIX flag
2322019-06-25T11:33:30 <fanquake> wumpus thanks
2332019-06-25T11:33:38 *** bitcoin-git has left #bitcoin-core-dev
2342019-06-25T11:34:09 *** bitcoin-git has joined #bitcoin-core-dev
2352019-06-25T11:34:09 <bitcoin-git> [bitcoin] laanwj merged pull request #15894: Remove duplicated "Error: " prefix in logs (master...20190425-duplicated-error-prefix) https://github.com/bitcoin/bitcoin/pull/15894
2362019-06-25T11:34:22 *** bitcoin-git has left #bitcoin-core-dev
2372019-06-25T11:36:59 *** darosior has quit IRC
2382019-06-25T11:37:30 *** queip has joined #bitcoin-core-dev
2392019-06-25T11:40:25 *** promag_ has joined #bitcoin-core-dev
2402019-06-25T11:51:47 *** promag_ has quit IRC
2412019-06-25T11:57:13 *** michaelfolkson has quit IRC
2422019-06-25T11:57:44 <fanquake> wumpus I was going to ACK #16278 (no longer because it doesn't seem to compile..). Basically because it's tests only, Marco seems ok with it and it doesn't conflict with anything else that is merge ready. However, for the rest of the the 0.19.0 cycle, I feel like we're at the point where we can just start rejecting those kinds of PRs.
2432019-06-25T11:57:46 <gribble> https://github.com/bitcoin/bitcoin/issues/16278 | tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests by practicalswift · Pull Request #16278 · bitcoin/bitcoin · GitHub
2442019-06-25T11:57:58 <fanquake> I know you'd be happy to just close them all the time.
2452019-06-25T12:00:02 *** peterpomade has quit IRC
2462019-06-25T12:00:36 *** harrigan has quit IRC
2472019-06-25T12:00:58 <fanquake> hebasto (are you on IRC, different nick?) also asked how to test these kinds of PRs. I was just going to say using whichever methods wastes the least developer time. It's sort of annoying that a lot of these changes are seemingly hand-rolled, and the PR's don't actually contain any information about how they were done, or point to ways that this can just be automated away and forgotten about in future.
2482019-06-25T12:02:27 *** michaelfolkson has joined #bitcoin-core-dev
2492019-06-25T12:03:28 <fanquake> It's also a bit crazy that the 0.19 branch off is only 3 months away. #15940.
2502019-06-25T12:03:30 <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
2512019-06-25T12:07:57 *** harrigan has joined #bitcoin-core-dev
2522019-06-25T12:10:59 *** porygon2 has joined #bitcoin-core-dev
2532019-06-25T12:14:01 *** laptop500 has quit IRC
2542019-06-25T12:22:31 *** ryanofsky has joined #bitcoin-core-dev
2552019-06-25T12:24:59 <wumpus> fanquake: whoa yes that branch-off is pretty soon, thanks for the reminder :)
2562019-06-25T12:27:48 <wumpus> fanquake: I don't necessarily want to close them, but yes, messing around with includes just has the lowest priority for me
2572019-06-25T12:28:29 <fanquake> yes
2582019-06-25T12:28:43 *** elichai2 has joined #bitcoin-core-dev
2592019-06-25T12:29:19 <wumpus> although it's nice they benchmarked it and it increased the build speed, it's not really a metric we generally optimized for, but still
2602019-06-25T12:30:03 <fanquake> Sure. Although a bit concerning that they might push a change like that and it not even compile.
2612019-06-25T12:30:11 *** aseem has joined #bitcoin-core-dev
2622019-06-25T12:30:31 *** michaelfolkson has quit IRC
2632019-06-25T12:33:06 <wumpus> fanquake: silent merge conflict I guess?
2642019-06-25T12:34:12 <fanquake> wumpus yea I'd assume so. Looks like it happened right after rebasing.
2652019-06-25T12:35:18 <wumpus> (tbh I'm not sure 2% compile speed improvement warrants that much work; most complaints with regard to compile are about compile-time memory usage, not sure how that is affected)
2662019-06-25T12:36:46 <fanquake> I think there is another PR open, or possibly got closed that reduced compile time memory by 1% or so by removing a bunch of includes
2672019-06-25T12:38:11 <fanquake> Yea #16238. Which was a follow up to #16129 which supposedly reduced compile time memory use by 2%.
2682019-06-25T12:38:14 <gribble> https://github.com/bitcoin/bitcoin/issues/16238 | build: Remove unused C++ standard library includes by practicalswift · Pull Request #16238 · bitcoin/bitcoin · GitHub
2692019-06-25T12:38:15 <gribble> https://github.com/bitcoin/bitcoin/issues/16129 | refactor: Remove unused includes by practicalswift · Pull Request #16129 · bitcoin/bitcoin · GitHub
2702019-06-25T12:39:14 <fanquake> tbh I'm not sure why the later wasn't part of the former.
2712019-06-25T12:43:48 *** DeanGuss has quit IRC
2722019-06-25T12:44:12 *** michaelfolkson has joined #bitcoin-core-dev
2732019-06-25T12:50:07 *** aseem has quit IRC
2742019-06-25T12:51:54 <jonasschnelli> wumpus: thanks for clearing up the mystery of openSSH's BE/LE code
2752019-06-25T12:52:57 <jonasschnelli> I think one conversion to host endianness needs to be kept:
2762019-06-25T12:52:58 <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/15649/commits/5aad287ef3b2c410385d6e9a898fb70526c5bd98#diff-d64c806cc86b6f80f4cf5b777238b493R126
2772019-06-25T12:53:19 <jonasschnelli> Since we are reading the stream (which is always LE) and give back an int
2782019-06-25T12:58:34 <wumpus> jonasschnelli: I'm not sure, it seems this could be done without ever relying on host endianness like openssh does
2792019-06-25T12:59:05 <wumpus> read the stream to integer with specified endian and write the integers with specified endian
2802019-06-25T13:00:29 <jonasschnelli> wumpus: hmm...
2812019-06-25T13:00:32 <wumpus> of course the integers will be in host endianness but you'd never rely on that fact in the code and use shifts and bitwise ANDs/ORs
2822019-06-25T13:00:33 <jonasschnelli> I guess we are doing that...
2832019-06-25T13:00:33 <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/15649/files#diff-d64c806cc86b6f80f4cf5b777238b493R121
2842019-06-25T13:00:50 <jonasschnelli> the byte shifts are BE/LE safe AFAIK
2852019-06-25T13:01:06 <jonasschnelli> so that one *len24_out = le32toh(*len24_out); is not necessary?
2862019-06-25T13:01:15 <wumpus> not as long as you're using the htole64
2872019-06-25T13:02:23 <wumpus> so basically you never want to cast bytes to integers and vice versa, so you don't need Xtoh or htoX
2882019-06-25T13:03:27 <wumpus> access bytes as bytes and integers as integers and use endian-explicit poke/peek functions where needed to convert between them
2892019-06-25T13:04:12 *** michaelfolkson has quit IRC
2902019-06-25T13:06:12 <jonasschnelli> wumpus: and we are using htole64 since this is network protocol serialisation... so you agree it's safe to remove that le32toh?
2912019-06-25T13:06:22 *** michaelfolkson has joined #bitcoin-core-dev
2922019-06-25T13:07:22 <wumpus> I'll have to review the code to be sure, but I think it's unnecessary, unless you're type-punning somethere
2932019-06-25T13:07:48 <wumpus> in which case that's what you'd want to avoid instead
2942019-06-25T13:08:50 <jonasschnelli> That part is not in the AEAD pull,... since nothing is really creating encrypted streams from internal structures (the testvectors are given)
2952019-06-25T13:09:21 <wumpus> jonasschnelli:yes, the " *len24_out = le32toh(*len24_out);" should be unnecessary
2962019-06-25T13:09:22 <jonasschnelli> So the AEAD PR tests against test vectors where the integer (there is only one for the AAD len) is encoded LE
2972019-06-25T13:09:56 <wumpus> "// encode to host endianness 32bit integer", it's an integer: it's always host endianness in memory, but you don't need to care, treat it as an abstract integer
2982019-06-25T13:10:48 <wumpus> only when you convert the integer from/to bytes, endian starts to be something you need to be concerned about
2992019-06-25T13:11:03 <jonasschnelli> Yes. Thanks for clearing that up...
3002019-06-25T13:11:19 <jonasschnelli> The current code that writes the 3 byte length field is...:
3012019-06-25T13:11:21 <jonasschnelli> CVectorWriter vector_writer(SER_NETWORK, INIT_PROTO_VERSION, serialized_envelope, 0, int24[0], int24[1], int24[2]);
3022019-06-25T13:14:21 <wumpus> right, would change that to ((int24>>16)&0xff), ((int24>>8)&0xff), (int24&0xff) (assuming you want it BE) instead of type-punning the int
3032019-06-25T13:14:39 <wumpus> (other way around if you want LE)
3042019-06-25T13:16:54 <jonasschnelli> if we would use a standard int32 for the size (instead of 3 bytes) we could just pass the int into CVectorWriter since it uses ser_writedata32 under the hood, right?
3052019-06-25T13:17:15 <wumpus> yes
3062019-06-25T13:17:26 <jonasschnelli> But since there is no ser_writedata24 (obviously), we need to use our own punning
3072019-06-25T13:19:07 <wumpus> you have to handle your own serialization / deserialization for the byte stream from/to an integer, yes
3082019-06-25T13:32:39 *** EagleTM has quit IRC
3092019-06-25T13:35:05 <wumpus> but not with type punning (which is explicitly defined as casting one type of pointer to another and suspicable to various kinds of UB and IBD), rather, use explicit shifts and logical operations to extract/concatentate the bytes
3102019-06-25T13:37:45 *** EagleTM has joined #bitcoin-core-dev
3112019-06-25T13:37:56 *** arubi has quit IRC
3122019-06-25T13:38:30 *** arubi has joined #bitcoin-core-dev
3132019-06-25T13:41:54 *** bralyclow has quit IRC
3142019-06-25T13:42:21 *** bralyclow has joined #bitcoin-core-dev
3152019-06-25T13:50:31 *** d_t has joined #bitcoin-core-dev
3162019-06-25T13:53:49 *** bralyclow01 has joined #bitcoin-core-dev
3172019-06-25T13:55:45 *** d_t has quit IRC
3182019-06-25T13:56:40 *** bralyclow has quit IRC
3192019-06-25T14:08:26 *** pinheadmz has quit IRC
3202019-06-25T14:11:25 *** spaced0ut has joined #bitcoin-core-dev
3212019-06-25T14:16:33 *** rafalcpp_ has joined #bitcoin-core-dev
3222019-06-25T14:17:07 *** rafalcpp has quit IRC
3232019-06-25T14:17:08 *** queip has quit IRC
3242019-06-25T14:18:07 *** bralyclow01 has quit IRC
3252019-06-25T14:18:25 *** aseem has joined #bitcoin-core-dev
3262019-06-25T14:18:51 *** hebasto has joined #bitcoin-core-dev
3272019-06-25T14:21:05 *** bralyclow has joined #bitcoin-core-dev
3282019-06-25T14:21:29 *** michaelfolkson has quit IRC
3292019-06-25T14:23:03 *** scoop has joined #bitcoin-core-dev
3302019-06-25T14:23:12 *** queip has joined #bitcoin-core-dev
3312019-06-25T14:23:16 *** bralyclow01 has joined #bitcoin-core-dev
3322019-06-25T14:23:21 *** michaelfolkson has joined #bitcoin-core-dev
3332019-06-25T14:26:38 *** bralyclow has quit IRC
3342019-06-25T14:28:15 *** michaelsdunn1 has joined #bitcoin-core-dev
3352019-06-25T14:28:15 *** michaelsdunn1 has quit IRC
3362019-06-25T14:28:15 *** michaelsdunn1 has joined #bitcoin-core-dev
3372019-06-25T14:29:23 *** aseem has quit IRC
3382019-06-25T14:40:43 *** aseem has joined #bitcoin-core-dev
3392019-06-25T14:51:36 *** darosior has joined #bitcoin-core-dev
3402019-06-25T14:53:32 *** Soligor has quit IRC
3412019-06-25T14:56:25 *** AaronvanW has quit IRC
3422019-06-25T15:00:01 *** porygon2 has quit IRC
3432019-06-25T15:01:29 *** Soligor has joined #bitcoin-core-dev
3442019-06-25T15:04:35 *** Inigo_Montoya has joined #bitcoin-core-dev
3452019-06-25T15:11:12 *** aseem has quit IRC
3462019-06-25T15:11:52 *** aseem has joined #bitcoin-core-dev
3472019-06-25T15:17:10 *** darosior has quit IRC
3482019-06-25T15:20:04 *** rh0nj has quit IRC
3492019-06-25T15:21:07 *** rh0nj has joined #bitcoin-core-dev
3502019-06-25T15:24:12 *** aseem has quit IRC
3512019-06-25T15:28:33 *** bralyclow01 has quit IRC
3522019-06-25T15:49:57 *** aseem has joined #bitcoin-core-dev
3532019-06-25T15:51:10 *** bralyclow has joined #bitcoin-core-dev
3542019-06-25T15:55:50 *** aseem has quit IRC
3552019-06-25T16:00:38 *** michaelfolkson has quit IRC
3562019-06-25T16:02:57 *** davec has quit IRC
3572019-06-25T16:05:08 *** davec has joined #bitcoin-core-dev
3582019-06-25T16:06:08 *** pinheadmz has joined #bitcoin-core-dev
3592019-06-25T16:08:07 *** pinheadmz has joined #bitcoin-core-dev
3602019-06-25T16:09:14 *** shesek has quit IRC
3612019-06-25T16:11:24 *** StopAndDecrypt has joined #bitcoin-core-dev
3622019-06-25T16:12:08 *** Emcy has quit IRC
3632019-06-25T16:17:51 *** Emcy has joined #bitcoin-core-dev
3642019-06-25T16:18:49 *** pinheadmz has joined #bitcoin-core-dev
3652019-06-25T16:19:14 *** bitcoin-git has joined #bitcoin-core-dev
3662019-06-25T16:19:14 <bitcoin-git> [bitcoin] promag opened pull request #16285: rpc: Improve scantxoutset response and help message (master...2019-06-scantxoutset-nits) https://github.com/bitcoin/bitcoin/pull/16285
3672019-06-25T16:19:15 *** bitcoin-git has left #bitcoin-core-dev
3682019-06-25T16:25:31 *** jarthur has joined #bitcoin-core-dev
3692019-06-25T16:26:05 *** pinheadmz has quit IRC
3702019-06-25T16:32:28 *** pinheadmz has joined #bitcoin-core-dev
3712019-06-25T16:36:08 *** pinheadmz has quit IRC
3722019-06-25T16:42:31 *** michaelfolkson has joined #bitcoin-core-dev
3732019-06-25T16:43:26 *** davec has quit IRC
3742019-06-25T16:44:37 *** davec has joined #bitcoin-core-dev
3752019-06-25T16:47:46 <wumpus> its funny that no one can answer my question in #16183
3762019-06-25T16:47:48 <gribble> https://github.com/bitcoin/bitcoin/issues/16183 | depends: xtrans: Configure flags cleanup. by dongcarl · Pull Request #16183 · bitcoin/bitcoin · GitHub
3772019-06-25T16:49:54 <gwillen> wumpus: it appears to be a library somehow involved in talking to the X windows server?
3782019-06-25T16:50:39 <dongcarl> wumpus: X11 needs it at build time
3792019-06-25T16:50:54 <gwillen> it looks like qt depends on xcb which might depend on xtrans
3802019-06-25T16:51:11 <gwillen> so it's a fairly deep dependency which is why nobody remembers what it does ;-)
3812019-06-25T16:51:35 <dongcarl> libX11*
3822019-06-25T17:00:36 *** scoop has quit IRC
3832019-06-25T17:05:33 *** setpill has quit IRC
3842019-06-25T17:11:05 *** aseem has joined #bitcoin-core-dev
3852019-06-25T17:12:09 *** kristapsk has joined #bitcoin-core-dev
3862019-06-25T17:15:41 *** harrigan has quit IRC
3872019-06-25T17:16:08 *** michaelfolkson has quit IRC
3882019-06-25T17:16:33 *** scoop has joined #bitcoin-core-dev
3892019-06-25T17:18:46 *** michaelfolkson has joined #bitcoin-core-dev
3902019-06-25T17:23:11 *** bitcoin-git has joined #bitcoin-core-dev
3912019-06-25T17:23:11 <bitcoin-git> [bitcoin] hebasto opened pull request #16286: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
3922019-06-25T17:23:12 *** bitcoin-git has left #bitcoin-core-dev
3932019-06-25T17:42:56 *** timothy has quit IRC
3942019-06-25T17:51:13 <wumpus> gwillen dongcarl: okay, thanks, makes sense, the thing that made me confused is that if it's not even a library, how do we depend on it?
3952019-06-25T17:51:49 <wumpus> I guess I'd still rather depend on some obscure X dep than... expat
3962019-06-25T17:51:52 <gwillen> .... that's a good question
3972019-06-25T17:56:02 *** usahgagahb has joined #bitcoin-core-dev
3982019-06-25T18:00:02 *** Inigo_Montoya has quit IRC
3992019-06-25T18:00:21 *** scoop has quit IRC
4002019-06-25T18:00:50 *** scoop has joined #bitcoin-core-dev
4012019-06-25T18:18:07 *** pinheadmz has joined #bitcoin-core-dev
4022019-06-25T18:21:12 *** edit_21 has joined #bitcoin-core-dev
4032019-06-25T18:25:31 *** scoop_ has joined #bitcoin-core-dev
4042019-06-25T18:25:31 *** scoop has quit IRC
4052019-06-25T18:29:51 *** harrigan has joined #bitcoin-core-dev
4062019-06-25T18:30:44 *** dviola has joined #bitcoin-core-dev
4072019-06-25T18:32:03 *** pinheadmz has joined #bitcoin-core-dev
4082019-06-25T18:33:58 *** pinheadmz has quit IRC
4092019-06-25T18:46:56 *** omonk has quit IRC
4102019-06-25T18:50:14 *** michaelfolkson has quit IRC
4112019-06-25T18:50:27 *** owowo has quit IRC
4122019-06-25T18:53:15 *** omonk has joined #bitcoin-core-dev
4132019-06-25T18:56:16 *** d_t has joined #bitcoin-core-dev
4142019-06-25T18:56:26 *** owowo has joined #bitcoin-core-dev
4152019-06-25T18:58:10 *** scoop_ has quit IRC
4162019-06-25T19:01:13 *** lightlike has joined #bitcoin-core-dev
4172019-06-25T19:08:21 *** rafalcpp has joined #bitcoin-core-dev
4182019-06-25T19:08:29 *** queip has quit IRC
4192019-06-25T19:09:13 *** rafalcpp_ has quit IRC
4202019-06-25T19:11:08 *** bitcoin-git has joined #bitcoin-core-dev
4212019-06-25T19:11:08 <bitcoin-git> [bitcoin] rrybarczyk opened pull request #16287: Remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287
4222019-06-25T19:11:21 *** bitcoin-git has left #bitcoin-core-dev
4232019-06-25T19:15:12 *** queip has joined #bitcoin-core-dev
4242019-06-25T19:15:46 *** bralyclow01 has joined #bitcoin-core-dev
4252019-06-25T19:18:00 *** usahgagahb has quit IRC
4262019-06-25T19:18:38 *** bralyclow has quit IRC
4272019-06-25T19:26:08 *** aseem has quit IRC
4282019-06-25T19:41:46 *** aseem has joined #bitcoin-core-dev
4292019-06-25T20:02:00 *** harrigan has quit IRC
4302019-06-25T20:03:41 *** pinheadmz has joined #bitcoin-core-dev
4312019-06-25T20:04:49 *** pinheadmz has quit IRC
4322019-06-25T20:10:15 <hebasto> Hi! Could someone point me to the adopted practice or discussion about translation of the "Bitcoin Core" brand name to other languages?
4332019-06-25T20:14:09 *** aseem has quit IRC
4342019-06-25T20:34:18 *** harrigan has joined #bitcoin-core-dev
4352019-06-25T20:36:20 *** harrigan has quit IRC
4362019-06-25T20:37:07 *** aseem has joined #bitcoin-core-dev
4372019-06-25T20:48:50 *** spaced0ut has quit IRC
4382019-06-25T21:00:01 *** edit_21 has quit IRC
4392019-06-25T21:00:21 *** morcos has quit IRC
4402019-06-25T21:01:03 *** morcos has joined #bitcoin-core-dev
4412019-06-25T21:04:10 *** lightlike has quit IRC
4422019-06-25T21:04:22 *** lightlike has joined #bitcoin-core-dev
4432019-06-25T21:04:45 *** Snowstormer has joined #bitcoin-core-dev
4442019-06-25T21:08:45 *** hebasto has quit IRC
4452019-06-25T21:11:57 *** tryphe_ has joined #bitcoin-core-dev
4462019-06-25T21:12:36 *** tryphe has quit IRC
4472019-06-25T21:18:17 *** IGHOR has joined #bitcoin-core-dev
4482019-06-25T21:19:00 *** arubi has quit IRC
4492019-06-25T21:23:57 *** arubi has joined #bitcoin-core-dev
4502019-06-25T21:25:52 *** Zenton has quit IRC
4512019-06-25T21:26:14 *** aseem has quit IRC
4522019-06-25T21:30:17 *** Zenton has joined #bitcoin-core-dev
4532019-06-25T21:46:09 <ossifrage> Some how I lost 7342 blocks in an out of space shutdown
4542019-06-25T21:48:27 *** hrofu has joined #bitcoin-core-dev
4552019-06-25T21:48:29 <ossifrage> The node had been down since jan, it synced up to the tip and then many hours later it ran out of disk.
4562019-06-25T21:49:21 <ossifrage> When I restarted the node the tip went from 582102 back to 574747
4572019-06-25T21:50:02 *** rockhouse has quit IRC
4582019-06-25T21:50:13 *** rabidus has quit IRC
4592019-06-25T21:50:14 *** Lauda has quit IRC
4602019-06-25T21:50:52 *** rockhouse has joined #bitcoin-core-dev
4612019-06-25T21:50:52 *** hrofu_ has quit IRC
4622019-06-25T21:51:29 *** Lauda has joined #bitcoin-core-dev
4632019-06-25T21:51:29 *** Lauda has joined #bitcoin-core-dev
4642019-06-25T21:52:07 <ossifrage> 574747 was the first UpdateTip line from the previous run of bitcoin-qt, this seems like an excessive amount of state to loose
4652019-06-25T21:52:15 *** rabidus has joined #bitcoin-core-dev
4662019-06-25T21:56:32 *** Jason has joined #bitcoin-core-dev
4672019-06-25T21:57:06 *** Jason is now known as Guest81088
4682019-06-25T22:00:08 *** aseem has joined #bitcoin-core-dev
4692019-06-25T22:12:56 *** pinheadmz has joined #bitcoin-core-dev
4702019-06-25T22:20:50 *** pinheadmz has quit IRC
4712019-06-25T22:21:20 *** spinza has quit IRC
4722019-06-25T22:24:39 *** aseem has quit IRC
4732019-06-25T22:28:51 *** ubba has joined #bitcoin-core-dev
4742019-06-25T22:31:02 *** aseem has joined #bitcoin-core-dev
4752019-06-25T22:32:02 *** jarthur has quit IRC
4762019-06-25T22:32:43 <achow101> is it project policy that all commits must compile and pass all tests?
4772019-06-25T22:35:23 *** ubba has quit IRC
4782019-06-25T22:36:27 <gwillen> achow101: I think it's like, polite at least?
4792019-06-25T22:36:38 <gwillen> I've not heard of it being enforced, I do not believe Travis checks anything but the tip
4802019-06-25T22:37:01 <gwillen> but I always try to preserve it, bisection is more annoying if you don't
4812019-06-25T22:37:27 <achow101> gwillen: my situation is either make people review a commit that's something like +/- 5000 LOC but compiles and passes tests, or break that up but none of those commits will pass tests (they should compile though)
4822019-06-25T22:37:53 <achow101> for my own sanity, I'm making the separate commits, but I can squash them all together if people want commits that pass tests
4832019-06-25T22:38:39 <gwillen> you could just disable the broken tests in the intermediate commits
4842019-06-25T22:38:48 <gwillen> I don't know if that's actually a good idea but it fixes the bisection issue
4852019-06-25T22:40:15 <achow101> .. there's a lot of broken tests. basically anything that involves the wallet
4862019-06-25T22:40:32 <achow101> which is almost all of them
4872019-06-25T22:44:04 <gwillen> *nods*
4882019-06-25T22:49:48 *** spinza has joined #bitcoin-core-dev
4892019-06-25T22:53:23 *** promag_ has joined #bitcoin-core-dev
4902019-06-25T22:54:30 *** michaelsdunn1 has quit IRC
4912019-06-25T22:57:37 *** promag_ has quit IRC
4922019-06-25T22:58:41 *** pinheadmz has joined #bitcoin-core-dev
4932019-06-25T23:01:34 *** itsiku has quit IRC
4942019-06-25T23:03:06 *** nullptr| has quit IRC
4952019-06-25T23:03:15 *** pinheadmz has quit IRC
4962019-06-25T23:12:08 *** nullptr| has joined #bitcoin-core-dev
4972019-06-25T23:13:02 <luke-jr> bisect should only ever go inside a merge when it's related to the issue
4982019-06-25T23:15:09 *** nullptr| has quit IRC
4992019-06-25T23:15:51 *** nullptr| has joined #bitcoin-core-dev
5002019-06-25T23:32:28 <promag> achow101: fwiw I prefer green commits
5012019-06-25T23:34:50 *** Emcy has quit IRC
5022019-06-25T23:39:32 *** Emcy has joined #bitcoin-core-dev
5032019-06-25T23:41:01 <meshcollider> Squash them locally then ;)
5042019-06-25T23:47:01 <jb55> in general I think you should structure commits so that each one passes tests, obviously that's not always possible, but it's good practice